On Sun, Aug 18, 2013 at 10:54 PM, Paolo Bonzini wrote:
> Il 14/08/2013 02:34, liu ping fan ha scritto:
>> On Tue, Aug 13, 2013 at 10:53 PM, Paolo Bonzini wrote:
>>>
>>> Il 13/08/2013 07:43, Liu Ping Fan ha scritto:
After disabling the QemuClock, we should make sure that no QemuTimers
ar
On Fri, Aug 16, 2013 at 09:09:38PM +1000, Alexey Kardashevskiy wrote:
> spapr-pci config space accessors use find_dev() to find a PCI device.
> However find_dev() only searched on a primary bus and did not do
> recursive search through secondary buses so config space access was not
> possible for d
On 08/19/2013 01:22 AM, Paolo Bonzini wrote:
> Il 16/08/2013 11:49, Alexey Kardashevskiy ha scritto:
>> With KVM, we could fall back to the qemu implementation
>>> + * when KVM doesn't support them, but that would be much slower
>>> + * than just using the KVM implementations of the single
On Wed, Aug 07, 2013 at 06:51:32PM +1000, Alexey Kardashevskiy wrote:
> On PPC64 systems MSI Messages are translated to system IRQ in a PCI
> host bridge. This is already supported for emulated MSI/MSIX but
> not for irqfd where the current QEMU allocates IRQ numbers from
> irqchip and maps MSIMess
On 08/19/2013 05:35 PM, Michael S. Tsirkin wrote:
> On Wed, Aug 07, 2013 at 06:51:32PM +1000, Alexey Kardashevskiy wrote:
>> On PPC64 systems MSI Messages are translated to system IRQ in a PCI
>> host bridge. This is already supported for emulated MSI/MSIX but
>> not for irqfd where the current QEM
On Mon, Aug 19, 2013 at 05:44:04PM +1000, Alexey Kardashevskiy wrote:
> On 08/19/2013 05:35 PM, Michael S. Tsirkin wrote:
> > On Wed, Aug 07, 2013 at 06:51:32PM +1000, Alexey Kardashevskiy wrote:
> >> On PPC64 systems MSI Messages are translated to system IRQ in a PCI
> >> host bridge. This is alre
Am 19.08.2013 um 09:30 schrieb Alexey Kardashevskiy :
> On 08/19/2013 01:22 AM, Paolo Bonzini wrote:
>> Il 16/08/2013 11:49, Alexey Kardashevskiy ha scritto:
>>> With KVM, we could fall back to the qemu implementation
+ * when KVM doesn't support them, but that would be much slower
Bring it up to support discussion in
[PATCH 0/2 v4] kvm irqfd: support msimessage to irq translation in PHB
On 06/30/2013 12:28 AM, Anthony Liguori wrote:
> On Sat, Jun 29, 2013 at 8:45 AM, Alexey Kardashevskiy wrote:
>> On PPC64 systems MSI Messages are translated to system IRQ in a PCI
>> host
On 08/19/2013 05:54 PM, Michael S. Tsirkin wrote:
> On Mon, Aug 19, 2013 at 05:44:04PM +1000, Alexey Kardashevskiy wrote:
>> On 08/19/2013 05:35 PM, Michael S. Tsirkin wrote:
>>> On Wed, Aug 07, 2013 at 06:51:32PM +1000, Alexey Kardashevskiy wrote:
On PPC64 systems MSI Messages are translated
Any comments?
Regards,
On 08/02/2013 02:48 PM, Fabien Chouteau wrote:
> Signed-off-by: Fabien Chouteau
> ---
> monitor.c | 17 +
> 1 file changed, 17 insertions(+)
>
> diff --git a/monitor.c b/monitor.c
> index 5dc0aa9..78e93af 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@
Any comments?
Regards,
On 08/02/2013 02:48 PM, Fabien Chouteau wrote:
> Part of M731-018.
>
> Signed-off-by: Fabien Chouteau
> ---
> disas.c | 16
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/disas.c b/disas.c
> index 71007fb..3ffb3ae 100644
> --- a/d
On 09.08.2013 18:29, Daniel P. Berrange wrote:
> On Fri, Aug 09, 2013 at 10:58:55AM -0500, Anthony Liguori wrote:
>> Michal Privoznik writes:
>>
>>> [CC'ing qemu-devel list]
>>> On 09.08.2013 15:17, Daniel P. Berrange wrote:
On Fri, Aug 09, 2013 at 07:13:58AM -0600, Eric Blake wrote:
> On
On 19 August 2013 09:26, Fabien Chouteau wrote:
> Any comments?
>
> Regards,
>
> On 08/02/2013 02:48 PM, Fabien Chouteau wrote:
>> Signed-off-by: Fabien Chouteau
>> ---
>> monitor.c | 17 +
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/monitor.c b/monitor.c
>> index 5d
On 2 August 2013 13:48, Fabien Chouteau wrote:
> Part of M731-018.
What is this a reference to?
> Signed-off-by: Fabien Chouteau
> ---
> disas.c | 16
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/disas.c b/disas.c
> index 71007fb..3ffb3ae 100644
> ---
On 08/19/2013 06:01 PM, Alexander Graf wrote:
>
>
> Am 19.08.2013 um 09:30 schrieb Alexey Kardashevskiy :
>
>> On 08/19/2013 01:22 AM, Paolo Bonzini wrote:
>>> Il 16/08/2013 11:49, Alexey Kardashevskiy ha scritto:
With KVM, we could fall back to the qemu implementation
> + * when KV
On Mon, Aug 19, 2013 at 06:10:01PM +1000, Alexey Kardashevskiy wrote:
> On 08/19/2013 05:54 PM, Michael S. Tsirkin wrote:
> > On Mon, Aug 19, 2013 at 05:44:04PM +1000, Alexey Kardashevskiy wrote:
> >> On 08/19/2013 05:35 PM, Michael S. Tsirkin wrote:
> >>> On Wed, Aug 07, 2013 at 06:51:32PM +1000,
On 08/16/2013 11:15 PM, Alexander Graf wrote:
>
> On 07.08.2013, at 10:08, Alexey Kardashevskiy wrote:
>
>> Currently only single TCE entry per requiest is supported (H_PUT_TCE).
>> However PAPR+ specification allows multiple entry requests such as
>> H_PUT_TCE_INDIRECT and H_STUFFF_TCE. Having l
On Mon, Aug 19, 2013 at 10:29:10AM +0200, Michal Privoznik wrote:
> On 09.08.2013 18:29, Daniel P. Berrange wrote:
> > On Fri, Aug 09, 2013 at 10:58:55AM -0500, Anthony Liguori wrote:
> >> Michal Privoznik writes:
> >>
> >>> [CC'ing qemu-devel list]
> >>> On 09.08.2013 15:17, Daniel P. Berrange wr
Laszlo Ersek writes:
> On 08/16/13 13:13, arm...@redhat.com wrote:
>
>> static void pc_init_isa(QEMUMachineInitArgs *args)
>> {
>> -ram_addr_t ram_size = args->ram_size;
>> -const char *cpu_model = args->cpu_model;
>> -const char *kernel_filename = args->kernel_filename;
>> -con
Laszlo Ersek writes:
> comments below
>
> On 08/16/13 13:13, arm...@redhat.com wrote:
>> From: Markus Armbruster
>>
>> Don't explode QEMUMachineInitArgs before passing it to
>> sun4m_hw_init(), sun4uv_init().
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> hw/sparc/sun4m.c | 113
>>
Laszlo Ersek writes:
> comments below
>
> On 08/16/13 13:13, arm...@redhat.com wrote:
>> From: Markus Armbruster
>>
>> Pass on the generic arguments unadulterated, and the machine-specific
>> ones as separate argument.
>>
>> Signed-off-by: Markus Armbruster
>> Acked-by: Alexander Graf
>> ---
Il 18/08/2013 20:23, Liu, Jinsong ha scritto:
> From 1273f8b2e5464ec987facf9942fd3ccc0b69087e Mon Sep 17 00:00:00 2001
> From: Liu Jinsong
> Date: Mon, 19 Aug 2013 09:33:30 +0800
> Subject: [PATCH] qemu-kvm bugfix for IA32_FEATURE_CONTROL
>
> This patch is to fix the bug https://bugs.launchpad.ne
By the time that qemu 1.7 will be released, enough time will has passed
since qemu 1.1, which is the first version to understand version 3
images, that changing the default shouldn't hurt many people any more
and the benefits of using the new format outweigh the pain.
qemu-iotests already runs wit
Hi,all:
in func virtqueue_get_avail_bytes, when found a indirect desc, we need
loop over it.
/* loop over the indirect descriptor table */
indirect = 1;
max = vring_desc_len(desc_pa, i) / sizeof(VRingDesc);
num_bufs = i = 0;
desc_
Il 19/08/2013 04:18, Fam Zheng ha scritto:
> On Sun, 08/18 17:19, Paolo Bonzini wrote:
>> Il 13/08/2013 03:21, Fam Zheng ha scritto:
>>> VMDK3 header has the field l1dir_size, but vmdk_open_vmdk3 hardcoded the
>>> value. This patch honors the header field.
>>>
>>> And the L2 table size is 4096 acco
Il 19/08/2013 09:14, liu ping fan ha scritto:
>> > But does timerlists need a lock, or does the BQL suffice? If it
>> > doesn't, there is no need for events_list_lock either. Is
>> > qemu_clock_enable called outside the BQL?
>> >
> Currently, no such guarantee based on BQL. But if we enforce that
On 08/19/13 11:24, Markus Armbruster wrote:
> Laszlo Ersek writes:
>> Please always use
>>
>> -O/path/to/order_file
>>
>> when invoking git-format-patch.
>>
>> The contents of "order_file" should be minimally
>>
>> configure
>> Makefile*
>> *.json
>> *.h
>> *.c
>>
>> It's much easier
Andreas Färber writes:
> Am 16.08.2013 15:18, schrieb arm...@redhat.com:
>> From: Markus Armbruster
>>
>> I'd like to access QEMUMachine from a QEMUMachine init() method, which
>> is currently not possible. Instead of passing it as an argument, I
>> simply set current_machine earlier.
>
> We h
Il 19/08/2013 10:44, Alexey Kardashevskiy ha scritto:
>> > It means that if you use the same QEMU version with the same command
>> > line on a different kernel version, your guest looks different because
>> > we generate the dtb differently.
> Oh. Sorry for my ignorance again, I am not playing dump
Am 13.08.2013 um 03:21 hat Fam Zheng geschrieben:
> VMDK3 header has the field l1dir_size, but vmdk_open_vmdk3 hardcoded the
> value. This patch honors the header field.
>
> And the L2 table size is 4096 according to VMDK spec[1], instead of
> 1 << 9 (512).
>
> [1]:
> http://www.vmware.com/suppor
On 08/13/13 00:43, Michael S. Tsirkin wrote:
> Migration code assumes that each RAM block is a multiple of target page
> size.
Isn't that a valid assumption, considering the TARGET_PAGE_ALIGN() macro
call in qemu_ram_alloc_from_ptr() [exec.c]?
> We can fix this in a variety of ways, the simplest
Am 13.08.2013 um 03:21 hat Fam Zheng geschrieben:
> This header check is common to VMDK3 and VMDK4, so move it into
> vmdk_add_extent().
>
> Signed-off-by: Fam Zheng
Aha, so this is the fix for patch 1. If you reorder the patches so that
this one comes first, you don't have broken intermediate p
On 19.08.2013 11:06, Daniel P. Berrange wrote:
> On Mon, Aug 19, 2013 at 10:29:10AM +0200, Michal Privoznik wrote:
>> On 09.08.2013 18:29, Daniel P. Berrange wrote:
>>> On Fri, Aug 09, 2013 at 10:58:55AM -0500, Anthony Liguori wrote:
Michal Privoznik writes:
> [CC'ing qemu-devel list
Il 10/08/2013 13:21, Alex Bligh ha scritto:
> Currently we use a separate timer list group (main_loop_tlg)
> for the main loop. This patch replaces this with a dummy AioContext
> used just for timers in the main loop.
>
> Signed-off-by: Alex Bligh
I guess for now this complicates things more tha
On 19 August 2013 10:59, Laszlo Ersek wrote:
> On 08/13/13 00:43, Michael S. Tsirkin wrote:
>> Migration code assumes that each RAM block is a multiple of target page
>> size.
>
> Isn't that a valid assumption, considering the TARGET_PAGE_ALIGN() macro
> call in qemu_ram_alloc_from_ptr() [exec.c]?
usb-bt-dongle device can't be disabled as there's dependency in vl.c file. This
patch add preprocesor condition to be able to disable it.
Signed-off-by: Miroslav Rezanina
---
hw/usb/Makefile.objs | 1 -
vl.c | 18 ++
2 files changed, 14 insertions(+), 5 deletion
This series add support for VMFS and VMFSSPARSE extents, these types are found
in description file from ESX hosts.
- VMFS is in monolithiFlat format (raw), but hosted in ESX.
- VMFSSPARSE is the format we call "vmdk3" with magic bytes "COWD". This patch
fix the opening of vmdk3 and rename it
VMDK3 header has the field l1dir_size, but vmdk_open_vmdk3 hardcoded the
value. This patch honors the header field.
And the L2 table size is 4096 according to VMDK spec[1], instead of
1 << 9 (512).
[1]:
http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk
Signed-off-by: Fam
VMware ESX hosts use a variant of the VMDK3 format, identified by the
vmfsSparse create type ad the VMFSSPARSE extent type.
It has 16 KB grain tables (L2) and a variable-size grain directory (L1).
In addition, the grain size is always 512, but that is not a problem
because it is included in the he
This header check is common to VMDK3 and VMDK4, so move it into
vmdk_add_extent().
Signed-off-by: Fam Zheng
---
block/vmdk.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 346bb5c..f8c0a4e 100644
--- a/block/vmdk.c
+++ b/blo
From: Paolo Bonzini
VMware ESX hosts also use different create and extent types for flat
files, respectively "vmfs" and "VMFS". This is not documented, but it
can be found at http://kb.vmware.com/kb/10002511 (Recreating a missing
virtual machine disk (VMDK) descriptor file).
Signed-off-by: Paol
On Mon, Aug 19, 2013 at 11:59:25AM +0200, Laszlo Ersek wrote:
> On 08/13/13 00:43, Michael S. Tsirkin wrote:
> > Migration code assumes that each RAM block is a multiple of target page
> > size.
>
> Isn't that a valid assumption, considering the TARGET_PAGE_ALIGN() macro
> call in qemu_ram_alloc_f
On 08/19/13 12:21, Peter Maydell wrote:
> On 19 August 2013 10:59, Laszlo Ersek wrote:
>> On 08/13/13 00:43, Michael S. Tsirkin wrote:
>>> Migration code assumes that each RAM block is a multiple of target page
>>> size.
>>
>> Isn't that a valid assumption, considering the TARGET_PAGE_ALIGN() macr
On 08/13/13 00:43, Michael S. Tsirkin wrote:
> ROM files that are put in FW CFG are copied to guest ram, by BIOS, but
> they are not backed by RAM so they don't get migrated.
Can you please elaborate on this? Do you mean the 384 KB range between
640KB and 1MB that is covered by RAMBlock, but no Me
On Mon, Aug 19, 2013 at 01:06:07PM +0200, Laszlo Ersek wrote:
> On 08/13/13 00:43, Michael S. Tsirkin wrote:
> > ROM files that are put in FW CFG are copied to guest ram, by BIOS, but
> > they are not backed by RAM so they don't get migrated.
>
> Can you please elaborate on this? Do you mean the 3
I note some recent work on vmdk file support. Has anyone looked at
supporting vmdk streaming format as an /output/ file format (I
think we currently support it as an input format). This is what
you need to use to upload a VM to vCenter. Currently the route
is convert to raw then use:
https://git
Hi Anthony,
> > +if (resource == 4) {
>
> This ought to be a #define. There's no else here, is that expected?
> Should you return failure for a different resource?
Good point, I made it a define. We were returning H_P2 for a different
resource, but it was a bit of a twisted maze of return
On 08/19/13 13:06, Laszlo Ersek wrote:
> On 08/13/13 00:43, Michael S. Tsirkin wrote:
>> @@ -646,6 +669,7 @@ int rom_add_file(const char *file, const char *fw_dir,
>> if (rom->fw_file && fw_cfg) {
>> const char *basename;
>> char fw_file_name[56];
>> +void *data;
>>
On Mon, Aug 19, 2013 at 01:09:36PM +0200, Laszlo Ersek wrote:
> On 08/19/13 12:21, Peter Maydell wrote:
> > On 19 August 2013 10:59, Laszlo Ersek wrote:
> >> On 08/13/13 00:43, Michael S. Tsirkin wrote:
> >>> Migration code assumes that each RAM block is a multiple of target page
> >>> size.
> >>
On Mon, Aug 19, 2013 at 01:15:36PM +0200, Laszlo Ersek wrote:
> On 08/19/13 13:06, Laszlo Ersek wrote:
> > On 08/13/13 00:43, Michael S. Tsirkin wrote:
>
> >> @@ -646,6 +669,7 @@ int rom_add_file(const char *file, const char *fw_dir,
> >> if (rom->fw_file && fw_cfg) {
> >> const char
On Mon, 08/19 12:09, Alex Bligh wrote:
> I note some recent work on vmdk file support. Has anyone looked at
> supporting vmdk streaming format as an /output/ file format (I
> think we currently support it as an input format). This is what
> you need to use to upload a VM to vCenter. Currently the r
Il 16/08/2013 13:45, Stefan Hajnoczi ha scritto:
>> > +#define BUCKETS_COUNT 6
>> > +
>> > +typedef enum {
>> > +THROTTLE_BPS_TOTAL = 0,
>> > +THROTTLE_BPS_READ = 1,
>> > +THROTTLE_BPS_WRITE = 2,
>> > +THROTTLE_OPS_TOTAL = 3,
>> > +THROTTLE_OPS_READ = 4,
>> > +THROTTLE_OPS
On 08/19/13 13:18, Michael S. Tsirkin wrote:
> On Mon, Aug 19, 2013 at 01:09:36PM +0200, Laszlo Ersek wrote:
>> On 08/19/13 12:21, Peter Maydell wrote:
>>> On 19 August 2013 10:59, Laszlo Ersek wrote:
On 08/13/13 00:43, Michael S. Tsirkin wrote:
> Migration code assumes that each RAM bloc
On 08/13/13 00:43, Michael S. Tsirkin wrote:
> Changes from v2: address comments on v2 by Peter Maydell
> - switch from global constant to function
> - use memory_region_init_ram instead of _ram_ptr
> - disable for 1.6
>
> Changes from v1: address comments by Peter Maydell
> - drop
On 19 Aug 2013, at 12:23, Fam Zheng wrote:
> Yes, that would be something possible to do. Is it the only format to
> upload a VM to vCenter now, shouldn't normal VMDK be supported as well?
Ian puts it better than I can:
> This format is only useful if you are attempting to import virtual machin
On Sun, Aug 18, 2013 at 04:50:02PM +0300, Michael S. Tsirkin wrote:
> Make 1.4 compat code call the 1.6 one, reducing
> code duplication. Add comment explaining why we can't
> make 1.4 call 1.5 as usual.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> hw/i386/pc_piix.c | 4 ++--
> hw/i386/pc_q35.c
Il 14/08/2013 14:32, Jan Kiszka ha scritto:
> I still need to check more corner cases as timer dequeuing can now race
> with the handler execution, ie. a dequeued timer can still see one more
> handler run after timer_del returned. That's a property one can easily
> take into account when writing d
On Mon, Aug 19, 2013 at 02:36:14PM +0800, Asias He wrote:
> On Fri, Aug 16, 2013 at 10:41:36AM +0200, Stefan Hajnoczi wrote:
> > On Mon, Aug 5, 2013 at 10:11 AM, Asias He wrote:
> > A simple but ugly way to fix this is for block.c to also have a
> > ->zero_beyond_eof flag which enables the behavio
Il 12/08/2013 14:49, Stefan Hajnoczi ha scritto:
> Introduce QEMUTimerList->active_timers_lock to protect the linked list
> of active timers. This allows qemu_timer_mod_ns() to be called from any
> thread.
>
> Note that vm_clock is not thread-safe and its use of
> qemu_clock_has_timers() works fi
Il 15/08/2013 14:00, Stefan Hajnoczi ha scritto:
> The common case is that we only check the first timer in
> ->active_timers. Usually the first timer has not expired yet and we
> return; the lock was taken once only.
>
> I'm not sure it's worth complicating the case where we iterate multiple
> t
Hi,
This patch series implement support for dumping guest memory using qemu gdb
server.
Without this patch we would get.
(gdb) x/10 do_fork
0xc0098660 : Cannot access memory at address
0xc0098660
(gdb)
With this patch series we can now do
(gdb) target remote localhost
From: "Aneesh Kumar K.V"
Without this, a value of rb=0 and rs=0, results in replacing the 0th
index. This can be observed when using gdb remote debugging support.
(gdb) x/10i do_fork
0xc0085330 :Cannot access memory at address
0xc0085330
(gdb)
This is because when we
From: "Aneesh Kumar K.V"
With kvm enabled, we store the hash page table information in the hypervisor.
Use ioctl to read the htab contents. Without this we get the below error when
trying to read the guest address
(gdb) x/10 do_fork
0xc0098660 : Cannot access memory at address
0xc00
From: "Aneesh Kumar K.V"
Use SLB_ESID_V instead of (1 << 27) in the code
Signed-off-by: Aneesh Kumar K.V
---
target-ppc/mmu_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-ppc/mmu_helper.c b/target-ppc/mmu_helper.c
index 5dd4e05..9c9132e 100644
--- a/target-
Am 19.08.2013 12:48, schrieb Miroslav Rezanina:
> usb-bt-dongle device can't be disabled as there's dependency in vl.c file.
> This patch add preprocesor condition to be able to disable it.
Please limit to 76 chars per line (check `git log` output).
>
> Signed-off-by: Miroslav Rezanina
> ---
>
Am 19.08.2013 14:29, schrieb Aneesh Kumar K.V:
> From: "Aneesh Kumar K.V"
>
> Without this, a value of rb=0 and rs=0, results in replacing the 0th
"... rs=0 results in ..."
> index. This can be observed when using gdb remote debugging support.
>
> (gdb) x/10i do_fork
>0xc0085330 :
Am 19.08.2013 14:29, schrieb Aneesh Kumar K.V:
> From: "Aneesh Kumar K.V"
>
> Use SLB_ESID_V instead of (1 << 27) in the code
>
> Signed-off-by: Aneesh Kumar K.V
Reviewed-by: Andreas Färber
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer
Am 19.08.2013 14:42, schrieb Andreas Färber:
> Am 19.08.2013 14:29, schrieb Aneesh Kumar K.V:
>> From: "Aneesh Kumar K.V"
>>
>> Without this, a value of rb=0 and rs=0, results in replacing the 0th
>
> "... rs=0 results in ..."
>
>> index. This can be observed when using gdb remote debugging supp
Il 19/08/2013 12:48, Miroslav Rezanina ha scritto:
> usb-bt-dongle device can't be disabled as there's dependency in vl.c file.
> This patch add preprocesor condition to be able to disable it.
>
> Signed-off-by: Miroslav Rezanina
> ---
> hw/usb/Makefile.objs | 1 -
> vl.c | 18
Am 19.08.2013 14:29, schrieb Aneesh Kumar K.V:
> From: "Aneesh Kumar K.V"
>
> With kvm enabled, we store the hash page table information in the hypervisor.
> Use ioctl to read the htab contents. Without this we get the below error when
> trying to read the guest address
>
> (gdb) x/10 do_fork
>
On Mon, Aug 19, 2013 at 11:25:33AM +0200, Kevin Wolf wrote:
> By the time that qemu 1.7 will be released, enough time will has passed
s/has/have/
> since qemu 1.1, which is the first version to understand version 3
> images, that changing the default shouldn't hurt many people any more
> and the
On Fri, Aug 16, 2013 at 04:37:28PM +0100, Alex Bligh wrote:
> Stefan,
>
> On 16 Aug 2013, at 16:24, Stefan Hajnoczi wrote:
>
> > Please run qemu-iotests on this series and fix any failures. It is
> > failing with "I/O thread has spun for 1000 iterations".
>
> It does that without my patch. Belo
Hi Aneesh,
Am 19.08.2013 14:29, schrieb Aneesh Kumar K.V:
> This patch series implement support for dumping guest memory using qemu gdb
> server.
I had a quick look through but will leave in-depth review to Alex or
Anthony.
Do you plan to implement dumping guest memory via QMP, too?
Cheers,
An
Il 15/08/2013 08:02, Alexey Kardashevskiy ha scritto:
> On 08/13/2013 08:07 AM, Alex Williamson wrote:
>>> +static void vfio_listener_region_add(MemoryListener *listener,
>>> + MemoryRegionSection *section)
>>> +{
>>> +VFIOContainer *container = container_of(
Il 13/08/2013 00:07, Alex Williamson ha scritto:
>> > +if (pci_iommu_as(pdev) != &address_space_memory) {
>> > +error_report("vfio: DMA address space must be system memory");
>> > +return -ENXIO;
> -EFAULT? It's a bad address of sorts.
>
Accessing it would SIGSEGV, so it is n
Il 13/08/2013 16:54, Jan Kiszka ha scritto:
>> > Using an AioContext lock for timers is somewhat complicated for lock
>> > ordering, because context A could try to modify a timer from context B,
>> > at the same time when context B is modifying a timer from context A.
>> > This would cause a deadlo
On Fri, 16 Aug 2013 14:21:50 +0100
Peter Maydell wrote:
> On 16 August 2013 08:59, Erik Rull wrote:
> > Hi all,
> >
> > when using the released qemu-1.6.0.tar.bz2, I get the following error
> > message:
> > File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164
> > except QAPISchemaError
On 08/19/13 14:31, Andreas Färber wrote:
> Am 19.08.2013 12:48, schrieb Miroslav Rezanina:
>> usb-bt-dongle device can't be disabled as there's dependency in vl.c file.
>> This patch add preprocesor condition to be able to disable it.
>
> Please limit to 76 chars per line (check `git log` output)
On Sat, Aug 17, 2013 at 10:52:34AM +0530, Bharata B Rao wrote:
> > From: Stefan Hajnoczi
> > Since .io_flush() is no longer called we do not need
> > qemu_gluster_aio_flush_cb() anymore. It turns out that qemu_aio_count
> > is unused now and can be dropped.
> >
> > Signed-off-by: Stefan Hajnoczi
On Fri, Aug 16, 2013 at 05:47:06PM +0200, Stefan Hajnoczi wrote:
> fatal: Needed a single revision
> The following changes since commit f202039811d8746b0586d2fd5f61de6c8cf68056:
>
> Open up 1.7 development branch (2013-08-15 15:41:13 -0500)
>
> are available in the git repository at:
>
> git
On 2013-08-19 15:21, Paolo Bonzini wrote:
> Il 13/08/2013 16:54, Jan Kiszka ha scritto:
Using an AioContext lock for timers is somewhat complicated for lock
ordering, because context A could try to modify a timer from context B,
at the same time when context B is modifying a timer fr
Am 19.08.2013 15:30, schrieb Laszlo Ersek:
> On 08/19/13 14:31, Andreas Färber wrote:
>> Am 19.08.2013 12:48, schrieb Miroslav Rezanina:
>>> usb-bt-dongle device can't be disabled as there's dependency in vl.c file.
>>> This patch add preprocesor condition to be able to disable it.
>>
>> Please li
Am 16.08.2013 15:21, schrieb Peter Maydell:
> On 16 August 2013 08:59, Erik Rull wrote:
>> Hi all,
>>
>> when using the released qemu-1.6.0.tar.bz2, I get the following error
>> message:
>> File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164
>> except QAPISchemaError as e:
>>
My IBM email address will be unaccessible after August 23rd, 2013.
Signed-off-by: Anthony Liguori
---
.mailmap| 2 +-
MAINTAINERS | 14 +++---
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/.mailmap b/.mailmap
index 9797802..7b91a95 100644
--- a/.mailmap
+++ b/.mailm
Am 19.08.2013 07:55, schrieb Alexey Kardashevskiy:
> The upcoming support of in-kernel XICS will redefine migration callbacks
> for both ICS and ICP so classes and callback pointers are added.
>
> This adds a cpu_setup callback to the XICS device class (as XICS-KVM
> will do it different) and xics
On 19 Aug 2013, at 14:21, Paolo Bonzini wrote:
> I like Stefan's patches to make the timer list thread-safe, especially
> if we can optimize it (with RCU?) to make the read side lockless.
We will have to be careful on the write side. I'm trying to
work out just how slow this would with Paolo's R
Il 19/08/2013 15:41, Andreas Färber ha scritto:
> By my reading of `git grep CONFIG_USB_BLUETOOTH` it isn't disappearing,
> check default-configs/usb.mak. All targets that include usb.mak will
> have CONFIG_USB_BLUETOOTH.
>
> It's only used in the build system and with this patch in vl.c, so
> ass
Hi,
I've decided to take an opportunity outside of IBM which means that my
IBM email address will no longer work after this friday (August 23rd).
Please start CC'ing my anth...@codemonkey.ws address on all patches and
pull requests.
I'm excited about my new opportunity but I am going to wait unti
On 08/19/2013 10:33 AM, Peter Maydell wrote:
> On 2 August 2013 13:48, Fabien Chouteau wrote:
>> Part of M731-018.
>
> What is this a reference to?
>
I'm sorry this is not supposed to be here. Do you have comments before I
resend the patch?
Regards,
--
Fabien Chouteau
Il 19/08/2013 15:40, Jan Kiszka ha scritto:
> On 2013-08-19 15:21, Paolo Bonzini wrote:
>> Il 13/08/2013 16:54, Jan Kiszka ha scritto:
> Using an AioContext lock for timers is somewhat complicated for lock
> ordering, because context A could try to modify a timer from context B,
> at th
Am 02.08.2013 14:48, schrieb Fabien Chouteau:
> Part of M731-018.
>
> Signed-off-by: Fabien Chouteau
> ---
> disas.c | 16
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/disas.c b/disas.c
> index 71007fb..3ffb3ae 100644
> --- a/disas.c
> +++ b/disas.c
> @
Since .io_flush() is no longer called we do not need
qemu_gluster_aio_flush_cb() anymore. It turns out that qemu_aio_count
is unused now and can be dropped.
Thanks to Bharata B Rao for catching a
build failure with CONFIG_GLUSTERFS_DISCARD, which has been fixed.
Signed-off-by: Stefan Hajnoczi
.io_flush() is no longer called so drop curl_aio_flush(). The acb[]
array that the function checks is still used in other parts of
block/curl.c. Therefore we cannot remove acb[], it is needed.
Signed-off-by: Stefan Hajnoczi
---
block/curl.c | 22 +++---
1 file changed, 3 insert
.io_flush() is no longer called so drop qemu_rbd_aio_flush_cb().
qemu_aio_count is unused now so drop it too.
Signed-off-by: Stefan Hajnoczi
---
block/rbd.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index cb71751..71b4a0c 100644
Check exit conditions before entering blocking aio_poll(). This is
mainly for consistency since it's unlikely that we are stopping in the
first event loop iteration.
Signed-off-by: Stefan Hajnoczi
---
hw/block/dataplane/virtio-blk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
dif
aio_poll(ctx, true) will soon block when fd handlers have been set.
Previously aio_poll() would return early if all .io_flush() returned
false. This means we need to check the equivalent of the .io_flush()
condition *before* calling aio_poll(ctx, true) to avoid deadlock.
Reviewed-by: Paolo Bonzin
aio_poll(ctx, true) will soon block if any fd handlers have been set.
Previously it would only block when .io_flush() returned true.
This means that callers must check their wait condition *before*
aio_poll() to avoid deadlock.
Reviewed-by: Paolo Bonzini
Signed-off-by: Stefan Hajnoczi
---
test
In bdrv_delete() make sure to call bdrv_make_anon() *after* bdrv_close()
so that the device is still seen by bdrv_drain_all() when iterating
bdrv_states.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Stefan Hajnoczi
---
block.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/
On Mon, Aug 19, 2013 at 04:02:10PM +0300, Michael S. Tsirkin wrote:
> On Mon, Aug 19, 2013 at 09:04:28AM -0300, Eduardo Habkost wrote:
> > On Sun, Aug 18, 2013 at 04:50:02PM +0300, Michael S. Tsirkin wrote:
> > > Make 1.4 compat code call the 1.6 one, reducing
> > > code duplication. Add comment ex
Drop the io_flush argument to aio_set_event_notifier().
Reviewed-by: Paolo Bonzini
Signed-off-by: Stefan Hajnoczi
---
tests/test-aio.c | 22 --
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/tests/test-aio.c b/tests/test-aio.c
index 1251952..7b2892a 100644
--
1 - 100 of 205 matches
Mail list logo