Re: [Qemu-devel] [RFC] [PATCHv8 09/30] aio / timers: Add QEMUTimerListGroup and helper functions

2013-08-12 Thread Alex Bligh
--On 12 August 2013 14:53:06 +0800 Wenchao Xia wrote: 1. Wrap TimerListGroup into a separate struct, leave all the TimerListGroup functions in. This probably makes it easier if (for instance) we decided to get rid of AioContexts entirely and make them g_source subclasses (per We

[Qemu-devel] [PATCHv2] add qemu-img convert -C option (skip target volume creation)

2013-08-12 Thread Alex Bligh
Add a -C option to skip volume creation on qemu-img convert. This is useful for targets such as rbd / ceph, where the target volume may already exist; we cannot always rely on qemu-img convert to create the image, as dependent on the output format, there may be parameters which are not possible to

Re: [Qemu-devel] [PATCH] add qemu-img convert -C option (skip target volume creation)

2013-08-12 Thread Alex Bligh
On 12 Aug 2013, at 07:22, Fam Zheng wrote: >> --- a/qemu-img.c >> +++ b/qemu-img.c >> @@ -103,6 +103,7 @@ static void help(void) >>" '-S' indicates the consecutive number of bytes that must >> contain only zeros\n" >>" for qemu-img to create a sparse image during co

Re: [Qemu-devel] [RFC] Convert AioContext to Gsource sub classes

2013-08-12 Thread Paolo Bonzini
> 1) rename AioContext to AioSource. > This is my major purpose, which declare it is not a "context" concept, > and GMainContext is the entity represent the thread's activity. Note that the nested event loops in QEMU are _very_ different from glib nested event loops. In QEMU, nested event loop

Re: [Qemu-devel] [PATCH 1/2] vmdk: support vmfsSparse files

2013-08-12 Thread Paolo Bonzini
- Original Message - > From: "Fam Zheng" > To: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, kw...@redhat.com > Sent: Monday, August 12, 2013 3:31:44 AM > Subject: Re: [PATCH 1/2] vmdk: support vmfsSparse files > > On Sun, 08/11 18:13, Paolo Bonzini wrote: > > VMware ESX hosts use a var

Re: [Qemu-devel] [SeaBIOS] [PATCH] acpi: hide 64-bit PCI hole for Windows XP

2013-08-12 Thread Michael S. Tsirkin
On Mon, Aug 12, 2013 at 08:37:00AM +0200, Gerd Hoffmann wrote: > Hi, > > > If we make it a rule that PCI is`setup before ACPI tables > > are read, then QEMU can do the patching itself when > > it detects BIOS reading the tables. > > Approach makes sense to me. The ordering constrain shouldn't

[Qemu-devel] [PATCH 0/8] virtio for endian curious guests Take #2

2013-08-12 Thread Rusty Russell
The driver parts (patches 3-8) are unchanged, so didn't repost. 1) Rebased onto more recent git tree. 2) New stub is virtio_get_byteswap() 3) PPC64 uses endianness of first CPU interrupt vectors, not CPU endiannes. Hope this one is closer... Rusty. Rusty Russell (8): virtio_get_byteswap: funct

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-12 Thread Rusty Russell
Peter Maydell writes: > On 9 August 2013 08:35, Rusty Russell wrote: >> That's a lot of replumbing and indirect function calls for a fairly >> obscure case. We certainly don't have a nice CPUState lying around in >> virtio at the moment, for example. > > Actually if you're in an IO routine you d

[Qemu-devel] [PATCH 3/8] virtio: allow byte swapping for vring and config access

2013-08-12 Thread Rusty Russell
This is based on a simpler patch by Anthony Liguouri, which only handled the vring accesses. We also need some drivers to access these helpers, eg. for data which contains headers. Signed-off-by: Rusty Russell --- hw/virtio/virtio.c | 29 +++-- 1 file changed, 15 inserti

[Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2013-08-12 Thread Rusty Russell
virtio data structures are defined as "target endian", which assumes that's a fixed value. In fact, that actually means it's platform-specific. Hopefully the OASIS virtio 1.0 spec will fix this. Meanwhile, create a hook for little endian ppc. Signed-off-by: Rusty Russell --- include/hw/virtio

[Qemu-devel] [PATCH 2/8] target-ppc: ppc64 target's virtio can be either endian.

2013-08-12 Thread Rusty Russell
We base it on the OS endian, as reflected by the endianness of the interrupt vectors. Suggested-by: Benjamin Herrenschmidt Signed-off-by: Rusty Russell --- target-ppc/misc_helper.c | 9 + 1 file changed, 9 insertions(+) diff --git a/target-ppc/misc_helper.c b/target-ppc/misc_helper.c i

[Qemu-devel] seabios 1.7.3.1 released

2013-08-12 Thread Gerd Hoffmann
Hi, The seabios 1.7.3.1 bugfix release is out of the door. Here is the shortlog: Kevin O'Connor (2): Fix USB EHCI detection that was broken in hlist conversion of PCIDevices. Fix bug in CBFS file walking with compressed files. Michael S. Tsirkin (1): acpi: sync FADT flags fro

[Qemu-devel] [PATCH for-1.6 0/1] seabios: update to 1.7.3.1 bugfix release

2013-08-12 Thread Gerd Hoffmann
Hi, seabios 1.7.3.1 has been released with a few bugfixes, here comes the update for qemu. please pull, Gerd The following changes since commit 2e985fe000e73097e325e18b943e8babfa96c35c: mips: revert commit b332d24a8e1290954029814d09156b06ede358e2 (2013-08-08 23:06:15 +0200) are availabl

[Qemu-devel] [PATCH 1/1] seabios: update to 1.7.3.1 bugfix release

2013-08-12 Thread Gerd Hoffmann
shortlog from 1.7.3: Kevin O'Connor (2): Fix USB EHCI detection that was broken in hlist conversion of PCIDevices. Fix bug in CBFS file walking with compressed files. Michael S. Tsirkin (1): acpi: sync FADT flags from PIIX4 to Q35 Signed-off-by: Gerd Hoffmann --- pc-bios/bios

Re: [Qemu-devel] [PATCH 1/2] vmdk: support vmfsSparse files

2013-08-12 Thread Andreas Färber
Am 11.08.2013 18:13, schrieb Paolo Bonzini: > VMware ESX hosts use a variant of the VMDK3 format, identified by the > vmfsSparse create type ad the VMFSSPARSE extent type. "and"? > It has 16 KB grain tables (L2) and a variable-size grain directory (L1). > In addition, the grain size is always 512

[Qemu-devel] [PATCH for-1.6 1/2] memory: export target page size

2013-08-12 Thread Michael S. Tsirkin
Add symbol to make it possible to use target page size in target-independent code. Signed-off-by: Michael S. Tsirkin --- exec.c| 2 ++ include/exec/memory.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/exec.c b/exec.c index 3ca9381..965076e 100644 --- a/exec.c +++ b/exe

[Qemu-devel] [PATCH for-1.6 0/2] future proof rom loading for cross versiom migration

2013-08-12 Thread Michael S. Tsirkin
ROM files that are put in FW CFG are copied to guest ram, by BIOS, but they are not backed by RAM so they don't get migrated. Each time we'll change at least two bytes in such a ROM this will break cross-version migration: since we can migrate after BIOS has read the first byte but before it has r

Re: [Qemu-devel] [PATCH] gdb: Fix gdb error

2013-08-12 Thread Andreas Färber
Hi Aneesh, Am 11.08.2013 20:14, schrieb Aneesh Kumar K.V: > From: "Aneesh Kumar K.V" > > Don't update the global register count if not requested. > Without this patch a remote gdb session gives > > (gdb) target remote localhost:1234 > Remote debugging using localhost:1234 > Remote 'g' packet re

[Qemu-devel] [PATCH for-1.6 2/2] loader: put FW CFG ROM files into RAM

2013-08-12 Thread Michael S. Tsirkin
ROM files that are put in FW CFG are copied to guest ram, by BIOS, but they are not backed by RAM so they don't get migrated. Each time we change two bytes in such a ROM this breaks cross-version migration: since we can migrate after BIOS has read the first byte but before it has read the second o

Re: [Qemu-devel] [PATCH for-1.6 v2 1/2] i82801b11: Fix i82801b11 PCI host bridge config space

2013-08-12 Thread Gerd Hoffmann
On 08/05/13 16:36, Andreas Färber wrote: > From: Gerd Hoffmann > > pci_bridge_write_config() was not being used. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Gerd Hoffmann > Signed-off-by: Andreas Färber Ping? I see it's not yet in master, can we *please* get this in? It is save to take j

Re: [Qemu-devel] [PATCH for-1.6 v2 1/2] i82801b11: Fix i82801b11 PCI host bridge config space

2013-08-12 Thread Andreas Färber
Am 12.08.2013 10:51, schrieb Gerd Hoffmann: > On 08/05/13 16:36, Andreas Färber wrote: >> From: Gerd Hoffmann >> >> pci_bridge_write_config() was not being used. >> >> Cc: qemu-sta...@nongnu.org >> Signed-off-by: Gerd Hoffmann >> Signed-off-by: Andreas Färber > > Ping? I see it's not yet in ma

Re: [Qemu-devel] [PATCH v3] pci: Introduce helper to retrieve a PCI device's DMA address space

2013-08-12 Thread Michael S. Tsirkin
On Mon, Aug 12, 2013 at 12:36:57AM +1000, Alexey Kardashevskiy wrote: > On 08/11/2013 11:58 PM, Michael S. Tsirkin wrote: > > On Sat, Aug 10, 2013 at 01:09:08AM +1000, Alexey Kardashevskiy wrote: > >> A PCI device's DMA address space (possibly an IOMMU) is returned by a > >> method on the PCIBus.

Re: [Qemu-devel] [PATCHv2] add qemu-img convert -C option (skip target volume creation)

2013-08-12 Thread Fam Zheng
On Mon, 08/12 08:09, Alex Bligh wrote: > Add a -C option to skip volume creation on qemu-img convert. > This is useful for targets such as rbd / ceph, where the > target volume may already exist; we cannot always rely on > qemu-img convert to create the image, as dependent on the > output format, t

[Qemu-devel] [PATCH for-1.6] virtio: clear signalled_used_valid when switching from dataplane

2013-08-12 Thread Stefan Hajnoczi
When the dataplane thread stops, its vring.c implementation synchronizes vring state back to virtio.c so we can continue emulating the virtio device. This patch ensures that virtio.c's signalled_used_valid flag is reset so that we do not suppress guest notifications due to stale signalled_used val

Re: [Qemu-devel] [PATCH 1/2] vmdk: support vmfsSparse files

2013-08-12 Thread Fam Zheng
On Mon, 08/12 03:40, Paolo Bonzini wrote: > > > - Original Message - > > From: "Fam Zheng" > > To: "Paolo Bonzini" > > Cc: qemu-devel@nongnu.org, kw...@redhat.com > > Sent: Monday, August 12, 2013 3:31:44 AM > > Subject: Re: [PATCH 1/2] vmdk: support vmfsSparse files > > > > On Sun, 08

Re: [Qemu-devel] [PATCH for-1.6] virtio: clear signalled_used_valid when switching from dataplane

2013-08-12 Thread Michael S. Tsirkin
On Mon, Aug 12, 2013 at 11:08:09AM +0200, Stefan Hajnoczi wrote: > When the dataplane thread stops, its vring.c implementation synchronizes > vring state back to virtio.c so we can continue emulating the virtio > device. > > This patch ensures that virtio.c's signalled_used_valid flag is reset so

Re: [Qemu-devel] [PATCH for-1.6 1/2] memory: export target page size

2013-08-12 Thread Peter Maydell
On 12 August 2013 09:49, Michael S. Tsirkin wrote: > Add symbol to make it possible to use target page size > in target-independent code. Given that TARGET_PAGE_SIZE is "smallest page size the TCG implementation currently supports for this core" (ie it is a TCG internal implementation detail as m

Re: [Qemu-devel] [PATCH] gdb: Fix gdb error

2013-08-12 Thread Aneesh Kumar K.V
Andreas Färber writes: > Hi Aneesh, > > Am 11.08.2013 20:14, schrieb Aneesh Kumar K.V: >> From: "Aneesh Kumar K.V" >> >> Don't update the global register count if not requested. >> Without this patch a remote gdb session gives >> >> (gdb) target remote localhost:1234 >> Remote debugging using

Re: [Qemu-devel] [PATCH for-1.6 1/2] memory: export target page size

2013-08-12 Thread Michael S. Tsirkin
On Mon, Aug 12, 2013 at 10:17:46AM +0100, Peter Maydell wrote: > On 12 August 2013 09:49, Michael S. Tsirkin wrote: > > Add symbol to make it possible to use target page size > > in target-independent code. > > Given that TARGET_PAGE_SIZE is "smallest page size the > TCG implementation currently

[Qemu-devel] [PATCH for-1.6] vhost: clear signalled_used_valid on vhost stop

2013-08-12 Thread Michael S. Tsirkin
When vhost device stops, its implementation synchronizes kernel state back to virtio.c so we can continue emulating the device in userspace. This patch ensures that virtio.c's signalled_used_valid flag is reset so that userspace does not suppress guest notifications due to stale signalled_used val

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2013-08-12 Thread Benjamin Herrenschmidt
On Mon, 2013-08-12 at 17:29 +0930, Rusty Russell wrote: > virtio data structures are defined as "target endian", which assumes > that's a fixed value. In fact, that actually means it's > platform-specific. > > Hopefully the OASIS virtio 1.0 spec will fix this. Meanwhile, create > a hook for litt

Re: [Qemu-devel] [PATCH for-1.6 2/2] loader: put FW CFG ROM files into RAM

2013-08-12 Thread Peter Maydell
On 12 August 2013 09:49, Michael S. Tsirkin wrote: > +static void *rom_set_mr(Rom *rom, Object *owner, const char *name) > +{ > +/* > + * Migration code expects that all RAM blocks are full target pages. > + * Round MR size up to make this work. > + */ > +unsigned size = ROUND_

Re: [Qemu-devel] [PATCHv2] add qemu-img convert -C option (skip target volume creation)

2013-08-12 Thread Alex Bligh
On 12 Aug 2013, at 10:03, Fam Zheng wrote: >> + " prior to running qemu-img)\n" > > Parenthesis not balanced. Otherwise, > > Reviewed-by: Fam Zheng Fixed in PATCHv3, just sent. -- Alex Bligh

[Qemu-devel] [PATCHv3] add qemu-img convert -C option (skip target volume creation)

2013-08-12 Thread Alex Bligh
Add a -C option to skip volume creation on qemu-img convert. This is useful for targets such as rbd / ceph, where the target volume may already exist; we cannot always rely on qemu-img convert to create the image, as dependent on the output format, there may be parameters which are not possible to

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2013-08-12 Thread Benjamin Herrenschmidt
On Mon, 2013-08-12 at 10:39 +0100, Peter Maydell wrote: > On 12 August 2013 10:28, Benjamin Herrenschmidt > wrote: > > We have explicit knowledge of when our endianness change (we get the > > hcall or a write to some SPR), we can call virtio *then* to adjust the > > endianness rather than having a

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2013-08-12 Thread Peter Maydell
On 12 August 2013 10:28, Benjamin Herrenschmidt wrote: > We have explicit knowledge of when our endianness change (we get the > hcall or a write to some SPR), we can call virtio *then* to adjust the > endianness rather than having a call-out to the platform on every > access. ARM doesn't -- I wou

Re: [Qemu-devel] [PATCHv3] add qemu-img convert -C option (skip target volume creation)

2013-08-12 Thread Alex Bligh
--On 12 August 2013 10:42:05 +0100 Alex Bligh wrote: Add a -C option to skip volume creation on qemu-img convert. This is useful for targets such as rbd / ceph, where the target volume may already exist; we cannot always rely on qemu-img convert to create the image, as dependent on the output

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2013-08-12 Thread Peter Maydell
On 12 August 2013 10:43, Benjamin Herrenschmidt wrote: > On Mon, 2013-08-12 at 10:39 +0100, Peter Maydell wrote: >> ARM doesn't -- I wouldn't expect changing the endianness of >> exceptions via writing to the SCTLR to trap to the hypervisor >> (and in any case it certainly won't result in a return

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2013-08-12 Thread Benjamin Herrenschmidt
On Mon, 2013-08-12 at 10:45 +0100, Peter Maydell wrote: > On 12 August 2013 10:43, Benjamin Herrenschmidt > wrote: > > On Mon, 2013-08-12 at 10:39 +0100, Peter Maydell wrote: > >> ARM doesn't -- I wouldn't expect changing the endianness of > >> exceptions via writing to the SCTLR to trap to the hy

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2013-08-12 Thread Peter Maydell
On 12 August 2013 10:50, Benjamin Herrenschmidt wrote: > I must be confused ... you mentioned in a previous discussion around > endianness that on some ARM cores at least, when changing the OS > endianness, you had to configure a different lane swapping in the bridge > to the the IO devices (AXI ?

Re: [Qemu-devel] [PATCH for-1.6] virtio: clear signalled_used_valid when switching from dataplane

2013-08-12 Thread Kevin Wolf
Am 12.08.2013 um 11:08 hat Stefan Hajnoczi geschrieben: > When the dataplane thread stops, its vring.c implementation synchronizes > vring state back to virtio.c so we can continue emulating the virtio > device. > > This patch ensures that virtio.c's signalled_used_valid flag is reset so > that we

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2013-08-12 Thread Benjamin Herrenschmidt
On Mon, 2013-08-12 at 10:52 +0100, Peter Maydell wrote: > On 12 August 2013 10:50, Benjamin Herrenschmidt > wrote: > > I must be confused ... you mentioned in a previous discussion around > > endianness that on some ARM cores at least, when changing the OS > > endianness, you had to configure a di

Re: [Qemu-devel] [PATCHv3] add qemu-img convert -C option (skip target volume creation)

2013-08-12 Thread Kevin Wolf
Am 12.08.2013 um 11:44 hat Alex Bligh geschrieben: > > > --On 12 August 2013 10:42:05 +0100 Alex Bligh wrote: > > >Add a -C option to skip volume creation on qemu-img convert. > >This is useful for targets such as rbd / ceph, where the > >target volume may already exist; we cannot always rely o

Re: [Qemu-devel] Are there plans to achieve ram live Snapshot feature?

2013-08-12 Thread Stefan Hajnoczi
On Fri, Aug 09, 2013 at 10:20:49AM +, Chijianchun wrote: > Now in KVM, when RAM snapshot, vcpus needs stopped, it is Unfriendly > restrictions to users. > > Are there plans to achieve ram live Snapshot feature? > > in my mind, Snapshots can not occupy additional too much memory, So when the

Re: [Qemu-devel] [PATCH for-1.6 2/2] loader: put FW CFG ROM files into RAM

2013-08-12 Thread Michael S. Tsirkin
On Mon, Aug 12, 2013 at 10:32:40AM +0100, Peter Maydell wrote: > On 12 August 2013 09:49, Michael S. Tsirkin wrote: > > +static void *rom_set_mr(Rom *rom, Object *owner, const char *name) > > +{ > > +/* > > + * Migration code expects that all RAM blocks are full target pages. > > + * R

Re: [Qemu-devel] [PATCHv3] add qemu-img convert -C option (skip target volume creation)

2013-08-12 Thread Alex Bligh
On 12 Aug 2013, at 10:58, Kevin Wolf wrote: > Stefan's decision, but considering that the very last release candidate > is planned for today, Ouch - I didn't realise we were that close. Point taken. I should have gotten around to tidying up months ago. FWIW save for the whitespace changes, I've

Re: [Qemu-devel] Are there plans to achieve ram live Snapshot feature?

2013-08-12 Thread Alex Bligh
--On 12 August 2013 11:59:03 +0200 Stefan Hajnoczi wrote: The idea that was discussed on qemu-devel@nongnu.org uses fork(2) to capture the state of guest RAM and then send it back to the parent process. The guest is only paused for a brief instant during fork(2) and can continue to run aft

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2013-08-12 Thread Peter Maydell
On 12 August 2013 10:56, Benjamin Herrenschmidt wrote: > On Mon, 2013-08-12 at 10:52 +0100, Peter Maydell wrote: >> On 12 August 2013 10:50, Benjamin Herrenschmidt >> wrote: >> > I must be confused ... you mentioned in a previous discussion around >> > endianness that on some ARM cores at least,

[Qemu-devel] [PULL 1/2] hw/virtio/virtio: Don't allow guests to add/remove queues

2013-08-12 Thread Peter Maydell
A queue size of 0 is used to indicate a nonexistent queue, so don't allow the guest to flip a queue between zero-size and non-zero-size. Don't permit setting of negative queue sizes either. Signed-off-by: Peter Maydell Message-id: 1374853288-9912-2-git-send-email-peter.mayd...@linaro.org Reviewed

[Qemu-devel] [PULL for-1.6 0/2] arm-devs queue

2013-08-12 Thread Peter Maydell
(2013-08-08 23:06:15 +0200) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-arm-devs-20130812 for you to fetch changes up to f7b803b377f74f7e109559e8e64f04c4c1fcd86b: hw/virtio/virtio-mmio: Make QueueNumMax read 0 for unavailable queues

[Qemu-devel] [PULL 2/2] hw/virtio/virtio-mmio: Make QueueNumMax read 0 for unavailable queues

2013-08-12 Thread Peter Maydell
The virtio-mmio spec says that QueueNumMax must read zero for queues which are unavailable; implement this, rather than always returning VIRTQUEUE_MAX_SIZE. Signed-off-by: Peter Maydell Message-id: 1374853288-9912-3-git-send-email-peter.mayd...@linaro.org Reviewed-by: Michael S. Tsirkin --- hw/

Re: [Qemu-devel] [PATCHv3] add qemu-img convert -C option (skip target volume creation)

2013-08-12 Thread Andreas Färber
Am 12.08.2013 11:42, schrieb Alex Bligh: > Add a -C option to skip volume creation on qemu-img convert. > This is useful for targets such as rbd / ceph, where the > target volume may already exist; we cannot always rely on > qemu-img convert to create the image, as dependent on the > output format,

Re: [Qemu-devel] [PATCHv3] add qemu-img convert -C option (skip target volume creation)

2013-08-12 Thread Alex Bligh
--On 12 August 2013 13:11:54 +0200 Andreas Färber wrote: The way git-commit works, any committer's Signed-off-by will be placed directly under the documentation chunk, but it's supposed to cover the whole commit/patch, not just some aspect of it. Since as you write, the code is his, the patc

Re: [Qemu-devel] [PATCH 1/2] vmdk: support vmfsSparse files

2013-08-12 Thread Stefan Hajnoczi
On Sun, Aug 11, 2013 at 06:13:57PM +0200, Paolo Bonzini wrote: > @@ -505,6 +505,34 @@ static int vmdk_open_vmdk3(BlockDriverState *bs, > return ret; > } > > +static int vmdk_open_vmfs_sparse(BlockDriverState *bs, > + BlockDriverState *file, > +

Re: [Qemu-devel] Are there plans to achieve ram live Snapshot feature?

2013-08-12 Thread Stefan Hajnoczi
On Mon, Aug 12, 2013 at 12:26 PM, Alex Bligh wrote: > --On 12 August 2013 11:59:03 +0200 Stefan Hajnoczi > wrote: > >> The idea that was discussed on qemu-devel@nongnu.org uses fork(2) to >> capture the state of guest RAM and then send it back to the parent >> process. The guest is only paused f

[Qemu-devel] [PATCHv4] add qemu-img convert -C option (skip target volume creation)

2013-08-12 Thread Alex Bligh
From: Alexandre Derumier Add a -C option to skip volume creation on qemu-img convert. This is useful for targets such as rbd / ceph, where the target volume may already exist; we cannot always rely on qemu-img convert to create the image, as dependent on the output format, there may be parameters

Re: [Qemu-devel] [PATCHv3] add qemu-img convert -C option (skip target volume creation)

2013-08-12 Thread Alex Bligh
On 12 Aug 2013, at 12:11, Andreas Färber wrote: > Since as you write, the code is his, the patch should have his From, his > Signed-off-by and finally your Signed-off-by. You can detail your > changes in [AB: ...] or similar between the Signed-off-bys. (To change > the authorship, use git commit

Re: [Qemu-devel] [PATCH 1/2] vmdk: support vmfsSparse files

2013-08-12 Thread Stefan Hajnoczi
On Mon, Aug 12, 2013 at 1:28 PM, Stefan Hajnoczi wrote: > On Sun, Aug 11, 2013 at 06:13:57PM +0200, Paolo Bonzini wrote: >> @@ -505,6 +505,34 @@ static int vmdk_open_vmdk3(BlockDriverState *bs, >> return ret; >> } >> >> +static int vmdk_open_vmfs_sparse(BlockDriverState *bs, >> +

[Qemu-devel] virtio-net with vhost RX stall

2013-08-12 Thread Benoît Canet
Hello, I am chasing a randomly occuring RX stall with virtio-net and vhost-net. So far we have a test setup with a kgdb to debug the guest and a regular gdb to debug QEMU. We are still trying to reproduce the bug in a test environment. Once the bug reproduced would you have hints on what to loo

[Qemu-devel] [PULL for-1.6 3/4] virtio: clear signalled_used_valid when switching from dataplane

2013-08-12 Thread Michael S. Tsirkin
From: Stefan Hajnoczi When the dataplane thread stops, its vring.c implementation synchronizes vring state back to virtio.c so we can continue emulating the virtio device. This patch ensures that virtio.c's signalled_used_valid flag is reset so that we do not suppress guest notifications due to

[Qemu-devel] [PULL for-1.6 0/4] pci,virtio fixes for 1.6

2013-08-12 Thread Michael S. Tsirkin
From: Michael S. Tsirkin The following changes since commit 6fdf98f281f85ae6e2883bed2f691bcfe33b1f9f: fw_cfg: the I/O port variant expects little-endian (2013-08-07 12:48:15 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony

[Qemu-devel] [PULL for-1.6 4/4] vhost: clear signalled_used_valid on vhost stop

2013-08-12 Thread Michael S. Tsirkin
When vhost device stops, its implementation synchronizes kernel state back to virtio.c so we can continue emulating the device in userspace. This patch ensures that virtio.c's signalled_used_valid flag is reset so that userspace does not suppress guest notifications due to stale signalled_used val

Re: [Qemu-devel] virtio-net with vhost RX stall

2013-08-12 Thread Michael S. Tsirkin
On Mon, Aug 12, 2013 at 01:57:40PM +0200, Benoît Canet wrote: > > Hello, > > I am chasing a randomly occuring RX stall with virtio-net and vhost-net. Any chance the bug is fixed by 'virtio_net: fix race in RX VQ processing'? > > So far we have a test setup with a kgdb to debug the guest and a

[Qemu-devel] [PULL for-1.6 1/4] pc: disable pci-info for 1.6

2013-08-12 Thread Michael S. Tsirkin
The BIOS that we ship in 1.6 does not use pci info from host (yet). Several issues turned up (e.g. around winXP boot crashes). So it's safest to disable that interface for 1.6 machine types for now, leave it on for 1.7 as we have enough time to fix issues if any. Reviewed-by: Richard Henderson Re

[Qemu-devel] [PULL for-1.6 2/4] i82801b11: Fix i82801b11 PCI host bridge config space

2013-08-12 Thread Michael S. Tsirkin
From: Gerd Hoffmann pci_bridge_write_config() was not being used. Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann Signed-off-by: Andreas Färber Signed-off-by: Michael S. Tsirkin --- hw/pci-bridge/i82801b11.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/pci-bridge/i82801b11.

[Qemu-devel] [PATCH 0/2] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-08-12 Thread Stefan Hajnoczi
These patches are based on Alex Bligh's v10 AioContext timers series. The purpose of these patches is to eventually allow device models to set and cancel timers without holding the global mutex. When the device model runs in a vcpu thread and the iothread processes timers, the QEMUTimerList->acti

[Qemu-devel] [PATCH 2/2] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-08-12 Thread Stefan Hajnoczi
Introduce QEMUTimerList->active_timers_lock to protect the linked list of active timers. This allows qemu_timer_mod_ns() to be called from any thread. Note that vm_clock is not thread-safe and its use of qemu_clock_has_timers() works fine today but is also not thread-safe. The purpose of this pa

[Qemu-devel] [PATCH 1/2] qemu-timer: drop outdated signal safety comments

2013-08-12 Thread Stefan Hajnoczi
host_alarm_handler() is invoked from the signal processing thread (currently the iothread). Previously we did processing in a real signal handler with signalfd and therefore needed signal-safe timer code. Today host_alarm_handler() just marks the alarm timer as expired/pending and notifies the ma

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2013-08-12 Thread Anthony Liguori
Benjamin Herrenschmidt writes: > On Mon, 2013-08-12 at 17:29 +0930, Rusty Russell wrote: >> virtio data structures are defined as "target endian", which assumes >> that's a fixed value. In fact, that actually means it's >> platform-specific. >> >> Hopefully the OASIS virtio 1.0 spec will fix th

Re: [Qemu-devel] [SeaBIOS] [PATCH] acpi: hide 64-bit PCI hole for Windows XP

2013-08-12 Thread Laszlo Ersek
On 08/09/13 17:49, Michael S. Tsirkin wrote: > On Fri, Aug 09, 2013 at 12:13:06AM -0400, Kevin O'Connor wrote: >> On Thu, Aug 08, 2013 at 04:56:55PM +0200, Gerd Hoffmann wrote: >>> On 08/08/13 16:13, Michael S. Tsirkin wrote: On Thu, Aug 08, 2013 at 12:21:32PM +0200, Gerd Hoffmann wrote: >

Re: [Qemu-devel] [PATCH 1/2] qemu-timer: drop outdated signal safety comments

2013-08-12 Thread Alex Bligh
--On 12 August 2013 14:49:28 +0200 Stefan Hajnoczi wrote: host_alarm_handler() is invoked from the signal processing thread (currently the iothread). Previously we did processing in a real signal handler with signalfd and therefore needed signal-safe timer code. Today host_alarm_handler()

Re: [Qemu-devel] [PATCH 2/2] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-08-12 Thread Alex Bligh
--On 12 August 2013 14:49:29 +0200 Stefan Hajnoczi wrote: Introduce QEMUTimerList->active_timers_lock to protect the linked list of active timers. This allows qemu_timer_mod_ns() to be called from any thread. Note that vm_clock is not thread-safe and its use of qemu_clock_has_timers() wor

Re: [Qemu-devel] [PATCH v2] virtio-serial: Do not notify virtqueue if no element was pushed back.

2013-08-12 Thread Laszlo Ersek
On 08/11/13 15:25, Gal Hammer wrote: > The redundant notification caused the Windows' driver to duplicate the > pending write request's buffer. The driver was fixed, but I think this > change is still required. > > Signed-off-by: Gal Hammer > --- > hw/char/virtio-serial-bus.c | 6 +- > 1 fil

Re: [Qemu-devel] [PULL for-1.6] TCG mips --enable-debug fix

2013-08-12 Thread Anthony Liguori
Richard Henderson writes: > Please pull for -rc2, thanks. > > > r~ > > > The following changes since commit 6fdf98f281f85ae6e2883bed2f691bcfe33b1f9f: > > fw_cfg: the I/O port variant expects little-endian (2013-08-07 12:48:15 > -0500) > > are available in the git repository at: > > git://git

Re: [Qemu-devel] [PATCH for-1.6] virtio: clear signalled_used_valid when switching from dataplane

2013-08-12 Thread Stefan Hajnoczi
On Mon, Aug 12, 2013 at 11:18 AM, Michael S. Tsirkin wrote: > On Mon, Aug 12, 2013 at 11:08:09AM +0200, Stefan Hajnoczi wrote: >> When the dataplane thread stops, its vring.c implementation synchronizes >> vring state back to virtio.c so we can continue emulating the virtio >> device. >> >> This p

Re: [Qemu-devel] [PULL for-1.6] TCG mips --enable-debug fix

2013-08-12 Thread Andreas Färber
Am 12.08.2013 15:31, schrieb Anthony Liguori: > Richard Henderson writes: > >> Please pull for -rc2, thanks. >> >> >> r~ >> >> >> The following changes since commit 6fdf98f281f85ae6e2883bed2f691bcfe33b1f9f: >> >> fw_cfg: the I/O port variant expects little-endian (2013-08-07 12:48:15 >> -0500)

Re: [Qemu-devel] [PATCH for-1.6 0/2] future proof rom loading for cross versiom migration

2013-08-12 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > ROM files that are put in FW CFG are copied to guest ram, by BIOS, but > they are not backed by RAM so they don't get migrated. > > Each time we'll change at least two bytes in such a ROM this will break > cross-version migration: since we can migrate after BIOS has

[Qemu-devel] [PATCH v2] pc: drop external DSDT loading

2013-08-12 Thread Anthony Liguori
This breaks migration and is unneeded with modern SeaBIOS. Signed-off-by: Anthony Liguori --- v1 -> v2 - Still load external DSDT for q35 --- hw/i386/pc_piix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 95c45b8..311574a 100644 --- a/hw/i386/pc

Re: [Qemu-devel] [PATCH v2] pc: drop external DSDT loading

2013-08-12 Thread Andreas Färber
Am 12.08.2013 16:01, schrieb Anthony Liguori: > This breaks migration and is unneeded with modern SeaBIOS. > > Signed-off-by: Anthony Liguori > --- > v1 -> v2 > - Still load external DSDT for q35 Care to extend $subject with "for i440fx" then before applying? :) Regards, Andreas > --- > hw/i

Re: [Qemu-devel] [PATCH for-1.6] virtio: clear signalled_used_valid when switching from dataplane

2013-08-12 Thread Michael S. Tsirkin
On Mon, Aug 12, 2013 at 03:39:23PM +0200, Stefan Hajnoczi wrote: > On Mon, Aug 12, 2013 at 11:18 AM, Michael S. Tsirkin wrote: > > On Mon, Aug 12, 2013 at 11:08:09AM +0200, Stefan Hajnoczi wrote: > >> When the dataplane thread stops, its vring.c implementation synchronizes > >> vring state back to

Re: [Qemu-devel] [PATCH v2] Fix query-migrate documentation in qmp-commands.hx

2013-08-12 Thread Luiz Capitulino
On Thu, 8 Aug 2013 20:05:48 +0300 Orit Wasserman wrote: > "ram" is present also when migration completes. > expected-downtime, total-time and downtime are no longer part of "ram" data. > > Signed-off-by: Orit Wasserman Applied to the qmp branch, thanks. > --- > qmp-commands.hx | 20

Re: [Qemu-devel] [PATCH] pc: compat: remove PCLMULQDQ from Westmere on pc-*-1.4 and older

2013-08-12 Thread Andreas Färber
Am 09.08.2013 19:24, schrieb Eduardo Habkost: > On Fri, Aug 09, 2013 at 04:47:53PM +0200, Andreas Färber wrote: >> Am 09.08.2013 16:11, schrieb Eduardo Habkost: >>> commit 41cb383f42d0cb51d8e3e25e3ecebc954dd4196f made a guest-visible >>> change by adding the PCLMULQDQ bit to Westmere without adding

Re: [Qemu-devel] [PATCH for 1.6 1/2] memory: Provide separate handling of unassigned io ports accesses

2013-08-12 Thread Anthony Liguori
Jan Kiszka writes: > Accesses to unassigned io ports shall return -1 on read and be ignored > on write. Ensure these properties via dedicated ops, decoupling us from > the memory core's handling of unassigned accesses. > > Signed-off-by: Jan Kiszka Breaks the build (linux-user): LINK xtensa

Re: [Qemu-devel] [PATCH v2] pc: drop external DSDT loading

2013-08-12 Thread Michael S. Tsirkin
On Mon, Aug 12, 2013 at 09:01:44AM -0500, Anthony Liguori wrote: > This breaks migration and is unneeded with modern SeaBIOS. > > Signed-off-by: Anthony Liguori Hmm don't we want to keep it around for machine types 1.4.0 and 1.5.0? By the way, copy stable as well? Loading it unconditonally is a

Re: [Qemu-devel] [PATCH v2] pc: drop external DSDT loading

2013-08-12 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Mon, Aug 12, 2013 at 09:01:44AM -0500, Anthony Liguori wrote: >> This breaks migration and is unneeded with modern SeaBIOS. >> >> Signed-off-by: Anthony Liguori > > Hmm don't we want to keep it around for machine types > 1.4.0 and 1.5.0? Hrm, why? Regards, A

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Guenter Roeck
On 08/11/2013 03:04 PM, Russell King - ARM Linux wrote: On Sun, Aug 11, 2013 at 08:54:43AM -0700, Guenter Roeck wrote: Hi, trying to boot arm versatile images with qemu results in the following error if I try to boot with a disk image. sym0: <895a> rev 0x0 at pci :00:0d.0 irq 92

[Qemu-devel] [PATCH v2 for 1.6 1/2] memory: Provide separate handling of unassigned io ports accesses

2013-08-12 Thread Jan Kiszka
Accesses to unassigned io ports shall return -1 on read and be ignored on write. Ensure these properties via dedicated ops, decoupling us from the memory core's handling of unassigned accesses. Signed-off-by: Jan Kiszka --- Changes in v2: - avoid breakage in ioport.h for user build exec.c

[Qemu-devel] [PULL for-1.6 0/1] QOM CPUState patch queue 2013-08-12

2013-08-12 Thread Andreas Färber
Hello Anthony, This is my current QOM CPU patch queue for 1.6. Please pull. Thanks, Andreas Cc: Anthony Liguori The following changes since commit 8f3067bd86485f8cd03abc940ddb2b8467ef3627: rdma: remaining documentation fixes (2013-08-12 09:31:16 -0500) are available in the git repository a

[Qemu-devel] [PULL 1/1] pc: Remove PCLMULQDQ from Westmere on pc-*-1.4 and older

2013-08-12 Thread Andreas Färber
From: Eduardo Habkost Commit 41cb383f42d0cb51d8e3e25e3ecebc954dd4196f made a guest-visible change by adding the PCLMULQDQ bit to Westmere without adding compatibility code to keep the ABI for older machine-types. Fix it by adding the missing compat code. Signed-off-by: Eduardo Habkost Signed-of

Re: [Qemu-devel] [PATCH v2 for 1.6 1/2] memory: Provide separate handling of unassigned io ports accesses

2013-08-12 Thread Anthony Liguori
Jan Kiszka writes: > Accesses to unassigned io ports shall return -1 on read and be ignored > on write. Ensure these properties via dedicated ops, decoupling us from > the memory core's handling of unassigned accesses. > > Signed-off-by: Jan Kiszka Please top-post. Regards, Anthony Liguori >

Re: [Qemu-devel] virtio-net with vhost RX stall

2013-08-12 Thread Benoît Canet
> Any chance the bug is fixed by 'virtio_net: fix race in RX VQ processing'? We will test if we have more luck with a 3.10 and a backport of this patch. > Dump the ring state and index values where they poll, on host and guest. ok Thanks Benoît

Re: [Qemu-devel] [PATCH v2 for 1.6 1/2] memory: Provide separate handling of unassigned io ports accesses

2013-08-12 Thread Andreas Färber
Am 12.08.2013 17:29, schrieb Jan Kiszka: > Accesses to unassigned io ports shall return -1 on read and be ignored > on write. Ensure these properties via dedicated ops, decoupling us from > the memory core's handling of unassigned accesses. > > Signed-off-by: Jan Kiszka > --- > > Changes in v2:

Re: [Qemu-devel] [PATCH for-1.6 V2 0/2] pvpanic: Separate pvpanic from machine type

2013-08-12 Thread Eric Blake
On 08/11/2013 09:10 AM, Marcel Apfelbaum wrote: > Creating the pvpanic device as part of the machine type has the > potential to trigger guest OS, guest firmware and driver bugs. > The potential of such was originally viewed as minimal. > However, since releasing 1.5 with pvpanic as part > of the b

Re: [Qemu-devel] [PATCH v5] vl.c: Output error on invalid machine type provided

2013-08-12 Thread Eric Blake
On 07/31/2013 01:04 AM, Michal Novotny wrote: > Output error message using qemu's error_report() function when user > provides the invalid machine type on the command line. This also saves > time to find what issue is when you downgrade from one version of qemu > to another that doesn't support req

Re: [Qemu-devel] [PATCH v5] vl.c: Output error on invalid machine type provided

2013-08-12 Thread Michal Novotny
On 08/12/2013 05:55 PM, Eric Blake wrote: > On 07/31/2013 01:04 AM, Michal Novotny wrote: >> Output error message using qemu's error_report() function when user >> provides the invalid machine type on the command line. This also saves >> time to find what issue is when you downgrade from one versi

Re: [Qemu-devel] [PATCH for-1.6 V2 1/2] hw/misc: don't create pvpanic device by default

2013-08-12 Thread Andreas Färber
Am 11.08.2013 17:10, schrieb Marcel Apfelbaum: > This patch is based on Hu Tao's: > http://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg00124.html > > No need to hard-code pvpanic as part of the machine. > It can be added with "-device pvpanic" from command line (The next patch). > Anyway,

Re: [Qemu-devel] [RFC] [PATCHv10 08/31] aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList

2013-08-12 Thread Jan Kiszka
On 2013-08-11 18:43, Alex Bligh wrote: > Split QEMUClock into QEMUClock and QEMUTimerList so that we can > have more than one QEMUTimerList associated with the same clock. > > Introduce a main_loop_timerlist concept and make existing > qemu_clock_* calls that actually should operate on a QEMUTimer

Re: [Qemu-devel] [PATCH v5] vl.c: Output error on invalid machine type provided

2013-08-12 Thread Eric Blake
On 08/12/2013 09:58 AM, Michal Novotny wrote: > > On 08/12/2013 05:55 PM, Eric Blake wrote: >> On 07/31/2013 01:04 AM, Michal Novotny wrote: >>> Output error message using qemu's error_report() function when user >>> provides the invalid machine type on the command line. This also saves >>> time t

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Peter Maydell
On 12 August 2013 01:40, Guenter Roeck wrote: > On 08/11/2013 03:04 PM, Russell King - ARM Linux wrote: >> It could be that it's qemu's PCI routing is wrong - it's not the first >> time that qemu has got something wrong. QEMU 1.5 has had its Versatile PCI routing code rewritten to correspond with

Re: [Qemu-devel] [RFC] [PATCHv10 08/31] aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList

2013-08-12 Thread Alex Bligh
On 12 Aug 2013, at 17:14, Jan Kiszka wrote: > The typedef part is a duplication of what we already have in > qemu/typedefs.h and breaks the build for me. Just declare the struct here. You mean one can't do typedef struct foo foo; ... typedef struct foo { ... } foo; ? I don't even get a warn

  1   2   3   >