Re: [Qemu-devel] RFC: [PATCH 0/5] Explicitly annotating coroutine_fn functions

2013-08-08 Thread Kevin Wolf
Am 08.08.2013 um 03:22 hat Charlie Shepherd geschrieben: > On 06/08/2013 10:37, Kevin Wolf wrote: > >Am 05.08.2013 um 20:44 hat Charlie Shepherd geschrieben: > >>This patch series is a follow up to a previous RFC about converting > >>functions > >>that dynamically yield execution depending on whet

[Qemu-devel] [PATCH 0/2] [v3] target-ppc: Enhance CPU nodes of SPAPR-generated device tree

2013-08-08 Thread Prerna Saxena
By default on KVM or when user asks for it via -cpu host, cpu_model will be "host" and sPAPR merely upper-cases it for the SLOF device tree. PATCH 1/2 : Change the SPAPR code so that we get the underlying CPU type, e.g., "POWER7_V2.3@0" in the device tree. PATCH 2/2 : Make the device-

[Qemu-devel] [PATCH 1/2] [v3] target-ppc: Get CPU name to correct reflect its model in the SLOF device tree.

2013-08-08 Thread Prerna Saxena
From: Andreas Farber Date: Wed, 7 Aug 2013 14:50:41 +0530 Subject: [PATCH 1/2] By default on KVM or when user asks for it via -cpu host, cpu_model will be "host" and sPAPR merely upper-cases it for the SLOF device tree. Change it so that we get the underlying CPU type, e.g., "POWER7_V2.3@0". T

[Qemu-devel] [PATCH 2/2] [v3] target-ppc: Enhance CPU nodes of device tree to be PAPR compliant.

2013-08-08 Thread Prerna Saxena
From: Prerna Saxena Date: Thu, 8 Aug 2013 06:38:03 +0530 Subject: [PATCH 2/2] Enhance CPU nodes of device tree to be PAPR compliant. This is based on patch from Andreas which enables the default CPU with KVM to show up as "-cpu ", such as "POWER7_V2.3@0" While this is definitely, more descripti

Re: [Qemu-devel] [RFC] [PATCHv7 00/22] aio / timers: Add AioContext timers and use ppoll

2013-08-08 Thread Alex Bligh
Pingfan has given me an idea here. I can convert the API over to solely use QEMUClockType and not even expose struct QEMUClock *. I'll do this in v8. I have that working here and the API is much cleaner. Now I just need to reengineer it into git. Alex --On 7 August 2013 00:48:54 +0100 Alex Bligh

Re: [Qemu-devel] [PATCH for 1.6] w32: Add missing version.o to all executables (fix regression)

2013-08-08 Thread Paolo Bonzini
- Original Message - > From: "Stefan Weil" > To: "qemu-devel" > Cc: "Anthony Liguori" , "Paolo Bonzini" > , "Stefan Weil" > Sent: Wednesday, August 7, 2013 11:07:04 PM > Subject: [PATCH for 1.6] w32: Add missing version.o to all executables (fix > regression) > > QEMU executables fo

Re: [Qemu-devel] [PATCH] tap: Use numbered tap/tun devices on all *BSD OS's

2013-08-08 Thread Stefan Hajnoczi
On Thu, Aug 08, 2013 at 02:12:20AM -0400, Brad Smith wrote: > On 05/08/13 7:57 AM, Stefan Hajnoczi wrote: > >On Sat, Aug 03, 2013 at 10:20:41PM -0400, Brad Smith wrote: > >>The following patch simplifies the *BSD tap/tun code and makes use of > >>numbered > >>tap/tun interfaces on all *BSD OS's. N

Re: [Qemu-devel] [PATCH] Moving alarm_timer assignment before atexit()

2013-08-08 Thread Stefan Hajnoczi
On Wed, Aug 07, 2013 at 04:17:29PM +0800, Amos Kong wrote: > BTW, can we add a check in quit_timers() to avoid one kind of crash > (try to quit the uninited timers, or quit timer repeatedly) ? > > > diff --git a/qemu-timer.c b/qemu-timer.c > index b2d95e2..023e4ae 100644 > --- a/qemu-timer.c > ++

Re: [Qemu-devel] [PATCH] Test coroutine execution order (v2)

2013-08-08 Thread Stefan Hajnoczi
On Thu, Aug 08, 2013 at 03:23:14AM +0100, Charlie Shepherd wrote: This patch's commit message will say "Test coroutine execution order (v2)" when applied. In the future please put the "v2" into the [PATCH ...] tag list instead so it gets stripped automatically when the patch is applied. With git-

Re: [Qemu-devel] [RFC] [PATCHv5 06/16] aio / timers: Untangle include files

2013-08-08 Thread Stefan Hajnoczi
On Wed, Aug 07, 2013 at 11:14:30AM +0100, Alex Bligh wrote: > >Some tips on which packages to install: > > > >>host big endian no > >>gprof enabled no > >>sparse enabledno > >>strip binariesno > >>profiler no > >>static build no > > > >All the ones above are okay, fine t

Re: [Qemu-devel] [SeaBIOS] [PATCH] acpi: hide 64-bit PCI hole for Windows XP

2013-08-08 Thread Michael S. Tsirkin
On Thu, Aug 08, 2013 at 09:57:39AM +0200, Gerd Hoffmann wrote: > >> (3) mmconf xbar start (MCFG, q35 only, at 0xb000 now). > >> (4) pmbase (FADT, at 0xb000 now). > >> > >> Especially 3+4 tend to be compile-time constants in the firmware as they > >> are needed very early in the setup proces

[Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx

2013-08-08 Thread Orit Wasserman
"ram" is present also when migration completes. total-time and downtime are no longer part of "ram" data. Signed-off-by: Orit Wasserman --- qmp-commands.hx | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 2e59b0d..1d43f4c

Re: [Qemu-devel] [SeaBIOS] [PATCH] acpi: hide 64-bit PCI hole for Windows XP

2013-08-08 Thread Gerd Hoffmann
On 08/08/13 10:37, Michael S. Tsirkin wrote: > On Thu, Aug 08, 2013 at 09:57:39AM +0200, Gerd Hoffmann wrote: (3) mmconf xbar start (MCFG, q35 only, at 0xb000 now). (4) pmbase (FADT, at 0xb000 now). Especially 3+4 tend to be compile-time constants in the firmware as they

Re: [Qemu-devel] [PATCH] seabios: update to 1.7.3

2013-08-08 Thread Gerd Hoffmann
On 08/07/13 22:47, Alex Williamson wrote: > Don't we really want this too? > > commit 2a9aeabdfb34374ecac25e7a8d21c9e368618cd4 > Author: Kevin O'Connor > Date: Sun Jul 14 13:55:52 2013 -0400 > > Fix USB EHCI detection that was broken in hlist convers

Re: [Qemu-devel] [PATCH 2/5] qemu_coroutine_self should not be marked coroutine_fn as it cannot yield

2013-08-08 Thread Charlie Shepherd
On 08/08/2013 07:16, Gabriel Kerneis wrote: On Thu, Aug 08, 2013 at 02:29:39AM +0100, Charlie Shepherd wrote: On 07/08/2013 23:13, Gabriel Kerneis wrote: On Wed, Aug 07, 2013 at 09:18:05PM +0200, Stefan Hajnoczi wrote: I guess the practical problem is that CPC will get upset that it's being ca

Re: [Qemu-devel] [PATCH 2/5] qemu_coroutine_self should not be marked coroutine_fn as it cannot yield

2013-08-08 Thread Gabriel Kerneis
On Thu, Aug 08, 2013 at 10:10:18AM +0100, Charlie Shepherd wrote: > >Note that qemu_coroutine_self() in principle really needs to be annotated > >coroutine_fn since it accesses (and returns) its execution context. The fact > >that it is implemented with thread-local variables in Qemu is an > >impl

Re: [Qemu-devel] [SeaBIOS] [PATCH] acpi: hide 64-bit PCI hole for Windows XP

2013-08-08 Thread Michael S. Tsirkin
On Thu, Aug 08, 2013 at 10:51:59AM +0200, Gerd Hoffmann wrote: > On 08/08/13 10:22, Michael S. Tsirkin wrote: > > On Thu, Aug 08, 2013 at 09:57:39AM +0200, Gerd Hoffmann wrote: > >> Hi, > >> > Huh? The 32bit window is sized according to the installed memory. > That > logic is in s

Re: [Qemu-devel] RFC: [PATCH 0/5] Explicitly annotating coroutine_fn functions

2013-08-08 Thread Charlie Shepherd
On 08/08/2013 08:15, Kevin Wolf wrote: Am 08.08.2013 um 03:22 hat Charlie Shepherd geschrieben: On 06/08/2013 10:37, Kevin Wolf wrote: Against which tree is this? It didn't apply on top of qemu-git master, nor on my block branch. Sorry, just to clarify, this isn't based on QEMU but is a repos

Re: [Qemu-devel] [PATCH] Test coroutine execution order (v2)

2013-08-08 Thread Charlie Shepherd
On 08/08/2013 09:28, Stefan Hajnoczi wrote: On Thu, Aug 08, 2013 at 03:23:14AM +0100, Charlie Shepherd wrote: This patch's commit message will say "Test coroutine execution order (v2)" when applied. In the future please put the "v2" into the [PATCH ...] tag list instead so it gets stripped autom

Re: [Qemu-devel] [SeaBIOS] [PATCH] acpi: hide 64-bit PCI hole for Windows XP

2013-08-08 Thread Michael S. Tsirkin
On Thu, Aug 08, 2013 at 10:57:44AM +0200, Gerd Hoffmann wrote: > On 08/08/13 10:37, Michael S. Tsirkin wrote: > > On Thu, Aug 08, 2013 at 09:57:39AM +0200, Gerd Hoffmann wrote: > (3) mmconf xbar start (MCFG, q35 only, at 0xb000 now). > (4) pmbase (FADT, at 0xb000 now). > > >>

Re: [Qemu-devel] [PATCH 5/7] hw/block/virtio-blk: use virtio wrappers to access headers.

2013-08-08 Thread Peter Maydell
On 8 August 2013 06:15, Rusty Russell wrote: > Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. This is the right thing, incidentally. The _raw() functions are supposed to take a guest physical address (as an integer), where the _p() ones take a host void*. However the i

Re: [Qemu-devel] [PATCH] Test coroutine execution order (v2)

2013-08-08 Thread Kevin Wolf
Am 08.08.2013 um 11:48 hat Charlie Shepherd geschrieben: > Ah sorry I forgot it should go in the square brackets. Did you want > me to resend it with the correct title? Not necessary, I've fixed it up. Just remember it for your next series. Thanks, applied to block-next (for 1.7) Kevin

Re: [Qemu-devel] [SeaBIOS] [PATCH] acpi: hide 64-bit PCI hole for Windows XP

2013-08-08 Thread Gerd Hoffmann
On 08/08/13 11:52, Michael S. Tsirkin wrote: > On Thu, Aug 08, 2013 at 10:57:44AM +0200, Gerd Hoffmann wrote: >> On 08/08/13 10:37, Michael S. Tsirkin wrote: >>> On Thu, Aug 08, 2013 at 09:57:39AM +0200, Gerd Hoffmann wrote: Also coreboot and seabios use different values for pmbase. coreboot

[Qemu-devel] Using TRIM to shrink qcow2 images

2013-08-08 Thread Ralf Ramsauer
Hi, QCOW2 uses a similar idea like file holes (sparse files) on filesystems [1]. RAW Images also may use file holes. If qemu would support TRIM, then the guest could easily discard and zero all unused blocks. The host system could detect all unused blocks in a (e.g.) qcow2 image and shrink it dow

Re: [Qemu-devel] [PATCH 2/2] [v3] target-ppc: Enhance CPU nodes of device tree to be PAPR compliant.

2013-08-08 Thread Andreas Färber
Am 08.08.2013 09:26, schrieb Prerna Saxena: > > From: Prerna Saxena > Date: Thu, 8 Aug 2013 06:38:03 +0530 > Subject: [PATCH 2/2] Enhance CPU nodes of device tree to be PAPR compliant. > > This is based on patch from Andreas which enables the default CPU with KVM > to show up as "-cpu ", such as

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: implement .bdrv_get_allocated_file_size

2013-08-08 Thread Kevin Wolf
Am 08.08.2013 um 01:14 hat MORITA Kazutaka geschrieben: > At Wed, 7 Aug 2013 16:59:53 +0800, > Liu Yuan wrote: > > > > With this patch, qemu-img info sheepdog:image will show disk size for > > sheepdog > > images. > > > > Cc: Kevin Wolf > > Cc: Stefan Hajnoczi > > Cc: MORITA Kazutaka > > Sig

[Qemu-devel] [PATCH] qemu-char: fix infinite recursion connecting to monitor pty

2013-08-08 Thread James Hogan
Since commit bd5c51e (qemu-char: don't issue CHR_EVENT_OPEN in a BH), an infinite recursion occurs when putting the monitor on a pty (-monitor pty) and connecting a terminal to the slave port. This is because of the qemu_chr_be_event(s, CHR_EVENT_OPENED) added to qemu_chr_be_generic_open(). This e

[Qemu-devel] [PULL for-1.6 0/1] usb patch queue

2013-08-08 Thread Gerd Hoffmann
Hi, Tiny queue this time, with a single xhci fix for 1.6 please pull, Gerd The following changes since commit 6fdf98f281f85ae6e2883bed2f691bcfe33b1f9f: fw_cfg: the I/O port variant expects little-endian (2013-08-07 12:48:15 -0500) are available in the git repository at: git://git.krax

[Qemu-devel] [PATCH 1/1] xhci: implement warm port reset

2013-08-08 Thread Gerd Hoffmann
Without this patch windows can't do port resets for usb3 devices. https://bugzilla.redhat.com/show_bug.cgi?id=949514 Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c inde

Re: [Qemu-devel] [PATCH 5/6] xics: split to xics and xics-common

2013-08-08 Thread Andreas Färber
Am 08.08.2013 05:10, schrieb Alexey Kardashevskiy: > On 08/08/2013 12:22 AM, Andreas Färber wrote: >> Setting a canonical path is done via object_property_add_child() after >> instantiating and before realizing a device. >> For x86 the northbridge is used as name, i.e. "i440fx" for pc and "q35" >>

Re: [Qemu-devel] Using TRIM to shrink qcow2 images

2013-08-08 Thread François Revol
On 08/08/2013 12:34, Ralf Ramsauer wrote: > Hi, > > QCOW2 uses a similar idea like file holes (sparse files) on filesystems [1]. > RAW Images also may use file holes. > > If qemu would support TRIM, then the guest could easily discard and zero > all unused blocks. > The host system could detect a

Re: [Qemu-devel] Using TRIM to shrink qcow2 images

2013-08-08 Thread Paolo Bonzini
On 08/08/2013 12:34 PM, Ralf Ramsauer wrote: Hi, QCOW2 uses a similar idea like file holes (sparse files) on filesystems [1]. RAW Images also may use file holes. If qemu would support TRIM, then the guest could easily discard and zero all unused blocks. QEMU supports trim. 1.5 supports it wi

Re: [Qemu-devel] vm performance degradation after kvm live migration or save-restore with EPT enabled

2013-08-08 Thread Paolo Bonzini
On 08/08/2013 01:31 PM, Zhanghaoyu (A) wrote: > And, rebuild the kvm-kmod, then re-insmod kvm-intel.ko with ept=0, I virsh-save the VM, and then virsh-restore the VM, the performance degradation disappeared, and no GFN printed. But, I also made a test on the first bad commit(612819c3c6e67bac8

Re: [Qemu-devel] [ceph-users] qemu-1.4.0 and onwards, linux kernel 3.2.x, ceph-RBD, heavy I/O leads to kernel_hung_tasks_timout_secs message and unresponsive qemu-process, [Bug 1207686]

2013-08-08 Thread Oliver Francke
Hi Josh, I have a session logged with: debug_ms=1:debug_rbd=20:debug_objectcacher=30 as you requested from Mike, even if I think, we do have another story here, anyway. Host-kernel is: 3.10.0-rc7, qemu-client 1.6.0-rc2, client-kernel is 3.2.0-51-amd... Do you want me to open a ticket

Re: [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx

2013-08-08 Thread Eric Blake
On 08/08/2013 02:46 AM, Orit Wasserman wrote: > "ram" is present also when migration completes. > total-time and downtime are no longer part of "ram" data. > > Signed-off-by: Orit Wasserman > --- > qmp-commands.hx | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-b

[Qemu-devel] -cpu host (was Re: KVM call minutes for 2013-08-06)

2013-08-08 Thread Peter Maydell
[I missed this KVM call but the stuff about -cpu host ties into an issue we've been grappling with for ARM KVM, so it seems a reasonable jumping-off-point.] On 6 August 2013 16:15, Juan Quintela wrote: > 2013-08-06 > -- > > What libvirt needs/miss Today? > - how to handle machine types? c

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Anthony Liguori
Rusty Russell writes: > Virtio is currently defined to work as "guest endian", but this is a > problem if the guest can change endian. As most targets can't change > endian, we make it a per-target option to avoid pessimising. > > This is based on a simpler patch by Anthony Liguouri, which only

Re: [Qemu-devel] [PATCH 4/7] hw/net/virtio-balloon: use virtio wrappers to access page frame numbers.

2013-08-08 Thread Anthony Liguori
Rusty Russell writes: > Signed-off-by: Rusty Russell Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > hw/virtio/virtio-balloon.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c > index d669756..

Re: [Qemu-devel] [PATCH 5/7] hw/block/virtio-blk: use virtio wrappers to access headers.

2013-08-08 Thread Anthony Liguori
Rusty Russell writes: > Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. > > Signed-off-by: Rusty Russell Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > hw/block/virtio-blk.c | 35 ++- > 1 file changed, 18 insertions(

Re: [Qemu-devel] [PATCH 3/7] hw/net/virtio-net: use virtio wrappers to access headers.

2013-08-08 Thread Anthony Liguori
Rusty Russell writes: > Signed-off-by: Rusty Russell Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > hw/net/virtio-net.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > index 1ea9556..e77e28d

Re: [Qemu-devel] [PATCH 6/7] hw/scsi/virtio-scsi: use virtio wrappers to access headers.

2013-08-08 Thread Anthony Liguori
Rusty Russell writes: > Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. > > Signed-off-by: Rusty Russell Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > hw/scsi/virtio-scsi.c | 33 + > 1 file changed, 17 insertions(+)

Re: [Qemu-devel] [PATCH 7/7] hw/char/virtio-serial-bus: use virtio wrappers to access headers.

2013-08-08 Thread Anthony Liguori
Rusty Russell writes: > Signed-off-by: Rusty Russell Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > hw/char/virtio-serial-bus.c | 34 ++ > 1 file changed, 18 insertions(+), 16 deletions(-) > > diff --git a/hw/char/virtio-serial-bus.c b/hw/char

Re: [Qemu-devel] [PATCH V3 for-1.6 3/5] block: Add support for throttling burst threshold in QMP and the command line.

2013-08-08 Thread Benoît Canet
> Kevin's series renamed these to have a dash in the name, and also moved > all the throttling parameters into a sub-struct. Does it make more > sense to have just '*throttling' with that sub-struct containing 12 > parameters, 6 for limits and 6 for thresholds, or would it be better to > have '*th

[Qemu-devel] 1.7.3.1 release planned

2013-08-08 Thread Gerd Hoffmann
Hi, I've just created a 1.7.3-stable branch. It has a single commit right now, which is 2a9aeabdfb34374ecac25e7a8d21c9e368618cd4 from master cherry-picked (Fix USB EHCI detection that was broken in hlist conversion of PCIDevices). My plan is to tag 1.7.3.1 next monday, so the update can be inc

Re: [Qemu-devel] [PATCH] qemu-char: fix infinite recursion connecting to monitor pty

2013-08-08 Thread Michael Roth
Quoting James Hogan (2013-08-08 06:09:38) > Since commit bd5c51e (qemu-char: don't issue CHR_EVENT_OPEN in a BH), an > infinite recursion occurs when putting the monitor on a pty (-monitor > pty) and connecting a terminal to the slave port. > > This is because of the qemu_chr_be_event(s, CHR_EVENT

Re: [Qemu-devel] 1.7.3.1 release planned

2013-08-08 Thread Michael S. Tsirkin
On Thu, Aug 08, 2013 at 03:43:48PM +0200, Gerd Hoffmann wrote: > Hi, > > I've just created a 1.7.3-stable branch. It has a single commit right > now, which is 2a9aeabdfb34374ecac25e7a8d21c9e368618cd4 from master > cherry-picked (Fix USB EHCI detection that was broken in hlist > conversion of PC

Re: [Qemu-devel] [PATCH] qemu-char: fix infinite recursion connecting to monitor pty

2013-08-08 Thread Michael Roth
Quoting Michael Roth (2013-08-08 09:03:08) > Quoting James Hogan (2013-08-08 06:09:38) > > Since commit bd5c51e (qemu-char: don't issue CHR_EVENT_OPEN in a BH), an > > infinite recursion occurs when putting the monitor on a pty (-monitor > > pty) and connecting a terminal to the slave port. > > >

Re: [Qemu-devel] [SeaBIOS] [PATCH] acpi: hide 64-bit PCI hole for Windows XP

2013-08-08 Thread Michael S. Tsirkin
On Thu, Aug 08, 2013 at 12:21:32PM +0200, Gerd Hoffmann wrote: > On 08/08/13 11:52, Michael S. Tsirkin wrote: > > On Thu, Aug 08, 2013 at 10:57:44AM +0200, Gerd Hoffmann wrote: > >> On 08/08/13 10:37, Michael S. Tsirkin wrote: > >>> On Thu, Aug 08, 2013 at 09:57:39AM +0200, Gerd Hoffmann wrote: > >

[Qemu-devel] [Bug 1209180] Re: hw/usb/core.c:415: usb_handle_packet: Assertion `p->ep->type != 3 || (dev->flags & (1 << USB_DEV_FLAG_IS_HOST))' failed

2013-08-08 Thread Lekensteyn
Thanks, this works as expected. Can this get backported to 1.5.x? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1209180 Title: hw/usb/core.c:415: usb_handle_packet: Assertion `p->ep->type != 3 ||

Re: [Qemu-devel] Using virtio-mmio

2013-08-08 Thread Erlon Cruz
On Wed, Aug 7, 2013 at 10:38 AM, Erlon Cruz wrote: > > On Sat, Aug 3, 2013 at 7:03 AM, Peter Maydell wrote: > >> On 2 August 2013 18:48, Erlon Cruz wrote: >> > kernel: Linux 3.10-rc6 -> vexpress_defconfig >> >> > The kernel boots, but it cant mount the SD: >> > >> > mmc0: host doesn't support c

[Qemu-devel] [PATCH V4 0/5] Continuous Leaky Bucket Throttling

2013-08-08 Thread Benoît Canet
This patchset implement continous leaky bucket throttling. It use two requests queue to enable to do silly unbalanced throttling like block_set_io_throttle 0 0 0 0 6000 1 It use two timer to get the timer callbacks and the throttle.c code simple It add unit tests. It fail with the following err

[Qemu-devel] [PATCH V4 1/5] throttle: Add a new throttling API implementing continuous leaky bucket.

2013-08-08 Thread Benoît Canet
Implement the continuous leaky bucket algorithm devised on IRC as a separate module. Signed-off-by: Benoit Canet --- include/qemu/throttle.h | 105 + util/Makefile.objs |1 + util/throttle.c | 391 +++ 3 files changed, 49

[Qemu-devel] [PATCH V4 3/5] block: Enable the new throttling code in the block layer.

2013-08-08 Thread Benoît Canet
tip: Do not ever use the cfg scheduler in the guest with this code. It gives incorrect throttling. Signed-off-by: Benoit Canet --- block.c | 351 ++--- block/qapi.c | 21 ++- blockdev.c| 100 +++--

[Qemu-devel] [PATCH V4 2/5] throttle: Add units tests

2013-08-08 Thread Benoît Canet
Signed-off-by: Benoit Canet --- tests/Makefile|2 + tests/test-throttle.c | 494 + 2 files changed, 496 insertions(+) create mode 100644 tests/test-throttle.c diff --git a/tests/Makefile b/tests/Makefile index d044908..fb1e06a 100644

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Andreas Färber
Am 08.08.2013 15:31, schrieb Anthony Liguori: > Rusty Russell writes: > >> Virtio is currently defined to work as "guest endian", but this is a >> problem if the guest can change endian. As most targets can't change >> endian, we make it a per-target option to avoid pessimising. >> >> This is ba

[Qemu-devel] [PATCH V4 4/5] block: Add support for throttling burst max in QMP and the command line.

2013-08-08 Thread Benoît Canet
The max parameter of the leaky bycket throttling algoritm can be used to allow the guest to do bursts. The max value is a pool of I/O that the guest can use without being throttled at all. Throttling is triggered once this pool is empty. Signed-off-by: Benoit Canet --- block/qapi.c | 26 ++

[Qemu-devel] [PATCH V4 5/5] block: Add iops_sector_count to do the iops accounting for a given io size.

2013-08-08 Thread Benoît Canet
This feature can be used in case where users are avoiding the iops limit by doing jumbo I/Os hammering the storage backend. Signed-off-by: Benoit Canet --- block/qapi.c |3 +++ blockdev.c | 22 +++--- hmp.c|8 ++-- qapi-schema.json | 10 +

[Qemu-devel] [PATCH] tcg/mips: fix invalid op definition errors

2013-08-08 Thread James Hogan
tcg/mips/tcg-target.h defines various operations conditionally depending upon the isa revision, however these operations are included in mips_op_defs[] unconditionally resulting in the following runtime errors if CONFIG_DEBUG_TCG is defined: Invalid op definition for movcond_i32 Invalid op definit

Re: [Qemu-devel] [PATCH for-1.6 4/4] rdma: proper getaddrinfo() handling

2013-08-08 Thread Michael R. Hines
On 08/08/2013 02:12 AM, Orit Wasserman wrote: On 08/07/2013 07:05 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" getaddrinfo() already knows what it's doing, wqand can potentially return multiple addresses. Signed-off-by: Michael R. Hines --- migration-rdma.c | 56 +++

[Qemu-devel] [PATCH] block: Bugfix 'format' and 'snapshot' used in drive option

2013-08-08 Thread Mike Qiu
When use -drive file='xxx',format=qcow2,snapshot=on the error message "Can't use snapshot=on with driver-specific options" can be show, and fail to start the qemu. This should not be happened, and there is no file.driver option in qemu command line. It is because the commit 74fe54f2a1b5c4f4498a8f

Re: [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx

2013-08-08 Thread Luiz Capitulino
On Thu, 8 Aug 2013 11:46:14 +0300 Orit Wasserman wrote: > "ram" is present also when migration completes. > total-time and downtime are no longer part of "ram" data. expected-downtime has to be moved too, looks good otherwise. > > Signed-off-by: Orit Wasserman > --- > qmp-commands.hx | 14 +

Re: [Qemu-devel] [SeaBIOS] [PATCH] acpi: hide 64-bit PCI hole for Windows XP

2013-08-08 Thread Gerd Hoffmann
On 08/08/13 16:13, Michael S. Tsirkin wrote: > On Thu, Aug 08, 2013 at 12:21:32PM +0200, Gerd Hoffmann wrote: >> On 08/08/13 11:52, Michael S. Tsirkin wrote: >>> On Thu, Aug 08, 2013 at 10:57:44AM +0200, Gerd Hoffmann wrote: On 08/08/13 10:37, Michael S. Tsirkin wrote: > On Thu, Aug 08, 20

Re: [Qemu-devel] [PATCH] block: Bugfix 'format' and 'snapshot' used in drive option

2013-08-08 Thread Mike Qiu
Hi all This 'bug' also happens use -snapshot, But as newer to qemu, I'm not sure about what am I understanding. But I think snapshot should works at least in qcow2. My understanding about the driver option is mainly for 'nbd' and 'http/https/ftp', and so in commit: c2ad1b0c465a9ea8375eaff14bbd8

[Qemu-devel] [PULL 1/4] dump: clamp guest-provided mapping lengths to ramblock sizes

2013-08-08 Thread Luiz Capitulino
From: Laszlo Ersek Even a trusted & clean-state guest can map more memory than what it was given. Since the vmcore contains RAMBlocks, mapping sizes should be clamped to RAMBlock sizes. Otherwise such oversized mappings can exceed the entire file size, and ELF parsers might refuse even the valid

[Qemu-devel] [PULL for-1.6 0/4] QMP queue

2013-08-08 Thread Luiz Capitulino
The following changes since commit 6fdf98f281f85ae6e2883bed2f691bcfe33b1f9f: fw_cfg: the I/O port variant expects little-endian (2013-08-07 12:48:15 -0500) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch changes up to 56c4bfb3f07f310

[Qemu-devel] [PULL 3/4] dump: populate guest_phys_blocks

2013-08-08 Thread Luiz Capitulino
From: Laszlo Ersek While the machine is paused, in guest_phys_blocks_append() we register a one-shot MemoryListener, solely for the initial collection of the valid guest-physical memory ranges that happens at listener registration time. For each range that is reported to guest_phys_blocks_region

[Qemu-devel] [PULL 4/4] dump: rebase from host-private RAMBlock offsets to guest-physical addresses

2013-08-08 Thread Luiz Capitulino
From: Laszlo Ersek RAMBlock.offset --> GuestPhysBlock.target_start RAMBlock.offset + RAMBlock.length --> GuestPhysBlock.target_end RAMBlock.length --> GuestPhysBlock.target_end - GuestPhysBlock.target_start "GuestPhysBlock

[Qemu-devel] [PULL 2/4] dump: introduce GuestPhysBlockList

2013-08-08 Thread Luiz Capitulino
From: Laszlo Ersek The vmcore must use physical addresses that are visible to the guest, not addresses that point into linear RAMBlocks. As first step, introduce the list type into which we'll collect the physical mappings in effect at the time of the dump. Related RHBZ: https://bugzilla.redhat.

Re: [Qemu-devel] [PATCH] memory: Return -1 again on reads from unsigned regions

2013-08-08 Thread Peter Maydell
On 16 July 2013 13:45, Jan Kiszka wrote: > This restore the behavior prior to b018ddf633 which accidentally changed > the return code to 0. Specifically guests probing for register existence > were affected by this. > > Signed-off-by: Jan Kiszka For the record (I know you have a revert-patch on

Re: [Qemu-devel] [PATCH 2/2] Revert "memory: Return -1 again on reads from unsigned regions"

2013-08-08 Thread Peter Maydell
On 3 August 2013 09:31, Jan Kiszka wrote: > From: Jan Kiszka > > This reverts commit 9b8c69243585a32d14b9bb9fcd52c37b0b5a1b71. > > The commit was wrong: We only return -1 on invalid accesses, not on > valid but unbacked ones. This broke various corner cases. > > Signed-off-by: Jan Kiszka This r

Re: [Qemu-devel] [PATCH 2/2] Revert "memory: Return -1 again on reads from unsigned regions"

2013-08-08 Thread Jan Kiszka
On 2013-08-08 17:23, Peter Maydell wrote: > On 3 August 2013 09:31, Jan Kiszka wrote: >> From: Jan Kiszka >> >> This reverts commit 9b8c69243585a32d14b9bb9fcd52c37b0b5a1b71. >> >> The commit was wrong: We only return -1 on invalid accesses, not on >> valid but unbacked ones. This broke various co

Re: [Qemu-devel] [PATCH V4 3/5] block: Enable the new throttling code in the block layer.

2013-08-08 Thread Paolo Bonzini
Il 08/08/2013 16:29, Benoît Canet ha scritto: > tip: Do not ever use the cfg scheduler in the guest with this code. > It gives incorrect throttling. This is not really accurate; the cfq scheduler reorders reads and writes to have longer bursts, and these sometimes exceed the rate you set. I

Re: [Qemu-devel] [PATCH] memory: Return -1 again on reads from unsigned regions

2013-08-08 Thread Jan Kiszka
On 2013-08-08 17:13, Peter Maydell wrote: > On 16 July 2013 13:45, Jan Kiszka wrote: >> This restore the behavior prior to b018ddf633 which accidentally changed >> the return code to 0. Specifically guests probing for register existence >> were affected by this. >> >> Signed-off-by: Jan Kiszka >

Re: [Qemu-devel] [PATCH 1/2] memory: Provide separate handling of unassigned io ports accesses

2013-08-08 Thread Peter Maydell
On 3 August 2013 09:31, Jan Kiszka wrote: > --- a/ioport.c > +++ b/ioport.c > @@ -44,6 +44,22 @@ typedef struct MemoryRegionPortioList { > MemoryRegionPortio ports[]; > } MemoryRegionPortioList; > > +static uint64_t unassigned_io_read(void *opaque, hwaddr addr, unsigned size) > +{ > +ret

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Anthony Liguori
Andreas Färber writes: > Am 08.08.2013 15:31, schrieb Anthony Liguori: >> Rusty Russell writes: >> >>> Virtio is currently defined to work as "guest endian", but this is a >>> problem if the guest can change endian. As most targets can't change >>> endian, we make it a per-target option to avo

Re: [Qemu-devel] [PATCH V4 3/5] block: Enable the new throttling code in the block layer.o

2013-08-08 Thread Benoît Canet
> This is not really accurate; the cfq scheduler reorders reads and writes > to have longer bursts, and these sometimes exceed the rate you set. I > understood this is mostly for separate rd/wr settings, or did you > reproduce it with "total" rates too? I'll drop the comment. It's only with read

Re: [Qemu-devel] [PATCH 1/2] memory: Provide separate handling of unassigned io ports accesses

2013-08-08 Thread Jan Kiszka
On 2013-08-08 17:33, Peter Maydell wrote: > On 3 August 2013 09:31, Jan Kiszka wrote: >> --- a/ioport.c >> +++ b/ioport.c >> @@ -44,6 +44,22 @@ typedef struct MemoryRegionPortioList { >> MemoryRegionPortio ports[]; >> } MemoryRegionPortioList; >> >> +static uint64_t unassigned_io_read(void *

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Daniel P. Berrange
On Thu, Aug 08, 2013 at 10:40:28AM -0500, Anthony Liguori wrote: > Andreas Färber writes: > >> We have a mechanism to do weak functions via stubs/. I think it would > >> be better to do cpu_get_byteswap() as a stub function and then overload > >> it in the ppc64 code. > > > > If this as your name

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Peter Maydell
On 8 August 2013 16:40, Anthony Liguori wrote: > PPC64 is big endian. AFAIK, there is no such thing as a little endian > PPC64 processor. What's your definition of "little endian processor" here if it isn't "one which is doing byte swaps of data"? I would describe a PPC64 with the relevant mode

[Qemu-devel] [PATCH v2 for-1.6] pc: disable pci-info for 1.6

2013-08-08 Thread Michael S. Tsirkin
The BIOS that we ship in 1.6 does not use pci info from host (yet). Several issues turned up (e.g. around winXP boot crashes). So it's safest to disable that interface for 1.6 machine types for now, leave it on for 1.7 so we have enough time to figure out the right way to fix issues if any. Cc: Ri

Re: [Qemu-devel] [PATCH] block: Bugfix 'format' and 'snapshot' used in drive option

2013-08-08 Thread Kevin Wolf
Am 08.08.2013 um 16:45 hat Mike Qiu geschrieben: > When use -drive file='xxx',format=qcow2,snapshot=on the error > message "Can't use snapshot=on with driver-specific options" > can be show, and fail to start the qemu. > > This should not be happened, and there is no file.driver option > in qemu c

Re: [Qemu-devel] [PATCH V4 3/5] block: Enable the new throttling code in the block layer.

2013-08-08 Thread Benoît Canet
> Also, it would be better to have a workaround for this. Perhaps we > could simply make the default value of max nonzero? In the old > throttling code the slice time is 0.1s, so perhaps we could see what > happens with max=0.1*avg. This gives correct results with cfg with some little auto compe

Re: [Qemu-devel] -cpu host (was Re: KVM call minutes for 2013-08-06)

2013-08-08 Thread Andreas Färber
Hi Peter, Am 08.08.2013 14:51, schrieb Peter Maydell: > [I missed this KVM call but the stuff about -cpu host ties into > an issue we've been grappling with for ARM KVM, so it seems > a reasonable jumping-off-point.] > > On 6 August 2013 16:15, Juan Quintela wrote: >> 2013-08-06 >> -- >>

Re: [Qemu-devel] [PATCH v2 for-1.6] pc: disable pci-info for 1.6

2013-08-08 Thread Richard Henderson
On 08/08/2013 05:55 AM, Michael S. Tsirkin wrote: > The BIOS that we ship in 1.6 does not use pci info > from host (yet). Several issues turned up > (e.g. around winXP boot crashes). So it's safest to disable that > interface for 1.6 machine types for now, leave it on for 1.7 > so we have enough ti

[Qemu-devel] [PATCH 11/14] hw/arm/versatilepb: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/versatilepb.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/arm/versatilepb.c b/hw/arm/versatilepb.c index b48d

[Qemu-devel] [PATCH 00/14] ARM: make IRQ/FIQ gpio lines on CPU object

2013-08-08 Thread Peter Maydell
This patch series makes IRQ and FIQ be inbound gpio lines on the ARMCPU object (which we can do now that it is a subclass of DeviceState). This allows us to drop the odd 'arm_pic' shim, which doesn't correspond to real hardware and existed purely to be a thing which exposed qemu_irqs. Peter Maydel

[Qemu-devel] [PATCH 06/14] hw/arm/kzm: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/kzm.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/arm/kzm.c b/hw/arm/kzm.c index bd6c05c..a248bf0 100644 ---

[Qemu-devel] [PATCH 14/14] hw/arm/pic_cpu: Remove the now-unneeded arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Now all the boards have been converted arm_pic_init_cpu() is unused and can just be deleted. Signed-off-by: Peter Maydell --- hw/arm/Makefile.objs |2 +- hw/arm/pic_cpu.c | 25 - include/hw/arm/arm.h |5 - 3 files changed, 1 insertion(+), 31 deletions(-)

[Qemu-devel] [PATCH 13/14] hw/arm/xilinx_zynq: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/xilinx_zynq.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index 3444

[Qemu-devel] [PATCH 12/14] hw/arm/vexpress: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/vexpress.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c index 9586e38..fbd

[Qemu-devel] [PATCH 02/14] hw/arm/armv7m: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/armv7m.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c index 82d36fb..89a9015 1006

[Qemu-devel] [PATCH 03/14] hw/arm/exynos4210: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/exynos4210.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c ind

[Qemu-devel] [PATCH 04/14] hw/arm/highbank: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/highbank.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index 35d5511..f733a6c

[Qemu-devel] [PATCH 09/14] hw/arm/realview: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/realview.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/realview.c b/hw/arm/realview.c index 3060f48..82ec02d

Re: [Qemu-devel] [PATCH] tcg/mips: fix invalid op definition errors

2013-08-08 Thread Richard Henderson
On 08/08/2013 04:40 AM, James Hogan wrote: > tcg/mips/tcg-target.h defines various operations conditionally depending > upon the isa revision, however these operations are included in > mips_op_defs[] unconditionally resulting in the following runtime errors > if CONFIG_DEBUG_TCG is defined: > > I

[Qemu-devel] [PATCH 08/14] hw/arm/omap*: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/omap1.c |8 hw/arm/omap2.c |8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/arm/omap1.c b/hw/arm/om

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Anthony Liguori
Peter Maydell writes: > On 8 August 2013 16:40, Anthony Liguori wrote: >> PPC64 is big endian. AFAIK, there is no such thing as a little endian >> PPC64 processor. > > What's your definition of "little endian processor" here if > it isn't "one which is doing byte swaps of data"? I would > descr

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Anthony Liguori
"Daniel P. Berrange" writes: > On Thu, Aug 08, 2013 at 10:40:28AM -0500, Anthony Liguori wrote: >> Andreas Färber writes: >> >> We have a mechanism to do weak functions via stubs/. I think it would >> >> be better to do cpu_get_byteswap() as a stub function and then overload >> >> it in the ppc

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Peter Maydell
On 8 August 2013 17:07, Anthony Liguori wrote: > It's the same processor. It still starts executing big endian > instructions. A magic register value is tweaked and loads/stores are > swapped. I dunno about PPC, but for ARM generally the boot-up state is controlled by config signals which a SoC

[Qemu-devel] [PATCH 10/14] hw/arm/strongarm: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/strongarm.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c index 82a9492..7b

  1   2   >