Re: [Qemu-devel] [PATCH v3 04/19] block: update bs->total_sectors on writes

2013-08-02 Thread Peter Lieven
On 29.07.2013 16:18, Paolo Bonzini wrote: Il 29/07/2013 16:10, Kevin Wolf ha scritto: Am 29.07.2013 um 15:47 hat Paolo Bonzini geschrieben: Il 29/07/2013 15:13, Kevin Wolf ha scritto: Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: If a BlockDriverState is growable, after every write we

[Qemu-devel] [PATCH for-1.6 1/2] don't create pvpanic device by default.

2013-08-02 Thread Hu Tao
The problem with pvpanic being an internal device is that VMs running operating systems without a driver for this device will have problems when qemu will be upgraded (from qemu without this pvpanic). The outcome may be, for example: in Windows(let's say XP) the Device manager will open a "new dev

[Qemu-devel] [PATCH for-1.6 2/2] pvpanic: make pvpanic known to user

2013-08-02 Thread Hu Tao
Thus user can create pvpanic by -device. Signed-off-by: Hu Tao --- hw/misc/pvpanic.c| 23 --- include/hw/i386/pc.h | 3 --- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c index 7bb49a5..6e4c53e 100644 --- a/hw/misc/p

Re: [Qemu-devel] default slot used for vga device on q35 machines

2013-08-02 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> qemu-kvm -M q35 -nodefaults -nodefconfig -qmp unix:/tmp/qemu,server >> -vnc :15 -vga std -usb >> >> Then ran "query-pci" in the qmp monitor and found that the vga device is >> put at slot 1 instead of slot 2. >> >> My questions: >> >> 1) Is this difference

Re: [Qemu-devel] [PATCH v3 1/7] vvfat: use bdrv_new() to allocate BlockDriverState

2013-08-02 Thread Wenchao Xia
Reviewed-by: Wenchao Xia > we need bdrv_new() to properly initialize BDS, don't allocate memory > manually. > > Signed-off-by: Fam Zheng > --- > block/vvfat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/vvfat.c b/block/vvfat.c > index cd3b8ed..a827d91 1006

Re: [Qemu-devel] [PATCH 1/2] raw: add license header

2013-08-02 Thread Peter Lieven
On 31.07.2013 10:01, Markus Armbruster wrote: Paolo Bonzini writes: Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. Cc: Christoph Hellwig Cc: Kevin Wolf Cc: Anthony Li

Re: [Qemu-devel] net/tap.c: Possibly a way to stall tap input

2013-08-02 Thread Stefan Hajnoczi
On Thu, Aug 01, 2013 at 07:24:13PM +0200, Jan Kiszka wrote: > On 2013-08-01 19:15, Jan Kiszka wrote: > > Hi all, > > > > I'm tracking down a nasty stall of tap input over a custom 1.3.x QEMU > > version. Under certain load, our tap backend stops reading from the char > > device, and that even if w

[Qemu-devel] [PATCH] qemu-option: Guard against qemu_opts_set_defaults() misuse

2013-08-02 Thread Markus Armbruster
Commit 6d4cd40 fixed qemu_opts_set_defaults() for an existing corner case, but broke it for another one that can't be reached in current code. Quote from its commit message: I believe [opts_parse()] attempts to do the following: If options don't yet exist, create new options

Re: [Qemu-devel] [PATCH v3 2/7] iscsi: use bdrv_new() instead of stack structure

2013-08-02 Thread Wenchao Xia
于 2013-7-31 18:13, Fam Zheng 写道: > BlockDriverState structure needs bdrv_new() to initialize refcnt, don't > allocate a local structure variable and memset to 0, becasue with coming > refcnt implementation, bdrv_unref will crash if bs->refcnt not > initialized to 1. > > Signed-off-by: Fam Zheng >

Re: [Qemu-devel] [PATCH v3 3/7] block: implement reference count for BlockDriverState

2013-08-02 Thread Wenchao Xia
Reviewed-by: Wenchao Xia > Introduce bdrv_ref/bdrv_unref to manage the lifecycle of > BlockDriverState. They are unused for now but will used to replace > bdrv_delete() later. > > Signed-off-by: Fam Zheng > --- > block.c | 21 + > include/block/block.h

Re: [Qemu-devel] net/tap.c: Possibly a way to stall tap input

2013-08-02 Thread Jan Kiszka
On 2013-08-02 09:33, Stefan Hajnoczi wrote: > On Thu, Aug 01, 2013 at 07:24:13PM +0200, Jan Kiszka wrote: >> On 2013-08-01 19:15, Jan Kiszka wrote: >>> Hi all, >>> >>> I'm tracking down a nasty stall of tap input over a custom 1.3.x QEMU >>> version. Under certain load, our tap backend stops readin

Re: [Qemu-devel] [PATCH v3 4/7] block: make bdrv_delete() static

2013-08-02 Thread Wenchao Xia
Reviewed-by: Wenchao Xia -- Best Regards Wenchao Xia

[Qemu-devel] [PATCH EMBARGOED 5/7] vmdk: check cluster size in vmdk_open

2013-08-02 Thread Fam Zheng
VMDK specification doesn't give upper limit of cluster size (header.grainSize). But we need to avoid unbounded memory allocation. Check the value when opening and refuse too big value (>512MB cluster size). Signed-off-by: Fam Zheng --- block/vmdk.c | 1 + tests/qemu-iotests/059

[Qemu-devel] [PATCH EMBARGOED 2/7] vmdk: use unsigned values for on disk header fields

2013-08-02 Thread Fam Zheng
The size and offset fields are all non-negative values, use uint64_t for them to avoid getting negative in memory value by int overflow. Signed-off-by: Fam Zheng --- block/vmdk.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c inde

[Qemu-devel] [PATCH EMBARGOED 1/7] vmdk: Make VMDK3Header QEMU_PACKED

2013-08-02 Thread Fam Zheng
Although the fields are all uint32_t, it's best to make it consistent that all on disk structures are QEMU_PACKED. Signed-off-by: Fam Zheng --- block/vmdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index 3756333..8ff43b9 100644 --- a/block/v

Re: [Qemu-devel] [PATCH v3 5/7] migration: omit drive ref as we have bdrv_ref now

2013-08-02 Thread Wenchao Xia
There should be a section of code in device hot unplug, checking DriverInfo's ref, fail or do nothing when ref != 1. But I haven't found that code, so not sure whether this patch will change the behavior in device hot unplug. > block-migration.c does not actually use DriveInfo anywhere. Hence it'

Re: [Qemu-devel] [sheepdog] [PATCH v4 06/10] coroutine: add co_aio_sleep_ns() to allow sleep in block drivers

2013-08-02 Thread liu ping fan
On Fri, Aug 2, 2013 at 2:20 PM, MORITA Kazutaka wrote: > At Tue, 30 Jul 2013 15:58:58 +0200, > Stefan Hajnoczi wrote: >> >> On Fri, Jul 26, 2013 at 03:10:48PM +0900, MORITA Kazutaka wrote: >> > This helper function behaves similarly to co_sleep_ns(), but the >> > sleeping coroutine will be resumed

[Qemu-devel] [PATCH EMBARGOED 3/7] qemu-iotests: add empty test case for vmdk

2013-08-02 Thread Fam Zheng
Will add vmdk specific tests later here. Signed-off-by: Fam Zheng --- tests/qemu-iotests/059 | 51 ++ tests/qemu-iotests/059.out | 2 ++ tests/qemu-iotests/group | 1 + 3 files changed, 54 insertions(+) create mode 100755 tests/qemu-iotests/05

Re: [Qemu-devel] [PATCH v3 6/7] xen_disk: simplify blk_disconnect with refcnt

2013-08-02 Thread Wenchao Xia
Better to split it into two patches: 1 bugfix: always call bdrv_detach_dev(). 2 use refcnt to manage lifecycle. > We call bdrv_attach_dev when initializing whether or not bs is created > locally, so call bdrv_detach_dev and let the refcnt handle the > lifecycle. > > Signed-off-by: Fam Zheng > --

Re: [Qemu-devel] [PATCH for-1.6 1/2] don't create pvpanic device by default.

2013-08-02 Thread Paolo Bonzini
On 08/02/2013 09:04 AM, Hu Tao wrote: The problem with pvpanic being an internal device is that VMs running operating systems without a driver for this device will have problems when qemu will be upgraded (from qemu without this pvpanic). The outcome may be, for example: in Windows(let's say XP)

Re: [Qemu-devel] [PATCH v3 7/7] nbd: use BlockDriverState refcnt

2013-08-02 Thread Wenchao Xia
Reviewed-by: Wenchao Xia > Previously, nbd calls drive_get_ref() on the drive of bs. A BDS doesn't > always have associated dinfo, which nbd doesn't care either. We already > have BDS ref count, so use it to make it safe for a BDS w/o blockdev. > > Signed-off-by: Fam Zheng -- Best Regards

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-02 Thread Paolo Bonzini
On 08/02/2013 12:42 AM, Eric Blake wrote: On 08/01/2013 04:23 PM, Paolo Bonzini wrote: Automatic devices with no command line argument have proven to be a nightmare for libvirt as well. Although the just-released libvirt 1.1.1 now supports the element for controlling the command line parameter

[Qemu-devel] [PATCH EMBARGOED 4/7] vmdk: check granularity field in opening

2013-08-02 Thread Fam Zheng
Granularity is used to calculate the cluster size and allocate r/w buffer. Check the value from image before using it, so we don't abort() for unbounded memory allocation. Signed-off-by: Fam Zheng --- block/vmdk.c | 13 + tests/qemu-iotests/059 | 6 ++ 2 files changed,

[Qemu-devel] [PATCH V5 0/6] Refine and export backing file loop check

2013-08-02 Thread Xu Wang
From: Xu Wang If there is loop exists in the backing file chain, many problems could be caused by it, such as no response and segment fault during system boot. Hence stopping backing file loop appear is very necessary. These patches refine and export loop checking function from collect_image_ inf

[Qemu-devel] [PATCH V5 3/6] block: Add WIN32 platform support for backing_file_loop_check()

2013-08-02 Thread Xu Wang
From: Xu Wang Method of get_inode is different between Linux and WIN32 plateform. This patch added inode caculate method on Windows plateform so that backing file check could work on Windows plateform. Signed-off-by: Xu Wang --- block.c | 156 +++

[Qemu-devel] [PATCH V5 6/6] block: Add infinite loop check in drive_init()

2013-08-02 Thread Xu Wang
From: Xu Wang Backing file should be checked if there is a loop in it during image boot. Becase if there is loop qemu would no response for a long time and segment fault occured. So this patch would check backing file chain if there is loop in it before open image. Signed-off-by: Xu Wang --- b

[Qemu-devel] [PATCH V5 2/6] qemu-img: Add infinite loop checking in bdrv_new_open()

2013-08-02 Thread Xu Wang
From: Xu Wang Every image should be checked if there is infinite loop in backing file chain before open it. So infinite loop check was added into bdrv_new_open(). If @filename is opened with no flags BDRV_O_NO_BACKING, the infinite loop check should be called. Signed-off-by: Xu Wang --- qemu-i

[Qemu-devel] [PATCH V5 4/6] block: Check infinite loop in bdrv_img_create()

2013-08-02 Thread Xu Wang
From: Xu Wang Backing file loop should be checked before qemu-img create command execution. If loop was found, qemu-img create should be stopped and an error was printed. Signed-off-by: Xu Wang --- block.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b

[Qemu-devel] [PATCH V5 1/6] block/qemu-img: Refine and export infinite loop checking in collect_image_info_list()

2013-08-02 Thread Xu Wang
From: Xu Wang If there is a loop exists in the backing file chain, many problems could be caused by it, such as no response and segment fault during system boot. Hence stopping backing file loop appear is very necessary. This patch refine and export loop checking function from collect_image_ info

[Qemu-devel] [PATCH V5 5/6] block: Add backing file loop check in change_backing_file()

2013-08-02 Thread Xu Wang
From: Xu Wang Backing file loop should be checked before calling change_backing_ file(). If loop appeared, this calling should be stopped and an error was printed. Signed-off-by: Xu Wang --- block.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/block.c b/block.c index 8bb63c2..a14

[Qemu-devel] [PATCH v2] target-mips: fix 34Kf configuration for DSP ASE

2013-08-02 Thread Yongbok Kim
34Kf core does support DSP ASE. CP0_Config3 configuration for 34Kf and description are wrong. Please refer to MIPS32(R) 34Kf(TM) Processor Core Datasheet Signed-off-by: Yongbok Kim --- changes from v1: make status.MX writeable target-mips/translate_init.c |7 +++ 1 files changed, 3 in

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-02 Thread Daniel P. Berrange
On Fri, Aug 02, 2013 at 10:31:11AM +0200, Paolo Bonzini wrote: > On 08/02/2013 12:42 AM, Eric Blake wrote: > >On 08/01/2013 04:23 PM, Paolo Bonzini wrote: > >>>Automatic devices with no command line argument have proven to be a > >>>nightmare for libvirt as well. Although the just-released libvirt

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-02 Thread Paolo Bonzini
On Aug 02 2013, liu ping fan wrote: > On Thu, Aug 1, 2013 at 10:28 PM, Paolo Bonzini wrote: > > > > > > So actually there is another problem with this patch (both the > > > > > > condvar and the event approach are equally buggy). If a timer > > > > > > on clock X disables clock X, qemu_clock_ena

[Qemu-devel] [Bug 1207686] [NEW] qemu-1.4.0 and onwards, linux kernel 3.2.x, heavy I/O leads to kernel_hung_tasks_timout_secs message and unresponsive qemu-process

2013-08-02 Thread Oliver Francke
Public bug reported: Hi, after some testing I tried to narrow down a problem, which was initially reported by some users. Seen on different distros - debian 7.1, ubuntu 12.04 LTS, IPFire-2.3 as reported by now. All using some flavour of linux-3.2.x kernel. Tried e.g. under Ubuntu an upgrade t

Re: [Qemu-devel] net/tap.c: Possibly a way to stall tap input

2013-08-02 Thread Stefan Hajnoczi
On Thu, Aug 01, 2013 at 07:15:54PM +0200, Jan Kiszka wrote: > I was digging into the involved code and found something fishy: > > net/tap.c: > static void tap_send(void *opaque) > { > ... > size = qemu_send_packet_async(&s->nc, buf, size, > tap_sen

Re: [Qemu-devel] [PATCH for-1.6 2/2] pvpanic: make pvpanic known to user

2013-08-02 Thread Andreas Färber
Am 02.08.2013 09:04, schrieb Hu Tao: > Thus user can create pvpanic by -device. > > Signed-off-by: Hu Tao > --- > hw/misc/pvpanic.c| 23 --- > include/hw/i386/pc.h | 3 --- > 2 files changed, 8 insertions(+), 18 deletions(-) > > diff --git a/hw/misc/pvpanic.c b/hw/misc/

Re: [Qemu-devel] [PATCH for 1.6] tci: Fix broken build (compiler warning caused by redefined macro BIT)

2013-08-02 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] seccomp: add additional asynchronous I/O syscalls

2013-08-02 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v2 for-1.6] chardev: fix CHR_EVENT_OPENED events for mux chardevs

2013-08-02 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.6 v3 0/7] pc: limit 64 bit hole to 2G by default

2013-08-02 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] net/tap.c: Possibly a way to stall tap input

2013-08-02 Thread Jan Kiszka
On 2013-08-02 13:46, Stefan Hajnoczi wrote: > On Thu, Aug 01, 2013 at 07:15:54PM +0200, Jan Kiszka wrote: >> I was digging into the involved code and found something fishy: >> >> net/tap.c: >> static void tap_send(void *opaque) >> { >> ... >> size = qemu_send_packet_async(&s->nc, buf, s

Re: [Qemu-devel] [PATCH] seccomp: add arch_prctl() to the syscall whitelist

2013-08-02 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [RFC] [PATCHv4 10/13] aio / timers: Convert mainloop to use timeout

2013-08-02 Thread Alex Bligh
Paolo, (apologies for taking a little time to reply to this one) --On 1 August 2013 16:14:11 +0200 Paolo Bonzini wrote: >> @@ -449,6 +460,7 @@ int main_loop_wait(int nonblocking) >> { >> int ret; >> uint32_t timeout = UINT32_MAX; >> +int64_t timeout_ns; >> >> if (nonblocking)

Re: [Qemu-devel] [PATCH for-1.6 0/2] Fix clang warnings in linux-user signal code

2013-08-02 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 1/3] rdma: don't use negative index to array

2013-08-02 Thread Michael R. Hines
On 08/01/2013 11:56 PM, Isaku Yamahata wrote: Cc: Michael R. Hines Signed-off-by: Isaku Yamahata --- migration-rdma.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/migration-rdma.c b/migration-rdma.c index 4828738..edbae9f 100644 --- a/mi

[Qemu-devel] [Bug 1207623] [NEW] 64bit RHEL6.4 guest crashes and reboots continuously

2013-08-02 Thread Yongjie Ren
Public bug reported: Environment: Host OS (ia32/ia32e/IA64):ia32e Guest OS (ia32/ia32e/IA64):ia32e Guest OS Type (Linux/Windows):Linux kvm.git next Commit:9576c4cd6b6fa5716400e63618757b76cff6a813 qemu-kvm uq/master Commit:0779caeb1a17f4d3ed14e2925b36ba09b084fb7b Host Kernel Version:3.

Re: [Qemu-devel] [v2][PATCH 1/1] cpus: use cpu_is_stopped efficiently

2013-08-02 Thread Andreas Färber
Am 02.08.2013 03:43, schrieb Tiejun Chen: > It makes more sense and simple later. > > Signed-off-by: Tiejun Chen > --- > v1 -> v2: > > To optimize performance slightly, we can reorder the two conditions to > avoid the non-inline function call if cpu->stopped. Patch doesn't apply to qemu.git: ne

Re: [Qemu-devel] [PATCH] qemu-option: Guard against qemu_opts_set_defaults() misuse

2013-08-02 Thread Eric Blake
On 08/02/2013 01:34 AM, Markus Armbruster wrote: > Commit 6d4cd40 fixed qemu_opts_set_defaults() for an existing corner > case, but broke it for another one that can't be reached in current > code. > > > Not reachable, because we never pass lists with !list->merge_lists to > qemu_opts_set_defaul

Re: [Qemu-devel] [PATCH 3/3] rdma: use RDMA_WRID_READY

2013-08-02 Thread Michael R. Hines
On 08/01/2013 11:56 PM, Isaku Yamahata wrote: Cc: Michael R. Hines Signed-off-by: Isaku Yamahata --- migration-rdma.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration-rdma.c b/migration-rdma.c index 67069d2..871f9cd 100644 --- a/migration-rdma.c +++ b/migr

Re: [Qemu-devel] [PATCH 2/3] rdma: qemu_rdma_post_send_control uses wrongly RDMA_WRID_MAX

2013-08-02 Thread Michael R. Hines
On 08/01/2013 11:56 PM, Isaku Yamahata wrote: RDMA_WRID_CONTROL should be used. And remove related work around. Cc: Michael R. Hines Signed-off-by: Isaku Yamahata --- migration-rdma.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/migration-rdma.c b/migra

Re: [Qemu-devel] [PATCH 0/3] rdma fixes and clean ups

2013-08-02 Thread Michael R. Hines
On 08/01/2013 11:56 PM, Isaku Yamahata wrote: Small fixes/clean up to rdma. found through code review. Isaku Yamahata (3): rdma: don't use negative index to array rdma: qemu_rdma_post_send_control uses wrongly RDMA_WRID_MAX rdma: use RDMA_WRID_READY migration-rdma.c | 43 ++

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmdk: fix comment for vmdk_co_write_zeroes

2013-08-02 Thread Michael Tokarev
01.08.2013 14:12, Fam Zheng wrote: The comment was truncated. Add the missing parts, especially explain why we need zero_dry_run. Thanks, applied to the trivial patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] block/iscsi.c: Fix printf format error.

2013-08-02 Thread Michael Tokarev
Thanks, applied to the trivial patches queue. /mjt

[Qemu-devel] [PULL 4/4] vmdk: fix comment for vmdk_co_write_zeroes

2013-08-02 Thread Michael Tokarev
From: Fam Zheng The comment was truncated. Add the missing parts, especially explain why we need zero_dry_run. Signed-off-by: Fam Zheng Signed-off-by: Michael Tokarev --- block/vmdk.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c in

[Qemu-devel] [PULL 0/4] trivial patches for 2013-08-02

2013-08-02 Thread Michael Tokarev
The following changes since commit 2ddc463725d0fa24e0910fba77fef2777fa94a74: Merge remote-tracking branch 'afaerber/tags/qom-cpu-for-anthony' into staging (2013-08-01 17:09:35 -0500) are available in the git repository at: git://git.corpit.ru/qemu.git trivial-patches for you to fetch chang

[Qemu-devel] [PULL 2/4] block/iscsi.c: Fix printf format error.

2013-08-02 Thread Michael Tokarev
From: "Richard W.M. Jones" The error on armv7hl was: block/iscsi.c: In function ‘is_request_lun_aligned’: block/iscsi.c:251:26: error: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘int64_t’ [-Werror=format=] iscsilun->block_size, sector_num

[Qemu-devel] [PULL 1/4] qemu-ga: build it even if !system

2013-08-02 Thread Michael Tokarev
Move qemu-ga build check out of if softmmu.. into its own section. We want to build qemu-ga for _guest_ even if system build isn't done. It is controlled separately using --enable-guest-agent. Additionally, give error message if guest agent is requested but not supported. Signed-off-by: Michael T

[Qemu-devel] [PULL 3/4] memory.c: drop kvm.h dependency

2013-08-02 Thread Michael Tokarev
From: "Michael S. Tsirkin" memory.c does not use any kvm specific interfaces, don't include kvm.h Signed-off-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- memory.c |1 - 1 file changed, 1 deletion(-) diff --git a/memory.c b/memory.c index ac6f3c6..886

[Qemu-devel] [PATCH v6] e1000: add interrupt mitigation support

2013-08-02 Thread Vincenzo Maffione
This patch partially implements the e1000 interrupt mitigation mechanisms. Using a single QEMUTimer, it emulates the ITR register (which is the newer mitigation register, recommended by Intel) and approximately emulates RADV and TADV registers. TIDV and RDTR register functionalities are not emulate

Re: [Qemu-devel] [Qemu-trivial] [PATCH] memory.c: drop kvm.h dependency

2013-08-02 Thread Michael Tokarev
01.08.2013 12:39, Paolo Bonzini wrote: memory.c does not use any kvm specific interfaces, don't include kvm.h Thanks, applied to the trivial patches queue. /mjt

[Qemu-devel] [PATCH 2/2] Add ARM registers definitions in Monitor commands

2013-08-02 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- monitor.c | 17 + 1 file changed, 17 insertions(+) diff --git a/monitor.c b/monitor.c index 5dc0aa9..78e93af 100644 --- a/monitor.c +++ b/monitor.c @@ -3167,6 +3167,23 @@ static const MonitorDef monitor_defs[] = { { "cleanwin", offsetof(

Re: [Qemu-devel] KVM call agenda for 2013-08-06

2013-08-02 Thread Eduardo Habkost
On Tue, Jul 23, 2013 at 06:31:45PM +0200, Juan Quintela wrote: > > Hi > > Please, send any topic that you are interested in covering. * libvirt requirements for: * Checking which CPU features are exposed/required by each CPU model + machine-type * Checking which CPU features are avail

Re: [Qemu-devel] [PATCH v2 0/2] Fix qdev 32-bit compilation

2013-08-02 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v2 15/17] raw-posix: detect XFS unwritten extents

2013-08-02 Thread Christoph Hellwig
On Tue, Jul 16, 2013 at 06:29:26PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini This isn't really XFS specific, at least ext4 and ocfs2 can report the same.

Re: [Qemu-devel] [Bug 1207686] [NEW] qemu-1.4.0 and onwards, linux kernel 3.2.x, heavy I/O leads to kernel_hung_tasks_timout_secs message and unresponsive qemu-process

2013-08-02 Thread Stefan Hajnoczi
On Fri, Aug 02, 2013 at 09:58:29AM -, Oliver Francke wrote: > after some testing I tried to narrow down a problem, which was initially > reported by some users. > Seen on different distros - debian 7.1, ubuntu 12.04 LTS, IPFire-2.3 as > reported by now. > > All using some flavour of linux-3.

Re: [Qemu-devel] Error handling in cpu_x86_create

2013-08-02 Thread Jan Kiszka
On 2013-07-30 14:21, Igor Mammedov wrote: > On Tue, 30 Jul 2013 13:00:40 +0200 > Jan Kiszka wrote: > >> Hi Igor, >> >> just noticed by chance that error handling in cpu_x86_create is likely >> broken after your changes. Any error after cpu = ...object_new() will >> not properly release the CPU ob

[Qemu-devel] [RFC V3 1/2] throttle: Add a new throttling API implementing continuus leaky bucket.

2013-08-02 Thread Benoît Canet
Implement the continuous leaky bucket algorithm devised on IRC as a separate module. Signed-off-by: Benoit Canet --- include/qemu/throttle.h | 111 util/Makefile.objs |1 + util/throttle.c | 436 +++ 3 files changed, 548

[Qemu-devel] [RFC V3 2/2] block: Enable the new throttling code in the block layer.

2013-08-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block.c | 316 +++-- block/qapi.c | 21 ++- blockdev.c| 115 + include/block/block.h |1 - include/block/block_int.h | 33 + 5 files changed, 15

Re: [Qemu-devel] [PULL 1/4] qemu-ga: build it even if !system

2013-08-02 Thread Andreas Färber
Am 02.08.2013 16:20, schrieb Michael Tokarev: > Move qemu-ga build check out of if softmmu.. into its own section. > We want to build qemu-ga for _guest_ even if system build isn't > done. It is controlled separately using --enable-guest-agent. > Additionally, give error message if guest agent is

Re: [Qemu-devel] [PATCH 4/4] xics: Support for in-kernel XICS interrupt controller

2013-08-02 Thread Alexey Kardashevskiy
On 08/01/2013 11:29 AM, Andreas Färber wrote: > Am 01.08.2013 02:14, schrieb Alexey Kardashevskiy: >> On 08/01/2013 05:52 AM, Andreas Färber wrote: >>> Am 17.07.2013 08:37, schrieb Alexey Kardashevskiy: + +icp->ss = g_malloc0(icp->nr_servers*sizeof(ICPState)); +for (i = 0; i

Re: [Qemu-devel] [PATCH] target-ppc: Add POWER7+ CPU model

2013-08-02 Thread Andreas Färber
Am 02.08.2013 04:59, schrieb Alexey Kardashevskiy: > This patch adds CPU PVR definition for POWER7+. > > Signed-off-by: Alexey Kardashevskiy > --- > target-ppc/cpu-models.c | 2 ++ > target-ppc/cpu-models.h | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/target-ppc/cpu-models.c b/tar

[Qemu-devel] [Bug 1207825] [NEW] "change ide1-cd0 /path/to/file.iso" doesn't work in qemu-kvm

2013-08-02 Thread Ruslan
Public bug reported: I'm using qemu-kvm from git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm , version qemu-kvm-1.2.0-703-g4d9367b, and when I try putting an ISO image to virtual CD drive via "change ide1-cd0 /path/to/file.iso", Windows XP guest says "I/O error reading CD". At the same time, usi

Re: [Qemu-devel] [PATCH for-1.6] pc: disable pci-info for 1.6

2013-08-02 Thread Richard Henderson
On 08/01/2013 02:42 AM, Michael S. Tsirkin wrote: > -static void pc_init_pci_1_5(QEMUMachineInitArgs *args) > +static void pc_init_pci_1_6(QEMUMachineInitArgs *args) > { > has_pci_info = false; > pc_init_pci(args); > } > > +static void pc_init_pci_1_5(QEMUMachineInitArgs *args) > +{ >

[Qemu-devel] [PATCH] target-arm: Implement 'int' loglevel

2013-08-02 Thread Peter Maydell
The 'int' loglevel for recording interrupts and exceptions requires support in the target-specific code. Implement it for ARM. This improves debug logging in some situations that were otherwise pretty opaque, such as when we fault trying to execute at an exception vector address, which would otherw

[Qemu-devel] [PATCH for-1.6] target-i386: Fix X86CPU error handling

2013-08-02 Thread Andreas Färber
Error **errp argument is not for emitting warnings, it means an error has occurred and the caller should not make any assumptions about the state of other return values (unless otherwise documented). Therefore cpu_x86_create() must unref the new X86CPU itself, and pc_new_cpu() must check for an Er

Re: [Qemu-devel] default slot used for vga device on q35 machines

2013-08-02 Thread Markus Armbruster
Laine Stump writes: > On 08/02/2013 03:23 AM, Markus Armbruster wrote: >> Gerd Hoffmann writes: >> >>> Hi, >>> qemu-kvm -M q35 -nodefaults -nodefconfig -qmp unix:/tmp/qemu,server -vnc :15 -vga std -usb Then ran "query-pci" in the qmp monitor and found that the vga device

Re: [Qemu-devel] [PATCH 7/7] pc: limit 64 bit hole to 2G by default

2013-08-02 Thread Andreas Färber
Am 29.07.2013 16:47, schrieb Igor Mammedov: > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index b0b98a8..a2b9d88 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c [...] > @@ -1003,15 +1004,27 @@ typedef struct PcRomPciInfo { > static void pc_fw_cfg_guest_info(PcGuestInfo *guest_info) > { > PcR

[Qemu-devel] [Bug 1204697] Re: guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/rdmsr

2013-08-02 Thread Christoph Anton Mitterer
Having tried now with virtio as well: works So: virtio, ide = OK sata = broken -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1204697 Title: guest disk accesses lead to ATA errors + host vcpu0 unha

Re: [Qemu-devel] default slot used for vga device on q35 machines

2013-08-02 Thread Laine Stump
On 08/02/2013 03:23 AM, Markus Armbruster wrote: > Gerd Hoffmann writes: > >> Hi, >> >>> qemu-kvm -M q35 -nodefaults -nodefconfig -qmp unix:/tmp/qemu,server >>> -vnc :15 -vga std -usb >>> >>> Then ran "query-pci" in the qmp monitor and found that the vga device is >>> put at slot 1 instead of

Re: [Qemu-devel] [PATCH 3/7] arch_init: add ram_madvise_free()

2013-08-02 Thread Michael R. Hines
On 06/16/2013 12:04 PM, Anthony Liguori wrote: Lei Li writes: Signed-off-by: Lei Li --- arch_init.c | 13 + include/migration/migration.h |3 +++ 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index 872020e..fc

Re: [Qemu-devel] [PATCH 04/12] arch_init: introduce ram_page_save()

2013-08-02 Thread Michael R. Hines
On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li --- arch_init.c | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index a8b91ee..a418071 100644 --- a/arch_init.c +++ b/arch_i

Re: [Qemu-devel] net/tap.c: Possibly a way to stall tap input

2013-08-02 Thread Jan Kiszka
On 2013-08-02 14:45, Jan Kiszka wrote: > On 2013-08-02 13:46, Stefan Hajnoczi wrote: >> On Thu, Aug 01, 2013 at 07:15:54PM +0200, Jan Kiszka wrote: >>> I was digging into the involved code and found something fishy: >>> >>> net/tap.c: >>> static void tap_send(void *opaque) >>> { >>> ... >>>

Re: [Qemu-devel] [PATCH 05/12] arch_init: introduce ram_save_local()

2013-08-02 Thread Michael R. Hines
On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li --- arch_init.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index a418071..7eeb52f 100644 --- a/arch_init.c +++ b/arch_init.c @@ -757,6 +757,38 @@

Re: [Qemu-devel] [PATCH 06/12] arch_init: add save_local_setup to savevm_ram_handlers

2013-08-02 Thread Michael R. Hines
On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li --- arch_init.c |1 + include/migration/vmstate.h |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index 7eeb52f..5c25005 100644 --- a/arch_init.c +++ b/arch_ini

Re: [Qemu-devel] net/tap.c: Possibly a way to stall tap input

2013-08-02 Thread Jan Kiszka
On 2013-08-02 14:45, Jan Kiszka wrote: > On 2013-08-02 13:46, Stefan Hajnoczi wrote: >> On Thu, Aug 01, 2013 at 07:15:54PM +0200, Jan Kiszka wrote: >>> I was digging into the involved code and found something fishy: >>> >>> net/tap.c: >>> static void tap_send(void *opaque) >>> { >>> ... >>>

Re: [Qemu-devel] [PATCH 09/12] migration-local: implementation of outgoing part

2013-08-02 Thread Michael R. Hines
On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li --- Makefile.objs |1 + include/migration/migration.h | 15 migration-local.c | 158 + migration-unix.c | 13 qapi-schema.json

[Qemu-devel] [PATCH] net: Rename send_queue to incoming_queue

2013-08-02 Thread Jan Kiszka
From: Jan Kiszka Each networking client has a queue for packets that could not yet be delivered to that client. Calling this queue "send_queue" is highly confusing as it has nothing to to with packets send from this client but to it. Avoid this confusing by renaming it to "incoming_queue". Signe

Re: [Qemu-devel] [PATCH 11/12] migration-local: add option to commandline for incoming-local

2013-08-02 Thread Michael R. Hines
On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li --- qemu-options.hx |9 + vl.c| 14 ++ 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 8355f9b..a975e83 100644 --- a/qemu-options.hx +++ b

Re: [Qemu-devel] [PATCH 12/12] hmp: add hmp_localhost_migration interface

2013-08-02 Thread Michael R. Hines
On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li --- hmp-commands.hx | 17 + hmp.c | 13 + hmp.h |1 + 3 files changed, 31 insertions(+), 0 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 915b0d1..ed21970

Re: [Qemu-devel] [PATCH 07/12] savevm: introduce qemu_savevm_local()

2013-08-02 Thread Michael R. Hines
On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li --- include/sysemu/sysemu.h |1 + savevm.c| 55 +++ 2 files changed, 56 insertions(+), 0 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-02 Thread Stefan Hajnoczi
On Fri, Aug 02, 2013 at 11:33:40AM +0800, liu ping fan wrote: > On Thu, Aug 1, 2013 at 9:28 PM, Alex Bligh wrote: > > Paolo, > > > > > > --On 1 August 2013 08:19:34 -0400 Paolo Bonzini wrote: > > > >>> > True, qemu_event basically works only when a single thread resets it. > >>> > But there is no

[Qemu-devel] [RFC V3 0/2] continuous leaky bucket throttling

2013-08-02 Thread Benoît Canet
This patchset implement continous leaky bucket throttling. It works mostly on the general case. The exception is where the load is composed of both reads and writes and two limits iops_rd and iops_wr are set. The resulting iops are a little above half of the given limits. I tried various strategie

Re: [Qemu-devel] [PATCH v3 5/7] migration: omit drive ref as we have bdrv_ref now

2013-08-02 Thread Stefan Hajnoczi
On Fri, Aug 02, 2013 at 04:13:55PM +0800, Wenchao Xia wrote: > There should be a section of code in device hot unplug, checking > DriverInfo's ref, fail or do nothing when ref != 1. But I haven't found > that code, so not sure whether this patch will change the behavior in > device hot unplug. It

Re: [Qemu-devel] Using virtio-mmio

2013-08-02 Thread Erlon Cruz
Hi, Im trying to test virtio-mmio too but Im having no success to boot vexpress-a9. kernel: Linux 3.10-rc6 -> vexpress_defconfig qemu: 1.6.0-rc0 cmd line: qemu-system-arm\ -m 512\ -M vexpress-a9\ -kernel arch/arm/boot/zImage\ -initrd boot-kernels/initrd-modified.img \ -append "root=/dev/mmcblk0

Re: [Qemu-devel] Licensing question

2013-08-02 Thread Rob Landley
On 07/31/2013 12:19:03 AM, Stefan Weil wrote: Am 31.07.2013 03:50, schrieb Erik de Castro Lopo: > Hi all, > > I have a patch I would like to submit and I am currently running it past > my employer's legal department. The legal department has identified 10 > different licenses in the Qemu code

Re: [Qemu-devel] [PATCH 00/16 RFC v6] ACPI memory hotplug

2013-08-02 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 0/4] Rename all 'dprintf' macros to 'DPRINTF'

2013-08-02 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] target-arm: Implement 'int' loglevel

2013-08-02 Thread Richard Henderson
On 08/02/2013 07:09 AM, Peter Maydell wrote: > +static const char *excnames[] = { static const char * const excnames[] r~

Re: [Qemu-devel] [PATCH 02/16] vl: set default ram_size during variable initialization

2013-08-02 Thread Andreas Färber
Am 23.07.2013 18:22, schrieb Igor Mammedov: > Signed-off-by: Igor Mammedov > --- > vl.c |7 +-- > 1 files changed, 1 insertions(+), 6 deletions(-) > > diff --git a/vl.c b/vl.c > index 8190504..bf0c658 100644 > --- a/vl.c > +++ b/vl.c > @@ -2947,7 +2947,7 @@ int main(int argc, char **argv

Re: [Qemu-devel] [PATCH for-1.6 0/5] qtest: Output cleanup

2013-08-02 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

  1   2   >