Re: [Qemu-devel] [RFC 0/3] Determinitic behaviour with icount.

2013-07-30 Thread Frederic Konrad
On 29/07/2013 18:42, Paolo Bonzini wrote: Il 29/07/2013 17:27, Frederic Konrad ha scritto: On 18/07/2013 17:35, Paolo Bonzini wrote: Il 18/07/2013 17:06, Peter Maydell ha scritto: On 18 July 2013 16:02, wrote: As I said in the last email, we have issues with determinism with icount. We are w

[Qemu-devel] [PATCH v2 0/2] block: allow commit active as top

2013-07-30 Thread Fam Zheng
Previously live commit of active block device is not supported, this series implements it and updates corresponding qemu-iotests cases. Please see commit messages for implementation details. v2: report ready when all blocks commited for the first time, leave it to the user to complete the job

[Qemu-devel] [PATCH v2 1/2] block: allow live commit of active image

2013-07-30 Thread Fam Zheng
This patch eliminates limitation of committing the active device. bdrv_drop_intermediate is reimplemented to take pointers to (BlockDriverState *), so it can modify the caller's local pointers to preserve their semantics, while updating active BDS in-place by bdrv_swap active and base: we need dat

[Qemu-devel] [PATCH v2 2/2] qemu-iotests: update test cases for commit active

2013-07-30 Thread Fam Zheng
Factor out commit test common logic into super class, and update test of committing the active image. Signed-off-by: Fam Zheng --- tests/qemu-iotests/040 | 73 +- 1 file changed, 31 insertions(+), 42 deletions(-) diff --git a/tests/qemu-iotests/04

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-07-30 Thread Igor Mammedov
On Mon, 29 Jul 2013 15:41:57 -0400 "Jason J. Herne" wrote: > On 06/08/2013 09:11 PM, Andreas Färber wrote: > >> if (tcg_enabled() && !inited) { > >> > inited = true; > >> > s390x_translate_init(); > >> > } > >> >+ > >> >+smp_cpus += 1; > > Won't we need some form of l

[Qemu-devel] [PATCH V6 01/11] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions

2013-07-30 Thread Wanlong Gao
Signed-off-by: Wanlong Gao --- qapi-schema.json | 58 1 file changed, 58 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index a51f7d2..b31fd08 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3773,3 +3773,61 @@ ##

[Qemu-devel] [PATCH V6 05/11] NUMA: Add Linux libnuma detection

2013-07-30 Thread Wanlong Gao
Add detection of libnuma (mostly contained in the numactl package) to the configure script. Can be enabled or disabled on the command line, default is use if available. Signed-off-by: Andre Przywara Signed-off-by: Wanlong Gao --- configure | 32 1 file changed,

[Qemu-devel] [PATCH V6 02/11] NUMA: split -numa option

2013-07-30 Thread Wanlong Gao
Change -numa option like following as Paolo suggested: -numa node,nodeid=0,cpus=0-1 \ -numa mem,nodeid=0,size=1G This new option will make later coming memory hotplug better. And this new option is implemented using OptsVisitor. And just remain "-numa node,mem=xx" as legacy. Signed-off-b

[Qemu-devel] [PATCH V6 00/11] Add support for binding guest numa nodes to host numa nodes

2013-07-30 Thread Wanlong Gao
As you know, QEMU can't direct it's memory allocation now, this may cause guest cross node access performance regression. And, the worse thing is that if PCI-passthrough is used, direct-attached-device uses DMA transfer between device and qemu process. All pages of the guest will be pinned by get_u

[Qemu-devel] [PATCH V6 09/11] NUMA: add hmp command set-mem-policy

2013-07-30 Thread Wanlong Gao
Add hmp command set-mem-policy to set host memory policy for a guest NUMA node. Then we can also set node's memory policy using the monitor command like: (qemu) set-mem-policy 0 policy=membind,relative=false,host-nodes=0-1 Signed-off-by: Wanlong Gao --- hmp-commands.hx | 16 ++ h

[Qemu-devel] [PATCH V6 06/11] NUMA: parse guest numa nodes memory policy

2013-07-30 Thread Wanlong Gao
The memory policy setting format is like: policy={default|membind|interleave|preferred}[,relative=true],host-nodes=N-N And we are adding this setting as a suboption of "-numa mem,", the memory policy then can be set like following: -numa node,nodeid=0,cpus=0 \ -numa node,nodeid=1,cpus=1

[Qemu-devel] [PATCH V6 08/11] NUMA: add qmp command set-mem-policy to set memory policy for NUMA node

2013-07-30 Thread Wanlong Gao
This QMP command allows user set guest node's memory policy through the QMP protocol. The qmp-shell command is like: set-mem-policy nodeid=0 policy=membind relative=true host-nodes=0-1 Signed-off-by: Wanlong Gao --- numa.c | 62 ++

[Qemu-devel] [PATCH V6 07/11] NUMA: set guest numa nodes memory policy

2013-07-30 Thread Wanlong Gao
Set the guest numa nodes memory policies using the mbind(2) system call node by node. After this patch, we are able to set guest nodes memory policies through the QEMU options, this arms to solve the guest cross nodes memory access performance issue. And as you all know, if PCI-passthrough is used,

[Qemu-devel] [PATCH V6 10/11] NUMA: add qmp command query-numa

2013-07-30 Thread Wanlong Gao
Add qmp command query-numa to show guest NUMA information. Signed-off-by: Wanlong Gao --- numa.c | 69 qapi-schema.json | 36 + qmp-commands.hx | 49 3 files c

[Qemu-devel] [PATCH V6 11/11] NUMA: convert hmp command info_numa to use qmp command query_numa

2013-07-30 Thread Wanlong Gao
Signed-off-by: Wanlong Gao --- hmp.c | 54 ++ hmp.h | 1 + monitor.c | 21 + 3 files changed, 56 insertions(+), 20 deletions(-) diff --git a/hmp.c b/hmp.c index b199409..3152f2e 100644 --- a/hmp.c +++ b/hmp.c @@ -27

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-07-30 Thread Igor Mammedov
On Sun, 09 Jun 2013 03:11:35 +0200 Andreas Färber wrote: > Am 07.06.2013 19:28, schrieb Jason J. Herne: > > From: "Jason J. Herne" > > > > Modify cpu initialization and QOM routines associated with s390-cpu such > > that > > all cpus on S390 are now created via the QOM device creation code pat

[Qemu-devel] [PATCH V6 03/11] NUMA: move numa related code to numa.c

2013-07-30 Thread Wanlong Gao
Signed-off-by: Wanlong Gao --- cpus.c | 14 --- include/sysemu/cpus.h | 1 - include/sysemu/sysemu.h | 2 ++ numa.c | 65 + vl.c| 47 +-- 5 files chang

Re: [Qemu-devel] [PATCH 7/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Infrastructure for Cpu Devices

2013-07-30 Thread Igor Mammedov
On Fri, 7 Jun 2013 13:28:06 -0400 "Jason J. Herne" wrote: > From: "Jason J. Herne" > > Add infrastructure for treating cpus as devices. This patch allows cpus to be > specified using a combination of '-smp' and '-device cpu'. This approach > forces a change in the way cpus are counted via smp

[Qemu-devel] [PATCH v2 0/7] Implement reference count for BlockDriverState

2013-07-30 Thread Fam Zheng
BlockDriverState lifecycle management is needed by future features such as image fleecing and blockdev-add. This series adds reference count to BlockDriverState. The first two patches clean up two odd BlockDriverState use cases, so all code uses bdrv_new() to create BlockDriverState instance. The

[Qemu-devel] [PATCH v2 3/7] block: implement reference count for BlockDriverState

2013-07-30 Thread Fam Zheng
Introduce bdrv_ref/bdrv_unref to manage the lifecycle of BlockDriverState. They are unused for now but will used to replace bdrv_delete() later. Signed-off-by: Fam Zheng --- block.c | 22 ++ include/block/block.h | 2 ++ include/block/block_int.h | 1 +

[Qemu-devel] [PATCH v2 7/7] nbd: use BlockDriverState refcnt

2013-07-30 Thread Fam Zheng
Previously, nbd calls drive_get_ref() on the drive of bs. A BDS doesn't always have associated dinfo, which nbd doesn't care either. We already have BDS ref count, so use it to make it safe for a BDS w/o blockdev. Signed-off-by: Fam Zheng --- blockdev-nbd.c | 10 +- nbd.c | 5 +

[Qemu-devel] [PATCH v2 4/7] block: make bdrv_delete() static

2013-07-30 Thread Fam Zheng
Manage BlockDriverState lifecycle with refcnt, so bdrv_delete() is no longer public and should be called by bdrv_unref() if refcnt is decreased to 0. This is an identical change because effectively, there's no multiple reference of BDS now: no caller of bdrv_ref() yet, only bdrv_new() sets bs->ref

[Qemu-devel] [PATCH v2 2/7] iscsi: use bdrv_new() instead of stack structure

2013-07-30 Thread Fam Zheng
BlockDriverState structure needs bdrv_new() to initialize refcnt, don't allocate a local structure variable and memset to 0, becasue with coming refcnt implementation, bdrv_unref will crash if bs->refcnt not initialized to 1. Signed-off-by: Fam Zheng --- block/iscsi.c | 14 +++--- 1 file

[Qemu-devel] [PATCH v2 1/7] vvfat: use bdrv_new() to allocate BlockDriverState

2013-07-30 Thread Fam Zheng
we need bdrv_new() to properly initialize BDS, don't allocate memory manually. Signed-off-by: Fam Zheng --- block/vvfat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vvfat.c b/block/vvfat.c index cd3b8ed..a827d91 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -29

[Qemu-devel] [PATCH v2 5/7] migration: omit drive ref as we have bdrv_ref now

2013-07-30 Thread Fam Zheng
block-migration.c does not actually use DriveInfo anywhere. Hence it's safe to drive ref code, we really only care about referencing BDS. Signed-off-by: Fam Zheng --- block-migration.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block-migration.c b/block-migration.c

[Qemu-devel] [PATCH v2 6/7] xen_disk: simplify blk_disconnect with refcnt

2013-07-30 Thread Fam Zheng
We call bdrv_attach_dev when initializing whether or not bs is created locally, so call bdrv_detach_dev and let the refcnt handle the lifecycle. Signed-off-by: Fam Zheng --- hw/block/xen_disk.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/block/xen_disk.c b/

[Qemu-devel] [PATCH V6 04/11] NUMA: Add numa_info structure to contain numa nodes info

2013-07-30 Thread Wanlong Gao
Add the numa_info structure to contain the numa nodes memory, VCPUs information and the future added numa nodes host memory policies. Reviewed-by: Eduardo Habkost Signed-off-by: Andre Przywara Signed-off-by: Wanlong Gao --- hw/i386/pc.c| 4 ++-- include/sysemu/sysemu.h | 8 ++

Re: [Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

2013-07-30 Thread Orit Wasserman
On 07/27/2013 05:23 AM, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > When testing with libvirt, a simple IPv6 migration test failed > because we were not using getaddrinfo() properly. > This makes IPv6 migration over RDMA work. > > Also, we forgot to turn the DPRINTF flag off

[Qemu-devel] [PULL for-1.6 0/3] usb patch queu

2013-07-30 Thread Gerd Hoffmann
Hi, Here comes the usb patch queue, with some bugfixes, for 1.6. please pull, Gerd The following changes since commit dbe49aea76a7805f05b33d548b2e543b51fa8bb1: Update version for 1.6.0-rc0 (2013-07-29 20:30:29 -0500) are available in the git repository at: git://git.kraxel.org/qemu us

[Qemu-devel] [PATCH 1/3] xhci: handle USB_RET_IOERROR

2013-07-30 Thread Gerd Hoffmann
https://bugzilla.redhat.com/show_bug.cgi?id=980377 Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 58f311d..7cbf813 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhc

[Qemu-devel] [PATCH 3/3] hcd-ohci: add dma error handling

2013-07-30 Thread Gerd Hoffmann
From: Alexey Kardashevskiy Current hcd-ohci does not handle DMA errors. However they may happen so here we introduce simple error handling. On such errors, a typical OHCI will stop operating, signal the guest about the error by sending "UnrecoverableError Event", set itself into error state and

[Qemu-devel] [PATCH 2/3] uhci: egsm fix

2013-07-30 Thread Gerd Hoffmann
When the guest goes suspend the uhci controller while there are pending resume requests on the ports go signal global resume instantly. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-uhci.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index cb4

[Qemu-devel] [PATCH 1/1] spice: fix display initialization

2013-07-30 Thread Gerd Hoffmann
Spice has two display interface implementations: One integrated into the qxl graphics card, and one generic which can operate with every qemu-emulated graphics card. The generic one is activated in case spice is used without qxl. The logic for that only caught the "-vga qxl" case, "-device qxl-v

[Qemu-devel] [PULL for-1.6 0/1] spice patch queue

2013-07-30 Thread Gerd Hoffmann
Hi, This is the spice patch queue, with a single fix for 1.6. please pull, Gerd The following changes since commit dbe49aea76a7805f05b33d548b2e543b51fa8bb1: Update version for 1.6.0-rc0 (2013-07-29 20:30:29 -0500) are available in the git repository at: git://anongit.freedesktop.org/s

Re: [Qemu-devel] vm performance degradation after kvm live migration or save-restore with ETP enabled

2013-07-30 Thread Zhanghaoyu (A)
>> >> hi all, >> >> >> >> I met similar problem to these, while performing live migration or >> >> save-restore test on the kvm platform (qemu:1.4.0, host:suse11sp2, >> >> guest:suse11sp2), running tele-communication software suite in >> >> guest, >> >> https://lists.gnu.org/archive/html/qemu

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-07-30 Thread Paolo Bonzini
Il 30/07/2013 04:42, liu ping fan ha scritto: > On Mon, Jul 29, 2013 at 7:21 PM, Paolo Bonzini wrote: >> Il 29/07/2013 10:10, liu ping fan ha scritto: >>> On Mon, Jul 29, 2013 at 2:30 PM, Paolo Bonzini wrote: Il 29/07/2013 05:16, Liu Ping Fan ha scritto: > After disabling the QemuClock,

[Qemu-devel] Standard benchmarks for VMs

2013-07-30 Thread Gabriele Paciucci
Hi guys, I'm new for this ml, sorry if this mail is not in the right place!!! I'm looking for standard benchmarks to test VMs. I have seen several presentations from IBM and Red Hat using FFSB. Is there a "widely used" configuration file for FFSB? Just to have a starting point… Thanks in advanc

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-07-30 Thread Alex Bligh
Paolo, --On 30 July 2013 11:17:05 +0200 Paolo Bonzini wrote: Hmm, do we even need clock->using at this point? For example: qemu_clock_enable() { clock->enabled = enabled; ... if (!enabled) { /* If another thread is within qemu_run_timers, * w

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-07-30 Thread Paolo Bonzini
Il 30/07/2013 11:51, Alex Bligh ha scritto: > As far as walking the QEMUTimerList itself is concerned, this is > something which is 99.999% done by the thread owning the AioContext. > qemu_clock_enable should not even be walking this list. So I don't > see why the protection here is needed. The pr

Re: [Qemu-devel] [PATCH 1/1] spice: fix display initialization

2013-07-30 Thread Alon Levy
> Spice has two display interface implementations: One integrated into > the qxl graphics card, and one generic which can operate with every > qemu-emulated graphics card. > > The generic one is activated in case spice is used without qxl. The > logic for that only caught the "-vga qxl" case, "-

Re: [Qemu-devel] [PATCH v3] e1000: add interrupt mitigation support

2013-07-30 Thread Stefan Hajnoczi
On Mon, Jul 29, 2013 at 04:46:22PM +0200, Vincenzo Maffione wrote: > Actually it's not always zero because > > - presave() calls e1000_mit_timer(), which sets mit_timer_on to 0 and > calls set_interrupt_cause(ICR); > > - if there are pending events, set_interrupt_cause(ICR) detects a > raising ed

Re: [Qemu-devel] [PATCH V6 01/11] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions

2013-07-30 Thread Laszlo Ersek
On 07/30/13 09:32, Wanlong Gao wrote: > +## > +# @UInt16 > +# > +# Let "uint16" be entry-wise > +# > +# @u16: a "uint16" type value > +# > +# Since 1.7 > +## > +{ 'type': 'UInt16', 'data': { 'u16': 'uint16' }} Ah sorry, I should have spelled this out more clearly -- I only mentioned it in my OptsV

Re: [Qemu-devel] [PATCH v4] e1000: add interrupt mitigation support

2013-07-30 Thread Stefan Hajnoczi
On Mon, Jul 29, 2013 at 05:12:49PM +0200, Vincenzo Maffione wrote: > This patch partially implements the e1000 interrupt mitigation mechanisms. > Using a single QEMUTimer, it emulates the ITR register (which is the newer > mitigation register, recommended by Intel) and approximately emulates > RADV

[Qemu-devel] Error handling in cpu_x86_create

2013-07-30 Thread Jan Kiszka
Hi Igor, just noticed by chance that error handling in cpu_x86_create is likely broken after your changes. Any error after cpu = ...object_new() will not properly release the CPU object again nor report NULL to the caller. That means errors should slip through, no? And cpu_x86_init looks similar.

Re: [Qemu-devel] [PATCH V6 02/11] NUMA: split -numa option

2013-07-30 Thread Laszlo Ersek
On 07/30/13 09:32, Wanlong Gao wrote: > +static int numa_node_parse(NumaNodeOptions *opts) > +{ > +uint16_t nodenr; > +UInt16List *cpus = NULL; > + > +if (opts->has_nodeid) { > +nodenr = opts->nodeid; > +if (nodenr >= MAX_NODES) { > +fprintf(stderr, "qemu: M

Re: [Qemu-devel] [PATCH v2 3/7] block: implement reference count for BlockDriverState

2013-07-30 Thread Andreas Färber
Am 30.07.2013 09:52, schrieb Fam Zheng: > Introduce bdrv_ref/bdrv_unref to manage the lifecycle of > BlockDriverState. They are unused for now but will used to replace > bdrv_delete() later. > > Signed-off-by: Fam Zheng > --- > block.c | 22 ++ > include/blo

Re: [Qemu-devel] Error handling in cpu_x86_create

2013-07-30 Thread Igor Mammedov
On Tue, 30 Jul 2013 13:00:40 +0200 Jan Kiszka wrote: > Hi Igor, > > just noticed by chance that error handling in cpu_x86_create is likely > broken after your changes. Any error after cpu = ...object_new() will > not properly release the CPU object again nor report NULL to the caller. > That mea

Re: [Qemu-devel] [PATCH v2] migration: don't use uninitialized variables

2013-07-30 Thread Eric Blake
On 07/29/2013 05:39 PM, Pawit Pornkitprasan wrote: > The qmp_migrate method uses the 'blk' and 'inc' parameter without > checking if they're valid or not (they may be uninitialized if > command is received via QMP) > > Signed-off-by: Pawit Pornkitprasan > --- > migration.c |4 ++-- > 1 files

Re: [Qemu-devel] [PATCH v2 1/2] block: allow live commit of active image

2013-07-30 Thread Stefan Hajnoczi
On Tue, Jul 30, 2013 at 03:17:47PM +0800, Fam Zheng wrote: > for (sector_num = 0; sector_num < end; sector_num += n) { > -uint64_t delay_ns = 0; > -bool copy; > > -wait: > -/* Note that even when no rate limit is applied we need to yield > - * with no pending

[Qemu-devel] [PATCH for-1.6] block: Disable driver-specific options for 1.6

2013-07-30 Thread Kevin Wolf
We don't want to commit to the API yet before everything is worked out. Like already for 1.5, disable it again for the 1.6 release. This commit is meant to be reverted after the 1.6 release. The disabling of the driver-specific options is achieved by applying the old checks while parsing the comma

Re: [Qemu-devel] [PATCH for-1.6] block: Disable driver-specific options for 1.6

2013-07-30 Thread Eric Blake
On 07/30/2013 06:58 AM, Kevin Wolf wrote: > We don't want to commit to the API yet before everything is worked out. > Like already for 1.5, disable it again for the 1.6 release. This commit > is meant to be reverted after the 1.6 release. > > The disabling of the driver-specific options is achieve

Re: [Qemu-devel] [PATCH for-1.6 0/5] qtest: Output cleanup

2013-07-30 Thread Anthony Liguori
Andreas Färber writes: > Hello, > > This mini-series cleans up noisy make check output from endian-test. > Reviewed-by: Anthony Liguori Although this is pretty ugly to have to do. It would be nicer to have something as a machine property indicating that the machine type requires -kernel to be

Re: [Qemu-devel] [PATCH v2 1/2] block: allow live commit of active image

2013-07-30 Thread Paolo Bonzini
Il 30/07/2013 14:53, Stefan Hajnoczi ha scritto: > On Tue, Jul 30, 2013 at 03:17:47PM +0800, Fam Zheng wrote: >> for (sector_num = 0; sector_num < end; sector_num += n) { >> -uint64_t delay_ns = 0; >> -bool copy; >> >> -wait: >> -/* Note that even when no rate limit i

[Qemu-devel] [PATCH for-1.6] chardev: fix CHR_EVENT_OPENED events for mux chardevs

2013-07-30 Thread Michael Roth
As of bd5c51ee6c4f1c79cae5ad2516d711a27b4ea8ec, chardevs no longer use bottom-halves to issue CHR_EVENT_OPENED events. To maintain past semantics, we instead defer the CHR_EVENT_OPENED events toward the end of chardev initialization. For muxes, this isn't good enough, since a range of FEs must be

Re: [Qemu-devel] [PATCH for-1.6? 04/14] gumstix: Don't enforce use of -pflash for qtest

2013-07-30 Thread Anthony Liguori
Andreas Färber writes: > Signed-off-by: Andreas Färber I'm not sure this is heading in the right direction. What's the bigger picture here? Are we saying that all machines must be launchable without any special parameters? If so, can we document that somewhere? Is that reasonable in practic

Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables

2013-07-30 Thread Anthony Liguori
On Tue, Jul 30, 2013 at 1:39 AM, Markus Armbruster wrote: > Anthony Liguori writes: > >> This was part of the discussion way back when this all was first >> introduced. Since everything was open coded and we had to preserve >> the semantics, that was the only choice we had. > > Yes, there is a d

Re: [Qemu-devel] [PATCH for-1.6? 04/14] gumstix: Don't enforce use of -pflash for qtest

2013-07-30 Thread Peter Maydell
On 30 July 2013 14:20, Anthony Liguori wrote: > What's the bigger picture here? Are we saying that all machines must be > launchable without any special parameters? If so, can we document that > somewhere? > > Is that reasonable in practice or are there cases where we must specify > parameters f

Re: [Qemu-devel] [PATCH v2] migration: don't use uninitialized variables

2013-07-30 Thread Luiz Capitulino
On Tue, 30 Jul 2013 08:39:52 +0900 Pawit Pornkitprasan wrote: > The qmp_migrate method uses the 'blk' and 'inc' parameter without > checking if they're valid or not (they may be uninitialized if > command is received via QMP) > > Signed-off-by: Pawit Pornkitprasan Applied to the qmp branch, th

Re: [Qemu-devel] [PATCH v4 01/10] ignore SIGPIPE in qemu-img and qemu-io

2013-07-30 Thread Stefan Hajnoczi
On Fri, Jul 26, 2013 at 03:10:43PM +0900, MORITA Kazutaka wrote: > This prevents the tools from being stopped when they write data to a > closed connection in the other side. > > Reviewed-by: Paolo Bonzini > Signed-off-by: MORITA Kazutaka > --- > qemu-img.c | 4 > qemu-io.c | 4 > 2

Re: [Qemu-devel] [PATCH 4/9] block: vhdx - log support struct and defines

2013-07-30 Thread Jeff Cody
On Tue, Jul 30, 2013 at 11:15:02AM +0800, Fam Zheng wrote: > On Wed, 07/24 13:54, Jeff Cody wrote: > > This adds some magic number defines, and internal structure > > definitions for VHDX log replay support. > > > > Signed-off-by: Jeff Cody > > --- > > block/vhdx.h | 21 - > >

Re: [Qemu-devel] [PATCH v4 03/10] sheepdog: check return values of qemu_co_recv/send correctly

2013-07-30 Thread Stefan Hajnoczi
On Fri, Jul 26, 2013 at 03:10:45PM +0900, MORITA Kazutaka wrote: > If qemu_co_recv/send doesn't return the specified length, it means > that an error happened. > > Tested-and-reviewed-by: Liu Yuan > Signed-off-by: MORITA Kazutaka > --- > block/sheepdog.c | 16 > 1 file changed,

Re: [Qemu-devel] [PATCH v4 06/10] coroutine: add co_aio_sleep_ns() to allow sleep in block drivers

2013-07-30 Thread Stefan Hajnoczi
On Fri, Jul 26, 2013 at 03:10:48PM +0900, MORITA Kazutaka wrote: > This helper function behaves similarly to co_sleep_ns(), but the > sleeping coroutine will be resumed when using qemu_aio_wait(). > > Signed-off-by: MORITA Kazutaka > --- > include/block/coroutine.h | 8 > qemu-coroutin

Re: [Qemu-devel] [PATCH 7/9] block: vhdx - log parsing, replay, and flush support

2013-07-30 Thread Jeff Cody
On Tue, Jul 30, 2013 at 11:48:15AM +0800, Fam Zheng wrote: > On Wed, 07/24 13:54, Jeff Cody wrote: > > This adds support for VHDX v0 logs, as specified in Microsoft's > > VHDX Specification Format v1.00: > > https://www.microsoft.com/en-us/download/details.aspx?id=34750 > > > > The following suppo

[Qemu-devel] [Bug 1204697] Re: guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/rdmsr

2013-07-30 Thread Christoph Anton Mitterer
Sorry for the confusion. The initial problem was _always_ with SATA... I couldn't try IDE at first, as the guest initrd haven't had and the IDE drivers. Yesterday then, I tried IDE and it worked with that. Sure, I just wanted to confirm that you were really right ;-) Sorry I have missed the

[Qemu-devel] [Bug 1098729] Re: qemu-user-static for armhf: segfault in threaded code

2013-07-30 Thread Alexander
./build/buildd/qemu-linaro-1.5.0-2013.06/tcg/tcg.c:149: tcg fatal error /build/buildd/qemu-linaro-1.5.0-2013.06/tcg/tcg.c:149: tcg fatal error same for me -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bug

[Qemu-devel] Using GDB with invalid memory access

2013-07-30 Thread Emmanuel Blot
Hi, I'm trying to give the hand back to the target GDB whenever an invalid memory access occurs within the target. I'm using an ARMv4T target w/o MMU with a hardly modified version of QEMU 1.5 QEMU successfully detects invalid memory accesses, and cpu_unassigned_access is invoked. However, I'm no

Re: [Qemu-devel] [PATCH 8/9] block: vhdx - add log write support

2013-07-30 Thread Jeff Cody
On Tue, Jul 30, 2013 at 11:57:20AM +0800, Fam Zheng wrote: > On Wed, 07/24 13:54, Jeff Cody wrote: > > This adds support for writing to the VHDX log. > > > > For spec details, see VHDX Specification Format v1.00: > > https://www.microsoft.com/en-us/download/details.aspx?id=34750 > > > > There are

Re: [Qemu-devel] [PATCH v4 00/10] sheepdog: reconnect server after connection failure

2013-07-30 Thread Stefan Hajnoczi
On Fri, Jul 26, 2013 at 03:10:42PM +0900, MORITA Kazutaka wrote: > Currently, if a sheepdog server exits, all the connecting VMs need to > be restarted. This series implements a feature to reconnect the > server, and enables us to do online sheepdog upgrade and avoid > restarting VMs when sheepdog

Re: [Qemu-devel] [PATCH v3 11/19] block: define get_block_status return value

2013-07-30 Thread Kevin Wolf
Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: > Define the return value of get_block_status. Bits 0, 1, 2 and 9-62 > are valid; bit 63 (the sign bit) is reserved for errors. Bits 3-8 > are left for future extensions. > > The return code is compatible with the old is_allocated API: if a d

Re: [Qemu-devel] [PATCH v3 11/19] block: define get_block_status return value

2013-07-30 Thread Paolo Bonzini
Il 30/07/2013 16:14, Kevin Wolf ha scritto: > Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: >> Define the return value of get_block_status. Bits 0, 1, 2 and 9-62 >> are valid; bit 63 (the sign bit) is reserved for errors. Bits 3-8 >> are left for future extensions. >> >> The return code i

[Qemu-devel] [PATCH 1/8] s390/sclpconsole: handle char layer busy conditions

2013-07-30 Thread Christian Borntraeger
From: Heinz Graalfs Handle busy conditions (errno=EAGAIN) in char layer by using the new char layer in the sclp console. Signed-off-by: Heinz Graalfs Signed-off-by: Christian Borntraeger --- hw/char/sclpconsole.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff -

[Qemu-devel] [PATCH 6/8] s390x/kvm: Reworked/fixed handling of cc3 in kvm_handle_css_inst()

2013-07-30 Thread Christian Borntraeger
From: Thomas Huth Consolidated the setting of the condition code in kvm_handle_css_inst(). For the (unhandled) instructions EQBS and SQBS, we have to return an operation exception instead of cc3. Also removed the is_ioinst() function to avoid decoding the opcode twice. Signed-off-by: Thomas Huth

[Qemu-devel] [PATCH 3/8] s390x/ioinst: Throw addressing exception when memory_map failed

2013-07-30 Thread Christian Borntraeger
From: Thomas Huth So far, the IO instructions were throwing specification exceptions when there was a problem with accessing the memory. However, the better way is to throw an addressing exception instead. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeg

[Qemu-devel] [PATCH 7/8] s390x/kvm: Remove redundant return code

2013-07-30 Thread Christian Borntraeger
From: Thomas Huth Removed the redundant return code statement from handle_instruction() - it always returned 0 and never reports any errors to its caller, since errors from the sub-functions are already reported via program exceptions instead. Signed-off-by: Thomas Huth Signed-off-by: Christian

[Qemu-devel] [PULLv2 0/8] s390 patch queue

2013-07-30 Thread Christian Borntraeger
Anthony, V2 of the s390 patch queue, now on top of master with the following changes since commit dbe49aea76a7805f05b33d548b2e543b51fa8bb1: Update version for 1.6.0-rc0 (2013-07-29 20:30:29 -0500) are available in the git repository at: git://github.com/borntraeger/qemu.git s390-for-1.6

[Qemu-devel] [PATCH 8/8] s390: Implement dump-guest-memory support for target s390x

2013-07-30 Thread Christian Borntraeger
From: Ekaterina Tumanova With this patch dump-guest-memory on s390 produces an ELF formatted, crash-readable dump. In order to implement this, the arch-specific part of dump-guest-memory was added: target-s390x/arch_dump.c contains the whole set of function for writing Elf note sections of all ty

[Qemu-devel] [PATCH 4/8] s390x/ioinst: Fixed alignment check in SCHM instruction

2013-07-30 Thread Christian Borntraeger
From: Thomas Huth Register 2 only has to be aligned to a 32-byte boundary, not a full page boundary. Signed-off-by: Thomas Huth Acked-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- target-s390x/ioinst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-s3

[Qemu-devel] [PATCH 2/8] s390x/ioinst: Add missing alignment checks for IO instructions

2013-07-30 Thread Christian Borntraeger
From: Thomas Huth The IO instructions MSCH, SSCH, STSCH, TSCH, STCRW and TPI require that the second operand address must be aligned on a word boundary. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- target-s390x/ioinst.c | 25 +

[Qemu-devel] [PATCH] vl.c: Output error on invalid machine type provided

2013-07-30 Thread Michal Novotny
Output error message when user provides the invalid machine type on the command line. This also saves time to find what issue is when you upgrade from one version of qemu to another version that doesn't support required machine type any longer. Michal Signed-off-by: Michal Novotny --- vl.c | 4

[Qemu-devel] [PATCH 5/8] s390x/ioinst: Fixed priority of operand exceptions

2013-07-30 Thread Christian Borntraeger
From: Thomas Huth Operand exceptions have a lower priority than specification and address exceptions. Thus the checks for operand exceptions must be done later. Signed-off-by: Thomas Huth Acked-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- target-s390x/ioinst.c | 30

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-07-30 Thread Jason J. Herne
On 07/30/2013 03:24 AM, Igor Mammedov wrote: On Mon, 29 Jul 2013 15:41:57 -0400 "Jason J. Herne" wrote: On 06/08/2013 09:11 PM, Andreas Färber wrote: if (tcg_enabled() && !inited) { inited = true; s390x_translate_init(); } + +smp_cpus += 1; Won't we need som

Re: [Qemu-devel] [PATCH v3 11/19] block: define get_block_status return value

2013-07-30 Thread Kevin Wolf
Am 30.07.2013 um 16:19 hat Paolo Bonzini geschrieben: > Il 30/07/2013 16:14, Kevin Wolf ha scritto: > > Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: > >> Define the return value of get_block_status. Bits 0, 1, 2 and 9-62 > >> are valid; bit 63 (the sign bit) is reserved for errors. Bits

Re: [Qemu-devel] [PATCH v3 12/19] block: return get_block_status data and flags for formats

2013-07-30 Thread Kevin Wolf
Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: > Reviewed-by: Eric Blake > Signed-off-by: Paolo Bonzini > --- > block/cow.c | 8 +++- > block/qcow.c | 9 - > block/qcow2.c| 16 ++-- > block/qed.c | 35 --- > block

Re: [Qemu-devel] [PATCH for-1.6] block: Disable driver-specific options for 1.6

2013-07-30 Thread Stefan Hajnoczi
On Tue, Jul 30, 2013 at 02:58:27PM +0200, Kevin Wolf wrote: > We don't want to commit to the API yet before everything is worked out. > Like already for 1.5, disable it again for the 1.6 release. This commit > is meant to be reverted after the 1.6 release. > > The disabling of the driver-specific

Re: [Qemu-devel] [PATCH] vl.c: Output error on invalid machine type provided

2013-07-30 Thread Peter Maydell
On 30 July 2013 15:28, Michal Novotny wrote: > Output error message when user provides the invalid machine type > on the command line. This also saves time to find what issue is > when you upgrade from one version of qemu to another version that > doesn't support required machine type any longer.

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-07-30 Thread Igor Mammedov
On Tue, 30 Jul 2013 10:27:26 -0400 "Jason J. Herne" wrote: > On 07/30/2013 03:24 AM, Igor Mammedov wrote: > > On Mon, 29 Jul 2013 15:41:57 -0400 > > "Jason J. Herne" wrote: > > > >> On 06/08/2013 09:11 PM, Andreas Färber wrote: > if (tcg_enabled() && !inited) { > > inited =

Re: [Qemu-devel] [PATCH v2 3/7] block: implement reference count for BlockDriverState

2013-07-30 Thread Stefan Hajnoczi
On Tue, Jul 30, 2013 at 02:16:08PM +0200, Andreas Färber wrote: > Am 30.07.2013 09:52, schrieb Fam Zheng: > > Introduce bdrv_ref/bdrv_unref to manage the lifecycle of > > BlockDriverState. They are unused for now but will used to replace > > bdrv_delete() later. > > > > Signed-off-by: Fam Zheng >

Re: [Qemu-devel] [PATCH v2 3/7] block: implement reference count for BlockDriverState

2013-07-30 Thread Jeff Cody
On Tue, Jul 30, 2013 at 03:52:53PM +0800, Fam Zheng wrote: > Introduce bdrv_ref/bdrv_unref to manage the lifecycle of > BlockDriverState. They are unused for now but will used to replace > bdrv_delete() later. > > Signed-off-by: Fam Zheng > --- > block.c | 22 ++

Re: [Qemu-devel] [PATCH V8 09/13] monitor: support sub command in help

2013-07-30 Thread Luiz Capitulino
On Fri, 26 Jul 2013 11:20:38 +0800 Wenchao Xia wrote: > The old code in help_cmd() uses global 'info_cmds' and treats it as a > special case. Actually 'info_cmds' is a sub command group of 'mon_cmds', > in order to avoid direct use of it, help_cmd() needs to change its work > mechanism to support

[Qemu-devel] [PATCH v2] vl.c: Output error on invalid machine type provided

2013-07-30 Thread Michal Novotny
Output error message when user provides the invalid machine type on the command line. This also saves time to find what issue is when you upgrade from one version of qemu to another version that doesn't support required machine type any longer. The patch is checked using ./scripts/checkpatch.pl sc

Re: [Qemu-devel] [PATCH] vl.c: Output error on invalid machine type provided

2013-07-30 Thread Michal Novotny
On 07/30/2013 04:46 PM, Peter Maydell wrote: > On 30 July 2013 15:28, Michal Novotny wrote: >> Output error message when user provides the invalid machine type >> on the command line. This also saves time to find what issue is >> when you upgrade from one version of qemu to another version that >

Re: [Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

2013-07-30 Thread Michael R. Hines
On 07/30/2013 04:14 AM, Orit Wasserman wrote: On 07/27/2013 05:23 AM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" When testing with libvirt, a simple IPv6 migration test failed because we were not using getaddrinfo() properly. This makes IPv6 migration over RDMA work. Also, we

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-07-30 Thread Andreas Färber
Am 30.07.2013 16:50, schrieb Igor Mammedov: > On Tue, 30 Jul 2013 10:27:26 -0400 > "Jason J. Herne" wrote: >> On 07/30/2013 03:24 AM, Igor Mammedov wrote: >> Is there an easier way of getting the count besides this? >> >> int cpu_count = 0; >> for (cpu = first_cpu; cpu != NULL; cpu = cpu->next_cpu

Re: [Qemu-devel] [PATCH v2 3/7] block: implement reference count for BlockDriverState

2013-07-30 Thread Stefan Hajnoczi
On Tue, Jul 30, 2013 at 03:52:53PM +0800, Fam Zheng wrote: > @@ -1518,6 +1519,9 @@ static void bdrv_move_feature_fields(BlockDriverState > *bs_dest, > /* dirty bitmap */ > bs_dest->dirty_bitmap = bs_src->dirty_bitmap; > > +/* reference count */ > +bs_dest->refcnt

Re: [Qemu-devel] [PATCH v3 13/19] qemu-img: add a "map" subcommand

2013-07-30 Thread Kevin Wolf
Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: > This command dumps the metadata of an entire chain, in either tabular or JSON > format. > > Signed-off-by: Paolo Bonzini Hm, we have a 'map' command in qemu-io, which isn't exactly the same, but then not much different either. Depending on

Re: [Qemu-devel] [PATCH v3 12/19] block: return get_block_status data and flags for formats

2013-07-30 Thread Paolo Bonzini
Il 30/07/2013 16:40, Kevin Wolf ha scritto: > Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: >> Reviewed-by: Eric Blake >> Signed-off-by: Paolo Bonzini >> --- >> block/cow.c | 8 +++- >> block/qcow.c | 9 - >> block/qcow2.c| 16 ++-- >> block/qed.c

Re: [Qemu-devel] [PATCH v2] vl.c: Output error on invalid machine type provided

2013-07-30 Thread Markus Armbruster
Michal Novotny writes: > Output error message when user provides the invalid machine type > on the command line. This also saves time to find what issue is > when you upgrade from one version of qemu to another version that > doesn't support required machine type any longer. Text from here > >

[Qemu-devel] [PATCH v2 0/3] rdma: IPv6 bugfixes and cleanups

2013-07-30 Thread mrhines
From: "Michael R. Hines" Changes: 1. IPv6 support was broken under libvirt. 2. incorrect use of error_setg() 3. DPRINTF flag was not disabled Michael R. Hines (3): rdma: bugfix: make IPv6 support work rdma: forgot to turn off the debugging flag rdma: correct newlines in error statements

[Qemu-devel] [PATCH v2 3/3] rdma: correct newlines in error statements

2013-07-30 Thread mrhines
From: "Michael R. Hines" Don't print newlines on the error_setg() function, but still allow newlines on fprintf(). Signed-off-by: Michael R. Hines --- migration-rdma.c | 68 +++--- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a

[Qemu-devel] [PATCH v2 1/3] rdma: bugfix: make IPv6 support work

2013-07-30 Thread mrhines
From: "Michael R. Hines" RDMA does not use sockets, so we cannot use many of the socket helper functions, but we *do* use inet_parse() which gives RDMA all the necessary details of the connection parameters. However, when testing with libvirt, a simple IPv6 migration test failed because we were

  1   2   >