Re: [Qemu-devel] [PATCH V7 09/13] monitor: support sub command in help

2013-07-24 Thread Eric Blake
On 07/19/2013 07:44 PM, Wenchao Xia wrote: > The old code in help_cmd() use global 'info_cmds' and treat it as a s/use/uses/; s/treat/treats/ > special case. Actually 'info_cmds' is an sub command group of 'mon_cmds', s/an sub/a sub/ > in order to avoid direct use of it, help_cmd() need to chan

Re: [Qemu-devel] [PATCH v2 08/11] block: simplify bdrv_drop_intermediate

2013-07-24 Thread Jeff Cody
On Wed, Jul 17, 2013 at 05:42:13PM +0800, Fam Zheng wrote: > bdrv_drop_intermediate used a local list to iterate through backing > chain and delete each BDS. It is simplified while adopting to refcount > mechanism. > Hi Fam, The reason for the local list is to keep the BDS deletion transactional

[Qemu-devel] [PATCH qom-next for-1.6 5/8] milkymist-vgafb: QOM cast cleanups

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/display/milkymist-vgafb.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/hw/display/milkymist-vgafb.c b/hw/display/milkymist-vgafb.c index 870b339..5150cb4 100644 --- a/hw/display/milkymist-vgafb.c +++ b/hw/display/milky

[Qemu-devel] [PATCH qom-next for-1.6 0/8] display: QOM cast cleanups

2013-07-24 Thread Andreas Färber
Hello, This series eliminates FROM_SYSBUS() in hw/display/. Regards, Andreas Cc: Hu Tao Andreas Färber (8): exynos4210_fimd: QOM cast cleanup g364fb: QOM cast cleanup jazz_led: QOM cast cleanups milkymist-tmu2: QOM cast cleanups milkymist-vgafb: QOM cast cleanups pl110: Rename pl11

[Qemu-devel] [PATCH qom-next for-1.6 2/8] g364fb: QOM cast cleanup

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/display/g364fb.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/hw/display/g364fb.c b/hw/display/g364fb.c index 79a0a50..a24a882 100644 --- a/hw/display/g364fb.c +++ b/hw/display/g364fb.c @@ -493,26 +493,33 @@ st

[Qemu-devel] [PATCH qom-next for-1.6 1/8] exynos4210_fimd: QOM cast cleanup

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/display/exynos4210_fimd.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/display/exynos4210_fimd.c b/hw/display/exynos4210_fimd.c index eb168ea..65cca1d 100644 --- a/hw/display/exynos4210_fimd.c +++ b/hw/display/exyn

[Qemu-devel] [PATCH qom-next for-1.6 4/8] milkymist-tmu2: QOM cast cleanups

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/display/milkymist-tmu2.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/display/milkymist-tmu2.c b/hw/display/milkymist-tmu2.c index efda082..b2a5fba 100644 --- a/hw/display/milkymist-tmu2.c +++ b/hw/display/milkymist-tmu2

[Qemu-devel] [PATCH qom-next for-1.6 7/8] pl110: QOM'ify pl110, pl110_versatile and pl111

2013-07-24 Thread Andreas Färber
Let pl110_versatile and pl111 inherit from pl110 and use PL110() cast; set their version index in an instance_init. Signed-off-by: Andreas Färber --- hw/display/pl110.c | 71 ++ 1 file changed, 29 insertions(+), 42 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH qom-next for-1.6 3/8] jazz_led: QOM cast cleanups

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/display/jazz_led.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/display/jazz_led.c b/hw/display/jazz_led.c index 7f82037..8407e6c 100644 --- a/hw/display/jazz_led.c +++ b/hw/display/jazz_led.c @@ -32,8 +32,12 @@ typedef e

[Qemu-devel] [PATCH qom-next for-1.6 6/8] pl110: Rename pl110_state to PL110State

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/display/pl110.c | 64 +++--- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/hw/display/pl110.c b/hw/display/pl110.c index 60afcf3..7c2cd36 100644 --- a/hw/display/pl110.c +++ b/hw/display/pl110.c

[Qemu-devel] [PATCH qom-next for-1.6 8/8] tcx: QOM cast cleanups

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/display/tcx.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/display/tcx.c b/hw/display/tcx.c index 9fd48b5..24876d3 100644 --- a/hw/display/tcx.c +++ b/hw/display/tcx.c @@ -34,8 +34,12 @@ #define TCX_THC_NREGS_24 0x1000

Re: [Qemu-devel] [PATCH qom-next] ide: Introduce abstract QOM type for PCIIDEState

2013-07-24 Thread Andreas Färber
Am 22.07.2013 17:58, schrieb Andreas Färber: > Needed for QOM casts. > > Signed-off-by: Andreas Färber > --- > hw/ide/cmd646.c | 62 > ++--- > hw/ide/pci.c| 30 +--- > hw/ide/pci.h| 8 +++- > hw/ide/piix.c

Re: [Qemu-devel] [PATCH v3 05/14] loader: use file path size from fw_cfg.h

2013-07-24 Thread Andreas Färber
Am 24.07.2013 18:01, schrieb Michael S. Tsirkin: > Avoid a bit of code duplication, make > max file path constant reusable. > > Suggested-by: Laszlo Ersek > Signed-off-by: Michael S. Tsirkin Reviewed-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germ

Re: [Qemu-devel] [PATCH v2 08/11] block: simplify bdrv_drop_intermediate

2013-07-24 Thread Fam Zheng
On Wed, 07/24 19:16, Jeff Cody wrote: > On Wed, Jul 17, 2013 at 05:42:13PM +0800, Fam Zheng wrote: > > bdrv_drop_intermediate used a local list to iterate through backing > > chain and delete each BDS. It is simplified while adopting to refcount > > mechanism. > > > > Hi Fam, > > The reason for

[Qemu-devel] vhost acceleration broken?

2013-07-24 Thread Rusty Russell
Hi all, Using latest kernel and master qemu, the following doesn't use vhost acceleration: sudo qemu-system-x86_64 -machine pc,accel=kvm $ARGS -m 1024 -net tap,script=/home/rusty/bin/kvm-ifup,downscript=no,vhost=on -net nic,model=virtio -drive file=$QEMUIMAGE,index=0,media=disk,if=virti

Re: [Qemu-devel] vhost acceleration broken?

2013-07-24 Thread Anthony Liguori
On Wed, Jul 24, 2013 at 8:55 PM, Rusty Russell wrote: > Hi all, > > Using latest kernel and master qemu, the following doesn't use > vhost acceleration: > > sudo qemu-system-x86_64 -machine pc,accel=kvm $ARGS -m 1024 -net > tap,script=/home/rusty/bin/kvm-ifup,downscript=no,vhost=on -net

Re: [Qemu-devel] [PATCH 0/4] export internal snapshot by qemu-nbd

2013-07-24 Thread Wenchao Xia
Besides the argument, I think it helps to probe snapshot without qemu-img convert, hope to get comments for the code. -- Best Regards Wenchao Xia

Re: [Qemu-devel] [sheepdog] [PATCH v2 0/9] sheepdog: reconnect server after connection failure

2013-07-24 Thread Liu Yuan
On Wed, Jul 24, 2013 at 11:42:49PM +0800, Liu Yuan wrote: > On Wed, Jul 24, 2013 at 06:07:21PM +0900, MORITA Kazutaka wrote: > > At Wed, 24 Jul 2013 16:28:30 +0800, > > Liu Yuan wrote: > > > > > > On Wed, Jul 24, 2013 at 04:56:24PM +0900, MORITA Kazutaka wrote: > > > > Currently, if a sheepdog ser

Re: [Qemu-devel] RFC [PATCH] Make bdrv_flush synchronous only and update callers

2013-07-24 Thread Wenchao Xia
I am glad to have an accurate sync bdrv_flush(). Code looks fine. Reviewed-by: Wenchao Xia > This patch makes bdrv_flush a synchronous function and updates any callers > from > a coroutine context to use bdrv_co_flush instead. > > The motivation for this patch comes from the GSoC Continuatio

Re: [Qemu-devel] Call for Proposals: 2013 Linux Plumbers Virtualization Microconference

2013-07-24 Thread Alex Williamson
Reminder, there's one week left to submit proposals for the virtualization micro-conference at LPC. Please see below for details and note the update to submit proposals through the Linux Plumbers website: http://www.linuxplumbersconf.org/2013/ocw/events/LPC2013/proposals/new Thanks, Alex On Su

[Qemu-devel] [Bug 1204697] Re: guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/rdmsr

2013-07-24 Thread Bug Watch Updater
** Changed in: qemu (Debian) Status: Unknown => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1204697 Title: guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/

[Qemu-devel] [Bug 1204697] [NEW] guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/rdmsr

2013-07-24 Thread Christoph Anton Mitterer
Public bug reported: Hi. This is from http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=717724. Using Debian sid with 1.5.0-5 my Linux VMs (also Debian sid) are broken. When they boot I get gazillions of ATA errors inside the guest, as well as: [ 242.479951] kvm [7790]: vcpu0 unhandled rdmsr: 0

Re: [Qemu-devel] vhost acceleration broken?

2013-07-24 Thread Michael S. Tsirkin
On Thu, Jul 25, 2013 at 11:25:20AM +0930, Rusty Russell wrote: > Hi all, > > Using latest kernel and master qemu, the following doesn't use > vhost acceleration: > > sudo qemu-system-x86_64 -machine pc,accel=kvm $ARGS -m 1024 -net > tap,script=/home/rusty/bin/kvm-ifup,downscript=no,vhost

[Qemu-devel] [PATCH 1/2] sheepdog: correct signedness of comparison

2013-07-24 Thread Liu Yuan
When signed int compared to unsigned int, signed int will be converted to unsigned int. For example, (-1 < sizeof(structure)) always true because -1 in the left is converted into unsigned int, thus this restule in unexpected true. Signed-off-by: Liu Yuan --- block/sheepdog.c | 10 +-

Re: [Qemu-devel] [PATCH v2 0/9] sheepdog: reconnect server after connection failure

2013-07-24 Thread Liu Yuan
Hello Kazutaka, I have two patches fixing the problems I found on my testing and they are complementary patches. Please consider sending them on top of your patch set. Thanks Yuan

[Qemu-devel] [PATCH 2/2] sheepdog: put aio request into failed list when failing to send request

2013-07-24 Thread Liu Yuan
qemu_co_send() in the add_aio_request might fail if connection is closed. In this case we should it requests into failed list to be resended later when connection is repaired. Signed-off-by: Liu Yuan --- block/sheepdog.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --gi

Re: [Qemu-devel] [PATCH 00/28] Memory API for 1.6: fix I/O port endianness mess

2013-07-24 Thread Benjamin Herrenschmidt
On Mon, 2013-07-22 at 10:34 -0500, Anthony Liguori wrote: > > Really nice series. I'd prefer we simply got rid of the endianness > flag > entirely but this is a good step. > > Reviewed-by: Anthony Liguori Are you going to merge this ? Afaik (Alexey just told me), pretty much anything IO is br

Re: [Qemu-devel] vhost acceleration broken?

2013-07-24 Thread Rusty Russell
Anthony Liguori writes: > On Wed, Jul 24, 2013 at 8:55 PM, Rusty Russell wrote: >> Hi all, >> >> Using latest kernel and master qemu, the following doesn't use >> vhost acceleration: >> >> sudo qemu-system-x86_64 -machine pc,accel=kvm $ARGS -m 1024 -net >> tap,script=/home/rusty/bin/kvm-

Re: [Qemu-devel] [PATCH v2 3/8] virtio: Add support for guest setting of queue size

2013-07-24 Thread Michael S. Tsirkin
On Fri, Jul 12, 2013 at 09:36:57PM +0100, Peter Maydell wrote: > The MMIO virtio transport spec allows the guest to tell the host how > large the queue size is. Add virtio_queue_set_num() function which > implements this in the QEMU common virtio support code. > > Signed-off-by: Peter Maydell Pr

Re: [Qemu-devel] [PATCH 00/28] Memory API for 1.6: fix I/O port endianness mess

2013-07-24 Thread Benjamin Herrenschmidt
On Thu, 2013-07-25 at 15:26 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2013-07-22 at 10:34 -0500, Anthony Liguori wrote: > > > > Really nice series. I'd prefer we simply got rid of the endianness > > flag > > entirely but this is a good step. > > > > Reviewed-by: Anthony Liguori > > Are yo

Re: [Qemu-devel] [sheepdog] [PATCH v2 0/9] sheepdog: reconnect server after connection failure

2013-07-24 Thread MORITA Kazutaka
At Thu, 25 Jul 2013 13:25:33 +0800, Liu Yuan wrote: > > Hello Kazutaka, > >I have two patches fixing the problems I found on my testing and they are > complementary patches. Please consider sending them on top of your patch set. Thanks a lot for your comments and patches, but I've already pr

Re: [Qemu-devel] [sheepdog] [PATCH v2 0/9] sheepdog: reconnect server after connection failure

2013-07-24 Thread Liu Yuan
On Thu, Jul 25, 2013 at 02:53:57PM +0900, MORITA Kazutaka wrote: > At Thu, 25 Jul 2013 13:25:33 +0800, > Liu Yuan wrote: > > > > Hello Kazutaka, > > > >I have two patches fixing the problems I found on my testing and they are > > complementary patches. Please consider sending them on top of y

Re: [Qemu-devel] [PATCH 00/28] Memory API for 1.6: fix I/O port endianness mess

2013-07-24 Thread Jan Kiszka
On 2013-07-25 07:47, Benjamin Herrenschmidt wrote: > On Thu, 2013-07-25 at 15:26 +1000, Benjamin Herrenschmidt wrote: >> On Mon, 2013-07-22 at 10:34 -0500, Anthony Liguori wrote: >>> >>> Really nice series. I'd prefer we simply got rid of the endianness >>> flag >>> entirely but this is a good ste

Re: [Qemu-devel] [PATCH v2 07/11] block: hold hard reference for backup/mirror target

2013-07-24 Thread Fam Zheng
On Tue, 07/23 11:52, Stefan Hajnoczi wrote: > On Wed, Jul 17, 2013 at 05:42:12PM +0800, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > block/backup.c | 3 ++- > > block/mirror.c | 4 ++-- > > 2 files changed, 4 insertions(+), 3 deletions(-) > > Should we update the blockjob.c in_use c

Re: [Qemu-devel] commit 08521e2 breaks SLOF usb boot

2013-07-24 Thread Nikunj A Dadhania
Paolo Bonzini writes: > Il 14/06/2013 12:32, Nikunj A Dadhania ha scritto: >> Nikunj A Dadhania writes: >>> commit 08521e28c7e6e8cc1f53424a0f845f58d2ed9546 >>> Author: Paolo Bonzini >>> Date: Fri May 24 12:54:01 2013 +0200 >>> >>> memory: add big endian support to access_with_adjusted_siz

Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: correct argument number for sys_mremap and sys_splice

2013-07-24 Thread Michael Tokarev
23.07.2013 21:33, Peter Maydell wrote: > On 23 July 2013 18:18, Michael Tokarev wrote: >> 23.07.2013 21:00, Petar Jovanovic wrote: >>> From: Petar Jovanovic >>> >>> sys_mremap missed 5th argument (new_address), which caused examples that >>> remap to a specific address to fail. >>> sys_splice mis

Re: [Qemu-devel] [Qemu-trivial] [PATCH] misc: Fix new typos in comments and strings

2013-07-24 Thread Michael Tokarev
24.07.2013 21:48, Stefan Weil wrote: > All these typos were found by codespell. > > sould -> should > emperical -> empirical > intialization -> initialization > successfuly -> successfully > gaurantee -> guarantee > > Fix also another error (before before) in the same context. Thanks, applied to

[Qemu-devel] windows guests: bad mouse responsiveness with gtk

2013-07-24 Thread Michael S. Tsirkin
I've recently tried experimenting with the gtk qemu frontend. Unfortunately with gtk, mouse seems very unresponsive: sometimes I move it and the pointer won't move, or it jumps around, or refuses to go to some parts of the screen. No issues if I supply -sdl. I don't know much about how mouse work

[Qemu-devel] [PATCH 1/1] cpu: Correct cpu-hotplug failure

2013-07-24 Thread Chen Fan
When useing x86_64-softmmu --enable-kvm boot qemu, cpu-add command fails to add a vcpu, there show (KVM: setting VAPIC address failed). The reason is that we use an uninitialized cpu->kvm-fd to ioctl. so we move realizing apic to the back of qemu_init_vcpu. Signed-off-by: Chen Fan --- include/

Re: [Qemu-devel] [PATCH 04/16] qapi: make visit_type_size fallback to type_int

2013-07-24 Thread Hu Tao
On Tue, Jul 23, 2013 at 06:23:00PM +0200, Igor Mammedov wrote: > From: Vasilis Liaskovitis > > Currently visit_type_size checks if the visitor's type_size function pointer > is > NULL. If not, it calls it, otherwise it calls v->type_uint64(). But neither of > these pointers are ever set. Fallbac

Re: [Qemu-devel] [PATCH 1/1] cpu: Correct cpu-hotplug failure

2013-07-24 Thread chenfan
On Thu, 2013-07-25 at 14:27 +0800, Chen Fan wrote: > When useing x86_64-softmmu --enable-kvm boot qemu, cpu-add command fails to > add a vcpu, > there show (KVM: setting VAPIC address failed). > > The reason is that we use an uninitialized cpu->kvm-fd to ioctl. > so we move realizing apic to the

Re: [Qemu-devel] [PATCH 06/16] dimm: implement dimm device abstraction

2013-07-24 Thread Hu Tao
On Tue, Jul 23, 2013 at 06:23:02PM +0200, Igor Mammedov wrote: > From: Vasilis Liaskovitis <...> > + > +/** > + * DimmBus: DimmDevice > + * @start: starting physical address, where @DimmDevice is mapped. > + * @size: amount of memory mapped at @start. > + * @node: numa node to which @DimmDevic

Re: [Qemu-devel] [PATCH] pc: limit 64 bit hole to 2G by default

2013-07-24 Thread Gerd Hoffmann
On 07/24/13 08:01, Michael S. Tsirkin wrote: > It turns out that some 32 bit windows guests crash > if 64 bit PCI hole size is >2G. Ah, *that* is the reason for winxp crashing with a 64bit hole. Current seabios uses a slightly different approach: the 64bit hole is present only in case it is actua

[Qemu-devel] [RFC] [PATCH] linux-user: implement m68k atomic syscalls

2013-07-24 Thread riku . voipio
From: Riku Voipio With nptl enabled, atomic_cmpxchg_32 and atomic_barrier system calls are needed. This patch enabled really dummy versions of the system calls, modeled after the m68k kernel code. With this patch I am able to execute m68k binaries with qemu linux-user (busybox compiled for coldf

Re: [Qemu-devel] [sheepdog] [PATCH 00/11] sheepdog: reconnect server after connection failure

2013-07-24 Thread MORITA Kazutaka
At Tue, 23 Jul 2013 13:08:04 +0200, Luca Lazzeroni wrote: > > Is this series of patches applyable to sheepdog-stable-0.6 band qemu 1.5.0 ? > I've seen they use async i/o... This series is against upstream qemu. I've not tried it with qemu 1.5.x, but probably it can be applied without a big cha

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-24 Thread Alex Bligh
--On 24 July 2013 08:42:26 +0200 Paolo Bonzini wrote: With ppoll, is this true or just hearsay? (Without ppoll, indeed setitimer has 1 us resolution while poll has 1 ms; too bad that select has other problems, because select has also 1 us resolution). Most 'reasonable' POSIX compliant oper

Re: [Qemu-devel] [PATCH v2 01/11] block: replace in_use with refcnt_soft and refcnt_hard

2013-07-24 Thread Stefan Hajnoczi
On Wed, Jul 24, 2013 at 08:39:53AM +0800, Fam Zheng wrote: > On Tue, 07/23 15:34, Stefan Hajnoczi wrote: > > On Tue, Jul 23, 2013 at 06:32:25PM +0800, Fam Zheng wrote: > > > On Tue, 07/23 11:36, Stefan Hajnoczi wrote: > > > > On Wed, Jul 17, 2013 at 05:42:06PM +0800, Fam Zheng wrote: > > > > > Intr

Re: [Qemu-devel] [sheepdog] [PATCH 03/11] qemu-sockets: make wait_for_connect be invoked in qemu_aio_wait

2013-07-24 Thread MORITA Kazutaka
At Tue, 23 Jul 2013 13:36:08 +0200, Paolo Bonzini wrote: > > Il 23/07/2013 10:30, MORITA Kazutaka ha scritto: > > This allows us to use inet_nonblocking_connect() and > > unix_nonblocking_connect() in block drivers. > > > > qemu-ga needs to link block-obj to resolve dependencies of > > qemu_aio_s

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 09:31, Alex Bligh ha scritto: > > > --On 24 July 2013 08:42:26 +0200 Paolo Bonzini wrote: > >> With ppoll, is this true or just hearsay? >> >> (Without ppoll, indeed setitimer has 1 us resolution while poll has 1 >> ms; too bad that select has other problems, because select has al

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-24 Thread liu ping fan
On Wed, Jul 24, 2013 at 2:42 PM, Paolo Bonzini wrote: > Il 24/07/2013 03:28, liu ping fan ha scritto: >> On Tue, Jul 23, 2013 at 6:30 PM, Paolo Bonzini wrote: >>> > Il 23/07/2013 04:53, liu ping fan ha scritto: >> The scenior I can figure out is if adopting timeout of poll, then when >>

Re: [Qemu-devel] [PATCH v2 01/11] block: replace in_use with refcnt_soft and refcnt_hard

2013-07-24 Thread Fam Zheng
On Wed, 07/24 09:35, Stefan Hajnoczi wrote: > On Wed, Jul 24, 2013 at 08:39:53AM +0800, Fam Zheng wrote: > > On Tue, 07/23 15:34, Stefan Hajnoczi wrote: > > > On Tue, Jul 23, 2013 at 06:32:25PM +0800, Fam Zheng wrote: > > > > On Tue, 07/23 11:36, Stefan Hajnoczi wrote: > > > > > On Wed, Jul 17, 201

[Qemu-devel] [PATCH qom-next for-1.6 04/29] integratorcp: QOM'ify icp_pic_state

2013-07-24 Thread Andreas Färber
Introduce type constant and use QOM cast. Fix indentation. Signed-off-by: Andreas Färber --- hw/arm/integratorcp.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/hw/arm/integratorcp.c b/hw/arm/integratorcp.c index 58f4ed7..af31007 100644 --

[Qemu-devel] [PATCH qom-next for-1.6 01/29] armv7m: QOM'ify BitBandState

2013-07-24 Thread Andreas Färber
Introduce TYPE_* constant and use QOM cast. Signed-off-by: Andreas Färber --- hw/arm/armv7m.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c index 5b22e84..82d36fb 100644 --- a/hw/arm/armv7m.c +++ b/hw/arm/armv7m.c @@ -114,

[Qemu-devel] [PATCH qom-next for-1.6 00/29] arm: QOM cast cleanups

2013-07-24 Thread Andreas Färber
Hello Peter, This series eliminates FROM_SYSBUS() in hw/arm/. Variable naming has been prepared for QOM realize and to avoid ->qdev access. Post-1.6 many of the devices should be moved into the appropriate hw/ sub-directory from their board file. Regards, Andreas Cc: Peter Maydell Cc: Peter Cr

[Qemu-devel] [PATCH qom-next for-1.6 05/29] musicpal: QOM'ify mv88w8618_eth_state

2013-07-24 Thread Andreas Färber
Introduce type constant and use QOM casts. Signed-off-by: Andreas Färber --- hw/arm/musicpal.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index b06d442..293ab26 100644 --- a/hw/arm/musicpal.c +++ b/hw/arm/musicpal.c @@

[Qemu-devel] [PATCH qom-next for-1.6 03/29] integratorcp: QOM'ify integratorcm_state

2013-07-24 Thread Andreas Färber
Rename to IntegratorCMState, introduce type constant and use QOM cast. Signed-off-by: Andreas Färber --- hw/arm/integratorcp.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/hw/arm/integratorcp.c b/hw/arm/integratorcp.c index 249a430..58f4

[Qemu-devel] [PATCH qom-next for-1.6 07/29] musicpal: Use TYPE_MV88W8618_ETH

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/musicpal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index e7efed9..e2d9e84 100644 --- a/hw/arm/musicpal.c +++ b/hw/arm/musicpal.c @@ -1641,7 +1641,7 @@ static void musicpal_init(QEMUMachineIn

[Qemu-devel] [PATCH qom-next for-1.6 17/29] pxa2xx_pic: QOM'ify PXA2xxPICState

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/pxa2xx_pic.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/arm/pxa2xx_pic.c b/hw/arm/pxa2xx_pic.c index 8929b6d..46d337c 100644 --- a/hw/arm/pxa2xx_pic.c +++ b/hw/arm/pxa2xx_pic.c @@ -31,8 +31,15 @@ #define P

[Qemu-devel] [PATCH qom-next for-1.6 09/29] musicpal: QOM'ify mv88w8618_pit_state

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/musicpal.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index d35b6cd..54ead12 100644 --- a/hw/arm/musicpal.c +++ b/hw/arm/musicpal.c @@ -814,8 +814,15 @@ typedef struct mv88w

[Qemu-devel] [PATCH qom-next for-1.6 06/29] musicpal: QOM'ify musicpal_lcd_state

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/musicpal.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index 293ab26..e7efed9 100644 --- a/hw/arm/musicpal.c +++ b/hw/arm/musicpal.c @@ -461,8 +461,15 @@ static const TypeInfo m

[Qemu-devel] [PATCH qom-next for-1.6 11/29] musicpal: QOM'ify musicpal_gpio_state

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/musicpal.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index 8c1d200..a8beae6 100644 --- a/hw/arm/musicpal.c +++ b/hw/arm/musicpal.c @@ -1181,8 +1181,15 @@ stati

[Qemu-devel] [PATCH qom-next for-1.6 26/29] strongarm: QOM'ify StrongARMPPCInfo

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/strongarm.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c index efb56b3..421ac54 100644 --- a/hw/arm/strongarm.c +++ b/hw/arm/strongarm.c @@ -706,9 +706,14 @@ static c

[Qemu-devel] [PATCH qom-next for-1.6 08/29] musicpal: QOM'ify mv88w8618_pic_state

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/musicpal.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index e2d9e84..d35b6cd 100644 --- a/hw/arm/musicpal.c +++ b/hw/arm/musicpal.c @@ -675,9 +675,15 @@ static const Ty

[Qemu-devel] [PATCH qom-next for-1.6 13/29] pxa2xx: QOM'ify PXA2xxSSPState

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/pxa2xx.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c index 3c520d7..babe22e 100644 --- a/hw/arm/pxa2xx.c +++ b/hw/arm/pxa2xx.c @@ -457,9 +457,16 @@ static const VMStat

[Qemu-devel] [PATCH qom-next for-1.6 10/29] musicpal: QOM'ify mv88w8618_flashcfg

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/musicpal.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index 54ead12..8c1d200 100644 --- a/hw/arm/musicpal.c +++ b/hw/arm/musicpal.c @@ -980,8 +980,15 @@ static const TypeInfo m

[Qemu-devel] [PATCH qom-next for-1.6 14/29] pxa2xx: QOM'ify PXA2xxRTCState

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/pxa2xx.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c index babe22e..6548338 100644 --- a/hw/arm/pxa2xx.c +++ b/hw/arm/pxa2xx.c @@ -798,8 +798,15 @@ static int pxa2xx_ssp_init(SysB

[Qemu-devel] [PATCH qom-next for-1.6 24/29] strongarm: QOM'ify StrongARMRTCState

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/strongarm.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c index 457f9c7..78211a0 100644 --- a/hw/arm/strongarm.c +++ b/hw/arm/strongarm.c @@ -242,8 +242,13 @@ static const TypeI

[Qemu-devel] [PATCH qom-next for-1.6 15/29] pxa2xx: QOM'ify PXA2xxI2CState

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/pxa2xx.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c index 6548338..ab145ee 100644 --- a/hw/arm/pxa2xx.c +++ b/hw/arm/pxa2xx.c @@ -1224,8 +1224,15 @@ typedef struct {

[Qemu-devel] [PATCH qom-next for-1.6 12/29] musicpal: QOM'ify musicpal_key_state

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/musicpal.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index a8beae6..6e8eb5d 100644 --- a/hw/arm/musicpal.c +++ b/hw/arm/musicpal.c @@ -1434,8 +1434,15 @@ static const T

[Qemu-devel] [PATCH qom-next for-1.6 20/29] stellaris: QOM'ify gptm_state

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/stellaris.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c index a2b6b17..1c69bcf 100644 --- a/hw/arm/stellaris.c +++ b/hw/arm/stellaris.c @@ -43,8 +43,13 @@ typedef const struct {

[Qemu-devel] [PATCH qom-next for-1.6 16/29] pxa2xx_gpio: QOM'ify PXA2xxGPIOInfo

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/pxa2xx_gpio.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/hw/arm/pxa2xx_gpio.c b/hw/arm/pxa2xx_gpio.c index f8c3ee0..ca77f56 100644 --- a/hw/arm/pxa2xx_gpio.c +++ b/hw/arm/pxa2xx_gpio.c @@ -13,9

[Qemu-devel] [PATCH qom-next for-1.6 28/29] strongarm: QOM'ify StrongARMSSPState

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/strongarm.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c index 61c2b22..82a9492 100644 --- a/hw/arm/strongarm.c +++ b/hw/arm/strongarm.c @@ -1336,8 +1336,14 @@ st

[Qemu-devel] [PATCH v2 0/9] sheepdog: reconnect server after connection failure

2013-07-24 Thread MORITA Kazutaka
Currently, if a sheepdog server exits, all the connecting VMs need to be restarted. This series implements a feature to reconnect the server, and enables us to do online sheepdog upgrade and avoid restarting VMs when sheepdog servers crash unexpectedly. v2: - Dropped nonblocking connect patches

[Qemu-devel] [PATCH qom-next for-1.6 27/29] strongarm: QOM'ify StrongARMUARTState

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/strongarm.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c index 421ac54..61c2b22 100644 --- a/hw/arm/strongarm.c +++ b/hw/arm/strongarm.c @@ -908,8 +908,13 @@ static const Typ

[Qemu-devel] [PATCH v2 6/9] coroutine: add co_aio_sleep_ns() to allow sleep in block drivers

2013-07-24 Thread MORITA Kazutaka
This helper function behaves similarly to co_sleep_ns(), but the sleeping coroutine will be resumed when using qemu_aio_wait(). Signed-off-by: MORITA Kazutaka --- include/block/coroutine.h | 8 qemu-coroutine-sleep.c| 47 +++ 2 files chan

Re: [Qemu-devel] Question on aio_poll

2013-07-24 Thread Stefan Hajnoczi
On Tue, Jul 23, 2013 at 03:46:23PM +0100, Alex Bligh wrote: > --On 23 July 2013 14:18:25 +0200 Stefan Hajnoczi wrote: > >Unfortunately there is an issue with the series which I haven't had time > >to look into yet. I don't remember the details but I think make check > >is failing. > > > >The curr

Re: [Qemu-devel] trim in windows guest witch virtio

2013-07-24 Thread Libaiqing
Hi paolo, With -M pc,trim works well in windows guest with ide device and ahci bus. About the filter driver,you mean do something in windows virtio-scsi driver,let it send unmap command to qemu? Thanks baiqing. > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 09:43, liu ping fan ha scritto: > Paid some time to dig the kernel code, and find out that the > resolution lost by timeout of poll/select..etc is cause by the timeout > is a slack region. > See code in > do_poll() >if (!poll_schedule_timeout(wait, TASK_INTERRUPTIBLE, to, slack))

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-24 Thread Alex Bligh
Paolo, --On 24 July 2013 09:43:28 +0200 Paolo Bonzini wrote: Most 'reasonable' POSIX compliant operating systems have ppoll Really? I could find no manpages for any of Solaris and *BSD. OK I shall (re)research that then! I suppose select() / pselect() is an alternative when there are few

[Qemu-devel] [PATCH qom-next for-1.6 23/29] strongarm: QOM'ify StrongARMPICState

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/strongarm.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c index feaaf45..457f9c7 100644 --- a/hw/arm/strongarm.c +++ b/hw/arm/strongarm.c @@ -70,8 +70,14 @@ static str

Re: [Qemu-devel] [PATCH qom-next for-1.6 07/29] musicpal: Use TYPE_MV88W8618_ETH

2013-07-24 Thread Andreas Färber
Am 24.07.2013 09:48, schrieb Andreas Färber: > Signed-off-by: Andreas Färber > --- > hw/arm/musicpal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Erm, this was supposed to be squashed, obviously. ;) Fixed. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, German

[Qemu-devel] [PATCH v2 4/9] sheepdog: handle vdi objects in resend_aio_req

2013-07-24 Thread MORITA Kazutaka
The current resend_aio_req() doesn't work when the request is against vdi objects. This fixes the problem. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index bca

[Qemu-devel] [PATCH v2 3/9] sheepdog: check return values of qemu_co_recv/send correctly

2013-07-24 Thread MORITA Kazutaka
qemu_co_recv/send return shorter length on error. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 6a41ad9..bca5730 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -67

[Qemu-devel] [PATCH qom-next for-1.6 21/29] stellaris: QOM'ify stellaris_i2c_state

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/stellaris.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c index 1c69bcf..15093ba 100644 --- a/hw/arm/stellaris.c +++ b/hw/arm/stellaris.c @@ -684,8 +684,13 @@ static in

[Qemu-devel] [PATCH qom-next for-1.6 29/29] versatilepb: QOM'ify vpb_sic_state

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/versatilepb.c | 37 + 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/hw/arm/versatilepb.c b/hw/arm/versatilepb.c index 725f60f..b48d84c 100644 --- a/hw/arm/versatilepb.c +++ b/hw/arm/versatilepb.c @@ -25

[Qemu-devel] [PATCH v2 1/9] ignore SIGPIPE in qemu-img and qemu-io

2013-07-24 Thread MORITA Kazutaka
This prevents the tools from being stopped when they write data to a closed connection in the other side. Reviewed-by: Paolo Bonzini Signed-off-by: MORITA Kazutaka --- qemu-img.c | 4 qemu-io.c | 4 2 files changed, 8 insertions(+) diff --git a/qemu-img.c b/qemu-img.c index c55ca5c.

[Qemu-devel] [PATCH v2 9/9] sheepdog: cancel aio requests if possible

2013-07-24 Thread MORITA Kazutaka
This patch tries to cancel aio requests in pending queue and failed queue. When the sheepdog driver cannot cancel the requests, it waits for them to be completed. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 70 +++- 1 file changed, 5

[Qemu-devel] [PATCH v2 7/9] sheepdog: try to reconnect to sheepdog after network error

2013-07-24 Thread MORITA Kazutaka
This introduces a failed request queue and links all the inflight requests to the list after network error happens. After QEMU reconnects to the sheepdog server successfully, the sheepdog block driver will retry all the requests in the failed queue. Signed-off-by: MORITA Kazutaka --- block/shee

[Qemu-devel] [PATCH v2 2/9] iov: handle EOF in iov_send_recv

2013-07-24 Thread MORITA Kazutaka
Without this patch, iov_send_recv() never returns when do_send_recv() returns zero. Reviewed-by: Paolo Bonzini Signed-off-by: MORITA Kazutaka --- util/iov.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/util/iov.c b/util/iov.c index cc6e837..f705586 100644 --- a/util/iov.c +++ b/uti

Re: [Qemu-devel] Question on aio_poll

2013-07-24 Thread Alex Bligh
Stefan, --On 24 July 2013 09:54:39 +0200 Stefan Hajnoczi wrote: I left this how it was in the end (I think), and got round it by creating a bogus pipe for the test to listen to. Doing that requires the changes in my patch series, otherwise you break aio_poll() loops that are waiting for pend

[Qemu-devel] [PATCH v2 8/9] sheepdog: make add_aio_request and send_aioreq void functions

2013-07-24 Thread MORITA Kazutaka
These functions no longer return errors. We can make them void functions and simplify the codes. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 66 +++- 1 file changed, 17 insertions(+), 49 deletions(-) diff --git a/block/sheepdog.c b/

[Qemu-devel] [PATCH v2 5/9] sheepdog: reload inode outside of resend_aioreq

2013-07-24 Thread MORITA Kazutaka
This prepares for using resend_aioreq() after reconnecting to the sheepdog server. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index f25c7df..cde887

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-24 Thread Alex Bligh
Paolo, --On 24 July 2013 09:54:57 +0200 Paolo Bonzini wrote: Alex, can you add it to your series? (Note that you must set a timer slack of 1, because 0 is interpreted as "default"). Sure, will do. I'm guessing I'll have to look for that inside configure as well. -- Alex Bligh

Re: [Qemu-devel] [PATCH v2 01/11] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-07-24 Thread Alexey Kardashevskiy
On 07/19/2013 05:32 AM, Anthony Liguori wrote: > From: Alexey Kardashevskiy > > The savevm code for the powerpc cpu emulation is currently based around > the old register_savevm() rather than register_vmstate() method. It's also > rather broken, missing some important state on some CPU models. >

[Qemu-devel] [PATCH qom-next for-1.6 19/29] spitz: QOM'ify SpitzKeyboardState

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/spitz.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c index 0bf5c5c..70f23b3 100644 --- a/hw/arm/spitz.c +++ b/hw/arm/spitz.c @@ -215,8 +215,13 @@ static const int spitz_gpiomap[5] =

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 10:01, Alex Bligh ha scritto: >>> >> >> Part of it should be fixed by os_setup_early_signal_handling. >> >> This is corroborated by the fact that without >> os_setup_early_signal_handling Wine always works, and Windows breaks. > > This: > http://www.windowstimestamp.com/description

Re: [Qemu-devel] trim in windows guest witch virtio

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 09:52, Libaiqing ha scritto: > Hi paolo, > With -M pc,trim works well in windows guest with ide device and ahci bus. > > About the filter driver,you mean do something in windows virtio-scsi > driver,let it send unmap command to qemu? Yes, it must trap the IOCTL_STORAGE_MA

Re: [Qemu-devel] [PATCH v2 01/11] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-07-24 Thread Andreas Färber
Am 24.07.2013 10:16, schrieb Alexey Kardashevskiy: > On 07/19/2013 05:32 AM, Anthony Liguori wrote: >> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c >> index 79bfcd8..09ea944 100644 >> --- a/target-ppc/translate_init.c >> +++ b/target-ppc/translate_init.c >> @@ -8449,6 +844

[Qemu-devel] [PATCH qom-next for-1.6 18/29] spitz: QOM'ify SLNANDState

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/spitz.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c index 593b75e..0bf5c5c 100644 --- a/hw/arm/spitz.c +++ b/hw/arm/spitz.c @@ -50,8 +50,12 @@ #define FLASHCTL_RYBY (1 <<

[Qemu-devel] [PATCH qom-next for-1.6 02/29] highbank: QOM'ify HighbankRegsState

2013-07-24 Thread Andreas Färber
Add type constant and use QOM casts. Signed-off-by: Andreas Färber --- hw/arm/highbank.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index be264d3..35d5511 100644 --- a/hw/arm/highbank.c +++ b/hw/arm/highbank.c @@ -1

  1   2   3   >