[Qemu-devel] [PATCH v3] gtk: Fix accelerator filtering

2013-07-22 Thread Jan Kiszka
This is in fact very simply: When the input in grabbed, everything should be exclusively passed to the guest - except it has our magic CTRL-ALT modifier set. Then let GTK filter out those accels that are in use. When checking the modifier state, we just need to filter out NUM and CAPS lock. Note:

Re: [Qemu-devel] [PATCH 0/2] block: allow commit active as top

2013-07-22 Thread Fam Zheng
On Mon, 07/22 14:43, Wenchao Xia wrote: > 于 2013-7-22 11:46, Fam Zheng 写道: > > Previously live commit of active block device is not supported, this series > > implements it and updates corresponding qemu-iotests cases. > > > > Please see commit messages for implementation details. > > > > Fam Zhe

Re: [Qemu-devel] [PATCH] migration: send total time in QMP at "completed" stage

2013-07-22 Thread Orit Wasserman
On 07/19/2013 05:23 AM, Pawit Pornkitprasan wrote: > The "completed" stage sets total_time but not has_total_time and > thus it is not sent via QMP reply (but sent via HMP nevertheless) > > Signed-off-by: Pawit Pornkitprasan > --- > migration.c | 1 + > 1 file changed, 1 insertion(+) > > diff -

Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables

2013-07-22 Thread Orit Wasserman
On 07/19/2013 05:36 AM, Pawit Pornkitprasan wrote: > The qmp_migrate method uses the 'blk' and 'inc' parameter without > checking if they're valid or not (they may be uninitialized if > command is received via QMP) > > Signed-off-by: Pawit Pornkitprasan > --- > migration.c | 4 ++-- > 1 file cha

Re: [Qemu-devel] [PATCH qom-next] fdc: Improve error propagation for QOM realize

2013-07-22 Thread Hu Tao
On Sun, Jul 21, 2013 at 11:31:57AM +0200, Andreas Färber wrote: > Rename fdctrl_init_common() to fdctrl_realize_common() and let > fdctrl_connect_drives() propagate an Error through it. > > Signed-off-by: Andreas Färber > --- > hw/block/fdc.c | 40 ++-- > 1 fi

Re: [Qemu-devel] Possibility of unaligned DMA accesses via the QEMU DMA API?

2013-07-22 Thread Mark Cave-Ayland
On 18/07/13 14:44, Alexander Graf wrote: What I would do, however, is to complete even the INPUT/OUTPUT_MORE commands only at the end of the whole request. This is definitely allowed behaviour, and it ensures that a memory region isn't already reused by the OS while e.g. a write request is still

[Qemu-devel] [PATCH V4 0/5] Redefine and export backing file loop check

2013-07-22 Thread Xu Wang
If there is loop exists in the backing file chain, many problems could be caused by it, such as no response and segment fault during system boot. Hence stopping backing file loop appear is very necessary. These patches refine and export loop checking function from collect_image_ info_list() to bloc

Re: [Qemu-devel] [PATCH] qemu-options: mention C-a h in the -nographic doc

2013-07-22 Thread Stefan Hajnoczi
On Sat, Jul 20, 2013 at 04:53:09PM +0530, Ramkumar Ramachandra wrote: > Otherwise, a new user will be wondering how to switch between the > console and monitor. > > Cc: Anthony Liguori > Cc: Stefan Hajnoczi > Cc: Markus Armbruster > Cc: Marcelo Tosatti > Cc: Peter Maydell > Signed-off-by: Ram

[Qemu-devel] [PATCH V4 2/5] block: Add WIN32 platform support for backing_file_loop_check()

2013-07-22 Thread Xu Wang
Method of get_inode is different between Linux and WIN32 plateform. This patch added inode caculate method on Windows plateform so that backing file check could work on Windows plateform. Signed-off-by: Xu Wang --- block.c | 160 1

[Qemu-devel] [PATCH V4 1/5] block/qemu-img: Refine and export infinite loop checking in collect_image_info_list()

2013-07-22 Thread Xu Wang
If there is a loop exists in the backing file chain, many problems could be caused by it, such as no response and segment fault during system boot. Hence stopping backing file loop appear is very necessary. This patch refine and export loop checking function from collect_image_ info_list() to block

[Qemu-devel] [PATCH V4 3/5] block: Check infinite loop in bdrv_img_create()

2013-07-22 Thread Xu Wang
Backing file loop should be checked before qemu-img create command execution. If loop was found, qemu-img create should be stopped and an error was printed. Signed-off-by: Xu Wang --- block.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index 3

[Qemu-devel] [PATCH V4 4/5] block: Add backing file loop check in change_backing_file()

2013-07-22 Thread Xu Wang
Backing file loop should be checked before calling change_backing_ file(). If loop appeared, this calling should be stopped and an error was printed. Signed-off-by: Xu Wang --- block.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/block.c b/block.c index 9daf63c..d996524 100644 ---

[Qemu-devel] [PATCH V4 5/5] block: Add infinite loop check in drive_init()

2013-07-22 Thread Xu Wang
Backing file should be checked if there is a loop in it during image boot. Becase if there is loop qemu would no response for a long time and segment fault occured. So this patch would check backing file chain if there is loop in it before open image. Signed-off-by: Xu Wang --- blockdev.c | 7 ++

Re: [Qemu-devel] [PATCH qom-next] fdc: Improve error propagation for QOM realize

2013-07-22 Thread Stefan Hajnoczi
On Sun, Jul 21, 2013 at 11:31:57AM +0200, Andreas Färber wrote: > Rename fdctrl_init_common() to fdctrl_realize_common() and let > fdctrl_connect_drives() propagate an Error through it. > > Signed-off-by: Andreas Färber > --- > hw/block/fdc.c | 40 ++-- > 1 fi

Re: [Qemu-devel] [PATCH V4 2/5] block: Add WIN32 platform support for backing_file_loop_check()

2013-07-22 Thread Fam Zheng
On Mon, 07/22 04:05, Xu Wang wrote: > Method of get_inode is different between Linux and WIN32 plateform. > This patch added inode caculate method on Windows plateform so that > backing file check could work on Windows plateform. > > Signed-off-by: Xu Wang > --- > block.c | 160 > ++

Re: [Qemu-devel] [PATCH V4 3/5] block: Check infinite loop in bdrv_img_create()

2013-07-22 Thread Fam Zheng
On Mon, 07/22 04:05, Xu Wang wrote: > Backing file loop should be checked before qemu-img create command > execution. If loop was found, qemu-img create should be stopped and > an error was printed. > > Signed-off-by: Xu Wang > --- > block.c | 10 +- > 1 file changed, 5 insertions(+), 5

Re: [Qemu-devel] [PATCH V4 4/5] block: Add backing file loop check in change_backing_file()

2013-07-22 Thread Fam Zheng
On Mon, 07/22 04:05, Xu Wang wrote: > Backing file loop should be checked before calling change_backing_ > file(). If loop appeared, this calling should be stopped and an > error was printed. > > Signed-off-by: Xu Wang > --- > block.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --gi

Re: [Qemu-devel] [PATCH v2] target-mips: fix mipsdsp_trunc16_sat16_round

2013-07-22 Thread Petar Jovanovic
ping From: Petar Jovanovic Sent: Monday, July 15, 2013 1:46 PM To: Richard Henderson; Petar Jovanovic Cc: qemu-devel@nongnu.org; aurel...@aurel32.net Subject: RE: [PATCH v2] target-mips: fix mipsdsp_trunc16_sat16_round ping _

Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15

2013-07-22 Thread Petar Jovanovic
ping From: Petar Jovanovic Sent: Monday, July 15, 2013 1:46 PM To: Richard Henderson Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurel...@aurel32.net Subject: RE: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15 ping _

[Qemu-devel] [PATCH v3 0/4] target-openrisc hw/openrisc: Some OpenRISC fix.

2013-07-22 Thread Jia Liu
Fix OpenRISC CPU and sim broad, we should free typename and check cpu models by name in cpu.c, and we should use stderr output in openrisc_sim.c. Updates from V3: * Replace a typo fix using a stderr fix. Updates from V2: * Combine typo patchset and typename free. * Add cpu_model by name fix, make

[Qemu-devel] [PATCH v3 1/4] hw/openrisc: Indent typo

2013-07-22 Thread Jia Liu
Indent typo. Signed-off-by: Jia Liu --- hw/openrisc/openrisc_sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c index 924438b..250f5b5 100644 --- a/hw/openrisc/openrisc_sim.c +++ b/hw/openrisc/openrisc_sim.c @@ -96,7

[Qemu-devel] [PATCH v3 3/4] target-openrisc: Free typename

2013-07-22 Thread Jia Liu
We should free typename here. Signed-off-by: Jia Liu --- target-openrisc/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c index 6d40f1b..e348df0 100644 --- a/target-openrisc/cpu.c +++ b/target-openrisc/cpu.c @@ -99,6 +99,7 @@ static ObjectCl

[Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Jia Liu
Fix cpu_model by name, make any and or1200 works both OK. Signed-off-by: Jia Liu --- target-openrisc/cpu.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c index e348df0..6637166 100644 --- a/target-openrisc/cpu.c

[Qemu-devel] [PATCH v3 2/4] hw/openrisc: Use stderr output instead of qemu_log

2013-07-22 Thread Jia Liu
We should use stderr output instead of qemu_log in order to output ErrMsg onto the screen. Signed-off-by: Jia Liu --- hw/openrisc/openrisc_sim.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c index 250f5b5..a08f27c

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-22 Thread Fabien Chouteau
On 07/19/2013 07:19 PM, Scott Wood wrote: > On 07/19/2013 04:22:46 AM, Fabien Chouteau wrote: >> On 07/18/2013 10:37 PM, Scott Wood wrote: >> > On 07/18/2013 04:27:50 AM, Fabien Chouteau wrote: >> >> The BD is full, we will have to put the rest of padding in the next one. >> > >> > What rest of pad

Re: [Qemu-devel] [PATCH v2 17/26] fwcfg: use realize for fwcfg

2013-07-22 Thread Hu Tao
On Sun, Jul 21, 2013 at 11:35:55AM +0200, Andreas Färber wrote: > Am 01.07.2013 12:18, schrieb Hu Tao: > > Signed-off-by: Hu Tao > > --- > > hw/nvram/fw_cfg.c | 26 -- > > 1 file changed, 16 insertions(+), 10 deletions(-) > > > > diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/

Re: [Qemu-devel] [PATCH qom-next] scsi: Improve error propagation for scsi_bus_legacy_handle_cmdline()

2013-07-22 Thread Hu Tao
On Sun, Jul 21, 2013 at 12:30:54PM +0200, Andreas Färber wrote: > Let scsi_bus_legacy_add_drive() and scsi_bus_legacy_handle_cmdline() > return an Error**. Prepare qdev initfns for QOM realize error model. > > Signed-off-by: Andreas Färber > --- > hw/pci/pci-hotplug-old.c | 2 +- > hw/scsi/esp-

Re: [Qemu-devel] [RFC PATCH] spapr-vscsi: add task management

2013-07-22 Thread Alexey Kardashevskiy
On 07/22/2013 04:30 PM, Paolo Bonzini wrote: > Il 22/07/2013 03:04, Benjamin Herrenschmidt ha scritto: >> The free_request callback >> is not directly "linked" to task management though it happens to only >> be called in that case. It's a pre-requisite to task management, make it >> a separate patc

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Peter Maydell
On 22 July 2013 09:56, Jia Liu wrote: > Fix cpu_model by name, make any and or1200 works both OK. > > Signed-off-by: Jia Liu > --- > target-openrisc/cpu.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c > in

Re: [Qemu-devel] [PATCH v3 2/4] hw/openrisc: Use stderr output instead of qemu_log

2013-07-22 Thread Peter Maydell
On 22 July 2013 09:56, Jia Liu wrote: > We should use stderr output instead of qemu_log in order to output ErrMsg > onto the screen. > > Signed-off-by: Jia Liu Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH v3 3/4] target-openrisc: Free typename

2013-07-22 Thread Jia Liu
Hi Andreas, On Mon, Jul 22, 2013 at 4:56 PM, Jia Liu wrote: > We should free typename here. > > Signed-off-by: Jia Liu Sorry I didn't know I need add Signed-off-by: Andreas Färber here. > --- > target-openrisc/cpu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target-openrisc/cp

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-22 Thread Alex Bligh
Liu, --On 22 July 2013 12:38:02 +0800 liu ping fan wrote: I read your second series, and try to summary the main different between us. Please correct me, if I misunderstood something. --1st. You try to create a separate QemuClock for AioContext. I think QemuClock is the clock event source

Re: [Qemu-devel] [PATCH v3 3/4] target-openrisc: Free typename

2013-07-22 Thread Peter Maydell
On 22 July 2013 10:37, Jia Liu wrote: > Hi Andreas, > > On Mon, Jul 22, 2013 at 4:56 PM, Jia Liu wrote: >> We should free typename here. >> >> Signed-off-by: Jia Liu > > Sorry I didn't know I need add Signed-off-by: Andreas Färber here. Not Signed-off-by, Reviewed-by. The distinction is import

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Jia Liu
Hi Andreas and Peter, On Mon, Jul 22, 2013 at 5:29 PM, Peter Maydell wrote: > On 22 July 2013 09:56, Jia Liu wrote: >> Fix cpu_model by name, make any and or1200 works both OK. >> >> Signed-off-by: Jia Liu >> --- >> target-openrisc/cpu.c | 16 >> 1 file changed, 12 insertions(

Re: [Qemu-devel] [PATCH v3 3/4] target-openrisc: Free typename

2013-07-22 Thread Jia Liu
On Mon, Jul 22, 2013 at 5:41 PM, Peter Maydell wrote: > On 22 July 2013 10:37, Jia Liu wrote: >> Hi Andreas, >> >> On Mon, Jul 22, 2013 at 4:56 PM, Jia Liu wrote: >>> We should free typename here. >>> >>> Signed-off-by: Jia Liu >> >> Sorry I didn't know I need add Signed-off-by: Andreas Färber

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Peter Maydell
On 22 July 2013 10:42, Jia Liu wrote: > Hi Andreas and Peter, > > On Mon, Jul 22, 2013 at 5:29 PM, Peter Maydell > wrote: >> This looks a bit odd. The commit message suggests it's an >> attempt to fix the bug that was fixed by commit 071b3364e -- >> is it really needed? Andreas? > > commit 071b3

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Paolo Bonzini
Il 22/07/2013 08:49, Orit Wasserman ha scritto: > Older KVM versions save CS dpl value to an invalid value for real mode guests > (0x3). This patch detect this situation when loading CPU state and set all the > segments dpl to zero. > This will allow migration from older KVM on host without unrestr

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Jia Liu
On Mon, Jul 22, 2013 at 5:43 PM, Peter Maydell wrote: > On 22 July 2013 10:42, Jia Liu wrote: >> Hi Andreas and Peter, >> >> On Mon, Jul 22, 2013 at 5:29 PM, Peter Maydell >> wrote: >>> This looks a bit odd. The commit message suggests it's an >>> attempt to fix the bug that was fixed by commit

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Gleb Natapov
On Mon, Jul 22, 2013 at 11:49:25AM +0200, Paolo Bonzini wrote: > Il 22/07/2013 08:49, Orit Wasserman ha scritto: > > Older KVM versions save CS dpl value to an invalid value for real mode > > guests > > (0x3). This patch detect this situation when loading CPU state and set all > > the > > segment

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Orit Wasserman
On 07/22/2013 12:49 PM, Paolo Bonzini wrote: > Il 22/07/2013 08:49, Orit Wasserman ha scritto: >> Older KVM versions save CS dpl value to an invalid value for real mode guests >> (0x3). This patch detect this situation when loading CPU state and set all >> the >> segments dpl to zero. >> This will

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Jia Liu
On Mon, Jul 22, 2013 at 5:43 PM, Peter Maydell wrote: > On 22 July 2013 10:42, Jia Liu wrote: >> Hi Andreas and Peter, >> >> On Mon, Jul 22, 2013 at 5:29 PM, Peter Maydell >> wrote: >>> This looks a bit odd. The commit message suggests it's an >>> attempt to fix the bug that was fixed by commit

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Paolo Bonzini
Il 22/07/2013 12:10, Orit Wasserman ha scritto: > > As discussed offlist, I would prefer to have this in the kernel since > > that's where the bug is. Gleb disagrees. > > As this is a migration bug I prefer to fix it in the migration code only. > Fixing it in the kernel will effect all scenarios

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-22 Thread liu ping fan
On Mon, Jul 22, 2013 at 5:40 PM, Alex Bligh wrote: > Liu, > > > --On 22 July 2013 12:38:02 +0800 liu ping fan wrote: > >> I read your second series, and try to summary the main different between >> us. Please correct me, if I misunderstood something. >> --1st. You try to create a separate QemuClo

Re: [Qemu-devel] [PATCH] target-mips: fix branch in likely delay slot tcg assert

2013-07-22 Thread Yongbok Kim
Ping! http://patchwork.ozlabs.org/patch/253911/ Is there any other person who can review the change? It seems that Aurelien didn't reply any of patches recently. Best Regards, Yongbok Kim -Original Message- From: Yongbok Kim Sent: 08 July 2013 10:44 To: qemu-devel@nongnu.org Cc: aure

Re: [Qemu-devel] [PATCH qom-next] scsi: Improve error propagation for scsi_bus_legacy_handle_cmdline()

2013-07-22 Thread Andreas Färber
Am 22.07.2013 11:16, schrieb Hu Tao: > On Sun, Jul 21, 2013 at 12:30:54PM +0200, Andreas Färber wrote: >> Let scsi_bus_legacy_add_drive() and scsi_bus_legacy_handle_cmdline() >> return an Error**. Prepare qdev initfns for QOM realize error model. >> >> Signed-off-by: Andreas Färber >> --- >> hw/p

Re: [Qemu-devel] BUG: Re: [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-22 Thread Paolo Bonzini
Il 21/07/2013 17:13, Hervé Poussineau ha scritto: > Paolo Bonzini a écrit : > >> oops. I am wrong and VGA works on mac99 in upstream because > isa_mmio_ops >>> does the swapping in this case and portio_ops does not swap (in >>> upstream). >> >> Uff... I guess we have to look at all cases for big-e

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Andreas Färber
Am 22.07.2013 11:49, schrieb Paolo Bonzini: > Il 22/07/2013 08:49, Orit Wasserman ha scritto: >> Older KVM versions save CS dpl value to an invalid value for real mode guests >> (0x3). This patch detect this situation when loading CPU state and set all >> the >> segments dpl to zero. >> This will

[Qemu-devel] [PATCH v4 2/3] hw/openrisc: Use stderr output instead of qemu_log

2013-07-22 Thread Jia Liu
We should use stderr output instead of qemu_log in order to output ErrMsg onto the screen. Signed-off-by: Jia Liu Reviewed-by: Peter Maydell --- hw/openrisc/openrisc_sim.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_s

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Andreas Färber
Am 22.07.2013 11:43, schrieb Peter Maydell: > On 22 July 2013 10:42, Jia Liu wrote: >> Hi Andreas and Peter, >> >> On Mon, Jul 22, 2013 at 5:29 PM, Peter Maydell >> wrote: >>> This looks a bit odd. The commit message suggests it's an >>> attempt to fix the bug that was fixed by commit 071b3364e

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Peter Maydell
On 22 July 2013 11:37, Andreas Färber wrote: > Am 22.07.2013 11:43, schrieb Peter Maydell: >>> commit 071b3364e fix the typename only, but this one make "-cpu any" >>> "-cpu or1200" "-cpu any-or32-cpu" "-cpu or1200-or32-cpu" working fine. >> >> The last two of these would be wrong: -cpu should onl

[Qemu-devel] [PATCH] kvm: add KVM_IRQFD_FLAG_RESAMPLE support

2013-07-22 Thread Vincenzo Maffione
>From e59e35380380c2986cd0164f11dcd8a07a8e4e59 Mon Sep 17 00:00:00 2001 From: Vincenzo Maffione Date: Mon, 22 Jul 2013 11:51:33 +0200 Subject: [PATCH] kvm: add KVM_IRQFD_FLAG_RESAMPLE support Added an EventNotifier* parameter to kvm-all.c:kvm_irqchip_add_irqfd_notifier(), in order to give KVM ano

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Gleb Natapov
On Mon, Jul 22, 2013 at 12:33:31PM +0200, Andreas Färber wrote: > Am 22.07.2013 11:49, schrieb Paolo Bonzini: > > Il 22/07/2013 08:49, Orit Wasserman ha scritto: > >> Older KVM versions save CS dpl value to an invalid value for real mode > >> guests > >> (0x3). This patch detect this situation whe

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Juan Quintela
Orit Wasserman wrote: > Older KVM versions save CS dpl value to an invalid value for real mode guests > (0x3). This patch detect this situation when loading CPU state and set all the > segments dpl to zero. > This will allow migration from older KVM on host without unrestricted guest > to hosts wi

Re: [Qemu-devel] [PATCH] gdbstub: fix sThreadInfo handler

2013-07-22 Thread Andreas Färber
Am 22.07.2013 07:24, schrieb Max Filippov: > After the commit 182735e cpu: Make first_cpu and next_cpu CPUState > we can no longer blindly use cpu->next_cpu->env_ptr to get CPUArchState > of the next CPU, as the next_cpu is NULL in the last CPU. > > This fixes segfault caused by gdb command 'info

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Orit Wasserman
On 07/22/2013 01:33 PM, Andreas Färber wrote: > Am 22.07.2013 11:49, schrieb Paolo Bonzini: >> Il 22/07/2013 08:49, Orit Wasserman ha scritto: >>> Older KVM versions save CS dpl value to an invalid value for real mode >>> guests >>> (0x3). This patch detect this situation when loading CPU state an

Re: [Qemu-devel] [PATCH 1/2] block: allow live commit of active image

2013-07-22 Thread Paolo Bonzini
Il 22/07/2013 08:48, Fam Zheng ha scritto: >> > I have only skimmed the patch, but I think this is incomplete. >> > Management needs to know the moment when 'active' is not valid anymore, >> > thus this job needs to be completed manually with "block-job-complete". > Does management need access to '

[Qemu-devel] [PATCH v2 2/2] Fix real mode guest segments dpl value in savevm

2013-07-22 Thread Orit Wasserman
Older KVM version put invalid value in the segments registers dpl field for real mode guests (0x3). This breaks migration from those hosts to hosts with unrestricted guest support. We detect it by checking CS dpl value for real mode guest and fix the dpl values of all the segment registers. Signed

[Qemu-devel] [PATCH v2 0/2] Fix real mode guest live migration

2013-07-22 Thread Orit Wasserman
Older KVM versions save CS dpl value to an invalid value for real mode guests (0x3). This caused migration to fail from older KVM on host without unrestricted guest to hosts with restricted guest support with "kvm: unhandled exit 8021". For example migration from a Penryn host (with kernel 2.

[Qemu-devel] [PATCH v2 1/2] Fix real mode guest migration

2013-07-22 Thread Orit Wasserman
Older KVM versions save CS dpl value to an invalid value for real mode guests (0x3). This patch detect this situation when loading CPU state and set all the segments dpl to zero. This will allow migration from older KVM on host without unrestricted guest to hosts with restricted guest support. For

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Andreas Färber
Am 22.07.2013 12:40, schrieb Peter Maydell: > On 22 July 2013 11:37, Andreas Färber wrote: >> Am 22.07.2013 11:43, schrieb Peter Maydell: commit 071b3364e fix the typename only, but this one make "-cpu any" "-cpu or1200" "-cpu any-or32-cpu" "-cpu or1200-or32-cpu" working fine. >>> >>> Th

[Qemu-devel] [PATCH v4 0/3] target-openrisc hw/openrisc: Some OpenRISC fix.

2013-07-22 Thread Jia Liu
Fix OpenRISC CPU and sim broad. We should free typename in openrisc_cpu_class_by_name, and we should use stderr output in openrisc_sim.c. Updates from V4: * Remove a not needed patch. Updates from V3: * Replace a typo fix using a stderr fix. Updates from V2: * Combine typo patchset and typenam

[Qemu-devel] [Question] why x2apic's set by default without host support(on Nehalem CPU).

2013-07-22 Thread Peter Huang(Peng)
Hi, Everyone I have been encountered a problem recently. My box uses Nehalem E5520 CPU, and this model doesn't support x2apic feature. I created a VM on KVM, and uses cpu mode=pass-through, I can get the right cpu model from the VM, but I can also see that the CPU in the vm supports x2apic. This

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Peter Maydell
On 22 July 2013 12:17, Andreas Färber wrote: > Am 22.07.2013 12:40, schrieb Peter Maydell: >> Yep; my view is that the acceptance of the -or32-cpu varieties >> was a bug which we have now fixed. In any case we should be >> consistent across target architectures about what we allow. >> I'm happy wi

[Qemu-devel] [PATCH v3 1/6] pc: Don't prematurely explode QEMUMachineInitArgs

2013-07-22 Thread Markus Armbruster
Don't explode QEMUMachineInitArgs before passing it to pc_init1(). Signed-off-by: Markus Armbruster --- hw/i386/pc_piix.c | 72 --- 1 file changed, 20 insertions(+), 52 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index b58c

[Qemu-devel] [PULL 08/10] vexpress: Add virtio-mmio transports

2013-07-22 Thread Peter Maydell
Add some virtio-mmio transports to the vexpress board model, together with a modify_dtb hook which adds them to the device tree so that the kernel will probe for them. We put them in a reserved area of the address map. Signed-off-by: Peter Maydell Message-id: 1373977512-28932-9-git-send-email-pet

Re: [Qemu-devel] [PATCH v2 0/6] Clean up bogus default boot order

2013-07-22 Thread Markus Armbruster
Anthony Liguori writes: > Markus Armbruster writes: > >> Ping? > > This needs a rebase. v3 sent.

[Qemu-devel] [PATCH v3 0/6] Clean up bogus default boot order

2013-07-22 Thread Markus Armbruster
The first five patches are admittedly related to the stated purpose of this series pretty much only by "I can't stand perpetuating this stupid crap". Max Filippov and Peter Maydell already cleaned up Xtensa and ARM the same way. v3: * Rebase * Don't screw up default CPU model for machine "isapc"

[Qemu-devel] [PULL 10/10] hw/arm: Use 'load_ramdisk()' for loading ramdisks w/ U-Boot header

2013-07-22 Thread Peter Maydell
From: Soren Brinkmann The load_ramdisk function is used to load ramdisk featuring a U-Boot header. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Maydell Message-id: 1373323202-17083-3-git-send-email-soren.brinkm...@xilinx.com Signed-off-by: Peter Maydell --- hw/arm/boot.c | 14

[Qemu-devel] [PULL 01/10] device_tree: Add qemu_devtree_setprop_sized_cells() utility functions

2013-07-22 Thread Peter Maydell
We already have a qemu_devtree_setprop_cells() which sets a dtb property to an array of cells whose values are specified by varargs. However for the fairly common case of setting a property to a list of addresses or of address,size pairs the number of cells used by each element in the list depends

[Qemu-devel] [PULL 04/10] virtio: Support transports which can specify the vring alignment

2013-07-22 Thread Peter Maydell
Support virtio transports which can specify the vring alignment (ie where the guest communicates this to the host) by providing a new virtio_queue_set_align() function. (The default alignment remains as before.) Transports which wish to make use of this must set the has_variable_vring_alignment fi

[Qemu-devel] [PULL 09/10] hw/loader: Support ramdisk with u-boot header

2013-07-22 Thread Peter Maydell
From: Soren Brinkmann Introduce 'load_ramdisk()' which can load "normal" ramdisks and ramdisks with a u-boot header. To enable this and leverage synergies 'load_uimage()' is refactored to accomodate this additional use case. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Maydell Message-id:

[Qemu-devel] [PULL 06/10] arm/boot: Allow boards to modify the FDT blob

2013-07-22 Thread Peter Maydell
Add a callback hook in arm_boot_info to allow board models to modify the device tree blob if they need to. (The major expected use case is to add virtio-mmio nodes for virtio-mmio transports that exist in QEMU but not in the hardware.) Signed-off-by: Peter Maydell Message-id: 1373977512-28932-7-g

[Qemu-devel] [PULL 05/10] virtio: Implement MMIO based virtio transport

2013-07-22 Thread Peter Maydell
Add support for the generic MMIO based virtio transport. This patch includes some fixes for bugs spotted by Ying-Shiuan Pan . Signed-off-by: Peter Maydell Signed-off-by: KONRAD Frederic Message-id: 1373977512-28932-6-git-send-email-peter.mayd...@linaro.org [Fred changes: updated to new virtio-b

[Qemu-devel] [PULL 00/10] arm-devs queue

2013-07-22 Thread Peter Maydell
ll/qemu-arm.git tags/pull-arm-devs-20130722 for you to fetch changes up to fd76663e3fe59dc7f7d5c439561b74f472727137: hw/arm: Use 'load_ramdisk()' for loading ramdisks w/ U-Boot header (2013-07-22 12:01:37 +0100) -

[Qemu-devel] [PULL 03/10] virtio: Add support for guest setting of queue size

2013-07-22 Thread Peter Maydell
The MMIO virtio transport spec allows the guest to tell the host how large the queue size is. Add virtio_queue_set_num() function which implements this in the QEMU common virtio support code. Signed-off-by: Peter Maydell Message-id: 1373977512-28932-4-git-send-email-peter.mayd...@linaro.org ---

[Qemu-devel] [PATCH v3 6/6] hw: Clean up bogus default boot order

2013-07-22 Thread Markus Armbruster
We set default boot order "cad" in every single machine definition except "pseries" and "moxiesim", even though very few boards actually care for boot order, and "cad" makes sense for even fewer. Machines that care: * pc and its variants Accept up to three letters 'a', 'b' (undocumented alias

[Qemu-devel] [PATCH v3 2/6] pc: Don't explode QEMUMachineInitArgs into local variables needlessly

2013-07-22 Thread Markus Armbruster
Don't explode when the variable is used just a few times, and never changed. Signed-off-by: Markus Armbruster --- hw/i386/pc_q35.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 6f10246..1657eb3 100644 --- a/h

[Qemu-devel] [PATCH v3 3/6] sun4: Don't prematurely explode QEMUMachineInitArgs

2013-07-22 Thread Markus Armbruster
Don't explode QEMUMachineInitArgs before passing it to sun4m_hw_init(), sun4uv_init(). Signed-off-by: Markus Armbruster --- hw/sparc/sun4m.c | 113 - hw/sparc64/sun4u.c | 52 +++- 2 files changed, 40 insertions(+), 125 de

[Qemu-devel] [PULL 02/10] arm/boot: Use qemu_devtree_setprop_sized_cells()

2013-07-22 Thread Peter Maydell
Replace the opencoded assembly of the reg property array for the /memory node with a call to qemu_devtree_setprop_sized_cells(). Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite Message-id: 1373977512-28932-3-git-send-email-peter.mayd...@linaro.org --- hw/arm/boot.c | 29 --

[Qemu-devel] [PULL 07/10] vexpress: Make VEDBoardInfo extend arm_boot_info

2013-07-22 Thread Peter Maydell
Make the VEDBoardInfo struct extend arm_boot_info; this will allow us to get at the VEDBoardInfo information inside callbacks from arm/boot code. Signed-off-by: Peter Maydell Message-id: 1373977512-28932-8-git-send-email-peter.mayd...@linaro.org --- hw/arm/vexpress.c | 31 +++--

Re: [Qemu-devel] -cpu behavior (was: [PATCH v3 4/4] target-openrisc: Fix cpu_model by name)

2013-07-22 Thread Andreas Färber
Am 22.07.2013 13:34, schrieb Peter Maydell: > On 22 July 2013 12:17, Andreas Färber wrote: >> Am 22.07.2013 12:40, schrieb Peter Maydell: >>> In any case we should be >>> consistent across target architectures about what we allow. >> >> alpha allows both, but -cpu ? just gave me a segfault. :/ >

Re: [Qemu-devel] [PATCH v3 00/13] linux-user: enable NPTL on everything

2013-07-22 Thread Peter Maydell
Ping! Can we get this in for 1.6? thanks -- PMM On 16 July 2013 18:44, Peter Maydell wrote: > This patchset enables NPTL on all linux-user targets; this is a > change for i386, m68k, mipsn32, mipsn32el, mips64, mips64el, > or32, ppc64, ppc46abi32, sparc, sparc32plus, sparc64, unicore32 > and x86

[Qemu-devel] [PATCH 0/4] Leaky bucket throttling and features

2013-07-22 Thread Benoît Canet
The first patch fixes the throttling which was broken by a previous commit. The next patch replace the existing throttling algorithm by the well described leaky bucket algorithm. Third patch implement bursting by adding *_threshold parameters to qmp_block_set_io_throttle. The last one allow to d

[Qemu-devel] [PATCH 1/4] block: Repair the throttling code.

2013-07-22 Thread Benoît Canet
The throttling code was segfaulting since commit 02ffb504485f0920cfc75a0982a602f824a9a4f4 because some qemu_co_queue_next caller does not run in a coroutine. qemu_co_queue_do_restart assume that the caller is a coroutinne. As sugested by Stefan fix this by entering the coroutine directly. Signed-o

[Qemu-devel] [PATCH 2/4] block: Modify the throttling code to implement the leaky bucket algorithm.

2013-07-22 Thread Benoît Canet
This patch replace the previous algorithm by the well described leaky bucket algorithm: A bucket is filled by the incoming IOs and a periodic timer decrement the counter to make the bucket leak. When a given threshold is reached the bucket is full and the IOs are hold. In this patch the threshold

[Qemu-devel] [PATCH 3/4] block: Add support for throttling burst threshold in QMP and the command line.

2013-07-22 Thread Benoît Canet
The thresholds of the leaky bucket algorithm can be used to allow some burstiness. Signed-off-by: Benoit Canet --- block/qapi.c | 24 + blockdev.c | 105 +++--- hmp.c| 32 +++-- qapi-schema.json |

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Andreas Färber
Am 22.07.2013 13:34, schrieb Peter Maydell: > On 22 July 2013 12:17, Andreas Färber wrote: >> Am 22.07.2013 12:40, schrieb Peter Maydell: >>> In any case we should be >>> consistent across target architectures about what we allow. >> >> alpha allows both [...] >> It didn't have -cpu ? before QOM,

Re: [Qemu-devel] [Question] why x2apic's set by default without host support(on Nehalem CPU).

2013-07-22 Thread Peter Huang(Peng)
I traced the qemu process, and find out that host cpuid doesn't support x2apic, but VM interception seems enabled x2apic. with function=1(bit 21 indicates x2apic) host_cpuid:ecx=0x009ce3bd guest_cpuid:ecx=0x00b82201 On 2013-07-22 19:24, Peter Huang(Peng) wrote: > Hi, Everyone > > I have been enco

Re: [Qemu-devel] [PATCH] gdbstub: fix sThreadInfo handler

2013-07-22 Thread Max Filippov
On Mon, Jul 22, 2013 at 2:54 PM, Andreas Färber wrote: > Am 22.07.2013 07:24, schrieb Max Filippov: >> After the commit 182735e cpu: Make first_cpu and next_cpu CPUState >> we can no longer blindly use cpu->next_cpu->env_ptr to get CPUArchState >> of the next CPU, as the next_cpu is NULL in the la

[Qemu-devel] [PATCH v4 3/3] target-openrisc: Free typename in openrisc_cpu_class_by_name

2013-07-22 Thread Jia Liu
We should free typename here. Signed-off-by: Jia Liu Reviewed-by: Andreas Färber --- target-openrisc/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c index 6d40f1b..e348df0 100644 --- a/target-openrisc/cpu.c +++ b/target-openrisc/cpu.c @@ -

[Qemu-devel] [PATCH v3 5/6] ppc: Don't duplicate QEMUMachineInitArgs in PPCE500Params

2013-07-22 Thread Markus Armbruster
Pass on the generic arguments unadulterated, and the machine-specific ones as separate argument. Signed-off-by: Markus Armbruster Acked-by: Alexander Graf --- hw/ppc/e500.c | 35 ++- hw/ppc/e500.h | 13 +++-- hw/ppc/e500plat.c | 8 +--- hw

[Qemu-devel] [PATCH 1/2] exec: Fix bounce buffer allocation in address_space_map()

2013-07-22 Thread Kevin Wolf
This fixes a regression introduced by commit e3127ae0c, which kept the allocation size of the bounce buffer limited to one page in order to avoid unbounded allocations (as explained in the commit message of 6d16c2f88), but broke the reporting of the shortened bounce buffer to the caller. The caller

[Qemu-devel] [PATCH 0/2] exec: Fix bounce buffer allocation in address_space_map()

2013-07-22 Thread Kevin Wolf
Kevin Wolf (2): exec: Fix bounce buffer allocation in address_space_map() ide-test: Check what happens with bus mastering disabled exec.c | 4 +++- tests/ide-test.c | 26 ++ 2 files changed, 29 insertions(+), 1 deletion(-) -- 1.8.1.4

[Qemu-devel] [PATCH 2/2] ide-test: Check what happens with bus mastering disabled

2013-07-22 Thread Kevin Wolf
The main goal is that qemu doesn't crash. Signed-off-by: Kevin Wolf --- tests/ide-test.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/ide-test.c b/tests/ide-test.c index 7307f1d..bc824a8 100644 --- a/tests/ide-test.c +++ b/tests/ide-test.c @@ -81,6 +81,7

[Qemu-devel] [PATCH 4/4] block: Add iops_sector_count to do the iops accounting for a given io size.

2013-07-22 Thread Benoît Canet
This feature can be used in case where users are avoiding the iops limit by doing jumbo I/Os hammering the storage backend. Signed-off-by: Benoit Canet --- block.c |8 +++- block/qapi.c |4 blockdev.c| 22 +- h

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Juan Quintela
Orit Wasserman wrote: > On 07/22/2013 01:33 PM, Andreas Färber wrote: >> Am 22.07.2013 11:49, schrieb Paolo Bonzini: >>> Il 22/07/2013 08:49, Orit Wasserman ha scritto: Older KVM versions save CS dpl value to an invalid value for real mode guests (0x3). This patch detect this situa

Re: [Qemu-devel] usb: a problem of using libusb for usb pass through

2013-07-22 Thread Gerd Hoffmann
On 07/16/13 10:45, Gonglei (Arei) wrote: > Hi, Gerd > My Qemu version is 1.5.1, and use libusb for usb pass through. > I pass through a host usb device to the guest by bus number and > physical port, when I unplug the usb device from > the host, and plug in on the same physical port i

[Qemu-devel] [PATCH v3 4/6] ppc: Don't explode QEMUMachineInitArgs into local variables needlessly

2013-07-22 Thread Markus Armbruster
Don't explode when the variable is used just once, and never changed. Signed-off-by: Markus Armbruster Acked-by: Alexander Graf --- hw/ppc/e500plat.c | 18 ++ hw/ppc/mpc8544ds.c | 18 ++ 2 files changed, 12 insertions(+), 24 deletions(-) diff --git a/hw/ppc/e50

Re: [Qemu-devel] [PATCH 1/2] exec: Fix bounce buffer allocation in address_space_map()

2013-07-22 Thread Paolo Bonzini
Il 22/07/2013 14:43, Kevin Wolf ha scritto: > -bounce.buffer = qemu_memalign(TARGET_PAGE_SIZE, TARGET_PAGE_SIZE); > +/* Avoid unbounded allocations */ > +l = TARGET_PAGE_SIZE; This should be l = MIN(l, TARGET_PAGE_SIZE). Otherwise the patch is okay. Paolo > +boun

Re: [Qemu-devel] [PATCH v3 1/4] hw/openrisc: Indent typo

2013-07-22 Thread Peter Maydell
On 22 July 2013 09:56, Jia Liu wrote: > Indent typo. > > Signed-off-by: Jia Liu Reviewed-by: Peter Maydell -- PMM

  1   2   3   4   >