Re: [Qemu-devel] [PULL] virtio-ccw: dataplane enablement

2013-07-16 Thread Stefan Hajnoczi
On Mon, Jul 15, 2013 at 07:15:55PM +0200, Paolo Bonzini wrote: > Il 15/07/2013 18:52, Anthony Liguori ha scritto: > > Cornelia Huck writes: > > > >> The following changes since commit > >> c3cb8e77804313e1be99b5f28a34a346736707a5: > >> > >> ioport: remove LITTLE_ENDIAN mark for portio (2013-07

Re: [Qemu-devel] [PATCHv3] block-migration: efficiently encode zero blocks

2013-07-16 Thread Peter Lieven
On 15.07.2013 23:27, Eric Blake wrote: On 07/15/2013 04:55 AM, Peter Lieven wrote: this patch adds an efficient encoding for zero blocks by adding a new flag indiciating a block is completly zero. s/indiciating/indicating/ s/completly/completely/ additionally bdrv_write_zeros() is used at the

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-16 Thread Jan Kiszka
On 2013-07-14 17:18, Anthony Liguori wrote: > On Sun, Jul 14, 2013 at 9:58 AM, Peter Maydell > wrote: >> On 14 July 2013 14:05, Anthony Liguori wrote: Also, what devices exactly would have a non-native byte order?!? I'm confused... >>> >>> MMIO/PIO requests don't have a byte order. I

Re: [Qemu-devel] [PATCH 16/17] block: add default get_block_status implementation for protocols

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 08:47, Peter Lieven ha scritto: >> >> @@ -2977,7 +2977,11 @@ static int64_t coroutine_fn >> bdrv_co_get_block_status(BlockDriverState *bs, >> if (!bs->drv->bdrv_co_get_block_status) { >> *pnum = nb_sectors; >> -return BDRV_BLOCK_DATA; >> +ret = BDRV_B

Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves

2013-07-16 Thread Alex Bligh
Paolo, --On 16 July 2013 08:16:42 +0200 Paolo Bonzini wrote: You did. But aio_wait() ignores the timeout. It is only used by the main loop. OK well that seems worth fixing in any case, as even without timed bh's that means no bh can be executed for an indeterminate time. I'll have a look a

Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 09:30, Alex Bligh ha scritto: > >> You did. But aio_wait() ignores the timeout. It is only used by the >> main loop. > > OK well that seems worth fixing in any case, as even without timed bh's > that means no bh can be executed for an indeterminate time. I'll have > a look at that

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-16 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 16/07/2013 09:18, Jan Kiszka ha scritto: > Sorry for sending out invitations and then being late to this party > - vacation. What is the status now? Do we have a short-term plan to > avoid the regression or is this better solved by cleaning up the >

Re: [Qemu-devel] [PATCH 16/17] block: add default get_block_status implementation for protocols

2013-07-16 Thread Peter Lieven
On 16.07.2013 09:19, Paolo Bonzini wrote: Il 16/07/2013 08:47, Peter Lieven ha scritto: @@ -2977,7 +2977,11 @@ static int64_t coroutine_fn bdrv_co_get_block_status(BlockDriverState *bs, if (!bs->drv->bdrv_co_get_block_status) { *pnum = nb_sectors; -return BDRV_BLOCK_D

Re: [Qemu-devel] [PATCH v5 05/14] vl: handle "-device dimm"

2013-07-16 Thread Hu Tao
On Tue, Jul 16, 2013 at 08:19:48AM +0200, Paolo Bonzini wrote: > Il 16/07/2013 03:27, Hu Tao ha scritto: > > > I think it's the same. One "-numa mem" option = one "-device dimm" > > > option; both define one range. Unused memory ranges may remain if you > > > stumble upon a unusable range such as

Re: [Qemu-devel] [RFC PATCH v1 1/2] gluster: Use pkg-config to configure GlusterFS block driver

2013-07-16 Thread Kevin Wolf
Am 12.07.2013 um 08:58 hat Bharata B Rao geschrieben: > gluster: Use pkg-config to configure GlusterFS block driver > > Use pkg-config to determine the version and library dependency > for GlusterFS block driver. > > Signed-off-by: Bharata B Rao > --- > configure | 20 +++- >

Re: [Qemu-devel] [RFC PATCH v1 2/2] gluster: Add discard support for GlusterFS block driver

2013-07-16 Thread Kevin Wolf
Am 12.07.2013 um 09:00 hat Bharata B Rao geschrieben: > gluster: Add discard support for GlusterFS block driver. > > Implement bdrv_aio_discard for gluster. > > Signed-off-by: Bharata B Rao Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-16 Thread Alexander Graf
Am 16.07.2013 um 08:20 schrieb Paolo Bonzini : > Il 16/07/2013 07:19, Alexey Kardashevskiy ha scritto: >> In the past, IO space could not be mapped into the memory address space >> so we introduced a workaround for that. Nowadays it does not look >> necessary so we can remove the workaround and

Re: [Qemu-devel] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-16 Thread Fabien Chouteau
On 07/16/2013 03:06 AM, Peter Crosthwaite wrote: + +memory_region_init_io(&etsec->io_area, OBJECT(etsec), &etsec_ops, etsec, + "eTSEC", 0x1000); >>> >>> Constant size memory_region_init_io should be migrated to the Object::Init >>> fm. >>> >> >> Wh

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-16 Thread Alexey Kardashevskiy
On 07/16/2013 06:32 PM, Alexander Graf wrote: > > > Am 16.07.2013 um 08:20 schrieb Paolo Bonzini : > >> Il 16/07/2013 07:19, Alexey Kardashevskiy ha scritto: >>> In the past, IO space could not be mapped into the memory address space >>> so we introduced a workaround for that. Nowadays it does n

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-16 Thread Alexander Graf
Am 16.07.2013 um 10:37 schrieb Alexey Kardashevskiy : > On 07/16/2013 06:32 PM, Alexander Graf wrote: >> >> >> Am 16.07.2013 um 08:20 schrieb Paolo Bonzini : >> >>> Il 16/07/2013 07:19, Alexey Kardashevskiy ha scritto: In the past, IO space could not be mapped into the memory address spa

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-16 Thread Benjamin Herrenschmidt
On Tue, 2013-07-16 at 10:32 +0200, Alexander Graf wrote: > >> Did I miss anything here? > > > > No, I don't think so. The patch looks good. > > ... and will break all Mac targets again, no? Not to speak of non-ppc > devices. Do you know why it breaks ? Can you suggest what's wrong and how to fi

[Qemu-devel] usb: a problem of using libusb for usb pass through

2013-07-16 Thread Gonglei (Arei)
Hi, Gerd My Qemu version is 1.5.1, and use libusb for usb pass through. I pass through a host usb device to the guest by bus number and physical port, when I unplug the usb device from the host, and plug in on the same physical port immediately, but the usb device don't show up i

Re: [Qemu-devel] [PULL] virtio-ccw: dataplane enablement

2013-07-16 Thread Cornelia Huck
On Tue, 16 Jul 2013 15:10:41 +0800 Stefan Hajnoczi wrote: > On Mon, Jul 15, 2013 at 07:15:55PM +0200, Paolo Bonzini wrote: > > Il 15/07/2013 18:52, Anthony Liguori ha scritto: > > > Cornelia Huck writes: > > > > > >> The following changes since commit > > >> c3cb8e77804313e1be99b5f28a34a346736

Re: [Qemu-devel] [RFC PATCH 09/11] Implement qdict_flatten()

2013-07-16 Thread Kevin Wolf
Am 11.07.2013 um 22:25 hat Eric Blake geschrieben: > On 07/09/2013 03:53 AM, Kevin Wolf wrote: > > Worth repeating this comment from the code into the commit message? > > > + * qdict_flatten(): For each nested QDict with key x, all fields with > key y > > + * are moved to this QDict and their key

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-16 Thread Alexander Graf
Am 16.07.2013 um 10:45 schrieb Benjamin Herrenschmidt : > On Tue, 2013-07-16 at 10:32 +0200, Alexander Graf wrote: Did I miss anything here? >>> >>> No, I don't think so. The patch looks good. >> >> ... and will break all Mac targets again, no? Not to speak of non-ppc >> devices. > > D

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-16 Thread Alexey Kardashevskiy
On 07/16/2013 07:01 PM, Alexander Graf wrote: > > > Am 16.07.2013 um 10:45 schrieb Benjamin Herrenschmidt > : > >> On Tue, 2013-07-16 at 10:32 +0200, Alexander Graf wrote: > Did I miss anything here? No, I don't think so. The patch looks good. >>> >>> ... and will break all Mac

Re: [Qemu-devel] [PULL] virtio-ccw: dataplane enablement

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 10:54, Cornelia Huck ha scritto: >> > Acked-by: Stefan Hajnoczi >> > > Thank you. > > Any further guidelines on when to ask for acks from you guys? The mode > I've been operating in is mostly "if virtio-pci provides this feature, > it shouldn't be half bad and we want it in virtio-

Re: [Qemu-devel] [PATCH 16/17] block: add default get_block_status implementation for protocols

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 09:54, Peter Lieven ha scritto: > On 16.07.2013 09:19, Paolo Bonzini wrote: >> Il 16/07/2013 08:47, Peter Lieven ha scritto: @@ -2977,7 +2977,11 @@ static int64_t coroutine_fn bdrv_co_get_block_status(BlockDriverState *bs, if (!bs->drv->bdrv_co_get_block_status

[Qemu-devel] [PATCH] ppc kvm: fix to compile

2013-07-16 Thread Alexey Kardashevskiy
Signed-off-by: Alexey Kardashevskiy --- target-ppc/kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c index 61f2737..606bdb9 100644 --- a/target-ppc/kvm.c +++ b/target-ppc/kvm.c @@ -1628,7 +1628,7 @@ void *kvmppc_create_spapr_tce(uint

Re: [Qemu-devel] [PATCH 00/11] pseries: migration and QOM support

2013-07-16 Thread Alexey Kardashevskiy
On 07/16/2013 01:11 AM, Anthony Liguori wrote: > This series is based on Alexey's series: > > spapr: migration, pci, msi, power8 > > Which in turn was based on work by David Gibson. > > I've removed the bits not related to migration and made the > following changes: > > 1) QOMify TCE tables

Re: [Qemu-devel] [PATCH v5 05/14] vl: handle "-device dimm"

2013-07-16 Thread Igor Mammedov
On Tue, 16 Jul 2013 08:19:48 +0200 Paolo Bonzini wrote: > Il 16/07/2013 03:27, Hu Tao ha scritto: > > > I think it's the same. One "-numa mem" option = one "-device dimm" > > > option; both define one range. Unused memory ranges may remain if you > > > stumble upon a unusable range such as the

Re: [Qemu-devel] [PATCH v5 05/14] vl: handle "-device dimm"

2013-07-16 Thread Igor Mammedov
On Tue, 16 Jul 2013 15:27:19 +0800 Hu Tao wrote: > On Tue, Jul 16, 2013 at 08:19:48AM +0200, Paolo Bonzini wrote: > > Il 16/07/2013 03:27, Hu Tao ha scritto: > > > > I think it's the same. One "-numa mem" option = one "-device dimm" > > > > option; both define one range. Unused memory ranges ma

Re: [Qemu-devel] [PATCH v5 05/14] vl: handle "-device dimm"

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 12:19, Igor Mammedov ha scritto: > On Tue, 16 Jul 2013 08:19:48 +0200 > Paolo Bonzini wrote: > >> Il 16/07/2013 03:27, Hu Tao ha scritto: I think it's the same. One "-numa mem" option = one "-device dimm" option; both define one range. Unused memory ranges may remain if

[Qemu-devel] [PATCH v2 0/2] QMP full introspection

2013-07-16 Thread Amos Kong
This is an implement of qmp full-introspection, parse and convert the json string to a dynamical tree, return it to management through QMP command output. Anthony has another suggestion: http://lists.nongnu.org/archive/html/qemu-devel/2013-07/msg01903.html The whole output of query-qmp-schema c

[Qemu-devel] [PATCH v2 2/2] full introspection support for QMP

2013-07-16 Thread Amos Kong
Introduces new monitor command to query QMP schema information, the return data is a dynamical and nested dict/list, it contains the useful metadata to help management to check feature support, QMP commands detail, etc. I added a document for QMP introspection support. (docs/qmp-full-introspection

[Qemu-devel] [PATCH v2 1/2] qapi: change qapi to convert schema json

2013-07-16 Thread Amos Kong
QMP schema is defined in a json file, it will be parsed by qapi scripts and generate C files. We want to return the schema information to management, this patch converts the json file to a string table in a C head file, then we can use the json content. eg: const char *const qmp_schema_table[]

Re: [Qemu-devel] [PATCH v2 2/2] full introspection support for QMP

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 12:37, Amos Kong ha scritto: > So here I defined a 'DataObject' type in qapi-schema.json, > it's used to describe the dynamical dictionary/list/string. > > { 'type': 'DataObject', > 'data': { '*key': 'str', '*type': 'str', '*data': ['DataObject'] } } This is missing '*optional': '

Re: [Qemu-devel] [PATCH MST/PCI] additional fixes for mac-programming feature

2013-07-16 Thread Amos Kong
On Mon, Jul 15, 2013 at 09:28:28PM +0300, Michael S. Tsirkin wrote: > On Thu, Jul 11, 2013 at 10:28:15PM +0800, Amos Kong wrote: > > Markus added some comments on old patchset, this patch contains > > some additional fixes, it's based on MST's PCI tree. > > > > * Fix typos (missed 1.6, NIC) > > *

Re: [Qemu-devel] [PATCH] full introspection support for QMP

2013-07-16 Thread Amos Kong
On Tue, Jul 02, 2013 at 10:20:39AM -0400, Luiz Capitulino wrote: > On Tue, 2 Jul 2013 16:37:29 +0800 > Amos Kong wrote: > > > > Btw, I find your approach interesting but I'm wondering if it's going to > > > be a good thing to keep all the schema in memory. Do you have an idea > > > on its size? >

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-16 Thread Paolo Bonzini
Il 15/07/2013 12:49, Peter Lieven ha scritto: > this adds the proposed solution to add a generic mechanism to zeroize > a target in qemu-img if it has discard_zeroes but has_zero_init is 0. > > Peter Lieven (4): > block: add discard_zeroes and max_unmap to BlockDriverInfo > iscsi: add .bdrv_ge

Re: [Qemu-devel] [PATCH v2 2/2] full introspection support for QMP

2013-07-16 Thread Amos Kong
On Tue, Jul 16, 2013 at 12:48:36PM +0200, Paolo Bonzini wrote: > Il 16/07/2013 12:37, Amos Kong ha scritto: > > So here I defined a 'DataObject' type in qapi-schema.json, > > it's used to describe the dynamical dictionary/list/string. > > > > { 'type': 'DataObject', > > 'data': { '*key': 'str',

Re: [Qemu-devel] [PATCH v2 2/2] full introspection support for QMP

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 13:04, Amos Kong ha scritto: >>> > > So here I defined a 'DataObject' type in qapi-schema.json, >>> > > it's used to describe the dynamical dictionary/list/string. >>> > > >>> > > { 'type': 'DataObject', >>> > > 'data': { '*key': 'str', '*type': 'str', '*data': ['DataObject'] } } >

Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE

2013-07-16 Thread Michael Tokarev
10.07.2013 02:03, Anthony Liguori wrote: > Peter Maydell writes: > >> On 9 July 2013 22:24, Anthony Liguori wrote: >>> Peter Maydell writes: Why the heck are we telling the guest that the user specified -nographic anyhow? It's a dumb guest ABI... >>> >>> I believe OpenBIOS uses this t

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-16 Thread Peter Lieven
On 16.07.2013 12:55, Paolo Bonzini wrote: Il 15/07/2013 12:49, Peter Lieven ha scritto: this adds the proposed solution to add a generic mechanism to zeroize a target in qemu-img if it has discard_zeroes but has_zero_init is 0. Peter Lieven (4): block: add discard_zeroes and max_unmap to Blo

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 13:18, Peter Lieven ha scritto: >> Looks good. Perhaps, as a followup, you can use max_unmap (which I'd >> rename to max_discard) in bdrv_co_discard to support splitting the >> request. You could also export the discard alignment in BlockDriverInfo. > I already did this in my previo

Re: [Qemu-devel] [RFC PATCH v1 1/2] gluster: Use pkg-config to configure GlusterFS block driver

2013-07-16 Thread Bharata B Rao
On Tue, Jul 16, 2013 at 10:25:29AM +0200, Kevin Wolf wrote: > > - glusterfs_libs="-lgfapi -lgfrpc -lgfxdr" > > - if compile_prog "" "$glusterfs_libs" ; then > > -glusterfs=yes > > -libs_tools="$glusterfs_libs $libs_tools" > > -libs_softmmu="$glusterfs_libs $libs_softmmu" > > + if $pk

[Qemu-devel] Alternative mac address setting

2013-07-16 Thread Benoît Canet
Hello, I want to implement an alternative mac address setting to allow a guest using virtio-net to change it's mac address by itself. The main use case is high availability setups where a slave machine take the lead when the master is failing. (heartbeat) The thing that an alternate mac address

Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE

2013-07-16 Thread Peter Maydell
On 10 July 2013 06:08, Michael Tokarev wrote: > I updated the git branch on my site -- > > http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/mjt-dt-nographic > > (two patches on the top). This now includes the `make check' fix by > flipping the check (FW_CFG_NOGRAPHIC==1 vs ==0), more doc

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-16 Thread Peter Lieven
On 16.07.2013 13:27, Paolo Bonzini wrote: Il 16/07/2013 13:18, Peter Lieven ha scritto: Looks good. Perhaps, as a followup, you can use max_unmap (which I'd rename to max_discard) in bdrv_co_discard to support splitting the request. You could also export the discard alignment in BlockDriverInf

Re: [Qemu-devel] [ [PATCH]] nVMX: Initialize IA32_FEATURE_CONTROL MSR in reset and migration

2013-07-16 Thread Gleb Natapov
On Sun, Jul 07, 2013 at 11:13:37PM +0800, Arthur Chunqi Li wrote: > The recent KVM patch adds IA32_FEATURE_CONTROL support. QEMU needs > to clear this MSR when reset vCPU and keep the value of it when > migration. This patch add this feature. > So what happens if we migrate from qemu that does not

[Qemu-devel] [PATCH] qmp: update send-key document

2013-07-16 Thread Amos Kong
commit 9f328977 changes qmp_send_key() to accept key codes in hex, but the document wasn't updated. The items of keys list is union now, not enum. Signed-off-by: Amos Kong --- qmp-commands.hx | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/qmp-commands.hx b/qmp-command

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 13:40, Peter Lieven ha scritto: > > The conflict with your block status patches can't be large. > upstream/master has no > iscsi_co_is_allocated yet, so there should be no trouble. Yes, whoever goes second has to change it to the new get_block_status API. Kevin and Stefan can decid

Re: [Qemu-devel] [ [PATCH]] nVMX: Initialize IA32_FEATURE_CONTROL MSR in reset and migration

2013-07-16 Thread Arthur Chunqi Li
On Tue, Jul 16, 2013 at 7:42 PM, Gleb Natapov wrote: > On Sun, Jul 07, 2013 at 11:13:37PM +0800, Arthur Chunqi Li wrote: >> The recent KVM patch adds IA32_FEATURE_CONTROL support. QEMU needs >> to clear this MSR when reset vCPU and keep the value of it when >> migration. This patch add this featur

Re: [Qemu-devel] [ [PATCH]] nVMX: Initialize IA32_FEATURE_CONTROL MSR in reset and migration

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 13:42, Gleb Natapov ha scritto: > On Sun, Jul 07, 2013 at 11:13:37PM +0800, Arthur Chunqi Li wrote: >> The recent KVM patch adds IA32_FEATURE_CONTROL support. QEMU needs >> to clear this MSR when reset vCPU and keep the value of it when >> migration. This patch add this feature. >> >

Re: [Qemu-devel] [ [PATCH]] nVMX: Initialize IA32_FEATURE_CONTROL MSR in reset and migration

2013-07-16 Thread Gleb Natapov
On Tue, Jul 16, 2013 at 07:56:25PM +0800, Arthur Chunqi Li wrote: > On Tue, Jul 16, 2013 at 7:42 PM, Gleb Natapov wrote: > > On Sun, Jul 07, 2013 at 11:13:37PM +0800, Arthur Chunqi Li wrote: > >> The recent KVM patch adds IA32_FEATURE_CONTROL support. QEMU needs > >> to clear this MSR when reset v

Re: [Qemu-devel] [PATCH v2 2/2] full introspection support for QMP

2013-07-16 Thread Amos Kong
On Tue, Jul 16, 2013 at 01:08:55PM +0200, Paolo Bonzini wrote: > Il 16/07/2013 13:04, Amos Kong ha scritto: > >>> > > So here I defined a 'DataObject' type in qapi-schema.json, > >>> > > it's used to describe the dynamical dictionary/list/string. > >>> > > > >>> > > { 'type': 'DataObject', > >>> >

Re: [Qemu-devel] [PATCH v5 05/14] vl: handle "-device dimm"

2013-07-16 Thread Igor Mammedov
On Tue, 16 Jul 2013 12:31:46 +0200 Paolo Bonzini wrote: > Il 16/07/2013 12:19, Igor Mammedov ha scritto: > > On Tue, 16 Jul 2013 08:19:48 +0200 > > Paolo Bonzini wrote: > > > >> Il 16/07/2013 03:27, Hu Tao ha scritto: > I think it's the same. One "-numa mem" option = one "-device dimm" >

Re: [Qemu-devel] [PATCH v5 05/14] vl: handle "-device dimm"

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 14:00, Igor Mammedov ha scritto: >>> we can leave -numa for initial memory mapping and manage of the mapping >>> of hotpluggable regions with -device dimm,node=X,size=Y. >>> >>> It that case command line -device dimm will provide a fully initialized >>> dimm device usable at startup (

Re: [Qemu-devel] [PATCH v2 2/2] full introspection support for QMP

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 14:04, Amos Kong ha scritto: >> > Thanks. I see this is unique, but it is also not too intuitive. >> > >> > So, could you add a "kind" field to DataObject that is an enum >> > (list/dict/scalar, or something like that)? This would make it easier >> > to parse (for humans at least,

Re: [Qemu-devel] [PATCH RFC 0/3] Recursive QOM realize

2013-07-16 Thread Andreas Färber
Am 15.07.2013 17:37, schrieb Paolo Bonzini: > Il 15/07/2013 17:06, Andreas Färber ha scritto: >> Am 15.07.2013 16:43, schrieb Paolo Bonzini: >>> Il 15/07/2013 15:40, Andreas Färber ha scritto: Originally Paolo and me had implemented QOM realize at Object level. Paolo's goal was to set rea

[Qemu-devel] [PATCH v3 1/8] device_tree: Add qemu_devtree_setprop_sized_cells() utility functions

2013-07-16 Thread Peter Maydell
We already have a qemu_devtree_setprop_cells() which sets a dtb property to an array of cells whose values are specified by varargs. However for the fairly common case of setting a property to a list of addresses or of address,size pairs the number of cells used by each element in the list depends

Re: [Qemu-devel] [PATCH 06/22] memory: dispatch unassigned accesses based on .valid.accepts

2013-07-16 Thread Jan Kiszka
On 2013-05-30 23:03, Paolo Bonzini wrote: > This provides the basics for detecting accesses to unassigned memory > as soon as they happen, and also for a simple implementation of > address_space_access_valid. > > Reviewed-by: Richard Henderson > Signed-off-by: Paolo Bonzini > --- > exec.c |

Re: [Qemu-devel] [PATCH] ahci: Fix FLUSH command

2013-07-16 Thread Andreas Färber
Am 15.07.2013 11:34, schrieb Kevin Wolf: > AHCI couldn't cope with asynchronous commands that aren't doing DMA, it > simply wouldn't complete them. Due to the bug fixed in commit f68ec837, > FLUSH commands would seem to have completed immediately even if they > were still running on the host. After

Re: [Qemu-devel] [PATCH] ppc kvm: fix to compile

2013-07-16 Thread Anthony Liguori
Alexey Kardashevskiy writes: > Signed-off-by: Alexey Kardashevskiy > --- > target-ppc/kvm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c > index 61f2737..606bdb9 100644 > --- a/target-ppc/kvm.c > +++ b/target-ppc/kvm.c > @@ -16

Re: [Qemu-devel] [PATCH 00/11] pseries: migration and QOM support

2013-07-16 Thread Anthony Liguori
Alexey Kardashevskiy writes: > On 07/16/2013 01:11 AM, Anthony Liguori wrote: >> This series is based on Alexey's series: >> >> spapr: migration, pci, msi, power8 >> >> Which in turn was based on work by David Gibson. >> >> I've removed the bits not related to migration and made the >> follo

Re: [Qemu-devel] [PATCH 06/22] memory: dispatch unassigned accesses based on .valid.accepts

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 14:28, Jan Kiszka ha scritto: > On 2013-05-30 23:03, Paolo Bonzini wrote: >> This provides the basics for detecting accesses to unassigned memory >> as soon as they happen, and also for a simple implementation of >> address_space_access_valid. >> >> Reviewed-by: Richard Henderson >>

Re: [Qemu-devel] [PULL] virtio-ccw: dataplane enablement

2013-07-16 Thread Anthony Liguori
Cornelia Huck writes: > On Tue, 16 Jul 2013 15:10:41 +0800 > Stefan Hajnoczi wrote: > >> > Considering what the patch looks like, I don't think it's a huge >> > problem... In fact, perhaps x-data-plane could be even added to >> > DEFINE_VIRTIO_BLK_PROPERTIES. This would make it clear that supp

Re: [Qemu-devel] [PATCH 00/11] pseries: migration and QOM support

2013-07-16 Thread Alexey Kardashevskiy
On 07/16/2013 10:33 PM, Anthony Liguori wrote: > Alexey Kardashevskiy writes: > >> On 07/16/2013 01:11 AM, Anthony Liguori wrote: >>> This series is based on Alexey's series: >>> >>> spapr: migration, pci, msi, power8 >>> >>> Which in turn was based on work by David Gibson. >>> >>> I've removed

Re: [Qemu-devel] [PATCH] ahci: Fix FLUSH command

2013-07-16 Thread Michael S. Tsirkin
On Mon, Jul 15, 2013 at 11:34:31AM +0200, Kevin Wolf wrote: > AHCI couldn't cope with asynchronous commands that aren't doing DMA, it > simply wouldn't complete them. Due to the bug fixed in commit f68ec837, > FLUSH commands would seem to have completed immediately even if they > were still running

Re: [Qemu-devel] [PATCH 06/22] memory: dispatch unassigned accesses based on .valid.accepts

2013-07-16 Thread Peter Maydell
On 16 July 2013 13:33, Paolo Bonzini wrote: > Il 16/07/2013 14:28, Jan Kiszka ha scritto: >> This changed the value read from unassigned memory from -1 to 0. Any >> particular reason or an unintentional change? > > Cut-and-paste (unassigned RAM used to return 0, invalid MMIO used to > return -1, u

[Qemu-devel] [PATCH] memory: Return -1 again on reads from unsigned regions

2013-07-16 Thread Jan Kiszka
This restore the behavior prior to b018ddf633 which accidentally changed the return code to 0. Specifically guests probing for register existence were affected by this. Signed-off-by: Jan Kiszka --- memory.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/memory.c b/mem

Re: [Qemu-devel] [PATCH] ahci: Fix FLUSH command

2013-07-16 Thread Kevin Wolf
Am 16.07.2013 um 14:30 hat Andreas Färber geschrieben: > Am 15.07.2013 11:34, schrieb Kevin Wolf: > > AHCI couldn't cope with asynchronous commands that aren't doing DMA, it > > simply wouldn't complete them. Due to the bug fixed in commit f68ec837, > > FLUSH commands would seem to have completed i

Re: [Qemu-devel] [PATCH] memory: Return -1 again on reads from unsigned regions

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 14:45, Jan Kiszka ha scritto: > This restore the behavior prior to b018ddf633 which accidentally changed > the return code to 0. Specifically guests probing for register existence > were affected by this. > > Signed-off-by: Jan Kiszka > --- > memory.c |2 +- > 1 files changed,

Re: [Qemu-devel] [PATCH 00/11] pseries: migration and QOM support

2013-07-16 Thread Alexey Kardashevskiy
On 07/16/2013 10:35 PM, Alexey Kardashevskiy wrote: > On 07/16/2013 10:33 PM, Anthony Liguori wrote: >> Alexey Kardashevskiy writes: >> >>> On 07/16/2013 01:11 AM, Anthony Liguori wrote: This series is based on Alexey's series: spapr: migration, pci, msi, power8 Which in

Re: [Qemu-devel] Alternative mac address setting

2013-07-16 Thread Benoît Canet
Sorry for the gibberish I misread the code. Please ignore this mail. Best regards Benoît >Le Tuesday 16 Jul 2013 à 13:36:49 (+0200), Benoît Canet a écrit : > > Hello, > > I want to implement an alternative mac address setting to allow a guest using > virtio-net to change it's mac address by i

Re: [Qemu-devel] [PATCH 06/22] memory: dispatch unassigned accesses based on .valid.accepts

2013-07-16 Thread Jan Kiszka
On 2013-07-16 14:38, Peter Maydell wrote: > On 16 July 2013 13:33, Paolo Bonzini wrote: >> Il 16/07/2013 14:28, Jan Kiszka ha scritto: >>> This changed the value read from unassigned memory from -1 to 0. Any >>> particular reason or an unintentional change? >> >> Cut-and-paste (unassigned RAM used

[Qemu-devel] [PATCH v3 8/8] vexpress: Add virtio-mmio transports

2013-07-16 Thread Peter Maydell
Add some virtio-mmio transports to the vexpress board model, together with a modify_dtb hook which adds them to the device tree so that the kernel will probe for them. We put them in a reserved area of the address map. Signed-off-by: Peter Maydell --- hw/arm/vexpress.c | 99 +++

[Qemu-devel] [PATCH v3 2/8] arm/boot: Use qemu_devtree_setprop_sized_cells()

2013-07-16 Thread Peter Maydell
Replace the opencoded assembly of the reg property array for the /memory node with a call to qemu_devtree_setprop_sized_cells(). Signed-off-by: Peter Maydell --- hw/arm/boot.c | 29 - 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/hw/arm/boot.c b/hw/

[Qemu-devel] [PATCH v3 7/8] vexpress: Make VEDBoardInfo extend arm_boot_info

2013-07-16 Thread Peter Maydell
Make the VEDBoardInfo struct extend arm_boot_info; this will allow us to get at the VEDBoardInfo information inside callbacks from arm/boot code. Signed-off-by: Peter Maydell --- hw/arm/vexpress.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --g

[Qemu-devel] [PATCH v3 3/8] virtio: Add support for guest setting of queue size

2013-07-16 Thread Peter Maydell
The MMIO virtio transport spec allows the guest to tell the host how large the queue size is. Add virtio_queue_set_num() function which implements this in the QEMU common virtio support code. Signed-off-by: Peter Maydell --- hw/virtio/virtio.c |8 include/hw/virtio/virtio.h

[Qemu-devel] [PATCH v3 4/8] virtio: Support transports which can specify the vring alignment

2013-07-16 Thread Peter Maydell
Support virtio transports which can specify the vring alignment (ie where the guest communicates this to the host) by providing a new virtio_queue_set_align() function. (The default alignment remains as before.) Transports which wish to make use of this must set the has_variable_vring_alignment fi

[Qemu-devel] [PATCH v3 0/8] Add virtio-mmio and use it in vexpress

2013-07-16 Thread Peter Maydell
This patch series adds an implementation of the virtio-mmio transport, and uses it in the vexpress-a9 and vexpress-a15 board models. The basic idea is that the board instantiates some transports, the user can create backends which automatically plug into them (via -device virtio-blk-backend and th

[Qemu-devel] [PATCH v3 6/8] arm/boot: Allow boards to modify the FDT blob

2013-07-16 Thread Peter Maydell
Add a callback hook in arm_boot_info to allow board models to modify the device tree blob if they need to. (The major expected use case is to add virtio-mmio nodes for virtio-mmio transports that exist in QEMU but not in the hardware.) Signed-off-by: Peter Maydell --- hw/arm/boot.c|5

[Qemu-devel] [PATCH v3 5/8] virtio: Implement MMIO based virtio transport

2013-07-16 Thread Peter Maydell
Add support for the generic MMIO based virtio transport. This patch includes some fixes for bugs spotted by Ying-Shiuan Pan . Signed-off-by: Peter Maydell [Fred changes: updated to new virtio-bus mechanisms] Signed-off-by: KONRAD Frederic [PMM changes: * fixed trivial makefile conflict * remo

Re: [Qemu-devel] [PATCH 00/11] pseries: migration and QOM support

2013-07-16 Thread Alexey Kardashevskiy
On 07/16/2013 10:48 PM, Alexey Kardashevskiy wrote: > On 07/16/2013 10:35 PM, Alexey Kardashevskiy wrote: >> On 07/16/2013 10:33 PM, Anthony Liguori wrote: >>> Alexey Kardashevskiy writes: >>> On 07/16/2013 01:11 AM, Anthony Liguori wrote: > This series is based on Alexey's series: >

Re: [Qemu-devel] [PATCH v3 1/8] device_tree: Add qemu_devtree_setprop_sized_cells() utility functions

2013-07-16 Thread Peter Crosthwaite
Hi Peter, On Tue, Jul 16, 2013 at 10:25 PM, Peter Maydell wrote: > We already have a qemu_devtree_setprop_cells() which sets a dtb > property to an array of cells whose values are specified by varargs. > However for the fairly common case of setting a property to a list > of addresses or of addre

Re: [Qemu-devel] [PATCH] qmp: update send-key document

2013-07-16 Thread Eric Blake
On 07/16/2013 05:52 AM, Amos Kong wrote: > commit 9f328977 changes qmp_send_key() to accept key codes in hex, > but the document wasn't updated. The items of keys list is union > now, not enum. > > Signed-off-by: Amos Kong > --- > qmp-commands.hx | 7 +-- > 1 file changed, 5 insertions(+), 2

Re: [Qemu-devel] ARRAYS :QMP Declaration

2013-07-16 Thread Luiz Capitulino
On Tue, 16 Jul 2013 09:27:27 +0800 Saptarshi Sen wrote: > Hi, > >Is it possible to use fixed array data structures for use through the > qmp-interface. > >My aim is to monitor IDE level activity in terms of sectors being > accessed. So >I plan to have a fixed size buffer. But I find

Re: [Qemu-devel] [PATCH v2 22/26] kvmclock: QOM'ify some more

2013-07-16 Thread Andreas Färber
Am 01.07.2013 12:18, schrieb Hu Tao: > Introduce type constant and avoid FROM_SYSBUS(). > > Signed-off-by: Hu Tao > --- > hw/i386/kvm/clock.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Thanks, by now I've picked up all remaining QOM cast patches (and renamed and marked up

Re: [Qemu-devel] ARRAYS :QMP Declaration

2013-07-16 Thread Michael Roth
Quoting Saptarshi Sen (2013-07-15 20:27:27) > Hi, > > Is it possible to use fixed array data structures for use through the >qmp-interface. > > My aim is to monitor IDE level activity in terms of sectors being >accessed. So > I plan to have a fixed size buffer. But I

Re: [Qemu-devel] [PATCH 00/11] pseries: migration and QOM support

2013-07-16 Thread Anthony Liguori
Alexey Kardashevskiy writes: > On 07/16/2013 10:48 PM, Alexey Kardashevskiy wrote: >> On 07/16/2013 10:35 PM, Alexey Kardashevskiy wrote: >>> On 07/16/2013 10:33 PM, Anthony Liguori wrote: Alexey Kardashevskiy writes: > On 07/16/2013 01:11 AM, Anthony Liguori wrote: >> This ser

Re: [Qemu-devel] [PATCH 3/4] target-openrisc: Free typename

2013-07-16 Thread Andreas Färber
Am 16.07.2013 04:00, schrieb Jia Liu: > We should free typename here. > > Signed-off-by: Jia Liu > --- > target-openrisc/cpu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c > index 6d40f1b..e348df0 100644 > --- a/target-openrisc/cpu.c > +

Re: [Qemu-devel] [PATCH v3 2/8] arm/boot: Use qemu_devtree_setprop_sized_cells()

2013-07-16 Thread Peter Crosthwaite
Hi Peter, On Tue, Jul 16, 2013 at 10:25 PM, Peter Maydell wrote: > Replace the opencoded assembly of the reg property array for the > /memory node with a call to qemu_devtree_setprop_sized_cells(). > > Signed-off-by: Peter Maydell > --- > hw/arm/boot.c | 29 - > 1

Re: [Qemu-devel] [PATCH v3 2/8] arm/boot: Use qemu_devtree_setprop_sized_cells()

2013-07-16 Thread Peter Maydell
On 16 July 2013 15:31, Peter Crosthwaite wrote: > Hi Peter, > > On Tue, Jul 16, 2013 at 10:25 PM, Peter Maydell > wrote: >> Replace the opencoded assembly of the reg property array for the >> /memory node with a call to qemu_devtree_setprop_sized_cells(). >> >> Signed-off-by: Peter Maydell >> --

[Qemu-devel] [PATCH] Bug Fix:Segmentation fault when use usb-ehci device

2013-07-16 Thread Mike Qiu
For usb-ehci in qemu, its caps just has read() operation, the write() operation does not exist. This cause a Segmentation fault when use usb-ehci device in ppc64 platform. here is gdb output: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x3fffa7fcef20 (LWP 6793)] 0x0

Re: [Qemu-devel] [PATCH 02/12] trace+libvirt: start trace processing thread in final child process

2013-07-16 Thread Michael Mueller
On Tue, 16 Jul 2013 11:05:11 +0800 Stefan Hajnoczi wrote: > On Mon, Jul 15, 2013 at 09:41:19PM +0200, Christian Borntraeger wrote: > > When running with trace backend e.g. "simple" the writer thread > > needs to be implemented in the same process context as the trace > > points that will be proce

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-16 Thread Fabien Chouteau
On 07/16/2013 04:06 AM, Scott Wood wrote: > On 07/10/2013 12:10:02 PM, Fabien Chouteau wrote: >> This implementation doesn't include ring priority, TCP/IP Off-Load, QoS. >> >> Signed-off-by: Fabien Chouteau > > From the code comments I gather this has been tested on VxWorks. Has it > been tested

Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves

2013-07-16 Thread Alex Bligh
Paolo, --On 16 July 2013 09:34:20 +0200 Paolo Bonzini wrote: You did. But aio_wait() ignores the timeout. It is only used by the main loop. OK well that seems worth fixing in any case, as even without timed bh's that means no bh can be executed for an indeterminate time. I'll have a look a

[Qemu-devel] [PATCH 1/3] exec.c: Pass correct pointer type to qemu_ram_ptr_length

2013-07-16 Thread Paolo Bonzini
From: Peter Maydell Commit e3127ae0 introduced a problem where we're passing a hwaddr* to qemu_ram_ptr_length() but it wants a ram_addr_t*; this will cause problems on 32 bit hosts and in any case provokes a clang warning on MacOSX: CCarm-softmmu/exec.o exec.c:2164:46: warning: incompatibl

[Qemu-devel] [PATCH for-1.6 0/3] Memory API fixes

2013-07-16 Thread Paolo Bonzini
Three fixes from Peter, Jan and me. I'm still recovering from the email backlog, hence I don't trust myself sending a pull request... In any case, they are available also from git://github.com/bonzini/qemu.git iommu-from-anthony Paolo Jan Kiszka (1): memory: Return -1 again on reads from u

[Qemu-devel] [PATCH 2/3] memory: actually set the owner

2013-07-16 Thread Paolo Bonzini
Brown paper bag for me. Commit 2c9b15c added a line setting mr->owner, but there was already one that initialized it to NULL (added in the earlier commit 803c0816). Signed-off-by: Paolo Bonzini --- memory.c | 1 - 1 file changed, 1 deletion(-) diff --git a/memory.c b/memory.c index c8f9a2b..99

[Qemu-devel] [PATCH 3/3] memory: Return -1 again on reads from unsigned regions

2013-07-16 Thread Paolo Bonzini
From: Jan Kiszka This restore the behavior prior to b018ddf633 which accidentally changed the return code to 0. Specifically guests probing for register existence were affected by this. Signed-off-by: Jan Kiszka Signed-off-by: Paolo Bonzini --- memory.c | 2 +- 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-16 Thread Alexander Graf
On 07/16/2013 05:28 PM, Fabien Chouteau wrote: On 07/16/2013 04:06 AM, Scott Wood wrote: On 07/10/2013 12:10:02 PM, Fabien Chouteau wrote: This implementation doesn't include ring priority, TCP/IP Off-Load, QoS. Signed-off-by: Fabien Chouteau From the code comments I gather this has been tes

Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 17:29, Alex Bligh ha scritto: > Paolo, > > --On 16 July 2013 09:34:20 +0200 Paolo Bonzini wrote: > You did. But aio_wait() ignores the timeout. It is only used by the main loop. >>> >>> OK well that seems worth fixing in any case, as even without timed bh's >>> that mea

Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves

2013-07-16 Thread Alex Bligh
Paolo, 3. aio_poll calls aio_bh_poll. If this returns true, this indicates at least one non-idle bh exists, which causes aio_poll not to block. No, this indicates that at least one scheduled non-idle bh exist*ed*, which causes aio_poll not to block (because some progress has been done).

  1   2   3   >