Re: [Qemu-devel] [PATCH] block: Don't parse protocol from file.filename

2013-07-11 Thread Kevin Wolf
Am 10.07.2013 um 19:09 hat Eric Blake geschrieben: > On 07/10/2013 07:51 AM, Kevin Wolf wrote: > > One of the major reasons for doing something new for -blockdev and > > blockdev-add was that the old block layer code parses filenames instead > > of just taking them literally. So we should really le

Re: [Qemu-devel] [PATCH v4] KVM: nVMX: Fix read/write to MSR_IA32_FEATURE_CONTROL

2013-07-11 Thread Gleb Natapov
On Mon, Jul 08, 2013 at 07:12:35PM +0800, Arthur Chunqi Li wrote: > From: Nadav Har'El > > Fix read/write to IA32_FEATURE_CONTROL MSR in nested environment. > > This patch simulate this MSR in nested_vmx and the default value is > 0x0. BIOS should set it to 0x5 before VMXON. After setting the lo

[Qemu-devel] [RFC] s/qemu_devtree/qemu_fdt

2013-07-11 Thread Peter Crosthwaite
Hi All, Any objections to a tree wide: s/qemu_devtree/qemu_fdt FWIU, the qemu_ prefix is supposed to indicate a wrapping of an API, in this case that API clearly being "fdt_" not "devtree_". It buys back a previous 4 chars, in line length, with line length being an obstacle to adding "_nofail" v

Re: [Qemu-devel] [PATCH qom-next v2 1/5] target-arm/cpu.c: delete un-needed instance/class sizes

2013-07-11 Thread Andreas Färber
Am 11.07.2013 03:45, schrieb peter.crosthwa...@xilinx.com: > From: Peter Crosthwaite > > QOM automatically inherits class and instance size from the parent > class. No need to redefine as the same value as the parent. Quoting my original comment: "It would be fair to mention since which commit b

Re: [Qemu-devel] [PATCH qom-next v2 1/5] target-arm/cpu.c: delete un-needed instance/class sizes

2013-07-11 Thread Peter Maydell
On 11 July 2013 09:07, Andreas Färber wrote: > PMM, do you want to pick this one up for target-arm.next? The rest > depends on central infrastructure under discussion. Suggest renaming to > "target-arm: Delete un-needed instance/class sizes for ARMCPU > subclasses" for simplicity and so that it al

Re: [Qemu-devel] [PATCH v5 10/14] pc: Add dimm paravirt SRAT info

2013-07-11 Thread Michael S. Tsirkin
On Thu, Jul 11, 2013 at 07:13:39AM +0200, Igor Mammedov wrote: > On Wed, 10 Jul 2013 13:10:03 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jun 26, 2013 at 05:13:33PM +0800, Hu Tao wrote: > > > The numa_fw_cfg paravirt interface is extended to include SRAT > > > information for > > > all hot

[Qemu-devel] vm performance degradation after kvm live migration or save-restore with ETP enabled

2013-07-11 Thread Zhanghaoyu (A)
hi all, I met similar problem to these, while performing live migration or save-restore test on the kvm platform (qemu:1.4.0, host:suse11sp2, guest:suse11sp2), running tele-communication software suite in guest, https://lists.gnu.org/archive/html/qemu-devel/2013-05/msg00098.html http://comments.

Re: [Qemu-devel] [PATCH qom-next v2 3/5] target-arm: Use parent classes for reset + realize

2013-07-11 Thread Igor Mammedov
On Thu, 11 Jul 2013 11:47:16 +1000 peter.crosthwa...@xilinx.com wrote: > From: Peter Crosthwaite > > ARMCPUClass is only needed for parent-class abstract function access. > Just use parent classes for reset and realize access and remove > ARMCPUClass completely. > > Signed-off-by: Peter Crosthw

Re: [Qemu-devel] [RFC] s/qemu_devtree/qemu_fdt

2013-07-11 Thread Alexander Graf
On 11.07.2013, at 09:56, Peter Crosthwaite wrote: > Hi All, > > Any objections to a tree wide: > > s/qemu_devtree/qemu_fdt > > FWIU, the qemu_ prefix is supposed to indicate a wrapping of an API, > in this case that API clearly being "fdt_" not "devtree_". It buys > back a previous 4 chars, in

Re: [Qemu-devel] [PULL 09/43] cpu: Make first_cpu and next_cpu CPUState

2013-07-11 Thread Andreas Färber
Am 11.07.2013 11:14, schrieb TeLeMan: > On Wed, Jul 10, 2013 at 10:33 PM, Andreas Färber wrote: >> diff --git a/gdbstub.c b/gdbstub.c >> index f7d9f13..0ee82a9 100644 >> --- a/gdbstub.c >> +++ b/gdbstub.c [...] >> @@ -2394,7 +2401,7 @@ static int gdb_handle_packet(GDBState *s, const char >> *line

Re: [Qemu-devel] [RFC] s/qemu_devtree/qemu_fdt

2013-07-11 Thread Peter Maydell
On 11 July 2013 08:56, Peter Crosthwaite wrote: > Hi All, > > Any objections to a tree wide: > > s/qemu_devtree/qemu_fdt No objection from me... > FWIU, the qemu_ prefix is supposed to indicate a wrapping of an API, > in this case that API clearly being "fdt_" not "devtree_". It buys > back a pr

Re: [Qemu-devel] [Qeustion] USB passthough doesn't work on Windows.

2013-07-11 Thread Hans de Goede
Hi, On 07/10/2013 03:37 PM, Geunhae Lee wrote: thank you for kind reply i personally tried to test QEMU on Windows with libusb feature (--enable-libusb) but, figured out qemu/hw/usb/host-libusb.c is linux-dependent . - because. it includes which is not compatible. Ah yes, that is true libu

Re: [Qemu-devel] vm performance degradation after kvm live migration or save-restore with ETP enabled

2013-07-11 Thread Michael S. Tsirkin
On Thu, Jul 11, 2013 at 09:36:47AM +, Zhanghaoyu (A) wrote: > hi all, > > I met similar problem to these, while performing live migration or > save-restore test on the kvm platform (qemu:1.4.0, host:suse11sp2, > guest:suse11sp2), running tele-communication software suite in guest, > https://

Re: [Qemu-devel] [PATCH qom-next v2 3/5] target-arm: Use parent classes for reset + realize

2013-07-11 Thread Michael S. Tsirkin
On Thu, Jul 11, 2013 at 11:47:59AM +0200, Igor Mammedov wrote: > On Thu, 11 Jul 2013 11:47:16 +1000 > peter.crosthwa...@xilinx.com wrote: > > > From: Peter Crosthwaite > > > > ARMCPUClass is only needed for parent-class abstract function access. > > Just use parent classes for reset and realize

Re: [Qemu-devel] [PATCH V4 00/10] Add support for binding guest numa nodes to host numa nodes

2013-07-11 Thread Peter Huang(Peng)
Hi,Wanlong >From the patch discription below, seems that qemu numa only support >cpu/memory node binding. As we know, binding is not the common usage due to VM migration may happen or the load balance would be disabled. So, do we have any plan of generating virtual numa automatically? For exam

[Qemu-devel] [PATCH v2] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-11 Thread Fabio Fantoni
Usage: usbversion=1|2|3 (default=2) Specifies the type of an emulated USB bus in the guest. 1 for usb1, 2 for usb2 and 3 for usb3, it is available only with upstream qemu. Default is 2. Signed-off-by: Fabio Fantoni --- docs/man/xl.cfg.pod.5 |6 ++ tools/libxl/libxl_create.c |3

Re: [Qemu-devel] [PATCH qom-next v2 3/5] target-arm: Use parent classes for reset + realize

2013-07-11 Thread Andreas Färber
Am 11.07.2013 12:31, schrieb Michael S. Tsirkin: > On Thu, Jul 11, 2013 at 11:47:59AM +0200, Igor Mammedov wrote: >> On Thu, 11 Jul 2013 11:47:16 +1000 >> peter.crosthwa...@xilinx.com wrote: >> >>> From: Peter Crosthwaite >>> >>> ARMCPUClass is only needed for parent-class abstract function access

Re: [Qemu-devel] vm performance degradation after kvm live migration or save-restore with ETP enabled

2013-07-11 Thread Gleb Natapov
On Thu, Jul 11, 2013 at 09:36:47AM +, Zhanghaoyu (A) wrote: > hi all, > > I met similar problem to these, while performing live migration or > save-restore test on the kvm platform (qemu:1.4.0, host:suse11sp2, > guest:suse11sp2), running tele-communication software suite in guest, > https://

Re: [Qemu-devel] vm performance degradation after kvm live migration or save-restore with ETP enabled

2013-07-11 Thread Xiao Guangrong
Hi, Could you please test this patch? >From 48df7db2ec2721e35d024a8d9850dbb34b557c1c Mon Sep 17 00:00:00 2001 From: Xiao Guangrong Date: Thu, 6 Sep 2012 16:56:01 +0800 Subject: [PATCH 10/11] using huge page on fast page fault path --- arch/x86/kvm/mmu.c | 27 --- 1 fi

Re: [Qemu-devel] [PATCH qom-next v2 3/5] target-arm: Use parent classes for reset + realize

2013-07-11 Thread Igor Mammedov
On Thu, 11 Jul 2013 13:31:15 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jul 11, 2013 at 11:47:59AM +0200, Igor Mammedov wrote: > > On Thu, 11 Jul 2013 11:47:16 +1000 > > peter.crosthwa...@xilinx.com wrote: > > > > > From: Peter Crosthwaite > > > > > > ARMCPUClass is only needed for parent-cla

Re: [Qemu-devel] vm performance degradation after kvm live migration or save-restore with ETP enabled

2013-07-11 Thread Andreas Färber
Hi, Am 11.07.2013 11:36, schrieb Zhanghaoyu (A): > I met similar problem to these, while performing live migration or > save-restore test on the kvm platform (qemu:1.4.0, host:suse11sp2, > guest:suse11sp2), running tele-communication software suite in guest, > https://lists.gnu.org/archive/html/

[Qemu-devel] [PATCH] pc: don't access fw cfg if NULL

2013-07-11 Thread Michael S. Tsirkin
commit f8c457b88d72a48989f190bc3d7b79f4f3b7d11c "pc: pass PCI hole ranges to Guests" broke Xen as it has no fw_cfg. Check for this configuration and boil out. Signed-off-by: Michael S. Tsirkin Tested-by: Stefano Stabellini --- Anthony, could you fast-track this into master please? Thanks!

Re: [Qemu-devel] [RFC PATCH 01/11] qapi-types.py: Split off generate_struct_fields()

2013-07-11 Thread Eric Blake
On 07/09/2013 03:53 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > scripts/qapi-types.py | 19 +-- > 1 file changed, 13 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://l

Re: [Qemu-devel] [PULL v4 00/18] pci,misc enhancements

2013-07-11 Thread Michael S. Tsirkin
On Wed, Jul 10, 2013 at 04:34:30PM +0100, Stefano Stabellini wrote: > On Wed, 10 Jul 2013, Michael S. Tsirkin wrote: > > On Wed, Jul 10, 2013 at 03:30:01PM +0100, Stefano Stabellini wrote: > > > On Wed, 10 Jul 2013, Michael S. Tsirkin wrote: > > > > On Wed, Jul 10, 2013 at 03:11:27PM +0100, Stefano

Re: [Qemu-devel] [RFC PATCH 02/11] qapi-types.py: Implement 'base' for unions

2013-07-11 Thread Eric Blake
On 07/09/2013 03:53 AM, Kevin Wolf wrote: > The new 'base' key in a union definition refers to a struct type, which > is inlined into the union definition and can represent fields common to > all kinds. Is it worth listing an example of intended use in the commit message? If I understand correctly

[Qemu-devel] [PATCH v2 1/2] pci: add pci_for_each_bus

2013-07-11 Thread Michael S. Tsirkin
Useful for ACPI hotplug. Signed-off-by: Michael S. Tsirkin --- hw/pci/pci.c | 17 + include/hw/pci/pci.h | 3 +++ 2 files changed, 20 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 8680063..a4f7f8d 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1679,6 +1

[Qemu-devel] [PATCH v2 0/2] acpi hotplug of devices behind a bridge

2013-07-11 Thread Michael S. Tsirkin
This is on top of patchset generating ACPI tables in qemu. Changes from v1: - fixed some bugs - fixed migration and cross version compatibility - rebased to latest bits Michael S. Tsirkin (2): pci: add pci_for_each_bus qemu: piix: PCI bridge ACPI hotplug support docs/specs/acpi_p

[Qemu-devel] [PATCH v2 2/2] qemu: piix: PCI bridge ACPI hotplug support

2013-07-11 Thread Michael S. Tsirkin
This adds support for device hotplug behind pci bridges. Bridge devices themselves need to be pre-configured on qemu command line. Design: - each bus gets assigned a number 0-255 - generated ACPI code writes this number to a new BSEL register, then uses existing UP/DOWN registe

[Qemu-devel] [PATCH] virtio-ccw patch queue as of 2013/07/11

2013-07-11 Thread Cornelia Huck
Hi, as we have notifiers for virtio-ccw now, we can enable dataplane for virtio-blk. (This patch has been running in our internal testing for some time now and just has been redone to fit on upstream qemu.) Patch is available at git://github.com/cohuck/qemu virtio-ccw-upstr Dominik Dingel (1):

[Qemu-devel] [PATCH] virtio-ccw: Enable x-data-plane for virtio-ccw-blk

2013-07-11 Thread Cornelia Huck
From: Dominik Dingel Add property x-data-plane to virtio-ccw-blk devices. Signed-off-by: Dominik Dingel Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index e744957..8835bd4 100644

Re: [Qemu-devel] [PATCH v2 0/2] acpi hotplug of devices behind a bridge

2013-07-11 Thread Michael S. Tsirkin
On Thu, Jul 11, 2013 at 03:03:58PM +0300, Michael S. Tsirkin wrote: > This is on top of patchset generating ACPI tables in qemu. > Changes from v1: > - fixed some bugs > - fixed migration and cross version compatibility > - rebased to latest bits Naturally, as I address review comment

[Qemu-devel] [PATCHv3 02/10] iscsi: add .bdrv_co_is_allocated

2013-07-11 Thread Peter Lieven
this patch adds a coroutine for .bdrv_co_is_allocated as well as a generic framework that can be used to build coroutines in block/iscsi. Signed-off-by: Peter Lieven --- block/iscsi.c | 130 + 1 file changed, 130 insertions(+) diff --git

[Qemu-devel] [PATCHv3 04/10] iscsi: add .bdrv_write_zeroes

2013-07-11 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 16 1 file changed, 16 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 60f2fd0..64554bc 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -906,6 +906,21 @@ retry: return 0; } +static int +coroutine_fn iscsi

[Qemu-devel] [PATCHv3 03/10] iscsi: add .bdrv_co_discard

2013-07-11 Thread Peter Lieven
this patch changes bdrv_discard to a co routine. it honours max_unmap information and splits requests if necessary. if unmap is unsupported by the target the request is silently discarded. Signed-off-by: Peter Lieven --- block/iscsi.c | 137 +++---

[Qemu-devel] [PATCHv3 07/10] iscsi: fix -ENOSPC in iscsi_create()

2013-07-11 Thread Peter Lieven
the -ENOPSC case did not work due to the missing goto. Reported-by: Kevin Wolf Signed-off-by: Peter Lieven --- block/iscsi.c |1 + 1 file changed, 1 insertion(+) diff --git a/block/iscsi.c b/block/iscsi.c index 64554bc..6cdd182 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1432,6 +143

[Qemu-devel] [PATCHv3 01/10] iscsi: add logical block provisioning information to iscsilun

2013-07-11 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 83 + 1 file changed, 83 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 0bbf0b1..c802e38 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -49,6 +49,12 @@ typedef struct Iscs

[Qemu-devel] [PATCHv3 00/10] iscsi/qemu-img/block-migration enhancements

2013-07-11 Thread Peter Lieven
this series adds logical block provisioning functions to the iscsi layer. it also is the first step to the change of migration to coroutines in block/iscsi. the changes to qemu-img and block migration have been split and will follow in separte patches later. changes in v3: - merge both block pro

Re: [Qemu-devel] [RFC PATCH 03/11] qapi-visit.py: Split off generate_visit_struct_fields()

2013-07-11 Thread Eric Blake
On 07/09/2013 03:53 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > scripts/qapi-visit.py | 62 > --- > 1 file changed, 34 insertions(+), 28 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266

[Qemu-devel] [PATCHv3 05/10] block: add bdrv_write_zeroes()

2013-07-11 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block.c | 27 +++ include/block/block.h |2 ++ 2 files changed, 21 insertions(+), 8 deletions(-) diff --git a/block.c b/block.c index 183fec8..bce1909 100644 --- a/block.c +++ b/block.c @@ -2155,6 +2155,7 @@ typedef stru

[Qemu-devel] [PATCHv3 09/10] iscsi: remove support for misaligned nb_sectors in aio_readv

2013-07-11 Thread Peter Lieven
this hask is not working (anymore). support for misaligned offsets should be handled at the block layer. Signed-off-by: Peter Lieven --- block/iscsi.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index bc62a7e..903f2f

[Qemu-devel] [PATCHv3 08/10] iscsi: factor out sector conversions

2013-07-11 Thread Peter Lieven
Reviewed-by: Kevin Wolf Signed-off-by: Peter Lieven --- block/iscsi.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 6cdd182..bc62a7e 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -289,6 +289,11 @@ static int64_t sector_

[Qemu-devel] [PATCHv3 10/10] iscsi: assert that sectors are aligned to LUN blocksize

2013-07-11 Thread Peter Lieven
if the blocksize of an iSCSI LUN is bigger than the BDRV_SECTOR_SIZE it is possible that sector_num or nb_sectors are not correctly alligned. to avoid corruption we fail requests which are misaligned. Signed-off-by: Peter Lieven --- block/iscsi.c | 34 ++ 1 fil

Re: [Qemu-devel] [RFC PATCH 04/11] qapi-visit.py: Implement 'base' for unions

2013-07-11 Thread Eric Blake
On 07/09/2013 03:53 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > scripts/qapi-visit.py | 33 - > 1 file changed, 28 insertions(+), 5 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization

[Qemu-devel] [PATCHv3 06/10] block/raw: add bdrv_co_write_zeroes

2013-07-11 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/raw.c |8 1 file changed, 8 insertions(+) diff --git a/block/raw.c b/block/raw.c index ce10422..8c81de9 100644 --- a/block/raw.c +++ b/block/raw.c @@ -42,6 +42,13 @@ static int coroutine_fn raw_co_is_allocated(BlockDriverState *bs, return

Re: [Qemu-devel] [PATCH] pc: don't access fw cfg if NULL

2013-07-11 Thread Igor Mammedov
On Thu, 11 Jul 2013 14:52:40 +0300 "Michael S. Tsirkin" wrote: > commit f8c457b88d72a48989f190bc3d7b79f4f3b7d11c > "pc: pass PCI hole ranges to Guests" > broke Xen as it has no fw_cfg. > Check for this configuration and boil out. > > Signed-off-by: Michael S. Tsirkin > Tested-by: Stefano S

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-11 Thread Alexander Graf
On 24.06.2013, at 08:07, Jan Kiszka wrote: > On 2013-06-23 22:50, Hervé Poussineau wrote: >> Jan Kiszka a écrit : >>> From: Jan Kiszka >>> >>> The current ioport dispatcher is a complex beast, mostly due to the >>> need to deal with old portio interface users. But we can overcome it >>> without

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-11 Thread Alexander Graf
On 11.07.2013, at 14:29, Alexander Graf wrote: > > On 24.06.2013, at 08:07, Jan Kiszka wrote: > >> On 2013-06-23 22:50, Hervé Poussineau wrote: >>> Jan Kiszka a écrit : From: Jan Kiszka The current ioport dispatcher is a complex beast, mostly due to the need to deal with o

Re: [Qemu-devel] [RFC PATCH 05/11] qapi: Add visitor for implicit structs

2013-07-11 Thread Eric Blake
On 07/09/2013 03:53 AM, Kevin Wolf wrote: > These can be used when an embedded struct is parsed and members not > belonging to the struct may be present in the input (parsing flat > namespect QMP union with discriminator) namespect? Not sure if you meant 'namespaced'? Again, a comment demonstrati

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-11 Thread Andreas Färber
Am 11.07.2013 14:34, schrieb Alexander Graf: > > On 11.07.2013, at 14:29, Alexander Graf wrote: > >> >> On 24.06.2013, at 08:07, Jan Kiszka wrote: >> >>> On 2013-06-23 22:50, Hervé Poussineau wrote: Jan Kiszka a écrit : > From: Jan Kiszka > > The current ioport dispatcher is a c

Re: [Qemu-devel] [RFC PATCH 02/11] qapi-types.py: Implement 'base' for unions

2013-07-11 Thread Eric Blake
On 07/11/2013 05:57 AM, Eric Blake wrote: > On 07/09/2013 03:53 AM, Kevin Wolf wrote: >> The new 'base' key in a union definition refers to a struct type, which >> is inlined into the union definition and can represent fields common to >> all kinds. > > Is it worth listing an example of intended u

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-11 Thread Alexander Graf
On 11.07.2013, at 14:46, Andreas Färber wrote: > Am 11.07.2013 14:34, schrieb Alexander Graf: >> >> On 11.07.2013, at 14:29, Alexander Graf wrote: >> >>> >>> On 24.06.2013, at 08:07, Jan Kiszka wrote: >>> On 2013-06-23 22:50, Hervé Poussineau wrote: > Jan Kiszka a écrit : >> From

Re: [Qemu-devel] [RFC PATCH 05/11] qapi: Add visitor for implicit structs

2013-07-11 Thread Eric Blake
On 07/11/2013 06:41 AM, Eric Blake wrote: > On 07/09/2013 03:53 AM, Kevin Wolf wrote: >> These can be used when an embedded struct is parsed and members not >> belonging to the struct may be present in the input (parsing flat >> namespect QMP union with discriminator) > > namespect? Not sure if yo

Re: [Qemu-devel] [PATCH] virtio-net: put virtio net header inline with data

2013-07-11 Thread Michael S. Tsirkin
On Tue, Jul 09, 2013 at 11:46:23AM +0930, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > For small packets we can simplify xmit processing > > by linearizing buffers with the header: > > most packets seem to have enough head room > > we can use for this purpose. > > Since existing hypervi

Re: [Qemu-devel] [PATCH V4 00/10] Add support for binding guest numa nodes to host numa nodes

2013-07-11 Thread Eduardo Habkost
On Thu, Jul 11, 2013 at 06:32:48PM +0800, Peter Huang(Peng) wrote: > Hi,Wanlong > > From the patch discription below, seems that qemu numa only support > cpu/memory node binding. > As we know, binding is not the common usage due to VM migration may happen or > the load balance > would be disabl

[Qemu-devel] [PATCH] virtio-net: add feature bit for any header s/g

2013-07-11 Thread Michael S. Tsirkin
Old qemu versions required that 1st s/g entry is the header. Since QEMU 1.5, patchset titled "virtio-net: iovec handling cleanup" removed this limitation but a feature bit is needed so guests know it's safe to lay out header differently. This patch applies on top and adds such a feature bit to QE

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-11 Thread Alexander Graf
On 11.07.2013, at 14:48, Alexander Graf wrote: > > On 11.07.2013, at 14:46, Andreas Färber wrote: > >> Am 11.07.2013 14:34, schrieb Alexander Graf: >>> >>> On 11.07.2013, at 14:29, Alexander Graf wrote: >>> On 24.06.2013, at 08:07, Jan Kiszka wrote: > On 2013-06-23 22:50,

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-11 Thread Alexander Graf
On 11.07.2013, at 15:28, Alexander Graf wrote: > > On 11.07.2013, at 14:48, Alexander Graf wrote: > >> >> On 11.07.2013, at 14:46, Andreas Färber wrote: >> >>> Am 11.07.2013 14:34, schrieb Alexander Graf: On 11.07.2013, at 14:29, Alexander Graf wrote: > > On 24.06.20

Re: [Qemu-devel] [PATCH] virtio-net: add feature bit for any header s/g

2013-07-11 Thread Laszlo Ersek
On 07/11/13 15:15, Michael S. Tsirkin wrote: > Old qemu versions required that 1st s/g entry is the header. > > Since QEMU 1.5, patchset titled "virtio-net: iovec handling cleanup" > removed this limitation but a feature bit is needed so guests know it's > safe to lay out header differently. > >

Re: [Qemu-devel] [PATCH] full introspection support for QMP

2013-07-11 Thread Amos Kong
On Wed, Jul 03, 2013 at 07:54:47AM -0500, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Il 02/07/2013 22:58, Anthony Liguori ha scritto: > >> > > We consume the schema in QEMU. No reason for us to consume it in a > >> > > different format than libvirt. > >> > > >> > One reason could be th

Re: [Qemu-devel] [PATCH] virtio-net: add feature bit for any header s/g

2013-07-11 Thread Michael S. Tsirkin
On Thu, Jul 11, 2013 at 03:39:42PM +0200, Laszlo Ersek wrote: > On 07/11/13 15:15, Michael S. Tsirkin wrote: > > Old qemu versions required that 1st s/g entry is the header. > > > > Since QEMU 1.5, patchset titled "virtio-net: iovec handling cleanup" > > removed this limitation but a feature bit i

Re: [Qemu-devel] [PATCH] virtio-net: add feature bit for any header s/g

2013-07-11 Thread Laszlo Ersek
On 07/11/13 15:41, Michael S. Tsirkin wrote: > So we'll add a way for users to shoot themselves in the foot > by setting a flag incorrectly. Point being? Point taken. The flag name being global / universal relates to the concept, not support level. Exposing it in any device enables the user to se

Re: [Qemu-devel] vm performance degradation after kvm live migration or save-restore with ETP enabled

2013-07-11 Thread Zhang Haoyu
>Hi, > >Could you please test this patch? > I tried this patch, but the problem still be there. Thanks, Zhang Haoyu >>From 48df7db2ec2721e35d024a8d9850dbb34b557c1c Mon Sep 17 00:00:00 2001 >From: Xiao Guangrong >Date: Thu, 6 Sep 2012 16:56:01 +0800 >Subject: [PATCH 10/11] using huge page on fast

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-07-11 Thread Amos Kong
On Thu, Jul 04, 2013 at 08:28:59AM +0200, Markus Armbruster wrote: > Amos Kong writes: > > > On Tue, Jul 02, 2013 at 03:27:12PM +0200, Markus Armbruster wrote: > >> Amos Kong writes: > >> > >> > On Tue, Jul 02, 2013 at 11:05:56AM +0200, Markus Armbruster wrote: > >> >> Amos Kong writes: > >> [

Re: [Qemu-devel] [RFC PATCH 06/11] qapi: Flat unions with arbitrary discriminator

2013-07-11 Thread Eric Blake
On 07/09/2013 03:53 AM, Kevin Wolf wrote: > Instead of the rather verbose syntax that distinguishes base and > subclass fields... > > { "type": "file", > "read-only": true, > "data": { > "filename": "test" > } } > > ...we can now have both in the same namespace, allowing a m

Re: [Qemu-devel] [Qemu-ppc] [PATCH 00/17] PPC: Mac OS X guest bringup v2

2013-07-11 Thread Alexander Graf
On 01.07.2013, at 02:13, Alexander Graf wrote: > Recently there has been a lot of progress on the OpenBIOS side to get Mac OS X > to boot. > > For a while now it seemed there was only very little to make it a fully > working > guest os in QEMU. > > This patch set is the result of this. With th

[Qemu-devel] [PATCH MST/PCI] additional fixes for mac-programming feature

2013-07-11 Thread Amos Kong
Markus added some comments on old patchset, this patch contains some additional fixes, it's based on MST's PCI tree. * Fix typos (missed 1.6, NIC) * Don't initialize list point at its declaration * Always notify QMP client if mactable is changed * Returns NULL list if no net client supports rx-fil

Re: [Qemu-devel] [PATCH v2 repost 3/9] acpi: add rules to compile ASL source

2013-07-11 Thread Laszlo Ersek
On 07/10/13 15:51, Michael S. Tsirkin wrote: > Detect presence of IASL compiler and use it > to process ASL source. If not there, use pre-compiled > files in-tree. Add script to update the in-tree files. > > Signed-off-by: Michael S. Tsirkin > --- > configure | 9 - > hw/i3

Re: [Qemu-devel] [PATCH v2 repost 1/9] hw/i386/pc.c: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/apic.h

2013-07-11 Thread Laszlo Ersek
On 07/10/13 15:51, Michael S. Tsirkin wrote: > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Laszlo Ersek > Signed-off-by: Michael S. Tsirkin > --- > hw/i386/pc.c | 2 -- > include/hw/i386/apic.h | 2 ++ > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Laszlo Erse

Re: [Qemu-devel] [PATCH v2 repost 3/9] acpi: add rules to compile ASL source

2013-07-11 Thread Laszlo Ersek
On 07/11/13 18:55, Laszlo Ersek wrote: > On 07/10/13 15:51, Michael S. Tsirkin wrote: >> Detect presence of IASL compiler and use it >> to process ASL source. If not there, use pre-compiled >> files in-tree. Add script to update the in-tree files. >> >> Signed-off-by: Michael S. Tsirkin >> --- >>

Re: [Qemu-devel] [PATCH v2 repost 4/9] acpi: pre-compiled ASL files

2013-07-11 Thread Laszlo Ersek
On 07/10/13 15:51, Michael S. Tsirkin wrote: > Add pre-compiled ASL files. Useful for systems that > do not have IASL. > > Signed-off-by: Michael S. Tsirkin > --- > hw/i386/acpi-dsdt.hex.generated | 4409 + > hw/i386/q35-acpi-dsdt.hex.generated | 7346 > +

Re: [Qemu-devel] [PATCH v2 repost 2/9] i386: add ACPI table files from seabios

2013-07-11 Thread Laszlo Ersek
On 07/10/13 15:51, Michael S. Tsirkin wrote: > This adds ASL code as well as scripts for processing it, > imported from seabios git tree > commit 51684b7ced75fb76776e8ee84833fcfb6ecf12dd > > Will be used for runtime acpi table generation. > > Note: > This patch reuses some code from SeaBIOS, whic

[Qemu-devel] [PATCH 17/22] PPC: dbdma: macio: Add DMA callback

2013-07-11 Thread Alexander Graf
We need to know when the IDE core starts a DMA transfer. Add a notifier function so we have the chance to start transmitting data. Signed-off-by: Alexander Graf --- hw/ide/macio.c | 40 hw/ppc/mac.h | 2 ++ 2 files changed, 42 insertions(+) diff --git

[Qemu-devel] [PATCH 03/22] spapr: Use named enum for function remove_hpte

2013-07-11 Thread Alexander Graf
From: Stefan Weil The function returned a target_ulong which was made from unnamed enum values. The target_ulong was then assigned to an int variable which was used in a switch statement. Using a named enum in both cases makes reviews easier. Signed-off-by: Stefan Weil Signed-off-by: Alexander

[Qemu-devel] [PATCH 11/22] PPC: Mac: Add debug prints in macio and dbdma code

2013-07-11 Thread Alexander Graf
The macio code is basically undebuggable as it stands today, with no debug prints anywhere whatsoever. DBDMA was better, but I needed a few more to create reasonable logs that tell me where breakage is. Add a DPRINTF macro in the macio source file and add a bunch of debug prints that are all disab

[Qemu-devel] [PATCH 15/22] PPC: dbdma: Introduce kick function

2013-07-11 Thread Alexander Graf
The DBDMA engine really is running all the time, waiting for input. However we don't want to waste cycles constantly polling. So introduce a kick function that data providers can call to notify the DBDMA controller of new input. Signed-off-by: Alexander Graf --- hw/misc/macio/mac_dbdma.c | 5 +

[Qemu-devel] [PATCH 10/22] PPC: dbdma: Replace tabs with spaces

2013-07-11 Thread Alexander Graf
s/^I//g on the file with a few manual tweaks to align things. Signed-off-by: Alexander Graf --- hw/misc/macio/mac_dbdma.c | 102 +++--- 1 file changed, 51 insertions(+), 51 deletions(-) diff --git a/hw/misc/macio/mac_dbdma.c b/hw/misc/macio/mac_db

[Qemu-devel] [PATCH 20/22] PPC: dbdma: Support unaligned DMA access

2013-07-11 Thread Alexander Graf
The DBDMA engine really just reads bytes from a producing device (IDE in our case) and shoves these bytes into memory. It doesn't care whether any alignment takes place or not. Our code today however assumes that block accesses always happen on sector (512 byte) boundaries. This is a fair assumpti

[Qemu-devel] [PATCH 14/22] PPC: dbdma: Move defines into header file

2013-07-11 Thread Alexander Graf
We usually keep struct and constant definitions in header files. Move them there to stay consistent and to make access to fields easier. Signed-off-by: Alexander Graf --- hw/misc/macio/mac_dbdma.c | 117 include/hw/ppc/mac_dbdma.h | 118 +

[Qemu-devel] [PATCH 07/22] PPC: Mac: Fix guest exported tbfreq values

2013-07-11 Thread Alexander Graf
We can tell the guest the frequency of its time base through fwcfg. However, we tell it a different value from the speed tb actually runs at. Let's fix it and make the tbfreq initialization and the fwcfg exposure use the same values. Signed-off-by: Alexander Graf --- hw/ppc/mac_newworld.c | 5 +

[Qemu-devel] [PATCH 21/22] PPC: Add timer handler for newworld mac-io

2013-07-11 Thread Alexander Graf
Mac OS X accesses fancy timer registers inside of the mac-io on bootup. These really should be ticking at the mac-io bus frequency, but I don't see anyone upset when we just make them as fast as we want to. With this patch on top of my previous patch queue and latest OpenBIOS I am able to boot Ma

[Qemu-devel] [PATCH 18/22] PPC: dbdma: Move processing to io

2013-07-11 Thread Alexander Graf
Soon we will introduce intermediate processing pauses which will allow the bottom half to restart a DMA request that couldn't be fulfilled yet. For that to work, move the processing variable into the io struct which is what DMA providers work with. While touching it, also change it into a bool S

Re: [Qemu-devel] [PATCH v2 repost 3/9] acpi: add rules to compile ASL source

2013-07-11 Thread Michael S. Tsirkin
On Thu, Jul 11, 2013 at 06:55:37PM +0200, Laszlo Ersek wrote: > On 07/10/13 15:51, Michael S. Tsirkin wrote: > > Detect presence of IASL compiler and use it > > to process ASL source. If not there, use pre-compiled > > files in-tree. Add script to update the in-tree files. > > > > Signed-off-by: M

[Qemu-devel] [PATCH 08/22] PPC: g3beige: Move secondary IDE bus to mac-io

2013-07-11 Thread Alexander Graf
On a real G3 Beige the secondary IDE bus lives on the mac-io chip, not on some random PCI device. Move it there to become more compatible. While at it, also clean up the IDE channel connection logic. Signed-off-by: Alexander Graf --- hw/ide/macio.c| 2 +- hw/misc/macio/macio.c | 93 +++

[Qemu-devel] [PATCH 06/22] target-ppc: Add POWER8 v1.0 CPU model

2013-07-11 Thread Alexander Graf
From: Prerna Saxena This patch adds CPU PVR definition for POWER8, and enables QEMU to launch guests on POWER8 hardware. Signed-off-by: Prerna Saxena Signed-off-by: Alexey Kardashevskiy Reviewed-by: Paul Mackerras Reviewed-by: Andreas Farber Signed-off-by: Alexander Graf --- target-ppc/cpu

[Qemu-devel] [Bug 1200212] [NEW] qemu-system-arm aborts in lsi_soft_reset

2013-07-11 Thread Sami Laine
Public bug reported: Qemu compiled from master branch (fetched on 11th Jul 2013, qemu-system- arm -version prints "QEMU emulator version 1.5.50, Copyright (c) 2003-2008 Fabrice Bellard") running on OSX 10.6.8 crashes during Debian 7.1 netboot installation with error: "Assertion failed: (QTAILQ_EMP

[Qemu-devel] sound recording

2013-07-11 Thread songtianyi
Hi, i got a trouble when i was using windows 7 guest, which emulated by qemu-kvm. When i start Sound Recorder application in win7 guest os, the guest's cpu usage rising up to 100%. i can't do any other operations because cpu was fully occupied. How to figure out this problem? Environment

[Qemu-devel] [PATCH 09/22] PPC: Macio: Replace tabs with spaces

2013-07-11 Thread Alexander Graf
s/^I//g on the file. Signed-off-by: Alexander Graf --- hw/ide/macio.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/ide/macio.c b/hw/ide/macio.c index 0b05a74..60b64ac 100644 --- a/hw/ide/macio.c +++ b/hw/ide/macio.c @@ -55,7 +55,7 @@ static void pmac_ide

Re: [Qemu-devel] [Xen-devel] [PATCH v2] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-11 Thread Dario Faggioli
On gio, 2013-07-11 at 12:33 +0200, Fabio Fantoni wrote: > Usage: usbversion=1|2|3 (default=2) > Specifies the type of an emulated USB bus in the guest. 1 for usb1, > 2 for usb2 and 3 for usb3, it is available only with upstream qemu. > Default is 2. > > Signed-off-by: Fabio Fantoni > > diff --git

[Qemu-devel] [PATCH 13/22] PPC: dbdma: Allow new commands in RUN state

2013-07-11 Thread Alexander Graf
The DBDMA controller can not change its command stream while it's actively streaming data, true. But the fact that it's in RUN state doesn't actually indicate anything. It could just as well be in WAIT while in RUN. And then it's legal to change commands. This fixes a real world issue I've encount

[Qemu-devel] [PATCH 01/22] e600 core for MPC86xx processors

2013-07-11 Thread Alexander Graf
From: Julio Guerra MPC86xx processors are based on the e600 core, which is not the case in qemu where it is based on the 7400 processor. This patch creates the e600 core and instantiates the MPC86xx processors based on it. Therefore, adding the high BATs, the SPRG 4..7 registers, which are e600-

[Qemu-devel] [PATCH 04/22] spapr: Respect -bios command line option for SLOF

2013-07-11 Thread Alexander Graf
From: Andreas Färber Allow the user to override the firmware file name rather than always using "slof.bin". Reported-by: Dinar Valeev Signed-off-by: Andreas Färber Signed-off-by: Alexander Graf --- hw/ppc/spapr.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/ppc/

[Qemu-devel] [PATCH 22/22] PPC: dbdma: Support more multi-issue DMA requests

2013-07-11 Thread Alexander Graf
A DMA request can happen for data that hasn't been completely been provided by the IDE core yet. For example - DBDMA request for 0x1000 bytes - IDE request for 1 sector - DBDMA wants to read 0x1000 bytes (8 sectors) from bdrv - breakage Instead, we should truncate our bdrv request to the

[Qemu-devel] [PATCH 19/22] PPC: dbdma: Wait for DMA until we have data

2013-07-11 Thread Alexander Graf
We should only start processing DMA requests when we have data to process. Hold off working through the DMA shuffling until the IDE core told us that it's ready. This is required because the guest can program the DMA engine or the IDE transfer first. Both are legal. Signed-off-by: Alexander Graf

[Qemu-devel] [PATCH 16/22] PPC: dbdma: Move static bh variable to device struct

2013-07-11 Thread Alexander Graf
The DBDMA controller has a bottom half to asynchronously process DMA request queues. This bh was stored as a gross static variable. Move it into the device struct instead. While at it, move all users of it to the new generic kick function. Signed-off-by: Alexander Graf --- hw/misc/macio/mac_db

Re: [Qemu-devel] vm performance degradation after kvm live migration or save-restore with ETP enabled

2013-07-11 Thread Bruce Rogers
>>> On 7/11/2013 at 03:36 AM, "Zhanghaoyu (A)" wrote: > hi all, > > I met similar problem to these, while performing live migration or > save-restore test on the kvm platform (qemu:1.4.0, host:suse11sp2, > guest:suse11sp2), running tele-communication software suite in guest, > https://lists.g

[Qemu-devel] [PATCH 12/22] PPC: dbdma: Fix debug print

2013-07-11 Thread Alexander Graf
There was a debug print that didn't compile for me because the format and the arguments weren't in sync. Fix it up. Signed-off-by: Alexander Graf --- hw/misc/macio/mac_dbdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/misc/macio/mac_dbdma.c b/hw/misc/macio/mac_dbdm

[Qemu-devel] [PULL 00/22] ppc patch queue 2013-07-11

2013-07-11 Thread Alexander Graf
Hi Blue / Aurelien, This is my current patch queue for ppc. Please pull. While at it, could you please also generate a new OpenBIOS binary for PPC and SPARC? Quite a number of bug fixes happened in there in between. Alex The following changes since commit c170a23ca0097a95b44fc7cc604018cd3c3b7

[Qemu-devel] [PATCH 05/22] pseries: move interrupt controllers to hw/intc/

2013-07-11 Thread Alexander Graf
From: Alexey Kardashevskiy Signed-off-by: Alexey Kardashevskiy Reviewed-by: Andreas Färber Signed-off-by: Alexander Graf --- default-configs/ppc64-softmmu.mak | 2 ++ hw/intc/Makefile.objs | 1 + hw/{ppc => intc}/xics.c | 0 hw/ppc/Makefile.objs | 2 +- 4 fi

[Qemu-devel] [PATCH 02/22] spapr: Fix compiler warnings for some versions of gcc

2013-07-11 Thread Alexander Graf
From: Stefan Weil i686-w64-mingw32-gcc (GCC) 4.6.3 from Debian wheezy reports these warnings: hw/ppc/spapr_hcall.c:188:1: warning: control reaches end of non-void function [-Wreturn-type] hw/ppc/spapr_pci.c:454:1: warning: control reaches end of non-void function [-Wreturn-type] Both warning

[Qemu-devel] [RFC] qapi: qapi-commands: fix possible leaks on visitor dealloc

2013-07-11 Thread Luiz Capitulino
I'm sending this as an RFC because this is untested, and also because I'm wondering if I'm seeing things after a long patch review session. The problem is: in qmp-marshal.c, the dealloc visitor calls use the same errp pointer of the input visitor calls. This means that if any of the input visitor

  1   2   >