Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug

2013-06-27 Thread Paolo Bonzini
Il 27/06/2013 04:08, liu ping fan ha scritto: >> > qdev_free is triggered by the guest, but free is a misnomer. It is >> > really "make it inaccessible from the guest and management" (the kernel >> > equivalent would be removal of /dev and /sys entries, for example). The >> > actual "free" will h

Re: [Qemu-devel] [PATCH] vmdk: remove wrong calculation of relative path

2013-06-27 Thread Paolo Bonzini
Il 26/06/2013 17:05, Kevin Wolf ha scritto: > Am 26.06.2013 um 11:24 hat Fam Zheng geschrieben: >> > When creating image with backing file, the driver tries to calculate the >> > relative path from created image file to backing file, but the path >> > computation is incorrect. e.g.: >> > >> >

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-27 Thread Qiao Nuohan
Sorry for replying late. On 06/20/2013 04:57 PM, Stefan Hajnoczi wrote: Please link to the code that writes DISKDUMP kdump files on a physical machine. I only see the crash utility code to read the DISKDUMP code but I haven't found anything in the Linux kernel, the crash utility, or the kexec-

[Qemu-devel] [Bug 1195012] Re: x86_64 and i386 return 0 when reading MSR_TSC

2013-06-27 Thread Jeff Rizzo
I should mention, the NetBSD 6.1 ISO I used for testing is here: http://iso.netbsd.org/pub/NetBSD/iso/6.1/NetBSD-6.1-amd64.iso -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1195012 Title: x86_64 a

[Qemu-devel] [Bug 1195012] [NEW] x86_64 and i386 return 0 when reading MSR_TSC

2013-06-27 Thread Jeff Rizzo
Public bug reported: Running NetBSD 6.1 (i386 and amd64) under QEMU (from git - 1.5.50 is the version it shows) results in an incorrectly set TSC frequency (set to 0), because NetBSD uses rdmsr(TSC_MSR) for its serializing CPU counter. To reproduce the problem, you can run an install ISO of Net

[Qemu-devel] [Bug 1195170] [NEW] cpu hot-add doesn't work with upstream qemu 1.5.50

2013-06-27 Thread chandrashekar shastri
Public bug reported: cpu hot-add doesn't work with upstream qemu 1.5.50. When we add the cpu [through QMP] it throws error as " {"error": {"class": "GenericError", "desc": "Unable to add CPU: 2, max allowed: 1"}} ", when we have booted the guest with two cpus. Host Kernel Version: 3.10.0-rc5+ Li

[Qemu-devel] [Bug 1195012] Re: x86_64 and i386 return 0 when reading MSR_TSC

2013-06-27 Thread Jeff Rizzo
The NetBSD problem report where this issue was raised: http://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=47967 a workaround has been put in place for now, but it would be good to fix this in QEMU. -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] qemu-img create encryption

2013-06-27 Thread Markus Armbruster
"Hamilton, Peter A." writes: > I've been doing some work with qemu-img and encrypted qcow2 images and have > noticed that "qemu-img create" does not prompt for a password to encrypt new > images, defaulting (from the documentation I've read) to the empty string as > a password. Why does "qemu-img

[Qemu-devel] [PATCH] hw/mips: align initrd to 64KB to avoid kernel error

2013-06-27 Thread Leon Alrae
From: James Hogan The Linux kernel can be configured to use 64KB pages, but it also requires initrd to be page aligned. Therefore, to be safe, align the initrd to 64KB using a new INITRD_PAGE_MASK rather than TARGET_PAGE_MASK. Signed-off-by: James Hogan Signed-off-by: Leon Alrae --- hw/mips/m

[Qemu-devel] [PATCH 0/2] Add infinite loop checking in img_create()

2013-06-27 Thread Xu Wang
From: Xu Wang If user creates a image with loop in backing file, qemu doesn't give any warning or error report and creation successful. If this image was opend by qemu, no response would occure and segment fault would happend at last. Hence these patches refine and export infinite loop checking i

[Qemu-devel] [PATCH 2/2] Check infinite loop in img_create()

2013-06-27 Thread Xu Wang
From: Xu Wang Signed-off-by: Xu Wang --- qemu-img.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/qemu-img.c b/qemu-img.c index 0bc265d..fe11421 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -415,6 +415,7 @@ static int img_create(int argc, char **argv) char *options = NULL

[Qemu-devel] [PATCH 1/2] Refine and export infinite loop checking in collect_image_info_list()

2013-06-27 Thread Xu Wang
From: Xu Wang Signed-off-by: Xu Wang --- qemu-img.c | 110 + 1 file changed, 89 insertions(+), 21 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 809b4f1..0bc265d 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -324,6 +324,86 @@ s

[Qemu-devel] Level of details in log file

2013-06-27 Thread ammad rehmat
Hi, I am trying to debug my program with the help of QEMU, I use the following command to generate the log : ./mips64-softmmu/qemu-system-mips64 -d in_asm,cpu,int,exec -m 1024 -M octeon -nographic -bios ~/work/sme_test/guest/OCTEON-SDK/bootloader/u-boot/u-boot-octeon_ebh5610.bin The problem is t

Re: [Qemu-devel] [PATCH] vmdk: remove wrong calculation of relative path

2013-06-27 Thread Kevin Wolf
Am 27.06.2013 um 09:09 hat Paolo Bonzini geschrieben: > Il 26/06/2013 17:05, Kevin Wolf ha scritto: > > Am 26.06.2013 um 11:24 hat Fam Zheng geschrieben: > >> > When creating image with backing file, the driver tries to calculate the > >> > relative path from created image file to backing file, but

[Qemu-devel] [Bug 1195170] Re: cpu hot-add doesn't work with upstream qemu 1.5.50

2013-06-27 Thread Paolo Bonzini
You need to specify "-smp maxcpus=N" on the command-line, for example "-smp cpus=2,maxcpus=4" will start the VM with 2 CPUs and let you add 2 more. Also, the argument to cpu-add is zero-based, so the range is 0..(maxcpus-1). ** Changed in: qemu Status: New => Invalid -- You received this

Re: [Qemu-devel] [PATCH] hw/mips: align initrd to 64KB to avoid kernel error

2013-06-27 Thread Peter Maydell
On 27 June 2013 08:35, Leon Alrae wrote: > From: James Hogan > > The Linux kernel can be configured to use 64KB pages, but it also > requires initrd to be page aligned. Therefore, to be safe, align the > initrd to 64KB using a new INITRD_PAGE_MASK rather than > TARGET_PAGE_MASK. This is kind of

Re: [Qemu-devel] [RFC PATCH 1/3] block: add target-id option to drive-backup QMP command

2013-06-27 Thread Stefan Hajnoczi
On Wed, Jun 26, 2013 at 11:59:19AM +0800, Fam Zheng wrote: > Add target-id (optional) to drive-backup command, to make the target bs > a named drive so that we can operate on it (e.g. export with NBD). > > Signed-off-by: Fam Zheng > --- > blockdev.c | 4 +++- > qapi-schema.json | 7 +--

Re: [Qemu-devel] [RFC PATCH 0/3] Point-in-time snapshot exporting with drive-backup

2013-06-27 Thread Stefan Hajnoczi
On Wed, Jun 26, 2013 at 03:31:19PM +0800, Fam Zheng wrote: > On Wed, 06/26 09:23, Paolo Bonzini wrote: > > Il 26/06/2013 05:59, Fam Zheng ha scritto: > > This leads to another observation: a sync:'none' block-backup job > > probably should never complete, and should instead go on until explicit > >

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-27 Thread Paul Durrant
> -Original Message- > From: Alex Bligh [mailto:a...@alex.org.uk] > Sent: 26 June 2013 21:00 > To: Paul Durrant; Tim (Xen.org) > Cc: Ian Campbell; Matt Wilson; xen-de...@lists.xen.org; qemu- > de...@nongnu.org; Alex Bligh > Subject: RE: [Xen-devel] [Qemu-devel] [PATCH] Add Xen platform PCI

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-27 Thread Stefan Hajnoczi
On Thu, Jun 27, 2013 at 03:11:09PM +0800, Qiao Nuohan wrote: > You asked about using ELF more efficiently. For implementing *excluding zero* > pages, *PT_LOAD* can be made use of. p_memsz and p_filesz fields of PT_LOAD > entry are used to describe memory size and the size of corresponding data in >

Re: [Qemu-devel] [RFC] qemu-img: add option -d in convert

2013-06-27 Thread Stefan Hajnoczi
On Tue, Jun 25, 2013 at 07:14:19PM +0800, Wenchao Xia wrote: > 于 2013-6-25 17:13, Stefan Hajnoczi 写道: > >On Thu, Jun 20, 2013 at 04:59:17PM +0800, Wenchao Xia wrote: > > > >If I understand correctly, you have a backing chain with internal > >snapshots: > > > >>imageA(sn0)->imageB(sn0,sn1)->imageC(s

Re: [Qemu-devel] [Bug 1195170] Re: cpu hot-add doesn't work with upstream qemu 1.5.50

2013-06-27 Thread chandrashekar shastri
Hi Bonzini, Thanks, cpu hot-plug is working. Could you please help me with cpu hot-unplug It is working. Thanks, chandrashekar On 06/27/2013 01:19 PM, Paolo Bonzini wrote: > You need to specify "-smp maxcpus=N" on the command-line, for example > "-smp cpus=2,maxcpus=4" will start the VM with 2 C

Re: [Qemu-devel] [Bug 1195170] Re: cpu hot-add doesn't work with upstream qemu 1.5.50

2013-06-27 Thread Paolo Bonzini
Il 27/06/2013 11:03, chandrashekar shastri ha scritto: > Hi Bonzini, > > Thanks, cpu hot-plug is working. > Could you please help me with cpu hot-unplug It is working. It is not implemented yet. Paolo -- You received this bug notification because you are a member of qemu- devel-ml, which is su

Re: [Qemu-devel] [Bug 1195170] Re: cpu hot-add doesn't work with upstream qemu 1.5.50

2013-06-27 Thread chandrashekar shastri
Ok. Thanks. On 06/27/2013 02:39 PM, Paolo Bonzini wrote: > Il 27/06/2013 11:03, chandrashekar shastri ha scritto: >> Hi Bonzini, >> >> Thanks, cpu hot-plug is working. >> Could you please help me with cpu hot-unplug It is working. > It is not implemented yet. > > Paolo > -- You received this bug

Re: [Qemu-devel] qemu-img create encryption

2013-06-27 Thread Daniel P. Berrange
On Wed, Jun 26, 2013 at 02:52:51PM -0400, Hamilton, Peter A. wrote: > I've been doing some work with qemu-img and encrypted qcow2 images and have > noticed that "qemu-img create" does not prompt for a password to encrypt new > images, defaulting (from the documentation I've read) to the empty strin

Re: [Qemu-devel] [PATCH] block: Make BlockJobTypes const

2013-06-27 Thread Stefan Hajnoczi
On Tue, Jun 25, 2013 at 03:15:12PM +0200, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/commit.c | 2 +- > block/mirror.c | 2 +- > block/stream.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [RFC PATCH 1/3] block: add target-id option to drive-backup QMP command

2013-06-27 Thread Fam Zheng
On Thu, 06/27 10:15, Stefan Hajnoczi wrote: > On Wed, Jun 26, 2013 at 11:59:19AM +0800, Fam Zheng wrote: > > Add target-id (optional) to drive-backup command, to make the target bs > > a named drive so that we can operate on it (e.g. export with NBD). > > > > Signed-off-by: Fam Zheng > > --- > >

Re: [Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

2013-06-27 Thread Gerd Hoffmann
Hi, >> +/* open framebuffer */ >> +if (device == NULL) { >> +device = getenv("FRAMEBUFFER"); >> +} >> +if (device == NULL) { >> +device = "/dev/fb0"; >> +} > > Maybe this is a matter of taste, but I think that having this logic at > this layer makes the API h

Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor commands to enable/disable/query

2013-06-27 Thread Gerd Hoffmann
Hi, >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -3608,3 +3608,46 @@ >> '*cpuid-input-ecx': 'int', >> 'cpuid-register': 'X86CPURegister32', >> 'features': 'int' } } >> + >> +## >> +# @framebuffer-display: > > Let me bike-shed: we're trying to

Re: [Qemu-devel] [RFC PATCH 0/3] Point-in-time snapshot exporting with drive-backup

2013-06-27 Thread Paolo Bonzini
Il 27/06/2013 10:17, Stefan Hajnoczi ha scritto: >>> > > Il 26/06/2013 05:59, Fam Zheng ha scritto: >>> > > This leads to another observation: a sync:'none' block-backup job >>> > > probably should never complete, and should instead go on until explicit >>> > > cancellation. This is because the jo

Re: [Qemu-devel] [PATCH v4] Add timestamp to error message

2013-06-27 Thread Laszlo Ersek
comments below On 06/27/13 04:08, Seiji Aguchi wrote: > [Issue] > When we offer a customer support service and a problem happens > in a customer's system, we try to understand the problem by > comparing what the customer reports with message logs of the > customer's system. > > In this case, we o

[Qemu-devel] [PULL 00/12] migration queue

2013-06-27 Thread Juan Quintela
Hi Anthony, please pull. - improve error message (Alon) - Make zero pages to work again (Peter Lieven) - First 10 patches of RDMA support Thanks, Juan. The following changes since commit 3e5087329489e0beceecf3426f1216619821937f: Merge remote-tracking branch 'pmaydell/arm-devs.for-upstrea

Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer.

2013-06-27 Thread Peter Maydell
On 26 June 2013 23:32, Jean-Christophe DUBOIS wrote: > On 06/27/2013 12:15 AM, Peter Maydell wrote: >> Just leave the memory region and vmstate names as they >> were before your patches. > OK, I will. > > Now, please notice that the EPIT timer has been changed recently (on main > line) with the e

Re: [Qemu-devel] [RFC PATCH 1/3] block: add target-id option to drive-backup QMP command

2013-06-27 Thread Paolo Bonzini
Il 27/06/2013 11:41, Fam Zheng ha scritto: > On Thu, 06/27 10:15, Stefan Hajnoczi wrote: >> On Wed, Jun 26, 2013 at 11:59:19AM +0800, Fam Zheng wrote: >>> Add target-id (optional) to drive-backup command, to make the target bs >>> a named drive so that we can operate on it (e.g. export with NBD). >

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-27 Thread Paul Durrant
> -Original Message- > From: qemu-devel-bounces+paul.durrant=citrix@nongnu.org > [mailto:qemu-devel-bounces+paul.durrant=citrix@nongnu.org] On > Behalf Of Paul Durrant > Sent: 27 June 2013 09:29 > To: Alex Bligh; Tim (Xen.org) > Cc: qemu-devel@nongnu.org; Ian Campbell; Matt Wilson;

[Qemu-devel] [PATCH] Avoid use of QOM type name macros in VMStateDescriptions

2013-06-27 Thread Peter Maydell
The name field in a VMStateDescription is part of the migration state versioning, so changing it will break migration. It's therefore a bad idea to use a QOM typename macro to initialize it, because in general we're free to rename QOM types as part of code refactoring and cleanup. For the handful

Re: [Qemu-devel] [RFC PATCH 1/3] block: add target-id option to drive-backup QMP command

2013-06-27 Thread Fam Zheng
On Thu, 06/27 12:57, Paolo Bonzini wrote: > Il 27/06/2013 11:41, Fam Zheng ha scritto: > > On Thu, 06/27 10:15, Stefan Hajnoczi wrote: > >> On Wed, Jun 26, 2013 at 11:59:19AM +0800, Fam Zheng wrote: > >>> Add target-id (optional) to drive-backup command, to make the target bs > >>> a named drive so

Re: [Qemu-devel] [RFC PATCH 1/3] block: add target-id option to drive-backup QMP command

2013-06-27 Thread Paolo Bonzini
Il 27/06/2013 13:37, Fam Zheng ha scritto: >>> > > >>> > > Yes, this makes me realize that ref count it not a solution to retire >>> > > bs->in_use, because we can't tell if drive-del or block-resize is safe >>> > > with only reference number. But I can't think of two situations to deny >>> > > di

Re: [Qemu-devel] [PATCH] Avoid use of QOM type name macros in VMStateDescriptions

2013-06-27 Thread Gerd Hoffmann
On 06/27/13 13:03, Peter Maydell wrote: > The one I didn't touch was hw/usb/host-linux.c, since that changes > the QOM typename and the VMStateDescription name depending on > whether QEMU was built with CONFIG_USB_LIBUSB defined or not. > That seems a bit fishy to me but I've left it alone. vmstat

Re: [Qemu-devel] [PATCH 02/17] pseries: rework XICS

2013-06-27 Thread David Gibson
On Thu, Jun 27, 2013 at 04:45:45PM +1000, Alexey Kardashevskiy wrote: > Currently XICS interrupt controller is not a QEMU device. As we are going > to support in-kernel emulated XICS which is a part of KVM, it make > sense not to extend the existing XICS and have multiple KVM stub functions > but t

Re: [Qemu-devel] qemu-img create encryption

2013-06-27 Thread Hamilton, Peter A.
> It also means you can't change the password of an existing image - you have > to create a new image with a new password & re-encrypt the data. Following up on this point, since "qemu-img create" cannot be used to specify a password, is "qemu-img convert" the only command that can be used to pr

Re: [Qemu-devel] [PATCH 02/17] pseries: rework XICS

2013-06-27 Thread Alexey Kardashevskiy
On 06/27/2013 09:47 PM, David Gibson wrote: > On Thu, Jun 27, 2013 at 04:45:45PM +1000, Alexey Kardashevskiy wrote: >> Currently XICS interrupt controller is not a QEMU device. As we are going >> to support in-kernel emulated XICS which is a part of KVM, it make >> sense not to extend the existing

Re: [Qemu-devel] [PATCH v4 00/17] aio: drop io_flush()

2013-06-27 Thread Stefan Hajnoczi
On Fri, Jun 14, 2013 at 1:43 PM, Stefan Hajnoczi wrote: > v4: > * Ensure pending BHs are processed in bdrv_drain_all() [bonzini] > > v3: > * I forgot about this series, time to push it again! > * Rebase onto qemu.git/master > * Drop now-unused AioFlushHandler typedef [bonzini] > > This series

Re: [Qemu-devel] [RFC] qemu-img: add option -d in convert

2013-06-27 Thread Wenchao Xia
于 2013-6-27 17:01, Stefan Hajnoczi 写道: On Tue, Jun 25, 2013 at 07:14:19PM +0800, Wenchao Xia wrote: 于 2013-6-25 17:13, Stefan Hajnoczi 写道: On Thu, Jun 20, 2013 at 04:59:17PM +0800, Wenchao Xia wrote: If I understand correctly, you have a backing chain with internal snapshots: imageA(sn0)->im

Re: [Qemu-devel] [RFC] qemu-img: add option -d in convert

2013-06-27 Thread Wenchao Xia
于 2013-6-27 17:01, Stefan Hajnoczi 写道: On Tue, Jun 25, 2013 at 07:14:19PM +0800, Wenchao Xia wrote: 于 2013-6-25 17:13, Stefan Hajnoczi 写道: On Thu, Jun 20, 2013 at 04:59:17PM +0800, Wenchao Xia wrote: If I understand correctly, you have a backing chain with internal snapshots: imageA(sn0)->im

Re: [Qemu-devel] qemu-img create encryption

2013-06-27 Thread Daniel P. Berrange
On Thu, Jun 27, 2013 at 08:05:38AM -0400, Hamilton, Peter A. wrote: > > It also means you can't change the password of an existing image - you have > > to create a new image with a new password & re-encrypt the data. > > Following up on this point, since "qemu-img create" cannot be used to specif

[Qemu-devel] [PATCH 6/8] arm/boot: Allow boards to modify the FDT blob

2013-06-27 Thread Peter Maydell
Add a callback hook in arm_boot_info to allow board models to modify the device tree blob if they need to. (The major expected use case is to add virtio-mmio nodes for virtio-mmio transports that exist in QEMU but not in the hardware.) Signed-off-by: Peter Maydell --- hw/arm/boot.c|5

[Qemu-devel] Dumping USB packets

2013-06-27 Thread Jordan Bouyat
Hi ! I recently grab a dummy usb driver(https://github.com/pkt/qemu-dummyusb/commit/c5f61398dcebc9831f4ca409553ae85b438f27a2) and modified it to behave like an HID mouse with the help of (hw/usb/dev-hid.c). It works, but my goal is to dump the whole USB packet in order to modify it or replaying it

[Qemu-devel] [PATCHv2 03/11] iscsi: add bdrv_co_is_allocated

2013-06-27 Thread Peter Lieven
this patch adds a coroutine for .bdrv_co_is_allocated as well as a generic framework that can be used to build coroutines in block/iscsi. Signed-off-by: Peter Lieven --- block/iscsi.c | 123 + 1 file changed, 123 insertions(+) diff --git

[Qemu-devel] [PATCHv2 00/11] iscsi/qemu-img/block-migration enhancements

2013-06-27 Thread Peter Lieven
this series adds logical block provisioning functions to the iscsi layer. it adds the ability to write sparse images to iscsi targets which support UNMAP and LBPRZ via qemu-img. additional block-migration is enhanced to support an encoding for zero blocks on the network and efficiently writing thos

[Qemu-devel] [PATCHv2 05/11] block: add bdrv_write_zeroes()

2013-06-27 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block.c | 27 +++ include/block/block.h |2 ++ 2 files changed, 21 insertions(+), 8 deletions(-) diff --git a/block.c b/block.c index 8e77d46..08b7325 100644 --- a/block.c +++ b/block.c @@ -2163,6 +2163,7 @@ typedef stru

[Qemu-devel] [PATCHv2 06/11] block/raw: add bdrv_co_write_zeroes

2013-06-27 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/raw.c |8 1 file changed, 8 insertions(+) diff --git a/block/raw.c b/block/raw.c index ce10422..8c81de9 100644 --- a/block/raw.c +++ b/block/raw.c @@ -42,6 +42,13 @@ static int coroutine_fn raw_co_is_allocated(BlockDriverState *bs, return

[Qemu-devel] [PATCHv2 10/11] iscsi: ignore aio_discard if unsupported

2013-06-27 Thread Peter Lieven
if the target does not support UNMAP or the request is too big silently ignore the discard request. Signed-off-by: Peter Lieven --- block/iscsi.c |8 1 file changed, 8 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index e9ecfce..0567b46 100644 --- a/block/iscsi.c +++ b/b

[Qemu-devel] [PATCHv2 02/11] iscsi: read unmap info from block limits vpd page

2013-06-27 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 80 - 1 file changed, 56 insertions(+), 24 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index a38a1bf..2e2455d 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -54,6 +54,8 @@ typ

[Qemu-devel] [PATCHv2 09/11] iscsi: factor out sector conversions

2013-06-27 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 621ca40..e9ecfce 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -293,6 +293,11 @@ static int64_t sector_qemu2lun(int64_t s

[Qemu-devel] [PATCHv2 01/11] iscsi: add logical block provisioning information to iscsilun

2013-06-27 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini --- block/iscsi.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 0bbf0b1..a38a1bf 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -49,6 +49,11 @@ t

[Qemu-devel] [PATCHv2 04/11] iscsi: add bdrv_co_write_zeroes

2013-06-27 Thread Peter Lieven
write zeroes is emulated by unmap if the target supports unmapping an unmapped blocks read as zero. this emulation is only done if the device was opened with BDRV_O_UNMAP and the request can be handled within a single request. a failback to writev is performed otherwise. Signed-off-by: Peter Lieve

Re: [Qemu-devel] [PATCH v4 01/17] block: stop relying on io_flush() in bdrv_drain_all()

2013-06-27 Thread Paolo Bonzini
Il 14/06/2013 13:43, Stefan Hajnoczi ha scritto: > If a block driver has no file descriptors to monitor but there are still > active requests, it can return 1 from .io_flush(). This is used to spin > during synchronous I/O. > > Stop relying on .io_flush() and instead check > QLIST_EMPTY(&bs->trac

Re: [Qemu-devel] [PATCH v4 03/17] tests: adjust test-aio to new aio_poll() semantics

2013-06-27 Thread Paolo Bonzini
Il 14/06/2013 13:43, Stefan Hajnoczi ha scritto: > aio_poll(ctx, true) will soon block if any fd handlers have been set. > Previously it would only block when .io_flush() returned true. > > This means that callers must check their wait condition *before* > aio_poll() to avoid deadlock. > > Signed

[Qemu-devel] [PATCHv2 11/11] iscsi: assert that sectors are aligned to LUN blocksize

2013-06-27 Thread Peter Lieven
if the blocksize of an iSCSI LUN is bigger than the BDRV_SECTOR_SIZE it is possible that sector_num or nb_sectors are not correctly alligned. to avoid corruption we fail requests which are misaligned. Signed-off-by: Peter Lieven --- block/iscsi.c | 27 +++ 1 file chang

[Qemu-devel] [PATCHv2 08/11] block-migration: efficiently encode zero blocks

2013-06-27 Thread Peter Lieven
this patch adds a efficient encoding for zero blocks by adding a new flag indiciating a block is completly zero. additionally bdrv_write_zeros() is used at the destination to efficiently write these zeroes. if the driver supports it this avoids blindly allocating all sectors consumed by zero block

Re: [Qemu-devel] [PATCH v4 02/17] dataplane/virtio-blk: check exit conditions before aio_poll()

2013-06-27 Thread Paolo Bonzini
Il 14/06/2013 13:43, Stefan Hajnoczi ha scritto: > Check exit conditions before entering blocking aio_poll(). This is > mainly for consistency since it's unlikely that we are stopping in the > first event loop iteration. > > Signed-off-by: Stefan Hajnoczi > --- > hw/block/dataplane/virtio-blk.c

Re: [Qemu-devel] [PATCH v4 05/17] aio: stop using .io_flush()

2013-06-27 Thread Paolo Bonzini
Il 14/06/2013 13:43, Stefan Hajnoczi ha scritto: > Now that aio_poll() users check their termination condition themselves, > it is no longer necessary to call .io_flush() handlers. > > The behavior of aio_poll() changes as follows: > > 1. .io_flush() is no longer invoked and file descriptors are

Re: [Qemu-devel] [PATCH v4 04/17] tests: adjust test-thread-pool to new aio_poll() semantics

2013-06-27 Thread Paolo Bonzini
Il 14/06/2013 13:43, Stefan Hajnoczi ha scritto: > > -/* Wait until all aio and bh activity has finished */ > -static void qemu_aio_wait_all(void) > -{ > -while (aio_poll(ctx, true)) { > -/* Do nothing */ > -} > -} > - > static void test_submit(void) > { > WorkerTestData da

Re: [Qemu-devel] [PATCH v4 16/17] tests: drop event_active_cb()

2013-06-27 Thread Paolo Bonzini
Il 14/06/2013 13:44, Stefan Hajnoczi ha scritto: > The .io_flush() handler no longer exists and has no users. Drop the > io_flush argument to aio_set_fd_handler() and related functions. Wrong commit message, but otherwise Reviewed-by: Paolo Bonzini > Signed-off-by: Stefan Hajnoczi > --- > t

Re: [Qemu-devel] [PATCH v4 00/17] aio: drop io_flush()

2013-06-27 Thread Paolo Bonzini
Il 14/06/2013 13:43, Stefan Hajnoczi ha scritto: > v4: > * Ensure pending BHs are processed in bdrv_drain_all() [bonzini] > > v3: > * I forgot about this series, time to push it again! > * Rebase onto qemu.git/master > * Drop now-unused AioFlushHandler typedef [bonzini] > > This series gets r

Re: [Qemu-devel] [PATCH v4 17/17] aio: drop io_flush argument

2013-06-27 Thread Paolo Bonzini
Il 14/06/2013 13:44, Stefan Hajnoczi ha scritto: > The .io_flush() handler no longer exists and has no users. Drop the > io_flush argument to aio_set_fd_handler() and related functions. > > The AioFlushEventNotifierHandler and AioFlushHandler typedefs are no > longer used and are dropped too. >

Re: [Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

2013-06-27 Thread Luiz Capitulino
On Thu, 27 Jun 2013 11:58:57 +0200 Gerd Hoffmann wrote: > Hi, > > >> +/* open framebuffer */ > >> +if (device == NULL) { > >> +device = getenv("FRAMEBUFFER"); > >> +} > >> +if (device == NULL) { > >> +device = "/dev/fb0"; > >> +} > > > > Maybe this is a mat

[Qemu-devel] [PATCH 3/8] virtio: Add support for guest setting of queue size

2013-06-27 Thread Peter Maydell
The MMIO virtio transport spec allows the guest to tell the host how large the queue size is. Add virtio_queue_set_num() function which implements this in the QEMU common virtio support code. Signed-off-by: Peter Maydell --- hw/virtio/virtio.c |6 ++ include/hw/virtio/virtio.h |

[Qemu-devel] [PATCH 5/8] virtio: Implement MMIO based virtio transport

2013-06-27 Thread Peter Maydell
Add support for the generic MMIO based virtio transport. This patch includes some fixes for bugs spotted by Ying-Shiuan Pan . Signed-off-by: Peter Maydell [Fred changes: updated to new virtio-bus mechanisms] Signed-off-by: KONRAD Frederic [PMM changes: * fixed trivial makefile conflict * remo

[Qemu-devel] [PATCH 7/8] vexpress: Make VEDBoardInfo extend arm_boot_info

2013-06-27 Thread Peter Maydell
Make the VEDBoardInfo struct extend arm_boot_info; this will allow us to get at the VEDBoardInfo information inside callbacks from arm/boot code. Signed-off-by: Peter Maydell --- hw/arm/vexpress.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --g

[Qemu-devel] [PATCH 4/8] virtio: Support transports which can specify the vring alignment

2013-06-27 Thread Peter Maydell
Support virtio transports which can specify the vring alignment (ie where the guest communicates this to the host) by providing a new virtio_queue_set_align() function. (The default alignment remains as before.) Transports which wish to make use of this must set the has_variable_vring_alignment fi

[Qemu-devel] [PATCH 1/8] device_tree: Add qemu_devtree_setprop_sized_cells() utility functions

2013-06-27 Thread Peter Maydell
We already have a qemu_devtree_setprop_cells() which sets a dtb property to an array of cells whose values are specified by varargs. However for the fairly common case of setting a property to a list of addresses or of address,size pairs the number of cells used by each element in the list depends

[Qemu-devel] [PATCH 8/8] vexpress: Add virtio-mmio transports

2013-06-27 Thread Peter Maydell
Add some virtio-mmio transports to the vexpress board model, together with a modify_dtb hook which adds them to the device tree so that the kernel will probe for them. We put them in a reserved area of the address map. Signed-off-by: Peter Maydell --- hw/arm/vexpress.c | 99 +++

[Qemu-devel] [PATCH 0/8] Add virtio-mmio and use it in vexpress

2013-06-27 Thread Peter Maydell
This patch series adds an implementation of the virtio-mmio transport, and uses it in the vexpress-a9 and vexpress-a15 board models. The basic idea is that the board instantiates some transports, the user can create backends which automatically plug into them (via -device virtio-blk-backend and th

Re: [Qemu-devel] [PATCH v4 03/17] tests: adjust test-aio to new aio_poll() semantics

2013-06-27 Thread Paolo Bonzini
Il 14/06/2013 13:43, Stefan Hajnoczi ha scritto: > aio_poll(ctx, true) will soon block if any fd handlers have been set. > Previously it would only block when .io_flush() returned true. > > This means that callers must check their wait condition *before* > aio_poll() to avoid deadlock. > > Signed

[Qemu-devel] [PATCH 1/1] qemu-char: Fix ID reuse after chardev-remove for qapi-based init

2013-06-27 Thread Markus Armbruster
Commit 2c5f488 introduced qapi-based character device initialization as a new code path in qemu_chr_new_from_opts(). Unfortunately, it failed to store parameter opts in the new chardev. Therefore, qemu_chr_delete() doesn't delete it. Even though the device is gone, its options linger, and any at

Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor commands to enable/disable/query

2013-06-27 Thread Luiz Capitulino
On Thu, 27 Jun 2013 12:05:33 +0200 Gerd Hoffmann wrote: > Hi, > > >> --- a/qapi-schema.json > >> +++ b/qapi-schema.json > >> @@ -3608,3 +3608,46 @@ > >> '*cpuid-input-ecx': 'int', > >> 'cpuid-register': 'X86CPURegister32', > >> 'features': 'int' } } > >>

[Qemu-devel] [PATCH] tests: Multiboot mmap test case

2013-06-27 Thread Kevin Wolf
This adds a test case for Multiboot memory map in the tests/multiboot directory, where future i386 test kernels can be dropped. Because this requires an x86 build host and an installed 32 bit libgcc, the test is not part of a regular 'make check'. The reference output for the test is verified agai

Re: [Qemu-devel] [PATCH 1/1] qemu-char: Fix ID reuse after chardev-remove for qapi-based init

2013-06-27 Thread Gerd Hoffmann
On 06/27/13 15:25, Markus Armbruster wrote: > Commit 2c5f488 introduced qapi-based character device initialization > as a new code path in qemu_chr_new_from_opts(). Unfortunately, it > failed to store parameter opts in the new chardev. Therefore, > qemu_chr_delete() doesn't delete it. Even thoug

[Qemu-devel] [PATCHv2 07/11] iscsi: let bdrv_create conditionally zero out the device

2013-06-27 Thread Peter Lieven
if the device supports unmapping and unmapped blocks read as zero ensure that the whole device is unmapped and report .has_zero_init = 1 in this case to speed up qemu-img convert. Signed-off-by: Peter Lieven --- block/iscsi.c | 72 - 1 fi

Re: [Qemu-devel] [PATCH v4 01/17] block: stop relying on io_flush() in bdrv_drain_all()

2013-06-27 Thread Stefan Hajnoczi
On Thu, Jun 27, 2013 at 03:13:19PM +0200, Paolo Bonzini wrote: > Il 14/06/2013 13:43, Stefan Hajnoczi ha scritto: > > If a block driver has no file descriptors to monitor but there are still > > active requests, it can return 1 from .io_flush(). This is used to spin > > during synchronous I/O. > >

[Qemu-devel] [PATCH] block: change default of .has_zero_init to 0

2013-06-27 Thread Peter Lieven
.has_zero_init defaults to 1 for all formats and protocols. this is a dangerous default since this means that all new added drivers need to manually overwrite it to 0 if they do not ensure that a device is zero initialized after bdrv_create(). if a driver needs to explicitly set this value to 1 i

Re: [Qemu-devel] x86-64 apic panic on shutdown on 1.4.93.

2013-06-27 Thread Luiz Capitulino
On Wed, 26 Jun 2013 00:52:31 -0500 Rob Landley wrote: > I intermittently get this from current kernels running under currentish > qemu-git. Look familiar to anybody? Which kernel do you run in the host? Is the guest doing anything special? > > reboot: machine restart > general protection fau

[Qemu-devel] [PATCH 2/8] arm/boot: Use qemu_devtree_setprop_sized_cells()

2013-06-27 Thread Peter Maydell
Replace the opencoded assembly of the reg property array for the /memory node with a call to qemu_devtree_setprop_sized_cells(). Signed-off-by: Peter Maydell --- hw/arm/boot.c | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/hw/arm/boot.c b/hw/a

Re: [Qemu-devel] [RFC PATCH 0/3] Point-in-time snapshot exporting with drive-backup

2013-06-27 Thread Stefan Hajnoczi
On Thu, Jun 27, 2013 at 12:06:44PM +0200, Paolo Bonzini wrote: > Il 27/06/2013 10:17, Stefan Hajnoczi ha scritto: > >>> > > Il 26/06/2013 05:59, Fam Zheng ha scritto: > >>> > > This leads to another observation: a sync:'none' block-backup job > >>> > > probably should never complete, and should ins

[Qemu-devel] [PATCH] sd/pl181.c: Avoid undefined shift behaviour in RWORD macro

2013-06-27 Thread Peter Maydell
Add a cast to avoid potentially shifting into the sign bit of a signed value, which is undefined behaviour in C. (Detected with clang's -fsanitize=undefined.) Signed-off-by: Peter Maydell --- Not the only problem clang detects by a long shot. I don't know if we even want to try to fix the warnin

[Qemu-devel] [PATCH 3/4] qemu-char: Register ring buffer driver with correct name "ringbuf"

2013-06-27 Thread Markus Armbruster
The driver is new in 1.4, with the documented name "ringbuf". However, it's actual name is the completely undocumented "memory". Screwed up in commit 3949e59. Fix code to match documentation. Keep the undocumented name working as an alias for compatibility. Cc: qemu-sta...@nongnu.org Signed-off-

[Qemu-devel] [PATCH 1/4] qemu-char: Fix ringbuf option size

2013-06-27 Thread Markus Armbruster
Any attempt to use it trips an "opt->desc->type == QEMU_OPT_NUMBER" assertion. Broken in commit 1da48c65. Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster --- qemu-char.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 63972ae..63a9

[Qemu-devel] [PATCH 2/4] Revert "chardev: Make the name of memory device consistent"

2013-06-27 Thread Markus Armbruster
This reverts commit 6a85e60cb994bd95d1537aafbff65816f3de4637. Commit 51767e7 "qemu-char: Add new char backend CirMemCharDriver" introduced a memory ring buffer character device driver named "memory". Commit 3949e59 "qemu-char: Saner naming of memchar stuff & doc fixes" changed the driver name to

[Qemu-devel] [PATCH 4/4] qapi: Rename ChardevBackend member "memory" to "ringbuf"

2013-06-27 Thread Markus Armbruster
Commit 1da48c6 called the new member "memory" after commit 3949e59 standardized "ringbuf". Rename for consistency. However, member name "memory" is visible in QMP since 1.5. It's undocumented just like the driver name. Keep it working anyway. Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Ar

[Qemu-devel] [PATCH 0/4] qemu-char: ringbuf fixes

2013-06-27 Thread Markus Armbruster
The first patch is a straightforward bug fix. The rest fix code to match documentation. The patches take pains to preserve command-line, HMP and QMP bug-compatibility. I'm not sure that's actually needed, because: * All: the documented way to use the driver never worked in any released versio

[Qemu-devel] PVFS2 Block Driver Support

2013-06-27 Thread Timothy Scott
I am working on adding block driver support for PVFS2 that will allow images stored on PVFS2 systems to bypass the kernel module and hopefully improve performance significantly. I have been modeling my changes off of the GlusterFS block driver implementation. *Can you please advise on a couple of

Re: [Qemu-devel] Monitoring Screen Activity in QEMU/KVM

2013-06-27 Thread Claudio Fontana
Shehbaz Jaffer wrote: > I want to determine the amount of screen activity taking place on VGA > monitor/ Screen for different applications (eg. playing vlc video, normal > typing.) > > When I do not start the X server, I can easily determine the screen activity > by counting the number of page

Re: [Qemu-devel] PVFS2 Block Driver Support

2013-06-27 Thread Stefan Hajnoczi
On Thu, Jun 27, 2013 at 4:25 PM, Timothy Scott wrote: > I am working on adding block driver support for PVFS2 that will allow images > stored on PVFS2 systems to bypass the kernel module and hopefully improve > performance significantly. What performance bottlenecks are you seeing in the kernel w

Re: [Qemu-devel] [PATCH] block: change default of .has_zero_init to 0

2013-06-27 Thread Richard W.M. Jones
On Thu, Jun 27, 2013 at 03:52:34PM +0200, Peter Lieven wrote: > +/* save default */ A minor thing, but s/save/safe/ :-) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or ove

Re: [Qemu-devel] PVFS2 Block Driver Support

2013-06-27 Thread Stefan Hajnoczi
On Thu, Jun 27, 2013 at 4:43 PM, Stefan Hajnoczi wrote: > On Thu, Jun 27, 2013 at 4:25 PM, Timothy Scott wrote: >> - Is there currently a testing suite/procedure for verifying new block >> drivers? > > There is a test suite in tests/qemu-iotests/. You will need to add > support for PVFS2, see

Re: [Qemu-devel] [PATCH v4 06/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-06-27 Thread Laszlo Ersek
On 06/26/13 16:32, Laszlo Ersek wrote: > On 06/25/13 18:03, Laszlo Ersek wrote: >> On 06/06/13 17:06, Tomoki Sekiyama wrote: >>> +/* Unregister this module from COM+ Applications Catalog */ >>> +STDAPI COMUnregister(void) >>> +{ >>> +HRESULT hr; >>> +IUnknown *pUnknown = NULL; >>> +ICO

Re: [Qemu-devel] [PATCH] block: change default of .has_zero_init to 0

2013-06-27 Thread Eric Blake
On 06/27/2013 07:52 AM, Peter Lieven wrote: > .has_zero_init defaults to 1 for all formats and protocols. > > this is a dangerous default since this means that all > new added drivers need to manually overwrite it to 0 if > they do not ensure that a device is zero initialized > after bdrv_create()

[Qemu-devel] [PATCH] target-arm: avoid undefined behaviour when writing TTBCR

2013-06-27 Thread Peter Maydell
LPAE CPUs have more potentially valid bits in the TTBCR, and so the simple masking out of invalid bits is no longer sufficient to obtain the base address width field of the register, which is what we use to precalculate c2_mask and c2_base_mask. Explicitly extract the relevant register field rathe

  1   2   >