[Qemu-devel] [RFT PATCH v1 19/30] pci-bridge/*: substitute ->qdev casts with DEVICE()

2013-06-11 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/pci-bridge/i82801b11.c | 2 +- hw/pci-bridge/ioh3420.c| 2 +- hw/pci-bridge/xio3130_downstream.c | 2 +- hw/pci-bridge/xio3130_upstream.c | 2 +- hw/pci/pci_bridge.c| 7 --- 5 files chang

[Qemu-devel] [RFT PATCH v1 20/30] misc/vfio: substitute ->qdev casts with DEVICE()

2013-06-11 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/misc/vfio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c index 693a9ff..aa75dc2 100644 --- a/hw/misc/vfio.c +++ b/hw/misc/vfio.c @@ -3072,7 +3072,7 @@ static int vfio_init

[Qemu-devel] [RFT PATCH v1 21/30] net/eepro100: substitute ->qdev casts with DEVICE()

2013-06-11 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/net/eepro100.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c index dc99ea6..f34b5dc 100644 --- a/hw/net/eepro100.c +++ b/hw/net/eepro100.c @@ -1842,13 +184

[Qemu-devel] [RFT PATCH v1 22/30] net/ne2000: substitute ->qdev casts with DEVICE()

2013-06-11 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/net/ne2000.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c index 33ee03e..70a7991 100644 --- a/hw/net/ne2000.c +++ b/hw/net/ne2000.c @@ -722,6 +722,8 @@ static NetClien

[Qemu-devel] [RFT PATCH v1 23/30] usb/*: substitute ->qdev casts with DEVICE()

2013-06-11 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/usb/hcd-ehci-pci.c | 13 - hw/usb/hcd-ohci.c | 2 +- hw/usb/hcd-uhci.c | 2 +- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/usb/hcd-ehci-pci.c b/hw/usb/hcd-ehci-pci.c index 0eb7826..c772

[Qemu-devel] [RFT PATCH v1 24/30] watchdog/wdt_i6300esb: substitute ->qdev casts with DEVICE()

2013-06-11 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/watchdog/wdt_i6300esb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c index 1407fba..df39d9c 100644 --- a/hw/watchdog/wdt_i6300esb.c +++ b/hw/watchdog/w

[Qemu-devel] [RFT PATCH v1 25/30] scsi/vmw_pvscsi: substitute ->qdev casts with DEVICE()

2013-06-11 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/scsi/vmw_pvscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index 48d12f4..e9cf15f 100644 --- a/hw/scsi/vmw_pvscsi.c +++ b/hw/scsi/vmw_pvscsi.c @@ -1088,7 +1088

[Qemu-devel] [RFT PATCH v1 26/30] i2c/smbus_ich9: substitute ->qdev casts with DEVICE()

2013-06-11 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/i2c/smbus_ich9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i2c/smbus_ich9.c b/hw/i2c/smbus_ich9.c index ca22978..f87343f 100644 --- a/hw/i2c/smbus_ich9.c +++ b/hw/i2c/smbus_ich9.c @@ -82,7 +82,7 @@ sta

[Qemu-devel] [RFT PATCH v1 27/30] ide/cmd646: substitute ->qdev casts with DEVICE()

2013-06-11 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/ide/cmd646.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index a73eb9a..9544c1f 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -281,7 +281,7 @@ static int pc

[Qemu-devel] [RFT PATCH v1 28/30] ide/via: substitute ->qdev casts with DEVICE()

2013-06-11 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/ide/via.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ide/via.c b/hw/ide/via.c index 5fe053c..b81e1fe 100644 --- a/hw/ide/via.c +++ b/hw/ide/via.c @@ -158,7 +158,7 @@ static void vt82c686b_init_ports

[Qemu-devel] [RFT PATCH v1 29/30] pci-host/*: substitute ->qdev casts with DEVICE()

2013-06-11 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/pci-bridge/dec.c | 2 +- hw/pci-host/apb.c | 4 ++-- hw/pci-host/q35.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/pci-bridge/dec.c b/hw/pci-bridge/dec.c index cff458b..1e5611d 100644 --- a/hw/p

[Qemu-devel] [RFT PATCH v1 30/30] i386/*: substitute ->qdev casts with DEVICE()

2013-06-11 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/i386/kvm/pci-assign.c | 21 - hw/i386/pc.c | 4 ++-- hw/i386/pc_piix.c| 4 ++-- hw/i386/pc_q35.c | 4 ++-- 4 files changed, 18 insertions(+), 15 deletions(-) diff --git a/hw/i386

Re: [Qemu-devel] [RFT PATCH v1 12/30] virtio/virtio-pci: QOM casting sweep

2013-06-11 Thread Frederic Konrad
Hi, On 11/06/2013 08:49, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite Use standard QOM cast macro. Remove usages of container_of() and direct -> style upcasting. Signed-off-by: Peter Crosthwaite [...] static inline VirtIOPCIProxy *to_virtio_pci_proxy(DeviceState *d) { -

Re: [Qemu-devel] [PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-11 Thread Michael S. Tsirkin
On Tue, Jun 11, 2013 at 08:43:51AM +0200, Frederic Konrad wrote: > On 10/06/2013 19:00, Michael S. Tsirkin wrote: > >On Mon, Jun 10, 2013 at 11:53:04AM +0200, fred.kon...@greensocs.com wrote: > >>From: KONRAD Frederic > >> > >>This fix a bug with scsi hotplug on virtio-scsi-pci: > >> > >>As virtio

Re: [Qemu-devel] [PATCH 2/2] Add monitor command mem-nodes

2013-06-11 Thread Wanlong Gao
On 06/05/2013 09:46 PM, Eduardo Habkost wrote: > On Wed, Jun 05, 2013 at 11:58:25AM +0800, Wanlong Gao wrote: >> Add monitor command mem-nodes to show the huge mapped >> memory nodes locations. >> > > This is for machine consumption, so we need a QMP command. > >> (qemu) info mem-nodes >> /proc/1

Re: [Qemu-devel] [PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-11 Thread Frederic Konrad
On 11/06/2013 09:21, Michael S. Tsirkin wrote: On Tue, Jun 11, 2013 at 08:43:51AM +0200, Frederic Konrad wrote: On 10/06/2013 19:00, Michael S. Tsirkin wrote: On Mon, Jun 10, 2013 at 11:53:04AM +0200, fred.kon...@greensocs.com wrote: From: KONRAD Frederic This fix a bug with scsi hotplug on

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-11 Thread Michael S. Tsirkin
On Mon, Jun 10, 2013 at 08:03:46PM -0500, Anthony Liguori wrote: > >> It is not "supported" by QEMU. > > > > No, but I've always thought that QEMU was happy to have alternative > > firmware projects. > > We are and we're happy to accept patches to enable things even if its > proprietary. But that

Re: [Qemu-devel] [PATCH] ide-test: fix failure for test_flush

2013-06-11 Thread Kevin Wolf
Am 10.06.2013 um 20:23 hat Michael Roth geschrieben: > bd07684aacfb61668ae2c25b7dd00b64f3d7c7f3 added a test to ensure BSY > flag is set when a flush request is in flight. It does this by setting > a blkdebug breakpoint on flush_to_os before issuing a CMD_FLUSH_CACHE. > It then resumes CMD_FLUSH_CA

Re: [Qemu-devel] [PATCH] curl: refuse to open URL from HTTP server without range support

2013-06-11 Thread Stefan Hajnoczi
On Tue, Jun 11, 2013 at 11:15:15AM +0800, Fam Zheng wrote: > On Mon, Jun 10, 2013 at 5:21 PM, Stefan Hajnoczi wrote: > > On Sun, Jun 09, 2013 at 10:34:54AM +0800, Fam Zheng wrote: > >> @@ -110,14 +111,14 @@ static int curl_sock_cb(CURL *curl, curl_socket_t > >> fd, int action, > >> return 0;

Re: [Qemu-devel] [PATCH qom-cpu 31/59] monitor: Simplify do_info_numa()

2013-06-11 Thread Markus Armbruster
Andreas Färber writes: > Am 10.06.2013 09:20, schrieb Markus Armbruster: >> Andreas Färber writes: >> >>> Use new qemu_for_each_cpu(). >>> >>> Signed-off-by: Andreas Färber >>> --- >>> monitor.c | 27 +++ >>> 1 file changed, 19 insertions(+), 8 deletions(-) >>> >>> dif

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-11 Thread Gerd Hoffmann
Hi, >>> Portability: >>> - Non x86 (or any Linux) platforms don't need any of this code. >>> They can keep happily using SHPC the way >>> they always did. >> >> Hmm. Is is possible to write a SHPC driver in AML? I think it would be >> alot better to have one guest/host interfac

Re: [Qemu-devel] [PATCH v2 0/9] QMP/HMP: add error reason to open failures

2013-06-11 Thread Stefan Hajnoczi
On Mon, Jun 10, 2013 at 01:02:19PM -0400, Luiz Capitulino wrote: > I was surprised to find out that we still have old users of > QERR_OPEN_FILE_FAILED that print errors like: > > (qemu) dump-guest-memory -p /lkmads/foo > Could not open '/lkmads/foo' > (qemu) > > This series converts all those use

Re: [Qemu-devel] [PATCH v2 0/9] QMP/HMP: add error reason to open failures

2013-06-11 Thread Stefan Hajnoczi
On Mon, Jun 10, 2013 at 01:02:19PM -0400, Luiz Capitulino wrote: I should have qualified by Reviewed-by: with "reviewed block layer changes". Stefan

Re: [Qemu-devel] [PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-11 Thread Michael S. Tsirkin
On Tue, Jun 11, 2013 at 09:32:05AM +0200, Frederic Konrad wrote: > On 11/06/2013 09:21, Michael S. Tsirkin wrote: > >On Tue, Jun 11, 2013 at 08:43:51AM +0200, Frederic Konrad wrote: > >>On 10/06/2013 19:00, Michael S. Tsirkin wrote: > >>>On Mon, Jun 10, 2013 at 11:53:04AM +0200, fred.kon...@greenso

Re: [Qemu-devel] [PATCH v2] curl: Don't set curl options on the handle just before it's going to be deleted.

2013-06-11 Thread Stefan Hajnoczi
On Mon, Jun 10, 2013 at 05:40:15PM +0100, Richard W.M. Jones wrote: > From: "Richard W.M. Jones" > > (Found by Kamil Dudka) > > Signed-off-by: Richard W.M. Jones > Cc: Michael Tokarev > --- > block/curl.c | 2 -- > 1 file changed, 2 deletions(-) Acked-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-11 Thread Michael S. Tsirkin
On Tue, Jun 11, 2013 at 09:42:29AM +0200, Gerd Hoffmann wrote: > Hi, > > >>> Portability: > >>> - Non x86 (or any Linux) platforms don't need any of this code. > >>> They can keep happily using SHPC the way > >>> they always did. > >> > >> Hmm. Is is possible to write a SHPC dri

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-11 Thread Gerd Hoffmann
Hi, > Yes and not just because of windows guests. > ACPI spec is also very explicit that native hotplug is an optional > feature. Test suites such as WHQL are known to test spec compliance. /me looks a bit surprised. This pretty much implies that any shpc bridge needs a second interface to the

Re: [Qemu-devel] [PATCH qom-cpu v4 07/18] cpu: Turn cpu_paging_enabled() into a CPUState hook

2013-06-11 Thread Jens Freimann
On Sun, Jun 09, 2013 at 06:10:36PM +0200, Andreas Färber wrote: > Relocate assignment of x86 get_arch_id to have all hooks in one place. > > Signed-off-by: Andreas Färber Reviewed-by: Jens Freimann > --- > include/qom/cpu.h | 10 ++ > include/sysemu/memory_mapping.h

[Qemu-devel] [PATCH 0/1] TCG Aarch64 ldst 12bit scaled uimm

2013-06-11 Thread Claudio Fontana
Using only the ldst simm9 (unscaled offset) will often result in the fallback mov immediate + ldst (register offset) to be triggered. This change implements the ldst uimm12 (scaled offset), which avoids the expensive fallback in certain conditions: the offset must be naturally aligned and positiv

[Qemu-devel] [PATCH 1/1] tcg/aarch64: implement ldst 12bit scaled uimm offset

2013-06-11 Thread Claudio Fontana
implement the 12bit scaled unsigned immediate offset variant of LDR/STR. This improves code size by avoiding the movi + ldst_r for naturally aligned offsets in range. Signed-off-by: Claudio Fontana --- tcg/aarch64/tcg-target.c | 32 +--- 1 file changed, 29 insertions

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-11 Thread Michael S. Tsirkin
On Tue, Jun 11, 2013 at 10:00:36AM +0200, Gerd Hoffmann wrote: > Hi, > > > Yes and not just because of windows guests. > > ACPI spec is also very explicit that native hotplug is an optional > > feature. Test suites such as WHQL are known to test spec compliance. > > /me looks a bit surprised. >

Re: [Qemu-devel] [PATCH] curl: refuse to open URL from HTTP server without range support

2013-06-11 Thread Kevin Wolf
Am 11.06.2013 um 09:40 hat Stefan Hajnoczi geschrieben: > On Tue, Jun 11, 2013 at 11:15:15AM +0800, Fam Zheng wrote: > > On Mon, Jun 10, 2013 at 5:21 PM, Stefan Hajnoczi wrote: > > > On Sun, Jun 09, 2013 at 10:34:54AM +0800, Fam Zheng wrote: > > >> @@ -110,14 +111,14 @@ static int curl_sock_cb(CUR

Re: [Qemu-devel] [PATCH v2] curl: Don't set curl options on the handle just before it's going to be deleted.

2013-06-11 Thread Kevin Wolf
Am 10.06.2013 um 18:40 hat Richard W.M. Jones geschrieben: > From: "Richard W.M. Jones" > > (Found by Kamil Dudka) > > Signed-off-by: Richard W.M. Jones > Cc: Michael Tokarev Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH 04/11] snapshot: new function bdrv_snapshot_find_by_id_and_name()

2013-06-11 Thread Stefan Hajnoczi
On Sat, Jun 08, 2013 at 02:58:00PM +0800, Wenchao Xia wrote: > +if (id && name) { > +for (i = 0; i < nb_sns; i++) { > +sn = &sn_tab[i]; > +if (!strcmp(sn->id_str, id) && !strcmp(sn->name, name)) { > +*sn_info = *sn; > +ret = true;

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-11 Thread Michael S. Tsirkin
On Tue, Jun 11, 2013 at 11:18:13AM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 11, 2013 at 10:00:36AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > Yes and not just because of windows guests. > > > ACPI spec is also very explicit that native hotplug is an optional > > > feature. Test suites s

Re: [Qemu-devel] [PATCH 8/9] block: bdrv_reopen_prepare(): don't use QERR_OPEN_FILE_FAILED

2013-06-11 Thread Kevin Wolf
Am 10.06.2013 um 19:02 hat Luiz Capitulino geschrieben: > The call to drv->bdrv_reopen_prepare() can fail due to reasons > other than an open failure. Unfortunately, we can't use errno > nor -ret, cause they are not always set. > > Stick to a generic error message then. > > Signed-off-by: Luiz Ca

Re: [Qemu-devel] [PATCH v2 0/9] QMP/HMP: add error reason to open failures

2013-06-11 Thread Kevin Wolf
Am 10.06.2013 um 19:02 hat Luiz Capitulino geschrieben: > I was surprised to find out that we still have old users of > QERR_OPEN_FILE_FAILED that print errors like: > > (qemu) dump-guest-memory -p /lkmads/foo > Could not open '/lkmads/foo' > (qemu) > > This series converts all those users to a n

Re: [Qemu-devel] [PATCH] Unbreak -no-quit for GTK when SDL is disabled

2013-06-11 Thread Peter Wu
On Monday 10 June 2013 16:53:06 Anthony Liguori wrote: > Peter Wu writes: > > When QEMU is built without SDL support, -no-quit would print an error > > message that SDL is disabled. Since GTK also supports -no-quit, enable > > the option when GTK or SDL is enabled at compile time. > > > > While a

[Qemu-devel] [PATCH] Unbreak -no-quit for GTK, validate SDL options

2013-06-11 Thread Peter Wu
Certain options (-no-frame, -alt-grab, -ctrl-grab) only make sense with SDL. When compiling without SDL, these options (and -no-quit) print an error message and exit qemu. In case QEMU is compiled with SDL support, the three aforementioned options still do not make sense with other display types.

Re: [Qemu-devel] [PATCH qom-cpu v4 12/18] cpu: Change default for CPUClass::get_paging_enabled()

2013-06-11 Thread Jens Freimann
On Sun, Jun 09, 2013 at 06:10:41PM +0200, Andreas Färber wrote: > qemu_get_guest_memory_mapping() uses cpu_paging_enabled() to determine > whether to use cpu_get_memory_mapping() to return mappings or whether to > fall back to a simple identity map. > > Since by default CPUClass::get_memory_mappin

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 1/5] intc/xilinx_intc: Use qemu_set_irq

2013-06-11 Thread Michael Tokarev
11.06.2013 04:41, Peter Crosthwaite wrote: > On Sat, Jun 8, 2013 at 8:36 AM, Michael Tokarev wrote: >> Thanks, applied to the trivial patches queue. > > I need to respin the later patches in this series but as you have > taken this ill drop it from the respin. No conflict issues. heh. I haven't

Re: [Qemu-devel] [PATCH 05/11] snapshot: add paired functions for internal snapshot id and name

2013-06-11 Thread Stefan Hajnoczi
On Sat, Jun 08, 2013 at 02:58:01PM +0800, Wenchao Xia wrote: > +/* > + * Every internal snapshot have an ID used by qemu block layer, this function > + * check whether name used by user mess up with ID. An empty string is also > + * invalid. > + */ > +bool snapshot_name_wellformed(const char *name)

Re: [Qemu-devel] [PATCH qom-cpu v4 09/18] cpu: Turn cpu_get_memory_mapping() into a CPUState hook

2013-06-11 Thread Jens Freimann
On Sun, Jun 09, 2013 at 06:10:38PM +0200, Andreas Färber wrote: > Change error reporting from return value to Error argument. > > Signed-off-by: Andreas Färber Reviewd-by: Jens Freimann > --- > include/qom/cpu.h | 14 ++ > include/sysemu/memory_mapping.h | 2 --

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-11 Thread M. Mohan Kumar
Michael Tokarev writes: > 11.06.2013 00:47, Michael Tokarev wrote: >> Or else >> >> ./configure --disable-system --enable-virtfs >> >> (which makes no sense by its own but does not error out) >> will fail to build, because it will define CONFIG_VIRTFS, >> and the makefile will try to build vir

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-11 Thread Peter Maydell
On 11 June 2013 10:22, M. Mohan Kumar wrote: > I tried ./configure --disable-system --enable-virtfs and make. But didnt > face any build failure. Could you please share your build failure > information? virtfs-proxy-helper.1 is created inside the fsdev folder. Michael wrote "The build fails in th

Re: [Qemu-devel] [PATCH 06/11] snapshot: distinguish id and name in snapshot delete

2013-06-11 Thread Stefan Hajnoczi
On Sat, Jun 08, 2013 at 02:58:02PM +0800, Wenchao Xia wrote: > static int find_snapshot_by_id_or_name(BlockDriverState *bs, const char > *name) I suggest renaming the argument to make it less confusing: const char *name_or_id > { > -BDRVQcowState *s = bs->opaque; > -int i, ret; > +

Re: [Qemu-devel] [PATCH v5] NVMe: Initial commit for new storage interface

2013-06-11 Thread Kevin Wolf
Am 04.06.2013 um 17:17 hat Keith Busch geschrieben: > Initial commit for emulated Non-Volatile-Memory Express (NVMe) pci > storage device. > > NVMe is an open, industry driven storage specification defining > an optimized register and command set designed to deliver the full > capabilities of non-

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-11 Thread Michael Tokarev
11.06.2013 13:22, M. Mohan Kumar wrote: > Michael Tokarev writes: > >> 11.06.2013 00:47, Michael Tokarev wrote: >>> Or else >>> >>> ./configure --disable-system --enable-virtfs >>> >>> (which makes no sense by its own but does not error out) >>> will fail to build, because it will define CONFIG_

Re: [Qemu-devel] [RFT PATCH v1 16/30] isa/*: QOM casting sweep

2013-06-11 Thread Andreas Färber
Am 11.06.2013 08:52, schrieb peter.crosthwa...@xilinx.com: > From: Peter Crosthwaite > > Use standard QOM cast macros. Remove usage of DO_UPCAST and > direct -> style upcasting. > > Signed-off-by: Peter Crosthwaite > --- > > hw/isa/i82378.c | 8 > hw/isa/lpc_ich9.c | 6 +++--- >

Re: [Qemu-devel] [PATCH] ide-test: fix failure for test_flush

2013-06-11 Thread Andreas Färber
Am 10.06.2013 20:23, schrieb Michael Roth: > bd07684aacfb61668ae2c25b7dd00b64f3d7c7f3 added a test to ensure BSY > flag is set when a flush request is in flight. It does this by setting > a blkdebug breakpoint on flush_to_os before issuing a CMD_FLUSH_CACHE. > It then resumes CMD_FLUSH_CACHE operat

[Qemu-devel] how to do performance monitor for single VM?

2013-06-11 Thread Peter Cheung
Dear AllMy name is Peter, i am working on a open source project called "Pandora". It is a new admin console for openstack. http://peter.kingofcoders.com/?p=663How to do performance monitor for single VM? For public cloud billing system, i need to know information about CPU/memory/IO tra

Re: [Qemu-devel] [PATCH qom-cpu 47/59] spapr: Abstract spapr_fix_cpu_dt() with qemu_for_each_cpu()

2013-06-11 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 11.06.2013 04:43, schrieb David Gibson: > On Sun, Jun 09, 2013 at 09:13:14PM +0200, Andreas F¦rber wrote: >> Signed-off-by: Andreas F¦rber > > These days, spapr patches should be CCed to Alexey, instead of me. Please update MAINTAINERS then, I us

Re: [Qemu-devel] [PATCH qom-cpu 00/15 v8] target-i386: convert CPU features into properties, part 1

2013-06-11 Thread Igor Mammedov
On Wed, 05 Jun 2013 19:04:59 +0200 Andreas Färber wrote: > Am 05.06.2013 16:39, schrieb Igor Mammedov: > > On Wed, 05 Jun 2013 15:29:08 +0200 > > Andreas Färber wrote: > > > >> Am 05.06.2013 15:18, schrieb Igor Mammedov: > >>> It's a rebase of v7 on current qom-cpu tree, since then some patches

Re: [Qemu-devel] [PATCH] hw/xen: Use g_free instead of free and fix potential memory leaks

2013-06-11 Thread Stefano Stabellini
On Mon, 10 Jun 2013, Stefan Weil wrote: > The wrong functions and the missing calls of g_free were reported > by cppcheck. > > Signed-off-by: Stefan Weil Acked-by: Stefano Stabellini Are you happy to get this patch upstream via qemu-trivial? Or do you want me to pick it up? > hw/xen/xen_pt_

[Qemu-devel] [PATCH] Makefile: Install qemu-img and qemu-nbd man pages only if built

2013-06-11 Thread Andreas Färber
When splitting openSUSE's qemu and qemu-linux-user packages we noticed that for linux-user-only builds unrelated man pages got installed. It's surely possible to delete them before packaging, but not installing them in the first place seems more logical. Cc: qemu-sta...@nongnu.org Signed-off-by: A

Re: [Qemu-devel] [PATCH 1/4] tcg-ppc64: Fix RLDCL opcode

2013-06-11 Thread Anton Blanchard
Hi Richard, > But that suggests then that we ought not be using XO30. > Or at least adding a comment. Good idea, how does this look? Anton -- The rldcl instruction doesn't have an sh field, so the minor opcode is shifted 1 bit. We were using the XO30 macro which shifted the minor opcode 2 bits

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 0/3] Serial cleanup

2013-06-11 Thread Michael Tokarev
10.06.2013 14:23, Peter Crosthwaite wrote: > Ping! > > Any objections to this one going in? perhaps even via trivial queue? Actually applied all 3 (including 2/3 which weren't submitted to -trivial -- I had some fun verifying it :) to the trivial-patches queue. Thanks! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] gtk: implement -full-screen

2013-06-11 Thread Michael Tokarev
10.06.2013 22:04, Peter Wu wrote: > Aiming for GTK as replacement for SDL, a feature like -full-screen should also > be implemented. > > Bringing the window into full-screen mode is done by activating the > "Fullscreen" > menu item. This is done after showing the windows to make the cursor and me

Re: [Qemu-devel] [Qemu-trivial] [PATCH 4/5] memory: use '=' instead of '|=' for memory_region_update_pending

2013-06-11 Thread Michael Tokarev
11.06.2013 09:15, liguang wrote: > because memory_region_update_pending is bool > > Signed-off-by: liguang > --- > memory.c | 18 +- > 1 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/memory.c b/memory.c > index 5cb8f4a..d99eecd 100644 > --- a/memory.c > +++ b

Re: [Qemu-devel] [Qemu-trivial] [PATCH 3/5] qemu-char: pass bool parameter for qemu_opt_get_bool

2013-06-11 Thread Michael Tokarev
11.06.2013 09:15, liguang wrote: > Signed-off-by: liguang > --- > qemu-char.c |8 > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/qemu-char.c b/qemu-char.c > index d04b429..8092eb8 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -2767,10 +2767,10 @@ static Ch

Re: [Qemu-devel] [PATCH 2/5] vnc: pass bool parameter for vnc_listen_read

2013-06-11 Thread Andreas Färber
Am 11.06.2013 07:15, schrieb liguang: > Signed-off-by: liguang Reviewed-by: Andreas Färber CC'ing Tim. Andreas > --- > ui/vnc.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ui/vnc.c b/ui/vnc.c > index 7d22660..1a8b940 100644 > --- a/ui/vnc.c > +++ b/ui/vn

Re: [Qemu-devel] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect

2013-06-11 Thread Andreas Färber
"parameter" Am 11.06.2013 07:15, schrieb liguang: > type last parameter of vnc_connect if bool, "Type of last ...", "is" > so pass 'false' instead of '0' for it. > > Signed-off-by: liguang Michael, can you fix those up? Then, Reviewed-by: Andreas Färber Thanks, Andreas > --- > ui/vnc.c |

[Qemu-devel] virtio-scsi and error handling

2013-06-11 Thread Hannes Reinecke
Hi Stefan, I currently playing around with improving SCSI EH, optimizing command aborts and the like. And, supposing it to be a nice testbed, tried to make things work with virtio_scsi. However, looking at the code there I've found virtscsi_tmf() just uses 'wait_for_completion', with no timeout

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-11 Thread Bhushan Bharat-R65777
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Monday, June 10, 2013 11:40 PM > To: Wood Scott-B07421 > Cc: Bhushan Bharat-R65777; Andreas Färber; qemu-...@nongnu.org; qemu- > de...@nongnu.org; Wood Scott-B07421 > Subject: Re: [Qemu-devel] [PATCH v2]booke: time

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect

2013-06-11 Thread Michael Tokarev
11.06.2013 09:15, liguang wrote: > type last parameter of vnc_connect if bool, > so pass 'false' instead of '0' for it. There's another parameter in here, `skipauth', which should be bool in vnc_connect(), and should be bool in vnc_display_add_client() too. Also, there's no big point in splitting

Re: [Qemu-devel] qemu-1.5.0 savevm error -95 while writing vm with ceph-rbd as storage-backend

2013-06-11 Thread Oliver Francke
Hi Alexandre, Josh, sorry for coming back so very late, I tried the patch and though I could not get it to work properly - very likely my fault - how would it be to integrate it into the rbd-handler of qemu? Josh? I think you are CC'd from another qemu-ticket anyway? I could just ignore the

Re: [Qemu-devel] [PATCH qom-cpu 27/59] cpu: Turn cpu_unassigned_access() into a CPUState hook

2013-06-11 Thread Stefano Stabellini
On Tue, 11 Jun 2013, Andreas Färber wrote: > Am 09.06.2013 21:12, schrieb Andreas Färber: > > diff --git a/include/qom/cpu.h b/include/qom/cpu.h > > index a69c09c..814d067 100644 > > --- a/include/qom/cpu.h > > +++ b/include/qom/cpu.h > [...] > > @@ -383,6 +401,21 @@ void cpu_interrupt(CPUState *cp

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: Install qemu-img and qemu-nbd man pages only if built

2013-06-11 Thread Michael Tokarev
11.06.2013 15:13, Andreas Färber wrote: > When splitting openSUSE's qemu and qemu-linux-user packages we noticed > that for linux-user-only builds unrelated man pages got installed. > It's surely possible to delete them before packaging, but not installing > them in the first place seems more logic

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-sparc: Replace free by g_free

2013-06-11 Thread Michael Tokarev
Thanks, applied all 4(*) to trivial-patches queue. (*) target-sparc: Replace free by g_free hw/scsi: Don't increment a boolean value device tree: Fix cppcheck warning hw/xen: Use g_free instead of free and fix potential memory leaks (I think it wont hurt if the xen one will come from both -tr

Re: [Qemu-devel] [PATCH] ide-test: fix failure for test_flush

2013-06-11 Thread Kevin Wolf
Am 11.06.2013 um 12:05 hat Andreas Färber geschrieben: > Am 10.06.2013 20:23, schrieb Michael Roth: > > bd07684aacfb61668ae2c25b7dd00b64f3d7c7f3 added a test to ensure BSY > > flag is set when a flush request is in flight. It does this by setting > > a blkdebug breakpoint on flush_to_os before issu

[Qemu-devel] QEMU 1.6 release schedule

2013-06-11 Thread Anthony Liguori
FYI, posted on http://wiki.qemu.org/Planning/1.6 The only small change compared to 1.5 is three release candidates instead of two in the original plan. I think having the third release candidate was helpful for 1.5. | 2013-05-20 | Beginning of 1.6 development phase |- | 2013-06-15 | Mid-point of

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Unbreak -no-quit for GTK, validate SDL options

2013-06-11 Thread Michael Tokarev
11.06.2013 12:55, Peter Wu wrote: > Certain options (-no-frame, -alt-grab, -ctrl-grab) only make sense with SDL. > When compiling without SDL, these options (and -no-quit) print an error > message > and exit qemu. > > In case QEMU is compiled with SDL support, the three aforementioned options > s

Re: [Qemu-devel] [PATCH] target-sparc: Replace free by g_free

2013-06-11 Thread Andreas Färber
Am 10.06.2013 22:40, schrieb Stefan Weil: > The wrong function was reported by cppcheck. > > Signed-off-by: Stefan Weil Reviewed-by: Andreas Färber > --- > target-sparc/cpu.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c >

Re: [Qemu-devel] [PATCH v2 0/9] QMP/HMP: add error reason to open failures

2013-06-11 Thread Luiz Capitulino
On Tue, 11 Jun 2013 09:44:08 +0200 Stefan Hajnoczi wrote: > On Mon, Jun 10, 2013 at 01:02:19PM -0400, Luiz Capitulino wrote: > I should have qualified by Reviewed-by: with "reviewed block layer changes". I've added it only to the block layer patches.

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-11 Thread Michael Tokarev
11.06.2013 01:45, Peter Maydell wrote: > On 10 June 2013 21:47, Michael Tokarev wrote: >> Or else >> >> ./configure --disable-system --enable-virtfs >> >> (which makes no sense by its own but does not error out) >> will fail to build, because it will define CONFIG_VIRTFS, >> and the makefile will

Re: [Qemu-devel] [PATCH 8/9] block: bdrv_reopen_prepare(): don't use QERR_OPEN_FILE_FAILED

2013-06-11 Thread Luiz Capitulino
On Tue, 11 Jun 2013 10:38:47 +0200 Kevin Wolf wrote: > Am 10.06.2013 um 19:02 hat Luiz Capitulino geschrieben: > > The call to drv->bdrv_reopen_prepare() can fail due to reasons > > other than an open failure. Unfortunately, we can't use errno > > nor -ret, cause they are not always set. > > > >

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-11 Thread Alexander Graf
On 06/11/2013 01:40 PM, Bhushan Bharat-R65777 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Monday, June 10, 2013 11:40 PM To: Wood Scott-B07421 Cc: Bhushan Bharat-R65777; Andreas Färber; qemu-...@nongnu.org; qemu- de...@nongnu.org; Wood Scott-B07421 Subjec

Re: [Qemu-devel] [Qemu-trivial] [PATCH] audio: Replace macro GCC_ATTR by GCC_FMT_ATTR and use inline functions

2013-06-11 Thread Michael Tokarev
[Removing malc's email since it bounces] 09.06.2013 16:22, Stefan Weil wrote: > GCC_ATTR was only used in audio_int.h, so it is now unused and > the definition can be removed from compiler.h. > > Signed-off-by: Stefan Weil > --- > audio/audio_int.h |8 +++- > include/qemu/compiler.

Re: [Qemu-devel] [Qemu-trivial] [PATCH] audio: Replace macro GCC_ATTR by GCC_FMT_ATTR and use inline functions

2013-06-11 Thread Andreas Färber
Am 11.06.2013 14:38, schrieb Michael Tokarev: > [Removing malc's email since it bounces] > 09.06.2013 16:22, Stefan Weil wrote: >> GCC_ATTR was only used in audio_int.h, so it is now unused and >> the definition can be removed from compiler.h. >> >> Signed-off-by: Stefan Weil >> --- >> audio/audi

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-11 Thread Alexander Graf
On 06/11/2013 02:47 PM, Bhushan Bharat-R65777 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Tuesday, June 11, 2013 6:10 PM To: Bhushan Bharat-R65777 Cc: Wood Scott-B07421; Andreas Färber; qemu-...@nongnu.org; qemu- de...@nongnu.org Subject: Re: [Qemu-devel]

Re: [Qemu-devel] [PATCH v2] create qemu_openpty_raw() helper function and move it to a separate file

2013-06-11 Thread Michael Tokarev
05.06.2013 19:25, Michael Tokarev wrote: > In two places qemu uses openpty() which is very system-dependent, > and in both places the pty is switched to raw mode as well. > Make a wrapper function which does both steps, and move all the > system-dependent complexity into a separate file, together >

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-11 Thread Bhushan Bharat-R65777
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Tuesday, June 11, 2013 6:10 PM > To: Bhushan Bharat-R65777 > Cc: Wood Scott-B07421; Andreas Färber; qemu-...@nongnu.org; qemu- > de...@nongnu.org > Subject: Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-11 Thread Bhushan Bharat-R65777
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Tuesday, June 11, 2013 6:27 PM > To: Bhushan Bharat-R65777 > Cc: Wood Scott-B07421; Andreas Färber; qemu-...@nongnu.org; qemu- > de...@nongnu.org > Subject: Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer

Re: [Qemu-devel] [PATCH 2/2] Add monitor command mem-nodes

2013-06-11 Thread Eduardo Habkost
On Tue, Jun 11, 2013 at 03:22:13PM +0800, Wanlong Gao wrote: > On 06/05/2013 09:46 PM, Eduardo Habkost wrote: > > On Wed, Jun 05, 2013 at 11:58:25AM +0800, Wanlong Gao wrote: > >> Add monitor command mem-nodes to show the huge mapped > >> memory nodes locations. > >> > > > > This is for machine co

Re: [Qemu-devel] [PATCH 1/4] tcg-ppc64: Fix RLDCL opcode

2013-06-11 Thread Richard Henderson
On 06/11/2013 04:19 AM, Anton Blanchard wrote: > The rldcl instruction doesn't have an sh field, so the minor opcode > is shifted 1 bit. We were using the XO30 macro which shifted the > minor opcode 2 bits. > > Remove XO30 and add MD30 and MDS30 macros which match the > Power ISA categories. > >

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-11 Thread Alexander Graf
On 06/11/2013 03:18 PM, Bhushan Bharat-R65777 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Tuesday, June 11, 2013 6:27 PM To: Bhushan Bharat-R65777 Cc: Wood Scott-B07421; Andreas Färber; qemu-...@nongnu.org; qemu- de...@nongnu.org Subject: Re: [Qemu-devel]

Re: [Qemu-devel] [PATCH 1/1] tcg/aarch64: implement ldst 12bit scaled uimm offset

2013-06-11 Thread Richard Henderson
On 06/11/2013 01:14 AM, Claudio Fontana wrote: > implement the 12bit scaled unsigned immediate offset > variant of LDR/STR. This improves code size by avoiding > the movi + ldst_r for naturally aligned offsets in range. > > Signed-off-by: Claudio Fontana > --- > tcg/aarch64/tcg-target.c | 32 +++

Re: [Qemu-devel] [SeaBIOS] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-11 Thread David Woodhouse
On Mon, 2013-06-10 at 20:03 -0500, Anthony Liguori wrote: > > > I agree that the FAT driver is not 'free software' and I agree that is > > a problem for usage with free software projects, such as QEMU. This is > > a big deal, but unfortunately, as an Intel employee, I think I've done > > as much a

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-11 Thread David Woodhouse
On Mon, 2013-06-10 at 19:11 -0500, Anthony Liguori wrote: > If we did this right in QEMU, we'd have to introduce a QOM property > anyway ... and then we'd have to update each firmware implementation to know about this new property, and the how it translates to the RESET_REG field in the DSDT, etc

[Qemu-devel] KVM minutes for 2013-06-11

2013-06-11 Thread Juan Quintela
2013-06-11 -- - move ACPI table generation to QEMU - code sharing with SEABIOS - easier to generate there Anthony: it is the same put in QEMU or SEABIOS Michael: there are some information not easily available in seabios (hot plug) Anthony: transfer QOM tree to SEA

Re: [Qemu-devel] [PATCH qom-cpu v4 07/18] cpu: Turn cpu_paging_enabled() into a CPUState hook

2013-06-11 Thread Luiz Capitulino
On Sun, 9 Jun 2013 18:10:36 +0200 Andreas Färber wrote: > Relocate assignment of x86 get_arch_id to have all hooks in one place. > > Signed-off-by: Andreas Färber Reviewed-by: Luiz Capitulino > --- > include/qom/cpu.h | 10 ++ > include/sysemu/memory_mapping.h |

Re: [Qemu-devel] [PATCH qom-cpu v4 09/18] cpu: Turn cpu_get_memory_mapping() into a CPUState hook

2013-06-11 Thread Luiz Capitulino
On Sun, 9 Jun 2013 18:10:38 +0200 Andreas Färber wrote: > Change error reporting from return value to Error argument. > > Signed-off-by: Andreas Färber > --- > include/qom/cpu.h | 14 ++ > include/sysemu/memory_mapping.h | 2 -- > memory_mapping-stub.c

Re: [Qemu-devel] [PATCH qom-cpu v4 12/18] cpu: Change default for CPUClass::get_paging_enabled()

2013-06-11 Thread Luiz Capitulino
On Sun, 9 Jun 2013 18:10:41 +0200 Andreas Färber wrote: > qemu_get_guest_memory_mapping() uses cpu_paging_enabled() to determine > whether to use cpu_get_memory_mapping() to return mappings or whether to > fall back to a simple identity map. > > Since by default CPUClass::get_memory_mapping() i

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-11 Thread Peter Maydell
On 11 June 2013 13:29, Michael Tokarev wrote: > 11.06.2013 01:45, Peter Maydell wrote: >> This doesn't feel to me like it's quite the right way >> to fix this bug. The current code in configure seems >> to tangle up (a) was virtfs requested and can we do it? >> with (b) what do we need to do if it

[Qemu-devel] [Bug 504368] Re: sdl window intermittently scales instead of resizing

2013-06-11 Thread Lekensteyn
I have attached a screenshot that shows the *contents* of a SDL window *not* being scaled despite the window being maximized. Is this the same issue or not? If not, can you attach a screenshot describing the issue? ** Attachment added: "screenshot of maximized window with scaling bug" https://

Re: [Qemu-devel] [PATCH] ide-test: fix failure for test_flush

2013-06-11 Thread mdroth
On Tue, Jun 11, 2013 at 12:05:20PM +0200, Andreas Färber wrote: > Am 10.06.2013 20:23, schrieb Michael Roth: > > bd07684aacfb61668ae2c25b7dd00b64f3d7c7f3 added a test to ensure BSY > > flag is set when a flush request is in flight. It does this by setting > > a blkdebug breakpoint on flush_to_os be

Re: [Qemu-devel] KVM call agenda for 2013-06-11

2013-06-11 Thread Michael S. Tsirkin
On Tue, Jun 04, 2013 at 04:24:31PM +0300, Michael S. Tsirkin wrote: > Juan is not available now, and Anthony asked for > agenda to be sent early. > So here comes: > > Agenda for the meeting Tue, June 11: > > - Generating acpi tables, redux Not so much notes as a quick summary of the call: Ther

[Qemu-devel] KVM call agenda for 2013-06-25

2013-06-11 Thread Juan Quintela
Hi Now we have moved to one call each other week. Please, send any topic that you are interested in covering. Thanks, Juan. PD. If you want to attend and you don't have the call details, contact me.

Re: [Qemu-devel] [PATCH qom-cpu v4 13/18] memory_mapping: Cleanup qemu_get_guest_memory_mapping()

2013-06-11 Thread Luiz Capitulino
On Sun, 9 Jun 2013 18:10:42 +0200 Andreas Färber wrote: > We relied on the CPUClass::get_memory_mapping() implementation being a > no-op when paging is disabled for that CPU. Therefore we can just as well > iterate over all CPUs to retrieve mappings. > > This allows to use qemu_for_each_cpu() i

Re: [Qemu-devel] [PATCH qom-cpu v4 14/18] dump: Abstract dump_init() with cpu_synchronize_all_states()

2013-06-11 Thread Luiz Capitulino
On Sun, 9 Jun 2013 18:10:43 +0200 Andreas Färber wrote: > Instead of calling cpu_synchronize_state() for each CPU, call the > existing cpu_synchronize_all_states() helper. > > Signed-off-by: Andreas Färber Reviewed-by: Luiz Capitulino > --- > dump.c | 5 +++-- > 1 file changed, 3 insertion

  1   2   >