[Qemu-devel] [PATCH] migration: ensure memory is zeroized at the destination

2013-06-10 Thread Peter Lieven
migration relies on the target memory to be zeroed out since commit f1c72795 (migration: do not sent zero pages in bulk stage). however, there is a subtle case where this breaks migration. if for some reason a page is zero at the source but not at the destination the destination memory is corrupted

Re: [Qemu-devel] [PATCH qom-cpu 31/59] monitor: Simplify do_info_numa()

2013-06-10 Thread Markus Armbruster
Andreas Färber writes: > Use new qemu_for_each_cpu(). > > Signed-off-by: Andreas Färber > --- > monitor.c | 27 +++ > 1 file changed, 19 insertions(+), 8 deletions(-) > > diff --git a/monitor.c b/monitor.c > index 9be515c..f37bf3d 100644 > --- a/monitor.c > +++ b/monitor

[Qemu-devel] [PATCH] Deactivate timer for target_bit above 61

2013-06-10 Thread Bharat Bhushan
QEMU timer supports a maximum timer of INT64_MAX. So starting timer only for time which is calculated using target_bit < 62 and deactivate/stop timer if the target bit is above 61. This patch also fix the time calculation from target_bit. The code was doing (1 << (target_bit + 1)) while this shoul

[Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-10 Thread Bharat Bhushan
QEMU timer supports a maximum timer of INT64_MAX. So starting timer only for time which is calculated using target_bit < 62 and deactivate/stop timer if the target bit is above 61. This patch also fix the time calculation from target_bit. The code was doing (1 << (target_bit + 1)) while this shoul

Re: [Qemu-devel] Qemu crashed while unpluging IDE disk

2013-06-10 Thread Stefan Hajnoczi
On Fri, Jun 07, 2013 at 02:31:00PM +, Gonglei (Arei) wrote: > While starting a Fedora_14 guest, we came across a segfault of qemu: > > the logs in /var/log/messages are: > Jun 1 02:38:56 NC587 kernel: [403549.565754] show_signal_msg: 136 callbacks > suppressed > Jun 1 02:38:56 NC587 kernel

Re: [Qemu-devel] [PATCH 3/9] block: bdrv_reopen_prepare(): use error_setg_file_open()

2013-06-10 Thread Stefan Hajnoczi
On Fri, Jun 07, 2013 at 03:52:29PM -0400, Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino > --- > block.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/block.c b/block.c > index 79ad33d..c78f152 100644 > --- a/block.c > +++ b/block.c > @@ -1291,8 +1291,7 @@ i

Re: [Qemu-devel] [PATCH] chardev: add baud parameter for serial host device

2013-06-10 Thread Peter Wu
On Monday 10 June 2013 07:56:01 Gerd Hoffmann wrote: > On 06/08/13 23:49, Peter Wu wrote: > > When QEMU starts, it always changes the serial port parameters including > > baud rate. This confused my guest which thought it was outputting at 9600 > > baud while it was in fact changed to 115200. > > >

Re: [Qemu-devel] [PATCH 3/9] block: bdrv_reopen_prepare(): use error_setg_file_open()

2013-06-10 Thread Stefan Hajnoczi
On Fri, Jun 07, 2013 at 03:52:29PM -0400, Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino > --- > block.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/block.c b/block.c > index 79ad33d..c78f152 100644 > --- a/block.c > +++ b/block.c > @@ -1291,8 +1291,7 @@ i

Re: [Qemu-devel] broken incoming migration

2013-06-10 Thread Peter Lieven
On 10.06.2013 08:55, Alexey Kardashevskiy wrote: On 06/10/2013 04:50 PM, Peter Lieven wrote: On 10.06.2013 08:39, Alexey Kardashevskiy wrote: On 06/09/2013 05:27 PM, Peter Lieven wrote: Am 09.06.2013 um 05:09 schrieb Alexey Kardashevskiy : On 06/09/2013 01:01 PM, Wenchao Xia wrote: 于 2013-6

Re: [Qemu-devel] [PATCH 4/9] block: mirror_complete(): use error_setg_file_open()

2013-06-10 Thread Stefan Hajnoczi
On Fri, Jun 07, 2013 at 03:52:30PM -0400, Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino > --- > block/mirror.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/mirror.c b/block/mirror.c > index 8b07dec..89d531d 100644 > --- a/block/mirror.c > +++ b/block/m

Re: [Qemu-devel] [PATCH 5/9] blockdev: use error_setg_file_open()

2013-06-10 Thread Stefan Hajnoczi
On Fri, Jun 07, 2013 at 03:52:31PM -0400, Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino > --- > blockdev.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) s/errno/-ret/g

Re: [Qemu-devel] how to know qemu devices topology

2013-06-10 Thread Stefan Hajnoczi
On Sun, Jun 09, 2013 at 01:26:21PM +0800, yue-kvm wrote: > 1. how could i know how many devices qemu support and hardware topology of > all of them? > > 2.the quantitativerestriction of guest's devices. vcpu,disk,ethernet,memory? Some resources are limited by the bus (e.g. PCI slots). The de

Re: [Qemu-devel] [PATCH v4 0/2] fix 'qemu-img snapshot -a' operation for sheepdog

2013-06-10 Thread Kevin Wolf
Am 07.06.2013 um 19:54 hat Liu Yuan geschrieben: > v4: > - fix savevm, pass current vdi_id instead of parent_vdi_id > > v3: > - fix sheepdog's loadvm handling, don't rely on the write to create branch > > v2: > - add the comment to make things more clear > - call sd_create_branch() after s->i

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-06-10 Thread Cornelia Huck
On Sun, 09 Jun 2013 03:11:35 +0200 Andreas Färber wrote: > Am 07.06.2013 19:28, schrieb Jason J. Herne: > > From: "Jason J. Herne" > > > > Modify cpu initialization and QOM routines associated with s390-cpu such > > that > > all cpus on S390 are now created via the QOM device creation code pat

[Qemu-devel] [PATCH] vmdk: byteswap VMDK4Header.desc_offset field

2013-06-10 Thread Stefan Hajnoczi
Remember to byteswap VMDK4Header.desc_offset on big-endian machines. Cc: qemu-sta...@nongnu.org Signed-off-by: Stefan Hajnoczi --- block/vmdk.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 608daaf..ee50a73 100644 --- a/block/vmdk.c

Re: [Qemu-devel] [PATCH] vmdk: refuse to open higher version than supported

2013-06-10 Thread Stefan Hajnoczi
On Sun, Jun 09, 2013 at 09:44:15AM +0800, Fam Zheng wrote: > Although we try to be compatible with published VMDK spec, VMware has > newer version from ESXi 5.1 exported OVF/OVA, which we have no knowledge > what's changed in it. And it is very likely to have more new versions in > the future, so i

Re: [Qemu-devel] [PATCH] vmdk: refuse to open higher version than supported

2013-06-10 Thread Kevin Wolf
Am 09.06.2013 um 03:44 hat Fam Zheng geschrieben: > Refuse to open higher version for safety. > > Although we try to be compatible with published VMDK spec, VMware has > newer version from ESXi 5.1 exported OVF/OVA, which we have no knowledge > what's changed in it. And it is very likely to have m

Re: [Qemu-devel] broken incoming migration

2013-06-10 Thread Alexey Kardashevskiy
On 06/10/2013 06:44 PM, Peter Lieven wrote: > On 10.06.2013 08:55, Alexey Kardashevskiy wrote: >> On 06/10/2013 04:50 PM, Peter Lieven wrote: >>> On 10.06.2013 08:39, Alexey Kardashevskiy wrote: On 06/09/2013 05:27 PM, Peter Lieven wrote: > Am 09.06.2013 um 05:09 schrieb Alexey Kardashevsk

Re: [Qemu-devel] [Qemu-trivial] [PATCH] ioport/memory: check that both .read and .write callbacks are defined

2013-06-10 Thread Peter Crosthwaite
Hi, On Mon, Jun 10, 2013 at 3:27 PM, Gerd Hoffmann wrote: > Hi, > >> Maybe instead (or in addition to), we should provide a dummy >> read or write functions -- instead of fixing each such occurence >> to use its own dummy function > > Makes sense, especially for write where we can just ignore w

Re: [Qemu-devel] [PATCH] curl: refuse to open URL from HTTP server without range support

2013-06-10 Thread Stefan Hajnoczi
On Sun, Jun 09, 2013 at 10:34:54AM +0800, Fam Zheng wrote: > @@ -110,14 +111,14 @@ static int curl_sock_cb(CURL *curl, curl_socket_t fd, > int action, > return 0; > } > > -static size_t curl_size_cb(void *ptr, size_t size, size_t nmemb, void > *opaque) > +static size_t curl_header_cb(void

Re: [Qemu-devel] [PATCH v4 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-06-10 Thread Stefan Hajnoczi
On Thu, Jun 06, 2013 at 11:06:19AM -0400, Tomoki Sekiyama wrote: > changes from v3: > -[01/10] Use c++ instead of g++ in configureing C++ compiler if neither > $cross_prefix nor $CXX is specified. > -[02/10] Add "alternative representations" as a reserved keywords in qapi.py. > -[03/10

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-10 Thread Peter Maydell
On 10 June 2013 08:55, Bharat Bhushan wrote: > QEMU timer supports a maximum timer of INT64_MAX. So starting timer only for > time which is calculated using target_bit < 62 and deactivate/stop timer if > the target bit is above 61. Is this really what the hardware does? Or do we need to set a tim

Re: [Qemu-devel] [Qemu-ppc] broken incoming migration

2013-06-10 Thread Benjamin Herrenschmidt
On Mon, 2013-06-10 at 19:10 +1000, Alexey Kardashevskiy wrote: > > I would prefer not to completely drop the patch since it saves bandwidth and > > resources. > > I would like migration to do what it should do - send pages no matter what, > this is exactly what migration is for. If there any many,

Re: [Qemu-devel] [PATCH] script: git script to compile every commit in a range of commits

2013-06-10 Thread Peter Crosthwaite
Hi, On Sat, Jun 8, 2013 at 6:30 AM, Jeff Cody wrote: > On Fri, Jun 07, 2013 at 11:51:36AM -0500, Anthony Liguori wrote: >> Laszlo Ersek writes: >> >> > On 06/07/13 16:44, Jeff Cody wrote: >> > >> >> Thanks. I can either do the above changes for a v2, or as follow on >> >> patches. >> > >> > Whi

Re: [Qemu-devel] [Qemu-ppc] broken incoming migration

2013-06-10 Thread Peter Lieven
On 10.06.2013 11:33, Benjamin Herrenschmidt wrote: On Mon, 2013-06-10 at 19:10 +1000, Alexey Kardashevskiy wrote: I would prefer not to completely drop the patch since it saves bandwidth and resources. I would like migration to do what it should do - send pages no matter what, this is exactly w

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-10 Thread Bhushan Bharat-R65777
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Monday, June 10, 2013 2:56 PM > To: Bhushan Bharat-R65777 > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; ag...@suse.de; Wood Scott- > B07421; Bhushan Bharat-R65777 > Subject: Re: [Qemu-devel] [PATCH v2

[Qemu-devel] [PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-10 Thread fred . konrad
From: KONRAD Frederic This fix a bug with scsi hotplug on virtio-scsi-pci: As virtio-scsi-pci doesn't have any scsi bus, we need to forward scsi-hot-add to the virtio-scsi-device plugged on the virtio-bus. Reported-by: Alexey Kardashevskiy Signed-off-by: KONRAD Frederic --- hw/pci/pci-hotplu

Re: [Qemu-devel] [PATCH] migration: ensure memory is zeroized at the destination

2013-06-10 Thread Peter Lieven
please ignore this one. Peter On 10.06.2013 09:03, Peter Lieven wrote: migration relies on the target memory to be zeroed out since commit f1c72795 (migration: do not sent zero pages in bulk stage). however, there is a subtle case where this breaks migration. if for some reason a page is zero a

[Qemu-devel] [PATCH] block/curl.c: Refuse to open the handle for writes.

2013-06-10 Thread Richard W.M. Jones
This simple patch avoids a segfault in qemu if the user tries to open a curl disk for writing. This was previously part of Fam Zheng's curl patch series, but it stands alone and we shouldn't forget about it. Rich.

[Qemu-devel] [PATCH] block/curl.c: Refuse to open the handle for writes.

2013-06-10 Thread Richard W.M. Jones
From: "Richard W.M. Jones" Signed-off-by: Richard W.M. Jones Signed-off-by: Fam Zheng --- block/curl.c | 4 1 file changed, 4 insertions(+) diff --git a/block/curl.c b/block/curl.c index b8935fd..f1e302b 100644 --- a/block/curl.c +++ b/block/curl.c @@ -406,6 +406,10 @@ static int curl_op

[Qemu-devel] [PATCHv2 2/2] migration: do not overwrite zero pages

2013-06-10 Thread Peter Lieven
on incoming migration do not memset pages to zero if they already read as zero. this will allocate a new zero page and consume memory unnecessarily. even if we madvise a MADV_DONTNEED later this will only deallocate the memory asynchronously. Signed-off-by: Peter Lieven --- arch_init.c | 14 ++

[Qemu-devel] [PATCHv2 0/2] fix migration of zero pages

2013-06-10 Thread Peter Lieven
There have been reports that migration is broken on pseries by Alexey Kardashevskiy. It turned out that migration will fail in general as soon as a page is zero on the source, but not on the destination. I thus reverted the skipping of zero pages in bulk transfer phase and added a patch that does

[Qemu-devel] [PATCHv2 1/2] Revert "migration: do not sent zero pages in bulk stage"

2013-06-10 Thread Peter Lieven
Not sending zero pages breaks migration if a page is zero at the source but not at the destination. This can e.g. happen if different BIOS versions are used at source and destination. It has also been reported that migration on pseries is completely broken with this patch. This effectively reverts

Re: [Qemu-devel] [PATCH v1 0/3] Serial cleanup

2013-06-10 Thread Peter Crosthwaite
Ping! Any objections to this one going in? perhaps even via trivial queue? Regards, Peter On Mon, Jun 3, 2013 at 3:11 PM, wrote: > From: Peter Crosthwaite > > Some cosmetics, refactored to use util/fifo8 for the FIFO8, then > factored out some common code. > > Tested as working on petalogix-m

Re: [Qemu-devel] [PATCH] xilinx_axienet: Fix bit mask code

2013-06-10 Thread Edgar E. Iglesias
On Sun, Jun 09, 2013 at 10:56:20PM +0200, Stefan Weil wrote: > Obviously the code wanted to mask the lower bits but failed to do so > because of a missing "<". > > cppcheck detected a conditional expression which was always true (1 < 7). Applied, thanks Stefan > > Signed-off-by: Stefan Weil

Re: [Qemu-devel] [PATCH v1 1/1] xilinx_axidma: Do not set DMA .notify to NULL after notify

2013-06-10 Thread Edgar E. Iglesias
On Fri, Jun 07, 2013 at 01:05:38PM +1000, peter.crosthwa...@xilinx.com wrote: > From: Wendy Liang > > If a stream notify function is not ready, it may re-populate the notify call- > back to indicate it should be re-polled later. This break in this usage, as > immediately following the notify() ca

Re: [Qemu-devel] [PATCH] block/curl.c: Refuse to open the handle for writes.

2013-06-10 Thread Kevin Wolf
Am 10.06.2013 um 12:06 hat Richard W.M. Jones geschrieben: > From: "Richard W.M. Jones" > > Signed-off-by: Richard W.M. Jones > Signed-off-by: Fam Zheng > --- > block/curl.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/block/curl.c b/block/curl.c > index b8935fd..f1e302b 10064

Re: [Qemu-devel] [PATCH 0/5] Trace fixes

2013-06-10 Thread Stefan Hajnoczi
On Fri, Jun 07, 2013 at 12:59:16PM +0200, Markus Armbruster wrote: > Markus Armbruster (5): > cleanup-trace-events.pl: New > slavio_misc: Fix slavio_led_mem_readw/_writew tracepoints > milkymist-minimac2: Fix minimac2_read/_write tracepoints > trace-events: Drop unused events > trace-even

Re: [Qemu-devel] [PATCH 0/5] Trace fixes

2013-06-10 Thread Stefan Hajnoczi
On Fri, Jun 07, 2013 at 12:59:16PM +0200, Markus Armbruster wrote: > Markus Armbruster (5): > cleanup-trace-events.pl: New > slavio_misc: Fix slavio_led_mem_readw/_writew tracepoints > milkymist-minimac2: Fix minimac2_read/_write tracepoints > trace-events: Drop unused events > trace-even

[Qemu-devel] [PATCH v2] block/curl.c: Refuse to open the handle for writes.

2013-06-10 Thread Richard W.M. Jones
From: "Richard W.M. Jones" Signed-off-by: Richard W.M. Jones Signed-off-by: Fam Zheng --- block/curl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/curl.c b/block/curl.c index b8935fd..b634ccf 100644 --- a/block/curl.c +++ b/block/curl.c @@ -406,6 +406,12 @@ static int curl_

[Qemu-devel] [PATCH v2] block/curl.c: Refuse to open the handle for writes.

2013-06-10 Thread Richard W.M. Jones
v2: - Use qerror_report to report an error. - Return -EROFS instead of -ENOTSUP.

Re: [Qemu-devel] [PATCH RFT 1/5] virtio-blk-dataplane: Improve error reporting

2013-06-10 Thread Stefan Hajnoczi
On Fri, Jun 07, 2013 at 08:18:56PM +0200, Andreas Färber wrote: > Return an Error so that it can be propagated later. > > Signed-off-by: Andreas Färber > --- > hw/block/dataplane/virtio-blk.c | 25 + > hw/block/dataplane/virtio-blk.h | 5 +++-- > hw/block/virtio-blk.c

Re: [Qemu-devel] [PATCH v1 0/3] Serial cleanup

2013-06-10 Thread Andreas Färber
Am 10.06.2013 12:23, schrieb Peter Crosthwaite: > Ping! > > Any objections to this one going in? perhaps even via trivial queue? No strong objection, but you are using an unusual 12-char indentation in some places that you may want to check. Otherwise the cosmetic cleanup looks fine to me. Chee

Re: [Qemu-devel] [PATCH v2] block/curl.c: Refuse to open the handle for writes.

2013-06-10 Thread Kevin Wolf
Am 10.06.2013 um 13:38 hat Richard W.M. Jones geschrieben: > From: "Richard W.M. Jones" > > Signed-off-by: Richard W.M. Jones > Signed-off-by: Fam Zheng Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-10 Thread Andreas Färber
Am 10.06.2013 11:53, schrieb fred.kon...@greensocs.com: > From: KONRAD Frederic > > This fix a bug with scsi hotplug on virtio-scsi-pci: > > As virtio-scsi-pci doesn't have any scsi bus, we need to forward scsi-hot-add > to the virtio-scsi-device plugged on the virtio-bus. > > Reported-by: Alex

Re: [Qemu-devel] [PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-10 Thread Frederic Konrad
On 10/06/2013 13:58, Andreas Färber wrote: Am 10.06.2013 11:53, schrieb fred.kon...@greensocs.com: From: KONRAD Frederic This fix a bug with scsi hotplug on virtio-scsi-pci: As virtio-scsi-pci doesn't have any scsi bus, we need to forward scsi-hot-add to the virtio-scsi-device plugged on the

Re: [Qemu-devel] [PATCH v1 0/3] Serial cleanup

2013-06-10 Thread Peter Crosthwaite
Hi Andreas, On Mon, Jun 10, 2013 at 9:49 PM, Andreas Färber wrote: > Am 10.06.2013 12:23, schrieb Peter Crosthwaite: >> Ping! >> >> Any objections to this one going in? perhaps even via trivial queue? > > No strong objection, but you are using an unusual 12-char indentation in > some places that

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-10 Thread Andreas Färber
Am 10.06.2013 09:55, schrieb Bharat Bhushan: > QEMU timer supports a maximum timer of INT64_MAX. So starting timer only for > time which is calculated using target_bit < 62 and deactivate/stop timer if > the target bit is above 61. > > This patch also fix the time calculation from target_bit. > Th

[Qemu-devel] [PATCH v3 06/17] block/curl: drop curl_aio_flush()

2013-06-10 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop curl_aio_flush(). The acb[] array that the function checks is still used in other parts of block/curl.c. Therefore we cannot remove acb[], it is needed. Signed-off-by: Stefan Hajnoczi --- block/curl.c | 22 +++--- 1 file changed, 3 insert

[Qemu-devel] [PATCH v3 03/17] tests: adjust test-aio to new aio_poll() semantics

2013-06-10 Thread Stefan Hajnoczi
aio_poll(ctx, true) will soon block if any fd handlers have been set. Previously it would only block when .io_flush() returned true. This means that callers must check their wait condition *before* aio_poll() to avoid deadlock. Signed-off-by: Stefan Hajnoczi --- tests/test-aio.c | 26 ++

[Qemu-devel] [PATCH v3 00/17] aio: drop io_flush()

2013-06-10 Thread Stefan Hajnoczi
v3: * I forgot about this series, time to push it again! * Rebase onto qemu.git/master * Drop now-unused AioFlushHandler typedef [bonzini] This series gets rid of aio's .io_flush() callback. It's based on Paolo's insight that bdrv_drain_all() can be implemented using the bs->tracked_requests l

[Qemu-devel] [PATCH v3 01/17] block: stop relying on io_flush() in bdrv_drain_all()

2013-06-10 Thread Stefan Hajnoczi
If a block driver has no file descriptors to monitor but there are still active requests, it can return 1 from .io_flush(). This is used to spin during synchronous I/O. Stop relying on .io_flush() and instead check QLIST_EMPTY(&bs->tracked_requests) to decide whether there are active requests. T

[Qemu-devel] [PATCH v3 07/17] block/gluster: drop qemu_gluster_aio_flush_cb()

2013-06-10 Thread Stefan Hajnoczi
Since .io_flush() is no longer called we do not need qemu_gluster_aio_flush_cb() anymore. It turns out that qemu_aio_count is unused now and can be dropped. Signed-off-by: Stefan Hajnoczi --- block/gluster.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/bl

[Qemu-devel] [PATCH v3 12/17] block/sheepdog: drop have_co_req() and aio_flush_request()

2013-06-10 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop have_co_req() and aio_flush_request(). Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 21a4edf..66918c6 100644 ---

[Qemu-devel] [PATCH v3 02/17] dataplane/virtio-blk: check exit conditions before aio_poll()

2013-06-10 Thread Stefan Hajnoczi
Check exit conditions before entering blocking aio_poll(). This is mainly for consistency since it's unlikely that we are stopping in the first event loop iteration. Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) dif

[Qemu-devel] [PATCH v3 08/17] block/iscsi: drop iscsi_process_flush()

2013-06-10 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop iscsi_process_flush(). Signed-off-by: Stefan Hajnoczi --- block/iscsi.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index f7199c1..e2041ca 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -147,

[Qemu-devel] [PATCH v3 11/17] block/rbd: drop qemu_rbd_aio_flush_cb()

2013-06-10 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop qemu_rbd_aio_flush_cb(). qemu_aio_count is unused now so drop it too. Signed-off-by: Stefan Hajnoczi --- block/rbd.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 0f2608b..40e5d55 100644

[Qemu-devel] [PATCH v3 05/17] aio: stop using .io_flush()

2013-06-10 Thread Stefan Hajnoczi
Now that aio_poll() users check their termination condition themselves, it is no longer necessary to call .io_flush() handlers. The behavior of aio_poll() changes as follows: 1. .io_flush() is no longer invoked and file descriptors are *always* monitored. Previously returning 0 from .io_flush()

[Qemu-devel] [PATCH v3 10/17] block/nbd: drop nbd_have_request()

2013-06-10 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop nbd_have_request(). We cannot drop in_flight since it is still used by other block/nbd.c code. Signed-off-by: Stefan Hajnoczi --- block/nbd.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/block/nbd.c b/block/nbd.c inde

[Qemu-devel] [PATCH v3 09/17] block/linux-aio: drop qemu_laio_completion_cb()

2013-06-10 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop qemu_laio_completion_cb(). It turns out that count is now unused so drop that too. Signed-off-by: Stefan Hajnoczi --- block/linux-aio.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/block/linux-aio.c b/block/linux-

[Qemu-devel] [PATCH v3 15/17] thread-pool: drop thread_pool_active()

2013-06-10 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop thread_pool_active(). The block layer is the only thread-pool.c user and it already tracks in-flight requests, therefore we do not need thread_pool_active(). Signed-off-by: Stefan Hajnoczi --- thread-pool.c | 8 +--- 1 file changed, 1 insertion(+), 7

[Qemu-devel] [PATCH v3 04/17] tests: adjust test-thread-pool to new aio_poll() semantics

2013-06-10 Thread Stefan Hajnoczi
aio_poll(ctx, true) will soon block when fd handlers have been set. Previously aio_poll() would return early if all .io_flush() returned false. This means we need to check the equivalent of the .io_flush() condition *before* calling aio_poll(ctx, true) to avoid deadlock. Signed-off-by: Stefan Haj

[Qemu-devel] [PATCH v3 16/17] tests: drop event_active_cb()

2013-06-10 Thread Stefan Hajnoczi
The .io_flush() handler no longer exists and has no users. Drop the io_flush argument to aio_set_fd_handler() and related functions. Signed-off-by: Stefan Hajnoczi --- tests/test-aio.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/tests/test-aio.c b

[Qemu-devel] [PATCH v3 17/17] aio: drop io_flush argument

2013-06-10 Thread Stefan Hajnoczi
The .io_flush() handler no longer exists and has no users. Drop the io_flush argument to aio_set_fd_handler() and related functions. The AioFlushEventNotifierHandler and AioFlushHandler typedefs are no longer used and are dropped too. Signed-off-by: Stefan Hajnoczi --- aio-posix.c

Re: [Qemu-devel] [PATCH] gtk: implement -full-screen and -no-frame

2013-06-10 Thread Kevin Wolf
Am 09.06.2013 um 12:30 hat Peter Wu geschrieben: > Aiming for GTK as replacement for SDL, features like -full-screen and > -no-frame > should also be implemented. > > Bringing the window into full-screen mode is done by faking activating the > full > screen menu item with a NULL menu item (which

[Qemu-devel] [PATCH v3 13/17] block/ssh: drop return_true()

2013-06-10 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop return_true(). Signed-off-by: Stefan Hajnoczi --- block/ssh.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index 246a70d..ed525cc 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -725,14 +725,6 @@ sta

[Qemu-devel] [PATCH v3 14/17] dataplane/virtio-blk: drop flush_true() and flush_io()

2013-06-10 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop flush_true() and flush_io(). Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 0

Re: [Qemu-devel] [PATCH] gtk: implement -full-screen and -no-frame

2013-06-10 Thread Peter Wu
On Monday 10 June 2013 14:33:28 Kevin Wolf wrote: > Am 09.06.2013 um 12:30 hat Peter Wu geschrieben: > > Aiming for GTK as replacement for SDL, features like -full-screen and > > -no-frame should also be implemented. > > > > > > > > Bringing the window into full-screen mode is done by faking activ

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-10 Thread Bhushan Bharat-R65777
> -Original Message- > From: Andreas Färber [mailto:afaer...@suse.de] > Sent: Monday, June 10, 2013 5:43 PM > To: Bhushan Bharat-R65777 > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; ag...@suse.de; Wood Scott- > B07421; Bhushan Bharat-R65777 > Subject: Re: [Qemu-devel] [PATCH v2]booke:

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-10 Thread Luiz Capitulino
On Mon, 10 Jun 2013 10:15:35 +0800 Qiao Nuohan wrote: > On 06/05/2013 10:15 AM, Luiz Capitulino wrote: > > I can review it until the end of this week. If this series is adding a new > > argument (which I believe is what it does) then there's only two ways > > to get this merged: either we wait fo

Re: [Qemu-devel] [PATCH] chardev: add baud parameter for serial host device

2013-06-10 Thread Gerd Hoffmann
On 06/10/13 10:42, Peter Wu wrote: > On Monday 10 June 2013 07:56:01 Gerd Hoffmann wrote: >> On 06/08/13 23:49, Peter Wu wrote: >>> When QEMU starts, it always changes the serial port parameters including >>> baud rate. This confused my guest which thought it was outputting at 9600 >>> baud while i

Re: [Qemu-devel] [PATCH] gtk: implement -full-screen and -no-frame

2013-06-10 Thread Kevin Wolf
Am 10.06.2013 um 14:43 hat Peter Wu geschrieben: > On Monday 10 June 2013 14:33:28 Kevin Wolf wrote: > > Am 09.06.2013 um 12:30 hat Peter Wu geschrieben: > > > --- a/include/ui/console.h > > > +++ b/include/ui/console.h > > > @@ -339,6 +339,6 @@ int index_from_keycode(int code); > > > > > > > > >

[Qemu-devel] [PATCH] curl: Don't set curl options on the handle just before it's going to be deleted.

2013-06-10 Thread Richard W.M. Jones
From: "Richard W.M. Jones" (Found by Kamil Dudka) Signed-off-by: Richard W.M. Jones --- block/curl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/curl.c b/block/curl.c index b634ccf..bf31efe 100644 --- a/block/curl.c +++ b/block/curl.c @@ -453,7 +453,6 @@ static int curl_open(Block

Re: [Qemu-devel] [PATCH 3/9] block: bdrv_reopen_prepare(): use error_setg_file_open()

2013-06-10 Thread Luiz Capitulino
On Mon, 10 Jun 2013 10:43:47 +0200 Stefan Hajnoczi wrote: > On Fri, Jun 07, 2013 at 03:52:29PM -0400, Luiz Capitulino wrote: > > Signed-off-by: Luiz Capitulino > > --- > > block.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/block.c b/block.c > > index 79ad3

Re: [Qemu-devel] [PATCH] chardev: add baud parameter for serial host device

2013-06-10 Thread Andreas Färber
Am 10.06.2013 14:58, schrieb Gerd Hoffmann: > On 06/10/13 10:42, Peter Wu wrote: >> On Monday 10 June 2013 07:56:01 Gerd Hoffmann wrote: >>> On 06/08/13 23:49, Peter Wu wrote: When QEMU starts, it always changes the serial port parameters including baud rate. This confused my guest which

Re: [Qemu-devel] [PATCH 5/9] blockdev: use error_setg_file_open()

2013-06-10 Thread Luiz Capitulino
On Mon, 10 Jun 2013 10:45:23 +0200 Stefan Hajnoczi wrote: > On Fri, Jun 07, 2013 at 03:52:31PM -0400, Luiz Capitulino wrote: > > Signed-off-by: Luiz Capitulino > > --- > > blockdev.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > s/errno/-ret/g I'll fix this and double ch

Re: [Qemu-devel] [PATCH] chardev: add baud parameter for serial host device

2013-06-10 Thread Peter Wu
On Monday 10 June 2013 14:58:07 Gerd Hoffmann wrote: > On 06/10/13 10:42, Peter Wu wrote: > > On Monday 10 June 2013 07:56:01 Gerd Hoffmann wrote: > >> On 06/08/13 23:49, Peter Wu wrote: > >>> When QEMU starts, it always changes the serial port parameters including > >>> baud rate. This confused my

Re: [Qemu-devel] [PATCH v1 1/3] char/serial: cosmetic fixes.

2013-06-10 Thread Andreas Färber
Hi Peter, Am 03.06.2013 07:12, schrieb peter.crosthwa...@xilinx.com: > From: Peter Crosthwaite > > Some cosmetic fixes to char/serial fixing some checkpatch errors. > > Cc: qemu-triv...@nongnu.org > > Signed-off-by: Peter Crosthwaite > --- > Needed for the next patch to pass checkpatch. Done

Re: [Qemu-devel] [PATCH v1 3/3] char/serial: serial_ioport_write: Factor out common code

2013-06-10 Thread Andreas Färber
Am 03.06.2013 07:14, schrieb peter.crosthwa...@xilinx.com: > From: Peter Crosthwaite > > These three lines are common to both FIFO and regular mode. Just factor > them out to outside the if rather than replicate the same lines inside > both if and else. > > Cc: qemu-triv...@nongnu.org > > Signe

Re: [Qemu-devel] [Qemu-ppc] real cdrom access failure

2013-06-10 Thread Alexander Graf
On 06/10/2013 03:39 PM, Programmingkid wrote: On Jun 9, 2013, at 12:34 PM, Alexander Graf wrote: On 09.06.2013, at 18:28, Programmingkid wrote: I am trying to access the cdrom drive in QEMU 1.5.0, but can't. This is the error I see: qemu-system-ppc: -cdrom /dev/cdrom: could not open disk ima

Re: [Qemu-devel] [PATCH] chardev: add baud parameter for serial host device

2013-06-10 Thread Peter Wu
On Monday 10 June 2013 15:28:32 Peter Wu wrote: > On Monday 10 June 2013 14:58:07 Gerd Hoffmann wrote: > > On 06/10/13 10:42, Peter Wu wrote: > > > On Monday 10 June 2013 07:56:01 Gerd Hoffmann wrote: > > >> On 06/08/13 23:49, Peter Wu wrote: > > >>> When QEMU starts, it always changes the serial p

Re: [Qemu-devel] [PATCH 3/9] block: bdrv_reopen_prepare(): use error_setg_file_open()

2013-06-10 Thread Kevin Wolf
Am 10.06.2013 um 15:21 hat Luiz Capitulino geschrieben: > On Mon, 10 Jun 2013 10:43:47 +0200 > Stefan Hajnoczi wrote: > > > On Fri, Jun 07, 2013 at 03:52:29PM -0400, Luiz Capitulino wrote: > > > Signed-off-by: Luiz Capitulino > > > --- > > > block.c | 3 +-- > > > 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH 3/9] block: bdrv_reopen_prepare(): use error_setg_file_open()

2013-06-10 Thread Luiz Capitulino
On Mon, 10 Jun 2013 15:54:10 +0200 Kevin Wolf wrote: > Am 10.06.2013 um 15:21 hat Luiz Capitulino geschrieben: > > On Mon, 10 Jun 2013 10:43:47 +0200 > > Stefan Hajnoczi wrote: > > > > > On Fri, Jun 07, 2013 at 03:52:29PM -0400, Luiz Capitulino wrote: > > > > Signed-off-by: Luiz Capitulino > >

Re: [Qemu-devel] [PATCH] vmdk: byteswap VMDK4Header.desc_offset field

2013-06-10 Thread Kevin Wolf
Am 10.06.2013 um 11:07 hat Stefan Hajnoczi geschrieben: > Remember to byteswap VMDK4Header.desc_offset on big-endian machines. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Stefan Hajnoczi Thanks, applied to the block layer. > @@ -507,8 +507,11 @@ static int vmdk_open_vmdk4(BlockDriverState *

Re: [Qemu-devel] [PATCH 3/9] block: bdrv_reopen_prepare(): use error_setg_file_open()

2013-06-10 Thread Kevin Wolf
Am 10.06.2013 um 16:02 hat Luiz Capitulino geschrieben: > On Mon, 10 Jun 2013 15:54:10 +0200 > Kevin Wolf wrote: > > > Am 10.06.2013 um 15:21 hat Luiz Capitulino geschrieben: > > > On Mon, 10 Jun 2013 10:43:47 +0200 > > > Stefan Hajnoczi wrote: > > > > > > > On Fri, Jun 07, 2013 at 03:52:29PM -

Re: [Qemu-devel] [PATCH qom-cpu 00/59] QOM CPUState, part 10: CPU loops

2013-06-10 Thread Stefano Stabellini
On Sun, 9 Jun 2013, Andreas Färber wrote: > Hello, > > Based on my guest-memory-dump cleanup patches, this large series changes > cpu_single_env, first_cpu, next_cpu and thread_env to CPUState. > > As a prerequisite, most open-coded CPU loops are replaced by either > qemu_for_each_cpu() or qemu_g

Re: [Qemu-devel] [PATCH] target-mips: 64-bit FPU for user-mode emulation.

2013-06-10 Thread Maciej W. Rozycki
On Sun, 9 Jun 2013, Thomas Schwinge wrote: > In my reading of the relevant documents, the latter change is not correct > for o32, and empirically has "interesting" effects on the glibc math > testsuite, for example. Keeping the FR register unset for o32 I'm > proposing to fix with the following p

Re: [Qemu-devel] [Qemu-ppc] real cdrom access failure

2013-06-10 Thread Andreas Färber
Am 10.06.2013 15:41, schrieb Alexander Graf: > On 06/10/2013 03:39 PM, Programmingkid wrote: >> On Jun 9, 2013, at 12:34 PM, Alexander Graf wrote: >> >>> On 09.06.2013, at 18:28, Programmingkid wrote: >>> I am trying to access the cdrom drive in QEMU 1.5.0, but can't. This is the error I

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-10 Thread Alexander Graf
On 06/10/2013 02:47 PM, Bhushan Bharat-R65777 wrote: -Original Message- From: Andreas Färber [mailto:afaer...@suse.de] Sent: Monday, June 10, 2013 5:43 PM To: Bhushan Bharat-R65777 Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; ag...@suse.de; Wood Scott- B07421; Bhushan Bharat-R65777 S

Re: [Qemu-devel] [PATCH] vmdk: byteswap VMDK4Header.desc_offset field

2013-06-10 Thread Kevin Wolf
Am 10.06.2013 um 16:32 hat Stefan Hajnoczi geschrieben: > On Mon, Jun 10, 2013 at 04:04:55PM +0200, Kevin Wolf wrote: > > Am 10.06.2013 um 11:07 hat Stefan Hajnoczi geschrieben: > > > Remember to byteswap VMDK4Header.desc_offset on big-endian machines. > > > > > > Cc: qemu-sta...@nongnu.org > > >

Re: [Qemu-devel] [PATCH] vmdk: byteswap VMDK4Header.desc_offset field

2013-06-10 Thread Stefan Hajnoczi
On Mon, Jun 10, 2013 at 04:04:55PM +0200, Kevin Wolf wrote: > Am 10.06.2013 um 11:07 hat Stefan Hajnoczi geschrieben: > > Remember to byteswap VMDK4Header.desc_offset on big-endian machines. > > > > Cc: qemu-sta...@nongnu.org > > Signed-off-by: Stefan Hajnoczi > > Thanks, applied to the block la

Re: [Qemu-devel] [PATCH v3 01/17] block: stop relying on io_flush() in bdrv_drain_all()

2013-06-10 Thread Stefan Hajnoczi
On Mon, Jun 10, 2013 at 02:25:57PM +0200, Stefan Hajnoczi wrote: > @@ -1427,26 +1456,18 @@ void bdrv_close_all(void) > void bdrv_drain_all(void) > { > BlockDriverState *bs; > -bool busy; > - > -do { > -busy = qemu_aio_wait(); > > +while (bdrv_requests_pending_all()) { >

Re: [Qemu-devel] [Qemu-ppc] real cdrom access failure

2013-06-10 Thread Kevin Wolf
Am 10.06.2013 um 16:22 hat Andreas Färber geschrieben: > Am 10.06.2013 15:41, schrieb Alexander Graf: > > On 06/10/2013 03:39 PM, Programmingkid wrote: > >> On Jun 9, 2013, at 12:34 PM, Alexander Graf wrote: > >> > >>> On 09.06.2013, at 18:28, Programmingkid wrote: > >>> > I am trying to acces

Re: [Qemu-devel] [Qemu-ppc] real cdrom access failure

2013-06-10 Thread Andreas Färber
Am 10.06.2013 16:33, schrieb Kevin Wolf: > Am 10.06.2013 um 16:22 hat Andreas Färber geschrieben: >> Am 10.06.2013 15:41, schrieb Alexander Graf: >>> On 06/10/2013 03:39 PM, Programmingkid wrote: On Jun 9, 2013, at 12:34 PM, Alexander Graf wrote: > On 09.06.2013, at 18:28, Programmingkid w

Re: [Qemu-devel] [PATCH qom-cpu 00/59] QOM CPUState, part 10: CPU loops

2013-06-10 Thread Andreas Färber
Am 10.06.2013 16:17, schrieb Stefano Stabellini: > On Sun, 9 Jun 2013, Andreas Färber wrote: >> Hello, >> >> Based on my guest-memory-dump cleanup patches, this large series changes >> cpu_single_env, first_cpu, next_cpu and thread_env to CPUState. >> >> As a prerequisite, most open-coded CPU loops

Re: [Qemu-devel] latest qemu with gdb remote not working

2013-06-10 Thread Peter Cheung
Sorry about that, i forgot i am in a mailing list > Date: Mon, 3 Jun 2013 06:19:56 -0600 > From: ebl...@redhat.com > To: mcheun...@hotmail.com > CC: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] latest qemu with gdb remote not working > > On 06/01/2013 02:09 PM, Peter Cheung wrote: > > i sta

Re: [Qemu-devel] [Qemu-ppc] real cdrom access failure

2013-06-10 Thread Kevin Wolf
Am 10.06.2013 um 16:45 hat Andreas Färber geschrieben: > Am 10.06.2013 16:33, schrieb Kevin Wolf: > > Am 10.06.2013 um 16:22 hat Andreas Färber geschrieben: > >> Am 10.06.2013 15:41, schrieb Alexander Graf: > >>> On 06/10/2013 03:39 PM, Programmingkid wrote: > On Jun 9, 2013, at 12:34 PM, Alex

Re: [Qemu-devel] latest qemu with gdb remote not working

2013-06-10 Thread Peter Cheung
Hi Peter I just git pull the latest code, the gdb still fail to run after sending a "c" command. Thanksfrom Peter > Date: Mon, 3 Jun 2013 09:47:41 +0200 > From: pbonz...@redhat.com > To: peter.crosthwa...@xilinx.com > CC: peter.mayd...@linaro.org; qemu-devel@nongnu.org; mcheun...@hotmail.com >

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 1/3] char/serial: cosmetic fixes.

2013-06-10 Thread Michael Tokarev
03.06.2013 09:12, peter.crosthwa...@xilinx.com wrote: > From: Peter Crosthwaite > > Some cosmetic fixes to char/serial fixing some checkpatch errors. These are all cosmetic fixes indeed. I weren't sure we're applying stylistic changes by its own. But apparently people don't object so I don't s

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 1/3] char/serial: cosmetic fixes.

2013-06-10 Thread Michael Tokarev
10.06.2013 19:17, Michael Tokarev пишет: > 03.06.2013 09:12, peter.crosthwa...@xilinx.com wrote: >> From: Peter Crosthwaite >> >> Some cosmetic fixes to char/serial fixing some checkpatch errors. > > These are all cosmetic fixes indeed. I weren't sure we're > applying stylistic changes by its ow

  1   2   3   >