Re: [Qemu-devel] [PATCH] virtio-net: put virtio net header inline with data

2013-06-09 Thread Michael S. Tsirkin
On Fri, Jun 07, 2013 at 11:42:43AM +0930, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > For small packets we can simplify xmit processing by linearizing buffers > > with the header: most packets seem to have enough head room we can use > > for this purpose. > > > > Since some older hyper

Re: [Qemu-devel] broken incoming migration

2013-06-09 Thread Peter Lieven
Am 09.06.2013 um 06:12 schrieb liu ping fan : > Hi Peter, > > Is it that sending zero page mostly service the first iteration, ie > bluk-stage? And for the subsequent iteration, dirty pages are normally > not zero. > Yes most Zero Pages are sent during bulk stage except for busy windows guests

Re: [Qemu-devel] broken incoming migration

2013-06-09 Thread Peter Lieven
Am 09.06.2013 um 05:09 schrieb Alexey Kardashevskiy : > On 06/09/2013 01:01 PM, Wenchao Xia wrote: >> 于 2013-6-9 10:34, Alexey Kardashevskiy 写道: >>> On 06/09/2013 12:16 PM, Wenchao Xia wrote: 于 2013-6-8 16:30, Alexey Kardashevskiy 写道: > On 06/08/2013 06:27 PM, Wenchao Xia wrote: >>>

Re: [Qemu-devel] RFH: boot from virtio cdrom?

2013-06-09 Thread Paolo Bonzini
Il 07/06/2013 03:02, Laszlo Ersek ha scritto: >>> >> I'm using libvirt to manage my VMs and configured one VM to boot from >>> >> a CDROM connected via virtio. This does neither work with QEMU-1.1.2 >>> >> nor with QEMU-1.5; neither with SeaBIOS is 1.7.0 nor 1.7.2. >> > >> > Doesn't work with virt

[Qemu-devel] [PATCH] gtk: implement -full-screen and -no-frame

2013-06-09 Thread Peter Wu
Aiming for GTK as replacement for SDL, features like -full-screen and -no-frame should also be implemented. Bringing the window into full-screen mode is done by faking activating the full screen menu item with a NULL menu item (which currently is not used by gd_menu_full_screen). This is done afte

Re: [Qemu-devel] [PATCH RFT 2/5] virtio: Convert VirtioDevice to QOM realize/unrealize

2013-06-09 Thread Michael S. Tsirkin
On Fri, Jun 07, 2013 at 08:18:57PM +0200, Andreas Färber wrote: > VirtioDevice's DeviceClass::exit code cleaning up bus_name is no longer > overwritten by virtio-{blk,serial,net,scsi,balloon,rng} and vhost-scsi. > > Note: VirtIOSCSI and VHostSCSI now perform some initializations after > VirtIOSCSI

Re: [Qemu-devel] [PATCH RFT 0/5] QOM realize for virtio

2013-06-09 Thread Michael S. Tsirkin
On Fri, Jun 07, 2013 at 08:18:55PM +0200, Andreas Färber wrote: > Hello, > > This series converts virtio devices to QOM realize/unrealize. > It is intended as base for fixing virtio-net initialization order issues, > as reported by Jesse. Only partially tested though. > > Note that while VirtioDe

[Qemu-devel] [PATCH] audio: Replace macro GCC_ATTR by GCC_FMT_ATTR and use inline functions

2013-06-09 Thread Stefan Weil
GCC_ATTR was only used in audio_int.h, so it is now unused and the definition can be removed from compiler.h. Signed-off-by: Stefan Weil --- audio/audio_int.h |8 +++- include/qemu/compiler.h |3 --- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/audio/audio_int

[Qemu-devel] [Bug 1188991] [NEW] Unable to do serial communication using -chardev tty

2013-06-09 Thread Franco
Public bug reported: Im running an Linux Image (kernel 3.2.8) for beagleboard-xm on QEMU's 1.4.0 emulator. What I want to do is to have a communication between guest and host across serial the 4 differents ttyO present on the guest. QEMU offer facilities to redirect the trafic to some device

[Qemu-devel] [PATCH qom-cpu v4 02/18] pc: Fix crash when attempting to hotplug CPU with negative ID

2013-06-09 Thread Andreas Färber
From: Igor Mammedov QMP command "{ 'execute': 'cpu-add', 'arguments': { 'id': -1 }}" may cause QEMU SIGSEGV at: piix4_cpu_hotplug_req () ... g->sts[cpu_id / 8] |= (1 << (cpu_id % 8)); ... Since for PC in current implementation id should be in range [0...maxcpus) and maxcpus is alrea

[Qemu-devel] [PATCH qom-cpu v4 06/18] target-i386: cpu: Fix potential buffer overrun in get_register_name_32()

2013-06-09 Thread Andreas Färber
From: Igor Mammedov Spotted by Coverity, x86_reg_info_32[] is CPU_NB_REGS32 elements long, so accessing x86_reg_info_32[CPU_NB_REGS32] will be one element off array. Signed-off-by: Igor Mammedov Reviewed-by: liguang Reviewed by: Jesse Larrew Signed-off-by: Andreas Färber --- target-i386/cpu

[Qemu-devel] [PATCH qom-cpu v4 08/18] memory_mapping: Move MemoryMappingList typedef to qemu/typedefs.h

2013-06-09 Thread Andreas Färber
This will avoid issues with hwaddr and ram_addr_t when including sysemu/memory_mapping.h for CONFIG_USER_ONLY. Signed-off-by: Andreas Färber --- include/qemu/typedefs.h | 2 ++ include/sysemu/memory_mapping.h | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/inclu

[Qemu-devel] [PATCH qom-cpu v4 03/18] pc: Create pc-*-1.6 machine-types

2013-06-09 Thread Andreas Färber
From: Eduardo Habkost Some CPU model fixes are going to be included and they will require compatibility properties in the pc-*-1.5 machine-types. Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov Signed-off-by: Andreas Färber --- hw/i386/pc_piix.c | 14 -- hw/i386/pc_q35.

[Qemu-devel] [PATCH qom-cpu v4 01/18] dump: Move stubs into libqemustub.a

2013-06-09 Thread Andreas Färber
This allows us to drop CONFIG_NO_CORE_DUMP with its indirect dependency on CONFIG_HAVE_CORE_DUMP. Acked-by: Paolo Bonzini Signed-off-by: Andreas Färber --- Makefile.target | 2 -- stubs/Makefile.objs | 1 + dump-stub.c => stubs/dump.c | 0 3 files changed, 1 insertion(+), 2

[Qemu-devel] [PATCH qom-cpu v4 14/18] dump: Abstract dump_init() with cpu_synchronize_all_states()

2013-06-09 Thread Andreas Färber
Instead of calling cpu_synchronize_state() for each CPU, call the existing cpu_synchronize_all_states() helper. Signed-off-by: Andreas Färber --- dump.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dump.c b/dump.c index b44dafc..44a1339 100644 --- a/dump.c +++ b/dump.

[Qemu-devel] [PATCH qom-cpu v4 12/18] cpu: Change default for CPUClass::get_paging_enabled()

2013-06-09 Thread Andreas Färber
qemu_get_guest_memory_mapping() uses cpu_paging_enabled() to determine whether to use cpu_get_memory_mapping() to return mappings or whether to fall back to a simple identity map. Since by default CPUClass::get_memory_mapping() is not implemented, change the default to false to use the identity ma

[Qemu-devel] [PATCH qom-cpu v4 04/18] target-i386: Update model values on Conroe/Penryn/Nehalem CPU models

2013-06-09 Thread Andreas Färber
From: Eduardo Habkost The CPUID model values on Conroe, Penryn, and Nehalem are too conservative and don't reflect the values found on real Conroe, Penryn, and Nehalem CPUs. This causes at least one known problems: Windows XP disables sysenter when (family == 6 && model <= 2), but Skype tries to

[Qemu-devel] [PATCH qom-cpu v4 09/18] cpu: Turn cpu_get_memory_mapping() into a CPUState hook

2013-06-09 Thread Andreas Färber
Change error reporting from return value to Error argument. Signed-off-by: Andreas Färber --- include/qom/cpu.h | 14 ++ include/sysemu/memory_mapping.h | 2 -- memory_mapping-stub.c | 6 -- memory_mapping.c | 7 --- qom/cpu.c

[Qemu-devel] [PATCH qom-cpu v4 05/18] target-i386: Set level=4 on Conroe/Penryn/Nehalem

2013-06-09 Thread Andreas Färber
From: Eduardo Habkost The CPUID level value on Conroe, Penryn, and Nehalem are too low. This causes at least one known problem: the -smp "threads" option doesn't work as expect if level is < 4, because thread count information is provided to the guest on CPUID[EAX=4,ECX=2].EAX Signed-off-by: Edu

[Qemu-devel] [PATCH qom-cpu v4 13/18] memory_mapping: Cleanup qemu_get_guest_memory_mapping()

2013-06-09 Thread Andreas Färber
We relied on the CPUClass::get_memory_mapping() implementation being a no-op when paging is disabled for that CPU. Therefore we can just as well iterate over all CPUs to retrieve mappings. This allows to use qemu_for_each_cpu() instead of open-coding CPU loops. Pass any Error out into dump_init()

[Qemu-devel] [PATCH qom-cpu v4 07/18] cpu: Turn cpu_paging_enabled() into a CPUState hook

2013-06-09 Thread Andreas Färber
Relocate assignment of x86 get_arch_id to have all hooks in one place. Signed-off-by: Andreas Färber --- include/qom/cpu.h | 10 ++ include/sysemu/memory_mapping.h | 1 - memory_mapping-stub.c | 6 -- memory_mapping.c | 2 +- qom/cpu.

[Qemu-devel] [PATCH qom-cpu v4 18/18] memory_mapping: Build only once

2013-06-09 Thread Andreas Färber
Move RAMBlock, RAMList and ram_list to exec/cpu-common.h since they do not depend on CPUArchState. We can then use it together with qom/cpu.h to replace cpu.h and exec/cpu-all.h includes, making it fully target-independent. Signed-off-by: Andreas Färber --- Makefile.objs | 1 +

[Qemu-devel] [PATCH qom-cpu v4 15/18] dump: Abstract dump_init() further with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Allows to drop CPUArchState variable. Signed-off-by: Andreas Färber --- dump.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/dump.c b/dump.c index 44a1339..4e6b855 100644 --- a/dump.c +++ b/dump.c @@ -702,10 +702,16 @@ static ram_addr_t get_start_block(DumpStat

[Qemu-devel] [PATCH qom-cpu v4 16/18] dump: Abstract write_elf{64, 32}_notes() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Removes the last use of CPUArchState. Signed-off-by: Andreas Färber --- dump.c | 133 +++-- 1 file changed, 97 insertions(+), 36 deletions(-) diff --git a/dump.c b/dump.c index 4e6b855..d3cb8e2 100644 --- a/dump.c +++ b/dump.c @@ -273,

Re: [Qemu-devel] [PATCH qom-cpu v4 00/18] dump: Build cleanups, redone

2013-06-09 Thread Andreas Färber
Am 09.06.2013 18:10, schrieb Andreas Färber: > Andreas Färber (13): > dump: Move stubs into libqemustub.a [...] > Eduardo Habkost (3): > pc: Create pc-*-1.6 machine-types > target-i386: Update model values on Conroe/Penryn/Nehalem CPU models > target-i386: Set level=4 on Conroe/Penryn/Nehal

[Qemu-devel] [PATCH qom-cpu v4 17/18] memory_mapping: Use hwaddr type for MemoryMapping virt_addr field

2013-06-09 Thread Andreas Färber
The memory mapping API uses hwaddr, so use it in the struct, too. This avoids a header dependency on target_ulong type. Cc: Wen Congyang Signed-off-by: Andreas Färber --- include/sysemu/memory_mapping.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/sysemu/memory_ma

[Qemu-devel] [PATCH qom-cpu v4 00/18] dump: Build cleanups, redone

2013-06-09 Thread Andreas Färber
Hello, As requested by Paolo, this replaces Kate's previous memory_mapping split and my follow-ups and instead goes directly for moving things to CPUState. All knowledge about dump / memory mapping are moved away from configure. v4 incorporates minor API changes, suggested by Luiz, as well as tw

[Qemu-devel] [PATCH qom-cpu v4 11/18] dump: Drop qmp_dump_guest_memory() stub and build for all targets

2013-06-09 Thread Andreas Färber
qmp_dump_guest_memory() calls dump_init() and returns an Error when cpu_get_dump_info() returns an error, as done by the stub. So there is no need to have a stub for qmp_dump_guest_memory(). Enable the documentation of the always-present dump-guest-memory command. That way we can drop CONFIG_HAVE

[Qemu-devel] [PATCH qom-cpu v4 10/18] memory_mapping: Drop qemu_get_memory_mapping() stub

2013-06-09 Thread Andreas Färber
dump.c:dump_init() never checked for the return code anyway. If paging is not enabled, it will fall back to an identity map. If paging is enabled and getting memory mapping list is not implemented, qemu_get_guest_memory_mapping() will return an error. Since the targets not implementing memory mapp

Re: [Qemu-devel] [PATCH qom-cpu v4 17/18] memory_mapping: Use hwaddr type for MemoryMapping virt_addr field

2013-06-09 Thread Peter Maydell
On 9 June 2013 17:10, Andreas Färber wrote: > The memory mapping API uses hwaddr, so use it in the struct, too. > This avoids a header dependency on target_ulong type. > --- a/include/sysemu/memory_mapping.h > +++ b/include/sysemu/memory_mapping.h > @@ -20,7 +20,7 @@ > /* The physical and virtua

Re: [Qemu-devel] [PATCH qom-cpu v4 17/18] memory_mapping: Use hwaddr type for MemoryMapping virt_addr field

2013-06-09 Thread Andreas Färber
Am 09.06.2013 19:17, schrieb Peter Maydell: > On 9 June 2013 17:10, Andreas Färber wrote: >> The memory mapping API uses hwaddr, so use it in the struct, too. >> This avoids a header dependency on target_ulong type. > >> --- a/include/sysemu/memory_mapping.h >> +++ b/include/sysemu/memory_mapping

Re: [Qemu-devel] [PATCH] audio: Replace macro GCC_ATTR by GCC_FMT_ATTR and use inline functions

2013-06-09 Thread Andreas Färber
Am 09.06.2013 14:22, schrieb Stefan Weil: > GCC_ATTR was only used in audio_int.h, so it is now unused and > the definition can be removed from compiler.h. > > Signed-off-by: Stefan Weil Reviewed-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany G

Re: [Qemu-devel] [PATCH qom-cpu v4 18/18] memory_mapping: Build only once

2013-06-09 Thread Peter Maydell
On 9 June 2013 17:10, Andreas Färber wrote: > Move RAMBlock, RAMList and ram_list to exec/cpu-common.h since they do > not depend on CPUArchState. We can then use it together with qom/cpu.h > to replace cpu.h and exec/cpu-all.h includes, making it fully > target-independent. Messing directly with

Re: [Qemu-devel] [PATCH qom-cpu v4 18/18] memory_mapping: Build only once

2013-06-09 Thread Andreas Färber
Am 09.06.2013 19:29, schrieb Peter Maydell: > On 9 June 2013 17:10, Andreas Färber wrote: >> Move RAMBlock, RAMList and ram_list to exec/cpu-common.h since they do >> not depend on CPUArchState. We can then use it together with qom/cpu.h >> to replace cpu.h and exec/cpu-all.h includes, making it f

Re: [Qemu-devel] [PATCH] gtk: implement -full-screen and -no-frame

2013-06-09 Thread Anthony Liguori
On Sun, Jun 9, 2013 at 5:30 AM, Peter Wu wrote: > Aiming for GTK as replacement for SDL, features like -full-screen and > -no-frame > should also be implemented. > > Bringing the window into full-screen mode is done by faking activating the > full > screen menu item with a NULL menu item (which

[Qemu-devel] [PATCH qom-cpu 00/59] QOM CPUState, part 10: CPU loops

2013-06-09 Thread Andreas Färber
Hello, Based on my guest-memory-dump cleanup patches, this large series changes cpu_single_env, first_cpu, next_cpu and thread_env to CPUState. As a prerequisite, most open-coded CPU loops are replaced by either qemu_for_each_cpu() or qemu_get_cpu(). Individual review appreciated! qemu_init_vcpu

[Qemu-devel] [PATCH qom-cpu 04/59] cpus: Simplify cpu_synchronize_all_post_init()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber --- cpus.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/cpus.c b/cpus.c index 1186ad3..85b35f6 100644 --- a/cpus.c +++ b/cpus.c @@ -425,13 +425,14 @@ void cpu_synchronize_all_post_reset(void) qemu_

[Qemu-devel] [PATCH qom-cpu 05/59] cpus: Simplify pause_all_vcpus()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu() to pause, stop and kick CPUs. Signed-off-by: Andreas Färber --- cpus.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/cpus.c b/cpus.c index 85b35f6..ad5edfe 100644 --- a/cpus.c +++ b/cpus.c @@ -962,39 +96

[Qemu-devel] [PATCH qom-cpu 01/59] kvm: Change kvm_cpu_synchronize_state() argument to CPUState

2013-06-09 Thread Andreas Färber
It no longer relies on CPUArchState. Signed-off-by: Andreas Färber --- hw/ppc/spapr_rtas.c | 2 +- include/sysemu/kvm.h | 4 ++-- kvm-all.c| 4 +--- kvm-stub.c | 2 +- target-i386/kvm.c| 10 +- 5 files changed, 10 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [PATCH qom-cpu 03/59] cpus: Simplify cpu_synchronize_all_post_reset()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber --- cpus.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/cpus.c b/cpus.c index 8ff66c3..1186ad3 100644 --- a/cpus.c +++ b/cpus.c @@ -415,13 +415,14 @@ void cpu_synchronize_all_states(void) qemu_for_

[Qemu-devel] [PATCH qom-cpu 10/59] cpus: Simplify qemu_tcg_wait_io_event() and qemu_tcg_cpu_thread_fn()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber --- cpus.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/cpus.c b/cpus.c index 9195bc3..a8572a9 100644 --- a/cpus.c +++ b/cpus.c @@ -703,10 +703,13 @@ static void qemu_wait_io_event_common(CPUState

[Qemu-devel] [PATCH qom-cpu 07/59] cpus: Simplify set_numa_modes()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber --- cpus.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/cpus.c b/cpus.c index 1babecf..24ee974 100644 --- a/cpus.c +++ b/cpus.c @@ -1188,22 +1188,22 @@ static void tcg_exec_all(void) exit_re

[Qemu-devel] [PATCH qom-cpu 15/59] cpus: Change qemu_kvm_wait_io_event() argument to CPUState

2013-06-09 Thread Andreas Färber
It no longer uses CPUArchState. Signed-off-by: Andreas Färber --- cpus.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index fcef422..2545e15 100644 --- a/cpus.c +++ b/cpus.c @@ -722,10 +722,8 @@ static void qemu_tcg_wait_io_event(void) qemu_for_e

[Qemu-devel] [PATCH qom-cpu 13/59] cpu: Change cpu_exit() argument to CPUState

2013-06-09 Thread Andreas Färber
It no longer depends on CPUArchState, so move it to qom/cpu.c. Signed-off-by: Andreas Färber --- cpus.c | 4 ++-- exec.c | 8 gdbstub.c | 2 +- hw/i386/pc.c| 2 +- hw/mips/mips_fulong2e.c | 2 +- hw/mips/mips_jazz.c | 2 +-

[Qemu-devel] [PATCH qom-cpu 02/59] kvm: Change cpu_synchronize_state() argument to CPUState

2013-06-09 Thread Andreas Färber
Change Monitor::mon_cpu to CPUState as well. In cpu_sychronize_all_states() use qemu_for_each_cpu() now. In dump_init() use cpu_synchronize_all_states(). Signed-off-by: Andreas Färber --- cpus.c | 13 +++-- gdbstub.c | 8 hw/i386/kvm/apic.c |

[Qemu-devel] [PATCH qom-cpu 12/59] gdbstub: Simplify find_cpu()

2013-06-09 Thread Andreas Färber
Use qemu_get_cpu() and CPUState::env_ptr. Signed-off-by: Andreas Färber --- gdbstub.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index fb6c6a5..92ecdcb 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2068,17 +2068,13 @@ static void gdb_set_c

[Qemu-devel] [PATCH qom-cpu 09/59] cpus: Simplify hw_error()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber --- cpus.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/cpus.c b/cpus.c index 1975c5c..9195bc3 100644 --- a/cpus.c +++ b/cpus.c @@ -386,21 +386,22 @@ void configure_icount(const char *option) }

[Qemu-devel] [PATCH qom-cpu 16/59] kvm: Change kvm_set_signal_mask() argument to CPUState

2013-06-09 Thread Andreas Färber
CPUArchState is no longer needed. Signed-off-by: Andreas Färber --- cpus.c | 3 ++- include/sysemu/kvm.h | 2 +- kvm-all.c| 3 +-- kvm-stub.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cpus.c b/cpus.c index 2545e15..aa8aa36 100644 -

[Qemu-devel] [PATCH qom-cpu 19/59] kvm: Change kvm_handle_internal_error() argument to CPUState

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- kvm-all.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 1cd4573..1675311 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1520,10 +1520,8 @@ static void kvm_handle_io(uint16_t port, void *data, int direction, int

[Qemu-devel] [PATCH qom-cpu 06/59] cpus: Simplify resume_all_vcpus()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber --- cpus.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/cpus.c b/cpus.c index ad5edfe..1babecf 100644 --- a/cpus.c +++ b/cpus.c @@ -1005,16 +1005,15 @@ void cpu_resume(CPUState *cpu) qemu_cpu_kic

[Qemu-devel] [PATCH qom-cpu 17/59] cpus: Change qemu_kvm_init_cpu_signals() argument to CPUState

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- cpus.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index aa8aa36..080f308 100644 --- a/cpus.c +++ b/cpus.c @@ -572,9 +572,8 @@ static void dummy_signal(int sig) { } -static void qemu_kvm_init_cpu_signals(CPUArchS

[Qemu-devel] [PATCH qom-cpu 08/59] cpus: Simplify qmp_inject_nmi()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber --- cpus.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/cpus.c b/cpus.c index 24ee974..1975c5c 100644 --- a/cpus.c +++ b/cpus.c @@ -1331,18 +1331,24 @@ exit: fclose(f); } -void qmp

[Qemu-devel] [PATCH qom-cpu 20/59] kvm: Change kvm_cpu_exec() argument to CPUState

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- cpus.c | 2 +- include/sysemu/kvm.h | 2 +- kvm-all.c| 3 +-- kvm-stub.c | 4 ++-- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/cpus.c b/cpus.c index 636d4d8..f07618f 100644 --- a/cpus.c +++ b/cpus.c @@ -757,7

[Qemu-devel] [PATCH qom-cpu 22/59] cpus: Change cpu_handle_guest_debug() argument to CPUState

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- cpus.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/cpus.c b/cpus.c index dba69bc..f629a15 100644 --- a/cpus.c +++ b/cpus.c @@ -463,10 +463,8 @@ static bool cpu_can_run(CPUState *cpu) return true; } -static void cpu_handle_g

[Qemu-devel] [PATCH qom-cpu 35/59] linux-user: Simplify start_exclusive()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber --- linux-user/main.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 95e17cf..5ced658 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -144,25

[Qemu-devel] [PATCH qom-cpu 21/59] gdbstub: Set gdb_set_stop_cpu() argument to CPUState

2013-06-09 Thread Andreas Färber
Use CPUState::env_ptr for now. Signed-off-by: Andreas Färber --- cpus.c | 2 +- gdbstub.c | 4 +++- include/exec/gdbstub.h | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/cpus.c b/cpus.c index f07618f..dba69bc 100644 --- a/cpus.c +++ b/cpus.c @

[Qemu-devel] [PATCH qom-cpu 23/59] cpus: Change qemu_kvm_start_vcpu() argument to CPUState

2013-06-09 Thread Andreas Färber
Pass it on to qemu_kvm_cpu_thread_fn(). Signed-off-by: Andreas Färber --- cpus.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/cpus.c b/cpus.c index f629a15..18dba18 100644 --- a/cpus.c +++ b/cpus.c @@ -732,14 +732,13 @@ static void qemu_kvm_wait_io_event(CPUS

[Qemu-devel] [PATCH qom-cpu 39/59] translate-all: Abstract tb_phys_invalidate() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- translate-all.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/translate-all.c b/translate-all.c index 78a6f4d..8e98a13 100644 --- a/translate-all.c +++ b/translate-all.c @@ -819,14 +819,31 @@ static inline void t

[Qemu-devel] [PATCH qom-cpu 11/59] monitor: Simplify do_inject_mce()

2013-06-09 Thread Andreas Färber
Use qemu_get_cpu() to avoid open-coded CPU loop. Signed-off-by: Andreas Färber --- monitor.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/monitor.c b/monitor.c index 6e22d15..19c297d 100644 --- a/monitor.c +++ b/monitor.c @@ -2013,7 +2013,6 @@ static void do

[Qemu-devel] [PATCH qom-cpu 26/59] hwaddr: Make hwaddr type usable beyond softmmu

2013-06-09 Thread Andreas Färber
While not normally needed for *-user, it can safely be used there since always based on uint64_t, to avoid ifdeffery. To avoid accidental uses, move the guards from exec/hwaddr.h to its inclusion sites. No need for them in include/hw/. Prepares for hwaddr use in qom/cpu.h. Signed-off-by: Andrea

[Qemu-devel] [PATCH qom-cpu 14/59] cpus: Change cpu_thread_is_idle() argument to CPUState

2013-06-09 Thread Andreas Färber
It no longer needs CPUArchState. Signed-off-by: Andreas Färber --- cpus.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/cpus.c b/cpus.c index b2b20c3..fcef422 100644 --- a/cpus.c +++ b/cpus.c @@ -62,10 +62,8 @@ static CPUArchState *next_cpu; -static bool cpu_th

[Qemu-devel] [PATCH qom-cpu 41/59] target-mips: Abstract helper_dvpe() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-mips/op_helper.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c index f6838ec..077e81c 100644 --- a/target-mips/op_helper.c +++ b/target-mips/op_helper.c @@

[Qemu-devel] [PATCH qom-cpu 25/59] cpu: Change qemu_init_vcpu() argument to CPUState

2013-06-09 Thread Andreas Färber
This allows to move the call to CPUState's realizefn. Therefore move the stub into libqemustub.a. Signed-off-by: Andreas Färber --- cpus.c | 5 + include/qemu-common.h | 8 include/qom/cpu.h | 8 qom/cpu.c | 2 ++ stubs

[Qemu-devel] [PATCH qom-cpu 18/59] cpu: Turn cpu_dump_{state, statistics}() into CPUState hooks

2013-06-09 Thread Andreas Färber
Make cpustats monitor command available unconditionally. Signed-off-by: Andreas Färber --- bsd-user/main.c | 3 ++- cpus.c| 2 +- exec.c| 3 ++- include/exec/cpu-all.h| 10 -- include/qemu/log.h| 2 +-

[Qemu-devel] [PATCH qom-cpu 28/59] cpu: Replace cpu_single_env with CPUState cpu_single_cpu

2013-06-09 Thread Andreas Färber
Fiddle with include order to ensure CPUState is defined before cpu_single_cpu. Signed-off-by: Andreas Färber --- cpu-exec.c | 13 +++-- cpus.c | 29 ++--- exec.c | 12 +++- hw/alpha/typhoon.c | 16 ---

[Qemu-devel] [PATCH qom-cpu 24/59] cpus: Change qemu_dummy_start_vcpu() argument to CPUState

2013-06-09 Thread Andreas Färber
Pass it to qemu_dummy_cpu_thread_fn(). Use CPUState::env_ptr for cpu_single_env. Signed-off-by: Andreas Färber --- cpus.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/cpus.c b/cpus.c index 18dba18..2651361 100644 --- a/cpus.c +++ b/cpus.c @@ -771,8 +771,7 @

[Qemu-devel] [PATCH qom-cpu 49/59] cpus: Abstract all_vcpus_paused() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Change return type from int to bool while at it. Signed-off-by: Andreas Färber --- cpus.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/cpus.c b/cpus.c index 506a0c8..3856bf1 100644 --- a/cpus.c +++ b/cpus.c @@ -946,19 +946,21 @@ void qemu_mutex_unlock

[Qemu-devel] [PATCH qom-cpu 27/59] cpu: Turn cpu_unassigned_access() into a CPUState hook

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- cputlb.c | 15 +-- hw/alpha/typhoon.c| 14 ++ include/qom/cpu.h | 33 + memory.c | 10 -- target-alpha/cpu.c| 1 + targe

[Qemu-devel] [PATCH qom-cpu 50/59] cpus: Abstract qmp_query_cpus() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- cpus.c | 75 ++ 1 file changed, 43 insertions(+), 32 deletions(-) diff --git a/cpus.c b/cpus.c index 3856bf1..a0b8e6b 100644 --- a/cpus.c +++ b/cpus.c @@ -1205,49 +1205,60 @@ void list_cpus(FILE *f,

[Qemu-devel] [PATCH qom-cpu 30/59] exec: Simplify tcg_commit()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber --- exec.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/exec.c b/exec.c index e14a815..91618fb 100644 --- a/exec.c +++ b/exec.c @@ -1705,16 +1705,19 @@ static void core_begin(MemoryListener *listener)

[Qemu-devel] [PATCH qom-cpu 33/59] kvm: Simplify kvm_remove_all_breakpoints() further

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber --- kvm-all.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index d5ed831..312106d 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1986,24 +1986,36 @@ int kvm_remove_br

[Qemu-devel] [PATCH qom-cpu 56/59] spapr_rtas: Abstract rtas_start_cpu() with qemu_get_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/ppc/spapr_rtas.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c index a67ffcd..42ed7dc 100644 --- a/hw/ppc/spapr_rtas.c +++ b/hw/ppc/spapr_rtas.c @@ -160,8 +160,7 @@ static v

[Qemu-devel] [PATCH qom-cpu 29/59] cputlb: Simplify cpu_tlb_reset_dirty_all()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber --- cputlb.c | 35 --- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/cputlb.c b/cputlb.c index f7cc4b4..748d0f6 100644 --- a/cputlb.c +++ b/cputlb.c @@ -173,24 +173,37 @@ static inline vo

[Qemu-devel] [PATCH qom-cpu 34/59] kvm: Change kvm_remove_all_breakpoints() argument to CPUState

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c| 2 +- include/sysemu/kvm.h | 2 +- kvm-all.c| 5 ++--- kvm-stub.c | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 1bee3dc..e05cd66 100644 --- a/gdbstub.c +++ b/gdbstub

[Qemu-devel] [PATCH qom-cpu 32/59] kvm: Simplify kvm_{insert, remove, remove_all}_breakpoint[s]()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber --- kvm-all.c | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 90b89cd..d5ed831 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1891,12 +1891,22 @@ int kvm

[Qemu-devel] [PATCH qom-cpu 31/59] monitor: Simplify do_info_numa()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber --- monitor.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/monitor.c b/monitor.c index 9be515c..f37bf3d 100644 --- a/monitor.c +++ b/monitor.c @@ -1803,21 +1803,32 @@ static void do_inf

[Qemu-devel] [PATCH qom-cpu 40/59] target-ppc: Abstract helper_msgsnd() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-ppc/excp_helper.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_helper.c index 4a0fc6d..b09aafc 100644 --- a/target-ppc/excp_helper.c +++ b/target-ppc/excp_helper.c @

[Qemu-devel] [PATCH qom-cpu 58/59] linux-user: Change thread_env to CPUState

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- linux-user/elfload.c | 16 +--- linux-user/linuxload.c | 3 ++- linux-user/main.c | 10 +- linux-user/qemu.h | 2 +- linux-user/signal.c| 12 +++- linux-user/syscall.c | 6 +++--- 6 files changed, 27 insertions(+),

[Qemu-devel] [PATCH qom-cpu 38/59] translate-all: Abstract tb_flush() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- translate-all.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/translate-all.c b/translate-all.c index c399a28..78a6f4d 100644 --- a/translate-all.c +++ b/translate-all.c @@ -675,12 +675,17 @@ static void page_flush_tb(void)

[Qemu-devel] [PATCH qom-cpu 36/59] linux-user/elfload: Abstract fill_note_info() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Eliminates a confusing CPUArchState *cpu variable. Signed-off-by: Andreas Färber --- linux-user/elfload.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index ddef23e..cb21487 100644 --- a/linux-user/elfload.c +

[Qemu-devel] [PATCH qom-cpu 42/59] target-mips: Abstract helper_evpe() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-mips/op_helper.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c index 077e81c..6c64d83 100644 --- a/target-mips/op_helper.c +++ b/target-mips/op_helpe

[Qemu-devel] [PATCH qom-cpu 51/59] exec: Abstract qemu_get_cpu() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- exec.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/exec.c b/exec.c index 91618fb..d2e790c 100644 --- a/exec.c +++ b/exec.c @@ -262,20 +262,29 @@ static const VMStateDescription vmstate_cpu_common = { #defin

[Qemu-devel] [PATCH qom-cpu 37/59] target-i386: Abstract cpu_x86_inject_mce() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-i386/helper.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index 5e5abe3..d928e82 100644 --- a/target-i386/helper.c +++ b/target-i386/helper.c @@ -1184,6 +11

[Qemu-devel] [PATCH qom-cpu 55/59] spapr_rtas: Abstract rtas_query_cpu_stopped_state() with qemu_get_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/ppc/spapr_rtas.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c index 48cea4b..a67ffcd 100644 --- a/hw/ppc/spapr_rtas.c +++ b/hw/ppc/spapr_rtas.c @@ -130,7 +130,6 @@ static void rtas_query

[Qemu-devel] [PATCH qom-cpu 47/59] spapr: Abstract spapr_fix_cpu_dt() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/ppc/spapr.c | 91 ++ 1 file changed, 53 insertions(+), 38 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 218ea23..53b603d 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -128,53 +128

[Qemu-devel] [PATCH qom-cpu 52/59] gdbstub: Abstract gdb_breakpoint_{insert, remove}() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 106 +- 1 file changed, 77 insertions(+), 29 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index e05cd66..eb47068 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1944,10 +1944,46 @@ static cons

[Qemu-devel] [PATCH qom-cpu 57/59] cpu: Make first_cpu and next_cpu CPUState (WIP)

2013-06-09 Thread Andreas Färber
TODO: gdbstub TBD: linux-user thread_env Signed-off-by: Andreas Färber --- cpus.c| 15 +-- exec.c| 27 ++- gdbstub.c | 15 --- hw/arm/boot.c | 10 +- hw/arm/exynos4_boards.

[Qemu-devel] [PATCH qom-cpu 43/59] kvmclock: Abstract kvmclock_vm_state_change() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/i386/kvm/clock.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c index 87d4d0f..eaeb0ff 100644 --- a/hw/i386/kvm/clock.c +++ b/hw/i386/kvm/clock.c @@ -61,13 +61,25 @@ st

[Qemu-devel] [PATCH qom-cpu 54/59] spapr: Abstract spapr_create_fdt_skel() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/ppc/spapr.c | 212 ++--- 1 file changed, 113 insertions(+), 99 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 53b603d..c8461da 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -237,6 +237

[Qemu-devel] [PATCH qom-cpu 44/59] kvmvapic: Abstract vapic_enable_tpr_reporting() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/i386/kvmvapic.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c index 9aac9de..dfb1085 100644 --- a/hw/i386/kvmvapic.c +++ b/hw/i386/kvmvapic.c @@ -485,19 +485,21 @@ static void

[Qemu-devel] [PATCH qom-cpu 45/59] pc: Abstract pic_irq_request() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/i386/pc.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 71d9019..28c9c6e 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -183,18 +183,23 @@ int cpu_get_pic_interrupt(CPUX86State *env)

[Qemu-devel] [PATCH qom-cpu 46/59] ppc: Abstract ppce500_set_mpic_proxy() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/ppc/ppc.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index fb57b42..31f3dc4 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -437,22 +437,23 @@ void ppce500_irq_init(CPUPPCState *env

[Qemu-devel] [PATCH qom-cpu 53/59] gdbstub: Abstract gdb_breakpoint_remove_all() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index eb47068..9400abd 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2059,21 +2059,24 @@ static int gdb_breakpoint_remove(target_ulong addr, tar

[Qemu-devel] [PATCH qom-cpu 48/59] cpus: Abstract all_cpu_threads_idle() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- cpus.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/cpus.c b/cpus.c index 7428389..506a0c8 100644 --- a/cpus.c +++ b/cpus.c @@ -77,16 +77,24 @@ static bool cpu_thread_is_idle(CPUState *cpu) return true; } -st

[Qemu-devel] [PATCH qom-cpu 59/59] bsd-user: Change thread_env to CPUState

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- bsd-user/elfload.c | 6 -- bsd-user/main.c| 6 +++--- bsd-user/qemu.h| 2 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index 5e20510..93fd9e4 100644 --- a/bsd-user/elfload.c +++ b/bsd-user/e

Re: [Qemu-devel] [PATCH qom-cpu 57/59] cpu: Make first_cpu and next_cpu CPUState (WIP)

2013-06-09 Thread Andreas Färber
Sorry, forgot to update the commit message! Am 09.06.2013 21:13, schrieb Andreas Färber: > TODO: gdbstub This was referring to changing gdbstub's c_cpu and g_cpu fields to CPUState - but considering the length of this series, that is left as a follow-up. > TBD: linux-user thread_env Addressed b

[Qemu-devel] [PATCH v4] target-ppc: Introduce unrealizefn for PowerPCCPU

2013-06-09 Thread Andreas Färber
Use it to clean up the opcode table, resolving a former TODO from Jocelyn. Also switch from malloc() to g_malloc(). Signed-off-by: Andreas Färber --- v3 -> v4: * Introduced PPC_CPU_OPCODES_LEN constant to avoid magic 0x40 (requested by Alex). From "QOM'ify Power Architecture CPU" v2: * Impl

[Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test

2013-06-09 Thread Stefan Weil
cppcheck detected a condition which was always false. According to the MCIMX31 Reference Manual, the PRCS bits have to be 01 to select the Frequency Pre-Multiplier (FPM). PRCS uses bits 1 and 2, so we have to test for 2. Signed-off-by: Stefan Weil --- hw/misc/imx_ccm.c |2 +- 1 file changed

[Qemu-devel] [PATCH 1/3] mpc8544_guts: Fix MemoryRegion name

2013-06-09 Thread Andreas Färber
6544 -> 8544 Signed-off-by: Andreas Färber --- hw/ppc/mpc8544_guts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/mpc8544_guts.c b/hw/ppc/mpc8544_guts.c index 193beab..98540a4 100644 --- a/hw/ppc/mpc8544_guts.c +++ b/hw/ppc/mpc8544_guts.c @@ -115,7 +115,7 @@ static

[Qemu-devel] [PATCH 3/3] mpc8544_guts: Turn qdev initfn into instance_init

2013-06-09 Thread Andreas Färber
SysBus can deal with NULL SysBusDeviceClass::init since 4ce5dae. Signed-off-by: Andreas Färber --- hw/ppc/mpc8544_guts.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/hw/ppc/mpc8544_guts.c b/hw/ppc/mpc8544_guts.c index f623b04..d41f615 100644 --- a/hw/pp

  1   2   >