[Qemu-devel] [PULL 1/2] vmxnet3: fix NICState cleanup

Use qemu_del_nic() instead of qemu_del_net_client() to correctly free the entire NICState. Cc: qemu-sta...@nongnu.org Reported-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- hw/net/vmxnet3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxn

[Qemu-devel] [PULL 2/2] tap: fix NULL dereference when passing invalid parameters to tap

From: Jason Wang This patch forbid the following invalid parameters to tap: 1) fd and vhostfds were specified but vhostfd were not specified 2) vhostfds were specified but fds were not specified 3) fds and vhostfd were specified For 1 and 2, net_init_tap_one() will still pass NULL as vhostfdnam

Re: [Qemu-devel] [PATCH 01/39] scsi: keep device alive while it has requests

Andreas Färber writes: > Am 04.06.2013 20:51, schrieb Paolo Bonzini: >> Signed-off-by: Paolo Bonzini >> --- >> hw/scsi/scsi-bus.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c >> index 53ea906..e443193 100644 >> --- a/hw/scsi/scsi-bus.c

Re: [Qemu-devel] [PATCH 02/39] dma: keep a device alive while it has SGLists

Andreas Färber writes: > Am 04.06.2013 20:51, schrieb Paolo Bonzini: >> A QEMUSGList has a reference to a device's address space. Keep >> the device alive while the QEMUSGList exists. >> >> Signed-off-by: Paolo Bonzini >> --- >> dma-helpers.c | 6 +- >> hw/ide/ahci.c | 3

Re: [Qemu-devel] [PATCH 03/39] pci: split exit and finalize

Paolo Bonzini writes: > To properly support devices that do DMA out of the BQL, destruction > needs to be done in two phases. First, the device is unrealized; > at this point, pending memory accesses can still be completed, but > no new accesses will be started. The second part is freeing the >

Re: [Qemu-devel] [PATCH 2/2] usb/host-libusb: Fix building with libusb git master code

On 6 June 2013 10:39, Hans de Goede wrote: > +#if LIBUSBX_API_VERSION >= 0x01000102 > +rc = libusb_get_port_numbers(dev, path, 7); > +#else > rc = libusb_get_port_path(ctx, dev, path, 7); > +#endif I just added libusb_get_port_numbers to FreeBSD's libusb, but we don't have LIBUSBX_API_VE

[Qemu-devel] [PATCH v2 0/2] fix 'qemu-img snapshot -a' operation for sheepdog

v2: - add the comment to make things more clear - call sd_create_branch() after s->is_snapshot = true because after calling sd_create_branch, it is not snapshot anymore. Nothing big, just two simple patches to enable this commind for sheepdog. Cc: qemu-devel@nongnu.org Cc: MORITA Kazutaka C

[Qemu-devel] [PATCH v2 2/2] sheepdog: support 'qemu-img snapshot -a'

Just call sd_create_branch() to rollback the image is good enough Cc: qemu-devel@nongnu.org Cc: MORITA Kazutaka Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/sheepdog.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/block/sheepd

Re: [Qemu-devel] [PATCH v2 16/16] Make qemu-io commands available in HMP

On Wed, 5 Jun 2013 14:19:41 +0200 Kevin Wolf wrote: > It was decided to not make this command available in QMP in order to > make clear that this is not supposed to be a stable API and should be > used only for testing and debugging purposes. I like this as a temporary solution. But I also see

[Qemu-devel] [PATCH v2 1/2] sheepdog: fix snapshot tag initialization

This is an old and obvious bug. We should pass snapshot_id to the tag. Or simple command like 'qemu-img snapshot -a tag sheepdog:image' will fail Cc: qemu-devel@nongnu.org Cc: MORITA Kazutaka Cc: Kevin Wolf Cc: Stefan Hajnoczi Reviewed-by: Kevin Wolf Signed-off-by: Liu Yuan --- block/sheepdo

[Qemu-devel] Qemu crashed while unpluging IDE disk

While starting a Fedora_14 guest, we came across a segfault of qemu: the logs in /var/log/messages are: Jun 1 02:38:56 NC587 kernel: [403549.565754] show_signal_msg: 136 callbacks suppressed Jun 1 02:38:56 NC587 kernel: [403549.565758] qemu-system-i38[25840]: segfault at 28 ip 00418d9

Re: [Qemu-devel] [PATCH] script: git script to compile every commit in a range of commits

On Thu, Jun 06, 2013 at 10:58:25AM +0200, Laszlo Ersek wrote: > comments below > > On 05/31/13 18:39, Jeff Cody wrote: > > > +usage() { > > +echo "" > > +echo "$0 [OPTIONS]" > > +echo "$desc" > > +echo "" > > +echo "OPTIONS:" > > +echo " -r git range > > +

Re: [Qemu-devel] [PATCH v4] qemu-char: don't issue CHR_EVENT_OPEN in a BH

On Fri, Jun 07, 2013 at 09:50:39AM -0400, Luiz Capitulino wrote: > On Tue, 4 Jun 2013 16:35:09 -0500 > Michael Roth wrote: > > > When CHR_EVENT_OPENED was initially added, it was CHR_EVENT_RESET, > > and it was issued as a bottom-half: > > > > 86e94dea5b740dad65446c857f6959eae43e0ba6 > > > > W

Re: [Qemu-devel] [PATCH v2] create qemu_openpty_raw() helper function and move it to a separate file

On 05/06/13 11:25 AM, Michael Tokarev wrote: In two places qemu uses openpty() which is very system-dependent, and in both places the pty is switched to raw mode as well. Make a wrapper function which does both steps, and move all the system-dependent complexity into a separate file, together wit

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

Am 07.06.2013 um 15:48 hat Liu Yuan geschrieben: > On 06/07/2013 03:31 PM, Kevin Wolf wrote: > > Am 06.06.2013 um 15:09 hat Liu Yuan geschrieben: > >> On 06/06/2013 08:46 PM, Kevin Wolf wrote: > >>> Am 06.06.2013 um 13:57 hat Liu Yuan geschrieben: > >> Only when the write comes from VM, we do the f

Re: [Qemu-devel] [PATCH v4] qemu-char: don't issue CHR_EVENT_OPEN in a BH

On Fri, 7 Jun 2013 09:56:00 -0500 mdroth wrote: > On Fri, Jun 07, 2013 at 09:50:39AM -0400, Luiz Capitulino wrote: > > On Tue, 4 Jun 2013 16:35:09 -0500 > > Michael Roth wrote: > > > > > When CHR_EVENT_OPENED was initially added, it was CHR_EVENT_RESET, > > > and it was issued as a bottom-half

Re: [Qemu-devel] [PATCH] script: git script to compile every commit in a range of commits

On 06/07/13 16:44, Jeff Cody wrote: > Thanks. I can either do the above changes for a v2, or as follow on > patches. Whichever is easier for you, certainly! I'm fine with the script going-in as is. Cheers, Laszlo

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

On 06/07/2013 11:22 PM, Kevin Wolf wrote: > Am 07.06.2013 um 15:48 hat Liu Yuan geschrieben: >> On 06/07/2013 03:31 PM, Kevin Wolf wrote: >>> Am 06.06.2013 um 15:09 hat Liu Yuan geschrieben: On 06/06/2013 08:46 PM, Kevin Wolf wrote: > Am 06.06.2013 um 13:57 hat Liu Yuan geschrieben: O

Re: [Qemu-devel] [PATCH, resend] linux-user: environment variables

Hi! On Wed, 29 May 2013 15:50:30 +0200, I wrote: > I'm resending here the patches previously posted and described in the thread > starting at > . > In short, fix a bug in util/envlist, code simplification, and the

[Qemu-devel] [PATCH 1/3] target-arm: add feature flag for ARMv8

Signed-off-by: Mans Rullgard --- target-arm/cpu.c | 5 - target-arm/cpu.h | 1 + target-arm/translate.c | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/target-arm/cpu.c b/target-arm/cpu.c index 496a59f..f5a1314 100644 --- a/target-arm/cpu.c +++ b/target-arm/cp

[Qemu-devel] [PATCH 3/3] target-arm: explicitly decode SEVL instruction

The ARMv8 SEVL instruction is in the architectural hint space already emulated as nop. This makes the decoding of SEVL explicit for clarity. Signed-off-by: Mans Rullgard --- target-arm/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-arm/translate.c b/target-arm/translate.

[Qemu-devel] [PATCH 2/3] target-arm: implement LDA/STL instructions

This adds support for the ARMv8 load acquire/store release instructions. Since qemu does nothing special for memory barriers, these can be emulated like their non-acquire/release counterparts. Signed-off-by: Mans Rullgard --- target-arm/translate.c | 91 ++

Re: [Qemu-devel] [PATCH] script: git script to compile every commit in a range of commits

Hi Jeff, On Sat, Jun 1, 2013 at 2:39 AM, Jeff Cody wrote: > This is a git script that will iterate through every commit in a > specified range, and perform a configure and make. The intention of > this script is not to act as a check of code correctness, but to see if > any commit breaks compila

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

Am 07.06.2013 um 18:14 hat Liu Yuan geschrieben: > On 06/07/2013 11:22 PM, Kevin Wolf wrote: > > Am 07.06.2013 um 15:48 hat Liu Yuan geschrieben: > >> On 06/07/2013 03:31 PM, Kevin Wolf wrote: > >>> Am 06.06.2013 um 15:09 hat Liu Yuan geschrieben: > On 06/06/2013 08:46 PM, Kevin Wolf wrote: >

Re: [Qemu-devel] [PATCH] script: git script to compile every commit in a range of commits

Laszlo Ersek writes: > On 06/07/13 16:44, Jeff Cody wrote: > >> Thanks. I can either do the above changes for a v2, or as follow on >> patches. > > Whichever is easier for you, certainly! I'm fine with the script > going-in as is. A suggestion I'll make is to split the script into two parts. gi

[Qemu-devel] [PATCH v3 0/2] fix 'qemu-img snapshot -a' operation for sheepdog

v3: - fix sheepdog's loadvm handling, don't rely on the write to create branch v2: - add the comment to make things more clear - call sd_create_branch() after s->is_snapshot = true because after calling sd_create_branch, it is not snapshot anymore. Nothing big, just two simple patches to en

[Qemu-devel] [PATCH v3 1/2] sheepdog: fix snapshot tag initialization

This is an old and obvious bug. We should pass snapshot_id to the tag. Or simple command like 'qemu-img snapshot -a tag sheepdog:image' will fail Cc: qemu-devel@nongnu.org Cc: MORITA Kazutaka Cc: Kevin Wolf Cc: Stefan Hajnoczi Reviewed-by: Kevin Wolf Signed-off-by: Liu Yuan --- block/sheepdo

[Qemu-devel] [PATCH v3 2/2] sheepdog: support 'qemu-img snapshot -a'

Just call sd_create_branch() in the snapshot_goto to rollback the image is good enough. With this patch, 'loadvm' process for sheepdog is modified: Suppose we have a snapshot chain A --> B --> C, we do 'loadvm A' so as to get a new chain, A --> B | V C1 in the old code: 1 reload inode of A (in

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

On 06/08/2013 12:48 AM, Kevin Wolf wrote: > Hm, yes, I was confused. :-) > > Anyway, the options stay the same: Either C1 must somehow inherit the VM > state from A on the Sheepdog level, or we must make sure to get this > order: > > 1. Switch to (read-only) snapshot A > 2. Load the VM state > 3.

[Qemu-devel] [PATCH 4/8] [PATCH RFC v2] s390-qemu: cpu hotplug - ipi_states enhancements

From: "Jason J. Herne" Modify s390_cpu_addr2state to allow fetching state information for cpu addresses above the number of online cpus. Hotplug requires this capability. Also add s390_cpu_set_state function to allow modification of ipi_state entries during hotplug. Finally, add function to fi

[Qemu-devel] [PATCH 3/8] [PATCH RFC v2] s390-qemu: cpu hotplug - SCLP Event integration

From: "Jason J. Herne" Add an sclp event for "cpu was hot plugged". This allows Qemu to deliver an SCLP interrupt to the guest stating that the requested cpu hotplug was completed. Signed-off-by: Jason J. Herne --- hw/s390x/Makefile.objs|2 +- hw/s390x/event-facility.c

[Qemu-devel] [PATCH 5/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Introduce post-cpu-init function

From: "Jason J. Herne" In preparation for treating cpus as devices we need to separate machine initialization into two stages: 1. Initialization that needs to be done before cpu devices can be created. 2. Initialization that requires cpu devices to already be created. This is accomplished by cre

[Qemu-devel] [PATCH 2/8] [PATCH RFC v2] s390-qemu: cpu hotplug - SCLP CPU Info

From: "Jason J. Herne" Implement the CPU data in SCLP "Read SCP Info". And implement "Read CPU Info" SCLP command. This data will be used by the guest to get information about hot plugged cpus. Signed-off-by: Jason J. Herne --- hw/s390x/sclp.c | 38 ++

[Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

From: "Jason J. Herne" Modify cpu initialization and QOM routines associated with s390-cpu such that all cpus on S390 are now created via the QOM device creation code path. Signed-off-by: Jason J. Herne --- hw/s390x/s390-virtio-ccw.c | 15 ++- hw/s390x/s390-virtio.c | 25 ++

[Qemu-devel] [PATCH 0/8] [PATCH RFC v2] s390-qemu: cpu hotplug

Latest code for cpu Hotplug designed to be controled via the QOM infrastructure. cpu on S390 are treated as devices via a new platform independent infrastructure I designed to allow this "new way" to exist with the "old way" of representing cpus. The Qemu command line now allows "-device s390-cpu"

[Qemu-devel] [PATCH 7/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Infrastructure for Cpu Devices

From: "Jason J. Herne" Add infrastructure for treating cpus as devices. This patch allows cpus to be specified using a combination of '-smp' and '-device cpu'. This approach forces a change in the way cpus are counted via smp_cpus. Signed-off-by: Jason J. Herne --- include/hw/boards.h |3

[Qemu-devel] [PATCH 6/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Storage key Global Access

From: "Jason J. Herne" In preparation for treating cpus as devices we refactor the code such that cpu initialization no longer relies on cpu 0 to obtain a pointer to the storage key data. This patch introduces global access to that data. Signed-off-by: Jason J. Herne --- hw/s390x/s390-virtio-

[Qemu-devel] [PATCH 1/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Define New SCLP Codes

From: "Jason J. Herne" Define new SCLP codes to improve code readability. Signed-off-by: Jason J. Herne --- hw/s390x/sclp.c |2 +- include/hw/s390x/sclp.h |8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c index 86d6ae0.

Re: [Qemu-devel] [PATCH v3 0/2] fix 'qemu-img snapshot -a' operation for sheepdog

On 06/08/2013 01:20 AM, Liu Yuan wrote: > v3: > - fix sheepdog's loadvm handling, don't rely on the write to create branch Oops, seems this version has problems. Please drop it. Thanks, Yuan

[Qemu-devel] [PATCH v4 0/2] fix 'qemu-img snapshot -a' operation for sheepdog

v4: - fix savevm, pass current vdi_id instead of parent_vdi_id v3: - fix sheepdog's loadvm handling, don't rely on the write to create branch v2: - add the comment to make things more clear - call sd_create_branch() after s->is_snapshot = true because after calling sd_create_branch, it is

[Qemu-devel] [PATCH 1/2] sheepdog: fix snapshot tag initialization

This is an old and obvious bug. We should pass snapshot_id to the tag. Or simple command like 'qemu-img snapshot -a tag sheepdog:image' will fail Cc: qemu-devel@nongnu.org Cc: MORITA Kazutaka Cc: Kevin Wolf Cc: Stefan Hajnoczi Reviewed-by: Kevin Wolf Signed-off-by: Liu Yuan --- block/sheepdo

[Qemu-devel] [PATCH v4 2/2] sheepdog: support 'qemu-img snapshot -a'

Just call sd_create_branch() in the snapshot_goto to rollback the image is good enough. With this patch, 'loadvm' process for sheepdog is modified: Suppose we have a snapshot chain A --> B --> C, we do 'loadvm A' so as to get a new chain, A --> B | V C1 in the old code: 1 reload inode of A (in

Re: [Qemu-devel] [PATCH] linux-user: add SIOCADDRT/SIOCDELRT support

Ping Le 27/05/2013 20:48, Laurent Vivier a écrit : This allows to pass the device name. You can test this with the "route" command. WITHOUT this patch: $ sudo route add -net default gw 10.0.3.1 eth0 SIOCADDRT: Bad address $ netstat -nr Kernel IP routing table Destination Gateway

[Qemu-devel] [PATCH RFT 4/5] virtio-console: Use exitfn for virtserialport, too

virtconsole and virtserialport are identical in every other aspect except for the distinguishing VirtIOSerialPortClass::is_console field. Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber --- hw/char/virtio-console.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/char/virtio-conso

[Qemu-devel] [PATCH RFT 1/5] virtio-blk-dataplane: Improve error reporting

Return an Error so that it can be propagated later. Signed-off-by: Andreas Färber --- hw/block/dataplane/virtio-blk.c | 25 + hw/block/dataplane/virtio-blk.h | 5 +++-- hw/block/virtio-blk.c | 8 +++- 3 files changed, 23 insertions(+), 15 deletions(-) dif

[Qemu-devel] [PATCH RFT 2/5] virtio: Convert VirtioDevice to QOM realize/unrealize

VirtioDevice's DeviceClass::exit code cleaning up bus_name is no longer overwritten by virtio-{blk,serial,net,scsi,balloon,rng} and vhost-scsi. Note: VirtIOSCSI and VHostSCSI now perform some initializations after VirtIOSCSICommon's realize calls virtio_bus_plug_device(), namely creating the SCSIB

[Qemu-devel] [PATCH RFT 0/5] QOM realize for virtio

Hello, This series converts virtio devices to QOM realize/unrealize. It is intended as base for fixing virtio-net initialization order issues, as reported by Jesse. Only partially tested though. Note that while VirtioDevice was setting a DeviceClass::exit callback for cleaning up the bus name, th

[Qemu-devel] [PATCH RFT 3/5] virtio-console: QOM'ify VirtConsole

Introduce type constant, cast macro and rename parent field. Signed-off-by: Andreas Färber --- hw/char/virtio-console.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c index 6759e51..7b1a3

[Qemu-devel] [PATCH RFT 5/5] virtio-serial-port: Convert to QOM realize/unrealize

Note: virtconsole's/virtserialport's realizefn now registers its handlers before VirtIOSerialPort's realizefn. Signed-off-by: Andreas Färber --- hw/char/virtio-console.c | 71 --- hw/char/virtio-serial-bus.c | 45 ++--- inclu

[Qemu-devel] [PATCH] gtk: use better icon

The current icon looks pretty terrible rendered in Gnome. This switches to a transparent SVG which looks much nicer. Signed-off-by: Anthony Liguori --- Makefile | 2 +- pc-bios/qemu_logo_no_text.svg | 976 ++ ui/gtk.c

Re: [Qemu-devel] [PATCH] script: git script to compile every commit in a range of commits

On Sat, Jun 08, 2013 at 02:36:33AM +1000, Peter Crosthwaite wrote: > Hi Jeff, > > On Sat, Jun 1, 2013 at 2:39 AM, Jeff Cody wrote: > > This is a git script that will iterate through every commit in a > > specified range, and perform a configure and make. The intention of > > this script is not t

[Qemu-devel] [PATCH 4/9] block: mirror_complete(): use error_setg_file_open()

Signed-off-by: Luiz Capitulino --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 8b07dec..89d531d 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -512,7 +512,7 @@ static void mirror_complete(BlockJob *job, Error **errp

[Qemu-devel] [PATCH 1/9] error: add error_setg_file_open() helper

Signed-off-by: Luiz Capitulino --- include/qapi/error.h | 5 + util/error.c | 5 + 2 files changed, 10 insertions(+) diff --git a/include/qapi/error.h b/include/qapi/error.h index 5cd2f0c..ffd1cea 100644 --- a/include/qapi/error.h +++ b/include/qapi/error.h @@ -45,6 +45,11 @@ voi

[Qemu-devel] [PATCH 0/9] QMP/HMP: add error reason to open failures

Today I was surprised to find out that we still have old users of QERR_OPEN_FILE_FAILED that print errors like: (qemu) dump-guest-memory -p /lkmads/foo Could not open '/lkmads/foo' (qemu) This series converts all those users to a new helper called error_setg_file_open(), which adds error reason

[Qemu-devel] [PATCH 3/9] block: bdrv_reopen_prepare(): use error_setg_file_open()

Signed-off-by: Luiz Capitulino --- block.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block.c b/block.c index 79ad33d..c78f152 100644 --- a/block.c +++ b/block.c @@ -1291,8 +1291,7 @@ int bdrv_reopen_prepare(BDRVReopenState *reopen_state, BlockReopenQueue *queue,

[Qemu-devel] [PULL 3/3] MAINTAINERS: split Monitor (QMP/HMP) entry

This entry doesn't reflect reality for a few years now. This commit splits it into Human Monitor (HMP), QAPI and QMP. Markus is dropped as a maintainer. This is what we have been for the last few years. Also, it's going to help me to offload some of this work to someone else in the near future. S

[Qemu-devel] [PULL 0/3] QMP queue

The changes (since 7387de16d0e4d2988df350926537cd12a8e34206) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Luiz Capitulino (2): MAINTAINERS: new maintainers for qapi-schema.json MAINTAINERS: split Monitor (QMP/HMP) entry Marcelo Tosatti (1):

[Qemu-devel] [PATCH 5/9] blockdev: use error_setg_file_open()

Signed-off-by: Luiz Capitulino --- blockdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 9937311..c09adba 100644 --- a/blockdev.c +++ b/blockdev.c @@ -899,7 +899,7 @@ static void external_snapshot_prepare(BlkTransactionStates *common,

[Qemu-devel] [PULL 1/3] correct RTC_CHANGE_EVENT description

From: Marcelo Tosatti Fix RTC_CHANGE event description to match implementation. Signed-off-by: Marcelo Tosatti Signed-off-by: Luiz Capitulino --- QMP/qmp-events.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt index 92fe5fb..00b

[Qemu-devel] [PATCH 6/9] cpus: use error_setg_file_open()

Signed-off-by: Luiz Capitulino --- cpus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index c232265..c8bc8ad 100644 --- a/cpus.c +++ b/cpus.c @@ -1278,7 +1278,7 @@ void qmp_memsave(int64_t addr, int64_t size, const char *filename, f = fopen(file

[Qemu-devel] [PATCH 8/9] savevm: qmp_xen_save_devices_state(): use error_setg_file_open()

Signed-off-by: Luiz Capitulino --- savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/savevm.c b/savevm.c index 2ce439f..ff5ece6 100644 --- a/savevm.c +++ b/savevm.c @@ -2410,7 +2410,7 @@ void qmp_xen_save_devices_state(const char *filename, Error **errp) f = qem

[Qemu-devel] [PATCH 7/9] dump: qmp_dump_guest_memory(): use error_setg_file_open()

Signed-off-by: Luiz Capitulino --- dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dump.c b/dump.c index c0d3da5..28fd296 100644 --- a/dump.c +++ b/dump.c @@ -847,7 +847,7 @@ void qmp_dump_guest_memory(bool paging, const char *file, bool has_begin, if (strstart(f

[Qemu-devel] [PATCH 9/9] qerror: drop QERR_OPEN_FILE_FAILED macro

Not used since the last commit. Signed-off-by: Luiz Capitulino --- include/qapi/qmp/qerror.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h index 6c0a18d..c30c2f6 100644 --- a/include/qapi/qmp/qerror.h +++ b/include/qapi/qmp/qerror.h @

[Qemu-devel] [PULL 2/3] MAINTAINERS: new maintainers for qapi-schema.json

I'm facing two problems lately wrt QMP patch review: increasingly lack of bandwidth and lack of background in so many different areas that are getting new QMP commands almost every week. In order to help me mitigate this problem, I'm adding Eric and Markus (besides me) as maintainers of the qapi-s

[Qemu-devel] [PATCH 2/9] rng-random: use error_setg_file_open()

Signed-off-by: Luiz Capitulino --- backends/rng-random.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/backends/rng-random.c b/backends/rng-random.c index 830360c..68dfc8a 100644 --- a/backends/rng-random.c +++ b/backends/rng-random.c @@ -78,9 +78,8 @@ static void rng_rand

Re: [Qemu-devel] [PATCH v4] qemu-char: don't issue CHR_EVENT_OPEN in a BH

On Fri, Jun 07, 2013 at 11:36:16AM -0400, Luiz Capitulino wrote: > On Fri, 7 Jun 2013 09:56:00 -0500 > mdroth wrote: > > > On Fri, Jun 07, 2013 at 09:50:39AM -0400, Luiz Capitulino wrote: > > > On Tue, 4 Jun 2013 16:35:09 -0500 > > > Michael Roth wrote: > > > > > > > When CHR_EVENT_OPENED was

[Qemu-devel] [PATCH v5] qemu-char: don't issue CHR_EVENT_OPEN in a BH

When CHR_EVENT_OPENED was initially added, it was CHR_EVENT_RESET, and it was issued as a bottom-half: 86e94dea5b740dad65446c857f6959eae43e0ba6 Which we basically used to print out a greeting/prompt for the monitor. AFAICT the only reason this was ever done in a BH was because in some cases we'd

Re: [Qemu-devel] [PATCH] script: git script to compile every commit in a range of commits

On Fri, Jun 07, 2013 at 11:51:36AM -0500, Anthony Liguori wrote: > Laszlo Ersek writes: > > > On 06/07/13 16:44, Jeff Cody wrote: > > > >> Thanks. I can either do the above changes for a v2, or as follow on > >> patches. > > > > Whichever is easier for you, certainly! I'm fine with the script >

[Qemu-devel] [PATCH] correct RTC_CHANGE_EVENT description (v2)

Fix RTC_CHANGE event description to match implementation. Signed-off-by: Marcelo Tosatti diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt index 92fe5fb..24e804e9 100644 --- a/QMP/qmp-events.txt +++ b/QMP/qmp-events.txt @@ -203,7 +203,8 @@ Emitted when the guest changes the RTC time. Data

Re: [Qemu-devel] [PULL 0/3] QMP queue

On Fri, 7 Jun 2013 15:54:12 -0400 Luiz Capitulino wrote: > The changes (since 7387de16d0e4d2988df350926537cd12a8e34206) are available > in the following repository: > > git://repo.or.cz/qemu/qmp-unstable.git queue/qmp > > Luiz Capitulino (2): > MAINTAINERS: new maintainers for qapi-schem

Re: [Qemu-devel] [PATCH v4] qemu-char: don't issue CHR_EVENT_OPEN in a BH

Luiz Capitulino writes: > On Fri, 7 Jun 2013 09:56:00 -0500 > mdroth wrote: > >> On Fri, Jun 07, 2013 at 09:50:39AM -0400, Luiz Capitulino wrote: >> > On Tue, 4 Jun 2013 16:35:09 -0500 >> > Michael Roth wrote: >> > >> > > When CHR_EVENT_OPENED was initially added, it was CHR_EVENT_RESET, >> >

Re: [Qemu-devel] [PATCH] correct RTC_CHANGE_EVENT description (v2)

On Fri, 7 Jun 2013 16:52:43 -0300 Marcelo Tosatti wrote: > > Fix RTC_CHANGE event description to match implementation. > > Signed-off-by: Marcelo Tosatti Applied to the qmp branch, thanks. > > diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt > index 92fe5fb..24e804e9 100644 > --- a/QMP/

Re: [Qemu-devel] [PATCH v4] qemu-char: don't issue CHR_EVENT_OPEN in a BH

On Fri, 07 Jun 2013 16:01:34 -0500 Anthony Liguori wrote: > Luiz Capitulino writes: > > > On Fri, 7 Jun 2013 09:56:00 -0500 > > mdroth wrote: > > > >> On Fri, Jun 07, 2013 at 09:50:39AM -0400, Luiz Capitulino wrote: > >> > On Tue, 4 Jun 2013 16:35:09 -0500 > >> > Michael Roth wrote: > >> >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: remove ${config_host_ld} variable

06.06.2013 16:53, Ed Maste wrote: > It was only used in one place (and already expanded in one other). Thanks, applied to the trivial patches queue. I think we should just as well get rid of ${config_host_mak}, as it makes no sense too... ;) And while at it, maybe use common constructs like {

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Disable host-bsd USB on FreeBSD

06.06.2013 17:18, Ed Maste wrote: > It hasn't built since FreeBSD 8.x, and is disabled by a patch in the > FreeBSD ports tree. FreeBSD is migrating to QEMU's libusb support. Thanks, applied to the trivial patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 1/5] intc/xilinx_intc: Use qemu_set_irq

07.06.2013 06:39, Peter Crosthwaite wrote: >> Use qemu_set_irq rather than if-elsing qemu_irq_(lower|raise). No >> functional change, just reduces verbosity. Thanks, applied to the trivial patches queue. /mjt

Re: [Qemu-devel] [PATCH 0/2] gdbstub runstate check follow-ups

Am 03.06.2013 17:06, schrieb Paolo Bonzini: > My patch committed at 87f25c12bfeaaa0c41fb857713bbc7e8a9b757dc > was broken. These patches fix the problem in a better way. > > Paolo > > Paolo Bonzini (2): > gdbstub: fix for commit 87f25c12bfeaaa0c41fb857713bbc7e8a9b757dc > gdbstub: let the deb

[Qemu-devel] [PATCH] kvmclock: clock should count only if vm is running

kvmclock should not count while vm is paused, because: 1) if the vm is paused for long periods, timekeeping math can overflow while converting the (large) clocksource delta to nanoseconds. 2) Users rely on CLOCK_MONOTONIC to count run time, that is, time which OS has been in a runnable state

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

I insist to remove compile warning since I want gcc check my code with strict rule. Wenchao Xia writes: This patch simply remove "variable may be used uninitialized" warning. Signed-off-by: Wenchao Xia --- V2: Address Stefan and Peter's comments, use 0 in send_msg() instead of initialize

Re: [Qemu-devel] [PATCH RFT 2/5] virtio: Convert VirtioDevice to QOM realize/unrealize

Hi Andreas, On Sat, Jun 8, 2013 at 4:18 AM, Andreas Färber wrote: > VirtioDevice's DeviceClass::exit code cleaning up bus_name is no longer > overwritten by virtio-{blk,serial,net,scsi,balloon,rng} and vhost-scsi. > > Note: VirtIOSCSI and VHostSCSI now perform some initializations after > VirtIOS

Re: [Qemu-devel] [PATCH arm-devs v1 1/1] char/cadence_uart: Fix reset for unattached instances

On Fri, Jun 07, 2013 at 02:02:43PM +1000, peter.crosthwa...@xilinx.com wrote: > From: Peter Crosthwaite > > commit 1db8b5efe0c2b5000e50691eea61264a615f43de introduced an issue > where QEMU would segfault if you have an unattached Cadence UART. > > Fix by guarding the flush-on-reset logic on ther

<    1   2