Re: [Qemu-devel] [PATCH 5/5] memory: able to pin guest node memory to host node manually

2013-05-24 Thread Wanlong Gao
On 05/23/2013 04:47 PM, Wanlong Gao wrote: > Use mbind to pin guest numa node memory to host nodes manually. > > If we are not able to pin memory to host node, we may meet the > cross node memory access performance regression. > > With this patch, we can add manual pinning host node like this: >

Re: [Qemu-devel] [PATCH 5/8] pci: Replace pci_find_domain() with more general pci_root_bus_path()

2013-05-24 Thread David Gibson
On Thu, May 23, 2013 at 05:00:39PM +0200, Paolo Bonzini wrote: > Il 23/05/2013 16:57, Michael S. Tsirkin ha scritto: > > On Thu, May 23, 2013 at 04:51:17PM +0200, Paolo Bonzini wrote: > >> Il 23/05/2013 13:04, Michael S. Tsirkin ha scritto: > > Most current uses of pci_find_domain() are for err

[Qemu-devel] [PATCH] migration: Remove double set of bandwidth_limit in migrate_init

2013-05-24 Thread Lei Li
bandwidth_limit is double set in migrate_init(), so remove one. Signed-off-by: Lei Li --- migration.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index bfbc345..058f9e6 100644 --- a/migration.c +++ b/migration.c @@ -349,7 +349,6 @@ static M

[Qemu-devel] qemu-1.5.0 savevm error -95 while writing vm with ceph-rbd as storage-backend

2013-05-24 Thread Oliver Francke
Hi, with a running VM I encounter this strange behaviour, former qemu-versions don't show up such an error. Perhaps this comes from the rbd-backend in qemu-1.5.0 in combination with ceph-0.56.6? Therefore my crosspost. Even if I have no real live-snapshot avail - they know of this restrictio

Re: [Qemu-devel] [PATCH 1/8] pci: Cleanup configuration for pci-hotplug.c

2013-05-24 Thread David Gibson
On Thu, May 23, 2013 at 02:11:35PM +0300, Michael S. Tsirkin wrote: > On Thu, May 09, 2013 at 10:31:05AM +1000, David Gibson wrote: [snip] > > diff --git a/hw/pci/Makefile.objs b/hw/pci/Makefile.objs > > index a7fb9d0..2ad32b6 100644 > > --- a/hw/pci/Makefile.objs > > +++ b/hw/pci/Makefile.objs > >

Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid

2013-05-24 Thread Paolo Bonzini
Il 23/05/2013 20:04, Peter Maydell ha scritto: > Shouldn't we be calling the MemoryRegionOps > accepts() callback here? What about access alignment constraints > and access size restrictions? Yes, we should. > What if the validity of the range > changes between the time you asked and when you act

Re: [Qemu-devel] [Libguestfs] ANNOUNCE: libguestfs 1.22 has been released

2013-05-24 Thread Richard W.M. Jones
On Fri, May 24, 2013 at 08:42:37AM +0530, Kashyap Chamarthy wrote: > On 05/23/2013 05:53 PM, Richard W.M. Jones wrote: > > I'm pleased to announce the next stable release of libguestfs (1.22). > > Great work! > > == > $ ./autogen.sh && make -j 7 && \ > time make -k check LIBGUESTFS_DEBUG=

Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read

2013-05-24 Thread Richard W.M. Jones
On Fri, May 24, 2013 at 01:36:55PM +0800, Fam Zheng wrote: > Changes from v5: > 05: Rename bs to s for BDRVCURLState. > 06: Use int64_t for offsets. > Fix printf format string. > Move introducing of use_count to 07. > 07: Drop explicit cast. > Use int64_t for offsets. >

Re: [Qemu-devel] [PATCH 1/8] pci: Cleanup configuration for pci-hotplug.c

2013-05-24 Thread David Gibson
On Thu, May 23, 2013 at 04:54:17PM +0200, Paolo Bonzini wrote: > Il 09/05/2013 02:31, David Gibson ha scritto: > > diff --git a/hw/pci/Makefile.objs b/hw/pci/Makefile.objs > > index a7fb9d0..2ad32b6 100644 > > --- a/hw/pci/Makefile.objs > > +++ b/hw/pci/Makefile.objs > > @@ -8,4 +8,4 @@ common-obj-

Re: [Qemu-devel] [PATCH arm-devs v2 5/5] sd/sd.c: Fix "inquiry" ACMD41

2013-05-24 Thread Peter Maydell
On 24 May 2013 06:18, wrote: > From: Peter Crosthwaite > > QEMU models two (of the three) ACMD41 has two modes, "inquiry" and > "first". The selection logic for which of the two is incorrect - it > compares != 0 for the entire argument value rather than only bits 23:0 > as per the spec. Fix. > >

Re: [Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 08:11:42AM +, Dietmar Maurer wrote: > > > I also consider it safer, because you make sure the data exists (using > > > hash keys > > like SHA1). > > > > > > I am unsure how you can check if a dirty bitmap contains errors, or is > > > out of > > date? > > > > > > Also,

Re: [Qemu-devel] [PATCH 2/4] tcg/aarch64: implement new TCG target for aarch64

2013-05-24 Thread Claudio Fontana
On 23.05.2013 18:39, Peter Maydell wrote: > On 23 May 2013 09:18, Claudio Fontana wrote: >> >> add preliminary support for TCG target aarch64. > > Richard's handling the technical bits of the review, so > just some minor style nits here. > > I tested this on the foundation model and was able to

Re: [Qemu-devel] [RFC PATCH v3 02/11] Fix errors and warnings while compiling with c++ compilier

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 06:34:43PM +, Tomoki Sekiyama wrote: > On 5/23/13 8:12 , "Stefan Hajnoczi" wrote: > > >On Tue, May 21, 2013 at 11:33:41AM -0400, Tomoki Sekiyama wrote: > >> Add C++ keywords to avoid errors in compiling with c++ compiler. > >> This also renames class member of PciDevic

Re: [Qemu-devel] [PATCH 2/4] tcg/aarch64: implement new TCG target for aarch64

2013-05-24 Thread Claudio Fontana
On 23.05.2013 18:29, Richard Henderson wrote: > On 05/23/2013 01:18 AM, Claudio Fontana wrote: >> +static inline void patch_reloc(uint8_t *code_ptr, int type, >> + tcg_target_long value, tcg_target_long >> addend) >> +{ >> +switch (type) { >> +case R_AARCH64_J

Re: [Qemu-devel] [RFC PATCH v3 05/11] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 06:36:35PM +, Tomoki Sekiyama wrote: > On 5/23/13 8:22 , "Stefan Hajnoczi" wrote: > > >On Tue, May 21, 2013 at 11:33:52AM -0400, Tomoki Sekiyama wrote: > >> diff --git a/qga/vss-win32.h b/qga/vss-win32.h > >> new file mode 100644 > >> index 000..7600087 > >> --- /d

Re: [Qemu-devel] [RFC PATCH v3 00/11] qemu-ga: fsfreeze on Windows using VSS

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 03:50:19PM +0200, Paolo Bonzini wrote: > Il 23/05/2013 15:28, Stefan Hajnoczi ha scritto: > > On Thu, May 23, 2013 at 3:20 PM, Paolo Bonzini wrote: > >> Il 23/05/2013 14:15, Stefan Hajnoczi ha scritto: > >>> On Tue, May 21, 2013 at 11:33:33AM -0400, Tomoki Sekiyama wrote: >

Re: [Qemu-devel] 'qemu-nbd' explicit flush

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 09:58:31PM +, Mark Trumpold wrote: > I have a working configuration using the signal approach suggested by Stefan. > > 'qemu-nbd.c' is patched as follows: > > do { > main_loop_wait(false); > + if (sighup_reported) { > + sighup_reported = fal

Re: [Qemu-devel] 'qemu-nbd' explicit flush

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 11:35:24PM +, Mark Trumpold wrote: > I had one question I forgot to ask.. > > Is it possible to switch from '--cache=writeback' functionality > to '--cache=writethrough' (and visa versa) while qemu-nbd is > connected to the '/dev/nbd' device? No. The block layer APIs

Re: [Qemu-devel] use O_DIRECT to open disk images for IDE failed under xen-4.1.2 and qemu upstream

2013-05-24 Thread Stefano Stabellini
On Fri, 24 May 2013, Gonglei (Arei) wrote: > Hi, > > > > > On Thu, 23 May 2013, Gonglei (Arei) wrote: > > > Hi, all > > > > > > I use O_DIRECT to open disk images for IDE, but I'm failed. After debug, > > > I get > > the below logs: > > > [2013-05-22 23:25:46] ide: CMD=c8 > > > [2013-05-22 23:25

Re: [Qemu-devel] [PATCH] kvm: add detail error message when fail to add ioeventfd

2013-05-24 Thread Amos Kong
On Thu, May 23, 2013 at 09:46:07AM +0200, Stefan Hajnoczi wrote: > On Wed, May 22, 2013 at 09:48:21PM +0800, Amos Kong wrote: > > On Wed, May 22, 2013 at 11:32:27AM +0200, Stefan Hajnoczi wrote: > > > On Wed, May 22, 2013 at 12:57:35PM +0800, Amos Kong wrote: > > > > I try to hotplug 28 * 8 multipl

Re: [Qemu-devel] [RFC PATCH v3 00/11] qemu-ga: fsfreeze on Windows using VSS

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 03:50:19PM +0200, Paolo Bonzini wrote: > Il 23/05/2013 15:28, Stefan Hajnoczi ha scritto: > > On Thu, May 23, 2013 at 3:20 PM, Paolo Bonzini wrote: > >> Il 23/05/2013 14:15, Stefan Hajnoczi ha scritto: > >>> On Tue, May 21, 2013 at 11:33:33AM -0400, Tomoki Sekiyama wrote: >

Re: [Qemu-devel] updated: kvm networking todo wiki

2013-05-24 Thread Jason Wang
On 05/23/2013 04:50 PM, Michael S. Tsirkin wrote: > Hey guys, > I've updated the kvm networking todo wiki with current projects. > Will try to keep it up to date more often. > Original announcement below. Thanks a lot. I've added the tasks I'm currently working on to the wiki. btw. I notice the v

Re: [Qemu-devel] [PATCH v5 07/11] curl: make use of CURLDataCache.

2013-05-24 Thread Stefan Hajnoczi
On Fri, May 24, 2013 at 11:10:26AM +0800, Fam Zheng wrote: > On Thu, 05/23 16:23, Stefan Hajnoczi wrote: > > On Thu, May 23, 2013 at 11:38:05AM +0800, Fam Zheng wrote: > > > +CURLDataCache *c = s->cache; > > > size_t realsize = size * nmemb; > > > -int i; > > > - > > > -DPRINTF("CU

Re: [Qemu-devel] "Designing QMP APIs" at KVM Forum

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 07:59:17AM -0600, Eric Blake wrote: > On 05/23/2013 06:46 AM, Luiz Capitulino wrote: > > On Thu, 23 May 2013 13:51:22 +0200 > > Stefan Hajnoczi wrote: > > > >> With better QMP introspection on the horizon and work in various > >> subsystems pushing QMP boundaries it would

Re: [Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command

2013-05-24 Thread Dietmar Maurer
> Maybe the best approach is to maintain a dirty bitmap while the guest is > running, which is fairly cheap. Then you can use the dirty bitmap to only > hash > modified clusters when building the Merkle tree - this avoids reading the > entire disk image. Yes, this is an good optimization. > > >

Re: [Qemu-devel] [PATCH 0/7] VNVRAM persistent storage

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 01:44:40PM -0400, Corey Bryant wrote: > This patch series provides VNVRAM persistent storage support that > QEMU can use internally. The initial target user will be a software > vTPM 1.2 backend that needs to store keys in VNVRAM and be able to > reboot/migrate and retain t

Re: [Qemu-devel] [PATCH] Remove unnecessary break statements

2013-05-24 Thread Peter Maydell
On 24 May 2013 11:19, Stefan Weil wrote: > Fix these warnings from cppcheck: > > hw/display/cirrus_vga.c:2603: > hw/sd/sd.c:348: > hw/timer/exynos4210_mct.c:1033: > target-arm/translate.c:9886: > target-s390x/mem_helper.c:518: > target-unicore32/translate.c:1936: > style: Consecutive return, brea

Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid

2013-05-24 Thread Jan Kiszka
On 2013-05-24 08:13, Jan Kiszka wrote: > On 2013-05-23 20:04, Peter Maydell wrote: >> On 21 May 2013 11:57, Paolo Bonzini wrote: >>> +bool address_space_valid(AddressSpace *as, hwaddr addr, int len, bool >>> is_write) >>> +{ >>> +AddressSpaceDispatch *d = as->dispatch; >>> +MemoryRegionSe

Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid

2013-05-24 Thread Peter Maydell
On 24 May 2013 07:13, Jan Kiszka wrote: > I'll also have a use for it: replace isa_is_ioport_assigned. That seems like it's something different: it's asking "has some other bit of QEMU registered a handler for this ioport?", not "at this moment in time if I make an I/O access will it succeed?" (w

Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid

2013-05-24 Thread Peter Maydell
On 24 May 2013 09:02, Paolo Bonzini wrote: > Il 23/05/2013 20:04, Peter Maydell ha scritto: >> Shouldn't we be calling the MemoryRegionOps >> accepts() callback here? What about access alignment constraints >> and access size restrictions? > > Yes, we should. > >> What if the validity of the range

[Qemu-devel] [PATCH] Remove unnecessary break statements

2013-05-24 Thread Stefan Weil
Fix these warnings from cppcheck: hw/display/cirrus_vga.c:2603: hw/sd/sd.c:348: hw/timer/exynos4210_mct.c:1033: target-arm/translate.c:9886: target-s390x/mem_helper.c:518: target-unicore32/translate.c:1936: style: Consecutive return, break, continue, goto or throw statements are unnecessary. Si

Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid

2013-05-24 Thread Jan Kiszka
On 2013-05-24 12:50, Peter Maydell wrote: > On 24 May 2013 07:13, Jan Kiszka wrote: >> I'll also have a use for it: replace isa_is_ioport_assigned. > > That seems like it's something different: it's asking > "has some other bit of QEMU registered a handler for > this ioport?", not "at this moment

Re: [Qemu-devel] [PATCH V2 2/5] block: move snapshot code in block.c to block/snapshot.c

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 04:47:13PM +0800, Wenchao Xia wrote: > -int bdrv_is_snapshot(BlockDriverState *bs) > -{ > -return !!(bs->open_flags & BDRV_O_SNAPSHOT); > -} No need to respin, but this function has nothing to do with the other functions. This function is about -drive snapshot=on, the

Re: [Qemu-devel] updated: kvm networking todo wiki

2013-05-24 Thread Michael S. Tsirkin
On Fri, May 24, 2013 at 05:41:11PM +0800, Jason Wang wrote: > On 05/23/2013 04:50 PM, Michael S. Tsirkin wrote: > > Hey guys, > > I've updated the kvm networking todo wiki with current projects. > > Will try to keep it up to date more often. > > Original announcement below. > > Thanks a lot. I've

Re: [Qemu-devel] [update][PATCH 00/12] target-i386: remove some macros

2013-05-24 Thread Andreas Färber
Am 23.04.2013 10:16, schrieb liguang: > remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF > as suggested by Richard Henderson > > Li Guang (12) >target-i386/helper: remove EAX macro >target-i386/helper: remove EBX macro >target-i386/helper: remove ECX macro >

Re: [Qemu-devel] [PATCH] Remove unnecessary break statements

2013-05-24 Thread Andreas Färber
Am 24.05.2013 12:19, schrieb Stefan Weil: > Fix these warnings from cppcheck: > > hw/display/cirrus_vga.c:2603: > hw/sd/sd.c:348: > hw/timer/exynos4210_mct.c:1033: > target-arm/translate.c:9886: > target-s390x/mem_helper.c:518: > target-unicore32/translate.c:1936: > style: Consecutive return, bre

Re: [Qemu-devel] [PATCH 0/4] add ACPI Embedded Controller

2013-05-24 Thread Michael S. Tsirkin
On Wed, May 22, 2013 at 11:46:33AM +0800, liguang wrote: > These patches try to add ACPI Embedded Controller (EC), > refer-to: > ACPI SPEC v5 chapter 5 > "ACPI Embedded Controller Interface Specification" > > EC is a standard ACPI device, it plays flexible roles, > e.g. > power controller, it ca

Re: [Qemu-devel] [PATCH V2 4/5] util: add new function message_printf()

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 04:47:15PM +0800, Wenchao Xia wrote: > This function takes an input parameter *output, which can be specified by > caller as stderr, stdout or a monitor. error_vprintf() now calls > message_vprintf(), > which is a static function added in this patch. > > Signed-off-by: Wen

Re: [Qemu-devel] [PATCH 4/4] debugcon: use fprintf(stderr...) instead of printf

2013-05-24 Thread Andreas Färber
Am 24.05.2013 04:47, schrieb liguang: > suggested by Andreas Färber > > Signed-off-by: liguang > --- > hw/char/debugcon.c |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c > index 3b0637d..be20ede 100644 > --- a/hw/char/de

Re: [Qemu-devel] [PATCH v4] net: introduce command to query rx-filter information

2013-05-24 Thread Michael S. Tsirkin
On Fri, May 24, 2013 at 02:44:06PM +0800, Amos Kong wrote: > We want to implement mac programming over macvtap through Libvirt. The > related rx-filter information of the nic contains main mac, rx-mode > items. > > This patch adds a QMP event to notify management of rx-filter change, > and adds a

Re: [Qemu-devel] [RFC PATCH v3 00/11] qemu-ga: fsfreeze on Windows using VSS

2013-05-24 Thread Paolo Bonzini
Il 24/05/2013 10:59, Stefan Hajnoczi ha scritto: > On Thu, May 23, 2013 at 03:50:19PM +0200, Paolo Bonzini wrote: >> Il 23/05/2013 15:28, Stefan Hajnoczi ha scritto: >>> On Thu, May 23, 2013 at 3:20 PM, Paolo Bonzini wrote: Il 23/05/2013 14:15, Stefan Hajnoczi ha scritto: > On Tue, May 21

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-24 Thread Michael S. Tsirkin
On Thu, May 23, 2013 at 01:26:33PM -0400, Luiz Capitulino wrote: > On Thu, 23 May 2013 20:18:34 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, May 23, 2013 at 11:54:03AM -0400, Luiz Capitulino wrote: > > > On Thu, 16 May 2013 18:17:23 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > > T

Re: [Qemu-devel] 'qemu-nbd' explicit flush

2013-05-24 Thread Paolo Bonzini
Il 23/05/2013 23:58, Mark Trumpold ha scritto: > I have a working configuration using the signal approach suggested by Stefan. > > 'qemu-nbd.c' is patched as follows: > > do { > main_loop_wait(false); > + if (sighup_reported) { > + sighup_reported = false; > +

Re: [Qemu-devel] [PATCH 0/7] VNVRAM persistent storage

2013-05-24 Thread Stefan Berger
On 05/24/2013 05:59 AM, Stefan Hajnoczi wrote: On Thu, May 23, 2013 at 01:44:40PM -0400, Corey Bryant wrote: This patch series provides VNVRAM persistent storage support that QEMU can use internally. The initial target user will be a software vTPM 1.2 backend that needs to store keys in VNVRAM

Re: [Qemu-devel] use O_DIRECT to open disk images for IDE failed under xen-4.1.2 and qemu upstream

2013-05-24 Thread Stefan Hajnoczi
On Fri, May 24, 2013 at 02:59:05AM +, Gonglei (Arei) wrote: > Hi, > > > > > On Thu, 23 May 2013, Gonglei (Arei) wrote: > > > Hi, all > > > > > > I use O_DIRECT to open disk images for IDE, but I'm failed. After debug, > > > I get > > the below logs: > > > [2013-05-22 23:25:46] ide: CMD=c8 >

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-24 Thread Luiz Capitulino
On Fri, 24 May 2013 11:08:13 +0800 Amos Kong wrote: > On Thu, May 23, 2013 at 12:03:25PM -0400, Luiz Capitulino wrote: > > On Thu, 23 May 2013 17:08:00 +0800 > > Amos Kong wrote: > > > > A flag is used to avoid events flooding, if user don't query > > > rx-filter after receives one event, new e

Re: [Qemu-devel] [PATCH v4] net: introduce command to query rx-filter information

2013-05-24 Thread Eric Blake
On 05/24/2013 06:03 AM, Michael S. Tsirkin wrote: > On Fri, May 24, 2013 at 02:44:06PM +0800, Amos Kong wrote: >> We want to implement mac programming over macvtap through Libvirt. The >> related rx-filter information of the nic contains main mac, rx-mode >> items. >> >> +Each array entry contains

Re: [Qemu-devel] [PATCH] Remove unnecessary break statements

2013-05-24 Thread Richard W.M. Jones
On Fri, May 24, 2013 at 12:19:25PM +0200, Stefan Weil wrote: > Fix these warnings from cppcheck: > > hw/display/cirrus_vga.c:2603: > hw/sd/sd.c:348: > hw/timer/exynos4210_mct.c:1033: > target-arm/translate.c:9886: > target-s390x/mem_helper.c:518: > target-unicore32/translate.c:1936: > style: Con

Re: [Qemu-devel] [PATCH 0/7] VNVRAM persistent storage

2013-05-24 Thread Stefan Hajnoczi
On Fri, May 24, 2013 at 08:13:27AM -0400, Stefan Berger wrote: > On 05/24/2013 05:59 AM, Stefan Hajnoczi wrote: > >On Thu, May 23, 2013 at 01:44:40PM -0400, Corey Bryant wrote: > >>This patch series provides VNVRAM persistent storage support that > >>QEMU can use internally. The initial target use

Re: [Qemu-devel] [PATCH v4] net: introduce command to query rx-filter information

2013-05-24 Thread Eric Blake
On 05/24/2013 12:44 AM, Amos Kong wrote: > We want to implement mac programming over macvtap through Libvirt. The > related rx-filter information of the nic contains main mac, rx-mode > items. > > This patch adds a QMP event to notify management of rx-filter change, > and adds a monitor command fo

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-24 Thread Luiz Capitulino
On Fri, 24 May 2013 15:10:16 +0300 "Michael S. Tsirkin" wrote: > On Thu, May 23, 2013 at 01:26:33PM -0400, Luiz Capitulino wrote: > > On Thu, 23 May 2013 20:18:34 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, May 23, 2013 at 11:54:03AM -0400, Luiz Capitulino wrote: > > > > On Thu, 16

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-24 Thread Eric Blake
On 05/24/2013 06:23 AM, Luiz Capitulino wrote: >>> I don't think we need this argument. This command is quite simple in its >>> response, let's do this filtering in HMP only. >> >> Event message contains the net client name, management might only want >> to query the single net client. > > The cli

Re: [Qemu-devel] [PATCH arm-devs v4 00/15] Xilinx SPIPS fixes round 2

2013-05-24 Thread Peter Maydell
On 21 May 2013 07:28, wrote: > From: Peter Crosthwaite > > Updates to the Zynq SPI controller. Some QOMifying cleanup, followed by > a number of bugs/incompletnesses found by some (very) rigourous test > vectors. Thanks; applied all to arm-devs.next. -- PMM

Re: [Qemu-devel] [RFC PATCH v3 02/11] Fix errors and warnings while compiling with c++ compilier

2013-05-24 Thread Laszlo Ersek
On 05/21/13 17:33, Tomoki Sekiyama wrote: > diff --git a/scripts/qapi.py b/scripts/qapi.py > index afc5f32..b174acb 100644 > --- a/scripts/qapi.py > +++ b/scripts/qapi.py > @@ -156,9 +156,16 @@ def c_var(name, protect=True): > # GCC http://gcc.gnu.org/onlinedocs/gcc-4.7.1/gcc/C-Extensions.htm

Re: [Qemu-devel] [PATCH 1/7] vnvram: VNVRAM bdrv support

2013-05-24 Thread Kevin Wolf
Am 23.05.2013 um 19:44 hat Corey Bryant geschrieben: > Provides low-level VNVRAM functionality that reads and writes data, > such as an entry's binary blob, to a drive image using the block > driver. > > Signed-off-by: Corey Bryant > +/* > + * Increase the drive size if it's too small to fit the

Re: [Qemu-devel] [PATCH] qemu-kvm: fix unmatched RAM alloction/free

2013-05-24 Thread Eric Blake
On 05/23/2013 07:21 PM, Hao, Xudong wrote: >> Just "git pull". :) This is very similar to commit e7a09b9 (osdep: introduce >> qemu_anon_ram_free to free qemu_anon_ram_alloc-ed memory, 2013-05-13) >> > > OK, this commit do the same thing as my patch, I did not notice qemu upstream > tree, just ta

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-24 Thread Luiz Capitulino
On Fri, 24 May 2013 06:55:44 -0600 Eric Blake wrote: > On 05/24/2013 06:23 AM, Luiz Capitulino wrote: > >>> I don't think we need this argument. This command is quite simple in its > >>> response, let's do this filtering in HMP only. > >> > >> Event message contains the net client name, managemen

Re: [Qemu-devel] [RFC PATCH v3 03/11] Add a script to extract VSS SDK headers on POSIX system

2013-05-24 Thread Laszlo Ersek
On 05/21/13 23:02, Tomoki Sekiyama wrote: > Maybe it also should have an additional check and a message to install > Msitools for the case msiextract isn't exectable. Right. One POSIX-y way would be command -v msiextract >/dev/null and checking the exit status. http://pubs.opengroup.org/onli

Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid

2013-05-24 Thread Paolo Bonzini
Il 24/05/2013 12:52, Peter Maydell ha scritto: > On 24 May 2013 09:02, Paolo Bonzini wrote: >> Il 23/05/2013 20:04, Peter Maydell ha scritto: >>> Shouldn't we be calling the MemoryRegionOps >>> accepts() callback here? What about access alignment constraints >>> and access size restrictions? >> >>

Re: [Qemu-devel] qmp commands get rejected

2013-05-24 Thread Luiz Capitulino
On Fri, 24 May 2013 07:50:33 +0200 Stefan Priebe wrote: > Hello list, > > since upgrading from qemu 1.4.1 to 1.5.0 i've problems with qmp commands. > > With Qemu 1.5 i've the following socket communication: > > '{"execute":"qmp_capabilities","id":"12125:1","arguments":{}}' > > '{"return": {},

Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid

2013-05-24 Thread Peter Maydell
On 24 May 2013 13:58, Paolo Bonzini wrote: > If it's okay > for you, I'll send a pull request up to "memory: clean up phys_page_find" > and go on with the next series. That's fine with me, but please don't forget to fix up the doc comment for memory_region_find() (see comments on patch 6/30). You

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-24 Thread Eric Blake
On 05/24/2013 07:08 AM, Luiz Capitulino wrote: > This sounds like premature optimization to me, but I wonder if instead > of cluttering commands with arguments to do the filtering we could add > some standard way of doing this in the QAPI. Maybe we could make QAPI support generic filtering for all

Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid

2013-05-24 Thread Paolo Bonzini
Il 24/05/2013 15:27, Peter Maydell ha scritto: > On 24 May 2013 13:58, Paolo Bonzini wrote: >> If it's okay >> for you, I'll send a pull request up to "memory: clean up phys_page_find" >> and go on with the next series. > > That's fine with me, but please don't forget to fix up > the doc comment

Re: [Qemu-devel] [RFC PATCH v3 03/11] Add a script to extract VSS SDK headers on POSIX system

2013-05-24 Thread Laszlo Ersek
On 05/21/13 17:33, Tomoki Sekiyama wrote: > VSS SDK(*) setup.exe is only runnable on Windows. This adds a script > to extract VSS SDK headers on POSIX-systems using msitools. > > * http://www.microsoft.com/en-us/download/details.aspx?id=23490 > > From: Paolo Bonzini > Signed-off-by: Tomoki Sek

Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid

2013-05-24 Thread Peter Maydell
On 24 May 2013 14:33, Paolo Bonzini wrote: > Il 24/05/2013 15:27, Peter Maydell ha scritto: >> On 24 May 2013 13:58, Paolo Bonzini wrote: >>> If it's okay >>> for you, I'll send a pull request up to "memory: clean up phys_page_find" >>> and go on with the next series. >> >> That's fine with me, b

Re: [Qemu-devel] [PATCH arm-devs v2 0/5] SD and SDHCI Fixes

2013-05-24 Thread Peter Maydell
On 24 May 2013 06:14, wrote: > From: Peter Crosthwaite > > Fixes found in SD and SDHCI found doing some corner case testing. > > Changed from v1: > Corrected ACMD41 patch. > Moved ACMD41 patch to back of series. Patches 1-4 (but not the ACMD41 one) queued to arm-devs.next. thanks -- PMM

Re: [Qemu-devel] [RFC PATCH v3 04/11] qemu-ga: Add an configure option to specify path to Windows VSS SDK

2013-05-24 Thread Laszlo Ersek
On 05/21/13 18:53, Eric Blake wrote: > On 05/21/2013 09:33 AM, Tomoki Sekiyama wrote: >> To enable VSS support in qemu-ga for Windows, header files included in >> VSS SDK is required. >> The VSS support is enabled when the option like below: >> ./configure --with-vss-sdk="/pass/to/VSS SDK" >> >>

Re: [Qemu-devel] updated: kvm networking todo wiki

2013-05-24 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Fri, May 24, 2013 at 05:41:11PM +0800, Jason Wang wrote: >> On 05/23/2013 04:50 PM, Michael S. Tsirkin wrote: >> > Hey guys, >> > I've updated the kvm networking todo wiki with current projects. >> > Will try to keep it up to date more often. >> > Original announ

Re: [Qemu-devel] qmp commands get rejected

2013-05-24 Thread Stefan Priebe - Profihost AG
Am 24.05.2013 um 15:23 schrieb Luiz Capitulino : > On Fri, 24 May 2013 07:50:33 +0200 > Stefan Priebe wrote: > >> Hello list, >> >> since upgrading from qemu 1.4.1 to 1.5.0 i've problems with qmp commands. >> >> With Qemu 1.5 i've the following socket communication: >> >> '{"execute":"qmp_cap

Re: [Qemu-devel] [RFC PATCH v3 04/11] qemu-ga: Add an configure option to specify path to Windows VSS SDK

2013-05-24 Thread Laszlo Ersek
On 05/21/13 17:33, Tomoki Sekiyama wrote: > +if test "$vss_win32_sdk" != "" ; then > + echo "ERROR: Please download and install Microsoft VSS SDK:" > + echo "ERROR: > http://www.microsoft.com/en-us/download/details.aspx?id=23490"; > + echo "ERROR: On POSIX-systems, you can ex

Re: [Qemu-devel] updated: kvm networking todo wiki

2013-05-24 Thread Michael S. Tsirkin
On Fri, May 24, 2013 at 08:47:58AM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Fri, May 24, 2013 at 05:41:11PM +0800, Jason Wang wrote: > >> On 05/23/2013 04:50 PM, Michael S. Tsirkin wrote: > >> > Hey guys, > >> > I've updated the kvm networking todo wiki with current p

Re: [Qemu-devel] [PATCH 00/30] Introduction of IOMMUs into the memory API

2013-05-24 Thread Alexey Kardashevskiy
On 05/24/2013 03:08 AM, Paolo Bonzini wrote: > Il 22/05/2013 11:24, Paolo Bonzini ha scritto: >> Il 22/05/2013 04:30, Alexey Kardashevskiy ha scritto: >>> On 05/21/2013 08:57 PM, Paolo Bonzini wrote: This is part 1 of the memory API updates for 1.6. (Part 2 is the introduction of get/set

Re: [Qemu-devel] qmp commands get rejected

2013-05-24 Thread Luiz Capitulino
On Fri, 24 May 2013 15:57:59 +0200 Stefan Priebe - Profihost AG wrote: > Am 24.05.2013 um 15:23 schrieb Luiz Capitulino : > > > On Fri, 24 May 2013 07:50:33 +0200 > > Stefan Priebe wrote: > > > >> Hello list, > >> > >> since upgrading from qemu 1.4.1 to 1.5.0 i've problems with qmp commands.

Re: [Qemu-devel] [PATCH v5 3/3] configure/Make: Build libfdt from submodule DTC

2013-05-24 Thread Peter Maydell
On 22 April 2013 05:45, Peter Crosthwaite wrote: > On Sun, Apr 21, 2013 at 11:16 PM, Paolo Bonzini wrote: >> libfdt is not that portable, it doesn't use libtool to build shared >> libraries. >> >> Perhaps we can just build the static library? >> > > Seems reasonable, and got this working with fai

Re: [Qemu-devel] [PATCH 00/30] Introduction of IOMMUs into the memory API

2013-05-24 Thread Paolo Bonzini
Il 24/05/2013 16:12, Alexey Kardashevskiy ha scritto: > On 05/24/2013 03:08 AM, Paolo Bonzini wrote: >> Il 22/05/2013 11:24, Paolo Bonzini ha scritto: >>> Il 22/05/2013 04:30, Alexey Kardashevskiy ha scritto: On 05/21/2013 08:57 PM, Paolo Bonzini wrote: > This is part 1 of the memory API u

Re: [Qemu-devel] [RFC PATCH v3 02/11] Fix errors and warnings while compiling with c++ compilier

2013-05-24 Thread Tomoki Sekiyama
On 5/24/13 4:52 , "Stefan Hajnoczi" wrote: >On Thu, May 23, 2013 at 06:34:43PM +, Tomoki Sekiyama wrote: >> On 5/23/13 8:12 , "Stefan Hajnoczi" wrote: >> >> >On Tue, May 21, 2013 at 11:33:41AM -0400, Tomoki Sekiyama wrote: >> >> Add C++ keywords to avoid errors in compiling with c++ compile

Re: [Qemu-devel] [RFC PATCH v3 05/11] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-05-24 Thread Tomoki Sekiyama
On 5/24/13 4:54 , "Stefan Hajnoczi" wrote: >On Thu, May 23, 2013 at 06:36:35PM +, Tomoki Sekiyama wrote: >> On 5/23/13 8:22 , "Stefan Hajnoczi" wrote: >> >> >On Tue, May 21, 2013 at 11:33:52AM -0400, Tomoki Sekiyama wrote: >> >> diff --git a/qga/vss-win32.h b/qga/vss-win32.h >> >> new file

[Qemu-devel] [PULL 00/11] Block patches

2013-05-24 Thread Stefan Hajnoczi
The following changes since commit 64afc2b4d48fb21e085517c38a59a3f61a11283c: Merge remote-tracking branch 'luiz/queue/qmp' into staging (2013-05-23 14:16:35 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git block for you to fetch changes up to 02ffb504485f0

[Qemu-devel] [PATCH 02/11] block: move input parsing code in qmp_transaction()

2013-05-24 Thread Stefan Hajnoczi
From: Wenchao Xia The code is moved into preparation function, and changed a bit to tip more clearly what it is doing. Signed-off-by: Wenchao Xia Reviewed-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- blockdev.c | 38 +++--

[Qemu-devel] [PATCH 03/11] block: package committing code in qmp_transaction()

2013-05-24 Thread Stefan Hajnoczi
From: Wenchao Xia The code is simply moved into a separate function. Signed-off-by: Wenchao Xia Reviewed-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- blockdev.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-)

[Qemu-devel] [PATCH 07/11] qemu-io: Fix 'map' output

2013-05-24 Thread Stefan Hajnoczi
From: Kevin Wolf The output of the 'map' command in qemu-io used to directly resemble bdrv_is_allocated() and could contain many lines for small chunks that all have the same allocation status. After this patch, they will be coalesced into a single output line for a large chunk. As a side effect

[Qemu-devel] [PATCH 05/11] block: make all steps in qmp_transaction() as callback

2013-05-24 Thread Stefan Hajnoczi
From: Wenchao Xia Make it easier to add other operations to qmp_transaction() by using callbacks, with external snapshots serving as an example implementation of the callbacks. Signed-off-by: Wenchao Xia Reviewed-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi Reviewed-by: Eric Blake Signed-off-

[Qemu-devel] [PATCH 09/11] qemu-iotests: Try creating huge qcow2 image

2013-05-24 Thread Stefan Hajnoczi
From: Kevin Wolf It's supposed to fail gracefully instead of segfaulting. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/054 | 58 tests/qemu-iotests/054.out | 10 tests/qemu-iotests/common.rc | 2 +- tests/qemu-iotests/group

[Qemu-devel] [PATCH 08/11] qcow2.py: Subcommand for changing header fields

2013-05-24 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf --- tests/qemu-iotests/qcow2.py | 17 + 1 file changed, 17 insertions(+) diff --git a/tests/qemu-iotests/qcow2.py b/tests/qemu-iotests/qcow2.py index fecf5b9..44a2b45 100755 --- a/tests/qemu-iotests/qcow2.py +++ b/tests/qemu-iotests/qc

Re: [Qemu-devel] [PATCH] i.MX: split GPT and EPIT timer implementation

2013-05-24 Thread Peter Maydell
On 19 May 2013 20:03, Jean-Christophe DUBOIS wrote: > There is no common code between these 2 timer implementation. > So it is better to split them. > > Signed-off-by: Jean-Christophe DUBOIS Thanks, applied to arm-devs.next. -- PMM

[Qemu-devel] [PATCH 06/11] blockdev: Rename BlockdevAction -> TransactionAction

2013-05-24 Thread Stefan Hajnoczi
From: Kevin Wolf There's no reason to restrict transactions to operations related to block devices, so rename the type now before schema introspection stops us from doing so. Also change the schema documentation of 'transaction' to not refer to block devices or snapshots any more. Signed-off-by

[Qemu-devel] [PATCH 10/11] coroutine: protect global pool with a mutex

2013-05-24 Thread Stefan Hajnoczi
The coroutine freelist is a global pool of unused coroutines. It avoids the setup/teardown overhead associated with the coroutine lifecycle. Since the pool is global, we need to synchronize access so that coroutines can be used outside the BQL. Signed-off-by: Stefan Hajnoczi --- qemu-coroutine.

[Qemu-devel] [PATCH 01/11] block: package preparation code in qmp_transaction()

2013-05-24 Thread Stefan Hajnoczi
From: Wenchao Xia The code before really committing is moved into a function. Most code is simply moved from qmp_transaction(), except that on fail it just returns now. Other code such as input parsing is not touched, to make it easier in review. Signed-off-by: Wenchao Xia Reviewed-by: Kevin Wo

[Qemu-devel] [PATCH 2/2] rtl8139: flush queued packets when RxBufPtr is written

2013-05-24 Thread Stefan Hajnoczi
Net queues support efficient "receive disable". For example, tap's file descriptor will not be polled while its peer has receive disabled. This saves CPU cycles for needlessly copying and then dropping packets which the peer cannot receive. rtl8139 is missing the qemu_flush_queued_packets() call

[Qemu-devel] [PATCH 1/2] net: support for bridged networking on Mac OS X

2013-05-24 Thread Stefan Hajnoczi
From: Alasdair McLeay tun tap can be implemented on Mac OS X using http://tuntaposx.sourceforge.net It behaves in the same way as FreeBSD/OpenBSD implementations, but Qemu needs a patch to use the OpenBS/FreeBSD code. As per the patch listed in this forum thread: http://forum.gns3.net/post17679

[Qemu-devel] [PULL 0/2] Net patches

2013-05-24 Thread Stefan Hajnoczi
The following changes since commit 64afc2b4d48fb21e085517c38a59a3f61a11283c: Merge remote-tracking branch 'luiz/queue/qmp' into staging (2013-05-23 14:16:35 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git net for you to fetch changes up to 00b7ade807b5ce6

Re: [Qemu-devel] [PATCH v5 3/3] configure/Make: Build libfdt from submodule DTC

2013-05-24 Thread Peter Maydell
On 24 May 2013 15:33, Edgar E. Iglesias wrote: > On Fri, May 24, 2013 at 03:16:00PM +0100, Peter Maydell wrote: >> Hi -- can you point me at the fix? Did it get committed? >> I did a search of my mail archives but couldn't find anything >> that looked like it. >> >> (I'm looking at making libfdt m

Re: [Qemu-devel] [PATCH v5 3/3] configure/Make: Build libfdt from submodule DTC

2013-05-24 Thread Edgar E. Iglesias
On Fri, May 24, 2013 at 03:16:00PM +0100, Peter Maydell wrote: > On 22 April 2013 05:45, Peter Crosthwaite > wrote: > > On Sun, Apr 21, 2013 at 11:16 PM, Paolo Bonzini wrote: > >> libfdt is not that portable, it doesn't use libtool to build shared > >> libraries. > >> > >> Perhaps we can just bu

[Qemu-devel] [PATCH 11/11] coroutine: stop using AioContext in CoQueue

2013-05-24 Thread Stefan Hajnoczi
qemu_co_queue_next(&queue) arranges that the next queued coroutine is run at a later point in time. This deferred restart is useful because the caller may not want to transfer control yet. This behavior was implemented using QEMUBH in the past, which meant that CoQueue (and hence CoMutex and CoRw

[Qemu-devel] [PATCH 04/11] block: package rollback code in qmp_transaction()

2013-05-24 Thread Stefan Hajnoczi
From: Wenchao Xia Signed-off-by: Wenchao Xia Reviewed-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- blockdev.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 76f0532..2131e13 1

Re: [Qemu-devel] [PATCH] rtl8139: flush queued packets when RxBufPtr is written

2013-05-24 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 02:50:18PM +0200, Stefan Hajnoczi wrote: > Net queues support efficient "receive disable". For example, tap's file > descriptor will not be polled while its peer has receive disabled. This > saves CPU cycles for needlessly copying and then dropping packets which > the peer

Re: [Qemu-devel] qmp commands get rejected

2013-05-24 Thread Stefan Priebe - Profihost AG
Am 24.05.2013 um 16:02 schrieb Luiz Capitulino : > On Fri, 24 May 2013 15:57:59 +0200 > Stefan Priebe - Profihost AG wrote: > >> Am 24.05.2013 um 15:23 schrieb Luiz Capitulino : >> >>> On Fri, 24 May 2013 07:50:33 +0200 >>> Stefan Priebe wrote: >>> Hello list, since upgradi

Re: [Qemu-devel] [RFC PATCH v3 02/11] Fix errors and warnings while compiling with c++ compilier

2013-05-24 Thread Tomoki Sekiyama
On 5/24/13 9:01 , "Laszlo Ersek" wrote: >On 05/21/13 17:33, Tomoki Sekiyama wrote: > >> diff --git a/scripts/qapi.py b/scripts/qapi.py >> index afc5f32..b174acb 100644 >> --- a/scripts/qapi.py >> +++ b/scripts/qapi.py >> @@ -156,9 +156,16 @@ def c_var(name, protect=True): >> # GCC http://gcc

[Qemu-devel] [ANNOUNCE] QEMU 1.4.2 Stable released

2013-05-24 Thread mdroth
Hi everyone, I am pleased to announce that the QEMU v1.4.2 stable release is now available at: http://wiki.qemu.org/download/qemu-1.4.2.tar.bz2 The official stable-1.4 repository has also been updated to v1.4.2: http://git.qemu.org/?p=qemu-stable-1.4.git;a=summary This release contains 25 buil

Re: [Qemu-devel] [PATCH 2/2] rtl8139: flush queued packets when RxBufPtr is written

2013-05-24 Thread Paolo Bonzini
Il 24/05/2013 16:38, Stefan Hajnoczi ha scritto: > Net queues support efficient "receive disable". For example, tap's file > descriptor will not be polled while its peer has receive disabled. This > saves CPU cycles for needlessly copying and then dropping packets which > the peer cannot receive.

  1   2   3   >