On 23.05.2013 15:03, Peter Maydell wrote:
> On 23 May 2013 13:53, Andreas Färber wrote:
>> Am 23.05.2013 14:50, schrieb Peter Maydell:
>>> I'm happy for us to wait until an actual big-endian system
>>> running Linux appears before we worry about it.
>
>> I was worried about Big Endian QEMU target
On Thu, May 23, 2013 at 11:48 AM, Gleb Natapov wrote:
> On Thu, May 23, 2013 at 08:53:55AM +0800, Asias He wrote:
>> On Wed, May 22, 2013 at 05:36:08PM -0700, Badari wrote:
>> > Hi,
>> >
>> > While testing vhost-scsi in the current qemu git, ran into an earlier issue
>> > with seabios. I had to di
On Thu, May 23, 2013 at 11:37:59AM +0800, Fam Zheng wrote:
> @@ -90,7 +98,16 @@ static int curl_aio_flush(void *opaque);
> static int curl_sock_cb(CURL *curl, curl_socket_t fd, int action,
> void *s, void *sp)
> {
> +BDRVCURLState *bs = s;
bs is used for BlockDriverS
Il 23/05/2013 15:28, Stefan Hajnoczi ha scritto:
> On Thu, May 23, 2013 at 3:20 PM, Paolo Bonzini wrote:
>> Il 23/05/2013 14:15, Stefan Hajnoczi ha scritto:
>>> On Tue, May 21, 2013 at 11:33:33AM -0400, Tomoki Sekiyama wrote:
* How to build & run qemu-ga with VSS support
- Download
Kevin Wolf writes:
> Am 23.05.2013 um 14:08 hat Anthony Liguori geschrieben:
>> Kevin Wolf writes:
>>
>>
>> There are two things here: the schema and the generated code. The
>> generated code can and should live in the module.
>>
>> But the schema always stays the same.
>>
>> Think of the s
On Thu, May 23, 2013 at 11:38:03AM +0800, Fam Zheng wrote:
> diff --git a/block/curl.c b/block/curl.c
> index fc464ad..4fd5bb9 100644
> --- a/block/curl.c
> +++ b/block/curl.c
> @@ -89,6 +89,7 @@ typedef struct BDRVCURLState {
> QLIST_HEAD(, CURLSockInfo) socks;
> char *url;
> size_t
On Thu, 16 May 2013 13:19:47 +0800
Amos Kong wrote:
> It's clearer to use defined macros than magic numbers.
>
> Signed-off-by: Amos Kong
Applied to the qmp branch, thanks.
> ---
> ui/input.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/ui/input.c b
On 05/23/2013 06:46 AM, Luiz Capitulino wrote:
> On Thu, 23 May 2013 13:51:22 +0200
> Stefan Hajnoczi wrote:
>
>> With better QMP introspection on the horizon and work in various
>> subsystems pushing QMP boundaries it would be useful to bring together
>> the latest best practices for designing Q
On 23/05/13 05:50 AM, Michael S. Tsirkin wrote:
Hey guys,
I've updated the kvm networking todo wiki with current projects.
Will try to keep it up to date more often.
Original announcement below.
I've put up a wiki page with a kvm networking todo list,
mainly to avoid effort duplication, bu
On Thu, May 23, 2013 at 11:38:04AM +0800, Fam Zheng wrote:
> +typedef struct CURLDataCache {
> +char *data;
> +size_t base_pos;
Must be int64_t. QEMU compiled on 32-bit hosts would only allow 4 GB
images with size_t!
> +size_t data_len;
> +size_t write_pos;
> +/* Ref count fo
On 05/23/2013 07:52 AM, Anthony Liguori wrote:
>> libvirt already knows how to use features. It must know it, just parsing
>> the schema doesn't automagically give you libvirt code, so someone must
>> have coded the libvirt side of things. The interesting part is whether a
>> given interface is ava
On Thu, May 23, 2013 at 11:38:05AM +0800, Fam Zheng wrote:
> @@ -221,31 +215,35 @@ static void curl_complete_io(BDRVCURLState *bs,
> CURLAIOCB *acb,
>
> static size_t curl_read_cb(void *ptr, size_t size, size_t nmemb, void
> *opaque)
> {
> -CURLState *s = ((CURLState*)opaque);
> +CURL
On Thu, 23 May 2013 13:24:59 +0300
"Michael S. Tsirkin" wrote:
> On Thu, May 23, 2013 at 05:07:59PM +0800, Amos Kong wrote:
> > Introduce this new QMP event to notify management after guest changes
> > rx-filter configuration.
> >
> > Signed-off-by: Amos Kong
> > ---
> > QMP/qmp-events.txt
Am 23.05.2013 um 15:52 hat Anthony Liguori geschrieben:
> Kevin Wolf writes:
>
> > Am 23.05.2013 um 14:08 hat Anthony Liguori geschrieben:
> >> Kevin Wolf writes:
> >>
> >>
> >> There are two things here: the schema and the generated code. The
> >> generated code can and should live in the mo
On Thu, May 23, 2013 at 11:38:06AM +0800, Fam Zheng wrote:
> @@ -660,9 +651,13 @@ static BlockDriverAIOCB *curl_aio_readv(BlockDriverState
> *bs,
> static void curl_close(BlockDriverState *bs)
> {
> BDRVCURLState *s = bs->opaque;
> -int i;
>
> DPRINTF("CURL: Close\n");
> +if
I'm working on adding new virtio layout to qemu.
The job is complicated by the fact that
qemu has its own copy of the virtio headers,
sometimes with slightly different names
and structure.
Import headers from linux instead.
Michael S. Tsirkin (10):
scripts/update-linux-headers.sh: add virtio
v
It's easier to keep everything in sync if
we just use linux headers for virtio constants.
Add virtio_rng.h header from linux 3.10-rc1, and
remove duplicate symbols from virtio-rng.h
Signed-off-by: Michael S. Tsirkin
---
include/hw/virtio/virtio-rng.h | 5 ++---
linux-headers/linux/virtio_rng.h
Add virtio headers to make it easy to keep
things in sync.
Signed-off-by: Michael S. Tsirkin
---
scripts/update-linux-headers.sh | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
index 120a694..
It's easier to keep everything in sync if
we just use linux headers for virtio constants.
Add virtio_console.h header from linux 3.10-rc1, and
remove duplicate symbols from virtio-serial.h
Signed-off-by: Michael S. Tsirkin
---
include/hw/virtio/virtio-serial.h| 38 +-
linux-h
All imported headers will use it.
Signed-off-by: Michael S. Tsirkin
---
linux-headers/linux/virtio_ids.h | 43
1 file changed, 43 insertions(+)
create mode 100644 linux-headers/linux/virtio_ids.h
diff --git a/linux-headers/linux/virtio_ids.h b/linux-hea
It's easier to keep everything in sync if
we just use linux headers for virtio constants.
Add virtio-9p header from linux 3.10-rc1, and
remove duplicate symbols from virtio-9p.h
Signed-off-by: Michael S. Tsirkin
---
hw/9pfs/virtio-9p.h | 13 +---
linux-headers/linux/virtio_9p
It's easier to keep everything in sync if
we just use linux headers for virtio constants.
Add virtio_balloon.h header from linux 3.10-rc1, and
remove duplicate symbols from virtio-balloon.h
Signed-off-by: Michael S. Tsirkin
---
hw/virtio/virtio-balloon.c | 2 +-
include/hw/virtio/virt
It's easier to keep everything in sync if
we just use linux headers for virtio constants.
Add virtio_pci.h header from linux 3.10-rc1, and
remove duplicate symbols from virtio-pci.h
Signed-off-by: Michael S. Tsirkin
---
hw/virtio/virtio-pci.c | 49 +++-
linux-headers/li
On Thu, May 23, 2013 at 11:37:58AM +0800, Fam Zheng wrote:
> CURL library API has changed, the current curl driver is not working.
> This patch rewrites the use of API as well as the structure of internal
> states.
>
> BDRVCURLState holds the pointer to curl multi interface (man 3
> libcurl-multi)
On 23 May 2013 15:34, Michael S. Tsirkin wrote:
> I'm working on adding new virtio layout to qemu.
> The job is complicated by the fact that
> qemu has its own copy of the virtio headers,
> sometimes with slightly different names
> and structure.
> Import headers from linux instead.
Do the kernel
On Thu, May 23, 2013 at 10:28:42AM -0400, Luiz Capitulino wrote:
> On Thu, 23 May 2013 13:24:59 +0300
> "Michael S. Tsirkin" wrote:
>
> > On Thu, May 23, 2013 at 05:07:59PM +0800, Amos Kong wrote:
> > > Introduce this new QMP event to notify management after guest changes
> > > rx-filter configur
On Thu, May 23, 2013 at 10:16:13PM +1000, David Gibson wrote:
> On Thu, May 23, 2013 at 02:01:57PM +0300, Michael S. Tsirkin wrote:
> > On Thu, May 09, 2013 at 10:31:10AM +1000, David Gibson wrote:
> > > Currently pci_get_primary_bus() searches the list of root buses for one
> > > with domain 0. B
We already have ring structure in virtio-ring.h for use by dataplane.
Use it in virtio.h as well, renaming some conflicting functions.
Signed-off-by: Michael S. Tsirkin
---
hw/virtio/virtio.c | 23 +--
include/hw/virtio/virtio.h | 45 +++---
On Thu, May 23, 2013 at 11:38:07AM +0800, Fam Zheng wrote:
> Introduce a cache quota: BDRVCURLState.cache_quota.
> When adding new CURLDataCache to BDRVCURLState, if number of existing
> CURLDataCache is larger than CURL_CACHE_QUOTA, try to release some first
> to limit the in memory cache size.
>
On 05/23/2013 06:32 AM, Stefan Hajnoczi wrote:
On Thu, May 23, 2013 at 11:48 AM, Gleb Natapov wrote:
On Thu, May 23, 2013 at 08:53:55AM +0800, Asias He wrote:
On Wed, May 22, 2013 at 05:36:08PM -0700, Badari wrote:
Hi,
While testing vhost-scsi in the current qemu git, ran into an earlier iss
Am 23.05.2013 um 13:57 hat Stefan Hajnoczi geschrieben:
> On Wed, May 22, 2013 at 03:53:05PM +0200, Kevin Wolf wrote:
> > Am 16.05.2013 um 21:05 hat Eric Blake geschrieben:
> > > On 05/16/2013 02:24 AM, Kevin Wolf wrote:
> > The other thing that I'm not sure about is whether we should teach QAPI
>
It's easier to keep everything in sync if
we just use linux headers for virtio constants.
Add virtio_blk.h header from linux 3.10-rc1, and
remove duplicate symbols from virtio-blk.h
In particular, it turns out that linux does
not have struct virtio_blk_inhdr for the status
field, so make this stru
On 05/23/2013 08:43 AM, Michael S. Tsirkin wrote:
>>> Please stress this is only for the NIC. It does not apply
>>> to non-NIC netclients.
>>
>> Stress it in the event name too, please. I find RX_FILTER_CHANGED a bit
>> generic.
>
> What do you suggest?
> NIC_RX_FILTER_CHANGED ?
Yes, that might w
Il 09/05/2013 02:31, David Gibson ha scritto:
> diff --git a/hw/pci/Makefile.objs b/hw/pci/Makefile.objs
> index a7fb9d0..2ad32b6 100644
> --- a/hw/pci/Makefile.objs
> +++ b/hw/pci/Makefile.objs
> @@ -8,4 +8,4 @@ common-obj-$(CONFIG_PCI) += pcie.o pcie_aer.o pcie_port.o
> common-obj-$(CONFIG_NO_PC
On Thu, May 23, 2013 at 03:41:07PM +0100, Peter Maydell wrote:
> On 23 May 2013 15:34, Michael S. Tsirkin wrote:
> > I'm working on adding new virtio layout to qemu.
> > The job is complicated by the fact that
> > qemu has its own copy of the virtio headers,
> > sometimes with slightly different n
On Thu, May 23, 2013 at 04:51:17PM +0200, Paolo Bonzini wrote:
> Il 23/05/2013 13:04, Michael S. Tsirkin ha scritto:
> >> > Most current uses of pci_find_domain() are for error or informational
> >> > messages, so the change in identifiers should be harmless. The exception
> >> > is pci_get_dev_pa
On Thu, May 23, 2013 at 08:52:16AM -0600, Eric Blake wrote:
> On 05/23/2013 08:43 AM, Michael S. Tsirkin wrote:
> >>> Please stress this is only for the NIC. It does not apply
> >>> to non-NIC netclients.
> >>
> >> Stress it in the event name too, please. I find RX_FILTER_CHANGED a bit
> >> generic
Il 23/05/2013 16:48, Badari Pulavarty ha scritto:
>> The common virtio-scsi code in QEMU should guard against this. In
>> virtio-blk data plane I hit a similar case and ended up starting the
>> data plane thread (equivalent to vhost here) *before* the status
>> register is set to DRIVER_OK.
>
> T
Il 23/05/2013 16:57, Michael S. Tsirkin ha scritto:
> On Thu, May 23, 2013 at 04:51:17PM +0200, Paolo Bonzini wrote:
>> Il 23/05/2013 13:04, Michael S. Tsirkin ha scritto:
> Most current uses of pci_find_domain() are for error or informational
> messages, so the change in identifiers should
Il 23/05/2013 13:04, Michael S. Tsirkin ha scritto:
>> > Most current uses of pci_find_domain() are for error or informational
>> > messages, so the change in identifiers should be harmless. The exception
>> > is pci_get_dev_path(), whose results form part of migration streams. To
>> > maintain c
On 2013-05-23 14:05, David Gibson wrote:
> On Tue, May 21, 2013 at 12:57:16PM +0200, Paolo Bonzini wrote:
>> The old-style IOMMU lets you check whether an access is valid in a
>> given DMAContext. There is no equivalent for AddressSpace in the
>> memory API, implement it with a lookup of the dispa
On Thu, May 23, 2013 at 05:00:39PM +0200, Paolo Bonzini wrote:
> Il 23/05/2013 16:57, Michael S. Tsirkin ha scritto:
> > On Thu, May 23, 2013 at 04:51:17PM +0200, Paolo Bonzini wrote:
> >> Il 23/05/2013 13:04, Michael S. Tsirkin ha scritto:
> > Most current uses of pci_find_domain() are for err
It's easier to keep everything virtio in sync if
we just use headers exported from linux kernel.
Import linux/virtio_net.h and linux/if_ether.h
that it depends on. Switch to symbols from
that header for stuff that was
duplicated in tap.h and eth.h
Signed-off-by: Michael S. Tsirkin
---
include/hw
On 05/23/2013 02:47 AM, Wenchao Xia wrote:
> This function takes an input parameter *output, which can be specified by
> caller as stderr, stdout or a monitor. error_vprintf() now calls
> message_vprintf(),
> which is a static function added in this patch.
>
> Signed-off-by: Wenchao Xia
> ---
>
Il 23/05/2013 16:22, Jan Kiszka ha scritto:
>>> >> The old-style IOMMU lets you check whether an access is valid in a
>>> >> given DMAContext. There is no equivalent for AddressSpace in the
>>> >> memory API, implement it with a lookup of the dispatch tree.
>> >
>> > I don't love the name - "addr
On Thu, May 23, 2013 at 04:58:05PM +0200, Paolo Bonzini wrote:
> Il 23/05/2013 16:48, Badari Pulavarty ha scritto:
> >> The common virtio-scsi code in QEMU should guard against this. In
> >> virtio-blk data plane I hit a similar case and ended up starting the
> >> data plane thread (equivalent to
Il 23/05/2013 17:27, Asias He ha scritto:
> On Thu, May 23, 2013 at 04:58:05PM +0200, Paolo Bonzini wrote:
>> Il 23/05/2013 16:48, Badari Pulavarty ha scritto:
The common virtio-scsi code in QEMU should guard against this. In
virtio-blk data plane I hit a similar case and ended up starti
On 05/23/2013 02:47 AM, Wenchao Xia wrote:
> Buffer is not used now so the string would not be truncated any more. They
> can be used
> by both qemu and qemu-img with correct parameter specified.
>
> Signed-off-by: Wenchao Xia
> ---
> block/qapi.c | 65
> +++--
On Thu, May 23, 2013 at 05:56:43PM +0300, Michael S. Tsirkin wrote:
> On Thu, May 23, 2013 at 03:41:07PM +0100, Peter Maydell wrote:
> > On 23 May 2013 15:34, Michael S. Tsirkin wrote:
> > > I'm working on adding new virtio layout to qemu.
> > > The job is complicated by the fact that
> > > qemu h
On Thu, 23 May 2013 17:57:56 +0300
"Michael S. Tsirkin" wrote:
> On Thu, May 23, 2013 at 08:52:16AM -0600, Eric Blake wrote:
> > On 05/23/2013 08:43 AM, Michael S. Tsirkin wrote:
> > >>> Please stress this is only for the NIC. It does not apply
> > >>> to non-NIC netclients.
> > >>
> > >> Stress
On Thu, 16 May 2013 18:17:23 +0300
"Michael S. Tsirkin" wrote:
> > The
> > existing throttling approach ensures that if the event includes latest
> > guest information, then the host doesn't even have to do do a query, and
> > is guaranteed that reacting to the final event will always see the mos
On Thu, May 23, 2013 at 4:41 PM, Kevin Wolf wrote:
> Am 23.05.2013 um 13:57 hat Stefan Hajnoczi geschrieben:
>> On Wed, May 22, 2013 at 03:53:05PM +0200, Kevin Wolf wrote:
>> > Am 16.05.2013 um 21:05 hat Eric Blake geschrieben:
>> > > On 05/16/2013 02:24 AM, Kevin Wolf wrote:
>> > The other thing
Il 23/05/2013 17:32, Michael S. Tsirkin ha scritto:
> On Thu, May 23, 2013 at 05:56:43PM +0300, Michael S. Tsirkin wrote:
>> On Thu, May 23, 2013 at 03:41:07PM +0100, Peter Maydell wrote:
>>> On 23 May 2013 15:34, Michael S. Tsirkin wrote:
I'm working on adding new virtio layout to qemu.
On Thu, 23 May 2013 17:08:00 +0800
Amos Kong wrote:
> We want to implement mac programming over macvtap through Libvirt,
> related rx-filter configuration contains main mac, some of rx-mode
> and mac-table.
>
> The previous patch adds QMP event to notify management of rx-filter
> change. This pa
On 05/23/2013 07:58 AM, Paolo Bonzini wrote:
Il 23/05/2013 16:48, Badari Pulavarty ha scritto:
The common virtio-scsi code in QEMU should guard against this. In
virtio-blk data plane I hit a similar case and ended up starting the
data plane thread (equivalent to vhost here) *before* the status
On 05/23/2013 08:30 AM, Paolo Bonzini wrote:
Il 23/05/2013 17:27, Asias He ha scritto:
On Thu, May 23, 2013 at 04:58:05PM +0200, Paolo Bonzini wrote:
Il 23/05/2013 16:48, Badari Pulavarty ha scritto:
The common virtio-scsi code in QEMU should guard against this. In
virtio-blk data plane I hit
Il 23/05/2013 18:11, Badari Pulavarty ha scritto:
> On 05/23/2013 08:30 AM, Paolo Bonzini wrote:
>> Il 23/05/2013 17:27, Asias He ha scritto:
>>> On Thu, May 23, 2013 at 04:58:05PM +0200, Paolo Bonzini wrote:
Il 23/05/2013 16:48, Badari Pulavarty ha scritto:
>> The common virtio-scsi code
On 05/23/2013 01:18 AM, Claudio Fontana wrote:
> +static inline void patch_reloc(uint8_t *code_ptr, int type,
> + tcg_target_long value, tcg_target_long addend)
> +{
> +switch (type) {
> +case R_AARCH64_JUMP26:
> +case R_AARCH64_CALL26:
> +reloc_pc2
On 05/23/2013 09:19 AM, Paolo Bonzini wrote:
Il 23/05/2013 18:11, Badari Pulavarty ha scritto:
On 05/23/2013 08:30 AM, Paolo Bonzini wrote:
Il 23/05/2013 17:27, Asias He ha scritto:
On Thu, May 23, 2013 at 04:58:05PM +0200, Paolo Bonzini wrote:
Il 23/05/2013 16:48, Badari Pulavarty ha scritto
On 23 May 2013 09:18, Claudio Fontana wrote:
>
> add preliminary support for TCG target aarch64.
Richard's handling the technical bits of the review, so
just some minor style nits here.
I tested this on the foundation model and was able to boot
a 32-bit-ARM kernel.
> +static inline void reloc_p
On 05/23/2013 04:59 AM, Peter Maydell wrote:
> TCGv changes size depending on the compile time value of
> TARGET_LONG_BITS. This is useful for generating code for MIPS style
> "instructions are the same but the register width changes" CPUs, and
> also for the generic bits of QEMU which operate on
On 05/23/2013 04:59 AM, Peter Maydell wrote:
> gen_ld64() and gen_st64() are used only in one place, so just
> expand them out.
>
> Signed-off-by: Peter Maydell
> ---
> target-arm/translate.c | 19 ---
> 1 file changed, 4 insertions(+), 15 deletions(-)
Reviewed-by: Richard Hen
On 05/23/2013 04:59 AM, Peter Maydell wrote:
> Signed-off-by: Peter Maydell
> ---
> target-arm/translate.c | 18 ++
> 1 file changed, 10 insertions(+), 8 deletions(-)
Reviewed-by: Richard Henderson
r~
Il 23/05/2013 18:38, Badari Pulavarty ha scritto:
>> If that is with the old SeaBIOS, then SIGABRT is intended. :) The guest
>> is buggy, the problem in QEMU only lies in _how_ it fails.
>>
>> Paolo
>>
>>
>
> I am confused now. Without above changes, seabios fix makes the
> guest boot. But with t
On 05/23/2013 05:00 AM, Peter Maydell wrote:
> AArch32 code (ie traditional 32 bit world) expects to be
> able to pass a vaddr in a TCGv_i32. However when QEMU is
> compiled with TARGET_LONG_BITS=32 the TCG load/store
> functions take a TCGv_i64. Abstract out load/store with
> a 32 bit vaddr so we
Hi Laszlo,
Thank you for reviewing.
On 5/23/13 7:05 , "Laszlo Ersek" wrote:
>Sekiyama-san,
>
>On 05/21/13 17:33, Tomoki Sekiyama wrote:
>
>> * About errors in Windows 7 with patch v2
>> VSS requires to write to snapshot volumes just before making them
>>read-only
>> at final commit phase. T
> mmap is used in qemu_vmalloc function instead of qemu_memalign(commit
> 7dda5dc8), so it should change qemu_vfree to munmap to fix a unmatched
> issue.
>
> This issue appears when a PCI device is being assigned to KVM guest,
> failure to read PCI rom file will bring RAM free, then the incorrect
On Thu, 23 May 2013 16:47:15 +0800
Wenchao Xia wrote:
> This function takes an input parameter *output, which can be specified by
> caller as stderr, stdout or a monitor. error_vprintf() now calls
> message_vprintf(),
> which is a static function added in this patch.
>
> Signed-off-by: Wenchao
Il 22/05/2013 11:24, Paolo Bonzini ha scritto:
> Il 22/05/2013 04:30, Alexey Kardashevskiy ha scritto:
>> On 05/21/2013 08:57 PM, Paolo Bonzini wrote:
>>> This is part 1 of the memory API updates for 1.6. (Part 2 is the
>>> introduction of get/set_owner, part 3 is the introduction of the
>>> RCU-s
On Thu, May 23, 2013 at 11:54:03AM -0400, Luiz Capitulino wrote:
> On Thu, 16 May 2013 18:17:23 +0300
> "Michael S. Tsirkin" wrote:
>
> > > The
> > > existing throttling approach ensures that if the event includes latest
> > > guest information, then the host doesn't even have to do do a query, a
On Thu, May 23, 2013 at 6:47 PM, Paolo Bonzini wrote:
> Il 23/05/2013 18:38, Badari Pulavarty ha scritto:
>>> If that is with the old SeaBIOS, then SIGABRT is intended. :) The guest
>>> is buggy, the problem in QEMU only lies in _how_ it fails.
>>>
>>> Paolo
>>>
>>>
>>
>> I am confused now. Witho
On 23 May 2013 18:08, Paolo Bonzini wrote:
> BTW, if you give me your Tested-by it would be good, since most comments
> have been cosmetic. I'd like to collect all of Peter's Reviewed-by from
> the RFC and send a pull request next week.
There's been at least one requested fix in code review, so
Il 23/05/2013 19:25, Peter Maydell ha scritto:
>> > BTW, if you give me your Tested-by it would be good, since most comments
>> > have been cosmetic. I'd like to collect all of Peter's Reviewed-by from
>> > the RFC and send a pull request next week.
> There's been at least one requested fix in cod
- Messaggio originale -
> Da: "Stefan Hajnoczi"
> A: "Paolo Bonzini"
> Cc: "Badari Pulavarty" , "Asias He" ,
> "Nicholas A. Bellinger"
> , "qemu-devel" , "Gleb Natapov"
>
> Inviato: Giovedì, 23 maggio 2013 19:18:26
> Oggetto: Re: qemu seabios issue with vhost-scsi
>
> On Thu, May 23
On 21 May 2013 11:57, Paolo Bonzini wrote:
> It is not used anywhere.
So does this get deleted just because it's not used, or because
it gets in the way of patches later in the series. As far as I
can tell the st*_phys_notdirty() are for TCG to update page
table entries with accessed/modified bit
On 21 May 2013 11:57, Paolo Bonzini wrote:
> While sized to 15 bits in PhysPageEntry, the ptr field is ORed into the
> iotlb entries together with a page-aligned pointer. The ptr field must
> not overflow into this page-aligned value, assert that it is smaller than
> the page size.
>
> Signed-off
From: Petar Jovanovic
Multiplication of Q15 fractional halfword vectors was incorrect in the
previous implementation of mipsdsp_rndq15_mul_q15_q15. It failed to take
element signs into account. This change fixes it, and it adds a test case
for it.
The change also removes unnecessary cast in the
Provides support for in-memory VNVRAM entries. The in-memory
entries are used for fast access to entry data such as the
current or max size of an entry and the disk offset where an
entry's binary blob data is stored.
Signed-off-by: Corey Bryant
---
vnvram.c | 196 ++
Provides VNVRAM APIs that can be used by other areas of QEMU to
provide persistent storage.
Signed-off-by: Corey Bryant
---
vnvram.c | 266 ++
vnvram.h | 14 +++
2 files changed, 280 insertions(+), 0 deletions(-)
diff --git a/vnvram
This patch series provides VNVRAM persistent storage support that
QEMU can use internally. The initial target user will be a software
vTPM 1.2 backend that needs to store keys in VNVRAM and be able to
reboot/migrate and retain the keys.
This support uses QEMU's block driver to provide persistent
Provides support that schedules and executes VNVRAM read/write
requests. A bottom-half is used to perform reads/writes from
the QEMU main thread.
Signed-off-by: Corey Bryant
---
vnvram.c | 142 ++
1 files changed, 142 insertions(+), 0
Provides debug support that dumps the disk and in-memory VNVRAM
contents to stderr.
Signed-off-by: Corey Bryant
---
vnvram.c | 94 ++
1 files changed, 94 insertions(+), 0 deletions(-)
diff --git a/vnvram.c b/vnvram.c
index 357923d..9
Signed-off-by: Corey Bryant
---
vl.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index 59dc0b4..5da88e6 100644
--- a/vl.c
+++ b/vl.c
@@ -171,6 +171,8 @@ int main(int argc, char **argv)
#include "ui/qemu-spice.h"
#include "qapi/string-input-visitor.h
Signed-off-by: Corey Bryant
---
hmp.c| 32
hmp.h|1 +
monitor.c|7 +
qapi-schema.json | 47 +++
qmp-commands.hx | 41 +++
vnvram.c | 71 +++
Provides low-level VNVRAM functionality that reads and writes data,
such as an entry's binary blob, to a drive image using the block
driver.
Signed-off-by: Corey Bryant
---
Makefile.objs |2 +
vnvram.c | 487 +
vnvram.h | 2
On 21 May 2013 11:57, Paolo Bonzini wrote:
> memory_region_find() is similar to registering a MemoryListener and
> checking for the MemoryRegionSections that come from a particular
> region. There is no reason for this to be limited to a root memory
> region.
>
> Signed-off-by: Paolo Bonzini
> -
On 05/23/2013 11:44 AM, Corey Bryant wrote:
> Signed-off-by: Corey Bryant
> ---
Might help to list a sample HMP or QMP usage in the commit message.
> +++ b/qapi-schema.json
> @@ -3619,3 +3619,50 @@
> '*cpuid-input-ecx': 'int',
> 'cpuid-register': 'X86CPURegister32',
>
Corey Bryant writes:
> This patch series provides VNVRAM persistent storage support that
> QEMU can use internally. The initial target user will be a software
> vTPM 1.2 backend that needs to store keys in VNVRAM and be able to
> reboot/migrate and retain the keys.
>
> This support uses QEMU's b
On 21 May 2013 11:57, Paolo Bonzini wrote:
> +bool address_space_valid(AddressSpace *as, hwaddr addr, int len, bool
> is_write)
> +{
> +AddressSpaceDispatch *d = as->dispatch;
> +MemoryRegionSection *section;
> +int l;
> +hwaddr page;
> +
> +while (len > 0) {
> +page =
On 21 May 2013 11:57, Paolo Bonzini wrote:
> Remove the goto.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Peter Maydell
-- PMM
On 21 May 2013 11:57, Paolo Bonzini wrote:
> Using phys_page_find to translate an AddressSpace to a MemoryRegionSection
> is unwieldy. It requires to pass the page index rather than the address,
> and later memory_region_section_addr has to be called. Replace
> memory_region_section_addr with a
On 21 May 2013 11:57, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
Reviewed-by: Peter Maydell
-- PMM
On 21 May 2013 11:57, Paolo Bonzini wrote:
> From: Jan Kiszka
>
> This introduces a wrapper for phys_page_find (before we complicate
> address_space_translate with IOMMU translation). This function will
> also encapsulate locking and reference counting when we introduce
> BQL-free dispatching.
>
The changes (since 95de21a430f7bc4166a153b1f69b1425c8a99c7b) are available
in the following repository:
git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
Amos Kong (1):
ui/input.c: replace magic numbers with macros
Luiz Capitulino (1):
monitor: allow to disable the default monitor
Michae
From: Michael Roth
Currently we assume non-list types when generating visitor routines for
union types. This is broken, since values like ['Type'] need to mapped
to 'TypeList'.
We already have a type_name() function to handle this that we use for
generating struct visitors, so use that here as w
From: Michael Roth
Teach type generators about native types so they can generate the
appropriate linked list types.
Signed-off-by: Michael Roth
Reviewed-by: Laszlo Ersek
Reviewed-by: Amos Kong
Signed-off-by: Luiz Capitulino
---
scripts/qapi-types.py | 45
From: Michael Roth
Signed-off-by: Michael Roth
Reviewed-by: Laszlo Ersek
Reviewed-by: Amos Kong
Signed-off-by: Luiz Capitulino
---
tests/test-visitor-serialization.c | 451 +++--
1 file changed, 433 insertions(+), 18 deletions(-)
diff --git a/tests/test-visit
From: Michael Roth
Teach visitor generators about native types so they can generate the
appropriate visitor routines.
Signed-off-by: Michael Roth
Reviewed-by: Laszlo Ersek
Reviewed-by: Amos Kong
Signed-off-by: Luiz Capitulino
---
scripts/qapi-visit.py | 34 +-
From: Michael Roth
Large integers previously got capped to LLONG_MAX/LLONG_MIN so we could
store them as int64_t. This could lead to silent errors occuring.
Now, we use a double to handle these cases.
Add a test to confirm that QMPInputVisitor handles this as expected if
we're expected an integ
From: Michael Roth
This exercises schema-generated visitors for native list types and does
some sanity checking on validity of deserialized data.
Signed-off-by: Michael Roth
Reviewed-by: Laszlo Ersek
Reviewed-by: Amos Kong
Signed-off-by: Luiz Capitulino
---
tests/test-qmp-input-visitor.c |
101 - 200 of 291 matches
Mail list logo
