Re: [Qemu-devel] [PATCH] qemu-iotests: Filter out vmdk creation options

2013-05-03 Thread Fam Zheng
On Fri, 05/03 08:48, Kevin Wolf wrote: > Am 03.05.2013 um 03:31 hat Fam Zheng geschrieben: > > Cover new image creation options for vmdk, so we can use '-o > > zeroed_grain=XXX' and '-o subformat=XXX' to run the tests successfully. > > Signed-off-by: Fam Zheng > > --- > > tests/qemu-iotests/commo

[Qemu-devel] [PATCH] qemu-iotests: Filter out 'adapter_type'

2013-05-03 Thread Fam Zheng
Filter out vmdk creation option 'adapter_type' for vmdk. So that tests with an explicit './check -o adapter_type=XXX' will not fail. --- tests/qemu-iotests/common.rc | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index 442cf51..31eb6

Re: [Qemu-devel] [PATCH v7 0/7] push mmio dispatch out of big lock

2013-05-03 Thread liu ping fan
On Fri, May 3, 2013 at 12:58 AM, Jan Kiszka wrote: > Hi Pingfan, > > On 2012-12-06 08:28, liu ping fan wrote: >> Any suggestion? Or new design idea for this? > > Finally... I'm getting back to this. I'm currently trying to make use of > this series, adapting it to my needs (selective BQL-free disp

[Qemu-devel] [PATCH] curl: fix curl read

2013-05-03 Thread Fam Zheng
CURL library API has changed, the current curl driver is not working. This patch rewrites the use of API as well as the structure of internal states. (It is hard to split this to multiple patches as basically all these changes need to work together.) BDRVCURLState holds the pointer to curl multi i

Re: [Qemu-devel] [PATCH v7 0/7] push mmio dispatch out of big lock

2013-05-03 Thread Jan Kiszka
On 2013-05-03 09:37, liu ping fan wrote: > On Fri, May 3, 2013 at 12:58 AM, Jan Kiszka wrote: >> Hi Pingfan, >> >> On 2012-12-06 08:28, liu ping fan wrote: >>> Any suggestion? Or new design idea for this? >> >> Finally... I'm getting back to this. I'm currently trying to make use of >> this series

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2013-05-03 Thread Sam Stoelinga
This is also affecting Windows Server 2008 and happens with all usb storage devices I tested. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/685096 Title: USB Passthrough not working for Windows 7 g

Re: [Qemu-devel] [PATCH V4 0/5] block: make qmp_transaction extendable

2013-05-03 Thread Kevin Wolf
Am 02.05.2013 um 04:26 hat Wenchao Xia geschrieben: > This serial will package backing chain snapshot code as one case, to make it > possible adding more operations later. > > v2: > Address Kevin's comments: > Use the same prototype prepare, commit, rollback model in original code, > commit

Re: [Qemu-devel] [PATCH v2 1/6] hostmem: make hostmem single, not per Vring related

2013-05-03 Thread Stefan Hajnoczi
On Fri, May 03, 2013 at 10:45:17AM +0800, Liu Ping Fan wrote: > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 9e88320..2761668 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -887,6 +887,7 @@ void *address_space_map(AddressSpace *as, hwaddr addr, > void

Re: [Qemu-devel] [PATCH v2 2/6] hostmem: AddressSpace has its own map and maintained by RCU prepared style

2013-05-03 Thread Stefan Hajnoczi
On Fri, May 03, 2013 at 10:45:18AM +0800, Liu Ping Fan wrote: > +/** > + * Install new regions list > + */ > +static void hostmem_listener_commit(MemoryListener *listener) > +{ > +HostMem *tmp; > +AddrSpaceMem *as_mem = container_of(listener, AddrSpaceMem, listener); > + > +/* writer of

Re: [Qemu-devel] [PATCH] qemu-iotests: Filter out vmdk creation options

2013-05-03 Thread Stefan Hajnoczi
On Fri, May 03, 2013 at 09:31:40AM +0800, Fam Zheng wrote: > Cover new image creation options for vmdk, so we can use '-o > zeroed_grain=XXX' and '-o subformat=XXX' to run the tests successfully. > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/common.rc | 2 ++ > 1 file changed, 2 insertion

Re: [Qemu-devel] [PATCH v5 0/6] vmdk: zeroed-grain GTE support

2013-05-03 Thread Stefan Hajnoczi
On Thu, May 02, 2013 at 10:25:21AM +0800, Fam Zheng wrote: > Added support for zeroed-grain GTE to VMDK according to VMDK Spec 5.0[1]. > > [1] Virtual Disk Format 5.0 - VMware, > http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk > > Changes since v4: > - 6/6: Correct

Re: [Qemu-devel] [PATCH v2 4/6] hostmem: hostmem listener pin RAM-Device by refcnt

2013-05-03 Thread Stefan Hajnoczi
On Fri, May 03, 2013 at 10:45:20AM +0800, Liu Ping Fan wrote: > From: Liu Ping Fan > > With ref()/unref() interface of MemoryRegion, we can pin RAM-Device > when using its memory, and release it when done. > > Signed-off-by: Liu Ping Fan > --- > hw/virtio/dataplane/hostmem.c | 44 +++

Re: [Qemu-devel] [PATCH] target-mips: fix calculation of overflow for SHLL.PH and SHLL.QB

2013-05-03 Thread Aurelien Jarno
On Sun, Apr 28, 2013 at 03:18:36AM +0200, Petar Jovanovic wrote: > From: Petar Jovanovic > > This change corrects and simplifies how discard is calculated for shift > left logical vector instructions. It is used to detect overflow and set bit > 22 in the DSPControl register. > > The existing tes

Re: [Qemu-devel] [PATCH v2 02/12] block: update error reporting for bdrv_snapshot_delete() and related functions

2013-05-03 Thread Kevin Wolf
Am 24.04.2013 um 17:32 hat Pavel Hrdina geschrieben: > @@ -2528,15 +2530,13 @@ void do_delvm(Monitor *mon, const QDict *qdict) > bs1 = NULL; > while ((bs1 = bdrv_next(bs1))) { > if (bdrv_can_snapshot(bs1)) { > -ret = bdrv_snapshot_delete(bs1, name); > -if

Re: [Qemu-devel] [PATCH for-1.5 0/2] more tcg-arm cleanups

2013-05-03 Thread Aurelien Jarno
On Mon, Apr 29, 2013 at 08:08:21AM -0700, Richard Henderson wrote: > The first patch really ought to get into 1.5. > > The second patch is a re-done version of the 19/19 patch from version 5 > of the previous patch series. We had dropped that due to wanting to > avoid 16MB assumption changes. Th

Re: [Qemu-devel] [PATCH v2 5/6] Vring: use hostmem's RAM safe api

2013-05-03 Thread Stefan Hajnoczi
On Fri, May 03, 2013 at 10:45:21AM +0800, Liu Ping Fan wrote: > @@ -109,11 +110,14 @@ bool vring_should_notify(VirtIODevice *vdev, Vring > *vring) > static int get_indirect(Vring *vring, > struct iovec iov[], struct iovec *iov_end, > unsigned int

Re: [Qemu-devel] [PATCH v2 6/6] virtio-blk: release reference to RAM's memoryRegion

2013-05-03 Thread Stefan Hajnoczi
On Fri, May 03, 2013 at 10:45:22AM +0800, Liu Ping Fan wrote: > From: Liu Ping Fan > > virtio-blk will unref RAM's memoryRegion when the io-req has been > done. So we can avoid to call bdrv_drain_all() when RAM hot unplug. > > Signed-off-by: Liu Ping Fan > --- > hw/block/dataplane/virtio-blk.c

Re: [Qemu-devel] [PATCH v2 03/12] savevm: update bdrv_snapshot_find() to find snapshot by id or name and add error parameter

2013-05-03 Thread Kevin Wolf
Am 24.04.2013 um 17:32 hat Pavel Hrdina geschrieben: > Finding snapshot by a name which could also be an id isn't best way > how to do it. There will be rewrite of savevm, loadvm and delvm to > improve the behavior of these commands. The savevm and loadvm will > have their own patch series. > > No

[Qemu-devel] Query on network support TCP redir for range of ports

2013-05-03 Thread Srikanth Baratam
Hi All, Is it possible to specify the range of port to be redirected by qemu? for example, I am want qemu to use the 2000 to 2500 port by qemu. Is it supported? Or do i need to pass all the ports by one by one at invocation? Thanks and Regards, Srikanth Baratam, Bangalore

Re: [Qemu-devel] [PATCH v2 04/12] qapi: Convert delvm

2013-05-03 Thread Kevin Wolf
Am 24.04.2013 um 17:32 hat Pavel Hrdina geschrieben: > QMP command vm-snapshot-delete takes two parameters: name and id. They are > optional, but one of the name or id must be provided. If both are provided > they > will match only the snapshot with the same name and id. The command returns > Snap

Re: [Qemu-devel] [PATCH v2 05/12] block: update error reporting for bdrv_snapshot_goto() and related functions

2013-05-03 Thread Kevin Wolf
Am 24.04.2013 um 17:32 hat Pavel Hrdina geschrieben: > Signed-off-by: Pavel Hrdina > --- a/block/sheepdog.c > +++ b/block/sheepdog.c > @@ -1867,7 +1867,9 @@ cleanup: > return ret; > } > > -static int sd_snapshot_goto(BlockDriverState *bs, const char *snapshot_id) > +static void sd_snapsho

Re: [Qemu-devel] [PATCH] qemu-iotests: Filter out 'adapter_type'

2013-05-03 Thread Stefan Hajnoczi
On Fri, May 03, 2013 at 03:31:16PM +0800, Fam Zheng wrote: > Filter out vmdk creation option 'adapter_type' for vmdk. So that tests > with an explicit './check -o adapter_type=XXX' will not fail. > --- > tests/qemu-iotests/common.rc | 1 + > 1 file changed, 1 insertion(+) Thanks, applied to my bl

Re: [Qemu-devel] [PATCH] curl: fix curl read

2013-05-03 Thread Stefan Hajnoczi
On Fri, May 03, 2013 at 04:00:09PM +0800, Fam Zheng wrote: > CURL library API has changed, the current curl driver is not working. > This patch rewrites the use of API as well as the structure of internal > states. (It is hard to split this to multiple patches as basically all > these changes need

Re: [Qemu-devel] [PATCH v2 07/12] savevm: update error reporting for qemu_loadvm_state()

2013-05-03 Thread Kevin Wolf
Am 24.04.2013 um 17:32 hat Pavel Hrdina geschrieben: > Signed-off-by: Pavel Hrdina > --- > include/sysemu/sysemu.h | 2 +- > migration.c | 11 ++--- > savevm.c| 65 > - > 3 files changed, 40 insertions(+), 38 deleti

Re: [Qemu-devel] [PATCH V4 0/5] block: make qmp_transaction extendable

2013-05-03 Thread Stefan Hajnoczi
On Thu, May 02, 2013 at 10:26:41AM +0800, Wenchao Xia wrote: > This serial will package backing chain snapshot code as one case, to make it > possible adding more operations later. > > v2: > Address Kevin's comments: > Use the same prototype prepare, commit, rollback model in original code,

Re: [Qemu-devel] [PATCH] curl: fix curl read

2013-05-03 Thread Fam Zheng
On Fri, 05/03 13:09, Stefan Hajnoczi wrote: > On Fri, May 03, 2013 at 04:00:09PM +0800, Fam Zheng wrote: > > CURL library API has changed, the current curl driver is not working. > > This patch rewrites the use of API as well as the structure of internal > > states. (It is hard to split this to mul

Re: [Qemu-devel] [PATCH 2/8] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-05-03 Thread Andreas Färber
Am 03.05.2013 03:38, schrieb David Gibson: > The savevm code for the powerpc cpu emulation is currently based around > the old register_savevm() rather than register_vmstate() method. It's also > rather broken, missing some important state on some CPU models. > > This patch completely rewrites th

Re: [Qemu-devel] [PATCH v2 08/12] qapi: Convert loadvm

2013-05-03 Thread Kevin Wolf
Am 24.04.2013 um 17:32 hat Pavel Hrdina geschrieben: > QMP command vm-snapshot-load and HMP command loadvm behave similar to > vm-snapshot-delete and delvm. The only different is that they will load > the snapshot instead of deleting it. > > Signed-off-by: Pavel Hrdina > bs = NULL; > w

Re: [Qemu-devel] [PATCH qom-cpu 6/9] target-i386: Add "feature-words" property

2013-05-03 Thread Igor Mammedov
On Mon, 22 Apr 2013 16:00:17 -0300 Eduardo Habkost wrote: > This property will be useful for libvirt, as libvirt already has logic > based on low-level feature bits (not feature names), so it will be > really easy to convert the current libvirt logic to something using the > "feature-words" prope

Re: [Qemu-devel] [PATCH 7/7] prep: QOM'ify System I/O

2013-05-03 Thread Andreas Färber
Am 02.05.2013 22:09, schrieb Hervé Poussineau: > Most of the functionality is extracted from hw/ppc/prep.c. > Also add support for board identification/equipment registers. > > Document it for the IBM 43p emulation. > > Cc: Julio Guerra > Signed-off-by: Hervé Poussineau > --- > docs/ibm_43p.cf

Re: [Qemu-devel] [PATCH 2/7] qom: handle registration of new types when initializing the first ones

2013-05-03 Thread Andreas Färber
Am 02.05.2013 22:08, schrieb Hervé Poussineau: > When initializing all types in object_class_foreach, called by > object_class_get_list, > some new types may be registered. Those will change the type internal > hashtable which > is currently enumerated, and may crash QEMU. > > Fix it, by adding

[Qemu-devel] [PULL 00/15] Block patches

2013-05-03 Thread Stefan Hajnoczi
Details on the patches: 1. Fam Zheng's VMDK zeroed-grain GTEs implements zero cluster support in VMDK. We need this to correctly read files containing zero clusters - it's essentially a bugfix. 2. Jeff Cody's VHDX series implements read-only support for the new Hyper-V image f

[Qemu-devel] [PATCH 04/15] block: add read-only support to VHDX image format.

2013-05-03 Thread Stefan Hajnoczi
From: Jeff Cody This adds in read-only support to the VHDX image format. This supports reads for fixed-size, and dynamic sized VHDX images. Differencing files are still unsupported. The image must be opened without BDRV_O_RDWR set, because we do not yet update the headers. I.e., pass 'readonl

[Qemu-devel] [PATCH 02/15] block: vhdx header for the QEMU support of VHDX images

2013-05-03 Thread Stefan Hajnoczi
From: Jeff Cody This is based on Microsoft's VHDX specification: "VHDX Format Specification v0.95", published 4/12/2012 https://www.microsoft.com/en-us/download/details.aspx?id=29681 These structures define the various header, metadata, and other block structures defined in the VHDX spec

[Qemu-devel] [PATCH 03/15] block: initial VHDX driver support framework - supports open and probe

2013-05-03 Thread Stefan Hajnoczi
From: Jeff Cody This is the initial block driver framework for VHDX image support (i.e. Hyper-V image file formats), that supports opening VHDX files, and parsing the headers. This commit does not yet enable: - reading - writing - updating the header - differencing files (images

[Qemu-devel] [PATCH 01/15] qemu: add castagnoli crc32c checksum algorithm

2013-05-03 Thread Stefan Hajnoczi
From: Jeff Cody This adds the Castagnoli CRC32C algorithm, using the 0x11EDC6F41 polynomial. This is extracted from the linux kernel cryptographic crc32.c module. The algorithm is based on: Castagnoli93: Guy Castagnoli and Stefan Braeuer and Martin Herrman "Optimization of Cyclic

[Qemu-devel] [PATCH 05/15] blockdev: Replace "undefined error" in qmp_block_resize

2013-05-03 Thread Stefan Hajnoczi
From: Kevin Wolf We have an errno value that can be displayed, so we should just do that. An easy way to reproduce this case is to resize a raw image to a size that is too large for the host file system. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- blo

[Qemu-devel] [PATCH 06/15] vmdk: named return code.

2013-05-03 Thread Stefan Hajnoczi
From: Fam Zheng Internal routines in vmdk.c previously return -1 on error and 0 on success. More return values are useful for future changes such as zeroed-grain GTE. Change all the magic `return 0` and `return -1` to macro names: * VMDK_OK 0 * VMDK_ERROR (-1) * VMDK_UNALLOC (-2) * VM

[Qemu-devel] [PATCH 07/15] vmdk: add support for “zeroed‐grain” GTE

2013-05-03 Thread Stefan Hajnoczi
From: Fam Zheng Introduced support for zeroed-grain GTE, as specified in Virtual Disk Format 5.0[1]. Recent VMware hosted platform products support a new “zeroed‐grain” grain table entry (GTE). The zeroed‐grain GTE returns all zeros on read. In other words, the zeroed‐grain GTE indi

[Qemu-devel] [PATCH 09/15] vmdk: change magic number to macro

2013-05-03 Thread Stefan Hajnoczi
From: Fam Zheng Two hard coded flag bits are changed to macros. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- block/vmdk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index cc19e20..0463d3b 100644 --- a/block/vmdk.c +++ b/bloc

[Qemu-devel] [PATCH 12/15] qemu-iotests: Filter out vmdk creation options

2013-05-03 Thread Stefan Hajnoczi
From: Fam Zheng Cover new image creation options for vmdk, so we can use '-o zeroed_grain=XXX' and '-o subformat=XXX' to run the tests successfully. Signed-off-by: Fam Zheng Reviewed-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/common.rc | 2 ++ 1 file changed, 2 inse

[Qemu-devel] [PATCH 08/15] vmdk: Add option to create zeroed-grain image

2013-05-03 Thread Stefan Hajnoczi
From: Fam Zheng Add image create option "zeroed-grain" to enable zeroed-grain GTE feature of vmdk sparse extents. When this option is on, header version of newly created extent will be 2 and VMDK4_FLAG_ZERO_GRAIN flag bit will be set. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi ---

[Qemu-devel] [PATCH 13/15] nbd: use g_slice_new() instead of a freelist

2013-05-03 Thread Stefan Hajnoczi
Use GLib's efficient slice allocator instead of open-coding the request freelist. This patch simplifies the NBDRequest code. Now we qemu_blockalign() the req->data buffer each time but the next patch switches from a fixed size buffer to a dynamic size anyway. Signed-off-by: Stefan Hajnoczi ---

[Qemu-devel] [PATCH 15/15] qemu-iotests: Filter out 'adapter_type'

2013-05-03 Thread Stefan Hajnoczi
From: Fam Zheng Filter out vmdk creation option 'adapter_type' for vmdk. So that tests with an explicit './check -o adapter_type=XXX' will not fail. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/common.rc | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/common.rc

[Qemu-devel] [PATCH 10/15] vmdk: store fields of VmdkMetaData in cpu endian

2013-05-03 Thread Stefan Hajnoczi
From: Fam Zheng Previously VmdkMetaData.offset is stored little endian while other fields are cpu endian. This changes offset to cpu endian and convert before writing to image. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- block/vmdk.c | 17 - 1 file changed, 8 in

[Qemu-devel] [PULL 0/2] Net patches

2013-05-03 Thread Stefan Hajnoczi
Two bug fixes for QEMU 1.5. The following changes since commit 8ca27ce2e1150486ea2db4116a03706b28294f16: Merge remote-tracking branch 'afaerber/qom-cpu' into staging (2013-05-02 10:57:01 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git net for you to fetc

[Qemu-devel] [PATCH 11/15] vmdk: add bdrv_co_write_zeroes

2013-05-03 Thread Stefan Hajnoczi
From: Fam Zheng Use special offset to write zeroes efficiently, when zeroed-grain GTE is available. If zero-write an allocated cluster, cluster is leaked because its offset pointer is overwritten by "0x1". Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- block/vmdk.c | 86 +

[Qemu-devel] [PATCH 1/2] net: make network client name unique

2013-05-03 Thread Stefan Hajnoczi
From: Amos Kong assign_name() creates a name MODEL.NUM, where MODEL is the client's model, and NUM is the number of MODELs that already exist. Markus added NIC naming for non-VLAN clients in commit 53e51d85. commit d33d93b2 incorrectly added a judgement of net-hub. It caused net clients created

[Qemu-devel] [PATCH 14/15] nbd: support large NBD requests

2013-05-03 Thread Stefan Hajnoczi
The Linux nbd driver recently increased the maximum supported request size up to 32 MB: commit 078be02b80359a541928c899c2631f39628f56df Author: Michal Belczyk Date: Tue Apr 30 15:28:28 2013 -0700 nbd: increase default and max request sizes Raise the default max request size

[Qemu-devel] [PATCH 2/2] tap: properly initialize vhostfds

2013-05-03 Thread Stefan Hajnoczi
From: Jason Wang Only tap->vhostfd were checked net_init_tap_one(), but tap->vhostfds were forgot, this will lead qemu to ignore all fds passed by management through vhostfds, and tries to create vhost_net device itself. Fix by adding this check also. Reportyed-by: Michal Privoznik Cc: Michal P

[Qemu-devel] [PATCH 1/4] kvm-all: add kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl tracepoints

2013-05-03 Thread Stefan Hajnoczi
From: Kazuya Saito This patch adds tracepoints at ioctl to kvm. Tracing these ioctl is useful for clarification whether the cause of troubles is qemu or kvm. Signed-off-by: Kazuya Saito Reviewed-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- kvm-all.c| 4 trace-events | 5

[Qemu-devel] [PULL 0/4] Tracing patches

2013-05-03 Thread Stefan Hajnoczi
This tracing pull request is long overdue for QEMU 1.5. Eiichi Tsukata's ftrace backend makes it easy to correlate QEMU events with host kernel events. He also reports good performance. Kazuya Saito's trace events make it easier to observe the KVM run loop. The following changes since commit 8c

[Qemu-devel] [PATCH 2/4] kvm-all: add kvm_run_exit tracepoint

2013-05-03 Thread Stefan Hajnoczi
From: Kazuya Saito This patch enable us to know exit reason of KVM_RUN. It will help us know where the trouble is caused. Signed-off-by: Kazuya Saito Reviewed-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- kvm-all.c| 1 + trace-events | 2 ++ 2 files changed, 3 insertions(+) diff

[Qemu-devel] [PATCH 3/4] trace: Add ftrace tracing backend

2013-05-03 Thread Stefan Hajnoczi
From: Eiichi Tsukata This patch adds a ftrace tracing backend which sends trace event to ftrace marker file. You can effectively compare qemu trace data and kernel(especially, kvm.ko when using KVM) trace data. The ftrace backend is restricted to Linux only. To try out the ftrace backend: $ ./

[Qemu-devel] [PATCH 4/4] trace: document ftrace backend

2013-05-03 Thread Stefan Hajnoczi
From: Eiichi Tsukata Add documentation of ftrace backend. Signed-off-by: Eiichi Tsukata Signed-off-by: Stefan Hajnoczi --- docs/tracing.txt | 16 1 file changed, 16 insertions(+) diff --git a/docs/tracing.txt b/docs/tracing.txt index cf53c17..60ff9c5 100644 --- a/docs/tracin

Re: [Qemu-devel] [PATCH 1/4] kvm-all: add kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl tracepoints

2013-05-03 Thread Andreas Färber
Am 03.05.2013 14:01, schrieb Stefan Hajnoczi: > From: Kazuya Saito > > This patch adds tracepoints at ioctl to kvm. Tracing these ioctl is > useful for clarification whether the cause of troubles is qemu or kvm. > > Signed-off-by: Kazuya Saito > Reviewed-by: Paolo Bonzini > Signed-off-by: Stef

Re: [Qemu-devel] [libvirt] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-03 Thread Daniel P. Berrange
On Thu, May 02, 2013 at 10:40:06AM -0500, Anthony Liguori wrote: > Kevin Wolf writes: > >> >> + > >> >> +if (strcmp(type, "ide-cd") == 0) { > >> >> +disk_type = DT_CDROM; > >> >> +} else if (strcmp(type, "isa-fdc") == 0) { > >> >> +disk_type = DT_FLOPPY; > >

Re: [Qemu-devel] [RFC] Moving Hard Freeze to Monday, May 6th.

2013-05-03 Thread Mark Cave-Ayland
On 01/05/13 17:24, Rob Landley wrote: On 04/30/2013 01:36:39 PM, Anthony Liguori wrote: The current release schedule has hard freeze happening tomorrow. There are a few things still outstanding including cpu hotplug and updating SeaBIOS. We still need to resolve how to handle the softfloat cod

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-03 Thread Andreas Färber
Am 02.05.2013 20:33, schrieb Jean-Christophe DUBOIS: > On 05/02/2013 02:16 PM, Peter Crosthwaite wrote: >> On Thu, May 2, 2013 at 5:53 AM, Jean-Christophe DUBOIS >> wrote: >>> +static int imx_i2c_init(SysBusDevice *dev) >>> +{ >> Use of the SysBusDeviceClass::init function is deprecated. Please us

Re: [Qemu-devel] [PATCH v2 10/12] savevm: update error reporting of qemu_savevm_state() and related functions

2013-05-03 Thread Kevin Wolf
Am 24.04.2013 um 17:32 hat Pavel Hrdina geschrieben: > Signed-off-by: Pavel Hrdina > --- > include/sysemu/sysemu.h | 7 --- > migration.c | 6 +++--- > savevm.c| 38 +++--- > 3 files changed, 26 insertions(+), 25 deletions(-) > --

Re: [Qemu-devel] [PATCH v2 11/12] qapi: Convert savevm

2013-05-03 Thread Kevin Wolf
Am 24.04.2013 um 17:32 hat Pavel Hrdina geschrieben: > QMP command vm-snapshot-save takes one parameter name and the name is > mandatory. The command returns SnapshotInfo on success, otherwise it returns > an error message. If there is a snapshot with the same name it also returns > an error messag

Re: [Qemu-devel] [PATCH v2 12/12] savevm: remove backward compatibility from bdrv_snapshot_find()

2013-05-03 Thread Kevin Wolf
Am 24.04.2013 um 17:32 hat Pavel Hrdina geschrieben: > Signed-off-by: Pavel Hrdina > --- > savevm.c | 35 --- > 1 file changed, 12 insertions(+), 23 deletions(-) > > diff --git a/savevm.c b/savevm.c > index 2e849b8..45d46c6 100644 > --- a/savevm.c > +++ b/savevm.c

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] bsd-user: OS-agnostic 64-bit SYSCTL types

2013-05-03 Thread Michael Tokarev
30.04.2013 17:29, Ed Maste wrote: > Use existence of type as #ifdef condition rather than FreeBSD-specific > version check, as suggested by Patrick Welche. > > Also handle the signed (CTLTYPE_S64) case identically to the unsigned > (CTLTYPE_U64) case, per later patches in the FreeBSD ports tree >

Re: [Qemu-devel] [PATCH qom-cpu 6/9] target-i386: Add "feature-words" property

2013-05-03 Thread Eduardo Habkost
On Fri, May 03, 2013 at 01:34:23PM +0200, Igor Mammedov wrote: > On Mon, 22 Apr 2013 16:00:17 -0300 > Eduardo Habkost wrote: > > > This property will be useful for libvirt, as libvirt already has logic > > based on low-level feature bits (not feature names), so it will be > > really easy to conve

[Qemu-devel] [PATCH for-1.5] qdev: skip bus check for bus-less devices in qdev_unplug()

2013-05-03 Thread Igor Mammedov
Since commit 2f7bd829db "qdev: Fix device_add bus assumptions" it's possible to device_add bus-less device, but if such device is unplugged it will dereference NULL parent_bus in qdev_unplug(). Fix it by taking in account that parent_bus might be NULL and skipping bus check. Signed-off-by: Igor M

Re: [Qemu-devel] [PATCH 1/4] kvm-all: add kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl tracepoints

2013-05-03 Thread Eduardo Habkost
On Fri, May 03, 2013 at 02:12:14PM +0200, Andreas Färber wrote: > Am 03.05.2013 14:01, schrieb Stefan Hajnoczi: > > From: Kazuya Saito > > > > This patch adds tracepoints at ioctl to kvm. Tracing these ioctl is > > useful for clarification whether the cause of troubles is qemu or kvm. > > > > Si

Re: [Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390

2013-05-03 Thread Jason J. Herne
I've done some investigating into using the device_add hmp/qmp command to support hot-plugging cpus on S390. The alternative suggestion was to simply use a new cpu_add hmp/qmp command. device_add accepts all of the same options as the -device command line parameter takes. This would imply th

Re: [Qemu-devel] [libvirt] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-03 Thread Anthony Liguori
"Daniel P. Berrange" writes: > On Thu, May 02, 2013 at 10:40:06AM -0500, Anthony Liguori wrote: >> Kevin Wolf writes: >> >> >> + >> >> >> +if (strcmp(type, "ide-cd") == 0) { >> >> >> +disk_type = DT_CDROM; >> >> >> +} else if (strcmp(type, "isa-fdc") == 0) { >> >> >>

Re: [Qemu-devel] [PATCH v2 1/2] ARM: Allow boards to provide an fdt blob

2013-05-03 Thread Peter Maydell
On 30 April 2013 17:04, John Rigby wrote: > If no fdt is provided on command line and the new field > get_dtb in struct arm_boot_info is set then call it to > get a device tree blob. > > Also allow dumping of device tree by calling qemu_devtree_dumpdtb > near the end of load_dtb. "Also ..." in a

Re: [Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390

2013-05-03 Thread Igor Mammedov
On Fri, 03 May 2013 09:50:50 -0400 "Jason J. Herne" wrote: > I've done some investigating into using the device_add hmp/qmp command > to support hot-plugging cpus on S390. The alternative suggestion was to > simply use a new cpu_add hmp/qmp command. > > device_add accepts all of the same opti

Re: [Qemu-devel] [libvirt] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-03 Thread Daniel P. Berrange
On Fri, May 03, 2013 at 08:52:59AM -0500, Anthony Liguori wrote: > "Daniel P. Berrange" writes: > > > On Thu, May 02, 2013 at 10:40:06AM -0500, Anthony Liguori wrote: > >> Kevin Wolf writes: > >> >> >> + > >> >> >> +if (strcmp(type, "ide-cd") == 0) { > >> >> >> +disk_type = D

Re: [Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390

2013-05-03 Thread Andreas Färber
Hi, Am 03.05.2013 15:50, schrieb Jason J. Herne: > I've done some investigating into using the device_add hmp/qmp command > to support hot-plugging cpus on S390. The alternative suggestion was to > simply use a new cpu_add hmp/qmp command. A cpu-add QMP command has been merged by now. Using it w

Re: [Qemu-devel] [PATCH V4 3/5] block: package committing code in qmp_transaction()

2013-05-03 Thread Eric Blake
On 05/01/2013 08:26 PM, Wenchao Xia wrote: > The code is simply moved into a separate function. > > Signed-off-by: Wenchao Xia > --- > blockdev.c | 19 --- > 1 files changed, 12 insertions(+), 7 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-91

Re: [Qemu-devel] [PATCH qom-cpu 6/9] target-i386: Add "feature-words" property

2013-05-03 Thread Eric Blake
On 05/03/2013 07:17 AM, Eduardo Habkost wrote: > > We could, but maybe it would make the interface harder to use and not > easier? > > Even when two feature words are returned in the same CPUID leaf, they > are independent and separate feature-words that must be checked > individually by libvirt,

Re: [Qemu-devel] [PATCH v2 2/2] ARM: Add mach-virt platform

2013-05-03 Thread Peter Maydell
On 30 April 2013 17:04, John Rigby wrote: > Add mach-virt platform support cooresponding to "corresponding" I wonder if we should just call this "virt" ? > /arch/arm/mach-virt in kernel tree. > > For now it is not virtual but instantiates a pl011 uart > and and sp804 timer. The uart is need fo

Re: [Qemu-devel] [PATCH V4 4/5] block: package rollback code in qmp_transaction()

2013-05-03 Thread Eric Blake
On 05/01/2013 08:26 PM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > blockdev.c | 11 --- > 1 files changed, 8 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org s

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/8] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-05-03 Thread David Gibson
On Fri, May 03, 2013 at 01:29:28PM +0200, Andreas Färber wrote: > Am 03.05.2013 03:38, schrieb David Gibson: > > The savevm code for the powerpc cpu emulation is currently based around > > the old register_savevm() rather than register_vmstate() method. It's also > > rather broken, missing some im

Re: [Qemu-devel] [PATCH V4 1/5] block: package preparation code in qmp_transaction()

2013-05-03 Thread Eric Blake
On 05/01/2013 08:26 PM, Wenchao Xia wrote: > The code before really committing is moved into a function. Most > code are simply moved from qmp_transaction(), except that on fail it s/are/is/ > just return now. Other code such as input parsing is not touched, s/return/returns/ > to make it easie

Re: [Qemu-devel] [PATCH V4 5/5] block: make all steps in qmp_transaction() as callback

2013-05-03 Thread Eric Blake
On 05/01/2013 08:26 PM, Wenchao Xia wrote: > Make it easier to add other operations to qmp_transaction() by using > callbacks, with external snapshots serving as an example implementation > of the callbacks. > > Signed-off-by: Wenchao Xia > --- > blockdev.c | 92 +++

Re: [Qemu-devel] [PATCH v2 09/12] linux-user: Add signal handling for AArch64

2013-05-03 Thread Peter Maydell
On 30 April 2013 07:38, John Rigby wrote: > +/* set up the stack frame for unwinding */ > +err |= __put_user(env->xregs[29], &sf->fp); __put_user can't fail so all this collection of error status is unnecessary. (Every address we write with it has to be covered by the lock_user_struct() c

Re: [Qemu-devel] [PATCH qom-cpu 6/9] target-i386: Add "feature-words" property

2013-05-03 Thread Eric Blake
On 04/22/2013 01:00 PM, Eduardo Habkost wrote: > This property will be useful for libvirt, as libvirt already has logic > based on low-level feature bits (not feature names), so it will be > really easy to convert the current libvirt logic to something using the > "feature-words" property. > > The

Re: [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

2013-05-03 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 02.05.2013 21:48, schrieb Eric Blake: > On 05/02/2013 01:43 PM, Eduardo Habkost wrote: >>> >>> As mentioned earlier I'd prefer to defer the property design >>> rather than putting it lightly reviewed into 1.5 and living >>> with some ABI. If libvir

Re: [Qemu-devel] [PATCH qom-cpu 7/9] target-i386: Use FeatureWord loop on filter_features_for_kvm()

2013-05-03 Thread Eric Blake
On 04/22/2013 01:00 PM, Eduardo Habkost wrote: > Instead of open-coding the filtering code for each feature word, change > the existing code to use the feature_word_info array, that have exactly > the same CPUID eax/ecx/register values for each feature word. > > Signed-off-by: Eduardo Habkost > -

Re: [Qemu-devel] [PATCH qom-cpu 8/9] target-i386: Introduce X86CPU.filtered_features field

2013-05-03 Thread Eric Blake
On 04/22/2013 01:00 PM, Eduardo Habkost wrote: > This field will contain the feature bits that were filtered out because > of missing host support. Yes, libvirt would definitely like to know that. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu-qom.h | 3 +++ > target-i386/cpu.c

Re: [Qemu-devel] [PATCH qom-cpu 5/9] target-i386: Add ECX information to FeatureWordInfo

2013-05-03 Thread Andreas Färber
Am 22.04.2013 21:00, schrieb Eduardo Habkost: > FEAT_7_0_EBX uses ECX as input, so we have to take that into account > when reporting feature word values. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --g

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-03 Thread Jean-Christophe DUBOIS
Andreas, On 05/02/2013 02:38 PM, Andreas Färber wrote: Hi, Am 01.05.2013 21:53, schrieb Jean-Christophe DUBOIS: Signed-off-by: Jean-Christophe DUBOIS --- default-configs/arm-softmmu.mak | 2 + hw/i2c/Makefile.objs| 1 + hw/i2c/imx_i2c.c| 374 +++

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-03 Thread Andreas Färber
Am 03.05.2013 17:16, schrieb Jean-Christophe DUBOIS: > Andreas, > > On 05/02/2013 02:38 PM, Andreas Färber wrote: >> Hi, >> >> Am 01.05.2013 21:53, schrieb Jean-Christophe DUBOIS: >>> Signed-off-by: Jean-Christophe DUBOIS >>> --- >>> default-configs/arm-softmmu.mak | 2 + >>> hw/i2c/Makefile

Re: [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

2013-05-03 Thread Igor Mammedov
On Fri, 03 May 2013 16:58:44 +0200 Andreas Färber wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 02.05.2013 21:48, schrieb Eric Blake: > > On 05/02/2013 01:43 PM, Eduardo Habkost wrote: > >>> > >>> As mentioned earlier I'd prefer to defer the property design > >>> rather than p

Re: [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

2013-05-03 Thread Eric Blake
On 05/03/2013 08:58 AM, Andreas Färber wrote: > >> I agree that libvirt would very much like to have this in 1.5. How >> can I help in reviewing things? > > Apart from the usual QMP considerations that you will know much better > than me, I have two concerns here: > 1) Polluting the QOM namespac

Re: [Qemu-devel] [PATCH qom-cpu 9/9] target-i386: Add "filtered-features" property to X86CPU

2013-05-03 Thread Eric Blake
On 04/22/2013 01:00 PM, Eduardo Habkost wrote: > This property will contain all the features that were removed from the > CPU because they are not supported by the host. > > This way, libvirt or other management tools can emulate the > check/enforce behavior by checking if filtered-properties is a

Re: [Qemu-devel] [PATCH qom-cpu 5/9] target-i386: Add ECX information to FeatureWordInfo

2013-05-03 Thread Eduardo Habkost
On Fri, May 03, 2013 at 05:16:46PM +0200, Andreas Färber wrote: > Am 22.04.2013 21:00, schrieb Eduardo Habkost: > > FEAT_7_0_EBX uses ECX as input, so we have to take that into account > > when reporting feature word values. > > > > Signed-off-by: Eduardo Habkost > > --- > > target-i386/cpu.c |

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-03 Thread Jean-Christophe DUBOIS
On 05/03/2013 05:20 PM, Andreas Färber wrote: Am 03.05.2013 17:16, schrieb Jean-Christophe DUBOIS: Andreas, On 05/02/2013 02:38 PM, Andreas Färber wrote: Hi, Am 01.05.2013 21:53, schrieb Jean-Christophe DUBOIS: Signed-off-by: Jean-Christophe DUBOIS --- default-configs/arm-softmmu.mak |

[Qemu-devel] [PATCH 2/9] qom: add object_property_add_unnamed_child

2013-05-03 Thread Michael Roth
This interface allows us to add a child property without specifying a name. Instead, a unique name is created and passed back after adding the property. Signed-off-by: Michael Roth --- include/qom/object.h | 16 qom/object.c | 25 + 2 files ch

[Qemu-devel] [PATCH 1/9] qom: add qom_init_completion

2013-05-03 Thread Michael Roth
This is similar in concept to "realize", though semantics are a bit more open-ended: And object might in some cases need a number of properties to be specified before it can be "used"/"started"/etc. This can't always be done via an open-ended new() function, the main example being objects that aro

[Qemu-devel] [RFC 0/9] QContext: QOM class to support multiple event loops

2013-05-03 Thread Michael Roth
These patches apply on top of qemu.git master, and can also be obtained from: git://github.com/mdroth/qemu.git qcontext OVERVIEW This series introduces a set of QOM classes/interfaces for event registration/handling: QContext and QSource, which are based closely on their GMainContext/GSource GLib

[Qemu-devel] [PATCH 3/9] QSource: QEMU event source object

2013-05-03 Thread Michael Roth
This references QContext, which will be introduced later (and also references this). These will likely be squashed eventually, but we leave them separate for now for easier review. This implements a QOM-based event source object which is used in much the same way as a GSource. Signed-off-by: Mich

[Qemu-devel] [PATCH 8/9] main-loop: drive main event loop via QContext

2013-05-03 Thread Michael Roth
This series attaches the global AioContext's GSource to the QContext we've layered on top of the main GMainContext. This, paired with the similar treatment given to IOHandlers earlier, allows us to drive the main loop without using fill/poll functions to add/dispatch events that are external to our

[Qemu-devel] [PATCH 9/9] dataplane: use a QContext event loop in place of custom thread

2013-05-03 Thread Michael Roth
virtio-blk dataplane currently creates/manages it's own thread to offload work to a separate event loop. This patch insteads allows us to specify a QContext-based event loop by adding a "context" property for virtio-blk we can use like so: qemu ... \ -object glib-qcontext,id=ctx0,threaded=y

[Qemu-devel] [PATCH 5/9] GlibQContext: a QContext wrapper around GMainContexts

2013-05-03 Thread Michael Roth
This QContext implementation wraps a GMainContext and maps most interfaces to the obvious/corresponding GMainContext interfaces. It can be used as a near drop-in replacement for event loops based directly around GMainContexts, and provides support for direct handling of GSources (which is unique t

[Qemu-devel] [PATCH 4/9] QContext: QEMU event loop context, abstract base class

2013-05-03 Thread Michael Roth
This class provided interfaces and helper functions for an event loop context modelled closely on GLib's GMainContext. It drives a number of QSources, which are in turn modelled on GLib GSources, and driven in very similar fashion (prepare/poll/check/dispatch interfaces). It also provides a mechani

  1   2   >