Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command

2013-04-29 Thread Stefan Hajnoczi
On Fri, Apr 26, 2013 at 04:58:24PM -0600, Eric Blake wrote: > On 04/23/2013 10:25 AM, Stefan Hajnoczi wrote: > > @block-backup > > > > Start a point-in-time copy of a block device to a new destination. > > > > @device: the name of the device whose writes should be mirrored. > > > > @target: the

Re: [Qemu-devel] [PATCH 0/3] block: block-backup live backup command

2013-04-29 Thread Stefan Hajnoczi
On Sat, Apr 27, 2013 at 01:37:07PM +0800, Wenchao Xia wrote: > 于 2013-4-24 0:25, Stefan Hajnoczi 写道: > > This series adds a new QMP command, block-backup, which takes a > > point-in-time > > snapshot of a block device. The snapshot is copied out to a target block > > device. A simple example is:

Re: [Qemu-devel] [oss-security] Re: [PATCH 1/3] virtio-pci: properly validate address before accessing config

2013-04-29 Thread Michael S. Tsirkin
On Mon, Apr 29, 2013 at 01:34:44AM -0600, Kurt Seifried wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 04/28/2013 05:29 AM, Petr Matousek wrote: > > On Sat, Apr 27, 2013 at 01:13:16PM +0800, Jason Wang wrote: > >> On 04/26/2013 10:27 PM, Petr Matousek wrote: > >>> On Fri, Apr 26,

Re: [Qemu-devel] [RFC PATCH v5 01/14] util: introduce gsource event abstraction

2013-04-29 Thread Stefan Hajnoczi
On Sat, Apr 27, 2013 at 10:11:40AM +0800, liu ping fan wrote: > On Fri, Apr 26, 2013 at 5:19 PM, Stefan Hajnoczi wrote: > > On Fri, Apr 26, 2013 at 10:47:22AM +0800, Liu Ping Fan wrote: > >> +GPollFD *events_source_add_gfd(EventsGSource *src, int fd) > >> +{ > >> +GPollFD *retfd; > >> + > >> +

[Qemu-devel] dec.c - move to pci-bridge

2013-04-29 Thread Michael S. Tsirkin
Looks like dec.c is in pci-host by mistake. I'll move it over to pci-bridge if not one complains.

Re: [Qemu-devel] [PATCH 3/4] vfio: Move container list to iommu MemoryRegion

2013-04-29 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 28/04/2013 03:58, David Gibson ha scritto: >>> Ok, knowing about changes that happen in the IOMMU mapping is >>> indeed out of scope of MemoryListeners. What about adding a >>> NotifierList? Then VFIO can register a notifier and use it to >>> learn

Re: [Qemu-devel] [PATCH] memory: give name every AddressSpace

2013-04-29 Thread Paolo Bonzini
Il 29/04/2013 04:11, Alexey Kardashevskiy ha scritto: > The "info mtree" command in QEMU console prints only "memory" and "I/O" > address spaces while there are actually a lot more other AddressSpace > structs created by PCI and VIO devices. Those devices do not normally > have names and therefore

Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients

2013-04-29 Thread Michael S. Tsirkin
On Fri, Apr 26, 2013 at 01:13:28PM +0200, Laszlo Ersek wrote: > On 04/25/13 21:03, Anthony Liguori wrote: > > Laszlo Ersek writes: > > > >> This patch reuses some code from SeaBIOS, which was originally under > >> LGPLv2 and then relicensed to GPLv3 or LGPLv3, in QEMU under GPLv2+. This > >> reli

Re: [Qemu-devel] [PATCH 6/6] pc_sysfw: change rom_only default to 0

2013-04-29 Thread Paolo Bonzini
Il 28/04/2013 10:32, Jordan Justen ha scritto: > Now KVM can support a flash memory. This feature depends on > KVM_CAP_READONLY_MEM, which was introduced in Linux 3.7. I don't think we can require such a new kernel to run KVM. IIUC, an older kernel would just fail to start, right? Paolo

Re: [Qemu-devel] [PATCH] memory: give name every AddressSpace

2013-04-29 Thread Alexey Kardashevskiy
On 04/29/2013 06:16 PM, Paolo Bonzini wrote: > Il 29/04/2013 04:11, Alexey Kardashevskiy ha scritto: >> The "info mtree" command in QEMU console prints only "memory" and "I/O" >> address spaces while there are actually a lot more other AddressSpace >> structs created by PCI and VIO devices. Those d

Re: [Qemu-devel] [RFC PATCH v5 05/14] net: port socket to GSource

2013-04-29 Thread Stefan Hajnoczi
On Sat, Apr 27, 2013 at 03:09:10PM +0800, liu ping fan wrote: > On Fri, Apr 26, 2013 at 5:48 PM, Stefan Hajnoczi wrote: > > On Fri, Apr 26, 2013 at 10:47:26AM +0800, Liu Ping Fan wrote: > >> @@ -141,6 +134,59 @@ static ssize_t > >> net_socket_receive_dgram(NetClientState *nc, const uint8_t *buf,

Re: [Qemu-devel] SCSI CD-ROM hotplug problem

2013-04-29 Thread Paolo Bonzini
Il 25/04/2013 15:40, Liuji (Jeremy) ha scritto: > Hello, everyone > > I have a question about hotplug of cd-rom. > > version of qemu: Apr-22-2013 bb71623811686ce3c34ce724f073f5c5dd95f51b > > 1) start the vm: > qemu-kvm -enable-kvm -m 1024 -smp 2 -boot c -drive > file=/home/vm/winxp.qcow2,if=n

Re: [Qemu-devel] [PATCH] Makefile: Fix build breakage

2013-04-29 Thread Paolo Bonzini
Il 28/04/2013 20:04, Dunrong Huang ha scritto: > The following error occurs when building dtc module: > > CHK version_gen.h >CC libfdt/fdt.o > cc1: error: dtc: No such file or directory [-Werror] > cc1: all warnings being treated as errors > make[1]: *** [libfdt/fdt.o] Error 1 > make

Re: [Qemu-devel] about the usbredirect lib problem run under Windows

2013-04-29 Thread Hans de Goede
Hi, On 04/28/2013 04:09 AM, zhou link wrote: Hans de Goede & Gerd Hoffmann: theses days i try to migrate the usbredir lib to Windows the usbredir-0.6/usbredirserver/usbredirserver.c connect to qemu's redirect channel and spicec connect to the guest the usbredirserver works smooth

Re: [Qemu-devel] [PATCH for-1.5 v2 08/20] mc146818rtc: QOM'ify

2013-04-29 Thread Igor Mammedov
On Sat, 27 Apr 2013 22:18:43 +0200 Andreas Färber wrote: > Introduce type constant and cast macro to obsolete DO_UPCAST(). > > Prepares for ISA realizefn. > > Signed-off-by: Andreas Färber > --- > hw/timer/mc146818rtc.c | 36 > include/hw/timer/mc1

Re: [Qemu-devel] [PATCH] memory: give name every AddressSpace

2013-04-29 Thread Paolo Bonzini
Il 29/04/2013 10:21, Alexey Kardashevskiy ha scritto: >>> >> +g_free((void *)as->name); >> > >> > No cast here. > ? > > CCppc64-softmmu/memory.o > /home/alexey/pcipassthru/qemu-impreza/memory.c: In function > 'address_space_destroy': > /home/alexey/pcipassthru/qemu-impreza/memory.c:1626

Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command

2013-04-29 Thread Paolo Bonzini
Il 29/04/2013 09:21, Stefan Hajnoczi ha scritto: > > I'd really love to see us change 'BlockJobInfo' to use an enum for > > 'type', instead of its open-coded 'str'. Likewise, the block-job > > related events in QMP/qmp-events.txt should be updated to refer to the > > enum instead of also being ope

[Qemu-devel] KVM call agenda for 2013-04-30

2013-04-29 Thread Juan Quintela
Hi Please send in any agenda topics you are interested in. Later, Juan.

Re: [Qemu-devel] [PATCH 17/21] introduce memory_region_get_address() and use it in kvm/ioapic

2013-04-29 Thread Paolo Bonzini
Il 27/04/2013 22:57, Blue Swirl ha scritto: >> The questions are, in order of importance: >> >> (1) what privileges would this require in the guest? Answer: a lot. >> >> (2) is this likely to happen by chance? Answer: no, not at all. >> >> (3) is there a workaround? Answer: yes, disable in-kerne

Re: [Qemu-devel] [PATCH 17/21] introduce memory_region_get_address() and use it in kvm/ioapic

2013-04-29 Thread Igor Mammedov
On Sat, 27 Apr 2013 20:57:26 + Blue Swirl wrote: > On Sat, Apr 27, 2013 at 12:12 PM, Paolo Bonzini wrote: > > Il 27/04/2013 12:09, Blue Swirl ha scritto: > >> On Fri, Apr 26, 2013 at 10:13 PM, Paolo Bonzini > >> wrote: > >>> Il 26/04/2013 19:46, Igor Mammedov ha scritto: > >> But as th

[Qemu-devel] [PULL 1.5 v6 0/4] fix win32 compilation

2013-04-29 Thread Paolo Bonzini
Here is a fix for the Win32 compilation problem that Blue reported, and another two nits I found while testing. After these patches, a cross libtool is not needed anymore to build on Win32. The following changes since commit 75f6e8b0f121b6a95eb9e35d88ec1f01824f: virtio-rng-s390: add proper

[Qemu-devel] [PATCH 1/4] win32: add generic RC rules to rules.mak

2013-04-29 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile | 2 -- rules.mak | 4 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 8aca92f..58e3527 100644 --- a/Makefile +++ b/Makefile @@ -167,9 +167,7 @@ recurse-all: $(SUBDIR_RULES) $(ROMSUBDIR_RULES) bt-host.o: QEM

[Qemu-devel] [PATCH 2/4] win32: move Makefile dependencies on version-obj-y to rules.mak

2013-04-29 Thread Paolo Bonzini
This makes the test on $(LIBTOOL) work. Otherwise, LIBTOOL is /bin/false by the time the test is done. Fixes Win32 compilation without a working cross-libtool. Signed-off-by: Paolo Bonzini --- Makefile | 3 +-- rules.mak | 3 +++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/

[Qemu-devel] [PATCH 3/4] win32: generate console executable again

2013-04-29 Thread Paolo Bonzini
The -mwindows option is not anymore in LIBS at this point of the Makefile, it is only in libs_softmmu. Check the right variable. Signed-off-by: Paolo Bonzini --- Makefile.target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.target b/Makefile.target index 7e4c77a..

[Qemu-devel] [PATCH 4/4] win32: add readv/writev emulation

2013-04-29 Thread Paolo Bonzini
Commit e9d8fbf (qemu-file: do not use stdio for qemu_fdopen, 2013-03-27) introduced a usage of writev, which mingw32 does not have. Even though qemu_fdopen itself is not used on mingw32, the future-proof solution is to add an implementation of it. This is simple and similar to how we emulate send

Re: [Qemu-devel] [PATCH prep for-1.5] prep: Add ELF support for -bios

2013-04-29 Thread Fabien Chouteau
On 04/28/2013 12:16 PM, Andreas Färber wrote: > Am 28.04.2013 11:44, schrieb Alexander Graf: >> >> On 28.04.2013, at 02:32, Andreas Färber wrote: >> >>> This prepares for switching from OpenHack'Ware to OpenBIOS. >>> >>> Signed-off-by: Andreas Färber >>> --- >>> hw/ppc/prep.c | 21 +---

Re: [Qemu-devel] dec.c - move to pci-bridge

2013-04-29 Thread Andreas Färber
Am 29.04.2013 10:10, schrieb Michael S. Tsirkin: > Looks like dec.c is in pci-host by mistake. > I'll move it over to pci-bridge if not one > complains. +1, matches my understanding from mac_newworld refactoring attempts. Also I noticed that firmware_abi.h with structs for OpenBIOS landed in hw/s

Re: [Qemu-devel] [PATCH 1/6] kvm: add kvm_readonly_mem_enabled

2013-04-29 Thread Jan Kiszka
On 2013-04-28 10:32, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > include/sysemu/kvm.h | 10 ++ > kvm-all.c|6 ++ > kvm-stub.c |1 + > 3 files changed, 17 insertions(+) > > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > index

Re: [Qemu-devel] [PATCH 3/6] kvm: workaround a possible KVM bug when using KVM_MEM_READONLY

2013-04-29 Thread Jan Kiszka
On 2013-04-28 10:32, Jordan Justen wrote: > On a Linux 3.8.0 based kernel, I occasionally saw a situation > where the memory region would continue to trap on memory > read even though KVM_MEM_READONLY was set. Only 3.8.0? Did you bisect the issue down to the causing commit? Is it fixed in later ve

Re: [Qemu-devel] [PATCH RFC qom-cpu-next] apic: QOM'ify APICCommonState casts

2013-04-29 Thread Igor Mammedov
On Sun, 28 Apr 2013 13:22:10 +0200 Andreas Färber wrote: > Necessary to change the name of ICCDevice's parent object field. > > Signed-off-by: Andreas Färber > --- > Could any of the APIC experts please review whether I'm touching any hot > path? > Not sure if this was a mix of pre- and post

Re: [Qemu-devel] SoftFloat licensing in Linux kernel

2013-04-29 Thread Peter Maydell
On 11 April 2013 07:49, Stefan Hajnoczi wrote: > http://lwn.net/Articles/546840/ > > QEMU uses the John Hauser's SoftFloat library. It seems the matter > isn't settled yet in Linux but the FSF says the license is > incompatible with GPLv2. So the resolution determined for the kernel is that they

Re: [Qemu-devel] [PATCH 05/30] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450

2013-04-29 Thread Fabien Chouteau
On 04/28/2013 03:59 PM, Andreas Färber wrote: > Am 26.04.2013 20:21, schrieb Alexander Graf: >> From: Fabien Chouteau >> >> According to the different user's manuals, the vector offset for system >> reset (both /HRESET and /SRESET) is 0x00100. >> >> This patch may break support of some executables

Re: [Qemu-devel] [PATCH v2 2/2] Add AT24Cxx I2C EEPROM device model

2013-04-29 Thread Jan Kiszka
On 2013-02-23 14:40, Andreas Färber wrote: >> +static int at24_init(I2CSlave *i2c) > > hw/i2c.c:i2c_slave_qdev_init() calls I2CSlaveClass::init only, so please > use a realize function instead. Cf. hw/qdev-core.h. > >> +{ >> +AT24State *s = DO_UPCAST(AT24State, i2c, i2c); >> +unsigned int

Re: [Qemu-devel] SoftFloat licensing in Linux kernel

2013-04-29 Thread Peter Maydell
On 29 April 2013 11:37, Peter Maydell wrote: > On 11 April 2013 07:49, Stefan Hajnoczi wrote: >> QEMU uses the John Hauser's SoftFloat library. It seems the matter >> isn't settled yet in Linux but the FSF says the license is >> incompatible with GPLv2. > > So the resolution determined for the k

Re: [Qemu-devel] [PATCH 3/4] vfio: Move container list to iommu MemoryRegion

2013-04-29 Thread David Gibson
On Mon, Apr 29, 2013 at 10:11:06AM +0200, Paolo Bonzini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Il 28/04/2013 03:58, David Gibson ha scritto: > >>> Ok, knowing about changes that happen in the IOMMU mapping is > >>> indeed out of scope of MemoryListeners. What about adding a

Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-29 Thread Peter Lieven
On 21.04.2013 16:21, Peter Crosthwaite wrote: Hi Peter, On Fri, Apr 19, 2013 at 5:01 PM, Peter Lieven wrote: On 18.04.2013 16:35, Peter Crosthwaite wrote: Hi Peter, On Fri, Apr 19, 2013 at 12:22 AM, Peter Lieven wrote: On 15.04.2013 15:08, Anthony Liguori wrote: Peter Crosthwaite writes

Re: [Qemu-devel] [PATCH RFC qom-cpu-next] apic: QOM'ify APICCommonState casts

2013-04-29 Thread Andreas Färber
Am 29.04.2013 12:29, schrieb Igor Mammedov: > On Sun, 28 Apr 2013 13:22:10 +0200 > Andreas Färber wrote: > >> Necessary to change the name of ICCDevice's parent object field. >> >> Signed-off-by: Andreas Färber >> --- >> Could any of the APIC experts please review whether I'm touching any hot

Re: [Qemu-devel] [PATCH 05/30] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450

2013-04-29 Thread Andreas Färber
Am 29.04.2013 12:38, schrieb Fabien Chouteau: > On 04/28/2013 03:59 PM, Andreas Färber wrote: >> Am 26.04.2013 20:21, schrieb Alexander Graf: >>> From: Fabien Chouteau >>> >>> According to the different user's manuals, the vector offset for system >>> reset (both /HRESET and /SRESET) is 0x00100. >

Re: [Qemu-devel] [PATCH 3/4] vfio: Move container list to iommu MemoryRegion

2013-04-29 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 29/04/2013 13:00, David Gibson ha scritto: > On Mon, Apr 29, 2013 at 10:11:06AM +0200, Paolo Bonzini wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> Il 28/04/2013 03:58, David Gibson ha scritto: > Ok, knowing about changes that ha

Re: [Qemu-devel] [PATCH RFC 2/3] acpi: load and link tables from /etc/acpi/

2013-04-29 Thread Laszlo Ersek
Not sure how much it counts, but I personally can agree with you on this direction :) One note below: > @@ -603,8 +604,72 @@ acpi_setup(void) > if (! CONFIG_ACPI) > return; > > +int acpi_generate = 1; > + > dprintf(3, "init ACPI tables\n"); > > +struct romfile_s *fi

Re: [Qemu-devel] dec.c - move to pci-bridge

2013-04-29 Thread Paolo Bonzini
Il 29/04/2013 12:17, Andreas Färber ha scritto: >> > Looks like dec.c is in pci-host by mistake. >> > I'll move it over to pci-bridge if not one >> > complains. > +1, matches my understanding from mac_newworld refactoring attempts. > > Also I noticed that firmware_abi.h with structs for OpenBIOS l

Re: [Qemu-devel] [PATCH] memory: give name every AddressSpace

2013-04-29 Thread David Gibson
On Mon, Apr 29, 2013 at 11:25:16AM +0200, Paolo Bonzini wrote: > Il 29/04/2013 10:21, Alexey Kardashevskiy ha scritto: > >>> >> +g_free((void *)as->name); > >> > > >> > No cast here. > > ? > > > > CCppc64-softmmu/memory.o > > /home/alexey/pcipassthru/qemu-impreza/memory.c: In function >

Re: [Qemu-devel] [PATCH 3/4] vfio: Move container list to iommu MemoryRegion

2013-04-29 Thread David Gibson
On Mon, Apr 29, 2013 at 01:38:06PM +0200, Paolo Bonzini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Il 29/04/2013 13:00, David Gibson ha scritto: > > On Mon, Apr 29, 2013 at 10:11:06AM +0200, Paolo Bonzini wrote: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > >> > >> Il 28/

Re: [Qemu-devel] [PATCH v2] virtio-net: unbreak the minix guest

2013-04-29 Thread Aurelien Jarno
On Fri, Apr 26, 2013 at 12:49:53PM +0200, Aurelien Jarno wrote: > On Thu, Apr 25, 2013 at 03:24:23PM +0800, Jason Wang wrote: > > Multiqueue patchset conditionally add control vq only when guest negotiate > > the > > feature. Though the spec is not clear on this but it breaks the minix guest > > s

Re: [Qemu-devel] [PATCH for-1.5 v3 08/15] xilinx_spips: Implement automatic CS

2013-04-29 Thread Peter Maydell
On 22 April 2013 06:16, wrote: > From: Peter Crosthwaite > > Implement the automatic CS control feature. If the MANUAL_CS bit is > cleared then the chip select stay de-asserted as long as the tx FIFO > is empty. > > Signed-off-by: Peter Crosthwaite > Reviewed-by: Peter Maydell Doesn't compile

Re: [Qemu-devel] [PATCH for-1.5 v3 05/15] xilinx_spips: Fix QSPI FIFO size

2013-04-29 Thread Peter Maydell
On 22 April 2013 06:14, wrote: > @@ -630,6 +652,7 @@ static const TypeInfo xilinx_spips_info = { > .parent = TYPE_SYS_BUS_DEVICE, > .instance_size = sizeof(XilinxSPIPS), > .class_init = xilinx_spips_class_init, > +.class_size = sizeof (XilinxSPIPSClass), Checkpatch doesn't li

[Qemu-devel] [PATCH] qdev: Report errors collected during device realization

2013-04-29 Thread Jan Kiszka
Better than just releasing the error object silently. Signed-off-by: Jan Kiszka --- hw/core/qdev.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 4eb0134..ab1d8f5 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -162,6 +162,7 @@

Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients

2013-04-29 Thread Kevin O'Connor
On Mon, Apr 29, 2013 at 11:20:15AM +0300, Michael S. Tsirkin wrote: > On Fri, Apr 26, 2013 at 01:13:28PM +0200, Laszlo Ersek wrote: > > > > I added this from v3 to v4 because Michael asked me for it > > . > > > > >From the Sea

Re: [Qemu-devel] [PATCH 2/2] s390: dump guest memory implementation

2013-04-29 Thread Ekaterina Tumanova
On 04/26/2013 09:12 PM, Alexander Graf wrote: On 23.04.2013, at 17:30, Jens Freimann wrote: Implement dump-guest-memory support for target s390x. dump-guest-memory QEMU monitor command didn't work for s390 architecture. The result of the command is supposed to be ELF format crash-readable dump

Re: [Qemu-devel] [PATCH 05/30] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450

2013-04-29 Thread Aurelien Jarno
On Mon, Apr 29, 2013 at 01:37:30PM +0200, Andreas Färber wrote: > Am 29.04.2013 12:38, schrieb Fabien Chouteau: > > On 04/28/2013 03:59 PM, Andreas Färber wrote: > >> Am 26.04.2013 20:21, schrieb Alexander Graf: > >>> From: Fabien Chouteau > >>> > >>> According to the different user's manuals, the

Re: [Qemu-devel] SoftFloat licensing in Linux kernel

2013-04-29 Thread Anthony Liguori
Peter Maydell writes: > On 29 April 2013 11:37, Peter Maydell wrote: >> On 11 April 2013 07:49, Stefan Hajnoczi wrote: >>> QEMU uses the John Hauser's SoftFloat library. It seems the matter >>> isn't settled yet in Linux but the FSF says the license is >>> incompatible with GPLv2. >> >> So the

[Qemu-devel] [PATCH v4 1/2] i2c: Introduce device address mask

2013-04-29 Thread Jan Kiszka
Some devices react on multiple addresses. To emulate this, we could register them multiple times, but that is cumbersome. The AT24C16, e.g. listens on 8 different addresses. Instead, introduce a device address mask that is applied on the transmitted address before matching it against the stored on

[Qemu-devel] [PATCH v4 0/2] i2c: Add AT24Cxx EEPROM model

2013-04-29 Thread Jan Kiszka
Changes in v4: - instead of provide size property, register at24c1..1024 types to allow specifying the size via the device name Jan Kiszka (2): i2c: Introduce device address mask Add AT24Cxx I2C EEPROM device model hw/arm/pxa2xx.c|3 +- hw/arm/tosa.c |2 +- hw/ar

[Qemu-devel] [PATCH v4 2/2] Add AT24Cxx I2C EEPROM device model

2013-04-29 Thread Jan Kiszka
This implements I2C EEPROMs of the AT24Cxx series. Sizes from 1Kbit to 1024Kbit are supported. Each EEPROM is backed by a block device. Its size can be explicitly specified by selecting the exact device type (required for sizes < 512, the blockdev sector size) or implicitly by providing a block dev

Re: [Qemu-devel] SoftFloat licensing in Linux kernel

2013-04-29 Thread Peter Maydell
On 29 April 2013 14:04, Anthony Liguori wrote: > Peter Maydell writes: >> ...rats, looks like (a) the license change was earlier, at >> the upstream version 2->2b boundary and (b) QEMU's softfloat >> is based on 2b, not 2 (as the kernel's is.) > > The kernel code is quite different than the QEMU

Re: [Qemu-devel] [PATCH V2 0/3] Virtio-9p live migration patchset

2013-04-29 Thread Benoît Canet
quintela: ping. I really need your review to get this patchset in shape for merging. Regards Benoît > Le Thursday 11 Apr 2013 à 16:41:05 (+0200), Benoît Canet a écrit : > This patchset is a rework of the 9p live migration patchs made a few years ago > by Aneesh. > As the new vmstate API doesn

Re: [Qemu-devel] [PATCH v2] linux-user: improve target_to_host_sock_type conversion

2013-04-29 Thread Petar Jovanovic
ping http://patchwork.ozlabs.org/patch/232770/ From: Petar Jovanovic Sent: Tuesday, April 23, 2013 2:15 AM To: Aurelien Jarno; Petar Jovanovic Cc: qemu-devel@nongnu.org; riku.voi...@linaro.org; r...@twiddle.net; blauwir...@gmail.com Subject: RE: [PATCH v2]

Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients

2013-04-29 Thread Laszlo Ersek
On 04/29/13 14:39, Kevin O'Connor wrote: > On Mon, Apr 29, 2013 at 11:20:15AM +0300, Michael S. Tsirkin wrote: >> in particular, seabios wants to interpret presence >> of any file in etc/acpi as a signal not to generate >> its own tables. > > Right. In that case, >> So merging this patch but wi

Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients

2013-04-29 Thread Michael S. Tsirkin
On Mon, Apr 29, 2013 at 08:39:26AM -0400, Kevin O'Connor wrote: > On Mon, Apr 29, 2013 at 11:20:15AM +0300, Michael S. Tsirkin wrote: > > On Fri, Apr 26, 2013 at 01:13:28PM +0200, Laszlo Ersek wrote: > > > > > > I added this from v3 to v4 because Michael asked me for it > > >

Re: [Qemu-devel] [PATCH RFC 2/3] acpi: load and link tables from /etc/acpi/

2013-04-29 Thread Michael S. Tsirkin
On Mon, Apr 29, 2013 at 01:41:01PM +0200, Laszlo Ersek wrote: > Not sure how much it counts, but I personally can agree with you on this > direction :) > > One note below: > > > @@ -603,8 +604,72 @@ acpi_setup(void) > > if (! CONFIG_ACPI) > > return; > > > > +int acpi_generate

Re: [Qemu-devel] [PATCH 3/4] vfio: Move container list to iommu MemoryRegion

2013-04-29 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 29/04/2013 13:56, David Gibson ha scritto: >> Why should VFIO be any special in this? It is reassuring to me >> that the VFIO maintainer thinks the same. :) > > Because device passthrough is a sufficiently special case, IMO. > It introduces requir

Re: [Qemu-devel] [PATCH] Makefile: Fix build breakage

2013-04-29 Thread Dunrong Huang
On Mon, Apr 29, 2013 at 4:19 PM, Paolo Bonzini wrote: > Il 28/04/2013 20:04, Dunrong Huang ha scritto: > > The following error occurs when building dtc module: > > > > CHK version_gen.h > >CC libfdt/fdt.o > > cc1: error: dtc: No such file or directory [-Werror] > > cc1: all warnings

Re: [Qemu-devel] Target-agnostic virtio?

2013-04-29 Thread Rob Landley
On 04/27/2013 03:00:06 PM, Artyom Tarasenko wrote: > For a lot of the 64-bit targets, actual 64 bit userspace support is > strangely lacking. For ppc64 they say to use ppc32, and I've been told that > about sparc64 as well. I don't know if this is an optimization or a > requirement. I have a 3

[Qemu-devel] [PATCH] bsd-user: OS-agnostic 64-bit SYSCTL types

2013-04-29 Thread Ed Maste
Use existence of type as #ifdef condition rather than FreeBSD-specific version check, as suggested by Patrick Welche. Also handle the signed (CTLTYPE_S64) case identically to the unsigned (CTLTYPE_U64) case, per later patches in the FreeBSD ports tree (emulators/qemu-devel/files/patch-z-arm-bsd-us

Re: [Qemu-devel] [PATCH 0/2] qom: make cpu_write_elfXX_ functions part of CPUClass

2013-04-29 Thread Andreas Färber
Am 19.04.2013 16:45, schrieb Jens Freimann: > Hi Andreas, > > I have two patches to make dump-guest-memory related > cpu_write_elfxx_note functions members of CPUClass and pass CPUstate > as an argument instead of CPUArchState. > > This is preparation for s390 patches which will follow on Monday.

Re: [Qemu-devel] [PATCH] Makefile: Fix build breakage

2013-04-29 Thread Paolo Bonzini
Il 29/04/2013 15:33, Dunrong Huang ha scritto: > > Yes, this way works for me. > > diff --git a/rules.mak b/rules.mak > index 292a422..2572070 100644 > --- a/rules.mak > +++ b/rules.mak > @@ -15,7 +15,7 @@ MAKEFLAGS += -rR > QEMU_DGFLAGS += -MMD -MP -MT $@ -MF $(*D)/$(*F).d > > # Same as -I$

Re: [Qemu-devel] [PATCH 6/6] pc_sysfw: change rom_only default to 0

2013-04-29 Thread Markus Armbruster
Jordan Justen writes: > Now KVM can support a flash memory. This feature depends on > KVM_CAP_READONLY_MEM, which was introduced in Linux 3.7. > > Signed-off-by: Jordan Justen > --- > hw/block/pc_sysfw.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/block/pc_sys

Re: [Qemu-devel] [PATCH] qdev: Report errors collected during device realization

2013-04-29 Thread Andreas Färber
Am 29.04.2013 14:35, schrieb Jan Kiszka: > Better than just releasing the error object silently. > > Signed-off-by: Jan Kiszka Reviewed-by: Andreas Färber but CC'ing monitor guys to verify this is the right print function. Andreas > --- > hw/core/qdev.c |1 + > 1 files changed, 1 insert

[Qemu-devel] [PATCH v2] ppc: initialize GPRs as per epapr

2013-04-29 Thread Bharat Bhushan
ePAPR defines the initial values of cpu registers. This patch initialize the GPRs as per ePAPR specification. This resolves the issue of guest reboot/reset (guest hang on reboot). Signed-off-by: Bharat Bhushan --- v1-->v2 - Dynemic seting of initial map size in gpr[7] - For this the tlb size c

Re: [Qemu-devel] [PATCH] virtio-net: count VIRTIO_NET_F_MAC when calculating config_len

2013-04-29 Thread Jesse Larrew
On 04/25/2013 01:59 AM, Michael S. Tsirkin wrote: > On Thu, Apr 25, 2013 at 02:21:29PM +0800, Jason Wang wrote: >> Commit 14f9b664 (hw/virtio-net.c: set config size using host features) tries >> to >> calculate config size based on the host features. But it forgets the >> VIRTIO_NET_F_MAC were alw

[Qemu-devel] [PATCH for-1.5 v2] rules.mk: Fix build breakage

2013-04-29 Thread Dunrong Huang
The following error occurs when building dtc module: CHK version_gen.h CC libfdt/fdt.o cc1: error: dtc: No such file or directory [-Werror] cc1: all warnings being treated as errors make[1]: *** [libfdt/fdt.o] Error 1 make: *** [subdir-dtc] Error 2 In rules.mak, "-I$( Cc: Blue Sw

[Qemu-devel] [PATCH v2 3/5] S390: BIOS create link to src folder for .img file

2013-04-29 Thread Dominik Dingel
For *.img files, there will be a link created directly to the src folder, like for all other blobs. Signed-off-by: Dominik Dingel diff --git a/configure b/configure index cb29b69..2ab54ec 100755 --- a/configure +++ b/configure @@ -4389,6 +4389,7 @@ for bios_file in \ $source_path/pc-bios/*.

[Qemu-devel] [PATCH v2 2/5] S390: BIOS check for file

2013-04-29 Thread Dominik Dingel
Add a check if the BIOS blob exists before trying to load. Signed-off-by: Dominik Dingel diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index bcbba7c..f7a570e 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -93,6 +93,10 @@ static int s390_ipl_init(SysBusDevice *dev) } bios_

[Qemu-devel] [PATCH v2 0/5] Enhance s390 BIOS to enable boot device selection

2013-04-29 Thread Dominik Dingel
This patchset allows the s390 platform to boot from a specified virtio-ccw-blk device, passed on the commandline. v1 -> v2 - no loadparm will be used - the virtio devices will not be automatically inserted in the boot order - if there is no boot device in the boot order we will fallback to the f

[Qemu-devel] [PATCH v2 1/5] S390: Add virtio-blk boot

2013-04-29 Thread Dominik Dingel
Check for a kernel IPL entry and load kernel image if one was specified. If no kernel image was supplied and no boot device was specified or the boot device is not of type virtio-blk-ccw, print an error message and exit. Signed-off-by: Christian Paro Signed-off-by: Dominik Dingel diff --git a/

Re: [Qemu-devel] [RFC PATCH v2] Throttle-down guest when live migration does not converge.

2013-04-29 Thread Eric Blake
On 04/27/2013 02:50 PM, Chegu Vinod wrote: > Busy enterprise workloads hosted on large sized VM's tend to dirty > memory faster than the transfer rate achieved via live guest migration. > Despite some good recent improvements (& using dedicated 10Gig NICs > between hosts) the live migration does NO

[Qemu-devel] [PATCH v2 4/5] S390: BIOS boot from given device

2013-04-29 Thread Dominik Dingel
Use the passed device, if there is no device, use the first applicable device. Signed-off-by: Dominik Dingel diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c index fd40fa5..206979f 100644 --- a/pc-bios/s390-ccw/main.c +++ b/pc-bios/s390-ccw/main.c @@ -12,6 +12,7 @@ struct subcha

Re: [Qemu-devel] [PATCH] virtio-net: count VIRTIO_NET_F_MAC when calculating config_len

2013-04-29 Thread KONRAD Frédéric
On 29/04/2013 16:42, Jesse Larrew wrote: On 04/25/2013 01:59 AM, Michael S. Tsirkin wrote: On Thu, Apr 25, 2013 at 02:21:29PM +0800, Jason Wang wrote: Commit 14f9b664 (hw/virtio-net.c: set config size using host features) tries to calculate config size based on the host features. But it forgets

[Qemu-devel] [PATCH v2 5/5] S390: Sync Blob with source changes

2013-04-29 Thread Dominik Dingel
Signed-off-by: Dominik Dingel diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img index 149cf70140e9e690960b49337b4e5f419c452a86..4d2145ecb8d658e3a766272a15e15749afb01705 100644 GIT binary patch literal 17528 zcmeHPe{37qeSbWjL`s&Gv*SASk2$AUNR`BqDcNb&G(c#{QI*bd6h|H8Hi0dhvPDD| zHHvm!BiNKxz+5

Re: [Qemu-devel] [PATCH v2] linux-user: improve target_to_host_sock_type conversion

2013-04-29 Thread Andreas Färber
Am 23.04.2013 02:15, schrieb Petar Jovanovic: > Thanks Aurelien for your comments. > > What others think? Can we submit this version of the patch? Riku? Richard, > Blue? No objection but isn't that a frequent issue that mappings may need to be extended from time to time? The way I've seen that h

[Qemu-devel] [PATCH 0/7 v7 for 1.5] target-i386: CPU hot-add with cpu-add QMP command

2013-04-29 Thread Igor Mammedov
Implements alternative way for hot-adding CPU using cpu-add QMP command, which could be useful until it would be possible to add CPUs via device_add. To hot-add CPU use following command from qmp-shell: cpu-add id=[0..max-cpus - 1) git tree for testing: https://github.com/imammedo/qemu/tree/cpu_

[Qemu-devel] [PATCH 1/7] target-i386: Introduce ICC bus/device/bridge

2013-04-29 Thread Igor Mammedov
Provides a hotpluggable bus for APIC and CPU. * icc-bridge will serve as a parent for icc-bus and provide mmio mapping services to child icc-devices. * icc-device will replace SysBusDevice as a parent of APIC and IOAPIC devices. Signed-off-by: Igor Mammedov [AF: QOM cleanups] Signed-off-by:

[Qemu-devel] [PATCH 5/7] add hot_add_cpu hook to QEMUMachine and export machine_args

2013-04-29 Thread Igor Mammedov
hot_add_cpu hook should be overriden by target that implements cpu hot-add via cpu-add QMP command. Make machine_args available globaly, it allows to reuse machine_args->cpu_model during hotplug, instead of adding target specific globals to keep a copy of cpu_model. Signed-off-by: Igor Mammedov

[Qemu-devel] [PATCH 4/7] pc: pass QEMUMachineInitArgs down to pc_cpus_init()

2013-04-29 Thread Igor Mammedov
It allows to store default cpu_model if none was specified. As side effect reduces size of the pc_piix.c code. Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 13 ++- hw/i386/pc_piix.c| 66 +--- hw/i386/pc_q35.c | 23 ++

[Qemu-devel] [PATCH 3/7] target-i386: Move APIC to ICC bus

2013-04-29 Thread Igor Mammedov
It allows APIC to be hotplugged. * map APIC's mmio at board level if it is present * do not register mmio region for each APIC, since only one is used/mapped Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- v2: - use icc-bridge from args instead of resolving it --- hw/cpu/

[Qemu-devel] [PATCH 7/7] QMP: add cpu-add command

2013-04-29 Thread Igor Mammedov
Adds "cpu-add id=xxx" QMP command. cpu-add's "id" argument is a CPU number in a range [0..max-cpus) Example QMP command: -> { "execute": "cpu-add", "arguments": { "id": 2 } } <- { "return": {} } Signed-off-by: Igor Mammedov Acked-by: Luiz Capitulino Reviewed-by: Eric Blake --- v7: * added

[Qemu-devel] [PATCH for-1.5 0/2] more tcg-arm cleanups

2013-04-29 Thread Richard Henderson
The first patch really ought to get into 1.5. The second patch is a re-done version of the 19/19 patch from version 5 of the previous patch series. We had dropped that due to wanting to avoid 16MB assumption changes. The revised patch merely changes how we handle the constant that needs loading.

[Qemu-devel] [PATCH for-1.5 1/2] tcg-arm: Fix 64-bit tlb load for pre-v6

2013-04-29 Thread Richard Henderson
Found by inspection, since the effect of the bug was simply to send all memory ops through the slow path. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 7216f7a..12eda

[Qemu-devel] [PATCH for-1.5 2/2] tcg-arm: Use movi32 in exit_tb

2013-04-29 Thread Richard Henderson
Avoid the mini constant pool for armv7, and avoid replicating the test for pre-v7. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 12edad4..3d43412 100

[Qemu-devel] [PATCH for-1.5 0/4] virtio: fix bus command line compatibility.

2013-04-29 Thread fred . konrad
From: KONRAD Frederic Cc: Libaiqing Cc: Michal Privoznik This series fix the bus name for virtio-serial-device and virtio-scsi-device. The bus name for virtio-serial-device and virtio-scsi-device is not "id.0" as it was the case before the refactoring. This trigger the error: qemu-system-xx

[Qemu-devel] [PATCH for-1.5 1/4] virtio-x-bus: force bus name to virtio-bus.

2013-04-29 Thread fred . konrad
From: KONRAD Frederic When the proxy id is set, this bus take the name "id.0" which is expected to be the virtio-device's first bus. So force this name to "virtio-bus" as it is an internal bus. Signed-off-by: KONRAD Frederic --- hw/s390x/s390-virtio-bus.c | 5 - hw/s390x/virtio-ccw.c

[Qemu-devel] [PATCH for-1.5 4/4] virtio-scsi: fix the command line compatibility.

2013-04-29 Thread fred . konrad
From: KONRAD Frederic The bus name is wrong since the refactoring. This keep the behaviour of the command line. Signed-off-by: KONRAD Frederic --- hw/s390x/s390-virtio-bus.c | 9 + hw/s390x/virtio-ccw.c | 9 + hw/scsi/virtio-scsi.c | 14 +

[Qemu-devel] [PATCH for-1.5 2/4] virtio-serial: fix command line compatibility.

2013-04-29 Thread fred . konrad
From: KONRAD Frederic The bus name is wrong since the refactoring. This keep the behaviour of the command line. Signed-off-by: KONRAD Frederic --- hw/char/virtio-serial-bus.c | 16 +++- hw/s390x/s390-virtio-bus.c| 8 hw/s390x/virtio-ccw.c | 9 +

[Qemu-devel] [PATCH for-1.5 3/4] scsi: add scsi_named_bus_new().

2013-04-29 Thread fred . konrad
From: KONRAD Frederic This add the possibility to create a scsi-bus with a specified name. Signed-off-by: KONRAD Frederic --- hw/scsi/scsi-bus.c | 12 +--- include/hw/scsi/scsi.h | 2 ++ 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/s

Re: [Qemu-devel] [PATCH] virtio-net: count VIRTIO_NET_F_MAC when calculating config_len

2013-04-29 Thread Jesse Larrew
On 04/29/2013 09:55 AM, KONRAD Frédéric wrote: > On 29/04/2013 16:42, Jesse Larrew wrote: >> On 04/25/2013 01:59 AM, Michael S. Tsirkin wrote: >>> On Thu, Apr 25, 2013 at 02:21:29PM +0800, Jason Wang wrote: Commit 14f9b664 (hw/virtio-net.c: set config size using host features) tries to >

[Qemu-devel] [PATCH 2/7] target-i386: Attach ICC bus to CPU on its creation

2013-04-29 Thread Igor Mammedov
X86CPU should have parent bus so it could provide bus for child APIC. Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- TODO: fix unplug of bus-less devices in device-del v2: - pass icc_bridge to cpu_x86_create instead of resolving it each time --- hw/i386/pc.c | 10

Re: [Qemu-devel] [PATCH] Trivial grammar and spelling fixes

2013-04-29 Thread Richard Henderson
On 2013-04-28 10:49, Stefan Weil wrote: similiar -> similar recieve -> receive transfered -> transferred preperation -> preparation Most changes are in comments, one modifies a parameter name in a function prototype. The spelling fixes were made using codespell. Signed-off-by: Stefan Weil Ac

Re: [Qemu-devel] [PATCH] virtio-net: count VIRTIO_NET_F_MAC when calculating config_len

2013-04-29 Thread KONRAD Frédéric
On 29/04/2013 17:14, Jesse Larrew wrote: On 04/29/2013 09:55 AM, KONRAD Frédéric wrote: On 29/04/2013 16:42, Jesse Larrew wrote: On 04/25/2013 01:59 AM, Michael S. Tsirkin wrote: On Thu, Apr 25, 2013 at 02:21:29PM +0800, Jason Wang wrote: Commit 14f9b664 (hw/virtio-net.c: set config size usin

[Qemu-devel] [PATCH 6/7] target-i386: implement machine->hot_add_cpu hook

2013-04-29 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: * override .hot_add_cpu staticaly starting with 1.5 machine --- hw/i386/pc.c | 22 ++ hw/i386/pc_piix.c| 1 + hw/i386/pc_q35.c | 1 + include/hw/i386/pc.h | 1 + 4 files changed, 25 insertions(+) diff --git a/hw/i386/p

Re: [Qemu-devel] [PATCH for-1.5 v2] rules.mk: Fix build breakage

2013-04-29 Thread Paolo Bonzini
Il 29/04/2013 16:52, Dunrong Huang ha scritto: > The following error occurs when building dtc module: > > CHK version_gen.h > CC libfdt/fdt.o > cc1: error: dtc: No such file or directory [-Werror] > cc1: all warnings being treated as errors > make[1]: *** [libfdt/fdt.o] Error 1 >

  1   2   3   >