Re: [Qemu-devel] [PATCH v2 3/5] vmdk: Add option to create zeroed-grain image

2013-04-23 Thread Stefan Hajnoczi
On Tue, Apr 23, 2013 at 08:52:02AM +0800, Fam Zheng wrote: > On Mon, 04/22 16:06, Stefan Hajnoczi wrote: > > On Mon, Apr 22, 2013 at 10:07:57AM +0800, Fam Zheng wrote: > > > Add image create option "zeroed-grain" to enable zeroed-grain GTE > > > feature of vmdk sparse extents. When this option is o

Re: [Qemu-devel] [PATCH] block: Fix build with tracing enabled

2013-04-23 Thread Stefan Hajnoczi
On Mon, Apr 22, 2013 at 05:48:40PM +0200, Kevin Wolf wrote: > filename was still uninitialised when it's used as a parameter to a > tracing function, so let's move the initialisation. Also, commit c2ad1b0c > forgot to add a NULL check, which this patch adds while we're at it. > > Signed-off-by: Ke

Re: [Qemu-devel] [PATCH v4 1/3] sheepdog: add discard/trim support for sheepdog

2013-04-23 Thread Stefan Hajnoczi
On Tue, Apr 23, 2013 at 02:03:33PM +0800, Liu Yuan wrote: > From: Liu Yuan > > The 'TRIM' command from VM that is to release underlying data storage for > better thin-provision is already supported by the Sheepdog. > > This patch adds the TRIM support at QEMU part. > > For older Sheepdog that d

Re: [Qemu-devel] [RFC PATCH v4 14/15] slirp: handle race condition

2013-04-23 Thread liu ping fan
On Mon, Apr 22, 2013 at 1:55 PM, liu ping fan wrote: > On Fri, Apr 19, 2013 at 4:21 PM, Jan Kiszka wrote: >> On 2013-04-19 02:18, liu ping fan wrote: >>> On Thu, Apr 18, 2013 at 3:13 PM, Jan Kiszka wrote: On 2013-04-17 10:39, Liu Ping Fan wrote: > From: Liu Ping Fan > > Slirp a

Re: [Qemu-devel] [PATCH] net/hub: remove can_receive handler

2013-04-23 Thread Fedorov Sergey
On 04/22/2013 08:09 PM, Paolo Bonzini wrote: Il 22/04/2013 17:27, Fedorov Sergey ha scritto: E.g. network hub has 3 ports. Suppose when iterating through port list in net_hub_port_can_receive() a packet is successfully delivered to the first port, and then is queued in the source port queue beca

Re: [Qemu-devel] [PATCH] net/hub: remove can_receive handler

2013-04-23 Thread Fedorov Sergey
On 04/23/2013 10:58 AM, Stefan Hajnoczi wrote: On Mon, Apr 22, 2013 at 07:27:21PM +0400, Fedorov Sergey wrote: On 04/22/2013 06:57 PM, Stefan Hajnoczi wrote: On Mon, Apr 22, 2013 at 04:26:16PM +0400, Fedorov Sergey wrote: On 04/22/2013 03:47 PM, Stefan Hajnoczi wrote: On Thu, Apr 18, 2013 at

Re: [Qemu-devel] [PATCH v5 18/19] tcg-arm: Convert to CONFIG_QEMU_LDST_OPTIMIZATION

2013-04-23 Thread Richard Henderson
On 2013-04-23 07:44, Aurelien Jarno wrote: On Mon, Apr 22, 2013 at 03:39:42PM +0100, Richard Henderson wrote: On 2013-04-22 13:59, Aurelien Jarno wrote: +/* The code buffer is limited to 16MB, with the prologue located + at the end of it. Therefore we needn't care for any out of +

[Qemu-devel] [PATCH] qxl: Call spice_qxl_driver_unload from qxl_enter_vga_mode

2013-04-23 Thread Hans de Goede
With a SPICE_DISPLAY_CAP_MONITORS_CONFIG capable client, the client needs to know what part of the primary to use for each monitor. If the guest driver does not support this, the server sends messages to the client for a single monitor spanning the entire primary. As soon as the guest calls spice_

[Qemu-devel] [update][PATCH 00/12] target-i386: remove some macros

2013-04-23 Thread liguang
remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF as suggested by Richard Henderson Li Guang (12) target-i386/helper: remove EAX macro target-i386/helper: remove EBX macro target-i386/helper: remove ECX macro target-i386/helper: remove EDX macro

[Qemu-devel] [update][PATCH 02/12] target-i386/helper: remove EBX macro

2013-04-23 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h |2 -- target-i386/mem_helper.c |4 ++-- target-i386/misc_helper.c |2 +- target-i386/seg_helper.c |6 +++--- target-i386/smm_helper.c |8 5 files changed, 10 insertions(+), 12 deletions(-) diff --git a/target-i

[Qemu-devel] [update][PATCH 04/12] target-i386/helper: remove EDX macro

2013-04-23 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h |2 -- target-i386/int_helper.c | 24 target-i386/mem_helper.c |8 target-i386/misc_helper.c |8 target-i386/seg_helper.c |8 target-i386/smm_helper.c |8 6

[Qemu-devel] [update][PATCH 08/12] target-i386/helper: remove EDI macro

2013-04-23 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h|2 -- target-i386/seg_helper.c |6 +++--- target-i386/smm_helper.c |8 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index a7c73bf..23166d1 100644 --- a/target-i386/cpu

Re: [Qemu-devel] [PATCH v5 18/19] tcg-arm: Convert to CONFIG_QEMU_LDST_OPTIMIZATION

2013-04-23 Thread Aurelien Jarno
Le 23/04/2013 10:13, Richard Henderson a écrit : > On 2013-04-23 07:44, Aurelien Jarno wrote: >> On Mon, Apr 22, 2013 at 03:39:42PM +0100, Richard Henderson wrote: >>> On 2013-04-22 13:59, Aurelien Jarno wrote: >> +/* The code buffer is limited to 16MB, with the prologue located >> +

[Qemu-devel] [update][PATCH 07/12] target-i386/helper: remove ESI macro

2013-04-23 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h|2 -- target-i386/seg_helper.c |6 +++--- target-i386/smm_helper.c |8 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 9d52939..a7c73bf 100644 --- a/target-i386/cpu

[Qemu-devel] [update][PATCH 11/12] target-i386/helper: remove redundant env->eip assignment

2013-04-23 Thread liguang
Signed-off-by: liguang --- target-i386/svm_helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-i386/svm_helper.c b/target-i386/svm_helper.c index 649be02..e18fa35 100644 --- a/target-i386/svm_helper.c +++ b/target-i386/svm_helper.c @@ -249,7 +249,7 @@ void he

[Qemu-devel] [update][PATCH 01/12] target-i386/helper: remove EAX macro

2013-04-23 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h |2 - target-i386/int_helper.c | 62 ++-- target-i386/mem_helper.c |8 +++--- target-i386/misc_helper.c | 10 +++--- target-i386/seg_helper.c |8 +++--- target-i386/smm_helper.c |8

[Qemu-devel] [update][PATCH 10/12] target-i386/helper: remove DF macro

2013-04-23 Thread liguang
Signed-off-by: liguang --- cpu-exec.c |4 ++-- target-i386/cc_helper.c |2 +- target-i386/cpu.h |6 ++ 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index 31c089d..ec46380 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -230,

[Qemu-devel] [update][PATCH 06/12] target-i386/helper: remove ESP macro

2013-04-23 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h|2 - target-i386/seg_helper.c | 80 +++-- target-i386/smm_helper.c |8 ++-- target-i386/svm_helper.c |8 ++-- 4 files changed, 49 insertions(+), 49 deletions(-) diff --git a/target-i386/cpu

[Qemu-devel] [update][PATCH 05/12] target-i386/helper: remove EBP macro

2013-04-23 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h|2 -- target-i386/seg_helper.c | 10 +- target-i386/smm_helper.c |8 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 78d1033..f2c4a49 100644 --- a/target-i38

[Qemu-devel] [update][PATCH 03/12] target-i386/helper: remove ECX macro

2013-04-23 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h |2 -- target-i386/mem_helper.c |4 ++-- target-i386/misc_helper.c | 44 ++-- target-i386/seg_helper.c | 18 +- target-i386/smm_helper.c |8 target-i386/svm_hel

[Qemu-devel] [update][PATCH 12/12] target-i386: fix over 80 chars warnings

2013-04-23 Thread liguang
Signed-off-by: liguang --- target-i386/misc_helper.c | 39 ++- target-i386/seg_helper.c | 16 +--- target-i386/svm_helper.c |6 -- 3 files changed, 39 insertions(+), 22 deletions(-) diff --git a/target-i386/misc_helper.c b/target-i386

Re: [Qemu-devel] KVM VM(windows xp) reseted when running geekbench for about 2 days

2013-04-23 Thread Zhanghaoyu (A)
>> >> On Thu, Apr 18, 2013 at 12:00:49PM +, Zhanghaoyu (A) wrote: >> >>> I start 10 VMs(windows xp), then running geekbench tool on them, >> >>> about 2 days, one of them was reset, I found the reset operation >> >>> is done by int kvm_cpu_exec(CPUArchState *env) { >> >>>... >> >>>

[Qemu-devel] [update][PATCH 09/12] target-i386/helper: remove EIP macro

2013-04-23 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h |2 -- target-i386/excp_helper.c |2 +- target-i386/misc_helper.c |4 ++-- target-i386/seg_helper.c | 24 target-i386/svm_helper.c | 16 5 files changed, 23 insertions(+), 25 deletions

[Qemu-devel] [PATCH 01/21] cpu: make kvm-stub.o a part of CPU library

2013-04-23 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- v3: put ifndef around msi.h in kvm-stub.c instead of in msi.h v2: remove unnecessary kvm-stub.o from "System emulator target" section --- Makefile.target | 14 +++--- include/sysemu/kvm.h |4 ++-- kvm-stub.c

[Qemu-devel] [PATCH 00/21 v5] target-i386: CPU hot-add with cpu-add QMP command

2013-04-23 Thread Igor Mammedov
Implements alternative way for hot-adding CPU using cpu-add QMP command, wich could be useful until it would be possible to add CPUs via device_add. All patches except the last are also applicable to device_add aprroach. To hot-add CPU use following command from qmp-shell: cpu-add id=[0..max-cp

[Qemu-devel] [PULL 0/4] usb patch queue

2013-04-23 Thread Gerd Hoffmann
Hi, Nothing major, just some small fixes. please pull, Gerd The following changes since commit 456736710df19c2275192269fe67a3f0b2583835: block: Fix build with tracing enabled (2013-04-22 11:31:41 -0500) are available in the git repository at: git://git.kraxel.org/qemu usb.81 for you

[Qemu-devel] [PATCH 4/4] usb-host: raise libusbx minimum version to 1.0.13

2013-04-23 Thread Gerd Hoffmann
Allows to remove one FIXME. Makes LIBUSB_LOG_LEVEL_WARNING build errors go away. And starting with that version libusb has a LIBUSBX_API_VERSION define which allows to easily #ifdef version dependencies should that need arrive in the future. Signed-off-by: Gerd Hoffmann --- configure

[Qemu-devel] [PATCH 2/4] ehci_free_packet: Discard finished packets when the queue is halted

2013-04-23 Thread Gerd Hoffmann
From: Hans de Goede With pipelining it is possible to encounter a finished packet when cleaning the queue due to a halt. This happens when a non stall error happens while talking to a real device. In this case the queue on the usb-host side will continue processing packets, and we can have comple

[Qemu-devel] [PATCH 07/21] cpu: introduce get_arch_id() method and override it for target-i386

2013-04-23 Thread Igor Mammedov
get_arch_id() adds possibility for generic code to get guest visible CPU ID without accessing CPUArchState. If target doesn't override it, it will return cpu_index. Override it on target-i386 to return APIC ID. Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Reviewed-by: liguang Acke

[Qemu-devel] [PATCH 09/21] cpu: add helper cpu_exists(), to check if CPU with specified id exists

2013-04-23 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v3: * use qemu_for_each_cpu() instead of recursion v2: * s/get_firmware_id()/get_arch_id()/ rebase fixup * remove check for get_arch_id being NULL, since it's always defined --- include/qom/cpu.h | 10 ++ qom/cpu.c | 26 ++

[Qemu-devel] [PATCH 12/21] target-i386: introduce ICC bus/device/bridge

2013-04-23 Thread Igor Mammedov
Provides hotplug-able bus for APIC and CPU. * icc-bridge will serve as a parent for icc-bus and provide mmio mapping services to child icc-devices. * icc-device will replace SysBusDevice as a parent of APIC and IOAPIC devices. Signed-off-by: Igor Mammedov --- v3: * mv include/hw/i386/icc_b

[Qemu-devel] [PATCH 19/21] add hot_add_cpu hook to QEMUMachine and export machine_args

2013-04-23 Thread Igor Mammedov
hot_add_cpu hook should be overriden by target that implements cpu hot-add via cpu-add QMP command. Make machine_args available to machine init code, it allows to centralize cpu_model starage instead of adding target specific globals to keep it. Signed-off-by: Igor Mammedov --- include/hw/board

[Qemu-devel] [PATCH 15/21] target-i386: kvmvapic: make expilict dependency on sysbus.h

2013-04-23 Thread Igor Mammedov
Allows kvmvapic to compile if sysbus.h is removed from apic_internal.h, from which it is indirectly included. sysbus.h will be removed from apic_internal.h after converting APICs to ICCDevice. Signed-off-by: Igor Mammedov --- Note: split it in separate patch from "move APIC to ICC bus" patch to

[Qemu-devel] [PATCH 10/21] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest

2013-04-23 Thread Igor Mammedov
* introduce processor status bitmask visible to guest at 0xaf00 addr, where ACPI asl code expects it * set bit corresponding to APIC ID in processor status bitmask on receiving CPU hot-plug notification * trigger CPU hot-plug SCI, to notify guest about CPU hot-plug event Signed-off-by: Igor Ma

[Qemu-devel] [PATCH 17/21] introduce memory_region_get_address() and use it in kvm/ioapic

2013-04-23 Thread Igor Mammedov
kvm/ioapic is relying on the fact that SysBus device maps mmio regions with offset counted from start of system memory. But if ioapic's region is moved to another sub-region which doesn't start at the beginning of system memory then using offset isn't correct. Fix kvm/ioapic by providing and using

[Qemu-devel] [PATCH 18/21] target-i386: move IOAPIC to ICC bus

2013-04-23 Thread Igor Mammedov
* inherit IOAPICs from ICCDevice and attach them to ICC bus * map IOAPIC's mmio at board level via indirect icc-bridge mmio region that provides address space to IOAPIC via icc-bus Signed-off-by: Igor Mammedov --- v3: * split out introduction of memory_region_get_address() helper * use

[Qemu-devel] [PATCH 21/21] QMP: add cpu-add command

2013-04-23 Thread Igor Mammedov
Adds "cpu-add id=xxx" QMP command. cpu-add's "id" argument is a CPU number in a range [0..max-cpus) Example QMP command: -> { "execute": "cpu-add", "arguments": { "id": 2 } } <- { "return": {} } Signed-off-by: Igor Mammedov --- v6: * added valid values description to qapi schema * split o

[Qemu-devel] [PATCH 16/21] target-i386: move APIC to ICC bus

2013-04-23 Thread Igor Mammedov
It allows APIC to be hotplugged * map APIC's mmio at board level if it is present * do not register mmio region for each APIC, since only one is used/mapped Signed-off-by: Igor Mammedov --- v2: * various style fixes * split out sysbus.h inclusion in kvmvapic.c to simplify review * squ

Re: [Qemu-devel] KVM VM(windows xp) reseted when running geekbench for about 2 days

2013-04-23 Thread Gleb Natapov
On Tue, Apr 23, 2013 at 08:21:29AM +, Zhanghaoyu (A) wrote: > >> >> On Thu, Apr 18, 2013 at 12:00:49PM +, Zhanghaoyu (A) wrote: > >> >>> I start 10 VMs(windows xp), then running geekbench tool on them, > >> >>> about 2 days, one of them was reset, I found the reset operation > >> >>> is d

Re: [Qemu-devel] [PATCH 05/12] S390: ccw firmware: Add main program

2013-04-23 Thread Christian Borntraeger
On 22/04/13 21:18, Alexander Graf wrote: > This C file is the main driving piece of the s390 ccw firmware. It > provides a search for a workable block device, sets it as the default > to boot off of and boots from it. > > Signed-off-by: Alexander Graf > --- > pc-bios/s390-ccw/main.c | 56 > ++

Re: [Qemu-devel] [PATCH 03/32] lsi: use qdev_reset_all

2013-04-23 Thread Jan Kiszka
On 2012-07-27 17:02, Paolo Bonzini wrote: > By first resetting the devices, lsi_soft_reset will find the queue > already cleared so there is no need to do that forcibly (which may also > leak SCSIRequests, and/or worse due to dangling references to the > lsi_request in the hba_private field). > >

Re: [Qemu-devel] [PATCH v5 18/19] tcg-arm: Convert to CONFIG_QEMU_LDST_OPTIMIZATION

2013-04-23 Thread Richard Henderson
On 2013-04-23 09:18, Aurelien Jarno wrote: If you plan to respin the series, do you want I start applying the first patches, at least the "Fix local stack frame" one that we want to see in 1.5 (and stable)? I've already the added the alignment bits you requested for that one. I'll post the rest

[Qemu-devel] [PATCH 20/21] target-i386: implement machine->hot_add_cpu hook

2013-04-23 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 5e50127..b649ed5 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -54,6 +54,7 @@ #include "qemu/config-file.h" #include "

Re: [Qemu-devel] [PATCH 05/12] S390: ccw firmware: Add main program

2013-04-23 Thread Cornelia Huck
On Mon, 22 Apr 2013 21:18:11 +0200 Alexander Graf wrote: > This C file is the main driving piece of the s390 ccw firmware. It > provides a search for a workable block device, sets it as the default > to boot off of and boots from it. > > Signed-off-by: Alexander Graf > --- > pc-bios/s390-ccw/m

[Qemu-devel] [PATCH v4 0/4] virtio-9p refactoring.

2013-04-23 Thread fred . konrad
From: KONRAD Frederic Basically it creates virtio-9p-device backend which extends virtio-device. Then a virtio-9p-device can be connected on a virtio-bus. virtio-9p-pci is modified, extends virtio-pci and have a virtio-9p-device. You can checkout my branch here: git://project.greensocs.com/qemu

[Qemu-devel] [PATCH 08/21] exec: add qemu_for_each_cpu

2013-04-23 Thread Igor Mammedov
wrapper will help to remove open-coded loops Signed-off-by: Michael S. Tsirkin Signed-off-by: Igor Mammedov --- Note: Will be used by ACPI table generation and cpu_exists() --- cpus.c| 13 +++-- exec.c| 10 ++ include/qom/cpu.h |8 3 fi

[Qemu-devel] [PATCH v4 1/4] virtio-9p: add the virtio-9p device.

2013-04-23 Thread fred . konrad
From: KONRAD Frederic Create virtio-9p-device which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/9pfs/virtio-9p-device.c | 73 +- hw/9pfs/virtio-9p.h| 9 ++ hw/virtio/virtio-pci.c

[Qemu-devel] [PATCH v4 2/4] virtio-9p-pci: switch to the new API.

2013-04-23 Thread fred . konrad
From: KONRAD Frederic Here the virtio-9p-pci is modified for the new API. The device virtio-9p-pci extends virtio-pci. It creates and connects a virtio-9p-device during the init. The properties are not changed. Signed-off-by: KONRAD Frederic --- hw/9pfs/virtio-9p.h| 1 - hw/virtio/virtio-

[Qemu-devel] [PATCH v4 3/4] virtio-9p: cleanup: init function.

2013-04-23 Thread fred . konrad
From: KONRAD Frederic This remove old init function as it is no longer needed. Signed-off-by: KONRAD Frederic --- hw/9pfs/virtio-9p-device.c | 75 ++ 1 file changed, 23 insertions(+), 52 deletions(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs

[Qemu-devel] [PATCH v4 4/4] virtio-9p: cleanup: QOM casts.

2013-04-23 Thread fred . konrad
From: KONRAD Frederic As the virtio-9p-pci is switched to the new API, we can use QOM casts. Signed-off-by: KONRAD Frederic --- hw/9pfs/virtio-9p-device.c | 11 +++ hw/9pfs/virtio-9p.c| 2 +- hw/9pfs/virtio-9p.h| 2 +- 3 files changed, 5 insertions(+), 10 deletions(-)

[Qemu-devel] [PATCH 14/21] target-i386: replace MSI_SPACE_SIZE with APIC_SPACE_SIZE

2013-04-23 Thread Igor Mammedov
... and put APIC_SPACE_SIZE in public header so that it could be reused later elsewhere. Signed-off-by: Igor Mammedov Reviewed-by: Andreas Färber --- hw/i386/kvm/apic.c |2 +- hw/intc/apic.c |2 +- hw/xen/xen_apic.c |2 +- include/hw/i386/

Re: [Qemu-devel] [PATCH 00/12] S390: Add virtio-ccw firmware

2013-04-23 Thread Christian Borntraeger
On 22/04/13 21:18, Alexander Graf wrote: > We used to be able to boot from the virtio-s390 machine using a > modified version of zipl. However, for our new virtio-ccw machine, > there was not such support available. > > This patch set adds a tiny but of firmware to the game, so that we > get the s

[Qemu-devel] [PATCH 13/21] target-i386: cpu: attach ICC bus to CPU on its creation

2013-04-23 Thread Igor Mammedov
X86CPU should have parent bus so it would be possible to unplug it later. Set bus_type to TYPE_ICC_BUS for X86CPU type to make device_add attach hotplugged CPU to ICC bus. Signed-off-by: Igor Mammedov --- v2: * make sure that missing or ambiguous icc-bus will cause error on softmmu target.

[Qemu-devel] [PATCH 02/21] cpu: call cpu_synchronize_post_init() from CPUClass.realize() if hotplugged

2013-04-23 Thread Igor Mammedov
... to synchronize CPU state to KVM Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- v2: * linking kvm-stub.o to *-user target moved in separate patch --- include/sysemu/kvm.h | 20 ++-- kvm-all.c|1 + kvm-stub.c |1 + qom/cpu.c

[Qemu-devel] [PATCH 03/21] introduce cpu_resume(), for single CPU

2013-04-23 Thread Igor Mammedov
also add stub for it, to make possible to use it in qom/cpu.c, which is shared with user emulators. Signed-off-by: Igor Mammedov --- v2: * rename resume_vcpu() to cpu_resume() * remove comment about neccessity to call cpu_synchronize_post_init() which is applicable only to CPU creation. But

Re: [Qemu-devel] [PATCH] net/hub: remove can_receive handler

2013-04-23 Thread Fedorov Sergey
On 04/23/2013 10:58 AM, Stefan Hajnoczi wrote: On Mon, Apr 22, 2013 at 07:27:21PM +0400, Fedorov Sergey wrote: On 04/22/2013 06:57 PM, Stefan Hajnoczi wrote: On Mon, Apr 22, 2013 at 04:26:16PM +0400, Fedorov Sergey wrote: On 04/22/2013 03:47 PM, Stefan Hajnoczi wrote: On Thu, Apr 18, 2013 at

[Qemu-devel] [PATCH 04/21] cpu: resume CPU from CPUClass.cpu_common_realizefn() when it is hot-plugged

2013-04-23 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: s/resume_vcpu/cpu_resume/ v2: * remove unnecessary now sysemu/cpus.h header * move out introducing resume_vcpu() into a separate patch --- qom/cpu.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/qom/cpu.c b/qom/cpu.c index 0c7671

[Qemu-devel] [PATCH 06/21] target-i386: pc: update rtc_cmos on CPU hot-plug

2013-04-23 Thread Igor Mammedov
it provides updated currently available CPUs count to BIOS on reboot Signed-off-by: Igor Mammedov --- v2: * reorder fields in rtc_cpu_hotplug_arg, make cpu_added_notifier first. * rebase on top of "mc146818rtc: QOM'ify" and use QOM style cast --- hw/i386/pc.c | 20 +++

[Qemu-devel] [PATCH 11/21] target-i386: introduce apic-id property

2013-04-23 Thread Igor Mammedov
The property is used from board level to set APIC ID for CPUs it creates. Do so in a new pc_new_cpu() helper, to be reused for hot-plug. Signed-off-by: Igor Mammedov --- Note: * pc_new_cpu() function will be reused later in CPU hot-plug hook. v4: * after switching to qemu_for_each_cpu() in c

[Qemu-devel] [PATCH 1/4] xhci: remove XHCIRing->base (unused)

2013-04-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index a26b78e..2c90e56 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -326,7 +326,6 @@ typedef enum EPType { } EPType;

[Qemu-devel] [PATCH 05/21] introduce CPU hot-plug notifier

2013-04-23 Thread Igor Mammedov
hot-add CPU event will be distributed to acpi_piix4 and rtc_cmos Signed-off-by: Igor Mammedov --- v3: * call notifier right before CPU becomes runable v2: * move notifier to qom/cpu.c and call it from CPUClass.realize() on hotplug * remove get_firmware_id() since it belong to other patch --

[Qemu-devel] [PATCH 3/4] usb: better speed mismatch error reporting

2013-04-23 Thread Gerd Hoffmann
Report the supported speeds for device and port in the error message. Also add the speeds to the tracepoint. And while being at it drop the redundant error message in usb_desc_attach, usb_device_attach will report the error anyway. Signed-off-by: Gerd Hoffmann --- hw/usb/bus.c | 36 +

[Qemu-devel] [PATCH] ui/gtk: Use gtk_widget_get_window() to support both gtk2 and gtk3

2013-04-23 Thread Ozan Çağlayan
This fixes build with gtk+-3.0. Signed-off-by: Ozan Çağlayan --- ui/gtk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index b46997a..4110342 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -337,7 +337,7 @@ static void gd_mouse_set(DisplayChangeListener *dc

[Qemu-devel] [PATCH] ui/gtk: Add Turkish translations

2013-04-23 Thread Ozan Çağlayan
Signed-off-by: Ozan Çağlayan --- po/tr.po | 62 ++ 1 file changed, 62 insertions(+) create mode 100644 po/tr.po diff --git a/po/tr.po b/po/tr.po new file mode 100644 index 000..4faefbd --- /dev/null +++ b/po/tr.po @@ -0,0 +1,62 @@

[Qemu-devel] [PATCH] replace while loop with a disabled wait on s390 bios

2013-04-23 Thread Christian Borntraeger
dont waste cpu power on an error condition. Lets stop the guest with a disabled wait. Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw/main.c | 4 ++-- pc-bios/s390-ccw/s390-ccw.h | 3 +++ pc-bios/s390-ccw/start.S| 15 +++ 3 files changed, 20 insertions(+), 2 delet

Re: [Qemu-devel] [PATCH 10/12] S390: ccw firmware: Add Makefile

2013-04-23 Thread Christian Borntraeger
On 22/04/13 21:18, Alexander Graf wrote: > +s390-ccw.elf: $(OBJECTS) > + $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $(OBJECTS)," Building > $(TARGET_DIR)$@") > + > +s390-ccw.img: s390-ccw.elf > + $(call quiet-command,strip $@," Stripping $(TARGET_DIR)$@") $(call quiet-command,

Re: [Qemu-devel] [PATCH v1 1/1] target-arm: helper.c: RAZ REVIDR cp register

2013-04-23 Thread Peter Maydell
On 23 April 2013 03:08, wrote: > From: Peter Crosthwaite > > Guests should be able to read REVIDR without suffering an abort. Just > RAZ the REVIDR register. > > Signed-off-by: Peter Crosthwaite > --- > > target-arm/helper.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > d

Re: [Qemu-devel] [RFC PATCH v2 00/11] qemu-ga: fsfreeze on Windows using VSS

2013-04-23 Thread Libaiqing
Hi, I tried the patch v2,with the following config. Guest os : win7 32bit professional Host os : fedora 17 Command: qemu-kvm -enable-kvm -name win7 -M pc-0.15 -m 1024 -smp 2 -boot c -device virtio-serial -drive file=/home/libaiqing/vss/win7.img,if=virtio,index=0,format=qcow2 -

[Qemu-devel] [PATCH 0/4] updates for s390-ccw.img

2013-04-23 Thread Christian Borntraeger
Alex, here are the quick things that I needed to make the s390-ccw.img working. Please have a look and feel free to apply. Christian Borntraeger (4): s390-ccw.img: replace while loop with a disabled wait on s390 bios s390-ccw.img: build s390-ccw rom on s3900 system by default s390-ccw.img:

[Qemu-devel] [PATCH 1/4] s390-ccw.img: replace while loop with a disabled wait on s390 bios

2013-04-23 Thread Christian Borntraeger
dont waste cpu power on an error condition. Lets stop the guest with a disabled wait. Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw/main.c | 2 ++ pc-bios/s390-ccw/s390-ccw.h | 3 +++ pc-bios/s390-ccw/start.S| 15 +++ 3 files changed, 20 insertions(+) diff --gi

[Qemu-devel] [PATCH 4/4] s390-ccw.img: Take care of the elf->img transition

2013-04-23 Thread Christian Borntraeger
We have to call strip with s390-ccw.elf as input and s390-ccw.img as output Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile index c126194..ad55a14 1006

[Qemu-devel] [PATCH 2/4] s390-ccw.img: build s390-ccw rom on s3900 system by default

2013-04-23 Thread Christian Borntraeger
Lets build the s390-ccw rom if on s390. Also fix the separate build folder case. Signed-off-by: Christian Borntraeger --- configure | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/configure b/configure index a382ff2..cb29b69 100755 --- a/configure +++ b/configure @@ -33

[Qemu-devel] [PATCH 3/4] s390-ccw.img: Fix compile warning in s390 ccw virtio code

2013-04-23 Thread Christian Borntraeger
Lets fix this gcc warning: virtio.c: In function ‘vring_send_buf’: virtio.c:125:35: error: operation on ‘vr->next_idx’ may be undefined [-Werror=sequence-point] Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw/virtio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --gi

Re: [Qemu-devel] [PATCH 07/12] S390: ccw firmware: Add virtio device drivers

2013-04-23 Thread Cornelia Huck
On Mon, 22 Apr 2013 21:18:13 +0200 Alexander Graf wrote: > In order to boot, we need to be able to access a virtio-blk device through > the CCW bus. Implement support for this. > > Signed-off-by: Alexander Graf > --- > pc-bios/s390-ccw/cio.h| 322 > +++

Re: [Qemu-devel] [PATCH 3/4] s390-ccw.img: Fix compile warning in s390 ccw virtio code

2013-04-23 Thread Alexander Graf
On 04/23/2013 01:23 PM, Christian Borntraeger wrote: Lets fix this gcc warning: virtio.c: In function ‘vring_send_buf’: virtio.c:125:35: error: operation on ‘vr->next_idx’ may be undefined [-Werror=sequence-point] Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw/virtio.c | 4 +++- 1

Re: [Qemu-devel] [PATCH 0/4] updates for s390-ccw.img

2013-04-23 Thread Alexander Graf
On 04/23/2013 01:23 PM, Christian Borntraeger wrote: Alex, here are the quick things that I needed to make the s390-ccw.img working. Please have a look and feel free to apply. Thanks, applied all except for 3/4 to my branch :) Alex Christian Borntraeger (4): s390-ccw.img: replace while

Re: [Qemu-devel] [PATCH 05/12] S390: ccw firmware: Add main program

2013-04-23 Thread Alexander Graf
On 04/23/2013 10:58 AM, Cornelia Huck wrote: On Mon, 22 Apr 2013 21:18:11 +0200 Alexander Graf wrote: This C file is the main driving piece of the s390 ccw firmware. It provides a search for a workable block device, sets it as the default to boot off of and boots from it. Signed-off-by: Alexa

Re: [Qemu-devel] [PATCH 00/12] S390: Add virtio-ccw firmware

2013-04-23 Thread Alexander Graf
On 04/23/2013 11:20 AM, Christian Borntraeger wrote: On 22/04/13 21:18, Alexander Graf wrote: We used to be able to boot from the virtio-s390 machine using a modified version of zipl. However, for our new virtio-ccw machine, there was not such support available. This patch set adds a tiny but o

Re: [Qemu-devel] [PATCH 10/21] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest

2013-04-23 Thread Juan Quintela
Igor Mammedov wrote: > > +#define VMSTATE_CPU_STATUS_ARRAY(_field, _state) > \ > + { > \ > + .name = (stringify(_field)), > \ > + .version_

Re: [Qemu-devel] [PATCH 3/4] s390-ccw.img: Fix compile warning in s390 ccw virtio code

2013-04-23 Thread Christian Borntraeger
On 23/04/13 13:31, Alexander Graf wrote: > On 04/23/2013 01:23 PM, Christian Borntraeger wrote: >> Lets fix this gcc warning: >> >> virtio.c: In function ‘vring_send_buf’: >> virtio.c:125:35: error: operation on ‘vr->next_idx’ may be undefined >> [-Werror=sequence-point] >> >> Signed-off-by: Christ

Re: [Qemu-devel] [PATCH] net/hub: remove can_receive handler

2013-04-23 Thread Stefan Hajnoczi
On Tue, Apr 23, 2013 at 01:32:11PM +0400, Fedorov Sergey wrote: > > On 04/23/2013 10:58 AM, Stefan Hajnoczi wrote: > >On Mon, Apr 22, 2013 at 07:27:21PM +0400, Fedorov Sergey wrote: > >>On 04/22/2013 06:57 PM, Stefan Hajnoczi wrote: > >>>On Mon, Apr 22, 2013 at 04:26:16PM +0400, Fedorov Sergey wro

Re: [Qemu-devel] [PATCH 05/12] S390: ccw firmware: Add main program

2013-04-23 Thread Cornelia Huck
On Tue, 23 Apr 2013 13:35:47 +0200 Alexander Graf wrote: > On 04/23/2013 10:58 AM, Cornelia Huck wrote: > > On Mon, 22 Apr 2013 21:18:11 +0200 > > Alexander Graf wrote: > > > >> This C file is the main driving piece of the s390 ccw firmware. It > >> provides a search for a workable block device,

Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command

2013-04-23 Thread Gerd Hoffmann
Hi, >> True, but I'm not sure we want to go there. We'd need to add support >> for options like JPG quality factor etc. > > PNG would be extremely handy and would go a long way to eliminating the > concern about size. We already link against libpng too. vnc uses libpng when available, but it

Re: [Qemu-devel] [PATCH] net/hub: remove can_receive handler

2013-04-23 Thread Fedorov Sergey
On 04/23/2013 03:48 PM, Stefan Hajnoczi wrote: On Tue, Apr 23, 2013 at 01:32:11PM +0400, Fedorov Sergey wrote: On 04/23/2013 10:58 AM, Stefan Hajnoczi wrote: On Mon, Apr 22, 2013 at 07:27:21PM +0400, Fedorov Sergey wrote: On 04/22/2013 06:57 PM, Stefan Hajnoczi wrote: On Mon, Apr 22, 2013 at

Re: [Qemu-devel] About network bridge.

2013-04-23 Thread Stefan Hajnoczi
On Mon, Apr 22, 2013 at 09:54:02AM -0500, Yaodong Yang wrote: > When I start my vm using virsh start vm2 or virt-manager, the vm's network is > working. I can access the internet within the vm. > However, we I start the same vm using qemu-system-x86_64 vm2.img -m 1024. The > vm can run but witho

Re: [Qemu-devel] [PATCH] net/hub: remove can_receive handler

2013-04-23 Thread Stefan Hajnoczi
On Tue, Apr 23, 2013 at 11:41:42AM +0400, Fedorov Sergey wrote: > >Beyond that, we also want to avoid growing net queues indefinitely. If > >the hub does not implement .can_receive() then it relies on growing > >queues (keeping packets buffered in memory). > No, net_hub_receive() calls qemu_send_p

[Qemu-devel] [PATCH 4/4] s390-ccw.img: Get queue config from host.

2013-04-23 Thread Cornelia Huck
Ask the host about the configuration instead of guessing it. Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/virtio.c | 10 +++--- pc-bios/s390-ccw/virtio.h | 5 + 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/pc-bios/s390-ccw/virtio.c b/pc-bios/s390-ccw/virtio.c ind

[Qemu-devel] [PATCH 1/4] s390-ccw.img: Detect devices with stsch.

2013-04-23 Thread Cornelia Huck
stsch is the canonical way to detect devices. As a bonus, we can abort the loop if we get cc 3, and we need to check only the valid devices (dnv set). Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/main.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/pc-bios/s39

[Qemu-devel] [PATCH 0/4] s390-ccw.img: Some more updates.

2013-04-23 Thread Cornelia Huck
Some changes I hacked up quickly for the ccw loader. Only compile tested as my main test system is currently unavailable. Cornelia Huck (4): s390-ccw.img: Detect devices with stsch. s390-ccw.img: Enhance drain_irqs(). s390-ccw.img: Rudimentary error checking. s390-ccw.img: Get queue confi

[Qemu-devel] [PATCH 2/4] s390-ccw.img: Enhance drain_irqs().

2013-04-23 Thread Cornelia Huck
- Use tpi + tsch to get interrupts. - Return an error if the irb indicates problems. Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/virtio.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/pc-bios/s390-ccw/virtio.c b/pc-bios/s390-ccw/virtio.c index 7

[Qemu-devel] [PATCH 3/4] s390-ccw.img: Rudimentary error checking.

2013-04-23 Thread Cornelia Huck
Try to handle at least some of the errors that may happen. Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/virtio.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/pc-bios/s390-ccw/virtio.c b/pc-bios/s390-ccw/virtio.c index 2a132f8..8e37dce 100644 ---

Re: [Qemu-devel] [PATCH 10/21] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest

2013-04-23 Thread Igor Mammedov
On Tue, 23 Apr 2013 13:38:10 +0200 Juan Quintela wrote: > Igor Mammedov wrote: > > > > > +#define VMSTATE_CPU_STATUS_ARRAY(_field, > > _state) \ > > + > > { > > \ > > + .name = > >

Re: [Qemu-devel] [PATCH 10/21] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest

2013-04-23 Thread Michael S. Tsirkin
On Tue, Apr 23, 2013 at 02:54:16PM +0200, Igor Mammedov wrote: > On Tue, 23 Apr 2013 13:38:10 +0200 > Juan Quintela wrote: > > > Igor Mammedov wrote: > > > > > > > > +#define VMSTATE_CPU_STATUS_ARRAY(_field, > > > _state) \ > > > + > > > {

Re: [Qemu-devel] [PATCH] net/hub: remove can_receive handler

2013-04-23 Thread Fedorov Sergey
On 04/23/2013 04:00 PM, Stefan Hajnoczi wrote: On Tue, Apr 23, 2013 at 11:41:42AM +0400, Fedorov Sergey wrote: Beyond that, we also want to avoid growing net queues indefinitely. If the hub does not implement .can_receive() then it relies on growing queues (keeping packets buffered in memory).

Re: [Qemu-devel] [PATCH 10/21] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest

2013-04-23 Thread Juan Quintela
Igor Mammedov wrote: > On Tue, 23 Apr 2013 13:38:10 +0200 > Juan Quintela wrote: > >> Igor Mammedov wrote: >> >> > >> > +#define VMSTATE_CPU_STATUS_ARRAY(_field, >> > _state) \ >> > + >> > {

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema

2013-04-23 Thread Luiz Capitulino
On Mon, 22 Apr 2013 09:00:05 -0600 Eric Blake wrote: > At any rate, we really DO want introspection, and having it in 1.5 is a > worthwhile goal. Even if the introspection turns up empty on legacy > options, having it for the sake of new options is worth the effort. Agreed. But as you said in a

Re: [Qemu-devel] [PATCH 21/21] QMP: add cpu-add command

2013-04-23 Thread Luiz Capitulino
On Tue, 23 Apr 2013 10:29:55 +0200 Igor Mammedov wrote: > Adds "cpu-add id=xxx" QMP command. > > cpu-add's "id" argument is a CPU number in a range [0..max-cpus) > > Example QMP command: > -> { "execute": "cpu-add", "arguments": { "id": 2 } } > <- { "return": {} } > > Signed-off-by: Igor Mam

Re: [Qemu-devel] [PATCH 10/21] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest

2013-04-23 Thread Juan Quintela
Igor Mammedov wrote: > * introduce processor status bitmask visible to guest at 0xaf00 addr, > where ACPI asl code expects it > * set bit corresponding to APIC ID in processor status bitmask on > receiving CPU hot-plug notification > * trigger CPU hot-plug SCI, to notify guest about CPU hot-pl

Re: [Qemu-devel] [PATCH 10/21] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest

2013-04-23 Thread Eduardo Habkost
On Tue, Apr 23, 2013 at 03:43:51PM +0200, Juan Quintela wrote: > Igor Mammedov wrote: > > * introduce processor status bitmask visible to guest at 0xaf00 addr, > > where ACPI asl code expects it > > * set bit corresponding to APIC ID in processor status bitmask on > > receiving CPU hot-plug no

Re: [Qemu-devel] [PATCH 05/11] block: update error reporting for bdrv_snapshot_goto() and related functions

2013-04-23 Thread Kevin Wolf
Am 16.04.2013 um 18:05 hat Pavel Hrdina geschrieben: > > Signed-off-by: Pavel Hrdina Can you split this in two separate patches for goto and for list? > --- > block.c | 55 > ++- > block/qcow2-snapshot.c| 32 +++

  1   2   3   >