[Qemu-devel] qemu-iotests 042: zero size image on VMDK

2013-04-18 Thread Fam Zheng
Hi, Currently VMDK block driver fails qemu-iotest case 042 because it refuses to create block with zero size (silently). Is support for zero size image desired or should this case be skipped? $ qemu-img create -f vmdk t.vmdk 0 Formatting 't.vmdk', fmt=vmdk size=0 compat6=off qemu-img

Re: [Qemu-devel] [RFC PATCH v4 14/15] slirp: handle race condition

2013-04-18 Thread Jan Kiszka
On 2013-04-17 10:39, Liu Ping Fan wrote: > From: Liu Ping Fan > > Slirp and its peer can run on different context at the same time. > Using lock to protect What are the usage rules for this lock, what precisely is it protecting? Is it ensured that we do not take the BQL while holding this one?

Re: [Qemu-devel] [RFC PATCH v4 15/15] slirp: use lock to protect the slirp_instances

2013-04-18 Thread Jan Kiszka
On 2013-04-17 10:39, Liu Ping Fan wrote: > From: Liu Ping Fan > > slirps will run on dedicated thread, so need to protect the global > list. > > Signed-off-by: Liu Ping Fan > --- > include/qemu/module.h |2 ++ > slirp/slirp.c | 20 > 2 files changed, 22 inser

Re: [Qemu-devel] [PATCH 11/11] savevm: remove backward compatibility from bdrv_snapshot_find()

2013-04-18 Thread Wenchao Xia
So, was I convincing enough in arguing that we want something different from the approach of both existing patch series? Plenty of details, thanks, Eric. I think Pavel's logic is better, which increase the capability of it, and I don't think a more complex logic should be there, since it is

Re: [Qemu-devel] [RFC PATCH] net: introduce monitor command to query mactables

2013-04-18 Thread Stefan Hajnoczi
On Thu, Apr 18, 2013 at 10:51:14AM +0800, Amos Kong wrote: > Hi Stefan, > > On Tue, Apr 16, 2013 at 10:11:50AM +0200, Stefan Hajnoczi wrote: > > On Thu, Apr 11, 2013 at 11:11:58PM +0800, Amos Kong wrote: > > Please add an optional net client name argument so the user can query > > just a single NI

Re: [Qemu-devel] [PATCH v7] sheepdog: add discard/trim support for sheepdog

2013-04-18 Thread Stefan Hajnoczi
On Thu, Apr 18, 2013 at 01:50:53PM +0800, Liu Yuan wrote: > @@ -184,6 +186,8 @@ typedef struct SheepdogInode { > uint32_t data_vdi_id[MAX_DATA_OBJS]; > } SheepdogInode; > > +static bool discard_supported = true; Normally state should be part of BDRVSheepdogState so that it does not affect

Re: [Qemu-devel] [PATCH uq/master v3 1/2] kvm: reset state from the CPU's reset method

2013-04-18 Thread Paolo Bonzini
Il 18/04/2013 07:37, Gleb Natapov ha scritto: >> > +static inline void kvm_arch_reset_vcpu(CPUState *cs) >> > +{ >> > +} >> > + > You added stub to s390, but not to x86. It will compile either way with > current enough gcc, but I wonder why the inconsistency? > Because I kept it consistent within

Re: [Qemu-devel] qemu-iotests 042: zero size image on VMDK

2013-04-18 Thread Stefan Hajnoczi
On Thu, Apr 18, 2013 at 03:08:55PM +0800, Fam Zheng wrote: > Currently VMDK block driver fails qemu-iotest case 042 because it > refuses to create block with zero size (silently). Is support for zero > size image desired or should this case be skipped? > > $ qemu-img create -f vmdk t.vmdk 0 >

Re: [Qemu-devel] [PATCH v7] sheepdog: add discard/trim support for sheepdog

2013-04-18 Thread Liu Yuan
On 04/18/2013 03:37 PM, Stefan Hajnoczi wrote: >> @@ -184,6 +186,8 @@ typedef struct SheepdogInode { >> > uint32_t data_vdi_id[MAX_DATA_OBJS]; >> > } SheepdogInode; >> > >> > +static bool discard_supported = true; > Normally state should be part of BDRVSheepdogState so that it does not > af

Re: [Qemu-devel] [PULL v4 11/11] rdma: add documentation

2013-04-18 Thread Michael S. Tsirkin
On Wed, Apr 17, 2013 at 07:07:20PM -0400, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > docs/rdma.txt contains full documentation, > wiki links, github url and contact information. > > Signed-off-by: Michael R. Hines OK that's better. Need to improve the following areas: - f

Re: [Qemu-devel] [PATCH uq/master v3 0/2] correctly reset the CPU on INIT interrupts

2013-04-18 Thread Gleb Natapov
On Mon, Apr 15, 2013 at 02:05:30PM +0200, Paolo Bonzini wrote: > These patches finally implement INIT entirely in userspace. The problem > here was that the CPU was being reset after kvm_arch_reset_vcpu is called. > This made it harder to hook into the reset process and put APs into > KVM_MP_STATE

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Paolo Bonzini
Il 18/04/2013 01:07, mrhi...@linux.vnet.ibm.com ha scritto: > +/* > + * Virtual address of the above structures used for transmitting > + * the RAMBlock descriptions at connection-time. > + * This structure is *not* transmitted. > + */ > +typedef struct RDMALocalBlocks { > +int num_blocks; > +

Re: [Qemu-devel] [PATCH RFC] vhost: fix vhost force with msix=off

2013-04-18 Thread Christian Borntraeger
On 17/04/13 15:42, Michael S. Tsirkin wrote: [...] >> +static int virtio_ccw_set_guest_notifier(VirtioCcwDevice *dev, int n, >> + bool assign, bool with_irqfd) >> +{ >> +VirtQueue *vq = virtio_get_queue(dev->vdev, n); >> +EventNotifier *notifier = vir

Re: [Qemu-devel] [PULL v4 00/11] rdma: migration support

2013-04-18 Thread Michael S. Tsirkin
On Wed, Apr 17, 2013 at 07:07:09PM -0400, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > The following changes since commit e0a83fc2c1582dc8d4453849852ebe6c258b7c3a: > > qom: do nothing on unparent of object without parent (2013-04-16 16:10:21 > -0500) > > are available in

[Qemu-devel] 'id' assigned to -device could not be set as net-client name (was Re: Nic devices' name are wrongly repeated)

2013-04-18 Thread Amos Kong
On Wed, Apr 10, 2013 at 02:28:40PM +0200, Andreas Färber wrote: > Hi, > > Am 10.04.2013 14:05, schrieb Amos Kong: > > If we don't assign 'id' for nic device, device name will be $model.$idx. > > The $idx are always 0 if we set nic by new style. > > > > # qemu-upstream -device virtio-net-pci,netd

Re: [Qemu-devel] [PATCH 2/2] vnc: Support for LED state extension

2013-04-18 Thread Lei Li
On 04/17/2013 09:52 PM, Anthony Liguori wrote: Lei Li writes: Signed-off-by: Lei Li --- ui/vnc.c | 50 ++ ui/vnc.h |3 ++- 2 files changed, 52 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index fa7ab94..b9b3766 10064

[Qemu-devel] [PATCH v8] sheepdog: add discard/trim support for sheepdog

2013-04-18 Thread Liu Yuan
From: Liu Yuan The 'TRIM' command from VM that is to release underlying data storage for better thin-provision is already supported by the Sheepdog. This patch adds the TRIM support at QEMU part. For older Sheepdog that doesn't support it, we return 0(success) to upper layer. Cc: MORITA Kazuta

Re: [Qemu-devel] [PATCH V18 1/6] docs: document for add-cow file format

2013-04-18 Thread Stefan Hajnoczi
On Wed, Apr 10, 2013 at 04:11:48PM +0800, Dong Xu Wang wrote: > +The Header is included in the first bytes: > +(HEADER_SIZE is defined in 40-43 bytes.) > +Byte0 - 3:magic > +add-cow magic string ("ACOW"). > + > +4 - 7:backing file name offset

Re: [Qemu-devel] GDB function call failing due to memory protection of stack page in QEMU

2013-04-18 Thread Abid, Hafiz
ping. On 11/04/13 12:20:57, Abid, Hafiz wrote: Hi All, I have faced a problem using GDB with user-mode qemu. Although problem was observed for MIPS, I think it is a generic problem. I would appreciate an advice from experts on how best to deal with. Here is the problem description. GDB h

Re: [Qemu-devel] GDB function call failing due to memory protection of stack page in QEMU

2013-04-18 Thread Peter Maydell
On 11 April 2013 12:20, Abid, Hafiz wrote: > Hi All, > I have faced a problem using GDB with user-mode qemu. Although problem was > observed for MIPS, I think it is a generic problem. I would appreciate an > advice from experts on how best to deal with. Here is the problem > description. > > GDB h

Re: [Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions

2013-04-18 Thread Igor Mammedov
On Tue, 16 Apr 2013 03:50:21 +0200 Andreas Färber wrote: > Drop an unreachable fallback bus assignment to SysBus. > > If no ,bus= is specified, only search busses recursively for bus type if > the DeviceClass has a bus_type specified. Handle resulting NULL cases. > > Signed-off-by: Andreas Färb

Re: [Qemu-devel] [PATCH V18 4/6] rename qcow2-cache.c to block-cache.c

2013-04-18 Thread Stefan Hajnoczi
On Wed, Apr 10, 2013 at 04:11:51PM +0800, Dong Xu Wang wrote: This patch does two things: 1. Rename and move qcow2-cache to block-cache. 2. Add a type enum to parameterize BLKDEBUG_EVENT() for L2, refcount, and bitmaps. It's hard to review #2 since all lines are changed in the diff by #1. In t

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Michael S. Tsirkin
The following comment applies to all of this code: On Wed, Apr 17, 2013 at 07:07:17PM -0400, mrhi...@linux.vnet.ibm.com wrote: > diff --git a/migration-rdma.c b/migration-rdma.c > new file mode 100644 > index 000..1dff06f > --- /dev/null > +++ b/migration-rdma.c > @@ -0,0 +1,2667 @@ > +/* > +

[Qemu-devel] [PULL 0/4] pci: add pci test device

2013-04-18 Thread Michael S. Tsirkin
The following changes since commit e2ec3f976803b360c70d9ae2ba13852fa5d11665: qjson: to_json() case QTYPE_QSTRING is buggy, rewrite (2013-04-13 19:40:25 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony for you to fetch change

[Qemu-devel] [PATCH 1/4] kvm: remove unused APIs

2013-04-18 Thread Michael S. Tsirkin
There are only used internally now, move them out of header and out of stub. Signed-off-by: Michael S. Tsirkin --- include/sysemu/kvm.h | 4 -- kvm-all.c| 107 ++- kvm-stub.c | 10 - 3 files changed, 54 insertions(+), 6

[Qemu-devel] [PATCH 3/4] kvm: support non datamatch ioeventfd

2013-04-18 Thread Michael S. Tsirkin
Adding restrictions just adds code. Signed-off-by: Michael S. Tsirkin --- kvm-all.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 589e37c..ce823f9 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -501,21 +501,24 @@ i

[Qemu-devel] [PATCH 2/4] kvm: support any size for pio eventfd

2013-04-18 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- kvm-all.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index ca9775d..589e37c 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -500,8 +500,8 @@ int kvm_check_extension(KVMState *s, unsigned int

[Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-18 Thread Michael S. Tsirkin
This device is used for kvm unit tests, currently it supports testing performance of ioeventfd. Using updated kvm unittest, here's an example output: mmio-no-eventfd:pci-mem 8796 mmio-wildcard-eventfd:pci-mem 3609 mmio-datamatch-eventfd:pci-mem 3685 portio-no-eventfd

[Qemu-devel] [PATCH 2/5] console: Hook QemuConsoles into qom tree

2013-04-18 Thread Gerd Hoffmann
Put them named "console[$index]" below "/backend", so you can list & inspect them via QMP. Signed-off-by: Gerd Hoffmann --- ui/console.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/ui/console.c b/ui/console.c index e9f3080..b92bde3 100644 --- a/ui/console.c +++ b/ui/console

[Qemu-devel] [PATCH 1/5] console: qom-ify QemuConsole

2013-04-18 Thread Gerd Hoffmann
Just the minimal bits to turn QemuConsoles into Objects. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 15 +++ ui/console.c | 15 ++- 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/include/ui/console.h b/include/ui/console.h index e59

[Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command

2013-04-18 Thread Gerd Hoffmann
Hi, This patch qom-ifies the QemuConsoles and adds an new, optional parameter to the screendump command to specify the device you want dump from. Question for the QOM guys: where in the tree should the QemuConsoles show up? I can't find anything in the tree doing this. I've placed them below

[Qemu-devel] [PATCH 5/5] console: extend screendump monitor cmd

2013-04-18 Thread Gerd Hoffmann
Add an optional device parameter to the screendump command. https://bugzilla.redhat.com/show_bug.cgi?id=903910 Signed-off-by: Gerd Hoffmann --- hmp-commands.hx |6 +++--- hmp.c|3 ++- qapi-schema.json |4 +++- qmp-commands.hx |3 ++- ui/console.c | 17 +++

Re: [Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions

2013-04-18 Thread Igor Mammedov
On Thu, 18 Apr 2013 10:41:56 +0200 Igor Mammedov wrote: [...] > > -if (!bus) { > > -bus = sysbus_get_default(); > > -} > > - > I've checked all direct childs of TYPE_DEVICE and they all set k->bus_type, > with only one exception of TYPE_CPU. So it should be safe to remove fallback

[Qemu-devel] [PATCH 4/5] console: add qemu_console_lookup_by_device

2013-04-18 Thread Gerd Hoffmann
Look up the QemuConsole for a given device, using the new link. Signed-off-by: Gerd Hoffmann --- include/ui/console.h |1 + ui/console.c | 19 +++ 2 files changed, 20 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index 22670d8..c74e791 1006

[Qemu-devel] [PATCH 3/5] console: add device link to QemuConsoles

2013-04-18 Thread Gerd Hoffmann
So it is possible to figure which qemu console displays which device. Signed-off-by: Gerd Hoffmann --- hw/arm/musicpal.c|2 +- hw/display/blizzard.c|2 +- hw/display/cirrus_vga.c |4 ++-- hw/display/exynos4210_fimd.c |2 +- hw/display/g364fb.c |

Re: [Qemu-devel] 'id' assigned to -device could not be set as net-client name (was Re: Nic devices' name are wrongly repeated)

2013-04-18 Thread KONRAD Frédéric
On 18/04/2013 10:19, Amos Kong wrote: On Wed, Apr 10, 2013 at 02:28:40PM +0200, Andreas Färber wrote: Hi, Am 10.04.2013 14:05, schrieb Amos Kong: If we don't assign 'id' for nic device, device name will be $model.$idx. The $idx are always 0 if we set nic by new style. # qemu-upstream -device

Re: [Qemu-devel] [PATCH 10/12] cpu: Pass CPUState to *cpu_synchronize_post*()

2013-04-18 Thread Gleb Natapov
On Tue, Apr 16, 2013 at 02:46:47AM +0200, Andreas Färber wrote: > From: Igor Mammedov > > ... so it could be called without requiring CPUArchState. > > Signed-off-by: Igor Mammedov > Reviewed-by: Eduardo Habkost > Signed-off-by: Andreas Färber Acked-by: Gleb Natapov > --- > cpus.c

Re: [Qemu-devel] [PATCH v19 4/7] pvpanic: pass configurable ioport to seabios

2013-04-18 Thread Markus Armbruster
Hu Tao writes: > This lets seabios patch the corresponding SSDT entry. > > Signed-off-by: Hu Tao > --- > hw/misc/pvpanic.c | 14 ++ > hw/nvram/fw_cfg.c | 8 +++- > include/hw/nvram/fw_cfg.h | 2 ++ > 3 files changed, 23 insertions(+), 1 deletion(-) > > diff --g

[Qemu-devel] [PATCH] savevm: Improve error message for unmigratable devices

2013-04-18 Thread Kevin Wolf
Trying to take an internal snapshot when an unmigratable device is in use resuled in an 'Error -22 while writing VM' message. This patch changes it to print the same error message as migration would print: 'State blocked by non-migratable device xyz' Signed-off-by: Kevin Wolf --- savevm.c | 17 +

Re: [Qemu-devel] [PATCH v19 3/7] introduce a new qom device to deal with panicked event

2013-04-18 Thread Markus Armbruster
Hu Tao writes: > pvpanic device is used to send guest panic event from guest to qemu. > > When guest panic happens, pvpanic device driver will write a event > number to IO port 0x505(which is the IO port occupied by pvpanic device, > by default). On receiving the event, pvpanic device will pause

Re: [Qemu-devel] reply: reply: qemu crashed when starting vm(kvm) with vnc connect

2013-04-18 Thread Gerd Hoffmann
On 04/11/13 11:29, Stefan Hajnoczi wrote: > On Mon, Apr 08, 2013 at 12:27:06PM +, Zhanghaoyu (A) wrote: >> On Sun, Apr 07, 2013 at 04:58:07AM +, Zhanghaoyu (A) wrote: >> I start a kvm VM with vnc(using the zrle protocol) connect, sometimes >> qemu program crashed during starting pe

Re: [Qemu-devel] GDB function call failing due to memory protection of stack page in QEMU

2013-04-18 Thread Abid, Hafiz
On 18/04/13 09:36:55, Peter Maydell wrote: > There are 2 possible solution in my mind. One was to allow writing memory if > this page originally had write access. This is a single line fix and a patch > is below. My worry here is that this will mean that writes by the debugger won't trigger

Re: [Qemu-devel] [PATCH v4 0/5] usb: QOM realize support for SysBus EHCI and FUSBH200

2013-04-18 Thread Gerd Hoffmann
On 04/10/13 14:31, Andreas Färber wrote: > Am 25.02.2013 18:06, schrieb Andreas Färber: >> Hello Gerd, >> >> v4 fixes the bus naming by leaving usb_bus_new() in realize for now. >> A mid-term fix will be to rework (q)bus initialization. > > Ping? Can you resend please? /me finds only patches 1-3

Re: [Qemu-devel] [PATCH 0/1] ehci_free_packet: Discard finished packets when the queue is halted v3

2013-04-18 Thread Gerd Hoffmann
On 04/09/13 10:24, Hans de Goede wrote: > And here is a v3 fixing a whitespace issue in v2, sorry about the noise. Patch added to usb patch queue. thanks, Gerd

Re: [Qemu-devel] 'id' assigned to -device could not be set as net-client name (was Re: Nic devices' name are wrongly repeated)

2013-04-18 Thread Amos Kong
On Thu, Apr 18, 2013 at 11:12:56AM +0200, KONRAD Frédéric wrote: > On 18/04/2013 10:19, Amos Kong wrote: > >On Wed, Apr 10, 2013 at 02:28:40PM +0200, Andreas Färber wrote: > >>Hi, > >> > >>Am 10.04.2013 14:05, schrieb Amos Kong: > >>>If we don't assign 'id' for nic device, device name will be $mode

[Qemu-devel] hw/usb/host-libusb.c:1254:217: error: ‘LIBUSB_LOG_LEVEL_WARNING’ undeclared here (not in a function)

2013-04-18 Thread Michael Tokarev
The error in $subject is spewed when trying to compile current qemu code on my debian wheezy system. /usr/include/libusb-1.0/libusb.h does not define any LIBUSB_LOG_LEVEL* constants. libusb-1.0-0 on my system is of version 1.0.11. Should we define some minimum libusb-1.0 version requiriment, or

Re: [Qemu-devel] hw/usb/host-libusb.c:1254:217: error: ‘LIBUSB_LOG_LEVEL_WARNING’ undeclared here (not in a function)

2013-04-18 Thread Peter Maydell
On 18 April 2013 10:40, Michael Tokarev wrote: > The error in $subject is spewed when trying to compile current > qemu code on my debian wheezy system. > > /usr/include/libusb-1.0/libusb.h does not define any LIBUSB_LOG_LEVEL* > constants. libusb-1.0-0 on my system is of version 1.0.11. > > Shoul

Re: [Qemu-devel] hw/usb/host-libusb.c:1254:217: error: ‘LIBUSB_LOG_LEVEL_WARNING’ undeclared here (not in a function)

2013-04-18 Thread Gerd Hoffmann
On 04/18/13 11:40, Michael Tokarev wrote: > The error in $subject is spewed when trying to compile current > qemu code on my debian wheezy system. > > /usr/include/libusb-1.0/libusb.h does not define any LIBUSB_LOG_LEVEL* > constants. libusb-1.0-0 on my system is of version 1.0.11. > > Should we

Re: [Qemu-devel] [PATCH V18 5/6] add-cow file format core code.

2013-04-18 Thread Stefan Hajnoczi
On Wed, Apr 10, 2013 at 04:11:52PM +0800, Dong Xu Wang wrote: > +header.cluster_bits = ffs(cluster_size) - 1; > +if (header.cluster_bits < MIN_CLUSTER_BITS || > +header.cluster_bits > MAX_CLUSTER_BITS || > +(1 << header.cluster_bits) != cluster_size) { > +error_repor

Re: [Qemu-devel] 'id' assigned to -device could not be set as net-client name (was Re: Nic devices' name are wrongly repeated)

2013-04-18 Thread KONRAD Frédéric
On 18/04/2013 11:47, Amos Kong wrote: On Thu, Apr 18, 2013 at 11:12:56AM +0200, KONRAD Frédéric wrote: On 18/04/2013 10:19, Amos Kong wrote: On Wed, Apr 10, 2013 at 02:28:40PM +0200, Andreas Färber wrote: Hi, Am 10.04.2013 14:05, schrieb Amos Kong: If we don't assign 'id' for nic device, dev

Re: [Qemu-devel] [PATCH V18 0/6] add-cow file format

2013-04-18 Thread Stefan Hajnoczi
On Wed, Apr 10, 2013 at 04:11:47PM +0800, Dong Xu Wang wrote: > It will introduce a new file format: add-cow. > > The add-cow file format makes it possible to perform copy-on-write on top of > a raw disk image. When we know that no backing file clusters remain visible > (e.g. we have streamed the

Re: [Qemu-devel] qemu-iotests 042: zero size image on VMDK

2013-04-18 Thread Fam Zheng
On Thu, 04/18 09:39, Stefan Hajnoczi wrote: > On Thu, Apr 18, 2013 at 03:08:55PM +0800, Fam Zheng wrote: > > Currently VMDK block driver fails qemu-iotest case 042 because it > > refuses to create block with zero size (silently). Is support for zero > > size image desired or should this case be ski

[Qemu-devel] [PATCH] usb-host: raise libusbx minimum version to 1.0.13

2013-04-18 Thread Gerd Hoffmann
Allows to remove one FIXME. Makes LIBUSB_LOG_LEVEL_WARNING build errors go away. And starting with that version libusb has a LIBUSBX_API_VERSION define which allows to easily #ifdef version dependencies should that need arrive in the future. Signed-off-by: Gerd Hoffmann --- configure

[Qemu-devel] [PATCH] usb: better speed mismatch error reporting

2013-04-18 Thread Gerd Hoffmann
Report the supported speeds for device and port in the error message. Also add the speeds to the tracepoint. And while being at it drop the redundant error message in usb_desc_attach, usb_device_attach will report the error anyway. Signed-off-by: Gerd Hoffmann --- hw/usb/bus.c | 36 +

Re: [Qemu-devel] [PATCH 11/11] savevm: remove backward compatibility from bdrv_snapshot_find()

2013-04-18 Thread Pavel Hrdina
On 18.4.2013 06:31, Wenchao Xia wrote: 于 2013-4-18 2:14, Eric Blake 写道: On 04/17/2013 04:51 AM, Pavel Hrdina wrote: On 17.4.2013 12:19, Wenchao Xia wrote: 于 2013-4-17 15:52, Pavel Hrdina 写道: Hi Wenchao, unfortunately no. According to new design of savevm, loadvm and delvm I need also search

Re: [Qemu-devel] [PATCH v3 6/7] virtio-net: cleanup: use QOM cast.

2013-04-18 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 04:30:01PM +0200, fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > As the virtio-net-pci and virtio-net-s390 are switched to the new API, > we can use QOM casts. > > Signed-off-by: KONRAD Frederic > --- > hw/net/virtio-net.c| 141 > +

Re: [Qemu-devel] [PATCH v5 0/3] DTC as submodule

2013-04-18 Thread Edgar E. Iglesias
On Thu, Apr 18, 2013 at 02:45:35PM +1000, peter.crosthwa...@xilinx.com wrote: > From: Peter Crosthwaite > > These two patches add and use dtc as a submodule as per the RFC: > > http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg05000.html > > There is a remaining action item to mandate lib

Re: [Qemu-devel] [PATCH 07/11] qapi: Convert loadvm

2013-04-18 Thread Pavel Hrdina
On 17.4.2013 01:43, Eric Blake wrote: On 04/16/2013 10:05 AM, Pavel Hrdina wrote: QMP command vm-snapshot-load and HMP command loadvm behave similar to vm-snapshot-delete and delvm. The only different is that they will load the snapshot instead of deleting it. Signed-off-by: Pavel Hrdina ---

Re: [Qemu-devel] [PATCH] savevm: Improve error message for unmigratable devices

2013-04-18 Thread Pavel Hrdina
On 18.4.2013 11:23, Kevin Wolf wrote: Trying to take an internal snapshot when an unmigratable device is in use resuled in an 'Error -22 while writing VM' message. This patch changes it to print the same error message as migration would print: 'State blocked by non-migratable device xyz' Signed-

[Qemu-devel] [PATCH] target-i386: upgrade family number of qemu64 CPU model to 15

2013-04-18 Thread Ren, Yongjie
qemu64 is the default CPU model for QEMU/KVM on x86-64, but its family number definition is not accurate. The vendor of 'qemu64' is defined as 'AMD'. For AMD processors, AMD K8 (i.e. Family 15) firstly introduced SSE3 instruction set. 'qemu64' already has 'CPUID_EXT_SSE3' in its ext_features, bu

Re: [Qemu-devel] Question to prefered

2013-04-18 Thread Stefano Stabellini
On Thu, 11 Apr 2013, Sander Eikelenboom wrote: > > No. It depends a bit what you mean by "verbose debugging", > > incidentally. QEMU has several commonly used logging options: > > Well since Xen has the option to be build with "make debug=y" which also > disables optimizations, enables extra asse

Re: [Qemu-devel] [PATCH 1/1 V6] VMWare PVSCSI paravirtual device implementation

2013-04-18 Thread Paolo Bonzini
Il 18/04/2013 11:38, Dmitry Fleytman ha scritto: > > > +static void > > +pvscsi_free_queue(PVSCSIRequestList *req_list) > > This shouldn't be needed. > > > > Doesn't one need to clear completion queue on reset command arrival from > driver? > It should happen in qbus_reset_all.

Re: [Qemu-devel] qemu-iotests 042: zero size image on VMDK

2013-04-18 Thread Stefan Hajnoczi
On Thu, Apr 18, 2013 at 12:08 PM, Fam Zheng wrote: > On Thu, 04/18 09:39, Stefan Hajnoczi wrote: >> On Thu, Apr 18, 2013 at 03:08:55PM +0800, Fam Zheng wrote: >> > Currently VMDK block driver fails qemu-iotest case 042 because it >> > refuses to create block with zero size (silently). Is support f

Re: [Qemu-devel] [PATCH v5 0/3] DTC as submodule

2013-04-18 Thread Paolo Bonzini
Il 18/04/2013 12:26, Edgar E. Iglesias ha scritto: > On Thu, Apr 18, 2013 at 02:45:35PM +1000, peter.crosthwa...@xilinx.com wrote: >> From: Peter Crosthwaite >> >> These two patches add and use dtc as a submodule as per the RFC: >> >> http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg05000.h

Re: [Qemu-devel] [PATCH v19 3/7] introduce a new qom device to deal with panicked event

2013-04-18 Thread Paolo Bonzini
Il 18/04/2013 11:23, Markus Armbruster ha scritto: > Hu Tao writes: > >> pvpanic device is used to send guest panic event from guest to qemu. >> >> When guest panic happens, pvpanic device driver will write a event >> number to IO port 0x505(which is the IO port occupied by pvpanic device, >> by

Re: [Qemu-devel] [PATCH v8] sheepdog: add discard/trim support for sheepdog

2013-04-18 Thread Stefan Hajnoczi
Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] target-i386: upgrade family number of qemu64 CPU model to 15

2013-04-18 Thread Gleb Natapov
On Thu, Apr 18, 2013 at 10:45:38AM +, Ren, Yongjie wrote: > qemu64 is the default CPU model for QEMU/KVM on x86-64, but its family number > definition is not accurate. The vendor of 'qemu64' is defined as 'AMD'. For > AMD > processors, AMD K8 (i.e. Family 15) firstly introduced SSE3 instruct

Re: [Qemu-devel] [PATCH v5 0/3] DTC as submodule

2013-04-18 Thread Edgar E. Iglesias
On Thu, Apr 18, 2013 at 01:02:41PM +0200, Paolo Bonzini wrote: > Il 18/04/2013 12:26, Edgar E. Iglesias ha scritto: > > On Thu, Apr 18, 2013 at 02:45:35PM +1000, peter.crosthwa...@xilinx.com > > wrote: > >> From: Peter Crosthwaite > >> > >> These two patches add and use dtc as a submodule as per

Re: [Qemu-devel] [PATCH v5 0/3] DTC as submodule

2013-04-18 Thread Peter Maydell
On 18 April 2013 12:08, Edgar E. Iglesias wrote: > On Thu, Apr 18, 2013 at 01:02:41PM +0200, Paolo Bonzini wrote: >> For submodules that do have autoconf-generated scripts in the repository >> (I think both of them do, in our case), we should trust upstream's >> configure script. That's what ever

Re: [Qemu-devel] [PATCH v5 0/3] DTC as submodule

2013-04-18 Thread Paolo Bonzini
Il 18/04/2013 13:08, Edgar E. Iglesias ha scritto: >> > For submodules that do have autoconf-generated scripts in the repository >> > (I think both of them do, in our case), we should trust upstream's >> > configure script. That's what everyone has been testing the git >> > repository with. > I do

[Qemu-devel] [PATCH] allow usage of older libusb which didn't define LIBUSB_LOG_LEVEL_WARNING

2013-04-18 Thread Michael Tokarev
Older libusb does not have any LIBUSB_LOG_LEVEL_* definitions. Since we expose these values as integers anyway, just use the right define if the constant isn't defined. Signed-off-by: Michael Tokarev --- hw/usb/host-libusb.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/usb/host-l

Re: [Qemu-devel] qemu-iotests 042: zero size image on VMDK

2013-04-18 Thread Fam Zheng
On Thu, 04/18 13:02, Stefan Hajnoczi wrote: > On Thu, Apr 18, 2013 at 12:08 PM, Fam Zheng wrote: > > On Thu, 04/18 09:39, Stefan Hajnoczi wrote: > >> On Thu, Apr 18, 2013 at 03:08:55PM +0800, Fam Zheng wrote: > >> > Currently VMDK block driver fails qemu-iotest case 042 because it > >> > refuses t

[Qemu-devel] reply: reply: reply: qemu crashed when starting vm(kvm) with vnc connect

2013-04-18 Thread Zhanghaoyu (A)
> > On Mon, Apr 08, 2013 at 12:27:06PM +, Zhanghaoyu (A) wrote: > >> On Sun, Apr 07, 2013 at 04:58:07AM +, Zhanghaoyu (A) wrote: > >> I start a kvm VM with vnc(using the zrle protocol) connect, sometimes > >> qemu program crashed during starting period, received signal SIGABRT. > >

Re: [Qemu-devel] [PATCH] allow usage of older libusb which didn't define LIBUSB_LOG_LEVEL_WARNING

2013-04-18 Thread Peter Maydell
On 18 April 2013 12:17, Michael Tokarev wrote: > diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c > index 29f35b3..78c315f 100644 > --- a/hw/usb/host-libusb.c > +++ b/hw/usb/host-libusb.c > @@ -1251,6 +1251,9 @@ static Property usb_host_dev_properties[] = { > DEFINE_PROP_UINT32("isobu

Re: [Qemu-devel] [PATCH] allow usage of older libusb which didn't define LIBUSB_LOG_LEVEL_WARNING

2013-04-18 Thread Peter Maydell
On 18 April 2013 12:17, Michael Tokarev wrote: > +#ifndef LIBUSB_LOG_LEVEL_WARNING /* older libusb didn't define these */ > +#define LIBUSB_LOG_LEVEL_WARNING 2 > +#endif By the way, where these are provided by the header, they're provided as an enum, not #defined constants. So we'll always #defin

Re: [Qemu-devel] [PATCH v2] net: make network client name unique

2013-04-18 Thread Stefan Hajnoczi
On Mon, Apr 15, 2013 at 06:55:19PM +0800, Amos Kong wrote: > assign_name() creates a name MODEL.NUM, where MODEL is the client's model, > and NUM is the number of MODELs that already exist. > > Markus added NIC naming for non-VLAN clients in commit 53e51d85. > commit d33d93b2 incorrectly added a j

[Qemu-devel] [PATCH] net/hub: remove can_receive handler

2013-04-18 Thread Sergey Fedorov
Network hub should always receive incoming packets. Then forward them to the appropriate port queue and let the qemu_send_packet() do the right things. If the destination queue cannot receive the packet it will be appended to the queue. When the receiver call qemu_flush_queued_packets() later the q

Re: [Qemu-devel] [PATCH] savevm: Improve error message for unmigratable devices

2013-04-18 Thread Kevin Wolf
Am 18.04.2013 um 12:43 hat Pavel Hrdina geschrieben: > On 18.4.2013 11:23, Kevin Wolf wrote: > >Trying to take an internal snapshot when an unmigratable device is in > >use resuled in an 'Error -22 while writing VM' message. This patch > >changes it to print the same error message as migration woul

Re: [Qemu-devel] [PATCH v3 6/7] virtio-net: cleanup: use QOM cast.

2013-04-18 Thread KONRAD Frédéric
On 18/04/2013 10:41, Michael S. Tsirkin wrote: On Thu, Apr 11, 2013 at 04:30:01PM +0200, fred.kon...@greensocs.com wrote: From: KONRAD Frederic As the virtio-net-pci and virtio-net-s390 are switched to the new API, we can use QOM casts. Signed-off-by: KONRAD Frederic --- hw/net/virtio-net.

Re: [Qemu-devel] [PATCH 00/15] block: Overriding the backing file with -drive

2013-04-18 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 10:47:53PM +0200, Kevin Wolf wrote: > This is the next part of the driver-specific options. Looks like we're getting > closer to pass file descriptors for the whole backing file chain. In fact, I > hope we're now only lacking QMP support before we can actually use it. :-) >

Re: [Qemu-devel] [PATCH 01/11] qemu-img: introduce qemu_img_handle_error()

2013-04-18 Thread Kevin Wolf
Am 16.04.2013 um 18:05 hat Pavel Hrdina geschrieben: > Later in the patch series we will use this function few times. > This will avoid of duplicating the code. > > Signed-off-by: Pavel Hrdina > --- > qemu-img.c | 17 +++-- > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff

[Qemu-devel] [PATCH] sheepdog: implement .bdrv_co_is_allocated

2013-04-18 Thread Liu Yuan
From: Liu Yuan Cc: MORITA Kazutaka Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- NOTE: This patch based on the previous discard path block/sheepdog.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index

Re: [Qemu-devel] [PATCH v5 0/3] DTC as submodule

2013-04-18 Thread Edgar E. Iglesias
On Thu, Apr 18, 2013 at 02:45:35PM +1000, peter.crosthwa...@xilinx.com wrote: > From: Peter Crosthwaite > > These two patches add and use dtc as a submodule as per the RFC: > > http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg05000.html > > There is a remaining action item to mandate lib

Re: [Qemu-devel] [PATCH 01/11] qemu-img: introduce qemu_img_handle_error()

2013-04-18 Thread Pavel Hrdina
On 18.4.2013 13:44, Kevin Wolf wrote: Am 16.04.2013 um 18:05 hat Pavel Hrdina geschrieben: Later in the patch series we will use this function few times. This will avoid of duplicating the code. Signed-off-by: Pavel Hrdina --- qemu-img.c | 17 +++-- 1 file changed, 11 insertions

Re: [Qemu-devel] [PATCH v5 0/3] DTC as submodule

2013-04-18 Thread Edgar E. Iglesias
On Thu, Apr 18, 2013 at 12:10:54PM +0100, Peter Maydell wrote: > On 18 April 2013 12:08, Edgar E. Iglesias wrote: > > On Thu, Apr 18, 2013 at 01:02:41PM +0200, Paolo Bonzini wrote: > >> For submodules that do have autoconf-generated scripts in the repository > >> (I think both of them do, in our c

[Qemu-devel] Is Qemu now support x2apic in TCG mode?

2013-04-18 Thread puckbee
Hi there: Is there somebody can tell me that if qemu can support x2apic now? I've seen the x2apic in the definition of cpu flags, but can not find any implementation about x2apic. Thanks a lot if somebody can give me some hints~ puck 2013.4.18

Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command

2013-04-18 Thread Eric Blake
On 04/18/2013 03:01 AM, Gerd Hoffmann wrote: > Hi, > > This patch qom-ifies the QemuConsoles and adds an new, optional > parameter to the screendump command to specify the device you > want dump from. > > Question for the QOM guys: where in the tree should the QemuConsoles > show up? I can't f

Re: [Qemu-devel] [PATCH 1/1 V6] VMWare PVSCSI paravirtual device implementation

2013-04-18 Thread Dmitry Fleytman
On Thu, Apr 18, 2013 at 1:54 PM, Paolo Bonzini wrote: > Il 18/04/2013 11:38, Dmitry Fleytman ha scritto: > > > > > +static void > > > +pvscsi_free_queue(PVSCSIRequestList *req_list) > > > > This shouldn't be needed. > > > > > > > > Doesn't one need to clear completion queue on reset c

Re: [Qemu-devel] [PATCH v3 6/7] virtio-net: cleanup: use QOM cast.

2013-04-18 Thread Michael S. Tsirkin
On Thu, Apr 18, 2013 at 01:34:17PM +0200, KONRAD Frédéric wrote: > >>@@ -618,9 +614,10 @@ static void virtio_net_handle_rx(VirtIODevice *vdev, > >>VirtQueue *vq) > >> static int virtio_net_can_receive(NetClientState *nc) > >> { > >> VirtIONet *n = qemu_get_nic_opaque(nc); > >>+VirtIODev

[Qemu-devel] KVM VM(windows xp) reseted when running geekbench for about 2 days

2013-04-18 Thread Zhanghaoyu (A)
I start 10 VMs(windows xp), then running geekbench tool on them, about 2 days, one of them was reset, I found the reset operation is done by int kvm_cpu_exec(CPUArchState *env) { ... switch (run->exit_reason) ... case KVM_EXIT_SHUTDOWN: DPRINTF("shutdown\n");

Re: [Qemu-devel] [PATCH v3 6/7] virtio-net: cleanup: use QOM cast.

2013-04-18 Thread Anthony Liguori
KONRAD Frédéric writes: > On 18/04/2013 10:41, Michael S. Tsirkin wrote: >> BTW this is data path so was supposed to use the faster non-QOM casts. >> Also in other places below. This was applied meanwhile, but maybe we >> could revert the relevant chunks? Or maybe everyone who cares about >> sp

Re: [Qemu-devel] KVM VM(windows xp) reseted when running geekbench for about 2 days

2013-04-18 Thread Gleb Natapov
On Thu, Apr 18, 2013 at 12:00:49PM +, Zhanghaoyu (A) wrote: > I start 10 VMs(windows xp), then running geekbench tool on them, about 2 > days, one of them was reset, > I found the reset operation is done by > int kvm_cpu_exec(CPUArchState *env) > { > ... >switch (run->exit_reason)

Re: [Qemu-devel] [PATCH 02/11] block: update error reporting for bdrv_snapshot_delete() and related functions

2013-04-18 Thread Kevin Wolf
Am 16.04.2013 um 18:05 hat Pavel Hrdina geschrieben: > > Signed-off-by: Pavel Hrdina > --- > block.c | 22 ++ > block/qcow2-snapshot.c| 21 +++-- > block/qcow2.h | 4 +++- > block/rbd.c | 11 --- > block

Re: [Qemu-devel] [PATCH 0/3] another round of qemu-char fixes

2013-04-18 Thread Gerd Hoffmann
Hi, > Hmm, this seems to be recursive locking. It sounded unlikely, but then > googling for "glib gsource finalize unlock" led to this: > https://mail.gnome.org/archives/commits-list/2010-November/msg01816.html > If this is RHEL6, you or Amit should file > a bug. Yes, it's RHEL-6. Filed bug

Re: [Qemu-devel] [PATCH 01/11] qemu-img: introduce qemu_img_handle_error()

2013-04-18 Thread Kevin Wolf
Am 18.04.2013 um 13:52 hat Pavel Hrdina geschrieben: > On 18.4.2013 13:44, Kevin Wolf wrote: > >Am 16.04.2013 um 18:05 hat Pavel Hrdina geschrieben: > >>Later in the patch series we will use this function few times. > >>This will avoid of duplicating the code. > >> > >>Signed-off-by: Pavel Hrdina

Re: [Qemu-devel] [RFC/PATCH 1/1] s390: implement CPU hotplug

2013-04-18 Thread Igor Mammedov
On Wed, 3 Apr 2013 08:42:25 +0200 Jens Freimann wrote: > From: Thang Pham > [...] > > @@ -31,25 +34,152 @@ static inline S390SCLPDevice *get_event_facility(void) > static void read_SCP_info(SCCB *sccb) > { > ReadInfo *read_info = (ReadInfo *) sccb; > +int cpu_count = standby_cpus

Re: [Qemu-devel] [PATCH 0/3] another round of qemu-char fixes

2013-04-18 Thread Paolo Bonzini
Il 18/04/2013 08:14, Gerd Hoffmann ha scritto: > Thread 1 (Thread 0x7f9038188980 (LWP 27849)): > ---Type to continue, or q to quit--- > #0 __lll_lock_wait () at > ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:136 > #1 0x7f90366a9388 in _L_lock_854 () from /lib64/libpthread.so.0 > #2

Re: [Qemu-devel] [PATCH 7/7] use libusb for usb-host

2013-04-18 Thread Markus Armbruster
Gerd Hoffmann writes: > Reimplement usb-host on top of libusb. > Reasons to do this: > > (1) Largely rewritten from scratch, nice opportunity to kill historical > cruft. > (2) Offload usbfs handling to libusb. > (3) Have a single portable code base instead of bsd + linux variants. > (4)

Re: [Qemu-devel] [PATCH 02/11] block: update error reporting for bdrv_snapshot_delete() and related functions

2013-04-18 Thread Eric Blake
On 04/18/2013 06:55 AM, Kevin Wolf wrote: > Am 16.04.2013 um 18:05 hat Pavel Hrdina geschrieben: >> >> Signed-off-by: Pavel Hrdina >> --- >> >> -int bdrv_snapshot_delete(BlockDriverState *bs, const char *snapshot_id) >> +void bdrv_snapshot_delete(BlockDriverState *bs, >> +

Re: [Qemu-devel] [PATCH 01/11] qemu-img: introduce qemu_img_handle_error()

2013-04-18 Thread Pavel Hrdina
On 18.4.2013 14:59, Kevin Wolf wrote: Am 18.04.2013 um 13:52 hat Pavel Hrdina geschrieben: On 18.4.2013 13:44, Kevin Wolf wrote: Am 16.04.2013 um 18:05 hat Pavel Hrdina geschrieben: Later in the patch series we will use this function few times. This will avoid of duplicating the code. Signed-

  1   2   3   >