On Thu, Mar 21, 2013 at 10:53:21AM -0400, Alon Levy wrote:
> > I am planning on bringing in the virtualbox svga card into kvm
> > as a new svga card type (vbox probably?) so that we can load
> > the VirtualBox SVGA card drivers in the guest.
I'm curious if the vbox SVGA card has fea
pvpanic device is used to notify host(qemu) when guest panic happens.
Signed-off-by: Paolo Bonzini
Signed-off-by: Hu Tao
---
No change from v16. qemu patches at:
http://lists.nongnu.org/archive/html/qemu-devel/2013-04/msg01028.html
src/acpi.c| 3 +++
src/ssdt-misc.dsl | 46 +
On Tue, Apr 02, 2013 at 12:02:52PM -0400, Elizabeth Brown wrote:
> I was wondering if anyone could help me by setting up a wiki account for me?
Done.
Stefan
pvpanic device is a qemu simulated device through which guest panic
event is sent to host.
Signed-off-by: Hu Tao
---
ref: http://lists.nongnu.org/archive/html/qemu-devel/2013-04/msg01028.html
drivers/platform/x86/Kconfig | 7 +++
drivers/platform/x86/Makefile | 2 +
drivers/platform/x86
>> -#else
>> ; /* nothing */
>> -#endif
>> } else {
>> /* we don't get update notifications, thus use the
>> * sledge hammer approach ... */
>
> You might as well remove the if () nothing; case.
Yep, will do.
>> @@ -785,6 +755,20 @@ static void xenfb_update(void *opaque)
>>
The character backend refactoring introduced an undesirable busy wait.
The busy wait happens if can_read returns zero and there is data available
on the character device's file descriptor. Then, the I/O watch will
fire continuously and, with TCG, the CPU thread will never run.
1) Char backend
On 5 April 2013 05:28, liguang wrote:
> define struct IRQState in irq.c bring in
> a annoying result, if you want dereference of
> IRQState's member like opaque outside of
> irq.c, compiler will complain:
> "error: dereferencing pointer to incomplete type"
No, this is deliberate -- it's an opaque
On 5 April 2013 05:28, liguang wrote:
> here, we will handle power state transition between
> on, off, suspend, wakeup, we treat reset as power
> on then off, and power out pin will be connected to
> power in pin of devices, if we want a transition,
> we will trigger a power signal(qemu_irq), then
在 2013-04-05五的 09:34 +0100，Peter Maydell写道：
> On 5 April 2013 05:28, liguang wrote:
> > define struct IRQState in irq.c bring in
> > a annoying result, if you want dereference of
> > IRQState's member like opaque outside of
> > irq.c, compiler will complain:
> > "error: dereferencing pointer to in
On s390 the disabled wait state indicates a state of attention.
For example Linux uses that state after a panic. Lets
put the system into panicked state.
An alternative implementation would be to state
disabled-wait instead of pause in the action field.
(e.g. z/OS, z/VM and other classic OSes use
Hi All. This is a new scheme i've come up with handling device registers in a
data driven way. My motivation for this is to factor out a lot of the access
checking that seems to be replicated in every device. See P2 commit message for
further discussion.
P1 is a trivial addition to bitops.h
P2 is
From: Peter A. G. Crosthwaite
Signed-off-by: Peter A. G. Crosthwaite
---
Changed since v1:
Added manual parenting of devcfg node (evil but needed for early access
to canonical path by devcfgs realize fn).
hw/arm/xilinx_zynq.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
d
On 5 April 2013 09:43, Peter Crosthwaite wrote:
> Little macro that just gives you N ones (justified to LSB).
>
> Signed-off-by: Peter Crosthwaite
> ---
>
> include/qemu/bitops.h |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/qemu/bitops.h b/include/qemu/b
Add memory io handlers that glue the register API to the memory API.
Just translation functions at this stage. Although it does allow for
devices to be created without all-in-one mmio r/w handlers.
Signed-off-by: Peter Crosthwaite
---
include/exec/register.h | 13 +
register.c
Little macro that just gives you N ones (justified to LSB).
Signed-off-by: Peter Crosthwaite
---
include/qemu/bitops.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h
index affcc96..da47fc8 100644
--- a/include/qemu/bitops.
Sent from Samsung tablet
在 2013-04-05五的 09:35 +0100，Peter Maydell写道：
> On 5 April 2013 05:28, liguang wrote:
> > here, we will handle power state transition between
> > on, off, suspend, wakeup, we treat reset as power
> > on then off, and power out pin will be connected to
> > power in pin of devices, if we want a transi
From: Peter A. G. Crosthwaite
Minimal device model for devcfg module of Zynq. DMA capabilities and
interrupt generation supported.
Signed-off-by: Peter A. G. Crosthwaite
---
Changed since v1:
Rebased against new version of Register API.
Use action callbacks for side effects rather than switch.
On 04/04/2013 06:47 PM, Alexander Graf wrote:
> On -M mac99, we can run 970 CPUs. However, these CPUs define the initial
> instruction pointer they start execution at as part of their bootup protocol,
> so effectively it's up to the board to decide where they start.
>
> This went unnoticed, because
Hi Peter,
On Fri, Apr 5, 2013 at 6:53 PM, Peter Maydell wrote:
> On 5 April 2013 09:43, Peter Crosthwaite wrote:
>> Little macro that just gives you N ones (justified to LSB).
>>
>> Signed-off-by: Peter Crosthwaite
>> ---
>>
>> include/qemu/bitops.h |2 ++
>> 1 files changed, 2 insertions(
This API provides some encapsulation of registers and factors our some
common functionality to common code. Bits of device state (usually MMIO
registers), often have all sorts of access restrictions and semantics
associated with them. This API allow you to define what those
restrictions are on a bi
On 04/04/2013 07:22 PM, Andreas Färber wrote:
> Am 04.04.2013 18:26, schrieb Artyom Tarasenko:
>> On Thu, Apr 4, 2013 at 6:20 PM, Peter Maydell
>> wrote:
>>> On 4 April 2013 17:17, Fabien Chouteau wrote:
>>>
>>> But -kernel for QEMU specifically means Linux kernel; you might
>>> argue we should
On 5 April 2013 09:45, li guang wrote:
> 在 2013-04-05五的 09:35 +0100，Peter Maydell写道：
>> What actual hardware is this supposed to be modelling?
>> I don't believe there's such a thing as a 'generic
>> power controller' that makes sense for all architectures.
>
> unfortunately, I'm considering it as
On 5 April 2013 10:11, Peter Crosthwaite wrote:
> But I thought about this more, and perhaps just ditch the ? anyway,
> and rely on the shift by 64 ending up as 0.
That's undefined behaviour, please don't.
-- PMM
On 5 April 2013 09:43, Peter Crosthwaite wrote:
> This API provides some encapsulation of registers and factors our some
> common functionality to common code. Bits of device state (usually MMIO
> registers), often have all sorts of access restrictions and semantics
> associated with them. This AP
We now require spice-server to be >= 0.12.0 so this is no longer needed.
Signed-off-by: Hans de Goede
---
spice-qemu-char.c | 27 +--
1 file changed, 1 insertion(+), 26 deletions(-)
diff --git a/spice-qemu-char.c b/spice-qemu-char.c
index 535f955..c4f81cf 100644
--- a/sp
This is necessary so that we get properly woken up to write the rest.
This patch also changes the len argument to the have_data callback, to
avoid doing an unsigned signed comparison.
Signed-off-by: Hans de Goede
Acked-by: Amit Shah
---
hw/virtio-console.c | 8 +---
hw/virtio-serial.h | 2
Hi Gerd,
Here is v4 of the series adding watch support to the spicevmc chardev
backend. This version resolved all outstanding discussions about this
patch-set, can you please include these in your next spice pull-req to
Anthony?
Note this also includes a few virtio-consoled bugfixes which were fo
Signed-off-by: Hans de Goede
---
hw/virtio-console.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index 61f9ff5..908ec17 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-console.c
@@ -18,6 +18,7 @@
typedef
usb-serial has a qdev chardev property, and hw/qdev-properties-system.c
already contains:
static void release_chr(Object *obj, const char *name, void *opaque)
{
DeviceState *dev = DEVICE(obj);
Property *prop = opaque;
CharDriverState **ptr = qdev_get_prop_ptr(dev, prop);
CharDriver
From: Alon Levy
virtio-serial's buffer is valid when it calls us, and we don't
access it otherwise: vmc_read is only called in response to wakeup,
or else we set datalen=0 and throttle. Then vmc_read is called back,
we return 0 (not accessing the buffer) and set the timer to unthrottle.
Also mak
Signed-off-by: Hans de Goede
---
spice-qemu-char.c | 67 +++
1 file changed, 63 insertions(+), 4 deletions(-)
diff --git a/spice-qemu-char.c b/spice-qemu-char.c
index c4f81cf..097a8c8 100644
--- a/spice-qemu-char.c
+++ b/spice-qemu-char.c
@@ -1
On 5 April 2013 10:19, Fabien Chouteau wrote:
> If the -kernel option is for Linux only, we have to rename it to -linux.
> And we remove the ambiguous -kernel option.
This isn't possible, for backwards compatibility reasons. We
have to retain -kernel/-initrd/-append under those names.
> And I ma
Am 04.04.2013 um 18:50 hat Josh Durgin geschrieben:
> On 04/04/2013 03:10 AM, Kevin Wolf wrote:
> >After searching the net a bit and trying out some things myself, I'm
> >afraid that this approach doesn't work. It does seem to do the right
> >thing when build and runtime version are the same, but n
Benoît Canet reported that QEMU I/O throttling can
oscillate under continuous I/O. The test case runs 50 threads performing
random writes and a -drive iops=150 limit is used.
Since QEMU I/O throttling is implemented using 100 millisecond time slices,
we'd expect 150 +/- 15 IOPS. Anything outsid
The wait_time variable is in seconds. Reflect this in a comment and use
NANOSECONDS_PER_SECOND instead of BLOCK_IO_SLICE_TIME * 10 (which
happens to have the right value).
Signed-off-by: Stefan Hajnoczi
Tested-By: Benoit Canet
---
block.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletion
I/O throttling relies on bdrv_acct_done() which is called when a request
completes. This leaves a blind spot since we only charge for completed
requests, not submitted requests.
For example, if there is 1 operation remaining in this time slice the
guest could submit 3 operations and they will all
It is not necessary to adjust the slice time at runtime. We already
extend the current slice in order to carry over accounting into the next
slice. Changing the actual slice time value introduces oscillations.
The guest may experience large changes in throughput or IOPS from one
moment to the ne
Hello all,
I have written a patch for the ARM TCG that prints the program counter and any
load/store addresses for every instruction that's run. We use this feature to
get detailed traces of our ARM programs.
We can tidy up and submit the patch; is there any interest in this feature?
Japheth L
Ah, there was a discussion where a better solution was supposed to be found.
Maybe a new try is needed with the argumentation that it doesn't make the
current code worse at all:
http://lists.gnu.org/archive/html/qemu-devel/2011-04/msg00742.html
--
You received this bug notification because you
Bard, are you going to submit the patch for inclusion in qemu?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/752476
Title:
monitor command mouse_button 1 moves mouse
Status in QEMU:
New
Bug des
This one took me eons to debug, but I've finally found it now, oh well.
The usage of the MIN macro in this line:
last_out = MIN(len, qemu_chr_be_can_write(scd->chr));
Causes qemu_chr_be_can_write to be called *twice*, since the MIN macro
evaluates its arguments twice (bad MIN macro, bad!). An
The current slice is extended when an I/O request exceeds the limit.
There is no need to extend the slice every time we check a request.
Signed-off-by: Stefan Hajnoczi
Tested-By: Benoit Canet
---
block.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/block.c b/block.c
i
On Fri, Apr 5, 2013 at 7:26 PM, Peter Maydell wrote:
> On 5 April 2013 09:43, Peter Crosthwaite wrote:
>> This API provides some encapsulation of registers and factors our some
>> common functionality to common code. Bits of device state (usually MMIO
>> registers), often have all sorts of access
On 5 April 2013 07:59, Japheth Lim wrote:
> I have written a patch for the ARM TCG that prints the program
> counter and any load/store addresses for every instruction that's
> run. We use this feature to get detailed traces of our ARM programs.
>
> We can tidy up and submit the patch; is there an
What is the highest addressable sector on an empty CD-ROM? Nothing is
addressable so produce an error.
This patch prevents a divide-by-zero in ide_set_sector() since
s->sectors and s->heads would be 0. Not to mention that a sector=-1
argument would be nonsense.
Note that WIN_READ_NATIVE_MAX can
The only change here is to use g_get_user_name from glib, rebasing
against latest git, and to re-test everything still works.
Rich.
From: "Richard W.M. Jones"
Signed-off-by: Richard W.M. Jones
---
tests/qemu-iotests/common| 5 +
tests/qemu-iotests/common.rc | 3 +++
2 files changed, 8 insertions(+)
diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common
index b3aad89..6826ea7 100644
--- a/tests/qemu-iote
From: "Richard W.M. Jones"
qemu-system-x86_64 -drive file=ssh://hostname/some/image
QEMU will ssh into 'hostname' and open '/some/image' which is made
available as a standard block device.
You can specify a username (ssh://user@host/...) and/or a port number
(ssh://host:port/...). You can al
On Fri, 5 Apr 2013, Gerd Hoffmann wrote:
> >> -#else
> >>; /* nothing */
> >> -#endif
> >> } else {
> >>/* we don't get update notifications, thus use the
> >> * sledge hammer approach ... */
> >
> > You might as well remove the if () nothing; case.
>
> Yep, will do.
>
> >> @@ -
Il 05/04/2013 10:43, Peter Crosthwaite ha scritto:
> Add memory io handlers that glue the register API to the memory API.
> Just translation functions at this stage. Although it does allow for
> devices to be created without all-in-one mmio r/w handlers.
>
> Signed-off-by: Peter Crosthwaite
> ---
This commit delays the point at which bdrv_new (and hence blk_open
on the underlying device) is called from blk_init to blk_connect.
This ensures that in an inbound live migrate, the block device is
not opened until it has been closed at the other end. This is in
preparation for supporting devices
Due to what is almost certainly a kernel bug, writes with O_DIRECT may
continue to reference the page after the write has been marked as
completed, particularly in the case of TCP retransmit. In other
scenarios, this "merely" risks data corruption on the write, but with
Xen pages from domU are only
Due to what is almost certainly a kernel bug, writes with O_DIRECT may
continue to reference the page after the write has been marked as
completed, particularly in the case of TCP retransmit. In other
scenarios, this "merely" risks data corruption on the write, but with
Xen pages from domU are only
This commit delays the point at which bdrv_new (and hence blk_open
on the underlying device) is called from blk_init to blk_connect.
This ensures that in an inbound live migrate, the block device is
not opened until it has been closed at the other end. This is in
preparation for supporting devices
Stefano,
--On 2 April 2013 12:08:25 +0100 Stefano Stabellini
wrote:
I'll redo and move setting sector-size and sectors into blk_connect, and
then add a second commit which removes BDRV_O_NOCACHE. Oh, and test it
...
Good :)
I've just sent patches for qemu-upstream-unstable and
qemu-upstr
Stefan Hajnoczi writes:
> What is the highest addressable sector on an empty CD-ROM? Nothing is
> addressable so produce an error.
>
> This patch prevents a divide-by-zero in ide_set_sector() since
> s->sectors and s->heads would be 0. Not to mention that a sector=-1
> argument would be nonsens
It ignored the error code, and at least the 'goto fail' is obvious
nonsense as it creates an endless loop (if the next attempt doesn't
magically succeed) and leaves the in-memory L1 table in big-endian
instead of converting it back.
In error cases, there's no point in writing an updated L1 table,
This fixes the error message triggered by the following script:
cat > /tmp/blkdebug.cfg <
---
block/qcow2-refcount.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index c38e970..4799681 100644
--- a/block/qcow2-
Apart from the patch missing a Signed-off-by, I have doubts whether
reusing the coordinates from the last monitor command is generally
correct. It should rather be the current coordinates, whether set by
monitor or via VNC/SDL, I guess.
--
You received this bug notification because you are a memb
Il 05/04/2013 08:36, Hu Tao ha scritto:
> Also parse command line options for ioport and set
> it accordingly.
This does not do the correct thing for versioned machine types like "-M
pc-1.4". Also, adding stuff to vl.c is really something you cannot do.
Please don't be afraid to ask!
See the at
Kevin Wolf (2):
qcow2: Return real error in qcow2_update_snapshot_refcount
qcow2: Fix L1 write error handling in qcow2_update_snapshot_refcount
block/qcow2-refcount.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
--
1.8.1.4
On 04/05/13 01:22, Kevin O'Connor wrote:
> On Thu, Apr 04, 2013 at 09:52:31AM +0200, Laszlo Ersek wrote:
>> On 04/03/13 22:05, Anthony Liguori wrote:
>>> Laszlo Ersek writes:
Any chance patches 01 to 09 could be considered? Esp. 06 which removes
an out-of-bounds access (an innocent-looki
Il 05/04/2013 09:10, Hu Tao ha scritto:
> pvpanic device is a qemu simulated device through which guest panic
> event is sent to host.
>
> Signed-off-by: Hu Tao
Reviewed-by: Paolo Bonzini
Matthew, it would be nice to include this in 3.10.
The implementation of the device in QEMU is final, the
Il 05/04/2013 06:28, liguang ha scritto:
> Signed-off-by: liguang
> ---
> vl.c |4
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index aeed7f4..a14549e 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -171,6 +171,8 @@ int main(int argc, char **argv)
> #include
I think the right fix would be to remember the last position in
ui/input.c, and use a new function kbd_mouse_button_event. mouse_move,
followed by moving the mouse in the UI, followed by mouse_button 5
minutes later should not remember the position of the first mouse_move.
Also, mouse_move should
On Fri, Apr 05, 2013 at 12:56:07PM +0200, Markus Armbruster wrote:
> Stefan Hajnoczi writes:
>
> > What is the highest addressable sector on an empty CD-ROM? Nothing is
> > addressable so produce an error.
> >
> > This patch prevents a divide-by-zero in ide_set_sector() since
> > s->sectors and
Am 05.04.2013 um 11:32 hat Stefan Hajnoczi geschrieben:
> Benoît Canet reported that QEMU I/O throttling can
> oscillate under continuous I/O. The test case runs 50 threads performing
> random writes and a -drive iops=150 limit is used.
>
> Since QEMU I/O throttling is implemented using 100 mill
On Sun, Mar 31, 2013 at 01:02:24PM +0200, Aurelien Jarno wrote:
> Move aes.h from include/block to include/qemu to show it can be reused
> by other subsystems.
>
> Cc: Kevin Wolf
> Cc: Stefan Hajnoczi
> Reviewed-by: Edgar E. Iglesias
> Reviewed-by: Richard Henderson
> Signed-off-by: Aurelien J
Paolo Bonzini writes:
> The character backend refactoring introduced an undesirable busy wait.
> The busy wait happens if can_read returns zero and there is data available
> on the character device's file descriptor. Then, the I/O watch will
> fire continuously and, with TCG, the CPU thread will
On Thu, Mar 28, 2013 at 02:33:24PM +, Peter Maydell wrote:
> Pass the 'last' parameter of print_signal() through to
> print_raw_param(); this fixes a problem where we weren't printing
> the comma separator for strace of rt_sigaction() when the signal
> was an unnamed (ie realtime) one:
> 6856
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
On Sat, Mar 30, 2013 at 10:03:25AM -0700, Richard Henderson wrote:
> Fallthough into abort = oops.
>
> Cc: qemu-triv...@nongnu.org
> Cc: Alexander Graf
> Signed-off-by: Richard Henderson
> ---
> target-s390x/translate.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to the trivial pat
Paolo Bonzini writes:
> The character backend refactoring introduced an undesirable busy wait.
> The busy wait happens if can_read returns zero and there is data available
> on the character device's file descriptor. Then, the I/O watch will
> fire continuously and, with TCG, the CPU thread will
Stefan Hajnoczi writes:
> On Fri, Apr 05, 2013 at 12:56:07PM +0200, Markus Armbruster wrote:
>> Stefan Hajnoczi writes:
>>
>> > What is the highest addressable sector on an empty CD-ROM? Nothing is
>> > addressable so produce an error.
>> >
>> > This patch prevents a divide-by-zero in ide_set_
On Mon, Apr 01, 2013 at 09:21:57AM +0800, liguang wrote:
> if head magic is missing or wrong unexpectedly, we'd
> better to reject booting.
> e.g.
> I make a mistake to boot a vmlinuz for MIPS(which
> I think it's for x86) like this:
> qemu-system-x86_64 -kernel vmlinuz -initrd demord
> then qemu r
Il 05/04/2013 14:54, Anthony Liguori ha scritto:
> I guess this works with migration because we assume that after migration
> the main loop will do a complete run?
Yes, migration will terminate in an fd handler, and the next round of
the main loop will re-evaluate chr_read.
> Is this a safe assum
On Thu, Apr 04, 2013 at 11:03:14AM +1000, Peter Crosthwaite wrote:
> Trivial code cleanup of the PetaLogix and Zynq machine models.
>
>
> Peter Crosthwaite (2):
> petalogix_ml605_mmu: Cleanup ssi_create_slave()
> xilinx_zynq: Cleanup ssi_create_slave
>
> hw/arm/xilinx_zynq.c
On Thu, Apr 04, 2013 at 07:13:03PM -0400, Brendan Dolan-Gavitt wrote:
> In target-i386 cpu_get_phys_page_debug, the CR4_PAE bit is checked
> before CR0_PG. This means that if paging is disabled but the PAE bit has
> been set in CR4, cpu_get_phys_page_debug will return the wrong result
> (it will tr
From: "Richard W.M. Jones"
Note in order to run these tests on ssh, you must be running a local
ssh daemon, and that daemon must accept loopback connections, and
ssh-agent has to be set up to allow logins on the local daemon. In
other words, the following command should just work without demandi
On Fri, Apr 05, 2013 at 10:55:57AM +0100, Richard W.M. Jones wrote:
> The only change here is to use g_get_user_name from glib, rebasing
> against latest git, and to re-test everything still works.
Ignore v6. I just posted v7 on this list.
Rich.
--
Richard Jones, Virtualization Group, Red Hat
Since v6:
- This fixes a rather serious race condition in the previous versions,
which only manifested itself when using 'snapshot=on'.
- Store the attributes (like filesize) in the state.
- Macros for LOCK/UNLOCK to make debugging simpler.
- Added an ssh driver to libguestfs and tested with
From: "Richard W.M. Jones"
qemu-system-x86_64 -drive file=ssh://hostname/some/image
QEMU will ssh into 'hostname' and open '/some/image' which is made
available as a standard block device.
You can specify a username (ssh://user@host/...) and/or a port number
(ssh://host:port/...). You can al
The changes (since d05ef160453e98546a4197496dc8a3cb2defac53) are available
in the following repository:
git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
Luiz Capitulino (4):
qstring: add qstring_get_length()
Monitor: Make output buffer dynamic
hmp: human-monitor-command: stop using the
Long overdue.
Signed-off-by: Luiz Capitulino
Reviewed-by: Eric Blake
Acked-by: Gerd Hoffmann
---
include/qapi/qmp/qstring.h | 1 +
qobject/qstring.c | 8
2 files changed, 9 insertions(+)
diff --git a/include/qapi/qmp/qstring.h b/include/qapi/qmp/qstring.h
index 0e690f4..1bc3
Commit f628926bb423fa8a7e0b114511400ea9df38b76a changed monitor_flush()
to retry on qemu_chr_fe_write() errors. However, the Monitor's output
buffer can keep growing while the retry is not issued and this can
cause the buffer to overflow.
To reproduce this issue, just start qemu and type on the Mo
It's not used anymore since the last commit.
Signed-off-by: Luiz Capitulino
Reviewed-by: Eric Blake
Acked-by: Gerd Hoffmann
---
qemu-char.c | 64 -
1 file changed, 64 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index e5eb8dd.
The Memory chardev driver was added because, as the Monitor's output
buffer was static, we needed a way to accumulate the output of an
HMP commmand when ran by human-monitor-command.
However, the Monitor's output buffer is now dynamic, so it's possible
for the human-monitor-command to use it inste
On Fri, 05 Apr 2013 10:42:38 +0200
Christian Borntraeger wrote:
> On s390 the disabled wait state indicates a state of attention.
> For example Linux uses that state after a panic. Lets
> put the system into panicked state.
>
> An alternative implementation would be to state
> disabled-wait ins
From: Stefan Hajnoczi
The current slice is extended when an I/O request exceeds the limit.
There is no need to extend the slice every time we check a request.
Signed-off-by: Stefan Hajnoczi
Tested-By: Benoit Canet
Signed-off-by: Kevin Wolf
---
block.c | 5 +
1 file changed, 1 insertion(+
usb-storage takes care to fetch the USB serial number from -drive
options, but it neglected to pass its own 'serial' property to the
scsi-disk it creates. With this patch, the 'serial' qdev property and
the 'serial' option in -drive behave the same and correctly apply the
serial number on both USB
From: Stefan Hajnoczi
I/O throttling relies on bdrv_acct_done() which is called when a request
completes. This leaves a blind spot since we only charge for completed
requests, not submitted requests.
For example, if there is 1 operation remaining in this time slice the
guest could submit 3 oper
It ignored the error code, and at least the 'goto fail' is obvious
nonsense as it creates an endless loop (if the next attempt doesn't
magically succeed) and leaves the in-memory L1 table in big-endian
instead of converting it back.
In error cases, there's no point in writing an updated L1 table,
1 - 100 of 239 matches
Mail list logo
