Re: [Qemu-devel] [PATCH V10 12/17] hmp: add function hmp_info_snapshots()

2013-04-02 Thread Kevin Wolf
Am 30.03.2013 um 13:38 hat Wenchao Xia geschrieben: > 于 2013-3-30 7:04, Eric Blake 写道: > >On 03/22/2013 08:19 AM, Wenchao Xia wrote: > >> This function will simply call qmp interface qmp_query_snapshots() > >>added in last commit and then dump information in monitor console. > >> To get snapsho

Re: [Qemu-devel] [PATCH V10 17/17] hmp: add parameter device and -b for info block

2013-04-02 Thread Kevin Wolf
Am 29.03.2013 um 03:48 hat Wenchao Xia geschrieben: > 于 2013-3-28 19:09, Kevin Wolf 写道: > >Am 22.03.2013 um 15:19 hat Wenchao Xia geschrieben: > >> With these parameters, user can choose the information to be showed, > >>to avoid message flood in the montior. > >> > >>Signed-off-by: Wenchao Xia

Re: [Qemu-devel] [PATCH] PPC: e500: advertise 4.2 MPIC only if KVM supports EPR

2013-04-02 Thread Alexander Graf
On 30.03.2013, at 17:40, Stuart Yoder wrote: > From: Stuart Yoder Missing patch description > > Signed-off-by: Stuart Yoder > --- > hw/ppc/e500plat.c |5 + > 1 file changed, 5 insertions(+) > > diff --git a/hw/ppc/e500plat.c b/hw/ppc/e500plat.c > index 25ac4b1..2cd7cad 100644 > --- a

Re: [Qemu-devel] [PATCH 1/2] PPC: Remvove env->hreset_excp_prefix

2013-04-02 Thread Alexander Graf
On 29.03.2013, at 13:06, Fabien Chouteau wrote: > This value is not needed if we use correctly the MSR[IP] bit. > > excp_prefix is always 0x, except when the MSR[IP] bit is > implemented and set to 1, in that case excp_prefix is 0xfff0. > > The handling of MSR[IP] was already implem

Re: [Qemu-devel] [PATCH 2/2] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450

2013-04-02 Thread Alexander Graf
On 29.03.2013, at 13:06, Fabien Chouteau wrote: > According to the different user's manuals, the vector offset for system > reset (both /HRESET and /SRESET) is 0x00100. > > This patch may break support of some executables, as the power-on start > address may change. For a specific board, if the

Re: [Qemu-devel] [PATCH v2] target-ppc: fix nego and subf*o instructions

2013-04-02 Thread Alexander Graf
On 01.04.2013, at 02:33, Aurelien Jarno wrote: > The overflow computation of nego and subf*o instructions has been broken > in commit ffe30937. Contrary to other targets, the instruction is subtract > from an not subtract on PowerPC. > > This patch fixes the issue by using the correct argument i

Re: [Qemu-devel] [RFC PATCH 1/3] aio-context: if io_flush isn't provided, assume "always busy"

2013-04-02 Thread Kevin Wolf
Am 29.03.2013 um 00:37 hat Paolo Bonzini geschrieben: > Il 28/03/2013 22:52, Anthony Liguori ha scritto: > > Today, all callers of qemu_aio_set_fd_handler() pass a valid io_flush > > function. > > Except one: > > aio_set_event_notifier(ctx, &ctx->notifier, >(EventN

Re: [Qemu-devel] [RFC PATCH 2/3] sheepdog: pass NULL for io_flush

2013-04-02 Thread Kevin Wolf
Am 28.03.2013 um 22:52 hat Anthony Liguori geschrieben: > Signed-off-by: Anthony Liguori > --- > block/sheepdog.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/block/sheepdog.c b/block/sheepdog.c > index bb67c4c..2bccd9b 100644 > --- a/block/sheepdog.c > ++

Re: [Qemu-devel] [PATCH V10 11/17] qmp: add ImageInfo in BlockDeviceInfo used by query-block

2013-04-02 Thread Kevin Wolf
Am 29.03.2013 um 03:35 hat Wenchao Xia geschrieben: > 于 2013-3-28 17:54, Kevin Wolf 写道: > >Am 22.03.2013 um 15:19 hat Wenchao Xia geschrieben: > >> Now image info will be retrieved as an embbed json object inside > >>BlockDeviceInfo, backing chain info and all related internal snapshot > >>info c

Re: [Qemu-devel] [PATCH] append the terminating '\0' to bootorder string

2013-04-02 Thread Gerd Hoffmann
On 03/20/13 11:16, Amos Kong wrote: > Problem was introduced in commit c8a6ae8b. The last terminating > '\0' was lost, use the right length 5 ("HALT\0"). Acked-by: Gerd Hoffmann cheers, Gerd

Re: [Qemu-devel] [PATCH 2/2] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450

2013-04-02 Thread Fabien Chouteau
On 04/02/2013 10:09 AM, Alexander Graf wrote: > > On 29.03.2013, at 13:06, Fabien Chouteau wrote: > >> According to the different user's manuals, the vector offset for system >> reset (both /HRESET and /SRESET) is 0x00100. >> >> This patch may break support of some executables, as the power-on st

Re: [Qemu-devel] [PATCH V10 11/17] qmp: add ImageInfo in BlockDeviceInfo used by query-block

2013-04-02 Thread Wenchao Xia
于 2013-4-2 16:09, Kevin Wolf 写道: Am 29.03.2013 um 03:35 hat Wenchao Xia geschrieben: 于 2013-3-28 17:54, Kevin Wolf 写道: Am 22.03.2013 um 15:19 hat Wenchao Xia geschrieben: Now image info will be retrieved as an embbed json object inside BlockDeviceInfo, backing chain info and all related int

Re: [Qemu-devel] [PATCH 2/2] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450

2013-04-02 Thread Alexander Graf
On 02.04.2013, at 09:53, Fabien Chouteau wrote: > On 04/02/2013 10:09 AM, Alexander Graf wrote: >> >> On 29.03.2013, at 13:06, Fabien Chouteau wrote: >> >>> According to the different user's manuals, the vector offset for system >>> reset (both /HRESET and /SRESET) is 0x00100. >>> >>> This pat

[Qemu-devel] qemu crashed when starting vm(kvm) with vnc connect

2013-04-02 Thread Zhanghaoyu (A)
I start a kvm VM with vnc(using the zrle protocol) connect, sometimes qemu program crashed during starting period, received signal SIGABRT. Trying about 20 times, this crash may be reproduced. I guess the cause memory corruption or double free. The backtrace shown as below: 0x7f32eda3dd95 in

[Qemu-devel] [RFC PATCH] main-loop: Unconditionally unlock iothread

2013-04-02 Thread Peter Crosthwaite
Public bug: 1154328 Broken Commit: a29753f8aa79a34a324afebe340182a51a5aef11 ATM, the timeout from g_pollfds_fill is inhibiting unlocking of the iothread. This is capable of causing a total deadlock when hw/serial is used as a device. The bug manifests when you go -nographic -serial mon:stdio and t

Re: [Qemu-devel] [SeaBIOS] [PATCH v16] Add pvpanic device driver

2013-04-02 Thread Gleb Natapov
On Mon, Apr 01, 2013 at 08:22:57PM -0400, Kevin O'Connor wrote: > On Sun, Mar 31, 2013 at 05:34:10PM +0300, Gleb Natapov wrote: > > On Sat, Mar 30, 2013 at 09:20:09AM -0400, Kevin O'Connor wrote: > > > On Fri, Mar 29, 2013 at 02:49:12PM +0100, Paolo Bonzini wrote: > > > > Il 29/03/2013 14:33, Kevin

Re: [Qemu-devel] [PATCH 2/2] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450

2013-04-02 Thread Fabien Chouteau
On 04/02/2013 10:56 AM, Alexander Graf wrote: > > On 02.04.2013, at 09:53, Fabien Chouteau wrote: > >> On 04/02/2013 10:09 AM, Alexander Graf wrote: >>> >>> What about the other users of hreset_vector? Can we just remove the >>> variable altogether? >>> >> >> For the CPUs that don't implement MS

Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2013-04-02 Thread liu ping fan
On Fri, Jan 11, 2013 at 2:57 AM, Vasilis Liaskovitis wrote: >> > >> > IIRC q35 supports memory hotplug natively (picked up in some >> > discussion). Is that correct? >> > >> From previous discussion I also understand that q35 supports native hotplug. >> Sections 5.1 and 5.2 of the spec describe t

Re: [Qemu-devel] [PATCH 2/2] Monitor: Make output buffer dynamic

2013-04-02 Thread Gerd Hoffmann
On 03/27/13 07:45, Wenchao Xia wrote: > Hi, Luiz > Personally I hope reduce the dynamic allocated buffer which brings > fragments and unexpected memory grow. It's a tradeoff. We can reduce the dynamic allocation, by simply reusing the qstring instead of allocation a new one (after complete/part

Re: [Qemu-devel] [PATCH 0/2] Monitor: make output buffer dynamic

2013-04-02 Thread Gerd Hoffmann
On 03/25/13 20:40, Luiz Capitulino wrote: > This series fixes an easy to reproduce assertion in the Monitor code. The > second patch contains all the relevant details. > > Gerd, I'd like a reviewed-by from you before merging this. Series looks good to me. Reviewed-by: Gerd Hoffmann cheers, G

[Qemu-devel] [PATCH 1/2] po/Makefile: Fix dependency for %.mo

2013-04-02 Thread Kevin Wolf
Otherwise make will refuse to build updated .po files. Signed-off-by: Kevin Wolf --- po/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/po/Makefile b/po/Makefile index 8297ab5..60ccd7d 100644 --- a/po/Makefile +++ b/po/Makefile @@ -30,7 +30,7 @@ install: $(OBJS)

[Qemu-devel] [PATCH 0/2] More translation improvements

2013-04-02 Thread Kevin Wolf
This series is meant to be applied on top of Aurélien's series. Kevin Wolf (2): po/Makefile: Fix dependency for %.mo po: Update German translation po/Makefile | 2 +- po/de_DE.po | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) -- 1.8.1.4

[Qemu-devel] [PATCH 2/2] po: Update German translation

2013-04-02 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- po/de_DE.po | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/po/de_DE.po b/po/de_DE.po index 2566674..92c5df5 100644 --- a/po/de_DE.po +++ b/po/de_DE.po @@ -18,27 +18,27 @@ msgstr "" #: ../ui/gtk.c:213 msgid " - Press Ctrl+Alt+G to

Re: [Qemu-devel] [PATCH V10 11/17] qmp: add ImageInfo in BlockDeviceInfo used by query-block

2013-04-02 Thread Kevin Wolf
Am 02.04.2013 um 10:54 hat Wenchao Xia geschrieben: > 于 2013-4-2 16:09, Kevin Wolf 写道: > >Am 29.03.2013 um 03:35 hat Wenchao Xia geschrieben: > >>于 2013-3-28 17:54, Kevin Wolf 写道: > >>>Am 22.03.2013 um 15:19 hat Wenchao Xia geschrieben: > Now image info will be retrieved as an embbed json ob

Re: [Qemu-devel] [RFC PATCH v2 0/4] port network layer onto glib

2013-04-02 Thread liu ping fan
On Thu, Mar 28, 2013 at 9:40 PM, Stefan Hajnoczi wrote: > On Thu, Mar 28, 2013 at 09:42:47AM +0100, Paolo Bonzini wrote: >> Il 28/03/2013 08:55, Liu Ping Fan ha scritto: >> >3rd. block layer's AioContext will block other AioContexts on the same >> > thread. >> >> I cannot understand this. > >

Re: [Qemu-devel] [PATCH] acpi: initialize s4_val used in s4 shutdown

2013-04-02 Thread Gerd Hoffmann
On 04/01/13 18:57, Bruce Rogers wrote: > While investigating why a 32 bit Windows 2003 guest wasn't able to > successfully perform a shutdown /h, it was discovered that commit > afafe4bbe0cf7d3318e1ac7b40925561f86a6bd4 inadvertently dropped the > initialization of the s4_val used to handle s4 shutd

Re: [Qemu-devel] [RFC PATCH 2/3] sheepdog: pass NULL for io_flush

2013-04-02 Thread Paolo Bonzini
> > diff --git a/block/sheepdog.c b/block/sheepdog.c > > index bb67c4c..2bccd9b 100644 > > --- a/block/sheepdog.c > > +++ b/block/sheepdog.c > > @@ -503,13 +503,6 @@ static void restart_co_req(void *opaque) > > qemu_coroutine_enter(co, NULL); > > } > > > > -static int have_co_req(void *opa

Re: [Qemu-devel] [PATCH 1/1] rng backend: open backend in blocking mode

2013-04-02 Thread Amit Shah
On (Mon) 01 Apr 2013 [09:02:46], Anthony Liguori wrote: > Amit Shah writes: > > > Opening backends in non-blocking mode isn't necessary, we don't do > > anything while waiting for data. > > > > This also excuses us from checking for EAGAIN, which for the default > > random backend, is a very comm

Re: [Qemu-devel] [PATCH 1/7] virtio-console: Also throttle when less was written then requested

2013-04-02 Thread Amit Shah
On (Mon) 01 Apr 2013 [18:00:55], Hans de Goede wrote: > Hi, > > On 03/29/2013 10:31 AM, Amit Shah wrote: > >On (Thu) 28 Mar 2013 [14:28:11], Hans de Goede wrote: > >>This is necessary so that we get properly woken up to write the rest. > >> > >>Signed-off-by: Hans de Goede > >>Acked-by: Amit Shah

[Qemu-devel] [PATCH] vga.c: Debug messages go to stderr

2013-04-02 Thread Alex DAMIAN
From: Alexandru DAMIAN Move debug messages to stderr since often in vga code debug stdio is used as serial console. Signed-off-by: Alexandru DAMIAN --- hw/vga.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/vga.c b/hw/vga.c index 59bfb22..2

Re: [Qemu-devel] [PATCH] [RFC] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect

2013-04-02 Thread Stefano Stabellini
On Mon, 1 Apr 2013, Alex Bligh wrote: > Stefano, > > --On 1 April 2013 16:44:05 +0100 Stefano Stabellini > wrote: > > >> Note this patch is compile-tested only. > > > > I think the patch looks good, just a minor comment. > > Thanks. I guess I ought to actually test it works then :-) > > >> +

Re: [Qemu-devel] [RFC PATCH] main-loop: Unconditionally unlock iothread

2013-04-02 Thread Paolo Bonzini
Il 02/04/2013 11:04, Peter Crosthwaite ha scritto: > Public bug: 1154328 > Broken Commit: a29753f8aa79a34a324afebe340182a51a5aef11 > > ATM, the timeout from g_pollfds_fill is inhibiting unlocking of the > iothread. This is capable of causing a total deadlock when hw/serial > is used as a device. T

Re: [Qemu-devel] [PATCH 13/16] IPMI: Add an external connection simulation interface

2013-04-02 Thread Zang Hongyong
What's the status of the IPMI patch? When will be merged into qemu? With this patch, an external watchdog can be used for VM HA, even through qemu is not healthy. This is more attractive to qemu's own watchdog (ib700 or 6300esb). On 2012/9/19 4:00, miny...@acm.org wrote: > From: Corey Minyard > >

[Qemu-devel] [PATCH 0/2 V3] virtio-spec/net: dynamic network offloads configuration

2013-04-02 Thread Dmitry Fleytman
From: Dmitry Fleytman V3 changes: 1. Compat macro added 2. Feature name beautification V2 changes: 1. _GUEST_ added to command and feature names 2. Live migration logic fixed Reported-by: Michael S. Tsirkin One of recently introduced Windows features (RSC) requires network driver to b

[Qemu-devel] [PATCH 1/2 V3] virtio-spec: dynamic network offloads configuration

2013-04-02 Thread Dmitry Fleytman
From: Dmitry Fleytman Virtio-net driver currently negotiates network offloads on startup via features mechanism and have no ability to change offloads state later. This patch introduced a new control command that allows to configure device network offloads state dynamically. The patch also introd

[Qemu-devel] [PATCH 2/2 V3] virtio-net: dynamic network offloads configuration

2013-04-02 Thread Dmitry Fleytman
From: Dmitry Fleytman Virtio-net driver currently negotiates network offloads on startup via features mechanism and have no ability to change offloads state later. This patch introduced a new control command that allows to configure device network offloads state dynamically. The patch also introd

[Qemu-devel] [PATCH V11 03/17] qemu-img: remove unused parameter in collect_image_info()

2013-04-02 Thread Wenchao Xia
Parameter *fmt was not used, so remove it. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf --- qemu-img.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 31627b0..937ec01 100644 --- a/qemu-img.c +++ b/qemu-

[Qemu-devel] [PATCH V11 01/17] block: move bdrv_snapshot_find() to block/snapshot.c

2013-04-02 Thread Wenchao Xia
This patch adds block/snapshot.c and then moves the function there. It also fixes small code style errors reported by check script. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf --- block/Makefile.objs |1 + block/snapshot.c | 48 ++

[Qemu-devel] [PATCH V11 00/17] qmp/hmp interfaces for internal snapshot info

2013-04-02 Thread Wenchao Xia
In the use of snapshot a way to retrieve related info at runtime is needed, so this serial of patches will merge some code for qemu and qemu-img, and add or enchance following interfaces for qemu: 1) qmp: query-block, show info for a block device include image info Example: -> { "execute": "quer

[Qemu-devel] [PATCH V11 02/17] block: distinguish id and name in bdrv_find_snapshot()

2013-04-02 Thread Wenchao Xia
To make it clear about id and name in searching, the API is changed a bit to distinguish them, and caller can choose to search by id or name. Searching will be done with higher priority of id. This function also returns negative value from bdrv_snapshot_list() instead of -ENOENT on error now. Si

[Qemu-devel] [PATCH V11 04/17] block: move collect_snapshots() and collect_image_info() to block/qapi.c

2013-04-02 Thread Wenchao Xia
This patch adds block/qapi.c and moves the functions there. To avoid conflict and tip better, macro in header file is BLOCK_QAPI_H instead of QAPI_H. The moving is for making review easier, those functions will be modified and renamed later. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake R

[Qemu-devel] [PATCH V11 05/17] block: add snapshot info query function bdrv_query_snapshot_info_list()

2013-04-02 Thread Wenchao Xia
This patch adds function bdrv_query_snapshot_info_list(), which will retrieve snapshot info of an image in qmp object format. The implementation is based on the code moved from qemu-img.c with modification to fit more for qmp based block layer API. Signed-off-by: Wenchao Xia --- block/qapi.c

[Qemu-devel] [PATCH V11 07/17] block: add image info query function bdrv_query_image_info()

2013-04-02 Thread Wenchao Xia
This patch adds function bdrv_query_image_info(), which will retrieve image info in qmp object format. The implementation is based on the code moved from qemu-img.c, but uses block layer function to get snapshot info. Signed-off-by: Wenchao Xia --- block/qapi.c | 41 +

[Qemu-devel] [PATCH V11 08/17] block: move qmp_query_block() and bdrv_query_info() to block/qapi.c

2013-04-02 Thread Wenchao Xia
This is a code move patch, except in qmp_query_block bdrv_next(bs) is used instead of direct traverse of global array 'bdrv_states'. This patch also fix code style error reported by check script. Signed-off-by: Wenchao Xia Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake --- block.c

[Qemu-devel] [PATCH V11 10/17] qmp: add recursive member in ImageInfo

2013-04-02 Thread Wenchao Xia
New member *backing-image is added to reflect the backing chain status. Signed-off-by: Wenchao Xia Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake --- block/qapi.c |6 +- qapi-schema.json |5 - 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/block/qapi.c b/

[Qemu-devel] [PATCH V11 06/17] block: add check for VM snapshot in bdrv_query_snapshot_info_list()

2013-04-02 Thread Wenchao Xia
This patch adds a parameter to tell whether return valid snapshots for whole VM only. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf --- block/qapi.c | 39 +-- include/block/qapi.h |1 + qemu-img.c |3

[Qemu-devel] [PATCH V11 11/17] qmp: add ImageInfo in BlockDeviceInfo used by query-block

2013-04-02 Thread Wenchao Xia
Now image info will be retrieved as an embbed json object inside BlockDeviceInfo, backing chain info and all related internal snapshot info can be got in the enhanced recursive structure of ImageInfo. Signed-off-by: Wenchao Xia --- block/qapi.c | 38 ++-- incl

[Qemu-devel] [PATCH V11 12/17] block: move bdrv_snapshot_dump() and dump_human_image_info() to block/qapi.c

2013-04-02 Thread Wenchao Xia
They are needed later in hmp command, dump_human_image_info() is renamed to bdrv_image_info_dump(). Signed-off-by: Wenchao Xia --- block.c | 33 block/qapi.c | 100 + include/block/block.h |1 - incl

[Qemu-devel] [PATCH V11 17/17] hmp: add parameters device and -v for info block

2013-04-02 Thread Wenchao Xia
With these parameters, user can choose the information to be showed, to avoid message flood in the montior. Signed-off-by: Wenchao Xia --- hmp.c | 34 -- monitor.c |7 --- 2 files changed, 24 insertions(+), 17 deletions(-) diff --git a/hmp.c b/hmp

[Qemu-devel] [PATCH V11 14/17] hmp: add function hmp_info_snapshots()

2013-04-02 Thread Wenchao Xia
This function will simply call qmp interface qmp_query_snapshots() added in last commit and then dump information in monitor console. To get snapshot info, Now qemu and qemu-img both call block layer function bdrv_query_snapshot_info_list() in their calling path, and then they just translate th

[Qemu-devel] [PATCH V11 13/17] block: dump to buffer for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-04-02 Thread Wenchao Xia
This patch would allow hmp use them just like qemu-img, and avoid string truncation. Signed-off-by: Wenchao Xia --- block/qapi.c | 65 +++--- include/block/qapi.h |4 +- qemu-img.c | 22 savevm.c

[Qemu-devel] [PATCH V11 15/17] hmp: switch snapshot info function to qmp based one

2013-04-02 Thread Wenchao Xia
This patch using new added function in last commit which retrieve info from qmp for snapshot info. Signed-off-by: Wenchao Xia Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake --- monitor.c |2 +- savevm.c | 69 - 2 files chang

[Qemu-devel] [PATCH V11 16/17] hmp: show ImageInfo in 'info block'

2013-04-02 Thread Wenchao Xia
Now human monitor can show image details include internal snapshot info for every block device. Signed-off-by: Wenchao Xia --- hmp.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/hmp.c b/hmp.c index 89e1aaf..6f93fcd 100644 --- a/hmp.c +++ b/hmp.

Re: [Qemu-devel] [PATCH 0/2 V3] virtio-spec/net: dynamic network offloads configuration

2013-04-02 Thread Michael S. Tsirkin
On Tue, Apr 02, 2013 at 02:38:58PM +0300, Dmitry Fleytman wrote: > From: Dmitry Fleytman > > V3 changes: > 1. Compat macro added > 2. Feature name beautification > > V2 changes: > 1. _GUEST_ added to command and feature names > 2. Live migration logic fixed > > Reported-by: Michael S. T

Re: [Qemu-devel] [PATCH] vga.c: Debug messages go to stderr

2013-04-02 Thread Gerd Hoffmann
On 04/02/13 12:53, Alex DAMIAN wrote: > From: Alexandru DAMIAN > > Move debug messages to stderr since often in vga code debug > stdio is used as serial console. Make them tracepoints would be even better ... cheers, Gerd

[Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots

2013-04-02 Thread Wenchao Xia
This interface returns info of valid internal snapshots for whole vm. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf --- block/qapi.c | 17 qapi-schema.json | 14 + qmp-commands.hx | 55 ++

Re: [Qemu-devel] [PATCH-v2 0/3] virtio/vhost: Add checks for uninitialized VQs

2013-04-02 Thread Michael S. Tsirkin
On Mon, Apr 01, 2013 at 11:58:21PM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi folks, > > This series adds a virtio_queue_valid() for use by virtio-pci code in > order to prevent opreations upon uninitialized VQs, which is currently > expected to occur during seabios se

Re: [Qemu-devel] [PATCH v4 0/7] virtio-serial refactoring.

2013-04-02 Thread Peter Maydell
On 29 March 2013 09:02, wrote: > From: KONRAD Frederic > > This is the next part of virtio-refactoring. > > Basically it creates virtio-serial device which extends virtio-device. > Then a virtio-serial can be connected on a virtio-bus. > virtio-serial-pci, virtio-serial-s390 and virtio-serial-cc

[Qemu-devel] [Patch] v2 fix /proc/self/maps output

2013-04-02 Thread Christophe Lyon
Add a space at end of line when there is no filename to print, to conform to linux kernel format (see show_map_vma() in fs/proc/task_mmu.c). Signed-off-by: Christophe Lyon --- Changes v1-v2: Additional space is now part of the format string. linux-user/syscall.c |4 ++-- 1 file changed, 2

Re: [Qemu-devel] vNVRAM / blobstore design

2013-04-02 Thread Michael S. Tsirkin
On Sun, Mar 31, 2013 at 04:48:24PM -0400, Kenneth Goldman wrote: > "Michael S. Tsirkin" wrote on 03/31/2013 04:17:28 AM: > > > > You want to protect against someone who is able to > > manipulate some bits in the file (content) but not others (hash)? > > What's the attack you are trying to protect

[Qemu-devel] [Bug 1042388] Re: qemu: Unsupported syscall: 257 (timer_create)

2013-04-02 Thread LocutusOfBorg
Any news on this? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1042388 Title: qemu: Unsupported syscall: 257 (timer_create) Status in QEMU: Confirmed Bug description: Running qemu-arm-static

Re: [Qemu-devel] [PATCH 1/1] rng backend: open backend in blocking mode

2013-04-02 Thread Anthony Liguori
Amit Shah writes: > On (Mon) 01 Apr 2013 [09:02:46], Anthony Liguori wrote: >> Amit Shah writes: >> >> > Opening backends in non-blocking mode isn't necessary, we don't do >> > anything while waiting for data. >> > >> > This also excuses us from checking for EAGAIN, which for the default >> > r

Re: [Qemu-devel] [PATCH v4 0/7] virtio-serial refactoring.

2013-04-02 Thread Anthony Liguori
fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > This is the next part of virtio-refactoring. > > Basically it creates virtio-serial device which extends virtio-device. > Then a virtio-serial can be connected on a virtio-bus. > virtio-serial-pci, virtio-serial-s390 and virtio-serial-

Re: [Qemu-devel] KVM call agenda for 2013-04-02

2013-04-02 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please send in any agenda topics you are interested in. As there are no items, today call is cancelled. Happy hacking.

Re: [Qemu-devel] vNVRAM / blobstore design

2013-04-02 Thread Kenneth Goldman
> > You are of course correct. I advised an integrity value just to detect > > a hardware or software fault. The check value would not protect against an > > attack. > > Fair enough, but why protect these bits specifically? > E.g. disk corruption seems more likely (since it's bigger). Add > in

[Qemu-devel] [PATCH 2/2] xen-mapcache: pass the right size argument to test_bits

2013-04-02 Thread Stefano Stabellini
From: Hanweidong Compute the correct size for test_bits(). qemu_get_ram_ptr() and qemu_safe_ram_ptr() will call xen_map_cache() with size is 0 if the requested address is in the RAM. Then xen_map_cache() will pass the size 0 to test_bits() for checking if the corresponding pfn was mapped in cach

[Qemu-devel] [PATCH 1/2] xen-mapcache: replace last_address_index with a last_entry pointer

2013-04-02 Thread Stefano Stabellini
Replace last_address_index and last_address_vaddr with a single pointer to the last MapCacheEntry used. Signed-off-by: Stefano Stabellini --- xen-mapcache.c | 34 -- 1 files changed, 16 insertions(+), 18 deletions(-) diff --git a/xen-mapcache.c b/xen-mapcache.c

Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-04-02 Thread Michael S. Tsirkin
On Mon, Apr 01, 2013 at 06:05:47PM -0700, Nicholas A. Bellinger wrote: > On Fri, 2013-03-29 at 09:14 +0100, Paolo Bonzini wrote: > > Il 29/03/2013 03:53, Nicholas A. Bellinger ha scritto: > > > On Thu, 2013-03-28 at 06:13 -0400, Paolo Bonzini wrote: > > >>> I think it's the right thing to do, but

Re: [Qemu-devel] [Xen-devel] frequently ballooning results in qemu exit

2013-04-02 Thread Stefano Stabellini
On Tue, 2 Apr 2013, Hanweidong wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: 2013年4月1日 22:39 > > To: Hanweidong > > Cc: Stefano Stabellini; Tim (Xen.org); George Dunlap; Andrew Cooper; > > Yanqiangjun; qemu-devel@nongnu.org; x

Re: [Qemu-devel] [PATCH uq/master v2 1/2] kvm: reset state from the CPU's reset method

2013-04-02 Thread Gleb Natapov
On Fri, Mar 22, 2013 at 09:37:16PM +0100, Paolo Bonzini wrote: > Now that we have a CPU object with a reset method, it is better to > keep the KVM reset close to the CPU reset. Using qemu_register_reset > as we do now keeps them far apart. > > As a side effect, a CPU reset (cpu_reset) will reset

Re: [Qemu-devel] [PATCH] set usb bus name by busno.

2013-04-02 Thread Gerd Hoffmann
On 03/29/13 03:48, qiaochong wrote: > So when we add several usb buses on system, we can add usb device on > special usb bus by special usb bus name usb-bus.busno. Just name your usb host adapters using id (i.e. -device usb-ehci,id=foo). The usb bus name will be "${id}.0" then. cheers, Gerd

Re: [Qemu-devel] vNVRAM / blobstore design

2013-04-02 Thread Michael S. Tsirkin
On Tue, Apr 02, 2013 at 09:24:51AM -0400, Kenneth Goldman wrote: > > > You are of course correct. I advised an integrity value just to detect > > > a hardware or software fault. The check value would not protect against > > > an > > > attack. > > > > Fair enough, but why protect these bits speci

Re: [Qemu-devel] [PATCH v3 17/27] tcg-ppc64: Implement bswap64

2013-04-02 Thread Richard Henderson
On 2013-04-01 23:34, Alexander Graf wrote: Is this faster than a load/store with std/ldbrx? Hmm. Almost certainly not. And since we've got stack space allocated for function calls, we've got scratch space to do it in. Probably similar for bswap32 too, eh? I'll do a tiny bit o benchmarking f

[Qemu-devel] [PATCH] configure: QEMU_INCLUDES are the same for all subtargets

2013-04-02 Thread Paolo Bonzini
No need to put them in config-target.mak. Signed-off-by: Paolo Bonzini --- configure | 36 +--- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/configure b/configure index fbea75e..04c2618 100755 --- a/configure +++ b/configure @@ -3860,6 +3860,23

[Qemu-devel] [PATCH] qom: do nothing on unparent of object without parent

2013-04-02 Thread Paolo Bonzini
Otherwise, device_unparent will fail to get a canonical path of the object. Signed-off-by: Paolo Bonzini --- qom/object.c | 4 1 file changed, 4 insertions(+) diff --git a/qom/object.c b/qom/object.c index 8818149..093502e 100644 --- a/qom/object.c +++ b/qom/object.c @@ -362,6 +362,10 @@ s

Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable

2013-04-02 Thread Kevin Wolf
Am 01.04.2013 um 12:01 hat Wenchao Xia geschrieben: > Now code for external snapshot are packaged as one case > in qmp_transaction, so later other operation could be added. > The logic in qmp_transaction is changed a bit: Original code > tries to create all images first and then update all *bdr

Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction

2013-04-02 Thread Kevin Wolf
Am 01.04.2013 um 12:01 hat Wenchao Xia geschrieben: > Last operaton should be cancelled first. > > Signed-off-by: Wenchao Xia Should it? This commit message does little to convince me. Kevin

Re: [Qemu-devel] [PATCH v2] rbd: add an asynchronous flush

2013-04-02 Thread Kevin Wolf
Am 29.03.2013 um 21:03 hat Josh Durgin geschrieben: > The existing bdrv_co_flush_to_disk implementation uses rbd_flush(), > which is sychronous and causes the main qemu thread to block until it > is complete. This results in unresponsiveness and extra latency for > the guest. > > Fix this by using

[Qemu-devel] [PULL 0/5] qga: w32 guest-{set, get}-time implementations and minor fixes

2013-04-02 Thread Michael Roth
The following changes since commit 5d45de9796539f95eb6b1201588362981f8cb2d4: microblaze: Add support for the sleep insn (2013-04-02 10:47:29 +0200) are available in the git repository at: git://github.com/mdroth/qemu.git qga-pull-4-2-13 for you to fetch changes up to ce7f7cc2715145eadf1ac45

[Qemu-devel] [PATCH 3/5] qga schema: mark optional GuestLogicalProcessor.can-offline with #optional

2013-04-02 Thread Michael Roth
From: Laszlo Ersek Suggested-by: Eric Blake Signed-off-by: Laszlo Ersek Reviewed-by: Eric Blake Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- qga/qapi-schema.json |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema

[Qemu-devel] [PATCH 1/5] qga: add windows implementation for guest-get-time

2013-04-02 Thread Michael Roth
From: Lei Li Signed-off-by: Lei Li Reviewed-by: Eric Blake Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- qga/commands-win32.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index b19be

[Qemu-devel] [PATCH 4/5] qga schema: document generic QERR_UNSUPPORTED

2013-04-02 Thread Michael Roth
From: Laszlo Ersek Part of the wording was shamelessly stolen from Michael Roth's email. Suggested-by: Michael Roth Signed-off-by: Laszlo Ersek Reviewed-by: Eric Blake Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- qga/qapi-schema.json | 11 +++ 1 file changed, 11 inse

[Qemu-devel] [PATCH 2/5] qga: add windows implementation for guest-set-time

2013-04-02 Thread Michael Roth
From: Lei Li Signed-off-by: Lei Li Reviewed-by: Eric Blake Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- qga/commands-win32.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index d98e

[Qemu-devel] [PATCH 5/5] qemu-ga: ga_get_fd_handle(): abort if fd_counter overflows

2013-04-02 Thread Michael Roth
From: Luiz Capitulino Today we reset fd_counter if it wraps, but it's better to abort() instead, as fd_counter should never reach INT64_MAX. Signed-off-by: Luiz Capitulino Reviewed-by: Eric Blake *fixed typo: s/resonable/reasonable/ Signed-off-by: Michael Roth --- qga/main.c |8 ++-

Re: [Qemu-devel] [PULL 6/6] Monitor: Make output buffer dynamic

2013-04-02 Thread Luiz Capitulino
On Mon, 01 Apr 2013 10:35:34 -0500 Anthony Liguori wrote: > Luiz Capitulino writes: > > > Commit f628926bb423fa8a7e0b114511400ea9df38b76a changed monitor_flush() > > to retry on qemu_chr_fe_write() errors. However, the Monitor's output > > buffer can keep growing while the retry is not issued a

Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device

2013-04-02 Thread Corey Bryant
On 04/01/2013 08:11 PM, Kevin O'Connor wrote: On Mon, Apr 01, 2013 at 03:05:55PM -0400, Corey Bryant wrote: On 03/28/2013 05:03 AM, Paolo Bonzini wrote: There is work on moving ACPI tables to QEMU. Please work with the other developers (Kevin of course, and Michael and Laszlo who I have CCed

Re: [Qemu-devel] [PATCH v3 17/27] tcg-ppc64: Implement bswap64

2013-04-02 Thread Alexander Graf
Am 02.04.2013 um 15:44 schrieb Richard Henderson : > On 2013-04-01 23:34, Alexander Graf wrote: >> Is this faster than a load/store with std/ldbrx? > > Hmm. Almost certainly not. And since we've got stack space > allocated for function calls, we've got scratch space to do it in. > > Probably

[Qemu-devel] [PATCH 0/5] trim down config-target.mak

2013-04-02 Thread Paolo Bonzini
configure puts a bunch of things in config-target.mak that do not really belong there; a better place is either config-host.mak or target-*/cpu.h. This series cleans it up. Paolo Bonzini (5): configure: move TARGET_*_ALIGNMENT to target-*/cpu.h cpu: default TARGET_LONG_ALIGNMENT to TARGET_LON

[Qemu-devel] [PATCH 1/5] configure: move TARGET_*_ALIGNMENT to target-*/cpu.h

2013-04-02 Thread Paolo Bonzini
This is no different from, for example, TARGET_LONG_BITS. It does not belong in configure. Signed-off-by: Paolo Bonzini --- configure | 18 -- include/exec/cpu-defs.h | 13 + target-alpha/cpu.h | 1 + target-arm/cpu.h| 1 + target-i386/cp

[Qemu-devel] [PATCH 4/5] configure: move common libraries to config-host.mak

2013-04-02 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.target | 2 +- configure | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Makefile.target b/Makefile.target index 2bd6d14..c8513f1 100644 --- a/Makefile.target +++ b/Makefile.target @@ -119,7 +119,7 @@ obj-$(CONFIG_HAVE_GET_M

[Qemu-devel] [PATCH 2/5] cpu: default TARGET_LONG_ALIGNMENT to TARGET_LONG_SIZE

2013-04-02 Thread Paolo Bonzini
This is the case for all supported 64-bits architectures. Signed-off-by: Paolo Bonzini --- include/exec/cpu-defs.h | 2 +- target-alpha/cpu.h | 1 - target-i386/cpu.h | 1 - target-ppc/cpu.h| 1 - target-s390x/cpu.h | 1 - target-sparc/cpu.h | 1 - 6 files changed, 1

Re: [Qemu-devel] [PULL 6/6] Monitor: Make output buffer dynamic

2013-04-02 Thread Luiz Capitulino
On Tue, 2 Apr 2013 10:37:01 -0400 Luiz Capitulino wrote: > On Mon, 01 Apr 2013 10:35:34 -0500 > Anthony Liguori wrote: > > > Luiz Capitulino writes: > > > > > Commit f628926bb423fa8a7e0b114511400ea9df38b76a changed monitor_flush() > > > to retry on qemu_chr_fe_write() errors. However, the Mon

[Qemu-devel] [PATCH 5/5] configure: CONFIG_NO_XEN is duplicated

2013-04-02 Thread Paolo Bonzini
We already define it in Makefile.target. But we need to avoid a curious double negation in order to eliminate it. Signed-off-by: Paolo Bonzini --- configure | 3 --- hw/xen.h | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/configure b/configure index da0e8aa..98716ae 1007

[Qemu-devel] [PATCH 3/5] configure: move CONFIG_QEMU_LDST_OPTIMIZATION to config-host.mak

2013-04-02 Thread Paolo Bonzini
Its value is the same for all targets. Signed-off-by: Paolo Bonzini --- configure | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/configure b/configure index 5d9a87e..629f70b 100755 --- a/configure +++ b/configure @@ -3481,6 +3481,15 @@ echo "extra_ldflags=

Re: [Qemu-devel] [PATCH] virtio-blk-x: fix configuration synchronization.

2013-04-02 Thread Kevin Wolf
Am 26.03.2013 um 17:15 hat KONRAD Frédéric geschrieben: > On 22/03/2013 20:41, Anthony Liguori wrote: > >KONRAD Frédéric writes: > > > >>On 22/03/2013 19:52, Kevin Wolf wrote: > >>>Am 22.03.2013 um 19:17 hat KONRAD Frédéric geschrieben: > On 22/03/2013 17:58, Kevin Wolf wrote: > >Am 20.03.

Re: [Qemu-devel] [PATCH] virtio-blk-x: fix configuration synchronization.

2013-04-02 Thread KONRAD Frédéric
On 02/04/2013 16:49, Kevin Wolf wrote: Am 26.03.2013 um 17:15 hat KONRAD Frédéric geschrieben: On 22/03/2013 20:41, Anthony Liguori wrote: KONRAD Frédéric writes: On 22/03/2013 19:52, Kevin Wolf wrote: Am 22.03.2013 um 19:17 hat KONRAD Frédéric geschrieben: On 22/03/2013 17:58, Kevin Wolf

[Qemu-devel] [RFC PATCH 0/6] audio: simplify -soundhw machinery, use default-configs

2013-04-02 Thread Paolo Bonzini
This avoids audio-specific hacks in configure, so that the same mechanism is used for all targets and all devices. Not yet tested enough, hence RFC. Paolo Paolo Bonzini (6): adlib: qdev-ify audio: remove the need for audio card CONFIG_* symbols audio: remove HAS_AUDIO audio: remove CONFI

[Qemu-devel] [RFC PATCH 3/6] audio: remove HAS_AUDIO

2013-04-02 Thread Paolo Bonzini
Several targets can have wavcapture/-soundhw support via PCI cards. HAS_AUDIO is a useless limitation, remove it. Signed-off-by: Paolo Bonzini --- arch_init.c | 9 - configure | 8 hmp-commands.hx | 4 monitor.c | 2 -- 4 files changed, 23 deletions(-) diff

[Qemu-devel] [RFC PATCH 2/6] audio: remove the need for audio card CONFIG_* symbols

2013-04-02 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- arch_init.c| 136 + configure | 8 +--- hw/ac97.c | 3 +- hw/adlib.c | 3 +- hw/audiodev.h | 23 ++--- hw/cs4231a.c | 3 +- hw/es1370.c| 3 +- h

[Qemu-devel] [RFC PATCH 4/6] audio: remove CONFIG_* symbols

2013-04-02 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 9 - 1 file changed, 9 deletions(-) diff --git a/configure b/configure index 16380f6..1b2dc53 100755 --- a/configure +++ b/configure @@ -3557,10 +3557,6 @@ fi if test "$cap_ng" = "yes" ; then echo "CONFIG_LIBCAP=y" >> $config_host_mak fi

  1   2   3   4   >