Re: [Qemu-devel] A crash problem about "loadvm"

2013-04-01 Thread Liuji (Jeremy)
I delete the "dev->sin = NULL;" in the last of "spice_char_device_reset" function. And the "loadvm" is OK. But I don't know whether this change will lead to other problems. Who can give me some advice? Best Regards, Jeremy Liu > Hello, everyone > > I found a problem about "loadvm", when I

Re: [Qemu-devel] [RFC PATCH v2 0/4] port network layer onto glib

2013-04-01 Thread liu ping fan
On Thu, Mar 28, 2013 at 10:55 PM, Stefan Hajnoczi wrote: > > On Thu, Mar 28, 2013 at 03:55:51PM +0800, Liu Ping Fan wrote: > > From: Liu Ping Fan > > > > These series aim to make the whole network re-entrant, here only apply > > backend and frontend, > > and for the netcore, separated patches ha

[Qemu-devel] [PATCH 0/5] proposal to make hostmem listener RAM unplug safe

2013-04-01 Thread Liu Ping Fan
From: Liu Ping Fan This is an proposal similar to push core listener out of biglock for core listener out of biglock, refer to orignal plan posted by Marcelo Tosatti, http://lists.gnu.org/archive/html/qemu-devel/2012-06/msg04315.html While core listener's out of biglock still no

[Qemu-devel] [PATCH 1/5] memory: add ref/unref interface for MemroyRegionOps

2013-04-01 Thread Liu Ping Fan
From: Liu Ping Fan This pair of interface are optinal, except for those device which is used outside the biglock's protection for hot unplug. Currently, HostMem used by virtio-blk dataplane is outside biglock, so the RAM device should implement this. Signed-off-by: Liu Ping Fan --- include/exe

[Qemu-devel] [PATCH 2/5] hostmem: make hostmem global and RAM hotunplg safe

2013-04-01 Thread Liu Ping Fan
From: Liu Ping Fan The hostmem listener will translate gpa to hva quickly. Make it global, so other component can use it. Also this patch adopt MemoryRegionOps's ref/unref interface to make it survive the RAM hotunplug. Signed-off-by: Liu Ping Fan --- hw/dataplane/hostmem.c | 130

[Qemu-devel] [PATCH 5/5] hostmem: init/finalize hostmem listener

2013-04-01 Thread Liu Ping Fan
From: Liu Ping Fan Signed-off-by: Liu Ping Fan --- vl.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 7643f16..46a25cf 100644 --- a/vl.c +++ b/vl.c @@ -4157,6 +4157,7 @@ int main(int argc, char **argv, char **envp) } os_set_line_bufferin

[Qemu-devel] [PATCH 3/5] vring: use hostmem's RAM safe api

2013-04-01 Thread Liu Ping Fan
From: Liu Ping Fan When lookup gpa to hva, the corresponding MemoryRegion will be exposed to caller, and will release by caller later Signed-off-by: Liu Ping Fan --- hw/dataplane/vring.c | 88 ++ hw/dataplane/vring.h |5 ++- include/qem

[Qemu-devel] [PATCH 4/5] virtio-blk: release reference to RAM's memoryRegion

2013-04-01 Thread Liu Ping Fan
From: Liu Ping Fan virtio-blk will reference to RAM's memoryRegion when the req has been done. So we can avoid to call bdrv_drain_all() when RAM hot unplug. Signed-off-by: Liu Ping Fan --- hw/dataplane/virtio-blk.c | 52 ++-- 1 files changed, 40 inser

Re: [Qemu-devel] [PATCH v16 5/6] pc_piix, pc_q35: export fw_cfg

2013-04-01 Thread Hu Tao
On Fri, Mar 29, 2013 at 10:28:07AM +0100, Paolo Bonzini wrote: > Il 29/03/2013 09:16, Hu Tao ha scritto: > > diff --git a/hw/pc.h b/hw/pc.h > > index 8e1dd4c..d42b76b 100644 > > --- a/hw/pc.h > > +++ b/hw/pc.h > > @@ -145,6 +145,12 @@ PCIBus *i440fx_init(PCII440FXState **pi440fx_state, > > int *pi

[Qemu-devel] [PATCH 1/1] rng backend: open backend in blocking mode

2013-04-01 Thread Amit Shah
Opening backends in non-blocking mode isn't necessary, we don't do anything while waiting for data. This also excuses us from checking for EAGAIN, which for the default random backend, is a very common return error type. Starting the guest with '-device virtio-rng-pci', issuing a 'cat /dev/hwrng'

Re: [Qemu-devel] [PER] Re: socket, mcast looping back frames -> IPv6 broken

2013-04-01 Thread Samuel Thibault
Mike Lovell, le Mon 01 Apr 2013 00:35:03 -0600, a écrit : > On 03/08/2013 05:47 AM, Samuel Thibault wrote: > >Samuel Thibault, le Fri 08 Mar 2013 10:08:55 +0100, a écrit : > >>There does exist some unique address, which is returned by recvfrom, > >>I'll have a look at how to get access to it. > >Ah

[Qemu-devel] [PATCH 0/3] block: make qmp_transaction extendable

2013-04-01 Thread Wenchao Xia
This serial will package backing chain snapshot code as one case to make it possible adding more operations later. It is splitted out from previous snapshot patches since it have slightly different purpose, adjusting qmp_transaction. Previous patch and discuss could be found at: http://lists.nong

[Qemu-devel] [PATCH 1/3] block: add function deappend()

2013-04-01 Thread Wenchao Xia
This function should be used to remove contents of active *bs on the top of backing chain, when top *bs was committed to bs->backing_hd or *bs was just appended. Signed-off-by: Wenchao Xia --- block.c | 66 + include/block/block.h

[Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable

2013-04-01 Thread Wenchao Xia
Now code for external snapshot are packaged as one case in qmp_transaction, so later other operation could be added. The logic in qmp_transaction is changed a bit: Original code tries to create all images first and then update all *bdrv once together, new code create and update one *bdrv one ti

[Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction

2013-04-01 Thread Wenchao Xia
Last operaton should be cancelled first. Signed-off-by: Wenchao Xia --- blockdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index 75416fb..a24d10e 100644 --- a/blockdev.c +++ b/blockdev.c @@ -954,7 +954,7 @@ void qmp_transaction(Blockdev

[Qemu-devel] After executing "savevm", the QEMU process is hanging

2013-04-01 Thread Liuji (Jeremy)
Hello, everyone After executing the "savevm" command, the QEMU process is hanging. But in the v1.4.0, it's no problem. Host OS: Fedora 17 x86_64 Qemu: the latest(2013-04-01) Quest OS: WinXP 1) Use the following command to start the VM: qemu-kvm -enable-kvm -name winxp -M pc-0.15 -m 1024 -smp

[Qemu-devel] KVM call agenda for 2013-04-02

2013-04-01 Thread Juan Quintela
Hi Please send in any agenda topics you are interested in. Later, Juan.

Re: [Qemu-devel] [PATCH] tweak lookup_feature() in target-i386/cpu.c

2013-04-01 Thread Igor Mammedov
On Sat, 30 Mar 2013 10:01:21 +0800 "Michael W. Bombardieri" wrote: > Hi, > > The following patch removes variable 'found' from lookup_feature(). > We can just return true/false (found/not found) directly. > Does this look OK? We are aiming to remove lookup_feature() and related feature tables, s

[Qemu-devel] Adding a persistent writeback cache to qemu

2013-04-01 Thread Alex Bligh
I'd like to experiment with adding persistent writeback cache to qemu. The use case here is where non-local storage is used (e.g. rbd, ceph) using the qemu drivers, together with a local cache as a file on a much faster locally mounted device, for instance an SSD (possibly replicated). This would

[Qemu-devel] question about performance of dataplane

2013-04-01 Thread Zhangleiqiang
Hi, Stefan: I have done some testing to compare the performance of dataplane and non-dataplane. But the result did not meet my expectations, the performance of disk with dataplane enabled did not have advantage over non-dataplane. The following contains the environment info

Re: [Qemu-devel] [PATCH 1/1] rng backend: open backend in blocking mode

2013-04-01 Thread Anthony Liguori
Amit Shah writes: > Opening backends in non-blocking mode isn't necessary, we don't do > anything while waiting for data. > > This also excuses us from checking for EAGAIN, which for the default > random backend, is a very common return error type. It's not common... It really shouldn't happen

Re: [Qemu-devel] [PATCH] hw/wom: Implement write-only-memory device

2013-04-01 Thread Blue Swirl
On Mon, Apr 1, 2013 at 12:00 AM, Peter Maydell wrote: > The lack of a write-only-memory device is a gaping hole in QEMU's > otherwise comprehensive range of device models. This patch implements > a model of the popular Signetics 25120 9046xN random access WOM. Awesome!! I made a short clip to sho

Re: [Qemu-devel] [Xen-devel] frequently ballooning results in qemu exit

2013-04-01 Thread Stefano Stabellini
On Sat, 30 Mar 2013, Hanweidong wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: 2013年3月29日 20:37 > > To: Hanweidong > > Cc: Tim (Xen.org); George Dunlap; Andrew Cooper; Yanqiangjun; qemu- > > de...@nongnu.org; xen-de...@lists.xe

Re: [Qemu-devel] [PATCH v2 01/27] disas: Disassemble all ppc insns for the host

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:32:44PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > disas.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/disas.c b/disas.c > index a46faee..c0ac7ec 100644 > --- a/disas.c > +++ b/disas.c > @@ -322,6 +322,7 @@ void disas(FILE *

Re: [Qemu-devel] [PATCH v2 03/27] tcg-ppc64: Introduce and use tcg_out_rlw

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:32:46PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 72 > ++ > 1 file changed, 20 insertions(+), 52 deletions(-) > > diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64

Re: [Qemu-devel] [PATCH v2 02/27] tcg-ppc64: Use TCGReg everywhere

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:32:45PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 36 +--- > 1 file changed, 21 insertions(+), 15 deletions(-) > > diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c > i

Re: [Qemu-devel] [PATCH v2 04/27] tcg-ppc64: Introduce and use tcg_out_ext32u

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:32:47PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c > index 3587d0e..84e30ad

Re: [Qemu-devel] [PATCH v2 05/27] tcg-ppc64: Introduce and use tcg_out_shli64

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:32:48PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c > index 84e30ad..9199ac4 100

Re: [Qemu-devel] [PATCH v2 09/27] tcg-ppc64: Rearrange integer constant constraints

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:32:52PM -0800, Richard Henderson wrote: > We'll need a zero, and Z makes more sense for that. Make sure we > have a full compliment of signed and unsigned 16 and 32-bit tests. > > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 43 +++

Re: [Qemu-devel] [PATCH v2 06/27] tcg-ppc64: Introduce and use tcg_out_shri64

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:32:49PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c > index 9199ac4..82e1da7 100644 >

Re: [Qemu-devel] [PATCH v2 07/27] tcg-ppc64: Cleanup tcg_out_movi

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:32:50PM -0800, Richard Henderson wrote: > The test for using movi32 was sub-optimal for TCG_TYPE_I32, comparing > a signed 32-bit quantity against an unsigned 32-bit quantity. > > When possible, use addi+oris for 32-bit unsigned constants. Otherwise, > standardize on ad

Re: [Qemu-devel] [PATCH v2 08/27] tcg-ppc64: Introduce and use TAI and SAI

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:32:51PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 138 > +++-- > 1 file changed, 66 insertions(+), 72 deletions(-) > > diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64

Re: [Qemu-devel] [PATCH v2 10/27] tcg-ppc64: Improve constant add and sub ops.

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:32:53PM -0800, Richard Henderson wrote: > Use SUBFIC to implement subtraction with constant op1. Improve constant > addition -- previously we'd emit useless addis with 0. Use new constraints > to force the driver to pull full 64-bit constants into a register. > > Signe

Re: [Qemu-devel] [PATCH v2 13/27] tcg-ppc64: Improve and_i64 with constant

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:32:56PM -0800, Richard Henderson wrote: > Use RLDICL and RLDICR. > > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 64 > +++--- > 1 file changed, 50 insertions(+), 14 deletions(-) > > diff --git a/tcg/pp

Re: [Qemu-devel] [PATCH v2 14/27] tcg-ppc64: Streamline qemu_ld/st insn selection

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:32:57PM -0800, Richard Henderson wrote: > Using a table to look up insns of the right width and sign. > Include support for the Power 2.05 LDBRX and STDBRX insns > included in e.g. Power6. These instructions have actually been added in the Power 2.06 specification. The d

Re: [Qemu-devel] [PATCH v2 11/27] tcg-ppc64: Tidy or and xor patterns.

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:32:54PM -0800, Richard Henderson wrote: > Handle constants in common code; we'll want to reuse that later. > > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 55 > -- > 1 file changed, 31 insertions(+)

Re: [Qemu-devel] [PATCH v2 12/27] tcg-ppc64: Improve and_i32 with constant

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:32:55PM -0800, Richard Henderson wrote: > Use RLWINM > > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 50 > +- > 1 file changed, 49 insertions(+), 1 deletion(-) > > diff --git a/tcg/ppc64/tcg-target

Re: [Qemu-devel] [PATCH v2 15/27] tcg-ppc64: Implement rotates

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:32:58PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 39 +++ > tcg/ppc64/tcg-target.h | 4 ++-- > 2 files changed, 41 insertions(+), 2 deletions(-) > > diff --git a/tcg/ppc64/tc

Re: [Qemu-devel] [PATCH v2 17/27] tcg-ppc64: Implement bswap64

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:33:00PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 35 +++ > tcg/ppc64/tcg-target.h | 2 +- > 2 files changed, 36 insertions(+), 1 deletion(-) > > diff --git a/tcg/ppc64/tcg-targe

Re: [Qemu-devel] [PATCH v2 16/27] tcg-ppc64: Implement bswap16 and bswap32

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:32:59PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 43 +++ > tcg/ppc64/tcg-target.h | 18 ++ > 2 files changed, 53 insertions(+), 8 deletions(-) > > diff --

Re: [Qemu-devel] [PATCH v2 21/27] tcg-ppc64: Use I constraint for mul

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:33:04PM -0800, Richard Henderson wrote: > The mul_i32 pattern was loading non-16-bit constants into a register, > when we can get the middle-end to do that for us. The mul_i64 pattern > was not considering that MULLI takes 64-bit inputs. > > Signed-off-by: Richard Hende

Re: [Qemu-devel] [PATCH v2 18/27] tcg-ppc64: Implement compound logicals

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:33:01PM -0800, Richard Henderson wrote: > Mostly copied from the ppc32 port. > > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 34 ++ > tcg/ppc64/tcg-target.h | 20 ++-- > 2 files changed, 44 insertion

Re: [Qemu-devel] [PATCH v2 19/27] tcg-ppc64: Handle constant inputs for some compound logicals

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:33:02PM -0800, Richard Henderson wrote: > Since we have special code to handle and/or/xor with a constant, > apply the same to andc/orc/eqv with a constant. > > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 44 ++-

Re: [Qemu-devel] [PATCH v2 23/27] tcg-ppc64: Rewrite setcond

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:33:06PM -0800, Richard Henderson wrote: > Never use MFCR, as the latency is really high. Even MFOCRF, at half > the latency of MFCR, isn't as fast as we can do with carry tricks. > > The ADDIC+SUBFE trick only works for word-sized operands, as we need > carry-out from b

Re: [Qemu-devel] [PATCH v2 20/27] tcg-ppc64: Implement deposit

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:33:03PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 12 > tcg/ppc64/tcg-target.h | 4 ++-- > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-

Re: [Qemu-devel] [PATCH v2 24/27] tcg-ppc64: Implement movcond

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:33:07PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 59 > ++ > tcg/ppc64/tcg-target.h | 4 ++-- > 2 files changed, 61 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v2 22/27] tcg-ppc64: Use TCGType throughout compares

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:33:05PM -0800, Richard Henderson wrote: > The optimization/bug being fixed is that tcg_out_cmp was not applying the > right type to loading a constant, in the case it can't be implemented > directly. Rather than recomputing the TCGType enum from the arch64 bool, > pass a

Re: [Qemu-devel] [PATCH] hw/wom: Implement write-only-memory device

2013-04-01 Thread Anthony Liguori
Peter Maydell writes: > The lack of a write-only-memory device is a gaping hole in QEMU's > otherwise comprehensive range of device models. This patch implements > a model of the popular Signetics 25120 9046xN random access WOM. Applied, thanks. Regards, Anthony Liguori > --- > hw/Makefile.o

Re: [Qemu-devel] [PATCH] [RFC] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect

2013-04-01 Thread Stefano Stabellini
On Mon, 1 Apr 2013, Alex Bligh wrote: > This commit delays the point at which bdrv_new (and hence blk_open > on the underlying device) is called from blk_init to blk_connect. > This ensures that in an inbound live migrate, the block device is > not opened until it has been closed at the other end.

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-04-01 Thread Alex Bligh
Stefano, --On 31 March 2013 19:53:28 + Alex Bligh wrote: Alex, do you have any updates on this patch? Sorry, I've been snowed under with other stuff. I got to the speed bump below, then didn't get back to it after Paolo's reply. I'll see if I can get some time tomorrow. Just sent unde

[Qemu-devel] [PATCH] target-ppc: Enable ISEL on POWER7

2013-04-01 Thread Aurelien Jarno
ISEL is a Power ISA 2.06 instruction and thus is available on POWER7. Given this is trapped and emulated by the Linux kernel, I guess it went unnoticed. Cc: Alexander Graf Signed-off-by: Aurelien Jarno --- target-ppc/translate_init.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[Qemu-devel] [PATCH v2] linux-user: improve target_to_host_sock_type conversion

2013-04-01 Thread Petar Jovanovic
From: Petar Jovanovic Previous implementation has failed to take into account different value of SOCK_NONBLOCK on target and host, and existence of SOCK_CLOEXEC. The same conversion has to be applied both for do_socket and do_socketpair, so the code has been isolated in a static inline function.

Re: [Qemu-devel] [PATCH] linux-user: improve target_to_host_sock_type conversion for MIPS

2013-04-01 Thread Petar Jovanovic
From: Aurelien Jarno [aurel...@aurel32.net] Sent: Sunday, March 24, 2013 11:27 AM To: Petar Jovanovic Cc: qemu-devel@nongnu.org; Petar Jovanovic; riku.voi...@linaro.org; Richard Henderson; Blue Swirl Subject: Re: [PATCH] linux-user: improve target_to_host_

Re: [Qemu-devel] [PATCH v2 25/27] tcg-ppc64: Use getauxval for ISA detection

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:33:08PM -0800, Richard Henderson wrote: > Glibc 2.16 includes an easy way to get feature bits previously > buried in /proc or the program startup auxiliary vector. Use it. > > Signed-off-by: Richard Henderson > --- > configure | 18 ++ > t

Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction

2013-04-01 Thread Eric Blake
On 04/01/2013 04:01 AM, Wenchao Xia wrote: > Last operaton should be cancelled first. s/operaton/operation/ [I don't care enough about US vs. UK to say whether canceled or cancelled looks better] > > Signed-off-by: Wenchao Xia > --- > blockdev.c |2 +- > 1 files changed, 1 insertions(+)

Re: [Qemu-devel] [PATCH V10 13/17] hmp: switch snapshot info function to qmp based one

2013-04-01 Thread Eric Blake
On 03/22/2013 08:19 AM, Wenchao Xia wrote: > This patch using new added function in last commit which retrieve > info from qmp for snapshot info. > > Signed-off-by: Wenchao Xia > --- > monitor.c |2 +- > savevm.c | 64 > - > 2

Re: [Qemu-devel] [PATCH 1/7] virtio-console: Also throttle when less was written then requested

2013-04-01 Thread Hans de Goede
Hi, On 03/29/2013 10:31 AM, Amit Shah wrote: On (Thu) 28 Mar 2013 [14:28:11], Hans de Goede wrote: This is necessary so that we get properly woken up to write the rest. Signed-off-by: Hans de Goede Acked-by: Amit Shah --- hw/virtio-console.c | 5 +++-- 1 file changed, 3 insertions(+), 2 d

Re: [Qemu-devel] [PATCH v2 26/27] tcg-ppc64: Implement add2/sub2_i64

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:33:09PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 56 > ++ > tcg/ppc64/tcg-target.h | 4 ++-- > 2 files changed, 58 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v2 27/27] tcg-ppc64: Implement mulu2/muls2_i64

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:33:10PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 27 +++ > tcg/ppc64/tcg-target.h | 4 ++-- > 2 files changed, 29 insertions(+), 2 deletions(-) > > diff --git a/tcg/ppc64/tcg-target.c b

Re: [Qemu-devel] [PATCH v2 12/27] tcg-ppc64: Improve and_i32 with constant

2013-04-01 Thread Aurelien Jarno
On Mon, Apr 01, 2013 at 08:43:24AM -0700, Richard Henderson wrote: > On 2013-04-01 07:55, Aurelien Jarno wrote: > >>>+static void tcg_out_andi32(TCGContext *s, TCGReg dst, TCGReg src, > >>>uint32_t c) > >>>+{ > >>>+int mb, me; > >>>+ > >>>+if ((c & 0x) == c) { > >>>+tcg_out32(s

[Qemu-devel] [PATCH] [RFC] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect

2013-04-01 Thread Alex Bligh
This commit delays the point at which bdrv_new (and hence blk_open on the underlying device) is called from blk_init to blk_connect. This ensures that in an inbound live migrate, the block device is not opened until it has been closed at the other end. This is in preparation for supporting devices

Re: [Qemu-devel] [PULL 6/6] Monitor: Make output buffer dynamic

2013-04-01 Thread Anthony Liguori
Luiz Capitulino writes: > Commit f628926bb423fa8a7e0b114511400ea9df38b76a changed monitor_flush() > to retry on qemu_chr_fe_write() errors. However, the Monitor's output > buffer can keep growing while the retry is not issued and this can > cause the buffer to overflow. > > To reproduce this issu

Re: [Qemu-devel] [PATCH v2 25/27] tcg-ppc64: Use getauxval for ISA detection

2013-04-01 Thread Richard Henderson
On 2013-04-01 08:00, Aurelien Jarno wrote: I wonder if the same could be used for arm with AT_PLATFORM to detect ARM v5/v6/v7. Yes you can. Once the ppc64 patch set was in, I was planning on seeing what I could infer from the ARM HWCAP bits. E.g. if you have neon then you're at least arm6, et

Re: [Qemu-devel] [PATCH v2 12/27] tcg-ppc64: Improve and_i32 with constant

2013-04-01 Thread Richard Henderson
On 2013-04-01 07:55, Aurelien Jarno wrote: >+static void tcg_out_andi32(TCGContext *s, TCGReg dst, TCGReg src, uint32_t c) >+{ >+int mb, me; >+ >+if ((c & 0x) == c) { >+tcg_out32(s, ANDI | SAI(src, dst, c)); >+return; >+} else if ((c & 0x) == c) { >+

Re: [Qemu-devel] [Bug 1154328] [NEW] qemu locks up on typing 41 characters at once into serial console

2013-04-01 Thread Aurelien Jarno
On Mon, Apr 01, 2013 at 12:26:16PM +0530, Amit Shah wrote: > On (Tue) 12 Mar 2013 [21:31:29], Andreas Gustafsson wrote: > > > Now cut-and-paste a string containing at least 41 characters into the > > terminal window. I used a string containing 41 copies of the letter > > "X". You can use o

Re: [Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

2013-04-01 Thread Petar Jovanovic
ping http://patchwork.ozlabs.org/patch/229787/ From: Peter Maydell [peter.mayd...@linaro.org] Sent: Thursday, March 21, 2013 7:03 PM To: Petar Jovanovic Cc: qemu-devel@nongnu.org; riku.voi...@linaro.org; Petar Jovanovic Subject: Re: [Qemu-devel] [PATCH] li

[Qemu-devel] [PATCH 1/5] gtk: make more messages translatable

2013-04-01 Thread Aurelien Jarno
Anthony Liguori Signed-off-by: Aurelien Jarno --- ui/gtk.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index a5a8156..9692c56 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -210,11 +210,11 @@ static void gd_update_caption(GtkDisplayState *s) bool

[Qemu-devel] [PATCH 3/5] po/Makefile: correctly pass QEMU version

2013-04-01 Thread Aurelien Jarno
Cc: Anthony Liguori Signed-off-by: Aurelien Jarno --- po/Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/po/Makefile b/po/Makefile index 2c0193e..8297ab5 100644 --- a/po/Makefile +++ b/po/Makefile @@ -34,7 +34,7 @@ install: $(OBJS) @msgfmt -o $@ $(SRC_PATH

[Qemu-devel] [PATCH 4/5] po: update existing translation files

2013-04-01 Thread Aurelien Jarno
Cc: Paolo Bonzini Cc: Kevin Wolf Cc: Anthony Liguori Signed-off-by: Aurelien Jarno --- po/de_DE.po| 41 - po/it.po | 41 - po/messages.po | 36 3 files changed,

[Qemu-devel] [PATCH 0/5] Translation improvements

2013-04-01 Thread Aurelien Jarno
This patch series marks a few more messages as translatable, improves po/Makefile and add French translation. Aurelien Jarno (5): gtk: make more messages translatable po/Makefile: simplify po/Makefile: correctly pass QEMU version po: update existing translation files po: add French trans

[Qemu-devel] [PATCH 2/5] po/Makefile: simplify

2013-04-01 Thread Aurelien Jarno
In the hope we get more translations, we should not have to modify po/Makefile for each of them. Cc: Anthony Liguori Signed-off-by: Aurelien Jarno --- po/Makefile | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/po/Makefile b/po/Makefile index 2b4420f..2c0193e

[Qemu-devel] [PATCH 5/5] po: add French translation

2013-04-01 Thread Aurelien Jarno
Cc: Anthony Liguori Signed-off-by: Aurelien Jarno --- po/fr_FR.po | 62 +++ 1 file changed, 62 insertions(+) create mode 100644 po/fr_FR.po diff --git a/po/fr_FR.po b/po/fr_FR.po new file mode 100644 index 000..27d8636 --- /dev/null

[Qemu-devel] [PATCH] acpi: initialize s4_val used in s4 shutdown

2013-04-01 Thread Bruce Rogers
While investigating why a 32 bit Windows 2003 guest wasn't able to successfully perform a shutdown /h, it was discovered that commit afafe4bbe0cf7d3318e1ac7b40925561f86a6bd4 inadvertently dropped the initialization of the s4_val used to handle s4 shutdown. Initialize the value as before. Signed-of

Re: [Qemu-devel] [PATCH 0/5] Translation improvements

2013-04-01 Thread Anthony Liguori
Aurelien Jarno writes: > This patch series marks a few more messages as translatable, improves > po/Makefile and add French translation. Reviewed-by: Anthony Liguori Regards, Anthony Liguori > > Aurelien Jarno (5): > gtk: make more messages translatable > po/Makefile: simplify > po/Mak

Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device

2013-04-01 Thread Corey Bryant
On 03/28/2013 05:03 AM, Paolo Bonzini wrote: Il 26/03/2013 15:14, Corey Bryant ha scritto: This patch provides ACPI support for the TPM device. It probes for the TPM device and only if a TPM device is found then the TPM's SSDT and TCPA table are created. This patch also connects them to the RS

[Qemu-devel] [Bug 1162644] Re: qemu-system-x86_64 crashed with SIGABRT in __assert_fail_base()

2013-04-01 Thread Lucas Meneghel Rodrigues
On my F19 box, it's failing about 2/3 of the attempts. What is funny is that on the Ubuntu 13.04 box, I can't get the problem reproduced anymore, for some reason beyond me. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.

Re: [Qemu-devel] [PATCH V10 15/17] block: dump to buffer for bdrv_image_info_dump()

2013-04-01 Thread Eric Blake
On 03/22/2013 08:19 AM, Wenchao Xia wrote: > This allow hmp use this function, just like qemu-img. > It also returns a pointer now to make it easy to use. > > > -void bdrv_image_info_dump(ImageInfo *info) > +GCC_FMT_ATTR(3, 4) > +static void snprintf_tail(char **p_buf, int *p_size, const char

[Qemu-devel] [RFC 0/4] target-i386: Add "feature-words" CPU object property

2013-04-01 Thread Eduardo Habkost
As the work to get X86CPU subclasses static properties defined is taking very long to get reviewed and we risk not getting it finished in 1.5, I am sending an alternative mechanism to allow libvirt to probe for CPU model information. It's interesting to note that this alternative solution is actua

[Qemu-devel] [RFC 1/4] target-i386: Add ECX information to FeatureWordInfo

2013-04-01 Thread Eduardo Habkost
FEAT_7_0_EBX uses ECX as input, so we have to take that into account when reporting feature word values. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 4b43759..974a8c

[Qemu-devel] [RFC 2/4] target-i386: Move feature word array outside get_register_name_32()

2013-04-01 Thread Eduardo Habkost
The array will be used by the "feature-words" properties to output the register enum value. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 974a8c6..20

[Qemu-devel] [RFC 3/4] target-i386: Add "feature-words" property

2013-04-01 Thread Eduardo Habkost
This property will be useful for libvirt, as libvirt already has logic based on low-level feature bits (not feature names), so it will be really easy to convert the current libvirt logic to something using the "feature-words" property. The property will have two main use cases: - Checking host ca

[Qemu-devel] [RFC 4/4] target-i386: Use qapi for x86_cpu_get_feature_words()

2013-04-01 Thread Eduardo Habkost
Add a schema for QAPI definitions that will be used by *-user. Example output: $ ./QMP/qmp --path=/tmp/m qom-get --path=/machine/unattached/device[1] --property=feature-words item[0].cpuid-register: EDX item[0].cpuid-input-eax: 2147483658 item[0].features: 0 item[1].cpuid-register: EAX

Re: [Qemu-devel] [PATCH] [RFC] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect

2013-04-01 Thread Alex Bligh
Stefano, --On 1 April 2013 16:44:05 +0100 Stefano Stabellini wrote: Note this patch is compile-tested only. I think the patch looks good, just a minor comment. Thanks. I guess I ought to actually test it works then :-) +/* fill info + * Temporarily write zero sectors as we won'

[Qemu-devel] [GIT PULL 0/9] vfio-pci updates & VGA support

2013-04-01 Thread Alex Williamson
Hi Anthony, The following changes since commit 174d4d215fb49b4d43196e62f22c2533431b260e: tcg/mips: Implement muls2_i32 (2013-04-01 18:49:17 +0200) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git tags/vfio-pci-for-qemu-20130401.0 for you to fetch changes up t

[Qemu-devel] [PATCH 1/9] linux-headers: Update to v3.9-rc2

2013-04-01 Thread Alex Williamson
Unedited scripts/update-linux-headers.sh run against v3.9-rc2 tag Signed-off-by: Alex Williamson --- linux-headers/linux/vfio.h |9 + 1 file changed, 9 insertions(+) diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h index f787b72..e094121 100644 --- a/linux-header

[Qemu-devel] [PATCH 2/9] vfio-pci: Generalize PCI config mangling

2013-04-01 Thread Alex Williamson
Kernel-side vfio virtualizes all of config space, but some parts are unique to Qemu. For instance we may or may not expose the ROM BAR, Qemu manages MSI/MSIX, and Qemu manages the multi-function bit so that single function devices can appear as multi-function and vica versa. Generalize this into a

[Qemu-devel] [PATCH 3/9] vfio-pci: Add PCIe capability mangling based on bus type

2013-04-01 Thread Alex Williamson
Windows seems to pay particular interest to the PCIe header type of devices and will fail to load drivers if we attach Endpoint devices or Legacy Endpoint devices to the Root Complex. We can use pci_bus_is_express and pci_bus_is_root to determine the bus type and mangle the type appropriately: *

[Qemu-devel] [PATCH 8/9] vfio: Add bootindex support

2013-04-01 Thread Alex Williamson
Signed-off-by: Alex Williamson --- hw/vfio_pci.c |5 + 1 file changed, 5 insertions(+) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index d310730..0d2a445 100644 --- a/hw/vfio_pci.c +++ b/hw/vfio_pci.c @@ -30,6 +30,7 @@ #include "qemu/event_notifier.h" #include "exec/address-spaces.h" #

[Qemu-devel] [PATCH 4/9] qemu vfio-pci: Add support for VGA MMIO and I/O port access

2013-04-01 Thread Alex Williamson
Most VGA cards need some kind of quirk to fully operate since they hide backdoors to get to other registers outside of PCI config space within the registers, but this provides the base infrastructure. If we could identity map PCI resources for assigned devices we would need a lot fewer quirks. To

[Qemu-devel] [PATCH 7/9] vfio-pci: Move devices to D0 on reset

2013-04-01 Thread Alex Williamson
Guests may leave devices in a low power state at reboot, but we expect devices to be woken up for the next boot. Make this happen. Signed-off-by: Alex Williamson --- hw/vfio_pci.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index

[Qemu-devel] [PATCH 5/9] qemu vfio-pci: Graphics device quirks

2013-04-01 Thread Alex Williamson
Graphics cards have a number of different backdoors. Some of these are alternative ways to get PCI BAR addresses, some of them are complete mirrors of PCI config space available through MMIO and I/O port access. These quirks cover a number of ATI Radeon and Nvidia devices. On the ATI/AMD side, t

Re: [Qemu-devel] [PATCH 01/12] target-i386: consolidate error propagation in x86_cpu_realizefn()

2013-04-01 Thread Eduardo Habkost
On Thu, Mar 21, 2013 at 03:28:34PM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost > --- > target-i386/cpu.c | 17 ++--- > 1 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index a06

[Qemu-devel] [PATCH 9/9] vfio: cleanup includes

2013-04-01 Thread Alex Williamson
Starting to get messy, put the back in alphabetical order. Signed-off-by: Alex Williamson --- hw/vfio_pci.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index 0d2a445..693a9ff 100644 --- a/hw/vfio_pci.c +++ b/hw/vfio_pci.c @@ -19,

[Qemu-devel] [PATCH 6/9] vfio-pci: Add extra debugging

2013-04-01 Thread Alex Williamson
Often when debugging it's useful to be able to disable bypass paths so no interactions with the device are missed. Add some extra debug options to do this. Also add device info on read/write BAR accesses, which is useful when debugging more than one assigned device. A couple DPRINTFs also had re

Re: [Qemu-devel] [PATCH] hw/milkymist-softusb: set buffer in softusb_read_{dmem, pmem} error path

2013-04-01 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v3 0/6] virtio-balloon refactoring.

2013-04-01 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] qemu-bridge-helper: force usage of a very high MAC address for the bridge

2013-04-01 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_memory

2013-04-01 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 0/3] piix_pci cleanups

2013-04-01 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

[Qemu-devel] [Bug 1162963] [NEW] migration fails with error about ram device

2013-04-01 Thread Serge Hallyn
Public bug reported: On one machine I call ./qemu-system-x86_64 -m 1024 -drive file=/srv/z.img,if=virtio,cache=none -vnc :1 -monitor stdio on another, I call ./qemu-system-x86_64 -incoming tcp:0.0.0.0: -vnc :1 -monitor stdio then in the first monitor I call migrate -b tcp:10.42.43.1:

  1   2   >