Re: [Qemu-devel] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-26 Thread Paolo Bonzini
Il 26/03/2013 02:59, Hu Tao ha scritto: >>> > > >> > Why doesn't it work with q35? > ACPI_EXTRACT_NAME_WORD_CONST dsdt_isa_pest generates two dsdt_isa_pest, > one in out/acpi-dsdt.hex the other in out/q35-acpi-dsdt.hex. We should > use the one in q35-acpi-dsdt.hex to patch DSDT for q35. But includ

Re: [Qemu-devel] coroutine: hung when using gthread backend

2013-03-26 Thread Paolo Bonzini
Il 26/03/2013 03:50, Wenchao Xia ha scritto: > When I using tcg with coroutine backend = gthread, > x86_64-softmmu/qemu-system-x86_64 will hung. Any one > working on it? coroutine backend gthread hardly works for qemu, only qemu-io and qemu-img. Paolo

Re: [Qemu-devel] [RFC PATCH 04/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-03-26 Thread Paolo Bonzini
Il 25/03/2013 21:50, Tomoki Sekiyama ha scritto: > Hi, > > Paolo Bonzini wrote: >> Il 14/02/2013 07:10, Tomoki Sekiyama ha scritto: >>> diff --git a/qga/vss-win32-provider/qga-provider.idl >> b/qga/vss-win32-provider/qga-provider.idl >>> new file mode 100644 >>> index 000..17abca0 >>> --- /de

Re: [Qemu-devel] [PATCH 0/5] Add some tracepoints for clarification of the cause of troubles

2013-03-26 Thread Kazuya Saito
(2013/03/22 20:13), Paolo Bonzini wrote: > Il 22/03/2013 09:25, Kazuya Saito ha scritto: >> This series adds tracepoints for helping us clarify the cause of >> troubles. Virtualization on Linux is composed of some components such >> as qemu, kvm, libvirt, and so on. So it is very important to clari

Re: [Qemu-devel] [PATCH v3] New QMP command query-cpu-max and HMP command cpu_max

2013-03-26 Thread Paolo Bonzini
Il 25/03/2013 17:31, Michal Novotny ha scritto: > These commands return the maximum number of CPUs supported by the > currently running emulator instance, as defined in its QEMUMachine > struct. For HMP, I think the output could be added to "info cpus". Paolo > Signed-off-by: Michal Novotny > -

Re: [Qemu-devel] [PATCH 0/5] Add some tracepoints for clarification of the cause of troubles

2013-03-26 Thread Paolo Bonzini
Il 26/03/2013 08:13, Kazuya Saito ha scritto: >> > >> > I'm not sure 4-5 are that useful, but the first 3 patches are definitely >> > good stuff. > Thanks. I'll modify the patch you pointed out about CPU number and > re-post it. > I'd like to add tracepoints to the virtual device creation/deletion

Re: [Qemu-devel] [PATCH v3] New QMP command query-cpu-max and HMP command cpu_max

2013-03-26 Thread Paolo Bonzini
Il 26/03/2013 08:14, Paolo Bonzini ha scritto: >> > These commands return the maximum number of CPUs supported by the >> > currently running emulator instance, as defined in its QEMUMachine >> > struct. > For HMP, I think the output could be added to "info cpus". Just saw Luiz's solution, that's a

Re: [Qemu-devel] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-26 Thread Hu Tao
On Tue, Mar 26, 2013 at 08:03:09AM +0100, Paolo Bonzini wrote: > Il 26/03/2013 02:59, Hu Tao ha scritto: > >>> > > > >> > Why doesn't it work with q35? > > ACPI_EXTRACT_NAME_WORD_CONST dsdt_isa_pest generates two dsdt_isa_pest, > > one in out/acpi-dsdt.hex the other in out/q35-acpi-dsdt.hex. We sh

Re: [Qemu-devel] Target-agnostic virtio?

2013-03-26 Thread Artyom Tarasenko
On Tue, Mar 26, 2013 at 1:52 AM, Rob Landley wrote: > Can the virtio things (serial, network, block, virtfs) be used on arbitrary > targets yet? I.E. Can I use a virtio network device on arm, mips, powerpc, > sparc... Yes. Moreover, for sparc64 the virtio network is currently the only way to have

Re: [Qemu-devel] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-26 Thread Paolo Bonzini
Il 26/03/2013 08:24, Hu Tao ha scritto: >>> > > ACPI_EXTRACT_NAME_WORD_CONST dsdt_isa_pest generates two dsdt_isa_pest, >>> > > one in out/acpi-dsdt.hex the other in out/q35-acpi-dsdt.hex. We should >>> > > use the one in q35-acpi-dsdt.hex to patch DSDT for q35. But including >>> > > q35-acpi-dsdt.

Re: [Qemu-devel] Want to be part of Memory Hotplug

2013-03-26 Thread li guang
在 2013-02-07四的 18:54 +0100,Vasilis Liaskovitis写道: > Hi Senthil, > > On Mon, Feb 04, 2013 at 04:17:30PM +0530, kumaran wrote: > > Hi, > > > > I am Senthil, doing post graduation in IIT Bombay,India. > > > > I am looking for some problems related to KVM as part of my research > > work. I read abou

Re: [Qemu-devel] [PATCHv4 0/9] buffer_is_zero / migration optimizations

2013-03-26 Thread Peter Lieven
Am 25.03.2013 um 15:34 schrieb Paolo Bonzini : > > Hmm, right. What about just processing the first few longs twice, i.e. > the above followed by "for (i = 0; i < len / sizeof(sizeof(VECTYPE); i > += BUFFER_FIND_NONZERO_OFFSET_UNROLL_FACTOR)"? I tested this version as v3: size_t buffer_find_n

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-26 Thread Jan Kiszka
On 2013-03-25 21:30, Gerd Hoffmann wrote: > On 03/25/13 14:56, Igor Mitsyanko wrote: >> On 03/25/2013 02:37 PM, Gerd Hoffmann wrote: >>> Hi, [5425.580115] displaysurface_create_from surface=0x7ff315d3df40, > 800x600, bpp 16, bswap 0 [5425.580257] displaysurface_free > sur

Re: [Qemu-devel] [RFC PATCH 04/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-03-26 Thread Vadim Rozenfeld
On Tue, 2013-03-26 at 08:09 +0100, Paolo Bonzini wrote: > Il 25/03/2013 21:50, Tomoki Sekiyama ha scritto: > > Hi, > > > > Paolo Bonzini wrote: > >> Il 14/02/2013 07:10, Tomoki Sekiyama ha scritto: > >>> diff --git a/qga/vss-win32-provider/qga-provider.idl > >> b/qga/vss-win32-provider/qga-provid

[Qemu-devel] [PATCH] hw/i386/pc: format load_linux function

2013-03-26 Thread liguang
Signed-off-by: liguang --- hw/i386/pc.c | 109 ++ 1 files changed, 56 insertions(+), 53 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index ed7d9ba..b1e06fa 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -646,8 +646,8 @@ static lo

Re: [Qemu-devel] [PATCH] hw/i386/pc: fix possible segment fault for port92_write

2013-03-26 Thread li guang
在 2013-03-22五的 12:20 +0100,Andreas Färber写道: > Am 22.03.2013 10:12, schrieb liguang: > > e.g. > > $qemu-system-x86_64 -device port92 > > will report segment fault, > > for port92_write try a un-allocated > > assignment for a20_out. > > so check before this assignment. > > > > Signed-off-by: liguan

Re: [Qemu-devel] [PATCH] glib: add a compatibility interface for g_timeout_add_seconds

2013-03-26 Thread Stefan Hajnoczi
On Mon, Mar 25, 2013 at 08:21:13PM -, Anthony Liguori wrote: > Applied. Thanks. Thanks for applying. RHEL5 and other old buildslaves should turn green again now :). Stefan

Re: [Qemu-devel] [PATCH] hw/i386/pc: fix possible segment fault for port92_write

2013-03-26 Thread li guang
在 2013-03-22五的 12:07 +0100,Paolo Bonzini写道: > Il 22/03/2013 10:12, liguang ha scritto: > > e.g. > > $qemu-system-x86_64 -device port92 > > will report segment fault, > > for port92_write try a un-allocated > > assignment for a20_out. > > so check before this assignment. > > > > Signed-off-by: ligu

[Qemu-devel] [PATCH v15.1] Add pvpanic device driver

2013-03-26 Thread Hu Tao
pvpanic device is used to notify host(qemu) when guest panic happens. Signed-off-by: Hu Tao --- Paolo, Can I add your Signed-off-by? Since the original code is given by you. Thank you, Paolo :) src/acpi.c| 3 +++ src/ssdt-misc.dsl | 46 ++

Re: [Qemu-devel] [PATCH v15.1] Add pvpanic device driver

2013-03-26 Thread Paolo Bonzini
Il 26/03/2013 09:52, Hu Tao ha scritto: > pvpanic device is used to notify host(qemu) when guest panic happens. > > Signed-off-by: Hu Tao > --- > > Paolo, > > Can I add your Signed-off-by? Since the original code is given by you. Sure, as you prefer. Paolo > src/acpi.c| 3 +++ > sr

[Qemu-devel] [PATCH v15.1 resend] Add pvpanic device driver

2013-03-26 Thread Hu Tao
pvpanic device is used to notify host(qemu) when guest panic happens. Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- src/acpi.c| 3 +++ src/ssdt-misc.dsl | 46 ++ 2 files changed, 49 insertions(+) diff --git a/src/acpi.c b/src/acpi.c

Re: [Qemu-devel] [PATCH] VMXNET3: initialize rx_ridx to eliminate compile warning

2013-03-26 Thread Stefan Hajnoczi
On Tue, Mar 26, 2013 at 10:24:06AM +0800, Wenchao Xia wrote: > Gcc report "hw/vmxnet3.c:972: error: ‘rx_ridx’ may be used > uninitialized in this function", so fix it. > > Signed-off-by: Wenchao Xia > --- > hw/vmxnet3.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --

Re: [Qemu-devel] [PATCH] VMXNET3: initialize rx_ridx to eliminate compile warning

2013-03-26 Thread Stefan Hajnoczi
On Tue, Mar 26, 2013 at 10:24:06AM +0800, Wenchao Xia wrote: > Gcc report "hw/vmxnet3.c:972: error: ‘rx_ridx’ may be used > uninitialized in this function", so fix it. > > Signed-off-by: Wenchao Xia > --- > hw/vmxnet3.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Anthony: Pl

Re: [Qemu-devel] [PATCHv4 0/9] buffer_is_zero / migration optimizations

2013-03-26 Thread Paolo Bonzini
Il 26/03/2013 09:14, Peter Lieven ha scritto: > If noone objects I would use is_zero_page_2 and continue with v5 of > the patch set. As I am ooo for the next 8 days from tomorrow. i > prefer v3 as it has better performance if the non-zeroness is within > the 8*sizeof(VECTYPE) bytes and not in the f

Re: [Qemu-devel] [PATCH v15.1 4/6] pvpanic: add document of pvpanic

2013-03-26 Thread Paolo Bonzini
Il 26/03/2013 04:03, Hu Tao ha scritto: > Signed-off-by: Hu Tao > --- > docs/specs/pvpanic.txt | 35 +++ > 1 file changed, 35 insertions(+) > create mode 100644 docs/specs/pvpanic.txt > > diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt > new file mod

Re: [Qemu-devel] KVM call agenda for 2013-03-26

2013-03-26 Thread Stefan Hajnoczi
On Mon, Mar 25, 2013 at 08:13:34PM -0500, Rob Landley wrote: > On 03/25/2013 08:17:44 AM, Juan Quintela wrote: > > > >Hi > > > >Please send in any agenda topics you are interested in. > > > >Later, Juan. > > If Google summer of code is still open: > > http://qemu-project.org/Google_Summer_of_Co

Re: [Qemu-devel] [PATCH 2/2] vl.c: throw an error if iscsi is not supported

2013-03-26 Thread Stefan Hajnoczi
On Mon, Mar 25, 2013 at 02:34:01PM +, Peter Maydell wrote: > On 25 March 2013 14:10, Peter Lieven wrote: > > Am 25.03.2013 um 15:00 schrieb Stefan Hajnoczi : > >> On Thu, Mar 21, 2013 at 01:07:11PM +0100, Peter Lieven wrote: > >>> this patch adds a check for qemu_find_opts("iscsi") returning >

Re: [Qemu-devel] [PATCH] block: Add support for Secure Shell (ssh) block device.

2013-03-26 Thread Stefan Hajnoczi
On Mon, Mar 25, 2013 at 03:11:37PM +, Richard W.M. Jones wrote: > On Mon, Mar 25, 2013 at 03:36:22PM +0100, Kevin Wolf wrote: > > You don't have a bdrv_co_flush_to_disk, what does this mean? Is every > > write immediately flushed to the disk, is the driver unsafe by design, > > or is this just

Re: [Qemu-devel] [Bug 1158912] Re: QEMU Version 1.4.0 - SLIRP hangs VM

2013-03-26 Thread Stefan Hajnoczi
On Mon, Mar 25, 2013 at 08:57:46PM -, Kenneth Salerno wrote: > Result of git bisect: > > commit 837d1f978224f7e7b020c71ffb10b291952cc596 > Merge: a6fc23e 2b35e93 > Author: Blue Swirl > Date: Sat Jan 12 12:46:57 2013 + > > Merge branch 's390-reorg' of git://repo.or.cz/qemu/rth >

Re: [Qemu-devel] coroutine: hung when using gthread backend

2013-03-26 Thread Stefan Hajnoczi
On Tue, Mar 26, 2013 at 08:03:50AM +0100, Paolo Bonzini wrote: > Il 26/03/2013 03:50, Wenchao Xia ha scritto: > > When I using tcg with coroutine backend = gthread, > > x86_64-softmmu/qemu-system-x86_64 will hung. Any one > > working on it? > > coroutine backend gthread hardly works for qemu, on

Re: [Qemu-devel] coroutine: hung when using gthread backend

2013-03-26 Thread Peter Maydell
On 26 March 2013 09:54, Stefan Hajnoczi wrote: > On Tue, Mar 26, 2013 at 08:03:50AM +0100, Paolo Bonzini wrote: >> coroutine backend gthread hardly works for qemu, only qemu-io and qemu-img. > > Do you know why it doesn't work? Because nobody tests it? -- PMM

[Qemu-devel] [PATCHv5 04/10] buffer_is_zero: use vector optimizations if possible

2013-03-26 Thread Peter Lieven
performance gain on SSE2 is approx. 20-25%. altivec is not tested. performance for unsigned long arithmetic is unchanged. Signed-off-by: Peter Lieven Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- util/cutils.c |5 + 1 file changed, 5 insertions(+) diff --git a/util/cutils.c

[Qemu-devel] [PATCHv5 05/10] bitops: unroll while loop in find_next_bit()

2013-03-26 Thread Peter Lieven
this patch adopts the loop unrolling idea of bitmap_is_zero() to speed up the skipping of large areas with zeros in find_next_bit(). this routine is extensively used to find dirty pages in live migration. testing only the find_next_bit performance on a zeroed bitfield the loop onrolling decreased

[Qemu-devel] [PATCHv5 08/10] migration: do not sent zero pages in bulk stage

2013-03-26 Thread Peter Lieven
during bulk stage of ram migration if a page is a zero page do not send it at all. the memory at the destination reads as zero anyway. even if there is an madvise with QEMU_MADV_DONTNEED at the target upon receipt of a zero page I have observed that the target starts swapping if the memory is over

[Qemu-devel] [PATCHv5 01/10] move vector definitions to qemu-common.h

2013-03-26 Thread Peter Lieven
vector optimizations will now be used at various places not just in is_dup_page() in arch_init.c Signed-off-by: Peter Lieven --- arch_init.c | 20 include/qemu-common.h | 21 + 2 files changed, 21 insertions(+), 20 deletions(-) diff --git a

[Qemu-devel] [PATCHv5 07/10] migration: add an indicator for bulk state of ram migration

2013-03-26 Thread Peter Lieven
the first round of ram transfer is special since all pages are dirty and thus all memory pages are transferred to the target. this patch adds a boolean variable to track this stage. Signed-off-by: Peter Lieven Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- arch_init.c |3 +++ 1 fi

[Qemu-devel] [PATCHv5 03/10] cutils: add a function to find non-zero content in a buffer

2013-03-26 Thread Peter Lieven
this adds buffer_find_nonzero_offset() which is a SSE2/Altivec optimized function that searches for non-zero content in a buffer. the function starts full unrolling only after the first few chunks have been checked one by one. analyzing real memory page data has revealed that non-zero pages are no

[Qemu-devel] [PATCHv5 09/10] migration: do not search dirty pages in bulk stage

2013-03-26 Thread Peter Lieven
avoid searching for dirty pages just increment the page offset. all pages are dirty anyway. Signed-off-by: Peter Lieven Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- arch_init.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch_init.c b/arch_init.c in

[Qemu-devel] [PATCHv5 06/10] migration: search for zero instead of dup pages

2013-03-26 Thread Peter Lieven
virtually all dup pages are zero pages. remove the special is_dup_page() function and use the optimized buffer_find_nonzero_offset() function instead. here buffer_find_nonzero_offset() is used directly to avoid the unnecssary additional checks in buffer_is_zero(). raw performace gain checking 1 G

Re: [Qemu-devel] coroutine: hung when using gthread backend

2013-03-26 Thread Paolo Bonzini
Il 26/03/2013 10:54, Stefan Hajnoczi ha scritto: > On Tue, Mar 26, 2013 at 08:03:50AM +0100, Paolo Bonzini wrote: >> Il 26/03/2013 03:50, Wenchao Xia ha scritto: >>> When I using tcg with coroutine backend = gthread, >>> x86_64-softmmu/qemu-system-x86_64 will hung. Any one >>> working on it? >> >

[Qemu-devel] [PATCH 01/11] qemu-char: Rename opened to be_open

2013-03-26 Thread Hans de Goede
Rename the opened variable to be_open to reflect that it contains the opened state of the backend. Signed-off-by: Hans de Goede --- hw/usb/dev-serial.c | 2 +- hw/usb/redirect.c | 2 +- include/char/char.h | 2 +- qemu-char.c | 6 +++--- spice-qemu-char.c | 4 ++-- 5 files changed, 8

[Qemu-devel] [PATCHv5 10/10] migration: use XBZRLE only after bulk stage

2013-03-26 Thread Peter Lieven
at the beginning of migration all pages are marked dirty and in the first round a bulk migration of all pages is performed. currently all these pages are copied to the page cache regardless of whether they are frequently updated or not. this doesn't make sense since most of these pages are never t

[Qemu-devel] [PATCHv5 00/10] buffer_is_zero / migration optimizations

2013-03-26 Thread Peter Lieven
this is v5 of my patch series with various optimizations in zero buffer checking and migration tweaks. thanks especially to Eric Blake, Orit Wassermann and Paolo Bonzini for reviewing. v5: - move zero splat vector to a different patch - fix indentation of can_user_buffer_find_nonzero_offset() - d

[Qemu-devel] [PATCHv5 02/10] add a zero splat vector to qemu-common.h

2013-03-26 Thread Peter Lieven
Signed-off-by: Peter Lieven --- include/qemu-common.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/include/qemu-common.h b/include/qemu-common.h index d7ad3a7..9022646 100644 --- a/include/qemu-common.h +++ b/include/qemu-common.h @@ -453,6 +453,7 @@ void hexdump(const char *buf, FIL

[Qemu-devel] [PATCH 05/11] qemu-char: Cleanup: consolidate fe_open/fe_close into fe_set_open

2013-03-26 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/virtio-console.c | 4 ++-- include/char/char.h | 17 - qemu-char.c | 24 ++-- 3 files changed, 12 insertions(+), 33 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 2f7c3df..7c89990 100644 -

[Qemu-devel] [PATCH 03/11] qemu-char: Add fe_open tracking

2013-03-26 Thread Hans de Goede
Add tracking of the fe_open state to struct CharDriverState. Signed-off-by: Hans de Goede --- include/char/char.h | 1 + qemu-char.c | 8 2 files changed, 9 insertions(+) diff --git a/include/char/char.h b/include/char/char.h index dd8f39a..3174575 100644 --- a/include/char/cha

[Qemu-devel] [PATCH 04/11] qemu-char: Automatically do fe_open / fe_close on qemu_chr_add_handlers

2013-03-26 Thread Hans de Goede
Most frontends can't really determine if the guest actually has the frontend side open. So lets automatically generate fe_open / fe_close as soon as a frontend becomes ready (as signalled by calling qemu_chr_add_handlers) / becomes non ready (as signalled by setting all handlers to NULL). And allo

[Qemu-devel] [PATCH 0/11] chardev frontend open handling cleanup v2

2013-03-26 Thread Hans de Goede
This patch-series is the result of the "[PATCH 1/2] char: add qemu_chr_be_is_fe_connected" discussion thread. This patch series makes the frontend open concept both more explicit and generic, and significantly cleans up the surrounding code. Changes in v2: - Based on top of latest master - Add pr

[Qemu-devel] [PATCH 11/11] spice-qemu-char: Drop hackish vmc_register on spice_chr_write

2013-03-26 Thread Hans de Goede
Now that the core takes care of fe_open tracking we no longer need this hack. Signed-off-by: Hans de Goede --- spice-qemu-char.c | 1 - 1 file changed, 1 deletion(-) diff --git a/spice-qemu-char.c b/spice-qemu-char.c index d249829..535f955 100644 --- a/spice-qemu-char.c +++ b/spice-qemu-char.c

[Qemu-devel] [PATCH 07/11] qemu-char: Move incrementing of avail_connections to qdev-properties-system

2013-03-26 Thread Hans de Goede
The decrement of avail_connections is done in qdev-properties-system move the increment there too for proper balancing of the calls. Signed-off-by: Hans de Goede --- hw/qdev-properties-system.c | 6 -- qemu-char.c | 2 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH 02/11] qemu-char: Rename qemu_chr_generic_open to qemu_chr_be_generic_open

2013-03-26 Thread Hans de Goede
To better reflect that it is for handling a backend being opened. Signed-off-by: Hans de Goede --- backends/baum.c | 2 +- include/char/char.h | 2 +- qemu-char.c | 24 ui/console.c| 2 +- ui/gtk.c| 2 +- 5 files changed, 16 insertions

[Qemu-devel] [PATCH 06/11] qemu-char: Consolidate guest_close/guest_open into a set_fe_open callback

2013-03-26 Thread Hans de Goede
Signed-off-by: Hans de Goede --- include/char/char.h | 3 +-- qemu-char.c | 10 +++--- spice-qemu-char.c | 17 +++-- 3 files changed, 11 insertions(+), 19 deletions(-) diff --git a/include/char/char.h b/include/char/char.h index 3c8dd28..1457e80 100644 --- a/include/ch

[Qemu-devel] [PATCH 08/11] qemu-char: add_handlers: Don't re-send the be_open event on unregister

2013-03-26 Thread Hans de Goede
Resending the be_open event only is useful when a frontend is registering, not when it is unregistering. Signed-off-by: Hans de Goede --- qemu-char.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 368e7f5..edf3779 100644 --- a/qemu-char.c +++

[Qemu-devel] [PATCH 10/11] virtio-serial: propagate guest_connected to the port on post_load

2013-03-26 Thread Hans de Goede
From: Alon Levy When migrating a host with with a spice agent running the mouse becomes non operational after the migration due to the agent state being inconsistent between the guest and the client. After migration the spicevmc backend on the destination has never been notified of the (non 0) g

[Qemu-devel] [PATCH 09/11] virtio-serial: Consolidate guest_open/guest_close into set_guest_connected

2013-03-26 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/virtio-console.c| 23 +-- hw/virtio-serial-bus.c | 15 +-- hw/virtio-serial.h | 6 ++ 3 files changed, 12 insertions(+), 32 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 7c89990..284180f

Re: [Qemu-devel] [PATCHv5 02/10] add a zero splat vector to qemu-common.h

2013-03-26 Thread Paolo Bonzini
Il 26/03/2013 10:58, Peter Lieven ha scritto: > Signed-off-by: Peter Lieven > --- > include/qemu-common.h |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/qemu-common.h b/include/qemu-common.h > index d7ad3a7..9022646 100644 > --- a/include/qemu-common.h > +++ b/include/qem

Re: [Qemu-devel] [PATCH v2] block: Add support for Secure Shell (ssh) block device.

2013-03-26 Thread Stefan Hajnoczi
On Mon, Mar 25, 2013 at 11:49:41PM +, Richard W.M. Jones wrote: > From: "Richard W.M. Jones" > > qemu-system-x86_64 -drive file=ssh://hostname/some/image > > QEMU will ssh into 'hostname' and open '/some/image' which is made > available as a standard block device. > > You can specify a us

Re: [Qemu-devel] [PATCHv5 02/10] add a zero splat vector to qemu-common.h

2013-03-26 Thread Peter Lieven
Am 26.03.2013 um 11:14 schrieb Paolo Bonzini : > Il 26/03/2013 10:58, Peter Lieven ha scritto: >> Signed-off-by: Peter Lieven >> --- >> include/qemu-common.h |3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/include/qemu-common.h b/include/qemu-common.h >> index d7ad3a7..9022646

Re: [Qemu-devel] [PATCHv5 02/10] add a zero splat vector to qemu-common.h

2013-03-26 Thread Paolo Bonzini
Il 26/03/2013 11:17, Peter Lieven ha scritto: >> > >> > C trivia of the day: this can be written simply as >> > >> > (VECTYPE) {0} > you are the first who mentions this ;-) > > respin? Yes, please. Paolo

Re: [Qemu-devel] [PATCHv5 02/10] add a zero splat vector to qemu-common.h

2013-03-26 Thread Peter Lieven
Am 26.03.2013 um 11:17 schrieb Paolo Bonzini : > Il 26/03/2013 11:17, Peter Lieven ha scritto: C trivia of the day: this can be written simply as (VECTYPE) {0} >> you are the first who mentions this ;-) >> >> respin? > > Yes, please. Ok, I wait if someone finds something

[Qemu-devel] [PATCH v2 11/11] hw/versatile_pci: Drop unnecessary vpb_pci_config_addr()

2013-03-26 Thread Peter Maydell
Drop the vpb_pci_config_addr() function -- it is unnecessary since the size of the memory regions means the hwaddr is always within the 24 bit size. (This function was probably a leftover from when read/write functions were called with absolute addresses rather than relative ones.) Signed-off-by:

[Qemu-devel] [PATCH v2 10/11] versatile_pci: Expose PCI memory space to system

2013-03-26 Thread Peter Maydell
The VersatilePB's PCI controller exposes the PCI memory space to the system via three regions controlled by the mapping control registers. Implement this so that guests can actually use MMIO-BAR PCI cards. Signed-off-by: Peter Maydell --- hw/arm/realview.c|3 +++ hw/arm/versatilepb.c |

Re: [Qemu-devel] [PATCHv5 03/10] cutils: add a function to find non-zero content in a buffer

2013-03-26 Thread Juan Quintela
Peter Lieven wrote: > this adds buffer_find_nonzero_offset() which is a SSE2/Altivec > optimized function that searches for non-zero content in a > buffer. > > the function starts full unrolling only after the first few chunks have > been checked one by one. analyzing real memory page data has rev

[Qemu-devel] [PATCH v3] block: Add support for Secure Shell (ssh) block device.

2013-03-26 Thread Richard W.M. Jones
From: "Richard W.M. Jones" qemu-system-x86_64 -drive file=ssh://hostname/some/image QEMU will ssh into 'hostname' and open '/some/image' which is made available as a standard block device. You can specify a username (ssh://user@host/...) and/or a port number (ssh://host:port/...). Current li

Re: [Qemu-devel] [PATCH v2] block: Add support for Secure Shell (ssh) block device.

2013-03-26 Thread Richard W.M. Jones
Thanks -- I've included all feedback up to this point in version 3, which I'll post in a moment. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative

Re: [Qemu-devel] [PATCHv5 03/10] cutils: add a function to find non-zero content in a buffer

2013-03-26 Thread Juan Quintela
Peter Lieven wrote: > this adds buffer_find_nonzero_offset() which is a SSE2/Altivec > optimized function that searches for non-zero content in a > buffer. > > the function starts full unrolling only after the first few chunks have > been checked one by one. analyzing real memory page data has rev

Re: [Qemu-devel] [PATCHv5 03/10] cutils: add a function to find non-zero content in a buffer

2013-03-26 Thread Peter Lieven
Am 26.03.2013 um 11:38 schrieb Juan Quintela : > Peter Lieven wrote: >> this adds buffer_find_nonzero_offset() which is a SSE2/Altivec >> optimized function that searches for non-zero content in a >> buffer. >> >> the function starts full unrolling only after the first few chunks have >> been c

[Qemu-devel] [PATCH v2 09/11] arm/realview: Fix mapping of PCI regions

2013-03-26 Thread Peter Maydell
Fix the mapping of the PCI regions for the realview board, which were all incorrect. (This was never noticed because the Linux kernel doesn't actually include a PCI driver for the realview boards.) Signed-off-by: Peter Maydell --- hw/arm/realview.c | 18 +- 1 file changed, 9 in

[Qemu-devel] [PATCH v2 06/11] versatile_pci: Put the host bridge PCI device at slot 29

2013-03-26 Thread Peter Maydell
On real hardware the host bridge appears as a PCI device in slot 29, so make QEMU put its host bridge in that slot too. Signed-off-by: Peter Maydell --- hw/versatile_pci.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/versatile_pci.c b/hw/versatile_pci.c index 777e9b1..576e619 1006

[Qemu-devel] [PATCH v2 05/11] versatile_pci: Use separate PCI I/O space rather than system I/O space

2013-03-26 Thread Peter Maydell
Rather than overloading the system I/O space (which doesn't even make any sense on ARM) for PCI I/O, create an memory region in the PCI controller and use that to represent the I/O space. Signed-off-by: Peter Maydell --- hw/versatile_pci.c | 17 + 1 file changed, 13 insertions(

[Qemu-devel] [PATCH v2 01/11] versatile_pci: Fix hardcoded tabs

2013-03-26 Thread Peter Maydell
There is just one line in this source file with a hardcoded tab indent, so just fix it. Signed-off-by: Peter Maydell --- hw/versatile_pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/versatile_pci.c b/hw/versatile_pci.c index 0b97a40..16ce5d1 100644 --- a/hw/versat

[Qemu-devel] [PATCH v2 02/11] versatile_pci: Expose PCI I/O region on Versatile PB

2013-03-26 Thread Peter Maydell
Comments in the QEMU source code claim that the version of the PCI controller on the VersatilePB board doesn't support the PCI I/O region, but this is incorrect; expose that region, map it in the correct location, and drop the misleading comments. This change removes the only currently implemented

[Qemu-devel] [PATCH v2 07/11] versatile_pci: Implement the correct PCI IRQ mapping

2013-03-26 Thread Peter Maydell
Implement the correct IRQ mapping for the Versatile PCI controller; it differs between realview and versatile boards, but the previous QEMU implementation was correct only for the first PCI card on a versatile board, since we weren't swizzling IRQs based on the slot number. Since this change would

[Qemu-devel] [PATCH v2 03/11] versatile_pci: Update to realize and instance init functions

2013-03-26 Thread Peter Maydell
Update the Versatile PCI controller to use a realize function rather than SysBusDevice::init. To reflect the fact that the 'realview_pci' class is taking most of its implementation from 'versatile_pci' (and to make the QOM casts work) we make 'realview_pci' a subclass of 'versatile_pci'. Signed-of

[Qemu-devel] [PATCH v2 04/11] versatile_pci: Change to subclassing TYPE_PCI_HOST_BRIDGE

2013-03-26 Thread Peter Maydell
Change versatile_pci to subclass TYPE_PCI_HOST_BRIDGE and generally handle PCI in a more QOM-like fashion. Signed-off-by: Peter Maydell --- hw/versatile_pci.c | 41 ++--- 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/hw/versatile_pci.c b/hw

[Qemu-devel] [PATCH v2 00/11] Fix versatile_pci (now without breaking linux)

2013-03-26 Thread Peter Maydell
This patch series fixes a number of serious bugs in our emulation of the PCI controller found on VersatilePB and the early Realview boards: * our interrupt mapping was totally wrong * we weren't implementing the PCI memory windows * the I/O window wasn't mapped on VersatilePB * realview mapped

Re: [Qemu-devel] [PATCHv5 00/10] buffer_is_zero / migration optimizations

2013-03-26 Thread Juan Quintela
Peter Lieven wrote: > this is v5 of my patch series with various optimizations in > zero buffer checking and migration tweaks. > > thanks especially to Eric Blake, Orit Wassermann and Paolo Bonzini > for reviewing. > > v5: > - move zero splat vector to a different patch > - fix indentation of can_

[Qemu-devel] [PATCH v2 08/11] versatile_pci: Implement the PCI controller's control registers

2013-03-26 Thread Peter Maydell
The versatile_pci PCI controller has a set of control registers which handle the mapping between PCI and system address spaces. Implement these registers (though for now they have no effect since we don't implement mapping PCI space into system memory at all). The most natural order for our sysbus

Re: [Qemu-devel] [PATCH v3] New QMP command query-cpu-max and HMP command cpu_max

2013-03-26 Thread Michal Novotny
On 03/25/2013 07:37 PM, Luiz Capitulino wrote: > On Mon, 25 Mar 2013 17:31:33 +0100 > Michal Novotny wrote: > >> These commands return the maximum number of CPUs supported by the >> currently running emulator instance, as defined in its QEMUMachine >> struct. > I've applied this patch to the QMP

Re: [Qemu-devel] [PATCH v2 07/11] versatile_pci: Implement the correct PCI IRQ mapping

2013-03-26 Thread Arnd Bergmann
On Tuesday 26 March 2013, Peter Maydell wrote: > > Implement the correct IRQ mapping for the Versatile PCI controller; it > differs between realview and versatile boards, but the previous QEMU > implementation was correct only for the first PCI card on a versatile > board, since we weren't swizzli

Re: [Qemu-devel] [PATCHv5 00/10] buffer_is_zero / migration optimizations

2013-03-26 Thread Peter Lieven
Am 26.03.2013 um 11:46 schrieb Juan Quintela : > Peter Lieven wrote: >> this is v5 of my patch series with various optimizations in >> zero buffer checking and migration tweaks. >> >> thanks especially to Eric Blake, Orit Wassermann and Paolo Bonzini >> for reviewing. >> >> v5: >> - move zero

Re: [Qemu-devel] [PATCH v2 07/11] versatile_pci: Implement the correct PCI IRQ mapping

2013-03-26 Thread Peter Maydell
On 26 March 2013 10:54, Arnd Bergmann wrote: > Yes, very good. We will probably introduce sparse irq support on > versatile in the near future, and then the value we write into the > PCI_INTERRUPT_LINE field will become arbitrary from qemu's point > of view, but I will make sure that we fix the i

Re: [Qemu-devel] [PATCH v2 07/11] versatile_pci: Implement the correct PCI IRQ mapping

2013-03-26 Thread Arnd Bergmann
On Tuesday 26 March 2013, Peter Maydell wrote: > > On 26 March 2013 10:54, Arnd Bergmann wrote: > > Yes, very good. We will probably introduce sparse irq support on > > versatile in the near future, and then the value we write into the > > PCI_INTERRUPT_LINE field will become arbitrary from qemu

Re: [Qemu-devel] [PATCH v5 00/10] virtio-scsi refactoring.

2013-03-26 Thread Peter Maydell
On 21 March 2013 14:15, wrote: > From: KONRAD Frederic > > This is the next part of virtio-refactoring. > > Basically it creates virtio-scsi device which extends virtio-device. > Then a virtio-scsi can be connected on a virtio-bus. > virtio-scsi-pci, virtio-scsi-s390x, virtio-scsi-ccw are create

[Qemu-devel] selecting a sparc framebuffer from command line

2013-03-26 Thread Artyom Tarasenko
It looks like we will have more framebuffers beside TCX in the near future. One way to use them would be to make new machines combining a base machine name with a framebuffer name, like ss5tcx and ss5cg3, but I guess this would produce too many machines if we have more than 2 framebuffers. Should

Re: [Qemu-devel] [PATCH v2 07/11] versatile_pci: Implement the correct PCI IRQ mapping

2013-03-26 Thread Peter Maydell
On 26 March 2013 11:08, Arnd Bergmann wrote: > On Tuesday 26 March 2013, Peter Maydell wrote: >> On 26 March 2013 10:54, Arnd Bergmann wrote: >> > Yes, very good. We will probably introduce sparse irq support on >> > versatile in the near future, and then the value we write into the >> > PCI_INT

[Qemu-devel] [Bug 1159605] Re: run command hangs using "-M none"

2013-03-26 Thread Shehbaz Jaffer
Andreas, sorry. My Bad. But could you please confirm that 3rd and 4th cmd run correctly/ lead to stall? Do you not get a help msg (unlike an infinite hang mentioned by Jiamswang ) that I mentioned in the comment? I tried running the given commands on my machine and the 1st and 2nd commands run jus

[Qemu-devel] [PATCH] sh7750: Fix crash when accessing PVR/PRR/CVR

2013-03-26 Thread Peter Maydell
Commit b350ab75 causes segfaults on accesses to PVR/PRR/CVR because it tries to call SUPERH_CPU_GET_CLASS() on a pointer that isn't a QOM object. Fix this by getting the actual QOM CPU object first. Signed-off-by: Peter Maydell --- Tested with the r2d image/instructions from https://oss.renesas.c

[Qemu-devel] [PATCH] hw/tcx: Remove unused 'addr' field and the property that sets it

2013-03-26 Thread Peter Maydell
Remove the 'addr' field from TCXState (since it is completely unused), also the qdev property which sets it. This seems to be a relic from many years past; devices don't need to know where they are mapped. Signed-off-by: Peter Maydell --- Random minor cleanup, but I'm hoping we might be able to g

[Qemu-devel] [PULL 0/4] QMP queue

2013-03-26 Thread Luiz Capitulino
The changes (since dcadaa9b40d6019ac18d6fd7763d43048ef79218) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Corey Bryant (2): QMP: Remove duplicate TPM type from query-tpm QMP: TPM QMP and man page documentation updates Igor Mammedov (1): qm

[Qemu-devel] [PULL 3/4] qmp: fix handling of boolean values in qmp-shell

2013-03-26 Thread Luiz Capitulino
From: Igor Mammedov qmp-shell converts only integer arguments and the rest is assumed to be strings which are faithfully sent as quoted strings by json. But QEMU refuses to accept qmp command with boolean argument whose value is escaped as string. Fix it by special-casing true/false keywords and

[Qemu-devel] [PULL 1/4] QMP: Remove duplicate TPM type from query-tpm

2013-03-26 Thread Luiz Capitulino
From: Corey Bryant Signed-off-by: Corey Bryant Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster Signed-off-by: Luiz Capitulino --- hmp.c| 8 qapi-schema.json | 12 tpm/tpm.c| 9 - 3 files changed, 12 insertions(+), 17 deletions(-) di

[Qemu-devel] [PULL 2/4] QMP: TPM QMP and man page documentation updates

2013-03-26 Thread Luiz Capitulino
From: Corey Bryant Signed-off-by: Corey Bryant Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster Signed-off-by: Luiz Capitulino --- qemu-options.hx | 3 ++- qmp-commands.hx | 58 + 2 files changed, 60 insertions(+), 1 deletion(-)

[Qemu-devel] [PULL 4/4] New QMP command query-cpu-max and HMP command cpu_max

2013-03-26 Thread Luiz Capitulino
From: Michal Novotny These commands return the maximum number of CPUs supported by the currently running emulator instance, as defined in its QEMUMachine struct. Signed-off-by: Michal Novotny Signed-off-by: Luiz Capitulino --- hmp-commands.hx | 2 ++ hmp.c| 8 hmp.h

Re: [Qemu-devel] [PATCH 07/11] qemu-char: Move incrementing of avail_connections to qdev-properties-system

2013-03-26 Thread Paolo Bonzini
Il 26/03/2013 11:07, Hans de Goede ha scritto: > The decrement of avail_connections is done in qdev-properties-system move > the increment there too for proper balancing of the calls. > > Signed-off-by: Hans de Goede > --- > hw/qdev-properties-system.c | 6 -- > qemu-char.c |

Re: [Qemu-devel] [PATCH 2/2] pflash_cfi01: Implement migration support

2013-03-26 Thread Peter Maydell
On 19 March 2013 18:24, Peter Maydell wrote: > Add a vmstate to pflash_cfi01, so that it can be live migrated. > > XXX this device is in pc, so does this break cross version > migration??? Oops. I checked that this was going to work ok, but forgot to remove the XXX markers. I'm planning to put th

Re: [Qemu-devel] [PATCH 07/11] qemu-char: Move incrementing of avail_connections to qdev-properties-system

2013-03-26 Thread Hans de Goede
Hi, On 03/26/2013 02:07 PM, Paolo Bonzini wrote: Il 26/03/2013 11:07, Hans de Goede ha scritto: The decrement of avail_connections is done in qdev-properties-system move the increment there too for proper balancing of the calls. Signed-off-by: Hans de Goede --- hw/qdev-properties-system.c |

Re: [Qemu-devel] [PATCH 11/12 v2] qmp: add cpu-set qmp command

2013-03-26 Thread Igor Mammedov
On Mon, 25 Mar 2013 14:22:36 -0600 Eric Blake wrote: > On 03/25/2013 02:09 PM, Luiz Capitulino wrote: > > On Mon, 25 Mar 2013 16:35:11 +0100 > > Igor Mammedov wrote: > > > > >> +void qmp_cpu_set(int64_t id, const bool online, Error **errp) > >> +{ > >> +if (online) { > >> +do_cpu_h

Re: [Qemu-devel] [PATCH 07/11] qemu-char: Move incrementing of avail_connections to qdev-properties-system

2013-03-26 Thread Paolo Bonzini
Il 26/03/2013 14:30, Hans de Goede ha scritto: > Hi, > > On 03/26/2013 02:07 PM, Paolo Bonzini wrote: >> Il 26/03/2013 11:07, Hans de Goede ha scritto: >>> The decrement of avail_connections is done in qdev-properties-system >>> move >>> the increment there too for proper balancing of the calls. >

[Qemu-devel] [RFC][PATCH 00/22] instrument: Let the user wrap/override specific event tracing routines

2013-03-26 Thread Lluís Vilanova
NOTE: Applies on top of the "trace: Generic event state description" series (already in the tracing tree), and is based on revision a4bcea3 from master. TODO: Make sure no TCG code is executing during 'instr_unload' (qemu_cpu_kick? tb_lock?) The whole set of patch series is avai

  1   2   3   >