From: Dunrong Huang
"--enable-debug-info" and "--disable-debug-info" were not shown
in --help output.
Signed-off-by: Dunrong Huang
---
configure | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configure b/configure
index f2af714..61e71fa 100755
--- a/configure
+++ b/configure
@@ -1057,6
The new parameter is unused yet.
This part was missing in commit 787e4a8500020695eb391e2f1cc4767ee071d441.
Cc: Kevin Wolf
Cc: Eric Blake
Signed-off-by: Stefan Weil
---
block/raw-win32.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/block/raw-win32.c b/block/raw-
From: Liu Yuan
Commit 787e4a85 [block: Add options QDict to bdrv_file_open() prototypes] didn't
update rbd.c accordingly.
Cc: Kevin Wolf
Cc: Stefan Hajnoczi
Signed-off-by: Liu Yuan
---
block/rbd.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/rbd.c b/block/rb
The type cast must use tcg_target_long instead of long.
This makes a difference for hosts where sizeof(long) != sizeof(void *).
Cc: Anthony Green
Cc: Blue Swirl
Signed-off-by: Stefan Weil
---
target-moxie/translate.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target
Am 24.03.2013 08:41, schrieb Liu Yuan:
> From: Liu Yuan
>
> Commit 787e4a85 [block: Add options QDict to bdrv_file_open() prototypes]
> didn't
> update rbd.c accordingly.
>
> Cc: Kevin Wolf
> Cc: Stefan Hajnoczi
> Signed-off-by: Liu Yuan
> ---
> block/rbd.c |3 ++-
> 1 file changed, 2 ins
On Fri, Mar 22, 2013 at 09:25:13AM -0600, Alex Williamson wrote:
> On Thu, 2013-03-21 at 18:56 +0200, Michael S. Tsirkin wrote:
> > On Tue, Mar 19, 2013 at 04:24:47PM -0600, Alex Williamson wrote:
> > > Enable PCIe devices to negotiate links. This upgrades our root ports
> > > and switches to adve
I am reviewing that for the MIPS part, and I am not really used to the
linux-user code, so a review from someone familiar with it would be
appreciated.
I added Richard Henderson and Blue Swirl in Cc: as alpha and sparc are
also affected by this issue.
On Mon, Mar 18, 2013 at 11:47:05PM +0100, Pe
On Sun, Mar 24, 2013 at 12:43:38AM -0400, Anthony Green wrote:
> Here's a fix for the build problem identified by Aurelien Jano here:
> http://lists.gnu.org/archive/html/qemu-devel/2013-03/msg04177.html
>
> I hadn't tested with FDT enabled recently.
>
> Thanks!
>
> AG
>
> Signed-off-by: Anthony
$ ./x86_64-linux-user/qemu-x86_64 bash64
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
Segmentation Fault
$ gdb x86_64-linux-user/qemu-x86_64
(gdb) ru bash64
Program received signal SIGSEGV, Segmentation fault.
disas_insn (s=s@entry=0xcf98, pc_start=18446744073699066880)
On 24 March 2013 10:43, Michael Tokarev wrote:
> $ ./x86_64-linux-user/qemu-x86_64 bash64
> qemu: uncaught target signal 11 (Segmentation fault) - core dumped
> Segmentation Fault
Are 64 bit linux-user guests on 32 bit hosts supposed to work?
I would expect them to be at best pretty unreliable.
Comments in the QEMU source code claim that the version of the PCI
controller on the VersatilePB board doesn't support the PCI I/O
region, but this is incorrect; expose that region, map it in the
correct location, and drop the misleading comments.
This change removes the only currently implemented
There is just one line in this source file with a hardcoded tab
indent, so just fix it.
Signed-off-by: Peter Maydell
---
hw/versatile_pci.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/versatile_pci.c b/hw/versatile_pci.c
index 0b97a40..16ce5d1 100644
--- a/hw/versat
The versatile_pci PCI controller has a set of control registers which
handle the mapping between PCI and system address spaces. Implement
these registers (though for now they have no effect since we don't
implement mapping PCI space into system memory at all).
The most natural order for our sysbus
Implement the correct IRQ mapping for the Versatile PCI controller; it
differs between realview and versatile boards, but the previous QEMU
implementation was correct only for the first PCI card on a versatile
board, since we weren't swizzling IRQs based on the slot number.
Note that this change w
On real hardware the host bridge appears as a PCI device in slot 29,
so make QEMU put its host bridge in that slot too.
Signed-off-by: Peter Maydell
---
hw/versatile_pci.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/versatile_pci.c b/hw/versatile_pci.c
index 777e9b1..576e619 1006
Update the Versatile PCI controller to use a realize function rather
than SysBusDevice::init. To reflect the fact that the 'realview_pci'
class is taking most of its implementation from 'versatile_pci' (and
to make the QOM casts work) we make 'realview_pci' a subclass of
'versatile_pci'.
Signed-of
Rather than overloading the system I/O space (which doesn't even make
any sense on ARM) for PCI I/O, create an memory region in the PCI
controller and use that to represent the I/O space.
Signed-off-by: Peter Maydell
---
hw/versatile_pci.c | 17 +
1 file changed, 13 insertions(
Fix the mapping of the PCI regions for the realview board, which were
all incorrect. (This was never noticed because the Linux kernel
doesn't actually include a PCI driver for the realview boards.)
Signed-off-by: Peter Maydell
---
hw/arm/realview.c | 18 +-
1 file changed, 9 in
This patch series fixes a number of serious bugs in our emulation of
the PCI controller found on VersatilePB and the early Realview boards:
* our interrupt mapping was totally wrong
* we weren't implementing the PCI memory windows
* the I/O window wasn't mapped on VersatilePB
* realview mapped
Change versatile_pci to subclass TYPE_PCI_HOST_BRIDGE and generally
handle PCI in a more QOM-like fashion.
Signed-off-by: Peter Maydell
---
hw/versatile_pci.c | 41 ++---
1 file changed, 30 insertions(+), 11 deletions(-)
diff --git a/hw/versatile_pci.c b/hw
The VersatilePB's PCI controller exposes the PCI memory space to the
system via three regions controlled by the mapping control registers.
Implement this so that guests can actually use MMIO-BAR PCI cards.
Signed-off-by: Peter Maydell
---
hw/arm/realview.c|3 +++
hw/arm/versatilepb.c |
Hi,
On 03/22/2013 06:11 PM, Anthony Liguori wrote:
Hans de Goede writes:
If the qemu-char.c code did:
int qemu_chr_fe_write(...) {
if (!s->fe_open) {
qemu_chr_fe_open(s);
}
...
}
That would be one thing. It's a hack, but a more reasonable hack than
doing this in
This patch-series is the result of the
"[PATCH 1/2] char: add qemu_chr_be_is_fe_connected" discussion thread.
This patch series (tries to) make(s) the frontend open concept both more
explicit and generic, and significantly cleans up the surrounding code.
Regards,
Hans
Rename the opened variable to be_open to reflect that it contains the
opened state of the backend.
Signed-off-by: Hans de Goede
---
hw/usb/dev-serial.c | 2 +-
hw/usb/redirect.c | 2 +-
include/char/char.h | 2 +-
qemu-char.c | 6 +++---
spice-qemu-char.c | 4 ++--
5 files changed, 8
To better reflect that it is for handling a backend being opened.
Signed-off-by: Hans de Goede
---
backends/baum.c | 2 +-
include/char/char.h | 2 +-
qemu-char.c | 24
ui/console.c| 2 +-
ui/gtk.c| 2 +-
5 files changed, 16 insertions
Most frontends can't really determine if the guest actually has the frontend
side open. So lets automatically generate fe_open / fe_close as soon as a
frontend becomes ready (as signalled by calling qemu_chr_add_handlers) /
becomes non ready (as signalled by setting all handlers to NULL).
And allo
Signed-off-by: Hans de Goede
---
hw/virtio-console.c| 23 +--
hw/virtio-serial-bus.c | 15 +--
hw/virtio-serial.h | 6 ++
3 files changed, 12 insertions(+), 32 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index c0d41c5..e28c54f
Signed-off-by: Hans de Goede
---
include/char/char.h | 3 +--
qemu-char.c | 10 +++---
spice-qemu-char.c | 17 +++--
3 files changed, 11 insertions(+), 19 deletions(-)
diff --git a/include/char/char.h b/include/char/char.h
index 3c8dd28..1457e80 100644
--- a/include/ch
Add tracking of the fe_open state to struct CharDriverState.
Signed-off-by: Hans de Goede
---
include/char/char.h | 1 +
qemu-char.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/include/char/char.h b/include/char/char.h
index dd8f39a..3174575 100644
--- a/include/char/char.h
++
Signed-off-by: Hans de Goede
---
hw/virtio-console.c | 4 ++--
include/char/char.h | 17 -
qemu-char.c | 19 +--
3 files changed, 11 insertions(+), 29 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index 209ea38..c0d41c5 100644
--- a/
Now that the core takes care of fe_open tracking we no longer need this hack.
Signed-off-by: Hans de Goede
---
spice-qemu-char.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/spice-qemu-char.c b/spice-qemu-char.c
index ba59374..7e6bd2d 100644
--- a/spice-qemu-char.c
+++ b/spice-qemu-char.c
usb-serial has a qdev chardev property, and hw/qdev-properties-system.c
already contains:
static void release_chr(Object *obj, const char *name, void *opaque)
{
DeviceState *dev = DEVICE(obj);
Property *prop = opaque;
CharDriverState **ptr = qdev_get_prop_ptr(dev, prop);
if (*ptr)
usb-serial has a qdev chardev property, and hw/qdev-properties-system.c
already contains:
static void release_chr(Object *obj, const char *name, void *opaque)
{
DeviceState *dev = DEVICE(obj);
Property *prop = opaque;
CharDriverState **ptr = qdev_get_prop_ptr(dev, prop);
if (*ptr)
Here is a new attempt on fixing the spicevmc needing the guest_connected
value post-migration, as discussed in various other threads.
Note this patch applies on top of my frontend-open handling cleanup series I
just posted.
Signed-off-by: Hans de Goede
From: Alon Levy
When migrating a host with with a spice agent running the mouse becomes
non operational after the migration due to the agent state being
inconsistent between the guest and the client.
After migration the spicevmc backend on the destination has never been notified
of the (non 0) g
Eric Blake wrote:
> You also need to add a line documenting this field:
>
> # @ifname: #optional Set the interface name that will be used (since
> 1.5).
Done. I also added an example with -netdev and -device
(seems this question is not covered in docs).
Signed-off-by: Alexandre Kandalintsev
-
24.03.2013 14:59, Peter Maydell wrote:
> On 24 March 2013 10:43, Michael Tokarev wrote:
>> $ ./x86_64-linux-user/qemu-x86_64 bash64
>> qemu: uncaught target signal 11 (Segmentation fault) - core dumped
>> Segmentation Fault
>
> Are 64 bit linux-user guests on 32 bit hosts supposed to work?
> I wo
At the moment registering an MR breaks COW. If the application does not
care that adapter sees stale data (for example, it tracks writes
reregisters and resends), it can use a new IBV_ACCESS_GIFT flag to
prevent registration from breaking COW.
The semantics are similar to that of SPLICE_F_GIFT th
At the moment registering an MR breaks COW. This breaks memory
overcommit for users such as KVM: we have a lot of COW pages, e.g.
instances of the zero page or pages shared using KSM.
If the application does not care that adapter sees stale data (for
example, it tracks writes reregisters and rese
On Sun, Mar 24, 2013 at 11:32:30AM +, Peter Maydell wrote:
> This patch series fixes a number of serious bugs in our emulation of
> the PCI controller found on VersatilePB and the early Realview boards:
> * our interrupt mapping was totally wrong
> * we weren't implementing the PCI memory win
On 24 March 2013 15:58, Aurelien Jarno wrote:
> On Sun, Mar 24, 2013 at 11:32:30AM +, Peter Maydell wrote:
>> This patch series fixes a number of serious bugs in our emulation of
>> the PCI controller found on VersatilePB and the early Realview boards:
>> Patchset tested on both versatilepb a
A second patchset to add dump-guest-memory support for ARM.
This version of the patchset addresses the following comments from the
previous posting, and also adds some more patches to the core dump code
(patch #4 and #6):
- memset prstatus to 0 in x86_64_write_elf64_note()
- handle big endian i
The files dump-guest-memory are created as read-only even for the owner.
This non-standard behaviour makes it annoying to deal with the dump
files (eg. rm -f is needed to delete them or saving a new dump by
overwriting the previous one is not possible). Change the code to
generate files with write
Extract out the ELF note size function from i386 so we can use it from
other targets.
Signed-off-by: Rabin Vincent
---
dump.c | 15 +++
include/sysemu/dump.h |2 ++
target-i386/arch_dump.c | 14 ++
3 files changed, 19 insertions(+), 12 deletions
Make a common helper function out of the x86 code to add ELF notes.
Signed-off-by: Rabin Vincent
---
dump.c | 51
include/sysemu/dump.h |4 +
target-i386/arch_dump.c | 208 +++
3 files changed, 104 insertions(+),
dump.c won't build without the functions from memory_mapping.c (and
memory_mapping-stub.c does not help there), so build memory_mapping.c
when CONFIG_HAVE_CORE_DUMP is set.
dump.c:84: undefined reference to `memory_mapping_list_free'
dump.c:819: undefined reference to `memory_mapping_list_init
RAMBlock.offset does not provide the physical address of the memory
region. This is available in the MemoryRegion's address. The wrong
usage leads to incorrect physical addreses in the ELF. Fix it.
Signed-off-by: Rabin Vincent
---
dump.c| 19 +++
include/exec
Enable support for the dump-guest-memory monitor command for ARM.
Cc: Peter Maydell
Signed-off-by: Rabin Vincent
---
configure|2 +-
target-arm/Makefile.objs |2 +-
target-arm/arch_dump.c | 61 ++
3 files changed, 63 insert
Am 27.02.2013 10:37, schrieb Jan Kiszka:
> On 2013-02-27 10:33, Andreas Färber wrote:
>> Am 27.02.2013 10:15, schrieb Jan Kiszka:
>>> Several issues fixed:
>>> - We were missing a bunch of feature lists. Fix this by simply dumping
>>>the meta list feature_word_info.
>>> - kvm_enabled() cannot
On 2013-03-18 12:12, Gerd Hoffmann wrote:
> Hi,
>
> This pull adds efi support to our nic roms.
>
> Patches have been posted here for review:
> https://lists.nongnu.org/archive/html/qemu-devel/2013-03/msg00344.html
>
> As there have been no changes (other than a rebase to master)
> I'm not pos
On 2013-02-18 22:47, Anthony Liguori wrote:
> This series implements an idea from Paolo to introduce flow control
> in the char layer by converting all char backends to use GIOChannels
> internally. Then we can just use the existing IO watch support in glib
> to implement flow control.
>
> This i
On 2013-02-25 16:44, Jan Kiszka wrote:
> On 2013-02-25 16:39, Anthony Liguori wrote:
>> Jan Kiszka writes:
>>
>>> This is in fact very simply: When the input in grabbed, everything
>>> should be exclusively passed to the guest - except it has our magic
>>> CTRL-ALT modifier set. Then let GTK filte
From: Jan Kiszka
This solves, e.g., sticky ALT when selecting a GTK menu, switching to a
different window or selecting a different virtual console.
Signed-off-by: Jan Kiszka
---
Changes in v3:
- rebased
ui/gtk.c | 53 +++--
1 files changed,
On 24 March 2013 17:27, Rabin Vincent wrote:
> Enable support for the dump-guest-memory monitor command for ARM.
Hi. I'm afraid I'm not really familiar with the dump-guest-memory
command/implementation so I have some possibly dumb comments below:
> --- /dev/null
> +++ b/target-arm/arch_dump.c
>
On 24 March 2013 17:27, Rabin Vincent wrote:
> /**
> + * memory_region_get_addr: Get the address of a memory region
> + *
> + * @mr: the memory region
> + */
> +hwaddr memory_region_get_addr(MemoryRegion *mr);
I'm afraid this doesn't make sense. A MemoryRegion by itself has
no "address" -- it co
On Sun, Mar 24, 2013 at 04:58:37PM +0100, Aurelien Jarno wrote:
> On Sun, Mar 24, 2013 at 11:32:30AM +, Peter Maydell wrote:
> > This patch series fixes a number of serious bugs in our emulation of
> > the PCI controller found on VersatilePB and the early Realview boards:
> > * our interrupt m
2013/3/24 Peter Maydell :
> On 24 March 2013 17:27, Rabin Vincent wrote:
>> --- /dev/null
>> +++ b/target-arm/arch_dump.c
>> @@ -0,0 +1,61 @@
>> +#include "cpu.h"
>> +#include "sysemu/dump.h"
>> +#include "elf.h"
>> +
>> +typedef struct {
>> +char pad1[24];
>> +uint32_t pid;
>> +char p
2013/3/24 Peter Maydell :
> On 24 March 2013 17:27, Rabin Vincent wrote:
>> /**
>> + * memory_region_get_addr: Get the address of a memory region
>> + *
>> + * @mr: the memory region
>> + */
>> +hwaddr memory_region_get_addr(MemoryRegion *mr);
>
> I'm afraid this doesn't make sense. A MemoryRegio
On Sun, Mar 24, 2013 at 04:49:37PM +, Peter Maydell wrote:
> On 24 March 2013 15:58, Aurelien Jarno wrote:
> > On Sun, Mar 24, 2013 at 11:32:30AM +, Peter Maydell wrote:
> >> This patch series fixes a number of serious bugs in our emulation of
> >> the PCI controller found on VersatilePB a
On 24 March 2013 19:35, Rabin Vincent wrote:
> 2013/3/24 Peter Maydell :
>> On 24 March 2013 17:27, Rabin Vincent wrote:
>>> /**
>>> + * memory_region_get_addr: Get the address of a memory region
>>> + *
>>> + * @mr: the memory region
>>> + */
>>> +hwaddr memory_region_get_addr(MemoryRegion *mr)
On 24 March 2013 19:26, Rabin Vincent wrote:
> 2013/3/24 Peter Maydell :
>> On 24 March 2013 17:27, Rabin Vincent wrote:
So I guess I should prefix this email by saying that quite
a bit of it is really comments on the existing dump code
rather than the ARM related support you're adding here. I
a
On 24 March 2013 19:17, Michael S. Tsirkin wrote:
> On Sun, Mar 24, 2013 at 04:58:37PM +0100, Aurelien Jarno wrote:
>> On Sun, Mar 24, 2013 at 11:32:30AM +, Peter Maydell wrote:
>> > I've provided a property for enabling the old broken IRQ mapping;
>> > this can be enabled with the command lin
On Sunday 24 March 2013, Peter Maydell wrote:
> Yeah, ideally being able to detect the buggy kernel would be good;
> I can't see anything at the controller level that would do though,
> and I don't really know enough about PCI to know about generic
> PCI stuff that would work. (Why would the OS nee
On 24 March 2013 21:16, Arnd Bergmann wrote:
> On Sunday 24 March 2013, Peter Maydell wrote:
>> Yeah, ideally being able to detect the buggy kernel would be good;
>> I can't see anything at the controller level that would do though,
>> and I don't really know enough about PCI to know about generic
On Sun, Mar 24, 2013 at 08:53:33PM +, Peter Maydell wrote:
> On 24 March 2013 19:17, Michael S. Tsirkin wrote:
> > On Sun, Mar 24, 2013 at 04:58:37PM +0100, Aurelien Jarno wrote:
> >> On Sun, Mar 24, 2013 at 11:32:30AM +, Peter Maydell wrote:
> >> > I've provided a property for enabling th
On Sun, Mar 24, 2013 at 09:16:28PM +, Arnd Bergmann wrote:
> On Sunday 24 March 2013, Peter Maydell wrote:
> > Yeah, ideally being able to detect the buggy kernel would be good;
> > I can't see anything at the controller level that would do though,
> > and I don't really know enough about PCI t
On Sunday 24 March 2013, Peter Maydell wrote:
> OK, I'll give that a go tomorrow.
>
> While you're here, do you know what the point of the PCI_SELFID
> register is? The h/w docs are clear that the OS has to write
> the slot number of the board itself in to this register, but
> again I don't see wh
On Sunday 24 March 2013, Michael S. Tsirkin wrote:
> For future kernels, let's build in some hook that let
> qemu detect a non broken guest. How about writing
> some magic value into revision ID or some other
> readonly field?
Yes, makes sense.
Hi Peter,
On Sat, Mar 23, 2013 at 1:49 AM, Peter Maydell wrote:
> Add a missing VMSTATE_TIMER() entry to the arm_mptimer vmstate
> description; this omission meant that we would probably hang on reload
> when the timer failed to fire.
>
I know load-save does not work for Zynq Linux. This will de
Hi Peter,
On Sun, Mar 24, 2013 at 9:32 PM, Peter Maydell wrote:
> Comments in the QEMU source code claim that the version of the PCI
> controller on the VersatilePB board doesn't support the PCI I/O
> region, but this is incorrect; expose that region, map it in the
> correct location, and drop th
On Fri, Mar 22, 2013 at 10:45:09AM +1030, Rusty Russell wrote:
> "Michael S. Tsirkin" writes:
> > On Thu, Mar 21, 2013 at 02:44:50PM +0800, Amos Kong wrote:
> >> The lengcy guests don't have mac programming command, we don't know when
> >> it's safe to use MAC. This patch changed qemu to makes MAC
On Thu, Mar 21, 2013 at 11:31 PM, Markus Armbruster wrote:
> Dong Xu Wang writes:
>
>> This patch will use QemuOpts related functions in block layer, add
>> a member bdrv_create_opts to BlockDriver struct, it will return
>> a QemuOptsList pointer, which includes the image format's create
>> optio
On Mon, Mar 25, 2013 at 10:23:57AM +0800, Amos Kong wrote:
> On Fri, Mar 22, 2013 at 10:45:09AM +1030, Rusty Russell wrote:
> > "Michael S. Tsirkin" writes:
> > > On Thu, Mar 21, 2013 at 02:44:50PM +0800, Amos Kong wrote:
> > >> The lengcy guests don't have mac programming command, we don't know w
73 matches
Mail list logo
