Penned by Paolo Bonzini on 20130321 3:25.51, we have:
| Il 21/03/2013 08:53, qemu-de...@email.fries.net ha scritto:
| > load averages: 6.74, 6.23, 5.17leveno.fries.net
02:42:23
| > 201 processes: 200 idle, 1 on processor
| > CPU0 states: 0.4% user, 0.0% nice, 33.3% system
On Thu, Mar 21, 2013 at 10:13:50AM +0100, Paolo Bonzini wrote:
> Il 21/03/2013 09:35, Hu Tao ha scritto:
> > Signed-off-by: Hu Tao
> > ---
> > docs/specs/pvpanic.txt | 25 +
> > 1 file changed, 25 insertions(+)
> > create mode 100644 docs/specs/pvpanic.txt
> >
> > diff -
On Thu, Mar 21, 2013 at 07:59:12PM -0600, Eric Blake wrote:
> On 03/21/2013 02:35 AM, Hu Tao wrote:
> > Signed-off-by: Hu Tao
> > ---
> > docs/specs/pvpanic.txt | 25 +
> > 1 file changed, 25 insertions(+)
> > create mode 100644 docs/specs/pvpanic.txt
>
> Grammar nits:
>
On Thu, Mar 21, 2013 at 06:54:59PM -0400, Kevin O'Connor wrote:
> On Thu, Mar 21, 2013 at 05:08:34PM +0800, Hu Tao wrote:
> > Signed-off-by: Hu Tao
>
> I don't think it is a good idea to dynamically modify the DSDT. We've
> been using the SSDT for that.
>
> In any case, I think this would be a
On Thu, Mar 21, 2013 at 11:54:25AM +0200, Michael S. Tsirkin wrote:
> On Thu, Mar 21, 2013 at 05:08:34PM +0800, Hu Tao wrote:
> > Signed-off-by: Hu Tao
>
> OK now you need to ACK GPLv2+ relicensing too :)
>
> Could you please review that message "make acpi bits GPLv2 compatible"
> and respond?
On 03/21/2013 09:35 PM, Eric Blake wrote:
> On 03/21/2013 12:34 PM, Orit Wasserman wrote:
>> Signed-off-by: Orit Wasserman
>> ---
>> savevm.c | 15 +++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/savevm.c b/savevm.c
>> index 35c8d1e..6608b6e 100644
>> --- a/savevm.c
>> +++
> Still no joy:
>
> PID USERNAME PRI NICE SIZE RES STATE WAIT TIMECPU COMMAND
> 21212 todd -5 20 1142M 118M sleep/0 - 1:03 37.30% cc1
>
> cc -I. -I/home/todd/git/sw/3rdParty/qemu
> -I/home/todd/git/sw/3rdParty/qemu/include
> -I/home/todd/git/sw/3rdParty/qemu/
On Thu, Mar 21, 2013 at 05:17:11PM +0800, Hu Tao wrote:
> On Thu, Mar 21, 2013 at 10:11:54AM +0100, Paolo Bonzini wrote:
> > Il 21/03/2013 10:08, Hu Tao ha scritto:
> > > Signed-off-by: Hu Tao
> > > ---
> > > src/acpi-dsdt-isa.dsl | 14 --
> > > src/acpi.c| 9 +
>
Hi,
On 03/21/2013 07:18 PM, Anthony Liguori wrote:
Alon Levy writes:
Note that the handler is called chr_is_guest_connected and not
chr_is_fe_connected, consistent with other members of CharDriverState.
Sorry, I don't get it.
There isn't a notion of "connected" for the front-ends in the ch
Ji,
On 03/21/2013 05:35 PM, Alon Levy wrote:
The target has not seen the guest_connected event via
spice_chr_guest_open or spice_chr_write, and so spice server wrongly
assumes there is no agent active, while the client continues to send
motion events only by the agent channel, which the server i
> Ji,
Ji,
>
> On 03/21/2013 05:35 PM, Alon Levy wrote:
> > The target has not seen the guest_connected event via
> > spice_chr_guest_open or spice_chr_write, and so spice server
> > wrongly
> > assumes there is no agent active, while the client continues to
> > send
> > motion events only by the
This series adds tracepoints for helping us clarify the cause of
troubles. Virtualization on Linux is composed of some components such
as qemu, kvm, libvirt, and so on. So it is very important to clarify
firstly and swiftly the cause of troubles is on what component of
them. Although qemu has usefu
Hi,
> There isn't a notion of "connected" for the front-ends in the char
> layer. The closest thing is whether add_handlers() have been called or
> not.
It isn't new. There are qemu_chr_fe_open + qemu_chr_fe_close doing
exactly that signaling (whenever someone has opened the virtio-serial
por
This patch enables us to know RunState transition. It will be userful
for investigation when the trouble occured in special event such like
live migration, shutdown, suspend, and so on.
Signed-off-by: Kazuya Saito
---
trace-events |1 +
vl.c |2 +-
2 files changed, 2 insertions(+
This patch adds tracepoints at ioctl to kvm. Tracing these ioctl is
useful for clarification whether the cause of troubles is qemu or kvm.
Signed-off-by: Kazuya Saito
---
kvm-all.c|4
trace-events |5 +
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/kvm-all.c
This patch enable us to know exit reason of KVM_RUN. It will help us
know where the trouble is caused.
Signed-off-by: Kazuya Saito
---
kvm-all.c|1 +
trace-events |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index da15623..29fca13 100644
This patch adds tracepoints at creating and removing virtual
devices. It is useful for investigation of trouble related to virtual
devices.
Signed-off-by: Kazuya Saito
---
hw/qdev.c|3 +++
trace-events |4
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/hw/qdev.c
This patch adds tracepoints at device-add command. It enables us to
clarify whether the trouble is caused by hot-plug through commands of
virsh (libvirt).
Signed-off-by: Kazuya Saito
---
qdev-monitor.c |2 ++
trace-events |3 +++
2 files changed, 5 insertions(+), 0 deletions(-)
diff -
ignore *.patch, *.gcda, *.gcno
Signed-off-by: liguang
---
.gitignore |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore
index 27ad002..9c234a3 100644
--- a/.gitignore
+++ b/.gitignore
@@ -80,6 +80,9 @@ fsdev/virtfs-proxy-helper.pod
*.swp
*.orig
Reviewed-by: Andreas Färber
Signed-off-by: liguang
---
hw/qdev.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 689cd54..2bed9d8 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -116,11 +116,10 @@ DeviceState *qdev_create(BusState *bus, const char
Hi,
On 03/22/2013 09:16 AM, Alon Levy wrote:
Ji,
Ji,
On 03/21/2013 05:35 PM, Alon Levy wrote:
The target has not seen the guest_connected event via
spice_chr_guest_open or spice_chr_write, and so spice server
wrongly
assumes there is no agent active, while the client continues to
send
moti
Hi,
On 03/22/2013 09:25 AM, Gerd Hoffmann wrote:
Hi,
There isn't a notion of "connected" for the front-ends in the char
layer. The closest thing is whether add_handlers() have been called or
not.
It isn't new. There are qemu_chr_fe_open + qemu_chr_fe_close doing
exactly that signaling (
QEMU.org has applied for Google Summer of Code 2013 and also aims to
be an umbrella organization for libvirt and the KVM kernel module.
Accepted mentoring organizations will be announced on April 8 at 19:00
UTC at http://google-melange.com/.
This year we have proposed 5 QEMU project ideas, 1 KVM
e.g.
$qemu-system-x86_64 -device port92
will report segment fault,
for port92_write try a un-allocated
assignment for a20_out.
so check before this assignment.
Signed-off-by: liguang
---
hw/i386/pc.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i38
Hi,
Seems there is an issue with the current git (found by toddf on IRC).
To reproduce:
./qemu-system-x86_64 --monitor stdio --nographic
and put "?" it should abort.
Here is the backtrace:
#0 0x7f77cd347935 in raise () from /lib64/libc.so.6
#1 0x7f77cd3490e8 in abort () from /lib64
Laszlo Ersek writes:
> I've (re-)read the UTF-8 article in wikipedia now... comments below
>
> On 03/14/13 18:49, Markus Armbruster wrote:
>
>> diff --git a/util/unicode.c b/util/unicode.c
>> new file mode 100644
>> index 000..954bcf7
>
>> +/**
>> + * mod_utf8_codepoint:
>> + * @s: string enc
On Thu, 21 Mar 2013 15:15:10 +0100
fred.kon...@greensocs.com wrote:
> From: KONRAD Frederic
>
> This is the next part of virtio-refactoring.
>
> Basically it creates virtio-scsi device which extends virtio-device.
> Then a virtio-scsi can be connected on a virtio-bus.
> virtio-scsi-pci, virtio-
Il 22/03/2013 08:08, qemu-de...@email.fries.net ha scritto:
> Penned by Paolo Bonzini on 20130321 3:25.51, we have:
> | Il 21/03/2013 08:53, qemu-de...@email.fries.net ha scritto:
> | > load averages: 6.74, 6.23, 5.17leveno.fries.net
> 02:42:23
> | > 201 processes: 200 idle
Il 22/03/2013 09:27, Kazuya Saito ha scritto:
> This patch adds tracepoints at ioctl to kvm. Tracing these ioctl is
> useful for clarification whether the cause of troubles is qemu or kvm.
>
> Signed-off-by: Kazuya Saito
> ---
> kvm-all.c|4
> trace-events |5 +
> 2 files ch
Il 22/03/2013 09:28, Kazuya Saito ha scritto:
> This patch enable us to know exit reason of KVM_RUN. It will help us
> know where the trouble is caused.
>
> Signed-off-by: Kazuya Saito
> ---
> kvm-all.c|1 +
> trace-events |1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
>
Il 22/03/2013 09:26, Kazuya Saito ha scritto:
> This patch enables us to know RunState transition. It will be userful
> for investigation when the trouble occured in special event such like
> live migration, shutdown, suspend, and so on.
>
> Signed-off-by: Kazuya Saito
> ---
> trace-events |
Il 22/03/2013 09:25, Kazuya Saito ha scritto:
> This series adds tracepoints for helping us clarify the cause of
> troubles. Virtualization on Linux is composed of some components such
> as qemu, kvm, libvirt, and so on. So it is very important to clarify
> firstly and swiftly the cause of troubles
Il 22/03/2013 10:12, liguang ha scritto:
> e.g.
> $qemu-system-x86_64 -device port92
> will report segment fault,
> for port92_write try a un-allocated
> assignment for a20_out.
> so check before this assignment.
>
> Signed-off-by: liguang
> ---
> hw/i386/pc.c |3 ++-
> 1 files changed, 2 in
On 21 March 2013 18:25, Anthony Liguori wrote:
> Gerd Hoffmann writes:
>> I think the most sensible way to handle this is to implement the output
>> routing device, make it own the (single) QemuConsole, and depending on
>> the router state the one or the other display device is allowed to
>> rend
Doing a complete git clone with all submodules is broken;
I guess by commit c3d8dab32.
cam-vm-266:precise:tmp$ git clone git://git.qemu-project.org/qemu.git
Cloning into 'qemu'...
remote: Counting objects: 142750, done.
remote: Compressing objects: 100% (34907/34907), done.
remote: Total 142750 (d
Am 22.03.2013 10:12, schrieb liguang:
> e.g.
> $qemu-system-x86_64 -device port92
> will report segment fault,
> for port92_write try a un-allocated
> assignment for a20_out.
> so check before this assignment.
>
> Signed-off-by: liguang
> ---
> hw/i386/pc.c |3 ++-
> 1 files changed, 2 inser
is_tcg_gen_code() checks the upper limit of TCG generated code range wrong, so
that TCG could get broken occasionally only when CONFIG_QEMU_LDST_OPTIMIZATION
enabled. The reason is code_gen_buffer_max_size does not cover the upper range
up to (TCG_MAX_OP_SIZE * OPC_BUF_SIZE), thus code_gen_buffer_m
On 03/22/13 12:25, Peter Maydell wrote:
> Doing a complete git clone with all submodules is broken;
> I guess by commit c3d8dab32.
> Unable to checkout '09c5109b8585178172c7608de8d52e9d9af0b680' in
> submodule path 'roms/ipxe'
Looks like git mirroring @ qemu.org is broken,
http://git.qemu.org/?p=
On 03/22/13 10:23, Markus Armbruster wrote:
> Laszlo Ersek writes:
>> On 03/14/13 18:49, Markus Armbruster wrote:
>>> +{
>>> +static int min_cp[5] = { 0x80, 0x800, 0x1, 0x20, 0x400 };
>>> +const unsigned char *p;
>>> +unsigned byte, mask, len, i;
>>> +int cp;
>>> +
>>>
On 22 March 2013 11:28, Yeongkyoon Lee wrote:
> is_tcg_gen_code() checks the upper limit of TCG generated code range wrong, so
> that TCG could get broken occasionally only when CONFIG_QEMU_LDST_OPTIMIZATION
> enabled. The reason is code_gen_buffer_max_size does not cover the upper range
> up to (
is_tcg_gen_code() checks the upper limit of TCG generated code range wrong, so
that TCG could get broken occasionally only when CONFIG_QEMU_LDST_OPTIMIZATION
enabled. The reason is code_gen_buffer_max_size does not cover the upper range
up to (TCG_MAX_OP_SIZE * OPC_BUF_SIZE), thus code_gen_buffer_m
On 22 March 2013 11:56, Yeongkyoon Lee wrote:
> is_tcg_gen_code() checks the upper limit of TCG generated code range wrong, so
> that TCG could get broken occasionally only when CONFIG_QEMU_LDST_OPTIMIZATION
> enabled. The reason is code_gen_buffer_max_size does not cover the upper range
> up to (
On Fri, Mar 15, 2013 at 02:32:01PM +0800, Hu Tao wrote:
> The collision reports before and after this patch are:
>
> before:
>
> warning: subregion collision cfc/4 (pci-conf-data) vs cf8/4 (pci-conf-idx)
> warning: subregion collision 800/f800 (pci-hole) vs 0/800
> (ram-below-4g)
> w
On Sun, Mar 17, 2013 at 03:43:26PM -0500, Doug Goldstein wrote:
> The configure script allows you to supply a libdir via --libdir but was
> not advertising this in --help.
>
> Signed-off-by: Doug Goldstein
> CC: qemu-triv...@nongnu.org
> ---
> configure | 1 +
> 1 file changed, 1 insertion(+)
T
On Mon, Mar 18, 2013 at 05:20:07PM +, Peter Maydell wrote:
> Fix various typos and misspellings. The bulk of these were found with
> codespell.
>
> Signed-off-by: Peter Maydell
> ---
> I noticed the PCI typo while reading the file so I figured I'd run codespell
> on the tree while I was at it
On Tue, Mar 19, 2013 at 12:25:43PM +0100, Kevin Wolf wrote:
> This fixes the build of hw/serial.c with DEBUG_SERIAL enabled.
>
> Signed-off-by: Kevin Wolf
> ---
> hw/serial.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.
Am 22.03.2013 12:56, schrieb Yeongkyoon Lee:
> is_tcg_gen_code() checks the upper limit of TCG generated code range wrong, so
> that TCG could get broken occasionally only when CONFIG_QEMU_LDST_OPTIMIZATION
> enabled. The reason is code_gen_buffer_max_size does not cover the upper range
> up to (TC
Am 22.03.2013 12:25, schrieb Peter Maydell:
> Doing a complete git clone with all submodules is broken;
> I guess by commit c3d8dab32.
>
> cam-vm-266:precise:tmp$ git clone git://git.qemu-project.org/qemu.git
> Cloning into 'qemu'...
> remote: Counting objects: 142750, done.
> remote: Compressing
is_tcg_gen_code() checks the upper limit of TCG generated code range wrong, so
that TCG could get broken occasionally only when CONFIG_QEMU_LDST_OPTIMIZATION
enabled. The reason is code_gen_buffer_max_size does not cover the upper range
up to (TCG_MAX_OP_SIZE * OPC_BUF_SIZE), thus code_gen_buffer_m
On 22 March 2013 12:22, Stefan Hajnoczi wrote:
> The int128_le() comparison below suggests that int128_gt() really should
> be int128_ge().
Agreed. It might be clearer to rephrase as:
AddrRange thisrange = addrrange_make(int128_make64(offset),
int128_make64
On 22 March 2013 12:50, Yeongkyoon Lee wrote:
> is_tcg_gen_code() checks the upper limit of TCG generated code range wrong, so
> that TCG could get broken occasionally only when CONFIG_QEMU_LDST_OPTIMIZATION
> enabled. The reason is code_gen_buffer_max_size does not cover the upper range
> up to (
virtually all dup pages are zero pages. remove
the special is_dup_page() function and use the
optimized buffer_find_nonzero_offset() function
instead.
here buffer_find_nonzero_offset() is used directly
to avoid the unnecssary additional checks in
buffer_is_zero().
raw performace gain checking zer
this is v4 of my patch series with various optimizations in
zero buffer checking and migration tweaks.
thanks especially to Eric Blake for reviewing.
v4:
- do not inline buffer_find_nonzero_offset()
- inline can_usebuffer_find_nonzero_offset() correctly
- readd asserts in buffer_find_nonzero_offs
performance gain on SSE2 is approx. 20-25%. altivec
is not tested. performance for unsigned long arithmetic
is unchanged.
Signed-off-by: Peter Lieven
Reviewed-by: Eric Blake
---
util/cutils.c |5 +
1 file changed, 5 insertions(+)
diff --git a/util/cutils.c b/util/cutils.c
index 41c627e
avoid searching for dirty pages just increment the
page offset. all pages are dirty anyway.
Signed-off-by: Peter Lieven
Reviewed-by: Eric Blake
---
arch_init.c |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch_init.c b/arch_init.c
index c34a4af..b2b932a 100644
-
vector optimizations will now be used at various places
not just in is_dup_page() in arch_init.c
this patch also adds a zero splat vector.
Signed-off-by: Peter Lieven
Reviewed-by: Eric Blake
---
arch_init.c | 20
include/qemu-common.h | 24 +++
at the beginning of migration all pages are marked dirty and
in the first round a bulk migration of all pages is performed.
currently all these pages are copied to the page cache regardless
of whether they are frequently updated or not. this doesn't make sense
since most of these pages are never t
this patch adds the usage of buffer_find_nonzero_offset()
to skip large areas of zeroes.
compared to loop unrolling presented in an earlier
patch this adds another 50% performance benefit for
skipping large areas of zeroes. loop unrolling alone
added close to 100% speedup.
Signed-off-by: Peter Li
the first round of ram transfer is special since all pages
are dirty and thus all memory pages are transferred to
the target. this patch adds a boolean variable to track
this stage.
Signed-off-by: Peter Lieven
Reviewed-by: Eric Blake
---
arch_init.c |3 +++
1 file changed, 3 insertions(+)
I got it working with Curl, patch attached.
However there are multiple issues (these are mainly notes for myself):
(1) libcurl cannot read the size of the file. I had to hard-code
this. This is probably just a shortcoming of libcurl (libssh2/sftp
itself can read the size of files). Will try t
this adds buffer_find_nonzero_offset() which is a SSE2/Altivec
optimized function that searches for non-zero content in a
buffer.
due to the optimizations used in the function there are restrictions
on buffer address and search length. the function
can_use_buffer_find_nonzero_content() can be used
during bulk stage of ram migration if a page is a
zero page do not send it at all.
the memory at the destination reads as zero anyway.
even if there is an madvise with QEMU_MADV_DONTNEED
at the target upon receipt of a zero page I have observed
that the target starts swapping if the memory is over
On 21 March 2013 22:43, Scott Wood wrote:
> What if the update is to a parent memory region, not to the one directly
> associated with the device?
>
> Or does add() get called for all child regions (recursively) in such cases?
The memory API flattens the tree of memory regions down into a flat
vi
Peter Maydell writes:
> Doing a complete git clone with all submodules is broken;
> I guess by commit c3d8dab32.
Fixed.
Regards,
Anthony Liguori
>
> cam-vm-266:precise:tmp$ git clone git://git.qemu-project.org/qemu.git
> Cloning into 'qemu'...
> remote: Counting objects: 142750, done.
> remot
comments below
On 03/14/13 18:49, Markus Armbruster wrote:
> diff --git a/qobject/qjson.c b/qobject/qjson.c
> index 83a6b4f..19085a1 100644
> --- a/qobject/qjson.c
> +++ b/qobject/qjson.c
> @@ -136,68 +136,56 @@ static void to_json(const QObject *obj, QString *str,
> int pretty, int indent)
>
This patch series convert the savevm command into qapi and introduce QMP
command vm-snapshot-save.
It also rewrite error report for functions used by this command.
The patch 10/11 introduce new functionality of savevm and vm-snapshot-save
that you cannot override existing snapshot without using 'f
Signed-off-by: Pavel Hrdina
---
block.c | 22 --
block/qcow2-snapshot.c| 9 -
block/qcow2.h | 4 +++-
block/rbd.c | 8 ++--
block/sheepdog.c | 17 +
include/block/block.h | 3 ++-
inc
Signed-off-by: Pavel Hrdina
---
include/sysemu/sysemu.h | 2 +-
migration.c | 2 +-
savevm.c| 5 +++--
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index af4f699..9e6a4a9 100644
--- a/include/sysemu/s
Signed-off-by: Pavel Hrdina
---
include/sysemu/sysemu.h | 2 +-
migration.c | 2 +-
savevm.c| 5 ++---
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index 2f35a05..af4f699 100644
--- a/include/sysemu/s
Signed-off-by: Pavel Hrdina
---
include/sysemu/sysemu.h | 3 ++-
migration.c | 2 +-
savevm.c| 6 --
3 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index 6578782..2f35a05 100644
--- a/include/sysemu
Signed-off-by: Pavel Hrdina
---
hmp-commands.hx | 4 ++--
hmp.c | 9 +
hmp.h | 1 +
include/sysemu/sysemu.h | 1 -
qapi-schema.json| 18 ++
qmp-commands.hx | 29 +
savevm.c
Signed-off-by: Pavel Hrdina
---
qemu-img.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 21d02bf..34badad 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -322,6 +322,14 @@ static int add_old_style_options(const char *fmt,
QEMUOptionPar
If we provide error message, we should also provide a return code.
In some cases we could not care about any error message and the return
code is enough for as.
Signed-off-by: Pavel Hrdina
---
block.c| 4 ++--
block/qcow2-snapshot.c | 4 ++--
block/rbd.c| 8
Signed-off-by: Pavel Hrdina
---
savevm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/savevm.c b/savevm.c
index 3e3d5f8..532c1be 100644
--- a/savevm.c
+++ b/savevm.c
@@ -112,7 +112,7 @@ void qemu_announce_self(void)
/***
HMP command "savevm" now takes extra optional force parameter to specify whether
replace existing snapshot or not.
QMP command "vm-snapshot-save" has also extra optional force parameter and
name parameter isn't optional anymore.
Signed-off-by: Pavel Hrdina
---
hmp-commands.hx | 15
Laszlo Ersek writes:
> I don't understand what's going on here.
>
> On 03/14/13 18:49, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster
>> ---
>> tests/check-qjson.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/check-qjson.c b/tests/check-q
Gerd Hoffmann writes:
> Hi,
>
>> There isn't a notion of "connected" for the front-ends in the char
>> layer. The closest thing is whether add_handlers() have been called or
>> not.
>
> It isn't new. There are qemu_chr_fe_open + qemu_chr_fe_close doing
> exactly that signaling (whenever someo
Signed-off-by: Pavel Hrdina
---
savevm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index 45d1b09..2e5f029 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1805,7 +1805,7 @@ static int qemu_savevm_state(QEMUFile *f, Error **errp)
};
if (qemu_s
Signed-off-by: Pavel Hrdina
---
savevm.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/savevm.c b/savevm.c
index fadde55..7b1867b 100644
--- a/savevm.c
+++ b/savevm.c
@@ -2110,7 +2110,7 @@ static int bdrv_snapshot_find(BlockDriverState *bs,
QEMUSnapshotInfo *s
On Fri, Mar 22, 2013 at 01:04:55PM +, Richard W.M. Jones wrote:
>
> I got it working with Curl, patch attached.
>
> However there are multiple issues (these are mainly notes for myself):
>
> (1) libcurl cannot read the size of the file. I had to hard-code
> this. This is probably just a sh
Signed-off-by: Pavel Hrdina
---
savevm.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/savevm.c b/savevm.c
index 76af390..71981d1 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1796,7 +1796,7 @@ void qemu_savevm_state_cancel(void)
}
}
-static int qemu_savevm_
Hans de Goede writes:
> Hi,
>
> On 03/21/2013 07:18 PM, Anthony Liguori wrote:
>> Alon Levy writes:
>>
>>> Note that the handler is called chr_is_guest_connected and not
>>> chr_is_fe_connected, consistent with other members of CharDriverState.
>>
>> Sorry, I don't get it.
>>
>> There isn't a no
This patch adds block/snapshot.c and then moves the function
there. It also fixes small code style errors reported by check script.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
---
block/Makefile.objs |1 +
block/snapshot.c | 48 +++
In the use of snapshot a way to retrieve related info at runtime is needed,
so this serial of patches will merge some code for qemu and qemu-img, and add
or enchance following interfaces for qemu:
1) qmp: query-block, show info for a block device include image info
Example:
-> { "execute": "quer
To make it clear about id and name in searching, the API is changed
a bit to distinguish them, and caller can choose to search by id or name.
Searching will be done with higher priority of id. This function also
returns negative value from bdrv_snapshot_list() instead of -ENOENT on
error now.
Si
Parameter *fmt was not used, so remove it.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
---
qemu-img.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 31627b0..937ec01 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1640,8 +1640,7
This patch adds block/qapi.c and moves the functions there. To avoid
conflict and tip better, macro in header file is BLOCK_QAPI_H instead
of QAPI_H. The moving is for making review easier, those functions
will be modified and renamed later.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
-
This patch adds function bdrv_query_snapshot_info_list(), which will
retrieve snapshot info of an image in qmp object format. The implementation
is based on the code moved from qemu-img.c with modification to fit more
for qmp based block layer API.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric B
This patch adds a parameter to tell whether return valid snapshots
for whole VM only.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
---
block/qapi.c | 42 --
include/block/qapi.h |1 +
qemu-img.c |3 ++-
3 files changed,
This is a code move patch, except in qmp_query_block bdrv_next(bs)
is used instead of direct traverse of global array 'bdrv_states'.
This patch also fix code style error reported by check script.
Signed-off-by: Wenchao Xia
---
block.c | 76
(that one was nack by you in 00/26, but it's a nice clean up anyway)
--
Marc-André Lureau
This interface returns info of valid internal snapshots for whole vm.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
---
block/qapi.c | 17
qapi-schema.json | 14 +
qmp-commands.hx | 55 ++
3 files
New member *backing-image is added to reflect the backing chain
status.
Signed-off-by: Wenchao Xia
---
block/qapi.c |6 +-
qapi-schema.json |5 -
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/block/qapi.c b/block/qapi.c
index ea1ca7f..df73f5b 100644
--- a/b
Hi,
review below
On Mon, Mar 18, 2013 at 2:11 PM, Alon Levy wrote:
> Only because qemu's checkpatch complains about it.
>
> Signed-off-by: Alon Levy
> ---
> Makefile.objs | 1 +
> libcacard/vcard_emul_nss.c | 11 ---
> libcacard/vcardt.c | 40 +
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
Since libcacard uses glib, why not just use g_debug() with a LOG_DOMAIN?
--
Marc-André Lureau
This patch using new added function in last commit which retrieve
info from qmp for snapshot info.
Signed-off-by: Wenchao Xia
---
monitor.c |2 +-
savevm.c | 64 -
2 files changed, 1 insertions(+), 65 deletions(-)
diff --git a
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
1 - 100 of 216 matches
Mail list logo
