Re: [Qemu-devel] [PATCH 7/8] spice-qemu-char: Register interface on post load

On 03/14/13 17:36, Hans de Goede wrote: > From: Alon Levy > > The target has not seen the guest_connected event via > spice_chr_guest_open or spice_chr_write, and so spice server wrongly > assumes there is no agent active, while the client continues to send > motion events only by the agent chann

Re: [Qemu-devel] Spice / usb-redir chardev flowcontrol patches v2

On 03/18/13 13:21, Amit Shah wrote: > On (Thu) 14 Mar 2013 [17:36:49], Hans de Goede wrote: >> Here is v2 of the series adding watch support to the spicevmc chardev backend >> and flowcontrol support to the usb-redir device. It also includes a few >> virtio-consoled bugfixes which were found during

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix compile failures introduced by recent console changes

On 03/18/13 21:28, Peter Maydell wrote: > Fix various compilation failures introduced by the recent console > changes. > > Signed-off-by: Peter Maydell > --- > ui/cocoa.m | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/ui/cocoa.m b/ui/cocoa.m > index 8e0eaa2..0

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm_gic_common: Use vmstate struct rather than save/load functions

Hi, >> (vmstate.h is getting hugely repetitive to the point that I'm >> really tempted to say we should just autogenerate it. That way >> you could define a fairly small set of things (arrays, base types, >> safe vs unsafe, etc) and have a script generate the cross product, >> rather than the cu

Re: [Qemu-devel] [PATCH 01/15] pixman: add qemu_pixman_color()

On 03/18/13 22:13, Søren Sandmann wrote: > Gerd Hoffmann writes: > >> Helper function to map qemu colors (32bit integer + matching PixelFormat) >> into pixman_color_t. > > Are qemu colors premultiplied? If not, this function should probably > premultiply before returning the color. The alpha ch

Re: [Qemu-devel] [PATCH] QMP: TPM QMP and man page documentation updates

[Note cc: Anthony for QAPI schema expertise] Stefan Berger writes: > On 03/18/2013 12:16 PM, Markus Armbruster wrote: >> Corey Bryant writes: >> >>> Signed-off-by: Corey Bryant >>> --- >>> qemu-options.hx | 3 ++- >>> qmp-commands.hx | 59 >>> ++

Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight

On 11.03.2013 11:16, Paolo Bonzini wrote: Il 11/03/2013 11:05, Peter Lieven ha scritto: ensure that there are no pending I/Os before calling the sync readcapacity commands. the block_resize monitor command will also flush all I/O, but double check in case iscsi_truncate() is called from elsewher

Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

在 2013-02-28四的 11:18 +0100，Vasilis Liaskovitis写道： > Hi, > > sorry for the delay. > On Tue, Feb 19, 2013 at 07:39:40PM -0300, Erlon Cruz wrote: > > On Tue, Dec 18, 2012 at 10:41 AM, Vasilis Liaskovitis < > > vasilis.liaskovi...@profitbricks.com> wrote: > > > > > This is v4 of the ACPI memory hotpl

Re: [Qemu-devel] [PATCH V27 1/7] Support for TPM command line options

Stefan Berger writes: > On 03/18/2013 09:10 AM, Markus Armbruster wrote: >>> >>> In case the TPM is currently not operating on a command there will be >>> no impact. In case the TPM is operating on a command, it will hold the >>> thread inside /dev/tpm0 until the command has finished. The solutio

Re: [Qemu-devel] [PULL 0/2] virtio-ccw patches 2013-03-18

On Mon, 18 Mar 2013 17:04:40 +0100 Cornelia Huck wrote: Hm, skip this. This clashes with the virtio-blk refactoring. > The following changes since commit 225dc991b03f0f034aa348f5cf499de9d0979107: > > s390: Fix cpu refactoring fallout. (2013-03-17 20:01:31 +) > > are available in the git

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

On Mon, Mar 18, 2013 at 07:23:53PM -0400, Michael R. Hines wrote: > On 03/18/2013 05:26 PM, Michael S. Tsirkin wrote: > > > >Probably but I haven't mentioned ballooning at all. > > > >memory overcommit != ballooning > > Sure, then setting ballooning aside for the moment, > then let's just consider

[Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

current git master segfaults if an iscsi option is specified in command line. Peter Lieven (2): qemu-option: avoid segfault if QemuOptsList == NULL vl.c: fix segfault in iscsi options parsing block/iscsi.c | 27 --- util/qemu-option.c |1 + vl.c

[Qemu-devel] [PATCH 1/2] qemu-option: avoid segfault if QemuOptsList == NULL

Signed-off-by: Peter Lieven --- util/qemu-option.c |1 + 1 file changed, 1 insertion(+) diff --git a/util/qemu-option.c b/util/qemu-option.c index 8b74bf1..24479d2 100644 --- a/util/qemu-option.c +++ b/util/qemu-option.c @@ -938,6 +938,7 @@ static QemuOpts *opts_parse(QemuOptsList *list, con

[Qemu-devel] [PATCH 2/2] vl.c: fix segfault in iscsi options parsing

this patch fixes parsing of iscsi options such as initiator-name passed to command line via -iscsi option group. because iscsi options where registered too late qemu_find_opts returned NULL leading to a segfault in qemu_opts_parse. Signed-off-by: Peter Lieven --- block/iscsi.c | 27 --

Re: [Qemu-devel] qemu segfault parsing iscsi options

Peter Lieven writes: > On 18.03.2013 13:52, Markus Armbruster wrote: >> Peter Lieven writes: >> >>> Hi, >>> >>> with recent qemu from git qemu segfaults with the following commandline: >>> >>> x86_64-softmmu/qemu-system-x86_64 -iscsi test >>> >>> qemu-system-x86_64: -iscsi test: There is no opti

[Qemu-devel] [PATCH] virtio-blk: Do not segfault fault if failed to initialize dataplane

$ ~/usr/bin/qemu-system-x86_64 -enable-kvm -m 1024 -drive if=none,id=drive0,cache=none,aio=native,format=raw,file=/root/Image/centos-6.4.raw -device virtio-blk-pci,drive=drive0,scsi=off,x-data-plane=on,config-wce=on # make dataplane fail to initialize qemu-system-x86_64: -device virtio-blk-pci,

Re: [Qemu-devel] qemu segfault parsing iscsi options

On 19.03.2013 09:25, Markus Armbruster wrote: Peter Lieven writes: On 18.03.2013 13:52, Markus Armbruster wrote: Peter Lieven writes: Hi, with recent qemu from git qemu segfaults with the following commandline: x86_64-softmmu/qemu-system-x86_64 -iscsi test qemu-system-x86_64: -iscsi tes

Re: [Qemu-devel] [PATCH] virtio-blk: Do not segfault fault if failed to initialize dataplane

On 19/03/2013 09:27, Dunrong Huang wrote: $ ~/usr/bin/qemu-system-x86_64 -enable-kvm -m 1024 -drive if=none,id=drive0,cache=none,aio=native,format=raw,file=/root/Image/centos-6.4.raw -device virtio-blk-pci,drive=drive0,scsi=off,x-data-plane=on,config-wce=on # make dataplane fail to initialize

Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

On Tue, Mar 19, 2013 at 08:34:45AM +0800, Asias He wrote: > --- > hw/vhost.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/vhost.c b/hw/vhost.c > index 4d6aee3..0c52ec4 100644 > --- a/hw/vhost.c > +++ b/hw/vhost.c > @@ -421,10 +421,12 @@ static void vhost_set_memory(MemoryListener

Re: [Qemu-devel] [PATCH V3 WIP 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

On Tue, Mar 19, 2013 at 08:34:44AM +0800, Asias He wrote: > +static void vhost_scsi_stop(VHostSCSI *vs, VirtIODevice *vdev) > +{ > +int ret = 0; > + > +if (!vdev->binding->set_guest_notifiers) { > +ret = vdev->binding->set_guest_notifiers(vdev->binding_opaque, > +

Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

On Tue, Mar 19, 2013 at 09:40:57AM +0100, Stefan Hajnoczi wrote: > On Tue, Mar 19, 2013 at 08:34:45AM +0800, Asias He wrote: > > --- > > hw/vhost.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/hw/vhost.c b/hw/vhost.c > > index 4d6aee3..0c52ec4 100644 > > --- a/hw/vhost.c > > +

Re: [Qemu-devel] [PATCH v2 0/2] block: fix BDRV_O_SNAPSHOT with protocols

On Tue, Mar 19, 2013 at 10:16:41AM +0400, Michael Tokarev wrote: > 18.03.2013 20:58, Stefan Hajnoczi wrote: > > Richard Jones reported that BDRV_O_SNAPSHOT does not > > work > > with NBD: > > Heh. http://permalink.gmane.org/gmane.comp.emulators.qemu/148390 > > (nothing's wrong with the patchse

Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

Paolo, please have a look. Peter Lieven writes: > current git master segfaults if an iscsi option is specified > in command line. > > Peter Lieven (2): > qemu-option: avoid segfault if QemuOptsList == NULL > vl.c: fix segfault in iscsi options parsing > > block/iscsi.c | 27 -

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

On 19 March 2013 00:55, li guang wrote: > 在 2013-03-18一的 11:07 +，Peter Maydell写道： >> I'm really dubious that this can or should be implemented by >> adding methods at the device base class level. I don't think >> real hardware works this way. > > and what it should be? > >> You could probably

[Qemu-devel] qmp monitor is broken

Hi, $subject says it. Bisecting points to: commit 23673ca740e0eda66901ca801a5a901df378b063 Author: Anthony Liguori Date: Tue Mar 5 23:21:23 2013 +0530 qemu-char: add watch support This allows a front-end to request for a callback when the backend is writable again. Signed

Re: [Qemu-devel] [PATCH 7/8] spice-qemu-char: Register interface on post load

> On 03/14/13 17:36, Hans de Goede wrote: > > From: Alon Levy > > > > The target has not seen the guest_connected event via > > spice_chr_guest_open or spice_chr_write, and so spice server > > wrongly > > assumes there is no agent active, while the client continues to > > send > > motion events o

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 08/10] introduce QEMUFileRDMA

Il 18/03/2013 21:33, Michael R. Hines ha scritto: >> >> +int qemu_drain(QEMUFile *f) >> +{ >> +return f->ops->drain ? f->ops->drain(f->opaque) : 0; >> +} >> Hmm, this is very similar to qemu_fflush, but not quite. :/ >> >> Why exactly is this needed? > > Good idea - I'll replace drain with flu

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 09/10] check for QMP string and bypass nonblock() calls

Il 18/03/2013 21:37, Michael R. Hines ha scritto: >> >> +if(!migrate_use_rdma(f)) { >> +int fd = qemu_get_fd(f); >> +assert(fd != -1); >> +socket_set_nonblock(fd); >> Is this because qemu_get_fd(f) returns -1 for RDMA? Then, you can >> instead put socket_set_nonblock un

Re: [Qemu-devel] [PATCH 00/35] hw/ reorganization, part 2

Il 18/03/2013 21:21, Peter Maydell ha scritto: > On 18 March 2013 20:05, Paolo Bonzini wrote: >> Il 18/03/2013 19:17, Peter Maydell ha scritto: > Shouldn't these containers also host the CPU device(s), rather than the > boards? And create them according to the num-cpu property? If so, th

Re: [Qemu-devel] [PATCH 7/8] spice-qemu-char: Register interface on post load

On 03/19/13 10:15, Alon Levy wrote: >>> +vmstate_register(NULL, -1, &spice_chr_vmstate, s); >>> + >> >> That is a showstopper. If there are two of these there is no >> reliable >> way to figure which is which. > > But they will both get a different state pointer s. I mean in the migration d

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

Peter Maydell writes: > On 13 March 2013 12:34, Anthony Liguori wrote: >> AioContext is necessary for the block layer because the block layer >> still has synchronous I/O. I think we should aim to replace all sync >> I/O in the long term with coroutine based I/O. > > I think coroutines are drea

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

在 2013-03-19二的 09:05 +，Peter Maydell写道： > On 19 March 2013 00:55, li guang wrote: > > 在 2013-03-18一的 11:07 +，Peter Maydell写道： > >> I'm really dubious that this can or should be implemented by > >> adding methods at the device base class level. I don't think > >> real hardware works this wa

[Qemu-devel] [PATCH] qcow2: fix null deref apparent during migration

Signed-off-by: Alon Levy --- block/qcow2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index 1f99866..260a1d3 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -512,7 +512,9 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, in

Re: [Qemu-devel] migrate cancel bug in latest qemu upstream

Il 19/03/2013 05:49, Amos Kong ha scritto: > On Mon, Mar 18, 2013 at 09:20:03PM +0800, Amos Kong wrote: >> On Tue, Mar 12, 2013 at 10:58:54AM +0800, Amos Kong wrote: >>> Hi quintela, I found a migrate bug in Autotest result, not sure if >>> it's already known. > > This bug was already fixed by this

Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight

Il 19/03/2013 08:29, Peter Lieven ha scritto: > On 11.03.2013 11:16, Paolo Bonzini wrote: >> Il 11/03/2013 11:05, Peter Lieven ha scritto: >>> ensure that there are no pending I/Os before calling >>> the sync readcapacity commands. the block_resize monitor >>> command will also flush all I/O, but d

Re: [Qemu-devel] qemu segfault parsing iscsi options

Il 18/03/2013 17:47, Markus Armbruster ha scritto: > Peter Lieven writes: > >> On 18.03.2013 13:52, Markus Armbruster wrote: >>> Peter Lieven writes: >>> Hi, with recent qemu from git qemu segfaults with the following commandline: x86_64-softmmu/qemu-system-x86_64 -iscsi

[Qemu-devel] [PATCH] fix monitor

chardev flow control broke monitor, fix it by adding watch support. --- monitor.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 112e920..680d344 100644 --- a/monitor.c +++ b/monitor.c @@ -261,11 +261,30 @@ int monitor_rea

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

On Mon, Mar 18, 2013 at 6:00 PM, Paolo Bonzini wrote: > Il 18/03/2013 18:38, George Dunlap ha scritto: >>> This might be a difference between Xen and KVM. On Xen migration is >>> made to a server in a paused state, and it's only unpaused when >>> the migration to B is complete. There's a sort

Re: [Qemu-devel] [PATCH 00/35] hw/ reorganization, part 2

On 19 March 2013 09:26, Paolo Bonzini wrote: > Il 18/03/2013 21:21, Peter Maydell ha scritto: >> On 18 March 2013 20:05, Paolo Bonzini wrote: >>> Il 18/03/2013 19:17, Peter Maydell ha scritto: >> Shouldn't these containers also host the CPU device(s), rather than the >> boards? And creat

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] pseries: Fixes and enhancements to L1 cache properties

On 19.03.2013, at 02:00, David Gibson wrote: > On Mon, Mar 18, 2013 at 11:54:05AM +0100, Andreas Färber wrote: >> Am 15.03.2013 13:27, schrieb Alexander Graf: >>> >>> On 14.03.2013, at 02:53, David Gibson wrote: >>> PAPR requires that the device tree's CPU nodes have several properties >>>

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

On 19 March 2013 09:30, Markus Armbruster wrote: > Coroutines are a perfectly pedestrian control flow construct. In some languages, sure. Not in C, and we're writing C. > Coroutines fit about as well with C as threads, namely not really. Threads are supported by the language runtime provided on

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

On 19 March 2013 09:31, li guang wrote: > 在 2013-03-19二的 09:05 +，Peter Maydell写道： >> I suspect this should involve more modelling of actual >> control signals between the power controller and >> the devices, not methods on the base class. >> > > do we have to realize something like signals whi

Re: [Qemu-devel] [PATCH] qcow2: fix null deref apparent during migration

Am 19.03.2013 um 10:35 hat Alon Levy geschrieben: > Signed-off-by: Alon Levy > --- > block/qcow2.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Thanks, Alon. I already sent a more comprehensive patch yesterday: http://patchwork.ozlabs.org/patch/228462/ I guess I should send a pull

Re: [Qemu-devel] [PATCH V27 1/7] Support for TPM command line options

On 03/19/2013 03:45 AM, Markus Armbruster wrote: Stefan Berger writes: On 03/18/2013 09:10 AM, Markus Armbruster wrote: In case the TPM is currently not operating on a command there will be no impact. In case the TPM is operating on a command, it will hold the thread inside /dev/tpm0 until th

Re: [Qemu-devel] [PATCH 00/35] hw/ reorganization, part 2

Il 19/03/2013 11:10, Peter Maydell ha scritto: > On 19 March 2013 09:26, Paolo Bonzini wrote: >> Il 18/03/2013 21:21, Peter Maydell ha scritto: >>> On 18 March 2013 20:05, Paolo Bonzini wrote: Il 18/03/2013 19:17, Peter Maydell ha scritto: >>> Shouldn't these containers also host the CPU

Re: [Qemu-devel] [PATCH 00/35] hw/ reorganization, part 2

On 19 March 2013 10:27, Paolo Bonzini wrote: > Il 19/03/2013 11:10, Peter Maydell ha scritto: >> Well, for the CPU to be a proper QOM object it should be exposing >> the IRQ/FIQ lines normally, not via the code in hw/arm/pic_cpu.c. > > That applies to everything else that was put in hw/ARCH. Ever

Re: [Qemu-devel] [PATCH v4] Add GDB qAttached support

On 03/15/2013 01:02 PM, Fabien Chouteau wrote: > On 03/14/2013 10:07 PM, Jesse Larrew wrote: >> On 03/14/2013 02:51 PM, Jan Kiszka wrote: >>> With this patch QEMU handles qAttached request from gdb. When QEMU >>> replies 1, GDB sends a "detach" command at the end of a debugging >>> session otherwis

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

On 19 March 2013 10:34, Paolo Bonzini wrote: > Il 19/03/2013 11:12, Peter Maydell ha scritto: >> Threads are supported by the language runtime provided on all >> the systems we support, which is why they are reasonably usable. >> When you've persuaded glibc, MacOSX libc and Windows to implement >>

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

Il 19/03/2013 11:06, George Dunlap ha scritto: > On Mon, Mar 18, 2013 at 6:00 PM, Paolo Bonzini wrote: >> Il 18/03/2013 18:38, George Dunlap ha scritto: > This might be a difference between Xen and KVM. On Xen migration is made to a server in a paused state, and it's only unpaused wh

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

Il 19/03/2013 11:12, Peter Maydell ha scritto: > On 19 March 2013 09:30, Markus Armbruster wrote: >> Coroutines are a perfectly pedestrian control flow construct. > > In some languages, sure. Not in C, and we're writing C. > >> Coroutines fit about as well with C as threads, namely not really. >

Re: [Qemu-devel] [PATCH] virtio-blk: Do not segfault fault if failed to initialize dataplane

Am 19.03.2013 um 09:37 hat KONRAD Frédéric geschrieben: > On 19/03/2013 09:27, Dunrong Huang wrote: > >$ ~/usr/bin/qemu-system-x86_64 -enable-kvm -m 1024 -drive > >if=none,id=drive0,cache=none,aio=native,format=raw,file=/root/Image/centos-6.4.raw > > -device virtio-blk-pci,drive=drive0,scsi=off,x-

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

On 03/19/2013 10:43 AM, Paolo Bonzini wrote: Even for successful migration, it would also be bad for downtime (QEMU isn't exactly lightning-fast to start). And even if failure weren't catastrophic, it would be a pity to transfer a few gigs of memory and then find out that QEMU isn't present in t

Re: [Qemu-devel] [PATCH v2 1/2] arm_gic: Fix sizes of state fields in preparation for vmstate support

Am 18.03.2013 18:47, schrieb Peter Maydell: > In preparation for switching to vmstate for migration support, fix > the sizes of various GIC state fields. In particular, we replace all > the bitfields (which VMState can't deal with) with straightforward > uint8_t values which we do bit operations on

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm_gic_common: Use vmstate struct rather than save/load functions

Am 18.03.2013 21:43, schrieb Igor Mitsyanko: > > On Mar 19, 2013 12:21 AM, "Peter Maydell" > wrote: >> >> On 18 March 2013 19:48, Igor Mitsyanko > wrote: >> >> On 03/18/2013 09:47 PM, Peter Maydell wrote: >> >>> >> >>> +VMSTA

Re: [Qemu-devel] [PATCH 3/5] pseries: Fixes and enhancements to L1 cache properties

Am 18.03.2013 12:05, schrieb Alexander Graf: > > On 18.03.2013, at 11:54, Andreas Färber wrote: > >> Am 15.03.2013 13:27, schrieb Alexander Graf: >>> >>> On 14.03.2013, at 02:53, David Gibson wrote: >>> PAPR requires that the device tree's CPU nodes have several properties with informat

Re: [Qemu-devel] [PATCH 3/5] pseries: Fixes and enhancements to L1 cache properties

On 19.03.2013, at 12:06, Andreas Färber wrote: > Am 18.03.2013 12:05, schrieb Alexander Graf: >> >> On 18.03.2013, at 11:54, Andreas Färber wrote: >> >>> Am 15.03.2013 13:27, schrieb Alexander Graf: On 14.03.2013, at 02:53, David Gibson wrote: > PAPR requires that the devic

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

Il 19/03/2013 11:51, George Dunlap ha scritto: > On 03/19/2013 10:43 AM, Paolo Bonzini wrote: Even for successful migration, it would also be bad for downtime (QEMU isn't exactly lightning-fast to start). And even if failure weren't catastrophic, it would be a pity to transfer a few

Re: [Qemu-devel] [PATCH 3/5] pseries: Fixes and enhancements to L1 cache properties

Am 19.03.2013 12:09, schrieb Alexander Graf: > > On 19.03.2013, at 12:06, Andreas Färber wrote: > >> Am 18.03.2013 12:05, schrieb Alexander Graf: >>> >>> On 18.03.2013, at 11:54, Andreas Färber wrote: >>> Am 15.03.2013 13:27, schrieb Alexander Graf: > > On 14.03.2013, at 02:53, David

Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

Il 19/03/2013 09:51, Markus Armbruster ha scritto: > Paolo, please have a look. Why isn't it enough to call bdrv_init_with_whitelist earlier? There is no conditional logic in it, the whitelist is checked at open time. Paolo > Peter Lieven writes: > >> current git master segfaults if an iscsi

[Qemu-devel] [PATCH 1/5] sheepdog: show error message for halt status

From: Liu Yuan Sheepdog (neither quorum nor unsafe mode) will refuse to serve IO requests when number of alive nodes is less than that of copies specified by users. This will return 0x19 to QEMU client which currently doesn't recognize it. This patch adds an error description when QEMU client re

[Qemu-devel] [PATCH 3/5] block: fix BDRV_O_SNAPSHOT protocol detection

From: Stefan Hajnoczi realpath(3) is used to get an absolute path to the image file when creating a -drive snapshot=on temporary qcow2. This does not work for protocols since their filenames ("proto:foo:...") do not correspond to file system paths. Commit 7c96d46ec245d73fd76726588409f9abe4bd5dc

[Qemu-devel] [PATCH 2/5] qcow2: Fix segfault in qcow2_invalidate_cache

Need to pass an options QDict to qcow2_open() now. This fixes a segfault on the migration target with qcow2. Signed-off-by: Kevin Wolf --- block/qcow2.c | 12 ++-- block/qcow2.h | 3 +++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index

[Qemu-devel] [PATCH V2 3/3] target-arm: Fix VFP register byte order in GDB remote

>From GDB Remote Serial Protocol doc: "The bytes with the register are transmitted in target byte order." Signed-off-by: Fabien Chouteau --- target-arm/helper.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper

[Qemu-devel] [PATCH V2 1/3] QAPI: Add ARMEB target-type

Signed-off-by: Fabien Chouteau --- qapi-schema.json |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 28b070f..0615715 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -2993,10 +2993,11 @@ # Since: 1.2.0 ## { 'enum

[Qemu-devel] [PATCH V2 2/3] Add default config for armeb-softmmu

Just create one that includes arm-softmmu.mak. Signed-off-by: Fabien Chouteau --- default-configs/armeb-softmmu.mak |3 +++ 1 file changed, 3 insertions(+) create mode 100644 default-configs/armeb-softmmu.mak diff --git a/default-configs/armeb-softmmu.mak b/default-configs/armeb-softmmu.m

[Qemu-devel] [PATCH 4/5] qemu-iotests: add 052 BDRV_O_SNAPSHOT test

From: Stefan Hajnoczi Check that writes to an image opened with BDRV_O_SNAPSHOT do not modify the underlying image file. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- tests/qemu-iotests/052 | 61 ++ tests/qemu-iotests/052.out | 13

[Qemu-devel] [PATCH 5/5] virtio-blk: Do not segfault fault if failed to initialize dataplane

From: Dunrong Huang $ ~/usr/bin/qemu-system-x86_64 -enable-kvm -m 1024 -drive if=none,id=drive0,cache=none,aio=native,format=raw,file=/root/Image/centos-6.4.raw -device virtio-blk-pci,drive=drive0,scsi=off,x-data-plane=on,config-wce=on # make dataplane fail to initialize qemu-system-x86_64: -d

[Qemu-devel] [PULL 0/5] Block layer fixes

Anthony, this includes the fixes for recently introduced regressions in the block layer: With qcow2 and migration a NULL pointer access, and with virtio-blk dataplane a double free in error cases. The following changes since commit 2d62a95766025e6a0a333528278936e2cc8bf978: virtio-blk: cleanup:

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

On 03/19/2013 11:14 AM, Paolo Bonzini wrote: Il 19/03/2013 11:51, George Dunlap ha scritto: On 03/19/2013 10:43 AM, Paolo Bonzini wrote: Even for successful migration, it would also be bad for downtime (QEMU isn't exactly lightning-fast to start). And even if failure weren't catastrophic, it w

[Qemu-devel] [PATCH V2 0/3] ARM: Misc ARM big-endian bug fixes

v2: - I drop the the CPSR.E/SCTLR.E/SCTLR.IE patch. The issue is still too complex for me to submit a good patch. - Fix the GDB byte order for 64bits registers Fabien Chouteau (3): QAPI: Add ARMEB target-type Add default config for armeb-softmmu target-arm: Fix VFP register byte order

Re: [Qemu-devel] [PATCH V2 0/3] ARM: Misc ARM big-endian bug fixes

On 19 March 2013 11:21, Fabien Chouteau wrote: > v2: > - I drop the the CPSR.E/SCTLR.E/SCTLR.IE patch. The issue is still too > complex for me to submit a good patch. > > - Fix the GDB byte order for 64bits registers > > Fabien Chouteau (3): > QAPI: Add ARMEB target-type > Add default co

[Qemu-devel] [PATCH] serial: Fix debug format strings

This fixes the build of hw/serial.c with DEBUG_SERIAL enabled. Signed-off-by: Kevin Wolf --- hw/serial.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/serial.c b/hw/serial.c index 48a5eb6..0ccc499 100644 --- a/hw/serial.c +++ b/hw/serial.c @@ -306,7 +306,7 @@ static

Re: [Qemu-devel] [PATCH 3/5] pseries: Fixes and enhancements to L1 cache properties

On 19.03.2013, at 12:16, Andreas Färber wrote: > Am 19.03.2013 12:09, schrieb Alexander Graf: >> >> On 19.03.2013, at 12:06, Andreas Färber wrote: >> >>> Am 18.03.2013 12:05, schrieb Alexander Graf: On 18.03.2013, at 11:54, Andreas Färber wrote: > Am 15.03.2013 13:27, schri

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

Il 19/03/2013 11:38, Peter Maydell ha scritto: > On 19 March 2013 10:34, Paolo Bonzini wrote: >> Il 19/03/2013 11:12, Peter Maydell ha scritto: >>> Threads are supported by the language runtime provided on all >>> the systems we support, which is why they are reasonably usable. >>> When you've per

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

--On 19 March 2013 12:14:36 +0100 Paolo Bonzini wrote: Unfortunately no. The problem is in the loading side's kernel, on which you do not have any control. If the loading side doesn't use O_DIRECT, any attempt to invalidate the metadata in userspace or on the source is futile, because there

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

Il 19/03/2013 12:44, Alex Bligh ha scritto: > If this isn't true, we have a problem anyway with (e.g.) emulated > devices which don't use O_DIRECT anyway. Yes, though that would be a libxl bug, not a QEMU bug. > And I had thought (I may be > wrong) using O_DIRECT does not guarantee no read cachin

[Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr

Although the support of this register may be uncomplete, there are no reason to prevent the debugger from reading or writing it. Signed-off-by: Fabien Chouteau --- gdbstub.c |3 ++- target-ppc/translate_init.c |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) dif

Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr

On 19.03.2013, at 13:03, Fabien Chouteau wrote: > Although the support of this register may be uncomplete, there are no > reason to prevent the debugger from reading or writing it. > > Signed-off-by: Fabien Chouteau > --- > gdbstub.c |3 ++- > target-ppc/translate_init.c |

Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr

On 19 March 2013 12:10, Alexander Graf wrote: > Check out helper_store_fpscr() in target-ppc/fpu_helper.c. Storing > fpscr has a bunch of side effects that won't happen when you just > set the env variable. Speaking of which, am I missing something, or does the code in machine.c do nothing to ens

Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr

On 19.03.2013, at 13:13, Peter Maydell wrote: > On 19 March 2013 12:10, Alexander Graf wrote: >> Check out helper_store_fpscr() in target-ppc/fpu_helper.c. Storing >> fpscr has a bunch of side effects that won't happen when you just >> set the env variable. > > Speaking of which, am I missing s

Re: [Qemu-devel] [PATCH] Introduce query-cpu-max QMP command and cpu_max HMP counterpart

Please cc: Luiz and me on QMP work in the future. Michal Novotny writes: > This is the patch to introduce the query-cpu-max QMP command to get > the maximum number of CPUs supported by the currently running emulator > instance. This may differ machine from machine as defined by -machine > settin

[Qemu-devel] [PATCH] char: Fix return type of qemu_chr_fe_add_watch()

qemu_chr_fe_add_watch() can return negative errors, therefore it must not have an unsigned return type. For consistency with other qemu_chr_fe_* functions, this uses a standard C int instead of glib types. In situations where qemu_chr_fe_add_watch() is falsely assumed to have succeeded, the serial

Re: [Qemu-devel] [PATCH 8/8] usb-redir: Add flow control support

On 03/14/13 17:36, Hans de Goede wrote: > +if (!dev->watch) { > +dev->watch = qemu_chr_fe_add_watch(dev->cs, G_IO_OUT, > + usbredir_write_unblocked, > dev); > +} > +if (r < 0) > +r = 0; > +} > +re

Re: [Qemu-devel] [PATCH] serial: Fix debug format strings

Cc'ing qemu-trivial Kevin Wolf writes: > This fixes the build of hw/serial.c with DEBUG_SERIAL enabled. > > Signed-off-by: Kevin Wolf > --- > hw/serial.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/serial.c b/hw/serial.c > index 48a5eb6..0ccc499 100644 > ---

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 09/10] check for QMP string and bypass nonblock() calls

On 03/19/2013 05:23 AM, Paolo Bonzini wrote: Yes---this is a separate patch. Apologies if you had the if(fd != -1) before. :) In fact, both the if(fd != -1) and the if(!migrate_use_rdma(f)) are bad, but I prefer to eliminate as many uses as possible of migrate_use_rdma. I agree. In my current

Re: [Qemu-devel] [PATCH 1/3] Revert "block: complete all IOs before .bdrv_truncate"

Am 11.03.2013 um 11:03 hat Peter Lieven geschrieben: > brdv_truncate() is also called from readv/writev commands on self- > growing file based storage. this will result in requests waiting > for theirselves to complete. > > This reverts commit 9a665b2b8640e464f0a778216fc2dca8d02acf33. Thanks, app

Re: [Qemu-devel] [PATCH 2/3] block: complete all IOs before resizing a device

Am 11.03.2013 um 11:04 hat Peter Lieven geschrieben: > this patch ensures that all pending IOs are completed > before a device is resized. this is especially important > if a device is shrinked as it the bdrv_check_request() > result is invalidated. > > Signed-off-by: Peter Lieven Thanks, applie

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 08/10] introduce QEMUFileRDMA

On 03/19/2013 05:18 AM, Paolo Bonzini wrote: Il 18/03/2013 21:33, Michael R. Hines ha scritto: +int qemu_drain(QEMUFile *f) +{ +return f->ops->drain ? f->ops->drain(f->opaque) : 0; +} Hmm, this is very similar to qemu_fflush, but not quite. :/ Why exactly is this needed? Good idea - I'll r

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

On 03/19/2013 04:19 AM, Michael S. Tsirkin wrote: We have ways (e.g. cgroups) to limit what a VM can do. If it tries to use more RAM than we let it, it will swap, still making progress, just slower. OTOH it looks like pinning more memory than allowed by the cgroups limit will just get stuck for

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 09/10] check for QMP string and bypass nonblock() calls

Il 19/03/2013 14:08, Michael R. Hines ha scritto: > On 03/19/2013 05:23 AM, Paolo Bonzini wrote: >> >> Yes---this is a separate patch. Apologies if you had the if(fd != -1) >> before. :) In fact, both the if(fd != -1) and the >> if(!migrate_use_rdma(f)) are bad, but I prefer to eliminate as many

Re: [Qemu-devel] [PATCH] Introduce query-cpu-max QMP command and cpu_max HMP counterpart

On 03/19/2013 01:28 PM, Markus Armbruster wrote: > Please cc: Luiz and me on QMP work in the future. > > Michal Novotny writes: > >> This is the patch to introduce the query-cpu-max QMP command to get >> the maximum number of CPUs supported by the currently running emulator >> instance. This may

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 08/10] introduce QEMUFileRDMA

Il 19/03/2013 14:12, Michael R. Hines ha scritto: > On 03/19/2013 05:18 AM, Paolo Bonzini wrote: >> Il 18/03/2013 21:33, Michael R. Hines ha scritto: +int qemu_drain(QEMUFile *f) +{ +return f->ops->drain ? f->ops->drain(f->opaque) : 0; +} Hmm, this is very similar to qe

Re: [Qemu-devel] [PATCH] Introduce query-cpu-max QMP command and cpu_max HMP counterpart

Am 19.03.2013 13:28, schrieb Markus Armbruster: > Please cc: Luiz and me on QMP work in the future. > > Michal Novotny writes: > >> This is the patch to introduce the query-cpu-max QMP command to get >> the maximum number of CPUs supported by the currently running emulator >> instance. This may

Re: [Qemu-devel] [PATCH] virtio-blk: Do not segfault fault if failed to initialize dataplane

On 19/03/2013 11:33, Kevin Wolf wrote: Am 19.03.2013 um 09:37 hat KONRAD Frédéric geschrieben: On 19/03/2013 09:27, Dunrong Huang wrote: $ ~/usr/bin/qemu-system-x86_64 -enable-kvm -m 1024 -drive if=none,id=drive0,cache=none,aio=native,format=raw,file=/root/Image/centos-6.4.raw -device virtio-

Re: [Qemu-devel] [PATCH] serial: Fix debug format strings

Am 19.03.2013 12:25, schrieb Kevin Wolf: > This fixes the build of hw/serial.c with DEBUG_SERIAL enabled. > > Signed-off-by: Kevin Wolf > --- > hw/serial.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/serial.c b/hw/serial.c > index 48a5eb6..0ccc499 100644 > --

Re: [Qemu-devel] [PATCH] Introduce query-cpu-max QMP command and cpu_max HMP counterpart

On 03/19/2013 02:27 PM, Andreas Färber wrote: > Am 19.03.2013 13:28, schrieb Markus Armbruster: >> Please cc: Luiz and me on QMP work in the future. >> >> Michal Novotny writes: >> >>> This is the patch to introduce the query-cpu-max QMP command to get >>> the maximum number of CPUs supported by

Re: [Qemu-devel] [PATCH v9 03/10] virtio-blk: don't use pointer for configuration.

On 18/03/2013 09:59, Kevin Wolf wrote: Am 15.03.2013 um 19:48 hat fred.kon...@greensocs.com geschrieben: From: KONRAD Frederic The configuration field must not be a pointer as it will be used for virtio-blk properties. So *blk is replaced by blk in VirtIOBlock structure. Signed-off-by: KONRAD

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 08/10] introduce QEMUFileRDMA

On 03/19/2013 09:25 AM, Paolo Bonzini wrote: Yes, the drain needs to happen in a few places already: 1. During save_rdma_page (if the current "chunk" is full of pages) Ok, this is internal to RDMA so no problem. 2. During the end of each iteration (now using qemu_fflush in my current patch) W

Re: [Qemu-devel] [PATCH] serial: Fix debug format strings

Am 19.03.2013 um 14:29 hat Andreas Färber geschrieben: > Am 19.03.2013 12:25, schrieb Kevin Wolf: > > This fixes the build of hw/serial.c with DEBUG_SERIAL enabled. > > > > Signed-off-by: Kevin Wolf > > --- > > hw/serial.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > di

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 08/10] introduce QEMUFileRDMA

Il 19/03/2013 14:40, Michael R. Hines ha scritto: > On 03/19/2013 09:25 AM, Paolo Bonzini wrote: >> Yes, the drain needs to happen in a few places already: >> >> 1. During save_rdma_page (if the current "chunk" is full of pages) >> Ok, this is internal to RDMA so no problem. >> >>> 2. During the en

  1   2   3   >