Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-26 Thread Eduardo Habkost
On Tue, Feb 26, 2013 at 11:50:08AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > This allows ":" to be used a separator between each CPU range, so the > > command-line may look like: > > > > -numa node,cpus=A-B:C-D > > > > Note that the following format, currently used by libv

Re: [Qemu-devel] [PATCH v4 RESEND 0/5] sheepdog: unix domain socket support

2013-02-26 Thread Stefan Hajnoczi
On Fri, Feb 22, 2013 at 12:39:48PM +0900, MORITA Kazutaka wrote: > This series makes sheepdog accept URI syntax, and adds a unix domain > socket support for a connection between qemu and local sheepdog server > based on the syntax. > > Changes from v3: > - fix wrong URI syntax in the commit log >

Re: [Qemu-devel] [PATCH v3 0/5] kvm: Make ioeventfd usable on s390.

2013-02-26 Thread Cornelia Huck
On Tue, 26 Feb 2013 15:56:43 +0200 "Michael S. Tsirkin" wrote: > On Tue, Feb 26, 2013 at 02:29:07PM +0100, Cornelia Huck wrote: > > On Tue, 26 Feb 2013 13:13:39 +0100 > > Christian Borntraeger wrote: > > > > > On 26/02/13 12:18, Michael S. Tsirkin wrote: > > > > virtio_ccw: pass a cookie value

Re: [Qemu-devel] [PATCH v3 4/5] KVM: ioeventfd for virtio-ccw devices.

2013-02-26 Thread Stefan Hajnoczi
On Tue, Feb 26, 2013 at 12:55:36PM +0200, Michael S. Tsirkin wrote: > On Mon, Feb 25, 2013 at 04:27:49PM +0100, Cornelia Huck wrote: > > diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c > > index f0ced1a..8de3cd7 100644 > > --- a/virt/kvm/eventfd.c > > +++ b/virt/kvm/eventfd.c > > @@ -679,11 +6

Re: [Qemu-devel] [PATCH v3 4/5] KVM: ioeventfd for virtio-ccw devices.

2013-02-26 Thread Stefan Hajnoczi
On Mon, Feb 25, 2013 at 04:27:49PM +0100, Cornelia Huck wrote: > diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c > index f0ced1a..8de3cd7 100644 > --- a/virt/kvm/eventfd.c > +++ b/virt/kvm/eventfd.c > @@ -679,11 +679,16 @@ static int > kvm_assign_ioeventfd(struct kvm *kvm, struct kvm_ioeventf

Re: [Qemu-devel] [PATCH] vl.c: Support multiple CPU ranges on -numa option

2013-02-26 Thread Paolo Bonzini
Il 26/02/2013 15:04, Eduardo Habkost ha scritto: >> > For me, the INI way to do multi-valued keys is still fine. > Having multiple-valued keys (cpus=A,cpus=B,cpus=C) seems like the best > intermediate solution while we don't have a decent generic syntax. Even more so since: 1) we already support

Re: [Qemu-devel] [PATCH 04/10] target-i386: convert 'hv_spinlocks' to static property

2013-02-26 Thread Eduardo Habkost
On Mon, Feb 25, 2013 at 02:03:03AM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > target-i386/cpu.c | 50 -- > 1 files changed, 48 insertions(+), 2 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 35

Re: [Qemu-devel] [PATCH 04/10] target-i386: convert 'hv_spinlocks' to static property

2013-02-26 Thread Eduardo Habkost
On Mon, Feb 25, 2013 at 02:03:03AM +0100, Igor Mammedov wrote: [...] > +static void x86_set_hv_spinlocks(Object *obj, Visitor *v, void *opaque, > + const char *name, Error **errp) > +{ > +const int64_t min = 0xFFF; > +const int64_t max = UINT_MAX; > +X86C

Re: [Qemu-devel] KVM call agenda for 2013-02-26

2013-02-26 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please send in any agenda topics you are interested in. No agenda -> No call. Happy hacking, Juan.

Re: [Qemu-devel] [PATCH v3 4/5] KVM: ioeventfd for virtio-ccw devices.

2013-02-26 Thread Cornelia Huck
On Tue, 26 Feb 2013 15:20:52 +0100 Stefan Hajnoczi wrote: > On Tue, Feb 26, 2013 at 12:55:36PM +0200, Michael S. Tsirkin wrote: > > On Mon, Feb 25, 2013 at 04:27:49PM +0100, Cornelia Huck wrote: > > > diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c > > > index f0ced1a..8de3cd7 100644 > > > -

Re: [Qemu-devel] [PATCH 03/10] target-i386: move hyperv_* static globals to CPUState

2013-02-26 Thread Eduardo Habkost
On Mon, Feb 25, 2013 at 02:03:02AM +0100, Igor Mammedov wrote: > - since hyperv_* helper functions are used only in target-i386/kvm.c > move them there as static helpers > > Signed-off-by: Igor Mammedov > Requestd-By: Eduardo Habkost I wonder if we could do this later, to make review and test

Re: [Qemu-devel] [PATCH v6 3/9] ARM: KVM: Add support for KVM on ARM architecture

2013-02-26 Thread Peter Maydell
On 23 February 2013 15:14, Andreas Färber wrote: > Am 22.02.2013 20:04, schrieb Peter Maydell: >> +static void kvm_arm_pic_cpu_handler(void *opaque, int irq, int level) >> +{ >> +#ifdef CONFIG_KVM >> +ARMCPU *armcpu = opaque; >> +CPUState *cpu = CPU(armcpu); > > I notice this is the only p

[Qemu-devel] [PATCH] block: for HMP commit() operations on 'all', skip non-COW drives

2013-02-26 Thread Jeff Cody
During a commit of 'all' using the HMP non-live commit, the operation is aborted and returns error on the first error enountered. When non-COW drives are in use (e.g. ejected floppy, cdrom, or drives without a backing parent), that means a commit all will return an error of either -ENOMEDIUM or -E

Re: [Qemu-devel] Which qemu version to use for CentOS6?

2013-02-26 Thread Andy Cress
Stefan, That is what I needed to know. Thanks. It was somewhat surprising to see how many patches have been backported to the CentOS6.3 source rpm. Andy -Original Message- From: Stefan Hajnoczi [mailto:stefa...@gmail.com] Sent: Monday, February 25, 2013 9:41 AM To: Andy Cress Cc: qe

Re: [Qemu-devel] Moving BIOS tables from SeaBIOS to QEMU

2013-02-26 Thread Paolo Bonzini
Il 25/02/2013 14:22, Laszlo Ersek ha scritto: >> > There have been a handful of contributors to these >> > files, but they all look to be regular QEMU contributors so I >> > don't think there would be any objections. Along with the code, >> > the IASL parsing code and associated bu

Re: [Qemu-devel] [PATCH] block: for HMP commit() operations on 'all', skip non-COW drives

2013-02-26 Thread Paolo Bonzini
Il 26/02/2013 15:55, Jeff Cody ha scritto: > During a commit of 'all' using the HMP non-live commit, the operation > is aborted and returns error on the first error enountered. When > non-COW drives are in use (e.g. ejected floppy, cdrom, or drives without > a backing parent), that means a commit

[Qemu-devel] qdev static properties, custom setter/getter & validation (was Re: [PATCH 04/10] target-i386: convert 'hv_spinlocks' to static property)

2013-02-26 Thread Eduardo Habkost
TL;DR: I want to understand why a DEFINE_PROP_CUSTOM(name, type, getter_func, setter_func) macro doesn't exist yet. On Tue, Feb 26, 2013 at 11:38:59AM -0300, Eduardo Habkost wrote: [...] > > +static void x86_get_hv_spinlocks(Object *obj, Visitor *v, void *opaque, > > +

Re: [Qemu-devel] [PATCH v2 0/5] Cleanup of ARM MPCore

2013-02-26 Thread Peter Maydell
On 20 February 2013 01:28, Peter Crosthwaite wrote: > Patches 1-3 and 5 are trivial code cleanup and may be candidate to go via > trivial queue inpdependent of review of this work. Thanks, whole series Reviewed-by: Peter Maydell and applied to arm-devs.next. -- PMM

Re: [Qemu-devel] [PATCH] block: for HMP commit() operations on 'all', skip non-COW drives

2013-02-26 Thread Kevin Wolf
Am 26.02.2013 um 15:55 hat Jeff Cody geschrieben: > During a commit of 'all' using the HMP non-live commit, the operation > is aborted and returns error on the first error enountered. When > non-COW drives are in use (e.g. ejected floppy, cdrom, or drives without > a backing parent), that means a

Re: [Qemu-devel] [PATCH v10 0/3] Standard SD host controller model

2013-02-26 Thread Peter Maydell
On 20 February 2013 03:38, Peter Crosthwaite wrote: > First patch introduces standard SD host controller model. This is accumulated > version of my previous patch I sent a while ago and a recent SDHCI patch by > Peter A. G. Crosthwaite. > > Second patch changes the -sd command line argument to be

Re: [Qemu-devel] [PATCH 03/10] target-i386: move hyperv_* static globals to CPUState

2013-02-26 Thread Igor Mammedov
On Tue, 26 Feb 2013 11:50:23 -0300 Eduardo Habkost wrote: > On Mon, Feb 25, 2013 at 02:03:02AM +0100, Igor Mammedov wrote: > > - since hyperv_* helper functions are used only in target-i386/kvm.c > > move them there as static helpers > > > > Signed-off-by: Igor Mammedov > > Requestd-By: Eduar

Re: [Qemu-devel] [PATCH v2] piix: define a TOM register to report the base of PCI

2013-02-26 Thread Stefano Stabellini
Right, I think that reading as 0xff and write once would be important improvements for this patch. I would like to see a document somewhere (maybe just a text file under xen-unstable/docs/misc) with a list of deviations of the i440fx we emulate and the real one. Other than that, it would be OK fo

Re: [Qemu-devel] [PATCH v2] piix: define a TOM register to report the base of PCI

2013-02-26 Thread Ian Campbell
Given that Xen has at least two other mechanisms (xenstore and hvmparams) for passing this sort of information around I'm not sure why hacking the emulated i440fx device should be the preferred option. On Tue, 2013-02-26 at 15:43 +, Stefano Stabellini wrote: > Right, I think that reading as 0x

Re: [Qemu-devel] [PATCH] PATCH1 - infrastructure for Evaluate breakpoint condition on target.OPC_MAX_SIZE - size of translation buffer - was increased because condition translated bytecode should be e

2013-02-26 Thread Jan Kiszka
Please study http://wiki.qemu.org/Contribute/SubmitAPatch carefully. But lets assume this patch only adds the infrastructure to parse and store the condition expression in a breakpoint. On 2013-02-26 14:50, Anna Neiman wrote: > Signed-off-by: Anna Neiman > --- > exec.c | 16 +

Re: [Qemu-devel] [PATCH V7 04/14] block: move collect_snapshots() and collect_image_info() to block.c

2013-02-26 Thread Eric Blake
On 02/26/2013 03:40 AM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia In v6, I complained that these functions didn't match the namespace expected in block.c. You replied: >> This patch is just for making review easier, those two functions will >> be deleted later so they do not have much m

Re: [Qemu-devel] [PATCH 03/10] target-i386: move hyperv_* static globals to CPUState

2013-02-26 Thread Eduardo Habkost
On Tue, Feb 26, 2013 at 04:42:17PM +0100, Igor Mammedov wrote: > On Tue, 26 Feb 2013 11:50:23 -0300 > Eduardo Habkost wrote: > > > On Mon, Feb 25, 2013 at 02:03:02AM +0100, Igor Mammedov wrote: > > > - since hyperv_* helper functions are used only in target-i386/kvm.c > > > move them there as s

Re: [Qemu-devel] [PATCH 1/2] bridge helper: support conf dirs

2013-02-26 Thread Stefan Hajnoczi
On Sun, Feb 24, 2013 at 08:00:19PM -0600, Doug Goldstein wrote: > @@ -84,6 +105,9 @@ static int parse_acl_file(const char *filename, ACLList > *acl_list) > while (fgets(line, sizeof(line), f) != NULL) { > char *ptr = line; > char *cmd, *arg, *argend; > +struct dirent

Re: [Qemu-devel] [PATCH 04/10] target-i386: convert 'hv_spinlocks' to static property

2013-02-26 Thread Eduardo Habkost
On Tue, Feb 26, 2013 at 04:50:22PM +0100, Igor Mammedov wrote: > On Tue, 26 Feb 2013 11:42:08 -0300 > Eduardo Habkost wrote: > > > On Mon, Feb 25, 2013 at 02:03:03AM +0100, Igor Mammedov wrote: > > [...] > > > +static void x86_set_hv_spinlocks(Object *obj, Visitor *v, void *opaque, > > > +

Re: [Qemu-devel] [PATCH v4] doc: document -netdev hubport

2013-02-26 Thread Stefan Hajnoczi
On Tue, Feb 26, 2013 at 11:07:16AM +0100, Stefan Hajnoczi wrote: > Signed-off-by: Stefan Hajnoczi > --- > hmp-commands.hx | 2 +- > qemu-options.hx | 11 ++- > 2 files changed, 11 insertions(+), 2 deletions(-) Applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan

Re: [Qemu-devel] [PATCH 03/10] target-i386: move hyperv_* static globals to CPUState

2013-02-26 Thread Igor Mammedov
On Tue, 26 Feb 2013 13:01:12 -0300 Eduardo Habkost wrote: > On Tue, Feb 26, 2013 at 04:42:17PM +0100, Igor Mammedov wrote: > > On Tue, 26 Feb 2013 11:50:23 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Feb 25, 2013 at 02:03:02AM +0100, Igor Mammedov wrote: > > > > - since hyperv_* helper f

Re: [Qemu-devel] [PATCH] block: for HMP commit() operations on 'all', skip non-COW drives

2013-02-26 Thread Stefan Hajnoczi
On Tue, Feb 26, 2013 at 09:55:48AM -0500, Jeff Cody wrote: > During a commit of 'all' using the HMP non-live commit, the operation > is aborted and returns error on the first error enountered. When > non-COW drives are in use (e.g. ejected floppy, cdrom, or drives without > a backing parent), that

Re: [Qemu-devel] [PATCH 03/10] target-i386: move hyperv_* static globals to CPUState

2013-02-26 Thread Eduardo Habkost
On Tue, Feb 26, 2013 at 05:12:21PM +0100, Igor Mammedov wrote: > On Tue, 26 Feb 2013 13:01:12 -0300 > Eduardo Habkost wrote: > > > On Tue, Feb 26, 2013 at 04:42:17PM +0100, Igor Mammedov wrote: > > > On Tue, 26 Feb 2013 11:50:23 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Mon, Feb 25, 2

Re: [Qemu-devel] [PATCH V7 14/14] hmp: show snapshots on single block device

2013-02-26 Thread Eric Blake
On 02/26/2013 03:40 AM, Wenchao Xia wrote: > This patch added the support of showing internal snapshots on an > image in the backing chain of a block device in hmp layer, by > calling a qmp function. > > Signed-off-by: Wenchao Xia > --- > hmp.c | 81 > +++

Re: [Qemu-devel] [PATCH 04/10] target-i386: convert 'hv_spinlocks' to static property

2013-02-26 Thread Igor Mammedov
On Tue, 26 Feb 2013 11:42:08 -0300 Eduardo Habkost wrote: > On Mon, Feb 25, 2013 at 02:03:03AM +0100, Igor Mammedov wrote: > [...] > > +static void x86_set_hv_spinlocks(Object *obj, Visitor *v, void *opaque, > > + const char *name, Error **errp) > > +{ > > +con

Re: [Qemu-devel] unix sockets for qemu

2013-02-26 Thread Stefan Hajnoczi
On Mon, Feb 25, 2013 at 07:02:30PM -0600, clow...@clownix.net wrote: > The associated file contains a README that will guide you through the > experiment that shows the difference between unix socket carried pings: > 0.7ms and inet carried pings: 40ms!!! There is no fundamental reason for inet soc

Re: [Qemu-devel] [PATCH 03/10] target-i386: move hyperv_* static globals to CPUState

2013-02-26 Thread Igor Mammedov
On Tue, 26 Feb 2013 13:22:22 -0300 Eduardo Habkost wrote: > On Tue, Feb 26, 2013 at 05:12:21PM +0100, Igor Mammedov wrote: > > On Tue, 26 Feb 2013 13:01:12 -0300 > > Eduardo Habkost wrote: > > > > > On Tue, Feb 26, 2013 at 04:42:17PM +0100, Igor Mammedov wrote: > > > > On Tue, 26 Feb 2013 11:50

Re: [Qemu-devel] Block I/O optimizations

2013-02-26 Thread Stefan Hajnoczi
On Mon, Feb 25, 2013 at 08:45:58PM +0200, Abel Gordon wrote: > > > Stefan Hajnoczi wrote on wrote on 25/02/2013 02:50:56 > PM: > > You also create a > > privileged thread that has access to all guests on the host - a security > > bug here compromises all guests. This can be fine for private > >

Re: [Qemu-devel] unix sockets for qemu

2013-02-26 Thread Daniel P. Berrange
On Tue, Feb 26, 2013 at 05:31:04PM +0100, Stefan Hajnoczi wrote: > On Mon, Feb 25, 2013 at 07:02:30PM -0600, clow...@clownix.net wrote: > > The associated file contains a README that will guide you through the > > experiment that shows the difference between unix socket carried pings: > > 0.7ms and

Re: [Qemu-devel] [PATCH v4 2/6] add basic backup support to block driver

2013-02-26 Thread Stefan Hajnoczi
On Mon, Feb 25, 2013 at 03:49:11PM +, Dietmar Maurer wrote: > > > We previously used LVM and run backup with 'idle' IO priority (CFQ) to > > > avoid > > such behavior. > > > > > > But qemu does not provide an IO queue where we can set scheduling > > priorities? > > > > QEMU block jobs support

Re: [Qemu-devel] [PATCH v4 2/6] add basic backup support to block driver

2013-02-26 Thread Dietmar Maurer
> QEMU is not in a position to implement global scheduling (priorities). > The QEMU process only knows about one guest. If you have multiple guests on > the host an I/O "priority" inside QEMU process A will not take into account > QEMU process B. I only want priorities inside the guest. The backu

Re: [Qemu-devel] [PATCH 03/10] target-i386: move hyperv_* static globals to CPUState

2013-02-26 Thread Eduardo Habkost
On Tue, Feb 26, 2013 at 05:39:02PM +0100, Igor Mammedov wrote: [...] > > > > > > * I don't expect hv-* to appear on a machine-type compat_props > > > > > > array in the near feature. > > > > > > * I don't expect people to need to set per-CPU hv-* properties on > > > > > > device_add for CPU hotpl

Re: [Qemu-devel] [PATCH 03/10] target-i386: move hyperv_* static globals to CPUState

2013-02-26 Thread Igor Mammedov
On Tue, 26 Feb 2013 14:06:05 -0300 Eduardo Habkost wrote: > On Tue, Feb 26, 2013 at 05:39:02PM +0100, Igor Mammedov wrote: > [...] > > > > > > > * I don't expect hv-* to appear on a machine-type compat_props > > > > > > > array in the near feature. > > > > > > > * I don't expect people to need to

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-26 Thread Stefan Hajnoczi
On Mon, Feb 25, 2013 at 06:53:04PM +0100, Paolo Bonzini wrote: > Il 25/02/2013 18:35, mdroth ha scritto: > > Yup, don't mean to get ahead of things, my main interest is just in how > > we might deal with the interaction between NetClients and virtio-net > > dataplane threads without introducing ad-

[Qemu-devel] QCOW2 deduplication

2013-02-26 Thread Benoît Canet
Hello Kevin, As you are best person to discuss QCOW2 implementations issues with I am writing this mail so you can know what has been done on deduplication and what I am planning to do next. In short I need your feedback before going into another code sprint and being in need of another code rev

Re: [Qemu-devel] [PATCH v11 5/5] VMXNET3 device implementation

2013-02-26 Thread Stefan Hajnoczi
On Mon, Feb 25, 2013 at 11:05:31PM +0100, Andreas Färber wrote: > > + > > +static void vmxnet3_qdev_reset(DeviceState *dev) > > +{ > > +VMXNET3State *s = DO_UPCAST(VMXNET3State, dev.qdev, dev); > > Cast macro > > Stefan, please keep an eye on such QOM issues during your review! I'll try but

[Qemu-devel] [PATCH v7 01/11] oslib-posix: Align to permit transparent hugepages on ARM Linux

2013-02-26 Thread Peter Maydell
ARM Linux (like x86-64 Linux) can use transparent hugepages for KVM if memory blocks are 2MiB aligned; set QEMU_VMALLOC_ALIGN accordingly. Signed-off-by: Peter Maydell Reviewed-by: Paolo Bonzini --- util/oslib-posix.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/o

[Qemu-devel] [PATCH v7 03/11] target-arm: Drop CPUARMState* argument from bank_number()

2013-02-26 Thread Peter Maydell
Drop the CPUARMState* argument from bank_number(), since we only use it for passing to cpu_abort(). Use hw_error() instead. This avoids propagating further interfaces using env pointers. In the long term this function's callers need auditing to fix problems where badly behaved guests can pass inva

[Qemu-devel] [PATCH v7 04/11] ARM: KVM: Add support for KVM on ARM architecture

2013-02-26 Thread Peter Maydell
From: Christoffer Dall Add basic support for KVM on ARM architecture. Signed-off-by: Christoffer Dall [PMM: Minor tweaks and code cleanup, switch to ONE_REG] Signed-off-by: Peter Maydell Reviewed-by: Paolo Bonzini --- hw/arm_pic.c | 26 target-arm/Makefile.objs |1 + t

[Qemu-devel] [PATCH v7 07/11] hw/arm_gic: Convert ARM GIC classes to use init/realize

2013-02-26 Thread Peter Maydell
Convert the ARM GIC classes to use init/realize rather than SysBusDevice::init. (We have to do them all in one patch to avoid unconverted subclasses calling a nonexistent SysBusDevice init function in the base class and crashing.) Signed-off-by: Peter Maydell --- hw/arm_gic.c | 23 +++

[Qemu-devel] [PATCH v3] qemu-log: default to stderr for logging output

2013-02-26 Thread Peter Maydell
Switch the default for qemu_log logging output from "/tmp/qemu.log" to stderr. This is an incompatible change in some sense, but logging is mostly used for debugging purposes so it shouldn't affect production use. The previous behaviour can be obtained by adding "-D /tmp/qemu.log" to the command li

Re: [Qemu-devel] [PATCH 03/10] target-i386: move hyperv_* static globals to CPUState

2013-02-26 Thread Eduardo Habkost
On Tue, Feb 26, 2013 at 06:10:25PM +0100, Igor Mammedov wrote: > On Tue, 26 Feb 2013 14:06:05 -0300 > Eduardo Habkost wrote: > > > On Tue, Feb 26, 2013 at 05:39:02PM +0100, Igor Mammedov wrote: > > [...] > > > > > > > > * I don't expect hv-* to appear on a machine-type compat_props > > > > > > >

[Qemu-devel] mail me about your outstanding arm patches...

2013-02-26 Thread Peter Maydell
Hi; I'm putting together an arm-devs pullrequest. I've reviewed some ARM patches and will go hunting for more later this week, but my mail client tells me I was cc'd on 250 qemu-devel patches this month, so if you want your patchset not to be overlooked please ping it or mail me the patchwork url f

[Qemu-devel] [PATCH v7 05/11] ARM KVM: save and load VFP registers from kernel

2013-02-26 Thread Peter Maydell
Add support for saving and restoring VFP register state from the kernel. This includes a check that the KVM-created CPU has full VFP support (as the TCG Cortex-A15 model always does), since for the moment ARM QEMU doesn't have any way to tweak optional features on created CPUs. Signed-off-by: Pete

[Qemu-devel] [PATCH v7 00/11] QEMU: Support KVM on ARM

2013-02-26 Thread Peter Maydell
KVM ARM support has just hit Linus' kernel tree, so we can finally commit this series to QEMU. Since all the patches got reviewed last time round this should be ready to commit. I plan to commit this via arm-devs.next. NB: the linux-headers sync is against Linus' mainline, and so I had to make a f

[Qemu-devel] [PATCH v7 02/11] linux-headers: resync from mainline to add ARM KVM headers

2013-02-26 Thread Peter Maydell
Resync QEMU's copy of the Linux kernel headers from git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit 2ef14f4. This adds the ARM KVM headers, since ARM KVM support has just hit mainline via Russell's ARM tree. This is not a pure sync -- I have removed by hand some chan

Re: [Qemu-devel] [PATCH 03/10] target-i386: move hyperv_* static globals to CPUState

2013-02-26 Thread Igor Mammedov
On Tue, 26 Feb 2013 14:21:22 -0300 Eduardo Habkost wrote: > On Tue, Feb 26, 2013 at 06:10:25PM +0100, Igor Mammedov wrote: > > On Tue, 26 Feb 2013 14:06:05 -0300 > > Eduardo Habkost wrote: > > > > > On Tue, Feb 26, 2013 at 05:39:02PM +0100, Igor Mammedov wrote: > > > [...] > > > > > > > > > * I

[Qemu-devel] cpu_set vs device_add (was Re: [PATCH 03/10] target-i386: move hyperv_* static globals to CPUState)

2013-02-26 Thread Eduardo Habkost
On Tue, Feb 26, 2013 at 08:03:16PM +0100, Igor Mammedov wrote: [...] > > > > > > > > Won't -cpu/parse_featurestr() simply set global properties? In > > > > > > > > this > > > > > > > > case, the common case would be to call "device_add XXX" with no > > > > > > > > extra options at all, so there's

Re: [Qemu-devel] [PATCH v4 2/6] add basic backup support to block driver

2013-02-26 Thread Stefan Hajnoczi
On Mon, Feb 25, 2013 at 03:49:11PM +, Dietmar Maurer wrote: > > > We previously used LVM and run backup with 'idle' IO priority (CFQ) to > > > avoid > > such behavior. > > > > > > But qemu does not provide an IO queue where we can set scheduling > > priorities? > > > > QEMU block jobs support

Re: [Qemu-devel] cpu_set vs device_add (was Re: [PATCH 03/10] target-i386: move hyperv_* static globals to CPUState)

2013-02-26 Thread Igor Mammedov
On Tue, 26 Feb 2013 16:16:55 -0300 Eduardo Habkost wrote: > On Tue, Feb 26, 2013 at 08:03:16PM +0100, Igor Mammedov wrote: > [...] > > > > > > > > > Won't -cpu/parse_featurestr() simply set global properties? > > > > > > > > > In this > > > > > > > > > case, the common case would be to call "dev

Re: [Qemu-devel] [PATCH qom-cpu v3 2/6] stubs: Add a vmstate_dummy struct for CONFIG_USER_ONLY

2013-02-26 Thread Eduardo Habkost
On Mon, Feb 25, 2013 at 07:22:46PM +0100, Andreas Färber wrote: > Reviewed-by: Juan Quintela > Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost > --- > include/migration/vmstate.h |4 > stubs/vmstate.c |2 ++ > 2 Dateien geändert, 6 Zeilen hinzugefügt(+) >

Re: [Qemu-devel] [PATCH qom-cpu v3 3/6] cpu: Register VMStateDescription through CPUState

2013-02-26 Thread Eduardo Habkost
On Mon, Feb 25, 2013 at 07:22:47PM +0100, Andreas Färber wrote: > In comparison to DeviceClass::vmsd, CPU VMState is split in two, > "cpu_common" and "cpu", and uses cpu_index as instance_id instead of -1. > Therefore add a CPU-specific CPUClass::vmsd field. > > Unlike the legacy CPUArchState regi

Re: [Qemu-devel] [PATCH qom-cpu v3 4/6] cpu: Introduce cpu_class_set_vmsd()

2013-02-26 Thread Eduardo Habkost
On Mon, Feb 25, 2013 at 07:22:48PM +0100, Andreas Färber wrote: > This setter avoids redefining each VMStateDescription value to > vmstate_dummy by not referencing the value for CONFIG_USER_ONLY. > > Suggested-by: Juan Quintela > Signed-off-by: Andreas Färber > --- > include/qom/cpu.h | 17 ++

Re: [Qemu-devel] [PATCH v2] piix: define a TOM register to report the base of PCI

2013-02-26 Thread Anthony Liguori
Ian Campbell writes: > Given that Xen has at least two other mechanisms (xenstore and > hvmparams) for passing this sort of information around I'm not sure why > hacking the emulated i440fx device should be the preferred option. And QEMU also provides the fw_cfg interface with this information.

Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-26 Thread Anthony Liguori
Eduardo Habkost writes: > On Tue, Feb 26, 2013 at 11:50:08AM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > This allows ":" to be used a separator between each CPU range, so the >> > command-line may look like: >> > >> > -numa node,cpus=A-B:C-D >> > >> > Note that the foll

[Qemu-devel] [PATCH v2] gtk: Release modifier when graphic console loses keyboard focus

2013-02-26 Thread Jan Kiszka
From: Jan Kiszka This solves, e.g., sticky ALT when selecting a GTK menu, switching to a different window or selecting a different virtual console. Signed-off-by: Jan Kiszka --- Changes in v2: - fix a style issue - truly switch off line-wrapping before sending (sorry) ui/gtk.c | 53 +

[Qemu-devel] [PATCH] apic: fixup fallthrough to PIC

2013-02-26 Thread Mark Asselstine
Commit 0e21e12bb311c4c1095d0269dc2ef81196ccb60a [Don't route PIC interrupts through the local APIC if the local APIC config says so.] missed a check to ensure the local APIC is enabled. Since if the local APIC is disabled it doesn't matter what the local APIC config says. If this check isn't done

Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-26 Thread Eduardo Habkost
On Tue, Feb 26, 2013 at 01:35:14PM -0600, Anthony Liguori wrote: > Eduardo Habkost writes: > > > On Tue, Feb 26, 2013 at 11:50:08AM +0100, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > This allows ":" to be used a separator between each CPU range, so the > >> > command-line

Re: [Qemu-devel] [PATCH qom-cpu v3 5/6] target-i386: Update VMStateDescription to X86CPU

2013-02-26 Thread Eduardo Habkost
On Mon, Feb 25, 2013 at 07:22:49PM +0100, Andreas Färber wrote: > Expose vmstate_cpu as vmstate_x86_cpu and hook it up to CPUClass::vmsd. > Adapt opaques and VMState fields to X86CPU. Drop cpu_{save,load}(). > > Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost > --- > target-i386/cp

Re: [Qemu-devel] unix sockets for qemu

2013-02-26 Thread Paolo Bonzini
Il 26/02/2013 17:51, Daniel P. Berrange ha scritto: > On Tue, Feb 26, 2013 at 05:31:04PM +0100, Stefan Hajnoczi wrote: >> On Mon, Feb 25, 2013 at 07:02:30PM -0600, clow...@clownix.net wrote: >>> The associated file contains a README that will guide you through the >>> experiment that shows the diff

Re: [Qemu-devel] [PATCH] Reenable -Wstrict-prototypes

2013-02-26 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] apic: fixup fallthrough to PIC

2013-02-26 Thread Jan Kiszka
On 2013-02-26 20:48, Mark Asselstine wrote: > Commit 0e21e12bb311c4c1095d0269dc2ef81196ccb60a [Don't route PIC > interrupts through the local APIC if the local APIC config says so.] > missed a check to ensure the local APIC is enabled. Since if the local > APIC is disabled it doesn't matter what th

Re: [Qemu-devel] [PATCH] gtk: Release modifier when graphic console loses keyboard focus

2013-02-26 Thread Anthony Liguori
Jan Kiszka writes: > From: Jan Kiszka > > This solves, e.g., sticky ALT when selecting a GTK menu, switching to a > different window or selecting a different virtual console. > > Signed-off-by: Jan Kiszka FYI, this patch is whitespace damaged. Looks like your mailer line wrapped. Regards, A

[Qemu-devel] [PATCH] target-i386: Use mulu2 and muls2

2013-02-26 Thread Richard Henderson
These correspond very closely to the insns that we're emulating. Signed-off-by: Richard Henderson --- target-i386/helper.h | 4 -- target-i386/int_helper.c | 40 target-i386/translate.c | 167 --- 3 files changed, 56 insertions(+),

Re: [Qemu-devel] [PATCH] target-i386: Improve x86_cpu_list output

2013-02-26 Thread Eduardo Habkost
On Sat, Feb 23, 2013 at 04:45:00PM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > Several issues fixed: > - We were missing a bunch of feature lists. Fix this by simply dumping >the meta list feature_word_info. > - kvm_enabled() cannot be true at this point because accelerators are >in

Re: [Qemu-devel] [PATCH] apic: fixup fallthrough to PIC

2013-02-26 Thread Mark Asselstine
On February 26, 2013 21:03:46 Jan Kiszka wrote: > On 2013-02-26 20:48, Mark Asselstine wrote: > > Commit 0e21e12bb311c4c1095d0269dc2ef81196ccb60a [Don't route PIC > > interrupts through the local APIC if the local APIC config says so.] > > missed a check to ensure the local APIC is enabled. Since i

Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-26 Thread Paolo Bonzini
Il 26/02/2013 20:35, Anthony Liguori ha scritto: >>> >> >>> >> See also discussion on multi-valued keys in command line option >>> >> arguments and config files in v1 thread. Hopefully we can reach a >>> >> conclusion soon, and then we'll see whether this patch is what we want. >> > >> > Yeah, le

Re: [Qemu-devel] [PATCH v3 0/3] Fix two carry problems in add2 patchset

2013-02-26 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-26 Thread Markus Armbruster
Paolo Bonzini writes: > Il 26/02/2013 20:35, Anthony Liguori ha scritto: >> >> See also discussion on multi-valued keys in command line option >> arguments and config files in v1 thread. Hopefully we can reach a >> conclusion soon, and then we'll see whether this patch is wh

[Qemu-devel] Qemu doesn't start with UEFI "bios"

2013-02-26 Thread Georgios Tsalikis
Greeting Qemu fellows :) I have invoked Qemu with various parameters. For example: $ /usr/bin/qemu-system-x86_64 -monitor stdio -enable-kvm -m 512 -localtime -hda /home/george/Qemu\ VMs/efi-bios/efi.disk -hdb /home/george/Qemu\ VMs/efi-bios/linux-0.2.img -net none -name "UEFI test" -bios /hom

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2013-02-26 Thread Stefan Mühlbacher
High! Tryed: apt-get install qemu-kvm/quantal-proposed reboot Feb 26 18:24:03 wbmain1 kernel: [ 651.947372] usb 8-2: reset full-speed USB device number 2 using uhci_hcd Feb 26 18:24:06 wbmain1 kernel: [ 655.077459] usb 8-2: reset full-speed USB device number 2 using uhci_hcd root@wbmain1:~#

Re: [Qemu-devel] [PATCH v2] ui/gtk: Use menu item from stock for full screen

2013-02-26 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v2] ui/gtk: Support versions of VTE before 0.26

2013-02-26 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

[Qemu-devel] [PATCH v7 08/11] target-arm: Use MemoryListener to identify GIC base address for KVM

2013-02-26 Thread Peter Maydell
When using an in-kernel GIC with KVM, we need to tell the kernel where the GIC's memory mapped registers live. Do this by registering a MemoryListener which tracks where the board model maps the A15's private peripherals, so we can finish the GIC initialisation when the GIC is actually mapped. Sig

Re: [Qemu-devel] [PULL] QMP queue

2013-02-26 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] cpu_set vs device_add (was Re: [PATCH 03/10] target-i386: move hyperv_* static globals to CPUState)

2013-02-26 Thread Eduardo Habkost
On Tue, Feb 26, 2013 at 08:22:13PM +0100, Igor Mammedov wrote: > On Tue, 26 Feb 2013 16:16:55 -0300 > Eduardo Habkost wrote: > > > On Tue, Feb 26, 2013 at 08:03:16PM +0100, Igor Mammedov wrote: > > [...] > > > > > > > > > > Won't -cpu/parse_featurestr() simply set global properties? > > > > > >

[Qemu-devel] [PATCH v7 11/11] MAINTAINERS: add entry for ARM KVM guest cores

2013-02-26 Thread Peter Maydell
Add an entry indicating maintainer status for the ARM KVM code. Signed-off-by: Peter Maydell --- MAINTAINERS |5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 21043e4..2439614 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -140,6 +140,11 @@ S: Supported

[Qemu-devel] [PATCH v7 10/11] configure: Enable KVM on ARM

2013-02-26 Thread Peter Maydell
Enable KVM on ARM hosts, now that all the necessary components for it exist. Signed-off-by: Peter Maydell Reviewed-by: Paolo Bonzini --- configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index dcaa67c..bb95552 100755 --- a/configure +++ b/con

[Qemu-devel] [PATCH v7 06/11] hw/arm_gic: Add presave/postload hooks

2013-02-26 Thread Peter Maydell
Add presave/postload hooks to the ARM GIC common base class. These will be used by the KVM in-kernel GIC subclass to sync state between kernel and userspace when migrating. Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber Reviewed-by: Paolo Bonzini --- hw/arm_gic_common.c | 10

[Qemu-devel] [PATCH v7 09/11] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC

2013-02-26 Thread Peter Maydell
Implement support for using the KVM in-kernel GIC for ARM. Signed-off-by: Peter Maydell --- hw/a15mpcore.c |8 ++- hw/arm/Makefile.objs |1 + hw/kvm/arm_gic.c | 167 ++ 3 files changed, 175 insertions(+), 1 deletion(-) create mo

Re: [Qemu-devel] [PATCH v4 2/6] add basic backup support to block driver

2013-02-26 Thread Dietmar Maurer
> I just reread the code and noticed the delay is 1 microsecond, not 1 > millisecond. Yes, It does not really add a delay. > The problem is that this is a magic value. It worked on your machine with > your > workload, but there's no guarantee it works on anyone else's machine or > workload. W

Re: [Qemu-devel] [PATCH] ICH9 LPC: Reset Control Register, basic implementation

2013-02-26 Thread Laszlo Ersek
On 02/20/13 02:51, Laszlo Ersek wrote: > This commit does the same for the ICH9 LPC as commit 1ec4ba74 for the > PIIX3. For the present we're ignoring the Full Reset (FULL_RST) and System > Reset (SYS_RST) bits; the guest can read them back but that's it. > > Signed-off-by: Laszlo Ersek > --- >

[Qemu-devel] [PATCHv2 for-1.4] e1000: unbreak the guest network migration to 1.3

2013-02-26 Thread Michael S. Tsirkin
QEMU 1.3 does not emulate the link auto negotiation, so if migrate to a 1.3 machine during link auto negotiation, the guest link will be set to down. Fix this by just disabling auto negotiation for 1.3 and older. Signed-off-by: Michael S. Tsirkin --- hw/e1000.c | 25 +

Re: [Qemu-devel] [PATCH] target-i386: Improve x86_cpu_list output

2013-02-26 Thread Igor Mammedov
On Sat, 23 Feb 2013 16:45:00 +0100 Jan Kiszka wrote: > From: Jan Kiszka > > Several issues fixed: > - We were missing a bunch of feature lists. Fix this by simply dumping >the meta list feature_word_info. > - kvm_enabled() cannot be true at this point because accelerators are >initial

Re: [Qemu-devel] [PATCH V25 1/7] Support for TPM command line options

2013-02-26 Thread Corey Bryant
I spent some time testing this patch series and just about everything is working as expected. Part of the testing included running Trousers and the Trousers testsuite and they behaved as expected. However I did find a few minor issues (and a couple of nits) so I'll expand on those inline. As

Re: [Qemu-devel] [PATCH V25 6/7] Add support for cancelling of a TPM command

2013-02-26 Thread Corey Bryant
On 02/21/2013 11:33 AM, Stefan Berger wrote: This patch adds support for cancelling an executing TPM command. In Linux for example a user can cancel a command through the TPM's sysfs 'cancel' entry using echo "1" > /sysfs/class/misc/tpm0/device/cancel This patch propagates the cancellation of

Re: [Qemu-devel] [PATCH] slirp: Properly initialize pollfds_idx of new sockets

2013-02-26 Thread Anthony Liguori
Jan Kiszka writes: > Otherwise we may start processing sockets in slirp_pollfds_poll that > were created past slirp_pollfds_fill. > > Signed-off-by: Jan Kiszka I think there's still something wrong... Somehow, my char flow series breaks slirp. Prior to the g_poll conversion, this was not the

Re: [Qemu-devel] [PATCH] ICH9 LPC: Reset Control Register, basic implementation

2013-02-26 Thread Michael S. Tsirkin
On Tue, Feb 26, 2013 at 10:53:27PM +0100, Laszlo Ersek wrote: > On 02/20/13 02:51, Laszlo Ersek wrote: > > This commit does the same for the ICH9 LPC as commit 1ec4ba74 for the > > PIIX3. For the present we're ignoring the Full Reset (FULL_RST) and System > > Reset (SYS_RST) bits; the guest can rea

[Qemu-devel] [PATCH 1/3] two new file wrappers

2013-02-26 Thread jschopp
These patches implement asn1 ber visitors for encoding and decoding data. References: <20130226230354.982917...@linux.vnet.ibm.com> Content-Disposition: inline; filename=qemu_file_bits.diff Signed-off-by: Stefan Berger Signed-off-by: Joel Schopp --- include/migration/qemu-file.h |4 qe

[Qemu-devel] [PATCH 3/3] asn1 visitor tests

2013-02-26 Thread jschopp
These patches implement asn1 ber visitors for encoding and decoding data. References: <20130226230354.982917...@linux.vnet.ibm.com> Content-Disposition: inline; filename=asn1_tests.diff Signed-off-by: Stefan Berger Signed-off-by: Joel Schopp --- tests/Makefile | 12 + tests/test-ber

Re: [Qemu-devel] Qemu doesn't start with UEFI "bios"

2013-02-26 Thread Laszlo Ersek
On 02/26/13 17:42, Georgios Tsalikis wrote: > Greeting Qemu fellows :) > > I have invoked Qemu with various parameters. For example: > $ /usr/bin/qemu-system-x86_64 -monitor stdio -enable-kvm -m 512 > -localtime -hda /home/george/Qemu\ VMs/efi-bios/efi.disk -hdb > /home/george/Qemu\ VMs/efi-bios/l

<    1   2   3   >