On 22 February 2013 03:58, Alexey Korolev wrote:
> This patch addresses the issue fully described here:
> http://lists.nongnu.org/archive/html/qemu-devel/2013-02/msg01804.html
>
> Linux kernels prior to 2.6.36 do not disable the PCI device during
> enumeration process. Since lower and higher parts
On Thu, Feb 21, 2013 at 05:29:25PM +0100, Jan Kiszka wrote:
> On 2013-02-21 16:33, Stefan Hajnoczi wrote:
> > On Thu, Feb 21, 2013 at 02:17:14PM +0100, Christian Borntraeger wrote:
> >> On 20/02/13 11:28, Stefan Hajnoczi wrote:
> >>> Amos Kong reported that file descriptors numbered
> >>> higher
On Thu, Feb 21, 2013 at 03:17:51PM +0100, Markus Armbruster wrote:
> Stefan Hajnoczi writes:
>
> > Signed-off-by: Stefan Hajnoczi
> > ---
> > qemu-options.hx | 11 ++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index 4b
Signed-off-by: Stefan Hajnoczi
---
hmp-commands.hx | 2 +-
qemu-options.hx | 11 ++-
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 64008a9..c204d31 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1169,7 +1169,7 @@ ETEXI
Il 22/02/2013 00:38, mdroth ha scritto:
> On Thu, Feb 21, 2013 at 11:12:01PM +0100, Paolo Bonzini wrote:
>> Il 21/02/2013 22:07, mdroth ha scritto:
>
> 100% agree. In particular hw/dataplane/event-poll.c should be the first
> to go away, but AioContext provides the functionality that P
On Thu, Feb 21, 2013 at 05:45:57PM +0800, Jason Wang wrote:
> @@ -1397,6 +1398,7 @@ void virtio_net_exit(VirtIODevice *vdev)
>
> g_free(n->mac_table.macs);
> g_free(n->vlans);
> +g_free(n->vqs);
>
> for (i = 0; i < n->max_queues; i++) {
> VirtIONetQueue *q = &n->vqs[
>>> On 22.02.13 at 04:23, Xudong Hao wrote:
> @@ -203,6 +251,16 @@ static int i440fx_initfn(PCIDevice *dev)
>
> d->dev.config[I440FX_SMRAM] = 0x02;
>
> +/* Emulate top of memory, here use 0xe000 as default val*/
> +if (xen_enabled()) {
> +d->dev.config[I440FX_PCI_HOLE_
On 2013-02-22 09:40, Stefan Hajnoczi wrote:
> On Thu, Feb 21, 2013 at 05:29:25PM +0100, Jan Kiszka wrote:
>> On 2013-02-21 16:33, Stefan Hajnoczi wrote:
>>> On Thu, Feb 21, 2013 at 02:17:14PM +0100, Christian Borntraeger wrote:
On 20/02/13 11:28, Stefan Hajnoczi wrote:
> Amos Kong reporte
On Thu, Feb 21, 2013 at 05:29:55PM +0100, Paolo Bonzini wrote:
> The only interesting note is the value-copy of EventNotifiers. At least
> in my opinion this is part of the EventNotifier API and is even portable
> to Windows. Of course, in this case you should not close the notifier's
> underlyin
On 2013-02-22 04:58, Alexey Korolev wrote:
> This patch addresses the issue fully described here:
> http://lists.nongnu.org/archive/html/qemu-devel/2013-02/msg01804.html
>
> Linux kernels prior to 2.6.36 do not disable the PCI device during
> enumeration process. Since lower and higher parts of a
Paolo Bonzini writes:
> Il 21/02/2013 15:41, Markus Armbruster ha scritto:
>> Trouble is the user interface is as confusing as ever. Worse, in a way,
>> because we now have to explain how "vlan" and the hubport netdev relate.
>>
>> Permit me a brief rant. Have you read the manual page on -netd
During the review of the dataplane code, the EventPoll API morphed itself
(not concidentially) into something very very similar to an AioContext.
Thus, it is trivial to convert virtio-blk-dataplane to use AioContext,
and a first baby step towards letting dataplane talk directly to the
QEMU block la
Paolo Bonzini wrote:
> Il 20/02/2013 07:32, Kazuya Saito ha scritto:
>> Signed-off-by: Kazuya Saito
>
> Unfortunately, this conflicts with my series to simplify migration.c
> (branch migration-thread-20130115 in git://github.com/bonzini/qemu.git).
>
> I'm not sure how to proceed here, because mig
Il 22/02/2013 10:50, Juan Quintela ha scritto:
> Paolo Bonzini wrote:
>> Il 20/02/2013 07:32, Kazuya Saito ha scritto:
>>> Signed-off-by: Kazuya Saito
>>
>> Unfortunately, this conflicts with my series to simplify migration.c
>> (branch migration-thread-20130115 in git://github.com/bonzini/qemu.g
Stefan Hajnoczi writes:
> On Thu, Feb 21, 2013 at 03:17:51PM +0100, Markus Armbruster wrote:
>> Stefan Hajnoczi writes:
>>
>> > Signed-off-by: Stefan Hajnoczi
>> > ---
>> > qemu-options.hx | 11 ++-
>> > 1 file changed, 10 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/qemu-optio
On 2013-02-22 10:35, Markus Armbruster wrote:
>>("-net socket" has some usecases too: "-net bridge" helps placing
>> a VM's network on a bridge, but adding a bridge still requires root
>> privileges).
>
> "-netdev socket" and "-netdev bridge" don't cut it?
Reminds me: Last time I tried -n
On Thu, Feb 21, 2013 at 03:48:57PM +, Dietmar Maurer wrote:
> > > In future, we can allow to pass multiple config files - the vma
> > > archive format can already handle that.
> >
> > My point is that QEMU has no business dealing with the management tool's VM
> > configuration file. And I thi
On Wed, Feb 20, 2013 at 11:28 AM, Stefan Hajnoczi wrote:
> Amos Kong reported that file descriptors numbered higher
> than 1024 could crash QEMU. This is due to the fixed size of the fd_set type
> used for select(2) event polling.
>
> This series converts the main-loop.c and aio-posix.c select(2
I intend to review the new QMP commands as soon as I can find the time.
Patch is ok, with this little warning when applied. Nothing really bad.
patching file qemu-options.hx
Hunk #1 succeeded at 2097 (offset 2 lines).
git head is :
http://git.qemu.org/?p=qemu.git;a=commit;h=73d4dc71f3a41131541c73b3ac2a8b160a51842b
Besides this, it builds perfectly.
Any hope to get
On Fri, Feb 22, 2013 at 12:04 AM, Anthony Liguori wrote:
>
> Since this is a pretty visible change for a lot of people, I thought I'd
> send a top level note. The GTK UI is now committed and is the default
> UI provided it's available.
>
> For anyone counting, it's been a little more than 7 years
> > The management tooI just needs to convert the config - looks quite easy to
> me.
>
> It's not an easy problem. This is why there is no central vm-images.com where
> everyone can share/sell virtual appliances. You cannot trivially convert
> between
> VMware, oVirt, proxmox, Xen, EC2, etc.
F
While we are sleeping we are not sending, so we should not use that
time to estimate our bandwidth.
Signed-off-by: Juan Quintela
Reviewed-by: Orit Wasserman
---
migration.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/migration.c b/migration.c
index b8e412f..6649e3a
We removed the calculation in commit e4ed1541ac9413eac494a03532e34beaf8a7d1c5
Now we add it back. We need to create dirty_bytes_rate because we
can't include cpu-all.h from migration.c, and there is no other way to
include TARGET_PAGE_SIZE.
Signed-off-by: Juan Quintela
Reviewed-by: Orit Wasse
> > Sure, that is no problem. But so far there is no indication that this
> > code will be added to qemu.
>
> FWIW the backup block job looks like a good feature and there's enough time to
> get it merged for QEMU 1.5.
>
> I'm not convinced by the backup writer part of this series, but don't let
Markus Armbruster writes:
> Anthony Liguori writes:
>
>> Markus Armbruster writes:
>>
>>> Eduardo Habkost writes:
>>>
This allows "," to be used a separator between each CPU range. Note
that commas inside key=value command-line options have to be escaped
using ",,", so the comm
On Thu, Feb 21, 2013 at 03:56:15PM +, Dietmar Maurer wrote:
> > On Wed, Feb 20, 2013 at 04:04:49PM +, Dietmar Maurer wrote:
> > > > The backup writer abstraction is a special case interface somewhere
> > > > between an image format and live migration. I'd prefer it if the
> > > > backup bl
On 2013-02-22 00:04, Anthony Liguori wrote:
>
> Since this is a pretty visible change for a lot of people, I thought I'd
> send a top level note. The GTK UI is now committed and is the default
> UI provided it's available.
>
> For anyone counting, it's been a little more than 7 years in the maki
Jason Wang writes:
> Cc: Markus Armbruster
> Cc: qemu-sta...@nongnu.org
> Signed-off-by: Jason Wang
> ---
> Changes from V1:
> - Add the missing docs for 'queues' (Markus)
V1 got committed already. Please respin the difference as a new patch.
On Fri, Feb 22, 2013 at 11:12:35AM +0100, Laurent Desnogues wrote:
> On Fri, Feb 22, 2013 at 12:04 AM, Anthony Liguori wrote:
> >
> > Since this is a pretty visible change for a lot of people, I thought I'd
> > send a top level note. The GTK UI is now committed and is the default
> > UI provided
Signed-off-by: Juan Quintela
---
qmp-commands.hx | 50 ++
1 file changed, 30 insertions(+), 20 deletions(-)
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 799adea..6d037bd 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -644,7 +644,7 @@
Am 22.02.2013 um 11:31 hat Stefan Hajnoczi geschrieben:
> On Thu, Feb 21, 2013 at 03:56:15PM +, Dietmar Maurer wrote:
> > > On Wed, Feb 20, 2013 at 04:04:49PM +, Dietmar Maurer wrote:
> > > > > The backup writer abstraction is a special case interface somewhere
> > > > > between an image fo
Markus Armbruster writes:
> Kevin Wolf writes:
>
>> On Mon, Feb 18, 2013 at 05:56:57PM -0600, Anthony Liguori wrote:
>>> GTK won't build with strict-prototypes due to gtkitemfactory.h:
>>>
>>> /* We use () here to mean unspecified arguments. This is deprecated
>>> * as of C99, but we c
Paolo Bonzini wrote:
> This is done by almost all callers of qemu_fflush, move the code
> directly to qemu_fflush.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Paolo Bonzini wrote:
> Including data that resided in the QEMUFile's own buffer.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Paolo Bonzini wrote:
> Always use qemu_file_get_error to detect errors, since that is how
> QEMUFile itself drops I/O after an error occurs. There is no need
> to propagate and check return values all the time.
>
> Also remove the "complete" member, since we know that it is set (via
> migrate_fd_
On Thu, Feb 21, 2013 at 06:05:44PM +0100, Paolo Bonzini wrote:
> Il 21/02/2013 17:33, Stefan Hajnoczi ha scritto:
> > This especially means things like adding live
> > migration support or solving other limitations. The limitations are
> > there to motivate core QEMU refactoring, so that core QEMU
Paolo Bonzini wrote:
> Completion of migration is currently done with a "nested" loop that
> invokes buffered_flush: migrate_fd_completed is called by
> buffered_file_thread, which calls migrate_fd_cleanup, which calls
> buffered_close (via qemu_fclose), which flushes the buffer.
>
> Simplify this
Hi
We add the calculation back. Before doing the calculation we do:
- expected_downtime intial value is max_downtime. Much, much better
intial value than 0.
- we move when we measure the time. We used to measure how much it
took "before" we really sent the data.
- we introduce sleep_time
Am 22.02.2013 um 08:51 hat Peter Lieven geschrieben:
> is there any project or plans to integrate a readcache in qemu either for
> iscsi or for the whole block layer?
>
> I was thinking of 2 options:
> a) assign (up to) a fixed amount of ram for readcaching of a VMs disk I/O.
> Without SG_IO thi
On Fri, Feb 22, 2013 at 05:48:33AM +, Dietmar Maurer wrote:
> > Not in qemu. There's a reason that we ask for clean specs, independent of
> > source code. That is the only way that we can later change the source code
> > to
> > do something more efficient or to define an extension, and still
Signed-off-by: Juan Quintela
Reviewed-by: Orit Wasserman
---
migration.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/migration.c b/migration.c
index b3f5ba4..b8e412f 100644
--- a/migration.c
+++ b/migration.c
@@ -673,7 +673,7 @@ static void *buffered_file_thread(void
Paolo Bonzini wrote:
> Perform final cleanup in a bottom half, and add joining the thread to
> the series of cleanup actions.
>
> Signed-off-by: Paolo Bonzini
> ---
> include/migration/migration.h |1 +
> migration.c | 37 +++--
> 2 files c
On Thu, Feb 21, 2013 at 05:38:04PM -0600, mdroth wrote:
> On Thu, Feb 21, 2013 at 11:12:01PM +0100, Paolo Bonzini wrote:
> > Il 21/02/2013 22:07, mdroth ha scritto:
> > >> >
> > >> > 100% agree. In particular hw/dataplane/event-poll.c should be the
> > >> > first
> > >> > to go away, but AioCont
Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
Acked-by: Juan Quintela
Paolo Bonzini wrote:
> Remove the return value of buffered_flush, pass it via the error code
> of s->file. Once this is done, the error can be retrieved simply
> via migrate_fd_close's call to qemu_fclose.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Paolo Bonzini wrote:
> Some state is shared between the block migration code and its AIO
> callbacks. Once block migration will run outside the iothread,
> the block migration code and the AIO callbacks will be able to
> run concurrently. Protect the critical sections with a separate
> lock. Do
Il 22/02/2013 11:59, Juan Quintela ha scritto:
> Paolo Bonzini wrote:
>> Some state is shared between the block migration code and its AIO
>> callbacks. Once block migration will run outside the iothread,
>> the block migration code and the AIO callbacks will be able to
>> run concurrently. Prot
Paolo Bonzini wrote:
> Right now, migration cannot entirely rely on QEMUFile's automatic
> drop of I/O after an error, because it does its "real" I/O outside
> the put_buffer callback. To fix this until buffering is gone, expose
> qemu_file_set_error which we will use in buffered_flush.
>
> Simil
Paolo Bonzini wrote:
> This groups together the callbacks that later will have similar
> locking rules.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
On Fri, Feb 22, 2013 at 08:51:48AM +0100, Peter Lieven wrote:
> is there any project or plans to integrate a readcache in qemu either for
> iscsi or for the whole block layer?
>
> I was thinking of 2 options:
> a) assign (up to) a fixed amount of ram for readcaching of a VMs disk I/O.
> Without
Am 21.02.2013 um 18:05 hat Paolo Bonzini geschrieben:
> Il 21/02/2013 17:33, Stefan Hajnoczi ha scritto:
> > * BlockDriverState <-> AioContext
> >
> >It probably makes sense to bind a BlockDriverState to an AioContext
> >in which its file descriptors and aio activity happens.
>
> ... and
VGA is a misnomer, only some of our targets have it. Use the more
generic term "display" instead.
Signed-off-by: Jan Kiszka
---
No translation updates yet as I do not know how you like to handle them.
ui/gtk.c | 45 +
1 files changed, 25 insertions
Paolo Bonzini wrote:
> This makes it possible to do blocking writes directly to the socket,
> with no buffer in the middle. For RAM, only the migration_bitmap_sync()
> call needs the iothread lock. For block migration, it is needed by
> the block layer (including bdrv_drain_all and dirty bitmap
Paolo Bonzini wrote:
> Only the migration_bitmap_sync() call needs the iothread lock.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Hi,
On 21.02.2013 15:33, Jan Kiszka wrote:
> On 2013-02-15 12:00, Vitaly Chipounov wrote:
>> A socket may still have references to it in various queues
>> at the time it is freed, causing memory corruptions.
> Did you see it in practice? Or is this patch based on code review? What
> will happen if
Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Paolo Bonzini wrote:
> Some small changes that will simplify the positioning of lock/unlock
> primitives
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Paolo Bonzini wrote:
> Buffering was needed because blocking writes could take a long time
> and starve other threads seeking to grab the big QEMU mutex.
>
> Now that all writes (except within _complete callbacks) are done
> outside the big QEMU mutex, we do not need buffering at all.
>
> Signed-o
Paolo Bonzini wrote:
> From: Juan Quintela
>
> This is consistent once that we have moved everything to migration.c
>
> Signed-off-by: Juan Quintela
Reviewed-by: Juan Quintela
Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
The gtk code uses gtk_widget_get_realized which is available in 2.20+
only, so make this the minimum accepted versions. Fixes build failures
on RHEL-6 (which ships 2.18) by not building gtk support there.
Signed-off-by: Gerd Hoffmann
---
configure |2 +-
1 file changed, 1 insertion(+), 1 de
Hi,
Two little build fixes. One in the gtk ui pull, one in the usb queue.
please pull,
Gerd
The following changes since commit 73d4dc71f3a41131541c73b3ac2a8b160a51842b:
gtk: suppress accelerators from the File menu when grab is active (2013-02-21
16:34:49 -0600)
are available in the gi
Commit 8550a02d1239415342959f6a32d178bc05c557cc added a streams
parameter to usb_wakeup and didn't update redirect.c. Fix it.
Signed-off-by: Gerd Hoffmann
---
hw/usb/redirect.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
index 707
Opening several NBD sockets 'nbd:127.0.0.1:1235' seems dangerous to me. One
backup task
and easily write to the wrong port - there is no protection? Or how can we
guarantee that
only one kvm process can write to that NBD device?
> transaction actions=[{'type': 'migrate-async',
>
0 is a very bad initial value, what we are trying to get is
max_downtime, so that is a much better estimation.
Signed-off-by: Juan Quintela
Reviewed-by: Orit Wasserman
---
migration.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration.c b/migration.c
index b1ebb01..b3f5ba4 100644
Paolo Bonzini wrote:
> We will go around the loop exactly once after setting last_round.
> Eliminate the variable altogether.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Paolo Bonzini wrote:
> migration_put_buffer is never called if there has been an error.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
On 2013-02-22 10:57, Vitaly Chipounov wrote:
> Hi,
>
> On 21.02.2013 15:33, Jan Kiszka wrote:
>> On 2013-02-15 12:00, Vitaly Chipounov wrote:
>>> A socket may still have references to it in various queues
>>> at the time it is freed, causing memory corruptions.
>> Did you see it in practice? Or is
On Fri, Feb 22, 2013 at 12:11:58PM +0100, Gerd Hoffmann wrote:
> The gtk code uses gtk_widget_get_realized which is available in 2.20+
> only, so make this the minimum accepted versions. Fixes build failures
> on RHEL-6 (which ships 2.18) by not building gtk support there.
IMHO it'd be nicer to a
Il 22/02/2013 12:11, Gerd Hoffmann ha scritto:
> The gtk code uses gtk_widget_get_realized which is available in 2.20+
> only, so make this the minimum accepted versions. Fixes build failures
> on RHEL-6 (which ships 2.18) by not building gtk support there.
We should either require GTK+ 3, or jus
Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Paolo Bonzini wrote:
> There is no reason for outgoing exec migration to do popen manually
> anymore (the reason used to be that we needed the FILE* to make it
> non-blocking). Use qemu_popen_cmd.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Paolo Bonzini wrote:
> This is what fd_close does. Prepare for switching to a QEMUFile.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Paolo Bonzini wrote:
> This is what exec_close does. Move this to the underlying QEMUFile.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
> > For now I have no plans to backup such large VMs.
>
> 640k ought to be enough for anybody?
>
> Code is easy enough to change that "works for now" can be good enough.
> Changing file formats and external interfaces is hard, though, so better get
> it
> right the first time. I don't want to ge
Paolo Bonzini wrote:
> Force a flush when qemu_ftell is called. This simplifies the buffer magic
> (it also breaks qemu_ftell for input QEMUFiles, but we never use it).
>
> Signed-off-by: Paolo Bonzini
Acked-by: Juan Quintela
Il 22/02/2013 12:13, Dietmar Maurer ha scritto:
> Opening several NBD sockets 'nbd:127.0.0.1:1235' seems dangerous to me. One
> backup task
> and easily write to the wrong port - there is no protection?
You can also use the named-export support. Something like
--nbd=127.0.0.1:1235
--block
On 02/21/13 22:58, Hervé Poussineau wrote:
> This fixes the following compilation error:
> hw/usb/hcd-xhci.c:1156:17: error: format ‘%llx’ expects argument of type
> ‘long long unsigned int’, but argument 4 has type ‘unsigned int’
>
> Signed-off-by: Hervé Poussineau
Acked-by: Gerd Hoffmann
che
Paolo Bonzini wrote:
> As a start, use QEMUFile to store the destination and close it.
> qemu_get_fd gets a file descriptor that will be used by the write
> callbacks.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Paolo Bonzini wrote:
> Second, drop the file descriptor indirection, and write directly to the
> QEMUFile.
>
> Signed-off-by: Paolo Bonzini
> +qemu_put_buffer(s->migration_file, buf, size);
> +if (qemu_file_get_error(s->migration_file)) {
> +return qemu_file_get_error(s->migratio
Il 22/02/2013 11:43, Stefan Hajnoczi ha scritto:
>> >
>> > It can and should stay. :) BHs are tied to an AioContext. Running
>> > thread-creation BHs from the AioContext's main thread ensures that the
>> > worker threads inherit the right attributes for e.g. real-time.
> When I say "this can sta
Paolo Bonzini wrote:
> Prepare for when s->bytes_xfer will be removed.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Paolo Bonzini wrote:
> This patch extracts a few small changes from the next patch, which
> are unrelated to adding generic rate-limiting functionality to
> QEMUFile. Make migration_set_rate_limit a simple accessor, and
> use qemu_file_set_rate_limit consistently. Also fix a typo where
> INT_MAX
Il 22/02/2013 12:06, Kevin Wolf ha scritto:
> or example think of
> the read-only qcow2 snapshot BDS that we've been talking about before.
>
> So it would have to be more like one AioContext per connected component
> in the BDS graph
Yes. For now it means one AioContext per top-level BDS, but th
Paolo Bonzini wrote:
> Rate limiting is now simply a byte counter; client call
> qemu_file_rate_limit() manually to determine if they have to exit.
> So it is possible and simple to move the functionality to QEMUFile.
>
> This makes the remaining functionality of s->file redundant;
> in the next p
Paolo Bonzini wrote:
> With this patch, the migration_file is not needed anymore.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Paolo Bonzini wrote:
> The indirection is useless now. Backends can open s->file directly.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Il 22/02/2013 11:07, Laurent Desnogues ha scritto:
>> The g_poll(3) interface is a portable version of the poll(2) system call.
>> The
>> > difference to select(2) is that fine-grained events (G_IO_IN, G_IO_OUT,
>> > G_IO_HUP, G_IO_ERR, G_IO_PRI) can be monitored instead of just
>> > read/write/e
> You can also use the named-export support. Something like
>
>--nbd=127.0.0.1:1235
>--blockdev=virtio-drive0 --blockdev=virtio-drive1 --blockdev=ide0-hd0
>
> etc.
>
> Then QEMU can migrate to nbd://127.0.0.1:1235/virtio-drive0.
>
> > Or how can we guarantee that only one kvm process c
Il 22/02/2013 10:35, Markus Armbruster ha scritto:
> Paolo Bonzini writes:
>
>> Il 21/02/2013 15:41, Markus Armbruster ha scritto:
>>> Trouble is the user interface is as confusing as ever. Worse, in a way,
>>> because we now have to explain how "vlan" and the hubport netdev relate.
>>>
>>> Perm
Juan Quintela wrote:
> Paolo Bonzini wrote:
>> Second, drop the file descriptor indirection, and write directly to the
>> QEMUFile.
>>
>> Signed-off-by: Paolo Bonzini
>
>> +qemu_put_buffer(s->migration_file, buf, size);
>> +if (qemu_file_get_error(s->migration_file)) {
>> +return
Il 22/02/2013 12:51, Dietmar Maurer ha scritto:
>> You can also use the named-export support. Something like
>> >
>> >--nbd=127.0.0.1:1235
>> >--blockdev=virtio-drive0 --blockdev=virtio-drive1 --blockdev=ide0-hd0
>> >
>> > etc.
>> >
>> > Then QEMU can migrate to nbd://127.0.0.1:1235/vir
Il 22/02/2013 12:06, Stefan Hajnoczi ha scritto:
> On Fri, Feb 22, 2013 at 08:51:48AM +0100, Peter Lieven wrote:
>> is there any project or plans to integrate a readcache in qemu either for
>> iscsi or for the whole block layer?
>>
>> I was thinking of 2 options:
>> a) assign (up to) a fixed amoun
Am 22.02.2013 um 12:21 hat Dietmar Maurer geschrieben:
> > > For now I have no plans to backup such large VMs.
> >
> > 640k ought to be enough for anybody?
> >
> > Code is easy enough to change that "works for now" can be good enough.
> > Changing file formats and external interfaces is hard, tho
On 02/15/2013 07:47 PM, Paolo Bonzini wrote:
> This patch extracts a few small changes from the next patch, which
> are unrelated to adding generic rate-limiting functionality to
> QEMUFile. Make migration_set_rate_limit a simple accessor, and
> use qemu_file_set_rate_limit consistently. Also fix
Here's the next version of ioeventfd support for virtio-ccw, again
against master.
v1 -> v2:
- Adapt to changed ioeventfd interface.
Cornelia Huck (2):
linux-headers: Update with ioeventfd changes.
virtio-ccw: Wire up ioeventfd.
hw/s390x/css.c| 2 +-
hw/s390x/css.h
1 - 100 of 419 matches
Mail list logo
