[Qemu-devel] kvm segfaulting

2013-02-11 Thread Stefan Priebe - Profihost AG
Hello list, i've seen segfaults of the kvm process. Sadly i've no core dumps just the line from dmesg: kvm[26268]: segfault at c050 ip 7fcfc3465eac sp 7fffe85a0d00 error 4 in kvm[7fcfc3223000+3ba000] Is it possible to get the function and some more details out of this line? I've symbol fi

Re: [Qemu-devel] [RFC V6 00/33] QCOW2 deduplication core functionality

2013-02-11 Thread Stefan Hajnoczi
On Mon, Feb 11, 2013 at 03:50:10AM +0100, Benoît Canet wrote: > As you can read dedup keep me awake at night. > > I still think that there is a need for a deduplication implementation > that would perform nearly as fast as regular qcow2. > > I though about this: http://en.wikipedia.org/wiki/Norma

Re: [Qemu-devel] kvm segfaulting

2013-02-11 Thread Paolo Bonzini
Il 11/02/2013 08:46, Stefan Priebe - Profihost AG ha scritto: > i've seen segfaults of the kvm process. Sadly i've no core dumps just > the line from dmesg: > kvm[26268]: segfault at c050 ip 7fcfc3465eac sp 7fffe85a0d00 > error 4 in kvm[7fcfc3223000+3ba000] > > Is it possible to get the fu

Re: [Qemu-devel] kvm segfaulting

2013-02-11 Thread Michael Tokarev
11.02.2013 11:46, Stefan Priebe - Profihost AG пишет: Hello list, i've seen segfaults of the kvm process. Sadly i've no core dumps just the line from dmesg: kvm[26268]: segfault at c050 ip 7fcfc3465eac sp 7fffe85a0d00 error 4 in kvm[7fcfc3223000+3ba000] Is it possible to get the functio

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-11 Thread Stefan Hajnoczi
On Fri, Feb 08, 2013 at 07:14:33AM -0500, Jeff Cody wrote: > On Fri, Feb 08, 2013 at 09:38:47AM +0100, Kevin Wolf wrote: > > Am 07.02.2013 20:26, schrieb Stefan Weil: > > > From: Stefan Weil > > > > > > The size calculated from the CHS values is not the real image (disk) size, > > > but usually a

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-11 Thread Kevin Wolf
Am 08.02.2013 18:43, schrieb Stefan Weil: > Am 08.02.2013 13:14, schrieb Jeff Cody: >> On Fri, Feb 08, 2013 at 09:38:47AM +0100, Kevin Wolf wrote: >>> Am 07.02.2013 20:26, schrieb Stefan Weil: From: Stefan Weil The size calculated from the CHS values is not the real image (disk) siz

Re: [Qemu-devel] [PATCH 2/4] qemu-img: Add "Quiet mode" option

2013-02-11 Thread Stefan Hajnoczi
On Fri, Feb 08, 2013 at 09:33:43AM +0100, Miroslav Rezanina wrote: > @@ -86,6 +87,7 @@ static void help(void) > " rebasing in this case (useful for renaming the backing > file)\n" > " '-h' with or without a command shows this help and lists the > supported formats\n

Re: [Qemu-devel] [Bug 1119281] [NEW] The virtio network device breaks UuidCreateSequential()

2013-02-11 Thread Stefan Hajnoczi
On Fri, Feb 08, 2013 at 10:45:03AM -, Francois Gouget wrote: > Public bug reported: > > UuidCreateSequential() usually creates version 1 UUIDs (1) which means > they contain the main network card's MAC address. However when using a > virtio network card and driver the UUIDs contain random data

Re: [Qemu-devel] request for mediawiki account / RDMA documentation

2013-02-11 Thread Stefan Hajnoczi
On Fri, Feb 08, 2013 at 11:27:20AM -0500, Michael R. Hines wrote: > According to the website, I should ask here for someone to make a > wiki account for me? > > I would like to post documentation of the RDMA patches I'm preparing. Your account has been created, please see the off-list email. The

[Qemu-devel] [PATCH for-1.5 0/8] virtio-blk refactoring.

2013-02-11 Thread fred . konrad
From: KONRAD Frederic This is the next part of virtio-refactoring. I send it now to have it reviewed. Basically it creates virtio-blk device which extends virtio-device. Then a virtio-blk can be connected on a virtio-bus. virtio-blk-pci, virtio-blk-s390x, virtio-blk-ccw are created too, they ex

[Qemu-devel] [PATCH for-1.5 1/8] virtio-blk: don't use pointer for configuration.

2013-02-11 Thread fred . konrad
From: KONRAD Frederic The configuration field must not be a pointer as it will be used for virtio-blk properties. So *blk is replaced by blk in VirtIOBlock structure. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 8 hw/virtio-blk.h | 2 +- 2 files changed, 5 insertions(+), 5 de

[Qemu-devel] [PATCH for-1.5 6/8] virtio-blk: cleanup: init and exit functions.

2013-02-11 Thread fred . konrad
From: KONRAD Frederic As all virtio-blk-* are switched to the new API, we can remove the separate init/exit for the old API. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 84 +++-- hw/virtio.h | 2 -- 2 files changed, 21 insertion

Re: [Qemu-devel] [PATCH for 1.5] virtio: make virtio device's structures public.

2013-02-11 Thread KONRAD Frédéric
oops, sorry for that, it was not supposed to be resent. :-s Fred. On 11/02/2013 10:37, fred.kon...@greensocs.com wrote: From: KONRAD Frederic These structures must be made public to avoid two memory allocations for refactored virtio devices. Signed-off-by: KONRAD Frederic --- hw/virtio-ba

Re: [Qemu-devel] kvm segfaulting

2013-02-11 Thread Stefan Hajnoczi
On Mon, Feb 11, 2013 at 08:46:03AM +0100, Stefan Priebe - Profihost AG wrote: > i've seen segfaults of the kvm process. Sadly i've no core dumps just > the line from dmesg: > kvm[26268]: segfault at c050 ip 7fcfc3465eac sp 7fffe85a0d00 > error 4 in kvm[7fcfc3223000+3ba000] > > Is it possib

Re: [Qemu-devel] kvm segfaulting

2013-02-11 Thread Stefan Priebe - Profihost AG
Hi Stefan, Am 11.02.2013 10:40, schrieb Stefan Hajnoczi: > On Mon, Feb 11, 2013 at 08:46:03AM +0100, Stefan Priebe - Profihost AG wrote: >> i've seen segfaults of the kvm process. Sadly i've no core dumps just >> the line from dmesg: >> kvm[26268]: segfault at c050 ip 7fcfc3465eac sp 7fffe8

[Qemu-devel] [PATCH for-1.5 8/8] virtio-blk: cleanup: remove qdev field.

2013-02-11 Thread fred . konrad
From: KONRAD Frederic The qdev field is no longer needed, just drop it. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 3 +-- hw/virtio-blk.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index c85b4d7..e02842d 100644 --- a/hw/virt

Re: [Qemu-devel] kvm segfaulting

2013-02-11 Thread Stefan Priebe - Profihost AG
So it looks a bit like a race condition in the virtio-scsi driver. Command got canceled and the completed or something like this. Stefan Am 11.02.2013 10:40, schrieb Stefan Hajnoczi: > On Mon, Feb 11, 2013 at 08:46:03AM +0100, Stefan Priebe - Profihost AG wrote: >> i've seen segfaults of the kvm

Re: [Qemu-devel] [PATCH 00/10] Support mips64/mipsn32-linux-user

2013-02-11 Thread Peter Maydell
On 10 February 2013 18:30, Richard Henderson wrote: > Peter's recent userland syscall testing has encouraged me to clean > up and re-submit some ages-old patches to enable userland testing > of the other mips abis. > > Please review. Eight patches out of ten have no commit message beyond the one-

[Qemu-devel] [PATCH for-1.5 3/8] virtio-blk-pci: switch to new API.

2013-02-11 Thread fred . konrad
From: KONRAD Frederic Here the virtio-blk-pci is modified for the new API. The device virtio-blk-pci extends virtio-pci. It creates and connects a virtio-blk during the init. The properties are not changed. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 115 ++

[Qemu-devel] [PATCH for-1.5 7/8] virtio-blk: cleanup: QOM cast

2013-02-11 Thread fred . konrad
From: KONRAD Frederic Use QOM casts inside virtio-blk. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 33 ++--- hw/virtio-blk.h | 2 +- 2 files changed, 15 insertions(+), 20 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 2f4cf19..c85b4d7 1

Re: [Qemu-devel] [PATCH for-1.4 stable] block: handle spurious coroutine entries

2013-02-11 Thread Paolo Bonzini
Il 09/02/2013 17:44, Stefan Hajnoczi ha scritto: > bdrv_co_io_em(), bdrv_co_flush(), and bdrv_co_discard() yield the > coroutine when waiting for aio to complete. They do not check that the > request has actually finished. > > In simple cases this works, but it returns early when we get spurious

Re: [Qemu-devel] [PATCH for-1.4 stable 1/3] block-migration: improve "Unknown flags" error message

2013-02-11 Thread Paolo Bonzini
Il 09/02/2013 19:01, Stefan Hajnoczi ha scritto: > Show the actual flags value and include "block migration" in the error > message so it's clear where the error is coming from. > > Signed-off-by: Stefan Hajnoczi > --- > block-migration.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Qemu-devel] [PATCH for-1.4 stable 2/3] block-migration: fix blk_mig_save_dirty_block() return value checking

2013-02-11 Thread Paolo Bonzini
Il 09/02/2013 19:01, Stefan Hajnoczi ha scritto: > Commit 43be3a25c931a7f61a76fbfc9d35584cbfc5fb58 changed the > blk_mig_save_dirty_block() return code handling. The function's doc > comment says: > > /* return value: >* 0: too much data for max_downtime >* 1: few enough data for max_do

Re: [Qemu-devel] [PATCH for-1.4 stable v2 3/3] block-migration: fix block_save_iterate() return value

2013-02-11 Thread Paolo Bonzini
Il 10/02/2013 23:12, Stefan Hajnoczi ha scritto: > The .save_live_iterate() function returns 0 to continue iterating or 1 > to stop iterating. > > Since 16310a3cca7320edb9341c976f7819de0a8c27e0 it only ever returns 0, > leading to an infinite loop. > > Return 1 if we have finished sending dirty b

[Qemu-devel] [PATCH for-1.5 5/8] virtio-blk-ccw switch to new API.

2013-02-11 Thread fred . konrad
From: KONRAD Frederic Signed-off-by: KONRAD Frederic --- hw/s390x/virtio-ccw.c | 38 -- hw/s390x/virtio-ccw.h | 14 +- 2 files changed, 37 insertions(+), 15 deletions(-) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index d92e427..27

Re: [Qemu-devel] [PATCH V4 RESEND 15/22] tap: multiqueue support

2013-02-11 Thread Markus Armbruster
Commit 264986e2 extended NetdevTapOptions without updating the documentation. Hasn't been addressed since. Must fix for 1.4, in my opinion. This is the offending patch: Jason Wang writes: > Recently, linux support multiqueue tap which could let userspace call > TUNSETIFF > for a signle devic

[Qemu-devel] [PATCH for 1.5] virtio: make virtio device's structures public.

2013-02-11 Thread fred . konrad
From: KONRAD Frederic These structures must be made public to avoid two memory allocations for refactored virtio devices. Signed-off-by: KONRAD Frederic --- hw/virtio-balloon.c| 15 --- hw/virtio-balloon.h| 14 ++ hw/virtio-blk.c| 16 hw

[Qemu-devel] [PATCH for-1.5 4/8] virtio-blk-s390: switch to the new API.

2013-02-11 Thread fred . konrad
From: KONRAD Frederic Here the virtio-blk-s390 is modified for the new API. The device virtio-blk-s390 extends virtio-s390-device as before. It creates and connects a virtio-blk during the init. The properties are not modified. Signed-off-by: KONRAD Frederic --- hw/s390x/s390-virtio-bus.c | 30

[Qemu-devel] [PATCH for-1.5 2/8] virtio-blk: add the virtio-blk device.

2013-02-11 Thread fred . konrad
From: KONRAD Frederic Create virtio-blk which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 97 ++--- hw/virtio-blk.h | 28 + hw/virtio-pci.c | 11 +-- 3

[Qemu-devel] [PATCH] Add Makefile rules to build pxe rom binaries (with/without EFI support)

2013-02-11 Thread Gerd Hoffmann
This patch adds two new targets to roms/Makefile. "make -C roms ipxerom" will build the ipxe roms and update the binaries in pc-bios/, i.e. it basically documents how the build process of our current pxe roms works. "make -C rpms epxerom" will build rom binaries with EFI support. They are compose

Re: [Qemu-devel] Question about default floppy and stdvga memory

2013-02-11 Thread Fabio Fantoni
Il 04/02/2013 10:41, Fabio Fantoni ha scritto: I tried to disable "default floppy" without use -nodefaults option that disable other things. I didn't found other parameters to do that in docs and code for now. Can someone tell me if there is another way to disable default floppy only? About s

Re: [Qemu-devel] [PATCH for-1.4 stable] block: handle spurious coroutine entries

2013-02-11 Thread Stefan Hajnoczi
On Mon, Feb 11, 2013 at 11:16:09AM +0100, Paolo Bonzini wrote: > Il 09/02/2013 17:44, Stefan Hajnoczi ha scritto: > > bdrv_co_io_em(), bdrv_co_flush(), and bdrv_co_discard() yield the > > coroutine when waiting for aio to complete. They do not check that the > > request has actually finished. > >

Re: [Qemu-devel] [PATCH for-1.4 stable] block: handle spurious coroutine entries

2013-02-11 Thread Paolo Bonzini
Il 11/02/2013 11:57, Stefan Hajnoczi ha scritto: >> > I would prefer to have ret initialized to -EINPROGRESS, but since we're >> > close to release it's easier this way. > I did it that way first but then I felt a little paranoid about using > the return value space as the sentinel. Granted, most

Re: [Qemu-devel] [PATCH for-1.5 0/8] virtio-blk refactoring.

2013-02-11 Thread Cornelia Huck
On Mon, 11 Feb 2013 10:37:20 +0100 fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > This is the next part of virtio-refactoring. > > I send it now to have it reviewed. > > Basically it creates virtio-blk device which extends virtio-device. > Then a virtio-blk can be connected on a

Re: [Qemu-devel] [PATCH for-1.4 stable] block: handle spurious coroutine entries

2013-02-11 Thread Kevin Wolf
Am 09.02.2013 17:44, schrieb Stefan Hajnoczi: > bdrv_co_io_em(), bdrv_co_flush(), and bdrv_co_discard() yield the > coroutine when waiting for aio to complete. They do not check that the > request has actually finished. > > In simple cases this works, but it returns early when we get spurious > w

Re: [Qemu-devel] [PATCH for-1.4 stable] block: handle spurious coroutine entries

2013-02-11 Thread Paolo Bonzini
Il 11/02/2013 13:29, Kevin Wolf ha scritto: > The bug is not in this function but in process_incoming_migration(). It > should never blindly enter a coroutine which is in an unknown state. process_incoming_migration() is the function that _creates_ the coroutine and enters it for the first time, s

Re: [Qemu-devel] kvm segfaulting

2013-02-11 Thread Paolo Bonzini
Il 11/02/2013 10:48, Stefan Priebe - Profihost AG ha scritto: > Great thing! This is current git master. > > [: ~]# addr2line -e /usr/lib/debug/usr/bin/kvm -f 242eac > > virtio_scsi_command_complete > /opt/debianpackages/pve-squeeze.sources/pve-qemu-kvm/qemu-kvm/hw/virtio-scsi.c:429 > > static v

Re: [Qemu-devel] [PATCH for-1.4 stable 2/3] block-migration: fix blk_mig_save_dirty_block() return value checking

2013-02-11 Thread Juan Quintela
Stefan Hajnoczi wrote: > Commit 43be3a25c931a7f61a76fbfc9d35584cbfc5fb58 changed the > blk_mig_save_dirty_block() return code handling. The function's doc > comment says: > > /* return value: >* 0: too much data for max_downtime >* 1: few enough data for max_downtime >*/ > > Because

Re: [Qemu-devel] [PATCH for-1.4 stable 3/3] block-migration: fix block_save_iterate() return value

2013-02-11 Thread Juan Quintela
Stefan Hajnoczi wrote: > The .save_live_iterate() function returns 0 it continue iterating or 1 > to stop iterating. > > Since 16310a3cca7320edb9341c976f7819de0a8c27e0 it only ever returns 0, > leading to an infinite loop. > > Return 1 if we have finished sending dirty blocks. > > Signed-off-by: S

Re: [Qemu-devel] [PATCH for-1.5 0/8] virtio-blk refactoring.

2013-02-11 Thread KONRAD Frédéric
On 11/02/2013 12:58, Cornelia Huck wrote: On Mon, 11 Feb 2013 10:37:20 +0100 fred.kon...@greensocs.com wrote: From: KONRAD Frederic This is the next part of virtio-refactoring. I send it now to have it reviewed. Basically it creates virtio-blk device which extends virtio-device. Then a virt

Re: [Qemu-devel] kvm segfaulting

2013-02-11 Thread Stefan Priebe - Profihost AG
Hi, Am 11.02.2013 13:48, schrieb Paolo Bonzini: > Il 11/02/2013 10:48, Stefan Priebe - Profihost AG ha scritto: >> req->resp.cmd->status = status; >> if (req->resp.cmd->status == GOOD) { >> req->resp.cmd->resid = tswap32(resid); >> } else { >> req->resp.cmd->resid = 0; >

Re: [Qemu-devel] [PATCH] Remove forward declaration of non-existant variable

2013-02-11 Thread Stefan Hajnoczi
On Sun, Feb 10, 2013 at 11:11:05PM +0100, Hervé Poussineau wrote: > This variable has been removed 5 years ago in > 970ac5a3082428dca91171f270dcd95d6f4b2636. > > Signed-off-by: Hervé Poussineau > --- > include/sysemu/sysemu.h |1 - > 1 file changed, 1 deletion(-) Thanks, applied to the tri

Re: [Qemu-devel] [PATCH for-1.4 stable] block: handle spurious coroutine entries

2013-02-11 Thread Stefan Hajnoczi
On Mon, Feb 11, 2013 at 1:42 PM, Paolo Bonzini wrote: > Il 11/02/2013 13:29, Kevin Wolf ha scritto: >> The bug is not in this function but in process_incoming_migration(). It >> should never blindly enter a coroutine which is in an unknown state. > > process_incoming_migration() is the function th

Re: [Qemu-devel] kvm segfaulting

2013-02-11 Thread Stefan Hajnoczi
On Mon, Feb 11, 2013 at 2:08 PM, Stefan Priebe - Profihost AG wrote: > Hi, > Am 11.02.2013 13:48, schrieb Paolo Bonzini: >> Il 11/02/2013 10:48, Stefan Priebe - Profihost AG ha scritto: >>> req->resp.cmd->status = status; >>> if (req->resp.cmd->status == GOOD) { >>> req->resp.cmd->

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Stefan Hajnoczi
On Sun, Feb 10, 2013 at 11:12:11PM +0100, Hervé Poussineau wrote: > > Signed-off-by: Hervé Poussineau > --- > hw/ide/core.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/ide/core.c b/hw/ide/core.c > index 3743dc3..f0ab1a8 100644 > --- a/hw/ide/core.c > +++ b/

Re: [Qemu-devel] [PATCH for-1.4 stable] block: handle spurious coroutine entries

2013-02-11 Thread Kevin Wolf
Am 11.02.2013 14:17, schrieb Stefan Hajnoczi: > On Mon, Feb 11, 2013 at 1:42 PM, Paolo Bonzini wrote: >> Il 11/02/2013 13:29, Kevin Wolf ha scritto: >>> The bug is not in this function but in process_incoming_migration(). It >>> should never blindly enter a coroutine which is in an unknown state.

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Kevin Wolf
Am 11.02.2013 14:27, schrieb Stefan Hajnoczi: > On Sun, Feb 10, 2013 at 11:12:11PM +0100, Hervé Poussineau wrote: >> >> Signed-off-by: Hervé Poussineau >> --- >> hw/ide/core.c |4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/hw/ide/core.c b/hw/ide/core.c >> index

Re: [Qemu-devel] kvm segfaulting

2013-02-11 Thread Stefan Priebe - Profihost AG
Hi Stefan, yes i use virtio-scsi-pci in all my guests. As it is the only one where i can use fstrim from guest to storage with rbd ;-) Stefan Am 11.02.2013 14:21, schrieb Stefan Hajnoczi: > On Mon, Feb 11, 2013 at 2:08 PM, Stefan Priebe - Profihost AG > wrote: >> Hi, >> Am 11.02.2013 13:48, schr

Re: [Qemu-devel] [PATCH for-1.4 stable 1/3] block-migration: improve "Unknown flags" error message

2013-02-11 Thread Juan Quintela
Stefan Hajnoczi wrote: > Show the actual flags value and include "block migration" in the error > message so it's clear where the error is coming from. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH for-1.4 stable] block: handle spurious coroutine entries

2013-02-11 Thread Kevin Wolf
Am 11.02.2013 13:42, schrieb Paolo Bonzini: > Il 11/02/2013 13:29, Kevin Wolf ha scritto: >> The bug is not in this function but in process_incoming_migration(). It >> should never blindly enter a coroutine which is in an unknown state. > > process_incoming_migration() is the function that _create

Re: [Qemu-devel] [PATCH for-1.4 stable] block: handle spurious coroutine entries

2013-02-11 Thread Paolo Bonzini
Il 11/02/2013 14:29, Kevin Wolf ha scritto: > Am 11.02.2013 14:17, schrieb Stefan Hajnoczi: >> On Mon, Feb 11, 2013 at 1:42 PM, Paolo Bonzini wrote: >>> Il 11/02/2013 13:29, Kevin Wolf ha scritto: The bug is not in this function but in process_incoming_migration(). It should never blindl

Re: [Qemu-devel] kvm segfaulting

2013-02-11 Thread Paolo Bonzini
Il 11/02/2013 14:35, Stefan Priebe - Profihost AG ha scritto: > Hi Stefan, > > yes i use virtio-scsi-pci in all my guests. As it is the only one where > i can use fstrim from guest to storage with rbd ;-) Can you check for anything suspicious in the kernel console output? Paolo > Stefan > Am 11

Re: [Qemu-devel] kvm segfaulting

2013-02-11 Thread Stefan Priebe - Profihost AG
Hi Paolo, as the guest crashes i can't check the guest. On the host i just have the segmentation fault line. Anything else is from the bootprocess or enabling the tap device. So nothing suspicious. Greets, Stefan Am 11.02.2013 14:56, schrieb Paolo Bonzini: > Il 11/02/2013 14:35, Stefan Priebe -

Re: [Qemu-devel] kvm segfaulting

2013-02-11 Thread Paolo Bonzini
Il 11/02/2013 14:58, Stefan Priebe - Profihost AG ha scritto: > Hi Paolo, > > as the guest crashes i can't check the guest. On the host i just have > the segmentation fault line. Anything else is from the bootprocess or > enabling the tap device. So nothing suspicious. What about log from the ser

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Markus Armbruster
Kevin Wolf writes: > Am 11.02.2013 14:27, schrieb Stefan Hajnoczi: >> On Sun, Feb 10, 2013 at 11:12:11PM +0100, Hervé Poussineau wrote: >>> >>> Signed-off-by: Hervé Poussineau >>> --- >>> hw/ide/core.c |4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/hw/ide/c

Re: [Qemu-devel] kvm segfaulting

2013-02-11 Thread Stefan Priebe - Profihost AG
Hi, nothing. What are you searching for? Stefan Am 11.02.2013 14:59, schrieb Paolo Bonzini: > Il 11/02/2013 14:58, Stefan Priebe - Profihost AG ha scritto: >> Hi Paolo, >> >> as the guest crashes i can't check the guest. On the host i just have >> the segmentation fault line. Anything else is fro

Re: [Qemu-devel] kvm segfaulting

2013-02-11 Thread Paolo Bonzini
Il 11/02/2013 15:02, Stefan Priebe - Profihost AG ha scritto: > Hi, > > nothing. What are you searching for? Some trace that a request was actually cancelled, but I think I believe that. This seems to be the same issue as commits 1bd075f29ea6d11853475c7c42734595720c3ac6 (iSCSI) and 473c7f0255920

Re: [Qemu-devel] [PATCH] Add Makefile rules to build pxe rom binaries (with/without EFI support)

2013-02-11 Thread Andreas Färber
Am 11.02.2013 11:36, schrieb Gerd Hoffmann: > This patch adds two new targets to roms/Makefile. > > "make -C roms ipxerom" will build the ipxe roms and update > the binaries in pc-bios/, i.e. it basically documents how > the build process of our current pxe roms works. > > "make -C rpms epxerom"

Re: [Qemu-devel] kvm segfaulting

2013-02-11 Thread Stefan Priebe - Profihost AG
Hi, > Some trace that a request was actually cancelled, but I think I > believe Ah but that must be in guest not on host right? How to grab that from client when it is crashing? > that. This seems to be the same issue as commits > 1bd075f29ea6d11853475c7c42734595720c3ac6 (iSCSI) and > 473c7f0255

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Andreas Färber
Am 11.02.2013 15:01, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 11.02.2013 14:27, schrieb Stefan Hajnoczi: >>> On Sun, Feb 10, 2013 at 11:12:11PM +0100, Hervé Poussineau wrote: Signed-off-by: Hervé Poussineau --- hw/ide/core.c |4 +++- 1 file changed, 3

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Peter Maydell
On 11 February 2013 14:19, Andreas Färber wrote: > Am 11.02.2013 15:01, schrieb Markus Armbruster: >> Kevin Wolf writes: >> >>> Am 11.02.2013 14:27, schrieb Stefan Hajnoczi: I think we need to side-track this patch email to figure out what to use: fprintf(stderr) - some warnin

Re: [Qemu-devel] [PATCH 06/10] qdev: Implement (variable length) array properties

2013-02-11 Thread Peter Maydell
On 4 February 2013 13:44, Peter Maydell wrote: > Add support for declaring array properties for qdev devices. > These work by defining an initial static property 'len-arrayname' > which the user of the device should set to the desired size > of the array. When this property is set, memory is alloc

Re: [Qemu-devel] kvm segfaulting

2013-02-11 Thread Paolo Bonzini
Il 11/02/2013 15:18, Stefan Priebe - Profihost AG ha scritto: >> > Some trace that a request was actually cancelled, but I think I >> > believe > Ah but that must be in guest not on host right? How to grab that from > client when it is crashing? Serial console could have something like "sda: abort

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Stefan Hajnoczi
On Mon, Feb 11, 2013 at 3:34 PM, Peter Maydell wrote: > On 11 February 2013 14:19, Andreas Färber wrote: >> Am 11.02.2013 15:01, schrieb Markus Armbruster: >>> Kevin Wolf writes: >>> Am 11.02.2013 14:27, schrieb Stefan Hajnoczi: > I think we need to side-track this patch email to figure

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Peter Maydell
On 11 February 2013 14:57, Stefan Hajnoczi wrote: > On Mon, Feb 11, 2013 at 3:34 PM, Peter Maydell > wrote: >> On 11 February 2013 14:19, Andreas Färber wrote: >>> Blue already did some work to make it more usable, and I believe Peter >>> adopted LOG_UNIMPL for ARM devices in place of hw_error(

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Peter Maydell
On 10 February 2013 22:12, Hervé Poussineau wrote: > --- a/hw/ide/core.c > +++ b/hw/ide/core.c > @@ -1394,8 +1394,10 @@ void ide_exec_cmd(IDEBus *bus, uint32_t val) > break; > case WIN_PACKETCMD: > /* overlapping commands not supported */ > -if (s->feature & 0x02) >

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Andreas Färber
Am 11.02.2013 15:57, schrieb Stefan Hajnoczi: > On Mon, Feb 11, 2013 at 3:34 PM, Peter Maydell > wrote: >> On 11 February 2013 14:19, Andreas Färber wrote: >>> Am 11.02.2013 15:01, schrieb Markus Armbruster: Kevin Wolf writes: > Am 11.02.2013 14:27, schrieb Stefan Hajnoczi: >>

Re: [Qemu-devel] [PATCH 4/7 v2] KVM regsync: Add register bitmap parameter to do_kvm_cpu_synchronize_state

2013-02-11 Thread Jason J. Herne
On 02/01/2013 10:47 AM, Jason J. Herne wrote: On 01/24/2013 07:40 AM, Alexander Graf wrote: I think for now the best choice for get_regs() would be to ignore the FULL/RESET bits and always keep the syncing as it happens today under the RUNTIME umbrella only. So all of get_regs() only checks for

Re: [Qemu-devel] [PATCH] (RFC) target-ppc: Remove vestigial PowerPC 620 support

2013-02-11 Thread Andreas Färber
Am 11.02.2013 05:50, schrieb David Gibson: > The PowerPC 620 was the very first 64-bit PowerPC implementation, but > hardly anyone ever actually used the chips. qemu notionally supports the > 620, but since we don't actually have code to implement the segment table, > the support is broken (quite

[Qemu-devel] New Message-id field in commits

2013-02-11 Thread Anthony Liguori
Hi, You may notice that a new tag is being added to patches that I commit that includes the Message-ID of the mail. I'm added this for two reasons. It's a useful way to have a link between a commit and a mailing list post (so you can quickly find discussion about a commit). Having this field al

Re: [Qemu-devel] [PATCH V21 1/7] Support for TPM command line options

2013-02-11 Thread Corey Bryant
On 02/08/2013 09:55 PM, Stefan Berger wrote: > On 02/08/2013 05:01 PM, Eric Blake wrote: >> On 02/08/2013 02:42 PM, Stefan Berger wrote: >>> This patch adds support for TPM command line options. >>> The command line options supported here are >>> >>> ./qemu-... -tpmdev passthrough,path=,id= >>>

Re: [Qemu-devel] [Bug 1119281] [NEW] The virtio network device breaks UuidCreateSequential()

2013-02-11 Thread Yan Vugenfirer
On Mon, Feb 11, 2013 at 11:13 AM, Stefan Hajnoczi wrote: > On Fri, Feb 08, 2013 at 10:45:03AM -, Francois Gouget wrote: > > Public bug reported: > > > > UuidCreateSequential() usually creates version 1 UUIDs (1) which means > > they contain the main network card's MAC address. However when usi

Re: [Qemu-devel] [PATCH for-1.4 stable] block: handle spurious coroutine entries

2013-02-11 Thread Stefan Hajnoczi
On Mon, Feb 11, 2013 at 2:54 PM, Paolo Bonzini wrote: > Il 11/02/2013 14:29, Kevin Wolf ha scritto: >> Am 11.02.2013 14:17, schrieb Stefan Hajnoczi: >>> On Mon, Feb 11, 2013 at 1:42 PM, Paolo Bonzini wrote: Il 11/02/2013 13:29, Kevin Wolf ha scritto: > The bug is not in this function but

Re: [Qemu-devel] [PATCH 00/10] Support mips64/mipsn32-linux-user

2013-02-11 Thread Richard Henderson
On 2013-02-11 01:59, Peter Maydell wrote: Eight patches out of ten have no commit message beyond the one-liner summary... Ok, so? Most of the patches are microscopic, and do exactly what the summary says. r~

[Qemu-devel] tap device not working on top of a bridge if on top of a bond?

2013-02-11 Thread Stefan Priebe - Profihost AG
Hello list, until now all my bridges were on top of a raw ethernet device. My tap devices worked fine. Now ihad moved my bridge on top of a bond but then no tap device is working. My old Ubuntu/Debian style interfaces file looked like this: auto vmbr0 iface vmbr0 inet manual bridge_ports

Re: [Qemu-devel] [PATCH 00/10] Support mips64/mipsn32-linux-user

2013-02-11 Thread Peter Maydell
On 11 February 2013 15:45, Richard Henderson wrote: > On 2013-02-11 01:59, Peter Maydell wrote: >> Eight patches out of ten have no commit message beyond the >> one-liner summary... > Ok, so? Most of the patches are microscopic, > and do exactly what the summary says. Well, just to start with,

[Qemu-devel] [PATCH for-1.4] migration: restrict scope of incoming fd read handler

2013-02-11 Thread Stefan Hajnoczi
The incoming migration is processed in a coroutine and uses an fd read handler to enter the yielded coroutine when data becomes available. The read handler was set too broadly, so that spurious coroutine entries were be triggered if other coroutine users yielded (like the block layer's bdrv_write(

Re: [Qemu-devel] [PATCH 01/10] mips-linux-user: Delete n32 and n64 signal stubs

2013-02-11 Thread Richard Henderson
On 2013-02-10 10:30, Richard Henderson wrote: Signed-off-by: Richard Henderson Deleting these first makes the next patch much easier to read. This doesn't cause any sort of compilation failure because we have not yet enabled n32/n64 compilation. This is dead code. r~

Re: [Qemu-devel] [PATCH 02/10] mips-linux-user: Share o32 code for n32 and n64 signals

2013-02-11 Thread Richard Henderson
On 2013-02-10 10:30, Richard Henderson wrote: Signed-off-by: Richard Henderson --- linux-user/signal.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) There are very few differences between the mips abis wrt signal handling. The major ones are the sigcon

Re: [Qemu-devel] [PATCH 03/10] mips-linux-user: Enable mips64 and mipsn32 linux-user targets

2013-02-11 Thread Richard Henderson
On 2013-02-10 10:30, Richard Henderson wrote: Signed-off-by: Richard Henderson --- configure | 4 1 file changed, 4 insertions(+) At this point we can enable compilation, though things still don't work. r~

Re: [Qemu-devel] [PATCH 04/10] mips-linux-user: Save and restore fpu and dsp from sigcontext

2013-02-11 Thread Richard Henderson
On 2013-02-10 10:30, Richard Henderson wrote: Signed-off-by: Richard Henderson --- linux-user/signal.c | 157 +-- target-mips/cpu.h| 3 + target-mips/dsp_helper.c | 16 - 3 files changed, 58 insertions(+), 118 deletions(-) Pro

Re: [Qemu-devel] [PATCH 05/10] mips-linux-user: Fix n32 and n64 syscalls

2013-02-11 Thread Richard Henderson
On 2013-02-10 10:30, Richard Henderson wrote: Signed-off-by: Richard Henderson --- linux-user/main.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) n32/n64 have different argument registers from o32. In addition, use abi_long properly instead of the host un

Re: [Qemu-devel] [PATCH 09/10] mipsn32-linux-user: Restrict address space to 31-bits.

2013-02-11 Thread Richard Henderson
On 2013-02-10 10:30, Richard Henderson wrote: Signed-off-by: Richard Henderson --- linux-user/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Just like o32, n32 will fail if we don't respect the 31-bit address limit. r~

Re: [Qemu-devel] [PATCH for-1.4] migration: restrict scope of incoming fd read handler

2013-02-11 Thread Kevin Wolf
Am 11.02.2013 17:01, schrieb Stefan Hajnoczi: > The incoming migration is processed in a coroutine and uses an fd read > handler to enter the yielded coroutine when data becomes available. > > The read handler was set too broadly, so that spurious coroutine entries > were be triggered if other cor

Re: [Qemu-devel] [PATCH 00/10] Support mips64/mipsn32-linux-user

2013-02-11 Thread Richard Henderson
On 2013-02-11 07:57, Peter Maydell wrote: Well, just to start with, I looked at patch 1 and thought "why is it ok to delete these without it making something fail to compile?". Fair enough. Assume the replies I just sent will be in the next revision. r~

[Qemu-devel] [PATCH 6/9] target-i386: convert 'check' and 'enforce' to static properties

2013-02-11 Thread Igor Mammedov
* additionally convert check_cpuid & enforce_cpuid to bool * make 'enforce' feature independent from 'check' Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 77 - 1 files changed, 70 insertions(+), 7 deletions(-) diff --git a/target-i38

[Qemu-devel] [PATCH 3/6] qemu-log: Rename cpu_str_to_log_mask to qemu_str_to_log_mask

2013-02-11 Thread Peter Maydell
Rename cpu_str_to_log_mask() to qemu_str_to_log_mask(), since the qemu_log functionality is no longer restricted to TCG CPU debug logging. Signed-off-by: Peter Maydell --- bsd-user/main.c|2 +- cpus.c |2 +- include/qemu/log.h |2 +- linux-user/main.c |2 +- moni

[Qemu-devel] [PATCH for-1.4 RESEND v2 2/2] libi2c-omap: Fix endianness dependency

2013-02-11 Thread Andreas Färber
From: Andreas Färber The libqos driver for omap_i2c currently does not work on Big Endian. Introduce helpers for reading from and writing to 16-bit armel registers. This fixes tmp105-test failures on ppc. To prepare for a QTest-level endianness solution, poison mem{read,write} and always use th

[Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names

2013-02-11 Thread Peter Maydell
This patchset is just cleanups; it has two major aims: * remove 'cpu' from public-facing qemu_log function/type/etc names, since the logging is now entirely generic and not tied to TCG CPU debug logging at all * remove unnecessary indirection through cpus.c (ie set_cpu_log and set_cpu_lo

[Qemu-devel] [PATCH 1/6] qemu-log: Unify {cpu_set, set_cpu}_log_filename as qemu_set_log_filename

2013-02-11 Thread Peter Maydell
The qemu_log() functionality is no longer specific to TCG CPU debug logs. Rename cpu_set_log_filename() to qemu_set_log_filename() and drop the pointless wrapper set_cpu_log_filename(). Signed-off-by: Peter Maydell --- bsd-user/main.c |2 +- cpus.c|5 - include/

[Qemu-devel] [PATCH 2/6] qemu-log: Abstract out "print usage message about valid log categories"

2013-02-11 Thread Peter Maydell
Abstract out the "print a human readable list of all the valid log categories" functionality which is currently duplicated in three separate places. (We leave the monitor.c help_cmd() implementation as-is since it wants to send the message to the monitor and add its own information.) Signed-off-by

[Qemu-devel] qemu book

2013-02-11 Thread khan wahid
Hi, Could anyone point me to the complete book of this available chapter? - http://lists.gnu.org/archive/html/qemu-devel/2011-04/pdfhC5rVdz7U8.pdf I was trying to find other chapters, but no luck. Thank you. Best regards

Re: [Qemu-devel] [PATCH V21 1/7] Support for TPM command line options

2013-02-11 Thread Stefan Berger
On 02/11/2013 10:20 AM, Corey Bryant wrote: On 02/08/2013 09:55 PM, Stefan Berger wrote: On 02/08/2013 05:01 PM, Eric Blake wrote: On 02/08/2013 02:42 PM, Stefan Berger wrote: This patch adds support for TPM command line options. The command line options supported here are ./qemu-... -tpmdev

Re: [Qemu-devel] [PATCH for-1.4 RESEND v2 1/2] qtest: Use strtoull() for uint64_t

2013-02-11 Thread Andreas Färber
Am 11.02.2013 17:41, schrieb Andreas Färber: > On 32-bit hosts, unsigned long may be uint32_t and uint64_t may be > unsigned long long. Account for this by always using strtoull(). > We were already using strtoll() for int64_t. > > Signed-off-by: Andreas Färber Sorry, this one was Reviewed-by:

[Qemu-devel] [PATCH 3/9] target-i386: convert 'hv_spinlocks' to static property

2013-02-11 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 41 ++--- 1 files changed, 34 insertions(+), 7 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index a062337..1f14b65 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -496,6 +496,3

Re: [Qemu-devel] [PATCH 01/10] mips-linux-user: Delete n32 and n64 signal stubs

2013-02-11 Thread Peter Maydell
On 11 February 2013 16:02, Richard Henderson wrote: > On 2013-02-10 10:30, Richard Henderson wrote: >> >> Signed-off-by: Richard Henderson > > > Deleting these first makes the next patch much easier to read. > This doesn't cause any sort of compilation failure because we > have not yet enabled n3

[Qemu-devel] KVM call agenda for 2013-02-12

2013-02-11 Thread Juan Quintela
Hi Please send in any agenda topics you are interested in. Later, Juan.

Re: [Qemu-devel] [PATCH 02/10] mips-linux-user: Share o32 code for n32 and n64 signals

2013-02-11 Thread Peter Maydell
On 10 February 2013 18:30, Richard Henderson wrote: > Signed-off-by: Richard Henderson > @@ -2646,6 +2666,7 @@ restore_sigcontext(CPUMIPSState *regs, struct > target_sigcontext *sc) > #endif > return err; > } > + > /* > * Determine which stack to use.. > */ I was going to say 'stra

[Qemu-devel] [PATCH 1/9] target-i386: cpu: convert existing dynamic properties into static properties

2013-02-11 Thread Igor Mammedov
Following properties are converted: * vendor * xlevel * custom setter/getter replaced by qdev's DEFINE_PROP_UINT32 * level * custom setter/getter replaced by qdev's DEFINE_PROP_UINT32 * tsc-frequency * stepping * model * family * model-id * ch

[Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qapi-schema.json | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 736f881..bd289ae 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3152,6 +3152,9 @@ # # Return info about the cha

  1   2   3   >