Re: [Qemu-devel] scp during migration with vhost fails

2013-02-03 Thread Michael S. Tsirkin
On Fri, Feb 01, 2013 at 06:03:32PM +0800, Jason Wang wrote: > Hello all: > > During testing, I find doing scp during migration with vhost fails with > warnings in guest like: > > Corrupted MAC on input. > Disconnecting: Packet corrupt. > lost connection > > Here's the bisect result: > > Commit

Re: [Qemu-devel] [PATCH v3] bitops: unify bitops_ffsl with the one in host-utils.h, call it bitops_ctzl

2013-02-03 Thread Peter Maydell
On 3 February 2013 03:47, Paolo Bonzini wrote: > Actually I'm pretty sure that var == 0 is not possible in hbitmap. But > I still prefer having total functions, and also keeping the function > monotonic. Er, ctz() isn't monotonic: 1 => 0 2 => 1 3 => 0 4 => 2 etc... -- PMM

Re: [Qemu-devel] [OpenBIOS] Fix double nvram entry on newworld

2013-02-03 Thread Alexander Graf
Am 02.02.2013 um 14:05 schrieb Blue Swirl : > On Thu, Jan 31, 2013 at 3:10 PM, Alexander Graf wrote: >> >> On 30.01.2013, at 11:29, Amadeusz Sławiński wrote: >> >>> Fix double nvram entry on newworld >>> >>> There are two nvram entries on newworld (for example qemu -M mac99) >>> >>> The fir

Re: [Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device?

2013-02-03 Thread Michael S. Tsirkin
On Sat, Feb 02, 2013 at 12:01:52AM +0100, Paolo Bonzini wrote: > Il 31/01/2013 12:25, Michael S. Tsirkin ha scritto: > > On Thu, Jan 31, 2013 at 10:13:11AM +0200, Gal Hammer wrote: > >> Hi, > >> > >> How many msi-x vectors should be allocated for the virtio-serial device? > >> > >> I'm asking this

Re: [Qemu-devel] [OpenBIOS] Fix double nvram entry on newworld

2013-02-03 Thread Andreas Färber
Am 03.02.2013 12:25, schrieb Alexander Graf: > > Am 02.02.2013 um 14:05 schrieb Blue Swirl : > >> On Thu, Jan 31, 2013 at 3:10 PM, Alexander Graf wrote: >>> >>> Blue, once this patch is in the tree, do you think you could rebuild >>> OpenBIOS for QEMU, so that it will land in 1.4? >> >> Sorry,

Re: [Qemu-devel] [PATCH WIP 0/4] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-02-03 Thread Michael S. Tsirkin
On Fri, Feb 01, 2013 at 11:46:28AM +0800, Asias He wrote: > On 01/31/2013 07:12 PM, Michael S. Tsirkin wrote: > > On Wed, Jan 30, 2013 at 05:41:22PM +0100, Paolo Bonzini wrote: > >> Ok, so here is my attempt at a vhost-scsi device. I'm creating an > >> entirely separate device, with the common par

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-03 Thread Yan Vugenfirer
On Feb 3, 2013, at 1:07 AM, Anthony Liguori wrote: > Vadim Rozenfeld writes: > >> On Sat, 2013-02-02 at 20:42 +0800, Jason Wang wrote: >>> >>> Have a look at this issue. It was caused by multiqueue patch who adds a >>> new field to virtio_net_cfg. Not sure multiqueue is the root cause since >>

[Qemu-devel] [PATCH v3 0/3] AER-KVM: Error containment of VFIO devices assigned to KVM guests

2013-02-03 Thread Pandarathil, Vijaymohan R
Add support for error containment when a VFIO device assigned to a KVM guest encounters an error. This is for PCIe devices/drivers that support AER functionality. When the host OS is notified of an error in a device either through the firmware first approach or through an interrupt handled by the

[Qemu-devel] [PATCH v3 1/3] VFIO: Wrapper for getting reference to vfio_device from device

2013-02-03 Thread Pandarathil, Vijaymohan R
- Added vfio_device_get_from_dev() as wrapper to get reference to vfio_device from struct device. - Added vfio_device_data() as a wrapper to get device_data from vfio_device. Signed-off-by: Vijay Mohan Pandarathil --- drivers/vfio/vfio.c | 41 +++

[Qemu-devel] [PATCH v3 2/3] VFIO-AER: Vfio-pci driver changes for supporting AER

2013-02-03 Thread Pandarathil, Vijaymohan R
- New VFIO_SET_IRQ ioctl option to pass the eventfd that is signaled when an error occurs in the vfio_pci_device - Register pci_error_handler for the vfio_pci driver - When the device encounters an error, the error handler registered by the vfio_pci dr

Re: [Qemu-devel] [OpenBIOS] Fix double nvram entry on newworld

2013-02-03 Thread Anthony Liguori
Alexander Graf writes: > Am 02.02.2013 um 14:05 schrieb Blue Swirl : > >> On Thu, Jan 31, 2013 at 3:10 PM, Alexander Graf wrote: >>> >>> On 30.01.2013, at 11:29, Amadeusz Sławiński wrote: >>> Fix double nvram entry on newworld There are two nvram entries on newworld (for exampl

Re: [Qemu-devel] [PATCH v3 0/3] AER-KVM: Error containment of VFIO devices assigned to KVM guests

2013-02-03 Thread Gleb Natapov
Please use "git send-email --thread --no-chain-reply-to" when sending patch series. On Sun, Feb 03, 2013 at 02:10:08PM +, Pandarathil, Vijaymohan R wrote: > > Add support for error containment when a VFIO device assigned to a KVM > guest encounters an error. This is for PCIe devices/drivers t

Re: [Qemu-devel] [OpenBIOS] Fix double nvram entry on newworld

2013-02-03 Thread Alexander Graf
Am 03.02.2013 um 15:18 schrieb Anthony Liguori : > Alexander Graf writes: > >> Am 02.02.2013 um 14:05 schrieb Blue Swirl : >> >>> On Thu, Jan 31, 2013 at 3:10 PM, Alexander Graf wrote: On 30.01.2013, at 11:29, Amadeusz Sławiński wrote: > Fix double nvram entry on newworl

[Qemu-devel] [PATCH v3 3/3] QEMU-AER: Qemu changes to support AER for VFIO-PCI devices

2013-02-03 Thread Pandarathil, Vijaymohan R
- Create eventfd per vfio device assigned to a guest and register an event handler - This fd is passed to the vfio_pci driver through the SET_IRQ ioctl - When the device encounters an error, the eventfd is signalled and the qemu eventfd handler gets inv

[Qemu-devel] [Bug 826363] Re: qemu-img convert does not work with vdi files

2013-02-03 Thread Aaron Bouzek
Did this bug come back, or is "error while reading" unrelated but similar? Oh look, Debian is using an old version, what are the odds? Distributor ID: Debian Description:Debian GNU/Linux 6.0.6 (squeeze) Release:6.0.6 Codename: squeeze root@nakvm:~# qemu-img --help qemu-img versi

[Qemu-devel] [Bug 826363] Re: qemu-img convert does not work with vdi files

2013-02-03 Thread Aaron Bouzek
Or an old copy because Ubuntu proffers 1.0 which works fine on the same image. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/826363 Title: qemu-img convert does not work with vdi files Status in Q

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-03 Thread Michael Tokarev
03.02.2013 17:23, Yan Vugenfirer wrote: If it helps, mq changes the config size from 8 to 16 bytes. If the driver was making an assumption about an 8-byte config size, that's likely what the problem is. That's exactly the problem. So what do we do? It isn't nice to break existing setups. M

Re: [Qemu-devel] [PATCH v3 2/3] VFIO-AER: Vfio-pci driver changes for supporting AER

2013-02-03 Thread Blue Swirl
On Sun, Feb 3, 2013 at 2:10 PM, Pandarathil, Vijaymohan R wrote: > - New VFIO_SET_IRQ ioctl option to pass the eventfd that is signaled > when > an error occurs in the vfio_pci_device > > - Register pci_error_handler for the vfio_pci driver > > - When the device

Re: [Qemu-devel] [PATCH v3] bitops: unify bitops_ffsl with the one in host-utils.h, call it bitops_ctzl

2013-02-03 Thread Blue Swirl
Thanks, applied. On Fri, Feb 1, 2013 at 10:03 PM, Paolo Bonzini wrote: > We had two copies of a ffs function for longs with subtly different > semantics and, for the one in bitops.h, a confusing name: the result > was off-by-one compared to the library function ffsl. > > Unify the functions into

Re: [Qemu-devel] [PATCH] util: Fix compilation of envlist.c for MinGW

2013-02-03 Thread Blue Swirl
Thanks, applied. On Wed, Jan 16, 2013 at 6:04 PM, Stefan Weil wrote: > MinGW has no strtok_r, so we need a declaration in sysemu/os-win32.h. > We must also fix the include statements in util/envlist.c to include > that file. > > We currently don't need an implementation of strtok_r because the >

Re: [Qemu-devel] [PATCH v3 3/3] QEMU-AER: Qemu changes to support AER for VFIO-PCI devices

2013-02-03 Thread Blue Swirl
On Sun, Feb 3, 2013 at 2:10 PM, Pandarathil, Vijaymohan R wrote: > - Create eventfd per vfio device assigned to a guest and register an > event handler > > - This fd is passed to the vfio_pci driver through the SET_IRQ ioctl > > - When the device encounters an err

Re: [Qemu-devel] [PATCH for-1.4] configure: Fix build with XFree

2013-02-03 Thread Richard Henderson
I should have put for-1.4 in the subject... r~ On 2013-02-01 14:32, Richard Henderson wrote: The build is broken on ppc64-linux, possibly only with new binutils: ld: hw/lm32/../milkymist-tmu2.o: undefined reference to symbol 'XFree' ld: note: 'XFree' is defined in DSO /lib64/libX11.so.6 so tr

[Qemu-devel] [PATCH for 1.4] target-s390x: Fix wrong comparison in interrupt handling

2013-02-03 Thread Stefan Weil
gcc with -Wextra complains about an ordered pointer comparison: target-s390x/helper.c:660:27: warning: ordered comparison of pointer with integer zero [-Wextra] Obviously the index was missing in the code. Signed-off-by: Stefan Weil --- I hope my analysis and the fix is correct - please revie

[Qemu-devel] [PATCH] vnc: recognize Hungarian doubleacutes

2013-02-03 Thread Michael Tokarev
As reported in http://bugs.debian.org/697641 , some Hungarian keys does not work with qemu when using vnc display. This is because while the Hungarian keymap mentions these symbols, qemu know nothing about them. So add them. This patch is applicable to -stable for all previous releases. Signed-

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-03 Thread Anthony Liguori
Michael Tokarev writes: > 03.02.2013 17:23, Yan Vugenfirer wrote: > >>> If it helps, mq changes the config size from 8 to 16 bytes. If the >>> driver was making an assumption about an 8-byte config size, that's >>> likely what the problem is. >>> >> That's exactly the problem. > > So what do we

Re: [Qemu-devel] [PATCH V3 8/8] hw/mdio: Use bitbang core for smc91c111 network device

2013-02-03 Thread Grant Likely
On Sat, 2 Feb 2013 23:51:42 +, Peter Maydell wrote: > On 2 February 2013 23:40, Grant Likely wrote: > > static const VMStateDescription vmstate_smc91c111 = { > > @@ -71,6 +76,8 @@ static const VMStateDescription vmstate_smc91c111 = { > > VMSTATE_BUFFER_UNSAFE(data, smc91c111_state,

[Qemu-devel] [PATCH V4 8/8] hw/mdio: Use bitbang core for smc91c111 network device

2013-02-03 Thread Grant Likely
The smc91c111 device has bitbanged MDIO access, but the model doesn't yet implement it. This patch uses the generalized bitbang MDIO support pulled out of etraxfs Ethernet driver. The MDIO state machine is driven by changes in state to the clock control bit in the management register. The PHY mode

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-03 Thread Michael S. Tsirkin
On Sun, Feb 03, 2013 at 03:09:39PM -0600, Anthony Liguori wrote: > Michael Tokarev writes: > > > 03.02.2013 17:23, Yan Vugenfirer wrote: > > > >>> If it helps, mq changes the config size from 8 to 16 bytes. If the > >>> driver was making an assumption about an 8-byte config size, that's > >>> li

[Qemu-devel] [Bug 1090600] Re: Improve error reporting when -drive format= is incorrect

2013-02-03 Thread Stefan Weil
Fixed in QEMU 1.4 ** Changed in: qemu Status: In Progress => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1090600 Title: Improve error reporting when -drive format= is incorre

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-03 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Sun, Feb 03, 2013 at 03:09:39PM -0600, Anthony Liguori wrote: >> Michael Tokarev writes: >> >> > 03.02.2013 17:23, Yan Vugenfirer wrote: >> > >> >>> If it helps, mq changes the config size from 8 to 16 bytes. If the >> >>> driver was making an assumption about

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-03 Thread Vadim Rozenfeld
On Sun, 2013-02-03 at 15:09 -0600, Anthony Liguori wrote: > Michael Tokarev writes: > > > 03.02.2013 17:23, Yan Vugenfirer wrote: > > > >>> If it helps, mq changes the config size from 8 to 16 bytes. If the > >>> driver was making an assumption about an 8-byte config size, that's > >>> likely wh

[Qemu-devel] [PATCH 0/6] change acpi numa info format passed from qemu to seabios

2013-02-03 Thread liguang
orginally, numa info was packed into an array of 64-bit data which was implicit and hard to maintain, so we define a struct for these info, hope to be as clear as enough. these changes also involved seabios paches which was sent to seabios mail-list. Li Guang(6) [PATCH 1/6] pc/bios: move

[Qemu-devel] [PATCH 4/6] pc: format load_linux()

2013-02-03 Thread liguang
seems this function was in wrong coding format so try correct it boldly. Signed-off-by: liguang --- hw/pc.c | 90 +++--- 1 files changed, 45 insertions(+), 45 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 893c930..01d00f6 100644 ---

[Qemu-devel] [PATCH 6/6] load_linux: change kernel header size allocation

2013-02-03 Thread liguang
it's not necessary to alloc 8K bytes for kernel header, 0.5K is enough. Signed-off-by: liguang --- hw/pc.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 0ccd775..b6b236f 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -637,6 +637,9 @@ static long

[Qemu-devel] [PATCH 5/6] load_linux: report open kernel file & its size error

2013-02-03 Thread liguang
Signed-off-by: liguang --- hw/pc.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 01d00f6..0ccd775 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -652,12 +652,20 @@ static void load_linux(void *fw_cfg, char *vmode; /* Align to 16

[Qemu-devel] [seabios][PATCH 2/2] acpi: change numa data format from fw_cfg interface

2013-02-03 Thread liguang
the old numa format got form fw_cfg is: number of nodes node id of cpu (array) node memory size (array) now, format it like array of: apci_map, memory_size, it has the advantage of simple and clear. Signed-off-by: liguang --- src/acpi.c | 57 --

[Qemu-devel] [PATCH 2/6] pc/numa: refactor bios_init function

2013-02-03 Thread liguang
orginally, numa data was packed into an array, which was implicit and hard to maintain, we define a struct for this data, hope to be as clear as enough. also, we only pass cpumask of corresponding nodes to seabios, and leave the paring work for it. Signed-off-by: liguang --- hw/pc.c | 40 +

[Qemu-devel] [PATCH 3/6] bitops: change BITS_TO_LONGS

2013-02-03 Thread liguang
Signed-off-by: liguang --- include/qemu/bitops.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h index 74e14e5..7758792 100644 --- a/include/qemu/bitops.h +++ b/include/qemu/bitops.h @@ -20,7 +20,7 @@ #define BIT(nr)

[Qemu-devel] [seabios][PATCH 1/2] move all acpi-table related definitions to acpi.h

2013-02-03 Thread liguang
Signed-off-by: liguang --- src/acpi.c | 209 ++-- src/acpi.h | 201 + 2 files changed, 206 insertions(+), 204 deletions(-) diff --git a/src/acpi.c b/src/acpi.c index 6267d7b..fde37e5

[Qemu-devel] [PATCH 1/6] pc/bios: move common BIOS_CFG_IOPORT into fw_cfg.h

2013-02-03 Thread liguang
BIOS_CFG_IOPORT are commonly used, so move it to fw_cfg.h bochs_bios_init seems misleading, bios may be seabios, seabios is not only for bochs, and also we are in qemu. Signed-off-by: liguang --- hw/fw_cfg.h |4 hw/pc.c |9 - hw/sun4u.c |3 +-- 3 files changed, 9 in

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-03 Thread Rusty Russell
Anthony Liguori writes: > Michael Tokarev writes: > >> 03.02.2013 17:23, Yan Vugenfirer wrote: >> If it helps, mq changes the config size from 8 to 16 bytes. If the driver was making an assumption about an 8-byte config size, that's likely what the problem is. >>> That's exac

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-03 Thread Michael S. Tsirkin
On Mon, Feb 04, 2013 at 10:30:47AM +1100, Vadim Rozenfeld wrote: > On Sun, 2013-02-03 at 15:09 -0600, Anthony Liguori wrote: > > Michael Tokarev writes: > > > > > 03.02.2013 17:23, Yan Vugenfirer wrote: > > > > > >>> If it helps, mq changes the config size from 8 to 16 bytes. If the > > >>> driv

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-03 Thread Michael S. Tsirkin
On Sun, Feb 03, 2013 at 04:57:38PM -0600, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Sun, Feb 03, 2013 at 03:09:39PM -0600, Anthony Liguori wrote: > >> Michael Tokarev writes: > >> > >> > 03.02.2013 17:23, Yan Vugenfirer wrote: > >> > > >> >>> If it helps, mq changes the con

[Qemu-devel] QEMU does not communicate properly with GDB with a 64 bit guest

2013-02-03 Thread Furukawa, Eiji
When GDB is connected with qemu-1.1.0(target x86_64-softmmu), it is not possible to debug it. (Bug#640213) The reason for the cause is that the correspondence of CPU register and the register value seen on the GDB side is incorrect. The evasion of the problem is possible by the replacement of

Re: [Qemu-devel] [PATCH 1/2] virtio-net: pass host features to virtio_net_init

2013-02-03 Thread Konrad Frederic
On 03/02/2013 00:06, Anthony Liguori wrote: Signed-off-by: Anthony Liguori --- hw/s390x/s390-virtio-bus.c | 3 ++- hw/s390x/virtio-ccw.c | 3 ++- hw/virtio-pci.c| 3 ++- hw/virtio.h| 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/s3

[Qemu-devel] [PATCHv2] virtio-net: remove mq feature flag

2013-02-03 Thread Michael S. Tsirkin
mq flag is not needed: we can look at the number of queues and set the flag accordingly. Removing this feature removes ambiguity (what does it mean to have queues=2 with mq=off?), and simplifies compatibility hacks. work-around for buggy windows guests. Signed-off-by: Michael S. Tsirkin --- hw/p

Re: [Qemu-devel] [PATCH for-1.4] tests/test-string-input-visitor: Handle errors provoked by fuzz test

2013-02-03 Thread Markus Armbruster
[Note cc: Luiz] Peter Maydell writes: > On 2 February 2013 21:37, Andreas Färber wrote: >> Am 02.02.2013 22:19, schrieb Peter Maydell: >>> It's OK and expected for visitors to return errors when presented with >>> the fuzz test's random data. This means the test harness needs to >>> handle them