Re: [Qemu-devel] RFC migration of zero pages

2013-01-31 Thread Peter Lieven
Am 31.01.2013 um 08:47 schrieb Orit Wasserman : > On 01/31/2013 08:57 AM, Peter Lieven wrote: >> Hi, >> >> I just came across an idea and would like to have feedback if it makes sence >> or not. >> >> If a VM is started without preallocated memory all memory that has not been >> written to >>

Re: [Qemu-devel] [PATCH WIP 0/4] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-01-31 Thread Nicholas A. Bellinger
Hi Paolo, On Wed, 2013-01-30 at 17:41 +0100, Paolo Bonzini wrote: > Ok, so here is my attempt at a vhost-scsi device. I'm creating an > entirely separate device, with the common parts of virtio-scsi and > vhost-scsi (actually little more than the initialization) grouped into > a VirtIOSCSICommon

Re: [Qemu-devel] RFC migration of zero pages

2013-01-31 Thread Orit Wasserman
On 01/31/2013 10:10 AM, Peter Lieven wrote: > > Am 31.01.2013 um 08:47 schrieb Orit Wasserman : > >> On 01/31/2013 08:57 AM, Peter Lieven wrote: >>> Hi, >>> >>> I just came across an idea and would like to have feedback if it makes >>> sence or not. >>> >>> If a VM is started without preallocate

Re: [Qemu-devel] [PATCH for-1.4 0/2] target-s390x: CPU cleanups preparing for 1.5

2013-01-31 Thread Cornelia Huck
On Wed, 30 Jan 2013 23:48:23 +0100 Andreas Färber wrote: > Hi Alex, > > Here's a cleanup of all of cpu_inject_*(), as requested by Cornelia, plus > another API preparation for my CPUState part 8 series, to go along with my > debug output bug fixes. > > As a reminder here's a link to one of my o

[Qemu-devel] [PATCH V17 01/10] build: add command check-clean

2013-01-31 Thread Wenchao Xia
This command will package the clean operations in tests, to make it easy to be extended. Now root Makefile simply calls the command and do not care the details of it any more. Signed-off-by: Wenchao Xia --- Makefile |1 - tests/Makefile |8 +++- 2 files changed, 7 insertions(

[Qemu-devel] [PATCH V17 10/10] libqblock: test: libqblock test example

2013-01-31 Thread Wenchao Xia
In this example, first it will create some qcow2 images, then try get information including backing file relationship, then it will do sync IO on the image. Signed-off-by: Wenchao Xia --- tests/Makefile|2 + tests/check-libqblock-qcow2.c | 392 +

[Qemu-devel] [PATCH V17 07/10] libqblock: libqblock API design and type defines

2013-01-31 Thread Wenchao Xia
Public API design header files: libqblock.h, libqblock-error.h. Public type define header files: libqblock-types.h. Private internal used header files: libqblock-internal. For ABI some reserved bytes are used in structure defines. Macro QEMU_DLL_PUBLIC is used to mark exported function. Importan

Re: [Qemu-devel] [PATCH V5 02/13] block: add bdrv_get_filename() function

2013-01-31 Thread Wenchao Xia
于 2013-1-29 20:53, Kevin Wolf 写道: Am 24.01.2013 03:57, schrieb Wenchao Xia: This function will simply return the uri or filename used to open the image. Reviewed-by: Eric Blake Signed-off-by: Wenchao Xia The only user of this function in the series is in block.c and could have called it

Re: [Qemu-devel] [PATCH 0/4] Fix misuse of atomics in trace/simple.c

2013-01-31 Thread Markus Armbruster
Ping? Markus Armbruster writes: > More old news: casting pointers considered harmful, and atomics > considered hard to use correctly. > > Markus Armbruster (4): > trace: Fix simple trace dropped event record for big endian > trace: Direct access of atomics is verboten, use the API > trace:

Re: [Qemu-devel] [PATCH V5 03/13] block: add bdrv_can_read_snapshot() function

2013-01-31 Thread Wenchao Xia
于 2013-1-29 20:37, Kevin Wolf 写道: Am 25.01.2013 19:11, schrieb Eric Blake: On 01/23/2013 07:57 PM, Wenchao Xia wrote: Compared to bdrv_can_snapshot(), this function return whether bs* is ready to read snapshot info from instead of write. If yes, caller can then query snapshot information, bu

Re: [Qemu-devel] [PATCH V5 04/13] block: add snapshot info query function bdrv_query_snapshot_infolist()

2013-01-31 Thread Wenchao Xia
于 2013-1-29 20:48, Kevin Wolf 写道: Am 24.01.2013 03:57, schrieb Wenchao Xia: This patch add function bdrv_query_snapshot_infolist(), which will return snapshot info of an image in qmp object format. The implementation code are mostly copied from qemu-img.c with modification to fit more for qmp

Re: [Qemu-devel] [PATCH V5 05/13] block: add image info query function bdrv_query_image_info()

2013-01-31 Thread Wenchao Xia
于 2013-1-29 20:55, Kevin Wolf 写道: Am 24.01.2013 03:57, schrieb Wenchao Xia: This patch add function bdrv_query_image_info(), which will return image info in qmp object format. The implementation code are mostly copied from qemu-img.c, but use block layer function to get snapshot info. Don't

Re: [Qemu-devel] [PATCH V5 06/13] qemu-img: switch image retrieving function

2013-01-31 Thread Wenchao Xia
于 2013-1-29 20:56, Kevin Wolf 写道: Am 24.01.2013 03:57, schrieb Wenchao Xia: Now qemu-img call block layer function to get image info and check if error happens. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake Merge this with patch 5. Kevin OK. -- Best Regards Wenchao Xia

[Qemu-devel] [PATCH V17 02/10] build: hide symbols in *.lo

2013-01-31 Thread Wenchao Xia
This patch will hide all symbols except those marked with QEMU_DLL_PUBLIC in .lo files. Because vsclient linked some function in qemu, so export them as well. All symbols in libcacard.syms are marked as public. Signed-off-by: Wenchao Xia --- configure | 18 +

Re: [Qemu-devel] [PATCH V5 07/13] block: rename bdrv_query_info to bdrv_query_block_info

2013-01-31 Thread Wenchao Xia
于 2013-1-29 21:05, Kevin Wolf 写道: Am 29.01.2013 14:04, schrieb Kevin Wolf: Am 24.01.2013 03:57, schrieb Wenchao Xia: Now that we have bdrv_query_image_info, rename this function to make it more obvious what it is doing. Reviewed-by: Eric Blake Signed-off-by: Wenchao Xia Should this prov

[Qemu-devel] [PATCH V17 05/10] libqblock: build: add packaging support

2013-01-31 Thread Wenchao Xia
Now libqblock can be packaged and installed by "sudo make install-libqblock'. Signed-off-by: Wenchao Xia --- libqblock/Makefile | 34 +- libqblock/libqblock.pc.in | 13 + 2 files changed, 42 insertions(+), 5 deletions(-) create mode 1

[Qemu-devel] [PATCH V17 04/10] libqblock: build: add rule for libqblock.la

2013-01-31 Thread Wenchao Xia
Now libqblock.la can be built with neccessary object files, and can be automatically cleaned by make clean in root directory. make libqblock-clean also clean it. -fvisibility=hidden was used to hide symbols, and a special macro was introduced to export symbols that marked as public. Signed-off-b

[Qemu-devel] [PATCH V17 00/10] libqblock qemu block layer library

2013-01-31 Thread Wenchao Xia
These patches introduce libqblock API, make subdir-libqblock and make check-libqblock could build this library. Functionalities: 1 create a new image. 2 sync access of an image. 3 basic image information retrieving such as backing file. 4 detect if a sector is allocated in an image. Supported

Re: [Qemu-devel] [PATCH V5 09/13] block: export function bdrv_find_snapshot()

2013-01-31 Thread Wenchao Xia
于 2013-1-29 21:15, Kevin Wolf 写道: Am 24.01.2013 03:57, schrieb Wenchao Xia: This patch move it from savevm.c to block.c and export it. To make it clear about id and name in searching, the API was changed a bit to distinguish them. Caller can choose to search by id or name now. Signed-off-by:

[Qemu-devel] [PATCH V17 08/10] libqblock: libqblock API implement

2013-01-31 Thread Wenchao Xia
This patch contains implemention for APIs. Basically it is a layer above qemu block general layer now. qb_context_new() will try do init for this library. Signed-off-by: Wenchao Xia --- libqblock/libqblock-error.c | 60 +++ libqblock/libqblock.c | 1092 +++

[Qemu-devel] qemu-ga: user tool in /usr/bin ?

2013-01-31 Thread Michael Tokarev
I wonder why qemu-ga is a user-callable binary as installed by `make install'. It appears to be a system daemon which, at the very least, requires root privileges to write its pidfile and open the transport device. Shouldn't it go to $sbindir or even $libexecdir instead of the current $bindif ?

[Qemu-devel] [PATCH V17 09/10] libqblock: build: add rules for test case

2013-01-31 Thread Wenchao Xia
Libtool will be used for final link, the rules do nothing if libqblock was disabled. Temp directory was used to store image created in test, which will be deleted in clean. Signed-off-by: Wenchao Xia --- tests/Makefile |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --

Re: [Qemu-devel] [RFC] qemu snapshot enchancement

2013-01-31 Thread Wenchao Xia
于 2013-1-30 1:44, Paolo Bonzini 写道: Il 29/01/2013 17:44, Stefan Hajnoczi ha scritto: I'm planning to add offline mirroring to qemu-img. If you use an NBD server as the destination, it can be used to send only the delta between two snapshots via NBD. I think this is the opposite of what you su

[Qemu-devel] [PATCH V17 06/10] block: export function path_has_protocol()

2013-01-31 Thread Wenchao Xia
libqblock need to use it. Signed-off-by: Wenchao Xia --- block.c |2 +- include/block/block.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index ba67c0d..44db62f 100644 --- a/block.c +++ b/block.c @@ -195,7 +195,7 @@ static void

[Qemu-devel] [PATCH V17 03/10] libqblock: build: add configure support

2013-01-31 Thread Wenchao Xia
Rule for libqblock.la will be included if it is enabled, and will be added to 'all' to be automatically built. Only support Linux now, to save trouble in building on windows. Signed-off-by: Wenchao Xia --- Makefile |3 +++ configure | 34 +

Re: [Qemu-devel] RFC migration of zero pages

2013-01-31 Thread Gleb Natapov
On Thu, Jan 31, 2013 at 09:47:24AM +0200, Orit Wasserman wrote: > On 01/31/2013 08:57 AM, Peter Lieven wrote: > > Hi, > > > > I just came across an idea and would like to have feedback if it makes > > sence or not. > > > > If a VM is started without preallocated memory all memory that has not be

Re: [Qemu-devel] [PATCH] Fix monitor 'info registers' command on multi processor guests

2013-01-31 Thread Markus Armbruster
"Erlon Cruz" writes: > QEMU monitor command 'info registers' only displays information for the first > CPU. This fix that by show registers information for each CPU in the system This is incorrect. It displays information for the *current* CPU. Monitor command "cpu" selects the current CPU. I

[Qemu-devel] [PATCH] configure: Undefine _FORTIFY_SOURCE prior using it

2013-01-31 Thread Michal Privoznik
Currently, we are enforcing the _FORTIFY_SOURCE=2 without any previous detection if the macro has been already defined, e.g. by environment, or is just enabled by compiler by default. Signed-off-by: Michal Privoznik --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] RFC migration of zero pages

2013-01-31 Thread Orit Wasserman
On 01/31/2013 11:48 AM, Gleb Natapov wrote: > On Thu, Jan 31, 2013 at 09:47:24AM +0200, Orit Wasserman wrote: >> On 01/31/2013 08:57 AM, Peter Lieven wrote: >>> Hi, >>> >>> I just came across an idea and would like to have feedback if it makes >>> sence or not. >>> >>> If a VM is started without p

Re: [Qemu-devel] KVM call minutes 2013-01-29 - Port I/O

2013-01-31 Thread Michael S. Tsirkin
On Wed, Jan 30, 2013 at 04:28:30PM -0700, Alex Williamson wrote: > On Thu, 2013-01-31 at 10:02 +1100, Benjamin Herrenschmidt wrote: > > On Thu, 2013-01-31 at 00:49 +0200, Michael S. Tsirkin wrote: > > > > In practice they do (VGA at least) > > > > > > > > >From a SW modelling standpoint, I don't t

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 4/5] connection-setup code between client/server

2013-01-31 Thread Orit Wasserman
Hi Michael, It will be cleaner to create a new file migration-rdma.c and put all the RDMA logic into it, this way you won't effect TCP migration code. More comments inline On 01/29/2013 12:01 AM, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > > Signed-off-by: Michael R. Hines

Re: [Qemu-devel] [kvmarm] [RFC v5 7/8] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC

2013-01-31 Thread KONRAD Frédéric
On 24/01/2013 16:43, Peter Maydell wrote: Implement support for using the KVM in-kernel GIC for ARM. Signed-off-by: Peter Maydell --- hw/a15mpcore.c |8 ++- hw/arm/Makefile.objs |1 + hw/kvm/arm_gic.c | 169 ++ 3 files chan

[Qemu-devel] [PATCH 00/11] main-loop: switch to g_poll(3) on POSIX hosts

2013-01-31 Thread Stefan Hajnoczi
Amos Kong reported that file descriptors numbered higher than 1024 could crash QEMU. This is due to the fixed size of the fd_set type used for select(2) event polling. This series converts the main-loop.c and aio-posix.c select(2) calls to g_poll(3). This eliminates the fd_set type and allows Q

[Qemu-devel] [PATCH 11/11] aio: support G_IO_HUP and G_IO_ERR

2013-01-31 Thread Stefan Hajnoczi
aio-posix.c could not take advantage of G_IO_HUP and G_IO_ERR because select(2) does not have equivalent events. Now that g_poll(3) is used we can support G_IO_HUP and G_IO_ERR. Signed-off-by: Stefan Hajnoczi --- aio-posix.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) d

[Qemu-devel] [PATCH 08/11] main-loop: drop rfds/wfds/xfds for good

2013-01-31 Thread Stefan Hajnoczi
Now that all *_fill() and *_poll() functions use Poller we no longer need rfds/wfds/xfds or poller_from_select()/poller_to_select(). >From now on everything uses Poller. Signed-off-by: Stefan Hajnoczi --- main-loop.c | 73 ++--- 1 file cha

[Qemu-devel] [PATCH 09/11] aio: extract aio_dispatch() from aio_poll()

2013-01-31 Thread Stefan Hajnoczi
We will need to loop over AioHandlers calling ->io_read()/->io_write() when aio_poll() is converted from select(2) to g_poll(2). Luckily the code for this already exists, extract it into the new aio_dispatch() function. Two small changes: * aio_poll() checks !node->deleted to avoid calling hand

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 5/5] send memory over RDMA as blocks are iterated

2013-01-31 Thread Orit Wasserman
Hi Michael, I maybe missing something here but why do you need a RAM_SAVE_FLAG_RDMA flag? You don't do any decoding in the destination. I would suggest creating a QEMUFileRDMA and moving the write/read code You can either add a new rdma_buffer QEMUFileOps or add the address to put_buffer. you al

[Qemu-devel] [PATCH 04/11] main-loop: switch to g_poll() on POSIX hosts

2013-01-31 Thread Stefan Hajnoczi
Use g_poll(3) instead of select(2). Well, this is kind of a cheat. It's true that we're now using g_poll(3) on POSIX hosts but the *_fill() and *_poll() functions are still using rfds/wfds/xfds. We've set the scene to start converting *_fill() and *_poll() functions step-by-step until no more rfd

Re: [Qemu-devel] [PATCH WIP 0/4] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-01-31 Thread Michael S. Tsirkin
On Wed, Jan 30, 2013 at 05:41:22PM +0100, Paolo Bonzini wrote: > Ok, so here is my attempt at a vhost-scsi device. I'm creating an > entirely separate device, with the common parts of virtio-scsi and > vhost-scsi (actually little more than the initialization) grouped into > a VirtIOSCSICommon type

Re: [Qemu-devel] [PATCH 6/8] linux-user: Rewrite __get_user/__put_user with __builtin_choose_expr

2013-01-31 Thread Peter Maydell
On 23 January 2013 18:31, Laurent Desnogues wrote: > On Sat, Jan 5, 2013 at 1:39 AM, Richard Henderson wrote: >> +#define __get_user_e(x, hptr, e)\ >> + ((x) =\ >> + __builtin_choose_expr(si

Re: [Qemu-devel] [PATCH 1/4] trace: Fix simple trace dropped event record for big endian

2013-01-31 Thread Laszlo Ersek
comments in-line On 01/25/13 16:43, Markus Armbruster wrote: > We use atomic operations to keep track of dropped events. > > Inconveniently, GLib supports only int and void * atomics, but the > counter dropped_events is uint64_t. That's too bad. Instead of (or in addition to) int, glib should ta

Re: [Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device?

2013-01-31 Thread Michael S. Tsirkin
On Thu, Jan 31, 2013 at 10:13:11AM +0200, Gal Hammer wrote: > Hi, > > How many msi-x vectors should be allocated for the virtio-serial device? > > I'm asking this as it seems that a proposed patch > (http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg02094.html) > was not accepted and I re-e

Re: [Qemu-devel] [PATCH 2/4] trace: Direct access of atomics is verboten, use the API

2013-01-31 Thread Laszlo Ersek
On 01/25/13 16:43, Markus Armbruster wrote: > The GLib Reference Manual says: > > It is very important that all accesses to a particular integer or > pointer be performed using only this API and that different sizes > of operation are not mixed or used on overlapping memory > regio

Re: [Qemu-devel] [PATCH 3/4] trace: Clean up the "try to update atomic until it worked" loops

2013-01-31 Thread Laszlo Ersek
On 01/25/13 16:43, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > trace/simple.c | 18 +- > 1 file changed, 5 insertions(+), 13 deletions(-) Reviewed-by: Laszlo Ersek

[Qemu-devel] [PATCH 03/11] poller: add poller_fill() and poller_poll()

2013-01-31 Thread Stefan Hajnoczi
The Windows event loop cannot be converted entirely to g_poll(3). It will still need select(2) so add functions that convert between Poller and rfds/wfds/xfds. This way most code only needs to be aware of Poller but it will still be possible to invoke select(2). Signed-off-by: Stefan Hajnoczi -

Re: [Qemu-devel] [PATCH 4/4] trace: Fix location of simpletrace.py in docs

2013-01-31 Thread Laszlo Ersek
On 01/25/13 16:43, Markus Armbruster wrote: > Missed when commit 4c3b5a48 moved it. > > Signed-off-by: Markus Armbruster > --- > docs/tracing.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Laszlo Ersek

Re: [Qemu-devel] [kvmarm] [RFC v5 7/8] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC

2013-01-31 Thread Peter Maydell
On 31 January 2013 10:54, Andreas Färber wrote: > Am 31.01.2013 11:52, schrieb KONRAD Frédéric: >>> +const char *gictype = "arm-gic"; >> s/arm-gic/arm_gic/ ^^ ? >> >> Christoffer and I had trouble with that: >> >> qemu-system-arm: Unknown device 'arm-gic' for default sysbus Oo

Re: [Qemu-devel] [PATCH] Fix monitor 'info registers' command on multi processor guests

2013-01-31 Thread Luiz Capitulino
On Thu, 31 Jan 2013 10:51:10 +0100 Markus Armbruster wrote: > "Erlon Cruz" writes: > > > QEMU monitor command 'info registers' only displays information for the > > first > > CPU. This fix that by show registers information for each CPU in the system > > This is incorrect. It displays inform

[Qemu-devel] [PATCH 05/11] main-loop: switch POSIX glib integration to Poller

2013-01-31 Thread Stefan Hajnoczi
Convert glib file descriptor polling from rfds/wfds/xfds to Poller. The Windows code still needs poll_fds[] and n_poll_fds but they can now become local variables. Signed-off-by: Stefan Hajnoczi --- main-loop.c | 75 - 1 file changed,

[Qemu-devel] [PATCH 10/11] aio: convert aio_poll() to g_poll(3)

2013-01-31 Thread Stefan Hajnoczi
AioHandler already has a GPollFD so we can directly use its events/revents. Add the int poller_idx field to AioContext so we can map g_poll(3) results back to AioHandlers. Reuse aio_dispatch() to invoke handlers after g_poll(3). Signed-off-by: Stefan Hajnoczi --- aio-posix.c | 62 +

[Qemu-devel] [PATCH 01/11] main-loop: fix select_ret uninitialized variable warning

2013-01-31 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- main-loop.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/main-loop.c b/main-loop.c index 6f52ac3..d0d8fe4 100644 --- a/main-loop.c +++ b/main-loop.c @@ -330,7 +330,8 @@ void qemu_fd_register(int fd) static int os_host_main_loop_wait(uin

Re: [Qemu-devel] [PATCH 1/4] trace: Fix simple trace dropped event record for big endian

2013-01-31 Thread Harsh Bora
On 01/25/2013 09:13 PM, Markus Armbruster wrote: We use atomic operations to keep track of dropped events. Inconveniently, GLib supports only int and void * atomics, but the counter dropped_events is uint64_t. Can't stop commit 62bab732: a quick (gint *)&dropped_events bludgeons the compiler in

Re: [Qemu-devel] [PATCH 2/4] trace: Direct access of atomics is verboten, use the API

2013-01-31 Thread Harsh Bora
On 01/25/2013 09:13 PM, Markus Armbruster wrote: The GLib Reference Manual says: It is very important that all accesses to a particular integer or pointer be performed using only this API and that different sizes of operation are not mixed or used on overlapping memory region

Re: [Qemu-devel] [PATCH 1/4] trace: Fix simple trace dropped event record for big endian

2013-01-31 Thread Markus Armbruster
Laszlo Ersek writes: > comments in-line > > On 01/25/13 16:43, Markus Armbruster wrote: >> We use atomic operations to keep track of dropped events. >> >> Inconveniently, GLib supports only int and void * atomics, but the >> counter dropped_events is uint64_t. > > That's too bad. Instead of (or

Re: [Qemu-devel] [PATCH] Fix monitor 'info registers' command on multi processor guests

2013-01-31 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 31 Jan 2013 10:51:10 +0100 > Markus Armbruster wrote: > >> "Erlon Cruz" writes: >> >> > QEMU monitor command 'info registers' only displays information >> > for the first >> > CPU. This fix that by show registers information for each CPU in the system >> >> T

[Qemu-devel] [PATCH 07/11] iohandler: switch to Poller

2013-01-31 Thread Stefan Hajnoczi
Convert iohandler_select_fill() and iohandler_select_poll() to use Poller instead of rfds/wfds/xfds. Signed-off-by: Stefan Hajnoczi --- include/qemu/main-loop.h | 5 +++-- iohandler.c | 33 +++-- main-loop.c | 4 ++-- 3 files changed, 28 in

[Qemu-devel] [PATCH 06/11] slirp: switch to Poller

2013-01-31 Thread Stefan Hajnoczi
Slirp uses rfds/wfds/xfds more extensively than other QEMU components. The rarely-used out-of-band TCP data feature is used. That means we need the full table of select(2) to g_poll(3) events: rfds -> G_IO_IN | G_IO_HUP | G_IO_ERR wfds -> G_IO_OUT | G_IO_ERR xfds -> G_IO_PRI I came up wit

[Qemu-devel] [PULL] virtio,make,pci,e1000,vfio,piix

2013-01-31 Thread Michael S. Tsirkin
The following changes since commit 0893d46014b0300fb8aec92df94effea34d04b61: Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-01-29 16:57:41 -0600) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony for you to fe

Re: [Qemu-devel] [PATCH v2 01/12] host-utils: add ffsl

2013-01-31 Thread Stefan Hajnoczi
On Wed, Jan 16, 2013 at 06:31:08PM +0100, Paolo Bonzini wrote: > We can provide fast versions based on the other functions defined > by host-utils.h. Some care is required on glibc, which provides > ffsl already. > > Signed-off-by: Paolo Bonzini > --- > include/qemu/host-utils.h | 26

[Qemu-devel] [PATCH 02/11] poller: add Poller for growable GPollFD arrays

2013-01-31 Thread Stefan Hajnoczi
QEMU currently uses select(2)-style rfds/wfds/xfds for file descriptor event polling. Unfortunately the underlying fd_set type and its macros (FD_SET()) have a hardcoded maximum for file descriptors. It is possible to exceed this limit so we need a more scalable event polling structure. Poller i

Re: [Qemu-devel] [PATCH 1/4] trace: Fix simple trace dropped event record for big endian

2013-01-31 Thread Laszlo Ersek
On 01/31/13 13:10, Markus Armbruster wrote: > Laszlo Ersek writes: >> On 01/25/13 16:43, Markus Armbruster wrote: >>> @@ -63,7 +63,7 @@ typedef struct { >>> uint64_t timestamp_ns; >>> uint32_t length; /*in bytes */ >>> uint32_t reserved; /*unused */ >>> -uint8_t argum

Re: [Qemu-devel] [PATCH 4/4] trace: Fix location of simpletrace.py in docs

2013-01-31 Thread Harsh Bora
On 01/25/2013 09:13 PM, Markus Armbruster wrote: Missed when commit 4c3b5a48 moved it. Signed-off-by: Markus Armbruster Reviewed-by: Harsh Prateek Bora --- docs/tracing.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/tracing.txt b/docs/tracing.txt index

[Qemu-devel] [PATCH for-1.4] linux-user: Restore cast to target type in get_user()

2013-01-31 Thread Peter Maydell
Commit 658f2dc97 accidentally dropped the cast to the target type of the value loaded by get_user(). The most visible effect of this would be that the sequence "uint64_t v; get_user_u32(v, addr)" would sign extend the 32 bit loaded value into v rather than zero extending as would be expected for a

Re: [Qemu-devel] [PATCH 3/4] trace: Clean up the "try to update atomic until it worked" loops

2013-01-31 Thread Harsh Bora
On 01/25/2013 09:13 PM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- trace/simple.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) Reviewed-by: Harsh Prateek Bora diff --git a/trace/simple.c b/trace/simple.c index 592ff48..74701e3 100644 --- a

Re: [Qemu-devel] [kvmarm] [RFC v5 7/8] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC

2013-01-31 Thread Andreas Färber
Am 31.01.2013 11:52, schrieb KONRAD Frédéric: > On 24/01/2013 16:43, Peter Maydell wrote: >> Implement support for using the KVM in-kernel GIC for ARM. >> >> Signed-off-by: Peter Maydell >> --- >> hw/a15mpcore.c |8 ++- >> hw/arm/Makefile.objs |1 + >> hw/kvm/arm_gic.c | 169

Re: [Qemu-devel] QEMU buildbot maintenance state

2013-01-31 Thread Stefan Hajnoczi
On Wed, Jan 30, 2013 at 10:31:22AM +0100, Gerd Hoffmann wrote: > Hi, > > > Gerd: Are you willing to co-maintain the QEMU buildmaster with Daniel > > and Christian? It would be awesome if you could do this given your > > experience running and customizing buildbot. > > I'll try to set aside som

Re: [Qemu-devel] QEMU buildbot maintenance state

2013-01-31 Thread Stefan Hajnoczi
On Wed, Jan 30, 2013 at 10:31:22AM +0100, Gerd Hoffmann wrote: > Hi, > > > Gerd: Are you willing to co-maintain the QEMU buildmaster with Daniel > > and Christian? It would be awesome if you could do this given your > > experience running and customizing buildbot. > > I'll try to set aside som

Re: [Qemu-devel] [PATCH 02/11] poller: add Poller for growable GPollFD arrays

2013-01-31 Thread Anthony Liguori
Stefan Hajnoczi writes: > QEMU currently uses select(2)-style rfds/wfds/xfds for file descriptor > event polling. Unfortunately the underlying fd_set type and its macros > (FD_SET()) have a hardcoded maximum for file descriptors. It is > possible to exceed this limit so we need a more scalable

Re: [Qemu-devel] QEMU buildbot maintenance state

2013-01-31 Thread Christian Berendt
On 01/31/2013 01:54 PM, Stefan Hajnoczi wrote: I sent a pull request that makes the BuildFactory definitions simpler using a single create_build_factory() function: https://github.com/b1-systems/buildbot/pull/1 Stefan, I'll have a look later this day. Christian. -- Christian Berendt Tel.: +4

Re: [Qemu-devel] RFC migration of zero pages

2013-01-31 Thread Peter Lieven
RFC patch is attached. Comments appreciated. I have two concerns left: a) what happens if a page turns from zero to non-zero in the first stage. Is this page transferred in the same round or in the next? b) what happens if live migration fails or is aborted and then again a migration is started to

Re: [Qemu-devel] [PATCH] vmdk: Allow space in file name

2013-01-31 Thread Stefan Hajnoczi
On Tue, Jan 29, 2013 at 10:50:31PM +0100, Philipp Hahn wrote: > The previous scanf() format string stopped parsing the file name on the > first white white space, which seems to be allowed at least by VMware > Wokrstation. > > Change the format string to collect everything between the first and >

Re: [Qemu-devel] [PATCH] Fix monitor 'info registers' command on multi processor guests

2013-01-31 Thread Erlon Cruz
On 01/31/2013 07:51 AM, Markus Armbruster wrote: > "Erlon Cruz" writes: > >> QEMU monitor command 'info registers' only displays information for the first >> CPU. This fix that by show registers information for each CPU in the system > This is incorrect. It displays information for the *current*

Re: [Qemu-devel] [PATCH] Fix monitor 'info registers' command on multi processor guests

2013-01-31 Thread Erlon Cruz
On 01/31/2013 09:33 AM, Luiz Capitulino wrote: > On Thu, 31 Jan 2013 10:51:10 +0100 > Markus Armbruster wrote: > >> "Erlon Cruz" writes: >> >>> QEMU monitor command 'info registers' only displays information for the >>> first >>> CPU. This fix that by show registers information for each CPU in t

[Qemu-devel] traversal termination in qbus_find_recursive() due to "max_dev"

2013-01-31 Thread Laszlo Ersek
Hi, I'm working on propagating errors out to do_device_add(). I've come accross qbus_find_recursive(). Re commit 1395af6f ("qdev: add a maximum device allowed field for the bus."), could someone please explain: (1) why the early termination due to max_index vs. max_dev merits an error message --

Re: [Qemu-devel] [PATCH V4 00/22] Multiqueue virtio-net

2013-01-31 Thread Eric Blake
On 01/31/2013 12:00 AM, Jason Wang wrote: > On 01/31/2013 02:29 AM, Eric Blake wrote: >> On 01/30/2013 04:12 AM, Jason Wang wrote: >> >>> With this changes, user could start a multiqueue virtio-net device through >>> >>> ./qemu -netdev tap,id=hn0,queues=2,vhost=on -device >>> virtio-net-pci,netdev

[Qemu-devel] [PATCH for-1.4 v2] target-ppc: Fix target_ulong vs. hwaddr format mismatches

2013-01-31 Thread Andreas Färber
Since HWADDR_PRIx is always the same now, use %016 for TARGET_PPC64 and %08 for common code. This may slightly change the ppc64 debug output. Signed-off-by: Andreas Färber --- target-ppc/mmu_helper.c |6 +++--- 1 Datei geändert, 3 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/tar

Re: [Qemu-devel] traversal termination in qbus_find_recursive() due to "max_dev"

2013-01-31 Thread KONRAD Frédéric
On 31/01/2013 14:23, Laszlo Ersek wrote: Hi, I'm working on propagating errors out to do_device_add(). I've come accross qbus_find_recursive(). Re commit 1395af6f ("qdev: add a maximum device allowed field for the bus."), could someone please explain: (1) why the early termination due to max_i

Re: [Qemu-devel] [PATCH V4 00/22] Multiqueue virtio-net

2013-01-31 Thread Michael S. Tsirkin
On Thu, Jan 31, 2013 at 06:44:49AM -0700, Eric Blake wrote: > On 01/31/2013 12:00 AM, Jason Wang wrote: > > On 01/31/2013 02:29 AM, Eric Blake wrote: > >> On 01/30/2013 04:12 AM, Jason Wang wrote: > >> > >>> With this changes, user could start a multiqueue virtio-net device through > >>> > >>> ./qe

Re: [Qemu-devel] [PATCH v3 0/5] XBZRLE fixes

2013-01-31 Thread Eric Blake
On 01/31/2013 12:12 AM, Orit Wasserman wrote: > Changes for V3: > Fix year in xbzrle.c copyright notice > Add copyright notice to test-xbzrle.c, use stack variable > for 2 byte array and fix spacing. > > This series add some testing to the XBZRLE compression > and fixes the error in loading a gues

Re: [Qemu-devel] [PATCH v3 1/5] Move XBZRLE encoding code to a separate file to allow testing

2013-01-31 Thread Eric Blake
On 01/31/2013 12:12 AM, Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > Reviewed-by: Paolo Bonzini > --- > Makefile.objs | 2 +- > savevm.c | 159 - > xbzrle.c | 173 > +++

Re: [Qemu-devel] RFC migration of zero pages

2013-01-31 Thread Peter Lieven
Am 31.01.2013 um 14:59 schrieb Avi Kivity : > > On Jan 31, 2013 12:29 PM, "Orit Wasserman" wrote: > > > > On 01/31/2013 11:48 AM, Gleb Natapov wrote: > > > On Thu, Jan 31, 2013 at 09:47:24AM +0200, Orit Wasserman wrote: > > >> On 01/31/2013 08:57 AM, Peter Lieven wrote: > > >>> Hi, > > >>> > >

Re: [Qemu-devel] [PATCH V4 00/22] Multiqueue virtio-net

2013-01-31 Thread Michael S. Tsirkin
On Wed, Jan 30, 2013 at 07:12:19PM +0800, Jason Wang wrote: > Hello all: > > This seires is an update of last version of multiqueue virtio-net support. > > This series tries to brings multiqueue support to virtio-net through a > multiqueue support tap backend and multiple vhost threads. > > Patc

Re: [Qemu-devel] [PATCH V17 03/10] libqblock: build: add configure support

2013-01-31 Thread Stefan Hajnoczi
On Thu, Jan 31, 2013 at 04:53:43PM +0800, Wenchao Xia wrote: > +## > +# libqblock probe > +if test "$libqblock" != "no"; then > +if test -n "$libtool" && > +$pkg_config --atleast-version=$glib_req_ver glib-2.0 > /dev/null > 2>&1 && \ > +

Re: [Qemu-devel] [PATCH for-1.4] linux-user: Restore cast to target type in get_user()

2013-01-31 Thread Laurent Desnogues
On Thu, Jan 31, 2013 at 1:50 PM, Peter Maydell wrote: > Commit 658f2dc97 accidentally dropped the cast to the target type of > the value loaded by get_user(). The most visible effect of this would > be that the sequence "uint64_t v; get_user_u32(v, addr)" would sign > extend the 32 bit loaded val

Re: [Qemu-devel] RFC migration of zero pages

2013-01-31 Thread Gleb Natapov
On Thu, Jan 31, 2013 at 03:59:23PM +0200, Avi Kivity wrote: > On Jan 31, 2013 12:29 PM, "Orit Wasserman" wrote: > > > > On 01/31/2013 11:48 AM, Gleb Natapov wrote: > > > On Thu, Jan 31, 2013 at 09:47:24AM +0200, Orit Wasserman wrote: > > >> On 01/31/2013 08:57 AM, Peter Lieven wrote: > > >>> Hi, >

Re: [Qemu-devel] [PATCH V4 00/22] Multiqueue virtio-net

2013-01-31 Thread Michael S. Tsirkin
On Thu, Jan 31, 2013 at 04:21:49PM +0200, Michael S. Tsirkin wrote: > On Wed, Jan 30, 2013 at 07:12:19PM +0800, Jason Wang wrote: > > Hello all: > > > > This seires is an update of last version of multiqueue virtio-net support. > > > > This series tries to brings multiqueue support to virtio-net

Re: [Qemu-devel] [PATCH V17 04/10] libqblock: build: add rule for libqblock.la

2013-01-31 Thread Stefan Hajnoczi
On Thu, Jan 31, 2013 at 04:53:44PM +0800, Wenchao Xia wrote: > diff --git a/libqblock/Makefile b/libqblock/Makefile > index 8173da7..a6be721 100644 > --- a/libqblock/Makefile > +++ b/libqblock/Makefile > @@ -1,4 +1,29 @@ > all: libqblock.la > > -libqblock.la: > - @true > +# objects linked in

[Qemu-devel] [PATCH for-1.4 v2] block/raw-posix: Build fix for O_ASYNC

2013-01-31 Thread Andreas Färber
Commit eeb6b45d48800e96f67ef2a5c80332557fd45ddb (block: raw-posix image file reopen) broke the build on OpenIndiana. illumos has no O_ASYNC. Exclude it from flags to be compared and instead assert that it is not set where defined. Cf. e61ab1da7e98357da47c54d8f893b9bd6ff2f7f9 for qemu-ga. Cc: qem

Re: [Qemu-devel] RFC migration of zero pages

2013-01-31 Thread Gleb Natapov
On Thu, Jan 31, 2013 at 04:36:25PM +0200, Avi Kivity wrote: > On Thu, Jan 31, 2013 at 4:30 PM, Gleb Natapov wrote: > >> > > >> > Avi/Michael do you remember why mincore can't be used to check if a guest > >> page is unmapped? > >> > >> A page may be not in core, but also nonzero (for example swap)

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 4/5] connection-setup code between client/server

2013-01-31 Thread Michael R. hines
I was wondering about that possibility myself, I'll give this a try (along with the other comments). Thanks, - Michael On 01/31/2013 05:51 AM, Orit Wasserman wrote: Hi Michael, It will be cleaner to create a new file migration-rdma.c and put all the RDMA logic into it, this way you won't effec

Re: [Qemu-devel] [PATCH V4 00/22] Multiqueue virtio-net

2013-01-31 Thread Jason Wang
On 01/31/2013 09:44 PM, Eric Blake wrote: > On 01/31/2013 12:00 AM, Jason Wang wrote: >> On 01/31/2013 02:29 AM, Eric Blake wrote: >>> On 01/30/2013 04:12 AM, Jason Wang wrote: >>> With this changes, user could start a multiqueue virtio-net device through ./qemu -netdev tap,id=hn0,qu

Re: [Qemu-devel] [PATCH V4 00/22] Multiqueue virtio-net

2013-01-31 Thread Jason Wang
On 01/31/2013 10:36 PM, Michael S. Tsirkin wrote: > On Thu, Jan 31, 2013 at 04:21:49PM +0200, Michael S. Tsirkin wrote: >> On Wed, Jan 30, 2013 at 07:12:19PM +0800, Jason Wang wrote: >>> Hello all: >>> >>> This seires is an update of last version of multiqueue virtio-net support. >>> >>> This serie

[Qemu-devel] [PATCH for-1.4?] target-i386: Pass X86CPU to cpu_x86_set_a20()

2013-01-31 Thread Andreas Färber
Prepares for cpu_interrupt() changing argument to CPUState. While touching it, rename to x86_cpu_...() now that it takes an X86CPU. Signed-off-by: Andreas Färber --- Extracted from my qom-cpu-8 queue. hw/pc.c |7 --- target-i386/cpu.h|2 +- target-i386/helper.c |

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 5/5] send memory over RDMA as blocks are iterated

2013-01-31 Thread Michael R. hines
Yes, I was hoping for a comment about this in particular (before I send out another patchest with the proper coverletter and so forth). So here's the problem I was experiencing inside savevm.c, qemu_loadvm_state(): I was having a little trouble serializing the client/server protocol in my br

Re: [Qemu-devel] [PATCH] Fix monitor 'info registers' command on multi processor guests

2013-01-31 Thread Luiz Capitulino
On Thu, 31 Jan 2013 05:12:25 -0800 "Erlon Cruz" wrote: > Legal Disclaimer: > The information contained in this message may be privileged and confidential. > It is intended to be read only by the individual or entity to whom it is > addressed or by their designee. If the reader of this message i

Re: [Qemu-devel] RFC migration of zero pages

2013-01-31 Thread Michael R. hines
What about using the linux pagemap? With RDMA, I have exactly this problem. The cost of mapping and faulting and checking for zeros is higher than the cost of simply dumping the page into remote memory on the server side. If we could avoid accessing the page, it was save huge amounts of time.

Re: [Qemu-devel] [PATCH V4 00/22] Multiqueue virtio-net

2013-01-31 Thread Eric Blake
On 01/31/2013 06:58 AM, Michael S. Tsirkin wrote: >>> For hotplug, it just work if you pass multiple file descriptors one by >>> one through getfd and then use fds=X:Y,vhostfds=M:N. >> >> For hotplug, you can't pass integers; you have to name the fds either >> way. Either you name it with getfd,

Re: [Qemu-devel] [PATCH for-1.4 0/2] target-s390x: CPU cleanups preparing for 1.5

2013-01-31 Thread Andreas Färber
Am 30.01.2013 23:48, schrieb Andreas Färber: > As a reminder here's a link to one of my original discussions of the new > types: > https://lists.nongnu.org/archive/html/qemu-devel/2012-05/msg01286.html > > That is, for any non-TCG functions (TCG does not support CPUState yet) an > S390CPU argumen

Re: [Qemu-devel] [PATCH 2/2] usb-ehci: add Faraday FUSBH200 support

2013-01-31 Thread Andreas Färber
Am 30.01.2013 01:44, schrieb Kuo-Jung Su: > > 2013/1/29 Andreas Färber mailto:afaer...@suse.de>> > > Gerd, what are your thoughts? If Kuo-Jung doesn't mind, I would offer to > send a v2 implementing the changes I suggested in the way you prefer. > > > Don't worry about me, I'm O.K to an

[Qemu-devel] [RFC 1/2] qbus_find_recursive(): don't abort search for named bus on full bus node

2013-01-31 Thread Laszlo Ersek
The bus we're looking for could be in the sub-tree rooted at the node being checked; don't skip looping over the children. Signed-off-by: Laszlo Ersek --- hw/qdev-monitor.c | 10 +- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c ind

  1   2   3   >