Re: [Qemu-devel] [PATCH 06/15] s390: Add channel I/O instructions.

2013-01-26 Thread Andreas Färber
Am 25.01.2013 20:53, schrieb Blue Swirl: > On Fri, Jan 25, 2013 at 7:28 PM, Alexander Graf wrote: >> The memory API is CPU agnostic today, and the special case here is that >> bytes [0..8192] are a CPU specific map. > > Each CPU should have a private address space managed by it. The areas > whic

Re: [Qemu-devel] [RFC] FDT as a git submodule?

2013-01-26 Thread Alexander Graf
Am 26.01.2013 um 03:05 schrieb Peter Crosthwaite : > Hi All, > > For us CONFIG_FDT is compulsory, we cannot build a sensible QEMU > without it. To make the build for us a little more user friendly could > we add it as a git submodule the same way as its handled for pixman? > By default FDT is n

Re: [Qemu-devel] [RFC] FDT as a git submodule?

2013-01-26 Thread Andreas Färber
Am 26.01.2013 10:13, schrieb Alexander Graf: > > Am 26.01.2013 um 03:05 schrieb Peter Crosthwaite > : > >> For us CONFIG_FDT is compulsory, we cannot build a sensible QEMU >> without it. To make the build for us a little more user friendly could >> we add it as a git submodule the same way as it

Re: [Qemu-devel] [RFC] FDT as a git submodule?

2013-01-26 Thread Peter Maydell
On 26 January 2013 10:11, Andreas Färber wrote: > You forget that a "distro" is pretty much a Linux concept. There is no > such thing on W32 (openSUSE doesn't package it for MinGW either), and on > Darwin the various competing ports systems suck IMO. > > On OpenBSD there's a "dtc" port but we'd ne

Re: [Qemu-devel] [PATCH] linux-user: convert /proc/net/route when endianess differs

2013-01-26 Thread Laurent Vivier
Le mercredi 02 janvier 2013 à 00:08 +0100, Laurent Vivier a écrit : > Ping ! ping > Le jeudi 20 décembre 2012 à 21:53 +0100, Laurent Vivier a écrit : > > This patch allows to have IP addresses in correct order > > in the case of "netstat -nr" when the endianess of the > > guest differs from one o

Re: [Qemu-devel] [PATCH] linux-user: correctly align types in thunking code

2013-01-26 Thread Laurent Vivier
Le mercredi 02 janvier 2013 à 00:08 +0100, Laurent Vivier a écrit : > Ping ! ping > Le jeudi 20 décembre 2012 à 21:55 +0100, Laurent Vivier a écrit : > > This is a follow up > > of patch: > > > > commit c2e3dee6e03527baf8698698cce76b1a3174969a > > Author: Laurent Vivier > >

Re: [Qemu-devel] [PATCH][v3] linux-user: correct semctl() and shmctl()

2013-01-26 Thread Laurent Vivier
Ping Le lundi 21 janvier 2013 à 07:25 +0100, Laurent Vivier a écrit : > The parameter "union semun" of semctl() is not a value > but a pointer to the value. > > Moreover, all fields of target_su must be swapped (if needed). > > The third argument of shmctl is a pointer. > > WITHOUT this patch:

Re: [Qemu-devel] [PATCH] linux-user: correct msgrcv()

2013-01-26 Thread Laurent Vivier
Ping Le dimanche 20 janvier 2013 à 00:29 +0100, Laurent Vivier a écrit : > Le mercredi 02 janvier 2013 à 00:03 +, Peter Maydell a écrit : > > On 20 December 2012 21:00, Laurent Vivier wrote: > > > All parameters must be swapped before the call of do_msgrcv(). > > > --- a/linux-user/syscall.c

Re: [Qemu-devel] [PATCH] linux-user: correct print_timeval() swap tv_sec and tv_usec

2013-01-26 Thread Laurent Vivier
ping Le lundi 31 décembre 2012 à 20:45 +0100, Laurent Vivier a écrit : > From: Laurent Vivier > > Signed-off-by: Laurent Vivier > --- > linux-user/strace.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux-user/strace.c b/linux-user/strace.c > index 6ec90e8..4e

Re: [Qemu-devel] [PATCH][v2] linux-user: correct setsockopt()

2013-01-26 Thread Laurent Vivier
Le dimanche 20 janvier 2013 à 00:32 +0100, Laurent Vivier a écrit : > ping ? ping > Le mardi 01 janvier 2013 à 19:24 +0100, Laurent Vivier a écrit : > > From: Laurent Vivier > > > > SO_SNDTIMEO and SO_RCVTIMEO take a struct timeval, not an int > > > > To test this, you can use : > > > > QEMU_

Re: [Qemu-devel] [PATCH][v2] linux-user: correct reboot()

2013-01-26 Thread Laurent Vivier
ping Le dimanche 20 janvier 2013 à 00:26 +0100, Laurent Vivier a écrit : > Le lundi 07 janvier 2013 à 21:46 +, Peter Maydell a écrit : > > On 7 January 2013 21:40, Laurent Vivier wrote: > > > According to man reboot(2), the 4th argument is only used with > > > LINUX_REBOOT_CMD_RESTART2. In ot

Re: [Qemu-devel] [PATCH][v2] linux-user: correct setsockopt()

2013-01-26 Thread Peter Maydell
On 1 January 2013 18:24, Laurent Vivier wrote: > From: Laurent Vivier > > SO_SNDTIMEO and SO_RCVTIMEO take a struct timeval, not an int > > To test this, you can use : > > QEMU_STRACE= ping localhost 2>&1 |grep TIMEO > 568 setsockopt(3,SOL_SOCKET,SO_SNDTIMEO,{1,0},8) = 0 > 568 setsockopt(3,SOL_SO

[Qemu-devel] [PATCH for-1.4 1/6] tests: Fix gcov report for check-q{dict, float, int, string, list, json}

2013-01-26 Thread Andreas Färber
Commit a372823a14461c454feaa86373bd672fd518847a moved the source files to qobject/ subdirectory but forgot to update tests/Makefile: GTESTER tests/check-qdict Gcov report for qdict.c: ./qdict.gcno:cannot open graph file GTESTER tests/check-qfloat Gcov report for qfloat.c: ./qfloat.gcno

Re: [Qemu-devel] [PATCH 06/15] s390: Add channel I/O instructions.

2013-01-26 Thread Blue Swirl
On Fri, Jan 25, 2013 at 8:50 PM, Alexander Graf wrote: > > On 25.01.2013, at 20:53, Blue Swirl wrote: > >> On Fri, Jan 25, 2013 at 7:28 PM, Alexander Graf wrote: >>> >>> On 25.01.2013, at 20:20, Blue Swirl wrote: >>> On Fri, Jan 25, 2013 at 12:48 PM, Alexander Graf wrote: > From: Cornel

Re: [Qemu-devel] [PATCH 06/15] s390: Add channel I/O instructions.

2013-01-26 Thread Blue Swirl
On Sat, Jan 26, 2013 at 8:02 AM, Andreas Färber wrote: > Am 25.01.2013 20:53, schrieb Blue Swirl: >> On Fri, Jan 25, 2013 at 7:28 PM, Alexander Graf wrote: >>> The memory API is CPU agnostic today, and the special case here is that >>> bytes [0..8192] are a CPU specific map. >> >> Each CPU shoul

[Qemu-devel] [PATCH for-1.4 2/6] tests: Fix gcov report for test-iov

2013-01-26 Thread Andreas Färber
Commit baacf04799ace72a9c735dd9306a1ceaf305e7cf moved iov.c to util/ subdirectory but forgot to update tests/Makefile, resulting in: Gcov report for iov.c: ./iov.gcno:cannot open graph file Fix this by supplying the new path. Cc: Paolo Bonzini Signed-off-by: Andreas Färber --- tests/Makef

[Qemu-devel] [PATCH for-1.4 5/6] tests: Add gcov support for x86_64 qtest

2013-01-26 Thread Andreas Färber
Since x86_64 is a superset of i386 and reuses all its test cases, adopt all the i386 gcov source files as well, substituting their paths appropriately. Signed-off-by: Andreas Färber --- tests/Makefile |1 + 1 Datei geändert, 1 Zeile hinzugefügt(+) diff --git a/tests/Makefile b/tests/Makefil

Re: [Qemu-devel] [PATCH] linux-user: correct print_timeval() swap tv_sec and tv_usec

2013-01-26 Thread Peter Maydell
On 31 December 2012 19:45, Laurent Vivier wrote: > From: Laurent Vivier > > Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [FYI] pixman on OS X ppc

2013-01-26 Thread Andreas Färber
To whom it may concern: In order to get pixman and thus QEMU building on OSX v10.5.8 ppc, I needed to take the following steps: Download stable pixman tarball and patch pixman as follows: --- pixman-0.28.0/pixman/pixman-ppc.c.orig 2013-01-26 12:17:03.0 +0100 +++ pixman-0.28.0/pixman

Re: [Qemu-devel] [PATCH for-1.4 qom-cpu 0/9] target-i386: Fix APIC-ID-based topology (v5)

2013-01-26 Thread Andreas Färber
Am 22.01.2013 21:25, schrieb Eduardo Habkost: > Eduardo Habkost (9): > kvm: Create kvm_arch_vcpu_id() function > target-i386: kvm: Set vcpu_id to APIC ID instead of CPU index > fw_cfg: Remove FW_CFG_MAX_CPUS from fw_cfg_init() > target-i386/cpu: Introduce x86_cpu_apic_id_from_index() functi

Re: [Qemu-devel] [PATCH V2 2/6] hw/mdio: Generalize etraxfs MDIO bitbanging emulation (fwd)

2013-01-26 Thread Andreas Färber
Am 25.01.2013 19:00, schrieb Paul Brook: >> 1. It's not point-to-point, has an arbitrary nr of connection points. > > QoM currently only does asymmetric 1-1 connections between objects. However > I > don't think this is a fatal problem. We can still retain an asymmetric API > (effectively equ

[Qemu-devel] [PATCH for-1.4 4/6] tests: Add gcov support for sparc64 qtest

2013-01-26 Thread Andreas Färber
m48t59-test is individually being executed for sparc and sparc64, so add the gcov source file for sparc64 as well. Signed-off-by: Andreas Färber --- tests/Makefile |1 + 1 Datei geändert, 1 Zeile hinzugefügt(+) diff --git a/tests/Makefile b/tests/Makefile index a4cc554..a6341f2 100644 --- a

[Qemu-devel] [RFC 6/6] tests: Workaround gcov being unable to open .gcda file

2013-01-26 Thread Andreas Färber
Resolve the following error: hw/tmp105.gcda:cannot open data file, assuming not executed by adding a sleep before running gcov after the qtest cases. Signed-off-by: Andreas Färber --- tests/Makefile |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/tests/

[Qemu-devel] [PATCH for-1.4 0/6] Various gcov fixes for 1.4

2013-01-26 Thread Andreas Färber
Hello Blue, Following the discussion with Eduardo about target-i386/topology.h coverage, I have set up a gcov build and fixed a few issues I noticed: * gcov breakages introduced when moving covered source files around * typo from merging my tmp105 qtest case * error fix for my tmp105 test case (n

[Qemu-devel] [PATCH for-1.4 3/6] tests: Fix gcov typo for tmp105-test

2013-01-26 Thread Andreas Färber
Commit 6e9989034b176a8e4cfdccd85892abfa73977ba7 introduced a new qtest test case but misspelled gcov, leading to no coverage analysis. Fix it. Signed-off-by: Andreas Färber --- tests/Makefile |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/tests/Makefile b/

[Qemu-devel] [PATCH] hw/vexpress: Use correct HBI (board model number) for vexpress-a15

2013-01-26 Thread Peter Maydell
The vexpress-a15 QEMU model is supposed to be a V2P-CA15; the HBI (a kind of board model number) for this coretile is 237, not 217. Signed-off-by: Peter Maydell --- The only effect of this bug I know of is that kernels using a device tree will yell at you if the HBI doesn't match the one in the d

Re: [Qemu-devel] [PATCH 00/57] target-i386 eflags cleanup and bmi/adx extensions

2013-01-26 Thread Laurent Desnogues
On Thu, Jan 24, 2013 at 9:37 PM, Richard Henderson wrote: > On 01/24/2013 08:57 AM, Laurent Desnogues wrote: >> >> On Thu, Jan 24, 2013 at 5:52 PM, Richard Henderson >> wrote: >>> >>> On 2013-01-24 08:46, Laurent Desnogues wrote: I gave a quick try a your branch. My host is an x86_

[Qemu-devel] [PATCH for-1.4] block/raw-posix: Build fix for O_ASYNC

2013-01-26 Thread Andreas Färber
Commit eeb6b45d48800e96f67ef2a5c80332557fd45ddb (block: raw-posix image file reopen) broke the build on OpenIndiana. illumos has no O_ASYNC. Exclude it from flags to be compared and use I_SETSIG ioctl after newly opening file. Cf. e61ab1da7e98357da47c54d8f893b9bd6ff2f7f9 for qemu-ga. Cc: qemu-st

Re: [Qemu-devel] [PULL 00/15] s390 patch queue 2013-01-25

2013-01-26 Thread Blue Swirl
On Fri, Jan 25, 2013 at 12:48 PM, Alexander Graf wrote: > Hi Blue / Aurelien, > > This is my current patch queue for s390. Please pull. > > Alex > > > The following changes since commit 11c29918be32be5b00f367c7da9724a5cddbbb0f: > Anthony Liguori (1): > Merge remote-tracking branch 'bonz

[Qemu-devel] [PATCH for-1.4] tests: Fix {rtc, m48t59}-test build on illumos

2013-01-26 Thread Andreas Färber
Struct tm does not have tm_gmtoff field on illumos. Fix the build by not zero-initializing these fields on Solaris. Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber --- tests/m48t59-test.c |2 ++ tests/rtc-test.c|2 ++ 2 Dateien geändert, 4 Zeilen hinzugefügt(+) diff --git a

[Qemu-devel] hd-geo-test failing on OpenIndiana

2013-01-26 Thread Andreas Färber
Hello Markus, On OpenIndiana 151a7 I am seeing assertion failures for ret == 0 in hd-geo-test.c:35:create_test_img(). It seems it is refusing to blow up the temporary file. Any suggestion what to do about that? Regards, Andreas

Re: [Qemu-devel] [PATCH] tests: adjust gcov variables for directory movement

2013-01-26 Thread Blue Swirl
Thanks, applied. On Tue, Jan 15, 2013 at 8:49 AM, Paolo Bonzini wrote: > I had missed the introduction of the gcov-files-* variables. > > Cc: Blue Swirl > Signed-off-by: Paolo Bonzini > --- > Blue, can you look at introducing a common variable for the coroutine > backend? Like

Re: [Qemu-devel] [PATCH] link seccomp only with softmmu targets

2013-01-26 Thread Blue Swirl
Thanks, applied. On Sat, Jan 19, 2013 at 2:58 PM, Michael Tokarev wrote: > Now, if seccomp is detected, it is linked into every executable, > but is used only by softmmu targets (from vl.c). So link it > only where it is actually needed. > > Signed-off-by: Michael Tokarev > --- > configure |

Re: [Qemu-devel] [PATCH 1/4] build: move around libcacard-y definition

2013-01-26 Thread Blue Swirl
Thanks, applied all. On Sat, Jan 19, 2013 at 10:06 AM, Paolo Bonzini wrote: > It is also needed if !CONFIG_SOFTMMU, unlike everything that surrounds it. > Signed-off-by: Paolo Bonzini > --- > Makefile.objs | 18 +- > 1 files changed, 9 insertions(+), 9 deletions(-) > > diff --

Re: [Qemu-devel] [PATCH v2] softfloat: Handle float_muladd_negate_c when product is zero

2013-01-26 Thread Blue Swirl
Thanks, applied. On Tue, Jan 22, 2013 at 5:03 PM, Richard Sandiford wrote: > Honour float_muladd_negate_c in the case where the product is zero and > c is nonzero. Previously we would fail to negate c. > > Seen in (and tested against) the gfortran testsuite on MIPS. > > Signed-off-by: Richard Sa

Re: [Qemu-devel] [PATCH 0/6] arm devices: mark or remove implicit fallthroughs

2013-01-26 Thread Blue Swirl
Thanks, applied all. On Mon, Jan 21, 2013 at 12:50 PM, Peter Maydell wrote: > These patches either mark implicit fallthroughs in case statements > or (in a few cases) remove them by putting in an explicit 'break' > or 'return' rather than relying on the one in the following case. > There is no be

Re: [Qemu-devel] [PATCH 0/2] fw_cfg: Splash image loader can overrun a stack variable

2013-01-26 Thread Blue Swirl
Thanks, applied both. On Wed, Jan 23, 2013 at 5:25 PM, Markus Armbruster wrote: > Casting pointers considered harmful, film at eleven. > > Markus Armbruster (2): > fw_cfg: Splash image loader can overrun a stack variable, fix > fw_cfg: Drop a few superfluous initializers > > hw/fw_cfg.c

Re: [Qemu-devel] [PATCH RESEND for-1.4] make_device_config.sh: Fix target path in generated dependency file

2013-01-26 Thread Blue Swirl
Thanks, applied. On Thu, Jan 24, 2013 at 3:47 PM, Andreas Färber wrote: > config-devices.mak.d is included from Makefile.target, i.e. from inside > the *-softmmu/ directory. It included the directory path, so never > applied to the actual ./config-devices.mak. Symptoms were spurious > build failu

Re: [Qemu-devel] [PATCH for-1.4] qemu-char: Avoid unused variable warning in some configs

2013-01-26 Thread Blue Swirl
Thanks, applied. On Thu, Jan 24, 2013 at 4:14 PM, Peter Maydell wrote: > Avoid unused variable warnings: > qemu-char.c: In function 'qmp_chardev_open_port': > qemu-char.c:3132: warning: unused variable 'fd' > qemu-char.c:3132: warning: unused variable 'flags' > > in configurations with neither HA

Re: [Qemu-devel] [PATCH for-1.4] hw/arm_boot: Align device tree to 4KB boundary, not page

2013-01-26 Thread Blue Swirl
Thanks, applied. On Thu, Jan 24, 2013 at 7:02 PM, Peter Maydell wrote: > Align the device tree blob to a 4KB boundary, not to QEMU's > idea of a page boundary -- the latter is the smallest possible > page size for the architecture, which on ARM is 1KB. > The documentation for Linux does not impos

Re: [Qemu-devel] [PATCH] build: remove *.lo, *.a, *.la files from all subdirectories on make clean

2013-01-26 Thread Blue Swirl
Thanks, applied. On Tue, Jan 15, 2013 at 8:49 AM, Paolo Bonzini wrote: > .lo files in stubs/, util/ and libcacard/ were not cleaned. > Fix this. > > Cc: Blue Swirl > Reported-by: Stefan Hajnoczi > Signed-off-by: Paolo Bonzini > --- > Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 d

Re: [Qemu-devel] [PATCH v2] vmware_vga: fix out of bounds and invalid rects updating

2013-01-26 Thread Blue Swirl
Thanks, applied. On Fri, Jan 25, 2013 at 5:23 PM, Michael Tokarev wrote: > This is a follow up for several attempts to fix this issue. > > Previous incarnations: > > 1. http://thread.gmane.org/gmane.linux.ubuntu.bugs.general/3156089 > https://bugs.launchpad.net/bugs/918791 > "qemu-kvm dies when u

Re: [Qemu-devel] [PATCH for-1.4 0/6] Various gcov fixes for 1.4

2013-01-26 Thread Blue Swirl
Thanks, applied patches 3 to 5. 1 & 2 were fixed by Paolo's patch. On Sat, Jan 26, 2013 at 11:45 AM, Andreas Färber wrote: > Hello Blue, > > Following the discussion with Eduardo about target-i386/topology.h coverage, > I have set up a gcov build and fixed a few issues I noticed: > > * gcov break

Re: [Qemu-devel] [PULL 00/21] ppc patch queue 2013-01-25

2013-01-26 Thread Blue Swirl
On Fri, Jan 25, 2013 at 1:47 PM, Alexander Graf wrote: > > On 25.01.2013, at 14:40, Andreas Färber wrote: > >> Am 25.01.2013 13:52, schrieb Alexander Graf: >>> Hi Blue / Aurelien, >>> >>> This is my current patch queue for ppc. Please pull. >>> >>> Alex >>> >>> >>> The following changes since com

Re: [Qemu-devel] [PATCH 4/5] target-i386: set custom features/properties without intermediate x86_def_t

2013-01-26 Thread Andreas Färber
Am 21.01.2013 15:06, schrieb Igor Mammedov: > Move custom features parsing after built-in cpu_model defaults are set > and set custom features directly on CPU instance. That allows to make > clear distinction between built-in cpu model defaults that eventually > should go into clas_init() and extra

Re: [Qemu-devel] [PATCH qom-cpu 0/5 v2] x86 CPU cleanup, part 4

2013-01-26 Thread Andreas Färber
Am 21.01.2013 15:06, schrieb Igor Mammedov: > Igor Mammedov (5): > target-i386: print deprecated warning if xlevel < 0x8000 > target-i386: replace uint32_t vendor fields by vendor string in > x86_def_t > target-i386: remove vendor_override field from CPUX86State > target-i386: set c

Re: [Qemu-devel] [PATCH qom-cpu for-1.4 07/14] target-openrisc: Detect attempt to instantiate non-CPU type in cpu_init()

2013-01-26 Thread Andreas Färber
Am 23.01.2013 13:07, schrieb Andreas Färber: > Consolidate model checking into a new openrisc_cpu_class_by_name(). > > If the name matches an existing type, also check whether that type is > actually (a sub-type of) TYPE_OPENRISC_CPU. > > This fixes, e.g., -cpu open_eth asserting. > > Cc: qemu-s

Re: [Qemu-devel] [PATCH qom-cpu for-1.4 08/14] target-unicore32: Detect attempt to instantiate non-CPU type in cpu_init()

2013-01-26 Thread Andreas Färber
Am 23.01.2013 13:07, schrieb Andreas Färber: > Consolidate model checking into a new uc32_cpu_class_by_name(). > > If the name matches an existing type, also check whether that type is > actually (a sub-type of) TYPE_UNICORE32_CPU. > > This fixes, e.g., -cpu puv3_dma asserting. > > Cc: qemu-sta.

Re: [Qemu-devel] [PATCH qom-cpu for-1.4 03/14] cpu: Add model resolution support to CPUClass

2013-01-26 Thread Andreas Färber
Am 23.01.2013 13:07, schrieb Andreas Färber: > Introduce CPUClass::class_by_name and add a default implementation. [...] > diff --git a/include/qom/cpu.h b/include/qom/cpu.h > index 773caf9..cd0378e 100644 > --- a/include/qom/cpu.h > +++ b/include/qom/cpu.h > @@ -49,6 +49,8 @@ typedef struct CPUCla

Re: [Qemu-devel] [PATCH qom-cpu for-1.4 00/14] QOM CPU fixes for 1.4

2013-01-26 Thread Andreas Färber
Am 23.01.2013 13:07, schrieb Andreas Färber: > Hello, > > This series fixes a number of bugs surrounding QOM CPU instantiation. > Please ack. Ping. > First, two remaining users of type_register_static() for iterative CPU type > registration are moved over to type_register(). TBD: better commit m

[Qemu-devel] [PATCH for-1.4?] usb/hcd-ehci-sysbus: Convert to QOM realizefn

2013-01-26 Thread Andreas Färber
The SysBus qdev initfn merely calls SysBusDeviceClass::init, so we can replace it with a realizefn already. This avoids getting into any initfn ambiguity with the upcoming Faraday EHCI implementation. Signed-off-by: Andreas Färber --- hw/usb/hcd-ehci-sysbus.c | 13 ++--- 1 Datei geände

Re: [Qemu-devel] [RFC] FDT as a git submodule?

2013-01-26 Thread Peter Crosthwaite
Hi All, On Sat, Jan 26, 2013 at 2:49 AM, Peter Maydell wrote: > On 26 January 2013 10:11, Andreas Färber wrote: >> You forget that a "distro" is pretty much a Linux concept. There is no >> such thing on W32 (openSUSE doesn't package it for MinGW either), and on >> Darwin the various competing po

Re: [Qemu-devel] [PATCH v2] cocoa: Fix VBE function Set Display Start

2013-01-26 Thread Andreas Färber
Am 27.11.2012 19:59, schrieb Henry Harrington: > Register a dpy_gfx_setdata callback so that the Cocoa code > is notified whenever the screen start address changes. > > Commit 1d3323d has a similar fix for the VNC UI. > > Signed-off-by: Henry Harrington Thanks, applied to cocoa-for-upstream que

Re: [Qemu-devel] [PATCH for-1.4?] usb/hcd-ehci-sysbus: Convert to QOM realizefn

2013-01-26 Thread Peter Crosthwaite
On Sat, Jan 26, 2013 at 9:27 AM, Andreas Färber wrote: > The SysBus qdev initfn merely calls SysBusDeviceClass::init, so we can > replace it with a realizefn already. This avoids getting into any initfn > ambiguity with the upcoming Faraday EHCI implementation. > > Signed-off-by: Andreas Färber

Re: [Qemu-devel] [PATCH] ui: Replace non-portable asprintf by g_strdup_printf

2013-01-26 Thread Andreas Färber
Am 16.01.2013 18:38, schrieb Stefan Weil: > Signed-off-by: Stefan Weil > --- > > This code is untested because I don't have a Mac available. > Portability is unimportant here (it's only for cocoa), > but I replaced asprintf nevertheless for the sake of > uniformity of QEMU's code. Builds fine. T

Re: [Qemu-devel] [RFC] FDT as a git submodule?

2013-01-26 Thread Alexander Graf
Am 26.01.2013 um 19:13 schrieb Peter Crosthwaite : > Hi All, > > On Sat, Jan 26, 2013 at 2:49 AM, Peter Maydell > wrote: >> On 26 January 2013 10:11, Andreas Färber wrote: >>> You forget that a "distro" is pretty much a Linux concept. There is no >>> such thing on W32 (openSUSE doesn't packa

[Qemu-devel] [PATCH prep for-1.4] prep: Move PReP machine to hw/ppc/

2013-01-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/ppc/Makefile.objs |3 ++- hw/{ppc_prep.c => ppc/prep.c} | 28 ++-- 2 Dateien geändert, 16 Zeilen hinzugefügt(+), 15 Zeilen entfernt(-) rename hw/{ppc_prep.c => ppc/prep.c} (98%) diff --git a/hw/ppc/Makefile.objs b/hw/pp

[Qemu-devel] [QEMU RFC 2/2] xilinx_axienet: Model timing.

2013-01-26 Thread Peter Crosthwaite
Add an artificial delay after receiving a packet to throttle rx traffic. This patch is a non-functional RFC please see the cover letter for discussion. Reported-by: Jason Wu Signed-off-by: Peter Crosthwaite --- hw/xilinx_axienet.c | 16 ++-- 1 file changed, 14 insertions(+), 2 dele

[Qemu-devel] [QEMU RFC 0/2] Spying on Memory to implement ethernet can_recieve()

2013-01-26 Thread Peter Crosthwaite
Hi All, Have a bit of a tricky question about ethernet controllers. We are maintaining two ethernet controllers the cadence GEM and the Xilinx AXI Ethernet both of which are scatter gather (SG) DMA capable. The issue comes about when trying to impelement the can_recieve() function for each. Fo

[Qemu-devel] [PATCH v1 1/3] xilinx_ethlite: fix eth_can_rx() for ping-pong

2013-01-26 Thread Peter Crosthwaite
The eth_can_rx() function only checks the first buffers status ("ping"). The controller should be able to receive into "pong" when ping-pong is enabled. Checks the active buffer (either "ping" or "pong") when determining can_rx() rather than just testing "ping". Signed-off-by: Peter Crosthwaite -

[Qemu-devel] [PATCH v1 3/3] xilinx_ethlite: Debug mode compile fixes

2013-01-26 Thread Peter Crosthwaite
Some printfs are throwing warnings when debug mode is enabled. Fixed. Signed-off-by: Peter Crosthwaite --- hw/xilinx_ethlite.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/xilinx_ethlite.c b/hw/xilinx_ethlite.c index 9463e92..5aeb73e 100644 --- a/hw/xilinx_et

[Qemu-devel] [PATCH v1 0/3] Xilinx Ethernet Lite bugfixes

2013-01-26 Thread Peter Crosthwaite
Small patch queue for ethernet lite. All are bugfixes so should be candidate for 1.4 hard freeze application. Peter Crosthwaite (3): xilinx_ethlite: fix eth_can_rx() for ping-pong xilinx_ethlite: Flush queued packets on SW service xilinx_ethlite: Debug mode compile fixes hw/xilinx_ethlite

[Qemu-devel] [PATCH v1 2/3] xilinx_ethlite: Flush queued packets on SW service

2013-01-26 Thread Peter Crosthwaite
Software services a received packet by clearing the CTRL_S bit in the RX_CTRLn register. If this bit is cleared, flush any packets queued for the device. Reported-by: John Williams Signed-off-by: Peter Crosthwaite --- hw/xilinx_ethlite.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions

[Qemu-devel] [RFC] Writeable files in fw_cfg

2013-01-26 Thread David Woodhouse
For OVMF we really want to have a way to store non-volatile variables, other than the dirty hack that currently puts them on a file in the EFI system partition. It looks like we've supported writing to fw_cfg items fairly much since they were introduced, but we've never actually made use of that.

[Qemu-devel] [QEMU RFC 1/2] cadence_gem: Throttle traffic using buffer state

2013-01-26 Thread Peter Crosthwaite
Under heady RX traffic, GEM just keeps receiving packets and dropping them as fast as possible. Throttle the traffic if GEM is incapable of receiving the packet because there is no valid buffer. This patch is a non-functional RFC please see the cover letter for discussion. Signed-off-by: Peter Cr

[Qemu-devel] [PATCH 3/4] xilinx_axidma: Fix debug mode compile messages

2013-01-26 Thread Peter Crosthwaite
Missing cast one one of the conditionally compiled printfs. Signed-off-by: Peter Crosthwaite --- hw/xilinx_axidma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xilinx_axidma.c b/hw/xilinx_axidma.c index d0ee566..cc51584 100644 --- a/hw/xilinx_axidma.c +++ b/hw/xilinx_a

[Qemu-devel] [PATCH 4/4] qemu/log.h: Fix missing includes

2013-01-26 Thread Peter Crosthwaite
qemu/log.h needs a few bits and pieces from qemu-common to compile. Fixes the case where qemu/log.h is the first files included. Signed-off-by: Peter Crosthwaite --- include/qemu/log.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/qemu/log.h b/include/qemu/log.h index 58f69cb..0a12

[Qemu-devel] [PATCH 1/4] cadence_ttc: Debug mode compile fixes

2013-01-26 Thread Peter Crosthwaite
Some printfs are throwing warnings when debug mode is enabled. Fixed. Signed-off-by: Peter Crosthwaite --- hw/cadence_ttc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/cadence_ttc.c b/hw/cadence_ttc.c index 2a8fadd..67028a3 100644 --- a/hw/cadence_ttc.c +++ b/hw/ca

[Qemu-devel] [PATCH 0/4] Xilinx Trivial Patches

2013-01-26 Thread Peter Crosthwaite
Current queue of trivial patches from the Xilinx tree. Peter Crosthwaite (4): cadence_ttc: Debug mode compile fixes cadence_gem: Debug mode compile fixes xilinx_axidma: Fix debug mode compile messages qemu/log.h: Fix missing includes hw/cadence_gem.c | 17 ++--- hw/cadence_

[Qemu-devel] [PATCH 2/4] cadence_gem: Debug mode compile fixes

2013-01-26 Thread Peter Crosthwaite
Some printfs are throwing warnings when debug mode is enabled. Fixed. Signed-off-by: Peter Crosthwaite --- hw/cadence_gem.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/cadence_gem.c b/hw/cadence_gem.c index 0d83442..b77423d 100644 --- a/hw/cadence_ge

Re: [Qemu-devel] [QEMU RFC 0/2] Spying on Memory to implement ethernet can_recieve()

2013-01-26 Thread Edgar E. Iglesias
On Sat, Jan 26, 2013 at 12:18:29PM -0800, Peter Crosthwaite wrote: > Hi All, > > Have a bit of a tricky question about ethernet controllers. We are > maintaining two ethernet controllers the cadence GEM and the Xilinx AXI > Ethernet both of which are scatter gather (SG) DMA capable. The issue co

Re: [Qemu-devel] [PULL 00/15] s390 patch queue 2013-01-25

2013-01-26 Thread Alexander Graf
On 26.01.2013, at 15:17, Blue Swirl wrote: > On Fri, Jan 25, 2013 at 12:48 PM, Alexander Graf wrote: >> Hi Blue / Aurelien, >> >> This is my current patch queue for s390. Please pull. >> >> Alex >> >> >> The following changes since commit 11c29918be32be5b00f367c7da9724a5cddbbb0f: >> Anthon

Re: [Qemu-devel] [PATCH V2 2/6] hw/mdio: Generalize etraxfs MDIO bitbanging emulation (fwd)

2013-01-26 Thread Edgar E. Iglesias
On Fri, Jan 25, 2013 at 06:00:36PM +, Paul Brook wrote: > > To be able to create generic GPIO devices or other devices that have GPIO > > like pins (e.g MDIO), and hook those up to external buses through common > > frameworks, we need agreement on how to model tristate pins. > > A tristate pin

Re: [Qemu-devel] [PULL 00/15] s390 patch queue 2013-01-25

2013-01-26 Thread Andreas Färber
Am 26.01.2013 22:31, schrieb Alexander Graf: > > On 26.01.2013, at 15:17, Blue Swirl wrote: > >> On Fri, Jan 25, 2013 at 12:48 PM, Alexander Graf wrote: >>> Cornelia Huck (10): >>> s390: Lowcore mapping helper. >>> s390: Add mapping helper functions. >>> s390: Channel I/O basic de

[Qemu-devel] [Bug 893956] Re: qemu-img bug with dynamic vhd

2013-01-26 Thread Bobby Dimmette
qemu-img fails to read a disk2vhd (VHD) image created from a Windows Server 2003. qemu-img will read and convert a VDI image created from that VHD VHD header/footer details: [root@T3400 ]# qemu-img info vhd/p.vhd qemu-img: Could not open 'vhd/p.vhd': File too large [root@T3400 ]# ./vhddum

Re: [Qemu-devel] [PULL 00/15] s390 patch queue 2013-01-25

2013-01-26 Thread Alexander Graf
On 26.01.2013, at 22:46, Andreas Färber wrote: > Am 26.01.2013 22:31, schrieb Alexander Graf: >> >> On 26.01.2013, at 15:17, Blue Swirl wrote: >> >>> On Fri, Jan 25, 2013 at 12:48 PM, Alexander Graf wrote: Cornelia Huck (10): s390: Lowcore mapping helper. s390: Add mappi

[Qemu-devel] [Bug 521202] Re: Windows XP x64 / 2008 Server x64 broken on 32-bit hosts with QEMU > 0.9.0

2013-01-26 Thread Christopher Yeleighton
The installer flashes the keyboard LED and clears the screen at that point when run on physical hardware. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/521202 Title: Windows XP x64 / 2008 Server x6

[Qemu-devel] qtest tmp105-test endianness issue

2013-01-26 Thread Andreas Färber
Hello, I've found that my tmp105-test fails on Mac OS X ppc(64), i.e. Little Endian arm-softmmu target and Big Endian host: GTESTER check-qtest-arm mipid_reset: Display off ** ERROR:/Users/andreas/QEMU/qemu/tests/libi2c-imap.c:163:omap_i2c_create: assertion failed (data == 0x34): (0x3400 == 0

Re: [Qemu-devel] qtest tmp105-test endianness issue

2013-01-26 Thread Alexander Graf
On 26.01.2013, at 23:12, Andreas Färber wrote: > Hello, > > I've found that my tmp105-test fails on Mac OS X ppc(64), i.e. Little > Endian arm-softmmu target and Big Endian host: > > GTESTER check-qtest-arm > mipid_reset: Display off > ** > ERROR:/Users/andreas/QEMU/qemu/tests/libi2c-imap.c:163

[Qemu-devel] buildbot failure in qemu on default_x86_64_rhel61

2013-01-26 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_rhel61 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel61/builds/509 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 B

Re: [Qemu-devel] qtest tmp105-test endianness issue

2013-01-26 Thread Andreas Färber
Am 26.01.2013 23:21, schrieb Alexander Graf: > > On 26.01.2013, at 23:12, Andreas Färber wrote: > >> I've found that my tmp105-test fails on Mac OS X ppc(64), i.e. Little >> Endian arm-softmmu target and Big Endian host: >> >> GTESTER check-qtest-arm >> mipid_reset: Display off >> ** >> ERROR:/Us

Re: [Qemu-devel] [QEMU PATCH] m25p80.c: Return state to IDLE after COLLECTING

2013-01-26 Thread Edgar E. Iglesias
On Fri, Jan 25, 2013 at 05:58:38PM -0800, Peter Crosthwaite wrote: > Default to moving back to the IDLE state after the COLLECTING_DATA > state. For a well behaved guest this patch has no consequence, but > A bad guest could crash QEMU by using one of the erase commands > followed by a longer than

Re: [Qemu-devel] [PATCH v1 1/3] xilinx_ethlite: fix eth_can_rx() for ping-pong

2013-01-26 Thread Edgar E. Iglesias
On Sat, Jan 26, 2013 at 12:36:22PM -0800, Peter Crosthwaite wrote: > The eth_can_rx() function only checks the first buffers status ("ping"). The > controller should be able to receive into "pong" when ping-pong is enabled. > Checks the active buffer (either "ping" or "pong") when determining can_r

Re: [Qemu-devel] [PATCH v1 2/3] xilinx_ethlite: Flush queued packets on SW service

2013-01-26 Thread Edgar E. Iglesias
On Sat, Jan 26, 2013 at 12:36:23PM -0800, Peter Crosthwaite wrote: > Software services a received packet by clearing the CTRL_S bit in the RX_CTRLn > register. If this bit is cleared, flush any packets queued for the device. Applied > > Reported-by: John Williams > Signed-off-by: Peter Crosthwa

Re: [Qemu-devel] [PATCH v1 3/3] xilinx_ethlite: Debug mode compile fixes

2013-01-26 Thread Edgar E. Iglesias
On Sat, Jan 26, 2013 at 12:36:24PM -0800, Peter Crosthwaite wrote: > Some printfs are throwing warnings when debug mode is enabled. Fixed. I committed a slightly different version using TARGET_FMT_plx and %zd > > Signed-off-by: Peter Crosthwaite > --- > hw/xilinx_ethlite.c | 10 ++ > 1

Re: [Qemu-devel] [PATCH] linux-user: allow to use sudo in guest

2013-01-26 Thread Laurent Vivier
In fact, this patch is useless as binfmt_mist provides a flag to manage credentials and security token. A new patch follows... Regards, Laurent Le jeudi 20 décembre 2012 à 21:56 +0100, Laurent Vivier a écrit : > When qemu-linux-user is used in a linux container or chroot, > if it needs to load b

[Qemu-devel] [PATCH] linux-user: add support of binfmt_misc 'O' flag

2013-01-26 Thread Laurent Vivier
The binfmt_misc module can calculate the credentials and security token according to the binary instead of to the interpreter if the 'C' flag is enabled. To be able to execute non-readable binaries, this flag implies 'O' flag. When 'O' flag is enabled, bintfmt_misc opens the file for reading and p

[Qemu-devel] [PATCH for-1.4] target-cris: Build fix for debug output

2013-01-26 Thread Andreas Färber
Around r3361 (81fdc5f8d2d681da8d255baf0713144f8656bac9) env->debug1 used to contain the address of an MMU fault. This is now written into env->pregs[PR_EDA] instead. Signed-off-by: Andreas Färber --- target-cris/op_helper.c |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)

Re: [Qemu-devel] qtest tmp105-test endianness issue

2013-01-26 Thread Alexander Graf
Am 26.01.2013 um 23:51 schrieb Andreas Färber : > Am 26.01.2013 23:21, schrieb Alexander Graf: >> >> On 26.01.2013, at 23:12, Andreas Färber wrote: >> >>> I've found that my tmp105-test fails on Mac OS X ppc(64), i.e. Little >>> Endian arm-softmmu target and Big Endian host: >>> >>> GTESTER c