Parameter *fmt was not used, so remove it.
Reviewed-by: Eric Blake
Signed-off-by: Wenchao Xia
---
qemu-img.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 85d3740..9dab48f 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1186,8 +1186,7
Am 17.01.2013 00:43, schrieb Eduardo Habkost:
> On Wed, Jan 16, 2013 at 11:52:47PM +0100, Andreas Färber wrote:
>> Am 16.01.2013 17:04, schrieb Eduardo Habkost:
>>> On Wed, Jan 16, 2013 at 06:32:48AM +0100, Andreas Färber wrote:
>>> [...]
@@ -2247,6 +2247,9 @@ static void x86_cpu_common_class_
Compared to bdrv_can_snapshot(), this function return whether
bs* is ready to read snapshot info from instead of write. If yes,
caller can then query snapshot information, but taking snapshot
is not always possible for that *bs may be read only.
Signed-off-by: Wenchao Xia
---
block.c
On Wed, Jan 16, 2013 at 07:53:35PM +0100, Stefan Weil wrote:
> Am 15.12.2012 15:09, schrieb Stefan Weil:
> >These patches improve the error report if the file format was
> >specified explicitly (example: -drive file=myfile,format=qcow2)
> >and the given format does not match the real format.
> >
>
17.01.2013 00:19, Kevin Wolf пишет:
Copying data in the right direction really helps a lot!
Cc: qemu-sta...@nongnu.org
Signed-off-by: Kevin Wolf
---
block/win32-aio.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/win32-aio.c b/block/win32-aio.c
index 46a5db7
Hi,
> But as the backinfo's request, should we extented the usbdevice parameter
> like:
>
> --usbdevice host:[:[:]?
-usbdevice is legacy syntax and isn't going to be extended.
Adding an "serial" property to usb-host is an option though.
Patches are welcome.
cheers,
Gerd
On Thu, Jan 17, 2013 at 01:45:11PM +0800, Amos Kong wrote:
> On Thu, Jan 17, 2013 at 11:49:20AM +1030, Rusty Russell wrote:
> > ak...@redhat.com writes:
> > > @@ -349,6 +351,14 @@ static int virtio_net_handle_mac(VirtIONet *n,
> > > uint8_t cmd,
> > > {
> > > struct virtio_net_ctrl_mac mac_d
On Thu, Jan 17, 2013 at 01:45:11PM +0800, Amos Kong wrote:
> On Thu, Jan 17, 2013 at 11:49:20AM +1030, Rusty Russell wrote:
> > ak...@redhat.com writes:
> > > @@ -349,6 +351,14 @@ static int virtio_net_handle_mac(VirtIONet *n,
> > > uint8_t cmd,
> > > {
> > > struct virtio_net_ctrl_mac mac_d
Now qemu-img call block layer function to get image info and check
if error happens.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
---
qemu-img.c | 90
1 files changed, 6 insertions(+), 84 deletions(-)
diff --git a/qemu-img.
Am 17.01.2013 09:33, schrieb Michael Tokarev:
> 17.01.2013 00:19, Kevin Wolf пишет:
>> Copying data in the right direction really helps a lot!
>>
>> Cc: qemu-sta...@nongnu.org
>> Signed-off-by: Kevin Wolf
>> ---
>> block/win32-aio.c |2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
The Buildbot has detected a new failure on builder s390-next_x86_64_debian_6_0
while building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/s390-next_x86_64_debian_6_0/builds/516
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: yuz
We have iov_from_buf() and iov_to_buf(), use them instead of
open-coding these in block/win32-aio.c
Signed-Off-By: Michael Tokarev
---
block/win32-aio.c | 18 +++---
1 file changed, 3 insertions(+), 15 deletions(-)
diff --git a/block/win32-aio.c b/block/win32-aio.c
index 0383370..
Am 17.01.2013 09:48, schrieb Michael Tokarev:
> We have iov_from_buf() and iov_to_buf(), use them instead of
> open-coding these in block/win32-aio.c
>
> Signed-Off-By: Michael Tokarev
> ---
> block/win32-aio.c | 18 +++---
> 1 file changed, 3 insertions(+), 15 deletions(-)
>
> di
17.01.2013 12:57, Kevin Wolf wrote:
I said on top of my patch for a reason: Now this looks like an innocent
Kevin, that wasn't intentional. I'm sorry. Somehow I thought your
bugfix is already applied to master, and these reverse memcpy args
are difficult to spot (gah, that's why the bug is h
The Buildbot has detected a new failure on builder s390-next_i386_debian_6_0
while building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/s390-next_i386_debian_6_0/builds/517
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: yuzuki
On Wed, Jan 16, 2013 at 07:25:51PM +0100, Kevin Wolf wrote:
> aio_poll() must return true if any work is still pending, even if it
> didn't make progress, so that bdrv_drain_all() doesn't stop waiting too
> early. The possibility of stopping early occasionally lead to a failed
> assertion in bdrv_d
On Thu, May 12, 2011 at 10:44 PM, Michael Tokarev wrote:
> This patch almost rewrites acpi_table_add() function
> (but still leaves it using old get_param_value() interface).
> The result is that it's now possible to specify whole table
> (together with a header) in an external file, instead of ju
On Wed, Jan 16, 2013 at 09:19:58PM +0100, Kevin Wolf wrote:
> Paolo, especially the first one is worrying with respect to the test status of
> this code. We should probably give it some additional testing.
>
> Kevin Wolf (2):
> win32-aio: Fix vectored reads
> win32-aio: Fix memory leak
>
> b
Let's get Jason's patches merged while they still apply. I addressed the review
comments (mostly my own) that came up during the v3 review, otherwise this is
unchanged.
Please note that in my tests it didn't work entirely reliably and I saw guest
lockups and kernel crashes in like one of ten cases
From: Jason Baron
'dma_status' and 'dma_cb' are written to, but never read.
Remove these fields in preparation for AHCI migration bits.
Signed-off-by: Jason Baron
Reviewed-by: Juan Quintela
Signed-off-by: Kevin Wolf
---
hw/ide/ahci.c |8 ++--
hw/ide/ahci.h |2 --
2 files changed,
The size of an int depends on the host, so in order to be able to
migrate these fields, make them either int32_t or bool, depending on the
use.
Signed-off-by: Kevin Wolf
---
hw/ide/ahci.c |8
hw/ide/ahci.h |8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git
From: Jason Baron
Jason tested these patches by migrating Windows 7 and Fedora 17 guests
(while under I/O) on both piix with ahci attached and on q35 (which has
a built-in AHCI controller).
Signed-off-by: Andreas Färber
Signed-off-by: Jason Baron
Signed-off-by: Kevin Wolf
---
Changes from v3:
On Thu, Jan 17, 2013 at 09:39:54AM +0100, Stefan Hajnoczi wrote:
> On Thu, Jan 17, 2013 at 01:45:11PM +0800, Amos Kong wrote:
> > On Thu, Jan 17, 2013 at 11:49:20AM +1030, Rusty Russell wrote:
> > > ak...@redhat.com writes:
> > > > @@ -349,6 +351,14 @@ static int virtio_net_handle_mac(VirtIONet *n,
On Thu, Jan 17, 2013 at 07:07:11AM +0100, Luigi Rizzo wrote:
> The comment at the beginning of net/queue.c says that packets that
> cannot be sent by qemu_net_queue_send() should not be enqueued
> unless a callback is set.
>
> This patch implements this behaviour, that prevents a queue to grow
> u
Today, we load
into memory in that order. However, Linux has a bug where it can only
handle the dtb if it's within the first 64MB of where starts.
So instead, let's change the order to
making Linux happy.
Signed-off-by: Alexander Graf
---
hw/ppc/e500.c |7 ++-
1 files cha
On Wed, Jan 16, 2013 at 04:33:48PM +0100, Paolo Bonzini wrote:
> Il 16/01/2013 15:48, Stefan Hajnoczi ha scritto:
> >> > hw/vmxnet_rx_pkt.c | 187 ++
> >> > hw/vmxnet_rx_pkt.h | 173
> >> > hw/vmxnet_tx_pkt.c | 567
> >> > ++
On Tue, Jan 15, 2013 at 06:36:50PM +0200, Michael S. Tsirkin wrote:
> libcacard lacks a clean target. Need to fix it,
> meanwhile mark this target phony so it does not
> stop parallel make clean.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> libcacard/Makefile | 2 +-
> 1 file changed, 1 inserti
On Thu, Jan 17, 2013 at 11:33:03AM +0100, Stefan Hajnoczi wrote:
> On Tue, Jan 15, 2013 at 06:36:50PM +0200, Michael S. Tsirkin wrote:
> > libcacard lacks a clean target. Need to fix it,
> > meanwhile mark this target phony so it does not
> > stop parallel make clean.
> >
> > Signed-off-by: Michae
Le Wednesday 16 Jan 2013 à 13:10:12 (-0700), Eric Blake a écrit :
> On 01/16/2013 09:25 AM, Benoît Canet wrote:
> > ---
> > block/qcow2-dedup.c | 13 +
> > block/qcow2.h |1 +
> > 2 files changed, 14 insertions(+)
> >
> > diff --git a/block/qcow2-dedup.c b/block/qcow2-dedu
> > +#
> > +# @device: the name of the device to pause the deduplication on
> > +#
> > +# Returns: nothing on success
> > +# If @device is not a valid block device, DeviceNotFound
> > +# If @device is not deduplicated, DeviceNotDeduplicated
>
> I don't think you need this secon
On Wed, Jan 16, 2013 at 06:32:12PM +0100, Markus Armbruster wrote:
> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
> index 6eab7f7..74155fb 100644
> --- a/hw/9pfs/virtio-9p-device.c
> +++ b/hw/9pfs/virtio-9p-device.c
> @@ -94,7 +94,7 @@ VirtIODevice *virtio_9p_init(DeviceStat
-acpitable {file|data}=file reads the content of file, but it is
in binary form, so the file should be opened usin O_BINARY flag.
On *nix it is a no-op, but on windows and other weird platform
it is really needed.
Signed-off-by: Michael Tokarev
---
hw/acpi.c |2 +-
1 file changed, 1 insertio
On Wed, Jan 16, 2013 at 06:32:15PM +0100, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> Reviewed-by: Eric Blake
> ---
> fsdev/virtfs-proxy-helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helpe
On Tue, Jan 15, 2013 at 10:04:57AM -0600, Rob Landley wrote:
> On 01/15/2013 05:45:44 AM, Alexander Graf wrote:
> >On 15.01.2013, at 12:39, Suzuki K. Poulose wrote:
> >> On 01/15/2013 04:39 PM, Alexander Graf wrote:
> >>> On 15.01.2013, at 12:05, Suzuki K. Poulose wrote:
> >
> >Does this one work
On Tue, Jan 15, 2013 at 06:57:34PM +0200, Michael S. Tsirkin wrote:
> Using a global pattern makes it easier to clean out
> old generated files.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> rules.mak | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/rules.mak b/rules.mak
> index d1
On Wed, Jan 16, 2013 at 06:32:17PM +0100, Markus Armbruster wrote:
> diff --git a/qemu-log.c b/qemu-log.c
> index 64a1b88..30c8b01 100644
> --- a/qemu-log.c
> +++ b/qemu-log.c
> @@ -21,10 +21,12 @@
> #include "qemu/log.h"
>
> #ifdef WIN32
> -static const char *logfilename = "qemu.log";
> +#defi
Am 17.01.2013 11:53, schrieb Paolo Bonzini:
> Il 16/01/2013 21:19, Kevin Wolf ha scritto:
>> Paolo, especially the first one is worrying with respect to the test status
>> of
>> this code. We should probably give it some additional testing.
>>
>> Kevin Wolf (2):
>> win32-aio: Fix vectored reads
Il 17/01/2013 12:35, Kevin Wolf ha scritto:
> Am 17.01.2013 11:53, schrieb Paolo Bonzini:
>> Il 16/01/2013 21:19, Kevin Wolf ha scritto:
>>> Paolo, especially the first one is worrying with respect to the test status
>>> of
>>> this code. We should probably give it some additional testing.
>>>
>>>
On Thu, 17 Jan 2013 08:49:38 +0100
Markus Armbruster wrote:
> [Cc: Luiz for error stuff]
>
> Jeff Cody writes:
>
> > The non-live bdrv_commit() function may return one of the following
> > errors: -ENOTSUP, -EBUSY, -EACCES, -EIO. The only error that is
> > checked in the HMP handler is -EBUSY
Am 15.12.2012 15:09, schrieb Stefan Weil:
> The block drivers normally return -errno for typical errors.
> There is no appropriate error code for "wrong format", so
> use a special error code which does not conflict with system
> error codes.
>
> Signed-off-by: Stefan Weil
> ---
> block.h |7
We have iov_from_buf() and iov_to_buf(), use them instead of
open-coding these in block/win32-aio.c
---
block/win32-aio.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/block/win32-aio.c b/block/win32-aio.c
index b9236ea..b10a0c0 100644
--- a/block/win32-ai
req was created by scsi_req_alloc(), which initializes req->dev to a
value it dereferences. req->dev isn't changed anywhere else.
Therefore, req->dev can't be null.
Drop the useless null test; it spooks Coverity.
Signed-off-by: Markus Armbruster
---
hw/scsi-bus.c | 2 +-
1 file changed, 1 inse
Am 15.12.2012 15:09, schrieb Stefan Weil:
> vdi_open returned -1 in case of any error, but it should return an
> error code (negative value of errno or BDRV_WRONG_FORMAT).
>
> vdi_open did not check for a bad signature. This check was only in vdi_probe.
>
> The signature is a 32 bit value and nee
On Thu, Jan 17, 2013 at 11:49:20AM +1030, Rusty Russell wrote:
> ak...@redhat.com writes:
> > @@ -349,6 +351,14 @@ static int virtio_net_handle_mac(VirtIONet *n, uint8_t
> > cmd,
> > {
> > struct virtio_net_ctrl_mac mac_data;
> >
> > +if (cmd == VIRTIO_NET_CTRL_MAC_ADDR_SET && elem->ou
Il 16/01/2013 19:14, Anthony Liguori ha scritto:
> Juan Quintela writes:
>
>> Hi
>>
>> This is the intersect of the paolo & me patches for migration thread,
>> please consided for inclusion.
>>
>> The following changes since commit cf7c3f0cb5a7129f57fa9e69d410d6a05031988c:
>>
>> virtio-9p: fix
Am 17.01.2013 09:33, schrieb Stefan Hajnoczi:
> On Wed, Jan 16, 2013 at 07:53:35PM +0100, Stefan Weil wrote:
>> Am 15.12.2012 15:09, schrieb Stefan Weil:
>>> These patches improve the error report if the file format was
>>> specified explicitly (example: -drive file=myfile,format=qcow2)
>>> and the
> +# @running: True if deduplication is running
Internally QCOW2 deduplication state switch between STOPPED, STARTING, RUNNING
and STOPPING.
Should the running field be a status field reflecting all theses states in a
string for example ?
Or is the boolean ok ?
Regards
Benoît
Il 16/01/2013 21:19, Kevin Wolf ha scritto:
> Paolo, especially the first one is worrying with respect to the test status of
> this code. We should probably give it some additional testing.
>
> Kevin Wolf (2):
> win32-aio: Fix vectored reads
> win32-aio: Fix memory leak
>
> block/win32-aio.c
On Thu, Jan 17, 2013 at 06:30:46PM +0800, ak...@redhat.com wrote:
> From: Amos Kong
>
> In virtio-net guest driver, currently we write MAC address to
> pci config space byte by byte, this means that we have an
> intermediate step where mac is wrong. This patch introduced
> a new control command t
Paolo Bonzini wrote:
> Il 16/01/2013 19:14, Anthony Liguori ha scritto:
>> Juan Quintela writes:
>>
>>> Hi
>>>
>>> This is the intersect of the paolo & me patches for migration thread,
>>> please consided for inclusion.
>>>
>>> The following changes since commit cf7c3f0cb5a7129f57fa9e69d410d6a05
The other question I have is if you look at the commit I mentioned as
causing the crash (at least on OpenBSD) and revert that change from
either 1.3.0 or HEAD branch and build QEMU on OS X does the crashing
you're experiencing go away?
--
You received this bug notification because you are a membe
Before the patch in question was commited running QEMU 1.3.0 hosted on
OpenBSD I was able to cause QEMU to crash reproducibly by just booting
OpenBSD within QEMU and upon the kernel accessing the virtual disk to
read the disklabel or during an install writing the disklabel. After the
patch was appl
On Thu, Jan 17, 2013 at 09:03:59AM +0100, Andreas Färber wrote:
[...]
> >> I mentioned in the cover letter that this needs to be changed once a
> >> CPUClass-level realizefn is introduced. I could introduce a no-op
> >> realizefn there and do the regular store+call.
> >
> > That was the semantics
On 01/16/13 18:59, Alon Levy wrote:
> Regarding orientation setting in windows 7 64 guest:
> Desktop, right click->Screen resolution
> - You can choose Orientation: Landscape, Portrait, Landscape (flipped),
> Portrait (flipped)
> - You can choose Resolution
> - You can click "Advanced Settings"
On Tue, Jan 15, 2013 at 08:47:26AM +0100, Stefan Hajnoczi wrote:
> Commit eb8eb53e5846a957cf333f2e1ec8cb6e0c04 ("libcacard: rewrite
> Makefile in non-recursive style") refactored libcacard/Makefile so it
> can be included by the top-level Makefile.
>
> The top-level clean target still loops over s
On Thu, Jan 17, 2013 at 02:44:41PM +0400, Michael Tokarev wrote:
> We have iov_from_buf() and iov_to_buf(), use them instead of
> open-coding these in block/win32-aio.c
Please use qemu_iovec_from_buf() and qemu_iovec_to_buf() since we're
operating on a QEMUIOVector.
Stefan
Stefan Hajnoczi writes:
> On Wed, Jan 16, 2013 at 06:32:15PM +0100, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster
>> Reviewed-by: Eric Blake
>> ---
>> fsdev/virtfs-proxy-helper.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fsdev/virtfs-proxy-
On Wed, Jan 16, 2013 at 02:50:21PM +0100, Markus Armbruster wrote:
> Markus Armbruster (8):
> fw_cfg: Replace debug prints by tracepoints
> fw_cfg: Dumb down fw_cfg_add_*() not to return success / failure
> fw_cfg: New fw_cfg_add_string()
> pc: Fix unchecked strdup() by switching to fw_cfg_
Stefan Hajnoczi writes:
> On Wed, Jan 16, 2013 at 06:32:17PM +0100, Markus Armbruster wrote:
>> diff --git a/qemu-log.c b/qemu-log.c
>> index 64a1b88..30c8b01 100644
>> --- a/qemu-log.c
>> +++ b/qemu-log.c
>> @@ -21,10 +21,12 @@
>> #include "qemu/log.h"
>>
>> #ifdef WIN32
>> -static const cha
Stefan Hajnoczi writes:
> On Wed, Jan 16, 2013 at 06:32:12PM +0100, Markus Armbruster wrote:
>> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
>> index 6eab7f7..74155fb 100644
>> --- a/hw/9pfs/virtio-9p-device.c
>> +++ b/hw/9pfs/virtio-9p-device.c
>> @@ -94,7 +94,7 @@ VirtIO
- Original Message -
> On 01/16/13 18:59, Alon Levy wrote:
> > Regarding orientation setting in windows 7 64 guest:
> > Desktop, right click->Screen resolution
> > - You can choose Orientation: Landscape, Portrait, Landscape
> > (flipped), Portrait (flipped)
> > - You can choose Resolu
Signed-off-by: Juan Quintela
Reviewed-by: Reviewed-by: Eric Blake
Reviewed-by: Paolo Bonzini
---
savevm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/savevm.c b/savevm.c
index 4e970ca..611e997 100644
--- a/savevm.c
+++ b/savevm.c
@@ -419,7 +419,9 @@ int qemu_file_get
Hi,
>> I think it would also be good to fix the driver to ignore everything
>> with or
> ... what was the end of that sentence?
.. orientation != 0, then registers every mode with the orientations it
wants, so orientation becomes unused with newer drivers (and we keep
orientation=0,1 for old d
On 11 December 2012 16:11, Peter Maydell wrote:
> Fix a leak of a TCG temporary in code paths for VFP system register
> writes for cases which UNDEF or are write-ignored.
>
> Signed-off-by: Peter Maydell
Rats, I forgot to put this into the last target-arm pullreq...
-- PMM
17.01.2013 17:06, Stefan Hajnoczi wrote:
On Thu, Jan 17, 2013 at 02:44:41PM +0400, Michael Tokarev wrote:
We have iov_from_buf() and iov_to_buf(), use them instead of
open-coding these in block/win32-aio.c
Please use qemu_iovec_from_buf() and qemu_iovec_to_buf() since we're
operating on a QEMU
From: Amos Kong
In virtio-net guest driver, currently we write MAC address to
pci config space byte by byte, this means that we have an
intermediate step where mac is wrong. This patch introduced
a new control command to set MAC address, it's atomic.
VIRTIO_NET_F_CTRL_MAC_ADDR is a new feature b
From: Paolo Bonzini
The call in buffered_close is enough, because buffered_close is called
already by migrate_fd_cleanup.
Signed-off-by: Paolo Bonzini
Signed-off-by: Juan Quintela
Reviewed-by: Reviewed-by: Eric Blake
---
migration.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/migrati
Signed-off-by: Juan Quintela
Reviewed-by: Reviewed-by: Eric Blake
Reviewed-by: Paolo Bonzini
---
include/migration/migration.h | 1 -
migration.c | 28 +++-
2 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/include/migration/migration.h
On line 216 of qemu-thread-posix.c I have commented out the
++sem->count; which seems to be the only change made in that commit.
Unfortunately it still crashes with that error.
I have compiled with --enable-debug but not sure how to get a backtrace
or even a log of what goes wrong.
--
You receiv
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Juan Quintela
Reviewed-by: Reviewed-by: Eric Blake
---
arch_init.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 8c833b6..dada6de 100644
--- a/arch_init.c
+++ b/arch_init.c
From: Paolo Bonzini
commit 5b4e1eb769eee892b44d3f6b2369b05196442f59
missed this use.
Signed-off-by: Paolo Bonzini
Signed-off-by: Juan Quintela
Reviewed-by: Reviewed-by: Eric Blake
---
migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration.c b/migration.c
Signed-off-by: Orit Wasserman
Signed-off-by: Juan Quintela
Reviewed-by: Reviewed-by: Eric Blake
Reviewed-by: Paolo Bonzini
---
migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration.c b/migration.c
index 6d3aeed..fe1a103 100644
--- a/migration.c
+++ b/migrat
Signed-off-by: Juan Quintela
Reviewed-by: Reviewed-by: Eric Blake
Reviewed-by: Paolo Bonzini
---
include/sysemu/sysemu.h | 2 +-
migration.c | 2 +-
savevm.c| 8
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/sysemu/sysemu.h b/includ
Signed-off-by: Juan Quintela
Reviewed-by: Reviewed-by: Eric Blake
Reviewed-by: Paolo Bonzini
---
migration.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/migration.c b/migration.c
index 17eb27d..651edd5 100644
--- a/migration.c
+++ b/migration.c
@@ -669,12
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Juan Quintela
Reviewed-by: Reviewed-by: Eric Blake
---
include/migration/migration.h | 2 --
migration.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/include/migration/migration.h b/
Hi,
here's the latest incarnation of my channel I/O and virtio-ccw
patchset for qemu, containing various changes over the last one.
(Note that "s390: Add a hypercall registration interface." has
already been posted: http://marc.info/?l=qemu-devel&m=135834160607372&w=2)
Changes include:
- Add var
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Juan Quintela
Reviewed-by: Reviewed-by: Eric Blake
---
arch_init.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch_init.c b/arch_init.c
index 86f8544..8c833b6 100644
--- a/arch_init.c
+++ b/arch_init.c
Add a new machine type, s390-ccw-virtio, making use of the
virtio-ccw transport to present virtio devices as channel
devices and make it the default on s390.
Signed-off-by: Cornelia Huck
---
hw/s390-virtio.c | 1 -
hw/s390-virtio.h | 1 +
hw/s390x/Makefile.objs | 1
Base is kvm-next as of 2013/01/16.
Signed-off-by: Cornelia Huck
---
linux-headers/asm-generic/kvm_para.h | 4
linux-headers/asm-powerpc/kvm_para.h | 2 +-
linux-headers/linux/kvm.h| 21 +
3 files changed, 26 insertions(+), 1 deletion(-)
create mode 100644
Basic channel I/O structures and helper function.
Signed-off-by: Cornelia Huck
---
target-s390x/Makefile.objs | 2 +-
target-s390x/cpu.h | 5 ++
target-s390x/ioinst.c | 36
target-s390x/ioinst.h | 207 +
4 files changed,
Provide handlers for (most) channel I/O instructions.
Signed-off-by: Cornelia Huck
---
target-s390x/cpu.h| 101
target-s390x/ioinst.c | 673 ++
target-s390x/ioinst.h | 16 ++
trace-events | 6 +
4 files changed, 796 inserti
Allow virtio machines to register for different diag500 function
codes and convert s390-virtio to use it.
Signed-off-by: Cornelia Huck
---
hw/s390-virtio.c | 90 +++-
hw/s390-virtio.h | 22 +++
hw/s390x/Makefile.objs |
Some of the machine initialization for s390-virtio will be reused
by virtio-ccw.
Signed-off-by: Cornelia Huck
---
hw/s390-virtio.c | 155 ++-
hw/s390-virtio.h | 5 ++
2 files changed, 91 insertions(+), 69 deletions(-)
diff --git a/hw/s390-vi
Add a new virtio transport that uses channel commands to perform
virtio operations.
Signed-off-by: Cornelia Huck
---
hw/s390x/Makefile.objs | 1 +
hw/s390x/virtio-ccw.c | 906 +
hw/s390x/virtio-ccw.h | 79 +
trace-events | 4 +
Provide a mechanism for qemu to provide fully virtual subchannels to
the guest.
Signed-off-by: Cornelia Huck
---
hw/s390x/Makefile.objs |1 +
hw/s390x/css.c | 1131
hw/s390x/css.h | 92
target-s390x/cpu.h | 65 +++
On Wed, Jan 16, 2013 at 10:14:33AM -0600, Anthony Liguori wrote:
> "Michael S. Tsirkin" writes:
>
> > On Wed, Jan 16, 2013 at 09:09:49AM -0600, Anthony Liguori wrote:
> >> Jason Wang writes:
> >>
> >> > On 01/15/2013 03:44 AM, Anthony Liguori wrote:
> >> >> Jason Wang writes:
> >> >>
> >> >>>
This will allow us finer control in next patches.
Signed-off-by: Juan Quintela
Reviewed-by: Reviewed-by: Eric Blake
Reviewed-by: Paolo Bonzini
---
migration.c | 95 ++---
1 file changed, 41 insertions(+), 54 deletions(-)
diff --git a/mi
Now that we have error handling we can do proper handling of
buffered_flush().
Signed-off-by: Juan Quintela
Reviewed-by: Reviewed-by: Eric Blake
Reviewed-by: Paolo Bonzini
---
migration.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/migration.c b/migration.c
index 7ae
Aaron, this added line in qemu-thread-posix.c is the fix, qemu is
expected to crash once this is removed.
I guess Brad meant to revert c166cb72f1676855816340666c3b618beef4b976
which introduced the fallback code. However, reverting this commit alone
will not work on Mac OS X as sem_timedwait() is n
Create a lowcore mapping helper that includes a check for sufficient
length.
Signed-off-by: Cornelia Huck
---
target-s390x/helper.c | 31 +--
1 file changed, 25 insertions(+), 6 deletions(-)
diff --git a/target-s390x/helper.c b/target-s390x/helper.c
index 9a132e6..bf
Wow you're replying to an old post... ;)
17.01.2013 13:50, TeLeMan wrote:
On Thu, May 12, 2011 at 10:44 PM, Michael Tokarev wrote:
This patch almost rewrites acpi_table_add() function
[]
+
+/* now read in the data files, reallocating buffer as needed */
+
+for (f = strtok(buf, ":");
We have iov_from_buf() and iov_to_buf(), use them instead of
open-coding these in block/win32-aio.c
---
v3: added the forgotten #include (compile-tested on mingw32)
v2: rebase on top of the fix from bonzini@
block/win32-aio.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions
Add s390_cpu_physical_memory_{map,unmap} with special handling
for the lowcore.
Signed-off-by: Cornelia Huck
---
target-s390x/cpu.h| 4
target-s390x/helper.c | 26 ++
2 files changed, 30 insertions(+)
diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h
index 6
This replaces the feature-bit fields on both X86CPU and x86_def_t
structs with an array.
With this, we will be able to simplify code that simply does the same
operation on all feature words (e.g. kvm_check_features_against_host(),
filter_features_for_kvm(), add_flagname_to_bitmaps(), and CPU
featu
I/O interrupts are queued per isc. Only crw pending machine checks
are supported.
Signed-off-by: Cornelia Huck
---
target-s390x/cpu.h| 69 +++-
target-s390x/helper.c | 143 ++
2 files changed, 211 insertions(+), 1 deletion(
On 17 January 2013 14:23, Cornelia Huck wrote:
> Base is kvm-next as of 2013/01/16.
> --- a/linux-headers/asm-powerpc/kvm_para.h
> +++ b/linux-headers/asm-powerpc/kvm_para.h
> @@ -78,7 +78,7 @@ struct kvm_vcpu_arch_shared {
>
> #define KVM_HCALL_TOKEN(num) _EV_HCALL_TOKEN(EV_KVM_VENDOR_ID, n
Il 17/01/2013 13:46, Juan Quintela ha scritto:
>> >
>> > It shouldn't be, because the patches have never been posted before.
>> > That said, I'm okay with pulling all patches except the last one.
> I will add that as reviewed by? O:-)
Yes.
Paolo
Trigger the code for our virtual css in case of instruction
intercepts for I/O instructions.
Handle the tsch exit for the subchannel-related part of tsch.
Signed-off-by: Cornelia Huck
---
target-s390x/cpu.h | 11 +++
target-s390x/kvm.c | 252 ++--
The changes (since 47f4dac3fde809e3da4e60d9eb699f1d4b378249) are available
in the following repository:
git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
Wenchao Xia (5):
HMP: add QDict to info callback handler
HMP: delete info handler
HMP: add infrastructure for sub command
HMP: move
From: Wenchao Xia
Now cmd and info handler have same format, so delete info handler.
Signed-off-by: Wenchao Xia
Signed-off-by: Luiz Capitulino
---
monitor.c | 91 +++
1 file changed, 45 insertions(+), 46 deletions(-)
diff --git a/
1 - 100 of 232 matches
Mail list logo
