[Qemu-devel] [PATCH V3 01/44] virtio: make virtio device's structures public.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic These structures must be made public to avoid two memory allocations for virtio-*-*. Signed-off-by: KONRAD Frederic --- hw/virtio-balloon.c| 12 hw/virtio-balloon.h| 11 +++ hw/virtio-blk.c| 16 hw/virtio-blk.h

[Qemu-devel] [PATCH V3 00/44] Virtio-refactoring part2.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic This is the part 2/3 of the virtio-refactoring for testing/reviewing. Don't be afraid by the 44 steps, the structure is the same for all devices: * Move the *conf field to conf: (I think trivial and short.) * Create the virtio-x device. * Switch virtio-x-pci to

[Qemu-devel] [PATCH V3 02/44] virtio-blk: don't use pointer for configuration.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic The configuration field must not be a pointer as it will be used for virtio-blk properties. So *blk is replaced by blk in VirtIOBlock structure. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 8 hw/virtio-blk.h | 2 +- 2 files changed, 5 insertions(+), 5 de

[Qemu-devel] [PATCH V3 05/44] virtio-blk-s390: switch to the new API.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Here the virtio-blk-s390 is modified for the new API. The device virtio-blk-s390 extends virtio-s390-device as before. It creates and connects a virtio-blk during the init. The properties are not modified. Signed-off-by: KONRAD Frederic --- hw/s390-virtio-bus.c | 30 +

[Qemu-devel] [PATCH V3 03/44] virtio-blk: add the virtio-blk device.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Create virtio-blk which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 97 ++--- hw/virtio-blk.h | 28 + hw/virtio-pci.c | 11 +-- 3

[Qemu-devel] [PATCH V3 04/44] virtio-blk-pci: switch to new API.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Here the virtio-blk-pci is modified for the new API. The device virtio-blk-pci extends virtio-pci. It creates and connects a virtio-blk during the init. The properties are not changed. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 115 ++

[Qemu-devel] [PATCH V3 07/44] virtio-blk: cleanup: remove qdev field.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic The qdev field is no longer needed, just drop it. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 3 +-- hw/virtio-blk.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index c19d347..74ba97b 100644 --- a/hw/virt

[Qemu-devel] [PATCH V3 12/44] virtio-net: cleanup: init and exit function.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic This remove old init and exit function as they are no longer needed. Signed-off-by: KONRAD Frederic --- hw/virtio-net.c | 95 - 1 file changed, 20 insertions(+), 75 deletions(-) diff --git a/hw/virtio-net.c b/hw/vir

[Qemu-devel] [PATCH V3 11/44] virtio-net: cleanup: use QOM cast.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic As the virtio-net-pci and virtio-net-s390 are switched to the new API, we can use QOM casts. Signed-off-by: KONRAD Frederic --- hw/virtio-net.c | 155 ++-- hw/virtio-net.h | 2 +- 2 files changed, 84 insertions(+), 73

[Qemu-devel] [PATCH V3 08/44] virtio-net: add the virtio-net device.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Create virtio-net which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/virtio-net.c | 117 +--- hw/virtio-net.h | 18 + hw/virtio-pci.c | 7 +--- hw/virtio-p

[Qemu-devel] [PATCH V3 44/44] virtio-9p: cleanup: QOM casts.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic As the virtio-9p-pci is switched to the new API, we can use QOM casts. Signed-off-by: KONRAD Frederic --- hw/9pfs/virtio-9p-device.c | 11 +++ hw/9pfs/virtio-9p.c| 2 +- hw/9pfs/virtio-9p.h| 2 +- 3 files changed, 5 insertions(+), 10 deletions(-)

[Qemu-devel] [PATCH V3 14/44] virtio-scsi: don't use pointer for configuration.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic The configuration field must not be a pointer as it will be used for virtio-scsi properties. So *conf is replaced by conf. Signed-off-by: KONRAD Frederic --- hw/virtio-scsi.c | 14 +++--- hw/virtio-scsi.h | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-)

[Qemu-devel] [PATCH V3 39/44] virtio-serial: cleanup: use QOM casts.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic As the virtio-serial-pci and virtio-serial-s390 are switched to the new API, we can use QOM casts. Signed-off-by: KONRAD Frederic --- hw/virtio-serial-bus.c | 50 ++ hw/virtio-serial.h | 2 +- 2 files changed, 27 insert

Re: [Qemu-devel] [PATCH 4/4] block: Fix how mirror_run() frees its buffer

2013-01-15 Thread Markus Armbruster
Kevin Wolf writes: > Am 15.01.2013 14:23, schrieb Markus Armbruster: >> It allocates with qemu_blockalign(), therefore it must free with >> qemu_vfree(), not g_free(). >> >> Since I'm touching it anyway, move the free to a more obviosly correct >> place. > > ...except that it's now leaked for al

[Qemu-devel] [PATCH V3 33/44] virtio-rng.c: cleanup: remove qdev field.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic The qdev field is no longer needed, just drop it. Signed-off-by: KONRAD Frederic --- hw/virtio-rng.c | 2 -- hw/virtio-rng.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c index c4a323d..daeb734 100644 --- a/hw/virtio-rng.c +++ b/h

[Qemu-devel] [PATCH V3 15/44] virtio-scsi: allocate cmd_vqs array separately.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Allocate/Free the cmd_vqs array separately to have a fixed size device. Signed-off-by: KONRAD Frederic --- hw/virtio-scsi.c | 6 +++--- hw/virtio-scsi.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c index 29eb39

[Qemu-devel] [PATCH V3 09/44] virtio-net-pci: switch to the new API.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Here the virtio-net-pci is modified for the new API. The device virtio-net-pci extends virtio-pci. It creates and connects a virtio-net during the init. The properties are not changed. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 111 --

[Qemu-devel] [PATCH 2/2] acl: Free memory allocated with g_malloc() with g_free()

2013-01-15 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- util/acl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/acl.c b/util/acl.c index 21b2205..a7f33ff 100644 --- a/util/acl.c +++ b/util/acl.c @@ -103,8 +103,8 @@ void qemu_acl_reset(qemu_acl *acl) acl->defaultDeny = 1; Q

[Qemu-devel] [PATCH 0/2] ACL fixes

2013-01-15 Thread Markus Armbruster
Markus Armbruster (2): acl: Fix acl_remove not to mess up the ACL acl: Free memory allocated with g_malloc() with g_free() util/acl.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 1.7.11.7

[Qemu-devel] [PATCH 1/2] acl: Fix acl_remove not to mess up the ACL

2013-01-15 Thread Markus Armbruster
It leaks memory and fails to adjust qemu_acl member nentries. Future acl_add become confused: can misreport the position, and can silently fail to add. Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster --- util/acl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/util/acl.c b/

[Qemu-devel] [PATCH V3 41/44] virtio-9p: add the virtio-9p device.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Create virtio-9p which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/9pfs/virtio-9p-device.c | 84 +++--- hw/9pfs/virtio-9p.h| 11 ++ 2 files changed, 82 insertions(+)

[Qemu-devel] [PATCH V3 18/44] virtio-scsi-pci: switch to new API.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Here the virtio-scsi-pci is modified for the new API. The device virtio-scsi-pci extends virtio-pci. It creates and connects a virtio-scsi during the init. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 125 h

[Qemu-devel] [PATCH V3 13/44] virtio-net: cleanup: remove qdev field.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic The qdev field is no longer needed. Just drop it. Signed-off-by: KONRAD Frederic --- hw/virtio-net.c | 1 - hw/virtio-net.h | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 62b8cb5..0445345 100644 --- a/hw/virtio-net.c +++ b/hw/

[Qemu-devel] [PATCH] sheepdog: add support for connecting to unix domain socket

2013-01-15 Thread MORITA Kazutaka
This patch adds support for a unix domain socket for a connection between qemu and local sheepdog server. You can use the unix domain socket with the following syntax like NBD driver: $ qemu sheepdog:unix:: Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 153 ---

[Qemu-devel] [PATCH V3 06/44] virtio-blk: cleanup: use QOM cast.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic As the virtio-blk-pci and virtio-blk-s390 are switched to the new API, we can use QOM casts and remove the separate init/exit for the old API. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 123 +--- hw/virtio-blk.

[Qemu-devel] [PATCH V3 10/44] virtio-net-s390: switch to the new API.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Here the virtio-net-s390 is modified for the new API. The device virtio-net-s390 extends virtio-s390-device as before. It creates and connects a virtio-net during the init. The properties are not modified. Signed-off-by: KONRAD Frederic --- hw/s390-virtio-bus.c | 32 +

[Qemu-devel] [PATCH v2 0/4] Fixes around qemu_vfree()

2013-01-15 Thread Markus Armbruster
v2: Fix silly mistake in 4/4; the other three patches are unchanged Markus Armbruster (4): w32: Make qemu_vfree() accept NULL like the POSIX implementation scsi-disk: qemu_vfree(NULL) is fine, simplify win32-aio: Fix how win32_aio_process_completion() frees buffer block: Fix how mirror_run

[Qemu-devel] [PATCH v2 2/4] scsi-disk: qemu_vfree(NULL) is fine, simplify

2013-01-15 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/scsi-disk.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index f8d7ef3..96db9a7 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -85,9 +85,7 @@ static void scsi_free_request(SCSIRequest *req) {

[Qemu-devel] [PATCH v2 4/4] block: Fix how mirror_run() frees its buffer

2013-01-15 Thread Markus Armbruster
It allocates with qemu_blockalign(), therefore it must free with qemu_vfree(), not g_free(). Signed-off-by: Markus Armbruster --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 8aeacbf..6180aa3 100644 --- a/block/mirror.c

[Qemu-devel] [PATCH v2 1/4] w32: Make qemu_vfree() accept NULL like the POSIX implementation

2013-01-15 Thread Markus Armbruster
On POSIX, qemu_vfree() accepts NULL, because it's merely wrapper around free(). As far as I can tell, the Windows implementation doesn't. Breeds bugs that bite only under Windows. Make the Windows implementation behave like the POSIX implementation. Signed-off-by: Markus Armbruster --- util/o

[Qemu-devel] [PATCH v2 3/4] win32-aio: Fix how win32_aio_process_completion() frees buffer

2013-01-15 Thread Markus Armbruster
win32_aio_submit() allocates it with qemu_blockalign(), therefore it must be freed with qemu_vfree(), not g_free(). Signed-off-by: Markus Armbruster --- block/win32-aio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/win32-aio.c b/block/win32-aio.c index 46a5db7..0383

[Qemu-devel] [PATCH V3 32/44] virtio-rng.c: cleanup: init and exit functions.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic This remove old init and exit function as they are no longer needed. Signed-off-by: KONRAD Frederic --- hw/virtio-rng.c | 87 ++--- 1 file changed, 21 insertions(+), 66 deletions(-) diff --git a/hw/virtio-rng.c b/hw/vir

[Qemu-devel] [PATCH V3 36/44] virtio-serial-pci: switch to the new API.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Here the virtio-serial-pci is modified for the new API. The device virtio-serial-pci extends virtio-pci. It creates and connects a virtio-serial during the init. The properties are not changed. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 128 +

[Qemu-devel] [PATCH V3 19/44] virtio-scsi-s390: switch to the new API.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Here the virtio-scsi-s390 is modified for the new API. The device virtio-scsi-s390 extends virtio-s390-device as before. It creates and connects a virtio-scsi during the init. The properties are not modified. Signed-off-by: KONRAD Frederic --- hw/s390-virtio-bus.c | 26 ++

[Qemu-devel] [PATCH V3 26/44] virtio-balloon: cleanup: QOM casts.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic As the virtio-balloon-pci is switched to the new API, we can use QOM casts. Signed-off-by: KONRAD Frederic --- hw/virtio-balloon.c | 39 +-- hw/virtio-balloon.h | 2 +- 2 files changed, 18 insertions(+), 23 deletions(-) diff --git a/h

[Qemu-devel] [PATCH V3 34/44] virtio-rng.c: cleanup: use QOM casts.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic As the virtio-rng-pci and virtio-rng-s390 are switched to the new API, we can use QOM casts. Signed-off-by: KONRAD Frederic --- hw/virtio-rng.c | 31 +-- hw/virtio-rng.h | 2 +- 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/

[Qemu-devel] [PATCH V3 27/44] virtio-balloon: cleanup: remove qdev field.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic The qdev field is no longer needed, just drop it. Signed-off-by: KONRAD Frederic --- hw/virtio-balloon.c | 1 - hw/virtio-balloon.h | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c index 6eafd42..f509d81 100644 --- a/hw/virtio

[Qemu-devel] [PATCH V3 29/44] virtio-rng: add virtio-rng device.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Create virtio-rng which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 8 +--- hw/virtio-rng.c | 112 +--- hw/virtio-rng.h | 16 3 files chan

[Qemu-devel] [PATCH V3 42/44] virtio-9p-pci: switch to the new API.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Here the virtio-9p-pci is modified for the new API. The device virtio-9p-pci extends virtio-pci. It creates and connects a virtio-9p during the init. The properties are not changed. Signed-off-by: KONRAD Frederic --- hw/9pfs/virtio-9p-device.c | 53 +++

Re: [Qemu-devel] [PATCH v2 0/4] Fixes around qemu_vfree()

2013-01-15 Thread Kevin Wolf
Am 15.01.2013 15:29, schrieb Markus Armbruster: > v2: Fix silly mistake in 4/4; the other three patches are unchanged > > Markus Armbruster (4): > w32: Make qemu_vfree() accept NULL like the POSIX implementation > scsi-disk: qemu_vfree(NULL) is fine, simplify > win32-aio: Fix how win32_aio_p

Re: [Qemu-devel] [PATCH 2/2] pixman: fix warning

2013-01-15 Thread Gerd Hoffmann
Hi, > Unfortunately this did not help on SLES11 SP2. I don't spot any typo in > your patches, it looked neat; CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE does > not get defined in config-host.h it seems. Hmm, anything in config.log? Maybe the sles11 gcc doesn't support the -Wunused-but-set-variable use

[Qemu-devel] [PATCH V3 21/44] virtio-scsi: cleanup: init and exit functions.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic This remove old init and exit function as they are no longer needed. Signed-off-by: KONRAD Frederic --- hw/virtio-scsi.c | 59 ++-- 1 file changed, 10 insertions(+), 49 deletions(-) diff --git a/hw/virtio-scsi.c b/hw/vi

[Qemu-devel] [PATCH] sdl: Fix heap smash in sdl_zoom_rgb{16, 32} for int > 32 bits

2013-01-15 Thread Markus Armbruster
Careless use of malloc(): allocate Uint32[N], assign to int *, use int[N]. Fix by converting to g_new(). Functions can't fail anymore, so make them return void. Caller ignored the value anyway. Signed-off-by: Markus Armbruster --- ui/sdl_zoom.c | 9 + ui/sdl_zoom_template.h

[Qemu-devel] [PATCH V3 30/44] virtio-rng-s390: switch to the new API.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Here the virtio-rng-s390 is modified for the new API. The device virtio-rng-s390 extends virtio-s390-device as before. It creates and connects a virtio-rng during the init. The properties are not modified. Signed-off-by: KONRAD Frederic --- hw/s390-virtio-bus.c | 35 +

[Qemu-devel] [PATCH V3 35/44] virtio-serial: add the virtio-serial device.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Create virtio-serial which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c| 2 +- hw/virtio-serial-bus.c | 100 + hw/virtio-serial.h | 11 ++

[Qemu-devel] [PATCH V3 43/44] virtio-9p: cleanup: init function.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic This remove old init function as it is no longer needed. Signed-off-by: KONRAD Frederic --- hw/9pfs/virtio-9p-device.c | 75 ++ 1 file changed, 23 insertions(+), 52 deletions(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs

[Qemu-devel] [PATCH V3 24/44] virtio-balloon-pci: switch to the new API.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Here the virtio-balloon-pci is modified for the new API. The device virtio-balloon-pci extends virtio-pci. It creates and connects a virtio-balloon during the init. The properties are not changed. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 111 ++

Re: [Qemu-devel] [PATCH 06/20] xen: Simplify halting of first CPU

2013-01-15 Thread Andreas Färber
Am 15.01.2013 12:03, schrieb Stefano Stabellini: > On Tue, 15 Jan 2013, Andreas Färber wrote: >> Use the global first_cpu variable to halt the CPU rather than using a >> local first_cpu initialized from qemu_get_cpu(0). >> >> This will allow to change qemu_get_cpu() return type to CPUState >> despi

[Qemu-devel] [PATCH V3 25/44] virtio-balloon: cleanup: init and exit function.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic This remove old init and exit function as they are no longer needed. Signed-off-by: KONRAD Frederic --- hw/virtio-balloon.c | 67 + 1 file changed, 11 insertions(+), 56 deletions(-) diff --git a/hw/virtio-balloon.c b/hw

[Qemu-devel] [PATCH V3 16/44] virtio-scsi: moving host_features from properties to transport properties.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic host_features field is part of the transport device. So move all the host_features related properties into transport device. Signed-off-by: KONRAD Frederic --- hw/s390-virtio-bus.c | 7 ++- hw/virtio-pci.c | 7 ++- hw/virtio-scsi.h | 9 +++-- 3 files

Re: [Qemu-devel] [PATCH v3 1/2] ahci: remove unused AHCIDevice fields

2013-01-15 Thread Juan Quintela
Jason Baron wrote: > From: Jason Baron > > 'dma_status' and 'dma_cb' are written to, but never read. > Remove these fields in preparation for AHCI migration bits. > > Signed-off-by: Jason Baron Reviewed-by: Juan Quintela

[Qemu-devel] [PATCH V3 37/44] virtio-serial-s390: switch to the new API.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Here the virtio-serial-s390 is modified for the new API. The device virtio-serial-s390 extends virtio-s390-device as before. It creates and connects a virtio-serial during the init. The properties are not modified. Signed-off-by: KONRAD Frederic --- hw/s390-virtio-bus.c |

[Qemu-devel] [PATCH V3 28/44] virtio-rng: don't use pointer for configuration.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic The configuration field must not be a pointer as it will be used for virtio-rng properties. So *conf is replaced by conf. Signed-off-by: KONRAD Frederic --- hw/virtio-rng.c | 12 ++-- hw/virtio-rng.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff

[Qemu-devel] [PATCH V3 38/44] virtio-serial: cleanup: init and exit functions.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic This remove old init and exit function as they are no longer needed. Signed-off-by: KONRAD Frederic --- hw/virtio-serial-bus.c | 93 -- 1 file changed, 21 insertions(+), 72 deletions(-) diff --git a/hw/virtio-serial-bus.c b

Re: [Qemu-devel] [PATCH v3 2/2] ahci: add migration support

2013-01-15 Thread Juan Quintela
Jason Baron wrote: > From: Jason Baron > > I've tested these patches by migrating Windows 7 and Fedora 17 guests (while > uunder i/o) on both piix with ahci attached and on q35 (which has a built-in > ahci controller). > > Changes from v2: > -migrate all relevant ahci fields > -flush any pendin

[Qemu-devel] [PATCH V3 23/44] virtio-balloon: add the virtio-balloon device.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Create virtio-balloon which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/virtio-balloon.c | 94 + hw/virtio-balloon.h | 4 +++ 2 files changed, 92 insertions(+), 6 d

[Qemu-devel] [PATCH V3 17/44] virtio-scsi: add the virtio-scsi device.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Create virtio-scsi which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/virtio-scsi.c | 91 hw/virtio-scsi.h | 7 + 2 files changed, 93 insertions(+), 5 delet

Re: [Qemu-devel] KVM call for 2013-01-15

2013-01-15 Thread Andreas Färber
Am 15.01.2013 11:36, schrieb Eduardo Habkost: > On Mon, Jan 14, 2013 at 02:26:12PM +0100, Juan Quintela wrote: >> Please send in any agenda topics that you have. > > - CPU hotplug plan/design For those that didn't read it, some food for thought: http://lists.gnu.org/archive/html/qemu-devel/2013-0

Re: [Qemu-devel] [PATCH v3 2/2] ahci: add migration support

2013-01-15 Thread Kevin Wolf
Am 15.01.2013 15:54, schrieb Juan Quintela: > Jason Baron wrote: >> From: Jason Baron >> >> I've tested these patches by migrating Windows 7 and Fedora 17 guests (while >> uunder i/o) on both piix with ahci attached and on q35 (which has a built-in >> ahci controller). >> >> Changes from v2: >>

Re: [Qemu-devel] [PATCH 14/14] Rename buffered_ to migration_

2013-01-15 Thread Paolo Bonzini
Il 15/01/2013 12:18, Juan Quintela ha scritto: > This is consistent once that we have moved everything to migration.c Please drop this patch, I have the same changes later in my queue and it causes a lot of conflicts if you put it here. It's true that the code is migration.c, but it is still abou

Re: [Qemu-devel] getting rid of coroutine-gthread?

2013-01-15 Thread Paolo Bonzini
Il 15/01/2013 14:40, Kevin Wolf ha scritto: >> > I'm not entirely confident in its correctness, and I'd be afraid of >> > breaking things when converting dataplane to AIOContext. > Dataplane is (at least for now) not the most important thing to have > when debugging a block driver. Would it help if

Re: [Qemu-devel] [PATCH 2/2] pixman: fix warning

2013-01-15 Thread Paolo Bonzini
Il 15/01/2013 15:29, Gerd Hoffmann ha scritto: >> > Using the pragmas unconditionally results in change from: >> > >> > CCqemu-timer.o >> > cc1: warnings being treated as errors >> > In file included from >> > /home/andreas/QEMU/qemu-s390/include/ui/qemu-pixman.h:13, >> > fr

Re: [Qemu-devel] [PATCH 2/4] scsi-disk: qemu_vfree(NULL) is fine, simplify

2013-01-15 Thread Paolo Bonzini
Il 15/01/2013 14:23, Markus Armbruster ha scritto: > Signed-off-by: Markus Armbruster > --- > hw/scsi-disk.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c > index f8d7ef3..96db9a7 100644 > --- a/hw/scsi-disk.c > +++ b/hw/scsi-disk.c >

Re: [Qemu-devel] [PATCH 2/2] qxl: change rom so that 4096 < size < 8192

2013-01-15 Thread Gerd Hoffmann
Hi, #define QXL_MODE_EX(x_res, y_res) \ QXL_MODE_16_32(x_res, y_res, 0), \ -QXL_MODE_16_32(y_res, x_res, 1), \ -QXL_MODE_16_32(x_res, y_res, 2), \ -QXL_MODE_16_32(y_res, x_res, 3) +QXL_MODE

Re: [Qemu-devel] [PATCH 4/4] block: Fix how mirror_run() frees its buffer

2013-01-15 Thread Paolo Bonzini
Il 15/01/2013 15:20, Markus Armbruster ha scritto: >> > Am 15.01.2013 14:23, schrieb Markus Armbruster: >>> >> It allocates with qemu_blockalign(), therefore it must free with >>> >> qemu_vfree(), not g_free(). >>> >> >>> >> Since I'm touching it anyway, move the free to a more obviosly correct >>

[Qemu-devel] [PATCH V3 31/44] virtio-rng-pci: switch to the new API.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic Here the virtio-rng-pci is modified for the new API. The device virtio-rng-pci extends virtio-pci. It creates and connects a virtio-rng during the init. The properties are not changed. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 140 +++---

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2013-01-15 Thread Bug Watch Updater
** Changed in: qemu-kvm (Debian) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1033727 Title: USB passthrough doesn't work anymore with qemu-kvm 1.1.1 Stat

Re: [Qemu-devel] [PATCH 0/4] Fixes around qemu_vfree()

2013-01-15 Thread Stefan Hajnoczi
On Tue, Jan 15, 2013 at 02:23:36PM +0100, Markus Armbruster wrote: > Markus Armbruster (4): > w32: Make qemu_vfree() accept NULL like the POSIX implementation > scsi-disk: qemu_vfree(NULL) is fine, simplify > win32-aio: Fix how win32_aio_process_completion() frees buffer > block: Fix how mi

Re: [Qemu-devel] Qemu s390x emulation

2013-01-15 Thread Rob Landley
On 01/15/2013 05:45:44 AM, Alexander Graf wrote: On 15.01.2013, at 12:39, Suzuki K. Poulose wrote: > On 01/15/2013 04:39 PM, Alexander Graf wrote: >> >> On 15.01.2013, at 12:05, Suzuki K. Poulose wrote: >> >>> Hi >>> >>> I have been trying to setup a qemu session for qemu-system-s390x (on >>>

[Qemu-devel] [PATCH] block: fix null-pointer bug on error case in block commit

2013-01-15 Thread Jeff Cody
This is a bug that was caught by a coverity run by Markus. In the error case when we errored out to exit_restore_open early in the function, 'overlay_bs' was still NULL at that point, although it is used to look up flags and perform a bdrv_reopen(). Move the overlay_bs lookup to where it is neede

[Qemu-devel] Minutes for KVM call 2013-01-15

2013-01-15 Thread Juan Quintela
* cpu hot plug - use qdev propierties conected to a set of socket objects (anthony) - cpusets are the wrong interface (anthony) - make a link between cpu <-> socket instead of a propierty? - how far are we from being able to describe a cpu with -device? (didn't heare the answer, andrea

[Qemu-devel] [PATCH] dataplane: avoid reentrancy during virtio_blk_data_plane_stop()

2013-01-15 Thread Stefan Hajnoczi
When dataplane is stopping, the s->vdev->binding->set_host_notifier(..., false) call can invoke the virtqueue handler if an ioeventfd notification is pending. This causes hw/virtio-blk.c to invoke virtio_blk_data_plane_start() before virtio_blk_data_plane_stop() returns! The result is that we try

Re: [Qemu-devel] [PATCH 06/20] xen: Simplify halting of first CPU

2013-01-15 Thread Stefano Stabellini
On Tue, 15 Jan 2013, Andreas Färber wrote: > Am 15.01.2013 12:03, schrieb Stefano Stabellini: > > On Tue, 15 Jan 2013, Andreas Färber wrote: > >> Use the global first_cpu variable to halt the CPU rather than using a > >> local first_cpu initialized from qemu_get_cpu(0). > >> > >> This will allow to

[Qemu-devel] [PATCH V3 22/44] virtio-scsi: cleanup: remove qdev field.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic The qdev field is no longer needed. Just drop it. Signed-off-by: KONRAD Frederic --- hw/virtio-scsi.c | 2 -- hw/virtio-scsi.h | 1 - 2 files changed, 3 deletions(-) diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c index a47667d..3566b97 100644 --- a/hw/virtio-scsi.c +++

[Qemu-devel] [PATCH V3 40/44] virtio-serial: cleanup: remove qdev field.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic The qdev field is no longer needed, just drop it. Signed-off-by: KONRAD Frederic --- hw/virtio-serial-bus.c | 2 -- hw/virtio-serial.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index e59dff5..f3ffad3 100644 -

Re: [Qemu-devel] [PULL] pci,virtio

2013-01-15 Thread Michael S. Tsirkin
On Tue, Jan 15, 2013 at 11:09:22AM +0100, Andreas Färber wrote: > Am 13.01.2013 11:47, schrieb Michael S. Tsirkin: > > The following changes since commit 8e4a424b305e29dc0e454f52df3b35577f342975: > > > > Revert "virtio-pci: replace byte swap hack" (2013-01-06 18:30:17 +) > > > > are availab

[Qemu-devel] [PATCH V3 20/44] virtio-scsi: cleanup: use QOM casts.

2013-01-15 Thread fred . konrad
From: KONRAD Frederic As the virtio-scsi-pci and virtio-scsi-s390 are switched to the new API, we can use QOM casts. Signed-off-by: KONRAD Frederic --- hw/virtio-scsi.c | 46 ++ hw/virtio-scsi.h | 2 +- 2 files changed, 27 insertions(+), 21 deletion

Re: [Qemu-devel] [PATCH v2 0/4] Fixes around qemu_vfree()

2013-01-15 Thread Stefan Hajnoczi
On Tue, Jan 15, 2013 at 03:35:43PM +0100, Kevin Wolf wrote: > Am 15.01.2013 15:29, schrieb Markus Armbruster: > > v2: Fix silly mistake in 4/4; the other three patches are unchanged > > > > Markus Armbruster (4): > > w32: Make qemu_vfree() accept NULL like the POSIX implementation > > scsi-dis

Re: [Qemu-devel] [PATCH] define qemukvm-1.2 machine type

2013-01-15 Thread Paolo Bonzini
Il 15/01/2013 04:45, Cole Robinson ha scritto: > Libvirt always specifies an explicit machine type and carries it for the life > of the VM. What we want is for 'qemu-kvm-1.2 -M pc-1.2' to migrate seamlessly > into 'qemu-1.3+ -M pc-1.2' without the user or libvirt having to change > machine type. >

[Qemu-devel] ChangeLog for 1.4

2013-01-15 Thread Paolo Bonzini
Hi, I've been somewhat busy with other things during the early 1.3 cycle so I have no idea what changes went in. I created a stub at http://wiki.qemu.org/ChangeLog/1.4, please fill it in. You're CCed if you sent pull requests during this release cycle. Paolo

[Qemu-devel] [PULL 00/15] Block patches for QEMU 1.4

2013-01-15 Thread Stefan Hajnoczi
Final block pull request for QEMU 1.4. The following changes since commit cf7c3f0cb5a7129f57fa9e69d410d6a05031988c: virtio-9p: fix compilation error. (2013-01-14 18:52:39 -0600) are available in the git repository at: git://github.com/stefanha/qemu.git block for you to fetch changes up to

[Qemu-devel] [PATCH 07/15] ide: fix TRIM with empty range entry

2013-01-15 Thread Stefan Hajnoczi
From: Paolo Bonzini ATA-ACS-3 says "If the two byte range length is zero, then the LBA Range Entry shall be discarded as padding." iovecs are used as if they are linearized, so it is incorrect to discard the rest of this iovec. Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi ---

[Qemu-devel] [PATCH 15/15] block: Fix how mirror_run() frees its buffer

2013-01-15 Thread Stefan Hajnoczi
From: Markus Armbruster It allocates with qemu_blockalign(), therefore it must free with qemu_vfree(), not g_free(). Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mi

[Qemu-devel] [PATCH 10/15] sheepdog: multiplex the rw FD to flush cache

2013-01-15 Thread Stefan Hajnoczi
From: Liu Yuan This will reduce sockfds connected to the sheep server to one, which simply the future hacks. Cc: MORITA Kazutaka Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c | 82 +

[Qemu-devel] [PATCH 12/15] w32: Make qemu_vfree() accept NULL like the POSIX implementation

2013-01-15 Thread Stefan Hajnoczi
From: Markus Armbruster On POSIX, qemu_vfree() accepts NULL, because it's merely wrapper around free(). As far as I can tell, the Windows implementation doesn't. Breeds bugs that bite only under Windows. Make the Windows implementation behave like the POSIX implementation. Signed-off-by: Mark

[Qemu-devel] [PATCH 13/15] scsi-disk: qemu_vfree(NULL) is fine, simplify

2013-01-15 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Acked-by: Paolo Bonzini Reviewed-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/scsi-disk.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index f8d7ef3..96db9a7 100644 ---

[Qemu-devel] [PATCH 0/4] qemu timestamp and related makefile cleanups

2013-01-15 Thread Michael S. Tsirkin
I recently had some build failures because of a stable timestamp file. The following patchset addresses some of the issue I found when going over the makefiles. Michael S. Tsirkin (4): rules.mak: cleanup config generation rules Makefile: clean timestamp generation rule rules/mak: make clean

[Qemu-devel] [PATCH 1/4] rules.mak: cleanup config generation rules

2013-01-15 Thread Michael S. Tsirkin
This addresses two issues with config generation 1. rule generating timestamp has side effect. Thus cleanup on error does not work. 2. rule for handling timestamp is too generic. It can create any missing .h file. As a result when .h file is removed, build might try to create it using this rule whi

[Qemu-devel] [PATCH 05/15] raw: support discard on block devices

2013-01-15 Thread Stefan Hajnoczi
From: Paolo Bonzini Block devices use a ioctl instead of fallocate, so add a separate implementation. Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block/raw-posix.c | 36 1 file changed, 36 insertions(+) diff --git a/block/raw-posix.c b

Re: [Qemu-devel] [PATCH 05/10] xen_platform: do not use old_portio-style callbacks

2013-01-15 Thread Andreas Färber
Stefano, Am 12.01.2013 17:06, schrieb Andreas Färber: > Am 04.01.2013 22:29, schrieb Hervé Poussineau: >> Signed-off-by: Hervé Poussineau >> --- >> hw/xen_platform.c | 21 ++--- >> 1 file changed, 10 insertions(+), 11 deletions(-) >> >> diff --git a/hw/xen_platform.c b/hw/xen_p

[Qemu-devel] [PATCH 01/15] qcow2: Fix segfault on zero-length write

2013-01-15 Thread Stefan Hajnoczi
From: Kevin Wolf One of the recent refactoring patches (commit f50f88b9) didn't take care to initialise l2meta properly, so with zero-length writes, which don't even enter the write loop, qemu just segfaulted. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block/qcow2.c | 2 +-

[Qemu-devel] Fwd: [Users] oVirt Node (HyperVisor) - Memory Usage

2013-01-15 Thread Alex Leonhardt
Hi All, Please could you see below post(s) to the oVirt users list regarding a possible issue with memory usage by VMs running on qemu kvm ? Thanks! Alex Versions: libvirt-client-0.9.10-21.el6_3.7.x86_64 libvirt-0.9.10-21.el6_3.7.x86_64 libvirt-lock-sanlock-0.9.10-21.el6_3.7.x86_64 libvirt-pyt

[Qemu-devel] Qemu s390x emulation

2013-01-15 Thread Suzuki K. Poulose
Hi I have been trying to setup a qemu session for qemu-system-s390x (on x86_64) using a kernel (with initramfs built-in the kernel) without a disk image. The kernel was built with s390 defconfig + disabled loadable modules (just to keep everything inside the kernel). $ qemu-system-s390x -M s390

Re: [Qemu-devel] Qemu s390x emulation

2013-01-15 Thread Suzuki K. Poulose
On 01/15/2013 04:39 PM, Alexander Graf wrote: On 15.01.2013, at 12:05, Suzuki K. Poulose wrote: Hi I have been trying to setup a qemu session for qemu-system-s390x (on x86_64) using a kernel (with initramfs built-in the kernel) without a disk image. The kernel was built with s390 defconfig +

[Qemu-devel] [PULL 0/3] Trivial patches for 12 to 15 January 2013

2013-01-15 Thread Stefan Hajnoczi
Trivial patches for QEMU 1.4. The following changes since commit cf7c3f0cb5a7129f57fa9e69d410d6a05031988c: virtio-9p: fix compilation error. (2013-01-14 18:52:39 -0600) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch changes up to

[Qemu-devel] [PATCH 1/3] Add libcacard/trace/generated-tracers.c to .gitignore

2013-01-15 Thread Stefan Hajnoczi
From: Alex Rozenman Signed-off-by: Alex Rozenman Signed-off-by: Stefan Hajnoczi --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 5fea65d..53fe9c3 100644 --- a/.gitignore +++ b/.gitignore @@ -7,6 +7,7 @@ trace/generated-tracers.h trace/generated-

Re: [Qemu-devel] 3 new x86 instructions

2013-01-15 Thread Richard Henderson
On 01/15/2013 09:14 AM, Torbjorn Granlund wrote: There seem to be no mention of MULX in the i386 subdirectory. Then you got the wrong branch from the repository: translate.c:4055:case 0x3f6: /* mulx By, Gy, rdx, Ey */ You need the "x86-next" branch. r~

[Qemu-devel] [PATCH 03/15] raw-posix: support discard on more filesystems

2013-01-15 Thread Stefan Hajnoczi
From: Kusanagi Kouichi Linux 2.6.38 introduced the filesystem independent interface to deallocate part of a file. As of Linux 3.7, btrfs, ext4, ocfs2, tmpfs and xfs support it. Even though the system calls here are in practice issued on Linux, the code is structured to allow plugging in alternat

[Qemu-devel] [PATCH 2/4] Makefile: clean timestamp generation rule

2013-01-15 Thread Michael S. Tsirkin
create timestamp by rule without sideeffects. Signed-off-by: Michael S. Tsirkin --- trace/Makefile.objs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/trace/Makefile.objs b/trace/Makefile.objs index 27fe26b..dde9d57 100644 --- a/trace/Makefile.objs +++ b/trace/Makefile.o

[Qemu-devel] [PATCH 02/15] block: fix initialization in bdrv_io_limits_enable()

2013-01-15 Thread Stefan Hajnoczi
From: Peter Lieven bdrv_io_limits_enable() starts a new slice, but does not set io_base correctly for that slice. Here is how io_base is used: bytes_base = bs->nr_bytes[is_write] - bs->io_base.bytes[is_write]; bytes_res = (unsigned) nb_sectors * BDRV_SECTOR_SIZE; if (bytes_base

<    1   2   3   4   >