Re: [Qemu-devel] KVM call agenda for 2013-01-08

2013-01-08 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please send in any agenda topics you are interested in. As there are no agenda, no call. Happy New Year to Everybody! Later, Juan.

Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring.

2013-01-08 Thread KONRAD Frédéric
On 08/01/2013 15:02, Michael S. Tsirkin wrote: On Tue, Jan 08, 2013 at 10:56:54AM +0100, KONRAD Frédéric wrote: On 07/01/2013 20:58, Michael S. Tsirkin wrote: On Tue, Dec 18, 2012 at 12:30:20PM +0100, KONRAD Frédéric wrote: On 18/12/2012 12:01, Michael S. Tsirkin wrote: On Tue, Dec 18, 2012 a

[Qemu-devel] [PULL 00/32] usb patch queue

2013-01-08 Thread Gerd Hoffmann
Hi, Time to flush the pretty full usb patch queue, with alot of patches, all posted to the list before xmas. A large part of it are performance improvements and and correctness fixes for ehci+uhci from Hans. Also some ehci sysbus bits and little fixes+cleanups here and there. please pull, G

Re: [Qemu-devel] [PATCH 00/61] Virtio refactoring.

2013-01-08 Thread KONRAD Frédéric
On 08/01/2013 15:21, Peter Maydell wrote: On 7 January 2013 18:40, wrote: From: KONRAD Frederic Here is the full series for virtio-refactoring. You can clone that from here : git.greensocs.com/home/greensocs/git/qemu_virtio.git virtio_refactoring This doesn't work as either an HTTP url or

[Qemu-devel] [PATCH 1/3] xhci: create xhci_detach_slot helper function

2013-01-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 24 ++-- 1 files changed, 18 insertions(+), 6 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 9132920..5d4d876 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -2198,6 +2198,23 @@ static uns

[Qemu-devel] [PATCH 25/32] usb-redir: Add debugging to bufpq save / restore

2013-01-08 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index ad22491..f15dc91 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/re

[Qemu-devel] [PATCH 3/3] xhci: nuke transfe5rs on detach

2013-01-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index b4736f5..f8f5aeb 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -1197,6 +1197,7 @@ static int xhci_ep_nuke_xfer

[Qemu-devel] [PATCH 0/3] xhci fixes

2013-01-08 Thread Gerd Hoffmann
Hi, Little patch series which makes sure xhci cancels inflight transfers on device detach. cheers, Gerd Gerd Hoffmann (3): xhci: create xhci_detach_slot helper function xhci: call xhci_detach_slot on root port detach too xhci: nuke transfe5rs on detach hw/usb/hcd-xhci.c | 31 ++

[Qemu-devel] [PATCH 2/3] xhci: call xhci_detach_slot on root port detach too

2013-01-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 5d4d876..b4736f5 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -2957,6 +2957,7 @@ static void xhci_detach(USBPort *us

[Qemu-devel] [PATCH 11/32] ehci: Don't call commit_irq after raising PCD

2013-01-08 Thread Gerd Hoffmann
From: Hans de Goede ehci_raise_irq(s, USBSTS_PCD), gets applied immediately so there is no need to call commit_irq after it. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-ehc

[Qemu-devel] [PATCH 07/32] ehci: Add an ehci_get_pid helper function

2013-01-08 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index dde2ff3..dae414a 100644 --- a/hw/usb/hcd-ehc

[Qemu-devel] [PATCH 01/32] ehci: Add a ehci_writeback_async_complete_packet helper function

2013-01-08 Thread Gerd Hoffmann
From: Hans de Goede Also drop the warning printf, which was there mainly because this was an untested code path (as the previous bug fixes to it show), but that no longer is the case now :) Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 28

[Qemu-devel] [PATCH 19/32] usb: Add an usb_device_ep_stopped USBDevice method

2013-01-08 Thread Gerd Hoffmann
From: Hans de Goede Some usb devices (host or network redirection) can benefit from knowing when the guest stops using an endpoint. Redirection may involve submitting packets independently from the guest (in combination with a fifo buffer between the redirection code and the guest), to ensure tha

Re: [Qemu-devel] [PATCH] pc: rename machine types

2013-01-08 Thread Gerd Hoffmann
On 01/08/13 14:57, Anthony Liguori wrote: > Gerd Hoffmann writes: > >> Starting with release 1.4 we have a fully functional q35 machine type, >> i.e. "qemu -M q35" JustWorks[tm]. Update machine type names to reflect >> that: >> >> * pc-1.4 becomes piix-1.4 > > PIIX is the southbridge. A more

[Qemu-devel] [PATCH] Check return values from g_poll and select

2013-01-08 Thread Fabien Chouteau
The current implementation of os_host_main_loop_wait() on Windows, returns 1 only when a g_poll() event occurs because the return value of select() is overridden. This is wrong as we may skip a socket event, as shown in this example: 1. select() returns 0 2. g_poll() returns 1 (socket event occur

[Qemu-devel] livelock in iolimits

2013-01-08 Thread Peter Lieven
Hi, i am experimenting with iolimits on a virtio block device and found a lock condition. My plan was to monitor IOPS and/or bandwidth and kick a limit in if a vServer is exhausting these limits too much. However, it seems that if a limit is defined while the defined limit is exceeded no furthe

Re: [Qemu-devel] [PATCH] target-mips: Allow DSP access to be disabled once enabled.

2013-01-08 Thread Aurelien Jarno
On Mon, Jan 07, 2013 at 10:26:44PM -0800, Eric Johnson wrote: > Clear the DSP hflags at the start of compute_hflags. Otherwise access > is not properly disabled once enabled. > > Signed-off-by: Eric Johnson > --- > target-mips/cpu.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [Qemu-devel] [PATCH] target-mips: Fix helper and tests for dot/cross-dot product instructions

2013-01-08 Thread Aurelien Jarno
On Wed, Jan 02, 2013 at 05:08:48AM +0100, Petar Jovanovic wrote: > From: Petar Jovanovic > > Helper function for dpa_w_ph, dpax_w_ph, dps_w_ph and dpsx_w_ph incorrectly > defines halfword vector elements as unsigned values. This results in wrong > output which is not triggered in the tests as the

Re: [Qemu-devel] [PATCH] linux-user: fix mips 32-on-64 prealloc case

2013-01-08 Thread Aurelien Jarno
On Thu, Jan 03, 2013 at 02:17:18PM +0100, Alexander Graf wrote: > MIPS only supports 31 bits of virtual address space for user space, so let's > make sure we stay within that limit with our preallocated memory block. > > This fixes the MIPS user space targets when executed without command line > o

Re: [Qemu-devel] [PATCH] target-mips: Replace macros by inline functions

2013-01-08 Thread Aurelien Jarno
On Tue, Jan 01, 2013 at 07:44:31PM +0100, Stefan Weil wrote: > The macros RESTORE_ROUNDING_MODE and RESTORE_FLUSH_MODE silently used > variable env from their callers. Using inline functions with env passed > as a function argument is more transparent. > > This modification was proposed by Peter M

Re: [Qemu-devel] [PULL 00/31] ppc patch queue 2013-01-07

2013-01-08 Thread Richard Henderson
On 01/08/2013 12:54 AM, Stefan Hajnoczi wrote: > agraf: "zypper search libfdt" on qemu-ppc.opensuse.org turns up no > packages. Any ideas where to get the packages from? Fedora 17 ships them. Either grab the packages from there, or the rpm info points to URL : http://git.jdl.com/gitweb

Re: [Qemu-devel] [PATCH] pc-testdev: use typedefs

2013-01-08 Thread Andreas Färber
Am 08.01.2013 10:31, schrieb Gerd Hoffmann: > Signed-off-by: Gerd Hoffmann Reviewed-by: Andreas Färber Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

[Qemu-devel] [PATCH v2] xen_disk: add persistent grant support to xen_disk backend

2013-01-08 Thread Roger Pau Monne
This protocol extension reuses the same set of grant pages for all transactions between the front/back drivers, avoiding expensive tlb flushes, grant table lock contention and switches between userspace and kernel space. The full description of the protocol can be found in the public blkif.h header

Re: [Qemu-devel] [PATCH 00/61] Virtio refactoring.

2013-01-08 Thread Peter Maydell
On 7 January 2013 19:11, Anthony Liguori wrote: > I appreciate the thoroughness here but 66 patches is too much all at > once. Can this be done in chunks or more reasonable patch sizes? It > would make review and committing a lot easier. So do you have any suggestions? The patchset is long but

Re: [Qemu-devel] [PATCH] configure: Support QEMU cross-compiling for ARM64 host

2013-01-08 Thread Richard Henderson
On 01/08/2013 04:08 AM, Peter Maydell wrote: > The translator sources (as and when we implement a > TCG QEMU target for this) should live under the existing target-arm. Of this I'm not certain, given that A64 is different enough from A32 to warrant a brand new gcc backend. I havn't tried to rever

Re: [Qemu-devel] [PATCH v4 1/2] Add TEWS TPCI200 IndustryPack emulation

2013-01-08 Thread Alberto Garcia
On Tue, Jan 08, 2013 at 02:55:56PM +0100, Andreas Färber wrote: > IPACK_DEVICE() > > You have them defined in the header, please use them consistently. > > Also, please avoid accessing internals like &s->bus.qbus > (BUS(s->bus)) or &s->dev.qdev (DEVICE(s->dev)). Ok, I'm using all the defined ma

Re: [Qemu-devel] [PATCH 1/1] exec: make -mem-path filenames deterministic

2013-01-08 Thread Peter Feiner
> This is not reasonable IMHO. > > I was okay with sticking a name on a ramblock, but encoding a guest PA > offset turns this into a supported ABI which I'm not willing to do. > > A one line change is one thing, but not a complex new option that > introduces an ABI only for a proprietary product th

Re: [Qemu-devel] [PATCH] configure: Support QEMU cross-compiling for ARM64 host

2013-01-08 Thread Peter Maydell
On 8 January 2013 15:57, Richard Henderson wrote: > On 01/08/2013 04:08 AM, Peter Maydell wrote: >> The translator sources (as and when we implement a >> TCG QEMU target for this) should live under the existing target-arm. > > Of this I'm not certain, given that A64 is different enough from A32 >

Re: [Qemu-devel] [PATCH] pc: rename machine types

2013-01-08 Thread Anthony Liguori
Gerd Hoffmann writes: > On 01/08/13 14:57, Anthony Liguori wrote: >> Gerd Hoffmann writes: >> >>> Starting with release 1.4 we have a fully functional q35 machine type, >>> i.e. "qemu -M q35" JustWorks[tm]. Update machine type names to reflect >>> that: >>> >>> * pc-1.4 becomes piix-1.4 >>

Re: [Qemu-devel] [PATCH 08/61] virtio-blk : show VirtIOBlock structure.

2013-01-08 Thread Peter Maydell
On 7 January 2013 18:40, wrote: > virtio-blk : show VirtIOBlock structure. If this survives as a separate patch then this should read "virtio-blk: make VirtIOBlock structure public" > As we discuss with anthony and andreas, this structure must be showed to avoid > two memory allocations for vir

Re: [Qemu-devel] [PATCH 02/20] target-i386: sanitize AMD's ext2_features at realize time

2013-01-08 Thread Andreas Färber
Am 28.12.2012 21:01, schrieb Igor Mammedov: > @@ -2062,6 +2052,17 @@ void x86_cpu_realize(Object *obj, Error **errp) > env->cpuid_level = 7; > } > > +/* On AMD CPUs, some CPUID[8000_0001].EDX bits must match the bits on > + * CPUID[1].EDX. > + */ > +if (env->cpuid_ve

Re: [Qemu-devel] [PATCH v4 1/2] Add TEWS TPCI200 IndustryPack emulation

2013-01-08 Thread Andreas Färber
Am 08.01.2013 16:57, schrieb Alberto Garcia: > On Tue, Jan 08, 2013 at 02:55:56PM +0100, Andreas Färber wrote: > >> IPACK_DEVICE() >> >> You have them defined in the header, please use them consistently. >> >> Also, please avoid accessing internals like &s->bus.qbus >> (BUS(s->bus)) or &s->dev.qde

Re: [Qemu-devel] [PATCH 00/61] Virtio refactoring.

2013-01-08 Thread Anthony Liguori
Peter Maydell writes: > On 7 January 2013 19:11, Anthony Liguori wrote: >> I appreciate the thoroughness here but 66 patches is too much all at >> once. Can this be done in chunks or more reasonable patch sizes? It >> would make review and committing a lot easier. > > So do you have any sugges

Re: [Qemu-devel] [PATCH 00/61] Virtio refactoring.

2013-01-08 Thread Peter Maydell
On 8 January 2013 16:22, Anthony Liguori wrote: > Peter Maydell writes: > >> On 7 January 2013 19:11, Anthony Liguori wrote: >>> I appreciate the thoroughness here but 66 patches is too much all at >>> once. Can this be done in chunks or more reasonable patch sizes? It >>> would make review an

Re: [Qemu-devel] [PULL 0/6] s390 patch queue 2013-01-07

2013-01-08 Thread Anthony Liguori
Alexander Graf writes: > Hi Blue / Aurelien, > > This is my current patch queue for s390. Please pull. > > This time the queue is fixed up to actually compile properly again :). Please say "v2" on the request when you need to resend it. Regards, Anthony Liguori > > Alex > > > The following c

Re: [Qemu-devel] [PATCH v4 1/2] Add TEWS TPCI200 IndustryPack emulation

2013-01-08 Thread Alberto Garcia
On Tue, Jan 08, 2013 at 05:22:35PM +0100, Andreas Färber wrote: > > Tell me if there's anything else I should change, else I can post > > the new patches. > > Haven't looked at the latest 2/2 patch yet, same might apply there. > Otherwise no issues spotted in 1/2. Yes, I updated both patches. Sh

Re: [Qemu-devel] [PATCH] target-arm: Fix SWI (SVC) instruction in M profile.

2013-01-08 Thread Peter Maydell
On 26 December 2012 07:24, Alex Rozenman wrote: > When do_interrupt_v7m is called with EXCP_SWI, the PC already > points to the next instruction. Don't modify it here. > > Signed-off-by: Alex Rozenman Thanks, applied to target-arm.next. -- PMM

Re: [Qemu-devel] [PATCH 01/61] qdev : add a maximum device allowed field for the bus.

2013-01-08 Thread Peter Maydell
On 7 January 2013 18:40, wrote: > From: KONRAD Frederic > > Add a max_dev field to BusClass to specify the maximum amount of devices > allowed > on the bus ( have no effect if max_dev=0 ) "has" (also no spacing needed after '(' or before ')'.) > > Signed-off-by: KONRAD Frederic Reviewed-by:

Re: [Qemu-devel] [PATCH 1/2] e1000: no need auto-negotiation if link was down

2013-01-08 Thread Stefan Hajnoczi
On Tue, Jan 08, 2013 at 05:45:30PM +0800, Amos Kong wrote: > On Mon, Jan 07, 2013 at 01:59:54PM +0100, Stefan Hajnoczi wrote: > > On Sun, Jan 06, 2013 at 01:11:49PM +0800, Amos Kong wrote: > > > On Sat, Jan 05, 2013 at 04:45:14PM +0800, Jason Wang wrote: > > > > On 01/03/2013 08:20 PM, Stefan Hajno

Re: [Qemu-devel] [PATCH 02/61] virtio-bus : introduce virtio-bus

2013-01-08 Thread Peter Maydell
On 7 January 2013 18:40, wrote: > From: KONRAD Frederic > > Introduce virtio-bus. Refactored transport device will create a bus which > extends virtio-bus. > > Signed-off-by: KONRAD Frederic Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2013-01-08 Thread Serge Hallyn
@Peter Schaefer, (replying to comment #12) could you please follow up on comments #6 and #7? It also would be worthwhile, at this point, checking whether latest upstream (1.3) is still broken. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [PATCH 04/61] virtio-pci : refactor virtio-pci device.

2013-01-08 Thread Peter Maydell
On 7 January 2013 18:40, wrote: > From: KONRAD Frederic > > Create the virtio-pci device. This transport device will create a > virtio-pci-bus, so one VirtIODevice can be connected. > > Signed-off-by: KONRAD Frederic > --- > hw/virtio-pci.c | 127 >

Re: [Qemu-devel] [PATCH 03/61] virtio-pci-bus : introduce virtio-pci-bus.

2013-01-08 Thread Peter Maydell
On 7 January 2013 18:40, wrote: > From: KONRAD Frederic > > Introduce virtio-pci-bus, which extends virtio-bus. It is used with virtio-pci > transport device. > > Signed-off-by: KONRAD Frederic This isn't quite right, I think (somebody correct me if I'm wrong!) The virtio-pci-bus subclass does

Re: [Qemu-devel] [PATCH v4 2/2] Add GE IP-Octal 232 IndustryPack emulation

2013-01-08 Thread Andreas Färber
Am 08.01.2013 02:10, schrieb Alberto Garcia: > The GE IP-Octal 232 is an IndustryPack module that implements eight > RS-232 serial ports, each one of which can be redirected to a > character device in the host. > > Signed-off-by: Alberto Garcia > --- > hw/Makefile.objs |2 +- > hw/ipoctal.c

Re: [Qemu-devel] [PATCH 00/20 v4] x86 CPU cleanup (wave 2)

2013-01-08 Thread Andreas Färber
Am 28.12.2012 21:01, schrieb Igor Mammedov: > Igor Mammedov (20): > target-i386: filter out unsupported features at realize time > target-i386: sanitize AMD's ext2_features at realize time > target-i386: explicitly set vendor for each built-in cpudef > target-i386: setting default 'vendor'

Re: [Qemu-devel] [PATCH 1/1] memory: add name in AddressSpace initialization.

2013-01-08 Thread Alexander Barabash
On 01/08/2013 04:00 PM, Anthony Liguori wrote: Alexander Barabash writes: Pass the AddressSpace's name (to be used for debugging) to address_space_init(). If NULL is passed, the name of root memory region is used instead. @@ -1784,13 +1784,11 @@ static void memory_map_init(void) ... m

[Qemu-devel] [PATCH] Makefile: install the "acpi-dsdt.aml" and "q35-acpi-dsdt.aml" blobs too

2013-01-08 Thread Laszlo Ersek
The WARNING message from commit f7e4dd6c made me notice. Signed-off-by: Laszlo Ersek --- Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index a7ac04b..f6626b5 100644 --- a/Makefile +++ b/Makefile @@ -280,6 +280,7 @@ bepo ifdef INSTALL_BLOBS

[Qemu-devel] [PATCH v2 1/1] chardev: Support abstract socket namespace in AF_UNIX socket family.

2013-01-08 Thread Alexander Barabash
The abstract socket namespace is a nonportable Linux extension. The sockets' names in this namespace have no connection with file system pathnames. To specify a named AF_UNIX socket in the abstract socket namespace, pass true for the boolean flag "abstract", e.g.: qemu -chardev socket,path

Re: [Qemu-devel] [PATCH 1/1] exec: make -mem-path filenames deterministic

2013-01-08 Thread Anthony Liguori
Peter Feiner writes: >> This is not reasonable IMHO. >> >> I was okay with sticking a name on a ramblock, but encoding a guest PA >> offset turns this into a supported ABI which I'm not willing to do. >> >> A one line change is one thing, but not a complex new option that >> introduces an ABI onl

[Qemu-devel] [PATCH v3 1/1] memory: add name in AddressSpace initialization.

2013-01-08 Thread Alexander Barabash
Pass the AddressSpace's name (to be used for debugging) to address_space_init(). If NULL is passed, the name of root memory region is used instead. Signed-off-by: Alexander Barabash --- exec.c|6 ++ hw/pci/pci.c |3 ++- include/exec/memory.h |5 +++-- mem

Re: [Qemu-devel] [PATCH 1/1] exec: make -mem-path filenames deterministic

2013-01-08 Thread Peter Maydell
On 8 January 2013 19:04, Anthony Liguori wrote: > This is an internal detail between Xen and QEMU. That doesn't mean it's > a general public API. > > I'm fairly certain that Xen does not support arbitrary versions of QEMU > to be used as qemu-dm. I would have thought that would be a large part o

Re: [Qemu-devel] [PULL 0/4] Net patches

2013-01-08 Thread Anthony Liguori
Pulled, thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL 00/32] usb patch queue

2013-01-08 Thread Anthony Liguori
Pulled, thanks. N.B. This note may be extraneous because the pull request was sent by a version of git older than 1.7.9 making the pull request ambigious. Please consider upgrading to a newer version of git. Regards, Anthony Liguori

[Qemu-devel] [PATCH 03/17] libqemustub: sysbus_get_default() stub

2013-01-08 Thread Andreas Färber
From: Eduardo Habkost The stub will be used on cases where sysbus.c is not compiled in (e.g. *-user). Note that code that uses NULL as the bus with qdev{_try,}_create() implicitly uses sysbus_get_default() as the bus, and will still require sysbus.c to be compiled in. Signed-off-by: Eduardo Hab

[Qemu-devel] [PATCH 06/17] cpu: Change parent type to Device

2013-01-08 Thread Andreas Färber
From: Eduardo Habkost This finally makes the CPU class a subclass of the Device class, allowing us to start using DeviceState properties on CPU subclasses. It has no_user=1, as creating CPUs using -device doesn't work yet. Signed-off-by: Igor Mammedov Signed-off-by: Eduardo Habkost Signed-off

[Qemu-devel] [PATCH 05/17] qdev: Don't assume existence of parent bus on unparenting

2013-01-08 Thread Andreas Färber
Commit 667d22d1ae59da46b4c1fbd094ca61145f19b8c3 (qdev: move bus removal to object_unparent) made the assumption that at unparenting time parent_bus is not NULL. This assumption is unjustified since object_unparent() may well be called directly after object_initialize(), without any qdev_set_parent_

[Qemu-devel] [PATCH 12/17] target-i386: check/enforce: Check SVM flag support as well

2013-01-08 Thread Andreas Färber
From: Eduardo Habkost When nested SVM is supported, the kernel returns the SVM flag on GET_SUPPORTED_CPUID[1], so we can check the SVM flag safely in kvm_check_features_against_host(). I don't know why the original code ignored the SVM flag. Maybe it was because kvm_cpu_fill_host() used the CPUI

[Qemu-devel] [PATCH 17/17] target-i386: Explicitly set vendor for each built-in cpudef

2013-01-08 Thread Andreas Färber
From: Igor Mammedov Since cpudef config is not supported anymore and all remaining sources now always set x86_def_t.vendor[123] fields, remove setting default vendor to simplify future re-factoring. Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Andreas Färber --- t

[Qemu-devel] [PATCH 13/17] target-i386: check/enforce: Eliminate check_feat field

2013-01-08 Thread Andreas Färber
From: Eduardo Habkost Now that all entries have check_feat=~0 in kvm_check_features_against_host(), we can eliminate check_feat entirely and make the code check all bits. This patch shouldn't introduce any behavior change, as check_feat is set to ~0 on all entries. Signed-off-by: Eduardo Habkos

[Qemu-devel] [PATCH 09/17] target-i386: check/enforce: Fix CPUID leaf numbers on error messages

2013-01-08 Thread Andreas Färber
From: Eduardo Habkost The -cpu check/enforce warnings are printing incorrect information about the missing flags. There are no feature flags on CPUID leaves 0 and 0x8000, but there were references to 0 and 0x8000 in the table at kvm_check_features_against_host(). This changes the model_f

[Qemu-devel] [PATCH 15/17] target-i386: Filter out unsupported features at realize time

2013-01-08 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Eduardo Habkost Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Andreas Färber --- target-i386/cpu.c | 31 --- 1 Datei geändert, 16 Zeilen hinzugefügt(+), 15 Zeilen entfernt(-) diff --git a/target-i386

[Qemu-devel] [PATCH 16/17] target-i386: Sanitize AMD's ext2_features at realize time

2013-01-08 Thread Andreas Färber
From: Igor Mammedov When CPU properties are implemented, ext2_features may change between object_new(CPU) and cpu_realize_fn(). Sanitizing ext2_features for AMD based CPU at realize() time will keep current behavior after CPU features are converted to properties. Signed-off-by: Igor Mammedov Re

[Qemu-devel] [PATCH 02/17] libqemustub: vmstate register/unregister stubs

2013-01-08 Thread Andreas Färber
From: Eduardo Habkost Add vmstate stub functions, so that qdev.o can be used without savevm.o when vmstate support is not necessary (i.e. by *-user). Signed-off-by: Eduardo Habkost Signed-off-by: Andreas Färber --- stubs/Makefile.objs |1 + stubs/vmstate.c | 17 + 2

[Qemu-devel] [PATCH 04/17] qdev: Include qdev code into *-user, too

2013-01-08 Thread Andreas Färber
From: Eduardo Habkost The code depends on some functions from qemu-option.o, so add qemu-option.o to universal-obj-y to make sure it's included. Signed-off-by: Eduardo Habkost Signed-off-by: Andreas Färber --- Makefile.objs|8 hw/Makefile.objs |9 +++-- 2 Dateien geän

[Qemu-devel] [PATCH 11/17] target-i386: check/enforce: Check all CPUID.80000001H.EDX bits

2013-01-08 Thread Andreas Färber
From: Eduardo Habkost I have no idea why PPRO_FEATURES was being ignored on the check of the CPUID.8001H.EDX bits. I believe it was a mistake, and it was supposed to be ~(PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) or just ~CPUID_EXT2_AMD_ALIASES, because some time ago kvm_cpu_fill_host() used th

[Qemu-devel] [PATCH 10/17] target-i386: check/enforce: Do not ignore "hypervisor" flag

2013-01-08 Thread Andreas Färber
From: Eduardo Habkost We don't need any hack to ignore CPUID_EXT_HYPERVISOR anymore, because kvm_arch_get_supported_cpuid() now sets CPUID_EXT_HYPERVISOR properly. So, this shouldn't introduce any behavior change, but it makes the code simpler. Signed-off-by: Eduardo Habkost Reviewed-by: Gleb N

[Qemu-devel] [PATCH 08/17] target-i386: kvm: Enable all supported KVM features for -cpu host

2013-01-08 Thread Andreas Färber
From: Eduardo Habkost When using -cpu host, we don't need to use the kvm_default_features variable, as the user is explicitly asking QEMU to enable all feature supported by the host. This changes the kvm_cpu_fill_host() code to use GET_SUPPORTED_CPUID to initialize the kvm_features field, so we

Re: [Qemu-devel] [PATCH qom-cpu 0/7] QOM CPUState, part 7: CPU_COMMON for topology

2013-01-08 Thread Eduardo Habkost
On Mon, Jan 07, 2013 at 06:18:14PM +0100, Andreas Färber wrote: > Am 19.12.2012 16:31, schrieb Andreas Färber: > > Hello, > > > > This series moves more fields from CPU_COMMON / CPU*State to CPUState, > > allowing access from target-independent code. It is an intermediate step in > > the effort to

[Qemu-devel] [PATCH 1/2] qemu-ga: ga_open_pidfile(): use qemu_open()

2013-01-08 Thread Luiz Capitulino
This ensures that O_CLOEXEC is passed to open(), this way the pid file fd is not leaked to executed processes. Signed-off-by: Luiz Capitulino --- qga/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index ba5fa1c..e4245cc 100644 --- a/qga/main.c

[Qemu-devel] [PATCH 2/2] qemu-ga: add ga_open_logfile()

2013-01-08 Thread Luiz Capitulino
This function sets O_CLOEXEC on the log file fd so that it isn't leaked to executed processes. Signed-off-by: Luiz Capitulino --- qga/main.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/qga/main.c b/qga/main.c index e4245cc..15be74f 100644 --- a/qga/main

[Qemu-devel] [PATCH 0/2] qemu-ga: don't leak fds to exec()ed processes

2013-01-08 Thread Luiz Capitulino
Please, check individual patches for details. Luiz Capitulino (2): qemu-ga: ga_open_pidfile(): use qemu_open() qemu-ga: add ga_open_logfile() qga/main.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) -- 1.8.0

[Qemu-devel] [PATCH 07/17] target-i386: kvm: -cpu host: Use GET_SUPPORTED_CPUID for SVM features

2013-01-08 Thread Andreas Färber
From: Eduardo Habkost The existing -cpu host code simply sets every bit inside svm_features (initializing it to -1), and that makes it impossible to make the enforce/check options work properly when the user asks for SVM features explicitly in the command-line. So, instead of initializing svm_fe

Re: [Qemu-devel] [PATCH 14/17] qemu-common.h: Make qemu_init_vcpu() stub static inline

2013-01-08 Thread Richard Henderson
On 01/08/2013 12:56 PM, Andreas Färber wrote: > Turn the *-user macro into a no-op inline function to avoid > unused-variable warnings and band-aiding #ifdef'ery. > > This allows to drop an #ifdef for alpha and avoids more for unicore32 > and other upcoming trivial realizefn implementations. > >

[Qemu-devel] [PATCH 14/17] qemu-common.h: Make qemu_init_vcpu() stub static inline

2013-01-08 Thread Andreas Färber
Turn the *-user macro into a no-op inline function to avoid unused-variable warnings and band-aiding #ifdef'ery. This allows to drop an #ifdef for alpha and avoids more for unicore32 and other upcoming trivial realizefn implementations. Suggested-by: Lluís Vilanova Signed-off-by: Eduardo Habkost

[Qemu-devel] [PATCH 01/17] libqemustub: Add qemu_[un]register_reset() stubs

2013-01-08 Thread Andreas Färber
From: Eduardo Habkost This will be useful for code that don't call qemu_devices_reset() (e.g. *-user). If qemu_devices_reset() is never called, it means we don't need to keep track of the reset handler list. Signed-off-by: Eduardo Habkost Signed-off-by: Andreas Färber --- stubs/Makefile.objs

[Qemu-devel] [RFC PATCH] PIIX: reset the VM when the Reset Control Register's RCPU bit gets set

2013-01-08 Thread Laszlo Ersek
>From : Traditional PCI config space access is achieved by writing a 32 bit value to io port 0xcf8 to identify the bus, device, function and config register. Port 0xcfc then contains the register in question. But if you write the appropriate pair of m

[Qemu-devel] [PULL] QOM CPUState patch queue 2013-01-08

2013-01-08 Thread Andreas Färber
Hello, This is my current QOM CPU patch queue. Please pull. It includes: * CPU as a device, * improvements for x86 -cpu host, * cleanups and preparations for QOM realize. Another pull is intended before the Soft Freeze. Regards, Andreas Cc: Anthony Liguori Cc: Eduardo Habkost Cc: Igor Mammed

Re: [Qemu-devel] [PULL] QOM CPUState patch queue 2013-01-08

2013-01-08 Thread Andreas Färber
Am 08.01.2013 21:56, schrieb Andreas Färber: > Hello, > > This is my current QOM CPU patch queue. Please pull. > > It includes: > * CPU as a device, > * improvements for x86 -cpu host, > * cleanups and preparations for QOM realize. > > Another pull is intended before the Soft Freeze. > > Regard

Re: [Qemu-devel] [PULL] QOM CPUState patch queue 2013-01-08

2013-01-08 Thread Anthony Liguori
Pulled, thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL] QOM CPUState patch queue 2013-01-08

2013-01-08 Thread Anthony Liguori
Andreas Färber writes: > Am 08.01.2013 21:56, schrieb Andreas Färber: >> Hello, >> >> This is my current QOM CPU patch queue. Please pull. >> >> It includes: >> * CPU as a device, >> * improvements for x86 -cpu host, >> * cleanups and preparations for QOM realize. >> >> Another pull is intende

Re: [Qemu-devel] [PATCH v8 0/2] qemu-ga: add hook to quiesce the guest on fsfreeze-freeze/thaw

2013-01-08 Thread mdroth
On Wed, Dec 12, 2012 at 12:55:47PM +0900, Tomoki Sekiyama wrote: > Hi, > > This is version 8 of the qemu-ga fsfreeze hook patchset. Thanks, applied to qga branch with some minor clarifications for the help output. > > *Changes from v7: ( http://patchwork.ozlabs.org/patch/204426/ ) > 1/2: Not c

[Qemu-devel] [PULL 0/12] qemu-ga: error handling improvements and fsfreeze hooks

2013-01-08 Thread Michael Roth
The following changes since commit 4b274b1603e1d15ef51aedc8b6b7ebbae0b555ce: Merge remote-tracking branch 'afaerber/qom-cpu' into staging (2013-01-08 15:15:57 -0600) are available in the git repository at: git://github.com/mdroth/qemu.git qga-pull-1-8-2013 for you to fetch changes up to 9

[Qemu-devel] [PATCH 06/12] qemu-ga: qmp_guest_fsfreeze_*(): get rid of sprintf() + error_set()

2013-01-08 Thread Michael Roth
From: Luiz Capitulino Convert them to error_setg_errno(). Signed-off-by: Luiz Capitulino Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- qga/commands-posix.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c

[Qemu-devel] [PATCH 08/12] qemu-ga: qmp_guest_network_get_interfaces(): get rid of snprintf() + error_set()

2013-01-08 Thread Michael Roth
From: Luiz Capitulino Convert them to error_setg_errno(). Signed-off-by: Luiz Capitulino Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- qga/commands-posix.c | 29 - 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/qga/commands-posix.c b/

Re: [Qemu-devel] [PATCH 1/2] qemu-ga: ga_open_pidfile(): use qemu_open()

2013-01-08 Thread Eric Blake
On 01/08/2013 02:26 PM, Luiz Capitulino wrote: > This ensures that O_CLOEXEC is passed to open(), this way the > pid file fd is not leaked to executed processes. > > Signed-off-by: Luiz Capitulino > --- > qga/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH 2/2] qemu-ga: add ga_open_logfile()

2013-01-08 Thread Eric Blake
On 01/08/2013 02:26 PM, Luiz Capitulino wrote: > This function sets O_CLOEXEC on the log file fd so that it isn't > leaked to executed processes. > > Signed-off-by: Luiz Capitulino > --- > qga/main.c | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) Reviewed-by: Eric Bl

[Qemu-devel] [PATCH 12/12] qemu-ga: sample fsfreeze hooks

2013-01-08 Thread Michael Roth
From: Tomoki Sekiyama Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ - fsfreeze-hook.d/mysql-flush.sh.sample : quiesce MySQL before snapshot Signed-off-by: Tomoki Sekiyama Reviewed-by: Michael Roth Signed-off-by: Michae

[Qemu-devel] [PATCH 10/12] qemu-ga: guest_suspend(): improve error reporting

2013-01-08 Thread Michael Roth
From: Luiz Capitulino Most errors are QERR_UNDEFINED_ERROR today. Signed-off-by: Luiz Capitulino Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- qga/commands-posix.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/qga/commands-p

Re: [Qemu-devel] [RFC PATCH v4 21/30] Implement dimm-info

2013-01-08 Thread Eric Blake
On 12/18/2012 05:41 AM, Vasilis Liaskovitis wrote: > "query-dimm-info" and "info dimm" will give current state of all dimms in the > system e.g. > > dimm0: on > dimm1: off > dimm2: off > dimm3: on > etc. > > Signed-off-by: Vasilis Liaskovitis > --- > +++ b/qapi-schema.json > @@ -2914,6 +2914,32

[Qemu-devel] [PATCH 04/12] qemu-ga: qmp_guest_shutdown(): improve error reporting

2013-01-08 Thread Michael Roth
From: Luiz Capitulino Most errors are QERR_UNDEFINED_ERROR. Also, adds ga_wait_child() as a future commit will use it too. Signed-off-by: Luiz Capitulino Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- qga/commands-posix.c | 48 ++-- 1

[Qemu-devel] [PATCH 07/12] qemu-ga: qmp_guest_fstrim(): get rid of sprintf() + error_set()

2013-01-08 Thread Michael Roth
From: Luiz Capitulino Convert them to error_setg_errno(). Signed-off-by: Luiz Capitulino Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- qga/commands-posix.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c

Re: [Qemu-devel] [PULL] QOM CPUState patch queue 2013-01-08

2013-01-08 Thread Andreas Färber
Am 08.01.2013 23:34, schrieb Anthony Liguori: > Andreas Färber writes: > >> Am 08.01.2013 21:56, schrieb Andreas Färber: >>> Hello, >>> >>> This is my current QOM CPU patch queue. Please pull. >>> >>> It includes: >>> * CPU as a device, >>> * improvements for x86 -cpu host, >>> * cleanups and pre

[Qemu-devel] [PATCH 02/12] qemu-ga: qmp_guest_file_close(): fix fclose() error check

2013-01-08 Thread Michael Roth
From: Luiz Capitulino fclose() returns EOF on error. Signed-off-by: Luiz Capitulino Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- qga/commands-posix.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index bbef66d.

[Qemu-devel] [PATCH 03/12] qemu-ga: qmp_guest_file_*: improve error reporting

2013-01-08 Thread Michael Roth
From: Luiz Capitulino Use error_setg_errno() when possible with an improved error description. Signed-off-by: Luiz Capitulino Signed-off-by: Michael Roth --- qga/commands-posix.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/qga/commands-posix.c

[Qemu-devel] [PATCH 01/12] qemu-ga: guest_file_handle_find(): take an Error argument

2013-01-08 Thread Michael Roth
From: Luiz Capitulino Signed-off-by: Luiz Capitulino Reviewed-by: Michael Roth *Fixed missing space character in error message Signed-off-by: Michael Roth --- qga/commands-posix.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/qga/commands-posix.c

[Qemu-devel] [PATCH 05/12] qemu-ga: build_fs_mount_list(): take an Error argument

2013-01-08 Thread Michael Roth
From: Luiz Capitulino Signed-off-by: Luiz Capitulino Signed-off-by: Michael Roth --- qga/commands-posix.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 247e8dc..f7b85b2 100644 --- a/qga/c

[Qemu-devel] [PATCH 11/12] qemu-ga: execute hook to quiesce the guest on fsfreeze-freeze/thaw

2013-01-08 Thread Michael Roth
From: Tomoki Sekiyama To use the online disk snapshot for online-backup, application-level consistency of the snapshot image is required. However, currently the guest agent can provide only filesystem-level consistency, and the snapshot may contain dirty data, for example, incomplete transactions

[Qemu-devel] [PATCH 09/12] qemu-ga: bios_supports_mode(): improve error reporting

2013-01-08 Thread Michael Roth
From: Luiz Capitulino Most errors are QERR_UNDEFINED_ERROR today. Signed-off-by: Luiz Capitulino Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- qga/commands-posix.c | 46 +++--- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git

Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2013-01-08 Thread Andreas Färber
Am 18.12.2012 13:41, schrieb Vasilis Liaskovitis: > Because dimm layout needs to be configured on machine-boot, all dimm devices > need to be specified on startup command line (either with populated=on or with > populated=off). The dimm information is stored in dimm configuration > structures. >

Re: [Qemu-devel] [RFC PATCH v4 06/30] qapi: make visit_type_size fallback to type_int

2013-01-08 Thread Andreas Färber
Am 18.12.2012 13:41, schrieb Vasilis Liaskovitis: > Currently visit_type_size checks if the visitor's type_size function pointer > is > NULL. If not, it calls it, otherwise it calls v->type_uint64(). But neither of > these pointers are ever set. Fallback to calling v->type_int() in this third > (d

<    1   2   3   >