Re: [Qemu-devel] [Resend][Seabios PATCH] don't boot from un-selected devices

2012-12-19 Thread Amos Kong
On Wed, Dec 19, 2012 at 08:38:13AM +0100, Gerd Hoffmann wrote: > On 12/19/12 08:24, Amos Kong wrote: > > Current seabios will try to boot from selected devices first, > > if they are all failed, seabios will also try to boot from > > un-selected devices. > > > > For example: > > @ qemu-kvm -boot o

Re: [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386

2012-12-19 Thread Paolo Bonzini
Il 28/11/2012 10:53, Alon Levy ha scritto: >> Il 28/11/2012 10:16, Alon Levy ha scritto: >>> > > diff --git a/roms/openbios b/roms/openbios >>> > > index f095c85..d1d2787 16 >>> > > --- a/roms/openbios >>> > > +++ b/roms/openbios >>> > > @@ -1 +1 @@ >>> > > -Subproject commit f095c858136896d236

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-19 Thread Paolo Bonzini
Il 19/12/2012 03:13, Alexander Graf ha scritto: > Does making libfdt a submodule really change things? Developers would > still have to init the submodule. They could just as well install the > libfdt-devel packet from their distro of choice instead :). RHEL does not have it unfortunately. I requ

[Qemu-devel] [PATCH v2] qemu-kvm/pci-assign: 64 bits bar emulation

2012-12-19 Thread Xudong Hao
Enable 64 bits bar emulation. v2 changes from v1: - Change 0lx% to 0x%016 when print a 64 bit variable. Test pass with the current seabios which already support 64bit pci bars. Signed-off-by: Xudong Hao --- hw/kvm/pci-assign.c | 22 ++ 1 files changed, 14 insertions(+), 8

Re: [Qemu-devel] [PATCH 1/2] hw: add isa-debug-exit device v3

2012-12-19 Thread Gerd Hoffmann
> Hello Anthony, > > So, there's this device that we need to get the test dev upstream to > support kvm-unit-tests and get rid of testing qemu-kvm.git once for all. > Hervé sent a similar patch, with some important differences (access > sizes >1). /me updated debug exit device so it handles all a

Re: [Qemu-devel] [PATCH 0/3] virtio: don't poll masked vectors with irqfd

2012-12-19 Thread Asias He
On 12/18/2012 08:39 PM, Michael S. Tsirkin wrote: > At the moment when vector is masked virtio will poll it > in userspace, even if it is handled by irqfd. > This is done in order to update pending bits, but > it's not really required until someone reads the pending bits. > On the other hand this r

Re: [Qemu-devel] [PATCH 3/3] virtio-pci: don't poll masked vectors

2012-12-19 Thread Asias He
On 12/18/2012 08:39 PM, Michael S. Tsirkin wrote: > At the moment, when irqfd is in use but a vector is masked, > qemu will poll it and handle vector masks in userspace. > Since almost no one ever looks at the pending bits, > it is better to defer this until pending bits > are actually read. > Impl

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-19 Thread Gerd Hoffmann
On 12/14/12 19:51, Scott Wood wrote: > On 12/14/2012 02:13:53 AM, Gerd Hoffmann wrote: >> Hi, >> >> > Yes, I could manually install it, though then I get to deal with >> telling >> > the pixman build exactly where to install itself, and repeating the >> > process for each toolchain and multilib-v

[Qemu-devel] [PATCH 0/8] misc acpi updates and test devices

2012-12-19 Thread Gerd Hoffmann
Hi, Next round of the minor acpi update patch series. The acpi bits are actually unchanged. The debug-exit device got updates. It handles byte, word + dword access. Also the io region size is configurable now. While being at it I also picked up the pc-testdev, polished it a bit (portio list

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-19 Thread Gerd Hoffmann
Hi, >> # ls -l /usr/bin/*-gcc >> -rwxr-xr-x. 2 root root 264112 Aug 23 2011 /usr/bin/i686-pc-mingw32-gcc >> -rwxr-xr-x. 2 root root 268216 Oct 18 18:24 >> /usr/bin/x86_64-redhat-linux-gcc >> >> I think the second part ("pc" / "redhat") can be choosen pretty freely >> when building gcc, so you c

[Qemu-devel] [PATCH 1/8] configure: also symlink *.aml files

2012-12-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 728caca..ec6f961 100755 --- a/configure +++ b/configure @@ -4197,6 +4197,7 @@ FILES="$FILES pc-bios/spapr-rtas/Makefile" FILES="$FILES roms/seabios/Make

[Qemu-devel] [PATCH 3/8] apci: assign memory regions to piix4 acpi device

2012-12-19 Thread Gerd Hoffmann
Get rid of get_system_io() usage. Signed-off-by: Gerd Hoffmann --- hw/acpi_piix4.c | 20 +--- 1 files changed, 13 insertions(+), 7 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 0b5b0d3..30bafb6 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -57,6 +57

Re: [Qemu-devel] [PATCH 26/26] usbredir: Add support for buffered bulk input

2012-12-19 Thread Hans de Goede
Hi, On 12/18/2012 02:36 PM, Gerd Hoffmann wrote: Hi, Added patches 1-25 to the usb queue (using v2 of patch 10). hw/usb/redirect-ftdi-ids.h | 1255 ++ hw/usb/redirect-pl2303-ids.h | 150 + hw/usb/redirect-usb-ids.h| 910 ++

[Qemu-devel] [PATCH 4/8] apci: assign memory regions to ich9 lpc device

2012-12-19 Thread Gerd Hoffmann
Get rid of get_system_io() usage. Signed-off-by: Gerd Hoffmann --- hw/acpi_ich9.c |6 -- hw/acpi_ich9.h |4 +++- hw/lpc_ich9.c |2 +- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c index c5978d3..b895422 100644 --- a/hw/acpi_ich9.c

[Qemu-devel] [PATCH 5/8] switch debugcon to memory api

2012-12-19 Thread Gerd Hoffmann
Also some QOM glue while being at it. Signed-off-by: Gerd Hoffmann --- hw/debugcon.c | 31 --- 1 files changed, 24 insertions(+), 7 deletions(-) diff --git a/hw/debugcon.c b/hw/debugcon.c index 14ab326..3cde16c 100644 --- a/hw/debugcon.c +++ b/hw/debugcon.c @@ -29,

Re: [Qemu-devel] [PATCH v2 1/2] pc_sysfw: Check for qemu_find_file() failure

2012-12-19 Thread Stefan Hajnoczi
On Wed, Dec 05, 2012 at 03:28:05PM +0100, Markus Armbruster wrote: > pc_fw_add_pflash_drv() ignores qemu_find_file() failure, and happily > creates a drive without a medium. > > When pc_system_flash_init() asks for its size, bdrv_getlength() fails > with -ENOMEDIUM, which isn't checked either. It

Re: [Qemu-devel] [Resend][Seabios PATCH] don't boot from un-selected devices

2012-12-19 Thread Gleb Natapov
On Wed, Dec 19, 2012 at 03:24:45PM +0800, Amos Kong wrote: > Current seabios will try to boot from selected devices first, > if they are all failed, seabios will also try to boot from > un-selected devices. > > For example: > @ qemu-kvm -boot order=n,menu=on ... > > Guest will boot from network f

[Qemu-devel] [PATCH 2/8] acpi: autoload dsdt

2012-12-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pc.c | 23 +++ hw/pc.h |1 + hw/pc_piix.c |1 + hw/pc_q35.c |1 + 4 files changed, 26 insertions(+), 0 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index b11e7c4..cc4b260 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -886,6

[Qemu-devel] [PATCH 7/8] hw: Add test device for unittests execution

2012-12-19 Thread Gerd Hoffmann
From: Lucas Meneghel Rodrigues Add a test device which supports the kvmctl ioports, so one can run the KVM unittest suite. Intended Usage: qemu-system-x86_64 -nographic \ -device pc-testdev \ -device isa-debug-exit,iobase=0xf4,iosize=0x04 \ -kernel /path/to/kvm/unittests/msr.flat W

[Qemu-devel] [PATCH 8/8] pc: remove bochs bios debug ports

2012-12-19 Thread Gerd Hoffmann
Prehistoric leftover, zap it. We poweroff via acpi these days. And having a port (0x501,0x502) where any random guest write will make qemu exit -- with no way to turn it off -- is a bad joke anyway. Signed-off-by: Gerd Hoffmann --- hw/pc.c | 41 - 1 fi

[Qemu-devel] [PATCH 6/8] add isa-debug-exit device.

2012-12-19 Thread Gerd Hoffmann
When present it makes qemu exit on any write. Mapped to port 0x501 by default. Without this patch Anthony doesn't allow me to remove the bochs bios debug ports because his test suite uses this. Signed-off-by: Gerd Hoffmann --- hw/debugexit.c| 75 +++

Re: [Qemu-devel] [PATCH 26/26] usbredir: Add support for buffered bulk input

2012-12-19 Thread Gerd Hoffmann
Hi, > These 2 are 1 on 1 copies from the kernel: > > hw/usb/redirect-ftdi-ids.h | 1255 > ++ > hw/usb/redirect-pl2303-ids.h | 150 + > > They contain "boring" stuff like: > > #define FTDI_8U232AM_PID 0x6001 /* Similar device to SIO above */ > #defi

[Qemu-devel] [RFC PATCH V8 04/15] virtio-pci : Refactor virtio-pci device.

2012-12-19 Thread fred . konrad
From: KONRAD Frederic Create the virtio-pci device. This transport device will create a virtio-pci-bus, so one VirtIODevice can be connected. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 130 hw/virtio-pci.h | 19 + 2 fi

[Qemu-devel] [RFC PATCH V8 09/15] virtio-blk-pci : Switch to new API.

2012-12-19 Thread fred . konrad
From: KONRAD Frederic Here the virtio-blk-pci is modified for the new API. The device virtio-blk-pci extends virtio-pci. It creates and connects a virtio-blk during the init. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 106 +--- hw/v

[Qemu-devel] [RFC PATCH V8 13/15] virtio : Remove the function pointer.

2012-12-19 Thread fred . konrad
From: KONRAD Frederic This remove the function pointer in VirtIODevice, and use only VirtioDeviceClass function pointer. It should be applied after all the device have been refactored. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 5 - hw/virtio-pci.c | 2 +- hw/virtio.c | 41

[Qemu-devel] [RFC PATCH V8 12/15] virtio-blk : cleanup : remove qdev field.

2012-12-19 Thread fred . konrad
From: KONRAD Frederic The qdev field is not needed, just drop it. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 93b9746..65932fd 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.

[Qemu-devel] [PATCH 0/3] HMP: enable info sub command taking parameter

2012-12-19 Thread Wenchao Xia
This serial of patch will enhance HMP's info command, make all command possible to take additional parameter. Please review to see if it have problem. Wenchao Xia (3): HMP: add QDict to info callback handler HMP: pass in parameter for info sub command HMP: show internal snapshots on a sing

[Qemu-devel] [PATCH 1/3] HMP: add QDict to info callback handler

2012-12-19 Thread Wenchao Xia
This patch change all info call back function to take additional QDict * parameter, which allow those command take parameter. Signed-off-by: Wenchao Xia --- hmp.c | 36 ++-- hmp.h | 36 ++-- hw/i825

[Qemu-devel] [PATCH 2/3] HMP: pass in parameter for info sub command

2012-12-19 Thread Wenchao Xia
This patch enable sub info command handler getting meaningful parameter. Signed-off-by: Wenchao Xia --- hmp-commands.hx |2 +- monitor.c | 79 +++ 2 files changed, 57 insertions(+), 24 deletions(-) diff --git a/hmp-commands.hx b/

[Qemu-devel] [PATCH 3/3] HMP: show internal snapshots on a single device

2012-12-19 Thread Wenchao Xia
This patch add an option to show snapshots on a single block device, so some snapshot do not exist on other block device could be shown. Signed-off-by: Wenchao Xia --- monitor.c |6 +++--- savevm.c | 55 ++- 2 files changed, 57 inserti

[Qemu-devel] [RFC PATCH V8 05/15] virtio-device : Refactor virtio-device.

2012-12-19 Thread fred . konrad
From: KONRAD Frederic Create the virtio-device which is abstract. All the virtio-device can extend this class. Signed-off-by: KONRAD Frederic --- hw/virtio.c | 70 ++--- hw/virtio.h | 31 +++ 2 files changed, 89 in

[Qemu-devel] [RFC PATCH V8 10/15] virtio-blk-s390 : Switch to the new API.

2012-12-19 Thread fred . konrad
From: KONRAD Frederic Here the virtio-blk-s390 is modified for the new API. The device virtio-blk-s390 extends virtio-s390-device. It creates and connects a virtio-blk during the init. Signed-off-by: KONRAD Frederic --- hw/s390-virtio-bus.c | 11 +-- 1 file changed, 5 insertions(+), 6

[Qemu-devel] [RFC PATCH V8 00/15] Virtio refactoring.

2012-12-19 Thread fred . konrad
From: KONRAD Frederic You can clone that from here : git.greensocs.com/home/greensocs/git/qemu_virtio.git virtio_refactoring_v8 The new modifications : * start the s390-virtio-bus refactoring. * add some virtio cleanup as moving VirtioBindings to VirtioBusClass and moving the Virt

[Qemu-devel] [RFC PATCH V8 01/15] qdev : add a maximum device allowed field for the bus.

2012-12-19 Thread fred . konrad
From: KONRAD Frederic Add a max_dev field to BusState to specify the maximum amount of devices allowed on the bus ( have no effect if max_dev=0 ) Signed-off-by: KONRAD Frederic --- hw/qdev-core.h| 2 ++ hw/qdev-monitor.c | 11 +++ 2 files changed, 13 insertions(+) diff --git a/hw

[Qemu-devel] [RFC PATCH V8 07/15] virtio-s390-device : create a virtio-s390-bus during init.

2012-12-19 Thread fred . konrad
From: KONRAD Frederic Create a virtio-s390-bus during init, so the refactored virtio device can be connected. Signed-off-by: KONRAD Frederic --- hw/s390-virtio-bus.c | 2 ++ hw/s390-virtio-bus.h | 1 + 2 files changed, 3 insertions(+) diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c i

[Qemu-devel] [RFC PATCH V8 02/15] virtio-bus : Introduce virtio-bus

2012-12-19 Thread fred . konrad
From: KONRAD Frederic Introduce virtio-bus. Refactored transport device will create a bus which extends virtio-bus. Signed-off-by: KONRAD Frederic --- hw/Makefile.objs | 1 + hw/virtio-bus.c | 169 +++ hw/virtio-bus.h | 98 ++

[Qemu-devel] [RFC PATCH V8 11/15] virtio-blk : cleanup : use QOM cast.

2012-12-19 Thread fred . konrad
From: KONRAD Frederic As the virtio-blk-pci is switched to the new API, we can use QOM casts and remove the separate init for the old API. This shouldn't been applyied before virtio-blk-pci refactoring and virtio-blk-s390 refactoring. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 117 ++

[Qemu-devel] [RFC PATCH V8 15/15] virtio : cleanup : init and exit function.

2012-12-19 Thread fred . konrad
From: KONRAD Frederic Clean the init and the exit function. It should be applied when all the device have been refactored. Signed-off-by: KONRAD Frederic --- hw/virtio.c | 15 --- hw/virtio.h | 4 2 files changed, 19 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index

[Qemu-devel] [RFC PATCH V8 08/15] virtio-blk : Add the virtio-blk device.

2012-12-19 Thread fred . konrad
From: KONRAD Frederic Create virtio-blk which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 101 +++- hw/virtio-blk.h | 19 +++ hw/virtio-pci.c | 7 ++-- 3 files c

[Qemu-devel] [RFC PATCH V8 06/15] virtio-s390-bus : Add virtio-s390-bus.

2012-12-19 Thread fred . konrad
From: KONRAD Frederic Introduce virtio-s390-bus, which extends virtio-bus. It is used with s390 transport device. Signed-off-by: KONRAD Frederic --- hw/s390-virtio-bus.c | 28 hw/s390-virtio-bus.h | 13 + 2 files changed, 41 insertions(+) diff --git a/

[Qemu-devel] [RFC PATCH V8 14/15] virtio : Remove VirtIOBindings.

2012-12-19 Thread fred . konrad
From: KONRAD Frederic This remove VirtIOBindings and use VirtioBusClass instead. It should be applied when all the device have been refactored. Signed-off-by: KONRAD Frederic --- hw/virtio-bus.c | 20 hw/virtio-bus.h | 6 -- hw/virtio.c | 52 ++

[Qemu-devel] [RFC PATCH V8 03/15] virtio-pci-bus : Introduce virtio-pci-bus.

2012-12-19 Thread fred . konrad
From: KONRAD Frederic Introduce virtio-pci-bus, which extends virtio-bus. It is used with virtio-pci transport device. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 37 + hw/virtio-pci.h | 19 +-- 2 files changed, 54 insertions(+), 2 d

Re: [Qemu-devel] [PATCH 3/3] virtio-pci: don't poll masked vectors

2012-12-19 Thread Michael S. Tsirkin
On Wed, Dec 19, 2012 at 04:59:05PM +0800, Asias He wrote: > On 12/18/2012 08:39 PM, Michael S. Tsirkin wrote: > > At the moment, when irqfd is in use but a vector is masked, > > qemu will poll it and handle vector masks in userspace. > > Since almost no one ever looks at the pending bits, > > it is

Re: [Qemu-devel] [PATCH 0/3] virtio: don't poll masked vectors with irqfd

2012-12-19 Thread Michael S. Tsirkin
On Wed, Dec 19, 2012 at 04:53:22PM +0800, Asias He wrote: > On 12/18/2012 08:39 PM, Michael S. Tsirkin wrote: > > At the moment when vector is masked virtio will poll it > > in userspace, even if it is handled by irqfd. > > This is done in order to update pending bits, but > > it's not really requi

Re: [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API

2012-12-19 Thread Luiz Capitulino
On Tue, 18 Dec 2012 14:34:16 -0700 Eric Blake wrote: > On 12/17/2012 03:13 AM, Dietmar Maurer wrote: > >> Next commit will re-enable balloon stats with a different interface, but > >> this > >> old code conflicts with it. Let's drop it. > > > > I don't really see any conflicts here? > > > >> I

Re: [Qemu-devel] [RFC 3/3] virtio-balloon: add auto-ballooning support

2012-12-19 Thread Luiz Capitulino
On Tue, 18 Dec 2012 14:53:30 -0800 Anton Vorontsov wrote: > Hello Luiz, > > On Tue, Dec 18, 2012 at 06:16:55PM -0200, Luiz Capitulino wrote: > > The auto-ballooning feature automatically performs balloon inflate > > or deflate based on host and guest memory pressure. This can help to > > avoid s

Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2012-12-19 Thread Vasilis Liaskovitis
Hi, On Wed, Dec 19, 2012 at 08:27:36AM +0100, Gerd Hoffmann wrote: > Hi, > > > - multiple memory buses can be registered. Memory buses of the real > > hw/chipset > > or a paravirtual memory bus can be added. > > IIRC q35 supports memory hotplug natively (picked up in some > discussion). Is

Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2012-12-19 Thread Vasilis Liaskovitis
On Wed, Dec 19, 2012 at 12:45:46AM +0800, Zhi Yong Wu wrote: > HI, > > One stupid question, 'dimm' presents one guest memory, then why it is > called as "dimm"? what is its full name? it's a bad name coming from dram technology (dual in-line memory module). Memory-slot or memory-module is probabl

Re: [Qemu-devel] [PATCH] e1000: Discard oversized packets based on SBP|LPE

2012-12-19 Thread Stefan Hajnoczi
On Tue, Dec 18, 2012 at 12:34:22PM -0500, Michael Contreras wrote: > On Tue, Dec 18, 2012 at 05:49:16PM +0100, Stefan Hajnoczi wrote: > > On Tue, Dec 18, 2012 at 5:20 PM, Michael Tokarev wrote: > > > On 18.12.2012 17:44, Stefan Hajnoczi wrote: > > >> On Wed, Dec 05, 2012 at 01:31:30PM -0500, Micha

Re: [Qemu-devel] [PATCH 26/26] usbredir: Add support for buffered bulk input

2012-12-19 Thread Hans de Goede
Hi, On 12/19/2012 10:51 AM, Gerd Hoffmann wrote: Hi, These 2 are 1 on 1 copies from the kernel: hw/usb/redirect-ftdi-ids.h | 1255 ++ hw/usb/redirect-pl2303-ids.h | 150 + They contain "boring" stuff like: #define FTDI_8U232AM_PID 0x6001 /* Si

Re: [Qemu-devel] [Bug 1091766] Re: Physical host crash with Mellanox IB PCI passthrough

2012-12-19 Thread Vlastimil Holer
Both patches against qemu 1.3 *works*, first with traditional PCI pass., second with VFIO. Mellanox IB card in guest works fine again. Great early Christmas present, thank you! Just FYI: between both ways I can see little difference on host system regarding the numbers of IRQs for MSI/MSI-X: * VF

[Qemu-devel] [PATCH 05/34] migration-fd: remove duplicate include

2012-12-19 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-fd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration-fd.c b/migration-fd.c index c501c4b..b8d16ad 100644 --- a/migration-fd.c +++ b/migration-fd.c @@ -20,7 +20,6 @@ #include "qemu-char.h" #include "qemu-file.h" #include "block.h" -#includ

[Qemu-devel] [PATCH 20/34] savevm: New save live migration method: pending

2012-12-19 Thread Juan Quintela
Code just now does (simplified for clarity) if (qemu_savevm_state_iterate(s->file) == 1) { vm_stop_force_state(RUN_STATE_FINISH_MIGRATE); qemu_savevm_state_complete(s->file); } Problem here is that qemu_savevm_state_iterate() returns 1 when it knows that remaining memory to

[Qemu-devel] [PATCH 21/34] migration: move buffered_file.c code into migration.c

2012-12-19 Thread Juan Quintela
This only moves the code (also from buffered_file.h to migration.h). Fix whitespace until checkpatch is happy. Signed-off-by: Juan Quintela --- Makefile.objs | 2 +- buffered_file.c | 259 buffered_file.h | 22 - migration.c |

[Qemu-devel] [PATCH 24/34] migration: Inline qemu_fopen_ops_buffered into migrate_fd_connect

2012-12-19 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c | 11 +++ migration.h | 2 -- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/migration.c b/migration.c index 7a27987..5a4ad74 100644 --- a/migration.c +++ b/migration.c @@ -371,13 +371,6 @@ bool migration_has_failed(MigrationS

Re: [Qemu-devel] [PATCH 00/34] migration thread and queue

2012-12-19 Thread Paolo Bonzini
Il 19/12/2012 13:33, Juan Quintela ha scritto: > Hi > > This is my queue for migration-thread and patches associated. This > integrates review comments & code for Paolo. This is the subset from > both approachs that we agreed with. rest of patches need more review > and are not here. > > Migrat

[Qemu-devel] [PATCH 07/34] exec: change RAM list to a TAILQ

2012-12-19 Thread Juan Quintela
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Juan Quintela --- arch_init.c | 24 cpu-all.h | 4 ++-- dump.c | 8 exec.c | 34 +- memory_mapping.c

Re: [Qemu-devel] [PATCH qom-cpu v2] cpu: Introduce CPUListState struct

2012-12-19 Thread Eduardo Habkost
On Wed, Dec 19, 2012 at 02:00:32PM +0100, Igor Mammedov wrote: > On Wed, 19 Dec 2012 02:03:55 +0100 > Andreas Färber wrote: > > > This generalizes {ARM,M68k,Alpha}CPUListState to avoid declaring it for > > each target. Place it in cpu-common.h to avoid circular dependencies. > > > > Signed-off-b

[Qemu-devel] [PATCH 11/34] buffered_file: Move from using a timer to use a thread

2012-12-19 Thread Juan Quintela
We still protect everything except the wait with the iothread lock. But we moved from a timer to a thread. Steps one by one. We also need to detect when we have finished with a variable "complete". Signed-off-by: Juan Quintela --- buffered_file.c | 58 +++---

[Qemu-devel] [PATCH 23/34] migration: move migration_fd_put_ready()

2012-12-19 Thread Juan Quintela
Put it near its use and un-export it. Signed-off-by: Juan Quintela --- migration.c | 130 ++-- migration.h | 1 - 2 files changed, 65 insertions(+), 66 deletions(-) diff --git a/migration.c b/migration.c index a233215..7a27987 100644 ---

[Qemu-devel] [PATCH 13/34] migration: move migration thread init code to migrate_fd_put_ready

2012-12-19 Thread Juan Quintela
This way everything related with migration is run on the migration thread and no locking is needed. Signed-off-by: Juan Quintela --- migration.c | 29 + migration.h | 1 + 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/migration.c b/migration.c inde

[Qemu-devel] [PATCH 06/34] exec: change ramlist from MRU order to a 1-item cache

2012-12-19 Thread Juan Quintela
From: Paolo Bonzini Most of the time, only 2 items will be active (from/to for a string operation, or code/data). But TCG guests likely won't have gigabytes of memory, so this actually goes down to 1 item. Signed-off-by: Paolo Bonzini Signed-off-by: Juan Quintela --- arch_init.c | 1 + cpu-

[Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque

2012-12-19 Thread Stefan Hajnoczi
The spice_server pointer is a global variable and vm_change_state_handler() therefore does not use its opaque parameter. The vm change state handler is added with a pointer to the spice_server pointer. This is useless and we probably would not want 2 levels of pointers. Signed-off-by: Stefan Haj

Re: [Qemu-devel] [PATCH 3/3] virtio-pci: don't poll masked vectors

2012-12-19 Thread Stefan Hajnoczi
On Tue, Dec 18, 2012 at 02:39:19PM +0200, Michael S. Tsirkin wrote: > -static int virtio_pci_set_guest_notifier(DeviceState *d, int n, bool assign) > +static void kvm_virtio_pci_vector_poll(PCIDevice *dev, > + unsigned int vector_start, > +

[Qemu-devel] [PATCH 17/34] buffered_file: Unfold the trick to restart generating migration data

2012-12-19 Thread Juan Quintela
This was needed before due to the way that the callbacks worked. Signed-off-by: Juan Quintela Reviewed-by: Paolo Bonzini --- buffered_file.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/buffered_file.c b/buffered_file.c index 5cd477a..f4f5110 100644

[Qemu-devel] [PATCH 27/34] ram: Add last_sent_block

2012-12-19 Thread Juan Quintela
This is the last block from where we have sent data. Signed-off-by: Orit Wasserman Signed-off-by: Juan Quintela --- arch_init.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch_init.c b/arch_init.c index 34a2f4b..af57cdb 100644 --- a/arch_init.c +++ b/arch_init.c @@

[Qemu-devel] [PATCH 12/34] migration: make qemu_fopen_ops_buffered() return void

2012-12-19 Thread Juan Quintela
We want the file assignment to happen before the thread is created to avoid locking, so we just do it before creating the thread. Signed-off-by: Juan Quintela Reviewed-by: Orit Wasserman --- buffered_file.c | 13 ++--- buffered_file.h | 2 +- migration.c | 2 +- migration.h |

[Qemu-devel] [PATCH 08/34] exec: sort the memory from biggest to smallest

2012-12-19 Thread Juan Quintela
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Juan Quintela --- arch_init.c | 30 -- exec.c | 14 -- 2 files changed, 12 insertions(+), 32 deletions(-) diff --git a/arch_init.c b/arch_init.c index 3c1aa00..8b5980f 100644 --- a/arc

[Qemu-devel] [PATCH 31/34] ram: account the amount of transferred ram better

2012-12-19 Thread Juan Quintela
Signed-off-by: Juan Quintela --- arch_init.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/arch_init.c b/arch_init.c index 978fe37..43a5b9e 100644 --- a/arch_init.c +++ b/arch_init.c @@ -265,16 +265,21 @@ uint64_t xbzrle_mig_pages_overflo

[Qemu-devel] [PATCH 20/20] MAINTAINERS: Include X86CPU in CPU maintenance area

2012-12-19 Thread Andreas Färber
Document that the x86 CPU refactorings are going through the qom-cpu tree. This does not contradict the established practice that patches adding KVM features to the x86 CPU go through the KVM maintainers, it merely takes it out of target-i386 TCG's Odd Fixes status. Signed-off-by: Andreas Färber

[Qemu-devel] [PATCH 11/20] kvm: Pass CPUState to kvm_vcpu_ioctl()

2012-12-19 Thread Andreas Färber
Adapt helper functions to pass X86CPU / PowerPCCPU / S390CPU. Signed-off-by: Andreas Färber --- hw/kvm/apic.c | 10 +-- hw/kvm/clock.c |2 +- hw/ppc.c |2 +- hw/s390-virtio-bus.c | 12 ++-- hw/spapr.c |2 +- kvm-all

[Qemu-devel] [PATCH 08/20] qdev-properties.c: Separate core from the code used only by qemu-system-*

2012-12-19 Thread Andreas Färber
From: Eduardo Habkost This separates the qdev properties code in two parts: - qdev-properties.c, that contains most of the qdev properties code; - qdev-properties-system.c for code specific for qemu-system-*, containing: - Property types: drive, chr, netdev, vlan, that depend on code that

[Qemu-devel] How to make TCP/IP applications run on guest OS?

2012-12-19 Thread GaoYi
Hi all, I have bridged the network of the host. There was one br0 and several taps on it. When I started up a guest using: #kvm -hda ubuntu.img -localtime -m 1G -net nic, -net tap,ifname=tap0,script=no The guest can ping to other VMs or physical PCs within the same LA

Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2012-12-19 Thread Gerd Hoffmann
Hi, > correct, only the number of channels and ranks(dimms) per channel has been > emulated so far (2 channels of 4 dimms each). So it is still paravirtual > memory > hotplug, not native. Native support still needs to be worked on. Ok. >> I think the paravirtual memory hotplug controller shou

[Qemu-devel] [PATCH 22/34] migration: add XFER_LIMIT_RATIO

2012-12-19 Thread Juan Quintela
The "magic" divisions by 10 are there because of the value of BUFFER_DELAY. Introduce a constant to explain them better. Signed-off-by: Paolo Bonzini Signed-off-by: Juan Quintela --- migration.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/migration.c b/migrati

[Qemu-devel] [PATCH 05/20] target-alpha: Add support for -cpu ?

2012-12-19 Thread Andreas Färber
Implement alphabetical listing of CPU subclasses. Signed-off-by: Andreas Färber Acked-by: Richard Henderson --- target-alpha/cpu.c | 41 + target-alpha/cpu.h |2 ++ 2 Dateien geändert, 43 Zeilen hinzugefügt(+) diff --git a/target-alpha/cpu.c b/targ

[Qemu-devel] [PATCH 02/34] buffered_file: do not send more than s->bytes_xfer bytes per tick

2012-12-19 Thread Juan Quintela
From: Paolo Bonzini Sending more was possible if the buffer was large. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini Signed-off-by: Juan Quintela --- buffered_file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/buffered_file.c b/buffered_file.c index bd0f6

[Qemu-devel] [PULL] QOM CPUState patch queue 2012-12-19

2012-12-19 Thread Andreas Färber
Hello, This is my current QOM CPU patch queue. Please pull. It includes: * CPU subclasses for target-alpha, * CPUListState cleanup (basis for all subsequent subclasses series), * more steps towards CPU as a device (qdev-properties.c split), * more CPUState field movements and API changes for KVM,

Re: [Qemu-devel] [PATCH v2 1/2] sheepdog: don't update inode when create_and_write fails

2012-12-19 Thread Stefan Hajnoczi
On Mon, Dec 17, 2012 at 02:17:26PM +0800, Liu Yuan wrote: > From: Liu Yuan > > For the error case such as SD_RES_NO_SPACE, we shouldn't update the inode > bitmap > to avoid the scenario that the object is allocated but wasn't created at the > server side. This will result in VM's IO error on the

[Qemu-devel] [PATCH 32/34] ram: refactor ram_save_block() return value

2012-12-19 Thread Juan Quintela
It could only return 0 if we only found dirty xbzrle pages that hadn't changed (i.e. they were written with the same content). We don't care about that case, it is the same than nothing dirty. So now the return of the function is how much have it written, nothing else. Adjust callers. And we als

[Qemu-devel] [PATCH 12/20] ppc: Pass PowerPCCPU to ppc_set_irq()

2012-12-19 Thread Andreas Färber
Adapt static caller functions. This cleans up after passing PowerPCCPU to kvmppc_set_interrupt(). Signed-off-by: Andreas Färber --- hw/ppc.c | 66 ++-- hw/ppc.h |2 +- hw/ppc_booke.c | 28 3 Dateien

[Qemu-devel] [PATCH 33/34] migration: fix qemu_get_fd for BufferedFile

2012-12-19 Thread Juan Quintela
From: Paolo Bonzini Not really used, but nice to have it correct. :) Signed-off-by: Paolo Bonzini Signed-off-by: Juan Quintela --- migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration.c b/migration.c index cabf17b..ca39564 100644 --- a/migration.c +++ b/mi

[Qemu-devel] [PATCH 03/34] migration: remove double call to migrate_fd_close

2012-12-19 Thread Juan Quintela
From: Paolo Bonzini The call in buffered_close is enough, because buffered_close is called already by migrate_fd_cleanup. Signed-off-by: Paolo Bonzini Signed-off-by: Juan Quintela --- migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration.c b/migration.c ind

[Qemu-devel] [PATCH 29/34] ram: Use memory_region_test_and_clear_dirty

2012-12-19 Thread Juan Quintela
This avoids having to do two walks over the dirty bitmap, once reading the dirty bits, and anthoer cleaning them. Signed-off-by: Juan Quintela --- arch_init.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch_init.c b/arch_init.c index af57cdb..562f721 100644 --- a/

[Qemu-devel] [PATCH 09/34] add a version number to ram_list

2012-12-19 Thread Juan Quintela
From: Umesh Deshpande This will be used to detect if last_block might have become invalid across different calls to ram_save_live. Signed-off-by: Paolo Bonzini Signed-off-by: Umesh Deshpande Signed-off-by: Juan Quintela Reviewed-by: Orit Wasserman --- arch_init.c | 7 ++- cpu-all.h |

[Qemu-devel] [PATCH 34/34] migration: merge QEMUFileBuffered into MigrationState

2012-12-19 Thread Juan Quintela
Avoid splitting the state of outgoing migration, more or less arbitrarily, between two data structures. QEMUFileBuffered anyway is used only during migration. Signed-off-by: Paolo Bonzini Signed-off-by: Juan Quintela --- migration.c | 63

[Qemu-devel] [PATCH 18/20] cpu: Move kvm_state field into CPUState

2012-12-19 Thread Andreas Färber
Adapt some functions to take CPUState / {PowerPC,S390}CPU argument. Signed-off-by: Andreas Färber --- cpu-defs.h |2 -- include/qemu/cpu.h |3 +++ kvm-all.c | 28 ++-- kvm.h |4 ++-- target-i386/cpu.c |7 +-- target-i38

[Qemu-devel] [PATCH 19/34] buffered_file: unfold buffered_append in buffered_put_buffer

2012-12-19 Thread Juan Quintela
It was the only user, and now buffered_put_buffer just do the append Signed-off-by: Juan Quintela Reviewed-by: Paolo Bonzini --- buffered_file.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/buffered_file.c b/buffered_file.c index 2c382

[Qemu-devel] [PATCH 18/34] buffered_file: don't flush on put buffer

2012-12-19 Thread Juan Quintela
We call buffered_put_buffer with iothread held, and buffered_flush() does synchronous writes. We only want to do the synchronous writes outside. Signed-off-by: Juan Quintela Reviewed-by: Paolo Bonzini --- buffered_file.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/buffered_file.c

[Qemu-devel] [PATCH 19/20] cpu: Move kvm_run into CPUState

2012-12-19 Thread Andreas Färber
Pass CPUState / {X86,S390}CPU to helper functions. Signed-off-by: Andreas Färber --- cpu-defs.h |4 +-- include/qemu/cpu.h |2 ++ kvm-all.c |8 +++--- target-i386/kvm.c |9 +++--- target-s390x/kvm.c | 77 5

[Qemu-devel] [PATCH 04/20] target-alpha: Turn CPU definitions into subclasses

2012-12-19 Thread Andreas Färber
Make TYPE_ALPHA_CPU abstract and add types -alpha-cpu. Use type inheritence, and turn "2*" models into aliases. Move cpu_alpha_init() to cpu.c and split out CPU realization. Default to creating type "ev67-alpha-cpu" as before. Signed-off-by: Andreas Färber Acked-by: Richard Henderson --- targe

[Qemu-devel] [PATCH 02/20] alpha: Pass AlphaCPU array to Typhoon

2012-12-19 Thread Andreas Färber
Also store it in TyphoonCchip. Signed-off-by: Andreas Färber Acked-by: Richard Henderson --- hw/alpha_dp264.c | 18 +- hw/alpha_sys.h |2 +- hw/alpha_typhoon.c | 29 - 3 Dateien geändert, 26 Zeilen hinzugefügt(+), 23 Zeilen entfernt(-)

[Qemu-devel] [PATCH 04/34] migration: include qemu-file.h

2012-12-19 Thread Juan Quintela
They don't use/know anything about buffered-file. Signed-off-by: Juan Quintela --- migration-exec.c | 2 +- migration-fd.c | 2 +- migration-tcp.c | 2 +- migration-unix.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/migration-exec.c b/migration-exec.c index 2b6fcb4.

[Qemu-devel] [PATCH 16/20] ppc4xx_devs: Return PowerPCCPU from ppc4xx_init()

2012-12-19 Thread Andreas Färber
Prepares for passing PowerPCCPU to ppc_booke_timers_init(). Signed-off-by: Andreas Färber --- hw/ppc405_uc.c |8 ++-- hw/ppc4xx.h |6 +++--- hw/ppc4xx_devs.c |8 3 Dateien geändert, 13 Zeilen hinzugefügt(+), 9 Zeilen entfernt(-) diff --git a/hw/ppc405_uc.c b/hw/p

[Qemu-devel] [PATCH 01/34] migration: fix migration_bitmap leak

2012-12-19 Thread Juan Quintela
From: Paolo Bonzini Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini Signed-off-by: Juan Quintela --- arch_init.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/arch_init.c b/arch_init.c index 83dcc53..0d7844c 100644 --- a/arch_init.c +++ b/arch_init.c

[Qemu-devel] [PATCH 01/20] target-alpha: Let cpu_alpha_init() return AlphaCPU

2012-12-19 Thread Andreas Färber
Replace cpu_init() macro with inline function for backwards compatibility. Signed-off-by: Andreas Färber Acked-by: Richard Henderson --- target-alpha/cpu.h | 13 +++-- target-alpha/translate.c |4 ++-- 2 Dateien geändert, 13 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff

[Qemu-devel] [PATCH 10/34] protect the ramlist with a separate mutex

2012-12-19 Thread Juan Quintela
From: Umesh Deshpande Add the new mutex that protects shared state between ram_save_live and the iothread. If the iothread mutex has to be taken together with the ramlist mutex, the iothread shall always be _outside_. Signed-off-by: Paolo Bonzini Signed-off-by: Umesh Deshpande Signed-off-by:

[Qemu-devel] [PATCH 03/20] target-alpha: Avoid leaking the alarm timer over reset

2012-12-19 Thread Andreas Färber
Move the timer from CPUAlphaState to AlphaCPU to avoid the pointer being zero'ed once we implement reset. Would cause a segfault in sys_helper.c:helper_set_alarm(). This also simplifies timer initialization in Typhoon. Signed-off-by: Andreas Färber Acked-by: Richard Henderson --- hw/alpha_typh

[Qemu-devel] [PATCH 14/34] migration: make writes blocking

2012-12-19 Thread Juan Quintela
Move all the writes to the migration_thread, and make writings blocking. Notice that are still using the iothread for everything that we do. Signed-off-by: Juan Quintela --- migration-exec.c | 1 - migration-fd.c | 1 - migration-tcp.c | 1 + migration-unix.c | 1 + migration.c | 17

[Qemu-devel] [PATCH 26/34] ram: rename last_block to last_seen_block

2012-12-19 Thread Juan Quintela
Signed-off-by: Juan Quintela --- arch_init.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/arch_init.c b/arch_init.c index f092ea2..34a2f4b 100644 --- a/arch_init.c +++ b/arch_init.c @@ -332,7 +332,10 @@ static int save_xbzrle_page(QEMUFile *f, uint8_t *cu

  1   2   3   >