Re: [Qemu-devel] qemu 1.3 vs qemu-kvm 1.3 differences ?

2012-11-21 Thread Alexandre DERUMIER
Hi, Can somebody give me infos ? Regards, Alexandre - Mail original - De: "Alexandre DERUMIER" À: "qemu-devel" Envoyé: Mardi 20 Novembre 2012 15:37:39 Objet: [Qemu-devel] qemu 1.3 vs qemu-kvm 1.3 differences ? Hi List, I would like to known what are the remaining differences betwe

[Qemu-devel] [PATCH 4/5] TCG: Use gen_opc_instr_start from context instead of global variable.

2012-11-21 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- target-alpha/translate.c |6 +++--- target-arm/translate.c|6 +++--- target-cris/translate.c |6 +++--- target-i386/translate.c |8 target-lm32/translate.c |6 +++--- target-m68k/translate.c |

Re: [Qemu-devel] [PATCH v2] exec.c: Use tb1->phys_hash_next directly in tb_remove

2012-11-21 Thread Peter Maydell
On 20 November 2012 23:52, 陳韋任 (Wei-Ren Chen) wrote: > When tb_remove was first commited at fd6ce8f6, there were three different > calls pass different names to offsetof. In current codebase, the other two > calls are replaced with tb_page_remove. There is no need to have a general > tb_remove.

Re: [Qemu-devel] [PATCH V10 6/7] libqblock API

2012-11-21 Thread Paolo Bonzini
Il 21/11/2012 04:40, Wenchao Xia ha scritto: >> >> Please move the creation of this file to the previous patch. >> > It is first created in 4/7 build system patch, should it be changed or > add API defines into that patch? I mean add API defines in 5/7. Paolo

Re: [Qemu-devel] [PATCH V10 5/7] libqblock type defines

2012-11-21 Thread Paolo Bonzini
Il 21/11/2012 04:12, Wenchao Xia ha scritto: >>> >>> +#define FUNC_FREE(p) g_free((p)) >>> +#define FUNC_MALLOC(size) g_malloc((size)) >>> +#define FUNC_CALLOC(nmemb, size) g_malloc0((nmemb)*(size)) >>> +#define FUNC_STRDUP(p) g_strdup((p)) >> >> Why keep these? > > This macro make it easy to sw

[Qemu-devel] [RFC PATCH v5 2/4] use uimage_reset to reload uimage

2012-11-21 Thread Olivia Yin
Signed-off-by: Olivia Yin --- hw/loader.c | 64 +++--- hw/loader.h |8 ++- 2 files changed, 54 insertions(+), 18 deletions(-) diff --git a/hw/loader.c b/hw/loader.c index a8a0a09..e1e2a20 100644 --- a/hw/loader.c +++ b/hw/loader.c @@

Re: [Qemu-devel] [PATCH v2 3/8] dataplane: add host memory mapping code

2012-11-21 Thread Stefan Hajnoczi
On Tue, Nov 20, 2012 at 01:24:08PM -0500, Don Koch wrote: > On 11/20/2012 07:31 AM, Stefan Hajnoczi wrote: > > +void hostmem_init(Hostmem *hostmem) > > +{ > > +memset(hostmem, 0, sizeof(*hostmem)); > > + > > +hostmem->listener = (MemoryListener){ > > +.begin = hostmem_listener_nop,

[Qemu-devel] [RFC PATCH v5 1/4] use image_file_reset to reload initrd image

2012-11-21 Thread Olivia Yin
Signed-off-by: Olivia Yin --- hw/loader.c | 39 +++ hw/loader.h |7 +++ 2 files changed, 46 insertions(+), 0 deletions(-) diff --git a/hw/loader.c b/hw/loader.c index ba01ca6..a8a0a09 100644 --- a/hw/loader.c +++ b/hw/loader.c @@ -86,6 +86,39 @@ int

[Qemu-devel] [RFC PATCH v5 4/4] free the memory malloced by load_at()

2012-11-21 Thread Olivia Yin
Signed-off-by: Olivia Yin --- hw/elf_ops.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/elf_ops.h b/hw/elf_ops.h index b346861..9c76a75 100644 --- a/hw/elf_ops.h +++ b/hw/elf_ops.h @@ -178,6 +178,8 @@ static int glue(load_symbols, SZ)(struct elfhdr *ehdr, int fd,

[Qemu-devel] [RFC PATCH v5 3/4] use elf_reset to reload elf image

2012-11-21 Thread Olivia Yin
Signed-off-by: Olivia Yin --- elf.h| 10 ++ hw/elf_ops.h | 40 hw/loader.c | 11 +++ 3 files changed, 57 insertions(+), 4 deletions(-) diff --git a/elf.h b/elf.h index a21ea53..335f1af 100644 --- a/elf.h +++ b/elf.h @@ -1078

[Qemu-devel] [PATCH 5/5] TCG: Remove unused global gen_opc_ arrays.

2012-11-21 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- exec-all.h |4 translate-all.c |4 2 files changed, 8 deletions(-) diff --git a/exec-all.h b/exec-all.h index 21aacda..b18d4ca 100644 --- a/exec-all.h +++ b/exec-all.h @@ -70,10 +70,6 @@ typedef struct TranslationBlock TranslationBlock;

[Qemu-devel] [RFC PATCH v5 0/4] reload images from host rootfs once reset to save footprint

2012-11-21 Thread Olivia Yin
The current model of loader copy "rom blobs" and kept in memory until a reset occurs and waste host memory. This serial of patches uses private reset handlers to load from hard disk on reset, which could make loader framework more dynamic and reduce the memory consumption of QEMU process. Oliv

Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-21 Thread Stefan Hajnoczi
On Wed, Nov 21, 2012 at 08:47:16AM +0100, Stefan Priebe - Profihost AG wrote: > Am 21.11.2012 07:41, schrieb Stefan Hajnoczi: > >On Tue, Nov 20, 2012 at 8:16 PM, Stefan Priebe wrote: > >>Hi Stefan, > >> > >>Am 20.11.2012 17:29, schrieb Stefan Hajnoczi: > >> > >>>On Tue, Nov 20, 2012 at 01:44:55PM

Re: [Qemu-devel] qemu 1.3 vs qemu-kvm 1.3 differences ?

2012-11-21 Thread Jan Kiszka
On 2012-11-20 15:37, Alexandre DERUMIER wrote: > Hi List, > > I would like to known what are the remaining differences between qemu 1.3 and > qemu-kvm 1.3 ? There is and there will be no qemu-kvm 1.3. That fork has been retired by the maintainers. The only difference remaining is some lacking i

Re: [Qemu-devel] Interrupt controller updates

2012-11-21 Thread Jan Kiszka
On 2012-11-21 02:07, Benjamin Herrenschmidt wrote: > Hi Jan ! > > David (CC) want to make some progress with our in-kernel PIC. From > memory, one of the outcomes of the BOF was that we need to move the > existing "enable in-kernel PIC" from generic KVM init to machine init in > order to be able t

Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-21 Thread Stefan Priebe - Profihost AG
Am 21.11.2012 09:26, schrieb Stefan Hajnoczi: On Wed, Nov 21, 2012 at 08:47:16AM +0100, Stefan Priebe - Profihost AG wrote: Am 21.11.2012 07:41, schrieb Stefan Hajnoczi: We're going in circles here. I know the types are wrong in the code and your patch fixes it, that's why I said it looks good

Re: [Qemu-devel] [PATCH V7 0/6] VMXNET3 paravirtual NIC device implementation

2012-11-21 Thread Stefan Hajnoczi
On Fri, Nov 16, 2012 at 03:55:29PM +0200, Dmitry Fleytman wrote: > NOTE: This is not a final patches for commit, > they are just for the latest fixes review. > This set of patches still misses test for the device. > > We didn't succeed to find any guide or sample for the >

Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-21 Thread Stefan Hajnoczi
On Wed, Nov 21, 2012 at 09:33:08AM +0100, Stefan Priebe - Profihost AG wrote: > Am 21.11.2012 09:26, schrieb Stefan Hajnoczi: > >On Wed, Nov 21, 2012 at 08:47:16AM +0100, Stefan Priebe - Profihost AG wrote: > >>Am 21.11.2012 07:41, schrieb Stefan Hajnoczi: > >QEMU is currently in hard freeze and on

Re: [Qemu-devel] qemu 1.3 vs qemu-kvm 1.3 differences ?

2012-11-21 Thread Alexandre DERUMIER
Thanks Jan, that's clear now ! (I was looking for this for qemu integration in next proxmox release) Best Regards, Alexandre - Mail original - De: "Jan Kiszka" À: "Alexandre DERUMIER" Cc: "qemu-devel" Envoyé: Mercredi 21 Novembre 2012 09:28:20 Objet: Re: qemu 1.3 vs qemu-kvm 1.3 di

Re: [Qemu-devel] [PATCH 1.3 0/2] ide: PRDT error handling fixes

2012-11-21 Thread Stefan Hajnoczi
On Tue, Nov 20, 2012 at 05:27:42PM +0100, Kevin Wolf wrote: > qtest cases for this exist, but they rely on prototype infrastructure that > isn't mergable. I'll submit them as soon as libqos is there and I've changed > the test to use it. > > Kevin Wolf (2): > ide: Fix crash with too long PRD >

Re: [Qemu-devel] [PATCH V7 0/6] VMXNET3 paravirtual NIC device implementation

2012-11-21 Thread Dmitry Fleytman
Thanks, Stefan. Sent from my iPhone On 21 בנוב 2012, at 10:37, Stefan Hajnoczi wrote: > On Fri, Nov 16, 2012 at 03:55:29PM +0200, Dmitry Fleytman wrote: >> NOTE: This is not a final patches for commit, >> they are just for the latest fixes review. >> This set of patches still misses t

Re: [Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel

2012-11-21 Thread Josh Durgin
On 11/19/2012 12:39 PM, Stefan Priebe wrote: From: Stefan Priebe This one fixes a race qemu also had in iscsi block driver between cancellation and io completition. qemu_rbd_aio_cancel was not synchronously waiting for the end of the command. It also removes the useless cancelled flag and int

[Qemu-devel] [PATCH/RFC] block: Ensure that block size constraints are considered

2012-11-21 Thread Christian Borntraeger
From: Heinz Graalfs While testing IPL code (booting) for s390x we faced some problems with cache=none on dasds (4k block size) on bdrv_preads with length values != block size. This patch makes sure that bdrv_pread and friends work fine with unaligned access even with cache=none - propagate al

[Qemu-devel] [PATCH 4/5] add backup related monitor commands

2012-11-21 Thread Dietmar Maurer
We currently create 'vma' archives without any configuration inside. Future versions may support other formats... Another option would be to simply dump to the output fh (pipe), and an external binary saves the data. That way we could move the whole archive format related code out of qemu. Signe

[Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-21 Thread Dietmar Maurer
This series provides a way to efficiently backup VMs. * Backup to a single archive file * Backup contain all data to restore VM (full backup) * Do not depend on storage type or image format * Avoid use of temporary storage * store sparse images efficiently The file docs/backup-rfc.txt contains mo

[Qemu-devel] [PATCH 2/5] add basic backup support to block driver

2012-11-21 Thread Dietmar Maurer
Function bdrv_backup_init() creates a block job to backup a block device. We call brdv_co_backup_cow() for each write during backup. That function reads the original data and pass it to backup_dump_cb(). The tracked_request infrastructure is used to serialize access. Currently backup cluster siz

Re: [Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel

2012-11-21 Thread Stefan Hajnoczi
On Mon, Nov 19, 2012 at 09:39:45PM +0100, Stefan Priebe wrote: > @@ -376,9 +376,7 @@ static void qemu_rbd_complete_aio(RADOSCB *rcb) > RBDAIOCB *acb = rcb->acb; > int64_t r; > > -if (acb->cancelled) { > -qemu_vfree(acb->bounce); > -qemu_aio_release(acb); > +if (a

Re: [Qemu-devel] [PATCH/RFC] block: Ensure that block size constraints are considered

2012-11-21 Thread Kevin Wolf
Am 21.11.2012 09:58, schrieb Christian Borntraeger: > From: Heinz Graalfs > > While testing IPL code (booting) for s390x we faced some problems > with cache=none on dasds (4k block size) on bdrv_preads with length > values != block size. > > This patch makes sure that bdrv_pread and friends work

Re: [Qemu-devel] [PATCH v3 1/2] qemu-ga: execute hook to quiesce the guest on fsfreeze-freeze/thaw

2012-11-21 Thread Tomoki Sekiyama
Hi Michael, Thanks for your review. On 2012/11/21 6:00, mdroth wrote: > On Tue, Nov 13, 2012 at 01:56:56PM +0900, Tomoki Sekiyama wrote: >> To use the online disk snapshot for online-backup, application-level >> consistency of the snapshot image is required. However, currently the >> guest agent

Re: [Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel

2012-11-21 Thread Stefan Priebe - Profihost AG
Hello Stefan, hello Paolo, most of the ideas and removing the whole cancellation stuff came from Paolo. Maybe he can comment also? I would then make a new patch. Greets, Stefan Am 21.11.2012 10:07, schrieb Stefan Hajnoczi: On Mon, Nov 19, 2012 at 09:39:45PM +0100, Stefan Priebe wrote: @@

[Qemu-devel] [PATCH 5/5] add regression tests for backup

2012-11-21 Thread Dietmar Maurer
Also added the ratelimit.h fix here, because it is still not upstream. Signed-off-by: Dietmar Maurer --- include/qemu/ratelimit.h |2 +- tests/Makefile | 11 +- tests/backup-test.c | 505 ++ 3 files changed, 515 insertions(+), 3 d

Re: [Qemu-devel] [RFC PATCH 1/3] virtio-bus : Introduce VirtioBus.

2012-11-21 Thread KONRAD Frédéric
On 19/11/2012 18:33, Peter Maydell wrote: On 16 November 2012 15:35, wrote: From: KONRAD Frederic You forgot to CC enough people... This patch create a new VirtioBus, which can be added to Virtio transports like virtio-pci, virtio-mmio,... One VirtIODevice can be connected to this device,

Re: [Qemu-devel] [PATCH v11] kvm: notify host when the guest is panicked

2012-11-21 Thread Gleb Natapov
On Tue, Nov 20, 2012 at 07:33:49PM -0200, Marcelo Tosatti wrote: > On Tue, Nov 20, 2012 at 06:09:48PM +0800, Hu Tao wrote: > > Hi Marcelo, > > > > On Tue, Nov 13, 2012 at 12:19:08AM -0200, Marcelo Tosatti wrote: > > > On Fri, Nov 09, 2012 at 03:17:39PM -0500, Sasha Levin wrote: > > > > On Mon, Nov

[Qemu-devel] [PATCH v3] Add compare subcommand for qemu-img

2012-11-21 Thread Miroslav Rezanina
This is second version of patch adding compare subcommand that compares two images. Compare has following criteria: - only data part is compared - unallocated sectors are not read - in case of different image size, exceeding part of bigger disk has to be zeroed/unallocated to compare rest -

Re: [Qemu-devel] [PATCH/RFC] block: Ensure that block size constraints are considered

2012-11-21 Thread Christian Borntraeger
On 21/11/12 10:15, Kevin Wolf wrote: > Am 21.11.2012 09:58, schrieb Christian Borntraeger: >> From: Heinz Graalfs >> >> While testing IPL code (booting) for s390x we faced some problems >> with cache=none on dasds (4k block size) on bdrv_preads with length >> values != block size. >> >> This patch

Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN

2012-11-21 Thread Alexander Graf
On 21.11.2012, at 02:56, David Gibson wrote: > On Wed, Nov 21, 2012 at 02:48:07AM +0100, Alexander Graf wrote: >> >> On 21.11.2012, at 02:14, David Gibson wrote: >> >>> On Tue, Nov 20, 2012 at 10:55:50AM +0100, Alexander Graf wrote: On 20.11.2012, at 10:53, Peter Maydell wrote: >>>

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-21 Thread Alexander Graf
On 21.11.2012, at 06:00, David Gibson wrote: > On Tue, Nov 20, 2012 at 10:27:11AM +0100, Alexander Graf wrote: >> >> On 19.11.2012, at 23:51, David Gibson wrote: >> >>> On Mon, Nov 19, 2012 at 05:34:12PM +0100, Alexander Graf wrote: On 13.11.2012, at 03:47, David Gibson wrote:

[Qemu-devel] [PULL 1.3-rc1 0/5] Block patches for QEMU 1.3-rc1

2012-11-21 Thread Stefan Hajnoczi
The following changes since commit ecf51c9abe63eae282e5f912d9367ce75f36636a: tcg/ppc: Fix !softmmu case (2012-11-21 10:56:22 +0400) are available in the git repository at: git://github.com/stefanha/qemu.git block for you to fetch changes up to 72bcca73c7a67c8506fa737618861ad413dabf38: id

[Qemu-devel] [PATCH 2/5] vdi: don't override libuuid symbols

2012-11-21 Thread Stefan Hajnoczi
It's poor symbol hygiene to provide a global symbols that collide with a common library like libuuid. If QEMU links against a shared library that depends on uuid_generate() it can end up calling our stub version of the function. This exact scenario happened with GlusterFS libgfapi.so, which depen

[Qemu-devel] [PATCH 4/5] ide: Fix crash with too long PRD

2012-11-21 Thread Stefan Hajnoczi
From: Kevin Wolf Without this, s->nsector can become negative and badness happens (trying to malloc huge amount of memory and glib calls abort()) Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/ide

[Qemu-devel] [PATCH 3/5] use int64_t for return values from rbd instead of int

2012-11-21 Thread Stefan Hajnoczi
From: Stefan Priebe rbd / rados tends to return pretty often length of writes or discarded blocks. These values might be bigger than int. The steps to reproduce are: mkfs.xfs -f a whole device bigger than int in bytes. mkfs.xfs sends a discard. Important is that you use scsi-hd and set di

[Qemu-devel] [PATCH 5/5] ide: Fix status register after short PRDs

2012-11-21 Thread Stefan Hajnoczi
From: Kevin Wolf When failing a request because the length of the regions described by the PRDT was too short for the requested number of sectors, the IDE emulation forgot to update the status register, so that the device would keep the BSY flag set indefinitely. Signed-off-by: Kevin Wolf Signe

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-21 Thread Kevin Wolf
Am 21.11.2012 10:01, schrieb Dietmar Maurer: > +Some storage types/formats supports internal snapshots using some kind > +of reference counting (rados, sheepdog, dm-thin, qcow2). It would be possible > +to use that for backups, but for now we want to be storage-independent. > + > +Note: It turned o

[Qemu-devel] [PATCH 1/5] block: add bdrv_reopen() support for raw hdev, floppy, and cdrom

2012-11-21 Thread Stefan Hajnoczi
From: Jeff Cody For hdev, floppy, and cdrom, the reopen() handlers are the same as for the file reopen handler. For floppy and cdrom types, however, we keep O_NONBLOCK, as in the _open function. Signed-off-by: Jeff Cody Signed-off-by: Stefan Hajnoczi --- block/raw-posix.c | 16 ++

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-21 Thread Dietmar Maurer
> > +Note: It turned out that taking a qcow2 snapshot can take a very long > > +time on larger files. > > Hm, really? What are "larger files"? It has always been relatively quick when > I > tested it, though internal snapshots are not my focus, so that need not mean > much. 300GB or larger > I

Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine

2012-11-21 Thread Christian Borntraeger
On 20/11/12 15:49, Alexander Graf wrote: > On 11/20/2012 03:30 PM, Christian Borntraeger wrote: >> There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a >> default/standard interface to their block devices / drives. Therefore, >> this patch introduces a new field default_block_type per Q

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-21 Thread Dietmar Maurer
> Not saying that this is necessarily the best option, but I think reusing > existing > formats and implementation is always a good thing, so it's an idea to > consider. Yes, I would really like to reuse something. Our current backup software uses 'tar' files, but that is really inefficient. We

Re: [Qemu-devel] [PATCH/RFC] block: Ensure that block size constraints are considered

2012-11-21 Thread Heinz Graalfs
On Wed, 2012-11-21 at 11:00 +0100, Christian Borntraeger wrote: > On 21/11/12 10:15, Kevin Wolf wrote: > > Am 21.11.2012 09:58, schrieb Christian Borntraeger: > >> From: Heinz Graalfs > >> > >> While testing IPL code (booting) for s390x we faced some problems > >> with cache=none on dasds (4k bloc

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-21 Thread Michael S. Tsirkin
On Wed, Nov 21, 2012 at 11:57:05AM +1100, David Gibson wrote: > On Tue, Nov 20, 2012 at 02:26:09PM +0200, Michael S. Tsirkin wrote: > > On Tue, Nov 20, 2012 at 10:27:11AM +0100, Alexander Graf wrote: > > > > > > On 19.11.2012, at 23:51, David Gibson wrote: > > > > > > > On Mon, Nov 19, 2012 at 05

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-21 Thread Michael S. Tsirkin
On Wed, Nov 21, 2012 at 11:09:50AM +0100, Alexander Graf wrote: > > > On 21.11.2012, at 06:00, David Gibson wrote: > > > On Tue, Nov 20, 2012 at 10:27:11AM +0100, Alexander Graf wrote: > >> > >> On 19.11.2012, at 23:51, David Gibson wrote: > >> > >>> On Mon, Nov 19, 2012 at 05:34:12PM +0100,

Re: [Qemu-devel] VFIO VGA passthrough

2012-11-21 Thread ching
On 11/20/2012 11:27 PM, Alex Williamson wrote: > > Getting VGA to work in a guest is mostly black magic and luck at this > point. The warning you're getting isn't preventing anything. We use > device reset to try to clear the state of the hardware between runs. If > it's not available we can pot

Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine

2012-11-21 Thread Igor Mitsyanko
This version of patch doesn't change anything for majority of machines, its just that later we can choose ourself which default block interface to use. So, nothing to review from Exynos point of view, but patch is OK, except realview_pb_a8 part (see bellow): Acked-by: Igor Mitsyanko On 11/20

Re: [Qemu-devel] [PATCH] Legacy qemu-kvm options have no argument

2012-11-21 Thread Jan Kiszka
On 2012-11-20 16:14, Markus Armbruster wrote: > Cc'ing Marcelo & Jan to speed up patch application. > > Bruce Rogers writes: > >> The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip >> should be marked as having no argument. >> >> Signed-off-by: Bruce Rogers >> --- >> qe

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-21 Thread David Gibson
On Wed, Nov 21, 2012 at 01:34:48PM +0200, Michael S. Tsirkin wrote: > On Wed, Nov 21, 2012 at 11:57:05AM +1100, David Gibson wrote: > > On Tue, Nov 20, 2012 at 02:26:09PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Nov 20, 2012 at 10:27:11AM +0100, Alexander Graf wrote: > > > > > > > > On 19.11

Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine

2012-11-21 Thread Christian Borntraeger
On 21/11/12 13:07, Igor Mitsyanko wrote: > This version of patch doesn't change anything for majority of machines, its > just that later we can > choose ourself which default block interface to use. So, nothing to review > from Exynos point of view, but patch > is OK, except realview_pb_a8 part (

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-21 Thread Kevin Wolf
Am 21.11.2012 12:10, schrieb Dietmar Maurer: >>> +Note: It turned out that taking a qcow2 snapshot can take a very long >>> +time on larger files. >> >> Hm, really? What are "larger files"? It has always been relatively quick >> when I >> tested it, though internal snapshots are not my focus, so t

Re: [Qemu-devel] [PATCH] ivshmem: use irqfd to interrupt among VMs

2012-11-21 Thread Jan Kiszka
On 2012-11-21 07:02, Liu Ping Fan wrote: > From: Liu Ping Fan > > Using irqfd, so we can avoid switch between kernel and user when > VMs interrupts each other. > > Signed-off-by: Liu Ping Fan > --- > hw/ivshmem.c | 48 +++- > 1 files changed, 47 in

Re: [Qemu-devel] [RFC PATCH 1/3] virtio-bus : Introduce VirtioBus.

2012-11-21 Thread Andreas Färber
Am 16.11.2012 16:35, schrieb fred.kon...@greensocs.com: > From: KONRAD Frederic > > This patch create a new VirtioBus, which can be added to Virtio transports > like > virtio-pci, virtio-mmio,... > > One VirtIODevice can be connected to this device, like virtio-blk in the 3rd > patch. > > The

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-21 Thread Michael S. Tsirkin
On Wed, Nov 21, 2012 at 11:36:00PM +1100, David Gibson wrote: > On Wed, Nov 21, 2012 at 01:34:48PM +0200, Michael S. Tsirkin wrote: > > On Wed, Nov 21, 2012 at 11:57:05AM +1100, David Gibson wrote: > > > On Tue, Nov 20, 2012 at 02:26:09PM +0200, Michael S. Tsirkin wrote: > > > > On Tue, Nov 20, 201

Re: [Qemu-devel] TCP based PCIE request forwarding

2012-11-21 Thread lementec fabien
Hi, As far as I know, all the PCIE devices implemented here work with 256 bytes config header. Cheers, Fabien. 2012/11/20 Jason Baron : > On Fri, Nov 16, 2012 at 09:39:07AM +0100, lementec fabien wrote: >> Hi, >> >> I am a software engineer who works in an electronic group. Using QEMU >> to emu

[Qemu-devel] [PATCH] ccid-card-emul: do not crash if backend is not provided

2012-11-21 Thread Marc-André Lureau
Program received signal SIGSEGV, Segmentation fault. __strcmp_sse42 () at ../sysdeps/x86_64/multiarch/strcmp-sse42.S:164 164 movdqu(%rsi), %xmm2 (gdb) bt at /home/elmarco/320g/src/qemu/hw/ccid-card-emulated.c:477 at /home/elmarco/320g/src/qemu/hw/ccid-card-emulated.c:5

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-21 Thread David Gibson
On Wed, Nov 21, 2012 at 03:13:39PM +0200, Michael S. Tsirkin wrote: > On Wed, Nov 21, 2012 at 11:36:00PM +1100, David Gibson wrote: > > On Wed, Nov 21, 2012 at 01:34:48PM +0200, Michael S. Tsirkin wrote: > > > On Wed, Nov 21, 2012 at 11:57:05AM +1100, David Gibson wrote: > > > > On Tue, Nov 20, 201

Re: [Qemu-devel] [PATCHv3 1/5] seccomp: adding new syscalls (bugzilla 855162)

2012-11-21 Thread Eduardo Otubo
Hello folks, Does anyone had a chance to take a look at this? We would like to get this into the 1.3 release. Thanks again :) On Mon, Nov 12, 2012 at 05:48:14PM -0200, Eduardo Otubo wrote: > According to the bug 855162[0] - there's the need of adding new syscalls > to the whitelist when using Q

Re: [Qemu-devel] [PATCH v2 39/39] raw-win32: implement native asynchronous I/O

2012-11-21 Thread Jan Kiszka
On 2012-10-31 16:30, Paolo Bonzini wrote: > With the new support for EventNotifiers in the AIO event loop, we > can hook a completion port to every opened file and use asynchronous > I/O on them. > > Wine's support is extremely inefficient, also because it really does > the I/O synchronously on re

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-21 Thread Paolo Bonzini
Il 21/11/2012 13:37, Kevin Wolf ha scritto: >>> >> The active part is a bit more tricky. You're putting some code into >>> >> block.c to >>> >> achieve it, which is kind of ugly. >> > >> > yes. but I tried to keep that small ;-) > Yup, it's already not too bad. I haven't looked into it in much d

[Qemu-devel] [PATCH 1/2] Documentation: Update block cache mode information

2012-11-21 Thread Kevin Wolf
Somehow we forgot to update this when cache=writeback became the default. While changing the information on the default, also make the description of all caches modes a bit more accurate. Signed-off-by: Kevin Wolf --- qemu-options.hx | 34 +- 1 files changed, 17

[Qemu-devel] [PATCH 1.3 0/2] Manpage updates for 1.3

2012-11-21 Thread Kevin Wolf
Kevin Wolf (2): Documentation: Update block cache mode information Documentation: Update image format information qemu-img.texi | 37 ++--- qemu-options.hx | 34 +- 2 files changed, 47 insertions(+), 24 deletions(-) -- 1.

[Qemu-devel] [PATCH 2/2] Documentation: Update image format information

2012-11-21 Thread Kevin Wolf
Document new options, mark QED as deprecated. Signed-off-by: Kevin Wolf --- qemu-img.texi | 37 ++--- 1 files changed, 30 insertions(+), 7 deletions(-) diff --git a/qemu-img.texi b/qemu-img.texi index 60b83fc..2fdb3ef 100644 --- a/qemu-img.texi +++ b/qemu-img.t

Re: [Qemu-devel] [PATCH] stream: fix ratelimit_set_speed

2012-11-21 Thread Paolo Bonzini
Il 24/10/2012 12:10, Dietmar Maurer ha scritto: > The formula to compute slice_quota was wrong. > > Signed-off-by: Dietmar Maurer > --- > include/qemu/ratelimit.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/qemu/ratelimit.h b/include/qemu/ratelimit.h >

Re: [Qemu-devel] [PATCH v2 39/39] raw-win32: implement native asynchronous I/O

2012-11-21 Thread Paolo Bonzini
Il 21/11/2012 14:20, Jan Kiszka ha scritto: > I'm seeing a regression with this patch when cross-compiling with > mingw32 for Win7. QEMU is stuck while booting a versatilepb guest that > accesses the block layer via pflash. Enabling tracing "fixes" the issue, > of course... > > Are there any patch

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-21 Thread Dietmar Maurer
> > AFAIK qcow2 file cannot store data out of order. In general, an backup > > fd is not seekable, and we only want to do sequential writes. Image format > always requires seekable fds? > > Ah, this is what you mean by "out of order". Just out of curiosity, what are > these non-seekable backup fds

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-21 Thread Alexander Graf
On 11/21/2012 02:21 PM, David Gibson wrote: On Wed, Nov 21, 2012 at 03:13:39PM +0200, Michael S. Tsirkin wrote: On Wed, Nov 21, 2012 at 11:36:00PM +1100, David Gibson wrote: On Wed, Nov 21, 2012 at 01:34:48PM +0200, Michael S. Tsirkin wrote: On Wed, Nov 21, 2012 at 11:57:05AM +1100, David Gibs

Re: [Qemu-devel] [PATCH v2 39/39] raw-win32: implement native asynchronous I/O

2012-11-21 Thread Jan Kiszka
On 2012-11-21 14:25, Paolo Bonzini wrote: > Il 21/11/2012 14:20, Jan Kiszka ha scritto: >> I'm seeing a regression with this patch when cross-compiling with >> mingw32 for Win7. QEMU is stuck while booting a versatilepb guest that >> accesses the block layer via pflash. Enabling tracing "fixes" the

Re: [Qemu-devel] [PATCH v2 39/39] raw-win32: implement native asynchronous I/O

2012-11-21 Thread Paolo Bonzini
Il 21/11/2012 14:27, Jan Kiszka ha scritto: >>> >> Are there any patches flying around that are supposed to resolve this? >> > >> > No. Is this with aio=native or aio=threads? > aio= - whatever that is on win32. That's aio=threads, just like POSIX. I'm curious (but not too optimistic) whether a

Re: [Qemu-devel] [PATCH 1/2] Documentation: Update block cache mode information

2012-11-21 Thread Peter Maydell
On 21 November 2012 13:23, Kevin Wolf wrote: > Somehow we forgot to update this when cache=writeback became the > default. While changing the information on the default, also make the > description of all caches modes a bit more accurate. Some minor nits below, mostly in text around the areas you

Re: [Qemu-devel] [PATCH v2 39/39] raw-win32: implement native asynchronous I/O

2012-11-21 Thread Jan Kiszka
On 2012-11-21 14:33, Paolo Bonzini wrote: > Il 21/11/2012 14:27, Jan Kiszka ha scritto: >> Are there any patches flying around that are supposed to resolve this? No. Is this with aio=native or aio=threads? >> aio= - whatever that is on win32. > > That's aio=threads, just like POSIX.

[Qemu-devel] [PULL for-1.3 0/2] spice patch queue

2012-11-21 Thread Gerd Hoffmann
Hi, Spice patch queue, featuring two bugfixes for 1.3. please pull, Gerd The following changes since commit 1ccbc2851282564308f790753d7158487b6af8e2: qemu-sockets: Fix parsing of the inet option 'to'. (2012-11-21 12:07:59 +0400) are available in the git repository at: git://anongit.fre

[Qemu-devel] [PATCH 2/2] vga: fix mmio vga register mapping

2012-11-21 Thread Gerd Hoffmann
--- hw/vga-pci.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/vga-pci.c b/hw/vga-pci.c index ec29cac..947e35c 100644 --- a/hw/vga-pci.c +++ b/hw/vga-pci.c @@ -84,9 +84,10 @@ static void pci_vga_ioport_write(void *ptr, hwaddr addr,

[Qemu-devel] [PATCH 1/2] vga: fix bochs alignment issue

2012-11-21 Thread Gerd Hoffmann
The bochs dispi interface traditionally uses port 0x1ce as 16bit index register and port 0x1cf as 16bit data register. The later is unaligned, and probably for that reason the the data register was moved to 0x1d0 for non-x86 archs. This patch makes the data register available at 0x1d0 on x86 too.

[Qemu-devel] [PATCH 2/2] spice: add new spice-server callbacks to ui/spice-display.c

2012-11-21 Thread Gerd Hoffmann
Otherwise qemu crashes with non-qxl graphics cards. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index 0cc0116..6aff336 100644 --- a/ui/spice

Re: [Qemu-devel] [PULL for-1.3 0/2] spice patch queue

2012-11-21 Thread Gerd Hoffmann
On 11/21/12 14:48, Gerd Hoffmann wrote: > Hi, > > Spice patch queue, featuring two bugfixes for 1.3. Ouch, two old patch files resent which where still laying around. Just ignore the two vga patches. They are not part of the pull request and they are merged into master already. sorry, Gerd

[Qemu-devel] [PATCH 1/2] Fix the inconsistency in x509-dh-key-file parameter

2012-11-21 Thread Gerd Hoffmann
From: Lei Li Commit c448e8552b0f6135dabddf944a7110f929c08320 (spice: tls support) added options to the -spice command line. But there is an inconsistency between the declaration of the option 'x509-dh-key-file' to -spice command line and its parameter parsing 'x509-dh-file' in function qemu_spice

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-21 Thread Kevin Wolf
Am 21.11.2012 14:25, schrieb Dietmar Maurer: >>> AFAIK qcow2 file cannot store data out of order. In general, an backup >>> fd is not seekable, and we only want to do sequential writes. Image format >> always requires seekable fds? >> >> Ah, this is what you mean by "out of order". Just out of curi

[Qemu-devel] [PATCH 2/7] uhci: Don't allow the guest to set port-enabled when there is no dev connected

2012-11-21 Thread Gerd Hoffmann
From: Hans de Goede It is possible for device disconnect and the guest trying to reset the port (because of USB xact errors prior to the disconnect getting signaled) to race, when we hit this race, the guest will write the port-control register with its pre-disconnect value + the reset bit set, a

[Qemu-devel] [PATCH 6/7] usb-redir: Split usb_handle_interrupt_data into separate in/out functions

2012-11-21 Thread Gerd Hoffmann
From: Hans de Goede No functional changes. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c | 138 +++- 1 files changed, 72 insertions(+), 66 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index

Re: [Qemu-devel] [RFC PATCH 1/3] virtio-bus : Introduce VirtioBus.

2012-11-21 Thread KONRAD Frédéric
On 21/11/2012 14:04, Andreas Färber wrote: Am 16.11.2012 16:35, schrieb fred.kon...@greensocs.com: From: KONRAD Frederic This patch create a new VirtioBus, which can be added to Virtio transports like virtio-pci, virtio-mmio,... One VirtIODevice can be connected to this device, like virtio-bl

Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers

2012-11-21 Thread Paolo Bonzini
Il 21/11/2012 15:00, Jan Kiszka ha scritto: > +if (!TlsGetValue(current_tls_index)) { > +leader = g_malloc0(sizeof(*leader)); > +leader->fiber = ConvertThreadToFiber(NULL); > +TlsSetValue(current_tls_index, &leader->base); > } Leaking leader is a bit bad, but it lo

[Qemu-devel] [PATCH 5/7] usb-smartcard-reader: Properly NAK interrupt eps when we've no events

2012-11-21 Thread Gerd Hoffmann
From: Hans de Goede When we've no data to return from the interrupt endpoint, return NAK rather then a 0 length packet. CC: Alon Levy Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/dev-smartcard-reader.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff

Re: [Qemu-devel] [RFC PATCH 1/3] virtio-bus : Introduce VirtioBus.

2012-11-21 Thread Andreas Färber
Am 21.11.2012 15:05, schrieb KONRAD Frédéric: > On 21/11/2012 14:04, Andreas Färber wrote: >> Am 16.11.2012 16:35, schrieb fred.kon...@greensocs.com: >>> +#define DEBUG_VIRTIO_BUS >>> + >>> +#ifdef DEBUG_VIRTIO_BUS >>> + >>> +#define DPRINTF(fmt, ...) \ >>> +do { printf("virtio_bus: " fmt , ## __VA

[Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers

2012-11-21 Thread Jan Kiszka
mingw32 with gcc up to (at least) 4.4 has broken __thread support. This means all __thread variables silently become global ones. Address this by switching the coroutine implementation for win32 to Get/SetTlsValue. Signed-off-by: Jan Kiszka --- coroutine-win32.c | 29 ++---

[Qemu-devel] [PATCH 7/7] usb-redir: Don't handle interrupt output packets async

2012-11-21 Thread Gerd Hoffmann
From: Hans de Goede Instead report them as successfully completed directly on submission, this has 2 advantages: 1) This matches the timing of interrupt output packets on real hardware, with the previous async handling, if an ep has an interval of say 500 ms, then there would be 500+ ms between

Re: [Qemu-devel] [RFC PATCH 1/3] virtio-bus : Introduce VirtioBus.

2012-11-21 Thread KONRAD Frédéric
On 21/11/2012 15:13, Andreas Färber wrote: Am 21.11.2012 15:05, schrieb KONRAD Frédéric: On 21/11/2012 14:04, Andreas Färber wrote: Am 16.11.2012 16:35, schrieb fred.kon...@greensocs.com: +#define DEBUG_VIRTIO_BUS + +#ifdef DEBUG_VIRTIO_BUS + +#define DPRINTF(fmt, ...) \ +do { printf("virtio_b

[Qemu-devel] [PATCH 1/7] uhci: Add a completions_only flag for async completions

2012-11-21 Thread Gerd Hoffmann
From: Hans de Goede Add a completions_only flag, and set this when running process_frame for async completion handling, this fixes 2 issues in a single patch: 1) It makes sure async completed packets get written to guest mem immediately, even if all the bandwidth for the frame was consumed from

[Qemu-devel] [PATCH 4/7] usb-bt: Return NAK instead of STALL when interrupt ep has no data

2012-11-21 Thread Gerd Hoffmann
From: Hans de Goede I noticed this while making all devices with interrupt endpoints properly do wakeup. While at it also add wakeup support. Note that I've not tested this, but returning STALL for an interrupt ep which has no data is cleary the wrong thing to do. Signed-off-by: Hans de Goede

[Qemu-devel] [PULL for-1.3 0/7] usb patch queue

2012-11-21 Thread Gerd Hoffmann
Hi, Here comes the usb patch queue with a set od bugfixes from Hans. please pull, Gerd The following changes since commit 1ccbc2851282564308f790753d7158487b6af8e2: qemu-sockets: Fix parsing of the inet option 'to'. (2012-11-21 12:07:59 +0400) are available in the git repository at: git

Re: [Qemu-devel] TCP based PCIE request forwarding

2012-11-21 Thread lementec fabien
I join you a doc describing the current small protocol implementation. 2012/11/19 Stefan Hajnoczi : > On Fri, Nov 16, 2012 at 02:05:29PM +0100, lementec fabien wrote: >> Actually, I wanted to be independant of the QEMU event loop. Plus, >> some proprietary simulation environment provides a closed

Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers

2012-11-21 Thread Jan Kiszka
On 2012-11-21 15:08, Paolo Bonzini wrote: > Il 21/11/2012 15:00, Jan Kiszka ha scritto: >> +if (!TlsGetValue(current_tls_index)) { >> +leader = g_malloc0(sizeof(*leader)); >> +leader->fiber = ConvertThreadToFiber(NULL); >> +TlsSetValue(current_tls_index, &leader->base);

[Qemu-devel] [PATCH 3/7] uhci: Fix double unlink

2012-11-21 Thread Gerd Hoffmann
From: Hans de Goede uhci_async_cancel() already does a uhci_async_unlink(). Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-uhci.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index 078be2a..8e47803 100

Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers

2012-11-21 Thread malc
On Wed, 21 Nov 2012, Jan Kiszka wrote: > On 2012-11-21 15:08, Paolo Bonzini wrote: > > Il 21/11/2012 15:00, Jan Kiszka ha scritto: > >> +if (!TlsGetValue(current_tls_index)) { > >> +leader = g_malloc0(sizeof(*leader)); > >> +leader->fiber = ConvertThreadToFiber(NULL); > >> +

Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers

2012-11-21 Thread Paolo Bonzini
Il 21/11/2012 15:33, malc ha scritto: >>> > > Leaking leader is a bit bad, but it looks ok for 1.3. >> > >> > Hmm. A TLS destructor is apparently not available. Is there some "on >> > thread termination" callback mechanism on Windows? Didn't find one on >> > first glance. >> > > Dlls receive some

  1   2   >