[Qemu-devel] qemu-kvm not listed by command "virsh list --all"

2012-11-12 Thread Peter Cheung
Dear All Run a VM by qemu-kvm, and then i cannot list it by command "virsh list --all". Why?I am sure the VM is running because i can vnc to it. Thanksfrom Peter

[Qemu-devel] [PATCH 0/1] Default block interface per machine

2012-11-12 Thread Christian Borntraeger
This is a continuation of this discussion: http://lists.gnu.org/archive/html/qemu-devel/2012-04/msg03908.html regarding a default block interface per machine. Sorry for taking so long, but this got somehow lost. Christian Borntraeger (1): Support default block interfaces per QEMUMachine blockd

[Qemu-devel] [PATCH 1/1] Support default block interfaces per QEMUMachine

2012-11-12 Thread Christian Borntraeger
There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a default/standard interface to their block devices / drives. Therfore, this patch introduces a new field default_block per QEMUMachine struct. The prior use_scsi field becomes thereby obsolete and is replaced through .default_block = D

Re: [Qemu-devel] [RFC v1 2/3] ramlist: apply fine grain lock for ram_list

2012-11-12 Thread Paolo Bonzini
Il 12/11/2012 07:22, liu ping fan ha scritto: > On Sat, Nov 10, 2012 at 9:54 AM, Paolo Bonzini wrote: >> Il 09/11/2012 04:14, Liu Ping Fan ha scritto: >>> From: Liu Ping Fan >>> >>> Signed-off-by: Liu Ping Fan >>> --- >>> cpu-all.h |1 + >>> exec.c| 46

Re: [Qemu-devel] [RFC v1 1/3] bouce buffer has fine grain lock

2012-11-12 Thread Paolo Bonzini
Il 12/11/2012 07:23, liu ping fan ha scritto: >> > Also, you do not need to keep the lock after address_space_map exits. >> > In fact, it can be released as soon as bounce.buffer is written to. >> > After that point, bounce will not be touched (the lock only serves to >> > serialize writes to bounc

Re: [Qemu-devel] DOS boot problem with LSI 53C895A SCSI controller and LSI option ROM

2012-11-12 Thread Paolo Bonzini
Il 10/11/2012 22:39, Gerhard Wiesinger ha scritto: > Hello, > > I bisected down a DOS boot problem with LSI 53C895A SCSI controller and > LSI option ROM to the following commit: > e93176d55f1eb4be1a366b51afeaf4f4c8c31d75 The emulation is known to be incomplete; the option ROM is not really suppor

[Qemu-devel] [PATCH v6 0/7] TCG global variables clean-up

2012-11-12 Thread Evgeny Voevodin
This set of patches moves global variables to tcg_ctx: gen_opc_ptr gen_opparam_ptr gen_opc_buf gen_opparam_buf Build tested for all targets. Execution tested on Exynos4210 target. After this patchset was aplied, I noticed 0.7% speed-up of code generation. Probably, this is due to better data cach

[Qemu-devel] [PATCH v6 3/7] TCG: Use gen_opc_ptr from context instead of global variable.

2012-11-12 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin Reviewed-by: Richard Henderson --- target-alpha/translate.c |8 ++--- target-arm/translate.c|8 ++--- target-cris/translate.c | 10 +++--- target-i386/translate.c |8 ++--- target-lm32/translate.c | 10 +++--- target-m

[Qemu-devel] [PATCH v6 5/7] TCG: Use gen_opc_buf from context instead of global variable.

2012-11-12 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin Reviewed-by: Richard Henderson --- target-alpha/translate.c |6 ++-- target-arm/translate.c|6 ++-- target-cris/translate.c |8 +++--- target-i386/translate.c |6 ++-- target-lm32/translate.c |9 +++--- target-m68k

[Qemu-devel] [PATCH v6 4/7] TCG: Use gen_opparam_ptr from context instead of global variable.

2012-11-12 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin Reviewed-by: Richard Henderson --- gen-icount.h |2 +- tcg/tcg-op.h | 254 +- tcg/tcg.c| 36 - 3 files changed, 146 insertions(+), 146 deletions(-) diff --git a/gen-icount.h b/gen-icount.h

Re: [Qemu-devel] [PATCH v6 3/8] hotplug: introduce qdev_unplug_complete() to remove device from views

2012-11-12 Thread Paolo Bonzini
Il 05/11/2012 06:38, Liu Ping Fan ha scritto: > +void qdev_unplug_complete(DeviceState *dev, Error **errp) > +{ > +/* isolate from mem view */ > +qdev_unmap(dev); > +/* isolate from device tree */ > +qdev_unset_parent(dev); > +object_unref(OBJECT(dev)); This leaks the device.

[Qemu-devel] [PATCH v2 0/2] qemu-ga: add hook to quiesce the guest on fsfreeze-freeze/thaw

2012-11-12 Thread Tomoki Sekiyama
Hi, This is version 2 of the qemu-ga fsfreeze hook patchset. *Changes from v1: ( http://lists.gnu.org/archive/html/qemu-devel/2012-11/msg00685.html ) - Fixed bugs in handling file path which contains spaces. - Improved error checkings. - Changed the default hook name to fsfreeze-hook.

Re: [Qemu-devel] [PATCH v2 2/2] qemu-ga: sample fsfreeze hooks

2012-11-12 Thread Tomoki Sekiyama
Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ - fsfreeze-hook.d.sample/mysql-flush.sh : quiesce MySQL before snapshot Signed-off-by: Tomoki Sekiyama --- docs/qemu-guest-agent/fsfreeze-hook| 31 +

Re: [Qemu-devel] [PATCH v2 1/2] qemu-ga: execute hook to quiesce the guest on fsfreeze-freeze/thaw

2012-11-12 Thread Tomoki Sekiyama
To use the online disk snapshot for online-backup, application-level consistency of the snapshot image is required. However, currently the guest agent can provide only filesystem-level consistency, and the snapshot may contain dirty data, for example, incomplete transactions. This patch provides th

Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC

2012-11-12 Thread Gerd Hoffmann
On 11/10/12 00:45, Marek Vasut wrote: > Dear Gerd Hoffmann, > >> On 11/09/12 10:50, Peter Maydell wrote: >>> On 9 November 2012 10:42, Anthony Liguori wrote: While the abstract discussion is fun, it never hurts to be defensive. I agree the root cause is vmware-vga but checking in vnc d

Re: [Qemu-devel] [PATCH] slirp: Don't crash on packets from 0.0.0.0/8.

2012-11-12 Thread Jan Kiszka
On 2012-11-12 01:59, Nickolai Zeldovich wrote: > LWIP can generate packets with a source of 0.0.0.0, which triggers an > assertion failure in arp_table_add(). Instead of crashing, simply return > to avoid adding an invalid ARP table entry. I would prefer to filter out such invalid packets at a di

Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC

2012-11-12 Thread Gerd Hoffmann
Hi, >> I'd go for clipping rather than asserting too (no crash) in all layers >> as a defensive approach (console.c/vnc.c). > > Won't that be an unnecessary slowdown? Thats why I tend to prefer assert for additional sanity checks. They help finding bugs, but can optionally be compiled out. B

Re: [Qemu-devel] [PATCH v6 1/8] atomic: introduce atomic operations

2012-11-12 Thread Paolo Bonzini
Il 05/11/2012 06:38, Liu Ping Fan ha scritto: > From: Liu Ping Fan > > If out of global lock, we will be challenged by SMP in low level, > so need atomic ops. > > This file is a wrapper of GCC atomic builtin. I still object to this. I know it enforces type-safety, but it is incomplete. It doe

Re: [Qemu-devel] [PATCH] MAINTAINERS: add Stefan Hajnoczi as block and virtio-blk co-maintainer

2012-11-12 Thread Kevin Wolf
Am 09.11.2012 14:29, schrieb Stefan Hajnoczi: > Kevin has requested co-maintainership to give him more time to write > code. We will alternate patch review duties on a weekly basis. > > Signed-off-by: Stefan Hajnoczi Acked-by: Kevin Wolf Thanks, applied to the block branch. Kevin

[Qemu-devel] [PATCH v6 2/7] tcg/tcg.h: Duplicate global TCG variables in TCGContext

2012-11-12 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin Reviewed-by: Richard Henderson --- tcg/tcg.h |6 ++ 1 file changed, 6 insertions(+) diff --git a/tcg/tcg.h b/tcg/tcg.h index c2ae873..6ffec1d 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -450,6 +450,12 @@ struct TCGContext { int goto_tb_issue_mask; #end

Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: Workaround for older versions of MinGW gcc

2012-11-12 Thread Kevin Wolf
Am 05.11.2012 06:57, schrieb Stefan Hajnoczi: > On Sun, Nov 04, 2012 at 12:09:34PM +0100, Stefan Weil wrote: >> Versions before gcc-4.6 don't support unnamed fields in initializers >> (see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676). >> >> Offset and OffsetHigh belong to an unnamed struct wh

[Qemu-devel] [PATCH v6 6/7] TCG: Use gen_opparam_buf from context instead of global variable.

2012-11-12 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin Reviewed-by: Richard Henderson --- tcg/tcg.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index a039001..ea0bd3a 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -298,7 +298,7 @@ void tcg_func_start(TCGContext *s)

Re: [Qemu-devel] [PATCH v3] tests: allow qemu-iotests to be run against nbd backend

2012-11-12 Thread Kevin Wolf
Am 02.11.2012 14:01, schrieb Nicholas Thomas: > > From: n...@bytemark.co.uk > To: qemu-devel@nongnu.org > Cc: pbonz...@redhat.com, kw...@redhat.com, Nick Thomas > > Subject: [PATCH v3] tests: allow qemu-iotests to be run against nbd > backend > Date: Fri, 2 Nov 2012 10:28:06 + Something went

[Qemu-devel] [PATCH v6 7/7] TCG: Remove unused global variables

2012-11-12 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin Reviewed-by: Richard Henderson --- tcg/tcg.c |4 tcg/tcg.h |4 translate-all.c |3 --- 3 files changed, 11 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index ea0bd3a..4f75696 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -96,10 +96

Re: [Qemu-devel] q35, usb-ehci1, and Mac OS X boot problems

2012-11-12 Thread Gerd Hoffmann
Hi, > First, what works: > > With the following command line (usb items on the last line): > > bin/qemu-system-x86_64 -enable-kvm -m 2048 -cpu core2duo \ > -device ich9-usb-uhci1 -device usb-kbd -device usb-mouse Just uhci. Ok. > If I replace: > > -device ich9-usb-uhci1 -device usb-kb

Re: [Qemu-devel] [PATCH v2 2/3] aio: use g_slice_alloc() for AIOCB pooling

2012-11-12 Thread Kevin Wolf
Am 31.10.2012 16:34, schrieb Stefan Hajnoczi: > AIO control blocks are frequently acquired and released because each aio > request involves at least one AIOCB. Therefore, we pool them to avoid > heap allocation overhead. > > The problem with the freelist approach in AIOPool is thread-safety. If

Re: [Qemu-devel] [PATCH v2 0/3] aio: use g_slice_alloc() for AIOCB pooling

2012-11-12 Thread Kevin Wolf
Am 31.10.2012 16:34, schrieb Stefan Hajnoczi: > AIO control blocks are frequently acquired and released because each aio > request involves at least one AIOCB. Therefore, we pool them to avoid heap > allocation overhead. > > The problem with the freelist approach in AIOPool is thread-safety. If

Re: [Qemu-devel] [PATCH v2 2/3] aio: use g_slice_alloc() for AIOCB pooling

2012-11-12 Thread Paolo Bonzini
Il 12/11/2012 11:34, Kevin Wolf ha scritto: >> Note that the change from g_malloc0() to g_slice_alloc() should be safe >> since the freelist reuse case doesn't zero the AIOCB either. > > Of course the real reason is that all fields are set anyway. This doesn't necessarily apply for "subclasses",

Re: [Qemu-devel] [PATCH v2 2/3] aio: use g_slice_alloc() for AIOCB pooling

2012-11-12 Thread Kevin Wolf
Am 12.11.2012 11:37, schrieb Paolo Bonzini: > Il 12/11/2012 11:34, Kevin Wolf ha scritto: >>> Note that the change from g_malloc0() to g_slice_alloc() should be safe >>> since the freelist reuse case doesn't zero the AIOCB either. >> >> Of course the real reason is that all fields are set anyway. >

[Qemu-devel] [PATCH] add mac address collision checking for device_add & pci_add

2012-11-12 Thread Lin Ma
QEMU doesn't check if there are mac collisions when adding nics. It causes mac address collisions in guest if adding the nics which include existing physical address. This patch fixes the issue. Signed-off-by: Lin Ma --- hw/qdev-properties.c |9 + net.c| 28 +++

Re: [Qemu-devel] [PATCH 8/8] usb-hid: Allow connecting to a USB-2 device

2012-11-12 Thread Hans de Goede
Hi, On 11/08/2012 04:36 PM, Gerd Hoffmann wrote: On 11/06/12 15:08, Hans de Goede wrote: Our ehci code has is capable of significantly lowering the wakeup rate for the hcd emulation while the device is idle. It is possible to add similar code ot the uhci emulation, but that simply is not there

Re: [Qemu-devel] [PATCH] add mac address collision checking for device_add & pci_add

2012-11-12 Thread Daniel P. Berrange
On Mon, Nov 12, 2012 at 07:12:46PM +0800, Lin Ma wrote: > QEMU doesn't check if there are mac collisions when adding nics. > It causes mac address collisions in guest if adding the nics which > include existing physical address. > This patch fixes the issue. I understand the issue, but are there n

Re: [Qemu-devel] [PATCH] add mac address collision checking for device_add & pci_add

2012-11-12 Thread Paolo Bonzini
Il 12/11/2012 12:18, Daniel P. Berrange ha scritto: >> > QEMU doesn't check if there are mac collisions when adding nics. >> > It causes mac address collisions in guest if adding the nics which >> > include existing physical address. >> > This patch fixes the issue. > I understand the issue, but ar

Re: [Qemu-devel] [PATCH 04/30] buffered_file: Move from using a timer to use a thread

2012-11-12 Thread Paolo Bonzini
Il 18/10/2012 09:30, Juan Quintela ha scritto: > @@ -160,11 +162,8 @@ static int buffered_close(void *opaque) > if (ret >= 0) { > ret = ret2; > } > -qemu_del_timer(s->timer); > -qemu_free_timer(s->timer); > -g_free(s->buffer); > -g_free(s); > - > +ret = migrat

[Qemu-devel] [PATCH 0/1] s390 files gplv2 or later

2012-11-12 Thread Christian Borntraeger
IBMs s390 contributions were meant to to be gplv2 or later (since we were contributing to qemu). Several of the s390 specific files link to gpl code anyway so the ones in qemu repository will have a hard time being strictly LGPL. So lets clarify the licence statement for new contributions for thos

[Qemu-devel] [PATCH 1/1] s390: new contributions GPLv2 or later

2012-11-12 Thread Christian Borntraeger
IBMs s390 contributions were meant to to be gplv2 or later (since we were contributing to qemu). Several of the s390 specific files link to gpl code anyway, so lets clarify the licence statement for new contributions for those files that we have touched multiple times or will likely touch again. T

Re: [Qemu-devel] [PATCH 06/30] migration: stop all cpus correctly

2012-11-12 Thread Paolo Bonzini
Il 18/10/2012 09:30, Juan Quintela ha scritto: > You can only stop all cpus from the iothread or an vcpu. As we want > to do it from the migration_thread, we need to do this dance with the > botton handlers. > > This patch is a request for ideas. I can move this function to cpus.c, but > wondere

Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC

2012-11-12 Thread BALATON Zoltan
On Mon, 12 Nov 2012, Gerd Hoffmann wrote: On 11/10/12 00:45, Marek Vasut wrote: Dear Gerd Hoffmann, On 11/09/12 10:50, Peter Maydell wrote: On 9 November 2012 10:42, Anthony Liguori wrote: While the abstract discussion is fun, it never hurts to be defensive. I agree the root cause is vmwar

Re: [Qemu-devel] [PATCH 1/1] s390: new contributions GPLv2 or later

2012-11-12 Thread Christian Borntraeger
> --- a/target-s390x/kvm.c > +++ b/target-s390x/kvm.c > @@ -2,6 +2,7 @@ > * QEMU S390x KVM implementation > * > * Copyright (c) 2009 Alexander Graf > + * Copyright IBM Corp. 2011 Arg. Should have been 2012.

Re: [Qemu-devel] [PATCH] add mac address collision checking for device_add & pci_add

2012-11-12 Thread Lin Ma
>>> Paolo Bonzini 11/12/12 7:27 PM >>> Il 12/11/2012 12:18, Daniel P. Berrange ha scritto: >> > QEMU doesn't check if there are mac collisions when adding nics. >> > It causes mac address collisions in guest if adding the nics which >> > include existing physical address. >> > This patch fixes the

Re: [Qemu-devel] [PATCH 07/30] migration: make writes blocking

2012-11-12 Thread Paolo Bonzini
Il 18/10/2012 09:30, Juan Quintela ha scritto: > @@ -247,10 +247,6 @@ static int migrate_fd_cleanup(MigrationState *s) > { > int ret = 0; > > -if (s->fd != -1) { > -qemu_set_fd_handler2(s->fd, NULL, NULL, NULL, NULL); > -} > - > if (s->file) { > DPRINTF("closing

[Qemu-devel] [PATCH] qemu-nbd: Initialise main loop earlier

2012-11-12 Thread Kevin Wolf
Since the latest AIO changes qemu-nbd would segfault because bdrv_init() requires qemu_aio_context to be initialised. Signed-off-by: Kevin Wolf --- qemu-nbd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index 15bcd08..80f08d8 100644 --- a/qem

Re: [Qemu-devel] [PATCH] tap: reset vnet header size on open

2012-11-12 Thread Stefan Hajnoczi
On Mon, Nov 12, 2012 at 09:19:18AM +0200, Michael S. Tsirkin wrote: > For tap, we currently assume the vnet header size is 10 > (the default value) but that might not be the case > if tap is persistent and has been used by qemu previously. > To fix, set vnet header size correctly on open. > > Sign

Re: [Qemu-devel] [PATCH] add mac address collision checking for device_add & pci_add

2012-11-12 Thread Stefan Hajnoczi
On Mon, Nov 12, 2012 at 12:49 PM, Lin Ma wrote: Paolo Bonzini 11/12/12 7:27 PM >>> > > Il 12/11/2012 12:18, Daniel P. Berrange ha scritto: >>> > QEMU doesn't check if there are mac collisions when adding nics. >>> > It causes mac address collisions in guest if adding the nics which >>> > inc

Re: [Qemu-devel] [PATCH] qemu-nbd: Initialise main loop earlier

2012-11-12 Thread Paolo Bonzini
Il 12/11/2012 13:23, Kevin Wolf ha scritto: > Since the latest AIO changes qemu-nbd would segfault because > bdrv_init() requires qemu_aio_context to be initialised. Thanks... I had this in my NBD queue, going to send it out later. Paolo > Signed-off-by: Kevin Wolf > --- > qemu-nbd.c |2 +-

[Qemu-devel] [PATCH] aio: fix aio_ctx_prepare with idle bottom halves

2012-11-12 Thread Paolo Bonzini
Commit ed2aec4867f0d5f5de496bb765347b5d0cfe113d changed the return value of aio_ctx_prepare from false to true when only idle bottom halves are available. This broke PC old-style DMA, which uses them. Fix this by making aio_ctx_prepare return true only when non-idle bottom halves are scheduled to

Re: [Qemu-devel] qemu-kvm not listed by command "virsh list --all"

2012-11-12 Thread Stefan Hajnoczi
On Mon, Nov 12, 2012 at 9:01 AM, Peter Cheung wrote: > Dear All >Run a VM by qemu-kvm, and then i cannot list it by command "virsh list > --all". Why? > I am sure the VM is running because i can vnc to it. Libvirt does not manage qemu-kvm processes that were started outside its control by def

Re: [Qemu-devel] [Bug 1077514] [NEW] *** buffer overflow detected ***: qemu-system-x86_64 terminated with nowait enabled

2012-11-12 Thread Stefan Hajnoczi
On Sun, Nov 11, 2012 at 12:24 AM, Kaare Baastrup wrote: > Public bug reported: > > qemu-system-x86_64 -m 1024 -nographic -cpu coreduo -icount auto -hdachs > 980,16,32 -kernel asa842-vmlinuz -initrd asa842-initrd.gz -append > "ide_generic.probe_mask=0x01 ide_core.chs=0.0:980,16,32 auto nousb > c

Re: [Qemu-devel] [Bug 1077514] [NEW] *** buffer overflow detected ***: qemu-system-x86_64 terminated with nowait enabled

2012-11-12 Thread Paolo Bonzini
Il 12/11/2012 13:47, Stefan Hajnoczi ha scritto: > > qemu-system-x86_64 -m 1024 -nographic -cpu coreduo -icount auto -hdachs > > 980,16,32 -kernel asa842-vmlinuz -initrd asa842-initrd.gz -append > > "ide_generic.probe_mask=0x01 ide_core.chs=0.0:980,16,32 auto nousb > > console=ttyS0,9600 bigphys

Re: [Qemu-devel] [PATCH] coroutine-sigaltstack.c: Use stack_t, not struct sigaltstack

2012-11-12 Thread Stefan Hajnoczi
On Sat, Nov 10, 2012 at 10:47 PM, Peter Maydell wrote: > Use the POSIX-specified stack_t type as the argument to sigaltstack() > rather than the legacy struct sigaltstack. This allows us to compile > on MacOSX with --with-coroutine=sigaltstack. > > Signed-off-by: Peter Maydell > --- > Tested on L

[Qemu-devel] KVM call agenda for 2012-11-12

2012-11-12 Thread Juan Quintela
Hi Please send in any agenda topics you are interested in. Later, Juan.

Re: [Qemu-devel] [PATCH V19 1/7] Support for TPM command line options

2012-11-12 Thread Stefan Berger
On 11/08/2012 10:52 AM, Corey Bryant wrote: On 10/24/2012 03:06 PM, Stefan Berger wrote: On 09/27/2012 10:12 AM, Corey Bryant wrote: On 06/04/2012 03:37 PM, Stefan Berger wrote: +if (!QLIST_EMPTY(&tpm_backends)) { +error_report("Only one TPM is allowed.\n"); +return 1

Re: [Qemu-devel] [PATCH V19 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-11-12 Thread Stefan Berger
On 11/08/2012 10:39 AM, Corey Bryant wrote: Thanks for your responses. I have a few comments below. On 10/24/2012 02:46 PM, Stefan Berger wrote: On 09/27/2012 10:22 AM, Corey Bryant wrote: On 06/04/2012 03:37 PM, Stefan Berger wrote: +/* check for ongoing seize by a highe

Re: [Qemu-devel] [PATCH V2] qemu-sockets: Fix parsing of the inet option 'to'.

2012-11-12 Thread Markus Armbruster
Anthony PERARD writes: > Having a qemu command line argument like "-vnc 127.0.0.1:0,to=99" is broken. > This have been break with commit 879e45c72da1569e07fbbc6a1aa2a708ea796044. > > Signed-off-by: Anthony PERARD Thanks for taking the time to identify the commit that broke it. Reviewed-by: Mar

[Qemu-devel] [PULL 1.3 0/5] SCSI updates for 2012-11-12

2012-11-12 Thread Paolo Bonzini
Anthony, The following changes since commit 3c5645fab3c4b65d0cffbe1aaafc787e4be63d0f: tcg: properly check that op's output needs to be synced to memory (2012-11-11 16:06:46 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you to fetch changes

[Qemu-devel] [PATCH 1/5] scsi: do not return short responses for emulated commands

2012-11-12 Thread Paolo Bonzini
The inquiry command, for the case of VPD=1, was returning short responses; the number of returned bytes was just the number of bytes in the request, without padding to the specified allocation length with zero bytes. This is usually harmless, but it is a violation of the SCSI specification. To fi

[Qemu-devel] [PATCH 3/5] scsi: remove superfluous call to scsi_device_set_ua

2012-11-12 Thread Paolo Bonzini
Suggested by Laszlo Ersek. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 1 - 1 file modificato. 1 rimozione(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 098558d..d15f891 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -1964,7 +1964,6 @@ static void scsi_disk_resize_cb(void *op

[Qemu-devel] [PATCH 4/5] megasas: do not include block_int.h

2012-11-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/megasas.c | 1 - 1 file modificato. 1 rimozione(-) diff --git a/hw/megasas.c b/hw/megasas.c index 7a2036e..b845ea7 100644 --- a/hw/megasas.c +++ b/hw/megasas.c @@ -25,7 +25,6 @@ #include "iov.h" #include "scsi.h" #include "scsi-defs.h" -#include "block_int.

[Qemu-devel] [PATCH] kvm: Actually remove software breakpoints from list on cleanup

2012-11-12 Thread Jan Kiszka
So far we only removed them from the guest, leaving its states in the list. This made it impossible for gdb to re-enable breakpoints on the same address after re-attaching. Signed-off-by: Jan Kiszka --- kvm-all.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/kvm-all.c

[Qemu-devel] [PATCH 5/5] scsi-disk: flush cache after disabling it

2012-11-12 Thread Paolo Bonzini
SBC says that "if an application client changes the WCE bit from one to zero via a MODE SELECT command, then the device server shall write any data in volatile cache to non-volatile medium before completing the command". Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 9 + 1 file modif

[Qemu-devel] [PULL 1.3 0/7] NBD updates for 2012-11-12

2012-11-12 Thread Paolo Bonzini
Anthony, The following changes since commit 3c5645fab3c4b65d0cffbe1aaafc787e4be63d0f: tcg: properly check that op's output needs to be synced to memory (2012-11-11 16:06:46 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git nbd-next for you to fetch changes u

[Qemu-devel] [PATCH 1/7] qemu-nbd: initialize main loop before block layer

2012-11-12 Thread Paolo Bonzini
qemu-nbd was broken because they initialized the block layer while qemu_aio_context was still NULL. Signed-off-by: Paolo Bonzini --- qemu-nbd.c | 2 +- 1 file modificato, 1 inserzione(+). 1 rimozione(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index 15bcd08..80f08d8 100644 --- a/qemu-nbd.c +++ b/qe

[Qemu-devel] [PATCH 7/7] hmp: add NBD server commands

2012-11-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hmp-commands.hx | 45 ++ hmp.c | 76 + hmp.h | 3 +++ 3 file modificati, 124 inserzioni(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index f916385..b

[Qemu-devel] [PATCH 2/7] nbd: accept relative path to Unix socket

2012-11-12 Thread Paolo Bonzini
Adding the "is_unix" member now will simplify the parsing of NBD URIs. Signed-off-by: Paolo Bonzini --- block/nbd.c | 17 +++-- 1 file modificato, 7 inserzioni(+), 10 rimozioni(-) diff --git a/block/nbd.c b/block/nbd.c index 2bce47b..48bbeca 100644 --- a/block/nbd.c +++ b/block/nbd.

[Qemu-devel] [PATCH 6/7] nbd: disallow nbd-server-add before nbd-server-start

2012-11-12 Thread Paolo Bonzini
It works nicely with the QMP commands, but it adds useless complication with HMP. In particular, see the following: (qemu) nbd_server_add -w scsi0-hd0 (qemu) nbd_server_start -a localhost:10809 NBD server already exporting device scsi0-hd0 Signed-off-by: Paolo Bonzini --- blockdev-

[Qemu-devel] [PATCH 2/5] virtio-scsi: factor checks for VIRTIO_SCSI_S_DRIVER_OK when reporting events

2012-11-12 Thread Paolo Bonzini
Suggested by Laszlo Ersek. Signed-off-by: Paolo Bonzini --- hw/virtio-scsi.c | 8 +--- 1 file modificato, 5 inserzioni(+), 3 rimozioni(-) diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c index b54c789..30d3f8a 100644 --- a/hw/virtio-scsi.c +++ b/hw/virtio-scsi.c @@ -596,6 +596,10 @@ static

[Qemu-devel] [PATCH 4/7] nbd: fix nbd_server_stop crash when no server was running

2012-11-12 Thread Paolo Bonzini
This failed on the new assertion of qemu_set_fd_handler2: qemu-system-x86_64: /home/pbonzini/work/upstream/qemu/iohandler.c:60: qemu_set_fd_handler2: Assertion `fd >= 0' failed. Signed-off-by: Paolo Bonzini --- blockdev-nbd.c | 8 +--- 1 file modificato, 5 inserzioni(+), 3 rimozioni(-) di

[Qemu-devel] [PATCH 5/7] nbd: force read-only export for read-only devices

2012-11-12 Thread Paolo Bonzini
This is the desired behavior for HMP, but it is a better choice for QMP as well. Signed-off-by: Paolo Bonzini --- blockdev-nbd.c | 7 +++ 1 file modificato, 7 inserzioni(+) diff --git a/blockdev-nbd.c b/blockdev-nbd.c index 274fba6..e362572 100644 --- a/blockdev-nbd.c +++ b/blockdev-nbd.c @

Re: [Qemu-devel] [PATCH] slirp: Don't crash on packets from 0.0.0.0/8.

2012-11-12 Thread Nickolai Zeldovich
On Mon, Nov 12, 2012 at 4:37 AM, Jan Kiszka wrote: > On 2012-11-12 01:59, Nickolai Zeldovich wrote: >> LWIP can generate packets with a source of 0.0.0.0, which triggers an >> assertion failure in arp_table_add(). Instead of crashing, simply return >> to avoid adding an invalid ARP table entry. >

[Qemu-devel] [PATCH] ehci: fix compile error with EHCI_DEBUG enabled

2012-11-12 Thread Gabriel L. Somlo
This patch fixes a few debugging print statements whose arguments fell out of sync over time with changes being made to the active code base. Signed-off-by: Gabriel Somlo --- On Mon, Nov 12, 2012 at 11:26:18AM +0100, Gerd Hoffmann wrote: > Seems macos doesn't like something in our ehci emulation

[Qemu-devel] [PATCH 3/7] nbd: accept URIs

2012-11-12 Thread Paolo Bonzini
The URI syntax is consistent with the Gluster syntax. Export names are specified in the path, preceded by one or more (otherwise unused) slashes. Signed-off-by: Paolo Bonzini --- block/nbd.c | 98 ++- qemu-doc.texi | 25 ++-

Re: [Qemu-devel] [PATCH] Revert "serial: fix retry logic"

2012-11-12 Thread Michael Tokarev
Ping^2 ? /mjt 27.10.2012 12:31, Michael Tokarev wrote: > Ping? > > On 19.09.2012 12:08, Michael Tokarev wrote: >> This reverts commit 67c5322d7000fd105a926eec44bc1765b7d70bdd: >> >> I'm not sure if the retry logic has ever worked when not using FIFO >> mode. I >> found this while writi

Re: [Qemu-devel] q35, usb-ehci1, and Mac OS X boot problems

2012-11-12 Thread Gabriel L. Somlo
Gerd, On Mon, Nov 12, 2012 at 11:26:18AM +0100, Gerd Hoffmann wrote: > Seems macos doesn't like something in our ehci emulation ... > Can you send a trace with all ehci tracepoints enabled? For brevity, I replaced each cluster of six "Port X not enabled" lines with one "Port 0..5 not enabled", bu

Re: [Qemu-devel] qemu and transparent huge pages

2012-11-12 Thread Michael Tokarev
Ping^2 ? Thanks, /mjt 16.09.2012 15:19, Michael Tokarev wrote: > So, is the patch okay? > > Thanks, > > /mjt > > On 15.08.2012 19:03, Michael Tokarev wrote: >> On 15.08.2012 18:26, Avi Kivity wrote: >>> On 08/15/2012 05:22 PM, Michael Tokarev wrote: >>> > > Please provide extra info,

[Qemu-devel] [PATCH] megasas: Correct target/lun mapping

2012-11-12 Thread Hannes Reinecke
The structure to reference a logical drive has an unused field, which can be used to carry the lun ID. This enabled seabios to establish the proper target/LUN mapping. Signed-off-by: Hannes Reinecke Cc: Paolo Bonzini Cc: Gerd Hofmann diff --git a/hw/megasas.c b/hw/megasas.c index 7a2036e..395f

Re: [Qemu-devel] [PATCH] megasas: Correct target/lun mapping

2012-11-12 Thread Paolo Bonzini
Il 12/11/2012 15:42, Hannes Reinecke ha scritto: > The structure to reference a logical drive has an unused field, > which can be used to carry the lun ID. This enabled seabios to > establish the proper target/LUN mapping. > > Signed-off-by: Hannes Reinecke > Cc: Paolo Bonzini > Cc: Gerd Hofmann

Re: [Qemu-devel] [PULL 1.3 0/5] SCSI updates for 2012-11-12

2012-11-12 Thread Paolo Bonzini
Il 12/11/2012 15:03, Paolo Bonzini ha scritto: > Anthony, > > The following changes since commit 3c5645fab3c4b65d0cffbe1aaafc787e4be63d0f: > > tcg: properly check that op's output needs to be synced to memory > (2012-11-11 16:06:46 +0100) > > are available in the git repository at: > > git

[Qemu-devel] -mtdblock QEMU option

2012-11-12 Thread Vipin Gahlaut
Hi Experts, QEMU 1.2.0 Virtual Platform:versatilepb Linux Kernel:3.5.5 Command to run QEMU: /usr/local/bin/qemu-system-arm -M versatilepb -kernel /home/vgahlaut/labs/linux-3.5.5/arch/arm/boot/zImage -nographic -hda /home/vgahlaut/labs/disk.img -append "root

Re: [Qemu-devel] [PATCH] aio: fix aio_ctx_prepare with idle bottom halves

2012-11-12 Thread malc
On Mon, 12 Nov 2012, Paolo Bonzini wrote: > Commit ed2aec4867f0d5f5de496bb765347b5d0cfe113d changed the return > value of aio_ctx_prepare from false to true when only idle bottom > halves are available. This broke PC old-style DMA, which uses them. > Fix this by making aio_ctx_prepare return true

Re: [Qemu-devel] [PATCH] slirp: Don't crash on packets from 0.0.0.0/8.

2012-11-12 Thread Jan Kiszka
On 2012-11-12 15:41, Nickolai Zeldovich wrote: > On Mon, Nov 12, 2012 at 4:37 AM, Jan Kiszka wrote: >> On 2012-11-12 01:59, Nickolai Zeldovich wrote: >>> LWIP can generate packets with a source of 0.0.0.0, which triggers an >>> assertion failure in arp_table_add(). Instead of crashing, simply ret

[Qemu-devel] [PATCH v2] slirp: Don't crash on packets from 0.0.0.0/8.

2012-11-12 Thread Nickolai Zeldovich
LWIP can generate packets with a source of 0.0.0.0, which triggers an assertion failure in arp_table_add(). Instead of crashing, simply return to avoid adding an invalid ARP table entry. Signed-off-by: Nickolai Zeldovich --- slirp/arp_table.c |4 +++- 1 file changed, 3 insertions(+), 1 dele

Re: [Qemu-devel] [PATCH V19 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-11-12 Thread Corey Bryant
On 11/12/2012 08:16 AM, Stefan Berger wrote: On 11/08/2012 10:39 AM, Corey Bryant wrote: Thanks for your responses. I have a few comments below. On 10/24/2012 02:46 PM, Stefan Berger wrote: On 09/27/2012 10:22 AM, Corey Bryant wrote: On 06/04/2012 03:37 PM, Stefan Berger wrote: +

Re: [Qemu-devel] [PATCH] block: vpc support for ~2 TB disks

2012-11-12 Thread Charles Arnold
Ping? Any thoughts on whether this is acceptable? - Charles >>> On 10/30/2012 at 08:59 PM, in message <50a0e561.5b74.009...@suse.com>, >>> Charles Arnold wrote: > The VHD specification allows for up to a 2 TB disk size. The current > implementation in qemu emulates EIDE and ATA-2 hardware whic

Re: [Qemu-devel] [PATCH] block: vpc initialize the uuid footer field

2012-11-12 Thread Charles Arnold
Ping? Is this ok? - Charles >>> On 11/2/2012 at 09:54 AM, in message <50a0e829.5b74.009...@suse.com>, >>> Charles Arnold wrote: > block/vpc: Initialize the uuid field in the footer with a generated uuid. > > Signed-off-by: Charles Arnold > > diff --git a/block/vpc.c b/block/vpc.c > index b6

[Qemu-devel] [PATCHv3 3/5] net: Disallow device hotplug that causes execve()

2012-11-12 Thread Eduardo Otubo
We'll soon be introducing a second whitelist that prevents execve() right before the main_loop() is entered. In preparation, we need to gracefully disable use of exec'd scripts/binaries when hotplugging network devices. For example, the following will not be allowed: netdev_add tap,id=tapdev0 ne

[Qemu-devel] [PATCHv3 2/5] seccomp: setting "-sandbox on" as deafult

2012-11-12 Thread Eduardo Otubo
Now the seccomp filter will be set to "on" even if no argument "-sandbox" is given. v3: * Introduced seccomp_states enum and new functions named seccomp_set_state() and seccomp_get_state() (pbonz...@redhat.com). * Merged seccomp_start() and install_seccomp_filter(), moved inst

[Qemu-devel] [PATCHv3 4/5] seccomp: double whitelist support

2012-11-12 Thread Eduardo Otubo
This patch includes a second whitelist right before the main loop. The second whitelist is more restricted and does not contain execve(). Although it works fine the way it is now, it's optimal to update and fine tune it. v2: * ctx changed to main_loop_ctx * seccomp_on now inside ifdef * op

[Qemu-devel] [PATCH] vga: fix bochs alignment issue

2012-11-12 Thread Gerd Hoffmann
The bochs dispi interface traditionally uses port 0x1ce as 16bit index register and port 0x1cf as 16bit data register. The later is unaligned, and probably for that reason the the data register was moved to 0x1d0 for non-x86 archs. This patch makes the data register available at 0x1d0 on x86 too.

[Qemu-devel] [PATCHv3 1/5] seccomp: adding new syscalls (bugzilla 855162)

2012-11-12 Thread Eduardo Otubo
According to the bug 855162[0] - there's the need of adding new syscalls to the whitelist when using Qemu with Libvirt. [0] - https://bugzilla.redhat.com/show_bug.cgi?id=855162 v2: Adding new syscalls to the list: readlink, rt_sigpending, and rt_sigtimedwait v3: * Added new syscalls based o

[Qemu-devel] [PATCHv3 5/5] seccomp: adding debug mode

2012-11-12 Thread Eduardo Otubo
This patch is meant for developer debug purposes only. It adds support that displays the offending system call number if QEMU is being killed by seccomp. The offending system call may need to be added to the appropriate system call white list in qemu-seccomp.c to prevent seccomp from killing QEMU

Re: [Qemu-devel] DOS boot problem with LSI 53C895A SCSI controller and LSI option ROM

2012-11-12 Thread Gerhard Wiesinger
On 12.11.2012 09:26, Paolo Bonzini wrote: Il 10/11/2012 22:39, Gerhard Wiesinger ha scritto: Hello, I bisected down a DOS boot problem with LSI 53C895A SCSI controller and LSI option ROM to the following commit: e93176d55f1eb4be1a366b51afeaf4f4c8c31d75 The emulation is known to be incomplete;

[Qemu-devel] [PATCH 05/17] target-i386: cpu_x86_init(): move error handling to end of function

2012-11-12 Thread Eduardo Habkost
Doing error handling on a single place will make it easier to make sure memory is freed, and that error information is properly printed or returned to the caller. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH 03/17] target-i386: cpu: rename x86_def_t to X86CPUDefinition

2012-11-12 Thread Eduardo Habkost
Change to match QEMU coding style. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index b50ca8c..2dfcc9c 100644 --- a/target-i386/cpu.c +++ b/target

[Qemu-devel] [PATCH 10/17] target-i386: kill cpu_x86_register()

2012-11-12 Thread Eduardo Habkost
Move the cpu_x86_register() code inside cpu_x86_init(), as the initialization steps are going to be reordered. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c in

[Qemu-devel] [PATCH 09/17] target-i386: move out CPU features initialization to separate func

2012-11-12 Thread Eduardo Habkost
From: Igor Mammedov Later it will be used in cpu_x86_init() to init CPU from found cpudef. This is will make it easier to reorder and clean up the cpu_x86_init() code later. Signed-off-by: Igor Mammedov [ehabkost: added error reporting to function] Signed-off-by: Eduardo Habkost --- v2: -

[Qemu-devel] [PATCH 08/17] target-i386: cpu_x86_register(): reorder CPU property setting

2012-11-12 Thread Eduardo Habkost
Trivial code movement, before moving the code to another function. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 9334e0c..7f4e8f0 100644 --- a/target-i386/cpu.c +++ b/ta

[Qemu-devel] [PATCH 06/17] target-i386: cpu_x86_init(): print error message in case of error

2012-11-12 Thread Eduardo Habkost
Error information is being ignored and never returned to the caller. While we don't change cpu_x86_init() to not return error information, print error message inside cpu_x86_init() in case of error. Signed-off-by: Eduardo Habkost --- Changes v2: - Use error_report() - Add "cpu_x86_init:" prefi

[Qemu-devel] [PATCH 17/17] target-i386: cpu_x86_init(): reorder split of CPU string and creation of CPU object

2012-11-12 Thread Eduardo Habkost
A step towards making the creation of CPU objects use the CPU model name as class name. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index e47ec5d..5f2ce7d 100644

[Qemu-devel] [PATCH 16/17] target-i386: cpu: separate cpudef lookup from feature string parsing

2012-11-12 Thread Eduardo Habkost
- Move the CPU string split and cpudef lookup to cpu_x86_init(); - Rename cpu_x86_find_by_name() to cpu_x86_parse_feature_string(), and make it just get the feature string as input. This will allow us to use the CPU model name for the CPU class lookup, inside cpu_x86_init(). Signed-off-by: Edua

[Qemu-devel] [PATCH 01/17] target-i386/cpu.c: coding style fix

2012-11-12 Thread Eduardo Habkost
Use spaces instead of tabs on cpu_x86_cpuid(). Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index e1db639..fa8b5bd 100644 --- a/target-i386/cpu.c +++ b/targe

  1   2   >