Re: [Qemu-devel] 1.1.1 -> 1.1.2 migrate /managedsave issue

2012-10-24 Thread Philipp Hahn
Hello Doug, On Tuesday 23 October 2012 22:38:47 Doug Goldstein wrote: > >>> qemu: warning: error while loading state for instance 0x0 of device > >>> 'ram' load of migration failed ... > >> I diagnosed that using gdb to single step kvm until I found > >> hw/pci.c#get_pci_config_device() returning

Re: [Qemu-devel] [patch v4 12/16] e1000: apply fine lock on e1000

2012-10-24 Thread Jan Kiszka
On 2012-10-24 08:31, liu ping fan wrote: > On Tue, Oct 23, 2012 at 5:04 PM, Jan Kiszka wrote: >> On 2012-10-22 11:23, Liu Ping Fan wrote: >>> Use local lock to protect e1000. When calling the system function, >>> dropping the fine lock before acquiring the big lock. This will >>> introduce broken

Re: [Qemu-devel] [PATCH 5/5] HMP: Introduce console command

2012-10-24 Thread Lei Li
On 10/23/2012 02:59 AM, Luiz Capitulino wrote: On Mon, 22 Oct 2012 00:48:01 +0800 Lei Li wrote: Signed-off-by: Lei Li --- hmp-commands.hx | 23 +++ hmp.c | 53 + hmp.h |1 + monitor.c

Re: [Qemu-devel] [patch v4 05/16] memory: introduce ref, unref interface for MemoryRegionOps

2012-10-24 Thread Paolo Bonzini
Il 23/10/2012 18:09, Avi Kivity ha scritto: >> But our interfaces had better support asynchronicity, and indeed they >> do: after you write to the "eject" register, the "up" will show the >> device as present until after destroy is done. This can be changed to >> show the device as present only un

Re: [Qemu-devel] [patch v4 12/16] e1000: apply fine lock on e1000

2012-10-24 Thread liu ping fan
On Tue, Oct 23, 2012 at 5:04 PM, Jan Kiszka wrote: > On 2012-10-22 11:23, Liu Ping Fan wrote: >> Use local lock to protect e1000. When calling the system function, >> dropping the fine lock before acquiring the big lock. This will >> introduce broken device state, which need extra effort to fix. >

[Qemu-devel] [PATCH v3 0/3] net: convert NetClientState to QOM

2012-10-24 Thread Stefan Hajnoczi
This series converts NetClientState from a plain C struct to QOM. This means emulated NICs and netdevs now derive from the NetClientState base class. There should be no user-visible change. Converting the net subsystem to QOM opens the door to the following improvements which can be built on top

[Qemu-devel] [PATCH v3 1/3] net: add public qemu_net_poll() function

2012-10-24 Thread Stefan Hajnoczi
The NetClientInfo .poll() callback is being called directly by hw/vhost_net.c. Create a public net.c function so callers do not depend on internals. This change is useful because later patches change net internals. Those changes shouldn't affect .poll() callers. Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v3 2/3] net: extract notify_link_status_changed() function

2012-10-24 Thread Stefan Hajnoczi
The code to invoke the NetClientInfo .link_status_changed() callback is duplicated in several places. Create a single notify_link_status_changed() function and avoid duplication. This is useful because later patches change net internals. By having a single function it is easier to make changes w

Re: [Qemu-devel] [RFC PATCH v3 05/19] Implement dimm device abstraction

2012-10-24 Thread liu ping fan
On Tue, Oct 23, 2012 at 8:25 PM, Stefan Hajnoczi wrote: > On Fri, Sep 21, 2012 at 01:17:21PM +0200, Vasilis Liaskovitis wrote: >> +static void dimm_populate(DimmDevice *s) >> +{ >> +DeviceState *dev= (DeviceState*)s; >> +MemoryRegion *new = NULL; >> + >> +new = g_malloc(sizeof(MemoryRe

Re: [Qemu-devel] [PATCH 0/7] ARM boards: don't prematurely explode QEMUMachineInitArgs

2012-10-24 Thread Markus Armbruster
Peter Maydell writes: > A lot of the ARM board models follow the pattern of having a > single common init function which is called with various > parameters from the QEMUMachine init function for several board > model variants. The change to QEMUMachineInitArgs in commit 5f072e > took the fairly

Re: [Qemu-devel] buildbot failure in qemu on block_mingw32

2012-10-24 Thread Kevin Wolf
Am 24.10.2012 03:05, schrieb q...@buildbot.b1-systems.de: > The Buildbot has detected a new failure on builder block_mingw32 while > building qemu. > Full details are available at: > http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/363 > > Buildbot URL: http://buildbot.b1-systems

Re: [Qemu-devel] [PATCH 0/7] ARM boards: don't prematurely explode QEMUMachineInitArgs

2012-10-24 Thread Peter Maydell
On 24 October 2012 09:42, Markus Armbruster wrote: > Peter Maydell writes: > >> A lot of the ARM board models follow the pattern of having a >> single common init function which is called with various >> parameters from the QEMUMachine init function for several board >> model variants. The change

Re: [Qemu-devel] raltelimit bug

2012-10-24 Thread Paolo Bonzini
Il 24/10/2012 10:56, Dietmar Maurer ha scritto: > The code to compute slice_quota seems buggy. The following fixes the issue: > > --- new.orig/include/qemu/ratelimit.h 2012-10-22 07:06:31.0 +0200 > +++ new/include/qemu/ratelimit.h2012-10-22 07:06:49.0 +0200 > @@ -42,7 +42

[Qemu-devel] [PATCH 19/32] block: introduce new dirty bitmap functionality

2012-10-24 Thread Kevin Wolf
From: Paolo Bonzini Assert that write_compressed is never used with the dirty bitmap. Setting the bits early is wrong, because a coroutine might concurrently examine them and copy incomplete data from the source. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block.c | 51 ++

[Qemu-devel] [PATCH 12/32] monitor: Allow add-fd to any specified fd set

2012-10-24 Thread Kevin Wolf
From: Corey Bryant The first call to add an fd to an fd set was previously not allowed to choose the fd set ID. The ID was generated as the first available and ensuing calls could add more fds by specifying the fd set ID. This change allows users to choose the fd set ID on the first call. Sign

[Qemu-devel] [PATCH 13/32] monitor: Enable adding an inherited fd to an fd set

2012-10-24 Thread Kevin Wolf
From: Corey Bryant qmp_add_fd() gets an fd that was received over a socket with SCM_RIGHTS and adds it to an fd set. This patch adds support that will enable adding an fd that was inherited on the command line to an fd set. Note: All of the code added to monitor_fdset_add_fd(), with the excepti

[Qemu-devel] [PATCH 21/32] block: rename block_job_complete to block_job_completed

2012-10-24 Thread Kevin Wolf
From: Paolo Bonzini The imperative will be used for the QMP command. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block/commit.c |2 +- block/stream.c |4 ++-- blockjob.c |2 +- blockjob.h |4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --

[Qemu-devel] [PATCH 18/32] block: add bdrv_open_backing_file

2012-10-24 Thread Kevin Wolf
From: Paolo Bonzini Mirroring runs without the backing file so that it can be copied outside QEMU. However, we need to add it at the time the job is completed and QEMU switches to the target. Factor out the common bits of opening an image and completing a mirroring operation. The new function

[Qemu-devel] [PATCH 31/32] qemu-iotests: add testcases for mirroring on-source-error/on-target-error

2012-10-24 Thread Kevin Wolf
From: Paolo Bonzini The new options are tested with blkdebug on both the source and the target. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- tests/qemu-iotests/041| 253 + tests/qemu-iotests/041.out|4 +- tests/qemu-iotest

[Qemu-devel] [PATCH 28/32] iostatus: forward block_job_iostatus_reset to block job

2012-10-24 Thread Kevin Wolf
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block.c|3 +++ blockjob.c |3 +++ blockjob.h |6 +- 3 files changed, 11 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index ad5e240..1564137 100644 --- a/block.c +++ b/block.c @@

[Qemu-devel] [PATCH 27/32] qemu-iotests: add mirroring test case

2012-10-24 Thread Kevin Wolf
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- tests/qemu-iotests/041 | 362 tests/qemu-iotests/041.out |5 + tests/qemu-iotests/group |1 + 3 files changed, 368 insertions(+), 0 deletions(-) create mo

[Qemu-devel] [Bug 1070762] [NEW] savevm fails with inserted CD, "Device '%s' is writable but does not support snapshots."

2012-10-24 Thread Oliver Francke
Public bug reported: Hi, yesterday unfortunately a customer reported a failed snapshot of his VM. Going through the logfile I discovered: "Device 'ide1-cd0' is writable but does not support snapshots" this is with qemu-1.2.0 and 1.0.1 at least... Why writeable? Even if I specify "-drive ...,re

[Qemu-devel] [PATCH 17/32] block: add bdrv_query_stats

2012-10-24 Thread Kevin Wolf
From: Paolo Bonzini qmp_query_blockstat cannot have errors, remove the Error argument and create a new public function bdrv_query_stats out of it. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block.c | 18 ++ block.h |1 + 2 files changed, 7 insertions(+),

Re: [Qemu-devel] [RFC PATCH v3 05/19] Implement dimm device abstraction

2012-10-24 Thread Stefan Hajnoczi
On Wed, Oct 24, 2012 at 10:06 AM, liu ping fan wrote: > On Tue, Oct 23, 2012 at 8:25 PM, Stefan Hajnoczi wrote: >> On Fri, Sep 21, 2012 at 01:17:21PM +0200, Vasilis Liaskovitis wrote: >>> +static void dimm_populate(DimmDevice *s) >>> +{ >>> +DeviceState *dev= (DeviceState*)s; >>> +MemoryR

[Qemu-devel] [PATCH 04/32] qemu-img rebase: use empty string to rebase without backing file

2012-10-24 Thread Kevin Wolf
From: Alex Bligh This patch allows an empty filename to be passed as the new base image name for qemu-img rebase to mean base the image on no backing file (i.e. independent of any backing file). According to Eric Blake, qemu-img rebase already supports this when '-u' is used; this adds support wh

[Qemu-devel] [PATCH 26/32] mirror: implement completion

2012-10-24 Thread Kevin Wolf
From: Paolo Bonzini Switching to the target of the migration is done mostly asynchronously, and reported to management via the BLOCK_JOB_COMPLETED event; the only synchronous phase is opening the backing files. bdrv_open_backing_file can always be done, even for migration of the full image (aka

[Qemu-devel] [PATCH 08/32] qemu-img: Add --backing-chain option to info command

2012-10-24 Thread Kevin Wolf
From: Stefan Hajnoczi The qemu-img info --backing-chain option enumerates the backing file chain. For example, for base.qcow2 <- snap1.qcow2 <- snap2.qcow2 the output becomes: $ qemu-img info --backing-chain snap2.qcow2 image: snap2.qcow2 file format: qcow2 virtual size: 100M (104857600

[Qemu-devel] [PATCH 32/32] osdep: Less restrictive F_SEFL in qemu_dup_flags()

2012-10-24 Thread Kevin Wolf
From: Corey Bryant qemu_dup_flags() currently limits the flags that can be set on the fcntl() F_SETFL call to those that we currently know can be set with fcntl() F_SETFL. The problem with this is that it will prevent use of new flags in the future without a code update. This patch relaxes the

[Qemu-devel] [PATCH 05/32] block: make bdrv_find_backing_image compare canonical filenames

2012-10-24 Thread Kevin Wolf
From: Jeff Cody Currently, bdrv_find_backing_image compares bs->backing_file with what is passed in as a backing_file name. Mismatches may occur, however, when bs->backing_file and backing_file are not both absolute or relative. Use path_combine() to make sure any relative backing filenames are

[Qemu-devel] [PATCH 14/32] monitor: Prevent removing fd from set during init

2012-10-24 Thread Kevin Wolf
From: Corey Bryant If an fd is added to an fd set via the command line, and it is not referenced by another command line option (ie. -drive), then clean it up after QEMU initialization is complete. Signed-off-by: Corey Bryant Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- monitor.c |

[Qemu-devel] [PATCH 15/32] qemu-config: Add new -add-fd command line option

2012-10-24 Thread Kevin Wolf
From: Corey Bryant This option can be used for passing file descriptors on the command line. It mirrors the existing add-fd QMP command which allows an fd to be passed to QEMU via SCM_RIGHTS and added to an fd set. This can be combined with commands such as -drive to link file descriptors in an

[Qemu-devel] [PATCH 09/32] qemu-iotests: Add 043 backing file chain infinite loop test

2012-10-24 Thread Kevin Wolf
From: Stefan Hajnoczi This new test verifies that qemu-img info --backing-chain safely aborts when an image file has a backing file infinite loop. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- tests/qemu-iotests/043 | 95 ++ tests

[Qemu-devel] [PATCH 16/32] block: add bdrv_query_info

2012-10-24 Thread Kevin Wolf
From: Paolo Bonzini Extract it out of the implementation of "info block". Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block.c | 106 +++--- block.h |1 + 2 files changed, 54 insertions(+), 53 deletions(-) diff --git

[Qemu-devel] [PATCH 03/32] qmp: fix __accept() in qmp.py

2012-10-24 Thread Kevin Wolf
From: Jeff Cody In QEMUMonitorProtocol, commit e9d17b6 removed the __sockfile creation from __negotiate_capabilities(), which breaks _accept(). This causes failures in qemu-io python based tests (i.e. tests 030 and 040). This patch creates the sockfile in __accept() as well. Signed-off-by: Jef

[Qemu-devel] [PATCH 07/32] qemu-iotests: add relative backing file tests for block-commit (040)

2012-10-24 Thread Kevin Wolf
From: Jeff Cody The previous block commit used absolute filenames for all block-commit images and commands; this adds relative filenames for the same tests. Signed-off-by: Jeff Cody Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- tests/qemu-iotests/040 | 102 ++

[Qemu-devel] [PATCH 06/32] block: in commit, determine base image from the top image

2012-10-24 Thread Kevin Wolf
From: Jeff Cody This simplifies some code and error checking, and also fixes a bug. bdrv_find_backing_image() should only be passed absolute filenames, or filenames relative to the chain. In the QMP message handler for block commit, when looking up the base do so from the determined top image,

[Qemu-devel] [PATCH 02/32] qemu-iotests: Test qemu-img operation on zero size image

2012-10-24 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Paolo Bonzini --- tests/qemu-iotests/042 | 78 tests/qemu-iotests/042.out | 15 tests/qemu-iotests/group |1 + 3 files changed, 94 insertions(+), 0 deletions(-) create mode 100755 tests/qe

[Qemu-devel] [PATCH 24/32] mirror: introduce mirror job

2012-10-24 Thread Kevin Wolf
From: Paolo Bonzini This patch adds the implementation of a new job that mirrors a disk to a new image while letting the guest continue using the old image. The target is treated as a "black box" and data is copied from the source to the target in the background. This can be used for several pur

[Qemu-devel] [PATCH 23/32] block: introduce BLOCK_JOB_READY event

2012-10-24 Thread Kevin Wolf
From: Paolo Bonzini Even for jobs that need to be manually completed, management may want to take care itself of the completion, not requiring the user to issue a command to terminate the job. In this case we want to avoid that they poll us continuously, waiting for completion to become availabl

[Qemu-devel] [PATCH 10/32] qemu-img: document 'info --backing-chain'

2012-10-24 Thread Kevin Wolf
From: Kashyap Chamarthy Signed-off-by: Kashyap Chamarthy Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qemu-img-cmds.hx |4 ++-- qemu-img.texi| 21 - 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx

[Qemu-devel] [PULL 00/32] Block patches

2012-10-24 Thread Kevin Wolf
The following changes since commit a8170e5e97ad17ca169c64ba87ae2f53850dab4c: Rename target_phys_addr_t to hwaddr (2012-10-23 08:58:25 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Alex Bligh (1): qemu-img rebase: use empty string to rebase

[Qemu-devel] [PATCH 20/32] block: export dirty bitmap information in query-block

2012-10-24 Thread Kevin Wolf
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block.c |7 +++ qapi-schema.json | 18 +- 2 files changed, 24 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index 2c3d3da..ad5e240 100644 --- a/block.c +++ b/block.

[Qemu-devel] [PATCH 01/32] qemu-img: Fix division by zero for zero size images

2012-10-24 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Paolo Bonzini --- qemu-img.c | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index f17f187..849eb41 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -674,7 +674,7 @@ static int img_convert(i

[Qemu-devel] [PATCH 30/32] qmp: add pull_event function

2012-10-24 Thread Kevin Wolf
From: Paolo Bonzini This function is unlike get_events in that it makes it easy to process one event at a time. This is useful in the mirroring test cases, where we want to process just one event (BLOCK_JOB_ERROR) and leave the others to a helper function. Acked-by: Luiz Capitulino Signed-off-

[Qemu-devel] [PATCH 11/32] block: bdrv_create(): don't leak cco.filename on error

2012-10-24 Thread Kevin Wolf
From: Luiz Capitulino Signed-off-by: Luiz Capitulino Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 5e7fc9e..7e26b6f 100644 --- a/block.c +++ b/block.c @@ -379,7 +379,8 @@

[Qemu-devel] [PATCH 29/32] mirror: add support for on-source-error/on-target-error

2012-10-24 Thread Kevin Wolf
From: Paolo Bonzini Error management is important for mirroring; otherwise, an error on the target (even something as "innocent" as ENOSPC) requires to start again with a full copy. Similar to on_read_error/on_write_error, two separate knobs are provided for on_source_error (reads) and on_target

[Qemu-devel] [PATCH 22/32] block: add block-job-complete

2012-10-24 Thread Kevin Wolf
From: Paolo Bonzini While streaming can be dropped as soon as it progressed through the whole image, mirroring needs to be completed manually for two reasons: 1) so that management knows exactly when the VM switches to the target; 2) because for other use cases such as replication, we may leave t

[Qemu-devel] [PATCH 25/32] qmp: add drive-mirror command

2012-10-24 Thread Kevin Wolf
From: Paolo Bonzini This adds the monitor commands that start the mirroring job. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- blockdev.c | 124 ++ hmp-commands.hx | 21 + hmp.c| 28

Re: [Qemu-devel] buildbot failure in qemu on block_mingw32

2012-10-24 Thread Luiz Capitulino
On Wed, 24 Oct 2012 11:16:38 +0200 Kevin Wolf wrote: > Am 24.10.2012 03:05, schrieb q...@buildbot.b1-systems.de: > > The Buildbot has detected a new failure on builder block_mingw32 while > > building qemu. > > Full details are available at: > > http://buildbot.b1-systems.de/qemu/builders/block

[Qemu-devel] [PATCH v1] qemu: Document GlusterFS block driver usage

2012-10-24 Thread Bharata B Rao
qemu: Document GlusterFS block driver usage From: Bharata B Rao Signed-off-by: Bharata B Rao --- qemu-doc.texi | 49 + qemu-options.hx | 17 + 2 files changed, 66 insertions(+) diff --git a/qemu-doc.texi b/qemu-doc.texi ind

Re: [Qemu-devel] [PATCH 0/7] ARM boards: don't prematurely explode QEMUMachineInitArgs

2012-10-24 Thread Markus Armbruster
Peter Maydell writes: > On 24 October 2012 09:42, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> A lot of the ARM board models follow the pattern of having a >>> single common init function which is called with various >>> parameters from the QEMUMachine init function for several boar

Re: [Qemu-devel] [PATCH 0/7] ARM boards: don't prematurely explode QEMUMachineInitArgs

2012-10-24 Thread Eduardo Habkost
On Wed, Oct 24, 2012 at 10:42:55AM +0200, Markus Armbruster wrote: > Peter Maydell writes: > > > A lot of the ARM board models follow the pattern of having a > > single common init function which is called with various > > parameters from the QEMUMachine init function for several board > > model

Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server

2012-10-24 Thread Nicholas Thomas
On Tue, 2012-10-23 at 16:02 +0100, Jamie Lokier wrote: > Nicholas Thomas wrote: > > On Tue, 2012-10-23 at 12:33 +0200, Kevin Wolf wrote: > > > Am 22.10.2012 13:09, schrieb n...@bytemark.co.uk: > > > > > > > > This is unlikely to come up now, but is a necessary prerequisite for > > > > reconnectio

Re: [Qemu-devel] [PATCH] linux-user: Merge pread/pwrite into pread64/pwrite64

2012-10-24 Thread Peter Maydell
Ping? -- PMM On 12 October 2012 14:55, Peter Maydell wrote: > The Linux syscalls underlying pread() and pwrite() take a 64 bit > offset on all architectures, even if some of them name the syscall > "pread/pwrite" rather than "pread64/pwrite64" for historical reasons. > So move the four QEMU targ

Re: [Qemu-devel] [PATCH] configure: Disable (clang) initializer-overrides warnings

2012-10-24 Thread Peter Maydell
On 14 October 2012 21:24, Peter Maydell wrote: > On 14 October 2012 21:15, Blue Swirl wrote: >> On Sun, Oct 14, 2012 at 8:00 PM, Peter Maydell >> wrote: >>> Blue Swirl previously submitted a patch which enabled this flag >>> (among others): >>> http://lists.gnu.org/archive/html/qemu-devel/2012-

[Qemu-devel] [PATCH] net: Reject non-netdevs in qmp_netdev_del()

2012-10-24 Thread Stefan Hajnoczi
The netdev_del command crashes when given a -net device, because it calls qemu_opts_del(NULL). Check that this is a -netdev before attempting to delete it and the QemuOpts. Note the subtle change from qemu_find_opts_err("netdev", errp) to qemu_find_opts_err("netdev", NULL). Since "netdev" is a b

[Qemu-devel] [RFC] net: Peer with existing NIC in netdev_add

2012-10-24 Thread Stefan Hajnoczi
Allow netdev_del followed by netdev_add to re-peer a NIC and its netdev: (qemu) info network virtio-net-pci.0: type=nic,model=virtio-net-pci,macaddr=52:54:00:12:34:56 \ netdev0: type=user,net=10.0.2.0,restrict=off (qemu) netdev_del netdev0 (qemu) netdev_add socket,id=netdev0,listen=:1

Re: [Qemu-devel] [PATCH 5/5] HMP: Introduce console command

2012-10-24 Thread Luiz Capitulino
On Wed, 24 Oct 2012 15:17:21 +0800 Lei Li wrote: > On 10/23/2012 02:59 AM, Luiz Capitulino wrote: > > On Mon, 22 Oct 2012 00:48:01 +0800 > > Lei Li wrote: > > > >> Signed-off-by: Lei Li > >> --- > >> hmp-commands.hx | 23 +++ > >> hmp.c | 53 > >> ++

Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server

2012-10-24 Thread Kevin Wolf
Am 24.10.2012 14:16, schrieb Nicholas Thomas: > On Tue, 2012-10-23 at 16:02 +0100, Jamie Lokier wrote: >> Since the I/O _order_ before, and sometimes after, flush, is important >> for data integrity, this needs to be maintained when I/Os are queued in >> the disconnected state -- including those wh

[Qemu-devel] [PATCH 01/32] libcacard: simplify rules for recursive build

2012-10-24 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile | 10 +- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/Makefile b/Makefile index 17e2d58..5fc94ef 100644 --- a/Makefile +++ b/Makefile @@ -141,19 +141,11 @@ version-obj-$(CONFIG_WIN32) += version.o # Support building shared lib

[Qemu-devel] [PATCH 15/32] net: reorganize headers

2012-10-24 Thread Paolo Bonzini
Move public headers to include/net, and leave private headers in net/. Put the virtio headers in include/net/tap.h, removing the multiple copies that existed. Leave include/net/tap.h as the interface for NICs, and net/tap_int.h as the interface for OS-specific parts of the tap backend. Signed-off

[Qemu-devel] [PATCH 20/32] qapi: move include files to include/qapi/

2012-10-24 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- blockdev.h |2 +- dump.c |2 +- error.c|2 +- hw/pci-hotplug.c |2 +- hw/qdev.c

[Qemu-devel] [PATCH 22/32] block: move include files to include/block/

2012-10-24 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- aes.c |2 +- aio.c |2 +- async.c|2 +- block-migration.c |2 +- block.c

[Qemu-devel] [PATCH 24/32] monitor: move include files to include/monitor/

2012-10-24 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- arch_init.c |2 +- audio/audio.c|2 +- audio/wavcapture.c |2 +- balloon.c|2 +- balloon.h|2 +- bloc

[Qemu-devel] [PATCH 29/32] softmmu: move remaining include files to include/ subdirectories

2012-10-24 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- bt-host.c |2 +- bt-vhci.c |2 +- gdbstub.c |2 +- hmp.c |2 +- hw/baum.c |2 +- hw/bt-hci-csr.c

[Qemu-devel] [PATCH 2/4] target-arm: Use TCG operation for Neon 64 bit negation

2012-10-24 Thread Peter Maydell
Use the TCG operation to do Neon 64 bit negations rather than calling a helper routine for it. Reviewed-by: Aurelien Jarno Signed-off-by: Peter Maydell --- target-arm/helper.h |1 - target-arm/neon_helper.c |6 -- target-arm/translate.c |4 +++- 3 files changed, 3 inserti

Re: [Qemu-devel] [PATCH v1] qemu: Document GlusterFS block driver usage

2012-10-24 Thread Kevin Wolf
Am 24.10.2012 13:47, schrieb Bharata B Rao: > qemu: Document GlusterFS block driver usage > > From: Bharata B Rao Please don't repeat the subject line and From: header in the body. > > Signed-off-by: Bharata B Rao > --- > qemu-doc.texi | 49 +++

[Qemu-devel] [PATCH 10/32] janitor: do not rely on indirect inclusions from qemu-char.h

2012-10-24 Thread Paolo Bonzini
Various header files rely on qemu-char.h including qemu-config.h or main-loop.h, but they really do not need qemu-char.h at all (particularly interesting is the case of the block layer!). Clean this up, and also complete the set of inclusions of qemu-config.h itself. Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH v3 01/26] blockdev: Introduce a default machine blockdev interface field, QEMUMachine->mach_if

2012-10-24 Thread Markus Armbruster
Jason Baron writes: > From: Jason Baron > > The current QEMUMachine definition has a 'use_scsi' field to indicate if a > machine type should use scsi by default. However, Q35 wants to use ahci by > default. Thus, introdue a new field in the QEMUMachine defintion, mach_if. Even though q35's desi

[Qemu-devel] [PATCH v2 0/8] ARM boards: don't prematurely explode QEMUMachineInitArgs

2012-10-24 Thread Peter Maydell
A lot of the ARM board models follow the pattern of having a single common init function which is called with various parameters from the QEMUMachine init function for several board model variants. The change to QEMUMachineInitArgs in commit 5f072e took the fairly mechanical approach of splitting t

[Qemu-devel] [PATCH v2 4/8] hw/spitz: Don't prematurely explode QEMUMachineInitArgs

2012-10-24 Thread Peter Maydell
Don't explode QEMUMachineInitArgs before calling common init function. Signed-off-by: Peter Maydell --- hw/spitz.c | 45 ++--- 1 file changed, 10 insertions(+), 35 deletions(-) diff --git a/hw/spitz.c b/hw/spitz.c index 944c274..12e2815 100644 --- a/hw/

[Qemu-devel] [PATCH v2 7/8] hw/mainstone: Don't prematurely explode QEMUMachineInitArgs

2012-10-24 Thread Peter Maydell
Don't explode QEMUMachineInitArgs before passing it to mainstone_init(). Signed-off-by: Peter Maydell --- hw/mainstone.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/hw/mainstone.c b/hw/mainstone.c index 3266946..5bbecb7 100644 --- a/hw/mainstone.c

[Qemu-devel] [PATCH 1/4] arm-semi.c: Handle get/put_user() failure accessing arguments

2012-10-24 Thread Peter Maydell
Rework the handling of arguments to ARM semihosting calls so that we handle a possible failure return from get_user_ual() or put_user_ual(). (This incidentally silences a lot of warnings from clang about "expression result unused"). Signed-off-by: Peter Maydell --- target-arm/arm-semi.c | 167 +

[Qemu-devel] [PATCH v2 2/8] hw/realview.c: Don't prematurely explode QEMUMachineInitArgs

2012-10-24 Thread Peter Maydell
Don't explode QEMUMachineInitArgs in every realview init function; just pass it to the common realview_init() code instead. Signed-off-by: Peter Maydell --- hw/realview.c | 68 - 1 file changed, 19 insertions(+), 49 deletions(-) diff --g

[Qemu-devel] [PATCH 4/4] target-arm: Remove out of date FIXME regarding saturating arithmetic

2012-10-24 Thread Peter Maydell
Remove an out of date FIXME regarding the saturating arithmetic helpers: we now do pass a pointer to CPUARMState to these helpers, and since the AREG0 changes went in there is no difference between helper.c and op_helper.c and therefore no point in moving the functions. Signed-off-by: Peter Maydel

[Qemu-devel] [PULL 0/3] QMP queue

2012-10-24 Thread Luiz Capitulino
The changes (since a8170e5e97ad17ca169c64ba87ae2f53850dab4c) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Aurelien Jarno (1): hmp: fix info cpus for sparc targets Paolo Bonzini (2): qmp: handle stop/cont in INMIGRATE state migration: go to

[Qemu-devel] [PULL 1/3] hmp: fix info cpus for sparc targets

2012-10-24 Thread Luiz Capitulino
From: Aurelien Jarno On sparc targets, info cpus returns this kind of output: | info cpus | * CPU #0: pc=0x00424d18pc=0x00424d18npc=0x00424d1c thread_id=19460 pc is printed twice, there is no space between pc, pc and npc. With this patch, pc is not printed anymore when

[Qemu-devel] [PULL 3/3] migration: go to paused state after finishing incoming migration with -S

2012-10-24 Thread Luiz Capitulino
From: Paolo Bonzini At the end of migration the machine has started already, and cannot be destroyed without losing the guest's data. Hence, prelaunch is the wrong state. Go to the paused state instead. QEMU would reach that state anyway (after running the guest for the blink of an eye) if the

[Qemu-devel] [PULL 2/3] qmp: handle stop/cont in INMIGRATE state

2012-10-24 Thread Luiz Capitulino
From: Paolo Bonzini Right now, stop followed by an incoming migration will let the virtual machine start. cont before an incoming migration instead will fail. This is bad because the actual behavior is not predictable; it is racy with respect to the start of the incoming migration. That's beca

[Qemu-devel] [PATCH v2 1/8] hw/vexpress.c: Don't prematurely explode QEMUMachineInitArgs

2012-10-24 Thread Peter Maydell
Don't explode QEMUMachineInitArgs before passing it to the vexpress common init function. Signed-off-by: Peter Maydell --- hw/vexpress.c | 38 +- 1 file changed, 9 insertions(+), 29 deletions(-) diff --git a/hw/vexpress.c b/hw/vexpress.c index 3f7cb66..d93f

[Qemu-devel] [PATCH 14/32] net: move net.c to net/

2012-10-24 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs |2 +- net/Makefile.objs |2 +- net.c => net/net.c |8 3 files changed, 6 insertions(+), 6 deletions(-) rename net.c => net/net.c (99%) diff --git a/Makefile.objs b/Makefile.objs index 66a0b3d..7bbe646 100644 --- a/Makefi

Re: [Qemu-devel] [PATCH 07/32] build: kill libdis, move disassemblers to disas/

2012-10-24 Thread Peter Maydell
On 24 October 2012 13:58, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > +echo "CONFIG_ALPHA_DIS=y" >> config-all-disass.mak "config-all-disas.mak" for consistency with the abbreviation we use everywhere else, please. -- PMM

[Qemu-devel] [PATCH v2 6/8] hw/nseries: Don't prematurely explode QEMUMachineInitArgs

2012-10-24 Thread Peter Maydell
Don't explode QEMUMachineInitArgs before passing it to n8x0_init(). Signed-off-by: Peter Maydell --- hw/nseries.c | 39 +++ 1 file changed, 11 insertions(+), 28 deletions(-) diff --git a/hw/nseries.c b/hw/nseries.c index 7ada90d..6560d3c 100644 --- a/hw/nse

[Qemu-devel] [PATCH 18/32] audio: move public header file to include/audio/

2012-10-24 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- audio/alsaaudio.c|2 +- audio/audio.c|2 +- audio/audio_pt_int.c |2 +- audio/audio_win_int.c|3 +-- audio/coreaudio.c|2 +- audio/dsoundaudio.c |2 +-

Re: [Qemu-devel] [PATCH 00/37 v5] target-i386: convert CPU features into properties

2012-10-24 Thread Eduardo Habkost
On Tue, Oct 23, 2012 at 03:56:52PM +0200, Igor Mammedov wrote: > On Tue, 23 Oct 2012 09:32:53 -0400 > Don Slutz wrote: > > > On 10/22/12 11:02, Igor Mammedov wrote: > > > v5: > > >- Use static properties instead of dynamic ones > > >- Compile in KVM CPUID features only if CONFIG_KVM is de

[Qemu-devel] [PATCH v2 3/8] hw/versatilepb: Don't prematurely explode QEMUMachineInitArgs

2012-10-24 Thread Peter Maydell
Don't explode QEMUMachineInitArgs before passing it to the common versatile init function. Signed-off-by: Peter Maydell --- hw/versatilepb.c | 44 +++- 1 file changed, 11 insertions(+), 33 deletions(-) diff --git a/hw/versatilepb.c b/hw/versatilepb.c in

[Qemu-devel] [PATCH v2 8/8] hw/exynos4_boards: Don't prematurely explode QEMUMachineInitArgs

2012-10-24 Thread Peter Maydell
Don't explode QEMUMachineInitArgs before passing it to exynos4_boards_init_common(). Signed-off-by: Peter Maydell --- hw/exynos4_boards.c | 32 +++- 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/hw/exynos4_boards.c b/hw/exynos4_boards.c index 49510

[Qemu-devel] [PATCH 02/32] vscclient: use per-target variables

2012-10-24 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 5fc94ef..21b4ded 100644 --- a/Makefile +++ b/Makefile @@ -162,8 +162,9 @@ qemu-io$(EXESUF): qemu-io.o cmd.o $(tools-obj-y) $(block-obj-y) qemu-bridge-

[Qemu-devel] [PATCH 31/32] hw: move executable format header files to hw/

2012-10-24 Thread Paolo Bonzini
Or delete a.out.h which is unused. Signed-off-by: Paolo Bonzini --- a.out.h | 430 - uboot_image.h => hw/uboot_image.h |0 2 files changed, 0 insertions(+), 430 deletions(-) delete mode 100644 a.out.h rename uboot_image.h => hw

[Qemu-devel] [PATCH 30/32] fpu: move public header file to include/fpu

2012-10-24 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure|2 +- fpu/softfloat.c |2 +- {fpu => include/fpu}/softfloat.h |0 include/qemu/bswap.h |2 +- linux-user/arm/nwfpe/double_cpdo.c |2 +- linux-user/arm/nwfpe/extend

Re: [Qemu-devel] [memory] abort with head a8170e5

2012-10-24 Thread Aurelien Jarno
On Wed, Oct 24, 2012 at 09:15:32AM +1000, Richard Henderson wrote: > qemu-system-sparc64: /home/rth/work/qemu/qemu/memory.c:1022: > memory_region_destroy: Assertion `memory_region_transaction_depth == 0' > failed. > > Program received signal SIGABRT, Aborted. > 0x75234925 in raise () fro

[Qemu-devel] [PATCH 09/32] janitor: move iovector functions out of cutils.c

2012-10-24 Thread Paolo Bonzini
This removes the dependency of cutils.c on iov.c, and lets us remove iov.o from several builds. Signed-off-by: Paolo Bonzini --- Makefile |2 +- Makefile.objs |4 +- cutils.c | 103 - iov.c | 103 +

[Qemu-devel] [PATCH 19/32] slirp: move public header file to include/slirp/

2012-10-24 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- {slirp => include/slirp}/libslirp.h |5 + main-loop.c |2 +- slirp/misc.c|1 - slirp/slirp.h |7 +-- 4 files changed, 7 insertions(+), 8 deletions(-) rename {slirp => in

[Qemu-devel] [PATCH 32/32] janitor: move remaining public headers to include/

2012-10-24 Thread Paolo Bonzini
Headers in the root directory are now used only from within that directory. Signed-off-by: Paolo Bonzini --- config.h => include/config.h |0 elf.h => include/elf.h |0 libfdt_env.h => include/libfdt_env.h |0 qemu-common.h => include/qemu-common.h |0

Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server

2012-10-24 Thread Paolo Bonzini
Il 24/10/2012 14:16, Nicholas Thomas ha scritto: > > I've also just noticed that flush & discard don't take the send_mutex > before writing to the socket. That can't be intentional, surely? Paolo? No, it's a bug. Paolo

Re: [Qemu-devel] Resource reporting for VGA cards

2012-10-24 Thread Gerd Hoffmann
On 10/23/12 23:04, Hervé Poussineau wrote: > Hi, > Gerd Hoffmann a écrit : >> On 10/22/12 21:43, Hervé Poussineau wrote: >>> Hello, >>> >>> I'm trying to add support for a S3 PCI VGA card to QEMU. It currently >>> works on some non-x86 systems. >>> However, on x86, it seems that the card is correct

[Qemu-devel] [PATCH] target-i386: cpu: recover items 28-31 of ext2_feature_name

2012-10-24 Thread Eduardo Habkost
I removed a line by mistake on commit 3b671a40cab2404bc63e57db8cd3afa4ec70bfab, containing the flags lm/i64, 3dnow, and 3dnowext. This patch restores the removed line. Reported-by: Don Slutz Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a

Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server

2012-10-24 Thread Paolo Bonzini
Il 24/10/2012 16:03, Paolo Bonzini ha scritto: > Il 24/10/2012 14:16, Nicholas Thomas ha scritto: >> >> I've also just noticed that flush & discard don't take the send_mutex >> before writing to the socket. That can't be intentional, surely? Paolo? > > No, it's a bug. Hmm, why do you say it doesn

Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server

2012-10-24 Thread Nicholas Thomas
On Wed, 2012-10-24 at 16:10 +0200, Paolo Bonzini wrote: > Il 24/10/2012 16:03, Paolo Bonzini ha scritto: > > Il 24/10/2012 14:16, Nicholas Thomas ha scritto: > >> > >> I've also just noticed that flush & discard don't take the send_mutex > >> before writing to the socket. That can't be intentional,

[Qemu-devel] [PATCH v12 02/14] target-mips: Add ASE DSP resources access check

2012-10-24 Thread Jia Liu
Add MIPS ASE DSP resources access check. Signed-off-by: Jia Liu --- linux-user/main.c |6 ++ target-mips/cpu.h | 23 +-- target-mips/helper.c|3 +++ target-mips/translate.c | 23 +++ 4 files changed, 53 insertions(+), 2 dele

  1   2   3   >