Eduardo Habkost writes:
> On Wed, Jul 15, 2009 at 01:43:31PM +0200, Gerd Hoffmann wrote:
> [...]
>> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
>> new file mode 100644
>> index 000..8b0d0ff
>> --- /dev/null
>> +++ b/hw/qdev-properties.c
>> @@ -0,0 +1,246 @@
>
> Gerd, could you cl
Jan Kiszka writes:
> On 2012-10-17 22:14, Eduardo Habkost wrote:
>> On Wed, Jul 15, 2009 at 01:43:31PM +0200, Gerd Hoffmann wrote:
>> [...]
>>> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
>>> new file mode 100644
>>> index 000..8b0d0ff
>>> --- /dev/null
>>> +++ b/hw/qdev-properti
Eduardo Habkost writes:
> On Wed, Oct 17, 2012 at 01:00:55PM -0500, Anthony Liguori wrote:
[...]
>> I don't really understand the split here and the 'system' suffix really
>> doesn't explain it for me. Could you at least add a comment to each of
>> these files explaining what belongs in them?
>
On Thu, Oct 18, 2012 at 05:06:33PM +0200, Paolo Bonzini wrote:
> Il 18/10/2012 16:56, Stefan Hajnoczi ha scritto:
> >
> > -static NetClientInfo net_tap_win32_info = {
> > -.type = NET_CLIENT_OPTIONS_KIND_TAP,
> > -.size = sizeof(TAPState),
> > -.receive = tap_receive,
> > -.cleanu
Paolo Bonzini writes:
> Il 17/10/2012 17:17, Markus Armbruster ha scritto:
>>> > +fail:
>>> > +if (!error_is_set(errp)) {
>>> > +error_set(errp, QERR_VNC_SERVER_FAILED, display);
>> How can we get here with no error set?
>>
>> 1. !vnc_display (first goto fail).
>
> This can be fixed
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1065325
Title:
qemu-system-arm hangs on SIGUSR1 on OS X 10.8.2
Status in QEMU:
Invalid
Bug descri
On Fri, Oct 19, 2012 at 07:56:55AM +0200, Dmitry Fleytman wrote:
> Real HW always treats RX ring with RDH == RDT as empty.
> Emulation is supposed to behave the same.
>
> Reported-by: Chris Webb
> Reported-by: Richard Davies
> Signed-off-by: Dmitry Fleytman
> ---
> hw/e1000.c | 7 ++-
> 1
On 19 October 2012 07:40, Peter Crosthwaite
wrote:
> This field is completely unused. The base address should also be abstracted
> away from the device anyway. Removed.
>
> Signed-off-by: Peter Crosthwaite
Reviewed-by: Peter Maydell
-- PMM
Paolo Bonzini writes:
> Il 17/10/2012 17:40, Markus Armbruster ha scritto:
>>> > if (s->current_addr) {
>>> > while (s->current_addr->ai_next != NULL && s->fd < 0) {
>>> > s->current_addr = s->current_addr->ai_next;
>>> > -s->fd = inet_connect_addr(s->curren
On 19 October 2012 07:40, Peter Crosthwaite
wrote:
> This field is completely unused.
>
> Signed-off-by: Peter Crosthwaite
Reviewed-by: Peter Maydell
-- PMM
Am 18.10.2012 16:52, schrieb Paolo Bonzini:
> Il 18/10/2012 15:56, Kevin Wolf ha scritto:
>> Am 18.10.2012 15:10, schrieb Paolo Bonzini:
>>> Il 18/10/2012 15:07, Kevin Wolf ha scritto:
>> +s->synced = false;
>> +if (read) {
>> +return block_job_error_action(&s->common, s
On 19 October 2012 07:40, Peter Crosthwaite
wrote:
> Add a variant to sysbus_mmio_map that allow specifying a target memory region.
> The requested device memory region is mapped within the argument target memory
> region rather than the default (get_system_memory()). Behaviour of original
> sysbu
Paolo Bonzini writes:
> Il 17/10/2012 18:43, Markus Armbruster ha scritto:
>> Paolo Bonzini writes:
>>
>>> Acked-by: Luiz Capitulino
>>> Signed-off-by: Paolo Bonzini
>>> ---
>>> qapi-schema.json | 53 +
>>> 1 file modificato, 53 inserzioni(
Paolo Bonzini writes:
> These are QAPI-friendly versions of the qemu-sockets functions. They
> support IP sockets, Unix sockets, and named file descriptors, using a
> QAPI union to dispatch to the correct function.
>
> Reviewed-by: Luiz Capitulino
> Signed-off-by: Paolo Bonzini
> ---
> Makefi
Paolo Bonzini writes:
> The first user of close notifiers will be the embedded NBD server.
> It is possible to use them to do some of the ad hoc processing
> (e.g. for block jobs and I/O limits) that is currently done by
> bdrv_close.
>
> Acked-by: Kevin Wolf
> Signed-off-by: Paolo Bonzini
> --
On Thu, Oct 18, 2012 at 08:32:54AM +0200, Alexander Graf wrote:
>
>
> On 18.10.2012, at 03:18, Benjamin Herrenschmidt
> wrote:
>
> > On Thu, 2012-10-18 at 11:09 +1100, David Gibson wrote:
> >
> That's horrible; if you use -boot just once it will clobber a
> persistent NVRAM's boot o
Paolo Bonzini writes:
> The first user of close notifiers will be the embedded NBD server.
> It is possible to use them to do some of the ad hoc processing
> (e.g. for block jobs and I/O limits) that is currently done by
> bdrv_close.
If the second sentence is an idea for future work, you could
On Wed, Oct 17, 2012 at 05:14:14PM -0300, Eduardo Habkost wrote:
> On Wed, Jul 15, 2009 at 01:43:31PM +0200, Gerd Hoffmann wrote:
> [...]
> > diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
> > new file mode 100644
> > index 000..8b0d0ff
> > --- /dev/null
> > +++ b/hw/qdev-properties.c
Support for the Quad SPI flash controller in Xilinx Zynq.
Peter Crosthwaite (3):
m25p80: Support for Quad SPI
xilinx_spips: Generalised to model QSPI
xilinx_zynq: added QSPI controller
hw/m25p80.c | 61 +++-
hw/xilinx_spips.c | 289 +
Added the Quad mode read and write commands. Data remains serialized on a
single wire, i.e. the quad mode instructions just behave the same as single
mode, with the expection of modelling the varying number of dummy/mode bytes
between the address bytes and the first data word.
Signed-off-by: Peter
Added the QSPI controller to the Zynq. 4 SPI devices are attached to allow
modelling of the different geometries. E.G. Dual parallel and dual stacked
mode can both be tested with this one arrangement.
Signed-off-by: Peter Crosthwaite
---
hw/xilinx_zynq.c | 40 -
Paolo Bonzini writes:
> Adding an NBD server inside QEMU is trivial, since all the logic is
> in nbd.c and can be shared easily between qemu-nbd and QEMU itself.
> The main difference is that qemu-nbd serves a single unnamed export,
> while QEMU serves named exports.
For NBD noobs like me, a sho
On Fri, Oct 12, 2012 at 06:59:44PM +0100, Peter Maydell wrote:
> Commit 4be403c accidentally defined the target_phys_addr_t type when
> building user-mode emulators. Since the type doesn't really make
> any sense except for system emulators, avoid defining it when building
> in user mode.
>
> Sign
On Fri, Oct 12, 2012 at 07:07:23PM +0100, Peter Maydell wrote:
> Commit 33ebc29 fixed the bugs in the implementation of VQRSHL,
> but forgot to remove the FIXME comment...
>
> Signed-off-by: Peter Maydell
> ---
> target-arm/neon_helper.c |1 -
> 1 file changed, 1 deletion(-)
Thanks, applied
Paolo Bonzini writes:
> Acked-by: Luiz Capitulino
> Signed-off-by: Paolo Bonzini
> ---
> hmp-commands.hx | 29 +
> hmp.c | 55 +++
> hmp.h | 2 ++
> 3 file modificati, 86 inserzioni(+)
>
> diff
> > These are QAPI-friendly versions of the qemu-sockets functions.
> > They support IP sockets, Unix sockets, and named file descriptors, using
> > a QAPI union to dispatch to the correct function.
> >
> > Reviewed-by: Luiz Capitulino
> > Signed-off-by: Paolo Bonzini
> > ---
> > Makefile
On Sun, Oct 14, 2012 at 07:58:48PM +, Blue Swirl wrote:
> I made a small tool to detect unused functions and
> variables. Here's some fixes.
>
> Blue Swirl (11):
> target-sparc: make do_unaligned_access static
> vl.c: add missing static
> vnc: add missing static and remove unused functio
Extended the xilinx spips controller to model QSPI as well. Paremeterised the
operational difference with the normal spi controller (num_ss_bits, width of the
tx/rx fifo heads etc.). Multiple bus functionality is modelled (needed for QSPI
dual parallel mode. LQSPI is modelled.
Signed-off-by: Peter
On Mon, Oct 15, 2012 at 07:45:40AM +0200, Stefan Weil wrote:
> This modification is required if compiler option -Wunused-parameter is
> activated.
>
> Signed-off-by: Stefan Weil
> ---
> configure |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to the trivial patc
> >> Two port members, one is 'str', the other is 'uint16'. Ugly.
> >
> > This is because port can be a service name. Using a union was
> > deemed
> > overkill.
>
> Two ways to reduce the ugliness:
>
> 1. Make @to a string, too. Yes, users don't normally want to specify
> the upper bound as s
On Wed, Oct 17, 2012 at 07:53:50PM +0200, Stefan Weil wrote:
> The include file for net_init_tap was missing:
>
> net/tap-win32.c:703:
> warning: no previous prototype for ‘net_init_tap’
>
> Signed-off-by: Stefan Weil
> ---
> net/tap-win32.c |1 +
> 1 file changed, 1 insertion(+)
Thanks,
On 19.10.2012, at 10:24, David Gibson wrote:
> On Thu, Oct 18, 2012 at 08:32:54AM +0200, Alexander Graf wrote:
>>
>>
>> On 18.10.2012, at 03:18, Benjamin Herrenschmidt
>> wrote:
>>
>>> On Thu, 2012-10-18 at 11:09 +1100, David Gibson wrote:
>>>
>> That's horrible; if you use -boot just
> > I tried to split this one into many commits, but I wasn't sure it
> > was worth to make a mini-series out of one function. In retrospect
> > it was.
>
> Review of a long series is unrewarding when the patches are all
> perfect ;)
LOL, will split the patch anyway.
Paolo
On Thu, Oct 18, 2012 at 05:40:53PM +0100, Peter Maydell wrote:
> Fix some minor typos/grammar errors in comments.
>
> Signed-off-by: Peter Maydell
> ---
> v1->v2: reinstated carelessly dropped 'if', noted by Stefan Weil.
>
> ui/vnc-jobs.c | 16
> 1 file changed, 8 insertions(
Thanks Stefan,
It was my very first idea to drop check_rxov and solve the problem,
however for some reason I was sure that it required to emulate real HW behavior.
I'm glad we clarified this.
Regards,
Dmitry Fleytman
On Fri, Oct 19, 2012 at 9:52 AM, Stefan Hajnoczi wrote:
> On Fri, Oct 19, 201
> >> If yes, but it's healed later in the series, the temporary
> >> breakage still needs to be spelled out in the commit message.
> >
> > No, it's not healed, which is why it's mentioned in the commit
> > message that future work is needed.
>
> I really hate "reward" submissions of tons of useful
The following changes since commit b6348f29d033d5a8a26f633d2ee94362595f32a4:
target-arm/translate: Fix RRX operands (2012-10-17 19:56:46 +0200)
are available in the git repository at:
git://github.com/stefanha/qemu.git trivial-patches
for you to fetch changes up to 11f66978618b542986172a62f
From: Peter Maydell
Commit 33ebc29 fixed the bugs in the implementation of VQRSHL,
but forgot to remove the FIXME comment...
Signed-off-by: Peter Maydell
Signed-off-by: Stefan Hajnoczi
---
target-arm/neon_helper.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target-arm/neon_helper.c b/t
From: Stefan Weil
The include file for net_init_tap was missing:
net/tap-win32.c:703:
warning: no previous prototype for ‘net_init_tap’
Signed-off-by: Stefan Weil
Signed-off-by: Stefan Hajnoczi
---
net/tap-win32.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/tap-win32.c b/net/tap
From: Stefan Weil
This modification is required if compiler option -Wunused-parameter is
activated.
Signed-off-by: Stefan Weil
Signed-off-by: Stefan Hajnoczi
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 353d788..499ad81 100
From: Peter Maydell
Fix some minor typos/grammar errors in comments.
Signed-off-by: Peter Maydell
Reviewed-by: Stefan Weil
Signed-off-by: Stefan Hajnoczi
---
ui/vnc-jobs.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c
index
> Why's nbd_server_add not needed in HMP?
>
> Oh, it's because HMP's nbd_server_start auto-adds *all* block
> devices, unlinke QMP's nbd-server-start.
>
> Are you sure that's a good idea?
Yes. Now that we have QMP we can go back and treat HMP as (mostly) a
debugging interface as it was meant t
> > >> In general, if struct X is QIDL_DECLAREd and only has
> > >> q_immutable
> > >> fields, it can be taken as q_immutable. Hence for example the
> > >> base
> > >> class should not need any decoration; ISADevice will be seen as
> > >> q_immutable, but PCIDevice will be seen as serialized. Bu
On Fri, Oct 19, 2012 at 6:06 PM, Peter Maydell wrote:
> On 19 October 2012 07:40, Peter Crosthwaite
> wrote:
>> Add a variant to sysbus_mmio_map that allow specifying a target memory
>> region.
>> The requested device memory region is mapped within the argument target
>> memory
>> region rather
From: Peter Maydell
Commit 4be403c accidentally defined the target_phys_addr_t type when
building user-mode emulators. Since the type doesn't really make
any sense except for system emulators, avoid defining it when building
in user mode.
Signed-off-by: Peter Maydell
Acked-by: Andreas Färber
S
Add more helpful debug information to the cadence UART.
Signed-off-by: Peter Crosthwaite
---
hw/cadence_uart.c | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/cadence_uart.c b/hw/cadence_uart.c
index f8afc4e..483a316 100644
--- a/hw/cadence_uart.c
+++ b/hw/c
Am 18.10.2012 19:18, schrieb Luiz Capitulino:
> On Thu, 18 Oct 2012 10:33:30 -0300
> Luiz Capitulino wrote:
>
>> On Thu, 18 Oct 2012 13:57:45 +0200
>> Kevin Wolf wrote:
>>
>>> Am 17.10.2012 21:35, schrieb Luiz Capitulino:
If set returns a copy of the parameter list used by the block driver
From: Joel Martin
If TIGHT_PNG is not enabled by the --enable-vnc-png configure flag
then do not report to the client that it is supported.
Also, since TIGHT_PNG is the same as the TIGHT encoding but with the
filter/copy replaced with PNG data, adding it to the supported
encodings list when it i
> What happens is that a stop command while in INMIGRATE state will just
> be ignored. Actually, any stops while in a state that pauses vCPUs
> are ignored.
>
> Also, I don't understand what you meant by "racy", care to elaborate?
Case 1: Case 2:
user runs qe
Hi,
> This patch unfortunately is somewhat invasive, since makeing the qemu
> usb core deal with this requires changes everywhere. This patch only
> prepares the usb core for this, all the hcd / device changes are done
> in such a way that there are no functional changes.
/me likes it.
When to
> Then let's break the API. Not immediately, I think we can keep some
> useless compatibility fields in the implementation of background jobs
> that would only be needed to allow the block job commands to be a
> wrapper (mostly 'bool is_block_job' and 'BlockDriverState bs', I think;
> maybe even j
> > @@ -1098,12 +1106,13 @@ void bdrv_reopen_abort(BDRVReopenState
> > *reopen_state)
> > void bdrv_close(BlockDriverState *bs)
> > {
> > bdrv_flush(bs);
> > -if (bs->drv) {
> > -if (bs->job) {
> > -block_job_cancel_sync(bs->job);
> > -}
> > -bdrv_dra
Hello,
On Wednesday 21 September 2011 22:06:25 dann frazier wrote:
> The Capabilities Pointer is NULL, so this bit shouldn't be set. The state
> of this bit doesn't appear to change any behavior on Linux/Windows versions
> we've tested, but it does cause Windows' PCI/PCI Express Compliance Test to
bdrvIl 19/10/2012 08:40, Peter Crosthwaite ha scritto:
> QOMified the pflash_cfi0x so machine models can connect them up in custom
> ways.
>
> Kept the pflash_cfi0x_register functions as is. They can still be used to
> create a flash straight onto system memory.
>
> Signed-off-by: Peter Crosthwa
This patch fixes bug 1031698 :
https://bugs.launchpad.net/qemu/+bug/1031698
If we look at the (truncated) translation of the conditional branch
instruction in the test submitted in the bug post, the call to the
exception helper is missing in the "bne-false" chunk of translated
code :
IN:
bne-
Hi,
On 10/19/2012 11:00 AM, Gerd Hoffmann wrote:
Hi,
This patch unfortunately is somewhat invasive, since makeing the qemu
usb core deal with this requires changes everywhere. This patch only
prepares the usb core for this, all the hcd / device changes are done
in such a way that there are
On 19 October 2012 07:40, Peter Crosthwaite
wrote:
> Add the pl353 memory controller with both NAND and parallel flashes
> attached.
>
> Signed-off-by: Peter Crosthwaite
> ---
>
> hw/xilinx_zynq.c | 49 +
> 1 files changed, 41 insertions(+), 8 de
Hi,
On Thu, Mar 08, 2012 at 11:13:46AM +0100, Gerd Hoffmann wrote:
> This patchs adds a frame buffer driver for (virtual/emulated) vga cards
> implementing the bochs dispi interface. Supported hardware are the
> bochs vga card with vbe extension and the qemu standard vga.
>
> The driver uses a f
On 19 October 2012 07:40, Peter Crosthwaite
wrote:
> QOMified the pflash_cfi0x so machine models can connect them up in custom
> ways.
>
> Kept the pflash_cfi0x_register functions as is. They can still be used to
> create a flash straight onto system memory.
>
> Signed-off-by: Peter Crosthwaite
On 19 October 2012 10:08, Peter Crosthwaite
wrote:
> Add more helpful debug information to the cadence UART.
>
> Signed-off-by: Peter Crosthwaite
Reviewed-by: Peter Maydell
-- PMM
Hello,
On Friday 19 October 2012 11:59:24 Philipp Hahn wrote:
> On Wednesday 21 September 2011 22:06:25 dann frazier wrote:
...
> > -/* TODO: we have no capabilities, so why is this bit set? */
> > -pci_set_word(pci_conf + PCI_STATUS, PCI_STATUS_CAP_LIST);
...
> Since cmask[PCI_STATUS=6] =
Am 18.10.2012 23:37, schrieb Corey Bryant:
>
>
> On 10/18/2012 04:43 PM, Eric Blake wrote:
>> On 10/18/2012 01:19 PM, Corey Bryant wrote:
>>> This option can be used for passing file descriptors on the
>>> command line. It mirrors the existing add-fd QMP command which
>>> allows an fd to be pass
Signed-off-by: Alon Levy
---
Spice package is not yet available, I assumed it will be the next version,
0.12.1, for the added API spice_server_set_ws_ports. Patches are on spice-devel
and git is at http://cgit.freedesktop.org/~alon/spice master branch
(db5817a059d640fb4ca21740e1362fc6c3e98765)
On 19 October 2012 07:40, Peter Crosthwaite
wrote:
> From: Edgar E. Iglesias
>
> Signed-off-by: Edgar E. Iglesias
> ---
>
> hw/nand.c |6 ++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/hw/nand.c b/hw/nand.c
> index 01f3ada..f931d0c 100644
> --- a/hw/nand.c
> +++
On Fri, Oct 19, 2012 at 12:59:49PM +0100, Peter Maydell wrote:
> On 19 October 2012 07:40, Peter Crosthwaite
> wrote:
> > From: Edgar E. Iglesias
> >
> > Signed-off-by: Edgar E. Iglesias
> > ---
> >
> > hw/nand.c |6 ++
> > 1 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff -
Signed-off-by: Evgeny
---
tcg/tcg.h |6 ++
1 file changed, 6 insertions(+)
diff --git a/tcg/tcg.h b/tcg/tcg.h
index 7bafe0e..8ba021a 100644
--- a/tcg/tcg.h
+++ b/tcg/tcg.h
@@ -422,6 +422,12 @@ struct TCGContext {
int temps_in_use;
int goto_tb_issue_mask;
#endif
+
+uint16_t
Signed-off-by: Evgeny
---
tcg/tcg.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index 3da1d83..77b15a0 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -302,7 +302,7 @@ void tcg_func_start(TCGContext *s)
#endif
s->gen_opc_ptr = s->gen_op
This set of patches moves global variables to tcg_ctx:
gen_opc_ptr
gen_opparam_ptr
gen_opc_buf
gen_opparam_buf
Where it was possible I used s->...
Where we don't have an interface to pass a pointer to tcg_ctx, I used
tcg_ctx.xxx
since it is a global variable too.
Build tested for all targets.
Ex
Signed-off-by: Evgeny
---
target-alpha/translate.c |8 ++---
target-arm/translate.c|8 ++---
target-cris/translate.c | 10 +++---
target-i386/translate.c |8 ++---
target-lm32/translate.c | 10 +++---
target-m68k/translate.c |8 ++---
targe
Signed-off-by: Evgeny
---
target-alpha/translate.c |6 ++--
target-arm/translate.c|8 +++---
target-cris/translate.c |8 +++---
target-i386/translate.c |8 +++---
target-lm32/translate.c |8 +++---
target-m68k/translate.c |6 ++--
targe
On Fri, 19 Oct 2012 11:13:39 +0200
Kevin Wolf wrote:
> Am 18.10.2012 19:18, schrieb Luiz Capitulino:
> > On Thu, 18 Oct 2012 10:33:30 -0300
> > Luiz Capitulino wrote:
> >
> >> On Thu, 18 Oct 2012 13:57:45 +0200
> >> Kevin Wolf wrote:
> >>
> >>> Am 17.10.2012 21:35, schrieb Luiz Capitulino:
> >
Am 18.10.2012 16:49, schrieb Paolo Bonzini:
> This adds the monitor commands that start the mirroring job.
>
> Signed-off-by: Paolo Bonzini
> ---
> v2->v3: bdrv_is_inserted pulled before dereference of bs->drv
>
> blockdev.c | 124
> +++
Use the TCG operation to do Neon 64 bit negations rather than calling
a helper routine for it.
Signed-off-by: Peter Maydell
---
target-arm/helper.h |1 -
target-arm/neon_helper.c |6 --
target-arm/translate.c |4 +++-
3 files changed, 3 insertions(+), 8 deletions(-)
diff
Signed-off-by: Evgeny
---
tcg/tcg.c |4
tcg/tcg.h |4
translate-all.c |3 ---
3 files changed, 11 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index 77b15a0..b5729f1 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -100,10 +100,6 @@ const size_t tcg_op_defs_max = AR
Il 19/10/2012 14:44, Markus Armbruster ha scritto:
> Apropos hotplug. The only way to unexport a block device is to stop the
> NBD server outright. Once the device backend has been exported,
> unplugging the device gets rid of the frontend, but the backend stays
> until you stop the NBD server, o
On 10/19/2012 07:05 AM, Kevin Wolf wrote:
Am 18.10.2012 23:37, schrieb Corey Bryant:
On 10/18/2012 04:43 PM, Eric Blake wrote:
On 10/18/2012 01:19 PM, Corey Bryant wrote:
This option can be used for passing file descriptors on the
command line. It mirrors the existing add-fd QMP command w
Il 19/10/2012 14:54, Kevin Wolf ha scritto:
>> > +proto_drv = bdrv_find_protocol(target);
>> > +if (!proto_drv) {
>> > +error_set(errp, QERR_INVALID_BLOCK_FORMAT, format);
> This error message is still not fixed, and totally confusing, pointing
> at the wrong cause. No matter what c
Implement abs_i32 inline (with movcond) rather than using a helper
function.
Signed-off-by: Peter Maydell
---
target-arm/helper.c|5 -
target-arm/helper.h|1 -
target-arm/translate.c | 11 +--
3 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/target-arm
On Fri, 19 Oct 2012 05:27:29 -0400 (EDT)
Paolo Bonzini wrote:
> > What happens is that a stop command while in INMIGRATE state will just
> > be ignored. Actually, any stops while in a state that pauses vCPUs
> > are ignored.
> >
> > Also, I don't understand what you meant by "racy", care to elab
Two minor patches which inline some operations rather than using helper
functions. The 64 bit negate is a no-brainer since there's a simple
TCG op for it. For abs we implement in terms of movcond:
movi_i32 tmp6,$0x0
neg_i32 tmp7,tmp5
movcond_i32 tmp5,tmp5,tmp6,tmp5,tmp7,gt
which the x86-64 backe
Paolo Bonzini writes:
>> Why's nbd_server_add not needed in HMP?
>>
>> Oh, it's because HMP's nbd_server_start auto-adds *all* block
>> devices, unlinke QMP's nbd-server-start.
>>
>> Are you sure that's a good idea?
>
> Yes. Now that we have QMP we can go back and treat HMP as (mostly) a
> deb
Signed-off-by: Evgeny
---
gen-icount.h |2 +-
tcg/tcg-op.h | 254 +-
tcg/tcg.c| 36 -
3 files changed, 146 insertions(+), 146 deletions(-)
diff --git a/gen-icount.h b/gen-icount.h
index 430cb44..248cf5b 100644
--- a/gen-i
On Fri, 19 Oct 2012 04:58:45 -0400 (EDT)
Paolo Bonzini wrote:
>
> > Why's nbd_server_add not needed in HMP?
> >
> > Oh, it's because HMP's nbd_server_start auto-adds *all* block
> > devices, unlinke QMP's nbd-server-start.
> >
> > Are you sure that's a good idea?
>
> Yes. Now that we have QM
Anthony,
The following changes since commit b6348f29d033d5a8a26f633d2ee94362595f32a4:
target-arm/translate: Fix RRX operands (2012-10-17 19:56:46 +0200)
are available in the git repository at:
git://github.com/bonzini/qemu.git nbd-next
for you to fetch changes up to 1f493f2c7ee75691c4ad22a
This patch mostly mimics what was done to TCP sockets, but simpler
because there is only one address to try. It also includes a free EINTR
bug fix.
Signed-off-by: Paolo Bonzini
---
qemu-char.c| 2 +-
qemu-sockets.c | 77 --
qemu_socke
This makes migration-unix.c again a cut-and-paste job from migration-tcp.c,
exactly as it was in the beginning. :)
Signed-off-by: Paolo Bonzini
---
migration-unix.c | 94 ++--
migration.c | 4 +--
migration.h | 4 +--
3 file modific
Before:
$ qemu-system-x86_64 nbd:localhost:12345
inet_connect_opts: connect(ipv4,yakj.usersys.redhat.com,127.0.0.1,12345):
Connection refused
qemu-system-x86_64: could not open disk image nbd:localhost:12345:
Connection refused
After:
$ x86_64-softmmu/qemu-system-x86_64 nbd:loc
The migration code is using errp to detect "internal" errors, this means
that it relies on errp being non-NULL.
No impact so far because our only QMP clients (the QMP marshaller and HMP)
never pass a NULL Error **. But if we had others, this patch would make
sure that migration can work with a NU
We need them because qemu-sockets will soon be using SocketAddress.
Acked-by: Luiz Capitulino
Signed-off-by: Paolo Bonzini
---
Makefile.objs | 3 ++-
1 file modificato, 2 inserzioni(+). 1 rimozione(-)
diff --git a/Makefile.objs b/Makefile.objs
index 74b3542..3f16d67 100644
--- a/Makefile.objs
Reviewed-by: Luiz Capitulino
Signed-off-by: Paolo Bonzini
---
qemu-sockets.c | 121 +
1 file modificato, 79 inserzioni(+), 42 rimozioni(-)
diff --git a/qemu-sockets.c b/qemu-sockets.c
index daff8e6..909c65f 100644
--- a/qemu-sockets.c
+++
There is no reason in principle to skip job cancellation and draining
of pending I/O when there is no medium in the disk. Do these unconditionally,
which also prepares the code for the next patch.
Signed-off-by: Paolo Bonzini
---
block.c | 10 +-
1 file modificato, 5 inserzioni(+), 5 ri
Reviewed-by: Luiz Capitulino
Signed-off-by: Paolo Bonzini
---
qga/channel-posix.c | 8 +---
1 file modificato, 5 inserzioni(+), 3 rimozioni(-)
diff --git a/qga/channel-posix.c b/qga/channel-posix.c
index e22eee6..d152827 100644
--- a/qga/channel-posix.c
+++ b/qga/channel-posix.c
@@ -181,9 +
These functions help maintaining homogeneous formatting of error
messages that include strerror values.
Acked-by: Luiz Capitulino
Signed-off-by: Paolo Bonzini
---
error.c | 28
error.h | 9 +
2 file modificati, 37 inserzioni(+)
diff --git a/error.c b/error
Acked-by: Luiz Capitulino
Signed-off-by: Paolo Bonzini
---
qapi-schema.json | 53 +
1 file modificato, 53 inserzioni(+)
diff --git a/qapi-schema.json b/qapi-schema.json
index f9dbdae..a92a33b 100644
--- a/qapi-schema.json
+++ b/qapi-schema.jso
Avoid the dance between csock and vs->lsock.
Signed-off-by: Paolo Bonzini
---
console.h | 2 +-
qmp.c | 6 ++
ui/vnc.c | 20 +---
3 file modificati, 12 inserzioni(+), 16 rimozioni(-)
diff --git a/console.h b/console.h
index f990684..6099d8d 100644
--- a/console.h
+++
This lets me adjust the clients to do proper error propagation first,
thus avoiding temporary regressions in the quality of the error messages.
Reviewed-by: Luiz Capitulino
Signed-off-by: Paolo Bonzini
---
nbd.c | 4 ++--
qemu-char.c | 6 +++---
qemu-sockets.c | 22
Error propagation is already there for socket backends. Add it to other
protocols, simplifying code that tests for errors that will never happen.
With all protocols understanding Error, the code can be simplified
further by removing the return value.
Unfortunately, the quality of error messages v
Reviewed-by: Luiz Capitulino
Signed-off-by: Paolo Bonzini
---
qemu-sockets.c | 41 +
1 file modificato, 21 inserzioni(+), 20 rimozioni(-)
diff --git a/qemu-sockets.c b/qemu-sockets.c
index 078f7c1..fb9c4c9 100644
--- a/qemu-sockets.c
+++ b/qemu-sockets.c
The first user of close notifiers will be the embedded NBD server.
It would be possible to use them to do some of the ad hoc processing
(e.g. for block jobs and I/O limits) that is currently done by
bdrv_close.
Acked-by: Kevin Wolf
Signed-off-by: Paolo Bonzini
---
Makefile.objs | 4 ++--
block.
Il 19/10/2012 15:23, Luiz Capitulino ha scritto:
>> >
>> > With HMP yes, with QMP no. You just get "An incoming migration is
>> > expected before this command can be executed" and no clue that disks
>> > are encrypted.
> We could move the bdrv_iterate() calls before the RUN_STATE_INMIGRATE check
1 - 100 of 239 matches
Mail list logo
