Il 15/10/2012 18:35, Michael Roth ha scritto:
>> - immutable/derived/broken/elsewhere (and the default, let's call it
>> serialized) are really five cases of the same QIDL property. Perhaps
>> this could be enforced in the extended syntax like this:
>>
>> #define q_immutable QIDL(serialize(imm
Il 15/10/2012 18:37, Michael Roth ha scritto:
> There is another way to do this (still using a "dummy" target) that is a
> bit less cryptic:
>
> QIDL-PP-%: %.c qidl.h ...
>
>
> %.o: QIDL-PP-%
>
>
> But make detects that QIDL-PP-% is an intermediate target and removes
> the *.qidl.c fi
Hi, all.
Here is the 6th version of the series optimizing TCG qemu_ld/st code generation.
v6:
- Remove an extra argument of return addr from MMU helpers
Instead, embed the fast path addr to the slow path for helpers to use it
- Change some bitwise operations to bitfields of structure
-
Enable CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization only when
a host is i386 or x86_64.
Signed-off-by: Yeongkyoon Lee
---
configure |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/configure b/configure
index 353d788..8b15111 100755
--- a/configure
Add GETPC_EXT which is used by MMU helpers to selectively calculate the code
address of accessing guest memory when called from a qemu_ld/st optimized code
or a C function. Currently, it supports only i386 and x86-64 hosts.
Signed-off-by: Yeongkyoon Lee
---
exec-all.h | 36 +++
Add optimized TCG qemu_ld/st generation which locates the code of TLB miss
cases at the end of a block after generating the other IRs.
Currently, this optimization supports only i386 and x86_64 hosts.
Signed-off-by: Yeongkyoon Lee
---
tcg/i386/tcg-target.c | 415 +++
Il 12/10/2012 23:11, Michael Roth ha scritto:
> Adds an abstract Lexer class to handle tokenizer via a
> peek/pop/peekline/popline interface, along with an implementation for C
> based on the lexer from qc.git
>
> Reviewed-by: Paolo Bonzini
> Signed-off-by: Michael Roth
Hmm, this does not print
Changes v3->v4:
* Patch 5 actually included,
* Patch 1 updates printf format for changed size_t.
r~
Richard Henderson (5):
exec: Split up and tidy code_gen_buffer
exec: Don't make DEFAULT_CODE_GEN_BUFFER_SIZE too large
exec: Do not use absolute address hints for code_gen_buffer with
The hard-coded addresses inside alloc_code_gen_buffer only make sense
if we're building an executable that will actually run at the address
we've put into the linker scripts.
When we're building with -fpie, the executable will run at some
random location chosen by the kernel. We get better placem
It is used nowhere else, and the corresponding MAX_CODE_GEN_BUFFER_SIZE
also lives there.
Signed-off-by: Richard Henderson
---
exec-all.h | 2 --
exec.c | 4
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/exec-all.h b/exec-all.h
index 6516da0..7f29820 100644
--- a/exec-a
It now consists of:
A macro definition of MAX_CODE_GEN_BUFFER_SIZE with host-specific values,
A function size_code_gen_buffer that applies most of the reasoning for
choosing a buffer size,
Three variations of a function alloc_code_gen_buffer that contain all
of the logic for allocating executabl
For ARM we cap the buffer size to 16MB. Do not allocate 32MB in that case.
Signed-off-by: Richard Henderson
---
exec.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/exec.c b/exec.c
index eecae2f..6c0b2d7 100644
--- a/exec.c
+++ b/exec.c
@@ -529,7 +529,11 @@ bool memor
Public bug reported:
The E1000 emulation is missing several counters that are used by other
software.
The following would be useful:
Good bytes receive counter GORCH/GORCL
Good bytes transmit counter GOTCH/GOTCL
Broadcast packets sent/received
Multicast packets sent/received.
** Affects: qem
On Mon, Oct 15, 2012 at 09:46:06PM -, Edivaldo de Araujo Pereira wrote:
> Hi Stefan,
>
> Thank you, very much for taking the time to help me, and excuse me for
> not seeing your answer early...
>
> I've run the procedure you pointed me out, and the result is:
>
> 0d8d7690850eb0cf2b2b60933cf4
We had a hack for arm and sparc, allocating code_gen_prologue to a
special section. Which, honestly does no good under certain cases.
We've already got limits on code_gen_buffer_size to ensure that all
TBs can use direct branches between themselves; reuse this limit to
ensure the prologue is also
On 16.10.2012, at 05:44, Avik Sil wrote:
> On 10/12/2012 05:33 AM, Alexander Graf wrote:
>>
>> On 12.10.2012, at 00:59, David Gibson wrote:
>>
>>> On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote:
This patch adds nvram specified boot device into qemu default
boot_devices lis
Am 15.10.2012 22:58, schrieb Jeff Cody:
> In QEMUMonitorProtocol, commit e9d17b6 removed the __sockfile creation
> from __negotiate_capabilities(), which breaks _accept(). This causes
> failures in qemu-io python based tests (i.e. tests 030 and 040).
>
> This patch creates the sockfile in __accep
On Mon, Oct 15, 2012 at 10:25:58AM +0100, Daniel P. Berrange wrote:
> On Mon, Oct 15, 2012 at 10:30:07AM +0200, Stefan Hajnoczi wrote:
> > On Sat, Oct 13, 2012 at 04:47:14PM -0400, Laine Stump wrote:
> > > Here is the sequence sent to disconnect only the host side, then
> > > reconnect it with a ne
Laine Stump writes:
> On 10/15/2012 05:25 AM, Daniel P. Berrange wrote:
>> On Mon, Oct 15, 2012 at 10:30:07AM +0200, Stefan Hajnoczi wrote:
>>> On Sat, Oct 13, 2012 at 04:47:14PM -0400, Laine Stump wrote:
Here is the sequence sent to disconnect only the host side, then
reconnect it with
On Mon, Oct 15, 2012 at 11:15:30AM -0400, Laine Stump wrote:
> On 10/15/2012 05:25 AM, Daniel P. Berrange wrote:
> > On Mon, Oct 15, 2012 at 10:30:07AM +0200, Stefan Hajnoczi wrote:
> >> On Sat, Oct 13, 2012 at 04:47:14PM -0400, Laine Stump wrote:
> >>> Here is the sequence sent to disconnect only
On Mon, Oct 15, 2012 at 11:47:04AM -0600, Eric Blake wrote:
> On 10/15/2012 06:44 AM, Stefan Hajnoczi wrote:
> > This new test verifies that qemu-img info --backing-chain safely aborts
> > when an image file has a backing file infinite loop.
> >
> > Signed-off-by: Stefan Hajnoczi
> > ---
> > tes
On Mon, Oct 15, 2012 at 04:58:02PM -0400, Jeff Cody wrote:
> In QEMUMonitorProtocol, commit e9d17b6 removed the __sockfile creation
> from __negotiate_capabilities(), which breaks _accept(). This causes
> failures in qemu-io python based tests (i.e. tests 030 and 040).
>
> This patch creates the
Am 16.10.2012 08:36, schrieb Paolo Bonzini:
> Il 15/10/2012 18:57, Kevin Wolf ha scritto:
>> Am 26.09.2012 17:56, schrieb Paolo Bonzini:
>>> +
>>> +/* We're out of the streaming phase. From now on, if the job
>>> + * is cancelled we will actually complete all pending I/O an
On Mon, Oct 15, 2012 at 06:48:53PM +0200, Dmitry Fleytman wrote:
The commit message is very long but the commit description is empty.
Please keep the message short and add the rest into the description.
> Signed-off-by: Dmitry Fleytman
> ---
> hw/e1000.c | 3 ++-
> 1 file changed, 2 insertions(
Il 16/10/2012 10:24, Kevin Wolf ha scritto:
>> > The idea was that block-job-cancel will still leave the target in a
>> > consistent state if executed during the second phase. Otherwise it is
>> > impossible to take a consistent snapshot and keep running on the first
>> > image.
> Yes, I noticed t
Am 16.10.2012 10:04, schrieb Alexander Graf:
>
>
> On 16.10.2012, at 05:44, Avik Sil wrote:
>
>> On 10/12/2012 05:33 AM, Alexander Graf wrote:
>>>
>>> On 12.10.2012, at 00:59, David Gibson wrote:
>>>
On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote:
> This patch adds nvram spec
Thierry reported that the "iron out" patch for isolate_freepages_block()
had problems due to the strict check being too strict with "mm: compaction:
Iron out isolate_freepages_block() and isolate_freepages_range() -fix1".
It's possible that more pages than necessary are isolated but the check
still
-boot and -bootindex
On 15.10.2012, at 12:17, Juan Quintela wrote:
>
> Hi
>
> Please send in any agenda topics you are interested in.
>
> Later, Juan.
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majord...@vger.kernel.org
> More majordomo
On 10/15/2012 04:06 PM, Gerd Hoffmann wrote:
This patch adds chardev_add and chardev_del monitor commands.
They work simliar to the netdev_{add,del} commands. The hmp version of
chardev_add accepts like the -chardev command line option does. The qmp
version expects the arguments being passed a
Instructions that both use the RRX second operand and update CS were
incorrect, as the Carry flag was updated too early. An example of such an
instruction would be:
ands r12,r13,RRX
Ands, because of the "s" flag will update the carry flag. But the RRX second
operand rotates through the C flag whi
On 10/16/2012 08:53 AM, Hu, Xuekun wrote:
> Setting the same PLE parameter arbitrarily for different
> workloads is not a good solution.
True.
> The solution enables
> per domain PLE which gives user ability to set PLE parameter
> for different domain for better performance.
The problem with th
On Tue, Oct 16, 2012 at 10:08:21AM +0200, Stefan Hajnoczi wrote:
> On Mon, Oct 15, 2012 at 10:25:58AM +0100, Daniel P. Berrange wrote:
> > On Mon, Oct 15, 2012 at 10:30:07AM +0200, Stefan Hajnoczi wrote:
> > > On Sat, Oct 13, 2012 at 04:47:14PM -0400, Laine Stump wrote:
> > > > Here is the sequence
On 10/15/2012 09:52 PM, Benjamin Herrenschmidt wrote:
>>
>> I do have an is_write parameter to translate, in fact I added it in
>> order to implement the spapr iommu. Or do you mean something else?
>
> Hrm, sort of. "is_write" means you can only express RO vs RW. Two
> parameter for read and wri
Infrastructure to be used to clean up handling of temporaries.
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 52
1 file changed, 52 insertions(+)
diff --git a/target-sparc/translate.c b/target-sparc/translate.c
index 6cef96b..ee
Am 16.10.2012 10:32, schrieb Stefan Hajnoczi:
> On Mon, Oct 15, 2012 at 06:48:53PM +0200, Dmitry Fleytman wrote:
>
> The commit message is very long but the commit description is empty.
> Please keep the message short and add the rest into the description.
>
>> Signed-off-by: Dmitry Fleytman
>>
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/target-sparc/translate.c b/target-sparc/translate.c
index 5296a37..5013aee 100644
--- a/target-sparc/translate.c
+++ b/target-sparc/tran
We don't need another temporary here. Load directly into the
register we want to set.
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 53 +++-
1 file changed, 21 insertions(+), 32 deletions(-)
diff --git a/target-sparc/translate.c b/t
On Mon, 15 Oct 2012 18:27:51 +0200
Igor Mammedov wrote:
> "CPU as DEVICE"
> http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg00719.html
> latest known tree for testing:
>
> https://github.com/ehabkost/qemu-hacks/commits/work/cpu-devicestate-qdev-core
> may be we could
The primary goal of this patch set is to have all references to windowed
registers to go through new routines that have access to DisasContext.
This is a prerequisite to any change in how windowed registers might be
managed.
Since such a goal must of course touch get_src[12], and therefore touch
t
Now that get_temp_tl is used for get_src[12], we don't need to
pre-allocate these temporaries.
Fallout from this is moving some assignments around cas/casx to
avoid uninitialized variable warnings.
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 16 +++-
1 file chang
Only handle the easy cases directly within disas_sparc_insn.
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 420 ---
1 file changed, 177 insertions(+), 243 deletions(-)
diff --git a/target-sparc/translate.c b/target-sparc/translate.c
Am 15.10.2012 14:44, schrieb Stefan Hajnoczi:
> The qemu-img info --backing-chain option enumerates the backing file
> chain. For example, for base.qcow2 <- snap1.qcow2 <- snap2.qcow2 the
> output becomes:
>
> $ qemu-img info --backing-chain snap2.qcow2
> image: snap2.qcow2
> file format: q
Am 15.10.2012 14:44, schrieb Stefan Hajnoczi:
> A malicious or corruption image can contain an infinite loop of backing
> files. The qemu-img info --backing-chain command must not hang when
> such files are encountered.
>
> Signed-off-by: Stefan Hajnoczi
This seems to do what is intended, but I
Use cpu_tmp0 for other stuff, like Write Priv Register.
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 52
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/target-sparc/translate.c b/target-sparc/translate.c
index 1
Am 15.10.2012 14:44, schrieb Stefan Hajnoczi:
> This new test verifies that qemu-img info --backing-chain safely aborts
> when an image file has a backing file infinite loop.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> tests/qemu-iotests/041 | 90
> +
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 29 +
1 file changed, 17 insertions(+), 12 deletions(-)
diff --git a/target-sparc/translate.c b/target-sparc/translate.c
index e3e4256..5296a37 100644
--- a/target-sparc/translate.c
+++ b/target-sparc/tra
No need to copy to a temporary to store 32 bits.
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 56 +---
1 file changed, 24 insertions(+), 32 deletions(-)
diff --git a/target-sparc/translate.c b/target-sparc/translate.c
index 43e44d5.
Push the DisasContext down so that we can use gen_load/store_gpr
in sode gen_ldda_asi, gen_stda_ast, gen_cas_asi, gen_casx_asi.
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 61 +---
1 file changed, 32 insertions(+), 29 deletions(-)
And initialize it such that it (may) write directly to rd.
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/target-sparc/translate.c b/target-sparc/translate.c
index 5b7e82b..8559cc3 100644
--- a/target-sparc
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/target-sparc/translate.c b/target-sparc/translate.c
index 2a95c1f..e3e4256 100644
--- a/target-sparc/translate.c
+++ b/target-sparc/translate.
This means we can avoid the incoming temporary, though the cleanup
of the existing temporaries is not performed in this patch.
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 75 +++-
1 file changed, 29 insertions(+), 46 deletions(-)
d
Remove the last uses of cpu_tmp32. Unify the code between sparc64
and sparc32 by using the proper "tl" functions.
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 37 +
1 file changed, 17 insertions(+), 20 deletions(-)
diff --git a/target-spar
In all cases we don't have write-before-read problems.
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/target-sparc/translate.c b/target-sparc/translate.c
index 9b7bbef..00ceb9d 1
Use a locally allocated temporary instead.
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 73 +---
1 file changed, 44 insertions(+), 29 deletions(-)
diff --git a/target-sparc/translate.c b/target-sparc/translate.c
index ed341b8..9b7bb
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 28 +---
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/target-sparc/translate.c b/target-sparc/translate.c
index 64feaa3..16cf8de 100644
--- a/target-sparc/translate.c
+++ b/target-sparc/tran
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/target-sparc/translate.c b/target-sparc/translate.c
index f4ab6cc..8a2e914 100644
--- a/target-sparc/translate.c
+++ b/target-sparc/translate.c
@@ -20
The use of "tl" functions and a tmp64 is logically incompatible.
Use cpu_tmp0 instead.
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/target-sparc/translate.c b/target-sparc/translate.c
index 00ceb9d.
All users of gen_movl_{reg_TN,TN_reg} are removed. At the same time,
make cpu_val a local variable for load/store disassembly.
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 58 +---
1 file changed, 20 insertions(+), 38 deletions(-)
Subroutines do their own local temporary management.
Within disas_sparc_insn we limit the existance of the variable
to OP=2 insns, and delay initialization as late as is reasonable
for the specific XOP.
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 203 +
Hi,
I'm using QEmu to debug an ARM target (OS-less code).
I searched/googled for help on how to trace all instructions executed
on the target CPU.
Using -singlestep and -d in_asm option switches generate the data I'm
looking for, however as the translation blocks are cached, the
instructions are
Hello,
From: Paolo Bonzini
Subject: Re: delvm does not reduce the qcow2 file size
Date: Tue, 16 Oct 2012 08:54:46 +0200
> >> QEMU should also convert the unused clusters to "holes" in the file
> >> system, but it doesn't do that yet.
> >
> > I hope a qcow2 file is reduced automatically when a
Il 16/10/2012 13:06, Kuniyasu Suzaki ha scritto:
QEMU should also convert the unused clusters to "holes" in the file
> >> system, but it doesn't do that yet.
>>> > >
>>> > > I hope a qcow2 file is reduced automatically when a snapshot is deleted.
>> >
>> > Yes, that's part of the plan.
Am 15.10.2012 22:50, schrieb Alex Bligh:
> This patch allows an empty filename to be passed as the new base image name
> for qemu-img rebase to mean base the image on no backing file (i.e.
> independent of any backing file). According to Eric Blake, qemu-img rebase
> already supports this when '-u'
On 14 October 2012 19:43, Andre Beckus wrote:
> Implement byte/halfword read and write for the NVIC SCB_SHPRx
> (System Handler Priority Registers). Do this by removing SHPR word access
> from nvic_readl/writel and adding common code to hande all access
> sizes in nvic_sysreg_read/write.
>
> Beca
Am 13.10.2012 17:25, schrieb Jeff Cody:
> On 10/12/2012 05:52 PM, Eric Blake wrote:
>> On 10/09/2012 11:56 PM, Jeff Cody wrote:
>>> Currently, bdrv_find_backing_image compares bs->backing_file with
>>> what is passed in as a backing_file name. Mismatches may occur,
>>> however, when bs->backing_fi
On 10/12/2012 08:32 AM, Chris Wright wrote:
> * Alexander Graf (ag...@suse.de) wrote:
>> On 12.10.2012, at 02:28, David Gibson wrote:
>>> On Fri, Oct 12, 2012 at 02:03:00AM +0200, Alexander Graf wrote:
On 12.10.2012, at 00:59, David Gibson wrote:
> On Thu, Oct 11, 2012 at 07:34:42AM +0530,
Hi Stefan
I finally could revert that commit in the latest snapshot; problem was I
needed to revert one later, that modified hw/virtio-serial-bus.c
accordingly; after that reversion, the regression in network performance
went completely away; this confirms my previous identification of the
commit
This patch allows an empty filename to be passed as the new base image name
for qemu-img rebase to mean base the image on no backing file (i.e.
independent of any backing file). According to Eric Blake, qemu-img rebase
already supports this when '-u' is used; this adds support when -u is not
used.
Kevin,
--On 16 October 2012 13:22:47 +0200 Kevin Wolf wrote:
Apart from the coding style problems, the patch looks good to me.
Coding problems fixed & v4 sent under separate cover.
--
Alex Bligh
On 16 October 2012 07:53, Catalin Patulea wrote:
> Sorry this got abandoned.. here is a fresh (and slightly leaner) patch on top
> of master. Can anyone take a look?
>
> ---
> This broke when the tests were moved from tests/ to tests/tcg/.
>
> On x86_64 host/i386-linux-user non-kvm guest, test-i3
On 10/16/2012 04:39 AM, Mel Gorman wrote:
Thierry reported that the "iron out" patch for isolate_freepages_block()
had problems due to the strict check being too strict with "mm: compaction:
Iron out isolate_freepages_block() and isolate_freepages_range() -fix1".
It's possible that more pages tha
On Wed, 10 Oct 2012 16:02:56 +0200
Paolo Bonzini wrote:
> perror and fprintf can be removed because all clients can now consume
> Errors properly. However, we need to change the non-blocking connect
> handlers to take an Error, in order to improve error handling for
> migration with the TCP prot
Am 16.10.2012 14:46, schrieb Alex Bligh:
> This patch allows an empty filename to be passed as the new base image name
> for qemu-img rebase to mean base the image on no backing file (i.e.
> independent of any backing file). According to Eric Blake, qemu-img rebase
> already supports this when '-u'
On Wed, 10 Oct 2012 16:02:41 +0200
Paolo Bonzini wrote:
> Luiz,
>
> The following changes since commit b4ae3cfa57b8c1bdbbd7b7d420971e9171203ade:
>
> ssi: Add slave autoconnect helper (2012-10-10 11:13:32 +1000)
>
> are available in the git repository at:
>
> git://github.com/bonzini/qemu.
Il 16/10/2012 15:09, Luiz Capitulino ha scritto:
> I've applied all these patches to the qmp tree, ie. I didn't pull. I did this
> because it was easier to me and because of the following changes:
>
> 1. I've added my signed-off to all patches
> 2. I've dropped previous acked & reviewed-by from
"Michael S. Tsirkin" writes:
> On Fri, Oct 12, 2012 at 08:21:50PM +1030, Rusty Russell wrote:
>> "Michael S. Tsirkin" writes:
>> > On Fri, Oct 12, 2012 at 08:59:36AM +1030, Rusty Russell wrote:
>> >> >> For writes, the standard seems to be a commit latch. We could abuse
>> >> >> the
>> >> >> ge
On Mon, 15 Oct 2012 13:09:55 +0200
Andreas Färber wrote:
> Am 15.10.2012 08:51, schrieb Lei Li:
> > On 10/12/2012 08:39 PM, Gerd Hoffmann wrote:
> >> +void qmp_chardev_del(const char *id, Error **errp)
> >> +{
> >> +CharDriverState *chr;
> >> +
> >> +chr = qemu_chr_find(id);
> >> +if
On Tue, Oct 16, 2012 at 11:45:41PM +1030, Rusty Russell wrote:
> "Michael S. Tsirkin" writes:
> > On Fri, Oct 12, 2012 at 08:21:50PM +1030, Rusty Russell wrote:
> >> "Michael S. Tsirkin" writes:
> >> > On Fri, Oct 12, 2012 at 08:59:36AM +1030, Rusty Russell wrote:
> >> >> >> For writes, the stand
On Tue, 2012-10-16 at 08:39 +0200, Michael S. Tsirkin wrote:
> On Mon, Oct 15, 2012 at 02:28:15PM -0600, Alex Williamson wrote:
> > This makes use of the new level irqfd support enabling bypass of
> > qemu userspace both on INTx injection and unmask. This significantly
> > boosts the performance o
"Michael S. Tsirkin" writes:
> On Tue, Oct 16, 2012 at 11:45:41PM +1030, Rusty Russell wrote:
>> "Michael S. Tsirkin" writes:
>> I was assuming the implementation would keep two complete copies of the
>> config space: writes go to the scratch version, which gets copied to the
>> master version up
Il 15/10/2012 19:36, Eric Blake ha scritto:
>>> >> +##
>>> >> +# @chardev_del:
> And this should be 'chardev-del' or even 'chardev-remove', as QMP
> commands tend to favor legibility over abbreviations.
In doubt we should favor consistency though (with netdev_add and
netdev_del). I'm for keeping
On Tue, Oct 16, 2012 at 07:51:43AM -0600, Alex Williamson wrote:
> On Tue, 2012-10-16 at 08:39 +0200, Michael S. Tsirkin wrote:
> > On Mon, Oct 15, 2012 at 02:28:15PM -0600, Alex Williamson wrote:
> > > This makes use of the new level irqfd support enabling bypass of
> > > qemu userspace both on IN
Eduardo Habkost writes:
> Also, add weak symbols that will be used if qdev-system.o is not
> compiled in (i.e. on *-user).
>
> Signed-off-by: Eduardo Habkost
> ---
> hw/qdev-core.c | 16 +++-
> hw/qdev-core.h | 3 +++
> hw/qdev-system.c | 15 +++
> 3 files changed,
v1 -> v2 differences:
* Updated changes to be protocol friendly
* Updated block-commit tests to account for different error message
wording
* Updated block-commit tests to add relative backing filename tests
* In bdrv_find_backing_image(), use g_malloc() instead of char arrays
Jeff Cody (4):
Some of the error messages put out by block-commit have changed
slightly, which causes 2 tests cases for block-commit to fail.
This patch updates the test cases to look for the correct error
output.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/040 | 4 ++--
1 file changed, 2 insertions(+), 2
The previous block commit used absolute filenames for all block-commit
images and commands; this adds relative filenames for the same tests.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/040 | 102 +
tests/qemu-iotests/040.out | 4 +-
2 files c
On Tue, 2012-10-16 at 16:14 +0200, Michael S. Tsirkin wrote:
> On Tue, Oct 16, 2012 at 07:51:43AM -0600, Alex Williamson wrote:
> > On Tue, 2012-10-16 at 08:39 +0200, Michael S. Tsirkin wrote:
> > > On Mon, Oct 15, 2012 at 02:28:15PM -0600, Alex Williamson wrote:
> > > > This makes use of the new l
2012-10-16
--
- cpu as dev
making qdev available to all parts of qemu is the best solution (aliguory)
how does linux-user people think about it?
Eduardo will follow
Objections:
* conceptually it makes no sense to have devices on *-user
* desire of linux-user to maintain the co
On Tue, Oct 16, 2012 at 12:04:24PM +0200, Kevin Wolf wrote:
> Am 15.10.2012 14:44, schrieb Stefan Hajnoczi:
> > The qemu-img info --backing-chain option enumerates the backing file
> > chain. For example, for base.qcow2 <- snap1.qcow2 <- snap2.qcow2 the
> > output becomes:
> >
> > $ qemu-img in
On Tue, Oct 16, 2012 at 12:22:38PM +0200, Kevin Wolf wrote:
> Am 15.10.2012 14:44, schrieb Stefan Hajnoczi:
> > This new test verifies that qemu-img info --backing-chain safely aborts
> > when an image file has a backing file infinite loop.
> >
> > Signed-off-by: Stefan Hajnoczi
> > ---
> > test
Am 16.10.2012 16:42, schrieb Stefan Hajnoczi:
> On Tue, Oct 16, 2012 at 12:11:44PM +0200, Kevin Wolf wrote:
>> Am 15.10.2012 14:44, schrieb Stefan Hajnoczi:
>>> A malicious or corruption image can contain an infinite loop of backing
>>> files. The qemu-img info --backing-chain command must not han
Currently, bdrv_find_backing_image compares bs->backing_file with
what is passed in as a backing_file name. Mismatches may occur,
however, when bs->backing_file and backing_file are both not
absolute or relative.
Use path_combine() to make sure any relative backing filenames are
relative to the c
On Tue, Oct 16, 2012 at 08:48:04AM -0600, Alex Williamson wrote:
> On Tue, 2012-10-16 at 16:14 +0200, Michael S. Tsirkin wrote:
> > On Tue, Oct 16, 2012 at 07:51:43AM -0600, Alex Williamson wrote:
> > > On Tue, 2012-10-16 at 08:39 +0200, Michael S. Tsirkin wrote:
> > > > On Mon, Oct 15, 2012 at 02:
Paolo fixed the problem with upstream commit:
commit b6db4aca20e9af4f62c9c9e08b9b9672a6ed3390
Author: Paolo Bonzini
Date: Mon Oct 1 14:22:06 2012 +0200
rtc: fix overflow in mktimegm
When setting a date in 1980, Linux is actually disregarding the century
byte and setting the ye
On 10/16/2012 08:44 AM, Jeff Cody wrote:
> Currently, bdrv_find_backing_image compares bs->backing_file with
> what is passed in as a backing_file name. Mismatches may occur,
> however, when bs->backing_file and backing_file are both not
Reads better as s/both not/not both/.
> absolute or relati
On Tue, 2012-10-16 at 17:08 +0200, Michael S. Tsirkin wrote:
> On Tue, Oct 16, 2012 at 08:48:04AM -0600, Alex Williamson wrote:
> > On Tue, 2012-10-16 at 16:14 +0200, Michael S. Tsirkin wrote:
> > > On Tue, Oct 16, 2012 at 07:51:43AM -0600, Alex Williamson wrote:
> > > > On Tue, 2012-10-16 at 08:39
On Tue, Oct 16, 2012 at 12:11:44PM +0200, Kevin Wolf wrote:
> Am 15.10.2012 14:44, schrieb Stefan Hajnoczi:
> > A malicious or corruption image can contain an infinite loop of backing
> > files. The qemu-img info --backing-chain command must not hang when
> > such files are encountered.
> >
> > S
This simplifies some code and error checking, and also fixes a bug.
bdrv_find_backing_image() should only be passed absolute filenames,
or filenames relative to the chain. In the QMP message handler for
block commit, when looking up the base do so from the determined top
image, so we know it is r
On Tue, Oct 16, 2012 at 09:13:15AM -0600, Alex Williamson wrote:
> > There's no chance we ship e.g. q35 by mistake without this API: since
> > there is no way this specific assert can be missed in even basic
> > testing:
> >
> > So I see it differently:
> >
> > As coded here:
> > chipset auth
On 10/16/2012 08:44 AM, Jeff Cody wrote:
> This simplifies some code and error checking, and also fixes a bug.
>
> bdrv_find_backing_image() should only be passed absolute filenames,
> or filenames relative to the chain. In the QMP message handler for
> block commit, when looking up the base do s
1 - 100 of 202 matches
Mail list logo
