Re: [Qemu-devel] [PATCH v2 4/9] qemu-sockets: add error propagation to Unix socket functions

2012-10-01 Thread Luiz Capitulino
On Mon, 01 Oct 2012 21:07:52 +0200 Paolo Bonzini wrote: > Il 01/10/2012 19:17, Luiz Capitulino ha scritto: > >> > if (bind(sock, (struct sockaddr*) &un, sizeof(un)) < 0) { > >> > -fprintf(stderr, "bind(unix:%s): %s\n", un.sun_path, > >> > strerror(errno)); > >> > +error_set(

Re: [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types

2012-10-01 Thread Eric Blake
On 10/01/2012 08:52 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > qapi-schema.json | 53 + > 1 file modificato, 53 inserzioni(+) > > diff --git a/qapi-schema.json b/qapi-schema.json > index 191d921..b443a99 100644 > --- a/qapi

Re: [Qemu-devel] [PATCH 1/6] savevm: Add VMSTATE_UINT64_EQUAL helpers

2012-10-01 Thread David Gibson
On Sat, Sep 29, 2012 at 11:36:35AM +, Blue Swirl wrote: > On Wed, Sep 26, 2012 at 3:21 AM, David Gibson > wrote: > > The savevm code already includes a number of *_EQUAL helpers which act as > > sanity checks verifying that the configuration of the saved state matches > > that of the machine w

Re: [Qemu-devel] [PATCH v2 8/9] qmp: add NBD server commands

2012-10-01 Thread Eric Blake
On 10/01/2012 08:52 AM, Paolo Bonzini wrote: > Adding an NBD server inside QEMU is trivial, since all the logic is > in nbd.c and can be shared easily between qemu-nbd and QEMU itself. > The main difference is that qemu-nbd serves a single unnamed export, > while QEMU serves named exports. > > +#

[Qemu-devel] [PATCH] hw/arm_gic.c: Fix improper DPRINTF output.

2012-10-01 Thread Evgeny Voevodin
s->cpu_enabled is an array, so s->cpu_enabled ? "En" : "Dis" returns "En" always. We should use s->cpu_enabled[cpu] here. Signed-off-by: Evgeny Voevodin --- hw/arm_gic.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm_gic.c b/hw/arm_gic.c index 55871fa..4024dae 1006

Re: [Qemu-devel] [PATCH] qtest: implement QTEST_STOP

2012-10-01 Thread Paolo Bonzini
Il 01/10/2012 23:19, Anthony Liguori ha scritto: > What about launching the guest with "-S" if that variable is set? > That's a bit nicer, right? That also requires that -S block reads from the qtest socket, which is not yet the case. Paolo

Re: [Qemu-devel] [PATCH v2 4/9] qemu-sockets: add error propagation to Unix socket functions

2012-10-01 Thread Paolo Bonzini
Il 02/10/2012 01:05, Luiz Capitulino ha scritto: > On Mon, 01 Oct 2012 21:07:52 +0200 > Paolo Bonzini wrote: > >> Il 01/10/2012 19:17, Luiz Capitulino ha scritto: > if (bind(sock, (struct sockaddr*) &un, sizeof(un)) < 0) { > -fprintf(stderr, "bind(unix:%s): %s\n", un.sun_path

Re: [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems

2012-10-01 Thread Paolo Bonzini
Il 01/10/2012 20:49, Alex Williamson ha scritto: >> > @@ -768,7 +768,7 @@ static int vfio_dma_map(VFIOContainer *container, >> > target_phys_addr_t iova, >> > struct vfio_iommu_type1_dma_map map = { >> > .argsz = sizeof(map), >> > .flags = VFIO_DMA_MAP_FLAG_READ, >> > -

Re: [Qemu-devel] [PATCH v9 2/4] qemu: URI parsing library

2012-10-01 Thread Paolo Bonzini
> BTW I'm fine by this assuming: >- someone keeps an eye on libxml2 upstream in case some security > problem shows up in that part of the code Yes. >- the code used is the 2.9.0 one where I added quite a bit of > cleanup on memory handling. It is, modulo the fact that QEMU u

<    1   2