[Qemu-devel] [PATCH] configure: Fix "configure: usbredir fixes" to not break softmmu builds

2012-09-13 Thread Hans de Goede
Feel free to merge this into the original commit at that is not upstream yet. Signed-off-by: Hans de Goede CC: Aurelien Jarno --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 1854b0b..d63530a 100755 --- a/configure +++ b/configure @@

Re: [Qemu-devel] [PATCH] configure: Fix "configure: usbredir fixes" to not break softmmu builds

2012-09-13 Thread Gerd Hoffmann
On 09/13/12 09:31, Hans de Goede wrote: > -libs_softmmu="$LIBS $usb_redir_libs" > +libs_softmmu="$libs_softmmu $usb_redir_libs" Good point ;) Fix squashed in. thanks, Gerd

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-13 Thread Peter Lieven
On 10.09.2012 14:32, Avi Kivity wrote: On 09/10/2012 03:29 PM, Peter Lieven wrote: On 09/10/12 14:21, Gleb Natapov wrote: On Mon, Sep 10, 2012 at 02:15:49PM +0200, Paolo Bonzini wrote: Il 10/09/2012 13:52, Peter Lieven ha scritto: dd if=/dev/cpu/0/msr skip=$((0x194)) bs=8 count=1 | xxd dd if=

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-13 Thread Paolo Bonzini
Il 13/09/2012 09:53, Peter Lieven ha scritto: >>> rdmsr returns it cannot read those MSRs. regardless if I use -cpu host >>> or -cpu qemu64. >> On the host. >> >> > did you get my output? > > #rdmsr -0 0x194 > 00011100 > #rdmsr -0 0xce > 0c0004011103 Yes, that can help implementi

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-13 Thread Gleb Natapov
On Thu, Sep 13, 2012 at 09:55:06AM +0200, Paolo Bonzini wrote: > Il 13/09/2012 09:53, Peter Lieven ha scritto: > > >>> rdmsr returns it cannot read those MSRs. regardless if I use -cpu host > >>> or -cpu qemu64. > >> On the host. > >> > >> > > did you get my output? > > > > #rdmsr -0 0x194 >

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-13 Thread Paolo Bonzini
Il 13/09/2012 09:57, Gleb Natapov ha scritto: >>> > > >>> > > #rdmsr -0 0x194 >>> > > 00011100 >>> > > #rdmsr -0 0xce >>> > > 0c0004011103 >> > >> > Yes, that can help implementing it in KVM. But without a spec to >> > understand what the bits actually mean, it's just as risky... >>

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-13 Thread Gleb Natapov
On Thu, Sep 13, 2012 at 10:00:26AM +0200, Paolo Bonzini wrote: > Il 13/09/2012 09:57, Gleb Natapov ha scritto: > >>> > > > >>> > > #rdmsr -0 0x194 > >>> > > 00011100 > >>> > > #rdmsr -0 0xce > >>> > > 0c0004011103 > >> > > >> > Yes, that can help implementing it in KVM. But without a

Re: [Qemu-devel] [PATCH V3 01/11] atomic: introduce atomic operations

2012-09-13 Thread Avi Kivity
On 09/13/2012 09:54 AM, liu ping fan wrote: >>> +typedef struct Atomic { >>> +int counter; >>> +} Atomic; >> >> Best to mark counter 'volatile'. >> >>> + >>> +static inline void atomic_set(Atomic *v, int i) >>> +{ >>> +v->counter = i; >>> +} >>> + >>> +static inline int atomic_read(Atomic

Re: [Qemu-devel] [PATCH V3 01/11] atomic: introduce atomic operations

2012-09-13 Thread Paolo Bonzini
Il 13/09/2012 10:14, Avi Kivity ha scritto: >>> +static inline void atomic_set(Atomic *v, int i) >>> +{ >>> +v->counter = i; >>> +} >>> + >>> +static inline int atomic_read(Atomic *v) >>> +{ >>> +return v->counter; >>> +} >>> >>> >> >>> >> S

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-13 Thread Avi Kivity
On 09/13/2012 09:55 AM, liu ping fan wrote: > On Tue, Sep 11, 2012 at 8:41 PM, Avi Kivity wrote: >> On 09/11/2012 03:24 PM, Avi Kivity wrote: >>> On 09/11/2012 12:57 PM, Jan Kiszka wrote: On 2012-09-11 11:44, liu ping fan wrote: > On Tue, Sep 11, 2012 at 4:35 PM, Avi Kivity wrote: >>

Re: [Qemu-devel] [PATCH V3 01/11] atomic: introduce atomic operations

2012-09-13 Thread Avi Kivity
On 09/13/2012 11:19 AM, Paolo Bonzini wrote: > Il 13/09/2012 10:14, Avi Kivity ha scritto: > >>> +static inline void atomic_set(Atomic *v, int i) > >>> +{ > >>> +v->counter = i; > >>> +} > >>> + > >>> +static inline int atomic_read(Atomic *v) > >>> +{ > >>> +

Re: [Qemu-devel] [PATCH v3 2/2] slirp: Implement TFTP Blocksize option

2012-09-13 Thread Jan Kiszka
On 2012-09-13 07:55, Hervé Poussineau wrote: > This option is described in RFC 1783. As this is only an optional field, > we may ignore it in some situations and handle it in some others. > > However, MS Windows 2003 PXE boot client requests a block size of the MTU > (most of the times 1472 bytes)

[Qemu-devel] [PATCH 13/14] usb-redir: Revert usb-redir part of commit 93bfef4c

2012-09-13 Thread Gerd Hoffmann
From: Hans de Goede Commit 93bfef4c6e4b23caea9d51e1099d06433d8835a4 makes qemu-devices which report the qemu version string to the guest in some way use a qemu_get_version function which reports a machine-specific version string. However usb-redir does not expose the qemu version to the guest, o

Re: [Qemu-devel] [PATCH V3 08/11] qom: introduce reclaimer to release obj in async

2012-09-13 Thread Avi Kivity
On 09/13/2012 09:54 AM, liu ping fan wrote: > On Tue, Sep 11, 2012 at 5:37 PM, Avi Kivity wrote: >> On 09/11/2012 12:32 PM, liu ping fan wrote: >>> On Tue, Sep 11, 2012 at 4:32 PM, Avi Kivity wrote: On 09/11/2012 10:51 AM, Liu Ping Fan wrote: > From: Liu Ping Fan > > DeviceState

[Qemu-devel] [PULL 00/10] spice patch queue

2012-09-13 Thread Gerd Hoffmann
Hi, This pull brings monitor configuration support for qxl which is needed by the upcoming kms qxl driver. Also a nice speedup for qxl in vga mode and as usual some bugfixes. please pull, Gerd The following changes since commit e0a1e32dbc41e6b2aabb436a9417dfd32177a3dc: Merge branch 'usb.

[Qemu-devel] [PATCH 10/10] hw/qxl: support client monitor configuration via device

2012-09-13 Thread Gerd Hoffmann
From: Alon Levy Until now we used only the agent to change the monitor count and each monitor resolution. This patch introduces the qemu part of using the device as the mediator instead of the agent via virtio-serial. Spice (>=0.11.5) calls the new QXLInterface::client_monitors_config, which ret

[Qemu-devel] [PATCH 02/14] ehci: switch to new-style memory ops

2012-09-13 Thread Gerd Hoffmann
Also register different memory regions for capabilities, operational registers and port status registers. Create separate tracepoints for operational regs and port status regs. Ditch a bunch of sanity checks because the memory core will do this for us now. Offloading the byte, word and dword acc

[Qemu-devel] [PATCH 02/10] spice: split qemu_spice_create_update

2012-09-13 Thread Gerd Hoffmann
Creating one function which creates a single update for a given rectangle. And one (for now) pretty simple wrapper around it to queue up screen updates for the dirty region. [ v2: also update bounding box ] Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 31 ++--

[Qemu-devel] [PATCH v2] rtl8139: implement 8139cp link status

2012-09-13 Thread Amos Kong
From: Jason Wang Add a link status chang callback and change the link status bit in BMSR & MSR accordingly. Tested in Linux/Windows guests. The link status bit of MediaStatus is infered from BasicModeStatus, they are reverse. Signed-off-by: Jason Wang Signed-off-by: Amos Kong --- v2: don't a

[Qemu-devel] [PULL 00/14] usb patch queue

2012-09-13 Thread Gerd Hoffmann
Hi, Here comes the usb patch queue, featuring life migration support for usb network redirection and the usual share of bugfixes ;) please pull, Gerd The following changes since commit e0a1e32dbc41e6b2aabb436a9417dfd32177a3dc: Merge branch 'usb.64' of git://git.kraxel.org/qemu (2012-09-11

Re: [Qemu-devel] [PATCH V3 01/11] atomic: introduce atomic operations

2012-09-13 Thread Paolo Bonzini
Il 13/09/2012 10:23, Avi Kivity ha scritto: >> > But I don't really see the point in wrapping atomically-accessed >> > variables in a struct. > Preventing accidental naked access (to be reported in patch review as > "wardrobe malfunction"). Yeah, I understand that, but it's rare enough that I do

[Qemu-devel] [PATCH 11/14] usb-redir: Add support for migration

2012-09-13 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c | 349 - 1 files changed, 346 insertions(+), 3 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 3196665..5e987e9 100644

[Qemu-devel] [PATCH 03/10] spice: add screen mirror

2012-09-13 Thread Gerd Hoffmann
Create a screen mirror, keep there a copy of the most recent update passed on to spice-server. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 32 ++-- ui/spice-display.h |1 + 2 files changed, 23 insertions(+), 10 deletions(-) diff --git a/ui/spice-displ

[Qemu-devel] [PATCH 05/10] qxl: dont update invalid area

2012-09-13 Thread Gerd Hoffmann
From: Dunrong Huang This patch fixes the following error: $ ~/usr/bin/qemu-system-x86_64 -enable-kvm -m 1024 -spice port=5900,disable-ticketing -vga qxl -cdrom ~/Images/linuxmint-13-mate-dvd-32bit.iso (/home/mathslinux/usr/bin/qemu-system-x86_64:10068): SpiceWorker-CRITICAL **: red_worker.c:4

[Qemu-devel] [PATCH 3/3] ivshmem: add 64bit option

2012-09-13 Thread Gerd Hoffmann
This patch adds a "use64" property which will make the ivshmem driver register a 64bit memory bar when set, so you have something to play with when testing 64bit pci bits. It also allows to have quite big shared memory regions, like this: [root@fedora ~]# lspci -vs1:1 01:01.0 RAM memory: Red Hat,

[Qemu-devel] [PATCH 0/3] add pc-1.3, fix xhci comat, ivshmem 64bit option

2012-09-13 Thread Gerd Hoffmann
Hi, Small series with tree patches, the first one adds a new machine type for the upcoming 1.3 release so we can add compat properties as needed, the other two patches actually add compat properties. The xhci one is a pure compat fix which turns off msi+msix on old machine types. The other is

[Qemu-devel] [PATCH 2/3] compat: turn off msi/msix on xhci for old machine types

2012-09-13 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pc_piix.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 5a0796b..afd8361 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -358,14 +358,30 @@ static QEMUMachine pc_machine_v1_3 = {

[Qemu-devel] [PATCH 1/3] add pc-1.3 machine type

2012-09-13 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pc_piix.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 88ff041..5a0796b 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -349,8 +349,8 @@ static void pc_xen_hvm_init(ram_addr_t ram_size,

[Qemu-devel] [PATCH 06/14] ehci: Don't set seen to 0 when removing unseen queue-heads

2012-09-13 Thread Gerd Hoffmann
From: Hans de Goede When removing unseen queue-heads from the async queue list, we should not set the seen flag to 0, as this may cause them to be removed by ehci_queues_rip_unused() during the next call to ehci_advance_async_state() if the timer is late or running at a low frequency. Note: 1) T

[Qemu-devel] [PATCH v2 7/9] fbdev: move to pixman

2012-09-13 Thread Gerd Hoffmann
Stop reinventing the wheel. Use the pixman library for raster ops. Signed-off-by: Gerd Hoffmann --- configure | 12 ui/fbdev.c | 172 +++ 2 files changed, 114 insertions(+), 70 deletions(-) diff --git a/configure b/configure inde

[Qemu-devel] [PATCH v2 2/9] add unregister_displaychangelistener

2012-09-13 Thread Gerd Hoffmann
Also change the way the gui_timer is initialized: each time a displaychangelistener is registered or unregistered we'll check whenever we need a timer (due to dpy_refresh callback being present) and if so setup a timer, otherwise zap it. This way the gui timer works correctly with displaychangelis

[Qemu-devel] [PATCH v2 3/9] move set_mouse + cursor_define callbacks

2012-09-13 Thread Gerd Hoffmann
When adding DisplayChangeListeners the set_mouse and cursor_define callbacks have been left in DisplayState for some reason. Fix it. Signed-off-by: Gerd Hoffmann --- console.c |2 +- console.h | 39 +++ hw/jazz_led.c |2 +- hw

[Qemu-devel] [PATCH v2 5/9] fbdev: add monitor command to enable/disable

2012-09-13 Thread Gerd Hoffmann
This patch adds a fbdev monitor command to enable/disable the fbdev display at runtime to both qmp and hmp. qmp: fbdev enable=on|off hmp: fbdev on|off Signed-off-by: Gerd Hoffmann --- hmp-commands.hx | 15 +++ hmp.c|9 + hmp.h|1 + qapi-sch

[Qemu-devel] [PATCH 03/14] ehci: Fix interrupts stopping when Interrupt Threshold Control is 8

2012-09-13 Thread Gerd Hoffmann
From: Hans de Goede If Interrupt Threshold Control is 8 or a multiple of 8, then s->usbsts_frindex can become exactly 0x4000, at which point (s->usbsts_frindex > s->frindex) will never become true, as s->usbsts_frindex will not be lowered / reset in this case. This patch fixes this. Signed-off-

[Qemu-devel] [PATCH 04/14] ehci: Don't process too much frames in 1 timer tick (v2)

2012-09-13 Thread Gerd Hoffmann
From: Hans de Goede The Linux ehci isoc scheduling code fills the entire schedule ahead of time minus 80 frames. If we make a large jump in where we are in the schedule, ie 40 frames, then the scheduler all of a sudden will only have 40 frames left to work in, causing it to fail packet submission

[Qemu-devel] [PATCH 01/14] usb-host: allow emulated (non-async) control requests without USBPacket

2012-09-13 Thread Gerd Hoffmann
xhci needs this for USB_REQ_SET_ADDRESS due to the way usb addressing is handled by the xhci hardware. Signed-off-by: Gerd Hoffmann --- hw/usb/host-linux.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb/host-linux.c b/hw/usb/host-linux.c index 8df9207..44f1a64 1

[Qemu-devel] [PATCH 09/14] usb-redir: Add an already_in_flight packet-id queue

2012-09-13 Thread Gerd Hoffmann
From: Hans de Goede After a live migration, the usb-hcd will re-queue all packets by walking over the schedule in the guest memory again, but requests which were encountered on the migration source before will already be in flight, so these should *not* be re-send to the usbredir-host. This patc

[Qemu-devel] [PATCH v2 9/9] fbdev: add display scaling support

2012-09-13 Thread Gerd Hoffmann
Add support for scaling the guest display. Ctrl-Alt-S hotkey toggles scaling. Signed-off-by: Gerd Hoffmann --- ui/fbdev.c | 61 ++- 1 files changed, 51 insertions(+), 10 deletions(-) diff --git a/ui/fbdev.c b/ui/fbdev.c index 5e700e8..e5

[Qemu-devel] [PATCH v2 8/9] fbdev: add mouse pointer support

2012-09-13 Thread Gerd Hoffmann
Add mouse_set and cursor_define DisplayChangeListener callbacks and mouse pointer rendering support. Signed-off-by: Gerd Hoffmann --- ui/fbdev.c | 95 1 files changed, 95 insertions(+), 0 deletions(-) diff --git a/ui/fbdev.c b/ui/fb

[Qemu-devel] [PATCH 04/10] spice: send updates only for changed screen content

2012-09-13 Thread Gerd Hoffmann
when creating screen updates go compare the current guest screen against the mirror (which holds the most recent update sent), then only create updates for the screen areas which did actually change. [ v2: drop redundant qemu_spice_create_one_update call ] Signed-off-by: Gerd Hoffmann --- ui/sp

Re: [Qemu-devel] [PATCH V3 01/11] atomic: introduce atomic operations

2012-09-13 Thread liu ping fan
On Thu, Sep 13, 2012 at 4:19 PM, Paolo Bonzini wrote: > Il 13/09/2012 10:14, Avi Kivity ha scritto: > >>> +static inline void atomic_set(Atomic *v, int i) > >>> +{ > >>> +v->counter = i; > >>> +} > >>> + > >>> +static inline int atomic_read(Atomic *v) > >>> +{ >

[Qemu-devel] [PATCH 06/10] qxl: Ignore set_client_capabilities pre/post migrate

2012-09-13 Thread Gerd Hoffmann
From: Hans de Goede The recent introduction of set_client_capabilities has broken (seamless) migration by trying to call qxl_send_events pre (seamless incoming) and post (*) migration, triggering the following assert: qxl_send_events: Assertion `qemu_spice_display_is_running(&d->ssd)' failed. Th

Re: [Qemu-devel] Windows VM slow boot

2012-09-13 Thread Mel Gorman
On Wed, Sep 12, 2012 at 05:46:15PM +0100, Richard Davies wrote: > Hi Mel - thanks for replying to my underhand bcc! > > Mel Gorman wrote: > > I see that this is an old-ish bug but I did not read the full history. > > Is it now booting faster than 3.5.0 was? I'm asking because I'm > > interested to

[Qemu-devel] [PATCH v2 0/9] linux framebuffer display driver

2012-09-13 Thread Gerd Hoffmann
Hi, Second round of the framebuffer display driver patches. Changes: Addressed the review comments. Added a few more patches on top: Using the pixman library for raster ops now. Added support for mouse pointer rendering and guest display scaling. cheers, Gerd Gerd Hoffmann (9): QLIST-

[Qemu-devel] [PATCH 10/14] usb-redir: Store max_packet_size in endp_data

2012-09-13 Thread Gerd Hoffmann
From: Hans de Goede So that we've a place to migrate it to / from to allow restoring it after migration. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redir

[Qemu-devel] [PATCH 01/10] spice: switch to queue for vga mode updates

2012-09-13 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/qxl.c |6 +++--- ui/spice-display.c | 25 ++--- ui/spice-display.h |3 ++- 3 files changed, 19 insertions(+), 15 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 5b3f484..257a37d 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @

[Qemu-devel] [PATCH 08/14] usb-redir: Change cancelled packet code into a generic packet-id queue

2012-09-13 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c | 102 + 1 files changed, 71 insertions(+), 31 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 5301a69..603262a 100644

[Qemu-devel] [PATCH v2 4/9] fbdev: add linux framebuffer display driver.

2012-09-13 Thread Gerd Hoffmann
Display works, requires truecolor framebuffer with 16 or 32 bpp on the host. 32bpp is recommended. The framebuffer is used as-is, qemu doesn't try to switch modes. With LCD displays mode switching is pretty pointless IMHO, also it wouldn't work anyway with the most common fbdev drivers (vesafb,

Re: [Qemu-devel] [PATCH V3 08/11] qom: introduce reclaimer to release obj in async

2012-09-13 Thread liu ping fan
On Thu, Sep 13, 2012 at 4:45 PM, Avi Kivity wrote: > On 09/13/2012 09:54 AM, liu ping fan wrote: >> On Tue, Sep 11, 2012 at 5:37 PM, Avi Kivity wrote: >>> On 09/11/2012 12:32 PM, liu ping fan wrote: On Tue, Sep 11, 2012 at 4:32 PM, Avi Kivity wrote: > On 09/11/2012 10:51 AM, Liu Ping Fa

[Qemu-devel] [PATCH 07/10] qxl: better cleanup for surface destroy

2012-09-13 Thread Gerd Hoffmann
From: Uri Lublin Add back a call to qxl_spice_destroy_surface_wait_complete() in qxl_spice_destroy_surface_wait(), that was removed by commit c480bb7da465186b84d8427e068ef7502e47ffbf It is needed to complete surface-removal cleanup, for non async. For async, qxl_spice_destroy_surface_wait_compl

[Qemu-devel] [PATCH 08/10] hw/qxl: tracing fixes

2012-09-13 Thread Gerd Hoffmann
From: Alon Levy Add two new trace events: qxl_send_events(int qid, uint32_t events) "%d %d" qxl_set_guest_bug(int qid) "%d" Change qxl_io_unexpected_vga_mode parameters to be equivalent to those of qxl_io_write for easier grouping under a single systemtap probe. Change d to qxl in one place. S

[Qemu-devel] [PATCH v2 6/9] fbdev: make configurable at compile time.

2012-09-13 Thread Gerd Hoffmann
Add CONFIG_FBDEV, add --enable-fbdev and --disable-fbdev configure switches so fbdev can be enabled/disabled at compile time. Signed-off-by: Gerd Hoffmann --- configure| 12 qmp.c|2 +- ui/Makefile.objs |2 +- vl.c |4 ++-- 4 files chang

[Qemu-devel] [PATCH 12/14] usb-redir: Add chardev open / close debug logging

2012-09-13 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 5e987e9..9a4be6d 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c

[Qemu-devel] [PATCH 07/14] ehci: Walk async schedule before and after migration

2012-09-13 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index bc86460..6a5da84 100644 --- a/hw/usb/hcd-ehci.c +

[Qemu-devel] [PATCH v2 1/9] QLIST-ify display change listeners.

2012-09-13 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- console.h | 72 +++ hw/xenfb.c |2 +- vl.c |9 ++- 3 files changed, 42 insertions(+), 41 deletions(-) diff --git a/console.h b/console.h index f990684..646ad4b 100644 --- a/console.h +++

Re: [Qemu-devel] [PATCH V3 08/11] qom: introduce reclaimer to release obj in async

2012-09-13 Thread Avi Kivity
On 09/13/2012 12:59 PM, liu ping fan wrote: > On Thu, Sep 13, 2012 at 4:45 PM, Avi Kivity wrote: >> On 09/13/2012 09:54 AM, liu ping fan wrote: >>> On Tue, Sep 11, 2012 at 5:37 PM, Avi Kivity wrote: On 09/11/2012 12:32 PM, liu ping fan wrote: > On Tue, Sep 11, 2012 at 4:32 PM, Avi Kivity

[Qemu-devel] [PATCH 09/10] qxl: add trace-event for QXL_IO_LOG

2012-09-13 Thread Gerd Hoffmann
From: Alon Levy Signed-off-by: Alon Levy Signed-off-by: Gerd Hoffmann --- hw/qxl.c |1 + trace-events |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 8c46766..5709e0d 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1515,6 +1515,7 @@ async_com

[Qemu-devel] [PATCH 14/14] uhci: Don't queue up packets after one with the SPD flag set

2012-09-13 Thread Gerd Hoffmann
From: Hans de Goede Don't queue up packets after a packet with the SPD (short packet detect) flag set. Since we won't know if the packet will actually be short until it has completed, and if it is short we should stop the queue. This fixes a miniature photoframe emulating a USB cdrom with the wi

Re: [Qemu-devel] [PATCH] rtl8139: implement 8139cp link status

2012-09-13 Thread Jason Wang
On 09/10/2012 04:15 PM, Jason Wang wrote: On 09/10/2012 03:59 PM, Amos Kong wrote: From: Jason Wang Add a link status chang callback and change the link status bit in BMSR & MSR accordingly. Tested in Linux/Windows guests. Signed-off-by: Jason Wang Signed-off-by: Amos Kong --- hw/rtl8139.c

[Qemu-devel] [PATCH 05/14] configure: usbredir fixes

2012-09-13 Thread Gerd Hoffmann
From: Aurelien Jarno usbredir is only used by system emulation, so add the libraries to libs_softmmu instead of LIBS. Cc: Michael Tokarev Cc: Gerd Hoffmann Signed-off-by: Aurelien Jarno Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- configure |2 +- 1 files changed, 1 in

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-13 Thread Gleb Natapov
On Wed, Sep 12, 2012 at 01:19:17PM -0500, Anthony Liguori wrote: > Gleb Natapov writes: > > > On Wed, Sep 12, 2012 at 08:54:26AM -0500, Anthony Liguori wrote: > >> > >> Hi, > >> > >> We've been running into a lot of problems lately with Windows guests and > >> I think they all ultimately could

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-13 Thread Gleb Natapov
On Wed, Sep 12, 2012 at 09:45:49PM +0200, Stefan Weil wrote: > Am 12.09.2012 20:13, schrieb Gleb Natapov: > >On Wed, Sep 12, 2012 at 07:30:08PM +0200, Stefan Weil wrote: > >>I also meant host hibernation. > >Than I don't see how guest can handle the situation since it has > >no idea that it was sto

Re: [Qemu-devel] [PATCH v3 1/2] slirp: Handle more than 65535 blocks in TFTP transfers

2012-09-13 Thread Jan Kiszka
On 2012-09-13 07:55, Hervé Poussineau wrote: > RFC 1350 does not mention block count roll-over. However, a lot of TFTP > servers > implement it to be able to transmit big files, so do it also. > > Current block size is 512 bytes, so TFTP files were limited to 32 MB. > > Signed-off-by: Hervé Pous

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-13 Thread Peter Lieven
On 13.09.2012 10:05, Gleb Natapov wrote: On Thu, Sep 13, 2012 at 10:00:26AM +0200, Paolo Bonzini wrote: Il 13/09/2012 09:57, Gleb Natapov ha scritto: #rdmsr -0 0x194 00011100 #rdmsr -0 0xce 0c0004011103 Yes, that can help implementing it in KVM. But without a spec to understand wh

Re: [Qemu-devel] [PATCH v2] rtl8139: implement 8139cp link status

2012-09-13 Thread Stefan Hajnoczi
On Thu, Sep 13, 2012 at 9:51 AM, Amos Kong wrote: > From: Jason Wang > > Add a link status chang callback and change the link status bit in BMSR > & MSR accordingly. Tested in Linux/Windows guests. > > The link status bit of MediaStatus is infered from BasicModeStatus, > they are reverse. > > Sig

Re: [Qemu-devel] [PATCH v2 1/3] Refactor inet_connect_opts function

2012-09-13 Thread Markus Armbruster
Orit Wasserman writes: > From: Michael S. Tsirkin > > refactor address resolution code to fix nonblocking connect > > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Amos Kong > Signed-off-by: Orit Wasserman > --- > qemu-sockets.c | 139 > +---

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-13 Thread Gleb Natapov
On Thu, Sep 13, 2012 at 02:05:23PM +0200, Peter Lieven wrote: > On 13.09.2012 10:05, Gleb Natapov wrote: > >On Thu, Sep 13, 2012 at 10:00:26AM +0200, Paolo Bonzini wrote: > >>Il 13/09/2012 09:57, Gleb Natapov ha scritto: > >>>#rdmsr -0 0x194 > >>>00011100 > >>>#rdmsr -0 0xce > >

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-13 Thread Don Slutz
On 09/12/12 09:58, Anthony Liguori wrote: Kevin Wolf writes: Am 12.09.2012 01:50, schrieb Michael S. Tsirkin: On Tue, Sep 11, 2012 at 01:00:13PM -0400, Don Slutz wrote: Add LSI53C1030, SAS1068, SAS1068e. Based on code from "VirtualBox Open Source Edition". Based on QEMU MegaRAID SAS 8708EM

Re: [Qemu-devel] [PATCH v2 2/3] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect

2012-09-13 Thread Markus Armbruster
Orit Wasserman writes: > No need to add non blocking parameters to the blocking inet_connect > > Signed-off-by: Orit Wasserman > --- > migration-tcp.c |2 +- > nbd.c |2 +- > qemu-sockets.c | 24 > qemu_socket.h |4 +++- > ui/vnc.c|

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-13 Thread Don Slutz
On 09/12/12 11:38, Avi Kivity wrote: On 09/11/2012 08:00 PM, Don Slutz wrote: Add LSI53C1030, SAS1068, SAS1068e. Based on code from "VirtualBox Open Source Edition". Based on QEMU MegaRAID SAS 8708EM2. This is a common VMware disk controller. SEABIOS change for booting is in the works. Test

Re: [Qemu-devel] [PATCH 27/47] block: introduce mirror job

2012-09-13 Thread Kevin Wolf
Am 24.07.2012 13:04, schrieb Paolo Bonzini: > This patch adds the implementation of a new job that mirrors a disk to > a new image while letting the guest continue using the old image. > The target is treated as a "black box" and data is copied from the > source to the target in the background. Th

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-13 Thread Peter Lieven
On 13.09.2012 14:42, Gleb Natapov wrote: On Thu, Sep 13, 2012 at 02:05:23PM +0200, Peter Lieven wrote: On 13.09.2012 10:05, Gleb Natapov wrote: On Thu, Sep 13, 2012 at 10:00:26AM +0200, Paolo Bonzini wrote: Il 13/09/2012 09:57, Gleb Natapov ha scritto: #rdmsr -0 0x194 00011100 #rdmsr

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-13 Thread Eric Blake
On 09/13/2012 04:49 AM, Gleb Natapov wrote: >> They do if you hibernate your laptop. >> > AFAIK libvirt migrates vm into a file on hibernate. It is better to move to S3 > (using qemu-ga) instead and migrate to file only if s3 fails. On host hibernate, libvirt currently does nothing to the guest.

Re: [Qemu-devel] [PATCH v2 1/3] Refactor inet_connect_opts function

2012-09-13 Thread Markus Armbruster
One more... Orit Wasserman writes: [...] > +static int inet_connect_addr(struct addrinfo *addr, bool block, > + bool *in_progress, Error **errp) Parameter errp is unused. > +{ > +char uaddr[INET6_ADDRSTRLEN + 1]; > +char uport[33]; > +int sock, rc; > + >

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-13 Thread Anthony Liguori
Paolo Bonzini writes: > Il 12/09/2012 15:58, Anthony Liguori ha scritto: >> Why would someone use this verses megasas vs. LSI vs virtio-scsi? > > LSI is dead. Compare it to IDE. > > virtio-scsi has the highest performance, but it is not supported on all > guests. Compare it to virtio-blk. > > T

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

2012-09-13 Thread Kevin Wolf
Am 24.07.2012 13:04, schrieb Paolo Bonzini: > This adds the monitor commands that start the mirroring job. > > Signed-off-by: Paolo Bonzini > --- > blockdev.c | 133 > -- > hmp-commands.hx | 21 + > hmp.c| 28 ++

Re: [Qemu-devel] [PATCH v2 3/3] Fix address handling in inet_nonblocking_connect

2012-09-13 Thread Markus Armbruster
Orit Wasserman writes: > getaddrinfo can give us a list of addresses, but we only try to > connect to the first one. If that fails we never proceed to > the next one. This is common on desktop setups that often have ipv6 > configured but not actually working. > > To fix this make inet_connect_no

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

2012-09-13 Thread Paolo Bonzini
Il 13/09/2012 15:15, Kevin Wolf ha scritto: >> > +flags = bs->open_flags | BDRV_O_RDWR; > Do we take care to make the image read-only again after completion? Not at the file-descriptor level, but bs->read_only is indeed restored to "true" via bdrv_swap. Doing it on the file descriptor is poss

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

2012-09-13 Thread Kevin Wolf
Am 13.09.2012 15:24, schrieb Paolo Bonzini: > Il 13/09/2012 15:15, Kevin Wolf ha scritto: +flags = bs->open_flags | BDRV_O_RDWR; >> Do we take care to make the image read-only again after completion? > > Not at the file-descriptor level, but bs->read_only is indeed restored > to "true" vi

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-13 Thread Daniel P. Berrange
On Thu, Sep 13, 2012 at 07:14:08AM -0600, Eric Blake wrote: > On 09/13/2012 04:49 AM, Gleb Natapov wrote: > >> They do if you hibernate your laptop. > >> > > AFAIK libvirt migrates vm into a file on hibernate. It is better to move to > > S3 > > (using qemu-ga) instead and migrate to file only if s

Re: [Qemu-devel] [PATCH v2 3/3] Fix address handling in inet_nonblocking_connect

2012-09-13 Thread Michael S. Tsirkin
On Thu, Sep 13, 2012 at 03:22:24PM +0200, Markus Armbruster wrote: > > +/* Struct to store connect state for non blocking connect */ > > +typedef struct ConnectState { > > +int fd; > > +struct addrinfo *addr_list; > > +struct addrinfo *current_addr; > > +ConnectHandler *callback; >

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

2012-09-13 Thread Paolo Bonzini
Il 13/09/2012 15:26, Kevin Wolf ha scritto: > +flags = bs->open_flags | BDRV_O_RDWR; >>> >> Do we take care to make the image read-only again after completion? >> > >> > Not at the file-descriptor level, but bs->read_only is indeed restored >> > to "true" via bdrv_swap. >> > >> > Doing it

Re: [Qemu-devel] [PATCH 1/2] KVM: fix i8259 interrupt high to low transition logic

2012-09-13 Thread Maciej W. Rozycki
On Wed, 12 Sep 2012, Matthew Ogilvie wrote: > Also, how big of a concern is a very rare gained or lost IRQ0 > actually? Under normal conditions, I would expect this to at most > cause a one time clock drift in the guest OS of a fraction of > a second. If that only happens when rebooting or migra

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-13 Thread Gleb Natapov
On Thu, Sep 13, 2012 at 02:56:33PM +0200, Peter Lieven wrote: > On 13.09.2012 14:42, Gleb Natapov wrote: > >On Thu, Sep 13, 2012 at 02:05:23PM +0200, Peter Lieven wrote: > >>On 13.09.2012 10:05, Gleb Natapov wrote: > >>>On Thu, Sep 13, 2012 at 10:00:26AM +0200, Paolo Bonzini wrote: > Il 13/09/2

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-13 Thread Gleb Natapov
On Thu, Sep 13, 2012 at 07:14:08AM -0600, Eric Blake wrote: > On 09/13/2012 04:49 AM, Gleb Natapov wrote: > >> They do if you hibernate your laptop. > >> > > AFAIK libvirt migrates vm into a file on hibernate. It is better to move to > > S3 > > (using qemu-ga) instead and migrate to file only if s

[Qemu-devel] [PATCH] m68k: implement move to/from usp register instruction

2012-09-13 Thread gerg
From: Greg Ungerer Fill out the code support for the move to/from usp instructions. They are being decoded, but there is no code to support there actions. So add it. Current versions of Linux running on the ColdFire 5208 use these instructions. Signed-off-by: Greg Ungerer --- target-m68k/help

[Qemu-devel] [PATCH] m68k: fix usp processing on interrupt entry and exception exit

2012-09-13 Thread gerg
From: Greg Ungerer The action to potentially switch sp register is not occurring at the correct point in the interrupt entry or exception exit sequences. For the interrupt entry case the sp on entry is used to create the stack exception frame - but this may well be the user stack pointer, since

[Qemu-devel] [PATCH] m68k: implmenent more ColdFire 5208 interrupt controller functionality

2012-09-13 Thread gerg
From: Greg Ungerer Implement the SIMR and CIMR registers of the 5208 interrupt controller. These are used by modern versions of Linux running on ColdFire (not sure of the exact version they were introduced, but they have been in for quite a while now). Without this change when attempting to run

Re: [Qemu-devel] [PATCH 1/2] KVM: fix i8259 interrupt high to low transition logic

2012-09-13 Thread Jan Kiszka
On 2012-09-13 15:41, Maciej W. Rozycki wrote: > On Wed, 12 Sep 2012, Matthew Ogilvie wrote: > >> Also, how big of a concern is a very rare gained or lost IRQ0 >> actually? Under normal conditions, I would expect this to at most >> cause a one time clock drift in the guest OS of a fraction of >> a

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-13 Thread Michael S. Tsirkin
On Tue, Sep 11, 2012 at 01:00:13PM -0400, Don Slutz wrote: > +if (next_chain_offset) { > +MptSGEntryChain sgec; > +cpu_physical_memory_read(seg_start_pa + next_chain_offset, > +&sgec, sizeof(MptSGEntryChain)); > +as

Re: [Qemu-devel] [PATCH 1/2] KVM: fix i8259 interrupt high to low transition logic

2012-09-13 Thread Jan Kiszka
On 2012-09-13 07:49, Matthew Ogilvie wrote: > On Wed, Sep 12, 2012 at 10:57:57AM +0200, Jan Kiszka wrote: >> On 2012-09-12 10:51, Avi Kivity wrote: >>> On 09/12/2012 11:48 AM, Jan Kiszka wrote: On 2012-09-12 10:01, Avi Kivity wrote: > On 09/10/2012 04:29 AM, Matthew Ogilvie wrote: >> I

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-13 Thread Anthony Liguori
"Daniel P. Berrange" writes: > On Thu, Sep 13, 2012 at 07:14:08AM -0600, Eric Blake wrote: >> On 09/13/2012 04:49 AM, Gleb Natapov wrote: >> >> They do if you hibernate your laptop. >> >> >> > AFAIK libvirt migrates vm into a file on hibernate. It is better to move >> > to S3 >> > (using qemu-ga

Re: [Qemu-devel] [PATCH 27/47] block: introduce mirror job

2012-09-13 Thread Paolo Bonzini
Il 13/09/2012 14:54, Kevin Wolf ha scritto: >> > +ret = bdrv_co_is_allocated_above(bs, base, >> > + sector_num, next - >> > sector_num, &n); >> > + >> > +if (ret < 0) { >> > +break; >> > +} else if (ret

Re: [Qemu-devel] [PATCH 03/13] pseries: Use new method to correct reset sequence

2012-09-13 Thread Andreas Färber
David, Am 13.09.2012 04:57, schrieb David Gibson: > A number of things need to occur during reset of the PAPR > paravirtualized platform in a specific order. For example, the hash > table needs to be cleared before the CPUs are reset, so that they > initialize their register state correctly, and

Re: [Qemu-devel] [PATCH 02/13] pseries: Fix and cleanup CPU initialization and reset

2012-09-13 Thread Andreas Färber
Am 13.09.2012 04:57, schrieb David Gibson: > The current pseries machine init function iterates over the CPUs at several > points, doing various bits of initialization. This is messy; these can > and should be merged into a single iteration doing all the necessary per > cpu initialization. Worse,

Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Remove unused registers from tcg_target_call_iarg_regs

2012-09-13 Thread Richard Henderson
On 09/12/2012 10:50 PM, Stefan Weil wrote: > I could use conditional compilation for those accesses, > but first I'd like to understand why this works at all. Before your patch you mean? Because those are the registers reserved by the "L" constraint. r~

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-13 Thread Gleb Natapov
On Thu, Sep 13, 2012 at 09:06:29AM -0500, Anthony Liguori wrote: > "Daniel P. Berrange" writes: > > > On Thu, Sep 13, 2012 at 07:14:08AM -0600, Eric Blake wrote: > >> On 09/13/2012 04:49 AM, Gleb Natapov wrote: > >> >> They do if you hibernate your laptop. > >> >> > >> > AFAIK libvirt migrates vm

Re: [Qemu-devel] [PATCH v2 3/3] Fix address handling in inet_nonblocking_connect

2012-09-13 Thread Orit Wasserman
On 13 בספט 2012, at 16:30, "Michael S. Tsirkin" wrote: > On Thu, Sep 13, 2012 at 03:22:24PM +0200, Markus Armbruster wrote: >>> +/* Struct to store connect state for non blocking connect */ >>> +typedef struct ConnectState { >>> +int fd; >>> +struct addrinfo *addr_list; >>> +struc

Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Remove unused registers from tcg_target_call_iarg_regs

2012-09-13 Thread Peter Maydell
On 13 September 2012 06:50, Stefan Weil wrote: > Am 12.09.2012 23:18, schrieb Peter Maydell: >> This makes the array zero-length for 32 bit targets, but functions >> like tcg_out_tlb_load() and tcg_out_qemu_ld() still unconditionally >> access elements in it... > Thanks for the hint. I'm afraid t

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-13 Thread Avi Kivity
On 09/13/2012 05:22 PM, Gleb Natapov wrote: >> >> It's much easier for us to call into qemu-ga to do the time correction >> whenever this event occurs than to try and have libvirt figure out when >> it's necessary. > And if guest does not have qemu-ga what is better inject interrupts like > crazy

  1   2   3   >