[Qemu-devel] [PATCH 36/54] xhci: trace cc codes in cleartext

2012-09-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 48 +++- trace-events |2 +- 2 files changed, 48 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 3c61bb8..ab32a7b 100644 --- a/hw/usb/hcd-xhci.c +++

[Qemu-devel] [PATCH 45/54] xhci: fix & cleanup msi.

2012-09-06 Thread Gerd Hoffmann
Drop custom write_config function which isn't needed any more. Make the msi property a bit property so it accepts 'on' & 'off'. Enable MSI by default. TODO: add compat property to disable on old machine types. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 27 +--

[Qemu-devel] [PATCH 47/54] xhci: add msix support

2012-09-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 47 ++- trace-events |3 +++ 2 files changed, 49 insertions(+), 1 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 5eae32e..3bac99a 100644 --- a/hw/usb/hcd-xhci.c +++

[Qemu-devel] [PATCH 07/14] spice: increase the verbosity of spice section in "qemu --help"

2012-09-06 Thread Gerd Hoffmann
From: Yonit Halperin Added all spice options to the help string. This can be used by libvirt to determine which spice related features are supported by qemu. Signed-off-by: Yonit Halperin Signed-off-by: Gerd Hoffmann --- qemu-options.hx | 18 +- 1 files changed, 17 insertion

[Qemu-devel] [PATCH 04/14] spice migration: add QEVENT_SPICE_MIGRATE_COMPLETED

2012-09-06 Thread Gerd Hoffmann
From: Yonit Halperin When migrating, libvirt queries the migration status, and upon migration completions, it closes the migration src. On the other hand, when migration is completed, spice transfers data from the src to destination via the client. This data is required for keeping the spice sess

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-06 Thread Paolo Bonzini
Il 05/09/2012 11:57, Bharata B Rao ha scritto: >> > What could be the issue here ? In general, how do I ensure that my >> > aio calls get completed correctly in such scenarios where bdrv_read etc >> > are called from coroutine context rather than from main thread context ? > One way to handle this

[Qemu-devel] [PATCH 48/54] xhci: move register update into xhci_intr_raise

2012-09-06 Thread Gerd Hoffmann
Now that we have a separate function to raise an IRQ we can move some comon code into the function. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 14 +- 1 files changed, 5 insertions(+), 9 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 3bac99a..e39fe0

[Qemu-devel] [PATCH 44/54] usb-storage: usb3 support

2012-09-06 Thread Gerd Hoffmann
Add usb3 descriptors to usb-storage, so it shows up as superspeed device when connected to xhci. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-storage.c | 46 +++--- 1 files changed, 43 insertions(+), 3 deletions(-) diff --git a/hw/usb/dev-storage.c b/hw/

[Qemu-devel] [PATCH 46/54] xhci: rework interrupt handling

2012-09-06 Thread Gerd Hoffmann
Split xhci_irq_update into a function which handles intx updates (including lowering the irq line once the guests acks the interrupt) and one which is used for raising an irq only. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 47 +-- 1 files

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-06 Thread Paolo Bonzini
Il 09/08/2012 15:02, Bharata B Rao ha scritto: > block: Support GlusterFS as a QEMU block backend. > > From: Bharata B Rao > > This patch adds gluster as the new block backend in QEMU. This gives > QEMU the ability to boot VM images from gluster volumes. Its already > possible to boot from VM im

[Qemu-devel] [PATCH 12/54] ehci: add doorbell trace events

2012-09-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |3 ++- trace-events |2 ++ 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 4564615..398f5e0 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -1241,6 +1241,7 @@ stat

[Qemu-devel] [PULL 0/4] wakeup: make wakeup events guest-configurable

2012-09-06 Thread Gerd Hoffmann
Hi, This patch series allows the guest to enable and disable s3 wakeup events per device via acpi. It also adds support for waking up the guest from uhci. Each device gets a GPE pin assigned. With this patch series applied and seabios updated (for the dsdt updates needed to tell guests about

[Qemu-devel] [PATCH 3/4] wakeup: make serial configurable

2012-09-06 Thread Gerd Hoffmann
serial port #1 gets gpe 0x0a. Now that the wakeup is guest-configurable via acpi we also enable it unconditionally. Other serial ports are unchanged: they continue to use the "other" exit reason and are disabled unless explicitly enabled via wakeup property. Signed-off-by: Gerd Hoffmann --- hw

[Qemu-devel] [PATCH 1/4] wakeup: add acpi gpe wakeup reasons

2012-09-06 Thread Gerd Hoffmann
Allocate four acpi gpe bits (0x08 -> 0x0b) for s3 wakeup configuration and notification. Signed-off-by: Gerd Hoffmann --- hw/acpi.c | 26 ++ sysemu.h |4 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/hw/acpi.c b/hw/acpi.c index f7950be..4d6bc

[Qemu-devel] [PATCH 23/54] usb-redir: Return babble when getting more bulk data then requested

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede Babble is the appropriate error in this case (rather then signalling a stall). Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.

Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable

2012-09-06 Thread Peter Maydell
On 6 September 2012 08:42, Gerd Hoffmann wrote: > @@ -789,6 +790,13 @@ static int serial_isa_initfn(ISADevice *dev) > isa->isairq = isa_serial_irq[isa->index]; > index++; > > +if (isa->iobase == 0x3f8) { > +s->reason = QEMU_WAKEUP_REASON_GPE_a; > +s->wakeup = 1; >

Re: [Qemu-devel] [PATCH] qxl: dont update invalid area

2012-09-06 Thread Gerd Hoffmann
On 08/30/12 18:44, riegama...@gmail.com wrote: > This patch fixes the following error: > > $ ~/usr/bin/qemu-system-x86_64 -enable-kvm -m 1024 -spice > port=5900,disable-ticketing -vga qxl -cdrom > ~/Images/linuxmint-13-mate-dvd-32bit.iso > (/home/mathslinux/usr/bin/qemu-system-x86_64:10068): Spi

[Qemu-devel] [PATCH 40/54] xhci: update port handling

2012-09-06 Thread Gerd Hoffmann
This patch changes the way xhci ports are linked to USBPorts. The fixed 1:1 relationship between xhci ports and USBPorts is gone. Now each USBPort represents a physical plug which has usually two xhci ports assigned: one usb2 and ond usb3 port. usb devices show up at one or the other, depending

[Qemu-devel] [PATCH 03/14] spice: notify on vm state change only via spice_server_vm_start/stop

2012-09-06 Thread Gerd Hoffmann
From: Yonit Halperin QXLWorker->start/stop are deprecated since spice-server 0.11.2 Signed-off-by: Yonit Halperin Signed-off-by: Gerd Hoffmann --- hw/qxl.c |7 --- ui/spice-core.c|4 ui/spice-display.c | 32 ++-- ui/spice-display.h

[Qemu-devel] [PATCH 4/4] wakeup: uhci support

2012-09-06 Thread Gerd Hoffmann
Implement the (intel-specific) pci configuration register 0xc4, which is a bitmask saying which ports are allowed to wakeup the system. Also assign gpe bit 0x0b (used only in case uhci handles device 01.2). Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-uhci.c | 35 ++

[Qemu-devel] [PATCH 18/54] usb-redir: Don't delay handling of open events to a bottom half

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede There is no need for this, and doing so means that a backend trying to write immediately after an open event will see qemu_chr_be_can_write returning 0, which not all backends handle well as there is no wakeup mechanism to detect when the frontend does become writable. Signed

[Qemu-devel] [PATCH 06/14] spice: adding seamless-migration option to the command line

2012-09-06 Thread Gerd Hoffmann
From: Yonit Halperin The seamless-migration flag is required in order to identify whether libvirt supports the new QEVENT_SPICE_MIGRATE_COMPLETED or not (by default the flag is off). New libvirt versions that wait for QEVENT_SPICE_MIGRATE_COMPLETED should turn on this flag. When this flag is off

[Qemu-devel] [PATCH 09/54] ehci: Properly report completed but not yet processed packets to the guest

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede Reported packets which have completed before being cancelled as such to the host. Note that the new code path this patch adds is untested since it I've been unable to actually trigger the race which needs this code path. Signed-off-by: Hans de Goede --- hw/usb/hcd-ehci.c |

[Qemu-devel] [PATCH 49/54] xhci: add XHCIInterrupter

2012-09-06 Thread Gerd Hoffmann
Move all state belonging to the (single) interrupter into a separate struct. First step in adding support for multiple interrupters. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 307 - trace-events |2 +- 2 files changed, 161

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-06 Thread Avi Kivity
On 08/14/2012 12:58 PM, Kevin Wolf wrote: > >> While we are at this, let me bring out another issue. Gluster supports 3 >> transport types: >> >> - socket in which case the server will be hostname, ipv4 or ipv4 address. >> - rdma in which case server will be interpreted similar to socket. >> - un

[Qemu-devel] [PATCH 20/54] usb-redir: Get rid of local shadow copy of packet headers

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede The shadow copy only serves as an extra check (besides the packet-id) to ensure the packet we get back is a reply to the packet we think it is. This check has never triggered in all the time usb-redir is in use now, and since the verified data in the returned packet-header is

[Qemu-devel] [PATCH 34/54] xhci: implement mfindex

2012-09-06 Thread Gerd Hoffmann
Implement mfindex register and mfindex wrap event. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 53 ++--- 1 files changed, 46 insertions(+), 7 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 303e1ac..9077cb3 100644

Re: [Qemu-devel] [PATCH 12/18] savevm: add error parameter to qemu_loadvm_state()

2012-09-06 Thread Pavel Hrdina
On 08/30/2012 07:09 PM, Luiz Capitulino wrote: On Wed, 15 Aug 2012 09:41:53 +0200 Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina --- migration.c | 2 +- savevm.c| 44 sysemu.h| 3 ++- 3 files changed, 31 insertions(+), 18 deletions(

Re: [Qemu-devel] [PATCH 01/18] qerror: introduce QERR_GENERIC_ERROR

2012-09-06 Thread Pavel Hrdina
On 08/30/2012 02:11 PM, Luiz Capitulino wrote: On Wed, 15 Aug 2012 09:41:42 +0200 Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina --- qerror.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qerror.h b/qerror.h index d0a76a4..7e0bae7 100644 --- a/qerror.h +++ b/qerror.h @@ -120,6 +1

[Qemu-devel] [PATCH 13/14] qxl: Add set_client_capabilities() interface to QXLInterface

2012-09-06 Thread Gerd Hoffmann
From: Søren Sandmann Pedersen This new interface lets spice server inform the guest whether (a) a client is connected (b) what capabilities the client has There is a fixed number (464) of bits reserved for capabilities, and when the capabilities bits change, the QXL_INTERRUPT_CLIENT interrupt i

[Qemu-devel] [PATCH 41/54] usb3: superspeed descriptors

2012-09-06 Thread Gerd Hoffmann
Add superspeed descriptor entry to USBDesc, advertise superspeed support when present. Signed-off-by: Gerd Hoffmann --- hw/usb/desc.c | 10 +- hw/usb/desc.h |1 + 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/hw/usb/desc.c b/hw/usb/desc.c index 0a9d3c9..3e8c6cb 10

[Qemu-devel] [PATCH 05/14] spice: add 'migrated' flag to spice info

2012-09-06 Thread Gerd Hoffmann
From: Yonit Halperin The flag is 'true' when spice migration has completed on the src side. It is needed for a case where libvirt dies before migration completes and it misses the event QEVENT_SPICE_MIGRATE_COMPLETED. When libvirt is restored and queries the migration status, it also needs to que

[Qemu-devel] [PATCH 02/54] usb-core: Don't set packet state to complete on a nak

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede This way the hcd can re-use the same packet to retry without needing to re-init it. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/core.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/usb/core.c b/hw/usb/core.c index

[Qemu-devel] [PATCH 08/14] qxl/update_area_io: guest_bug on invalid parameters

2012-09-06 Thread Gerd Hoffmann
From: Alon Levy Signed-off-by: Alon Levy Signed-off-by: Gerd Hoffmann --- hw/qxl.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 95bbc03..baf9bb4 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1386,6 +1386,18 @@ async_common:

[Qemu-devel] [PATCH 52/54] xhci: support multiple interrupters

2012-09-06 Thread Gerd Hoffmann
Everything is in place, flip the big switch now and enable support for multiple interrupters. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index d6ab0c6..55e31ec 100644 --- a

Re: [Qemu-devel] [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment

2012-09-06 Thread Jan Kiszka
On 2012-08-30 20:30, Jan Kiszka wrote: > This adds PCI device assignment for i386 targets using the classic KVM > interfaces. This version is 100% identical to what is being maintained > in qemu-kvm for several years and is supported by libvirt as well. It is > expected to remain relevant for anoth

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-06 Thread Avi Kivity
On 09/05/2012 10:04 PM, Blue Swirl wrote: > > Reinventing a disassembler for ever growing x86 assembly is > no fun. We can try linking to a disassembler library. I use udis86 to disassemble instructions in kvm tracepoints (http://udis86.git.sourceforge.net/git/gitweb.cgi?p=udis86/udis86;a=shortlo

[Qemu-devel] [PATCH 02/14] spice: notify spice server on vm start/stop

2012-09-06 Thread Gerd Hoffmann
From: Yonit Halperin Spice server needs to know about the vm state in order to prevent attempts to write to devices when they are stopped, mainly during the non-live stage of migration. Instead, spice will take care of restoring this writes, on the migration target side, after migration completes

[Qemu-devel] [PATCH 17/54] usb-redir: Never return USB_RET_NAK for async handled packets

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede USB_RET_NAK is not a valid response for async handled packets (and will trigger an assert as such). Also drop the warning when receiving a status of cancelled for packets not cancelled by qemu itself, this can happen when a device gets unredirected by the usbredir-host while

[Qemu-devel] [PATCH 54/54] xhci: allow bytewise capability register reads

2012-09-06 Thread Gerd Hoffmann
Some guests need this according to Alejandro Martinez Ruiz Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 500892d..2918e64 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-

[Qemu-devel] [PATCH 33/54] xhci: move device lookup into xhci_setup_packet

2012-09-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 74 +++- 1 files changed, 38 insertions(+), 36 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index c858b6d..303e1ac 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -

Re: [Qemu-devel] [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment

2012-09-06 Thread Michael S. Tsirkin
On Thu, Sep 06, 2012 at 10:44:15AM +0200, Jan Kiszka wrote: > On 2012-08-30 20:30, Jan Kiszka wrote: > > This adds PCI device assignment for i386 targets using the classic KVM > > interfaces. This version is 100% identical to what is being maintained > > in qemu-kvm for several years and is support

[Qemu-devel] [PATCH 11/14] configure: print spice-protocol and spice-server versions

2012-09-06 Thread Gerd Hoffmann
From: Alon Levy Signed-off-by: Alon Levy Signed-off-by: Gerd Hoffmann --- configure |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 59521ea..9592095 100755 --- a/configure +++ b/configure @@ -2701,6 +2701,8 @@ EOF spice="yes" li

[Qemu-devel] [PATCH 29/54] Better name usb braille device

2012-09-06 Thread Gerd Hoffmann
From: Samuel Thibault Windows users need to know that they have to use the Baum driver to make the qemu braille device work. Signed-off-by: Samuel Thibault Signed-off-by: Gerd Hoffmann --- hw/usb/dev-serial.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb/dev

[Qemu-devel] [PATCH 43/54] usb3: bos decriptor

2012-09-06 Thread Gerd Hoffmann
Add support for creating BOS descriptor and device cappability descriptors. Signed-off-by: Gerd Hoffmann --- hw/usb.h |6 +++ hw/usb/desc.c | 109 + hw/usb/desc.h | 25 + trace-events |1 + 4 files changed, 141

[Qemu-devel] [PATCH 14/54] ehci: Fix memory leak in handling of NAK-ed packets

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede Currently each time we try to execute a NAK-ed packet we redo ehci_init_transfer, and usb_packet_map, re-allocing (without freeing) the sg list every time. This patch fixes this, it does this by introducing another async state, so that we also properly cleanup a NAK-ed packet

[Qemu-devel] [PATCH 42/54] usb3: superspeed endpoint companion

2012-09-06 Thread Gerd Hoffmann
Add support for building superspeed endpoint companion descriptors, create them for superspeed usb devices. Signed-off-by: Gerd Hoffmann --- hw/usb.h |1 + hw/usb/desc.c | 55 --- hw/usb/desc.h | 26 +- 3 fi

[Qemu-devel] [PATCH 35/54] xhci: iso xfer support

2012-09-06 Thread Gerd Hoffmann
Add support for iso transfers. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 117 +--- 1 files changed, 101 insertions(+), 16 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 9077cb3..3c61bb8 100644 --- a/hw/usb/hcd-xh

[Qemu-devel] [PATCH 11/54] ehci: trace guest bugs

2012-09-06 Thread Gerd Hoffmann
make qemu_queue_{cancel,reset} return the number of packets released, so the caller can figure whenever there have been active packets even though there shouldn't have been any. Add tracepoint to log this. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 26 -- tra

[Qemu-devel] [PATCH 22/54] usb-redir: Move to core packet id and queue handling

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c | 226 ++--- 1 files changed, 92 insertions(+), 134 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 6593d50..fd1f8cc 10064

[Qemu-devel] [PULL 00/14] spice patch queue

2012-09-06 Thread Gerd Hoffmann
Hi, Here comes the spice patch queue with a bunch of fresh patches for 1.3. A new qmp event is there, to fix spice client migration races, and a bunch of patches needed to make use of the new goodies the upcoming spice-server version (0.12) brings. The later is disabled by default, we'll flip t

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-06 Thread Kevin Wolf
Am 06.09.2012 09:23, schrieb Paolo Bonzini: > Il 05/09/2012 11:57, Bharata B Rao ha scritto: What could be the issue here ? In general, how do I ensure that my aio calls get completed correctly in such scenarios where bdrv_read etc are called from coroutine context rather than from m

Re: [Qemu-devel] [PATCH 02/18] block: add error parameter to bdrv_snapshot_create() and related functions

2012-09-06 Thread Pavel Hrdina
On 08/30/2012 04:47 PM, Luiz Capitulino wrote: On Wed, 15 Aug 2012 09:41:43 +0200 Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina --- block.c| 25 + block.h| 3 ++- block/qcow2-snapshot.c | 9 - block/qcow2.h | 4

[Qemu-devel] [PATCH 01/14] spice: abort on invalid streaming cmdline params

2012-09-06 Thread Gerd Hoffmann
From: Christophe Fergeau When parsing its command line parameters, spice aborts when it finds unexpected values, except for the 'streaming-video' option. This happens because the parsing of the parameters for this option is done using the 'name2enum' helper, which does not error out on unknown va

[Qemu-devel] [PATCH 10/14] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-09-06 Thread Gerd Hoffmann
From: Alon Levy Revision bumped to 4 for new IO support, enabled for spice-server >= 0.11.1. New io enabled if revision is 4. Revision can be set to 4. [ kraxel: 3 continues to be the default revision. Once we have a new stable spice-server release and the qemu patches to enable

[Qemu-devel] [PATCH 51/54] xhci: pick target interrupter

2012-09-06 Thread Gerd Hoffmann
Pick the correct interrupter when queuing an event. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 22 -- 1 files changed, 16 insertions(+), 6 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 68a19ab..d6ab0c6 100644 --- a/hw/usb/hcd-xhci.c +++ b/

[Qemu-devel] [PATCH 24/54] usb-redir: Convert to new libusbredirparser 0.5 API

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede This gives us support for 64 bit ids which is needed for using XHCI with the new hcd generated ids. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- configure |2 +- hw/usb/redirect.c | 62 ++-- 2 f

[Qemu-devel] [PATCH 2/4] wakeup: make ps/2 configurable

2012-09-06 Thread Gerd Hoffmann
ps/2 gets gpe bits 0x08 (keyboard) and 0x09 (mouse). Signed-off-by: Gerd Hoffmann --- hw/ps2.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ps2.c b/hw/ps2.c index f93cd24..a3cd124 100644 --- a/hw/ps2.c +++ b/hw/ps2.c @@ -155,7 +155,7 @@ static void ps2_put_keyco

[Qemu-devel] [PATCH 37/54] xhci: add trace_usb_xhci_ep_set_dequeue

2012-09-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c |2 +- trace-events |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index ab32a7b..5cdaf76 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -1145,7 +1145,7 @@ static

[Qemu-devel] [PATCH 04/54] usb-core: Allow the first packet of a pipelined ep to complete immediately

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede This can happen with usb-redir live-migration when the packet gets re-queued after the migration and the original queuing from the migration source side has already finished. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/core.c |2 +- 1 files cha

[Qemu-devel] [PATCH 15/54] ehci: Handle USB_RET_PROCERR in ehci_fill_queue

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede USB_RET_PROCERR can be triggered by the guest (by for example requesting more then BUFFSIZE bytes), so don't assert on it. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) di

[Qemu-devel] [PATCH 50/54] xhci: prepare xhci_runtime_{read, write} for multiple interrupters

2012-09-06 Thread Gerd Hoffmann
Prepare xhci runtime register access function for multiple interrupters. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 100 ++--- 1 files changed, 57 insertions(+), 43 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index d

Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers

2012-09-06 Thread Alejandro Martinez
Gerd, On Tue, Sep 4, 2012 at 3:30 PM, Gerd Hoffmann wrote: > On 08/30/12 14:49, Alejandro Martinez Ruiz wrote: >> Some xHC drivers (most notably on Windows and BSD systems) read >> the first capability registers using 1 and 2 bytes accesses, since >> this is how they are defined in section 5.3 of

Re: [Qemu-devel] [PATCH 3/7] block: raw-posix image file reopen

2012-09-06 Thread Kevin Wolf
Am 05.09.2012 18:43, schrieb Jeff Cody: >>> +} >>> + >>> +int fcntl_flags = O_APPEND | O_ASYNC | O_NONBLOCK; >>> +#ifdef O_NOATIME >>> +fcntl_flags |= O_NOATIME; >>> +#endif >>> +if ((raw_s->open_flags & ~fcntl_flags) == (s->open_flags & >>> ~fcntl_flags)) { >>> +/* dup the

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-06 Thread Paolo Bonzini
Il 06/09/2012 11:06, Kevin Wolf ha scritto: >> > If it works, I think this change would be preferrable to using a "magic" >> > BH in every driver. > The way it works in posix-aio-compat is that the request is first > removed from the list and then the callback is called. This way > posix_aio_flush(

[Qemu-devel] [PATCH 25/54] usb-redir: Set ep max_packet_size if available

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede This is needed for usb-redir to work properly with the xhci emulation. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index e

[Qemu-devel] [PATCH 10/54] ehci: check for EHCI_ASYNC_FINISHED first in ehci_free_packet

2012-09-06 Thread Gerd Hoffmann
Otherwise we'll see the packet free twice in the trace log even though it actually happens only once. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 0a6c9ef..23221d

[Qemu-devel] [PATCH 13/54] ehci: Add some additional ehci_trace_guest_bug() calls

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 19 +-- 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 398f5e0..5a88268 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/u

[Qemu-devel] [PATCH 03/54] usb-core: Add a usb_ep_find_packet_by_id() helper function

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb.h |2 ++ hw/usb/core.c | 15 +++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/hw/usb.h b/hw/usb.h index b8fceec..684e3f4 100644 --- a/hw/usb.h +++ b/hw/usb.h @@ -3

Re: [Qemu-devel] [PATCH] usb: Fix host-side endian bugs in hcd-ehci

2012-09-06 Thread Gerd Hoffmann
On 08/22/12 05:04, David Gibson wrote: > The EHCI device model is horribly broken for big-endian hosts. It uses a > union of 'mmio' a byte array which is as-is as the device's MMIO space > with the various internal registers. The IO routines assume that mmio is > laid out in little-endian order,

[Qemu-devel] [PATCH] ehci: switch to new-style memory ops

2012-09-06 Thread Gerd Hoffmann
Also register different memory regions for capabilities, operational registers and port status registers. Create separate tracepoints for operational regs and port status regs. Ditch a bunch of sanity checks because the memory core will do this for us now. Offloading the byte, word and dword acc

[Qemu-devel] [PATCH 16/54] ehci: Correct a comment in fetchqtd packet processing

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede Since my previous comment said "Should never happen", I tried changing the next line to an assert(0), which did not go well, which as the new comments explains is logical if you think about it for a moment. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/u

[Qemu-devel] [PATCH 26/54] usb-redir: Add a usbredir_reject_device helper function

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c | 21 +++-- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index a91e073..c518201 100644 --- a/hw/usb/redirect.c +++ b/h

[Qemu-devel] [PATCH 05/54] Revert "ehci: don't flush cache on doorbell rings."

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede This reverts commit 9bc3a3a216e2689bfcdd36c3e079333bbdbf3ba0, which got added to fix an issue where the real, underlying cause was not stopping the ep queue on an error. Now that the underlying cause is fixed by the "usb: Halt ep queue and cancel pending packets on a packet e

[Qemu-devel] [PATCH 12/14] spice: make number of surfaces runtime-configurable.

2012-09-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/qxl.c | 31 +-- hw/qxl.h |3 +-- ui/spice-display.c |5 - ui/spice-display.h |3 +-- 4 files changed, 23 insertions(+), 19 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index adf17fd..8725f67 10

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-06 Thread Kevin Wolf
Am 06.09.2012 11:38, schrieb Paolo Bonzini: > Il 06/09/2012 11:06, Kevin Wolf ha scritto: If it works, I think this change would be preferrable to using a "magic" BH in every driver. >> The way it works in posix-aio-compat is that the request is first >> removed from the list and then the

[Qemu-devel] [PATCH 53/54] xhci: kill xhci_mem_{read, write} dispatcher functions

2012-09-06 Thread Gerd Hoffmann
... and register subregions instead, so we offload the dispatching to the the memory subsystem which is designed to handle it. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 140 1 files changed, 75 insertions(+), 65 deletions(-) diff

[Qemu-devel] [PATCH 27/54] usb-redir: Ensure our peer has the necessary caps when redirecting to XHCI

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede In order for redirection to work properly when redirecting to an emulated XHCI controller, the usb-redir-host must support both usb_redir_cap_ep_info_max_packet_size and usb_redir_cap_64bits_ids, reject any devices redirected to an XHCI controller when these are not supported.

Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers

2012-09-06 Thread Gerd Hoffmann
Hi, > usb-next will fail to compile using -Werror with: > hcd-xhci.c: In function ‘xhci_fire_ctl_transfer’: > hcd-xhci.c:1508:14: error: variable ‘wLength’ set but not used > [-Werror=unused-but-set-variable] Fixed. Which gcc is this? Must be pretty cutting edge, even on Fedora 17 (gcc 4.7.0)

[Qemu-devel] [PATCH 2/2] usb-host: allow emulated (non-async) control requests without USBPacket

2012-09-06 Thread Gerd Hoffmann
xhci needs this for USB_REQ_SET_ADDRESS due to the way usb addressing is handled by the xhci hardware. Signed-off-by: Gerd Hoffmann --- hw/usb/host-linux.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb/host-linux.c b/hw/usb/host-linux.c index 8df9207..44f1a64 1

[Qemu-devel] [PATCH 1/2] xhci: drop unused wlength

2012-09-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 2918e64..e0ca690 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -1505,7 +1505,6 @@ static int xhci_fire_ctl_transfer(

[Qemu-devel] [PATCH 32/54] xhci: drop buffering

2012-09-06 Thread Gerd Hoffmann
This patch splits the xhci_xfer_data function into three. The xhci_xfer_data function used to do does two things: (1) copy transfer data between guest memory and a temporary buffer. (2) report transfer results to the guest using events. Now we three functions to handle this: (1) xhci_xfer_

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-06 Thread Paolo Bonzini
Il 06/09/2012 12:07, Kevin Wolf ha scritto: >> The AIOCB is already invalid at the time the callback is entered, so we >> could release it before the call. However, not all implementation of >> AIO are ready for that and I'm not really in the mood for large scale >> refactoring... > > But the way

[Qemu-devel] [PATCH 07/54] ehci: Update copyright headers to reflect recent work

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede Update copyright headers to reflect all the work Gerd and I have been doing on the EHCI emulation. Signed-off-by: Hans de Goede --- hw/usb/hcd-ehci.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 35e

Re: [Qemu-devel] [PATCH] target-i386: Allow changing of Hypervisor CPUIDs.

2012-09-06 Thread Andreas Färber
Am 30.08.2012 21:20, schrieb Don Slutz: > This is primarily done so that the guest will think it is running > under vmware when hypervisor=vmware is specified as a property of a > cpu. > > Also allow this to work in accel=tcg mode. > > The new cpu properties hyper_level, hyper_extra, hyper_extra_

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-06 Thread Kevin Wolf
Am 06.09.2012 12:18, schrieb Paolo Bonzini: > Il 06/09/2012 12:07, Kevin Wolf ha scritto: >>> The AIOCB is already invalid at the time the callback is entered, so we >>> could release it before the call. However, not all implementation of >>> AIO are ready for that and I'm not really in the mood f

Re: [Qemu-devel] [PATCH v2 0/4] CHECKPATCH: Add warning for single else statement.

2012-09-06 Thread Andreas Färber
Am 05.09.2012 21:46, schrieb Blue Swirl: > Thanks, applied all. Question: Are additions to checkpatch.pl supposed to be in QEMU Coding Style as done here? Do you plan to convert it consistently then? checkpatch.pl uses tabs consistently, making checkpatch.pl complain. ;) The alternative would be t

Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers

2012-09-06 Thread Alejandro Martinez
Hi Gerd, On Thu, Sep 6, 2012 at 12:15 PM, Gerd Hoffmann wrote: > Hi, > >> usb-next will fail to compile using -Werror with: >> hcd-xhci.c: In function ‘xhci_fire_ctl_transfer’: >> hcd-xhci.c:1508:14: error: variable ‘wLength’ set but not used >> [-Werror=unused-but-set-variable] > > Fixed. > >

[Qemu-devel] [PATCH 31/54] xhci: rip out background transfer code

2012-09-06 Thread Gerd Hoffmann
original xhci code (the one which used libusb directly) used to use 'background transfers' for iso streams. In upstream qemu the iso stream buffering is handled by usb-host & usb-redir, so we will never ever need this. It has been left in as reference, but is dead code anyway. Rip it out. Signe

Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable

2012-09-06 Thread Gerd Hoffmann
On 09/06/12 09:48, Peter Maydell wrote: > On 6 September 2012 08:42, Gerd Hoffmann wrote: >> @@ -789,6 +790,13 @@ static int serial_isa_initfn(ISADevice *dev) >> isa->isairq = isa_serial_irq[isa->index]; >> index++; >> >> +if (isa->iobase == 0x3f8) { >> +s->reason = QEMU_

[Qemu-devel] [PATCH 08/54] ehci: Properly cleanup packets on cancel

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede --- hw/usb/hcd-ehci.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 78a248f..4fe85c8 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -747,6 +747,8 @@ static void eh

[Qemu-devel] [PATCH 21/54] usb-redir: Get rid of unused async-struct dev member

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede This is a preparation patch for completely getting rid of the async-packet struct in usb-redir, instead relying on the (new) per ep queues in the qemu usb core. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c |2 -- 1 files changed, 0 in

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-06 Thread Paolo Bonzini
Il 06/09/2012 12:29, Kevin Wolf ha scritto: >> That's quite difficult. Completion of an I/O operation can trigger >> another I/O operation on another block device, and so on until we go >> back to the first device (think of a hypothetical RAID-5 device). > > You always have a tree of BDSes, and c

[Qemu-devel] [PATCH 06/54] ehci: Validate qh is not changed unexpectedly by the guest

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede -combine the qh check with the check for devaddr changes -also ensure that p gets set to NULL when the queue gets cancelled on devaddr change, which was not done properly before this patch Signed-off-by: Hans de Goede --- hw/usb/hcd-ehci.c | 41 ++

[Qemu-devel] [PATCH 28/54] usb-redir: Enable pipelining for bulk endpoints

2012-09-06 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 7fb0fb3..5301a69 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@

Re: [Qemu-devel] [PATCH v7 12/14] target-mips-ase-dsp: Add MIPS DSP processors

2012-09-06 Thread Aurelien Jarno
On Tue, Aug 28, 2012 at 02:36:23PM +0800, Jia Liu wrote: > Add MIPS[32|64] ASE DSP[R1|R2] generic cpu model for test. > > Signed-off-by: Jia Liu > --- > target-mips/translate_init.c | 55 > ++ > 1 file changed, 55 insertions(+) > > diff --git a/target-

Re: [Qemu-devel] [PATCH v7 01/14] target-mips-ase-dsp: Add internal functions

2012-09-06 Thread Aurelien Jarno
On Tue, Aug 28, 2012 at 02:36:12PM +0800, Jia Liu wrote: > Add internal functions using by MIPS ASE DSP instructions. > > Signed-off-by: Jia Liu > --- > target-mips/Makefile.objs |2 +- > target-mips/dsp_helper.c | 1277 > + > 2 files changed, 12

[Qemu-devel] [PATCH 14/14] Remove #ifdef QXL_COMMAND_FLAG_COMPAT_16BPP

2012-09-06 Thread Gerd Hoffmann
From: Søren Sandmann Pedersen We require spice >= 0.8 now, so this flag is always present. Signed-off-by: Soren Sandmann Signed-off-by: Gerd Hoffmann --- hw/qxl.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 2aa5848..b726c19 100644 --- a/

[Qemu-devel] [PULL 00/54] usb patch queue

2012-09-06 Thread Gerd Hoffmann
Hi, Here comes the usb patch queue with a bunch of new goodies accumulated while qemu was in freeze for the 1.2 release: * ehci gets more tracepoints & improvements in the queuing code and minor bugfixes (the important fixes where a last minute 1.2 pull). * usbredir goes make use of the ne

Re: [Qemu-devel] [PATCH v7 03/14] target-mips-ase-dsp: Use correct acc value to index cpu_HI/cpu_LO rather than using a fix number

2012-09-06 Thread Aurelien Jarno
On Tue, Aug 28, 2012 at 02:36:14PM +0800, Jia Liu wrote: > Use correct acc value to index cpu_HI/cpu_LO rather than using a fix number. > > Signed-off-by: Jia Liu > --- > target-mips/translate.c | 134 > +-- > 1 file changed, 107 insertions(+), 27 de

  1   2   3   >