Re: [Qemu-devel] [PATCH for 1.2] w32: Fix broken build

2012-08-30 Thread Anthony Liguori
Stefan Weil writes: > Commit ef8621b1a3b199c348606c0a11a77d8e8bf135f1 added an include > file which is not available for MinGW compilations. > > Signed-off-by: Stefan Weil Applied. Thanks. Regards, Anthony Liguori > --- > target-i386/cpu.c |2 ++ > 1 file changed, 2 insertions(+) > > d

[Qemu-devel] [Bug 1037606] Re: vmwgfx does not work with kvm vmware vga

2012-08-30 Thread Bug Watch Updater
** Changed in: linux Status: Unknown => Confirmed ** Changed in: linux Importance: Unknown => Medium -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1037606 Title: vmwgfx does not work wit

Re: [Qemu-devel] [PATCH for 1.2] console: Fix warning from clang (and potential crash)

2012-08-30 Thread Anthony Liguori
Stefan Weil writes: > Am 17.08.2012 16:10, schrieb Jan Kiszka: >> On 2012-08-17 15:50, Stefan Weil wrote: >> >>> ccc-analyzer reports this warning: >>> >>> console.c:1090:29: warning: Dereference of null pointer >>> if (active_console->cursor_timer) { >>>

Re: [Qemu-devel] Adding support for Stateless Static NAT for TAP devices

2012-08-30 Thread John Basila
I have a setup that requires to run virtual machines using QEMU. All these machines will be executed from the same snapshot thus giving them the save same state when they come to life, this is why they all will have the same source IP, the only difference between them is that each one is connect

Re: [Qemu-devel] [PATCH 3/7] block: raw-posix image file reopen

2012-08-30 Thread Eric Blake
On 08/30/2012 11:47 AM, Jeff Cody wrote: > This is derived from the Supriya Kannery's reopen patches. > > This contains the raw-posix driver changes for the bdrv_reopen_* > functions. All changes are staged into a temporary scratch buffer > during the prepare() stage, and copied over to the live

Re: [Qemu-devel] macvlan/macvtap: guest/host cannot communicate when network cable is unplugged

2012-08-30 Thread ching
>> I also perform an additional test: the guests (macvtap bridge mode) CAN >> communicate each other no matter network cable is plugged or not. > Strange. I thought the original problem was that the macvtap guests > cannot communicate with each other when the network cable is > unplugged? > > Ho

Re: [Qemu-devel] [RFC v2 PATCH 4/6] qerror: new error for live block commit, QERR_TOP_NOT_FOUND

2012-08-30 Thread Eric Blake
On 08/30/2012 11:47 AM, Jeff Cody wrote: > Signed-off-by: Jeff Cody > --- > qerror.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/qerror.h b/qerror.h > index d0a76a4..7396184 100644 > --- a/qerror.h > +++ b/qerror.h > @@ -219,6 +219,9 @@ void assert_no_error(Error *err); > #defin

Re: [Qemu-devel] [RFC v2 PATCH 6/6] QAPI: add command for live block commit, 'block-commit'

2012-08-30 Thread Eric Blake
On 08/30/2012 11:47 AM, Jeff Cody wrote: > The command for live block commit is added, which has the following > arguments: > > device: the block device to perform the commit on (mandatory) > base: the base image to commit into; optional (if not specified, > it is the underlying original

[Qemu-devel] [PATCH] iSCSI: remove the now obsolete call to qemu_notify_event()

2012-08-30 Thread Ronnie Sahlberg
Paolo, List Please find a trivial patch to iscsi that removes the call to qemu_notify_event() We do not need to call this any more since a recent patch that made qemu_aio_set_fd_handler() and friends invoke this call automatically when required. regards ronnie sahlberg

[Qemu-devel] [PATCH] iSCSI: We dont need to explicitely call qemu_notify_event() any more

2012-08-30 Thread Ronnie Sahlberg
We no longer need to explicitely call qemu_notify_event() any more since this is now done automatically any time the filehandles we listen to change. Signed-off-by: Ronnie Sahlberg --- block/iscsi.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/block/iscsi.c b/bl

[Qemu-devel] [PATCH] iSCSI: Add support for SG_IO to iscsi_ioctl()

2012-08-30 Thread Ronnie Sahlberg
Paolo, List Please find a small patch that adds support for SG_IO to the synchronous iscsi_ioctl() function. This is needed to make scsi-block work with iscsi. regards ronnie sahlberg

[Qemu-devel] [PATCH] iSCSI: We need to support SG_IO also from iscsi_ioctl()

2012-08-30 Thread Ronnie Sahlberg
We need to support SG_IO from the synchronous iscsi_ioctl() since scsi-block uses this to do an INQ to the device to discover its properties This patch makes scsi-block work with iscsi. Signed-off-by: Ronnie Sahlberg --- block/iscsi.c | 20 +++- 1 files changed, 19 insertions(+

Re: [Qemu-devel] QEMU emulation per CPU

2012-08-30 Thread Wei-Ren Chen
On Fri, Aug 31, 2012 at 01:50:05AM +0700, Mulyadi Santosa wrote: > On Thu, Aug 30, 2012 at 7:27 PM, Naresh Bhat wrote: > > Hi Santosa, > > > > Can you please forward a link of that discussion thread ?? > > try: > http://lists.nongnu.org/archive/html/qemu-devel/2012-08/msg05037.html I also thin

Re: [Qemu-devel] [PATCH v3 2/5] [RFC] libqblock, user example

2012-08-30 Thread Wenchao Xia
于 2012-8-30 15:46, Paolo Bonzini 写道: Il 30/08/2012 03:59, Wenchao Xia ha scritto: Busy waiting is not acceptable, and this is the reason why I had suggested to keep AIO out of the design for now. You need to provide an implementation of AIO for either glib or something else, but this is best

Re: [Qemu-devel] [PATCH v7 5/6] add the QKeyCode enum and the key_defs table

2012-08-30 Thread Amos Kong
On 31/08/12 01:46, Luiz Capitulino wrote: On Mon, 20 Aug 2012 12:39:28 +0800 Amos Kong wrote: key_defs[] in monitor.c is a mapping table of keys and keycodes, this patch added a QKeyCode enum and a new key_defs table, key's index in the enmu is same as keycode's index in new key_defs[]. And a

[Qemu-devel] [PATCH v8 0/7] convert sendkey to qapi

2012-08-30 Thread Amos Kong
This series converted 'sendkey' command to qapi. The raw value in hexadecimal format is not supported by 'send-key' of qmp. Amos Kong (7): fix doc of using raw values with sendkey monitor: rename keyname '<' to 'less' hmp: rename arguments qapi: generate list struct and visit_list for enum

[Qemu-devel] [PATCH v8 6/7] monitor: move key_defs[] table and introduce two help functions

2012-08-30 Thread Amos Kong
This patch added two help functions to convert key/code to index of mapping table, those functions will return Q_KEY_CODE_MAX if the code/key is invalid. Patch also moved key_defs[] to input.c, and removed useless KeyDef struct. Key's index in QKeyCode enmu is same as keycode's index in new key_de

[Qemu-devel] [PATCH v8 4/7] qapi: generate list struct and visit_list for enum

2012-08-30 Thread Amos Kong
Currently, if we define an 'enum' and use it in one command's data, list struct for enum could not be generated, but it's used in qmp function. For example: KeyCodesList could not be generated. >>> qapi-schema.json: { 'enum': 'KeyCodes', 'data': [ 'shift', 'alt' ... ] } { 'command': 'sendkey',

[Qemu-devel] [PATCH v8 2/7] monitor: rename keyname '<' to 'less'

2012-08-30 Thread Amos Kong
There are many maps of keycode 0x56 in pc-bios/keymaps/* pc-bios/keymaps/common:less 0x56 pc-bios/keymaps/common:greater 0x56 shift pc-bios/keymaps/common:bar 0x56 altgr pc-bios/keymaps/common:brokenbar 0x56 shift altgr This patch just renamed '<' to 'less', QAPI might add new variable by

[Qemu-devel] [PATCH v8 3/7] hmp: rename arguments

2012-08-30 Thread Amos Kong
Rename 'string' to 'keys', rename 'hold_time' to 'hold-time'. Signed-off-by: Amos Kong --- hmp-commands.hx |2 +- monitor.c | 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 6a70a9c..bd0c6c9 100644 --- a/hmp-co

[Qemu-devel] [PATCH v8 1/7] fix doc of using raw values with sendkey

2012-08-30 Thread Amos Kong
(qemu) sendkey a (qemu) sendkey 0x1e (qemu) sendkey #0x1e unknown key: '#0x1e' The last command doesn't work, '#' is not requested before raw values, and the raw value in decimal format is not supported. Signed-off-by: Amos Kong --- hmp-commands.hx |6 +++--- 1 files changed, 3 insertions(

[Qemu-devel] [PATCH v8 5/7] qapi: add the QKeyCode enum

2012-08-30 Thread Amos Kong
key_defs[] in monitor.c is a mapping table of keys and keycodes, this patch added a QKeyCode enum. Key's index in the enmu is same as keycode's index in key_defs[]. Signed-off-by: Amos Kong --- qapi-schema.json | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH v8 7/7] qapi: convert sendkey

2012-08-30 Thread Amos Kong
Convert 'sendkey' to use QAPI. QAPI passes key's index of mapping table to qmp_send_key(), not keycode. So we use help functions to convert key/code to index of key_defs, and 'index' will be converted to 'keycode' inside qmp_send_key(). For qmp, QAPI would check invalid key and raise error. For h

Re: [Qemu-devel] [PATCH v2] Fix buffer run out in eepro100.

2012-08-30 Thread Stefan Hajnoczi
On Fri, Aug 31, 2012 at 4:40 AM, Bo Yang wrote: > > Stefan Hajnoczi 08/30/12 7:42 PM >>> > On Thu, Aug 30, 2012 at 9:38 AM, Bo Yang wrote: >> On 08/30/2012 04:04 PM, Stefan Hajnoczi wrote: >>> On Wed, Aug 29, 2012 at 09:17:43PM +0200, Stefan Weil wrote: Am 29.08.2012 13:26, schrieb Bo

Re: [Qemu-devel] macvlan/macvtap: guest/host cannot communicate when network cable is unplugged

2012-08-30 Thread Stefan Hajnoczi
On Thu, Aug 30, 2012 at 11:32 PM, ching wrote: > >>> I also perform an additional test: the guests (macvtap bridge mode) CAN >>> communicate each other no matter network cable is plugged or not. >> Strange. I thought the original problem was that the macvtap guests >> cannot communicate with eac

Re: [Qemu-devel] [PATCH 02/18] block: add error parameter to bdrv_snapshot_create() and related functions

2012-08-30 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 15 Aug 2012 09:41:43 +0200 > Pavel Hrdina wrote: > >> Signed-off-by: Pavel Hrdina >> --- >> block.c| 25 + >> block.h| 3 ++- >> block/qcow2-snapshot.c | 9 - >> block/qcow2.h | 4 +++-

<    1   2