On Mon, Aug 13, 2012 at 09:16:52PM +0200, Igor Mammedov wrote:
> On 08/07/2012 09:56 PM, Eduardo Habkost wrote:
> >The CPU ID in KVM is supposed to be the APIC ID, so change the
> >KVM_CREATE_VCPU call to match it. It didn't break anything yet because
> >today the APIC ID is assumed to be == the CP
On Mon, Aug 13, 2012 at 09:52:43PM +0200, Igor Mammedov wrote:
> On 08/07/2012 09:56 PM, Eduardo Habkost wrote:
> >This changes FW_CFG_MAX_CPUS and FW_CFG_NUMA to use apic_id_for_cpu(),
> >so the NUMA table can be based on the APIC IDs, instead of CPU index
> >(SeaBIOS knows nothing about CPU index
On Mon, Aug 13, 2012 at 11:27 AM, Wenchao Xia
wrote:
> 于 2012-8-11 20:18, Blue Swirl 写道:
>
>> On Fri, Aug 10, 2012 at 8:04 AM, Wenchao Xia
>> wrote:
>>>
>>> Thanks for your review, sorry I have forgot some fixing you
>>> mentioned before, will correct them this time.
>>>
>>> 于 2012-8-10 1:12,
asprintf is not available for all hosts. g_strdup_printf is
more portable and simplifies the code because if does not
need error handling.
The static variable does not need an explicit assignment to be NULL.
Cc: Stefan Hajnoczi
Signed-off-by: Stefan Weil
---
trace/simple.c | 14 -
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
block.c | 1 +
qapi-schema.json | 9 ++---
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/block.c b/block.c
index 24323c1..016858b 100644
--- a/block.c
+++ b/block.c
@@ -2445,6 +2445,7 @@ BlockInfoList
gcc complains when a 32 bit pointer is casted to a 64 bit integer.
Cc: Stefan Hajnoczi
Signed-off-by: Stefan Weil
---
scripts/tracetool/backend/simple.py |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/tracetool/backend/simple.py
b/scripts/tracetool/backend/si
On 08/13/2012 12:21 PM, Marcelo Tosatti wrote:
> On Wed, Aug 08, 2012 at 10:43:01AM +0800, Wen Congyang wrote:
>> We can know the guest is panicked when the guest runs on xen.
>> But we do not have such feature on kvm.
>>
>> Another purpose of this feature is: management app(for example:
>> libvirt
On Mon, Aug 13, 2012 at 01:48:39PM -0600, Eric Blake wrote:
> On 08/13/2012 12:21 PM, Marcelo Tosatti wrote:
> > On Wed, Aug 08, 2012 at 10:43:01AM +0800, Wen Congyang wrote:
> >> We can know the guest is panicked when the guest runs on xen.
> >> But we do not have such feature on kvm.
> >>
> >> An
IMPORTANT: this BREAKS QMP's compatibility for the error response.
This commit changes QMP's wire protocol to make use of the simpler
error format introduced by previous commits.
There are two important (and mostly incompatible) changes:
1. Almost all error classes have been replaced by Generic
Next commit will introduce enum strings in camel case.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
scripts/qapi-types.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
index 9b7da96..cf601ae 100644
--- a/sc
Actually, renames it to 'object'. This must be what the original author
meant to write, as there's no 'object' in the error's data member.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qerror.c b/qe
They have never been fully used and conflict with future error
improvements.
Also makes qerror_report() a proper function, as there's no point
in having it as a macro anymore.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.c | 20 +++-
qerror.h | 8 +-
Today, the error message is only constructed when it's used. This commit
changes qerror to construct the error message when the error object is
built (ie. when the error is reported).
This eliminates the need of storing a pointer to qerror_table[], which
will be dropped soon, and also simplifies t
On 08/13/2012 10:31 AM, Peter Maydell wrote:
> Fix an incorrect default value for the num-irqs property (we were
> attempting to override it from the default set by the parent class
> but not succeeding, which meant that the lm3s6965evb model would
> assert on startup attempting to wire up nonexis
hmp.h is relying on qdict.h being provided by qapi-types.h. Fix this,
as a future commit will change qapi-types.h not to provide qdict.h.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
hmp.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/hmp.h b/hmp.h
index 8d2b0d7..3275
It's used to indicate the special case where a valid file-descriptor
is returned (ie. success) but the connection can't be completed
w/o blocking.
This is needed because QERR_SOCKET_CONNECT_IN_PROGRESS is not
treated like an error and a future commit will drop it.
Signed-off-by: Luiz Capitulino
On Mon, Aug 13, 2012 at 2:10 PM, Gleb Natapov wrote:
> On Mon, Aug 13, 2012 at 05:04:30PM +0300, Avi Kivity wrote:
>> On 08/13/2012 05:02 PM, Gleb Natapov wrote:
>>
>> >> IMO we need to fix CMOS reporting.
>> >>
>> >> (technically we shouldn't touch CMOS NVRAM at all; seabios should
>> >> discover
This commit replaces the place holder value for the ErrorClass
argument with a proper ErrorClass value for all QERR_ macros.
All current errors are mapped to GenericError, except for errors
CommandNotFound, DeviceEncrypted, DeviceNotActive, DeviceNotFound,
KVMMissingCap and MigrationExpected, whic
On Fri, Aug 10, 2012 at 01:22:34PM +0200, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
> ---
> target-i386/cpu.c | 167
> +++---
> 1 file changed, 20 insertions(+), 147 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> i
On Mon, Aug 13, 2012 at 7:33 PM, Anthony Liguori wrote:
> Alex Williamson writes:
>
>> On Mon, 2012-08-13 at 08:27 -0500, Anthony Liguori wrote:
>>> Alex Williamson writes:
>>>
>>> > VFIO kernel support was just merged into Linux, so I'd like to
>>> > formally propose inclusion of the QEMU vfio-
They are unused since last commit.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.c | 400 ---
qerror.h | 7 --
2 files changed, 407 deletions(-)
diff --git a/qerror.c b/qerror.c
index dda1427..ccc52be 1006
Today, the error message is only constructed when it's used. This commit
changes that to construct the error message when the error object is
built (ie. when the error is reported).
This simplifies the Error object.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
error.c | 8
Besides being unused, they operate on the current error format,
which is going to be replaced soon.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
error.c | 48
error.h | 16
error_int.h | 1 -
3 files
On Sun, Aug 12, 2012 at 02:13:52PM +0100, Peter Maydell wrote:
> Ping? I don't think this one quite made it into Avi's pullreq...
Please post this with the rest of the code to support the new
s->irqchip_inject_ioctl value.
> thanks
> -- PMM
>
> On 6 August 2012 18:05, Peter Maydell wrote:
> > M
On Mon, 2012-08-13 at 14:33 -0500, Anthony Liguori wrote:
> Alex Williamson writes:
>
> > On Mon, 2012-08-13 at 08:27 -0500, Anthony Liguori wrote:
> >> Alex Williamson writes:
> >>
> >> > VFIO kernel support was just merged into Linux, so I'd like to
> >> > formally propose inclusion of the QE
From: Anthony Liguori
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
target-ppc/translate_init.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 5742229..6fe4168 100644
--- a/targ
On Mon, 2012-08-13 at 20:48 +, Blue Swirl wrote:
> On Mon, Aug 13, 2012 at 7:33 PM, Anthony Liguori wrote:
> > Alex Williamson writes:
> >
> >> On Mon, 2012-08-13 at 08:27 -0500, Anthony Liguori wrote:
> >>> Alex Williamson writes:
> >>>
> >>> > VFIO kernel support was just merged into Linux
"Michael S. Tsirkin" writes:
> On Mon, Aug 13, 2012 at 01:46:46PM -0500, Anthony Liguori wrote:
>> +typedef struct MyType MyType;
>> +
>> +struct MyType
>> +{
>
> This seems to violate our style:should be
>
>> +struct MyType {
That's a bug in CODING_STYLE. Coding style only
The new argument is added to functions qerror_report() and error_set().
It's stored in Error and QError. qerror_report_err() is also updated to
take care of it.
The QERR_ macros are changed to contain a place holder value for the
new argument, so that the value is used on all current calls to
qerr
QEMU is basically using reset logic when waking up from S3. This
causes the QMP RESET event to be emitted, which is wrong. Also,
the runstate checks done in reset are not necessary for S3 wakeup.
Fix this by untangling wakeup from reset logic and passing
VMRESET_SILENT to qemu_system_reset() to av
From: Anthony Liguori
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
target-i386/cpu.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 880cfea..6d5d0d6 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cp
qerror_abort() depends on the 'file', 'func' and 'linenr' members of
QError. However, these members are going to be dropped by the next
commit, so let's drop qerror_abort() in favor of printing an error
message to stderr plus a call to abort().
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus A
error_get_qobject() is unused since last commit, error_set_qobject()
has never been used. Also drops error_int.h.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
error.c | 20
error_int.h | 28
qapi/qmp-disp
Today, the WAKEUP event is emitted when a wakeup _request_ is made.
This could be the system_wakeup command, for example.
A better semantic would be to emit the event when the guest is
already running, as that's what matters in the end. This commit does
that change.
In theory, this could break co
In the old QMP days, this code was used to find out QMP commands that
might be calling monitor_printf() down its call chain.
This is almost impossible to happen today, because the qapi converted
commands don't even have a monitor object. Besides, it's been more than
a year since I used this last t
Several block/ files are relying on qerror.h being provided by
qapi-types.h. Fix this, as a future commit will change qapi-types.h
not to provide qerror.h.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
block_int.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/block_int
The error_is_type() function is going to be dropped.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
hmp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hmp.c b/hmp.c
index 54c37d7..9b44dfc 100644
--- a/hmp.c
+++ b/hmp.c
@@ -793,7 +793,8 @@ void hmp_cha
IMPORTANT: this BREAKS qemu-ga compatibility for the error response.
Instead of returning something like:
{ "error": { "class": "InvalidParameterValue",
"data": {"name": "mode", "expected": "halt|powerdown|reboot" } } }
qemu-ga now returns:
{ "error": { "class": "GenericError",
qerror will be dropped in a near future, let's reduce its public
exposure by making functions only used in qerror.c static.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.c | 10 +-
qerror.h | 5 -
2 files changed, 5 insertions(+), 10 deletions(-)
diff --
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qapi-schema.json | 30 ++
1 file changed, 30 insertions(+)
diff --git a/qapi-schema.json b/qapi-schema.json
index a62bf68..b513935 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3,6 +3,36 @@
Emitted when the guest makes a request to enter S4 state.
There are three possible ways of having this event, as described here:
http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg02307.html
I've decided to add a new event and make it indepedent of SHUTDOWN.
This means that the SHUTDOWN ev
This allows for changing QERR_ macros to initialize two struct members
at the same time. See next commit for more details.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.c | 276 +++
qerror.h | 2 +-
2 files
It's not needed. As the device name is already known, we can replace
the duplicated password prompting code by monitor_read_block_device_key().
This overly simplifies hmp_change().
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
hmp.c | 29 ++---
1 fil
qapi-types.h needs only qemu-common.h. Including qapi-types-core.h
causes problems when qerror.h or error.h includes qapi-types.h.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
scripts/qapi-types.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/script
This commit changes hmp_cont() to loop through all block devices
and proactively set an encryption key for any encrypted device
missing a key.
This change is needed because QERR_DEVICE_ENCRYPTED is going to be
dropped by a future commit.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbrus
An enum like GenericError in the schema, should generate
GENERIC_ERROR and not GENERICERROR.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
scripts/qapi-types.py | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi-types.py b/scripts/q
Unused since last commit.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.c | 4
qerror.h | 3 ---
2 files changed, 7 deletions(-)
diff --git a/qerror.c b/qerror.c
index 5d38428..452ec69 100644
--- a/qerror.c
+++ b/qerror.c
@@ -309,10 +309,6 @@ static const QError
From: Anthony Liguori
This command attempts to map to the behavior of -cpu ?. Unfortunately, the
output of this command differs wildly across targets.
To accommodate this, we use a weak symbol to implement a default version of the
command that fails with a QERR_NOT_SUPPORTED error code. Target
Avi Kivity writes:
> Please pull from:
>
> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master
Pulled. Thanks.
Regards,
Anthony Liguori
>
> This is mostly Peter's kvm_irqchip_in_kernel() decoupling work.
>
>
> Dunrong
From: Anthony Liguori
We've had a cycle to tweak. It is time to commit to supporting them.
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
qapi-schema.json | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/qapi-schema.json b/qapi-schem
Match what HMP commands print on DeviceEncrypted errors.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qerror.c b/qerror.c
index 082de98..de0a79e 100644
--- a/qerror.c
+++ b/qerror.c
@@ -81,7 +81,7
qmp-commands.h declares several functions that have arguments of
type QDict. However, qdict.h is not included. This will cause a
build breakage when a file includes qmp-commands.h but doesn't
include qdict.h.
Signed-off-by: Luiz Capitulino
---
scripts/qapi-commands.py | 1 +
1 file changed, 1 in
Add information about the new error format and improve the text a bit.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
docs/writing-qmp-commands.txt | 47 +--
1 file changed, 27 insertions(+), 20 deletions(-)
diff --git a/docs/writing-q
Signed-off-by: Luiz Capitulino
Reviewed-by: Eric Blake
Acked-by: Gerd Hoffmann
---
QMP/qmp-events.txt | 266 ++---
1 file changed, 130 insertions(+), 136 deletions(-)
diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
index 10f69d1..2389370 100
Signed-off-by: Luiz Capitulino
Reviewed-by: Eric Blake
Acked-by: Gerd Hoffmann
---
QMP/qmp-events.txt | 12
1 file changed, 12 insertions(+)
diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
index 2389370..df190ac 100644
--- a/QMP/qmp-events.txt
+++ b/QMP/qmp-events.txt
@@ -240
This commit changes all QERR_ macros to contain a human message (ie.
the desc string found in qerr_table[]) instead of a json dictionary
in string format.
Before this commit, error_set() and qerror_report() would receive
a json dictionary in string format and build a qobject from it. Now,
both fun
Simplifies current and future users.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
error.c | 5 +
qerror.c | 10 --
qerror.h | 2 +-
3 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/error.c b/error.c
index 58f55a0..3a62592 100644
--- a/error.c
+
Use the in_progress argument for QERR_SOCKET_CONNECT_IN_PROGRESS. The
other errors are handled the same by checking if the error is set and
then calling migrate_fd_error() if it's.
It's also necessary to change inet_connect_opts() not to set
QERR_SOCKET_CONNECT_IN_PROGRESS. This error is only used
Helps dropping/modifying qerror functions.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/qerror.c b/qerror.c
index 7cb7c12..e717496 100644
--- a/qerror.c
+++ b/qerror.c
@@
From: Anthony Liguori
This lets us provide a default implementation of a symbol which targets can
override.
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
compiler.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/compiler.h b/compiler.h
index 736e770..f76921e 100644
--
From: Anthony Liguori
This provides the same output as -M ? but in a structured way.
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
qapi-schema.json | 28
qmp-commands.hx | 6 ++
vl.c | 31 +++
3 fil
On 13 August 2012 21:45, Marcelo Tosatti wrote:
> On Sun, Aug 12, 2012 at 02:13:52PM +0100, Peter Maydell wrote:
>> Ping? I don't think this one quite made it into Avi's pullreq...
>
> Please post this with the rest of the code to support the new
> s->irqchip_inject_ioctl value.
Er, which new irq
On Mon, Aug 13, 2012 at 03:57:41PM -0500, Anthony Liguori wrote:
> "Michael S. Tsirkin" writes:
>
> > On Mon, Aug 13, 2012 at 01:46:46PM -0500, Anthony Liguori wrote:
> >> +typedef struct MyType MyType;
> >> +
> >> +struct MyType
> >> +{
> >
> > This seems to violate our style:sho
Jan Kiszka writes:
> On 2012-08-01 07:18, Alex Williamson wrote:
>> Signed-off-by: Alex Williamson
>> ---
>>
>> MAINTAINERS |5 +
>> configure | 12
>> hw/i386/Makefile.objs |1 +
>> 3 files changed, 18 insertions(+)
>>
>> diff --git a/MAINTAIN
Public bug reported:
Hi,
I am experiencing some major performance problems with all of our beefy
AMD Opteron 6274 servers running Fedora 17 (kernel 3.4.4-5.fc17.x86_64,
qemu 1.0-17). The network performance between host and the virtual
machine is terrible:
# iperf -c 10.10.11.22 -r
I would also like to add that a VM running Windows 2008 R2 is having the
same identical problem too.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1036363
Title:
Major network performance problems
Luiz Capitulino writes:
> Contains my new error format series, a few fixes related to the WAKEUP event,
> a new event and the new commands to avoid -help output parsing.
>
> The changes (since 33e95c6328a3149a52615176617997c4f8f7088b) are available
> in the following repository:
>
> git://rep
Juan Quintela writes:
> [Resent with PULL request instead of PATCH, sorry for the inconvenience]
>
> Hi
>
> This includes xbzrle series (v12) That were reviewed by Erik and Luiz.
>
> Anthony, please apply.
Pulled. Thanks.
Regards,
Anthony Liguori
>
> Later, Juan.
>
> The following changes si
Peter Maydell writes:
> This is the usual arm-devs pullreq, with the last set of patches
> to go in before the 1.2 hardfreeze. Nothing particularly exciting
> here, mostly just cleanup, plus a fix for that embarrassing
> "v7m machines assert on startup" bug of mine.
>
> thanks
> -- PMM
>
Pulled.
On Mon, 13 Aug 2012 10:56:38 +0200, Cornelia Huck
wrote:
> On Wed, 08 Aug 2012 13:52:57 +0930
> Rusty Russell wrote:
>
> > On Tue, 7 Aug 2012 16:52:47 +0200, Cornelia Huck
> > wrote:
> > 1) Please don't limit yourself to 32 feature bits! If you look at how
> >virtio_mmio does it, they u
On Fri, Aug 10, 2012 at 08:42:11AM -0500, Anthony Liguori wrote:
> Gerd Hoffmann writes:
>
> > Hi,
> >
> > This pull updates seabios in qemu to the latest bits from seabios
> > master, so the upcoming 1.2 qemu release gets all the new shiny
> > stuff added recently. I'd like to have a new seab
Hi,
with this new syscall.c content above things are going in the right
direction:-).
I make a test with strace from the program testthread of the Qemu testsuite.
When I understand the result right,
threading works now with this new compiled qemu-i386.
The child and the parents tidptr NOW have the
On Mon, Aug 13, 2012 at 03:01:56PM -0300, Luiz Capitulino wrote:
> On Fri, 10 Aug 2012 18:24:10 -0500
> Michael Roth wrote:
>
> > Currently, when parsing a stream of tokens we make a copy of the token
> > list at the beginning of each level of recursion so that we do not
> > modify the original l
On Mon, Aug 13, 2012 at 08:49:26PM +0200, Markus Armbruster wrote:
> Michael Roth writes:
>
> > Currently, when parsing a stream of tokens we make a copy of the token
> > list at the beginning of each level of recursion so that we do not
> > modify the original list in cases where we need to fall
Hello all,
This patch is an effort to sandbox Qemu guests using Libseccomp[0]. The patches
that follows are pretty simple and straightforward. I added the correct options
and checks to the configure script and the basic calls to libseccomp in the
main loop at vl.c. Details of each one are in the e
v1:
* Full seccomp calls and data included in vl.c
v2:
* Full seccomp calls and data removed from vl.c and put into separate
qemu-seccomp.[ch] file.
Signed-off-by: Eduardo Otubo
---
vl.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index
v1:
* I added a syscall struct using priority levels as described in the
libseccomp man page. The priority numbers are based to the frequency
they appear in a sample strace from a regular qemu guest run under
libvirt.
Libseccomp generates linear BPF code to filter system calls, those
Adding basic options to the configure script to use libseccomp or not.
The default is set to 'no'. If the flag --enable-libseccomp is used, the
script will check for its existence using pkg-config.
v2:
* As I removed all the code related to seccomp from vl.c, I created
qemu-seccomp.[ch].
* Al
Kevin, Thanks for your review. I will address all of your comments
in the next iteration, but have a few questions/comments on the others...
On Mon, Aug 13, 2012 at 02:50:29PM +0200, Kevin Wolf wrote:
> > +static int parse_server(GlusterURI *uri, char *server)
> > +{
> > +int ret = -EINVAL;
>
On Mon, 2012-08-13 at 17:18 -0500, Anthony Liguori wrote:
> Alex Williamson writes:
> > +static int vfio_load_rom(VFIODevice *vdev)
> > +{
> > +uint64_t size = vdev->rom_size;
> > +const VMStateDescription *vmsd;
> > +char name[32];
> > +off_t off = 0, voff = vdev->rom_offset;
> >
On Mon, 2012-08-13 at 17:19 -0500, Anthony Liguori wrote:
> Jan Kiszka writes:
>
> > On 2012-08-01 07:18, Alex Williamson wrote:
> >> Signed-off-by: Alex Williamson
> >> ---
> >>
> >> MAINTAINERS |5 +
> >> configure | 12
> >> hw/i386/Makefile.objs
Hi All. A couple of times now ive had debug issues due to silent failure of
object_property_set. This function silently fails if the requested property
does not exist for the target object. To trap this error I applied the patch
below to my tree, but I am assuming that this is not mergeable as is a
On Mon, Aug 13, 2012 at 07:50:39PM +, Blue Swirl wrote:
> On Mon, Aug 13, 2012 at 8:40 AM, Jens Freimann wrote:
> > From: Einar Lueck
> >
> > Virtio-blk does not impose fixed block sizes for access to
> > backing devices. This patch introduces support for auto
> > lookup of the block sizes of
From: spriebe
---
block/iscsi.c | 36
1 files changed, 20 insertions(+), 16 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 12ca76d..257f97f 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -76,6 +76,10 @@ static void
iscsi_abort_task_cb(st
201 - 284 of 284 matches
Mail list logo
