Re: [Qemu-devel] [PATCH v3 00/35]: add new error format

2012-08-11 Thread Markus Armbruster
Luiz Capitulino writes: [...] > This series implements the 'Plan for error handling in QMP' as described > by Anthony in this email: > > http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg03764.html > > Basically, this replaces almost all error classes by GenericError (the > exception ar

[Qemu-devel] buildbot failure in qemu on ppc-next_i386_debian_6_0

2012-08-11 Thread qemu
The Buildbot has detected a new failure on builder ppc-next_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/ppc-next_i386_debian_6_0/builds/356 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Bu

[Qemu-devel] buildbot failure in qemu on ppc-next_x86_64_debian_6_0

2012-08-11 Thread qemu
The Buildbot has detected a new failure on builder ppc-next_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/ppc-next_x86_64_debian_6_0/builds/356 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuk

Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field

2012-08-11 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 10 Aug 2012 19:17:22 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Fri, 10 Aug 2012 18:35:26 +0200 >> > Markus Armbruster wrote: >> > >> >> Luiz Capitulino writes: >> >> >> >> > On Fri, 10 Aug 2012 09:56:11 +0200 >> >> > Markus Ar

[Qemu-devel] buildbot failure in qemu on s390-next_x86_64_debian_6_0

2012-08-11 Thread qemu
The Buildbot has detected a new failure on builder s390-next_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/s390-next_x86_64_debian_6_0/builds/357 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuz

[Qemu-devel] buildbot failure in qemu on s390-next_i386_debian_6_0

2012-08-11 Thread qemu
The Buildbot has detected a new failure on builder s390-next_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/s390-next_i386_debian_6_0/builds/357 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

[Qemu-devel] buildbot failure in qemu on monitor_x86_64_debian_6_0

2012-08-11 Thread qemu
The Buildbot has detected a new failure on builder monitor_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/monitor_x86_64_debian_6_0/builds/357 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

[Qemu-devel] buildbot failure in qemu on monitor_i386_debian_6_0

2012-08-11 Thread qemu
The Buildbot has detected a new failure on builder monitor_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/monitor_i386_debian_6_0/builds/357 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Buil

Re: [Qemu-devel] [PATCH 09/15] memory: prepare flatview and radix-tree for rcu style access

2012-08-11 Thread liu ping fan
On Sat, Aug 11, 2012 at 9:58 AM, liu ping fan wrote: > On Wed, Aug 8, 2012 at 5:41 PM, Avi Kivity wrote: >> On 08/08/2012 09:25 AM, Liu Ping Fan wrote: >>> From: Liu Ping Fan >>> >>> Flatview and radix view are all under the protection of pointer. >>> And this make sure the change of them seem t

[Qemu-devel] [Bug 1033494] Re: qemu-system-x86_64 segfaults with kernel 3.5.0

2012-08-11 Thread Michael Tokarev
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1033494 Title: qemu-system-x86_64 segfaults with kernel 3.5.0 Status in QEMU: Incomplete Bug d

Re: [Qemu-devel] Is the return address of get_page_addr_code guest physical address?

2012-08-11 Thread Laurent Desnogues
On Sat, Aug 11, 2012 at 5:41 AM, Steven wrote: [...] > I want to get the guest physical address of a pc. I note the part of > the function cpu_x86_handle_mmu_fault will do something like page > walking to convert a pc to its guest physical address. I think this is > the guest physical address I ne

Re: [Qemu-devel] [qemu-devel] [PATCH V2 0/3] [RFC] libqblock draft code v2

2012-08-11 Thread Blue Swirl
On Fri, Aug 10, 2012 at 8:04 AM, Wenchao Xia wrote: >Thanks for your review, sorry I have forgot some fixing you > mentioned before, will correct them this time. > > 于 2012-8-10 1:12, Blue Swirl 写道: > >> On Thu, Aug 9, 2012 at 10:10 AM, Wenchao Xia >> wrote: >>> >>>This patch intrudce lib

Re: [Qemu-devel] [RFC 01/20] target-i386: return Error from cpu_x86_find_by_name()

2012-08-11 Thread Blue Swirl
On Fri, Aug 10, 2012 at 11:22 AM, Igor Mammedov wrote: > it will allow to use property setters there later. > > Signed-off-by: Igor Mammedov > --- > target-i386/cpu.c | 18 +++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.

Re: [Qemu-devel] [PATCH] device_tree: load_device_tree(): Allow NULL sizep

2012-08-11 Thread Stefan Hajnoczi
On Sat, Aug 11, 2012 at 12:11 AM, Peter Crosthwaite wrote: > On Fri, Aug 10, 2012 at 11:42 PM, Stefan Hajnoczi wrote: >> On Fri, Aug 10, 2012 at 01:54:26PM +1000, Peter A. G. Crosthwaite wrote: >>> The sizep arg is populated with the size of the loaded device tree. Since >>> this >>> is one of t

Re: [Qemu-devel] virtio-scsi <-> vhost multi lun/adapter performance results with 3.6-rc0

2012-08-11 Thread Stefan Hajnoczi
On Sat, Aug 11, 2012 at 12:23 AM, Nicholas A. Bellinger wrote: > Using a KVM guest with 32x vCPUs and 4G memory, the results for 4x > random I/O now look like: > > workload | jobs | 25% write / 75% read | 75% write / 25% read > -|--|--|--

[Qemu-devel] github mirror still stale

2012-08-11 Thread Peter Maydell
On 18 July 2012 10:28, Peter Maydell wrote: > On 12 March 2012 20:12, Stefan Weil wrote: >> We also need more resources for technical maintenance of the >> QEMU infrastructure. For example, the official mirror of the >> QEMU git repository (https://github.com/qemu/QEMU) is several >> months behin

[Qemu-devel] [PATCH v9 0/7] file descriptor passing using fd sets

2012-08-11 Thread Corey Bryant
libvirt's sVirt security driver provides SELinux MAC isolation for Qemu guest processes and their corresponding image files. In other words, sVirt uses SELinux to prevent a QEMU process from opening files that do not belong to it. sVirt provides this support by labeling guests and resources with

[Qemu-devel] [PATCH v9 3/7] block: Prevent detection of /dev/fdset/ as floppy

2012-08-11 Thread Corey Bryant
Signed-off-by: Corey Bryant --- v8 -This patch is new in v8. It was reported on a prior fd passing approach and I realized it's needed in this series. (kw...@redhat.com) v9 -No changes block/raw-posix.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/raw-po

[Qemu-devel] [PATCH v9 6/7] block: Enable qemu_open/close to work with fd sets

2012-08-11 Thread Corey Bryant
When qemu_open is passed a filename of the "/dev/fdset/nnn" format (where nnn is the fdset ID), an fd with matching access mode flags will be searched for within the specified monitor fd set. If the fd is found, a dup of the fd will be returned from qemu_open. Signed-off-by: Corey Bryant --- v2:

[Qemu-devel] [PATCH v9 5/7] block: Convert close calls to qemu_close

2012-08-11 Thread Corey Bryant
This patch converts all block layer close calls, that correspond to qemu_open calls, to qemu_close. Signed-off-by: Corey Bryant --- v5: -This patch is new in v5. (kw...@redhat.com, ebl...@redhat.com) v6-v9: -No changes block/raw-posix.c | 24 block/raw-win32.c |

[Qemu-devel] [PATCH v9 4/7] block: Convert open calls to qemu_open

2012-08-11 Thread Corey Bryant
This patch converts all block layer open calls to qemu_open. Note that this adds the O_CLOEXEC flag to the changed open paths when the O_CLOEXEC macro is defined. Signed-off-by: Corey Bryant --- v2: -Convert calls to qemu_open instead of file_open (kw...@redhat.com) -Mention introduction of O_

[Qemu-devel] [PATCH v9 7/7] monitor: Clean up fd sets on monitor disconnect

2012-08-11 Thread Corey Bryant
Fd sets are shared by all monitor connections. Fd sets are considered to be in use while at least one monitor is connected. When the last monitor disconnects, all fds that are members of an fd set with no outstanding dup references are closed. This prevents any fd leakage associated with a clien

[Qemu-devel] [PATCH v9 1/7] qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg

2012-08-11 Thread Corey Bryant
Set the close-on-exec flag for the file descriptor received via SCM_RIGHTS. Signed-off-by: Corey Bryant --- v4 -This patch is new in v4 (ebl...@redhat.com) v5 -Fallback to FD_CLOEXEC if MSG_CMSG_CLOEXEC is not available (ebl...@redhat.com, stefa...@linux.vnet.ibm.com) v6 -Set cloexec on co

Re: [Qemu-devel] [PATCH v9 5/7] block: Convert close calls to qemu_close

2012-08-11 Thread Blue Swirl
On Sat, Aug 11, 2012 at 1:14 PM, Corey Bryant wrote: > This patch converts all block layer close calls, that correspond > to qemu_open calls, to qemu_close. > > Signed-off-by: Corey Bryant > --- > v5: > -This patch is new in v5. (kw...@redhat.com, ebl...@redhat.com) > > v6-v9: > -No changes > >

[Qemu-devel] [PATCH v9 2/7] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-11 Thread Corey Bryant
This patch adds support that enables passing of file descriptors to the QEMU monitor where they will be stored in specified file descriptor sets. A file descriptor set can be used by a client like libvirt to store file descriptors for the same file. This allows the client to open a file with diff

[Qemu-devel] building qemu on macos mountain lion

2012-08-11 Thread Peter Maydell
[Karl: I've cc'd you because I think you were the person asking about this on #qemu IRC yesterday. Apologies if I have the wrong person...] I just had a go at building qemu on macos X (mountain lion). The good news is I got something working, but I had to fiddle with stuff a bit: * block/raw-posi

Re: [Qemu-devel] [PATCH v9 2/7] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-11 Thread Eric Blake
On 08/11/2012 07:14 AM, Corey Bryant wrote: > This patch adds support that enables passing of file descriptors > to the QEMU monitor where they will be stored in specified file > descriptor sets. > > > v9: > -Use fdset-id rather than fdset_id. (ebl...@redhat.com) > -Update example for query-fd

Re: [Qemu-devel] [PATCH v9 6/7] block: Enable qemu_open/close to work with fd sets

2012-08-11 Thread Eric Blake
On 08/11/2012 07:14 AM, Corey Bryant wrote: > When qemu_open is passed a filename of the "/dev/fdset/nnn" > format (where nnn is the fdset ID), an fd with matching access > mode flags will be searched for within the specified monitor > fd set. If the fd is found, a dup of the fd will be returned >

Re: [Qemu-devel] [PATCH] w64: Fix compiler warning [-Wformat]

2012-08-11 Thread Blue Swirl
On Fri, Aug 10, 2012 at 7:45 PM, Stefan Weil wrote: > Glib2 uses __printf__ in macro G_GNUC_PRINTF for printf like > functions. For MinGW, we want __gnu_printf__ because we use > POSIX format specifiers instead of the MS format specifiers. I get these warnings from glib: CCtrace/control.o I

Re: [Qemu-devel] [PATCHv2 00/19] unicore32: Add unicore32-softmmu support

2012-08-11 Thread Blue Swirl
On Fri, Aug 10, 2012 at 6:42 AM, wrote: > From: Guan Xuetao > > These patches implement softmmu support on unicore32 architecture. Thanks, applied all. > > v1->v2: Correct maybe-uninitialized warning in gpio/pm/dma handlers. > > UniCore32 CPU is embedded in PKUnity-3 SoC, so we add necessary p

Re: [Qemu-devel] [PATCH] Makefile: add qapi.py dependencies

2012-08-11 Thread Blue Swirl
On Fri, Aug 10, 2012 at 1:08 PM, Stefan Hajnoczi wrote: > Commit 427a1a2cb1d35b83b6302886f46289f6d617134d ("qapi: avoid reserved > keywords") modifies qapi.py, which is used by qapi-types.py and other > Python scripts. Because Makefile has no dependencies for qapi.py the > qapi code generator wil

Re: [Qemu-devel] [PATCH] exec.c: fix dirty bitmap reallocation

2012-08-11 Thread Blue Swirl
Thanks, applied. On Fri, Aug 10, 2012 at 2:45 PM, Igor Mitsyanko wrote: > For each newly created RAM block, dirty bitmap is reallocated with g_realloc, > which doesn't > make any promises on initial content of new extra data in returned buffer. In > theory, > we initialize this new data with cp

[Qemu-devel] [PATCH v2] configure: fix double check tests with Clang

2012-08-11 Thread Blue Swirl
Configuring with Clang compiler with -Werror would not work after improved checks: /tmp/qemu-conf--25992-.c:4:32: error: self-comparison always evaluates to true [-Werror,-Wtautological-compare] int main(void) { return preadv == preadv; } /tmp/qemu-conf--25992-.c:13:26: error: self-comparison alway

[Qemu-devel] [Bug 1032828] Re: 64-bit capable PPC models should be supported in 32-bit usermode.

2012-08-11 Thread Samuel Bronson
** Changed in: qemu Status: Invalid => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1032828 Title: 64-bit capable PPC models should be supported in 32-bit usermode. Status in

Re: [Qemu-devel] [PATCH v2] configure: fix double check tests with Clang

2012-08-11 Thread Peter Maydell
On 11 August 2012 16:11, Blue Swirl wrote: > Configuring with Clang compiler with -Werror would not work after > improved checks: > /tmp/qemu-conf--25992-.c:4:32: error: self-comparison always evaluates > to true [-Werror,-Wtautological-compare] > int main(void) { return preadv == preadv; } > /tmp

Re: [Qemu-devel] [PATCH v5 08/15] ssd0323: abort() instead of exit(1) on error.

2012-08-11 Thread Peter Maydell
On 11 August 2012 00:31, Peter Crosthwaite wrote: > On Mon, Aug 6, 2012 at 7:41 PM, Peter Maydell > wrote: >> On 6 August 2012 03:16, Peter A. G. Crosthwaite >> wrote: >>> To be more consistent with the newer ways of error signalling. That and >>> SIGABT >>> is easier to debug with than exit(1

Re: [Qemu-devel] [PATCH RFC for-1.2] arm: Move some ARM devices into libhw

2012-08-11 Thread Peter Maydell
On 10 August 2012 18:15, Andreas Färber wrote: > Am 02.08.2012 15:48, schrieb Peter Maydell: >> On 2 August 2012 02:16, Andreas Färber wrote: >>> +hw-obj-$(CONFIG_STELLARIS_ENET) += stellaris_enet.o >> >> Why just this stellaris device and not the others? > > So, turns out there was an actual rea

Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests

2012-08-11 Thread Blue Swirl
Thanks, applied. On Wed, Jul 18, 2012 at 2:10 PM, Peter Maydell wrote: > Add support for checking whether test case code can compile without > warnings, by recompiling each successful test with -Werror. If the > -Werror version doesn't pass, we bail out. This gives us the same > level of visibil

Re: [Qemu-devel] [PATCH v2] configure: fix double check tests with Clang

2012-08-11 Thread Blue Swirl
On Sat, Aug 11, 2012 at 5:44 PM, Peter Maydell wrote: > On 11 August 2012 16:11, Blue Swirl wrote: >> Configuring with Clang compiler with -Werror would not work after >> improved checks: >> /tmp/qemu-conf--25992-.c:4:32: error: self-comparison always evaluates >> to true [-Werror,-Wtautological-

Re: [Qemu-devel] [PATCH] w64: Fix compiler warning [-Wformat]

2012-08-11 Thread Stefan Weil
Am 11.08.2012 16:42, schrieb Blue Swirl: On Fri, Aug 10, 2012 at 7:45 PM, Stefan Weil wrote: Glib2 uses __printf__ in macro G_GNUC_PRINTF for printf like functions. For MinGW, we want __gnu_printf__ because we use POSIX format specifiers instead of the MS format specifiers. I get these warning

Re: [Qemu-devel] [PATCH v2 00/12] Portable thread-pool/AIO, Win32 emulated AIO

2012-08-11 Thread Stefan Weil
Am 07.08.2012 13:17, schrieb Paolo Bonzini: This patch series is part 2 in my EventNotifier/AIO improvements for QEMU 1.2. It extends use of EventNotifier to the main loop and AIO subsystems. A new API using EventNotifier is added to aio.c and a new portable thread pool is introduced (based on

[Qemu-devel] [PATCH] framebuffer: Fix spelling in comment (leight -> height)

2012-08-11 Thread Stefan Weil
Signed-off-by: Stefan Weil --- hw/framebuffer.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/framebuffer.c b/hw/framebuffer.c index f4747cd..85a00a5 100644 --- a/hw/framebuffer.c +++ b/hw/framebuffer.c @@ -28,7 +28,7 @@ void framebuffer_update_display( MemoryRegi

[Qemu-devel] [PATCH] iov_send_recv(): Handle zero bytes case even if OS does not

2012-08-11 Thread Peter Maydell
POSIX allows sendmsg() and recvmsg() to fail EMSGSIZE if passed a zero msg.msg_iovlen (in particular the MacOS X implementation will do this). Handle the case where iov_send_recv() is passed a zero byte count explicitly, to avoid accidentally depending on the OS to treat zero msg_iovlen as a no-op.

[Qemu-devel] [PATCH 2/2] Support using a different compiler for Objective-C files

2012-08-11 Thread Peter Maydell
MacOSX 10.8 ("Mountain Lion") requires us to compile our one Objective-C source file with clang even if the rest of QEMU requires a real gcc, because the system headers we use make use of Apple's "Blocks" extension to C/ObjC, and mainline gcc doesn't support that. Since we only need to use a true g

[Qemu-devel] [PATCH 1/2] configure: Define OS_OBJECT_USE_OBJC=0 for MacOSX builds

2012-08-11 Thread Peter Maydell
MacOSX 10.8 ("Mountain Lion") defaults to trying to use automated reference counting on certain objects. This means that the system header files will use some Objective C syntax constructs even when compiling pure C, which confuses mainline gcc. Suppress this by setting OS_OBJECT_USE_OBJC=0. This

[Qemu-devel] [PATCH 0/2] Fix compilation on MacOS X 10.8 ("Mountain Lion")

2012-08-11 Thread Peter Maydell
I had a go at compiling on my Macbook, which runs Apple's most recent cat. I had to fix a couple of issues, which I think are down to new stuff in the system headers: * the os/object.h header will try to use Objective-C syntax unless explicitly squashed * some of the headers we use in the coco

Re: [Qemu-devel] github mirror still stale

2012-08-11 Thread Anthony Liguori
Peter Maydell writes: > On 18 July 2012 10:28, Peter Maydell wrote: >> On 12 March 2012 20:12, Stefan Weil wrote: >>> We also need more resources for technical maintenance of the >>> QEMU infrastructure. For example, the official mirror of the >>> QEMU git repository (https://github.com/qemu/QE

Re: [Qemu-devel] [PULL 0/7] last SCSI changes for 1.2

2012-08-11 Thread Anthony Liguori
Paolo Bonzini writes: > Anthony, > > The following changes since commit 0b8db8fe15d17a529a5ea90614c11e9f031dfee8: > > slirp: fix build on mingw32 (2012-08-06 19:31:55 -0500) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git scsi-next > > for you to fetch change

[Qemu-devel] [Bug 1013691] Re: ppc64 + virtio-scsi: only first scsi disk shows up in the guest

2012-08-11 Thread Benjamin Herrenschmidt
Only just saw this bug, I assume the problem still exist ? I have somebody look at it next week -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1013691 Title: ppc64 + virtio-scsi: only first scsi dis

Re: [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-11 Thread Kevin Shanahan
On Thu, Aug 09, 2012 at 10:42:51AM +0200, Kevin Wolf wrote: > Am 07.08.2012 10:47, schrieb Markus Armbruster: > > Kevin Wolf writes: > > > >> Am 02.08.2012 09:20, schrieb Kevin Shanahan: > >>> On Thu, Aug 02, 2012 at 02:49:52PM +0930, Kevin Shanahan wrote: > On Thu, Aug 02, 2012 at 11:46:13A

[Qemu-devel] [Bug 1035572] [NEW] Bug in Qemu User Mode

2012-08-11 Thread Dietmar Stölting
Public bug reported: Hi, I make an interesting discovery. My aim is to have a working qemu-i386 on Raspberry Pi. After long searching in the dark what goes wrong with ANY Qemu version for User Mode until today, I find the following: The bug must be in at least one function, that the program test

[Qemu-devel] [Bug 1035572] Re: Bug in Qemu User Mode

2012-08-11 Thread Dietmar Stölting
I mean of course, that the tidptr from child and parent are different, parent_tidptr=0x43076590 child_tidptr=0x42fcb788 Dietmar -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1035572 Title: Bug

[Qemu-devel] [Bug 1035572] Re: Bug in Qemu User Mode

2012-08-11 Thread Dietmar Stölting
I just compiled the testclone new on debian Wheezy, for to understand what is going on and name it clonemi. Before I have always an endless loop on Raspberry Pi because waitpid was never fullfilled. So I commened the two waitpid lines out. Also I enlarged the STACK_SIZE to 262144. Enlarging of the

[Qemu-devel] [Bug 1035572] Re: Bug in Qemu User Mode

2012-08-11 Thread Dietmar Stölting
After studying the source code of testclone intensive, I see only one possibility: The implementation of the function [b]clone() [/b]in Qemu User Mode must be wrong. This would indeed affect any configuration, means it is NOT CPU depending, Dietmar -- You received this bug notification because y

Re: [Qemu-devel] [PATCH] iov_send_recv(): Handle zero bytes case even if OS does not

2012-08-11 Thread Michael Tokarev
On 12.08.2012 01:24, Peter Maydell wrote: > POSIX allows sendmsg() and recvmsg() to fail EMSGSIZE if passed a zero > msg.msg_iovlen (in particular the MacOS X implementation will do this). > Handle the case where iov_send_recv() is passed a zero byte count > explicitly, to avoid accidentally depen