Re: [Qemu-devel] [PATCH] add support for ATA_PASSTHROUGH_xx scsi command

2012-08-03 Thread Paolo Bonzini
Il 03/08/2012 08:57, Paolo Bonzini ha scritto: > Il 03/08/2012 06:02, Cong Meng ha scritto: >> > Correct the command names of opcode 0x85 and 0xa1, and calculate >> > their xfer size from CDB. >> > >> > ChangeLog: >> > v2: For opcode 0xa1 on TYPE_ROM device, do not calc the xfer size >> > v3: Comp

[Qemu-devel] [PATCH] build: change dist target to use xz

2012-08-03 Thread Brad Smith
If a compression format other than gzip is used we might as well move to xz instead of bzip2. 11.0M qemu-1.1.1-1.tar.gz 9.2M qemu-1.1.1-1.tar.bz2 7.3M qemu-1.1.1-1.tar.xz --- Makefile |6 +++--- scripts/make-release |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) d

[Qemu-devel] Smc support in qemu

2012-08-03 Thread Itaru Kitayama
The recent upstream highbank kernel uses smc to enable its L2 cache, but on a qemu virt machine it is not supported yet. Is it likely supported by qemu soon? What is the time frame for that? If support can not be expected any time soon, how do we work around the issue? I have been using qemu-linar

Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1

2012-08-03 Thread Wenchao Xia
于 2012-8-2 19:13, Paolo Bonzini 写道: Il 02/08/2012 13:11, Daniel P. Berrange ha scritto: Please include GPLv2+ license headers in new source files you create. See existing code like include/qemu/object.h for the license header text. Actually, LGPLv2+ (or compatible, like BSD), if you plan on ma

[Qemu-devel] [PULL 00/10] SCSI patches for 2012-08-03

2012-08-03 Thread Paolo Bonzini
Anthony, The following changes since commit 5e3bc7144edd6e4fa2824944e5eb16c28197dd5a: Merge remote-tracking branch 'mst/tags/for_anthony' into staging (2012-07-30 10:00:48 -0500) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you to fetch changes

[Qemu-devel] [PATCH 03/10] megasas: Update function megasys_scsi_uninit

2012-08-03 Thread Paolo Bonzini
From: Stefan Weil Commit f90c2bcdbc69e41e575f868b984c3e2de8f51bac changed PCIUnregisterFunc, therefore the function prototype needs an update. megasas.o is currently not linked, so this bug was not detected by the buildbots. Signed-off-by: Stefan Weil Signed-off-by: Paolo Bonzini --- hw/mega

[Qemu-devel] [PATCH 05/10] megasas: static SAS addresses

2012-08-03 Thread Paolo Bonzini
From: Hannes Reinecke This patch introduces a new property 'sas_address' which allows the user to specify the SAS address for the HBA. The default address is following the NAA locally assigned identifier format with the locally assigned address 0x525400 as used eg for the MAC addresses. The lower

[Qemu-devel] [PATCH 04/10] scsi-disk: fix compilation with DEBUG_SCSI

2012-08-03 Thread Paolo Bonzini
Reported-by: Gerhard Wiesinger Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index e2ec177..a9c7279 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -447,7 +447,7

[Qemu-devel] [PATCH 06/10] Revert "megasas: disable due to build breakage"

2012-08-03 Thread Paolo Bonzini
This reverts commit 92336855975805d88c7979f53bc05c2d47abab04. Signed-off-by: Paolo Bonzini --- default-configs/pci.mak |1 + 1 file changed, 1 insertion(+) diff --git a/default-configs/pci.mak b/default-configs/pci.mak index 9d3e1db..4b49c00 100644 --- a/default-configs/pci.mak +++ b/defaul

[Qemu-devel] [PATCH 10/10] scsi: add support for ATA_PASSTHROUGH_xx scsi command

2012-08-03 Thread Paolo Bonzini
From: Cong Meng Correct the command names of opcode 0x85 and 0xa1, and calculate their xfer size from CDB. Signed-off-by: Cong Meng Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c | 88 ++-- hw/scsi-defs.h |4 +-- 2 files changed, 87 i

Re: [Qemu-devel] Smc support in qemu

2012-08-03 Thread Laurent Desnogues
On Thu, Aug 2, 2012 at 2:20 PM, Itaru Kitayama wrote: > The recent upstream highbank kernel uses smc to enable its L2 cache, > but on a qemu virt machine > it is not supported yet. Is it likely supported by qemu soon? What is > the time frame for that? For other people reading this, SMC is the in

Re: [Qemu-devel] [PATCH 1/6 v11] docs: spec for add-cow file format

2012-08-03 Thread Stefan Hajnoczi
On Fri, Aug 3, 2012 at 6:56 AM, Dong Xu Wang wrote: > On Thu, Aug 2, 2012 at 6:44 PM, Stefan Hajnoczi wrote: >> On Thu, Aug 2, 2012 at 8:09 AM, Dong Xu Wang >> wrote: >>> On Wed, Aug 1, 2012 at 9:55 PM, Stefan Hajnoczi wrote: On Tue, Jul 31, 2012 at 5:51 PM, Dong Xu Wang wrote:

[Qemu-devel] [PATCH 07/10] esp: enable for all PCI machines

2012-08-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- default-configs/i386-softmmu.mak |1 - default-configs/pci.mak |1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak index fee8cde..2c78175 100644 --- a/default-confi

[Qemu-devel] [PATCH 01/10] SCSI: Update the sense code for PREVENT REMOVAL errors

2012-08-03 Thread Paolo Bonzini
From: Ronnie Sahlberg Change the sense codes for failures to eject a device that is locked by PREVENT_ALLOW_MEDIUM_REMOVAL from the generic MEDIA_LOAD_OR_EJECT_FAILED to the more specific MEDIUM_REMOVAL_PREVENTED. The second sense code is more accurate, and is also listed in MMC annex F for the

[Qemu-devel] [PATCH 08/10] esp: add missing const on TypeInfo structures

2012-08-03 Thread Paolo Bonzini
From: Hervé Poussineau Signed-off-by: Hervé Poussineau Signed-off-by: Paolo Bonzini --- hw/esp.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index a011347..77f5707 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -816,7 +816,7 @@ static void sysbus_esp

Re: [Qemu-devel] Smc support in qemu

2012-08-03 Thread Peter Maydell
On 3 August 2012 09:15, Laurent Desnogues wrote: > On Thu, Aug 2, 2012 at 2:20 PM, Itaru Kitayama wrote: >> The recent upstream highbank kernel uses smc to enable its L2 cache, >> but on a qemu virt machine >> it is not supported yet. Is it likely supported by qemu soon? What is >> the time frame

[Qemu-devel] [PATCH 09/10] esp: add Tekram DC-390 emulation (PC SCSI adapter)

2012-08-03 Thread Paolo Bonzini
From: Hervé Poussineau Difference with AMD PCscsi is that DC-390 contains a EEPROM. This has been successfully tested on: - MS DOS 6.22 (using DC390 ASPI driver) - MS Windows 98 SE (using DC390 driver) - MS Windows NT 3.1 (using DC390 driver) - MS Windows NT 4.0 (using DC390 driver) - hard disk

Re: [Qemu-devel] Smc support in qemu

2012-08-03 Thread Laurent Desnogues
On Fri, Aug 3, 2012 at 10:37 AM, Peter Maydell wrote: [...] >> http://git.linaro.org/gitweb?p=people/rikuvoipio/qemu.git;a=shortlog;h=refs/heads/linaro > > That's just a personal (and as you say old) copy of qemu-linaro. > qemu-linaro proper is here: > http://git.linaro.org/gitweb?p=qemu/qemu-lina

[Qemu-devel] [PATCH 02/10] SCSI: STARTSTOPUNIT only eject/load media if powercondition is 0

2012-08-03 Thread Paolo Bonzini
From: Ronnie Sahlberg The START STOP UNIT command will only eject/load media if power condition is zero. If power condition is !0 then LOEJ and START will be ignored. >From MMC (sbc contains similar wordings too) The Power Conditions field requests the block device to be placed in the power

Re: [Qemu-devel] [RFC 00/12] Qorum disk image corruption resiliency

2012-08-03 Thread Stefan Hajnoczi
On Thu, Aug 2, 2012 at 8:22 PM, Benoît Canet wrote: >> I'm not entirely sure I understand the use-case all that well. >> >> Wouldn't the more typical approach be RAID-5 and the use of parity >> instead of relying on voting? >> >> Quorum doesn't work well with an odd number of disks whereas RAID-5

Re: [Qemu-devel] [PATCH v2 0/2] trivial fix of qemu-sockets.c

2012-08-03 Thread Stefan Hajnoczi
On Fri, Aug 3, 2012 at 4:06 AM, Amos Kong wrote: > Those patches fix trivial issues which were found > in the second review. > > Amos Kong (2): > remove unused include of error.h > socket: clean up redundant assignment > > qemu-sockets.c |1 - > qemu_socket.h |1 - > 2 files changed,

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage

2012-08-03 Thread Stefan Hajnoczi
On Wed, Jul 25, 2012 at 06:45:03PM -0400, Tyler Hall wrote: > subpage_register() expects "end" to be the last byte in the mapping. > Registering a non-page-aligned memory region that extends up to or > beyond a page boundary causes subpage_register() to silently fail > through the (end >= PAGE_SIZE

Re: [Qemu-devel] [Qemu-trivial] [PATCH] exec.c: Remove out of date comment

2012-08-03 Thread Stefan Hajnoczi
On Wed, Aug 01, 2012 at 02:35:47PM +0100, Peter Maydell wrote: > Remove an out of date comment: this comment used to be attached to > cpu_register_physical_memory_log(), before commit 0f0cb164 accidentally > inserted a couple of other functions between the comment and its function. > It is in any c

Re: [Qemu-devel] [PATCH 0/2] configure: fix minor issues in Xen checks

2012-08-03 Thread Stefano Stabellini
On Thu, 2 Aug 2012, Peter Maydell wrote: > These patches fix some minor issues in the Xen checks: > * the use of subshells meant that the (not yet committed) "bail out >on -Werror failure" check in do_cc didn't actually cause the >configure run to stop > * the 4.1 probe code had a set-but

[Qemu-devel] [PULL 0/7] Trivial patches for 22 July to 3 August 2012

2012-08-03 Thread Stefan Hajnoczi
This pull request subsumes the currently pending request from 1 August. Patches from Amos Kong, Peter Cong, and Tyler Hall have been added. The following changes since commit 02d2bd5d57812154cfb978bc2098cf49d551583d: Replace 'struct siginfo' with 'siginfo_t'. (2012-08-01 08:54:07 -0500) are av

[Qemu-devel] [PATCH 3/7] remove unused include of error.h

2012-08-03 Thread Stefan Hajnoczi
From: Amos Kong Signed-off-by: Amos Kong Signed-off-by: Stefan Hajnoczi --- qemu_socket.h |1 - 1 file changed, 1 deletion(-) diff --git a/qemu_socket.h b/qemu_socket.h index 4689ff3..1a2f517 100644 --- a/qemu_socket.h +++ b/qemu_socket.h @@ -27,7 +27,6 @@ int inet_aton(const char *cp, st

[Qemu-devel] [PATCH 2/7] qom: Clean libuser object and dependency files

2012-08-03 Thread Stefan Hajnoczi
From: Jan Kiszka Signed-off-by: Jan Kiszka Signed-off-by: Stefan Hajnoczi --- Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index d872d46..000b46c 100644 --- a/Makefile +++ b/Makefile @@ -215,7 +215,7 @@ clean: rm -f *.o *.d *.a *.l

[Qemu-devel] [PATCH 7/7] exec.c: Remove out of date comment

2012-08-03 Thread Stefan Hajnoczi
From: Peter Maydell Remove an out of date comment: this comment used to be attached to cpu_register_physical_memory_log(), before commit 0f0cb164 accidentally inserted a couple of other functions between the comment and its function. It is in any case obsolete since (a) the function arguments it

[Qemu-devel] [PATCH 6/7] exec.c: Use subpages for large unaligned mappings

2012-08-03 Thread Stefan Hajnoczi
From: Tyler Hall Registering a multi-page memory region that is non-page-aligned results in a subpage from the start to the page boundary, some number of full pages, and possibly another subpage from the last page boundary to the end. The full pages will have a value for offset_within_region that

[Qemu-devel] [PATCH 4/7] socket: clean up redundant assignment

2012-08-03 Thread Stefan Hajnoczi
From: Amos Kong Signed-off-by: Amos Kong Signed-off-by: Stefan Hajnoczi --- qemu-sockets.c |1 - 1 file changed, 1 deletion(-) diff --git a/qemu-sockets.c b/qemu-sockets.c index 668fa93..beb2bb6 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -284,7 +284,6 @@ int inet_connect_opts(Qem

[Qemu-devel] [PATCH 5/7] exec.c: Fix off-by-one error in register_subpage

2012-08-03 Thread Stefan Hajnoczi
From: Tyler Hall subpage_register() expects "end" to be the last byte in the mapping. Registering a non-page-aligned memory region that extends up to or beyond a page boundary causes subpage_register() to silently fail through the (end >= PAGE_SIZE) check. This bug does not cause noticeable prob

[Qemu-devel] [PATCH 1/7] usb: Clean common object and dependency files

2012-08-03 Thread Stefan Hajnoczi
From: Jan Kiszka Signed-off-by: Jan Kiszka Signed-off-by: Stefan Hajnoczi --- Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 621cb86..d872d46 100644 --- a/Makefile +++ b/Makefile @@ -216,7 +216,7 @@ clean: rm -Rf .libs

Re: [Qemu-devel] [PATCH 4/7] s390: sclp event support

2012-08-03 Thread Christian Borntraeger
On 31/07/12 14:59, Andreas Färber wrote: >> +typedef struct EventTypes { >> +BusState qbus; >> +SCLPEventFacility *event_facility; >> +} EventTypes; >> + >> +struct SCLPEventFacility { >> +EventTypes sbus; >> +DeviceState *qdev; >> +/* guest' receive mask */ >> +unsigned int

[Qemu-devel] [PATCH v2] configure: Don't implicitly hardcode list of KVM architectures

2012-08-03 Thread Peter Maydell
The code creating the symlink from linux-headers/asm to the architecture specific linux-headers/asm-$arch directory was implicitly hardcoding a list of KVM supporting architectures. Add a default case for the common "Linux architecture name and QEMU CPU name match" case, so future architectures wil

Re: [Qemu-devel] [PATCH v2 1/2] remove unused include of error.h

2012-08-03 Thread Luiz Capitulino
On Fri, 3 Aug 2012 11:06:21 +0800 Amos Kong wrote: > Signed-off-by: Amos Kong > --- > qemu_socket.h |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/qemu_socket.h b/qemu_socket.h > index 4689ff3..1a2f517 100644 > --- a/qemu_socket.h > +++ b/qemu_socket.h > @@ -27,

Re: [Qemu-devel] [PATCH v2 2/2] socket: clean up redundant assignment

2012-08-03 Thread Luiz Capitulino
On Fri, 3 Aug 2012 11:06:22 +0800 Amos Kong wrote: > Signed-off-by: Amos Kong Reviewed-by: Luiz Capitulino > --- > qemu-sockets.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/qemu-sockets.c b/qemu-sockets.c > index 668fa93..beb2bb6 100644 > --- a/qemu-socke

Re: [Qemu-devel] [PATCH] update-linux-headers.sh: Don't hard code list of architectures

2012-08-03 Thread Peter Maydell
Ping? patchwork url: http://patchwork.ozlabs.org/patch/171628/ -- PMM On 18 July 2012 11:11, Peter Maydell wrote: > Rather than hardcoding the list of architectures in the kernel > header update script, just import headers for every architecture > which supports KVM (with a blacklist exception

Re: [Qemu-devel] [PATCH 3/7] remove unused include of error.h

2012-08-03 Thread Luiz Capitulino
On Fri, 3 Aug 2012 11:51:02 +0100 Stefan Hajnoczi wrote: > From: Amos Kong > > Signed-off-by: Amos Kong > Signed-off-by: Stefan Hajnoczi > --- > qemu_socket.h |1 - > 1 file changed, 1 deletion(-) > > diff --git a/qemu_socket.h b/qemu_socket.h > index 4689ff3..1a2f517 100644 > --- a/qe

Re: [Qemu-devel] [PATCH v5 6/6] qapi: convert sendkey

2012-08-03 Thread Luiz Capitulino
On Thu, 2 Aug 2012 21:38:00 -0400 (EDT) Amos Kong wrote: > - Original Message - > > On Thu, 26 Jul 2012 12:49:01 +0800 > > Amos Kong wrote: > > > > > Convert 'sendkey' to use QAPI. > > > > > > Keys' indexes in the enmu are same as keycodes' indexes in the > > > key_defs[], index_from_c

Re: [Qemu-devel] [PATCH 3/7] remove unused include of error.h

2012-08-03 Thread Stefan Hajnoczi
On Fri, Aug 3, 2012 at 2:00 PM, Luiz Capitulino wrote: > On Fri, 3 Aug 2012 11:51:02 +0100 > Stefan Hajnoczi wrote: > >> From: Amos Kong >> >> Signed-off-by: Amos Kong >> Signed-off-by: Stefan Hajnoczi >> --- >> qemu_socket.h |1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/qemu

Re: [Qemu-devel] [PATCH v2 1/2] remove unused include of error.h

2012-08-03 Thread Stefan Hajnoczi
On Fri, Aug 3, 2012 at 4:06 AM, Amos Kong wrote: > Signed-off-by: Amos Kong > --- > qemu_socket.h |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) I have dropped this, see Luiz' comment. Stefan

Re: [Qemu-devel] [PULL 0/7] Trivial patches for 22 July to 3 August 2012

2012-08-03 Thread Stefan Hajnoczi
On Fri, Aug 3, 2012 at 11:50 AM, Stefan Hajnoczi wrote: > This pull request subsumes the currently pending request from 1 August. > Patches from Amos Kong, Peter Cong, and Tyler Hall have been added. > > The following changes since commit 02d2bd5d57812154cfb978bc2098cf49d551583d: > > Replace 'st

Re: [Qemu-devel] [PATCH v6 5/7] add the QKeyCode enum and the key_defs table

2012-08-03 Thread Luiz Capitulino
On Fri, 3 Aug 2012 10:48:40 +0800 Amos Kong wrote: > key_defs[] in monitor.c is a mapping table of keys and keycodes, > this patch added a QKeyCode enum and a new key_defs table, > Key's index in the enmu is same as keycode's index in new key_defs[]. > > Signed-off-by: Amos Kong > --- > input

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-03 Thread Anthony Liguori
Alon Levy writes: > On Wed, Aug 01, 2012 at 02:22:37PM -0500, Anthony Liguori wrote: >> Andreas Färber writes: >> >> > Am 30.07.2012 18:19, schrieb Alon Levy: >> >> On Mon, Jul 30, 2012 at 09:54:27PM +1000, Benjamin Herrenschmidt wrote: >> >>> On Mon, 2012-07-30 at 14:25 +0300, Avi Kivity wrote

Re: [Qemu-devel] [PATCH 2/2] pseries: Use new hook to correct reset sequence

2012-08-03 Thread Anthony Liguori
David Gibson writes: > On Thu, Aug 02, 2012 at 02:40:19PM -0500, Anthony Liguori wrote: >> The "root" of the composition tree is the machine. The machine in the >> abstract sense, not the QEMUMachine sense. QEMUMachine::init() should >> eventually become trivial--just create a handful of device

Re: [Qemu-devel] [PATCH 2/2] pseries: Use new hook to correct reset sequence

2012-08-03 Thread Peter Maydell
On 3 August 2012 14:50, Anthony Liguori wrote: > There ought to be a hierarchy (based on composition) that reset flows > through. I think saying "the reset tree is isomorphic to the composition tree" is making the same mistake that qbus did with "the bus tree is isomorphic to the composition tree

Re: [Qemu-devel] [PATCH 2/2] pseries: Use new hook to correct reset sequence

2012-08-03 Thread Anthony Liguori
Peter Maydell writes: > On 3 August 2012 14:50, Anthony Liguori wrote: >> There ought to be a hierarchy (based on composition) that reset flows >> through. > > I think saying "the reset tree is isomorphic to the composition tree" > is making the same mistake that qbus did with "the bus tree is >

Re: [Qemu-devel] [PATCH 2/2] pseries: Use new hook to correct reset sequence

2012-08-03 Thread Peter Maydell
On 3 August 2012 15:22, Anthony Liguori wrote: > Peter Maydell writes: >> On 3 August 2012 14:50, Anthony Liguori wrote: >>> There ought to be a hierarchy (based on composition) that reset flows >>> through. >> >> I think saying "the reset tree is isomorphic to the composition tree" >> is making

Re: [Qemu-devel] [PATCH 2/2] pseries: Use new hook to correct reset sequence

2012-08-03 Thread Andreas Färber
Am 02.08.2012 21:40, schrieb Anthony Liguori: > Andreas Färber writes: > >> Am 02.08.2012 20:29, schrieb Anthony Liguori: >>> Andreas Färber writes: >>> Anthony was favoring moving reset code out of machines and expressed dislike for looping through CPUs, which my above patch took into

[Qemu-devel] [PATCH] Revert "virtio: move common ioeventfd handling out of virtio-pci"

2012-08-03 Thread Stefan Hajnoczi
This reverts commit b1f416aa8d870fab71030abc9401cfc77b948e8e. The above commit breaks vhost_net because it always registers the virtio_pci_host_notifier_read() handler function on the ioeventfd, even when vhost_net.ko is using the ioeventfd. The result is both QEMU and vhost_net.ko polling on the

Re: [Qemu-devel] [PATCH 2/2] pseries: Use new hook to correct reset sequence

2012-08-03 Thread Andreas Färber
Am 02.08.2012 21:40, schrieb Anthony Liguori: > Reset propagates. There is unanimous consensus that this is the Right > Way to model reset. There is also wide consensus that reset typically > will propagate through the composition tree although in some cases, > reset actually propagates through t

Re: [Qemu-devel] [PATCH 2/2] pseries: Use new hook to correct reset sequence

2012-08-03 Thread Andreas Färber
Am 03.08.2012 04:31, schrieb David Gibson: > On Thu, Aug 02, 2012 at 05:44:49PM +0200, Andreas Färber wrote: >> Am 02.08.2012 04:10, schrieb David Gibson: >>> A number of things need to occur during reset of the PAPR paravirtualized >>> platform in a specific order. For example, the hash table nee

Re: [Qemu-devel] [PATCH v2][RFC] Add compare subcommand for qemu-img

2012-08-03 Thread Eric Blake
On 08/03/2012 12:45 AM, Miroslav Rezanina wrote: > This is second version of patch adding compare subcommand that compares two > images. Compare has following criteria: > - only data part is compared > - unallocated sectors are not read > - in case of different image size, exceeding part of big

Re: [Qemu-devel] [PATCH 3/7] s390: sclp base support

2012-08-03 Thread Andreas Färber
Am 24.07.2012 09:37, schrieb Christian Borntraeger: > diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c > new file mode 100644 > index 000..4095ba6 > --- /dev/null > +++ b/hw/s390x/sclp.c [...] > + > +static TypeInfo s390_sclp_bridge_info = { Two minor comments: static const please. > +.nam

Re: [Qemu-devel] [PATCH v4 2/2] block: Support GlusterFS as a QEMU block backend

2012-08-03 Thread Blue Swirl
On Thu, Aug 2, 2012 at 3:55 AM, Bharata B Rao wrote: > On Wed, Aug 01, 2012 at 06:35:22PM +, Blue Swirl wrote: >> > + >> > +if (!transport) { >> > +uri->transport = strdup("socket"); >> >> g_strdup > > Sorry about that, pitfalls of developing the parsing code out of line :( > >> >

Re: [Qemu-devel] [RFC 00/12] Qorum disk image corruption resiliency

2012-08-03 Thread Blue Swirl
On Thu, Aug 2, 2012 at 10:16 AM, Benoît Canet wrote: > This patchset create a block driver implementing a qorum using three qemu disk > images. Writes are mirrored on the three files. > For the reading part the three files are read at the same time and a vote is > done to determine which is the ma

[Qemu-devel] [untested PATCH] virtio: fix vhost handling

2012-08-03 Thread Paolo Bonzini
Commit b1f416aa8d870fab71030abc9401cfc77b948e8e breaks vhost_net because it always registers the virtio_pci_host_notifier_read() handler function on the ioeventfd, even when vhost_net.ko is using the ioeventfd. The result is both QEMU and vhost_net.ko polling on the same eventfd and the virtio_net.

Re: [Qemu-devel] [PATCH 2/2] pseries: Use new hook to correct reset sequence

2012-08-03 Thread Anthony Liguori
Andreas Färber writes: > Am 02.08.2012 21:40, schrieb Anthony Liguori: >> Reset propagates. There is unanimous consensus that this is the Right >> Way to model reset. There is also wide consensus that reset typically >> will propagate through the composition tree although in some cases, >> rese

Re: [Qemu-devel] [BUG] BSOD on Win2003 Server when 64bit PCI resource is present

2012-08-03 Thread Paolo Bonzini
Il 26/07/2012 17:38, Alexey Korolev ha scritto: > HI, > > Current version of Seabios is causing blue screen on Windows2003 when 64bit > PCI resource is present and occupies high memory. > > BSOD Error code is: 0x00A5 (0x02, 0xfADF6A446880, 0x1, > 0xFADFAA34690) > > The issue is loc

[Qemu-devel] [PULL 0/4]: QMP queue

2012-08-03 Thread Luiz Capitulino
A qapi fix from Markus and a new field to query-block by Benoit. The changes (since 02d2bd5d57812154cfb978bc2098cf49d551583d) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Benoît Canet (3): block: create bdrv_get_backing_file_depth()

[Qemu-devel] [PATCH 1/4] qapi: qapi.py: allow the "'" character to be escaped

2012-08-03 Thread Luiz Capitulino
Support escaping the escape character, and make more robust (don't die for '', handle ' without matching '. Signed-off-by: Markus Armbruster Reviewed-by: Peter Maydell Signed-off-by: Luiz Capitulino --- scripts/qapi.py | 31 +-- 1 file changed, 21 insertions(+), 10

[Qemu-devel] [PATCH 3/4] block: Use bdrv_get_backing_file_depth()

2012-08-03 Thread Luiz Capitulino
From: Benoît Canet Use the dedicated counting function in qmp_query_block in order to propagate the backing file depth to HMP and add backing_file_depth to qmp-commands.hx Signed-off-by: Benoit Canet Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- block.c | 3 +++ qapi-sc

[Qemu-devel] [PATCH 2/4] block: create bdrv_get_backing_file_depth()

2012-08-03 Thread Luiz Capitulino
From: Benoît Canet Create bdrv_get_backing_file_depth() in order to be able to show in QMP and HMP how many ancestors backing an image a block device have. Signed-off-by: Benoit Canet Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- block.c | 13 + block.h | 1 + 2 fil

[Qemu-devel] [PATCH 4/4] hmp: show the backing file depth

2012-08-03 Thread Luiz Capitulino
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- hmp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hmp.c b/hmp.c index 6b72a64..25688ab 100644 --- a/hmp.c +++ b/hmp.c @@ -227,6 +227,8 @@ void hmp_info_block(Monitor *mon)

Re: [Qemu-devel] [PATCH 01/11] Add migration capabilities

2012-08-03 Thread Luiz Capitulino
On Thu, 2 Aug 2012 15:44:44 +0300 Orit Wasserman wrote: > Add migration capabilities that can be queried by the management using > query-migration-supported-capabilities command. > The management can query the source QEMU and the destination QEMU in order to > verify both support some migration

[Qemu-devel] [Bug 833658] Re: Qemu ppc does not boot Debian 3.1r8

2012-08-03 Thread Samuel Bronson
** Tags added: ppc -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/833658 Title: Qemu ppc does not boot Debian 3.1r8 Status in QEMU: New Bug description: I tried booting the official image debi

[Qemu-devel] [Bug 681613] Re: Failed to convert vmdk on MacOSX ppc

2012-08-03 Thread Samuel Bronson
** Tags added: big-endian endian ppc -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/681613 Title: Failed to convert vmdk on MacOSX ppc Status in QEMU: New Bug description: qemu-img -O vmdk raw

[Qemu-devel] [Bug 623852] Re: PPC emulation loops on booting a FreeBSD kernel

2012-08-03 Thread Samuel Bronson
** Tags added: openbios ppc -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/623852 Title: PPC emulation loops on booting a FreeBSD kernel Status in QEMU: New Bug description: Has anyone tried b

[Qemu-devel] [Bug 811683] Re: 7400, 7410, 7450 cpus vector have wrong exception prefix at reset

2012-08-03 Thread Samuel Bronson
** Tags added: exceptions ppc -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/811683 Title: 7400,7410,7450 cpus vector have wrong exception prefix at reset Status in QEMU: New Bug description:

Re: [Qemu-devel] [PATCH 02/11] Add migrate-set-capabilities and query-migrate-capabilities

2012-08-03 Thread Luiz Capitulino
On Thu, 2 Aug 2012 15:44:45 +0300 Orit Wasserman wrote: > The management can enable/disable a capability for the next migration by using > migrate-set-apabilities QMP command. > The management can query the current migration capabilities using > query-migrate-capabilities QMP command. > The user

[Qemu-devel] [Bug 1020309] Re: qemu-system-ppc: no keyboard after savevm/loadvm

2012-08-03 Thread Samuel Bronson
** Tags added: ppc savevm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1020309 Title: qemu-system-ppc: no keyboard after savevm/loadvm Status in QEMU: New Bug description: Here the steps to

[Qemu-devel] [Bug 929638] Re: qemu 1.0 unable to compile on the pandaboard ES

2012-08-03 Thread Samuel Bronson
** Tags added: arm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/929638 Title: qemu 1.0 unable to compile on the pandaboard ES Status in QEMU: Incomplete Bug description: root@omap:/home/mari

[Qemu-devel] [PATCH v6 3/6] monitor: Clean up fd sets on monitor disconnect

2012-08-03 Thread Corey Bryant
Each fd set has a boolean that keeps track of whether or not the fd set is in use by a monitor connection. When a monitor disconnects, all fds that are members of an fd set with refcount of zero are closed. This prevents any fd leakage associated with a client disconnect prior to using a passed f

[Qemu-devel] [PATCH v6 5/6] block: Convert close calls to qemu_close

2012-08-03 Thread Corey Bryant
This patch converts all block layer close calls, that correspond to qemu_open calls, to qemu_close. v5: -This patch is new in v5. (kw...@redhat.com, ebl...@redhat.com) v6: -No changes Signed-off-by: Corey Bryant --- block/raw-posix.c | 24 block/raw-win32.c |2

[Qemu-devel] [PATCH v6 1/6] qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg

2012-08-03 Thread Corey Bryant
Set the close-on-exec flag for the file descriptor received via SCM_RIGHTS. v4 -This patch is new in v4 (ebl...@redhat.com) v5 -Fallback to FD_CLOEXEC if MSG_CMSG_CLOEXEC is not available (ebl...@redhat.com, stefa...@linux.vnet.ibm.com) v6 -Set cloexec on correct fd (ebl...@redhat.com) Sig

[Qemu-devel] [PATCH v6 6/6] block: Enable qemu_open/close to work with fd sets

2012-08-03 Thread Corey Bryant
When qemu_open is passed a filename of the "/dev/fdset/nnn" format (where nnn is the fdset ID), an fd with matching access mode flags will be searched for within the specified monitor fd set. If the fd is found, a dup of the fd will be returned from qemu_open. Each fd set has a reference count.

[Qemu-devel] [PATCH v6 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-03 Thread Corey Bryant
This patch adds support that enables passing of file descriptors to the QEMU monitor where they will be stored in specified file descriptor sets. A file descriptor set can be used by a client like libvirt to store file descriptors for the same file. This allows the client to open a file with diff

[Qemu-devel] [PATCH v6 4/6] block: Convert open calls to qemu_open

2012-08-03 Thread Corey Bryant
This patch converts all block layer open calls to qemu_open. Note that this adds the O_CLOEXEC flag to the changed open paths when the O_CLOEXEC macro is defined. Signed-off-by: Corey Bryant --- v2: -Convert calls to qemu_open instead of file_open (kw...@redhat.com) -Mention introduction of O_

[Qemu-devel] [PATCH v6 0/6] file descriptor passing using fd sets

2012-08-03 Thread Corey Bryant
libvirt's sVirt security driver provides SELinux MAC isolation for Qemu guest processes and their corresponding image files. In other words, sVirt uses SELinux to prevent a QEMU process from opening files that do not belong to it. sVirt provides this support by labeling guests and resources with

Re: [Qemu-devel] [PATCH v6 1/6] qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg

2012-08-03 Thread Corey Bryant
If these patches are acceptable, I'll resend and get the version history out of the commit message. -- Regards, Corey On 08/03/2012 01:28 PM, Corey Bryant wrote: Set the close-on-exec flag for the file descriptor received via SCM_RIGHTS. v4 -This patch is new in v4 (ebl...@redhat.com) v5

Re: [Qemu-devel] [PATCH 30/34] qemu-ga: switch to the new error format on the wire

2012-08-03 Thread Michael Roth
On Wed, Aug 01, 2012 at 10:02:50PM -0300, Luiz Capitulino wrote: > IMPORTANT: this BREAKS qemu-ga compatibility for the error response. > > Instead of returning something like: > > { "error": { "class": "InvalidParameterValue", > "data": {"name": "mode", "expected": "halt|powerdown|r

Re: [Qemu-devel] [PATCH 30/34] qemu-ga: switch to the new error format on the wire

2012-08-03 Thread Eric Blake
On 08/03/2012 11:44 AM, Michael Roth wrote: > On Wed, Aug 01, 2012 at 10:02:50PM -0300, Luiz Capitulino wrote: >> IMPORTANT: this BREAKS qemu-ga compatibility for the error response. >> >> Instead of returning something like: >> >> { "error": { "class": "InvalidParameterValue", >> "dat

Re: [Qemu-devel] [PATCH v6 5/7] add the QKeyCode enum and the key_defs table

2012-08-03 Thread Andreas Färber
Am 03.08.2012 15:32, schrieb Luiz Capitulino: > On Fri, 3 Aug 2012 10:48:40 +0800 > Amos Kong wrote: > >> key_defs[] in monitor.c is a mapping table of keys and keycodes, >> this patch added a QKeyCode enum and a new key_defs table, >> Key's index in the enmu is same as keycode's index in new ke

Re: [Qemu-devel] [PATCH 30/34] qemu-ga: switch to the new error format on the wire

2012-08-03 Thread Luiz Capitulino
On Fri, 03 Aug 2012 11:56:29 -0600 Eric Blake wrote: > On 08/03/2012 11:44 AM, Michael Roth wrote: > > On Wed, Aug 01, 2012 at 10:02:50PM -0300, Luiz Capitulino wrote: > >> IMPORTANT: this BREAKS qemu-ga compatibility for the error response. > >> > >> Instead of returning something like: > >> > >

Re: [Qemu-devel] [PATCH 08/11] Add migrate_set_cachesize command

2012-08-03 Thread Luiz Capitulino
On Thu, 2 Aug 2012 15:44:51 +0300 Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2, it will be > rounded down to the nearest power of 2). > If XBZRLE cache size is too small there will be many cache miss. > > New query-migrate-cache-size QMP command and

Re: [Qemu-devel] [PATCH 17/34] qerror: drop QERR_SOCKET_CONNECT_IN_PROGRESS

2012-08-03 Thread Michael Roth
On Thu, Aug 02, 2012 at 02:08:48PM -0300, Luiz Capitulino wrote: > On Thu, 2 Aug 2012 11:54:11 -0500 > Michael Roth wrote: > > > On Wed, Aug 01, 2012 at 10:02:37PM -0300, Luiz Capitulino wrote: > > > This error is currently returned by inet_connect_opts(), however > > > it causes the follow spuri

[Qemu-devel] [PATCH v5] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-08-03 Thread Paul Moore
FIPS 140-2 requires disabling certain ciphers, including DES, which is used by VNC to obscure passwords when they are sent over the network. The solution for FIPS users is to disable the use of VNC password auth when the host system is operating in FIPS compliance mode and the user has specified '

Re: [Qemu-devel] [RFC 00/12] Qorum disk image corruption resiliency

2012-08-03 Thread Benoît Canet
Le Friday 03 Aug 2012 à 16:14:51 (+), Blue Swirl a écrit : > On Thu, Aug 2, 2012 at 10:16 AM, Benoît Canet wrote: > > This patchset create a block driver implementing a qorum using three qemu > > disk > > images. Writes are mirrored on the three files. > > For the reading part the three files

Re: [Qemu-devel] [PULL 00/10] SCSI patches for 2012-08-03

2012-08-03 Thread Anthony Liguori
On 08/03/2012 03:06 AM, Paolo Bonzini wrote: Anthony, The following changes since commit 5e3bc7144edd6e4fa2824944e5eb16c28197dd5a: Merge remote-tracking branch 'mst/tags/for_anthony' into staging (2012-07-30 10:00:48 -0500) are available in the git repository at: git://github.com/bonz

[Qemu-devel] Fwd: Re: New Debian iso images

2012-08-03 Thread Nigel Horne
This is a copy of a message I've just sent to the debian-hurd mailing list. I'm copying here in case anyone has any ideas. I'm 99% it's a problem with GNU/Hurd rather than QEMU, but you never know and there is a wealth of experience here which may be able to help and share ideas. -Nigel ---

[Qemu-devel] [Bug 636446] Re: prep ppc "machine" no more working

2012-08-03 Thread Andreas Färber
This has long been fixed, at least for v1.0 I believe. ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/636446 Title: prep ppc "machine" n

Re: [Qemu-devel] [PULL 00/10] SCSI patches for 2012-08-03

2012-08-03 Thread Paolo Bonzini
Il 03/08/2012 21:27, Anthony Liguori ha scritto: > On 08/03/2012 03:06 AM, Paolo Bonzini wrote: >> Anthony, >> >> The following changes since commit >> 5e3bc7144edd6e4fa2824944e5eb16c28197dd5a: >> >>Merge remote-tracking branch 'mst/tags/for_anthony' into staging >> (2012-07-30 10:00:48 -0500)

[Qemu-devel] [PATCH v2] ahci: fix cdrom read corruption

2012-08-03 Thread Jason Baron
Hi, While testing q35 I found data corruption on reads from the cdrom on the ahci controller. The first patch addresses this issue. I also noticed that there is a memory leak in the ahci code, which is addressed in the second patch. Thanks, -Jason v2: fprintf -> DPRINTF (so can't be trigge

[Qemu-devel] [PATCH 1/2 v2] ahci: Fix ahci cdrom read corruptions for reads > 128k

2012-08-03 Thread Jason Baron
While testing q35, which has its cdrom attached to the ahci controller, I found that the Fedora 17 install would panic on boot. The panic occurs while squashfs is trying to read from the cdrom. The errors are: [8.622711] SQUASHFS error: xz_dec_run error, data probably corrupt [8.625180] SQ

[Qemu-devel] [PATCH 2/2 v2] ahci: Fix sglist memleak in ahci_dma_rw_buf()

2012-08-03 Thread Jason Baron
I noticed that in hw/ide/ahci:ahci_dma_rw_buf() we do not free the sglist. Thus, I've added a call to qemu_sglist_destroy() to fix this memory leak. In addition, I've adeed a call in qemu_sglist_destroy() to 0 all of the sglist fields, in case there is some other codepath that tries to free the sg

Re: [Qemu-devel] [PULL 00/10] SCSI patches for 2012-08-03

2012-08-03 Thread Anthony Liguori
Paolo Bonzini writes: > Il 03/08/2012 21:27, Anthony Liguori ha scritto: >> On 08/03/2012 03:06 AM, Paolo Bonzini wrote: >>> Anthony, >>> >>> The following changes since commit >>> 5e3bc7144edd6e4fa2824944e5eb16c28197dd5a: >>> >>>Merge remote-tracking branch 'mst/tags/for_anthony' into stagin

Re: [Qemu-devel] [PATCH v2] configure: Don't implicitly hardcode list of KVM architectures

2012-08-03 Thread Marcelo Tosatti
On Fri, Aug 03, 2012 at 01:51:25PM +0100, Peter Maydell wrote: > The code creating the symlink from linux-headers/asm to the > architecture specific linux-headers/asm-$arch directory was > implicitly hardcoding a list of KVM supporting architectures. > Add a default case for the common "Linux archi

[Qemu-devel] [PATCH] pci: add some stubs

2012-08-03 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/pci-stub.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/pci-stub.c b/hw/pci-stub.c index e083191..ed31441 100644 --- a/hw/pci-stub.c +++ b/hw/pci-stub.c @@ -39,6 +39,16 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num, {

Re: [Qemu-devel] [PATCH v3] kvm: Check if smp_cpus exceeds max cpus supported by kvm

2012-08-03 Thread Marcelo Tosatti
On Tue, Jul 31, 2012 at 07:18:17PM +0800, riegama...@gmail.com wrote: > From: Dunrong Huang > > Add a helper function for fetching max cpus supported by kvm. > > Make QEMU exit with an error message if smp_cpus exceeds limit > of VCPU count retrieved by invoking this helper function. > > Signed

Re: [Qemu-devel] [PULL 00/10] SCSI patches for 2012-08-03

2012-08-03 Thread Hervé Poussineau
Paolo Bonzini a écrit : Il 03/08/2012 21:27, Anthony Liguori ha scritto: On 08/03/2012 03:06 AM, Paolo Bonzini wrote: Anthony, The following changes since commit 5e3bc7144edd6e4fa2824944e5eb16c28197dd5a: Merge remote-tracking branch 'mst/tags/for_anthony' into staging (2012-07-30 10:00:48

  1   2   >