Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_capabilities and query-migrate-capabilities

2012-08-01 Thread Orit Wasserman
Still wrong header should be migrate-set-capabilities, I will resend the patch again. (note to myself it is better to do stuff in the morning , not late at night :)) Orit On 07/31/2012 11:05 PM, Orit Wasserman wrote: > The management can enable/disable a capability for the next migration by using

Re: [Qemu-devel] [RFC PATCH 2/4] block: add live block commit functionality

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 08:32, Kevin Wolf ha scritto: >>> +enum { >>> +/* >>> + * Size of data buffer for populating the image file. This >>> should be large >>> + * enough to process multiple clusters in a single call, so that >>> populating >>> + * cont

[Qemu-devel] [PATCH 02/11] Add migrate-set-capabilities and query-migrate-capabilities

2012-08-01 Thread Orit Wasserman
The management can enable/disable a capability for the next migration by using migrate-set-apabilities QMP command. The management can query the current migration capabilities using query-migrate-capabilities QMP command. The user can use migrate_set_capability and 'info migrate_capabilities' HMP c

Re: [Qemu-devel] [PATCH 1/3] vfio: Import vfio kernel header

2012-08-01 Thread Jan Kiszka
On 2012-08-01 07:18, Alex Williamson wrote: > Signed-off-by: Alex Williamson > --- > > linux-headers/linux/vfio.h | 368 > > 1 file changed, 368 insertions(+) > create mode 100644 linux-headers/linux/vfio.h > > diff --git a/linux-headers/linux/vfi

Re: [Qemu-devel] [PATCH 3/3] vfio: Enable vfio-pci and mark supported

2012-08-01 Thread Jan Kiszka
On 2012-08-01 07:18, Alex Williamson wrote: > Signed-off-by: Alex Williamson > --- > > MAINTAINERS |5 + > configure | 12 > hw/i386/Makefile.objs |1 + > 3 files changed, 18 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 2d219d

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 00:17, Hannes Reinecke ha scritto: > Ad 2: no, the SAS address for the devices is _not_ the WWN. > The WWN is the ID of the LUN, whereas the SAS address is the ID of the > Target. So to be correct we would need to generate unique SAS addressed > per target which needs to be different

Re: [Qemu-devel] [PATCH 06/47] qmp: add block-job-pause and block-job-resume

2012-08-01 Thread Kevin Wolf
Am 24.07.2012 13:03, schrieb Paolo Bonzini: > Add QMP commands matching the functionality. > > Paused jobs cannot be canceled without first resuming them. This > ensures that I/O errors are never missed by management. However, an > optional force argument can be specified to allow that. Right n

Re: [Qemu-devel] [SeaBIOS PATCH 0/2] Allow non-contiguous APIC IDs (v3)

2012-08-01 Thread Gleb Natapov
On Tue, Jul 31, 2012 at 09:14:13PM -0400, Kevin O'Connor wrote: > On Wed, Jul 25, 2012 at 03:45:28PM -0300, Eduardo Habkost wrote: > > Changes v2 -> v3: > > - Report I/O APIC ID = 0 on MP-table, too > > > > Changes v1 -> v2: > > - Patch 1/2: cosmetic whitespace change > > - Patch 2/2: use size

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-08-01 Thread Hannes Reinecke
On 08/01/2012 09:38 AM, Paolo Bonzini wrote: > Il 01/08/2012 00:17, Hannes Reinecke ha scritto: >> Ad 2: no, the SAS address for the devices is _not_ the WWN. >> The WWN is the ID of the LUN, whereas the SAS address is the ID of the >> Target. So to be correct we would need to generate unique SAS a

[Qemu-devel] [PATCH] add suport for ATA_PASSTHROUGH_xx scsi command

2012-08-01 Thread Cong Meng
Correct the command names of opcode 0x85 and 0xa1, and calculate their xfer size from CDB. Signed-off-by: Cong Meng --- hw/scsi-bus.c | 17 ++--- hw/scsi-defs.h |4 ++-- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index e4ec19e

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 09:54, Hannes Reinecke ha scritto: > On 08/01/2012 09:38 AM, Paolo Bonzini wrote: >> Il 01/08/2012 00:17, Hannes Reinecke ha scritto: >>> Ad 2: no, the SAS address for the devices is _not_ the WWN. >>> The WWN is the ID of the LUN, whereas the SAS address is the ID of the >>> Target.

Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c

2012-08-01 Thread Gleb Natapov
Looks good to me. On Mon, Jul 23, 2012 at 03:22:26PM +0200, Igor Mammedov wrote: > v2: > ommited moving of x86_cpu_realize() from cpu_x86_init() to pc_new_cpu(), > to keep cpu_init implementation in -softmmu and -user targets the same > in single place and maintanable. > > v3: > reuse cpu

Re: [Qemu-devel] [PATCH] add suport for ATA_PASSTHROUGH_xx scsi command

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 09:53, Cong Meng ha scritto: > Correct the command names of opcode 0x85 and 0xa1, and calculate > their xfer size from CDB. > > Signed-off-by: Cong Meng > --- > hw/scsi-bus.c | 17 ++--- > hw/scsi-defs.h |4 ++-- > 2 files changed, 16 insertions(+), 5 deletions(-

Re: [Qemu-devel] [PATCH] add suport for ATA_PASSTHROUGH_xx scsi command

2012-08-01 Thread Cong Meng
On Wed 01 Aug 2012 04:20:28 PM CST, Paolo Bonzini wrote: Il 01/08/2012 09:53, Cong Meng ha scritto: Correct the command names of opcode 0x85 and 0xa1, and calculate their xfer size from CDB. Signed-off-by: Cong Meng --- hw/scsi-bus.c | 17 ++--- hw/scsi-defs.h |4 ++--

Re: [Qemu-devel] [PATCH] add suport for ATA_PASSTHROUGH_xx scsi command

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 10:43, Cong Meng ha scritto: >> >> Please make this conditional on the type _not_ being TYPE_ROM. > > May I ask why cdrom device should be an exception? Because CD-ROM devices do not support ATA PASSTHROUGH (the SAT standard only describes direct access devices---type=0x00). The 0x

Re: [Qemu-devel] [PATCH] add suport for ATA_PASSTHROUGH_xx scsi command

2012-08-01 Thread ronnie sahlberg
Because opcode 0xA1 has a different meaning for CDROM/MMC devices. On such devices 0xA1 means BLANK, so it would collide if QEMU some day adds support for re-writeable mmc device. On Wed, Aug 1, 2012 at 6:45 PM, Paolo Bonzini wrote: > Il 01/08/2012 10:43, Cong Meng ha scritto: >>> >>> Please mak

Re: [Qemu-devel] QEMU CPU model versioning/compatibility (was Re: KVM call minutes July 31th)

2012-08-01 Thread Avi Kivity
On 07/31/2012 06:14 PM, Eduardo Habkost wrote: > On Tue, Jul 31, 2012 at 04:32:05PM +0200, Juan Quintela wrote: >> - 1.2 plans for CPU model versioning/compatibility (eduardo) >> (global properties vs QOM vs qdev) >> how to do it ? configuration file? moving back to the code? >> different e

Re: [Qemu-devel] [PATCH] add suport for ATA_PASSTHROUGH_xx scsi command

2012-08-01 Thread Cong Meng
I see. thank both. On Wed 01 Aug 2012 04:49:18 PM CST, ronnie sahlberg wrote: Because opcode 0xA1 has a different meaning for CDROM/MMC devices. On such devices 0xA1 means BLANK, so it would collide if QEMU some day adds support for re-writeable mmc device. On Wed, Aug 1, 2012 at 6:45 PM, Paol

[Qemu-devel] [RESEND PATCH 1/3] socket: remove redundant check

2012-08-01 Thread Amos Kong
It's aleady in the end of loop, error should be set. Signed-off-by: Amos Kong --- qemu-sockets.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/qemu-sockets.c b/qemu-sockets.c index 668fa93..c636882 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -181,9 +181,7 @@

[Qemu-devel] [RESEND PATCH 0/3] trivial fix of qemu-sockets.c

2012-08-01 Thread Amos Kong
Those patches fix trivial issues which were found in the second review. Amos Kong (3): socket: remove redundant check remove unused include of error.h socket: clean up redundant assignment qemu-sockets.c |5 + qemu_socket.h |1 - 2 files changed, 1 insertions(+), 5 deletions(-

[Qemu-devel] [RESEND PATCH 2/3] remove unused include of error.h

2012-08-01 Thread Amos Kong
Signed-off-by: Amos Kong --- qemu_socket.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemu_socket.h b/qemu_socket.h index 4689ff3..1a2f517 100644 --- a/qemu_socket.h +++ b/qemu_socket.h @@ -27,7 +27,6 @@ int inet_aton(const char *cp, struct in_addr *ia); #endif /* !

[Qemu-devel] [RESEND PATCH 3/3] socket: clean up redundant assignment

2012-08-01 Thread Amos Kong
Signed-off-by: Amos Kong --- qemu-sockets.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemu-sockets.c b/qemu-sockets.c index c636882..9cd4114 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -282,7 +282,6 @@ int inet_connect_opts(QemuOpts *opts, Error **errp)

[Qemu-devel] [PATCH v2] add suport for ATA_PASSTHROUGH_xx scsi command

2012-08-01 Thread Cong Meng
Correct the command names of opcode 0x85 and 0xa1, and calculate their xfer size from CDB. ChangeLog: v2: For opcode 0xa1 on TYPE_ROM device, do not calc the xfer size Signed-off-by: Cong Meng --- hw/scsi-bus.c | 19 --- hw/scsi-defs.h |4 ++-- 2 files changed, 18 inserti

[Qemu-devel] [PATCH] megasas: static SAS addresses

2012-08-01 Thread Hannes Reinecke
This patch introduces a new property 'sas_address' which allows the user to specify the SAS address for the HBA. The default address it taken from the qumranet IEEE number and the pci slot address. That ensures it'll be unique and reproduceable locally. The port addresses are now calculated based

[Qemu-devel] [PATCH] [RFC] libqblock draft code v1

2012-08-01 Thread Wenchao Xia
This patch encapsulate qemu general block layer to provide block services. API are declared in libqblock.h. libqblock-test.c simulate library consumer's behaviors. Make libqblock-test could build the code. For easy this patch does not form a dynamic libarary yet. Signed-off-by: Wenchao Xia --

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-08-01 Thread Hannes Reinecke
On 08/01/2012 10:01 AM, Paolo Bonzini wrote: > Il 01/08/2012 09:54, Hannes Reinecke ha scritto: >> On 08/01/2012 09:38 AM, Paolo Bonzini wrote: >>> Il 01/08/2012 00:17, Hannes Reinecke ha scritto: Ad 2: no, the SAS address for the devices is _not_ the WWN. The WWN is the ID of the LUN, wh

Re: [Qemu-devel] [PATCH] megasas: static SAS addresses

2012-08-01 Thread Hannes Reinecke
(Bad style to reply to my own post. I know.) On 08/01/2012 11:12 AM, Hannes Reinecke wrote: > This patch introduces a new property 'sas_address' which > allows the user to specify the SAS address for the HBA. > The default address it taken from the qumranet IEEE number > and the pci slot address.

Re: [Qemu-devel] [PATCH] megasas: static SAS addresses

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 11:19, Hannes Reinecke ha scritto: >> > +#define IEEE_COMPANY_QUMRANET 0x001A4AULL >> > + > Something worth of note: > To generate a valid SAS address I need an IEEE number. > > I seem to remember Qumranet donated their PCI id for KVM use. > I don't actually know if that donatio

Re: [Qemu-devel] [PATCH 11/47] block: reorganize io error code

2012-08-01 Thread Kevin Wolf
Am 24.07.2012 13:03, schrieb Paolo Bonzini: > Move the common part of IDE/SCSI/virtio error handling to the block > layer. The new function bdrv_error_action subsumes all three of > bdrv_emit_qmp_error_event, vm_stop, bdrv_iostatus_set_err. > > The same scheme will be used for errors in block job

Re: [Qemu-devel] [PATCH v2] add suport for ATA_PASSTHROUGH_xx scsi command

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 11:05, Cong Meng ha scritto: > +case ATA_PASSTHROUGH_12: > +if (dev->type != TYPE_ROM) { > +if ((buf[2] & 0x3) == 2) { > +cmd->xfer = buf[4] * dev->blocksize; > +} > +} > +break; > +case ATA_PASSTHROUGH_16: > +

Re: [Qemu-devel] [PATCH 12/47] block: sort BlockDeviceIoStatus errors by severity

2012-08-01 Thread Paolo Bonzini
Il 24/07/2012 13:03, Paolo Bonzini ha scritto: > This does not let a "failed" (EIO) status override a "nospace" status. > When several concurrent asynchronous operations fail, management will > always observe the most severe condition. Patch dropped; Kevin noted on IRC that if you have both errors

Re: [Qemu-devel] [PATCH 12/47] block: sort BlockDeviceIoStatus errors by severity

2012-08-01 Thread Kevin Wolf
Am 24.07.2012 13:03, schrieb Paolo Bonzini: > This does not let a "failed" (EIO) status override a "nospace" status. > When several concurrent asynchronous operations fail, management will > always observe the most severe condition. > > Signed-off-by: Paolo Bonzini As discussed in IRC, the commi

Re: [Qemu-devel] [PATCH 11/47] block: reorganize io error code

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 11:30, Kevin Wolf ha scritto: > Maybe bool is_read? I was mimicking existing code, but since we're touching this part it's worth cleaning it up. I'll add a patch before this one to convert the existing occurrences of int is_read, and then use bool here too. Paolo

[Qemu-devel] [RFC PATCH 0/4] char: expose MemoryCharDriver to users and provide QMP interface

2012-08-01 Thread Lei Li
This RFC series attempts to convert the MemCharDriver to use a circular buffer for input and output, expose it to users by introducing QMP commands memchar_write and memchar_read and via the command line like the other CharDriverStates. Serial ports in qemu always use CharDriverStates as there bac

[Qemu-devel] [RFC PATCH 4/4] qmp: Introduce memchar_read QMP command

2012-08-01 Thread Lei Li
Signed-off-by: Lei Li --- qapi-schema.json | 20 qemu-char.c | 16 qmp-commands.hx | 28 3 files changed, 64 insertions(+), 0 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 3c8530f..23edda9 100644

Re: [Qemu-devel] [PATCH v3] kvm: Check if smp_cpus exceeds max cpus supported by kvm

2012-08-01 Thread Peter Maydell
On 31 July 2012 12:18, wrote: > From: Dunrong Huang > > Add a helper function for fetching max cpus supported by kvm. > > Make QEMU exit with an error message if smp_cpus exceeds limit > of VCPU count retrieved by invoking this helper function. > > Signed-off-by: Dunrong Huang Reviewed-by: Pet

[Qemu-devel] [RFC PATCH 1/4] qemu-char: Convert MemCharDriver to circular buffer

2012-08-01 Thread Lei Li
Signed-off-by: Lei Li --- qemu-char.c | 96 +++--- qemu-char.h |2 +- 2 files changed, 78 insertions(+), 20 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index c2aaaee..087c92d 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2517,38

[Qemu-devel] [RFC PATCH 3/4] qmp: Introduce memchar_write QMP command

2012-08-01 Thread Lei Li
Signed-off-by: Lei Li --- qapi-schema.json | 20 qemu-char.c | 19 +++ qmp-commands.hx | 29 + 3 files changed, 68 insertions(+), 0 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index bc55ed2..3c8530f 10

[Qemu-devel] [PATCH][RFC] Add compare subcommand for qemu-img

2012-08-01 Thread Miroslav Rezanina
This patch adds compare subcommand that compares two images. Compare has following criteria: - only data part is compared - unallocated sectors are not read - in case of different image size, exceeding part of bigger disk has to be zeroed/unallocated to compare rest - qemu-img returns: - 0 if

Re: [Qemu-devel] [PATCH] megasas: static SAS addresses

2012-08-01 Thread Hannes Reinecke
On 08/01/2012 11:23 AM, Paolo Bonzini wrote: > Il 01/08/2012 11:19, Hannes Reinecke ha scritto: +#define IEEE_COMPANY_QUMRANET 0x001A4AULL + >> Something worth of note: >> To generate a valid SAS address I need an IEEE number. >> >> I seem to remember Qumranet donated their PCI id fo

Re: [Qemu-devel] [PATCH v2] add suport for ATA_PASSTHROUGH_xx scsi command

2012-08-01 Thread Cong Meng
On Wed 01 Aug 2012 05:42:08 PM CST, Paolo Bonzini wrote: Il 01/08/2012 11:05, Cong Meng ha scritto: +case ATA_PASSTHROUGH_12: +if (dev->type != TYPE_ROM) { +if ((buf[2] & 0x3) == 2) { +cmd->xfer = buf[4] * dev->blocksize; +} +} +

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-01 Thread Kevin Wolf
Am 24.07.2012 13:03, schrieb Paolo Bonzini: > The following behaviors are possible: > > 'report': The behavior is the same as in 1.1. An I/O error, > respectively during a read or a write, will complete the job immediately > with an error code. > > 'ignore': An I/O error, respectively during a r

Re: [Qemu-devel] virtio-blk: Something bizarre with VIRTIO_BLK_T_GET_ID

2012-08-01 Thread Stefan Hajnoczi
On Wed, Aug 1, 2012 at 5:54 AM, Benjamin Herrenschmidt wrote: > However, virtio_blk_req_complete() does: > > virtqueue_push(s->vq, &req->elem, req->qiov.size + sizeof(*req->in)); > > So it pushes into the queue req->qiov.size (which is 0) + sizeof(*req->in) > which is as far as I can tell ...

Re: [Qemu-devel] [PATCH v2] add suport for ATA_PASSTHROUGH_xx scsi command

2012-08-01 Thread Peter Maydell
On 1 August 2012 11:08, Cong Meng wrote: > On Wed 01 Aug 2012 05:42:08 PM CST, Paolo Bonzini wrote: >> >> Hmm, I think you're only handling this partially. > > > Ah, I will complete it. Since you're redoing the patch anyway, you could correct the typo in the commit message summary line: it should

[Qemu-devel] [RFC PATCH 2/4] monitor: Adjust qmp_human_monitor_command to new MemCharDriver

2012-08-01 Thread Lei Li
Signed-off-by: Lei Li --- monitor.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index 49dccfe..c1a4d81 100644 --- a/monitor.c +++ b/monitor.c @@ -645,7 +645,13 @@ char *qmp_human_monitor_command(const char *command_line, bool has_cpu_inde

[Qemu-devel] [PATCH] fix Xen compilation

2012-08-01 Thread Stefano Stabellini
xen_pt_unregister_device is used as PCIUnregisterFunc, so it should match the type. Signed-off-by: Stefano Stabellini diff --git a/hw/xen_pt.c b/hw/xen_pt.c index fdf68aa..307119a 100644 --- a/hw/xen_pt.c +++ b/hw/xen_pt.c @@ -764,7 +764,7 @@ out: return 0; } -static int xen_pt_unregiste

Re: [Qemu-devel] [PATCH][RFC] Add compare subcommand for qemu-img

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 12:03, Miroslav Rezanina ha scritto: > This patch adds compare subcommand that compares two images. Compare has > following criteria: > - only data part is compared > - unallocated sectors are not read > - in case of different image size, exceeding part of bigger disk has to be > ze

Re: [Qemu-devel] virtio-blk: Something bizarre with VIRTIO_BLK_T_GET_ID

2012-08-01 Thread Benjamin Herrenschmidt
On Wed, 2012-08-01 at 11:16 +0100, Stefan Hajnoczi wrote: > The len field is mostly informational. The virtio device driver > inside the guest may make use of it. In many cases it doesn't so an > incorrect len value has no effect. In > drivers/block/virtio_blk.c:blk_done() the len variable is u

Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target

2012-08-01 Thread Stefan Hajnoczi
On Tue, Jul 31, 2012 at 08:24:58AM -0600, Eric Blake wrote: > On 07/31/2012 08:19 AM, Markus Armbruster wrote: > > Peter Maydell writes: > > > >> Avoid having an explicit list of directories in the 'clean' > >> target by using 'find' to remove all .o and .d files instead. > >> > > >>rm -f qe

Re: [Qemu-devel] [PATCH 14/47] stream: add on-error argument

2012-08-01 Thread Kevin Wolf
Am 24.07.2012 13:03, schrieb Paolo Bonzini: > This patch adds support for error management to streaming. > > Signed-off-by: Paolo Bonzini > --- > block/stream.c | 28 +++- > block_int.h |3 ++- > blockdev.c | 11 --- > hmp.c|3

Re: [Qemu-devel] virtio-blk: Something bizarre with VIRTIO_BLK_T_GET_ID

2012-08-01 Thread Stefan Hajnoczi
On Wed, Aug 1, 2012 at 11:27 AM, Benjamin Herrenschmidt wrote: > On Wed, 2012-08-01 at 11:16 +0100, Stefan Hajnoczi wrote: > >> The len field is mostly informational. The virtio device driver >> inside the guest may make use of it. In many cases it doesn't so an >> incorrect len value has no eff

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage

2012-08-01 Thread Stefan Hajnoczi
On Wed, Jul 25, 2012 at 06:45:03PM -0400, Tyler Hall wrote: > subpage_register() expects "end" to be the last byte in the mapping. > Registering a non-page-aligned memory region that extends up to or > beyond a page boundary causes subpage_register() to silently fail > through the (end >= PAGE_SIZE

Re: [Qemu-devel] [PATCH 17/47] qemu-iotests: add tests for streaming error handling

2012-08-01 Thread Kevin Wolf
Am 24.07.2012 13:03, schrieb Paolo Bonzini: > Add a test for each of report/ignore/stop. The tests use blkdebug > to generate an error in the middle of a script. The error is > recoverable (once = "on") so that we can test resuming a job after > stopping for an error. > > Signed-off-by: Paolo Bo

Re: [Qemu-devel] [PATCH][RFC] Add compare subcommand for qemu-img

2012-08-01 Thread Miroslav Rezanina
- Original Message - > From: "Paolo Bonzini" > To: "Miroslav Rezanina" > Cc: qemu-devel@nongnu.org > Sent: Wednesday, August 1, 2012 12:22:50 PM > Subject: Re: [PATCH][RFC] Add compare subcommand for qemu-img > > Il 01/08/2012 12:03, Miroslav Rezanina ha scritto: > > This patch adds co

Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 11:09, Wenchao Xia ha scritto: > This patch encapsulate qemu general block layer to provide block > services. API are declared in libqblock.h. libqblock-test.c > simulate library consumer's behaviors. Make libqblock-test could > build the code. > For easy this patch does not form

[Qemu-devel] [PATCH v2] megasas: static SAS addresses

2012-08-01 Thread Hannes Reinecke
This patch introduces a new property 'sas_address' which allows the user to specify the SAS address for the HBA. The default address is following the NAA locally assigned identifier format with the locally assigned address 0x525400 as used eg for the MAC addresses. The lower bytes are set to the pc

Re: [Qemu-devel] [Qemu-trivial] [RESEND PATCH 1/3] socket: remove redundant check

2012-08-01 Thread Stefan Hajnoczi
On Wed, Aug 01, 2012 at 04:59:01PM +0800, Amos Kong wrote: > It's aleady in the end of loop, error should be set. > > Signed-off-by: Amos Kong > --- > qemu-sockets.c |4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/qemu-sockets.c b/qemu-sockets.c > index 668fa93.

Re: [Qemu-devel] [PATCH][RFC] Add compare subcommand for qemu-img

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 12:44, Miroslav Rezanina ha scritto: >> >> Also, perhaps we can add a "strict" mode (-S) that would fail if the >> images are of different size, and if a sector is allocated in one but >> unallocated in the other? >> >> And a "silent" or "quiet" mode (-s or -q, your choice) that print

Re: [Qemu-devel] [PATCH v2] megasas: static SAS addresses

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 12:46, Hannes Reinecke ha scritto: > This patch introduces a new property 'sas_address' which > allows the user to specify the SAS address for the HBA. > The default address is following the NAA locally assigned > identifier format with the locally assigned address > 0x525400 as used

Re: [Qemu-devel] [PATCH 17/47] qemu-iotests: add tests for streaming error handling

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 12:43, Kevin Wolf ha scritto: >> > + >> > +def test_report(self): >> > +self.assert_no_active_streams() >> > + >> > +result = self.vm.qmp('block-stream', device='drive0') >> > +self.assert_qmp(result, 'return', {}) >> > + >> > +completed = False >>

Re: [Qemu-devel] [PATCH 14/47] stream: add on-error argument

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 12:29, Kevin Wolf ha scritto: >> > +if ((on_error == BLOCKDEV_ON_ERROR_STOP || >> > + on_error == BLOCKDEV_ON_ERROR_ENOSPC) && >> > +!bdrv_iostatus_is_enabled(bs)) { >> > +error_set(errp, QERR_INVALID_PARAMETER, "on-error"); >> > +return; >> > +

[Qemu-devel] [PATCH 1/2] usb: Clean common object and dependency files

2012-08-01 Thread Stefan Hajnoczi
From: Jan Kiszka Signed-off-by: Jan Kiszka Signed-off-by: Stefan Hajnoczi --- Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 621cb86..d872d46 100644 --- a/Makefile +++ b/Makefile @@ -216,7 +216,7 @@ clean: rm -Rf .libs

[Qemu-devel] [PATCH 2/2] qom: Clean libuser object and dependency files

2012-08-01 Thread Stefan Hajnoczi
From: Jan Kiszka Signed-off-by: Jan Kiszka Signed-off-by: Stefan Hajnoczi --- Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index d872d46..000b46c 100644 --- a/Makefile +++ b/Makefile @@ -215,7 +215,7 @@ clean: rm -f *.o *.d *.a *.l

[Qemu-devel] [PULL 0/2] Trivial patches for 22 July to 1 August 2012

2012-08-01 Thread Stefan Hajnoczi
The following changes since commit 0b22ef0f57a8910d849602bef0940edcd0553d2c: configure: -I\$(SRC_PATH) goes in QEMU_INCLUDES not QEMU_CFLAGS (2012-07-31 20:06:03 +) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch changes up to

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 12:14, Kevin Wolf ha scritto: >> > Signed-off-by: Paolo Bonzini > If we want to switch to named target block devices later, it would > probably make sense to use the io_status of that block device rather > than adding it to the job. > > Maybe what results is a duplication that can b

Re: [Qemu-devel] [Qemu-trivial] [RESEND PATCH 1/3] socket: remove redundant check

2012-08-01 Thread Peter Maydell
On 1 August 2012 11:50, Stefan Hajnoczi wrote: > This isn't obvious. It looks like the intent of the if (!e->ai_next) is > to suppress the error so that the next iteration of the *outer* loop can > succeed. Yeah, we only call it an error on the last time round. This loop is a bit confusingly str

Re: [Qemu-devel] [RFC PATCH 2/4] block: add live block commit functionality

2012-08-01 Thread Jeff Cody
On 08/01/2012 03:07 AM, Paolo Bonzini wrote: > Il 01/08/2012 08:32, Kevin Wolf ha scritto: +enum { +/* + * Size of data buffer for populating the image file. This should be large + * enough to process multiple clusters in a single call, so

Re: [Qemu-devel] [RFC 00/27]: add new error format

2012-08-01 Thread Amos Kong
On 31/07/12 22:44, Luiz Capitulino wrote: On Fri, 27 Jul 2012 18:31:41 -0300 Luiz Capitulino wrote: [Please, read below why this is an RFC] This series implements the 'Plan for error handling in QMP' as described by Anthony in this email: Tested with http://repo.or.cz/w/qemu/qmp-unstable

Re: [Qemu-devel] [PATCH 26/27] error, qerror: pass desc string to error calls

2012-08-01 Thread Amos Kong
On 28/07/12 05:32, Luiz Capitulino wrote: FIXME: broke error_is_type() and qemu-ga. Signed-off-by: Luiz Capitulino --- error.c | 5 ++- qerror.c | 44 ++-- qerror.h | 143 +++ 3 files changed, 77 insertions(+),

Re: [Qemu-devel] [PATCH 11/27] hmp: hmp_cont(): don't rely on QERR_DEVICE_ENCRYPTED

2012-08-01 Thread Markus Armbruster
Luiz Capitulino writes: > Today, hmp_cont() checks for QERR_DEVICE_ENCRYPTED in order to know > if qmp_cont() failed due to an encrypted device. If it did, > hmp_cont() accesses QERR_DEVICE_ENCRYPTED's data member 'device' to > precisely know for which device an encryption key must be set. > > Ho

Re: [Qemu-devel] [PATCH 14/47] stream: add on-error argument

2012-08-01 Thread Kevin Wolf
Am 01.08.2012 13:11, schrieb Paolo Bonzini: > Il 01/08/2012 12:29, Kevin Wolf ha scritto: +if ((on_error == BLOCKDEV_ON_ERROR_STOP || + on_error == BLOCKDEV_ON_ERROR_ENOSPC) && +!bdrv_iostatus_is_enabled(bs)) { +error_set(errp, QERR_INVALID_PARAMETER,

Re: [Qemu-devel] [Qemu-trivial] [RESEND PATCH 1/3] socket: remove redundant check

2012-08-01 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Wed, Aug 01, 2012 at 04:59:01PM +0800, Amos Kong wrote: >> It's aleady in the end of loop, error should be set. >> >> Signed-off-by: Amos Kong >> --- >> qemu-sockets.c |4 +--- >> 1 files changed, 1 insertions(+), 3 deletions(-) >> >> diff --git a/qemu-sockets

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-01 Thread Kevin Wolf
Am 01.08.2012 13:17, schrieb Paolo Bonzini: > Il 01/08/2012 12:14, Kevin Wolf ha scritto: Signed-off-by: Paolo Bonzini >> If we want to switch to named target block devices later, it would >> probably make sense to use the io_status of that block device rather >> than adding it to the job. >>

Re: [Qemu-devel] [PATCH] Fixing sh4 serial abort

2012-08-01 Thread Rob Landley
On 07/27/2012 12:28 PM, Peter Maydell wrote: > On 27 July 2012 18:16, Rob Landley wrote: >> On 07/27/2012 09:32 AM, Peter Maydell wrote: >>> The thing this analysis is missing is any examination of the question >>> "what is the hardware we are modelling documented to do?". >> >> Given that 3.3, 3.

Re: [Qemu-devel] [Qemu-trivial] [RESEND PATCH 1/3] socket: remove redundant check

2012-08-01 Thread Markus Armbruster
Peter Maydell writes: > On 1 August 2012 11:50, Stefan Hajnoczi wrote: >> This isn't obvious. It looks like the intent of the if (!e->ai_next) is >> to suppress the error so that the next iteration of the *outer* loop can >> succeed. > > Yeah, we only call it an error on the last time round. Th

Re: [Qemu-devel] [PATCH] Fixing sh4 serial abort

2012-08-01 Thread Peter Maydell
On 1 August 2012 12:50, Rob Landley wrote: > I can switch to a newer board, but I want to plug armv4tl, armv5l, > armv6l, and armv7l processors into it. (And eventually armv8 but nothing > supports that yet.) If it's always running armv7 then I can't _prove_ > that this userspace would actually ru

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 13:49, Kevin Wolf ha scritto: > > The real question is: if I remove the possibility to inspect the (so far > > anonymous) target device with query-block-jobs, how do you read the > > status of the target device?... > > You don't? :-) That's a possibility. :) You can just report it

Re: [Qemu-devel] [PATCH][RFC] Add compare subcommand for qemu-img

2012-08-01 Thread Stefan Hajnoczi
On Wed, Aug 1, 2012 at 11:03 AM, Miroslav Rezanina wrote: > This patch adds compare subcommand that compares two images. Compare has > following criteria: > - only data part is compared > - unallocated sectors are not read > - in case of different image size, exceeding part of bigger disk has to

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-01 Thread Kevin Wolf
Am 01.08.2012 14:09, schrieb Paolo Bonzini: > Il 01/08/2012 13:49, Kevin Wolf ha scritto: >>> The real question is: if I remove the possibility to inspect the (so far >>> anonymous) target device with query-block-jobs, how do you read the >>> status of the target device?... >> >> You don't? :-) >

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 14:23, Kevin Wolf ha scritto: > Am 01.08.2012 14:09, schrieb Paolo Bonzini: >> Il 01/08/2012 13:49, Kevin Wolf ha scritto: The real question is: if I remove the possibility to inspect the (so far anonymous) target device with query-block-jobs, how do you read the status

Re: [Qemu-devel] [PATCH 12/27] hmp: hmp_change(): don't use error_get_field()

2012-08-01 Thread Markus Armbruster
Luiz Capitulino writes: > Use the 'device' passed by the user and call qmp_query_block() to > get the 'filename' info. > > error_get_field() is going to be dropped by a future commit. > > Signed-off-by: Luiz Capitulino > --- > hmp.c | 37 - > 1 file changed,

Re: [Qemu-devel] [PATCH 15/27] block: block_int: include qerror.h

2012-08-01 Thread Markus Armbruster
Luiz Capitulino writes: > Several block/ files are relying on qerror.h being provided by > qapi-types.h. However, qapi-types.h won't provide it anymore. Squash it into commit that makes qapi-types.h no longer provide it?

Re: [Qemu-devel] [PATCH 16/27] hmp: hmp.h: include qdict.h

2012-08-01 Thread Markus Armbruster
Luiz Capitulino writes: > hmp.h is relying on qdict.h being provided by qapi-types.h. However, > qapi-types.h won't provide it anymore. Squash it into commit that makes qapi-types.h no longer provide it?

Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1

2012-08-01 Thread Stefan Hajnoczi
On Wed, Aug 1, 2012 at 10:09 AM, Wenchao Xia wrote: > This patch encapsulate qemu general block layer to provide block > services. API are declared in libqblock.h. libqblock-test.c > simulate library consumer's behaviors. Make libqblock-test could > build the code. > For easy this patch does n

Re: [Qemu-devel] [PATCH 12/27] hmp: hmp_change(): don't use error_get_field()

2012-08-01 Thread Anthony Liguori
Markus Armbruster writes: > Luiz Capitulino writes: > >> Use the 'device' passed by the user and call qmp_query_block() to >> get the 'filename' info. >> >> error_get_field() is going to be dropped by a future commit. >> >> Signed-off-by: Luiz Capitulino >> --- >> hmp.c | 37 ++

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage

2012-08-01 Thread Peter Maydell
On 1 August 2012 11:42, Stefan Hajnoczi wrote: > On Wed, Jul 25, 2012 at 06:45:03PM -0400, Tyler Hall wrote: >> subpage_register() expects "end" to be the last byte in the mapping. >> Registering a non-page-aligned memory region that extends up to or >> beyond a page boundary causes subpage_regist

[Qemu-devel] [PATCH 17/19] hub: add the support for hub own flow control

2012-08-01 Thread Stefan Hajnoczi
From: Zhi Yong Wu Only when all other hub port's *peer* .can_receive() all return 1, the source hub port .can_receive() return 1. Reviewed-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi Reviewed-by: Laszlo Ersek --- net/hub.c | 27 ---

[Qemu-devel] [PATCH 03/19] net: Use hubs for the vlan feature

2012-08-01 Thread Stefan Hajnoczi
Stop using the special-case vlan code in net.c. Instead use the hub net client to implement the vlan feature. The next patch will remove vlan code from net.c completely. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu Reviewed-by: Laszlo Ersek --- net.c | 37 +++

[Qemu-devel] [PATCH 14/19] net: Make "info network" output more readable info

2012-08-01 Thread Stefan Hajnoczi
From: Zhi Yong Wu Reviewed-by: Jan Kiszka Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi Reviewed-by: Laszlo Ersek --- net.c | 15 ++- net.h |1 + net/hub.c |6 -- 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/net.c b/net.c inde

[Qemu-devel] [PATCH 09/19] net: Remove VLANState

2012-08-01 Thread Stefan Hajnoczi
VLANState is no longer used and can be removed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu Reviewed-by: Laszlo Ersek --- hw/dp8393x.c |1 - hw/exynos4_boards.c |2 +- hw/highbank.c|2 +- hw/integratorcp.c|2 +- hw/kzm.c |2 +-

[Qemu-devel] [PATCH 12/19] net: Rename vc local variables to nc

2012-08-01 Thread Stefan Hajnoczi
Now that VLANClientState has been renamed to NetClientState all 'vc' local variables should be 'nc'. Much of the code already used 'nc' but there are places where 'vc' needs to be renamed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu Reviewed-by: Laszlo Ersek --- hw/ne2000.h

[Qemu-devel] [PATCH 02/19] net: Add a hub net client

2012-08-01 Thread Stefan Hajnoczi
The vlan feature can be implemented in terms of hubs. By introducing a hub net client it becomes possible to remove the special case vlan code from net.c and push the vlan feature out of generic networking code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu Reviewed-by: Laszlo Ersek

[Qemu-devel] [PATCH 04/19] net: Look up 'vlan' net clients using hubs

2012-08-01 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu Reviewed-by: Laszlo Ersek --- net.c | 28 +--- net/hub.c | 23 +++ net/hub.h |1 + net/slirp.c |7 +-- 4 files changed, 30 insertions(+), 29 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage

2012-08-01 Thread Stefan Hajnoczi
On Wed, Aug 1, 2012 at 1:56 PM, Avi Kivity wrote: > On 07/26/2012 01:45 AM, Tyler Hall wrote: >> subpage_register() expects "end" to be the last byte in the mapping. >> Registering a non-page-aligned memory region that extends up to or >> beyond a page boundary causes subpage_register() to silentl

Re: [Qemu-devel] [PATCH 2/2] exec.c: Use subpages for large unaligned mappings

2012-08-01 Thread Avi Kivity
On 07/26/2012 01:45 AM, Tyler Hall wrote: > Registering a multi-page memory region that is non-page-aligned results > in a subpage from the start to the page boundary, some number of full > pages, and possibly another subpage from the last page boundary to the > end. The full pages will have a valu

Re: [Qemu-devel] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage

2012-08-01 Thread Avi Kivity
On 08/01/2012 04:01 PM, Stefan Hajnoczi wrote: > On Wed, Aug 1, 2012 at 1:56 PM, Avi Kivity wrote: >> On 07/26/2012 01:45 AM, Tyler Hall wrote: >>> subpage_register() expects "end" to be the last byte in the mapping. >>> Registering a non-page-aligned memory region that extends up to or >>> beyond

Re: [Qemu-devel] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage

2012-08-01 Thread Avi Kivity
On 07/26/2012 01:45 AM, Tyler Hall wrote: > subpage_register() expects "end" to be the last byte in the mapping. > Registering a non-page-aligned memory region that extends up to or > beyond a page boundary causes subpage_register() to silently fail > through the (end >= PAGE_SIZE) check. > > This

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-01 Thread Kevin Wolf
Am 01.08.2012 14:30, schrieb Paolo Bonzini: > Il 01/08/2012 14:23, Kevin Wolf ha scritto: >> Am 01.08.2012 14:09, schrieb Paolo Bonzini: >>> Il 01/08/2012 13:49, Kevin Wolf ha scritto: > The real question is: if I remove the possibility to inspect the (so far > anonymous) target device with

[Qemu-devel] [PATCH 08/19] net: Remove vlan code from net.c

2012-08-01 Thread Stefan Hajnoczi
The vlan implementation in net.c has been replaced by hubs so we can remove the code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu Reviewed-by: Laszlo Ersek --- hw/xen_nic.c |1 - net.c| 108 -- net.h|

[Qemu-devel] [PATCH 10/19] net: Rename non_vlan_clients to net_clients

2012-08-01 Thread Stefan Hajnoczi
There is no longer a distinction between vlan clients and non-vlan clients in the net core. The net core only knows about point-to-point clients which are connected to a peer. It's time to rename the global list of net clients since it no longer refers to vlans at all. Signed-off-by: Stefan Hajn

  1   2   3   4   >